5d94731c20dcb7f5f6a4168bce772473eef53281
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
2
3         [GTK] [CMake] Add support for generating gtkdoc
4         https://bugs.webkit.org/show_bug.cgi?id=116376
5
6         Reviewed by Martin Robinson.
7
8         * gtk/common.py: look for files in the directories used by the cmake build as well.
9
10 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         [GTK] Build with network process unconditionally
13         https://bugs.webkit.org/show_bug.cgi?id=126128
14
15         Reviewed by Martin Robinson.
16
17         * Scripts/webkitperl/FeatureList.pm: Remove network-process
18         feature command line option.
19
20 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
21
22         [GTK] run-gtk-tests should always run glib tests with -k option
23         https://bugs.webkit.org/show_bug.cgi?id=126132
24
25         Reviewed by Philippe Normand.
26
27         With -k command line option, gtester continues running all other
28         test cases after a failure.
29
30         * Scripts/run-gtk-tests:
31         (TestRunner._run_test_glib): Use -k option when runing glib tests
32         to not stop on failure.
33
34 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
35
36         [GTK][CMake] Integrate GResource for inspector files (and others?)
37         https://bugs.webkit.org/show_bug.cgi?id=125569
38
39         Reviewed by Gustavo Noronha Silva.
40
41         * gtk/generate-inspector-gresource-manifest.py: Added.
42
43 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
44
45         Last URTBF after r160971 to make EFL build happy.
46
47         * TestWebKitAPI/efl/PlatformWebView.cpp:
48         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
49
50 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
51
52         Unreviewed. Add myself to some more watch lists.
53
54         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
55         and binding scripts patches.
56
57 2013-12-20  Commit Queue  <commit-queue@webkit.org>
58
59         Unreviewed, rolling out r160941.
60         http://trac.webkit.org/changeset/160941
61         https://bugs.webkit.org/show_bug.cgi?id=126095
62
63         Doesn't handle subpixel layout being disabled (Requested by
64         smfr on #webkit).
65
66         * gdb/webkit.py:
67         (JSCJSStringPrinter.to_string):
68         (add_pretty_printers):
69         * lldb/lldb_webkit.py:
70         (WTFMediaTime_SummaryProvider):
71         (WTFStringProvider.to_string):
72
73 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
74
75         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
76         https://bugs.webkit.org/show_bug.cgi?id=126080
77
78         Reviewed by Anders Carlsson.
79
80         This changes the output of printing LayoutUnits to be in px, removing
81         the need to divide by 64 manually.
82
83         This will lead to gdb output like:
84
85         m_frameRect = {
86             m_location = LayoutPoint(0px, 0px),
87             m_size = LayoutSize(800px, 585px)
88         }
89
90         And lldb output like:
91
92         (const WebCore::LayoutRect) $0 = {
93           m_location = { x = 744px, y = 1px }
94           m_size = { width = 236px, height = 40px }
95         }
96
97         This patch is based on patch for Blink by cbiesinger@chromium.org.
98
99         * gdb/webkit.py:
100         (WebCoreLayoutUnitPrinter):
101         (WebCoreLayoutUnitPrinter.__init__):
102         (WebCoreLayoutUnitPrinter.to_string):
103         (WebCoreLayoutSizePrinter):
104         (WebCoreLayoutSizePrinter.__init__):
105         (WebCoreLayoutSizePrinter.to_string):
106         (WebCoreLayoutPointPrinter):
107         (WebCoreLayoutPointPrinter.__init__):
108         (WebCoreLayoutPointPrinter.to_string):
109         (add_pretty_printers):
110         * lldb/lldb_webkit.py:
111         (__lldb_init_module):
112         (WebCoreLayoutUnit_SummaryProvider):
113         (WebCoreLayoutSize_SummaryProvider):
114         (WebCoreLayoutPoint_SummaryProvider):
115         (WebCoreLayoutUnitProvider):
116         (WebCoreLayoutUnitProvider.__init__):
117         (WebCoreLayoutUnitProvider.to_string):
118         (WebCoreLayoutSizeProvider):
119         (WebCoreLayoutSizeProvider.__init__):
120         (WebCoreLayoutSizeProvider.get_width):
121         (WebCoreLayoutSizeProvider.get_height):
122         (WebCoreLayoutPointProvider):
123         (WebCoreLayoutPointProvider.__init__):
124         (WebCoreLayoutPointProvider.get_x):
125         (WebCoreLayoutPointProvider.get_y):
126
127 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
128
129         [GTK] [CMake] Add support for building ImageDiff
130         https://bugs.webkit.org/show_bug.cgi?id=125960
131
132         Reviewed by Gustavo Noronha Silva.
133
134         * CMakeLists.txt: Build ImageDiff for GTK+.
135         * ImageDiff/PlatformGTK.cmake: Added.
136
137 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
138
139         [GTK] [CMake] Add support for building DumpRenderTree
140         https://bugs.webkit.org/show_bug.cgi?id=125767
141
142         Reviewed by Gustavo Noronha Silva.
143
144         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
145         * DumpRenderTree/PlatformGTK.cmake: Added.
146
147 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
148
149         [GTK] [CMake] Add support for building WebKitTestRunner
150         https://bugs.webkit.org/show_bug.cgi?id=125768
151
152         Reviewed by Gustavo Noronha Silva.
153
154         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
155         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
156         build file.
157         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
158         * WebKitTestRunner/PlatformGTK.cmake: Added.
159
160 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
161
162         Myles C. Maxfield is a committer now
163
164         Unreviewed.
165
166         * Scripts/webkitpy/common/config/contributors.json:
167
168 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
169
170         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
171         https://bugs.webkit.org/show_bug.cgi?id=125854
172
173         Reviewed by Chris Fleizach.
174
175         Ensure we don't ever create instances of AccessibilityUIElement
176         wrapping invalid platform-specific accessibility objects in DRT,
177         both for consistency with what WKTR does (so we avoid situations
178         where some tests fail in WK2 and not in WK1) and also to avoid
179         overlooking tests that might not be checking the right thing.
180
181         * DumpRenderTree/AccessibilityUIElement.cpp:
182         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
183         nullPtr if the platformUIElement() is not a valid one.
184         * DumpRenderTree/AccessibilityUIElement.h:
185         (AccessibilityUIElement::platformUIElement): Added const modifier.
186
187 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
188
189         Programmatically-inserted children lack accessibility events
190         https://bugs.webkit.org/show_bug.cgi?id=100275
191
192         Reviewed by Chris Fleizach.
193
194         Update DRT and WebKitTestRunner to handle the children-changed
195         signal properly, considering the detail and optional parameters.
196
197         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
198         (axObjectEventListener):
199         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
200
201 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
202
203         Removed unused BUILDER_BASE_URL.
204         https://bugs.webkit.org/show_bug.cgi?id=125442
205
206         Reviewed by Csaba Osztrogonác.
207
208         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
209         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
210
211 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
212
213         Removed unused BUILDER_BASE_URL.
214         https://bugs.webkit.org/show_bug.cgi?id=125442
215
216         Reviewed by Csaba Osztrogonác.
217
218         The string constant BUILDER_BASE_URL is passed around several times,
219         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
220
221         * Scripts/webkitpy/layout_tests/controllers/manager.py:
222         (Manager._upload_json_files):
223         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
224         (JSONLayoutResultsGenerator.__init__):
225         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
226         (JSONResultsGenerator.__init__):
227
228 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
229
230         check-webkit-style mistakenly flags assigning to a dereferenced pointer
231         https://bugs.webkit.org/show_bug.cgi?id=126041
232
233         Reviewed by Ryosuke Niwa.
234
235         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
236         sure that there is a declaration. This patch makes sure that there is a
237         declaration in order to flag spacing around asterisks.
238
239         * Scripts/webkitpy/style/checkers/cpp.py:
240         (check_spacing):
241         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
242         (CppStyleTest.test_pointer_reference_marker_location):
243
244 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
245
246         check-webkit-style marks rvalue references as violations
247         https://bugs.webkit.org/show_bug.cgi?id=126000
248
249         Reviewed by Ryosuke Niwa.
250
251         Previously, check-webkit-style was making sure that any line with "&&" had
252         spaces around it. However, we can now legitimately use "&&" without a previous
253         space when declaring an rvalue reference. This patch relaxes this check.
254
255         * Scripts/webkitpy/style/checkers/cpp.py:
256         (check_spacing):
257         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
258         (CppStyleTest.test_spacing_for_binary_ops):
259
260 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
261
262         check-webkit-style marks auto return types for functions as violations
263         https://bugs.webkit.org/show_bug.cgi?id=125999
264
265         Reviewed by Ryosuke Niwa.
266
267         If a function declaration ends with a "->" followed by a non whitespace
268         string, don't mark as an invalid "{" on its own line
269
270         * Scripts/webkitpy/style/checkers/cpp.py:
271         (check_braces):
272         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
273         (CppStyleTest.test_brace_at_begin_of_line):
274
275 2013-12-19  Alex Christensen  <achristensen@webkit.org>
276
277         [WinCairo] More GStreamer preparations.
278
279         Unreviewed.
280
281         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
282         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
283
284 2013-12-19  Lucas Forschler  <lforschler@apple.com>
285
286         Add Apple Mavericks perf bot.
287         
288         Unreviewed.
289
290         * BuildSlaveSupport/build.webkit.org-config/config.json:
291
292 2013-12-19  Commit Queue  <commit-queue@webkit.org>
293
294         Unreviewed, rolling out r160842.
295         http://trac.webkit.org/changeset/160842
296         https://bugs.webkit.org/show_bug.cgi?id=126003
297
298         broke accessibility/loading-iframe-updates-axtree.html
299         (Requested by ap on #webkit).
300
301         * DumpRenderTree/AccessibilityUIElement.cpp:
302         (AccessibilityUIElement::makeJSAccessibilityUIElement):
303         * DumpRenderTree/AccessibilityUIElement.h:
304         (AccessibilityUIElement::platformUIElement):
305
306 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
307
308         get_test_baseline should get Host from test_config
309         https://bugs.webkit.org/show_bug.cgi?id=125989
310
311         Reviewed by Ryosuke Niwa.
312
313         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
314         (TestConfig.__init__):
315         (RebaselineServer._prepare_config):
316         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
317         (get_test_baselines):
318         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
319         (get_test_config):
320
321 2013-12-19  Roger Fong  <roger_fong@apple.com>
322
323         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
324         https://bugs.webkit.org/show_bug.cgi?id=125998.
325
326         Reviewed by Alexey Proskuryakov.
327
328         * Scripts/webkitdirs.pm:
329         (visualStudioInstallDir):
330         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
331
332 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
333
334         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
335         https://bugs.webkit.org/show_bug.cgi?id=125854
336
337         Reviewed by Chris Fleizach.
338
339         Ensure we don't ever create instances of AccessibilityUIElement
340         wrapping invalid platform-specific accessibility objects in DRT,
341         both for consistency with what WKTR does (so we avoid situations
342         where some tests fail in WK2 and not in WK1) and also to avoid
343         overlooking tests that might not be checking the right thing.
344
345         * DumpRenderTree/AccessibilityUIElement.cpp:
346         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
347         nullPtr if the platformUIElement() is not a valid one.
348         * DumpRenderTree/AccessibilityUIElement.h:
349         (AccessibilityUIElement::platformUIElement): Added const modifier.
350
351 2013-12-18  Anders Carlsson  <andersca@apple.com>
352
353         Deprecate some WKMutableDictionary functions
354         https://bugs.webkit.org/show_bug.cgi?id=125962
355
356         Reviewed by Tim Horton.
357
358         * TestWebKitAPI/PlatformUtilities.cpp:
359         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
360         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
361         (TestWebKitAPI::didAssociateFormControls):
362         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
363         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
364         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
365         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
366         (WTR::createMouseMessageBody):
367         (WTR::EventSendingController::mouseMoveTo):
368         (WTR::EventSendingController::leapForward):
369         (WTR::createKeyDownMessageBody):
370         (WTR::EventSendingController::mouseScrollBy):
371         (WTR::EventSendingController::continuousMouseScrollBy):
372         (WTR::EventSendingController::addTouchPoint):
373         (WTR::EventSendingController::updateTouchPoint):
374         (WTR::EventSendingController::setTouchModifier):
375         (WTR::EventSendingController::setTouchPointRadius):
376         (WTR::EventSendingController::touchStart):
377         (WTR::EventSendingController::touchMove):
378         (WTR::EventSendingController::touchEnd):
379         (WTR::EventSendingController::touchCancel):
380         (WTR::EventSendingController::clearTouchPoints):
381         (WTR::EventSendingController::releaseTouchPoint):
382         (WTR::EventSendingController::cancelTouchPoint):
383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
384         (WTR::InjectedBundle::done):
385         (WTR::InjectedBundle::setMockGeolocationPosition):
386         (WTR::InjectedBundle::setCustomPolicyDelegate):
387         (WTR::InjectedBundle::setVisibilityState):
388         (WTR::InjectedBundle::queueLoad):
389         (WTR::InjectedBundle::queueLoadHTMLString):
390         * WebKitTestRunner/TestController.cpp:
391         (WTR::TestController::initialize):
392         (WTR::TestController::resetStateToConsistentValues):
393         * WebKitTestRunner/TestInvocation.cpp:
394         (WTR::updateThreadedScrollingForCurrentTest):
395         (WTR::updateLayoutType):
396         (WTR::TestInvocation::invoke):
397
398 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
399
400         [GTK] [CMake] Add support for building GtkLauncher
401         https://bugs.webkit.org/show_bug.cgi?id=125766
402
403         Reviewed by Gustavo Noronha Silva.
404
405         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
406         * GtkLauncher/CMakeLists.txt: Added.
407         * GtkLauncher/main.c: Support including the CMake config file.
408
409 2013-12-18  Alex Christensen  <achristensen@webkit.org>
410
411         [WinCairo] Preparation for GStreamer on Windows.
412         https://bugs.webkit.org/show_bug.cgi?id=125946
413
414         Reviewed by Brent Fulgham.
415
416         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
417         Use new GStreamer property sheets for WinCairo.
418         * win/DLLLauncher/DLLLauncherMain.cpp:
419         (modifyPath):
420         (wWinMain):
421         Prepend GStreamer bin directory to path if it exists.
422
423 2013-12-18  Anders Carlsson  <andersca@apple.com>
424
425         Remove now useless test.
426
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
429         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
430         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
431
432 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
433
434         Fix page visibility api test, initialization in WebKit2
435         https://bugs.webkit.org/show_bug.cgi?id=125933
436
437         Reviewed by Anders Carlsson.
438
439         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
440         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
441
442         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
443         (TestWebKitAPI::TEST_F):
444             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
445
446 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
447
448         Should not have identifiers with underscores in them, especially not leading underscores.
449         https://bugs.webkit.org/show_bug.cgi?id=125847
450
451         Reviewed by Darin Adler.
452
453         * Scripts/webkitpy/style/checkers/cpp.py:
454         (check_identifier_name_in_declaration):
455         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
456         (CppStyleTest.test_runtime_selfinit):
457         (WebKitStyleTest.test_names):
458
459 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
460
461         False webkit-check-style warnings on *.
462         https://bugs.webkit.org/show_bug.cgi?id=125915
463
464         Reviewed by Darin Adler.
465
466         * Scripts/webkitpy/style/checkers/cpp.py:
467         (check_spacing):
468         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
469         (CppStyleTest.test_pointer_reference_marker_location):
470
471 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
472
473         prepare-ChangeLog doesn't handle templates properly
474         https://bugs.webkit.org/show_bug.cgi?id=125853
475
476         Reviewed by Daniel Bates.
477
478         * Scripts/prepare-ChangeLog:
479         (get_function_line_ranges_for_cpp):
480         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
481         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
482         (Class110<TemplateClass>::func36):
483
484 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
485
486         Move expectation parsing out of the constructor of TestExpectations
487         https://bugs.webkit.org/show_bug.cgi?id=125439
488
489         Reviewed by Csaba Osztrogonác.
490
491         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
492         (LayoutTestRunnerTests._run_tests):
493         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
494         (LayoutTestRunnerTests.test_update_summary_with_result):
495         * Scripts/webkitpy/layout_tests/controllers/manager.py:
496         (Manager.run):
497         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
498         (ManagerTest.test_look_for_new_crash_logs):
499         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
500         (lint):
501         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
502         (TestExpectations.suffixes_for_expectations):
503         (TestExpectations.__init__):
504         (TestExpectations):
505         (TestExpectations.parse_generic_expectations):
506         (TestExpectations.parse_default_port_expectations):
507         (TestExpectations.parse_override_expectations):
508         (TestExpectations.parse_all_expectations):
509         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
510         (parse_exp):
511         (SkippedTests.check):
512         (SkippedTests.test_skipped_entry_dont_exist):
513         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
514         (run_results):
515         * Scripts/webkitpy/tool/commands/queries.py:
516         (PrintExpectations._model):
517         * Scripts/webkitpy/tool/commands/rebaseline.py:
518         (RebaselineTest._update_expectations_file):
519         (RebaselineExpectations._update_expectations_files):
520         (RebaselineExpectations._tests_to_rebaseline):
521
522 2013-12-17  Jer Noble  <jer.noble@apple.com>
523
524         Fix TimeRanges::intersectWith
525         https://bugs.webkit.org/show_bug.cgi?id=118802
526
527         Reviewed by Eric Carlson.
528
529         Add unit tests for WebCore/TimeRanges.
530
531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
532         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
533         (TestWebKitAPI::ToString):
534         (TestWebKitAPI::TEST):
535
536 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
537
538         Botwatcher's dashboard ceases to update itself after a while
539         https://bugs.webkit.org/show_bug.cgi?id=125885
540
541         Reviewed by Timothy Hatcher.
542
543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
544         Removed code that checked for the view being hidden. It's none of model's business.
545
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
547         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
548         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
549         We now stop the timer for hidden views.
550         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
551
552 2013-12-17  Anders Carlsson  <andersca@apple.com>
553
554         Fix the 32-bit build.
555
556         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
557         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
558
559 2013-12-17  Anders Carlsson  <andersca@apple.com>
560
561         Give the MiniBrowser a bundle
562         https://bugs.webkit.org/show_bug.cgi?id=125882
563
564         Reviewed by Sam Weinig.
565
566         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
567         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
568         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
569         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
570         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
571         * MiniBrowser/mac/AppDelegate.m:
572         (-[BrowserAppDelegate init]):
573         * MiniBrowser/mac/Bundle/Info.plist: Added.
574         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
575
576 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
577
578         Remove PageVisibilityStateUnloaded
579         https://bugs.webkit.org/show_bug.cgi?id=125869
580
581         Reviewed by Anders Carlsson.
582
583         This is not currently supported by WebKit, remove this enum value.
584         We can always add this back later if/when we add support for this state.
585
586         * DumpRenderTree/mac/TestRunnerMac.mm:
587         (TestRunner::setPageVisibility):
588         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
589         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
591         (WTR::TestRunner::setPageVisibility):
592             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
593
594 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
595
596         [GTK] [CMake] Build the plugin process against GTK+ 2
597         https://bugs.webkit.org/show_bug.cgi?id=116374
598
599         Reviewed by Gustavo Noronha Silva.
600
601         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
602         libraries required for WebCore unit tests.
603
604 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
605
606         [Win] Revise filter-build-webkit to deal with Windows build logs
607         https://bugs.webkit.org/show_bug.cgi?id=125866
608
609         Reviewed by David Kilzer.
610
611         Enhance the script to accept a 'platform' argument. When platform
612         'win' is provided, use processing for the Windows build file format.
613         Otherwise, process the files as normal.
614
615         * Scripts/filter-build-webkit:
616         (usageAndExit): Add a 'platform' argument
617         (shouldIgnoreLine): When platform == 'win' use the new Windows
618         rules for processing the build file.
619
620 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
621
622         Update style checker now that ENUM_CLASS is gone
623         https://bugs.webkit.org/show_bug.cgi?id=125864
624
625         Reviewed by Anders Carlsson.
626
627         * Scripts/webkitpy/style/checkers/cpp.py:
628         (_EnumState.process_clean_line):
629         (check_braces):
630         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
631         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
632         (NoNonVirtualDestructorsTest.test_enum_casing):
633         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
634         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
635         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
636         (WebKitStyleTest.test_braces.CPP11EnumClass):
637
638 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
639
640         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
641         https://bugs.webkit.org/show_bug.cgi?id=125857
642
643         Reviewed by Chris Fleizach.
644
645         Add mappings to DRT & WKTR for the newly exposed roles, and
646         increase the version of ATK used by the internal jhbuild.
647
648         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
650         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
651
652 2013-12-17  Alex Christensen  <achristensen@webkit.org>
653
654         [WinCairo] Adding support for GStreamer and GLib.
655         https://bugs.webkit.org/show_bug.cgi?id=124867
656
657         Reviewed by Philippe Normand.
658
659         * WinLauncher/WinLauncher.cpp:
660         (wWinMain):
661         Added g_main_context_iteration in main event loop.
662
663 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
664
665         Fix for C++ should have the & or * beside the type not the variable name check.
666         https://bugs.webkit.org/show_bug.cgi?id=125846
667
668         Reviewed by Darin Adler.
669
670         * Scripts/webkitpy/style/checkers/cpp.py:
671         (check_spacing):
672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
673         (CppStyleTest.test_pointer_reference_marker_location):
674
675 2013-12-16  Rob Buis  <rob.buis@samsung.com>
676
677         Add my Samsung email address.
678
679         Unreviewed.
680
681         * Scripts/webkitpy/common/config/contributors.json:
682
683 2013-12-16  Oliver Hunt  <oliver@apple.com>
684
685         Cache getters and custom accessors on the prototype chain
686         https://bugs.webkit.org/show_bug.cgi?id=125602
687
688         Reviewed by Michael Saboff.
689
690         Make sure bencher scripts also make noInline exist
691
692         * Scripts/bencher:
693
694 2013-12-16  Anders Carlsson  <andersca@apple.com>
695
696         Fix crash when trying to load a null HTML string
697         https://bugs.webkit.org/show_bug.cgi?id=125801
698
699         Reviewed by Dan Bernstein.
700
701         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
702         (TestWebKitAPI::TEST_F):
703         Update test results.
704
705 2013-12-16  Alex Christensen  <achristensen@webkit.org>
706
707         Fixed Win64 build on VS2013.
708         https://bugs.webkit.org/show_bug.cgi?id=125753
709
710         Reviewed by Brent Fulgham.
711
712         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
713         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
714         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
715         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
716         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
717         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
718         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
719         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
720         * win/record-memory/record-memory.vcxproj:
721         Added correct PlatformToolset for 64-bit builds.
722
723 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
724
725         Add a menu option to MiniBrowser to enable UI-side compositing
726         https://bugs.webkit.org/show_bug.cgi?id=125793
727
728         Reviewed by Anders Carlsson.
729         
730         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
731
732         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
733         to toggle UI-side compositing.
734         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
735         * MiniBrowser/mac/WK2BrowserWindowController.m:
736         (-[WK2BrowserWindowController validateMenuItem:]):
737         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
738         (-[WK2BrowserWindowController toggleUISideCompositing:]):
739         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
740         Adjust the window title to indicate whether the window is using UI-side compositing.
741
742 2013-12-16  Commit Queue  <commit-queue@webkit.org>
743
744         Unreviewed, rolling out r160645.
745         http://trac.webkit.org/changeset/160645
746         https://bugs.webkit.org/show_bug.cgi?id=125787
747
748         Change breaks test-webkitpy (Requested by bfulgham on
749         #webkit).
750
751         * Scripts/prepare-ChangeLog:
752         (get_selector_line_ranges_for_css):
753
754 2013-12-16  David Farler  <dfarler@apple.com>
755
756         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
757         https://bugs.webkit.org/show_bug.cgi?id=124610
758
759         Reviewed by Mark Rowe.
760
761         * WebKitLauncher/WebKitNightlyEnabler.m:
762         (enableWebKitNightlyBehaviour):
763         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
764         * WebKitLauncher/main.m:
765         (main):
766         Include both libasancrashreporter and the nightly enabler to
767         the list of libraries to insert.
768
769 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
770
771         Resolve inconsistant style warning caused by r160319.
772         https://bugs.webkit.org/show_bug.cgi?id=125772
773
774         Reviewed by Darin Adler.
775
776         * Scripts/webkitpy/style/checkers/cpp.py:
777         (check_for_extra_new_line_at_eof):
778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
779         (CppStyleTest.test_newline_at_eof):
780         (CppStyleTest.test_extra_newlines_at_eof):
781
782 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
783
784         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
785         https://bugs.webkit.org/show_bug.cgi?id=125780
786
787         Reviewed by Darin Adler.
788
789         * Scripts/webkitpy/port/mock_drt.py:
790         (main):
791         (parse_options):
792         (MockDRT.write_test_output):
793         * Scripts/webkitpy/port/mock_drt_unittest.py:
794         (MockDRTTest.assertTest):
795         (MockDRTTest.test_reftest_mismatch):
796
797 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
798
799         prepare-Changelog treats CSS keyframes as mismatched parentheses.
800         https://bugs.webkit.org/show_bug.cgi?id=125435
801
802         Reviewed by Darin Adler.
803
804         * Scripts/prepare-ChangeLog:
805         (get_selector_line_ranges_for_css):
806
807 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
808
809         [ATK] Expose accessibility objects for more WAI-ARIA roles
810         https://bugs.webkit.org/show_bug.cgi?id=125596
811
812         Reviewed by Chris Fleizach.
813
814         Add mappings to DRT & WKTR for the newly exposed roles.
815
816         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
818
819 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
820
821         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
822         https://bugs.webkit.org/show_bug.cgi?id=125594
823
824         Reviewed by Chris Fleizach.
825
826         Add mappings to DRT & WKTR for checkmenuitem role.
827
828         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
830
831 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
832
833         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
834         https://bugs.webkit.org/show_bug.cgi?id=125587
835
836         Reviewed by Chris Fleizach.
837
838         Add mappings to DRT & WKTR for article roles.
839
840         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
841         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
842
843 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
844
845         [FTL] Allow EFL to build FTL with the build-jsc script.
846         https://bugs.webkit.org/show_bug.cgi?id=125774
847
848         Reviewed by Zoltan Herczeg.
849
850         * Scripts/build-jsc:
851
852 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
853
854         Add myself as a committer
855
856         Unreviewed.
857
858         * Scripts/webkitpy/common/config/contributors.json:
859
860 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
861
862         Refactor option handling in WebKitTestRunner.
863         https://bugs.webkit.org/show_bug.cgi?id=123185
864
865         Reviewed by Darin Adler.
866
867         Option handling is refactored (according to the FIXME) that allows
868         to automatically generate the help message.
869
870         * WebKitTestRunner/CMakeLists.txt:
871         * WebKitTestRunner/GNUmakefile.am:
872         * WebKitTestRunner/Options.cpp: Added.
873         (WTR::Options::Options):
874         (WTR::handleOptionTimeout):
875         (WTR::handleOptionNoTimeout):
876         (WTR::handleOptionNoTimeoutAtAll):
877         (WTR::handleOptionVerbose):
878         (WTR::handleOptionGcBetweenTests):
879         (WTR::handleOptionPixelTests):
880         (WTR::handleOptionPrintSupportedFeatures):
881         (WTR::handleOptionComplexText):
882         (WTR::handleOptionAcceleratedDrawing):
883         (WTR::handleOptionRemoteLayerTree):
884         (WTR::handleOptionUnmatched):
885         (WTR::OptionsHandler::OptionsHandler):
886         (WTR::Option::Option):
887         (WTR::Option::matches):
888         (WTR::OptionsHandler::parse):
889         (WTR::OptionsHandler::printHelp):
890         * WebKitTestRunner/Options.h: Added.
891         * WebKitTestRunner/TestController.cpp:
892         (WTR::TestController::initialize):
893         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
894
895 2013-12-15  Dan Bernstein  <mitz@apple.com>
896
897         32-bit build fix.
898
899         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
900         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
901
902 2013-12-14  Tim Horton  <timothy_horton@apple.com>
903
904         stylebot should warn when FeatureDefines differ
905         https://bugs.webkit.org/show_bug.cgi?id=125748
906
907         Reviewed by Dan Bernstein.
908
909         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
910         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
911         an unlikely occurrance, to add them to the list).
912
913         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
914         but that is the most straightforward way to implement it (and we're at zero diffs right now).
915
916         * Scripts/webkitpy/style/checker.py:
917         (_all_categories):
918         (FileType):
919         (CheckerDispatcher._file_type):
920         (CheckerDispatcher._create_checker):
921         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
922         (FeatureDefinesChecker):
923         (FeatureDefinesChecker.__init__):
924         (FeatureDefinesChecker.check):
925
926 2013-12-13  Sam Weinig  <sam@webkit.org>
927
928         Fix API tests.
929
930         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
931         (TestWebKitAPI::TEST_F):
932
933 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
934
935         [Win] Remove Pre-VS2013 support code.
936         https://bugs.webkit.org/show_bug.cgi?id=125693
937
938         Reviewed by Darin Adler.
939
940         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
941         the math library.
942         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
943
944 2013-12-13  Lucas Forschler  <lforschler@apple.com>
945
946         Update Webkit bots.
947         
948         Unreviewed.
949         
950         * BuildSlaveSupport/build.webkit.org-config/config.json:
951
952 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
953
954         [Win] Unreviewed build fix after r160548
955
956         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
957         we are using vs12_xp target for Makefile-based projects.
958
959 2013-12-13  Lucas Forschler  <lforschler@apple.com>
960
961         Update Apple Webkit Bots
962         
963         Unreviewed.
964
965         * BuildSlaveSupport/build.webkit.org-config/config.json:
966
967 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
968
969         Unreviewed build fix after r160548.
970
971         * Scripts/webkitdirs.pm:
972         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
973
974 2013-12-13  Lucas Forschler  <lforschler@apple.com>
975
976         Update Apple bots.
977         
978         Unreviewed.
979
980         * BuildSlaveSupport/build.webkit.org-config/config.json:
981
982 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
983
984         [Win] Switch WebKit solution to Visual Studio 2013
985         https://bugs.webkit.org/show_bug.cgi?id=125192
986
987         Reviewed by Anders Carlsson.
988
989         Project files must reference vs12_xp for 32-bit builds. 
990
991         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
992         Update for VS2013
993         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
994         Ditto
995         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
996         Ditto
997         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
998         Ditto
999         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1000         Ditto
1001         * Scripts/webkitdirs.pm:
1002         (visualStudioInstallDir): Specify VS2013
1003         (visualStudioVersion): Ditto.
1004         (setupAppleWinEnv): Use VS2013 in messages
1005         (setupCygwinEnv): Ditto
1006         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1007         Update for VS2013
1008         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1009         Ditto
1010         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1011         Ditto
1012         * win/record-memory/record-memory.vcxproj:
1013         Ditto
1014
1015 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
1016
1017         Adding a .ycm_extra_conf file for webkitGtk
1018         https://bugs.webkit.org/show_bug.cgi?id=119618
1019
1020         Reviewed by Gustavo Noronha Silva.
1021
1022         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
1023         read the GTK+ build files to determine dynamically what flags to compile a source
1024         file with. This allows Vim to provide auto-complete for C++/C language. See
1025         https://github.com/Valloric/YouCompleteMe for how to use this file.
1026
1027         * gtk/common.py:
1028         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
1029         * gtk/ycm_extra_conf.py: Added.
1030
1031 2013-12-12  Tim Horton  <timothy_horton@apple.com>
1032
1033         [wk2] Handle pinch-to-zoom gesture
1034         https://bugs.webkit.org/show_bug.cgi?id=125604
1035
1036         Reviewed by Simon Fraser.
1037
1038         * MiniBrowser/mac/WK2BrowserWindowController.m:
1039         (-[WK2BrowserWindowController awakeFromNib]):
1040         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
1041
1042 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
1043
1044         Unreviewed. Add myself as a committer.
1045
1046         * Scripts/webkitpy/common/config/contributors.json:
1047
1048 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1049
1050         Update hardware for Apple bots.
1051         
1052         Unreviewed.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/config.json:
1055
1056 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1057
1058         Remove unused Apple Bots.
1059         
1060         Unreviewed.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/config.json:
1063
1064 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1065
1066         Unreviewed. Add myself as a committer.
1067
1068         * Scripts/webkitpy/common/config/contributors.json:
1069
1070 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
1071
1072         Test new JSContext name APIs
1073         https://bugs.webkit.org/show_bug.cgi?id=125607
1074
1075         Reviewed by Darin Adler.
1076
1077         * Scripts/run-javascriptcore-tests:
1078         Remove trailing whitespace.
1079
1080 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1081
1082         [Autotools] Prepend the WebCore layer archives' names with 'lib'
1083         https://bugs.webkit.org/show_bug.cgi?id=125627
1084
1085         Reviewed by Martin Robinson.
1086
1087         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
1088         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
1089
1090 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1091
1092         Unreviewed, rolling out r160446.
1093         http://trac.webkit.org/changeset/160446
1094         https://bugs.webkit.org/show_bug.cgi?id=125630
1095
1096         The upower-glib-based implementation is using API that was
1097         recently removed (Requested by zdobersek1 on #webkit).
1098
1099         * Scripts/webkitperl/FeatureList.pm:
1100
1101 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1102
1103         Unreviewed, rolling out r160417.
1104         http://trac.webkit.org/changeset/160417
1105         https://bugs.webkit.org/show_bug.cgi?id=125629
1106
1107         The patch is causing crashes (Requested by zdobersek1 on
1108         #webkit).
1109
1110         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1111         (axObjectEventListener):
1112         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1113
1114 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1115
1116         Use of ar T option not supported by older binutils
1117         https://bugs.webkit.org/show_bug.cgi?id=118732
1118
1119         Reviewed by Gustavo Noronha Silva.
1120
1121         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
1122         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
1123         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
1124         of the member's object file, and not the full path to it. To work around that, all the object files
1125         under the build directory are listed by their relative paths. The members of various archives then have
1126         the basenames of their paths grepped against that list, with the found path correlating to the member
1127         finally added as the new member of the WebCoreLayer archive.
1128
1129 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1130
1131         check-webkit-style shouldn't check spacing in #if preprocessor lines
1132         https://bugs.webkit.org/show_bug.cgi?id=125534
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         Preprocessor lines that start with #if shouldn't have to adhere to
1137         the same spacing requirements that regular code does
1138
1139         * Scripts/webkitpy/style/checkers/cpp.py:
1140         (check_spacing):
1141         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1142         (CppStyleTest.test_spacing_for_binary_ops):
1143         (WebKitStyleTest.test_line_breaking):
1144
1145 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1146
1147         check-webkit-style can't determine if a comma is part of an initialization list
1148         https://bugs.webkit.org/show_bug.cgi?id=125537
1149
1150         Reviewed by Darin Adler.
1151
1152         The original check to make sure that initialization list lines start with
1153         a comma didn't distinguish between commas that belong to the initialization
1154         list and commas that are part of function calls. Because we don't want to
1155         match parentheses with regular expressions, we should weaken this check to
1156         only check for commas at the end of initialization list lines.
1157
1158         * Scripts/webkitpy/style/checkers/cpp.py:
1159         (check_member_initialization_list):
1160         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1161         (WebKitStyleTest.test_member_initialization_list):
1162
1163 2013-12-11  Tim Horton  <timothy_horton@apple.com>
1164
1165         Make it possible to compare layout test results between various configurations of WebKit
1166         https://bugs.webkit.org/show_bug.cgi?id=125212
1167         <rdar://problem/15199108>
1168
1169         Reviewed by Darin Adler.
1170
1171         * Scripts/compare-webkit-configurations: Added.
1172         Add a script that allows comparison between the "normal" WebKit configuration
1173         used for testing and a different configuration (e.g. with accelerated drawing
1174         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
1175
1176         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
1177
1178         This script runs the tests once in the default configuration, ignoring
1179         all test expectations, writing the results out to a temporary directory.
1180
1181         It then runs the tests again in the modified configuration, against the
1182         just-written temporary results.
1183
1184         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
1185
1186         * DumpRenderTree/mac/DumpRenderTree.mm:
1187         (resetWebPreferencesToConsistentValues):
1188         (initializeGlobalsFromCommandLineOptions):
1189         Enable accelerated drawing if requested.
1190
1191         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1192         (parse_args):
1193         Add --accelerated-drawing and --remote-layer-tree feature switches, which
1194         are forwarded on to the test drivers.
1195         Move those two and --complex-text into their own "feature switches" section.
1196         Drive-by change "Mac OS X" to "OS X".
1197         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
1198         as traditional pixel tests (with PNGs dumped on disk), and
1199         ignores e.g. -expected.html files.
1200
1201         * Scripts/webkitpy/port/base.py:
1202         (Port.reference_files):
1203         Pretend that there are no ref tests.
1204         Since is_reference_html_file is intact, our mechanism to ignore
1205         the expected files will continue working in this case.
1206
1207         * Scripts/webkitpy/port/driver.py:
1208         (Driver.cmd_line):
1209         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
1210
1211         * WebKitTestRunner/TestController.cpp:
1212         (WTR::TestController::TestController):
1213         (WTR::TestController::initialize):
1214         (WTR::TestController::resetPreferencesToConsistentValues):
1215         * WebKitTestRunner/TestController.h:
1216         (WTR::TestController::shouldUseRemoteLayerTree):
1217         * WebKitTestRunner/TestInvocation.cpp:
1218         (WTR::updateThreadedScrollingForCurrentTest):
1219         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1220         (WTR::PlatformWebView::PlatformWebView):
1221         Parse and implement the three feature switches.
1222
1223 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1224
1225         [ATK] Expose accessibility objects WAI-ARIA landmark roles
1226         https://bugs.webkit.org/show_bug.cgi?id=125584
1227
1228         Reviewed by Chris Fleizach.
1229
1230         Add mappings to DRT & WKTR for landmark roles.
1231
1232         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1233         (AccessibilityUIElement::role):
1234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1235         (WTR::AccessibilityUIElement::role):
1236         * gtk/jhbuild.modules:
1237
1238 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
1239
1240         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
1241         https://bugs.webkit.org/show_bug.cgi?id=125441
1242
1243         Reviewed by Martin Robinson.
1244
1245         Just avoid the double quotations when building the parameter
1246         because some versions of valgrind are not handling it correctly.
1247
1248         * Scripts/webkitpy/port/gtk.py:
1249         (GtkPort.setup_environ_for_server):
1250
1251 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
1252
1253         [GTK] Enable Battery Status API
1254         https://bugs.webkit.org/show_bug.cgi?id=125453
1255
1256         Reviewed by Martin Robinson.
1257
1258         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
1259
1260 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1261
1262         [GTK][WK2] Add the WebKitBatteryProvider class
1263         https://bugs.webkit.org/show_bug.cgi?id=115720
1264
1265         Reviewed by Martin Robinson.
1266
1267         * gtk/generate-gtkdoc:
1268         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
1269
1270 2013-12-11  Mark Rowe  <mrowe@apple.com>
1271
1272         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
1273
1274         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
1275         to build and maintain this custom Perl module.
1276
1277         Reviewed by Anders Carlsson.
1278
1279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1280         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
1281         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1282         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1283         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
1284         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
1285         build DumpRenderTree.
1286         (dumpToolDidCrash): Stop importing and using the module.
1287         * Scripts/webkitpy/port/base.py:
1288         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
1289
1290 2013-12-11  Brendan Long  <b.long@cablelabs.com>
1291
1292         [GTK] Add "enable-mediasource" property to WebKitWebSettings
1293         https://bugs.webkit.org/show_bug.cgi?id=125566
1294
1295         Reviewed by Philippe Normand.
1296
1297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1298         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
1299         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1300         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
1301
1302 2013-12-11  Dan Bernstein  <mitz@apple.com>
1303
1304         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
1305         https://bugs.webkit.org/show_bug.cgi?id=125579
1306
1307         Reviewed by Anders Carlsson.
1308
1309         * MiniBrowser/mac/WK2BrowserWindowController.m:
1310         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
1311         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
1312         activeURL property changes, update the URL field with its value.
1313         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
1314         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
1315         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1316         Ditto.
1317         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
1318         Ditto.
1319         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1320         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1321
1322 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1323
1324         Fixed test-wepkitpy logging for buildslaves
1325         https://bugs.webkit.org/show_bug.cgi?id=125445
1326
1327         Reviewed by Csaba Osztrogonác.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1330         (RunPythonTests):
1331
1332 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1333
1334         Programmatically-inserted children lack accessibility events
1335         https://bugs.webkit.org/show_bug.cgi?id=100275
1336
1337         Reviewed by Chris Fleizach.
1338
1339         Update DRT and WebKitTestRunner to handle the children-changed
1340         signal properly, considering the detail and optional parameters.
1341
1342         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1343         (axObjectEventListener):
1344         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1345
1346 2013-12-03  Mark Rowe  <mrowe@apple.com>
1347
1348         <https://webkit.org/b/125139> Modernize the WebKit API headers
1349         <rdar://problem/15540175>
1350
1351         Reviewed by Anders Carlsson.
1352
1353         * DumpRenderTree/mac/TestRunnerMac.mm:
1354         (TestRunner::setCacheModel): Cast to the enum type.
1355
1356 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
1357
1358         Get rid of forward exit on DoubleAsInt32
1359         https://bugs.webkit.org/show_bug.cgi?id=125552
1360
1361         Reviewed by Oliver Hunt.
1362         
1363         Add some support for testing the generic (non-X86) paths on X86 by disabling
1364         architecture-specific optimizations (ASO's).
1365
1366         * Scripts/run-javascriptcore-tests:
1367         * Scripts/run-jsc-stress-tests:
1368
1369 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
1370
1371         Unreviewed EFL build fix attempt
1372
1373         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
1374         * WebKitTestRunner/CMakeLists.txt: Ditto.
1375
1376 2013-12-10  Anders Carlsson  <andersca@apple.com>
1377
1378         Add a HashMap constructor that takes an initializer list
1379         https://bugs.webkit.org/show_bug.cgi?id=125551
1380
1381         Reviewed by Dan Bernstein.
1382
1383         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1384         (TestWebKitAPI::TEST):
1385
1386 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1387
1388         Use std::array when computing MD5 checksum
1389         https://bugs.webkit.org/show_bug.cgi?id=125509
1390
1391         Reviewed by Anders Carlsson.
1392
1393         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
1394
1395         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1396         (computeMD5HashStringForBitmapContext):
1397         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1398         (computeMD5HashStringForBitmapContext):
1399         * TestWebKitAPI/Tests/WTF/MD5.cpp:
1400         (TestWebKitAPI::expectMD5):
1401         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1402         (WTR::computeMD5HashStringForCairoSurface):
1403         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1404         (WTR::computeMD5HashStringForContext):
1405
1406 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1407
1408         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1409         https://bugs.webkit.org/show_bug.cgi?id=125522
1410
1411         Reviewed by Chris Fleizach.
1412
1413         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1414
1415         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1416         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1417
1418 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1419
1420         Add --makeargs option to build-jsc
1421         https://bugs.webkit.org/show_bug.cgi?id=125344
1422
1423         Reviewed by Filip Pizlo.
1424
1425         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1426
1427 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1428
1429         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1430         https://bugs.webkit.org/show_bug.cgi?id=125497
1431
1432         Reviewed by Mario Sanchez Prada.
1433
1434         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1435         (AccessibilityUIElement::stringForRange): Implemented.
1436         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1437         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1438
1439 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1440
1441         Various fixes for the CMake GTK+ build
1442
1443         Reviewed by Gustavo Noronha.
1444
1445         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1446         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1447
1448 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1449
1450         --cloop option does not work in Tools/Scripts/build-jsc.
1451         https://bugs.webkit.org/show_bug.cgi?id=125214
1452
1453         Reviewed by Csaba Osztrogonác.
1454
1455         * Scripts/build-jsc:
1456
1457 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1458
1459         Merge mark_for_landing and mark_for_commit_queue into one argument
1460         https://bugs.webkit.org/show_bug.cgi?id=125448
1461
1462         Reviewed by Ryosuke Niwa.
1463
1464         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1465         (CommitQueueFlag):
1466         (Bugzilla._commit_queue_flag):
1467         (Bugzilla._fill_attachment_form):
1468         (Bugzilla.add_patch_to_bug):
1469         (Bugzilla.create_bug):
1470         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1471         (test_commit_queue_flag.assert_commit_queue_flag):
1472         (test_commit_queue_flag):
1473
1474 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1475
1476         Remove dead extract_reference_link.py (and the reftests module)
1477         https://bugs.webkit.org/show_bug.cgi?id=125116
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         This code doesn't seem to have ever been used.
1482
1483         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1484         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1485         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1486
1487 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1488
1489         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1490         https://bugs.webkit.org/show_bug.cgi?id=125456
1491
1492         Reviewed by Chris Fleizach.
1493
1494         Return 'AXSection' for section roles instead of 'AXDiv'.
1495
1496         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1497         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1498
1499 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1500
1501         check-webkit-style should check for extra newlines at EOF
1502         https://bugs.webkit.org/show_bug.cgi?id=125424
1503
1504         Reviewed by Darin Adler.
1505
1506         Report a style violation if extraneous newlines are added
1507         to the end of a C++ file. There should only be one newline at EOF.
1508
1509         * Scripts/webkitpy/style/checkers/cpp.py:
1510         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1511         (check_for_extra_new_line_at_eof): Added.
1512         (_process_lines): Added new check and renamed existing EOF check.
1513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1514         (CppStyleTest.test_extra_newlines_at_eof): Added.
1515         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1516
1517 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1518
1519         check-webkit-style: ternary operator in macro call identified as initialization list
1520         https://bugs.webkit.org/show_bug.cgi?id=125443
1521
1522         Reviewed by Ryosuke Niwa.
1523
1524         Do not match initialization list when questionmark is placed before :
1525
1526         * Scripts/webkitpy/style/checkers/cpp.py:
1527         (check_member_initialization_list):
1528
1529 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1530
1531         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1532         https://bugs.webkit.org/show_bug.cgi?id=125451
1533
1534         Reviewed by Mario Sanchez Prada.
1535
1536         Create the needed callbacks for DRT and WKTR.
1537
1538         * DumpRenderTree/AccessibilityUIElement.cpp:
1539         (characterAtOffsetCallback): added
1540         (wordAtOffsetCallback): added
1541         (lineAtOffsetCallback): added
1542         (sentenceAtOffsetCallback): added
1543         (AccessibilityUIElement::getJSClass):
1544         * DumpRenderTree/AccessibilityUIElement.h:
1545         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1546         (stringAtOffset): added
1547         (AccessibilityUIElement::characterAtOffset): added
1548         (AccessibilityUIElement::wordAtOffset): added
1549         (AccessibilityUIElement::lineAtOffset): added
1550         (AccessibilityUIElement::sentenceAtOffset): added
1551         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1552         (WTR::AccessibilityUIElement::characterAtOffset): added
1553         (WTR::AccessibilityUIElement::wordAtOffset): added
1554         (WTR::AccessibilityUIElement::lineAtOffset): added
1555         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1556         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1557         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1558         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1559         (WTR::stringAtOffset): added
1560         (WTR::AccessibilityUIElement::characterAtOffset): added
1561         (WTR::AccessibilityUIElement::wordAtOffset): added
1562         (WTR::AccessibilityUIElement::lineAtOffset): added
1563         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1564
1565 2013-12-08  Sam Weinig  <sam@webkit.org>
1566
1567         32-bit MiniBrowser doesn't build
1568         https://bugs.webkit.org/show_bug.cgi?id=125420
1569
1570         Reviewed by Dan Bernstein.
1571
1572         * MiniBrowser/mac/AppDelegate.h:
1573         * MiniBrowser/mac/AppDelegate.m:
1574         (-[BrowserAppDelegate init]):
1575         (-[BrowserAppDelegate applicationWillTerminate:]):
1576
1577 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1578
1579         [WK2] Add ENABLE_NETWORK_PROCESS flag
1580         https://bugs.webkit.org/show_bug.cgi?id=125421
1581
1582         Add support to build with the Network Process enabled.
1583
1584         Reviewed by Martin Robinson.
1585
1586         * Scripts/webkitperl/FeatureList.pm:
1587
1588 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1589
1590         Fold typedArray.length if typedArray is constant
1591         https://bugs.webkit.org/show_bug.cgi?id=125252
1592
1593         Reviewed by Sam Weinig.
1594         
1595         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1596         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1597         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1598
1599         * Scripts/run-javascriptcore-tests:
1600
1601 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1602
1603         [gdb] Update printers for WTF::CString, JSC::JSString
1604         https://bugs.webkit.org/show_bug.cgi?id=124600
1605
1606         Reviewed by Gustavo Noronha Silva.
1607
1608         Update the two printers after they fell behind the changes in implementation.
1609
1610         * gdb/webkit.py:
1611         (WTFCStringPrinter.to_string):
1612         (JSCJSStringPrinter.to_string):
1613
1614 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1615
1616         [webkitpy] Add a WestonDriver unit test
1617         https://bugs.webkit.org/show_bug.cgi?id=125408
1618
1619         Reviewed by Gustavo Noronha Silva.
1620
1621         Add a webkitpy unit test for the Weston driver.
1622
1623         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1624         (WestonDriverTest):
1625         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1626         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1627         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1628         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1629         the driver cleans up the temporary directory.
1630         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1631         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1632
1633 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1634
1635         [Gtk] install-dependencies doesn't install libgtk-3-dev
1636         https://bugs.webkit.org/show_bug.cgi?id=125320
1637
1638         Reviewed by Gustavo Noronha Silva.
1639
1640         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1641
1642 2013-12-07  Sam Weinig  <sam@webkit.org>
1643
1644         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1645         https://bugs.webkit.org/show_bug.cgi?id=125401
1646
1647         Reviewed by Dan Bernstein.
1648
1649         * MiniBrowser/mac/WK2BrowserWindowController.m:
1650         (-[WK2BrowserWindowController fetch:]):
1651         (-[WK2BrowserWindowController reload:]):
1652         (-[WK2BrowserWindowController goBack:]):
1653         (-[WK2BrowserWindowController goForward:]):
1654         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1655         (-[WK2BrowserWindowController currentZoomFactor]):
1656         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1657         (-[WK2BrowserWindowController zoomIn:]):
1658         (-[WK2BrowserWindowController zoomOut:]):
1659         (-[WK2BrowserWindowController canResetZoom]):
1660         (-[WK2BrowserWindowController resetZoom:]):
1661         (-[WK2BrowserWindowController toggleZoomMode:]):
1662         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1663
1664 2013-12-07  Sam Weinig  <sam@webkit.org>
1665
1666         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1667         https://bugs.webkit.org/show_bug.cgi?id=125400
1668
1669         Reviewed by Dan Bernstein.
1670
1671         * MiniBrowser/mac/AppDelegate.h:
1672         * MiniBrowser/mac/AppDelegate.m:
1673         * MiniBrowser/mac/WK2BrowserWindowController.h:
1674         * MiniBrowser/mac/WK2BrowserWindowController.m:
1675         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1676         (-[WK2BrowserWindowController dealloc]):
1677         (createNewPage):
1678         (-[WK2BrowserWindowController awakeFromNib]):
1679         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1680         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1681         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1682         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1683         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1684         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1685
1686 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1687
1688         [GTK] Run each gtest subtest separately instead of in one go
1689         https://bugs.webkit.org/show_bug.cgi?id=125386
1690
1691         Reviewed by Martin Robinson.
1692
1693         This is what other ports are doing (except they build each test as a separate binary)
1694         and will help with the timeouts we sometimes hit because it applies to the full test
1695         run.
1696
1697         * Scripts/run-gtk-tests:
1698         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1699         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1700         (TestRunner._run_google_test_suite): call the binary once per subtest.
1701
1702 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1703
1704         Move PrettyPatch related code to prettypatch.py
1705         https://bugs.webkit.org/show_bug.cgi?id=124937
1706
1707         Reviewed by Ryosuke Niwa.
1708
1709         This code seems to have a better place here than in Port, since PrettyPatch already knows
1710         pretty_patch_path, and this also unifies the usage of PrettyPatch
1711
1712         * Scripts/webkitpy/common/prettypatch.py:
1713         (PrettyPatch.__init__):
1714         (PrettyPatch.pretty_diff):
1715         (PrettyPatch):
1716         (PrettyPatch.pretty_patch_available):
1717         (PrettyPatch.check_pretty_patch):
1718         (PrettyPatch.pretty_patch_text):
1719         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1720         (TestResultWriter.create_text_diff_and_write_result):
1721         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1722         (summarize_results):
1723         * Scripts/webkitpy/port/base.py:
1724         (Port.__init__):
1725         (Port.wdiff_available):
1726         (Port.check_image_diff):
1727         (Port.wdiff_text):
1728         * Scripts/webkitpy/port/base_unittest.py:
1729         (PortTest.test_pretty_patch_os_error):
1730         (PortTest.test_pretty_patch_script_error):
1731
1732 2013-12-06  Dan Bernstein  <mitz@apple.com>
1733
1734         [Mac] MiniBrowser Debug builds are compiled with -Os
1735         https://bugs.webkit.org/show_bug.cgi?id=125376
1736
1737         Reviewed by Tim Horton.
1738
1739         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1740         the Debug configuration at the project level.
1741
1742 2013-12-06  Jer Noble  <jer.noble@apple.com>
1743
1744         [MSE] Add a runtime-setting for the MediaSource constructor.
1745         https://bugs.webkit.org/show_bug.cgi?id=125336
1746
1747         Reviewed by Eric Carlson.
1748
1749         Enable MediaSource in DRT and WKTR.
1750
1751         * DumpRenderTree/mac/DumpRenderTree.mm:
1752         (resetWebPreferencesToConsistentValues):
1753         * WebKitTestRunner/TestController.cpp:
1754         (WTR::TestController::resetPreferencesToConsistentValues):
1755
1756 2013-12-06  Jer Noble  <jer.noble@apple.com>
1757
1758         Strip out extraneous logging from AppleGVA in media tests.
1759         https://bugs.webkit.org/show_bug.cgi?id=125357
1760
1761         Reviewed by Simon Fraser.
1762
1763         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1764
1765         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1766         (SingleTestRunner._run_compare_test): Strip out logging
1767         * Scripts/webkitpy/port/base.py:
1768         (Port.logging_patterns_to_strip): Return an empty list by default.
1769         * Scripts/webkitpy/port/driver.py:
1770         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1771         * Scripts/webkitpy/port/mac.py:
1772         (MacPort.logging_patterns_to_strip): Return a complete list.
1773
1774 2013-12-06  Dean Jackson  <dino@apple.com>
1775
1776         Updating ANGLE should point to instructions
1777         https://bugs.webkit.org/show_bug.cgi?id=125361
1778
1779         Reviewed by Eric Carlson.
1780
1781         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1782         someone wants to patch ANGLE.
1783
1784         * Scripts/webkitpy/common/config/watchlist:
1785
1786 2013-12-06  Dan Bernstein  <mitz@apple.com>
1787
1788         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1789         https://bugs.webkit.org/show_bug.cgi?id=125334
1790
1791         Reviewed by Darin Adler.
1792
1793         * MiniBrowser/mac/WK2BrowserWindowController.m:
1794         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1795         title property.
1796         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1797         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1798         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1799         window title with the title property changes.
1800         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1801         set the load delegate instead of the load client.
1802         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1803         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1804         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1805         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1806         Implemented this load delegate method.
1807         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1808         Ditto.
1809         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1810         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1811         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1812         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1813         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1814         Ditto.
1815         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1816         Ditto.
1817         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1818
1819 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1820
1821         Remove function from style/checkers/cpp.py.
1822         https://bugs.webkit.org/show_bug.cgi?id=125341
1823
1824         Reviewed by Darin Adler.
1825
1826         Corrects a FIXME: by removing a function from cpp.py.
1827
1828         * Scripts/webkitpy/style/checkers/cpp.py:
1829         (CppChecker.__init__):
1830         (CppChecker.check):
1831         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1832         (CppStyleTestBase.process_file_data):
1833
1834 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1835
1836         check-webkit-style: false positive warning for indentation of #ifdef code.
1837         https://bugs.webkit.org/show_bug.cgi?id=125254
1838
1839         Reviewed by Darin Adler.
1840
1841         * Scripts/webkitpy/style/checkers/cpp.py:
1842         (check_member_initialization_list):
1843         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1844         (WebKitStyleTest.test_member_initialization_list):
1845
1846 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1847
1848         Fix spelling error in style checker: beggining
1849         https://bugs.webkit.org/show_bug.cgi?id=125347
1850
1851         Reviewed by Anders Carlsson.
1852
1853         * Scripts/webkitpy/style/checkers/cpp.py:
1854         (check_member_initialization_list):
1855         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1856         (WebKitStyleTest.test_member_initialization_list):
1857
1858 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1859
1860         [ATK] Missing aria roles mappings
1861         https://bugs.webkit.org/show_bug.cgi?id=117729
1862
1863         Reviewed by Mario Sanchez Prada.
1864
1865         Added new mappings to AccessibilityUIElementAtk.cpp.
1866
1867         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1868         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1869
1870 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1871
1872         Typo fix after r160218.
1873
1874         * Scripts/webkitpy/test/main.py:
1875         (main):
1876
1877 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1878
1879         Unreviewed fix after r160206.
1880
1881         * Scripts/webkitpy/test/main.py:
1882         (main): sys.platform can be win32 or cygwin too on Windows.
1883
1884 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1885
1886         Disable WebKit2 webkitpy unittests on Windows
1887         https://bugs.webkit.org/show_bug.cgi?id=125318
1888
1889         Reviewed by Ryosuke Niwa.
1890
1891         * Scripts/webkitpy/test/main.py:
1892         (main):
1893
1894 2013-12-05  Anders Carlsson  <andersca@apple.com>
1895
1896         Tweak WeakObjCPtr
1897         https://bugs.webkit.org/show_bug.cgi?id=125311
1898
1899         Reviewed by Darin Adler.
1900
1901         Split up tests into more logical groups. Add new tests for new functionality.
1902
1903         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1904
1905 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1908         https://bugs.webkit.org/show_bug.cgi?id=125302
1909
1910         Reviewed by Philippe Normand.
1911
1912         * gtk/generate-webkitdom-doc-files:
1913         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1914         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1915         and WEBKIT_DEPRECATED_FOR macros.
1916
1917 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1918
1919         Fix cross compilation on x86
1920         https://bugs.webkit.org/show_bug.cgi?id=125295
1921
1922         Reviewed by Zoltan Herczeg.
1923
1924         Certain compiler flags should not be added when cross compilation is enabled.
1925
1926         * Scripts/webkitdirs.pm:
1927         (runAutogenForAutotoolsProjectIfNecessary):
1928         (generateBuildSystemFromCMakeProject):
1929
1930 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1931
1932         Remove duplicated/dead code from cpp style checker unit tests.
1933         https://bugs.webkit.org/show_bug.cgi?id=125226
1934
1935         Reviewed by Ryosuke Niwa.
1936
1937         Remove the first definition of OrderOfIncludesTest class as it is
1938         overwritten by the second. Remove a duplicated assert statement
1939         from the second class.
1940
1941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1942         (OrderOfIncludesTest.setUp):
1943         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1944           The last assert was duplicated.
1945
1946 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1947
1948         Remove Scripts/generate-qt-inspector-resource.
1949         https://bugs.webkit.org/show_bug.cgi?id=125288
1950
1951         Reviewed by Andreas Kling.
1952
1953         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1954         We don't need this file.
1955
1956 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1957
1958         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1959         https://bugs.webkit.org/show_bug.cgi?id=125218
1960
1961         Reviewed by Ryosuke Niwa.
1962
1963         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1964         (LayoutTestFinder.skip_tests):
1965         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1966         (LayoutTestRunner.run_tests):
1967         (LayoutTestRunner._update_summary_with_result):
1968         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1969         (Manager._test_is_slow):
1970         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1971         (JSONLayoutResultsGenerator._insert_failure_summaries):
1972         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1973         (TestExpectations.get_rebaselining_failures):
1974         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1975         (assert_exp):
1976         (MiscTests.test_multiple_results):
1977         (MiscTests.test_category_expectations):
1978         (MiscTests.test_get_modifiers):
1979         (MiscTests.test_get_expectations_string):
1980         (MiscTests.test_expectation_to_string):
1981         (MiscTests.test_get_test_set):
1982         (MiscTests.test_more_specific_override_resets_skip):
1983         (SkippedTests.check):
1984         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1985         (TestRunResults.__init__):
1986         (summarize_results):
1987         * Scripts/webkitpy/tool/commands/rebaseline.py:
1988         (RebaselineExpectations._tests_to_rebaseline):
1989
1990 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1991
1992         Enable HTMLTemplateElement by default
1993         https://bugs.webkit.org/show_bug.cgi?id=123851
1994
1995         Reviewed by Antti Koivisto.
1996
1997         * Scripts/webkitperl/FeatureList.pm:
1998
1999 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
2000
2001         [EFL] Bumping GStreamer version to 1.2.1
2002         https://bugs.webkit.org/show_bug.cgi?id=125155
2003
2004         Reviewed by Gyuyoung Kim.
2005
2006         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
2007
2008
2009 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2010
2011         Update jhbuild revision.
2012         https://bugs.webkit.org/show_bug.cgi?id=124966
2013         
2014         Reviewed by Gyuyoung Kim.
2015
2016         Used version of Jhbuild failed to create directories and caused
2017         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
2018
2019         * jhbuild/jhbuild-wrapper:
2020
2021 2013-12-04  Anders Carlsson  <andersca@apple.com>
2022
2023         Add a WeakObjCPtr class
2024         https://bugs.webkit.org/show_bug.cgi?id=125267
2025
2026         Reviewed by Geoffrey Garen.
2027
2028         Add API tests for WeakObjCPtr.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
2032         (TEST):
2033
2034 2013-12-04  Anders Carlsson  <andersca@apple.com>
2035
2036         Make the estimatedProgress property observable using KVO
2037         https://bugs.webkit.org/show_bug.cgi?id=125259
2038
2039         Reviewed by Dan Bernstein.
2040
2041         Bind the progress indicator value to the "estimatedProgress" property.
2042
2043         * MiniBrowser/mac/WK2BrowserWindowController.m:
2044         (-[WK2BrowserWindowController dealloc]):
2045         (-[WK2BrowserWindowController awakeFromNib]):
2046
2047 2013-12-04  Anders Carlsson  <andersca@apple.com>
2048
2049         Add a loading property to WKBrowsingContextController
2050         https://bugs.webkit.org/show_bug.cgi?id=125256
2051
2052         Reviewed by Dan Bernstein.
2053
2054         Bind the progress indicator visibility to the "loading" property.
2055
2056         * MiniBrowser/mac/WK2BrowserWindowController.m:
2057         (-[WK2BrowserWindowController dealloc]):
2058         (-[WK2BrowserWindowController awakeFromNib]):
2059         (-[WK2BrowserWindowController didStartProgress]):
2060         (-[WK2BrowserWindowController didFinishProgress]):
2061
2062 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2063
2064         [EFL][WK2] Buildfix after r160104
2065         https://bugs.webkit.org/show_bug.cgi?id=125231
2066
2067         Reviewed by Anders Carlsson.
2068
2069         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2070         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
2071         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2072         (TestWebKitAPI::setViewClient): Ditto.
2073
2074 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
2075
2076         check-webkit-style detected some ternary statements as initialization lists
2077         https://bugs.webkit.org/show_bug.cgi?id=125246
2078
2079         Reviewed by Dean Jackson.
2080
2081         The regular expression that check-webkit-tests uses to detect initialization
2082         lists was too broad, resulting in false positives. This patch makes the
2083         regex more specific
2084
2085         * Scripts/webkitpy/style/checkers/cpp.py:
2086         (check_member_initialization_list):
2087         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2088         (WebKitStyleTest.test_member_initialization_list):
2089
2090 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2091
2092         run-jsc-stress-tests can only run locally
2093         https://bugs.webkit.org/show_bug.cgi?id=124551
2094
2095         Reviewed by Filip Pizlo.
2096
2097         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
2098         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
2099         added a couple more signals to handle gracefully at shutdown. 
2100         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
2101         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
2102         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
2103         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
2104         toward the end of the script to make it easier to tell which of the various modes do what.
2105
2106 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
2107
2108         [EFL][WK2] Buildfix after r160104
2109         https://bugs.webkit.org/show_bug.cgi?id=125233
2110
2111         Reviewed by Anders Carlsson.
2112
2113         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2114         (TestWebKitAPI::TEST):
2115         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2116         (TestWebKitAPI::setPageLoaderClient):
2117
2118 2013-12-03  Anders Carlsson  <andersca@apple.com>
2119
2120         Deprecate all unversioned client structs in favor of having explicit versioned structs
2121         https://bugs.webkit.org/show_bug.cgi?id=125203
2122
2123         Reviewed by Dan Bernstein.
2124
2125         Update for WebKit2 API changes.
2126
2127         * MiniBrowser/mac/AppDelegate.m:
2128         (-[BrowserAppDelegate init]):
2129         * MiniBrowser/mac/WK2BrowserWindowController.m:
2130         (-[WK2BrowserWindowController awakeFromNib]):
2131         * TestWebKitAPI/InjectedBundleController.cpp:
2132         (TestWebKitAPI::InjectedBundleController::initialize):
2133         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2136         (TestWebKitAPI::setInjectedBundleClient):
2137         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2144         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2145         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2148         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
2149         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2150         (TestWebKitAPI::setInjectedBundleClient):
2151         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2152         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2153         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2158         (TestWebKitAPI::setContextDownloadClient):
2159         (TestWebKitAPI::setPagePolicyClient):
2160         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2163         (TestWebKitAPI::TEST):
2164         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2165         (TestWebKitAPI::TEST):
2166         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2173         (TestWebKitAPI::setupGeolocationProvider):
2174         (TestWebKitAPI::setupView):
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2179         (TestWebKitAPI::setPageLoaderClient):
2180         (TestWebKitAPI::setInjectedBundleClient):
2181         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2182         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2183         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2184         (TestWebKitAPI::TEST):
2185         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2186         (TestWebKitAPI::setInjectedBundleClient):
2187         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2188         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
2189         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2190         (TestWebKitAPI::TEST):
2191         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2192         (TestWebKitAPI::TEST):
2193         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2194         (TestWebKitAPI::TEST):
2195         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2196         (TestWebKitAPI::TEST):
2197         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2198         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
2199         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2200         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2201         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2202         (TestWebKitAPI::setPageLoaderClient):
2203         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2204         (TestWebKitAPI::setPageLoaderClient):
2205         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2206         (TestWebKitAPI::setPageLoaderClient):
2207         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2208         (TestWebKitAPI::setPageLoaderClient):
2209         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2210         (TestWebKitAPI::setPageLoaderClient):
2211         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2212         (TestWebKitAPI::TEST):
2213         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2214         (TestWebKitAPI::TEST):
2215         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2216         (TestWebKitAPI::setInjectedBundleClient):
2217         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2218         (TestWebKitAPI::ParentFrameTest::didCreatePage):
2219         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2220         (TestWebKitAPI::setInjectedBundleClient):
2221         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2222         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
2223         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2224         (TestWebKitAPI::TEST):
2225         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2226         (TestWebKitAPI::TEST):
2227         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2228         (TestWebKitAPI::TEST):
2229         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2230         (TestWebKitAPI::TEST):
2231         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2232         (TestWebKitAPI::setInjectedBundleClient):
2233         (TestWebKitAPI::setPageLoaderClient):
2234         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2235         (TestWebKitAPI::setPageLoaderClient):
2236         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2237         (TestWebKitAPI::TEST):
2238         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2239         (TestWebKitAPI::setPageLoaderClient):
2240         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2241         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
2242         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2243         (TestWebKitAPI::TEST):
2244         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2245         (TestWebKitAPI::TEST):
2246         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2247         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2248         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2249         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
2250         (TestWebKitAPI::TEST):
2251         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
2252         (TestWebKitAPI::WKConnectionTest::initialize):
2253         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2254         (TestWebKitAPI::setPageLoaderClient):
2255         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2256         (TestWebKitAPI::setInjectedBundleClient):
2257         (TestWebKitAPI::TEST):
2258         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2259         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
2260         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2261         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2262         (TestWebKitAPI::setInjectedBundleClient):
2263         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2264         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
2265         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2266         (TestWebKitAPI::TEST):
2267         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2268         (TestWebKitAPI::setInjectedBundleClient):
2269         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2270         (TestWebKitAPI::TEST):
2271         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2272         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2273         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2274         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2275         (TestWebKitAPI::didCreateConnection):
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2278         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2279         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2280         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2281         (TestWebKitAPI::setPageLoaderClient):
2282         * WebKitTestRunner/GeolocationProviderMock.cpp:
2283         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2284         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2285         (WTR::InjectedBundle::initialize):
2286         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2287         (WTR::InjectedBundlePage::InjectedBundlePage):
2288         * WebKitTestRunner/TestController.cpp:
2289         (WTR::TestController::createOtherPage):
2290         (WTR::TestController::initialize):
2291         (WTR::TestController::createWebViewWithOptions):
2292
2293 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2294
2295         Style checker for .messages.in files (WTF:: prefix)
2296         https://bugs.webkit.org/show_bug.cgi?id=125142
2297
2298         Reviewed by Anders Carlsson.
2299
2300         A new style checker for .messages.in files, that checks for the use of WTF::
2301         prefix in these files. (Also checks for tabs as these files were previously
2302         handled as text files.)
2303
2304         * Scripts/webkitpy/style/checker.py:
2305         (CheckerDispatcher._create_checker):
2306           New checker is returned for .messages.in files.
2307         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
2308           The new style checker class.
2309         (MessagesInChecker):
2310         (MessagesInChecker.__init__):
2311         (MessagesInChecker.check):
2312         (MessagesInChecker.check_WTF_prefix):
2313         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
2314           Unit test for the new style  checker class.
2315         (MessagesInCheckerStyleTestCase):
2316         (test_checker):
2317         (test_checker.error_handler_for_test):
2318         (MessagesInCheckerTestCase):
2319         (MessagesInCheckerTestCase.test_init):
2320         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
2321
2322 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2323
2324         Style checker requires alphabetical ordering in cmake lists even it contains variable.
2325         https://bugs.webkit.org/show_bug.cgi?id=124918
2326
2327         Reviewed by Csaba Osztrogonác.
2328
2329         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2330         (CMakeCheckerTest.test_check):
2331         * Scripts/webkitpy/style/checkers/cmake.py:
2332         (CMakeChecker._check_list_order):
2333         This will ignore lines with variable substitution.
2334
2335 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2336
2337         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
2338         https://bugs.webkit.org/show_bug.cgi?id=124731
2339
2340         Reviewed by Zoltan Herczeg.
2341
2342         * Scripts/webkitpy/style/checkers/cpp.py:
2343         (check_spacing):
2344         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2345         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
2346
2347 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2348
2349         Remove codecs and os dependencies from filereader.py in webkitpy/style.
2350         https://bugs.webkit.org/show_bug.cgi?id=124719
2351
2352         Although TextFileReader requires a FileSystem it circumvents it in two places!
2353         We should use the FileSystem only and remove codecs and os imports.
2354
2355         Reviewed by Zoltan Herczeg.
2356
2357         * Scripts/webkitpy/common/system/filesystem.py:
2358         (FileSystem.open_stdin): Moved from TextFileReader
2359         * Scripts/webkitpy/style/filereader.py:
2360         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
2361         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
2362
2363 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2364
2365         check-webkit-style should check member initialization indentation.
2366         https://bugs.webkit.org/show_bug.cgi?id=124820
2367
2368         Reviewed by Zoltan Herczeg.
2369
2370         check-webkit-style should check member initialization indentation
2371         belongs to webkit coding style:
2372         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
2373
2374         * Scripts/webkitpy/style/checkers/cpp.py:
2375         (check_member_initialization_list): Add new method to check member
2376         initialization list.
2377         (check_style): Add the call of the new method.
2378         (check_language): Move self initialization checking into the new method.
2379         (CppChecker): Add a new category for initialization list.
2380         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2381         (CppStyleTest.test_runtime_selfinit):
2382         (CppStyleTest.test_deprecated_cast):
2383         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
2384         the new feature.
2385
2386 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
2387
2388         style-bot should reject Committer additions to committers.py
2389         https://bugs.webkit.org/show_bug.cgi?id=107574
2390
2391         Reviewed by Zoltan Herczeg.
2392
2393         The style check when executed in non-interactive mode (probably by a
2394         bot) will raise an additional error if the contributors.json file is
2395         modified. Non-interactive mode information is propagated to the
2396         Dispatcher, which creates a special JSON checker for the
2397         contributors.json file.
2398
2399         * Scripts/webkitpy/style/checker.py:
2400         (check_webkit_style_configuration):
2401         (CheckerDispatcher._create_checker):
2402         (CheckerDispatcher.dispatch):
2403         (StyleProcessorConfiguration.__init__):
2404         (StyleProcessor.process):
2405         * Scripts/webkitpy/style/checker_unittest.py:
2406         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
2407         (CheckerDispatcherDispatchTest.dispatch):
2408         (StyleProcessorConfigurationTest._style_checker_configuration):
2409         (StyleProcessor_EndToEndTest.test_init):
2410         (StyleProcessor_EndToEndTest.test_process):
2411         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2412         (StyleProcessor_CodeCoverageTest.setUp):
2413         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2414         (JSONChecker.line_number_from_json_exception):
2415         (JSONContributorsChecker):
2416         (JSONContributorsChecker.check):
2417         * Scripts/webkitpy/style/error_handlers_unittest.py:
2418         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2419         * Scripts/webkitpy/style/optparser.py:
2420         (CommandOptionValues.__init__):
2421         (ArgumentParser._create_option_parser):
2422         (ArgumentParser.parse):
2423         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2424         (test_post):
2425         (test_upload):
2426         * Scripts/webkitpy/tool/steps/checkstyle.py:
2427         (CheckStyle.run):
2428
2429 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2430
2431         [EFL][WK2] Fix build after API::Client changes
2432         https://bugs.webkit.org/show_bug.cgi?id=125206
2433
2434         Reviewed by Csaba Osztrogonác.
2435
2436         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2437         (TestWebKitAPI::TEST):
2438         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2439         (TestWebKitAPI::setViewClient):
2440
2441 2013-12-03  Dan Bernstein  <mitz@apple.com>
2442
2443         Fixed a test timing out after r160040.
2444
2445         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2446         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2447         Updated for the delegate method rename.
2448
2449 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2450
2451         REGRESSION: repro scripts disappear when you rerun tests
2452         https://bugs.webkit.org/show_bug.cgi?id=125184
2453
2454         Reviewed by Mark Hahnenberg.
2455         
2456         This bug made it difficult to quickly see if a test that recently failed is still
2457         failing while also running a new batch of tests.
2458
2459         Repro scripts are supposed to stay around until you delete them explicitly. This
2460         patch accomplishes that.
2461
2462         * Scripts/run-jsc-stress-tests:
2463
2464 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2465
2466         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2467         https://bugs.webkit.org/show_bug.cgi?id=125111
2468
2469         Reviewed by Filip Pizlo.
2470
2471         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2472
2473         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2474         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2475
2476 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2477
2478         Add a script to automatically configure a git clone
2479         https://bugs.webkit.org/show_bug.cgi?id=110073
2480
2481         Revert the change to use https for now since git.webkit.org is setup with http.
2482
2483         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2484         (SetupGitClone.execute):
2485
2486 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2487
2488         Add a script to automatically configure a git clone
2489         https://bugs.webkit.org/show_bug.cgi?id=110073
2490
2491         Reviewed by Benjamin Poulain.
2492
2493         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2494
2495         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2496
2497         * Scripts/webkitpy/tool/commands/__init__.py:
2498         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2499         (SetupGitClone):
2500         (SetupGitClone.execute):
2501
2502 2013-12-03  Anders Carlsson  <andersca@apple.com>
2503
2504         Deprecate WKNotificationProvider
2505         https://bugs.webkit.org/show_bug.cgi?id=125178
2506
2507         Reviewed by Sam Weinig.
2508
2509         Update for WebKit2 changes.
2510
2511         * WebKitTestRunner/TestController.cpp:
2512         (WTR::TestController::initialize):
2513         * WebKitTestRunner/WebNotificationProvider.cpp:
2514         (WTR::WebNotificationProvider::provider):
2515         * WebKitTestRunner/WebNotificationProvider.h:
2516
2517 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2518
2519         [Win] Support 64-bit Application Support Libraries Location 
2520         https://bugs.webkit.org/show_bug.cgi?id=125179
2521
2522         Reviewed by Tim Horton.
2523
2524         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2525         on Windows until an official distribution is available that properly creates registry settings
2526         to specify these locations.
2527
2528         * Scripts/webkitdirs.pm:
2529         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2530         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2531         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2532         running 64-bit builds.
2533
2534 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2535
2536         run-jsc-stress-tests only supports host environments that have make installed
2537         https://bugs.webkit.org/show_bug.cgi?id=124550
2538
2539         Reviewed by Darin Adler.
2540
2541         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2542         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2543         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2544         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2545         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2546         of the make-based runner.
2547
2548         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2549         the bundle and controls all of the parallel aspects of the shell-based test runner.
2550         * Scripts/run-jsc-stress-tests:
2551
2552 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2553
2554         Remove function from TextChecker
2555         https://bugs.webkit.org/show_bug.cgi?id=125148
2556
2557         Reviewed by Darin Adler.
2558
2559         The process_file_data is used only from the unit tests, so it is simply moved there.
2560
2561         * Scripts/webkitpy/style/checkers/text.py:
2562         (TextChecker.check):
2563         * Scripts/webkitpy/style/checkers/text_unittest.py:
2564         (TextStyleTestCase.process_file_data):
2565         (TextStyleTestCase.assertNoError):
2566         (TextStyleTestCase.assertError):
2567
2568 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2569
2570         Remove get_test() and reference test names directly instead.
2571         https://bugs.webkit.org/show_bug.cgi?id=124962
2572
2573         Reviewed by Csaba Osztrogonác.
2574
2575         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2576         (Base.__init__):
2577         (Base.get_basic_tests):
2578         (assert_exp):
2579         (MiscTests.test_multiple_results):
2580         (MiscTests.test_category_expectations):
2581         (MiscTests.test_get_modifiers):
2582         (MiscTests.test_get_expectations_string):
2583         (MiscTests.test_get_test_set):
2584         (MiscTests.test_parse_warning):
2585         (MiscTests.test_pixel_tests_flag.match):
2586
2587 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2588
2589         Style Checker false pass.
2590         https://bugs.webkit.org/show_bug.cgi?id=112456
2591
2592         Reviewed by Csaba Osztrogonác.
2593
2594         * Scripts/webkitpy/style/checkers/changelog.py:
2595         (ChangeLogChecker.check_entry):
2596         simple regex fix to check "No new tests (...)."
2597         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2598         (ChangeLogCheckerTest.test_no_new_tests):
2599
2600 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2601
2602         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2603         https://bugs.webkit.org/show_bug.cgi?id=125130
2604
2605         Reviewed by Geoffrey Garen.
2606
2607         * Scripts/run-jsc-stress-tests:
2608
2609 2013-12-02  Samuel White  <samuel_white@apple.com>
2610
2611         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2612         https://bugs.webkit.org/show_bug.cgi?id=124561
2613
2614         Reviewed by Chris Fleizach.
2615
2616         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2617
2618         * DumpRenderTree/AccessibilityUIElement.cpp:
2619         (uiElementCountForSearchPredicateCallback):
2620         (uiElementForSearchPredicateCallback):
2621         (AccessibilityUIElement::getJSClass):
2622         * DumpRenderTree/AccessibilityUIElement.h:
2623         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2624         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2625         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2626         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2627         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2628         (searchPredicateParameterizedAttributeForSearchCriteria):
2629         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2630         (AccessibilityUIElement::uiElementForSearchPredicate):
2631         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2632         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2633         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2634         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2635         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2636         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2637         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2638         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2639         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2640         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2641         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2642         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2643
2644 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2645
2646         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2647         https://bugs.webkit.org/show_bug.cgi?id=124714
2648
2649         Reviewed by Ryosuke Niwa.
2650
2651         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2652         (write_test_result):
2653         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2654         (TestFailure.write_failure):
2655         (FailureText):
2656         (FailureText.write_failure):
2657         (FailureAudio):
2658         (FailureAudio.write_failure):
2659         (FailureCrash.write_failure):
2660         (FailureMissingResult):
2661         (FailureTextMismatch):
2662         (FailureMissingImageHash.write_failure):
2663         (FailureMissingImage.write_failure):
2664         (FailureImageHashMismatch.write_failure):
2665         (FailureReftestMismatch.write_failure):
2666         (FailureReftestMismatchDidNotOccur.write_failure):
2667         (FailureMissingAudio):
2668         (FailureAudioMismatch):
2669
2670 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2671
2672         Remove the stderr_write attribute from StyleProcessorConfiguration
2673         https://bugs.webkit.org/show_bug.cgi?id=124703
2674
2675         Reviewed by Ryosuke Niwa.
2676
2677         Remove the stderr_write attribute from this class in checker and
2678         replace its use with calls to a logging module logger. We Should 
2679         use logging module instead of writing to stderr directly.
2680
2681         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2682         (check_webkit_style_configuration):
2683         (CheckerDispatcher.dispatch): Remove FIXME comment.
2684         (StyleProcessorConfiguration):
2685         (StyleProcessorConfiguration.__init__):
2686         (StyleProcessorConfiguration.write_style_error):
2687         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2688         There is an "ERROR" prefix in log messiges from now.
2689         (StyleProcessorConfigurationTest):
2690         (StyleProcessorConfigurationTest._style_checker_configuration):
2691         (StyleProcessorConfigurationTest.test_init):
2692         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2693         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2694         (StyleProcessor_EndToEndTest.with):
2695         (StyleProcessor_EndToEndTest.test_init):
2696         (StyleProcessor_EndToEndTest.test_process):
2697         (StyleProcessor_CodeCoverageTest.setUp):
2698         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2699         (DefaultStyleErrorHandler.__call__):
2700         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2701         There is an "ERROR" prefix in log messiges from now.
2702         (DefaultStyleErrorHandlerTest):
2703         (DefaultStyleErrorHandlerTest.setUp):
2704         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2705         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2706         (DefaultStyleErrorHandlerTest._check_initialized):
2707         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2708         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2709         (DefaultStyleErrorHandlerTest.test_line_numbers):
2710
2711 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2712
2713         Add JavaScript style checker and teach checker.py about .js files
2714         https://bugs.webkit.org/show_bug.cgi?id=125049
2715
2716         Reviewed by Joseph Pecoraro.
2717
2718         Add a JavaScript file type, extension, and checker (JSChecker).
2719         Use TextChecker for JavaScript tests, libraries, website resources,
2720         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2721
2722         Amended tests for TextChecker to reflect the rule above.
2723
2724         * Scripts/webkitpy/style/checker.py:
2725         (_all_categories): Add categories defined by JSChecker.
2726         (FileType): Add file type for JS and re-number the enum.
2727         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2728         (CheckerDispatcher._create_checker):
2729         Create a JSChecker or TextChecker depending on the file's path.
2730
2731         * Scripts/webkitpy/style/checker_unittest.py:
2732         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2733         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2734         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2735         that end in .js but should be checked with TextChecker.
2736         * Scripts/webkitpy/style/checkers/js.py: Added.
2737         (JSChecker):
2738         (JSChecker.__init__):
2739         (JSChecker.check):
2740         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2741         (JSTestCase):
2742         (JSTestCase.assertNoError):
2743         (JSTestCase.assertNoError.error_for_test):
2744         (JSTestCase.assertError):
2745         (JSTestCase.assertError.error_for_test):
2746         (JSTestCase.test_no_error):
2747         (JSTestCase.test_error):
2748
2749 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2750
2751         run-jsc-stress-tests always copies the VM
2752         https://bugs.webkit.org/show_bug.cgi?id=125092
2753
2754         Reviewed by Filip Pizlo.
2755
2756         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2757         bundle by default and do a full copy only when asked.
2758
2759         * Scripts/run-jsc-stress-tests:
2760
2761 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2762
2763         [Win] Port run-jsc-stress-tests
2764         https://bugs.webkit.org/show_bug.cgi?id=124801
2765
2766         Reviewed by Filip Pizlo.
2767
2768         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2769         command on Windows so that stress tests can run.
2770
2771 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2772
2773         Build fix after r159955
2774
2775         * Scripts/run-jsc-stress-tests:
2776
2777 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2778
2779         run-jsc-stress-tests should be able to package its tests and move them places
2780         https://bugs.webkit.org/show_bug.cgi?id=124549
2781
2782         Reviewed by Filip Pizlo.
2783
2784         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2785         of grep -i -q
2786         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2787         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2788         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2789         All of the generated scripts now are completely relative within the results directory. This allows
2790         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2791         tarball of the generated results directory. Also refactored several portions of the script into
2792         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2793
2794 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2795
2796         [ATK] Support active state for listbox elements.
2797         https://bugs.webkit.org/show_bug.cgi?id=125009
2798
2799         Reviewed by Chris Fleizach.
2800
2801         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2802
2803         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2804         (AccessibilityUIElement::isSelectedOptionActive):
2805         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2806         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2807         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2808         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2809         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2810         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2811         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2812         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2813
2814 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2815
2816         Unreviewed GTK gardening.
2817
2818         * Scripts/run-gtk-tests:
2819         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2820
2821 2013-12-01  Dan Bernstein  <mitz@apple.com>
2822
2823         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2824         https://bugs.webkit.org/show_bug.cgi?id=125046
2825
2826         Reviewed by Sam Weinig.
2827
2828         * MiniBrowser/mac/AppDelegate.m:
2829         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2830         (-[BrowserAppDelegate openDocument:]): Ditto.
2831         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2832         interface to the implementation.
2833         * MiniBrowser/mac/WK2BrowserWindowController.m:
2834         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2835         the policy client.
2836         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2837         Moved policy client implementation into this delegate method.
2838         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2839         Ditto.
2840         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2841         Ditto.
2842
2843 2013-12-01  Dan Bernstein  <mitz@apple.com>
2844
2845         [Mac] Remove the MiniBrowser injected bundle
2846         https://bugs.webkit.org/show_bug.cgi?id=125041
2847
2848         Reviewed by Anders Carlsson.
2849
2850         It had no ops!
2851
2852         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2853         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2854         * MiniBrowser/mac/AppDelegate.m:
2855         (-[BrowserAppDelegate init]):
2856         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2857         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2858
2859 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2860
2861         check-webkit-style should check for extraneous newline between config.h and primary header.
2862         https://bugs.webkit.org/show_bug.cgi?id=124821
2863
2864         Reviewed by Csaba Osztrogonác.
2865
2866         * Scripts/webkitpy/style/checkers/cpp.py:
2867         (check_include_line):
2868         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2869         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2870         (OrderOfIncludesTest):
2871         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2872
2873 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2874
2875         test-webkit-scripts should show the failing tests and use an appropriate exit code
2876         https://bugs.webkit.org/show_bug.cgi?id=124840
2877
2878         Reviewed by Ryosuke Niwa.
2879
2880         A fixme in test-webkit-scripts asked that the script should display success or failiure
2881         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2882
2883         * Scripts/test-webkit-scripts:
2884         (ScriptsTester.run_test_script):
2885         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2886         because at this point we don't need to pass on more information other than success or failiure.
2887         (ScriptsTester.main):
2888         The return values are now stored for each script and when all tests have completed successfully,
2889         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2890
2891 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2892
2893         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2894         https://bugs.webkit.org/show_bug.cgi?id=124923
2895
2896         Reviewed by Mario Sanchez Prada.
2897
2898         Added missing implementation of isAttributeSettable. Using
2899         ATK_STATE_EDITABLE for checking whether attribute is settable.
2900
2901         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2902         (AccessibilityUIElement::isAttributeSettable):
2903         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2904         (WTR::AccessibilityUIElement::isAttributeSettable):
2905
2906 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2907
2908         Unreviewed, rolling out r159839.
2909         http://trac.webkit.org/changeset/159839
2910         https://bugs.webkit.org/show_bug.cgi?id=124974
2911
2912         run-webkit-tests doesn't generate pretty diff (Requested by
2913         Ossy on #webkit).
2914
2915         * Scripts/webkitpy/common/prettypatch.py:
2916         (PrettyPatch.__init__):
2917         (PrettyPatch.pretty_diff):
2918         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2919         (TestResultWriter.create_text_diff_and_write_result):
2920         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2921         (summarize_results):
2922         * Scripts/webkitpy/port/base.py:
2923         (Port.__init__):
2924         (Port.pretty_patch_available):
2925         (Port.check_pretty_patch):
2926         (Port.variable):
2927         (Port.variable.pretty_patch_text):
2928         * Scripts/webkitpy/port/base_unittest.py:
2929         (PortTest.test_pretty_patch_os_error):
2930         (PortTest.test_pretty_patch_script_error):
2931
2932 2013-11-28  Antti Koivisto  <antti@apple.com>
2933
2934         Remove feature: CSS variables
2935         https://bugs.webkit.org/show_bug.cgi?id=114119
2936
2937         Reviewed by Andreas Kling.
2938
2939         * Scripts/webkitperl/FeatureList.pm:
2940
2941 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2942
2943         Move PrettyPatch related code to prettypatch.py
2944         https://bugs.webkit.org/show_bug.cgi?id=124937
2945
2946         Reviewed by Ryosuke Niwa.
2947
2948         This code seems to have a better place here than in Port, since PrettyPatch already knows
2949         pretty_patch_path, and this also unifies the usage of PrettyPatch
2950
2951         * Scripts/webkitpy/common/prettypatch.py:
2952         (PrettyPatch.__init__):
2953         (PrettyPatch.pretty_diff):
2954         (PrettyPatch):
2955         (PrettyPatch.pretty_patch_available):
2956         (PrettyPatch.check_pretty_patch):
2957         (PrettyPatch.pretty_patch_text):
2958         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2959         (TestResultWriter.create_text_diff_and_write_result):
2960         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2961         (summarize_results):
2962         * Scripts/webkitpy/port/base.py:
2963         (Port.__init__):
2964         (Port.wdiff_available):
2965         (Port.check_image_diff):
2966         (Port.wdiff_text):
2967         * Scripts/webkitpy/port/base_unittest.py:
2968         (PortTest.test_pretty_patch_os_error):
2969         (PortTest.test_pretty_patch_script_error):
2970
2971 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2972
2973         Checkout should own the scm object in Host
2974         https://bugs.webkit.org/show_bug.cgi?id=124943
2975
2976         Reviewed by Ryosuke Niwa.
2977
2978         * Scripts/webkitpy/common/host.py:
2979         (Host.__init__):
2980         (Host.initialize_scm):
2981         (Host.scm):
2982
2983 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2984
2985         Do bytecode validation as part of testing
2986         https://bugs.webkit.org/show_bug.cgi?id=124913
2987
2988         Reviewed by Oliver Hunt.
2989
2990         * Scripts/run-jsc-stress-tests:
2991
2992 2013-11-27  Andres Gomez  <agomez@igalia.com>
2993
2994         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2995         https://bugs.webkit.org/show_bug.cgi?id=124940
2996
2997         Reviewed by Martin Robinson.
2998
2999         xserver-font-utils is needed for building gtk port dependencies
3000         with jhbuild.
3001
3002         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
3003         dependecies.
3004
3005 2013-11-27  Andres Gomez  <agomez@igalia.com>
3006
3007         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
3008         https://bugs.webkit.org/show_bug.cgi?id=124938
3009
3010         Reviewed by Philippe Normand.
3011
3012         Added needed git dependency for building the gtk port with
3013         jhbuild. Also, the dependencies needed for building the gtk port
3014         are now sorted alphabetically.
3015
3016         * gtk/install-dependencies: Added git as jhbuild dependency and
3017         sorted dependencies alphabetically.
3018
3019 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
3020
3021         run_webkit_tests.py: error: no such option: --wincairo
3022         https://bugs.webkit.org/show_bug.cgi?id=124927
3023
3024         Reviewed by Ryosuke Niwa.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
3027         the layout testing on wincairo, so it is turned off.
3028
3029 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
3030
3031         Nix upstreaming - Adding build files and supporting scripts
3032         https://bugs.webkit.org/show_bug.cgi?id=118367
3033
3034         Reviewed by Ryosuke Niwa.
3035
3036         * Scripts/build-webkit:
3037         * Scripts/run-nix-tests: Added.
3038         * Scripts/run-webkit-tests:
3039         * Scripts/update-webkit-libs-jhbuild:
3040         * Scripts/update-webkitnix-libs: Added.
3041         * Scripts/webkitdirs.pm:
3042         (determineArchitecture):
3043         (argumentsForConfiguration):
3044         (jscProductDir):
3045         (builtDylibPathForName):
3046         (determineIsNix):
3047         (isNix):
3048         (isAppleWebKit):
3049         (launcherPath):
3050         (launcherName):
3051         (checkRequiredSystemConfig):
3052         (copyInspectorFrontendFiles):
3053         (jhbuildWrapperPrefixIfNeeded):
3054         (buildCMakeProjectOrExit):
3055         (cmakeBasedPortName):
3056         * Scripts/webkitpy/common/config/ports.py:
3057         (DeprecatedPort.port):
3058         (EflWK2Port.build_webkit_command):
3059         (NixPort):
3060         (NixPort.build_webkit_command):
3061         * Scripts/webkitpy/port/factory.py:
3062         (platform_options):
3063         (PortFactory):
3064         * Scripts/webkitpy/port/nix.py: Added.
3065         (NixPort):
3066         (NixPort._wk2_port_name):
3067         (NixPort.determine_full_port_name):
3068         (NixPort.__init__):
3069         (NixPort._port_flag_for_scripts):
3070         (NixPort.setup_test_run):
3071         (NixPort.setup_environ_for_server):
3072         (NixPort.default_timeout_ms):
3073         (NixPort.clean_up_test_run):
3074         (NixPort._generate_all_test_configurations):
3075         (NixPort._path_to_driver):
3076         (NixPort._path_to_image_diff):
3077         (NixPort._image_diff_command):
3078         (NixPort._search_paths):
3079         (NixPort.show_results_html_file):
3080         (NixPort._port_specific_expectations_files):
3081         (NixPort.default_baseline_search_path):
3082         * Scripts/webkitpy/port/nix_unittest.py: Added.
3083         (NixPortTest):
3084         (NixPortTest._assert_search_path):
3085         (NixPortTest._assert_expectations_files):
3086         (NixPortTest.test_baseline_search_path):
3087         (NixPortTest.test_expectations_files):
3088         (NixPortTest.test_default_timeout_ms):
3089         * jhbuild/jhbuild-wrapper:
3090         (determine_platform):
3091         * nix/common.py: Added.
3092         (script_path):
3093         (top_level_path):
3094         * nix/jhbuild.modules: Added.
3095         * nix/jhbuildrc: Added.
3096
3097 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3098
3099         Record subtest values in Dromaeo tests
3100         https://bugs.webkit.org/show_bug.cgi?id=124498
3101
3102         Reviewed by Andreas Kling.
3103
3104         Supported parsing subtest results.
3105
3106         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
3107         which contains a dictionary with its name and an ordered list of subtest's metrics.
3108         (PerfTest.__init__): Initialize _metrics as a list.
3109         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
3110         (PerfTest._run_with_driver):
3111         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
3112
3113         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3114         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
3115         (TestPerfTest.test_parse_output): Ditto.
3116         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
3117         assertions to ensure subtest results are parsed properly.
3118         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
3119         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
3120
3121         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3122         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
3123         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
3124         adding new results.
3125
3126         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3127         (TestWithSubtestsData): Added.
3128         (TestDriver.run_test):
3129         (MainTest.test_run_test_with_subtests): Added.
3130
3131 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         Enable HTML template element on Windows ports
3134         https://bugs.webkit.org/show_bug.cgi?id=124758
3135
3136         Reviewed by Andreas Kling.
3137
3138         * Scripts/webkitperl/FeatureList.pm:
3139
3140 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3141
3142         Remove replay performance tests as it's not actively maintained
3143         https://bugs.webkit.org/show_bug.cgi?id=124764
3144
3145         Reviewed by Andreas Kling.
3146
3147         Removed the feature.
3148
3149         * Scripts/webkitpy/performance_tests/perftest.py:
3150         (SingleProcessPerfTest.__init__):
3151         (PerfTestFactory):
3152         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3153         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3154         (PerfTestsRunner._parse_args):
3155         (PerfTestsRunner._collect_tests):
3156         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3157         (MainTest.test_collect_tests_with_ignored_skipped_list):
3158         (MainTest.test_default_args):
3159         * Scripts/webkitpy/thirdparty/__init__.py:
3160         (AutoinstallImportHook.find_module):
3161         (AutoinstallImportHook._install_unittest2):
3162         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3163         (ThirdpartyTest.test_imports):
3164
3165 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
3166
3167         Enable aggressive DFG validation in testing
3168         https://bugs.webkit.org/show_bug.cgi?id=124911
3169
3170         Rubber stamped by Ryosuke Niwa.
3171         
3172         This enables validation testing in non-concurrent-JIT runs.
3173
3174         * Scripts/run-jsc-stress-tests:
3175
3176 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3177
3178         Moved methods which belong to Checkout into checkout.py
3179         https://bugs.webkit.org/show_bug.cgi?id=124889
3180
3181         Reviewed by Ryosuke Niwa.
3182
3183         * Scripts/webkitpy/common/checkout/checkout.py:
3184         (Checkout.scripts_directory):
3185         (Checkout):
3186         (Checkout.script_path):
3187         (Checkout.commit_message_for_this_commit):
3188         (Checkout.apply_patch):
3189         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3190         (test_commit_message_for_this_commit):
3191         (CheckoutTest.test_apply_patch):
3192         * Scripts/webkitpy/common/checkout/scm/scm.py:
3193         (SCM.absolute_path):
3194         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3195         (SCMTest._setup_webkittools_scripts_symlink):
3196         * Scripts/webkitpy/common/checkout/scm/svn.py:
3197         (SVN.create_patch):
3198
3199 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
3200
3201         [EFL] Use Config mode of find_package for EFL 1.8
3202         https://bugs.webkit.org/show_bug.cgi?id=124555
3203
3204         Reviewed by Gyuyoung Kim.
3205
3206         * MiniBrowser/efl/CMakeLists.txt:
3207         Added optional config mode and made version requirement optional.
3208
3209 2013-11-25  Andres Gomez  <agomez@igalia.com>
3210
3211         [GTK] Search functionality in MiniBrowser provides feedback on search fail
3212         https://bugs.webkit.org/show_bug.cgi?id=122681
3213
3214         Reviewed by Mario Sanchez Prada.
3215
3216         When using the search functionality in MiniBrowser, if the search
3217         fails, the entry background color gets red to report the user
3218         about the failing condition. When the entry is cleaned or the
3219         search is again succesful the background turns back to its
3220         original color.
3221
3222         * MiniBrowser/gtk/BrowserSearchBar.c:
3223         (setFailedStyleForEntry): Added.
3224         (doSearch): Sets the entry's background to its original style if
3225         there is no text to search.
3226         (findControllerFailedToFindTextCallback): Added.
3227         (findControllerFoundTextCallback): Added.
3228         (browser_search_bar_init): Creates and adds a new CSS provider to
3229         the text entry so we can change its style based on the success
3230         condition of the search.
3231         (browserSearchBarFinalize): Frees the new CSS provider.
3232         (browser_search_bar_new): Connects the two new handlers to the
3233         "failed-to-find-text" and "found-text" signals emitted by the
3234         WebKitFindController.
3235
3236 2013-11-25  Dan Bernstein  <mitz@apple.com>
3237
3238         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
3239         https://bugs.webkit.org/show_bug.cgi?id=124850
3240
3241         Reviewed by Brady Eidson.
3242
3243         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
3244
3245         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3246         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3247         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3248         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3249         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3250         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3251         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3252
3253 2013-11-25  Commit Queue  <commit-queue@webkit.org>
3254
3255         Unreviewed, rolling out r159752 and r159754.
3256         http://trac.webkit.org/changeset/159752
3257         http://trac.webkit.org/changeset/159754
3258         https://bugs.webkit.org/show_bug.cgi?id=124847
3259
3260         Broke linux test bots. (Requested by mhahnenberg on #webkit).
3261
3262         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3263         * Scripts/run-javascriptcore-tests:
3264         * Scripts/run-jsc-stress-tests:
3265
3266 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3267
3268         Followup fix after r159752
3269
3270         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
3271
3272 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3273
3274         run-jsc-stress-tests should be able to package its tests and move them places
3275         https://bugs.webkit.org/show_bug.cgi?id=124549
3276
3277         Reviewed by Filip Pizlo.
3278
3279         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
3280         of grep -i -q
3281         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
3282         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
3283         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
3284         All of the generated scripts now are completely relative within the results directory. This allows 
3285         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
3286         tarball of the generated results directory. Also refactored several portions of the script into 
3287         separate functions to make it easier to run them conditionally depending on which mode we're running in.
3288
3289 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
3290
3291         EWS creates 0 byte sized log files
3292         https://bugs.webkit.org/show_bug.cgi?id=107606
3293
3294         Reviewed by Ryosuke Niwa.
3295
3296         There was a modification in r138264, that tried to make less log,
3297         because some of the messeges were duplicated. After this the EWS
3298         created the log file (with the same name as the bugID) but doesn't
3299         write anything into it, even if there were errors during the build.
3300         From now only creates the log file only if there is some error.
3301
3302         * Scripts/webkitpy/tool/bot/queueengine.py:
3303         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3304         there is nothing to log. Open the log file only if a ScriptError was raised to
3305         avoid to make empty log files for bugs.
3306         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3307         because of changes in r138264. Teeing is used for locally testing purposes and
3308         this feature is not used anymore.
3309         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
3310         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3311         change.
3312         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3313         (LoggingDelegate): The order of the callbacks was changed by this patch.
3314         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
3315         so we have to update this test.
3316         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
3317         this patch.
3318         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3319         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3320         to be able to handle it in QueueEngine.run. Without this change, the existing
3321         exception handler never run (the process_work_item method never raise ScriptError)
3322         We can get the error message only from the ScriptError at this point.
3323
3324 2013-11-22  Dean Jackson  <dino@apple.com>
3325
3326         Speculative Mountain Lion build fix.
3327
3328         * MiniBrowser/mac/AppDelegate.m:
3329         (-[BrowserAppDelegate openDocument:]):
3330
3331 2013-11-22  Anders Carlsson  <andersca@apple.com>
3332
3333         Fix Mountain Lion bug.
3334
3335         * MiniBrowser/mac/AppDelegate.m:
3336         (-[BrowserAppDelegate openDocument:]):
3337
3338 2013-11-22  Anders Carlsson  <andersca@apple.com>
3339
3340         MiniBrowser should use the blocks-based NSOpenPanel API
3341         https://bugs.webkit.org/show_bug.cgi?id=124786
3342
3343         Reviewed by Simon Fraser.
3344
3345         * MiniBrowser/mac/AppDelegate.m:
3346         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3347         Account for windows that don't have a BrowserWindowController.
3348
3349         (-[BrowserAppDelegate openDocument:]):
3350
3351 2013-11-22  Commit Queue  <commit-queue@webkit.org>
3352
3353         Unreviewed, rolling out r159690.
3354         http://trac.webkit.org/changeset/159690
3355         https://bugs.webkit.org/show_bug.cgi?id=124782
3356
3357         Broke webkitpy tests (Requested by ap on #webkit).
3358
3359         * Scripts/webkitpy/tool/bot/queueengine.py:
3360         (QueueEngine.run):
3361         (QueueEngine._open_work_log):
3362         (QueueEngine._ensure_work_log_closed):
3363         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3364         (AbstractEarlyWarningSystem.review_patch):
3365
3366 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
3367
3368         EWS creates 0 byte sized log files
3369         https://bugs.webkit.org/show_bug.cgi?id=107606
3370
3371         Reviewed by Ryosuke Niwa.
3372
3373         There was a modification in r138264, that tried to make less log, 
3374         because some of the messeges were duplicated. After this the EWS 
3375         created the log file (with the same name as the bugID) but doesn't 
3376         write anything into it, even if there were errors during the build. 
3377         From now only creates the log file only if there is some error.
3378
3379         * Scripts/webkitpy/tool/bot/queueengine.py:
3380         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3381         there is nothing to log. Open the log file only if a ScriptError was raised to
3382         avoid to make empty log files for bugs.
3383         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3384         because of changes in r138264. Teeing is used for locally testing purposes and
3385         this feature is not used anymore.
3386         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
3387         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3388         change.
3389         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3390         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3391         to be able to handle it in QueueEngine.run. Without this change, the existing
3392         exception handler never run (the process_work_item method never raise ScriptError)
3393         We can get the error message only from the ScriptError at this point.
3394
3395 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3396
3397         Remove ENABLE_WORKERS
3398         https://bugs.webkit.org/show_bug.cgi?id=105784
3399
3400         Reviewed by Darin Adler.
3401
3402         * Scripts/webkitperl/FeatureList.pm:
3403
3404 2013-11-21  Darin Adler  <darin@apple.com>
3405
3406         Try to fix buildbot Dashboard for people who have not hidden anything.
3407
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3409         Add a null check for hidden platforms.
3410
3411 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3412
3413         Remove chrome/chromium related things from webkitpy.
3414         https://bugs.webkit.org/show_bug.cgi?id=124493
3415
3416         Reviewed by Darin Adler.
3417
3418         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3419         (PortTest.assert_mock_port_works):
3420         * Scripts/webkitpy/port/base.py:
3421         (Port.to.setup_environ_for_server):
3422         * Scripts/webkitpy/port/mac_unittest.py:
3423         (test_tests_for_other_platforms):
3424         * Scripts/webkitpy/port/mock_drt.py:
3425         (MockTestShell.output_for_test):
3426         * Scripts/webkitpy/tool/bot/irc_command.py:
3427         (Restart.execute):
3428         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3429         (IRCBotTest.test_help):
3430
3431 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3432
3433         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3434         https://bugs.webkit.org/show_bug.cgi?id=124717
3435
3436         Reviewed by Ryosuke Niwa.
3437
3438         * Scripts/webkitpy/style/filereader.py:
3439         (TextFileReader.process_file):
3440         * Scripts/webkitpy/style/filereader_unittest.py:
3441         (TextFileReaderTest.test_process_file__does_not_exist):
3442
3443 2013-11-21  Mark Rowe  <mrowe@apple.com>
3444
3445         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3446
3447         All modern versions of Xcode set it appropriately for our needs.
3448
3449         Reviewed by Alexey Proskuryakov.
3450
3451         * MiniBrowser/Configurations/Base.xcconfig:
3452         * WebKitTestRunner/Configurations/Base.xcconfig:
3453
3454 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3455
3456         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3457         https://bugs.webkit.org/show_bug.cgi?id=124676
3458
3459         Reviewed by Daniel Bates.
3460
3461         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3462         elements when there were more then one occurrence of that argument.
3463         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3464         {b, a}, when it should be {b, c}.
3465
3466         * Scripts/webkitdirs.pm:
3467         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3468         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3469         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3470
3471 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3472
3473         Update build-webkit after r159550.
3474
3475         * Scripts/webkitperl/FeatureList.pm:
3476
3477 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3478
3479         Bring a new bot online, replacing the previous ones.
3480         
3481         Unreviewed.
3482
3483         * BuildSlaveSupport/build.webkit.org-config/config.json:
3484
3485 2013-11-21  Dean Jackson  <dino@apple.com>
3486
3487         Don't fetch hidden platforms on build.webkit.org/dashboard
3488         https://bugs.webkit.org/show_bug.cgi?id=124750
3489
3490         Reviewed by Tim Horton.
3491
3492         If a platform is hidden, don't fetch its data. If it
3493         becomes unhidden, try to fetch immediately (unless
3494         you've recently fetched).
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3498
3499 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3500
3501         Unreviewed, rolling out r159633.
3502         http://trac.webkit.org/changeset/159633
3503         https://bugs.webkit.org/show_bug.cgi?id=124726
3504
3505         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3506
3507         * Scripts/webkitpy/style/checker.py:
3508         (check_webkit_style_configuration):
3509         (CheckerDispatcher.dispatch):
3510         (StyleProcessorConfiguration):
3511         (StyleProcessorConfiguration.__init__):
3512         (StyleProcessorConfiguration.write_style_error):
3513
3514 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3515
3516         Remove the stderr_write attribute from StyleProcessorConfiguration.
3517         https://bugs.webkit.org/show_bug.cgi?id=124703
3518
3519         Reviewed by Brent Fulgham.
3520
3521         * Scripts/webkitpy/style/checker.py:
3522         (check_webkit_style_configuration):
3523         (CheckerDispatcher.dispatch):
3524         (StyleProcessorConfiguration):
3525         (StyleProcessorConfiguration.__init__):
3526         (StyleProcessorConfiguration.write_style_error):
3527
3528 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3529
3530         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3531         https://bugs.webkit.org/show_bug.cgi?id=124623
3532
3533         Removed the dependency on test objects from results JSON generation.
3534         This allows single test.run to return metrics for multiple tests
3535
3536         Reviewed by Antti Koivisto.
3537
3538         * Scripts/webkitpy/performance_tests/perftest.py:
3539         (PerfTestMetric.__init__): Takes the test path and test name.
3540         (PerfTestMetric.path): Added.
3541         (PerfTestMetric.test_file_name): Added.
3542         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3543         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3544         The path is going to have the names of subtests at the end once we support them.
3545
3546         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3547         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3548         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3549         (TestPerfTestMetric.test_has_values): Ditto.
3550         (TestPerfTestMetric.test_append): Ditto.
3551
3552         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3553         (_generate_results_dict): Only use metrics.
3554         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3555
3556 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3557
3558         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3559         https://bugs.webkit.org/show_bug.cgi?id=124697
3560
3561         Reviewed by Ryosuke Niwa.
3562
3563         * Scripts/webkitdirs.pm:
3564         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3565         before trying to access to the first element.
3566
3567 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3568
3569         [GTK] Mark all deprecated symbols in GObject DOM bindings
3570         https://bugs.webkit.org/show_bug.cgi?id=124406
3571
3572         Reviewed by Gustavo Noronha Silva.
3573
3574         * Scripts/webkitpy/style/checker.py: Add special case for
3575         WebKitDOMDeprecated.
3576         * gtk/generate-gtkdoc:
3577         (get_webkit2_options): Use the prefix of the methods as namespace,
3578         since this is what gtkdoc expects to sort the index.
3579         (get_webkit1_options): Ditto.
3580         (get_webkitdom_options): Ditto.
3581         * gtk/generate-webkitdom-doc-files:
3582         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3583         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3584         the documentation for classes that are deprecated because they
3585         have been removed.
3586         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3587         for deleted classes too.
3588         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3589         deprecated symbols using the given symbols file.
3590         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3591         deleted class corresponding to the given function.
3592         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3593         dictionary of deprecated symbols for every class.
3594         (WebKitDOMDocGeneratorSections.write_section): Add also the
3595         deprecated symbols in every section.
3596         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3597         sections for deleted classes too.
3598
3599 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3600
3601         check-webkit-style should support C++11 rvalue references.
3602         https://bugs.webkit.org/show_bug.cgi?id=123406
3603
3604         Reviewed by Brent Fulgham.
3605
3606         * Scripts/webkitpy/style/checkers/cpp.py:
3607         (check_style):
3608         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3609         (Cpp11StyleTest):
3610         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3611
3612 2013-11-20  Dean Jackson  <dino@apple.com>
3613
3614         Allow settings to be shown/hidden on build.webkit.org/dashboard
3615         https://bugs.webkit.org/show_bug.cgi?id=124694
3616
3617         Reviewed by Tim Horton.
3618
3619         In preparation for more options/buttons, allow the page to
3620         show or hide all the interactive things using a little gear icon
3621         in the top left corner.
3622
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3625         (Settings.prototype.toggleSettingsDisplay):
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3627         (div.cellButton.hide):
3628         (div.cellButton.unhide):
3629         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3630         (.settings):
3631         (.settings:hover):
3632         (.settings-visible .settings):
3633
3634 2013-11-20  Dean Jackson  <dino@apple.com>
3635
3636         No need to base64 SVG on build.webkit.org/dashboard
3637         https://bugs.webkit.org/show_bug.cgi?id=124687
3638
3639         Reviewed by Tim Horton.
3640
3641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3642         (.status-line.good .bubble.pictogram):
3643
3644 2013-11-20  Dean Jackson  <dino@apple.com>
3645
3646         Make links look more like links on build.webkit.org/dashboard
3647         https://bugs.webkit.org/show_bug.cgi?id=124686
3648
3649         Reviewed by Tim Horton.
3650
3651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3652         (.queue-view .queueLabel:hover):
3653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3654         (.status-line.linked .label:hover):
3655
3656 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3657
3658         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3659         https://bugs.webkit.org/show_bug.cgi?id=124581
3660
3661         Reviewed by Daniel Bates.
3662
3663         Some subroutines are replicating code from checkForArgument**
3664         functions instead of reusing them as is being don