5ca2904669b5c118f39cd48e4494c5726b8d96c0
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [CMake] Add dependencies for Visual Studio projects
6         https://bugs.webkit.org/show_bug.cgi?id=53773
7
8         Add a WebKit dependecy to WinCELauncher, so CMake can 
9         generate the correct build order for the solution.
10
11         * CMakeListsWinCE.txt:
12
13 2011-02-06  Andreas Kling  <kling@webkit.org>
14
15         Reviewed by Antonio Gomes.
16
17         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
18         https://bugs.webkit.org/show_bug.cgi?id=53869
19
20         * MiniBrowser/qt/BrowserView.cpp:
21         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
22         * MiniBrowser/qt/BrowserWindow.cpp:
23         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
24         * MiniBrowser/qt/BrowserWindow.h:
25
26 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
27
28         Reviewed by Dan Bernstein.
29
30         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
31         https://bugs.webkit.org/show_bug.cgi?id=42690
32         <rdar://problem/8213851>
33
34         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
35         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
36         (WTR::InjectedBundlePage::willSendRequestForFrame):
37         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
38         (WTR::LayoutTestController::LayoutTestController):
39         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
40         (WTR::LayoutTestController::willSendRequestReturnsNull):
41         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
42
43 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
44
45         Unreviewed, rolling out r77720.
46         http://trac.webkit.org/changeset/77720
47         https://bugs.webkit.org/show_bug.cgi?id=53854
48
49         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
50         #webkit).
51
52         * Scripts/webkitpy/common/system/executive.py:
53
54 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
55
56         Unreviewed, rolling out r77725.
57         http://trac.webkit.org/changeset/77725
58         https://bugs.webkit.org/show_bug.cgi?id=53844
59
60         It broke Qt minimal build (Requested by Ossy_ on #webkit).
61
62         * QtTestBrowser/launcherwindow.cpp:
63         (LauncherWindow::createChrome):
64         * QtTestBrowser/launcherwindow.h:
65         (WindowOptions::WindowOptions):
66         * QtTestBrowser/main.cpp:
67         (LauncherApplication::handleUserOptions):
68
69 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
70
71         Reviewed by Adam Barth.
72
73         [GTK] plugins/plugin-document-back-forward.html fails
74         https://bugs.webkit.org/show_bug.cgi?id=53833
75
76         Add the new "alert on load" functionality for the Unix version of the
77         test plugin. This functionality was originally introduced in r77706.
78
79         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
80         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
81
82 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
83
84         Reviewed by Andreas Kling.
85
86         Local Storage settings can be enable/disable from "Develop" menu
87         https://bugs.webkit.org/show_bug.cgi?id=52296
88
89         * QtTestBrowser/launcherwindow.cpp:
90         (LauncherWindow::createChrome):
91         (LauncherWindow::toggleLocalStorage):
92         (LauncherWindow::toggleOfflineStorageDatabase):
93         (LauncherWindow::toggleOfflineWebApplicationCache):
94         (LauncherWindow::setOfflineStorageDefaultQuota):
95         * QtTestBrowser/launcherwindow.h:
96         (WindowOptions::WindowOptions):
97         * QtTestBrowser/main.cpp:
98         (LauncherApplication::handleUserOptions):
99
100 2011-02-04  Tony Chang  <tony@chromium.org>
101
102         Reviewed by Eric Seidel.
103
104         get test-webkitpy running on win32 python
105         https://bugs.webkit.org/show_bug.cgi?id=53822
106
107         The test harness crashes with a WindowsError because it can't find
108         'svn' when using subprocess.Popen.  This gets us past the error
109         so we can see the failing tests on the Chromium Win Release Tests
110         bot.
111
112         * Scripts/webkitpy/common/system/executive.py:
113
114 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
115
116         Reviewed by Gustavo Noronha Silva.
117
118         [GTK] fast/events/pagehide-timeout.html fails
119         https://bugs.webkit.org/show_bug.cgi?id=53771
120
121         Add knowledge of the document browser cache model the DRT. When resetting
122         WebKit settings to consistent values between tests, default to the document
123         browser cache model.
124
125         * DumpRenderTree/gtk/DumpRenderTree.cpp:
126         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
127         cache model between tests.
128         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
129         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
130         document browser cache model.
131
132 2011-02-04  Adam Barth  <abarth@webkit.org>
133
134         Reviewed by Eric Seidel.
135
136         PluginDocuments don't create widgets for plugins on back/forward
137         https://bugs.webkit.org/show_bug.cgi?id=53474
138
139         Teach the test plugin how to call alert on load.
140
141         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
142         (NPP_New):
143
144 2011-02-04  Adam Roben  <aroben@apple.com>
145
146         Add a test case for encode/decode of FormData/FormDataElement
147
148         If the fix made in r77401 is broken, this new test will crash.
149
150         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
151
152         Reviewed by Sam Weinig.
153
154         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
155         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
156
157         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
158         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
159         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
160         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
161         form, an return the session state data.
162         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
163         and restore it into another WKPage.
164
165         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
169         * TestWebKitAPI/win/copy-resources.cmd:
170         Added new files.
171
172 2011-02-04  Adam Roben  <aroben@apple.com>
173
174         Move code to run JavaScript tests into its own files
175
176         This will allow other tests to use this mechanism.
177
178         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
179         world
180
181         Reviewed by Sam Weinig.
182
183         * TestWebKitAPI/JavaScriptTest.cpp: Added.
184         * TestWebKitAPI/JavaScriptTest.h: Added.
185         Moved code here...
186
187         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
188
189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
190         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
191         Added the new files.
192
193 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
194
195         Reviewed by Mihai Parparita.
196
197         merge test expectations for chromium, chromium-gpu. The
198         chromium-gpu port will no longer maintain its own
199         test expectations file.
200
201         Also add in a graphics_type() call on the port object to
202         determine what graphics type to use in the test configuration,
203         and log the configuration as a config setting.
204
205         https://bugs.webkit.org/show_bug.cgi?id=53562
206
207         * Scripts/webkitpy/layout_tests/port/base.py:
208         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
209         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
210         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
211
212 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
213
214         Reviewed by Pavel Feldman.
215
216         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
217         https://bugs.webkit.org/show_bug.cgi?id=53781
218
219         * Scripts/check-inspector-strings:
220
221 2011-02-04  Adam Roben  <aroben@apple.com>
222
223         Include the crashing function in the link to a crash log on Mac
224
225         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
226         function that crashed on Mac
227
228         Reviewed by David Kilzer.
229
230         * Scripts/old-run-webkit-tests:
231         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
232         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
233         the crash log.
234
235 2011-02-04  Adam Roben  <aroben@apple.com>
236
237         Link to Mac crash logs from results.html
238
239         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
240         results.html
241
242         Reviewed by David Kilzer.
243
244         * Scripts/old-run-webkit-tests:
245         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
246         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
247
248 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
249
250         Reviewed by Dan Bernstein.
251
252         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
253         https://bugs.webkit.org/show_bug.cgi?id=52897
254         <rdar://problem/8898294>
255
256         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
257         (WTR::InjectedBundlePage::InjectedBundlePage):
258         (WTR::InjectedBundlePage::willSendRequestForFrame):
259         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
260
261 2011-02-03  Ivan Krstić  <ike@apple.com>
262
263         Unreviewed.
264
265         Adding myself to committers.py.
266
267         * Scripts/webkitpy/common/config/committers.py:
268
269 2011-02-03  James Kozianski  <koz@chromium.org>
270
271         Reviewed by Dimitri Glazkov.
272
273         Add navigator.registerProtocolHandler behind a flag.
274         https://bugs.webkit.org/show_bug.cgi?id=52609
275
276         * Scripts/build-webkit:
277
278 2011-02-03  Hayato Ito  <hayato@chromium.org>
279
280         Reviewed by Eric Seidel.
281
282         [NRWT] Remove TestArgs class, which is wrongly used.
283
284         https://bugs.webkit.org/show_bug.cgi?id=53063
285
286         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
287         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
288         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
289         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
290         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
291         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
292
293 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
294
295         Reviewed by Kenneth Russell.
296
297         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
298         https://bugs.webkit.org/show_bug.cgi?id=53714
299
300         * Scripts/build-webkit: change --3d-canvas build option
301           to set ENABLE_WEBGL
302
303 2011-02-03  Hayato Ito  <hayato@chromium.org>
304
305         Reviewed by Tony Chang.
306
307         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
308         move _run_single_test() and _process_output() functions from
309         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
310
311         This is clean up and acts as a preparation for elimination of test_types/*
312         classes. These classes will move to the single_test_runner module introduced
313         in this patch.
314
315         https://bugs.webkit.org/show_bug.cgi?id=53004
316
317         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
318         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
319         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
320         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
321         * Scripts/webkitpy/layout_tests/port/base.py:
322         * Scripts/webkitpy/layout_tests/port/chromium.py:
323         * Scripts/webkitpy/layout_tests/port/dryrun.py:
324         * Scripts/webkitpy/layout_tests/port/test.py:
325         * Scripts/webkitpy/layout_tests/port/webkit.py:
326         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
327         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
328         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
329
330 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
331
332         Unreviewed, build fix.
333
334         Delete a line that was accidentally missed in r77586; without it
335         there is still a race between the two threads.
336
337         https://bugs.webkit.org/show_bug.cgi?id=51572
338
339         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
340
341 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
342
343         Reviewed by Tony Chang.
344
345         nrwt: handle "broken pipe" notifications from DRT more cleanly.
346
347         https://bugs.webkit.org/show_bug.cgi?id=52927
348
349         * Scripts/webkitpy/layout_tests/port/server_process.py:
350         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
351
352 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
353
354         Reviewed by Kenneth Russell.
355
356         Update, resubmit change to bug 51572. I think the race that was
357         fixed in r76703 caused the hang that caused us to roll this
358         patch out before, so I'd like to try again.
359
360         https://bugs.webkit.org/show_bug.cgi?id=51572
361
362         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
363         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
364
365 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
366
367         Unreviewed.
368
369         Adding myself to committers.py.
370
371         * Scripts/webkitpy/common/config/committers.py:
372
373 2011-02-03  Adam Roben  <aroben@apple.com>
374
375         Include the crashing function in the link to a crash log
376
377         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
378         function that crashed
379
380         Reviewed by David Kilzer.
381
382         * Scripts/old-run-webkit-tests:
383         (crashLocation): Added. Returns the location of the crash.
384         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
385         could be determined.
386
387 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
388
389         Unreviewed, build fix.
390
391         Actually make the changes suggested by Mihai in his review
392         of bug 53720 :(
393
394         https://bugs.webkit.org/show_bug.cgi?id=53720
395
396         * Scripts/webkitpy/layout_tests/port/test_files.py:
397         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
398
399 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
400
401         Reviewed by Mihai Parparita.
402
403         new-run-webkit-tests: Fix bug introduced in r77434 that was
404         causing us to run the canvas GPU tests on the Mac GPU port. This
405         bug revealed that we were not setting the port.name() field
406         properly in many cases, so I've cleaned up all of that code, and
407         removed a few comments about "version-specific" GPU ports that
408         don't exist and just confused things.
409
410         Testing also revealed that port.abspath_for_test() wasn't
411         normalizing paths on Windows properly, so I fixed that as well.
412
413         https://bugs.webkit.org/show_bug.cgi?id=53719
414
415         * Scripts/webkitpy/layout_tests/port/base.py:
416         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
417         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
418
419 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
420
421         Reviewed by Mihai Parparita.
422
423         new-run-webkit-tests: fix normalization of paths on windows when gathering files
424
425         r77434 introduced a bug that was causing the test expectations
426         for the GPU ports to not be treated properly. It turns out that
427         when we gathered the list of test files on Windows, we would
428         return paths of the form "c:\LayoutTests/fast/canvas", and the
429         mixture of backslashes and forward slashes was confusing things.
430
431         This patch normalizes all of the filenames returned from
432         test_files.find(), and adds better tests for this (fixing a
433         couple of other bugs found in the meantime).
434
435         https://bugs.webkit.org/show_bug.cgi?id=53720
436
437         * Scripts/webkitpy/layout_tests/port/test.py:
438         * Scripts/webkitpy/layout_tests/port/test_files.py:
439         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
440
441 2011-02-03  Adam Roben  <aroben@apple.com>
442
443         Add links to Windows crash logs in results.html
444
445         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
446         results.html
447
448         Reviewed by David Kilzer.
449
450         * Scripts/old-run-webkit-tests:
451         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
452         createDebuggerCommandFile).
453         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
454         tool has exited.
455         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
456         it into the test results directory tree. Only implemented for Cygwin currently.
457         (findNewestFileMatchingGlob): Added. Does what it says.
458         (htmlForResultsSection): Only link to files that exist.
459         (linksForErrorTest): Add a link to the crash log.
460         (deleteExpectedAndActualResults): Delete any old crash log for this test.
461         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
462         hardcoding it here.
463
464 2011-02-03  Adam Roben  <aroben@apple.com>
465
466         Tell the debugger the path to the WebKit source tree when saving a crash log
467
468         This allows the debugger to include the crashing line of code in the log.
469
470         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
471         of code
472
473         Reviewed by Sam Weinig.
474
475         * Scripts/old-run-webkit-tests:
476         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
477         file and returns the path to that file. The commands we pass came from
478         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
479         WebKit source code lives.
480         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
481         line using -c, save them to a file and specify the path to that file using -cf. This works
482         around what is presumably a bug in Windows's command line parsing, where having multiple
483         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
484         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
485         together to make them easier to modify in the future.
486
487 2011-02-02  Sam Weinig  <sam@webkit.org>
488
489         Reviewed by Anders Carlsson.
490
491         Add notification of the end of a rubber band.
492         <rdar://problem/8940648>
493
494         * MiniBrowser/mac/BrowserWindowController.m:
495         (-[BrowserWindowController awakeFromNib]):
496         * WebKitTestRunner/TestController.cpp:
497         (WTR::TestController::createOtherPage):
498         (WTR::TestController::initialize):
499         Stub out the new WKUIClient function.
500
501 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
502
503         Unreviewed.
504
505         Adding myself to committers.py.
506
507         * Scripts/webkitpy/common/config/committers.py:
508
509 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
510
511         Reviewed by Csaba Osztrogonác.
512
513         [Qt][WK2] MiniBrowser's window size should be 800x600
514         https://bugs.webkit.org/show_bug.cgi?id=53670
515
516         Make layout test failure debugging easier.
517         * MiniBrowser/qt/BrowserWindow.cpp:
518         (BrowserWindow::BrowserWindow):
519
520 2011-02-02  Andy Estes  <aestes@apple.com>
521
522         Reviewed by Mark Rowe.
523
524         'update-webkit' should handle OpenSource and Internal using different
525         VCSs.
526
527         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
528         Internal directory.
529
530 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
531
532         Reviewed by Mihai Parparita.
533
534         new-run-webkit-tests: hardcode the directories to scan for tests
535         for GPU bots instead of SKIPping them. See bug 53562 for some
536         context, but we will now hard-code the list of directories to
537         use by default instead of skipping over directories in the
538         expectations file. We do this so that we will be able to merge
539         the expectations files without getting conflicting SKIP
540         directives. Note that this change will reduce the # of tests
541         being run on the Mac GPU bots, because we're accidentally
542         including some today.
543
544         https://bugs.webkit.org/show_bug.cgi?id=53631
545
546         * Scripts/webkitpy/layout_tests/port/base.py:
547         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
548         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
549
550 2011-02-02  Sam Weinig  <sam@webkit.org>
551
552         Reviewed by Beth Dakin.
553
554         Add ChromeClient function to paint custom overhang areas.
555         https://bugs.webkit.org/show_bug.cgi?id=53639
556
557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
558         (WTR::InjectedBundlePage::InjectedBundlePage):
559         Stub out new callback.
560
561 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
562
563         Reviewed by Tony Chang.
564
565         new-run-webkit-tests: support chromium code paths in mock_drt
566
567         https://bugs.webkit.org/show_bug.cgi?id=53471
568
569         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
570         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
571
572 2011-02-02  Adam Klein  <adamk@chromium.org>
573
574         Reviewed by Tony Chang.
575
576         Update new-run-webkit-tests --chromium to put output under Source/...
577         https://bugs.webkit.org/show_bug.cgi?id=53612
578
579         * BuildSlaveSupport/test-result-archive:
580         * Scripts/webkitpy/layout_tests/port/chromium.py:
581
582 2011-01-28  Tony Chang  <tony@chromium.org>
583
584         Reviewed by Eric Seidel.
585
586         [chromium] remove --use-test-shell from NRWT
587         https://bugs.webkit.org/show_bug.cgi?id=53346
588
589         I've already started removing some of the bindings like eventSender so
590         this already doesn't work isn't useful.  Also updated some comments to
591         refer to DRT instead of test_shell.
592
593         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
594         * Scripts/webkitpy/layout_tests/port/chromium.py:
595         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
596         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
597         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
598         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
600         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
601
602 2011-02-02  Steve Lacey  <sjl@chromium.org>
603
604         Reviewed by Eric Carlson.
605
606         Implement basic media statistics on media elements.
607         https://bugs.webkit.org/show_bug.cgi?id=53322
608
609         * Scripts/build-webkit:
610
611 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
612
613         [wx] Build fixes for wxWebKit.
614
615         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
616         (LayoutTestController::setSerializeHTTPLoads):
617         * wx/browser/wscript:
618         * wx/build/build_utils.py:
619         * wx/build/settings.py:
620
621 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
622
623         Reviewed by Mihai Parparita.
624
625         new-run-webkit-tests: stop skipping so many tests
626
627         r77163 introduced a regression where we weren't resetting test
628         expectations properly and were skipping too many tests as a
629         result. This patch fixes that and adds a test for it.
630
631         https://bugs.webkit.org/show_bug.cgi?id=53551
632
633         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
634         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
635
636 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
637
638         Reviewed by Tony Chang.
639
640         new-run-webkit-tests: add first stub of test_runner2. This
641         will add support for the 'inline', 'threads', and 'processes'
642         flags to --worker-model, but for now the implementatios just
643         fall back on the old ones.
644
645         https://bugs.webkit.org/show_bug.cgi?id=53157
646
647         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
648         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
649
650 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
651
652         Reviewed by James Robinson.
653
654         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
655         https://bugs.webkit.org/show_bug.cgi?id=53522
656
657         * Scripts/run-chromium-webkit-unit-tests:
658
659 2011-02-01  Adam Barth  <abarth@webkit.org>
660
661         Reviewed by Mihai Parparita.
662
663         Using Control-C to cancel webkit-patch or other python tools causes
664         unpleasant traceback console spew
665         https://bugs.webkit.org/show_bug.cgi?id=53462
666
667         Catch the exception and don't print the stack trace.
668
669         * Scripts/webkit-patch:
670
671 2011-02-01  Scott Cameron  <sccameron@rim.com>
672
673         Reviewed by Daniel Bates.
674
675         Use Windows format for MinGW HTTPD path.
676         https://bugs.webkit.org/show_bug.cgi?id=53503
677
678         * Scripts/webkitperl/httpd.pm:
679           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
680             so that we don't have to escape the space characters in the path. Also,
681             changed path to Windows-style path and removed FIXME comment.
682
683 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
684
685         Reviewed by Andreas Kling.
686
687         [Qt][WK2] Add a way to use shared process model in MiniBrowser
688         https://bugs.webkit.org/show_bug.cgi?id=53090
689
690         * MiniBrowser/qt/BrowserView.cpp:
691         (BrowserView::BrowserView): Removed the m_context member.
692         From now the context is guaranteed to be non-null and we
693         don't need to store that in the object.
694         * MiniBrowser/qt/BrowserView.h:
695         * MiniBrowser/qt/BrowserWindow.cpp:
696         Added static bool to determine that new windows need to be
697         created with their own context or not. Use the same context
698         and web process by default to be inilne with the other ports.
699         (BrowserWindow::BrowserWindow):
700         (BrowserWindow::newWindow):
701         * MiniBrowser/qt/BrowserWindow.h:
702         * MiniBrowser/qt/main.cpp:
703         (main): Added command line switch to be able to use the
704         non-shared process model. Simplify the handling of the command line
705         switches a little bit.
706
707 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
708
709         Reviewed by Andreas Kling.
710
711         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
712         https://bugs.webkit.org/show_bug.cgi?id=53491
713
714         * MiniBrowser/qt/BrowserWindow.cpp:
715         (BrowserWindow::BrowserWindow):
716         (BrowserWindow::toggleFullScreenMode):
717         * MiniBrowser/qt/BrowserWindow.h:
718
719 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
720
721         Reviewed by Andreas Kling.
722
723         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
724         https://bugs.webkit.org/show_bug.cgi?id=53489
725
726         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
727         to Settings menu.
728
729         * MiniBrowser/qt/BrowserWindow.cpp:
730         (BrowserWindow::BrowserWindow):
731         (BrowserWindow::toggleFrameFlattening):
732         (BrowserWindow::toggleDisableJavaScript):
733         (BrowserWindow::toggleAutoLoadImages):
734         * MiniBrowser/qt/BrowserWindow.h:
735
736 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
737
738         Reviewed by Tony Chang.
739
740         [Chromium] Switch chromium-mac to use ChromiumDriver
741         https://bugs.webkit.org/show_bug.cgi?id=53461
742         
743         For the sake of consistency with the other Chromium platforms (and so
744         that chromium-mac picks up special flags like --enable-hardware-gpu),
745         switch chromium-mac from the WebKitDriver to ChromiumDriver.
746
747         * Scripts/webkitpy/layout_tests/port/chromium.py:
748
749 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
750
751         Reviewed by Mihai Parparita.
752
753         The current modifier parsing code in test_expectations is
754         fragile and hard-coded, so it's not easy to understand the logic
755         or easily add new types of modifiers (like GPU vs. CPU testing
756         for graphics tests, or 32-bit vs. 64-bit differences).
757
758         This is the first of two patches that will add in more generic
759         support and then eliminate the GPU-specific test expectations
760         files for Chromium.
761
762         This patch adds two standalone objects for handling modifiers. The
763         rules for interpreting modifiers, precedence, and conflicts are
764         given in the docstring to the ModifierMatcher class, which
765         returns ModifierMatchResult objects.
766         
767         This patch also adds routines to the Port interface and a
768         default set of values in the base object, in order to obtain the
769         values needed on a given test run. These values are then passed
770         to the expectation parser. This also allows us to clean up the
771         logic used to lint all of the different configurations in a
772         single test_expectations.txt file.
773
774         The next patch will merge in the separate GPU expectations file.
775
776         https://bugs.webkit.org/show_bug.cgi?id=51222
777
778         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
779         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
780         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
781         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
782         * Scripts/webkitpy/layout_tests/port/base.py:
783         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
784         * Scripts/webkitpy/layout_tests/port/chromium.py:
785         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
786         * Scripts/webkitpy/layout_tests/port/test.py:
787         * Scripts/webkitpy/layout_tests/port/webkit.py:
788         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
789         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
790         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
791         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
792         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
793
794 2011-01-31  Scott Cameron  <sccameron@rim.com>
795
796         Reviewed by Daniel Bates.
797
798         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
799         https://bugs.webkit.org/show_bug.cgi?id=50036
800
801         This will add an Apache2.2 configuration file and modifies scripts to allow
802         running an httpd server in an MSYS environment.
803
804         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
805         in order to allow for simple installation/execution.  Simply install the latest
806         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
807         be able to execute run-webkit-httpd.
808         
809
810         * Scripts/run-webkit-httpd:
811         * Scripts/webkitperl/httpd.pm:
812
813 2011-01-31  Tony Chang  <tony@chromium.org>
814
815         Reviewed by Eric Seidel.
816
817         mac DRT should report RTL scroll offset relative to top right corner
818         https://bugs.webkit.org/show_bug.cgi?id=53324
819
820         * DumpRenderTree/mac/DumpRenderTree.mm:
821         (dumpFrameScrollPosition):
822
823 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
824
825         Reviewed by Andreas Kling.
826
827         [Qt] Add Take Screen Shot action to MiniBrowser
828         https://bugs.webkit.org/show_bug.cgi?id=53422
829
830         Add Take Screen Shot action to MiniBrowser's view menu.
831
832         * MiniBrowser/qt/BrowserWindow.cpp:
833         (BrowserWindow::BrowserWindow):
834         (BrowserWindow::screenshot):
835         * MiniBrowser/qt/BrowserWindow.h:
836
837 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
838
839         Reviewed by Xan Lopez.
840
841         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
842         https://bugs.webkit.org/show_bug.cgi?id=53379
843
844         Remove left over #ifdef's. I thought all of the conditional code
845         had been freed from the condition, but I forgot to check DRT.
846
847         * DumpRenderTree/gtk/DumpRenderTree.cpp:
848         (resetDefaultsToConsistentValues):
849         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
850         (LayoutTestController::setAlwaysAcceptCookies):
851
852 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
853
854         Unreviewed, build fix.
855
856         Fix regression introduced in r77093 - path.rsplit() doesn't
857         take keyword arguments.
858
859         https://bugs.webkit.org/show_bug.cgi?id=53326
860
861         * Scripts/webkitpy/common/system/filesystem_mock.py:
862
863 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
864
865         Reviewed by Mihai Parparita.
866
867         Add more unit tests for rebaseline-chromium-webkit-tests. This
868         change involves restructuring a bunch of r-c-w-t code to make it
869         more testable as well. We also add wrapper classes for handling
870         testing zip files and fetching URLs.
871
872         https://bugs.webkit.org/show_bug.cgi?id=53040
873
874         * Scripts/webkitpy/common/system/urlfetcher.py:
875         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
876         * Scripts/webkitpy/common/system/zipfileset_mock.py:
877         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
878         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
879         * Scripts/webkitpy/tool/mocktool.py:
880
881 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
882
883         Reviewed by Eric Seidel.
884
885         Clean up of the filesystem-related modules used in webkitpy.
886         I've added relpath() to the filesystem interface, modified
887         ospath.relpath() so that it could work with the filesystem
888         interface, and modified the fileset* routines to use the
889         filesystem interface consistently.
890
891         This patch also adds a close() routine to the fileset routines
892         to indicate that the caller is done with the fileset. This
893         allows zipfileset to clean up after itself when it creates
894         tempfiles to store downloads.
895
896         https://bugs.webkit.org/show_bug.cgi?id=53326
897
898         * Scripts/webkitpy/common/system/directoryfileset.py:
899         * Scripts/webkitpy/common/system/fileset.py:
900         * Scripts/webkitpy/common/system/filesystem.py:
901         * Scripts/webkitpy/common/system/filesystem_mock.py:
902         * Scripts/webkitpy/common/system/filesystem_unittest.py:
903         * Scripts/webkitpy/common/system/ospath.py:
904         * Scripts/webkitpy/common/system/zipfileset.py:
905         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
906
907 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
908
909         Reviewed by Csaba Osztrogonác.
910
911         [Qt][WK2]REGRESSION (r76991): Fix build errors
912         https://bugs.webkit.org/show_bug.cgi?id=53400
913
914         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
915         and remove WebKit2Prefix.h from the build.
916         * MiniBrowser/qt/MiniBrowser.pro:
917
918 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
919
920         Unreviewed.
921
922         [Qt][WK2] Buildfix.
923
924         * MiniBrowser/qt/MiniBrowser.pro:
925
926 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
927
928         Reviewed by Adam Roben.
929         
930         define NOMINMAX when building ImageDiff, as we do elsewhere.
931
932         Add various clampToInt() methods to MathExtras.h
933         https://bugs.webkit.org/show_bug.cgi?id=52910
934
935         * DumpRenderTree/win/ImageDiffCommon.vsprops:
936
937 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
938
939         Reviewed by Darin Adler.
940
941         WebKitTestRunner needs layoutTestController.setPOSIXLocale
942         https://bugs.webkit.org/show_bug.cgi?id=42682
943
944         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
946         (WTR::InjectedBundle::resetLocalSettings):
947         (WTR::InjectedBundle::didReceiveMessage):
948         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
949         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
950         (WTR::LayoutTestController::setPOSIXLocale):
951         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
952
953 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
954  
955          Reviewed by Mihai Parparita.
956  
957          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
958  
959          This patch re-enables this test and changes it to
960          handle all of the mac platform versions, not just the one
961          it is running on.
962  
963          https://bugs.webkit.org/show_bug.cgi?id=53356
964  
965          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
966  
967 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
968
969         Unreviewed, build fix.
970
971         Take two. The fix in 77023 didn't work, because we were
972         still calling path.abspath_to_uri, which calls _cygpath under
973         the covers, and it appears the cygpath on the bots does
974         something different than it does on my machine. This patch
975         removes the calls to path.abspath_to_uri, so it should be safe.
976         If it doesn't work, I'll roll it out along with r76982 and 77023.
977
978         https://bugs.webkit.org/show_bug.cgi?id=53126
979
980         * Scripts/webkitpy/layout_tests/port/test.py:
981
982 2011-01-28  David Kilzer  <ddkilzer@apple.com>
983
984         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
985         <http://webkit.org/b/53353>
986
987         Reviewed by Mark Rowe.
988
989         * Scripts/webkitdirs.pm:
990         (checkRequiredSystemConfig): Check the Xcode marketing version
991         in addition to the DevCoreTools build version before complaining
992         about an old version of Xcode.  Also make the Mac OS X version
993         check use Perl's built-in version string comparitor.
994
995 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
996
997         Unreviewed, build fix.
998
999         Work around breakage on Win 7 Release bot caused by r76982
1000         and the fact that windows ports use "file:////" instead of
1001         "file:///". Ideally the test code should be isolated from
1002         this, but it isn't yet. Will fix properly in a bit.
1003
1004         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1005
1006 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1007
1008         Reviewed by Tony Chang.
1009
1010         new-run-webkit-tests: change worker model values to
1011         "old-inline", "old-threads" in preparation for test_runner2 /
1012         multiprocessing changes.
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=53156
1015
1016         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1017         * Scripts/webkitpy/layout_tests/port/base.py:
1018         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1019         * Scripts/webkitpy/layout_tests/port/mac.py:
1020         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1021
1022 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1023
1024         Reviewed by Tony Chang.
1025
1026         committers.py - add an IRC nickname for dpranke
1027         https://bugs.webkit.org/show_bug.cgi?id=53335
1028
1029         * Scripts/webkitpy/common/config/committers.py:
1030
1031 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1032
1033         Reviewed by Tony Chang.
1034
1035         new-run-webkit-tests: add a "mock DRT" port implementation
1036         and a separate class that emulates what we expect the
1037         DumpRenderTree behavior to be.
1038
1039         This will eventually replace port/dryrun.py and allow us to get
1040         better test coverage of the new-run-webkit-tests code as well as
1041         a reference for what new-run-webkit-tests expects from DRT.
1042
1043         This is the first attempt at this, and it is pretty bare-boned. It
1044         really only has been tested on the 'mac' port (and a little on
1045         the 'chromium-mac' port.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=53126
1048
1049         * Scripts/webkitpy/common/system/filesystem_mock.py:
1050         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1051         * Scripts/webkitpy/layout_tests/port/factory.py:
1052         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1053         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1054         * Scripts/webkitpy/layout_tests/port/test.py:
1055
1056 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1057
1058         Unreviewed. Removing .swp file checked in by mistake.
1059
1060         * Scripts/.webkitdirs.pm.swp: Removed.
1061
1062 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1063
1064         Reviewed by David Kilzer.
1065
1066         Space not necessary for undefined feature
1067         https://bugs.webkit.org/show_bug.cgi?id=53317
1068
1069         * Scripts/build-webkit:
1070
1071 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1072
1073         Reviewed by Andreas Kling.
1074
1075         Reset NetworkAccessManager to clean up credentials from previous tests.
1076         This change causes no performance overhead either.
1077         https://bugs.webkit.org/show_bug.cgi?id=36688
1078
1079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1080         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1081         (WebCore::DumpRenderTree::open):
1082         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1083
1084 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1085
1086         Reviewed by Andreas Kling.
1087
1088         [Qt] Add Zoom Text Only action to MiniBrowser
1089         https://bugs.webkit.org/show_bug.cgi?id=53297
1090
1091         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1092
1093         * MiniBrowser/qt/BrowserWindow.cpp:
1094         (BrowserWindow::BrowserWindow):
1095         (BrowserWindow::zoomIn):
1096         (BrowserWindow::zoomOut):
1097         (BrowserWindow::resetZoom):
1098         (BrowserWindow::toggleZoomTextOnly):
1099         (BrowserWindow::applyZoom):
1100         * MiniBrowser/qt/BrowserWindow.h:
1101
1102 2011-01-28  Adam Barth  <abarth@webkit.org>
1103
1104         Reviewed by Eric Seidel.
1105
1106         Add webkit-patch roll-chromium-deps
1107         https://bugs.webkit.org/show_bug.cgi?id=53288
1108
1109         This command updates the Source/WebKit/chromium/DEPS file with the
1110         last-known good revision of Chromium (or a revision specified on the
1111         command line).  I'd eventually like to turn this into a SheriffBot
1112         command, but this is the first step.
1113
1114         This patch somewhat sprawled because I needed to move a bunch of code
1115         out of ChangeLog that should never have been there in the first place.
1116         Also, I had to fix a bug in MockUser in order to test the new command.
1117
1118         * Scripts/webkitpy/common/checkout/api.py:
1119         * Scripts/webkitpy/common/checkout/changelog.py:
1120         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1121         * Scripts/webkitpy/common/checkout/deps.py: Added.
1122         * Scripts/webkitpy/common/config/urls.py:
1123         * Scripts/webkitpy/tool/commands/__init__.py:
1124         * Scripts/webkitpy/tool/commands/download_unittest.py:
1125         * Scripts/webkitpy/tool/commands/roll.py: Added.
1126         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1127         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1128         * Scripts/webkitpy/tool/mocktool.py:
1129         * Scripts/webkitpy/tool/steps/__init__.py:
1130         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1131         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1132         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1133         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1134         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1135         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1136
1137 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1138
1139         Reviewed by Laszlo Gombos.
1140
1141         Get rid of prefix header dependency for WebKit2 build system
1142         https://bugs.webkit.org/show_bug.cgi?id=50174
1143
1144         Change the style checker so that it enforces config.h include for
1145         WebKit2.
1146
1147         * Scripts/webkitpy/style/checker.py:
1148
1149 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1150
1151         Reviewed by Darin Adler.
1152
1153         execCommand("Paste") doesn't work in WebKitTestRunner
1154         https://bugs.webkit.org/show_bug.cgi?id=52785
1155
1156         Enable both of the settings needed to allow paste.
1157         
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::TestController::resetStateToConsistentValues):
1160
1161 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1162
1163         Reviewed by Andreas Kling.
1164
1165         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1166         https://bugs.webkit.org/show_bug.cgi?id=48440
1167
1168         Preserve user input when toggling use of QGraphicsView
1169
1170         * QtTestBrowser/launcherwindow.cpp:
1171         (LauncherWindow::initializeView):
1172         (LauncherWindow::loadFinished):
1173         * QtTestBrowser/launcherwindow.h:
1174         * QtTestBrowser/mainwindow.cpp:
1175         (MainWindow::addressUrl):
1176         * QtTestBrowser/mainwindow.h:
1177
1178 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1179
1180         Reviewed by Mihai Parparita.
1181
1182         new-run-webkit-tests: turn off pixel tests correctly by default
1183         for webkit-based ports. r70013 (bug 47510) used
1184         port.set_option_default() to attempt to set default values, but
1185         that didn't work correctly. I have removed set_option_default
1186         for now since it was only being used in two places and in three
1187         useless unit tests. There is a separate bug open to fix the
1188         option parsing (48095), so this workaround is fine for now.
1189
1190         https://bugs.webkit.org/show_bug.cgi?id=53217
1191
1192         * Scripts/webkitpy/layout_tests/port/webkit.py:
1193         * Scripts/webkitpy/layout_tests/port/base.py:
1194         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1195
1196 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1197
1198         Rubber-stamped by Ariya Hidayat.
1199
1200         Trivial crash fix in WTR.
1201
1202         * WebKitTestRunner/TestController.cpp:
1203         (WTR::TestController::initialize): Increase the size
1204         of the vector by one to be able to store the null character.
1205
1206 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1207
1208         Reviewed by Csaba Osztrogonác.
1209
1210         [Qt][WK2] WTR should be initialized in the same way as DRT
1211         https://bugs.webkit.org/show_bug.cgi?id=53240
1212
1213         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1214         (WTR::activateFonts): Added missing initialization steps.
1215
1216 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1217
1218         Unreviewed. 
1219
1220         Adding myself to committers.py.
1221
1222         * Scripts/webkitpy/common/config/committers.py:
1223
1224 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1225
1226         Reviewed by Csaba Osztrogonác.
1227
1228         [Qt] [Symbian] Move project files into Source
1229         https://bugs.webkit.org/show_bug.cgi?id=52891
1230
1231         Fix the Symbian build after the project files
1232         are moved to Source directory. On Symbian qmake
1233         needs to run in the same directory where the main
1234         pro files (WebKit.pro, Tools.pro) are located.
1235
1236         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1237         is located before running qmake for Symbian. Qmake on Symbian
1238         does not properly honor the "-o" option, work it around by setting
1239         the name of the Makefile to bld.inf.
1240
1241 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1242
1243         Reviewed by Andreas Kling.
1244
1245         [Qt] Add simple zooming features to MiniBrowser
1246         https://bugs.webkit.org/show_bug.cgi?id=53231
1247
1248         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1249
1250         * MiniBrowser/qt/BrowserWindow.cpp:
1251         (BrowserWindow::BrowserWindow):
1252         (BrowserWindow::zoomIn):
1253         (BrowserWindow::zoomOut):
1254         (BrowserWindow::resetZoom):
1255         (BrowserWindow::updateUserAgentList):
1256         (BrowserWindow::applyZoom):
1257         * MiniBrowser/qt/BrowserWindow.h:
1258
1259 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1260
1261         Reviewed by Dan Bernstein.
1262
1263         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1264         https://bugs.webkit.org/show_bug.cgi?id=42319
1265         
1266         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1267
1268         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1269         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1270         (WTR::LayoutTestController::showWebInspector):
1271         (WTR::LayoutTestController::closeWebInspector):
1272         (WTR::LayoutTestController::evaluateInWebInspector):
1273         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1274         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1275         * WebKitTestRunner/TestInvocation.cpp:
1276         (WTR::shouldOpenWebInspector):
1277         (WTR::TestInvocation::invoke):
1278         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1279
1280 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1281
1282         Reviewed by Xan Lopez.
1283
1284         [GTK] Pixel dumps do not include scrollbars in output images
1285         https://bugs.webkit.org/show_bug.cgi?id=53216
1286
1287         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1288         that have scrollbars.
1289
1290         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1291         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1292         instead of the web view itself.
1293
1294 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1295
1296         Reviewed by Mihai Parparita.
1297
1298         Fix regression introduced in r76322 ... new-run-webkit-tests
1299         was attempting to save the image diff output as a UTF-8-encoded
1300         file.
1301
1302         https://bugs.webkit.org/show_bug.cgi?id=53210
1303
1304         * Scripts/webkitpy/layout_tests/port/webkit.py:
1305
1306 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1307
1308         Unreviewed, rolling out r76709.
1309         http://trac.webkit.org/changeset/76709
1310         https://bugs.webkit.org/show_bug.cgi?id=53194
1311
1312         "broke python tests on non-snowleopard platforms" (Requested
1313         by dpranke on #webkit).
1314
1315         * Scripts/webkitpy/layout_tests/port/factory.py:
1316         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1317         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1318
1319 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1320
1321         Reviewed by Tony Chang.
1322
1323         new-run-webkit-tests: add a "mock DRT" port implementation
1324         and a separate class that emulates what we expect the
1325         DumpRenderTree behavior to be.
1326
1327         This will eventually replace port/dryrun.py and allow us to get
1328         better test coverage of the new-run-webkit-tests code as well as
1329         a reference for what new-run-webkit-tests expects from DRT.
1330
1331         This is the first attempt at this, and it is pretty bare-boned. It
1332         really only has been tested on the 'mac' port (and a little on
1333         the 'chromium-mac' port.
1334
1335         https://bugs.webkit.org/show_bug.cgi?id=53126
1336
1337         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1338         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1339         * Scripts/webkitpy/layout_tests/port/factory.py:
1340
1341 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1342
1343         Reviewed by Tony Chang.
1344
1345         Add '--no-timeout' option to Chromium DRT to ease debugging.
1346         https://bugs.webkit.org/show_bug.cgi?id=52873
1347
1348         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1349         (main):
1350
1351 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1352
1353         Reviewed by Andreas Kling.
1354
1355         [Qt] Fix qt_minimal build
1356         https://bugs.webkit.org/show_bug.cgi?id=53172
1357
1358         * QtTestBrowser/locationedit.h:
1359
1360 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1361
1362         Reviewed by Antonio Gomes.
1363
1364         QtTestBrowser should have a UI Setting to disable plugins
1365         https://bugs.webkit.org/show_bug.cgi?id=52408
1366         
1367         Added a new action item named "Disable Plugins"
1368         under the "Settings" menu. 
1369
1370         * QtTestBrowser/launcherwindow.cpp:
1371         (LauncherWindow::createChrome):
1372         (LauncherWindow::togglePlugins):
1373         * QtTestBrowser/launcherwindow.h:
1374
1375 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1376
1377         Reviewed by Adam Barth.
1378
1379         Move main CMakeLists.txt into Source directory
1380         https://bugs.webkit.org/show_bug.cgi?id=52888
1381
1382         * Scripts/webkitdirs.pm:
1383
1384 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1385
1386         Reviewed by Eric Seidel.
1387
1388         Improve label text in submit-to-ews
1389         https://bugs.webkit.org/show_bug.cgi?id=53130
1390
1391         * QueueStatusServer/templates/submittoews.html:
1392
1393 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1394
1395         Reviewed by Antonio Gomes.
1396
1397         QtTestBrowser should have a UI Settings to prevent loading images
1398         https://bugs.webkit.org/show_bug.cgi?id=52409
1399         
1400         Added a new action item named "DisableAutoLoadImages"
1401         under the "Settings" menu 
1402
1403         * QtTestBrowser/launcherwindow.cpp:
1404         (LauncherWindow::createChrome):
1405         (LauncherWindow::toggleAutoLoadImages):
1406         * QtTestBrowser/launcherwindow.h:
1407
1408 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1409
1410         Reviewed by Tony Chang.
1411
1412         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1413         classes, test_expectations.py. This change adds "test-win" and
1414         "test-mac" variants to the test port so that we can better test
1415         rebaselining, and adds a MockUser() object for reuse in testing.
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=53036
1418
1419         * Scripts/webkitpy/common/system/filesystem.py:
1420         * Scripts/webkitpy/common/system/filesystem_mock.py:
1421         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1422         * Scripts/webkitpy/layout_tests/port/factory.py:
1423         * Scripts/webkitpy/layout_tests/port/base.py:
1424         * Scripts/webkitpy/layout_tests/port/test.py:
1425         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1426         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1427         * Scripts/webkitpy/tool/mocktool.py:
1428
1429 2011-01-25  Tony Chang  <tony@chromium.org>
1430
1431         Reviewed by Dimitri Glazkov.
1432
1433         [chromium] remove unused layoutTestController callback
1434         https://bugs.webkit.org/show_bug.cgi?id=53103
1435
1436         This method is used by a test_shell_test, but not needed by DRT.
1437
1438         * DumpRenderTree/chromium/LayoutTestController.cpp:
1439         (LayoutTestController::LayoutTestController):
1440         * DumpRenderTree/chromium/LayoutTestController.h:
1441
1442 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1443
1444         Reviewed by Andreas Kling.
1445
1446         [GTK] Remove 64 bits release bot from the buildbot master
1447         https://bugs.webkit.org/show_bug.cgi?id=52899
1448
1449         Removes the 64 bits release slave from the buildbot configuration,
1450         so that we can use it as an EWS.
1451
1452         * BuildSlaveSupport/build.webkit.org-config/config.json:
1453
1454 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1455
1456         Reviewed by Dan Bernstein.
1457
1458         Implement database quota callback to fix storage tests on WebKit2 bot
1459         https://bugs.webkit.org/show_bug.cgi?id=53064
1460
1461         * WebKitTestRunner/TestController.cpp:
1462         (WTR::exceededDatabaseQuota):
1463         (WTR::TestController::createOtherPage):
1464         (WTR::TestController::initialize):
1465
1466 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1467
1468         Reviewed by Anders Carlsson.
1469
1470         Use designated temp directory for the database for WebKit2
1471         https://bugs.webkit.org/show_bug.cgi?id=53052
1472         
1473         Adopt the new WK2 API for this.
1474
1475         * WebKitTestRunner/TestController.cpp:
1476         (WTR::TestController::libraryPathForTesting):
1477         (WTR::TestController::initialize):
1478         * WebKitTestRunner/TestController.h:
1479         * WebKitTestRunner/mac/TestControllerMac.mm:
1480         (WTR::TestController::platformLibraryPathForTesting):
1481         * WebKitTestRunner/qt/TestControllerQt.cpp:
1482         (WTR::TestController::platformLibraryPathForTesting):
1483         * WebKitTestRunner/win/TestControllerWin.cpp:
1484         (WTR::TestController::platformLibraryPathForTesting):
1485
1486 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1487
1488         Reviewed by Stephanie Lewis.
1489
1490         Add a new Leopard test bot.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/config.json:
1493
1494 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1495
1496         Reviewed by Adam Barth.
1497
1498         Add EFL Builder to core waterfall
1499         https://bugs.webkit.org/show_bug.cgi?id=52704
1500
1501         Add EFL Builder to the core waterfall again.
1502
1503         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1504         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1505
1506 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1507
1508         Reviewed by Tony Chang.
1509
1510         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1511         https://bugs.webkit.org/show_bug.cgi?id=52872
1512
1513         Force disabling proxy to resolve the problem.
1514
1515         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1516         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1517
1518 2011-01-24  Andreas Kling  <kling@webkit.org>
1519
1520         Reviewed by Darin Adler.
1521
1522         check-webkit-style: Update exemptions following Source/ move.
1523         https://bugs.webkit.org/show_bug.cgi?id=53017
1524
1525         * Scripts/webkitpy/style/checker.py:
1526         * Scripts/webkitpy/style/checker_unittest.py:
1527
1528 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1529
1530         Rubber-stamped by Csaba Osztrogonác.
1531
1532         [Qt] Move project files into Source
1533         https://bugs.webkit.org/show_bug.cgi?id=52891
1534
1535         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1536
1537 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1538
1539         Reviewed by Yury Semikhatsky.
1540
1541         Web Inspector: Find duplicate strings in localizedStrings.js
1542
1543         https://bugs.webkit.org/show_bug.cgi?id=53005
1544
1545         * Scripts/check-inspector-strings:
1546
1547 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1548
1549         Reviewed by Andreas Kling.
1550
1551         [Qt] Regroup MiniBrowser's menubar and add open file action
1552         https://bugs.webkit.org/show_bug.cgi?id=53000
1553
1554         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1555
1556         * MiniBrowser/qt/BrowserWindow.cpp:
1557         (BrowserWindow::BrowserWindow):
1558         (BrowserWindow::openFile):
1559         (BrowserWindow::~BrowserWindow):
1560         * MiniBrowser/qt/BrowserWindow.h:
1561
1562 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1563
1564         Unreviewed fix after r76496
1565
1566         [Qt] Move project files into Source
1567         https://bugs.webkit.org/show_bug.cgi?id=52891
1568
1569         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1570         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1571         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1572
1573 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         [Qt] Move project files into Source
1578         https://bugs.webkit.org/show_bug.cgi?id=52891
1579
1580         * DerivedSources.pro: Renamed from DerivedSources.pro.
1581         * DumpRenderTree/qt/DumpRenderTree.pro:
1582         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1583         * MiniBrowser/DerivedSources.pro:
1584         * MiniBrowser/qt/MiniBrowser.pro:
1585         * QtTestBrowser/QtTestBrowser.pro:
1586         * Scripts/webkitdirs.pm:
1587         * Tools.pro: Added.
1588         * WebKitTestRunner/DerivedSources.pro:
1589         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1590         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1591
1592 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1593
1594         Reviewed by Dan Bernstein.
1595
1596         Beefed up --threaded mode to catch even more kinds of errors.
1597         https://bugs.webkit.org/show_bug.cgi?id=52971
1598
1599         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1600         context group to force JSC to mark multiple threads. (This used to be
1601         the default, but it changed in SnowLeopard.)
1602         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1603         to give threading mistakes more chances to show themselves.
1604         (startJavaScriptThreads):
1605         (stopJavaScriptThreads):
1606
1607 2011-01-22  Robert Hogan  <robert@webkit.org>
1608
1609         Reviewed by Andreas Kling.
1610
1611         [Qt] Support layoutTestController.addURLToRedirect()
1612         https://bugs.webkit.org/show_bug.cgi?id=52956
1613
1614         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1615         (LayoutTestController::addURLToRedirect):
1616         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1617
1618 2011-01-22  Robert Hogan  <robert@webkit.org>
1619
1620         Reviewed by Kenneth Rohde Christiansen.
1621
1622         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1623         https://bugs.webkit.org/show_bug.cgi?id=49802
1624
1625         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1626         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1627         (WebCore::DumpRenderTree::open):
1628
1629 2011-01-21  Adam Barth  <abarth@webkit.org>
1630
1631         Reviewed by Maciej Stachowiak.
1632
1633         Disable mac_unittest.py that fails on some of the Mac bots
1634         https://bugs.webkit.org/show_bug.cgi?id=52947
1635
1636         As noted in the comment, this test does not appear to be correct
1637         because the function this test is testing returns different results
1638         depending on which flavor of Mac the test is run on.  This patch
1639         disable the test.  Hopefully we can re-enable the test once we've
1640         probably insulated the test from its environment.
1641
1642         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1643
1644 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1645
1646         Reviewed by Mihai Parparita.
1647
1648         Fix bug introduced in r76322 that caused NRWT to not actually
1649         read the Skipped files properly.
1650
1651         https://bugs.webkit.org/show_bug.cgi?id=52771
1652
1653         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1654         * Scripts/webkitpy/layout_tests/port/webkit.py:
1655         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1656
1657 2011-01-21  Sam Weinig  <sam@webkit.org>
1658
1659         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1660
1661         WebKitTestRunner needs the HOME environment variable to be set.
1662         <rdar://problem/8896573>
1663
1664         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1665         it exists.
1666
1667 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1668
1669         Reviewed by Eric Seidel.
1670
1671         Suppress a few remaining integration tests so that none of the
1672         layout_test unit tests ever read from the filesystem or launch
1673         subprocesses that aren't part of the unit tests.
1674
1675         Also fix a minor bug in the printing unit tests that was
1676         incorrectly relying on sys.argv.
1677
1678         https://bugs.webkit.org/show_bug.cgi?id=52863
1679
1680         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1681         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1682         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1683
1684 2011-01-21  Darin Adler  <darin@apple.com>
1685
1686        Fix Mac build.
1687
1688         * MiniBrowser/mac/BrowserWindowController.m:
1689         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1690
1691 2011-01-20  Darin Adler  <darin@apple.com>
1692
1693         Reviewed by Dan Bernstein.
1694
1695         WebKit2: Implement showModalDialog
1696         https://bugs.webkit.org/show_bug.cgi?id=52855
1697
1698         This fixes WebKitTestRunner to compile, but more work is probably
1699         needed to get it to pass the tests.
1700
1701         * WebKitTestRunner/TestController.cpp:
1702         (WTR::TestController::runModal): Added. Calls through to the
1703         platform-specific version of runModal.
1704         (WTR::TestController::createOtherPage): Changed to be a private
1705         static member function so it can refer to runModal, which is
1706         a private static member function.
1707         (WTR::TestController::initialize): Pass 0 for the runModal
1708         function since we don't need to run the main window modal.
1709         I suspect this is wrong and will need to change.
1710         * WebKitTestRunner/TestController.h: Added declarations for
1711         the functions added above.
1712         * WebKitTestRunner/mac/TestControllerMac.mm:
1713         (WTR::TestController::runModal): Added. Untested implementation.
1714         * WebKitTestRunner/qt/TestControllerQt.cpp:
1715         (WTR::TestController::runModal): Added.
1716         * WebKitTestRunner/win/TestControllerWin.cpp:
1717         (WTR::TestController::runModal): Added.
1718
1719 2011-01-21  Eric Seidel  <eric@webkit.org>
1720
1721         Reviewed by Adam Barth.
1722
1723         Split Host object off from WebKitPatch for easier re-use
1724         https://bugs.webkit.org/show_bug.cgi?id=52284
1725
1726         new-run-webkit-tests and other tools are eventually going to want one of these.
1727         Basically you need to inherit from this class if you want to pretend to be a
1728         self.tool object for Steps/Commands.
1729
1730         * Scripts/webkitpy/common/host.py: Added.
1731         * Scripts/webkitpy/tool/main.py:
1732
1733 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1734
1735         Reviewed by Adam Barth.
1736
1737         Disable the tests that start and stop the http server and web
1738         server, so that we don't have to worry about port collisions on
1739         the bots.
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=52861
1742
1743         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1744
1745 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1746
1747         Reviewed by Eric Seidel.
1748
1749         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1750         
1751         https://bugs.webkit.org/show_bug.cgi?id=52772
1752         
1753         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1754
1755 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1756
1757         Reviewed by Eric Siedel.
1758
1759         nrwt: clean up almost all remaining port references, remove
1760         unnecessary import clauses. The only remaining references are
1761         in places where a mock filesystem makes no sense or can't be
1762         used, and in one routine in port/google_chrome_unittest that
1763         I'll rewrite in a separate patch.
1764
1765         https://bugs.webkit.org/show_bug.cgi?id=52771
1766
1767         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1768         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1769         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1770         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1771         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1772         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1773         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1774         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1775         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1776         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1777         * Scripts/webkitpy/layout_tests/port/gtk.py:
1778         * Scripts/webkitpy/layout_tests/port/mac.py:
1779         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1780         * Scripts/webkitpy/layout_tests/port/qt.py:
1781         * Scripts/webkitpy/layout_tests/port/webkit.py:
1782         * Scripts/webkitpy/layout_tests/port/win.py:
1783         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1784
1785 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1786
1787         Reviewed by Mihai Parparita.
1788
1789         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1790
1791         https://bugs.webkit.org/show_bug.cgi?id=52762
1792
1793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1794         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1795
1796 2011-01-20  Tony Chang  <tony@chromium.org>
1797
1798         Reviewed by Ojan Vafai.
1799
1800         [chromium] fix the paths used for the rebaseline tool
1801         https://bugs.webkit.org/show_bug.cgi?id=52857
1802
1803         Some of the bots were renamed so the path to grab the results zip
1804         file has changed.
1805
1806         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1807
1808 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Tony Chang.
1811
1812         Fix bug introduced in r72688 / bug 52768 that broke the
1813         generation of the output filename links in the results.html
1814         output. Apparently none of the unit tests actually checked to
1815         make sure the generated links were correct :(
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=52854
1818
1819         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1820         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1821
1822 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1823
1824         Reviewed by Darin Adler.
1825
1826         https://bugs.webkit.org/show_bug.cgi?id=52849
1827         Make window.print work with WebKit2
1828
1829         * MiniBrowser/mac/BrowserWindowController.m:
1830         (-[BrowserWindowController awakeFromNib]):
1831         * WebKitTestRunner/TestController.cpp:
1832         (WTR::createOtherPage):
1833         (WTR::TestController::initialize):
1834         Added zeroes to WKPageUIClient structures to avoid build failures.
1835
1836 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1837
1838         Reviewed by Eric Seidel.
1839
1840         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=52756
1843
1844         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1845         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1846         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1847         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1848         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1849         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1850
1851 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1852
1853         Reviewed by Antonio Gomes.
1854
1855         QtTestBrowser should have a seperate menu for Settings
1856         https://bugs.webkit.org/show_bug.cgi?id=52817
1857         
1858         Added a new menu item named "Settings"
1859         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1860
1861         * QtTestBrowser/launcherwindow.cpp:
1862         (LauncherWindow::createChrome):
1863
1864 2011-01-20  Sam Weinig  <sam@webkit.org>
1865
1866         Reviewed by John Sullivan.
1867
1868         Update update-webkit-localizable-strings with new path to WebKit.
1869
1870         * Scripts/update-webkit-localizable-strings:
1871
1872 2011-01-20  James Robinson  <jamesr@chromium.org>
1873
1874         Reviewed by Darin Fisher.
1875
1876         Implement mozilla's requestAnimationFrame API
1877         https://bugs.webkit.org/show_bug.cgi?id=51218
1878
1879         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1880
1881         * DumpRenderTree/chromium/WebViewHost.cpp:
1882         (invokeScheduleComposite):
1883         (WebViewHost::scheduleAnimation):
1884         (WebViewHost::paintInvalidatedRegion):
1885         * DumpRenderTree/chromium/WebViewHost.h:
1886
1887 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1888
1889         Reviewed by Adam Roben.
1890
1891         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1892         https://bugs.webkit.org/show_bug.cgi?id=42327
1893
1894         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1895         for methods that take their normal arguments but also a JSContextRef.
1896         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1897         for evaluateScriptInIsolatedWorld.
1898         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1899         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1900         this call is for an isolated world.
1901         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1902         (WTR::worldMap): Helper to create a world map.
1903         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1904         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1905         added LayoutTestController API.
1906         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1907
1908 2011-01-19  Adam Roben  <aroben@apple.com>
1909
1910         Convert paths in environment variables back to msys-style inside commit-log-editor
1911
1912         When this script gets run from inside git commit, msys-style paths in the environment will
1913         have been turned into Windows-style paths with forward slashes. This screws up functions
1914         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1915         the paths back to msys-style before doing anything else.
1916
1917         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1918         using msysgit's Perl and multiple ChangeLogs have been edited
1919
1920         Reviewed by David Kilzer.
1921
1922         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1923         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1924         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1925
1926 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1927
1928         [Win] Unreviewed build fix after r76248.
1929
1930         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1931
1932 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1933
1934         Reviewed by Csaba Osztrogonác.
1935
1936         Refactoring of the custom allocation framework
1937         https://bugs.webkit.org/show_bug.cgi?id=49897
1938
1939         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1940         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1941         equivalent macro implementation at the necessary places.
1942 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1943
1944         Unreviewed. 
1945
1946         Adding myself to committers.py.
1947
1948         * Scripts/webkitpy/common/config/committers.py:
1949
1950 2011-01-20  Adam Barth  <abarth@webkit.org>
1951
1952         Reviewed by Tony Chang.
1953
1954         Chromium builders don't delete unversioned directories when DEPS change
1955         https://bugs.webkit.org/show_bug.cgi?id=52745
1956
1957         If we pass this option to gclient sync, gclient will delete directories
1958         that are no longer part of DEPS instead of leaving them around to
1959         confuse us later.  Apparently, the downstream buildbots use this option
1960         already.
1961
1962         * Scripts/update-webkit-chromium:
1963
1964 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1965
1966         Unreviewed, build fix - I pulled this patch in to fix an issue
1967         revealed by r76195 running on some new bots). Also fix a couple
1968         of other issues revealed in testing.
1969
1970         nrwt: remove fs refs from layout_package/json*
1971
1972         https://bugs.webkit.org/show_bug.cgi?id=52754
1973
1974         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1975         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1976         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1977         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1978         * Scripts/webkitpy/layout_tests/port/base.py:
1979
1980 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1981
1982         Unreviewed, build fix.
1983
1984         Fix a couple of minor bugs discovered while bringing up new bots
1985         for testing.
1986
1987         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1988         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1989
1990 2011-01-19  James Robinson  <jamesr@chromium.org>
1991
1992         Unreviewed, rolling out r76194.
1993         http://trac.webkit.org/changeset/76194
1994         https://bugs.webkit.org/show_bug.cgi?id=51218
1995
1996         Caused mysterious compile failure on the chromium win
1997         build.webkit.org bots
1998
1999         * DumpRenderTree/chromium/WebViewHost.cpp:
2000         (WebViewHost::paintInvalidatedRegion):
2001         * DumpRenderTree/chromium/WebViewHost.h:
2002
2003 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2004
2005         Reviewed by Mihai Parparita.
2006
2007         remove fs refs from test_runner, dump_render_tree_thread
2008
2009         https://bugs.webkit.org/show_bug.cgi?id=52753
2010
2011         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2012         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2013         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2014         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2015
2016 2011-01-19  James Robinson  <jamesr@chromium.org>
2017
2018         Reviewed by Darin Fisher.
2019
2020         Implement mozilla's requestAnimationFrame API
2021         https://bugs.webkit.org/show_bug.cgi?id=51218
2022
2023         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2024
2025         * DumpRenderTree/chromium/WebViewHost.cpp:
2026         (invokeScheduleComposite):
2027         (WebViewHost::scheduleAnimation):
2028         (WebViewHost::paintInvalidatedRegion):
2029         * DumpRenderTree/chromium/WebViewHost.h:
2030
2031 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2032
2033         Unreviewed, build fix.
2034
2035         Fix a few incorrect "self._filesystem" references introduced in
2036         r76184.
2037
2038         * Scripts/webkitpy/layout_tests/port/chromium.py:
2039         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2040
2041 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2042
2043         Reviewed by Mihai Parparita.
2044
2045         add a .sep property, abspath(), isabs(), mtime(), and
2046         open_text_file_for_writing() to filesystem modules. Some of
2047         these properties are not needed in this patch but will be needed
2048         in subsequent patches (I'm doing this to avoid having to track
2049         multiple versions of a single file).
2050
2051         Also, change most of the port/* modules to use the filesystem
2052         objects instead of referencing the filesystem directly.
2053
2054         https://bugs.webkit.org/show_bug.cgi?id=52748
2055
2056         * Scripts/webkitpy/common/system/filesystem.py:
2057         * Scripts/webkitpy/common/system/filesystem_mock.py:
2058         * Scripts/webkitpy/layout_tests/port/__init__.py:
2059         * Scripts/webkitpy/layout_tests/port/base.py:
2060         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2061         * Scripts/webkitpy/layout_tests/port/chromium.py:
2062         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2063         * Scripts/webkitpy/layout_tests/port/config.py:
2064         * Scripts/webkitpy/layout_tests/port/test.py:
2065         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2066
2067 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2068
2069         Reviewed by Anders Carlsson.
2070
2071         If resetting between tests times out, treat it as a WebProcess crash
2072         https://bugs.webkit.org/show_bug.cgi?id=52757
2073
2074         * WebKitTestRunner/TestController.cpp:
2075         (WTR::TestController::runTest):
2076
2077 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2078
2079         Reviewed by Darin Adler.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=52739
2082         Make it possible for a WebKit2 client to print headers and footers
2083
2084         Added dummy implementations for new printing UIClient calls.
2085
2086         * MiniBrowser/mac/BrowserWindowController.m:
2087         (-[BrowserWindowController awakeFromNib]):
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::createOtherPage):
2090         (WTR::TestController::initialize):
2091
2092 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2093
2094         Reviewed by Ojan Vafai.
2095
2096         Change webkitpy/layout_tests/port/test.py to use the
2097         in-memory filesystem for cleaner unit testing. This
2098         change allows us to kill a lot of code that was
2099         specific to the test port, at the cost of being a
2100         little less clear about how things would work if
2101         you didn't have a filesystem.
2102
2103         https://bugs.webkit.org/show_bug.cgi?id=52605
2104
2105         * Scripts/webkitpy/layout_tests/port/test.py:
2106
2107 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2108
2109         Unreviewed, build fix.
2110
2111         Fix test failure caused by committing attachment 79368 instead
2112         of attachment 79461 on bug 52604.
2113
2114         * Scripts/webkitpy/common/system/filesystem_mock.py:
2115
2116 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2117
2118         Reviewed by Mihai Parparita.
2119
2120         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2121         unit testing. os.walk() is too much of a hassle to implement on
2122         top of the in-memory mock filesystem and adding the necessary
2123         interface to files_under() gives clients a cleaner API anyway
2124         (for this particular usage model).
2125
2126         https://bugs.webkit.org/show_bug.cgi?id=52691
2127
2128         * Scripts/webkitpy/common/system/filesystem.py:
2129         * Scripts/webkitpy/common/system/filesystem_mock.py:
2130         * Scripts/webkitpy/layout_tests/port/test_files.py:
2131         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2132
2133 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2134
2135         Reviewed by Tony Chang.
2136
2137         Change more modules in the layout-tests code to use the
2138         filesystem wrapper for cleaner unit testing.
2139
2140         This patch also adds the glob() wrapper to the filesystem
2141         abstraction.
2142         
2143         https://bugs.webkit.org/show_bug.cgi?id=52604
2144
2145         * Scripts/webkitpy/layout_tests/port/test_files.py:
2146         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2147         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2148         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2149         * Scripts/webkitpy/common/system/filesystem.py:
2150         * Scripts/webkitpy/common/system/filesystem_mock.py:
2151
2152 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2153
2154         Unreviewed.
2155
2156         Updating my email addresses and irc nick.
2157
2158         * Scripts/webkitpy/common/config/committers.py:
2159
2160 2011-01-19  Tony Chang  <tony@chromium.org>
2161
2162         Reviewed by Mihai Parparita.
2163
2164         [chromium] [linux] if check-sys-deps fails, output the failure reason
2165         https://bugs.webkit.org/show_bug.cgi?id=52671
2166
2167         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2168             error handler functions.
2169         * Scripts/webkitpy/layout_tests/port/chromium.py:
2170             output the error text from --check-sys-deps
2171         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2172
2173 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2174
2175         Reviewed by Andreas Kling.
2176
2177         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2178         https://bugs.webkit.org/show_bug.cgi?id=52554
2179         
2180         QtNetworkAccessManager is created in a thread and set as
2181         member variable in QWebPage. When the thread is destroyed
2182         the object is still used. So fix will set the object to
2183         NULL once the thread is destroyed.
2184
2185         * QtTestBrowser/launcherwindow.cpp:
2186         (LauncherWindow::~LauncherWindow):
2187
2188 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2189
2190         Rubber stamped by Csaba Osztrogonac
2191
2192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2193
2194 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2195
2196         Reviewed by Tony Chang.
2197
2198         new-run-webkit-tests: add a --build-directory command line argument
2199
2200         Official Google Chrome builds use a non-standard build directory
2201         location. This patch adds a --build-directory argument that
2202         allows that location to be specified on the command line. Only
2203         Chromium-based builds will use this flag for now, but anyone can
2204         in the future.
2205
2206         There are no unit tests for this since it's difficult to test
2207         until mock filesystems are fully supported in the code. This was
2208         tested by hand for now.
2209
2210         https://bugs.webkit.org/show_bug.cgi?id=52694
2211
2212         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2213         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2214         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2216
2217 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2218
2219         Not reviewed. Bot fix.
2220
2221         Remove an inadvertently committed debugging print.
2222
2223         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2224         (LayoutTestController::notifyDone):
2225
2226 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2227
2228         Reviewed by Sam Weinig.
2229
2230         WebKitTestRunner should track loading more like DumpRenderTree
2231         https://bugs.webkit.org/show_bug.cgi?id=52692
2232
2233         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2234         This makes some tests that call notifyDone multiple times pass.
2235         
2236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2237         (WTR::InjectedBundle::InjectedBundle):
2238         (WTR::InjectedBundle::done):
2239         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2240         (WTR::InjectedBundle::topLoadingFrame):
2241         (WTR::InjectedBundle::setTopLoadingFrame):
2242         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2243         (WTR::InjectedBundlePage::InjectedBundlePage):
2244         (WTR::InjectedBundlePage::stopLoading):
2245         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2246         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2247         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2248         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2250         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2251         (WTR::LayoutTestController::notifyDone):
2252         * WebKitTestRunner/TestController.cpp:
2253         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2254
2255 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2256
2257         Reviewed by Kent Tamura.
2258
2259         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2260         https://bugs.webkit.org/show_bug.cgi?id=52678
2261         
2262         Update path now that WebKit is inside Source.
2263
2264         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2265
2266 2011-01-18  Robert Hogan  <robert@webkit.org>
2267
2268         Reviewed by Simon Hausmann.
2269
2270         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2271         https://bugs.webkit.org/show_bug.cgi?id=44282
2272
2273         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2274         (WebCore::DumpRenderTree::dump):
2275
2276 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2277
2278         Reviewed by Mihai Parparita.
2279
2280         Fix a small race condition that could cause the unit tests for
2281         new-run-webkit-tests to fail in a multithreaded environment.
2282         There was a small window in the code where one thread would
2283         check to see if a thread had raised an exception, do something,
2284         and then check to see if the thread was alive. If the other
2285         thread raised an exception and exited in between these two
2286         steps, the exception would be lost. Flipping the order of the
2287         two checks fixes the race, since we will now always check for an
2288         exception on the thread before exiting.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=51579
2291
2292         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2293
2294 2011-01-18  Eric Seidel  <eric@webkit.org>
2295
2296         Reviewed by Adam Barth.
2297
2298         commit-queue dies when test archiving fails
2299         https://bugs.webkit.org/show_bug.cgi?id=52617
2300
2301         I looked at the machine and it had 10 archives already
2302         thus find_unused_name was returning None.  I've upped
2303         the limit to 100 (per bug) and tested the case where
2304         find_unused_name returns None (making archive return None).
2305
2306         * Scripts/webkitpy/common/system/workspace.py:
2307         * Scripts/webkitpy/common/system/workspace_unittest.py:
2308         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2309         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2310         * Scripts/webkitpy/tool/commands/queues.py:
2311
2312 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2313
2314         Reviewed by Ojan Vafai.
2315
2316         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2317         filesystem. Also fix a couple of "with" statements missed by
2318         r76050.
2319
2320         https://bugs.webkit.org/show_bug.cgi?id=52487
2321
2322         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2323
2324 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2325
2326         Reviewed by Martin Robinson.
2327
2328         [Gtk] Build fixes for gtk3 build
2329         https://bugs.webkit.org/show_bug.cgi?id=52648
2330
2331         * DumpRenderTree/gtk/EventSender.cpp:
2332         (beginDragWithFilesCallback):
2333
2334 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2335
2336         Reviewed by Mihai Parparita.
2337
2338         Update rebaseline-chromium-webkit-tests to use filesystem objects
2339         instead of direct references to os.path, shutil, tempfile, etc.
2340
2341         This patch doesn't change anything, but will allow subsequent
2342         patches to change the unit tests to no longer use the real
2343         filesystem.
2344
2345         This patch adds a bunch more methods to the filesystem object as
2346         well.
2347
2348         https://bugs.webkit.org/show_bug.cgi?id=52482
2349
2350         * Scripts/webkitpy/common/system/filesystem.py:
2351         * Scripts/webkitpy/common/system/filesystem_mock.py:
2352         * Scripts/webkitpy/tool/commands/queues.py:
2353         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2354         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2355
2356 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2357
2358         Reviewed by Mihai Parparita.
2359
2360         new-run-webkit-tests shouldn't crash when you try to run a
2361         directory containing only skipped files.
2362
2363         https://bugs.webkit.org/show_bug.cgi?id=52478
2364         
2365         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2366         * Scripts/webkitpy/layout_tests/port/test.py:
2367         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2368
2369 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2370
2371         Reviewed by Gustavo Noronha Silva.
2372
2373         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2374         https://bugs.webkit.org/show_bug.cgi?id=40833
2375
2376         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2377         GTK+ event sender.
2378         (dragWithFilesDragDataGetCallback): Added.
2379         (dragWithFilesDragEndCallback): Added.
2380         (beginDragWithFilesCallback): Added.
2381
2382 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2383
2384         Reviewed by Adam Barth.
2385
2386         ews: Add additional watcher to efl ews
2387         https://bugs.webkit.org/show_bug.cgi?id=52613
2388
2389         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2390
2391         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2392
2393 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2394
2395         Reviewed by Alexey Proskuryakov.
2396
2397         Fix some headers with missing or misspelled #ifndef guards
2398         https://bugs.webkit.org/show_bug.cgi?id=52545
2399
2400         * DumpRenderTree/chromium/TestEventPrinter.h:
2401         * DumpRenderTree/chromium/WebPreferences.h:
2402
2403 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2404
2405         Reviewed by Anders Carlsson.
2406
2407         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2408         navigating back to an unreachable URL
2409         https://bugs.webkit.org/show_bug.cgi?id=52388
2410
2411         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2412
2413         * DumpRenderTree/LayoutTestController.cpp:
2414         (queueLoadHTMLStringCallback):
2415         (LayoutTestController::queueLoadHTMLString):
2416         (LayoutTestController::queueLoadAlternateHTMLString):
2417         * DumpRenderTree/LayoutTestController.h:
2418
2419         * DumpRenderTree/WorkQueueItem.h:
2420         (LoadHTMLStringItem::LoadHTMLStringItem):
2421
2422         * DumpRenderTree/chromium/LayoutTestController.cpp:
2423         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2424         (WorkItemLoadHTMLString::run):
2425         (LayoutTestController::queueLoadHTMLString):
2426
2427         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2428         (LoadHTMLStringItem::invoke):
2429         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2430         (LoadHTMLStringItem::invoke):
2431         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2432         (LoadHTMLStringItem::invoke):
2433
2434 2011-01-17  Dan Bernstein  <mitz@apple.com>
2435
2436         Rubber-stamped by Mark Rowe.
2437
2438         Update xcodeproj svn:ignore to include xcuserdata.
2439
2440         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2441         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2442         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2443         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2444         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2445
2446 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2447
2448         Unreviewed fix after r75908.
2449
2450         Move WebKit into Source
2451         https://bugs.webkit.org/show_bug.cgi?id=52530
2452
2453         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2454
2455 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2456
2457         Unreviewed.
2458
2459         Remove accidentally committed debug printing after r75908.
2460
2461         * Scripts/webkitdirs.pm:
2462
2463 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2464
2465         Unreviewed.
2466
2467         Add myself to committers list
2468         https://bugs.webkit.org/show_bug.cgi?id=52566
2469
2470         * Scripts/webkitpy/common/config/committers.py:
2471
2472 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2473
2474         Reviewed by Jeremy Orlow.
2475
2476         GeolocationController should call stopUpdating on destruction
2477         https://bugs.webkit.org/show_bug.cgi?id=52216
2478
2479         fast/dom/Geolocation/window-close-crash.html requires that a
2480         Geolocation watch be started in a secondary window. Consequently,
2481         we need to allow geolocation permission and provide a mock
2482         geolocation position for the secondary window's
2483         GeolocationClientMock.
2484
2485         * DumpRenderTree/chromium/LayoutTestController.cpp:
2486         (LayoutTestController::setGeolocationPermission):
2487         (LayoutTestController::setMockGeolocationPosition):
2488         (LayoutTestController::setMockGeolocationError):
2489         * DumpRenderTree/chromium/TestShell.h:
2490         (TestShell::windowList):
2491
2492 2011-01-16  Adam Barth  <abarth@webkit.org>
2493
2494         Update more include paths to reflect WebKit move.
2495
2496         * DumpRenderTree/chromium/EventSender.cpp:
2497         (EventSender::keyDown):
2498         (EventSender::needsShiftModifier):
2499         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2500         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2501
2502 2011-01-16  Kent Tamura  <tkent@chromium.org>
2503
2504         Unreviewed, Chromium build fix.
2505
2506         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2507
2508 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2509
2510         Build fix for GTK+ after source directory movement.
2511
2512         * GNUmakefile.am: Correct include paths.
2513
2514 2011-01-16  Adam Barth  <abarth@webkit.org>
2515
2516         Teach svn-apply about WebKit move.
2517
2518         * Scripts/VCSUtils.pm:
2519
2520 2011-01-16  Adam Barth  <abarth@webkit.org>
2521
2522         Rubber-stamped by Eric Seidel.
2523
2524         Move WebKit into Source
2525         https://bugs.webkit.org/show_bug.cgi?id=52530
2526
2527         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2528         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2529         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2530         * DumpRenderTree/qt/GCControllerQt.cpp:
2531         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2532         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2533         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2534         * DumpRenderTree/wscript:
2535         * QtTestBrowser/launcherwindow.h:
2536         * Scripts/build-webkit:
2537         * Scripts/webkitdirs.pm:
2538
2539 2011-01-15  Adam Barth  <abarth@webkit.org>
2540
2541         Teach svn-apply about WebKit2 move.
2542
2543         * Scripts/VCSUtils.pm:
2544
2545 2011-01-15  Adam Barth  <abarth@webkit.org>
2546
2547         Rubber-stamped by Eric Seidel.
2548
2549         Move WebKit2 into Source
2550         https://bugs.webkit.org/show_bug.cgi?id=52438
2551
2552         * MiniBrowser/qt/MiniBrowser.pro:
2553         * Scripts/build-webkit:
2554         * Scripts/do-file-rename:
2555         * Scripts/do-webcore-rename:
2556         * Scripts/test-webkitpy:
2557         * Scripts/webkitdirs.pm:
2558         * Scripts/webkitpy/style/checker.py:
2559         * WebKitTestRunner/DerivedSources.pro:
2560         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2561         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2562
2563 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2564
2565         Reviewed by David Levin.
2566
2567         [chromium] remove obsolete createView method
2568         https://bugs.webkit.org/show_bug.cgi?id=52437
2569
2570         * DumpRenderTree/chromium/WebViewHost.cpp:
2571         (WebViewHost::createView):
2572         * DumpRenderTree/chromium/WebViewHost.h:
2573
2574 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2575
2576         Reviewed by Geoff Garen.
2577
2578         ShouldLoadResourceForFrame should use strings, not URLs.
2579         https://bugs.webkit.org/show_bug.cgi?id=52476
2580
2581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2582         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2584
2585 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2586
2587         Reviewed by David Levin.
2588
2589         Add Tony Gentilcore as a reviewer
2590         https://bugs.webkit.org/show_bug.cgi?id=52480
2591
2592         * Scripts/webkitpy/common/config/committers.py:
2593
2594 2011-01-14  David Levin  <levin@chromium.org>
2595
2596         Reviewed by Eric Seidel.
2597
2598         check-webkit-style: _FunctionState should keep track of where the function name starts.
2599         https://bugs.webkit.org/show_bug.cgi?id=52454
2600
2601         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2602         _FunctionState and logic for setting it correctly.
2603         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2604
2605 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2606
2607         Reviewed by David Levin.
2608
2609         Add support to DumpRenderTree to use the GPU rather than software renderer
2610         https://bugs.webkit.org/show_bug.cgi?id=52333
2611
2612         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2613         (main):
2614         * Scripts/webkitpy/layout_tests/port/chromium.py:
2615         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2616
2617 2011-01-14  Tony Chang  <tony@chromium.org>
2618
2619         Reviewed by Kent Tamura.
2620
2621         [chromium] update fonts.conf to fix 6 linux tests in drt
2622         https://bugs.webkit.org/show_bug.cgi?id=52411
2623
2624         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2625             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2626
2627 2011-01-14  Eric Seidel  <eric@webkit.org>
2628
2629         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2630
2631         Reviewed by Adam Barth.
2632
2633         Fix when running Tools/Scripts/check-webkit-style without arguments.
2634         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2635
2636         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2637         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2638
2639 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2640
2641         Reviewed by David Levin.
2642
2643         Store the tempdir object in a variable so it doesn't get deleted too early.
2644         https://bugs.webkit.org/show_bug.cgi?id=51875
2645
2646         * Scripts/update-webkit-auxiliary-libs:
2647         * Scripts/update-webkit-support-libs:
2648
2649 2011-01-14  Eric Seidel  <eric@webkit.org>
2650
2651         Unreviewed.  Make it work in python 2.5.
2652
2653         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2654         https://bugs.webkit.org/show_bug.cgi?id=49158
2655
2656         * Scripts/webkitpy/common/checkout/api_unittest.py:
2657
2658 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2659
2660         Unreviewed, rolling out r75774.
2661         http://trac.webkit.org/changeset/75774
2662         https://bugs.webkit.org/show_bug.cgi?id=52431
2663
2664         gtk builds were broken (Requested by loislo2 on #webkit).
2665
2666         * Scripts/webkitpy/common/checkout/scm.py:
2667
2668 2011-01-14  David Levin  <levin@chromium.org>
2669
2670         Reviewed by Shinichiro Hamaji.
2671
2672         check-webkit-style: _FunctionState should detect pure functions.
2673         https://bugs.webkit.org/show_bug.cgi?id=52428
2674
2675         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2676         is a pure virtual function.
2677         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2678         virtual functions are correctly detected.
2679
2680 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2681
2682         Reviewed by Yury Semikhatsky.
2683
2684         Just small fix for problem with check-webkit-style.
2685         It just didn't work for this patch.
2686         Old code can't concatenate a list of strings with None.
2687
2688         * Scripts/webkitpy/common/checkout/scm.py:
2689
2690 2011-01-13  David Levin  <levin@chromium.org>
2691
2692         Reviewed by Shinichiro Hamaji.
2693
2694         check-webkit-style: _FunctionState should use Position to know where items are.
2695         https://bugs.webkit.org/show_bug.cgi?id=52424
2696
2697         * Scripts/webkitpy/style/checkers/cpp.py:
2698         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2699         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2700         did some minor clean-up.
2701         (*): Other changes are simply about converting to use the Position's in_FunctionState
2702         instead of line numbers.
2703         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2704         to verify the positions stored in _FunctionState.
2705
2706 2011-01-13  Eric Seidel  <eric@webkit.org>
2707
2708         Reviewed by David Levin.
2709
2710         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2711         https://bugs.webkit.org/show_bug.cgi?id=49158
2712
2713         This is not the most elegant, but it is a very safe fix to this bug.
2714         One advantage of catching ScriptError like this instead of adding a
2715         new added_or_modified_files or fixing all changed_files callers
2716         to use a more specific change_files variant, is that we catch
2717         all kinds of ScriptErrors which might cause our (non-essential)
2718         suggest-reviewers code to fail out.  This should make passing
2719         --suggest-reviewers to webkit-patch upload much more robust
2720         and may even make it possible for us to make it default.
2721
2722         The root of the problem here is that SCM.changed_files includes
2723         deleted ChangeLog paths (from moves, etc) which then when we ask
2724         SVN/Git for the contents of the file at that revision, the command
2725         errors out and Executive.run_command raises a ScriptError.
2726
2727         In the future we might fix this differently by making all current
2728         callers of chagned_files use a more specific method for requesting
2729         what types of changes they're interested in (adds, modifies, deletes, etc.)
2730
2731         * Scripts/webkitpy/common/checkout/api.py:
2732         * Scripts/webkitpy/common/checkout/api_unittest.py:
2733
2734 2011-01-13  Dan Bernstein  <mitz@apple.com>
2735
2736         Reviewed by Alexey Proskuryakov.
2737
2738         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2739         https://bugs.webkit.org/show_bug.cgi?id=52419
2740
2741         Allow to further control the behavior of the willSendRequest delegate callback by making it
2742         set a different URL in the new request.
2743
2744         * DumpRenderTree/LayoutTestController.cpp:
2745         (addURLToRedirectCallback): Added.
2746         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2747         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2748         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2749         * DumpRenderTree/LayoutTestController.h:
2750         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2751         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2752         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2753         change the URL in the new request to the redirect destination.
2754
2755 2011-01-13  Eric Seidel  <eric@webkit.org>
2756
2757         Reviewed by Mihai Parparita.
2758
2759         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2760         https://bugs.webkit.org/show_bug.cgi?id=52416
2761
2762         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2763         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2764
2765         I also added FIXMEs about the changed_files returning deleted files problem
2766         which is causing the other most common exception for suggest-reviewers
2767         (and is probably breaking sheriff-bots blame detection).
2768
2769         * Scripts/webkitpy/common/checkout/api.py:
2770         * Scripts/webkitpy/common/checkout/api_unittest.py:
2771         * Scripts/webkitpy/common/checkout/scm.py:
2772
2773 2011-01-13  Eric Seidel  <eric@webkit.org>
2774
2775         Reviewed by Adam Barth.
2776
2777         results archives from commit-queue are too large to upload
2778         https://bugs.webkit.org/show_bug.cgi?id=52405
2779
2780         * Scripts/webkitpy/common/system/filesystem.py:
2781         * Scripts/webkitpy/common/system/filesystem_mock.py:
2782         * Scripts/webkitpy/tool/commands/queues.py:
2783
2784 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2785
2786         Reviewed by Martin Robinson.
2787
2788         [gtk] Zero-sized font does not yet work
2789         https://bugs.webkit.org/show_bug.cgi?id=49793
2790
2791         Set minimum-font-size to 0 for the DRT.
2792
2793         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2794         (resetDefaultsToConsistentValues):
2795
2796 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2797
2798         Reviewed by Darin Adler.
2799
2800         Make old-run-webkit-tests more robust on buildbots
2801         https://bugs.webkit.org/show_bug.cgi?id=52364
2802
2803         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2804
2805 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2806
2807         Reviewed by Darin Adler.
2808
2809         Make old-run-webkit-tests more robust on buildbots
2810         https://bugs.webkit.org/show_bug.cgi?id=52364
2811
2812         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2813
2814 2011-01-13  Tony Chang  <tony@chromium.org>
2815
2816         Reviewed by Kent Tamura.
2817
2818         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2819         https://bugs.webkit.org/show_bug.cgi?id=52332
2820
2821         Forked Info.plist is not longer needed.
2822
2823         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2824
2825 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2826
2827         Reviewed by Timothy Hatcher.
2828
2829         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2830         to be passed directly to WebInspector.UIString
2831
2832         https://bugs.webkit.org/show_bug.cgi?id=52365
2833
2834         * Scripts/check-inspector-strings:
2835
2836 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2837
2838         Unreviewed, rolling out r74881.
2839         http://trac.webkit.org/changeset/74881
2840         https://bugs.webkit.org/show_bug.cgi?id=52357
2841
2842         The EFL builder has been red for days (Requested by abarth on
2843         #webkit).
2844
2845         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2846         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2847
2848 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2849
2850         Reviewed by David Levin.
2851
2852         Add beforeunload support to WebKitTestRunner
2853         https://bugs.webkit.org/show_bug.cgi?id=52353
2854         
2855         This makes a number of currently failing tests pass.
2856
2857         * WebKitTestRunner/TestController.cpp:
2858         (WTR::runBeforeUnloadConfirmPanel):
2859         (WTR::createOtherPage):
2860         (WTR::TestController::initialize):
2861
2862 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2863
2864         Reviewed by Sam Weinig.
2865
2866         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2867         https://bugs.webkit.org/show_bug.cgi?id=52330
2868
2869         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2870         a web process crash.
2871         * WebKitTestRunner/TestController.cpp:
2872         (WTR::TestController::initialize): Set up a processDidCrash
2873         callback.
2874         (WTR::TestController::processDidCrash): Report that the Web process
2875         crashed.
2876         * WebKitTestRunner/TestController.h:
2877
2878 2011-01-12  David Levin  <levin@chromium.org>
2879
2880         Reviewed by Shinichiro Hamaji.
2881
2882         check-webkit-style -- close_expression function doesn't work correctly.
2883         https://bugs.webkit.org/show_bug.cgi?id=52272
2884
2885         * Scripts/webkitpy/style/checkers/cpp.py:
2886         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2887         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2888         generally useful (for upcoming code changes).
2889         (close_expression): Changed to use Position for input and output.
2890         Also, fixed many bugs such as only working correctly for parenthesis,
2891         not working correctly if given an offset in a line and not finding
2892         the real closing element if there were multiple closing elements in
2893         the same line.
2894         (detect_functions): Adjusted due to the change in arguments for
2895         close_expression.
2896         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2897         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2898         two positions are the same.
2899         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2900         (CppStyleTest.test_close_expression): Added tests to catch the issues
2901         that were fixed.
2902
2903 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2904
2905         Unreviewed, rolling out r75576.
2906         http://trac.webkit.org/changeset/75576
2907         https://bugs.webkit.org/show_bug.cgi?id=52304
2908
2909         broke rebaseline-chromium-webkit-test (Requested by thakis on
2910         #webkit).
2911
2912         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2913         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2914         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2915         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2916         * Scripts/webkitpy/layout_tests/port/base.py:
2917         * Scripts/webkitpy/layout_tests/port/chromium.py:
2918         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2919         * Scripts/webkitpy/layout_tests/port/test.py:
2920         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2922         * Scripts/webkitpy/style/checkers/test_expectations.py:
2923         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2924
2925 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2926
2927         Reviewed by Darin Adler.
2928
2929         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2930         https://bugs.webkit.org/show_bug.cgi?id=52307
2931
2932         * Scripts/old-run-webkit-tests:
2933
2934 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2935
2936         Reviewed by Martin Robinson.
2937
2938         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2939         https://bugs.webkit.org/show_bug.cgi?id=50867
2940
2941         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2942         TestNetscapePlugin.cpp 
2943
2944         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2945         * Scripts/webkitdirs.pm:
2946
2947 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2948
2949         Reviewed by Pavel Feldman.
2950
2951         Add check-inspector-strings script.
2952
2953         https://bugs.webkit.org/show_bug.cgi?id=52295
2954
2955         * Scripts/check-inspector-strings: Added.
2956
2957 2011-01-12  Adam Roben  <aroben@apple.com>
2958
2959         Advertise the .testnetscape file extension on Windows
2960
2961         Fixes <http://webkit.org/b/52298>
2962         plugins/no-mime-with-valid-extension.html fails on Windows
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2967         FileExtents field to map the .testnetscape file extension to the
2968         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2969
2970 2011-01-12  Adam Barth  <abarth@webkit.org>
2971
2972         Reviewed by Eric Seidel.
2973
2974         Make webkit-patch support subdirectories for SVN checkouts
2975         https://bugs.webkit.org/show_bug.cgi?id=52261
2976
2977         os.relpath does not exist on Python 2.5, so we need to call our version
2978         of the API.
2979
2980         * Scripts/webkitpy/common/checkout/scm.py:
2981
2982 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2983
2984         Reviewed by Eric Seidel.
2985
2986         Close additional pages opened during a test once the test completes.
2987         https://bugs.webkit.org/show_bug.cgi?id=52276
2988
2989         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2990         (WTR::InjectedBundle::done):
2991
2992 2011-01-11  David Levin  <levin@chromium.org>
2993
2994         Reviewed by Eric Seidel.
2995
2996         Errors should be separated from the command line in bot messages.
2997         https://bugs.webkit.org/show_bug.cgi?id=52275
2998
2999         * Scripts/webkitpy/common/system/executive.py:
3000         (ScriptError.message_with_output): Added a newline to separate the command
3001         line from the errors.
3002         * Scripts/webkitpy/common/system/executive_unittest.py:
3003         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3004         paths in message_with_output.
3005
3006 2011-01-11  Eric Seidel  <eric@webkit.org>
3007
3008         Unreviewed.
3009
3010         commit-queue should know how to upload archived results (for test flakes or general failures)
3011         https://bugs.webkit.org/show_bug.cgi?id=52048
3012
3013         The zips are mostly empty due to forgetting -r.
3014         Expected diffs were not being pulled from the archive due
3015         to the archive having longer paths than I realized.
3016
3017         * Scripts/webkitpy/common/system/workspace.py:
3018         * Scripts/webkitpy/common/system/workspace_unittest.py:
3019         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3020         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3021
3022 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3023
3024         Reviewed by Ojan Vafai.
3025
3026         The current modifier parsing code in test_expectations is
3027         fragile and hard-coded, so it's not easy to understand the logic
3028         or easily add new types of modifiers (like GPU vs. CPU testing
3029         for graphics tests, or 32-bit vs. 64-bit differences).
3030
3031         This is the first of two patches that will add in more generic
3032         support and then eliminate the GPU-specific test expectations
3033         files for Chromium.
3034
3035         This patch adds two standalone objects for handling modifiers. The
3036         rules for interpreting modifiers, precedence, and conflicts are
3037         given in the docstring to the ModifierMatcher class, which
3038         returns ModifierMatchResult objects.
3039         
3040         This patch also adds routines to the Port interface and a
3041         default set of values in the base object, in order to obtain the
3042         values needed on a given test run. These values are then passed
3043         to the expectation parser. This also allows us to clean up the
3044         logic used to lint all of the different configurations in a
3045         single test_expectations.txt file.
3046
3047         The next patch will merge in the separate GPU expectations file.
3048
3049         https://bugs.webkit.org/show_bug.cgi?id=51222
3050
3051         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3052         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3053         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3054         * Scripts/webkitpy/layout_tests/port/base.py:
3055         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3056         * Scripts/webkitpy/layout_tests/port/chromium.py:
3057         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3058         * Scripts/webkitpy/layout_tests/port/test.py:
3059         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3060         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3061
3062 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3063
3064         Reviewed by Adam Barth.
3065
3066         Make webkit-patch support subdirectories for SVN checkouts
3067         https://bugs.webkit.org/show_bug.cgi?id=52261
3068
3069         * Scripts/webkitpy/common/checkout/scm.py:
3070         * Scripts/webkitpy/style_references.py:
3071         * Scripts/webkitpy/tool/main.py:
3072         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3073
3074 2011-01-11  Eric Seidel  <eric@webkit.org>
3075
3076         Unreviewed.
3077
3078         commit-queue should know how to upload archived results (for test flakes or general failures)
3079         https://bugs.webkit.org/show_bug.cgi?id=52048
3080
3081         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3082         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3083
3084         * Scripts/webkitpy/common/system/workspace.py:
3085         * Scripts/webkitpy/common/system/workspace_unittest.py:
3086         * Scripts/webkitpy/tool/commands/queues.py:
3087
3088 2011-01-11  Sam Weinig  <sam@webkit.org>
3089
3090         Roll r75474 back in.
3091
3092 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3093
3094         Reviewed by Kenneth Rohde Christiansen.
3095
3096         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3097         https://bugs.webkit.org/show_bug.cgi?id=51204
3098
3099         * QtTestBrowser/webpage.h:
3100         (QtNAMThread::QtNAMThread):
3101         (QtNAMThread::networkAccessManager):
3102         (QtNAMThread::run):
3103
3104 2011-01-11  Peter Varga  <pvarga@webkit.org>
3105
3106         Unreviewed.
3107
3108         Add myself to committers' list.
3109
3110         * Scripts/webkitpy/common/config/committers.py:
3111
3112 2011-01-11  Eric Seidel  <eric@webkit.org>
3113
3114         Reviewed by Adam Barth.
3115
3116         commit-queue should know how to upload archived results (for test flakes or general failures)
3117         https://bugs.webkit.org/show_bug.cgi?id=52048
3118
3119         Now the queue will always upload results.  Either the entire zip, or just
3120         the diffs.txt in the case of text failures.
3121
3122         This should make understanding flakes much easier, and paves the way
3123         for having the EWS run layout tests (and upload failures).
3124
3125         In order to upload .zip files I had to teach bugzilla.py to autodetect
3126         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3127         for .patch files, I have it add one before calling guess_type.
3128
3129         We may find that always uploading the whole zip instead of just the -diffs.txt
3130         file is preferable, but for now I'm keeping the old behavior because it makes
3131         quickly understanding text failures easy.
3132
3133         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3134         * Scripts/webkitpy/common/system/workspace.py: Added.
3135         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3136         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3137         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3138         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3139         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3140         * Scripts/webkitpy/tool/commands/queues.py:
3141         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3142
3143 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3144
3145         Unreviewed, rolling out r75464.
3146         http://trac.webkit.org/changeset/75464
3147         https://bugs.webkit.org/show_bug.cgi?id=52193
3148
3149         Followup rollout for 75474 (Requested by Ossy on #webkit).
3150
3151         * MiniBrowser/mac/BrowserWindowController.m:
3152         (-[BrowserWindowController awakeFromNib]):
3153         * MiniBrowser/win/BrowserView.cpp:
3154         (BrowserView::create):
3155         * WebKitTestRunner/TestController.cpp:
3156         (WTR::createOtherPage):
3157         (WTR::TestController::initialize):
3158
3159 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3160
3161         Reviewed by Csaba Osztrogonác.
3162
3163         [Qt] Baseline qt_minimal configuration
3164         https://bugs.webkit.org/show_bug.cgi?id=51313
3165
3166         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3167         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3168         QT_NO_UNDOSTACK guard.
3169
3170         * QtTestBrowser/launcherwindow.cpp:
3171         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3172         guards.
3173         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3174         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3175         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3176         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3177
3178         * QtTestBrowser/launcherwindow.h:
3179         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3180         * QtTestBrowser/locationedit.h: Ditto.
3181
3182         * QtTestBrowser/mainwindow.cpp:
3183         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3184         QT_NO_UNDOSTACK guards.
3185         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3186         (MainWindow::changeLocation): Ditto.
3187         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3188         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3189
3190         * QtTestBrowser/webpage.cpp:
3191         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3192         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3193
3194         * QtTestBrowser/webview.cpp:
3195         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3196         (WebViewGraphicsBased::animatedYFlip): Ditto.
3197
3198 2011-01-10  Sam Weinig  <sam@webkit.org>
3199
3200         Fix build.
3201
3202         * MiniBrowser/mac/BrowserWindowController.m:
3203         (-[BrowserWindowController awakeFromNib]):
3204         * MiniBrowser/win/BrowserView.cpp:
3205         (BrowserView::create):
3206         * WebKitTestRunner/TestController.cpp:
3207         (WTR::createOtherPage):
3208         (WTR::TestController::initialize):
3209
3210 2011-01-10  Eric Seidel  <eric@webkit.org>
3211
3212         Reviewed by Ojan Vafai.
3213
3214         style-queue messages are way too long for big patches
3215         https://bugs.webkit.org/show_bug.cgi?id=52161
3216
3217         We definitely could build much fancier list-to-string-with-limit functions
3218         but this should be sufficient for our needs at the moment.
3219
3220         * Scripts/webkitpy/common/system/executive.py:
3221         * Scripts/webkitpy/common/system/executive_unittest.py:
3222
3223 2011-01-10  Tony Chang  <tony@chromium.org>
3224
3225         Unreviewed, rolling out r75398.
3226         http://trac.webkit.org/changeset/75398
3227         https://bugs.webkit.org/show_bug.cgi?id=52008
3228
3229         Some layout tests are crashing on Chromium Win.
3230
3231         * DumpRenderTree/chromium/WebViewHost.cpp:
3232         (WebViewHost::updatePaintRect):
3233         * DumpRenderTree/chromium/WebViewHost.h:
3234
3235 2011-01-10  Adam Roben  <aroben@apple.com>
3236
3237         Roll out r75392
3238
3239         It isn't needed now that r75289 has been rolled out.
3240
3241         * Scripts/run-javascriptcore-tests:
3242
3243 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3244
3245         Reviewed by Anders Carlsson.
3246
3247         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3248         https://bugs.webkit.org/show_bug.cgi?id=52160
3249
3250         * WebKitTestRunner/mac/TestControllerMac.mm:
3251         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3252         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3253         anyway.
3254
3255 2011-01-10  Tony Chang  <tony@chromium.org>
3256
3257         Reviewed by Mihai Parparita.
3258
3259         [chromium] fix for animated gif layout tests
3260         https://bugs.webkit.org/show_bug.cgi?id=52008
3261
3262         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3263             to trigger gif animations.
3264         (WebViewHostPaintTask::WebViewHostPaintTask):
3265         (WebViewHostPaintTask::runIfValid):
3266         (WebViewHost::updatePaintRect):
3267         * DumpRenderTree/chromium/WebViewHost.h:
3268         (WebViewHost::taskList):
3269
3270 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3271
3272         Reviewed by Xan Lopez.
3273
3274         [GTK] Fix gtk2 compilation for master
3275         https://bugs.webkit.org/show_bug.cgi?id=51885
3276
3277         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3278         (createBitmapContextFromWebView): Replaced the old
3279         gdk_drawable_get_size with gdk_pixmap_get_size.
3280
3281 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3282
3283         Reviewed by Laszlo Gombos.
3284
3285         [WINCE] Reenable NPAPI after r75203
3286         https://bugs.webkit.org/show_bug.cgi?id=52109
3287
3288         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3289         it with !isEfl(), because EFL port does not support NPAPI (yet).
3290
3291         * Scripts/build-webkit:
3292
3293 2011-01-10  Adam Roben  <aroben@apple.com>
3294
3295         Skip some asserting JS tests
3296
3297         See <http://webkit.org/b/52156>.
3298
3299         * Scripts/run-javascriptcore-tests:
3300
3301 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3302
3303         Reviewed by Xan Lopez.
3304
3305         [GTK] build-webkit disable Blob support via arguments passed to automake
3306         https://bugs.webkit.org/show_bug.cgi?id=52097
3307
3308         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3309         build-webkit.
3310
3311 2011-01-10  Adam Roben  <aroben@apple.com>
3312
3313         Use the same name and description for TestNetscapePlugin on Windows and
3314         Mac
3315
3316         Fixes <http://webkit.org/b/52151>
3317         fast/frames/iframe-reparenting-plugins.html fails on Windows
3318
3319         Reviewed by Steve Falkenburg.
3320
3321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3322         the name and description from Mac's Info.plist.
3323
3324 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3325
3326         Reviewed by Laszlo Gombos.
3327
3328         [Qt][WK2] Guard gcc-specific syntax
3329
3330         Non-gcc based compliers choke on the "-include"
3331         syntax for preinclude, place guard around it.
3332
3333         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3334         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3335
3336 2011-01-10  Andreas Kling  <kling@webkit.org>
3337
3338         Reviewed by Simon Hausmann.
3339
3340         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3341         https://bugs.webkit.org/show_bug.cgi?id=52111
3342
3343         When getting a createNewPage() callback from QWKPage, create the
3344         new page with the same QWKContext as the page that is passed to
3345         the callback.
3346
3347         * MiniBrowser/qt/BrowserView.h:
3348         * MiniBrowser/qt/BrowserWindow.cpp:
3349         (newPageFunction):
3350         (BrowserWindow::BrowserWindow):
3351         * MiniBrowser/qt/BrowserWindow.h:
3352
3353 2011-01-10  Andreas Kling  <kling@webkit.org>
3354
3355         Reviewed by Kenneth Rohde Christiansen.
3356
3357         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3358
3359         BrowserView set its own useless createNewPage() callback on QWKPage.
3360         This was immediately overridden by BrowserWindow anyway, so remove
3361         the BrowserView one.
3362
3363         * MiniBrowser/qt/BrowserView.cpp:
3364         (BrowserView::BrowserView):
3365
3366 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3367
3368         Reviewed by Jeremy Orlow.
3369
3370         [Chromium] Remove non-client-based Geolocation code
3371         https://bugs.webkit.org/show_bug.cgi?id=50921
3372
3373         * DumpRenderTree/chromium/LayoutTestController.cpp:
3374         (LayoutTestController::setGeolocationPermission):
3375         (LayoutTestController::setMockGeolocationPosition):
3376         (LayoutTestController::setMockGeolocationError):
3377         * DumpRenderTree/chromium/WebViewHost.cpp:
3378         (WebViewHost::geolocationClientMock):
3379         (WebViewHost::reset):
3380         * DumpRenderTree/chromium/WebViewHost.h:
3381
3382 2011-01-10  Eric Seidel  <eric@webkit.org>
3383
3384         Reviewed by Adam Barth.
3385
3386         Commit bot tried to land r? cq+ patch
3387         https://bugs.webkit.org/show_bug.cgi?id=36638
3388
3389         It should now be possible to post a patch with r? and cq+ and the
3390         commit-queue will correctly wait for the r+ before attempting to land the patch.
3391         (This was a feature requested by several users.)
3392
3393         One caveat: We don't actually reject r-, cq+ patches from the queue
3394         (we just ignore them), but I think that's OK for now.
3395
3396         I also noticed that setting r- once a commit-queue node had grabbed
3397         a patch would not properly cancel the landing.  That's fixed and
3398         tested in this patch.
3399
3400         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3401         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3402         * Scripts/webkitpy/tool/bot/feeders.py:
3403         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3404
3405 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3406
3407         Reviewed by Kenneth Rohde Christiansen.
3408
3409         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3410         https://bugs.webkit.org/show_bug.cgi?id=51934
3411
3412         When accessing the network from the destructor of QWebPage, the network access manager
3413         was already deleted because the object WebPage was already destructed.
3414
3415         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3416         The object is now destructed in the destructor of QObject.
3417
3418         * QtTestBrowser/webpage.cpp:
3419         (WebPage::WebPage):
3420         (WebPage::setQnamThreaded):
3421         * QtTestBrowser/webpage.h:
3422         (QtNAMThread::QtNAMThread):
3423
3424 2011-01-08  Eric Seidel  <eric@webkit.org>
3425
3426         Reviewed by Ojan Vafai.
3427
3428         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3429         https://bugs.webkit.org/show_bug.cgi?id=52067
3430
3431         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3432         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3433
3434         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3435
3436 2011-01-08  Eric Seidel  <eric@webkit.org>
3437
3438         Reviewed by Mihai Parparita.
3439
3440         commit-queue hangs when the ChangeLog diff is bad
3441         https://bugs.webkit.org/show_bug.cgi?id=52072
3442
3443         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3444         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3445
3446 2011-01-08  Adam Barth  <abarth@webkit.org>
3447
3448         Teach svn-apply how to re-write WebCore to Source/WebCore.
3449
3450         * Scripts/VCSUtils.pm:
3451
3452 2011-01-07  Adam Barth  <abarth@webkit.org>
3453
3454         Rubber-stamped by Eric Seidel.
3455
3456         Move WebCore to Source
3457         https://bugs.webkit.org/show_bug.cgi?id=52050
3458
3459         Update the tools to understand WebCore's new location.
3460
3461         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3462         * DumpRenderTree/wscript:
3463         * GNUmakefile.am:
3464         * Scripts/build-webkit:
3465         * Scripts/do-file-rename:
3466         * Scripts/do-webcore-rename:
3467         * Scripts/generate-qt-inspector-resource:
3468         * Scripts/prepare-ChangeLog:
3469         * Scripts/run-bindings-tests:
3470         * Scripts/update-iexploder-cssproperties:
3471         * Scripts/update-sources-list.py:
3472         * Scripts/update-webkit-localizable-strings:
3473         * Scripts/webkitdirs.pm:
3474         * Scripts/webkitpy/common/config/build.py:
3475         * Scripts/webkitpy/common/config/build_unittest.py:
3476         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3477         * Scripts/webkitpy/style/checker.py:
3478         * Scripts/webkitpy/style/checker_unittest.py:
3479         * WebKitTestRunner/DerivedSources.pro:
3480         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3481         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3482         * wx/browser/wscript:
3483         * wx/build/settings.py:
3484
3485 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3486
3487         Reviewed by Sam Weinig.
3488
3489         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3490         https://bugs.webkit.org/show_bug.cgi?id=52086
3491
3492         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3493         (WTR::InjectedBundle::didReceiveMessage):
3494         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3495         (WTR::LayoutTestController::notifyDone):
3496         * WebKitTestRunner/TestController.cpp:
3497         (WTR::TestController::resetStateToConsistentValues):
3498         (WTR::TestController::run):
3499
3500 2011-01-07  James Robinson  <jamesr@chromium.org>
3501
3502         Revert "Implement mozilla's animationTime property"
3503         https://bugs.webkit.org/show_bug.cgi?id=51952
3504
3505         This approach isn't quite right.
3506
3507         * DumpRenderTree/chromium/WebViewHost.cpp:
3508         (WebViewHost::paintInvalidatedRegion):
3509
3510 2011-01-07  Adam Roben  <aroben@apple.com>
3511
3512         Build master fix
3513
3514         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3515         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3516
3517 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3518
3519         Reviewed by Csaba Osztrogonác.
3520
3521         run-qtwebkit-tests should be able to kill a testsuite.
3522
3523         Add new option in the script that can setup a timeout for a test.
3524         If the test execution takes more then specified time then the test
3525         would be terminated.
3526
3527         [Qt] run-qtwebkit-tests needs timeout
3528         https://bugs.webkit.org/show_bug.cgi?id=51894
3529
3530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3531         * Scripts/run-qtwebkit-tests:
3532
3533 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3534
3535         Unreviewed fix after r75233.
3536
3537         Based on idea from Eric Seidel.
3538
3539         Add remote zip file handling to webkitpy.
3540         https://bugs.webkit.org/show_bug.cgi?id=50901
3541
3542         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3543
3544 2011-01-07  Shane Stephens  <shanestephens@google.com>
3545
3546         Reviewed by Eric Seidel.
3547
3548         svn-apply: should support git binary delta diffs
3549         https://bugs.webkit.org/show_bug.cgi?id=38864
3550
3551         * Scripts/VCSUtils.pm:
3552         * Scripts/svn-apply:
3553
3554 2011-01-06  Julie Parent  <jparent@chromium.org>
3555
3556         Reviewed by Eric Seidel.
3557
3558         Test Result Server not removing old results.
3559         https://bugs.webkit.org/show_bug.cgi?id=52012
3560
3561         * TestResultServer/model/jsonresults.py:
3562         Fix off-by-one: Truncate if >= num_runs, not just >.
3563         * TestResultServer/model/jsonresults_unittest.py:
3564         Add unit test to test that merging in a new result with the same value
3565         as the last result causes previous result to fall off.
3566
3567 2011-01-06  James Kozianski  <koz@chromium.org>
3568
3569         Reviewed by Mihai Parparita.
3570
3571         Add classes to provide a consistent interface to a set of files.
3572         https://bugs.webkit.org/show_bug.cgi?id=50901
3573
3574         These classes allow us to write code that is agnostic to whether a
3575         particular set of files resides in a local directory or in a zip file
3576         on a remote machine.
3577
3578         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3579         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3580         * Scripts/webkitpy/common/system/fileset.py: Added.
3581         * Scripts/webkitpy/common/system/filesystem.py:
3582         * Scripts/webkitpy/common/system/filesystem_mock.py:
3583         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3584         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3585
3586 2011-01-06  Eric Seidel  <eric@webkit.org>
3587
3588         Reviewed by Adam Barth.
3589
3590         NetworkTransaction should log the url it is retrying
3591         https://bugs.webkit.org/show_bug.cgi?id=52043
3592
3593         * Scripts/webkitpy/common/net/networktransaction.py:
3594         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3595
3596 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3597
3598         Windows build fix.
3599         Import os before using it.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3602
3603 2011-01-06  Eric Seidel  <eric@webkit.org>
3604
3605         Reviewed by Adam Barth.
3606
3607         StyleQueue fails to report errors when patches have many files
3608         https://bugs.webkit.org/show_bug.cgi?id=52042
3609
3610         This is one of at least two errors preventing style error reporting at the moment.
3611         When we moved to passing the list of files to check explicitly,
3612         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3613         We could change the type of the QueueStatus.message type, or we could
3614         just teach statusserver.py how to clamp values (and warn when it does).
3615         I chose the latter path.
3616
3617         * Scripts/webkitpy/common/net/statusserver.py:
3618
3619 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3620
3621         Reviewed by Stephanie Lewis.
3622         
3623         Fix syntax error in script.
3624
3625         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3626         https://bugs.webkit.org/show_bug.cgi?id=51996
3627
3628         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3629
3630 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3631
3632         Unreviewed, fixing WinCE build after r75196.
3633
3634         WinCE port does not (yet) support NPAPI.
3635
3636         * Scripts/build-webkit:
3637
3638 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3639
3640         Reviewed by Darin Adler.
3641
3642         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3643         https://bugs.webkit.org/show_bug.cgi?id=52015
3644
3645         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3646         after the platform has been detected, otherwise the script will
3647         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3648         detection.
3649
3650 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3651
3652         Reviewed by Eric Seidel.
3653
3654         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3655         https://bugs.webkit.org/show_bug.cgi?id=51346
3656
3657         * Scripts/build-webkit:
3658
3659 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3660
3661         Reviewed by Adam Roben.
3662
3663         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3664         https://bugs.webkit.org/show_bug.cgi?id=51996
3665         
3666         After the configuration directory change, we were archiving the incorrect directory for
3667         build product, so we were running tests on the wrong binaries.
3668         
3669         This change archives the correct directory, and also unarchives it into a configuration-
3670         specific directory.
3671
3672         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3673         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3674
3675 2011-01-06  Eric Seidel  <eric@webkit.org>
3676
3677         Reviewed by Mihai Parparita.
3678
3679         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3680         https://bugs.webkit.org/show_bug.cgi?id=52002
3681
3682         See an example of this here:
3683         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3684
3685         It's due to the fact that we pass around TestFailure() instance
3686         objects and yet expect them to all compare to be the same.
3687
3688         This is bad.  We should either have shared instances of these values
3689         or we should just pass around the class names.  There are already hacks
3690         in place to make TestFailure objects pass equality tests, I just added
3691         a __hash__ implementation so they can be used in sets as expected.
3692
3693         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3694         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3695
3696 2011-01-06  Evan Martin  <evan@chromium.org>
3697
3698         Reviewed by Tony Chang.
3699
3700         [gdb] handle inaccessible memory and UChar*
3701         https://bugs.webkit.org/show_bug.cgi?id=52003
3702
3703         To pretty-print a UChar*, we just grope around in the memory
3704         looking for a terminating NUL.  We need to handle the exception
3705         that can occur when we poke into an invalid location.
3706
3707         Additionally, the logic for choosing which pretty-printer would
3708         early return before hitting the point where we'd use the UChar*
3709         printer.  (Did this ever work?  How did it regress?)
3710
3711         * gdb/webkit.py:
3712
3713 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3714
3715         Reviewed by Ada Chan.