1 2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
3 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
4 https://bugs.webkit.org/show_bug.cgi?id=150307
6 Reviewed by Brent Fulgham.
8 The DLL build rules have been changed to generate "{Name}Lib.DLL",
9 but these changes have not yet been applied to the Visual Studio builds.
11 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
13 2015-10-16 Andreas Kling <akling@apple.com>
15 [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
16 <https://webkit.org/b/150153>
20 Just use simple arrays of LChar and UChar for this test instead of creating String
21 objects and then getting the characters8()/characters16() from them, since that
22 doesn't guarantee null-termination (the bug.)
24 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
25 (TestWebKitAPI::TEST):
26 (TestWebKitAPI::build): Deleted.
28 2015-10-16 Tim Horton <timothy_horton@apple.com>
30 WebKit2.AutoLayoutIntegration API test is failing on some of the bots
31 https://bugs.webkit.org/show_bug.cgi?id=150255
33 Reviewed by Simon Fraser.
35 * Scripts/run-api-tests:
37 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
38 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
39 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
40 (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
41 (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
42 Don't set the layout size until after the load finishes and we're waiting
43 for the reply, so that there is no race between the new size coming in
44 and us waiting for it.
46 2015-10-16 Anders Carlsson <andersca@apple.com>
48 WebEditingDelegate should be a formal protocol
49 https://bugs.webkit.org/show_bug.cgi?id=150254
50 <rdar://problem/23149847>
52 Reviewed by Dan Bernstein.
54 * DumpRenderTree/mac/EditingDelegate.h:
55 Conform to the WebEditingDelegate protocol.
57 2015-10-16 Tim Horton <timothy_horton@apple.com>
59 Hook up autolayout intrinsic sizing for WKWebView
60 https://bugs.webkit.org/show_bug.cgi?id=150219
61 <rdar://problem/20016905>
63 Reviewed by Simon Fraser.
65 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
66 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
67 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
68 (-[AutoLayoutWKWebView load:expectingContentSize:]):
69 (-[AutoLayoutWKWebView expectContentSizeChange:]):
70 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
72 Add a variety of tests, including one which catches the bug that
73 the WebCore part of this patch fixes.
75 2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
77 Update the help message of --system-malloc
78 https://bugs.webkit.org/show_bug.cgi?id=150169
80 Reviewed by Geoffrey Garen.
82 * Scripts/webkitperl/FeatureList.pm:
84 2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
86 Update ImportExpectations according currently imported wpt tests
87 https://bugs.webkit.org/show_bug.cgi?id=150158
89 Reviewed by Chris Dumez.
91 * Scripts/webkitpy/w3c/test_downloader.py:
92 (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
94 2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
96 Unreviewed, Update my email address.
98 * Scripts/webkitpy/common/config/contributors.json:
100 2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
102 [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
103 https://bugs.webkit.org/show_bug.cgi?id=84960
105 Reviewed by Žan Doberšek.
107 * Scripts/run-gtk-tests:
108 (TestRunner): Unskip tests using SessionState.
109 * TestWebKitAPI/PlatformGTK.cmake: Add
110 WKPageCopySessionStateWithFiltering test.
112 2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
114 [GTK] Missing return value on TestWebExtensions.cpp:193
115 https://bugs.webkit.org/show_bug.cgi?id=149755
117 Unreviewed. Add missing return value.
119 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
120 (permissionRequestCallback):
122 2015-10-14 Andy Estes <aestes@apple.com>
124 [iOS] build-dumprendertree does not build ImageDiff
125 https://bugs.webkit.org/show_bug.cgi?id=150152
127 Reviewed by Tim Horton.
129 run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
130 On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
131 as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
132 WebKit.xcworkspace), tests that rely on image diffing won't work properly.
134 There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
135 fine on that platform, and results in ImageDiff being built.
137 * Scripts/build-dumprendertree:
139 2015-10-14 Brent Fulgham <bfulgham@apple.com>
141 [Win] Enforce launcher/library naming scheme
142 https://bugs.webkit.org/show_bug.cgi?id=150124
144 Reviewed by Alex Christensen.
146 * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
147 * MiniBrowser/win/CMakeLists.txt: Ditto.
148 * TestWebKitAPI/PlatformWin.cmake: Ditto.
149 * win/DLLLauncher/DLLLauncherMain.cpp:
150 (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
153 2015-10-14 Andreas Kling <akling@apple.com>
155 REGRESSION(r190882): Concatenating a character array and an empty string is broken.
156 <https://webkit.org/b/150135>
158 Reviewed by Geoffrey Garen.
160 Add a new WTF API test that covers this issue.
162 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
163 (TestWebKitAPI::build):
164 (TestWebKitAPI::TEST):
166 2015-10-14 Alex Christensen <achristensen@webkit.org>
168 Add SPI for reloading without content blockers
169 https://bugs.webkit.org/show_bug.cgi?id=150058
170 rdar://problem/22742222
172 Reviewed by Sam Weinig.
174 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
175 (WTR::TestController::cocoaResetStateToConsistentValues):
176 * WebKitTestRunner/mac/TestControllerMac.mm:
177 (WTR::TestController::platformConfigureViewForTest):
179 2015-10-14 Mark Lam <mark.lam@apple.com>
181 Rename some JSC option names to be more uniform.
182 https://bugs.webkit.org/show_bug.cgi?id=150127
184 Reviewed by Geoffrey Garen.
186 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
187 * Scripts/run-jsc-stress-tests:
189 2015-10-14 Anders Carlsson <andersca@apple.com>
191 Change the bundle app cache APIs to take a page
192 https://bugs.webkit.org/show_bug.cgi?id=150123
194 Reviewed by Sam Weinig.
198 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
199 (WTR::InjectedBundle::beginTesting):
200 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
201 (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
202 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
203 (WTR::TestRunner::clearAllApplicationCaches):
204 (WTR::TestRunner::clearApplicationCacheForOrigin):
205 (WTR::TestRunner::setAppCacheMaximumSize):
206 (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
207 (WTR::TestRunner::originsWithApplicationCache):
209 2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
211 Update web-platform-tests tools to the latest revision
212 https://bugs.webkit.org/show_bug.cgi?id=149645
214 Reviewed by Darin Adler.
216 Disabling git submodules information conversion to json install file for web-platform-tests.
217 Disabling related python unit tests.
218 The tools submodules contain submodules and the conversion tool does not support that yet.
220 Updating wpt launcher script to aling it with web-platform-test main script.
222 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
224 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
225 (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
226 * Scripts/webkitpy/w3c/test_importer_unittest.py:
227 (TestImporterTest.test_submodules_generation):
229 2015-10-13 Alexey Proskuryakov <ap@apple.com>
231 More debug queue build fixing.
233 Preserve the build style in one more place. Changed mock build_style from "both"
234 to "release", as we don't support testing both debug and release.
236 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
237 (MockCommitQueue.archive_last_test_results):
239 (MockCommitQueue.build_style):
240 (MockCommitQueue.did_pass_testing_ews):
241 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
242 (PatchAnalysisTask._test):
243 (PatchAnalysisTask._build_and_test_without_patch):
244 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
245 (EarlyWarningSystemTest._default_expected_logs):
246 * Scripts/webkitpy/tool/commands/queues_unittest.py:
248 2015-10-13 Alexey Proskuryakov <ap@apple.com>
250 More debug queue build fixing.
252 Add build_style argument to derived classes as well.
254 * Scripts/webkitpy/common/config/ports.py:
256 (MacPort.run_webkit_tests_command):
257 (WinPort.run_bindings_tests_command):
259 (WinPort.run_webkit_tests_command):
260 (GtkWK2Port.build_webkit_command):
262 (GtkWK2Port.run_webkit_tests_command):
264 2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
270 Mach-O section names are limited to 16 characters.
272 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
273 * DumpRenderTree/mac/DumpRenderTree.mm:
276 2015-10-13 Alexey Proskuryakov <ap@apple.com>
278 Build fix for mac-debug EWS queue.
282 Pass --debug to run-webkit-tests.
284 While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
285 will need to be substantially modified to work in EWS, so the dummy implementation
288 * Scripts/webkitpy/common/config/ports.py:
289 (DeprecatedPort.run_javascriptcore_tests_command):
291 (DeprecatedPort.run_webkit_tests_command):
292 (DeprecatedPort.run_python_unittests_command):
293 (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
294 * Scripts/webkitpy/common/config/ports_mock.py:
295 (MockPort.run_javascriptcore_tests_command):
297 (MockPort.run_webkit_tests_command):
298 (MockPort.run_bindings_tests_command):
299 (MockPort.run_webkit_unit_tests_command): Deleted.
300 * Scripts/webkitpy/tool/commands/download_unittest.py:
301 * Scripts/webkitpy/tool/steps/runtests.py:
303 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
304 (RunTestsTest.test_webkit_run_unit_tests):
305 * Scripts/webkitpy/tool/steps/steps_unittest.py:
306 (StepsTest.test_runtests_args):
308 2015-10-13 Brent Fulgham <bfulgham@apple.com>
310 [Win] Generate Crash Traces
311 https://bugs.webkit.org/show_bug.cgi?id=150103
313 Reviewed by Daniel Bates.
315 We were using an exception filter to try to emit "#CRASHED" to stderr
316 when a test program crashed. However, the modern Python implementation
317 seems capable of recognizing crashes on its own. Furthermore, registering
318 the exception handler was preventing the JIT debugger (NTSD) from
319 automatically attaching to the crashing program, so we were not getting
322 * DumpRenderTree/win/DumpRenderTree.cpp:
323 (main): Don't register an exception filter.
324 (exceptionFilter): Deleted.
325 * Scripts/webkitpy/common/system/crashlogs.py:
326 (CrashLogs): Add another regular expression to handle a second crash trace
327 syntax I encountered during testing.
328 (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
329 try the new one. The PID found by the new expression is in hexadecimal, so
330 convert it to an integer before returning it.
331 * Scripts/webkitpy/port/driver.py:
332 (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
333 the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
334 check for "#CRASHED" after stripping off the EOL characters.
335 * Scripts/webkitpy/port/win.py:
336 (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
337 invocation. This is apparently used to signal an event when the debugger is finished.
339 2015-10-13 Alexey Proskuryakov <ap@apple.com>
341 Mac Debug and 32-bit queues should be separate
342 https://bugs.webkit.org/show_bug.cgi?id=150092
344 Reviewed by Lucas Forschler.
346 * QueueStatusServer/config/queues.py:
347 * QueueStatusServer/model/queues.py:
348 (Queue._capitalize_after_dash):
349 (Queue._caplitalize_after_dash): Deleted.
350 * Scripts/webkitpy/common/config/ews.json:
352 2015-10-13 Sergio Villar Senin <svillar@igalia.com>
354 [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
355 https://bugs.webkit.org/show_bug.cgi?id=150085
357 Reviewed by Carlos Garcia Campos.
359 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
361 2015-10-13 Sebastian Dröge <sebastian@centricular.com>
363 Unreviewed, add myself to the committers list.
365 * Scripts/webkitpy/common/config/contributors.json:
367 2015-10-12 Alexey Proskuryakov <ap@apple.com>
369 Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
370 https://bugs.webkit.org/show_bug.cgi?id=149983
372 Reviewed by Dan Bates.
374 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
376 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
378 2015-10-12 Alexey Proskuryakov <ap@apple.com>
380 Fix webkitpy tests after r190922.
382 * Scripts/webkitpy/common/config/ews.json:
383 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
384 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
386 2015-10-12 Alexey Proskuryakov <ap@apple.com>
388 Add a Mac debug EWS queue
389 https://bugs.webkit.org/show_bug.cgi?id=150069
391 Reviewed by Geoffrey Garen.
393 * QueueStatusServer/config/queues.py:
394 * Scripts/webkitpy/common/config/ews.json:
395 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
396 (AbstractEarlyWarningSystem):
397 (AbstractEarlyWarningSystem.archive_last_test_results):
398 (AbstractEarlyWarningSystem.build_style):
399 (AbstractEarlyWarningSystem.refetch_patch):
400 (AbstractEarlyWarningSystem.load_ews_classes):
402 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
404 [GTK] Update jhbuild's version of harfbuzz
405 https://bugs.webkit.org/show_bug.cgi?id=149749
407 Reviewed by Martin Robinson.
409 Update harfbuzz to 0.9.35, following the lead of Debian Stable.
411 * gtk/jhbuild.modules: Updated details for harfbuzz.
413 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
415 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
416 https://bugs.webkit.org/show_bug.cgi?id=150026
418 Reviewed by Philippe Normand.
420 Backport upstream patch from gst-plugins-bad so that the right version
421 of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
422 gets compiled properly, avoiding crashes on runtime while running tests.
424 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
425 * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
427 2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
429 Test font-variant-* and font-feature-settings with mocked preinstalled fonts
430 https://bugs.webkit.org/show_bug.cgi?id=149777
432 Reviewed by Simon Fraser.
434 Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
435 to the list of tests to preinstall at startup time.
437 Also, update the generation of the 'name' table in the FontWithFeatures font.
439 * DumpRenderTree/mac/DumpRenderTree.mm:
440 (allowedFontFamilySet):
441 (activateTestingFonts):
443 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
444 (Generator::generate):
445 (Generator::appendCFFTable):
446 (Generator::appendNameSubtable):
447 (Generator::appendNAMETable):
448 * FontWithFeatures/FontWithFeatures/main.cpp:
450 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
451 (WTR::allowedFontFamilySet):
452 (WTR::activateFonts):
453 * WebKitTestRunner/mac/TestControllerMac.mm:
454 (WTR::allowedFontFamilySet):
456 2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
458 Unreviewed. Add Jinyoung Hur as a committer.
460 * Scripts/webkitpy/common/config/contributors.json:
462 2015-10-10 Dan Bernstein <mitz@apple.com>
464 [iOS] Remove unnecessary iOS version checks
465 https://bugs.webkit.org/show_bug.cgi?id=150002
467 Reviewed by Alexey Proskuryakov.
469 * WebKitTestRunner/ios/HIDEventGenerator.mm:
470 (-[HIDEventGenerator _createIOHIDEventType:]):
471 (-[HIDEventGenerator _sendHIDEvent:]):
472 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
473 * WebKitTestRunner/ios/UIKitSPI.h:
475 2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
477 Unreviewed, rolling out r190689
478 https://bugs.webkit.org/show_bug.cgi?id=149992
480 Fixed in other repository.
484 "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
485 https://bugs.webkit.org/show_bug.cgi?id=149897
487 2015-10-09 Brian Burg <bburg@apple.com>
489 Teach webkitperl how to figure out IOS versions from the SDK
490 https://bugs.webkit.org/show_bug.cgi?id=149963
492 Reviewed by Daniel Bates.
494 It should be easier to check the major and minor version of IOS SDKs.
496 * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
497 * Scripts/webkitdirs.pm:
498 (splitVersionString): Added.
499 (determineOSXVersion): Use splitVersionString.
500 (determineIOSVersion): Added. Look at the SDK version and make a tuple.
503 2015-10-09 Simon Fraser <simon.fraser@apple.com>
505 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
506 https://bugs.webkit.org/show_bug.cgi?id=149960
508 Reviewed by Tim Horton.
510 Use adoptWK(), and null out some members (file is not using ARC).
512 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
513 (UIScriptContext::uiScriptComplete):
514 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
515 (-[TestRunnerWKWebView dealloc]):
517 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
519 Remove ENABLE_SUID_SANDBOX_LINUX cruft
520 https://bugs.webkit.org/show_bug.cgi?id=149954
522 Reviewed by Darin Adler.
524 * Scripts/webkitperl/FeatureList.pm:
526 2015-10-09 Daniel Bates <dabates@apple.com>
528 Make iOS builders generate debug information in a separate dSYM file
529 https://bugs.webkit.org/show_bug.cgi?id=149696
531 Reviewed by Darin Adler.
533 Similar to the Mac builders, the iOS builders should write debug information
534 into a separate dSYM file instead of including such information in the binary
535 itself (default Xcode behavior)
537 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
538 (CompileWebKit.start):
540 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
542 Fix webkitpy tests after r190779
543 https://bugs.webkit.org/show_bug.cgi?id=149949
545 Reviewed by Ryosuke Niwa.
547 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
548 (BenchmarkResults.format):
549 (BenchmarkResults._format_values):
551 2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
553 Extend run-benchmark script to support human-readable results conversion.
554 https://bugs.webkit.org/show_bug.cgi?id=149944
556 Reviewed by Ryosuke Niwa.
558 Add '--read-results-json' and '--no-adjust-unit' options.
559 '--read-results-json' option converts result file to human readable format.
560 '--no-adjust-unit' option skips scientific notation convertion.
561 '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
563 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
564 (BenchmarkResults.format):
565 (BenchmarkResults._format_tests):
566 (BenchmarkResults._format_values):
567 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
568 (BenchmarkRunner.__init__):
569 (BenchmarkRunner._run_benchmark):
570 (BenchmarkRunner._dump):
571 (BenchmarkRunner.show_results):
572 (BenchmarkRunner._show_results): Deleted.
573 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
577 2015-10-08 Daniel Bates <dabates@apple.com>
579 Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
580 https://bugs.webkit.org/show_bug.cgi?id=149945
582 Reviewed by Dan Bernstein.
584 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
585 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
586 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
587 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
589 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
590 (table.queue-grid tr.platform.ios-9 img.logo):
592 2015-10-08 Daniel Bates <dabates@apple.com>
594 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
595 https://bugs.webkit.org/show_bug.cgi?id=149943
597 Reviewed by Dan Bernstein.
599 Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
600 teach build-webkit to install them when building for iOS device using the public iOS SDK.
602 * Scripts/build-webkit:
604 2015-10-08 Daniel Bates <dabates@apple.com>
606 Add LLVM binaries for iOS 9 device
607 https://bugs.webkit.org/show_bug.cgi?id=149913
609 Reviewed by Filip Pizlo.
611 Implement support for building LLVM for ARM64-based iOS devices.
613 * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
614 * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
615 an existing build earlier in the file such that remove previously built
616 libraries before building/copying new ones (if applicable).
617 (fileContains): Moved function outside of if-block.
618 (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
619 (buildLLVM): Added. Extracted machinery to build LLVM into this function and
620 added logic to build LLVM for ARM64-based iOS devices.
621 (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
622 LLVM into the WebKitBuild directory.
624 2015-10-08 Alexey Proskuryakov <ap@apple.com>
626 Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
627 https://bugs.webkit.org/show_bug.cgi?id=149848
629 Reviewed by Darin Adler.
631 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
633 2015-10-07 Brent Fulgham <bfulgham@apple.com>
635 [Win] Support 64-bit Build and Testing
636 https://bugs.webkit.org/show_bug.cgi?id=149904
638 Reviewed by Daniel Bates.
640 Extend our existing scripts to support 64-bit build and test operations on
643 * Scripts/build-dumprendertree: We don't need to build DRT on its own;
644 Windows always builds the whole stack.
645 * Scripts/webkit-build-directory: Add an option to return the location of
646 the executable files produced by a specific configuration. This change is
647 actually useful for Gtk and EFL, too.
648 * Scripts/webkitdirs.pm:
649 (executableProductDir): Added. This function appends the proper binary
650 path to the productDir. This is useful for Windows, Gtk, and EFL ports.
651 (jscProductDir): Use the new 'executableProductDir' method.
652 (setPathForRunningWebKitApp): Ditto.
654 (runMiniBrowser): Ditto.
655 * Scripts/webkitpy/port/factory.py:
656 (configuration_options): Add a 64-bit option, used on Windows to specify
657 which binary target should be used for testing.
658 * Scripts/webkitpy/port/win.py:
659 (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
660 processes when needed.
661 (WinPort._build_path): Add the correct binary target path to _build_path.
662 (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
663 64-bit paths for 64-bit tests.
664 (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
665 NTSD debugger does not understand this argument.
667 2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
669 Test font-variant-* and font-feature-settings with TrueType fonts
670 https://bugs.webkit.org/show_bug.cgi?id=149776
672 Reviewed by Simon Fraser.
674 This test extends our existing FontWithFeatures project to be able to generate a
675 TrueType font. This font is conceptually similar as the existing OpenType font,
676 except the feature -> character mapping is different.
678 The font itself only supports the following characters:
679 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
680 However, the shape of these letters are either an X or a check mark.
681 The letter "A" always is a check mark.
682 The letter "B" always is an X.
683 Each font feature has an letter associated with it. When the font feature is enabled,
684 that letter is shown as a check mark. For example, when
685 "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
688 Here are the mappings of font features to letters:
689 kLigaturesType / kCommonLigaturesOnSelector: C
690 kLigaturesType / kContextualLigaturesOnSelector: D
691 kLigaturesType / kRareLigaturesOnSelector: G
692 kLigaturesType / kHistoricalLigaturesOnSelector: I
693 kContextualAlternatesType / kContextualAlternatesOnSelector: L
694 kVerticalPositionType / kInferiorsSelector: O
695 kVerticalPositionType / kSuperiorsSelector: P
696 kLowerCaseType / kLowerCaseSmallCapsSelector: S
697 kUpperCaseType / kUpperCaseSmallCapsSelector: V
698 kLowerCaseType / kLowerCasePetiteCapsSelector: T
699 kUpperCaseType / kUpperCasePetiteCapsSelector: W
700 kLetterCaseType / 14: Y
701 kStyleOptionsType / kTitlingCapsSelector: a
702 kNumberCaseType / kUpperCaseNumbersSelector: c
703 kNumberCaseType / kLowerCaseNumbersSelector: d
704 kNumberSpacingType / kProportionalNumbersSelector: f
705 kNumberSpacingType / kMonospacedNumbersSelector: g
706 kFractionsType / kDiagonalFractionsSelector: i
707 kFractionsType / kVerticalFractionsSelector: j
708 kVerticalPositionType / kOrdinalsSelector: Q
709 kTypographicExtrasType / kSlashedZeroOnSelector: k
710 kLigaturesType / kHistoricalLigaturesOnSelector: K
711 kCharacterShapeType / kJIS1978CharactersSelector: m
712 kCharacterShapeType / kJIS1983CharactersSelector: n
713 kCharacterShapeType / kJIS1990CharactersSelector: o
714 kCharacterShapeType / kJIS2004CharactersSelector: p
715 kCharacterShapeType / kSimplifiedCharactersSelector: q
716 kCharacterShapeType / kTraditionalCharactersSelector: r
717 kTextSpacingType / kMonospacedTextSelector: t
718 kTextSpacingType / kProportionalTextSelector: u
719 kRubyKanaType / kRubyKanaOnSelector: v
721 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
722 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
723 (CFFBuilder::moveTo):
724 (CFFBuilder::lineTo):
725 (GLYFBuilder::GLYFBuilder):
726 (GLYFBuilder::takeResult):
727 (GLYFBuilder::moveTo):
728 (GLYFBuilder::lineTo):
729 (GLYFBuilder::closePath):
730 (GLYFBuilder::writePoint):
731 (GLYFBuilder::append16):
732 (generateBoxCharString):
733 (generateCheckCharString):
734 (generateXCharString):
736 (Generator::generate):
737 (Generator::insertSelector):
738 (Generator::insertFeature):
739 (Generator::generateFeatureDescription):
740 (Generator::appendCFFTable):
741 (Generator::appendGLYFTable):
742 (Generator::appendLOCATable):
743 (Generator::appendFEATTable):
744 (Generator::appendMetamorphosisChain):
745 (Generator::appendMORXTable):
746 (Generator::appendHEADTable):
747 (Generator::appendHMTXTable):
748 (Generator::appendNameSubtable):
749 (Generator::append2ByteASCIIString):
750 (Generator::appendNAMETable):
752 (CFFBuilder::curveToCubic): Deleted.
753 (charStringForGlyph): Deleted.
754 * FontWithFeatures/FontWithFeatures/FontCreator.h:
755 * FontWithFeatures/FontWithFeatures/main.cpp:
756 (constructFontWithTrueTypeFeature):
757 (constructFontWithOpenTypeFeature):
760 (drawTextWithFeature): Deleted.
762 2015-10-07 Commit Queue <commit-queue@webkit.org>
764 Unreviewed, rolling out r190572, r190593, r190594, and
766 https://bugs.webkit.org/show_bug.cgi?id=149897
768 Breaks Mavericks build (Requested by litherum on #webkit).
772 "Allow WKRetainPtrs to be used as keys in hashing data
774 https://bugs.webkit.org/show_bug.cgi?id=149762
775 http://trac.webkit.org/changeset/190572
777 "REGRESSION(189668?): http/tests/notifications/events.html
778 flakily asserts or times out"
779 https://bugs.webkit.org/show_bug.cgi?id=149218
780 http://trac.webkit.org/changeset/190593
782 "Prospective Mavericks build fix."
783 http://trac.webkit.org/changeset/190594
785 "Post-review cleanup after r190572."
786 http://trac.webkit.org/changeset/190639
788 2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
790 [GTK] Add autocleanups
791 https://bugs.webkit.org/show_bug.cgi?id=149588
793 Reviewed by Darin Adler.
795 * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
796 (AutocleanupsTest::create):
797 (AutocleanupsTest::testWebProcessAutocleanups):
799 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
800 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
801 (testUIProcessAutocleanups):
802 (testWebProcessAutocleanups):
806 2015-10-06 Brian Burg <bburg@apple.com>
808 Unreviewed, try to fix the iOS 8 build after r190368.
810 On older versions, IOHIDEventCreateForceEvent is not available.
812 * WebKitTestRunner/ios/HIDEventGenerator.mm:
813 (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
815 2015-10-06 Keith Miller <keith_miller@apple.com>
817 Add gmalloc option to run-javascriptcore-tests.
818 https://bugs.webkit.org/show_bug.cgi?id=149858
820 Reviewed by Geoffrey Garen.
822 run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
823 If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
825 * Scripts/run-javascriptcore-tests:
827 2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
829 Post-review cleanup after r190572.
833 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
835 2015-10-06 Brent Fulgham <bfulgham@apple.com>
837 [Win] Unreviewed build correction.
839 * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
840 are soft-linked at runtime.
842 2015-10-06 Keith Miller <keith_miller@apple.com>
844 Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
845 https://bugs.webkit.org/show_bug.cgi?id=149815
847 Reviewed by Filip Pizlo.
849 Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
850 Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
851 running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
852 Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
853 so should just use one test runner.
855 * Scripts/run-javascriptcore-tests:
857 (runMozillaTests): Deleted.
858 (defaultJsDriverArgsForMozillaTests): Deleted.
859 * Scripts/run-jsc-stress-tests:
861 2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
863 [GTK] Make update-webkitgtk-libs work behind firewall
865 update-webkitgtk-libs can work behind a firewall with changes to
866 a few packages. Where outbound git and active FTP connections
867 fail, using http protocol succeeds. Most packages are
868 already accessed using http.
870 https://bugs.webkit.org/show_bug.cgi?id=148941
872 Reviewed by Martin Robinson.
875 * gtk/jhbuild.modules:
876 Replace git URLs with http. Remove no longer used ftp repositories.
877 Update argument for libxml2's autogen.sh script (--without-python
878 is ignored; --with-python=no is correct).
879 * jhbuild/jhbuild-wrapper:
880 Instead of connecting to git://git.gnome.org/jhbuild, connect to
881 http://git.gnome.org/browse/jhbuild.
883 2015-10-06 Daniel Bates <dbates@webkit.org>
885 Enable XSLT when building WebKit for iOS using the public iOS SDK
886 https://bugs.webkit.org/show_bug.cgi?id=149827
888 Reviewed by Alexey Proskuryakov.
890 Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
891 and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
892 run this script before building WebKit for iOS or the build will fail because one or more XSLT
893 headers cannot be found.
895 * Scripts/configure-xcode-for-ios-development:
896 (copyMissingXSLTHeadersToSDKIfNeeded): Added.
898 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
900 REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
901 https://bugs.webkit.org/show_bug.cgi?id=149218
903 Reviewed by Alexey Proskuryakov.
905 Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
906 when the TestOptions change. Previously, WebNotificationProvider only could handle a single
907 WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
908 and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
909 the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
910 WebNotificationProvider must be updated to appropriately handle multiple
911 WKNotificationManagerRefs in flight at the same time.
913 * WebKitTestRunner/WebNotificationProvider.cpp:
914 (WTR::WebNotificationProvider::~WebNotificationProvider):
915 (WTR::WebNotificationProvider::showWebNotification):
916 (WTR::WebNotificationProvider::closeWebNotification):
917 (WTR::WebNotificationProvider::addNotificationManager):
918 (WTR::WebNotificationProvider::removeNotificationManager):
919 (WTR::WebNotificationProvider::simulateWebNotificationClick):
920 (WTR::WebNotificationProvider::reset):
921 * WebKitTestRunner/WebNotificationProvider.h:
923 2015-10-05 Daniel Bates <dabates@apple.com>
925 Disable Bitcode when building for iOS device
926 https://bugs.webkit.org/show_bug.cgi?id=149818
928 Reviewed by Alexey Proskuryakov.
930 Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
931 when building for iOS device.
933 * Scripts/webkitdirs.pm:
936 2015-10-05 Daniel Bates <dabates@apple.com>
938 [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
939 https://bugs.webkit.org/show_bug.cgi?id=140828
940 <rdar://problem/19520599>
942 Reviewed by Alexey Proskuryakov.
944 Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
945 we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
946 to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
949 * Scripts/webkitdirs.pm:
950 (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
951 to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
952 Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
953 (hasIOSDevelopmentCertificate): Added.
955 2015-10-05 Daniel Bates <dabates@apple.com>
957 DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
958 https://bugs.webkit.org/show_bug.cgi?id=149766
960 Reviewed by Alexey Proskuryakov.
962 Create network storage testing session on iOS.
964 Currently we do not create a network storage testing session on iOS. A network storage testing session always
965 has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
966 returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
967 NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
968 NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
969 it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
970 create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
971 testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
972 DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
974 As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
975 when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
976 returns a non-null pointer to a cookie store.
978 * DumpRenderTree/mac/DumpRenderTree.mm:
979 (prepareConsistentTestingEnvironment):
981 2015-10-05 Simon Fraser <simon.fraser@apple.com>
983 Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
986 * WebKitTestRunner/ios/HIDEventGenerator.mm:
987 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
989 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
991 Allow WKRetainPtrs to be used as keys in hashing data structures
992 https://bugs.webkit.org/show_bug.cgi?id=149762
994 Reviewed by Anders Carlsson.
996 * TestWebKitAPI/PlatformGTK.cmake:
997 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
998 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
999 (TestWebKitAPI::TEST):
1001 2015-10-05 Simon Fraser <simon.fraser@apple.com>
1003 Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1004 available, and tidy up the #ifdefs in the UIKitSPI header.
1006 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1007 (-[HIDEventGenerator _sendHIDEvent:]):
1008 * WebKitTestRunner/ios/UIKitSPI.h:
1010 2015-10-04 Zan Dobersek <zdobersek@igalia.com>
1012 [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1013 https://bugs.webkit.org/show_bug.cgi?id=149792
1015 Reviewed by Martin Robinson.
1017 * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1018 for WebKitTestRunner multiple times.
1020 2015-10-04 Daniel Bates <dabates@apple.com>
1022 Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1023 (https://bugs.webkit.org/show_bug.cgi?id=149753)
1025 For now, support calling build-layouttestrelay without --ios-simulator so long
1026 as we are building on a Mac.
1028 * Scripts/build-layouttestrelay:
1030 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1032 Support Trac 1.0.x XML timeline link format
1033 https://bugs.webkit.org/show_bug.cgi?id=149786
1035 Reviewed by Lucas Forschler.
1037 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1038 (Trac.prototype._convertCommitInfoElementToObject):
1040 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1042 Fix some errors on bot watcher's dashboard
1043 https://bugs.webkit.org/show_bug.cgi?id=149789
1045 Reviewed by Lucas Forschler.
1047 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1048 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1049 tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1051 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1053 Bot watcher's dashboard builders should turn yellow when svn fails
1054 https://bugs.webkit.org/show_bug.cgi?id=149791
1056 Reviewed by Lucas Forschler.
1058 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1059 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1060 (BuildbotBuilderQueueView.prototype.update):
1062 2015-10-02 Daniel Bates <dabates@apple.com>
1064 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1065 https://bugs.webkit.org/show_bug.cgi?id=149769
1067 Reviewed by Alexey Proskuryakov.
1069 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1070 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1071 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1072 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1074 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1075 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1077 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
1079 REGRESSION(r190370): Speedometer spits out an extra console message
1080 https://bugs.webkit.org/show_bug.cgi?id=149720
1082 Unreviewed. Temporarily ignore the console error message.
1084 * Scripts/webkitpy/performance_tests/perftest.py:
1085 (PerfTest._filter_output):
1087 2015-10-02 Brent Fulgham <bfulgham@apple.com>
1089 Provide "--no-ninja" option to avoid using Ninja
1090 https://bugs.webkit.org/show_bug.cgi?id=149757
1092 Reviewed by Alex Christensen.
1094 Add a new command line argument understood by webkitdirs.pm so
1095 that we can conditionally avoid using Ninja. This is an
1096 'opt-out' argument, so no existing Ninja users should be affected.
1098 * Scripts/webkitdirs.pm:
1099 (canUseNinja): Check for option and block ninja if present.
1101 2015-10-02 Aakash Jain <aakash_jain@apple.com>
1103 Flakiness dashboard should support OS X El Capitan
1104 https://bugs.webkit.org/show_bug.cgi?id=149648
1106 Reviewed by Alexey Proskuryakov.
1108 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1110 2015-10-02 Daniel Bates <dabates@apple.com>
1112 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1113 (https://bugs.webkit.org/show_bug.cgi?id=149753)
1115 For now, pass --ios-simulator.
1117 * Scripts/webkitpy/port/ios.py:
1118 (IOSSimulatorPort._build_relay):
1120 2015-10-02 Simon Fraser <simon.fraser@apple.com>
1122 Remove a "nullable" that breaks the iOS 8 build.
1124 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1125 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1127 2015-10-02 Daniel Bates <dabates@apple.com>
1129 LayoutTestRelay is not built and archived when building for iOS Simulator
1130 https://bugs.webkit.org/show_bug.cgi?id=149753
1132 Reviewed by Alexey Proskuryakov and Andy Estes.
1134 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1135 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1136 product archive when building for iOS Simulator, respectively.
1138 * BuildSlaveSupport/built-product-archive:
1139 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1140 differentiate between iOS device and iOS Simulator platforms.
1141 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1142 from determineWebKitBuildDirectories() into this function so that it can be used by both
1143 determineWebKitBuildDirectories() and archiveBuiltProduct().
1144 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1145 webkitBuildDirectoryForConfigurationAndPlatform().
1146 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1147 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1148 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1149 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1150 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1151 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1152 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1153 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1154 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1155 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1156 * Scripts/build-layouttestrelay:
1157 - Remove unnecessary include of Perl module POSIX.
1158 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1159 * Scripts/build-webkit:
1160 - Invoke script build-layouttestrelay when building for iOS Simulator.
1162 2015-10-02 Brent Fulgham <bfulgham@apple.com>
1164 [Win] Unreviewed test fix.
1166 You cannot run 'run-webkit-tests' from the command line because it does not know
1167 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1168 because they explicitly set use the 'root' argument to provide the full path to
1171 * Scripts/webkitpy/port/win.py:
1172 (WinPort._build_path): Added.
1174 2015-10-02 Alex Christensen <achristensen@webkit.org>
1176 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1177 https://bugs.webkit.org/show_bug.cgi?id=149430
1178 rdar://problem/22742222
1180 Reviewed by Geoffrey Garen.
1182 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1183 (WTR::TestController::cocoaResetStateToConsistentValues):
1184 * WebKitTestRunner/mac/TestControllerMac.mm:
1185 (WTR::TestController::platformConfigureViewForTest):
1186 Test what happens when you disable content blockers from the SPI.
1188 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1190 [Win] Unreviewed build fix for run-api-tests
1192 * Scripts/run-api-tests:
1193 (testToolPaths): Windows run needs to specify the binary path.
1195 2015-10-01 Daniel Bates <dabates@apple.com>
1197 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1198 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1200 Following r190424 we can now rely on webkit-build-directory to return the path to
1201 the correct configuration-specific build directory on Windows.
1203 * BuildSlaveSupport/built-product-archive:
1204 (archiveBuiltProduct):
1206 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1208 [Win] Unreviewed build fix.
1210 * Scripts/webkitdirs.pm:
1211 (setupAppleWinEnv): Use 64-bit build tools if available
1213 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1215 [Win] Fix TestWebKitAPI build under CMake.
1217 Reviewed by Alex Christensen.
1219 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1222 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1224 [Win] Fix behavior of webkit-build-directory script
1225 https://bugs.webkit.org/show_bug.cgi?id=149718
1227 Reviewed by Alex Christensen.
1229 * Scripts/webkitdirs.pm:
1230 (determineConfigurationProductDir): Do not include the binary
1231 sub-directory in the configuration product directory output.
1232 (jscProductDir): Append correct binary path for Windows build.
1233 (setPathForRunningWebKitApp): Include properly binary subdirectories.
1234 (runSafari): Update for revised productDir behavior.
1235 (runMiniBrowser): Ditto.
1237 2015-10-01 Alexey Proskuryakov <ap@apple.com>
1239 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1240 use iOS SDK, like with all the others.
1242 * Scripts/build-webkit:
1244 2015-10-01 Daniel Bates <dabates@apple.com>
1246 Attempt to fix the iOS 9 Simulator testers
1248 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1249 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1250 LayoutTestRelay when building for iOS Simulator.
1252 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1253 * Scripts/build-webkit:
1255 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1257 [GTK] Websites with invalid auth header keep loading forever
1258 https://bugs.webkit.org/show_bug.cgi?id=149710
1260 Reviewed by Martin Robinson.
1262 Add test case to check that we can authenticate sites with an
1265 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1266 (testWebViewAuthenticationEmptyRealm):
1270 2015-10-01 Alexey Proskuryakov <ap@apple.com>
1272 [Mac] Make run-api-tests work with System Integrity Protection
1273 https://bugs.webkit.org/show_bug.cgi?id=149711
1274 rdar://problem/22928202
1276 Reviewed by Dan Bernstein.
1278 * Scripts/run-api-tests:
1280 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1282 2015-10-01 Daniel Bates <dabates@apple.com>
1284 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1285 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1287 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1288 For now, use the path to the top-level WebKit build directory instead of using the configuration-
1289 specific build directory.
1291 * BuildSlaveSupport/built-product-archive:
1292 (archiveBuiltProduct):
1294 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
1296 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1297 https://bugs.webkit.org/show_bug.cgi?id=145837
1299 Reviewed by Philippe Normand.
1301 * efl/jhbuild.modules:
1302 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1303 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1305 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
1307 Unreviewed. Fix the iOS build after r190407.
1309 * WebKitTestRunner/ios/IOKitSPI.h:
1311 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
1313 Implement keyboard event sending for iOS in WebKitTestRunner
1314 https://bugs.webkit.org/show_bug.cgi?id=149676
1316 Reviewed by Simon Fraser.
1318 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1319 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1320 allows us to run code when the keyboard is shown or hidden.
1322 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1323 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1324 (WTR::UIScriptController::setDidShowKeyboardCallback):
1325 (WTR::UIScriptController::didShowKeyboardCallback):
1326 (WTR::UIScriptController::setDidHideKeyboardCallback):
1327 (WTR::UIScriptController::didHideKeyboardCallback):
1328 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1329 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1330 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1331 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1332 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1333 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1334 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1335 the notifications that the keyboard has been raised or lowered.
1336 (-[TestRunnerWKWebView _keyboardDidShow:]):
1337 (-[TestRunnerWKWebView _keyboardDidHide:]):
1338 * WebKitTestRunner/ios/HIDEventGenerator.h:
1339 * WebKitTestRunner/ios/HIDEventGenerator.m:
1340 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1341 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1342 (hidUsageCodeForCharacter): Ditto.
1343 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1344 a keyDown event in WebKit.
1345 * WebKitTestRunner/ios/IOKitSPI.h:
1346 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1348 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1350 Unreviewed, rolling out r190399.
1352 Tests are still failing even after r190362
1356 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1357 http://trac.webkit.org/changeset/190399
1359 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
1361 [jhbuild] switch to new upstream usrsctp library
1362 https://bugs.webkit.org/show_bug.cgi?id=149494
1364 Reviewed by Philippe Normand.
1366 * efl/jhbuild.modules:
1367 * gtk/jhbuild.modules:
1369 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1371 Unreviewed. Unskip GTK+ user media unit tests after r190362.
1373 They should pass now.
1375 * Scripts/run-gtk-tests:
1378 2015-09-30 Daniel Bates <dabates@apple.com>
1380 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1381 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1383 * BuildSlaveSupport/built-product-archive:
1384 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1385 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1387 2015-09-30 Daniel Bates <dabates@apple.com>
1389 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1390 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1392 Actually, we need to pass --configuration to script webkit-build-directory to have
1393 it return the path to the configuration-specific build directory.
1395 * BuildSlaveSupport/built-product-archive:
1396 (determineWebKitBuildDirectories):
1398 2015-09-30 Daniel Bates <dabates@apple.com>
1400 built-product-archive archives incorrect build directory for iOS port
1401 https://bugs.webkit.org/show_bug.cgi?id=149695
1403 Reviewed by Darin Adler.
1405 Fixes an issue where the script built-product-archive archives a non-existent
1406 build directory for the iOS port. Without loss of generality, the script assumes
1407 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1408 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1410 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1411 to determine the top-level build directory and computes the configuration-specific
1412 build directory to be the concatenation of the the top-level build directory and
1413 the configuration (e.g. Release). This is incorrect. Instead we should call
1414 webkit-build-directory omitting the flag --top-level to compute the path to the
1415 configuration-specific build directory.
1417 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1418 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1419 its purpose and added global variable _configurationBuildDirectory to store the path
1420 to the configuration-specific build directory. Ensure that we have a non-empty string
1421 for both the top-level and configuration-specific build directories.
1422 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1423 Compute the configuration-specific build directory and store it in the global variable
1424 _configurationBuildDirectory.
1425 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1426 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1428 (determineWebKitBuildDirectory): Deleted.
1430 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
1432 [EFL] css3/device-adapt/* tests failed after r190335.
1433 https://bugs.webkit.org/show_bug.cgi?id=149655
1435 Reviewed by Simon Fraser.
1437 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1438 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1440 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1441 (WTR::shouldUseFixedLayout):
1443 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
1445 Extend JetStream timeout for slow devices.
1447 Reviewed by Chris Dumez.
1449 Extend JetStream timeout to 20 minutes.
1451 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1453 2015-09-30 Daniel Bates <dabates@apple.com>
1455 Rename iOS builders/testers to include version
1456 https://bugs.webkit.org/show_bug.cgi?id=149685
1458 Reviewed by Simon Fraser.
1460 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1461 make it clear to a reader the version of iOS these builders/testers are using.
1463 * BuildSlaveSupport/build.webkit.org-config/config.json:
1464 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1466 2015-09-30 Daniel Bates <dabates@apple.com>
1468 Add iOS criterion for triggering a build
1469 https://bugs.webkit.org/show_bug.cgi?id=149679
1471 Rubber-stamped by Alexey Proskuryakov.
1473 First pass at defining criterion for triggering an iOS build.
1475 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1476 (_should_file_trigger_build):
1477 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1479 (ShouldBuildTest.test_should_build):
1481 2015-09-29 Simon Fraser <simon.fraser@apple.com>
1483 [iOS] Allow tests to generate user gestures for UI testing
1484 https://bugs.webkit.org/show_bug.cgi?id=149653
1486 Reviewed by Tim Horton.
1488 Expose functionality in UIScriptController to allow for testing single- and double-tap,
1489 and to listen for completion of scrolling and zooming in the WKWebView.
1491 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1492 which hides the complexity of creating these events. Event dispatch is asynchronous.
1493 We detect when the last event has been handled by dispatching a vendor-specific event,
1494 which is detected via -_handleHIDEvent: in our UIApplication subclass.
1496 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1497 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1498 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1499 single and double taps.
1500 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1501 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1502 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1503 (UIScriptContext::unregisterCallback):
1504 (UIScriptContext::callbackWithID):
1505 (UIScriptContext::fireCallback):
1506 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1507 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1508 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1509 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1510 (WTR::UIScriptController::setDidEndZoomingCallback):
1511 (WTR::UIScriptController::didEndZoomingCallback):
1512 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1513 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1514 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1515 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1516 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1517 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1518 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1519 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1520 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1521 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1522 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1523 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1524 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1525 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1527 (calculateNextLocation):
1529 (+[HIDEventGenerator sharedHIDEventGenerator]):
1530 (+[HIDEventGenerator nextEventCallbackID]):
1531 (-[HIDEventGenerator init]):
1532 (-[HIDEventGenerator _createIOHIDEventType:]):
1533 (-[HIDEventGenerator _sendHIDEvent:]):
1534 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1535 (-[HIDEventGenerator _updateTouchPoints:count:]):
1536 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1537 (-[HIDEventGenerator touchDown:touchCount:]):
1538 (-[HIDEventGenerator touchDown:]):
1539 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1540 (-[HIDEventGenerator liftUp:touchCount:]):
1541 (-[HIDEventGenerator liftUp:]):
1542 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1543 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1544 (-[HIDEventGenerator tap:completionBlock:]):
1545 (-[HIDEventGenerator doubleTap:completionBlock:]):
1546 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1547 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1548 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1549 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1550 (-[HIDEventGenerator markerEventReceived:]):
1551 * WebKitTestRunner/ios/IOKitSPI.h: Added.
1552 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1553 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1554 (WTR::globalToContentCoordinates):
1555 (WTR::UIScriptController::singleTapAtPoint):
1556 (WTR::UIScriptController::doubleTapAtPoint):
1557 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1558 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1559 * WebKitTestRunner/ios/mainIOS.mm:
1560 (-[WebKitTestRunnerApp _handleHIDEvent:]):
1562 2015-09-30 Dana Burkart <dburkart@apple.com>
1564 git-add-reviewer should trim trailing spaces/newlines
1565 https://bugs.webkit.org/show_bug.cgi?id=149513
1567 Reviewed by Darin Adler.
1569 * Scripts/git-add-reviewer:
1572 2015-09-30 Eric Carlson <eric.carlson@apple.com>
1574 REGRESSION(r190262): User media unit test failures after r190262
1575 https://bugs.webkit.org/show_bug.cgi?id=149580
1577 Reviewed by Darin Adler.
1579 * WebKitTestRunner/TestController.cpp:
1580 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1581 order to WKUserMediaPermissionRequestAllow.
1583 2015-09-30 Daniel Bates <dabates@apple.com>
1585 Add iOS builders and testers
1586 https://bugs.webkit.org/show_bug.cgi?id=149549
1588 Reviewed by Alexey Proskuryakov.
1590 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1591 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1593 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1594 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1596 2015-09-30 Timothy Hatcher <timothy@apple.com>
1598 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1599 https://bugs.webkit.org/show_bug.cgi?id=149674
1601 Reviewed by Lucas Forschler.
1603 * WebKitLauncher/WebKitLauncher.entitlements: Added.
1604 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1606 2015-09-30 Jason Marcell <jmarcell@apple.com>
1608 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1609 have an associated trac instance.
1610 https://bugs.webkit.org/show_bug.cgi?id=149673
1612 Reviewed by Alexey Proskuryakov.
1614 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1615 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1616 have an associated trac instance.
1618 2015-09-30 Daniel Bates <dabates@apple.com>
1620 Prioritize testing latest build request on iOS test bots
1621 https://bugs.webkit.org/show_bug.cgi?id=149669
1623 Reviewed by Darin Adler.
1625 We should prioritize testing of the latest build request on the iOS test bots
1626 as we do for Mac and Windows test bots.
1628 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1629 (loadBuilderConfig):
1631 2015-09-30 Daniel Bates <dabates@apple.com>
1633 Add buildbot category for iOS builders and testers
1634 https://bugs.webkit.org/show_bug.cgi?id=149667
1636 Reviewed by Darin Adler.
1638 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1639 for iOS to the build.webkit.org home page.
1641 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1642 (loadBuilderConfig):
1643 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1645 2015-09-30 Daniel Bates <dabates@apple.com>
1647 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1648 (https://bugs.webkit.org/show_bug.cgi?id=149539)
1650 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1651 in <http://trac.webkit.org/changeset/190351>.
1653 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1654 (CompileWebKit.start):
1656 2015-09-30 Daniel Bates <dabates@apple.com>
1658 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1659 (https://bugs.webkit.org/show_bug.cgi?id=149539)
1661 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1662 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1664 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1665 (CompileWebKit.start):
1667 2015-09-30 Lucas Forschler <lforschler@apple.com>
1669 bot210 was configured for a queue instead of bot126.
1671 Unreviewed config.json fix.
1673 * BuildSlaveSupport/build.webkit.org-config/config.json:
1675 2015-09-30 Lucas Forschler <lforschler@apple.com>
1677 Bring El Capitan buildbot infrastructure online.
1678 https://bugs.webkit.org/show_bug.cgi?id=149605
1680 Reviewed by Darin Adler.
1682 * BuildSlaveSupport/build.webkit.org-config/config.json:
1684 2015-09-30 Tomas Popela <tpopela@redhat.com>
1686 [GTK] Deprecation warnings in DOMNodeTest
1687 https://bugs.webkit.org/show_bug.cgi?id=149663
1689 After the webkit_dom_document_get_elements_by_tag_name deprecation we
1690 need to update the tests to use webkit_dom_document_query_selector_all
1691 to avoid compilation warnings.
1693 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1694 (the suggested replacement for the deprecated function).
1696 Reviewed by Carlos Garcia Campos.
1698 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1699 (WebKitDOMNodeTest::testTagNamesNodeList):
1700 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1702 (WebKitDOMNodeTest::testTagNames): Deleted.
1703 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1704 (prepareDOMForTagNamesTests):
1705 (testWebKitDOMNodeTagNamesNodeList):
1706 (testWebKitDOMNodeTagNamesHTMLCollection):
1708 (testWebKitDOMNodeTagNames): Deleted.
1710 2015-09-29 Simon Fraser <simon.fraser@apple.com>
1712 WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1713 https://bugs.webkit.org/show_bug.cgi?id=149650
1715 Reviewed by Tim Horton.
1717 TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1718 looks at the file path, and not the custom options that come from file comments.
1720 Fix by computing TestOptions before making the TestInvocation, and setting them
1721 as const TestInvocation data. This meant changing various call sites to take
1722 the std::string pathOrURL, rather than the TestInvocation itself.
1724 Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1726 * WebKitTestRunner/CMakeLists.txt:
1727 * WebKitTestRunner/TestController.cpp:
1728 (WTR::TestController::ensureViewSupportsOptionsForTest):
1730 (WTR::createTestURL):
1731 (WTR::updateTestOptionsFromTestHeader):
1732 (WTR::TestController::testOptionsForTest):
1733 (WTR::TestController::updateWebViewSizeForTest):
1734 (WTR::TestController::updateWindowScaleForTest):
1735 (WTR::TestController::runTest):
1736 * WebKitTestRunner/TestController.h:
1737 * WebKitTestRunner/TestInvocation.cpp:
1738 (WTR::TestInvocation::TestInvocation):
1739 (WTR::TestInvocation::invoke):
1740 (WTR::createWKURL): Deleted.
1741 (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1742 (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1743 * WebKitTestRunner/TestInvocation.h:
1744 (WTR::TestInvocation::options):
1745 * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1746 (WTR::pathContains):
1747 (WTR::shouldMakeViewportFlexible):
1748 (WTR::shouldUseFixedLayout):
1749 (WTR::isSVGTestPath):
1750 (WTR::isHiDPITestPath):
1751 (WTR::TestOptions::TestOptions):
1752 * WebKitTestRunner/TestOptions.h:
1753 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1754 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1755 (WTR::pathContains):
1756 (WTR::shouldUseFixedLayout):
1757 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1758 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1759 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1760 * WebKitTestRunner/ios/TestControllerIOS.mm:
1761 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1762 * WebKitTestRunner/mac/TestControllerMac.mm:
1763 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1765 2015-09-29 Aakash Jain <aakash_jain@apple.com>
1767 Flakiness dashboard should support OS X El Capitan
1768 https://bugs.webkit.org/show_bug.cgi?id=149648
1770 Reviewed by Alexey Proskuryakov.
1772 * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
1773 difference between new appscale and old Google App Engine implementation.
1774 * TestResultServer/app.yaml: Same.
1775 * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1777 2015-09-29 Daniel Bates <dabates@apple.com>
1779 configure-xcode-for-ios-development does not work with Xcode 7
1780 https://bugs.webkit.org/show_bug.cgi?id=149640
1782 Reviewed by Alexey Proskuryakov.
1784 When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1785 because it cannot find the Xcode specification files for iOS simulator and device. These
1786 files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1787 relevant definitions to the Xcode 7 specification files directly as opposed to creating
1788 new specification files with the added definitions (as we did in older versions of Xcode)
1789 in order for Xcode 7 to honor these definitions.
1791 * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1792 (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1793 (updateXcode7SpecificationFile): Added.
1794 (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1795 (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1796 appropriate success message.
1797 (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1798 (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1799 (createXcodeSpecificationFromSpecificationAndId): Deleted.
1801 2015-09-29 Brent Fulgham <bfulgham@apple.com>
1803 [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1804 https://bugs.webkit.org/show_bug.cgi?id=149639
1806 Reviewed by Alex Christensen.
1808 * Scripts/VCSUtils.pm:
1809 (exitStatus): Use 'isWindows()' method.
1810 (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1811 an error. This method could probably just go away.
1812 (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1813 always changing to Unix style.
1814 (unixPath): Added. Needed so Windows can always show a Unix path in the
1816 (changeLogName): Work around the fact that 'getpwuid' is not available on
1817 a pure Windows build of Perl.
1818 * Scripts/prepare-ChangeLog:
1819 (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1821 (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1822 support using arrays for 'open' arguments.
1823 (resolveChangeLogsPath): Ditto.
1824 (resolveConflictedChangeLogs): Use new helper functions.
1825 (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1826 (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1827 quotes. Unix systems are happy either way.
1828 (statusCommand): Ditto.
1829 * Scripts/webkitdirs.pm:
1830 (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1832 2015-09-29 Brent Fulgham <bfulgham@apple.com>
1834 [Win] Unreviewed 64-bit build fix after switch to CMake.
1836 * Scripts/webkitdirs.pm:
1837 (determineIsWin64FromArchitecture): Added.
1839 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
1841 printing does not use minimum page zoom factor
1842 https://bugs.webkit.org/show_bug.cgi?id=108507
1844 Reviewed by Darin Adler.
1846 WebKitTestRunner always takes the snapshots from the UI process
1847 (expect for IOS), so in the case of printing, the layout in the
1848 web view is not the expected one. When printing, we need to take
1849 the snapshot in the web process and ensure it's rendered with a
1852 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1853 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1854 kWKSnapshotOptionsPrinting option to
1855 WKBundlePageCreateSnapshotWithOptions() when printing.
1857 2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
1859 [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1860 https://bugs.webkit.org/show_bug.cgi?id=149595
1862 Reviewed by Tim Horton.
1864 All ports except IOS implement
1865 PlatformWebView::windowSnapshotImage() to generate the snapshot
1866 for the pixel tests in the UI process. But we are still generating
1867 a snapshot for pixel tests in the Web process too, that is passed
1868 to the UI process but ignored.
1869 Whether a pixel result is needed or not, is only known by the web
1870 process depending on whether the test called dumpAsText with
1871 dumpPixels == true or not. Since the pixels are now dump in the UI
1872 process, we need to pass that information to the UI process when
1873 the test is done. For that we set a PixelResultIsPending bool
1874 parameter to the Done message, and we only add the PixelResult
1875 when UI process doesn't need to generate the pixels dump.
1877 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1878 (WTR::InjectedBundle::didReceiveMessageToPage): Set
1879 m_pixelResultIsPending to false on reset.
1880 (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1881 Done message, and set the PixelResult if m_pixelResultIsPending is false.
1882 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1883 (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1884 (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1885 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1886 (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1888 * WebKitTestRunner/TestInvocation.cpp:
1889 (WTR::TestInvocation::dumpResults): Use either the pixel result
1890 from the web process or generate a pixel result from the web view
1892 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1893 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1894 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1895 is created by the caller now, but the CG implementation needs to
1896 know if it's a Web or UI process snapshot.
1897 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1898 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1899 cairo surface for the given image.
1900 * WebKitTestRunner/cg/TestInvocationCG.cpp:
1901 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1902 CGContext for the given image.
1904 2015-09-28 Dean Johnson <dean_johnson@apple.com>
1906 Fix JS errors on dashboard metrics page
1907 https://bugs.webkit.org/show_bug.cgi?id=149608
1909 Reviewed by Alexey Proskuryakov.
1911 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1912 (initPlatformsByFamily):
1913 (updateHiddenPlatforms):
1914 (parsePlatformFamily): Deleted.
1915 (updateToggleButtons): Deleted.
1916 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1917 (updateHiddenPlatforms): Added to remove errors.
1918 (initPlatformsByFamily): Added to remove errors.
1919 (unhiddenQueues): Updated to use Settings.
1920 (documentReady): Added logic to add toggle buttons to the settings menu.
1921 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1922 (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1923 MetricsMain.js to Settings.
1924 (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1925 MetricsMain.js to Settings.
1926 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1927 (QueueView.prototype._updateHiddenState): Updated to use Settings.
1929 2015-09-28 Aakash Jain <aakash_jain@apple.com>
1931 Appscale query fails because of missing index
1932 https://bugs.webkit.org/show_bug.cgi?id=149609
1934 Reviewed by Darin Adler.
1936 * QueueStatusServer/index.yaml: Added the required index.
1938 2015-09-28 Brent Fulgham <bfulgham@apple.com>
1940 [Win] Fix the 64-bit build after switch to cmake.
1942 Reviewed by Alex Christensen.
1944 * Scripts/webkitdirs.pm:
1945 (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1948 2015-09-28 Brent Fulgham <bfulgham@apple.com>
1950 [Win] Allow Windows to run test-webkitpy without Cygwin
1951 https://bugs.webkit.org/show_bug.cgi?id=149602
1953 Reviewed by Alex Christensen.
1955 These changes mostly shift from hard-coded paths using UNIX-style
1956 separators to Python's "os.path.join" syntax that uses the correct
1957 path separator for each platform.
1959 * Scripts/webkitpy/common/system/path.py:
1960 (cygpath): Don't pass paths through Cygpath on native Windows.
1961 * Scripts/webkitpy/port/win.py:
1962 (WinPort._path_to_apache): Use os.path.join.
1963 (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1964 in 64-bit environments).
1965 * Scripts/webkitpy/style/checker.py: Use os.path.join.
1966 * Scripts/webkitpy/style/checker_unittest.py:
1967 (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1968 (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1969 (GlobalVariablesTest): Ditto.
1970 (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1971 (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1972 (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1973 (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1974 (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1975 (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1976 (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1977 (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1978 (StyleProcessor_CodeCoverageTest): Ditto.
1979 (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1980 (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1981 (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1982 * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1983 manual string concatenation of paths.
1985 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
1987 Add bugzilla addresses of committers to contributors.json
1988 https://bugs.webkit.org/show_bug.cgi?id=149520
1990 Reviewed by Darin Adler.
1992 * Scripts/webkitpy/common/config/contributors.json:
1994 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
1996 validate-committer-lists -b shouldn't need edituser privileges
1997 https://bugs.webkit.org/show_bug.cgi?id=149519
1999 Reviewed by Darin Adler.
2001 * Scripts/validate-committer-lists:
2002 (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2003 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2004 (BugzillaQueries.is_invalid_bugzilla_email):
2005 (BugzillaQueries): Deleted.
2006 (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2008 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
2010 Unreviewed. Gardening: skip media stream tests failing after r190262.
2012 * Scripts/run-gtk-tests:
2015 2015-09-25 Alexey Proskuryakov <ap@apple.com>
2017 [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2018 https://bugs.webkit.org/show_bug.cgi?id=149571
2020 Reviewed by Dan Bernstein.
2022 Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
2024 * DumpRenderTree/mac/Configurations/Base.xcconfig:
2025 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2026 * LayoutTestRelay/Configurations/Base.xcconfig:
2027 * MiniBrowser/Configurations/Base.xcconfig:
2028 * MiniBrowser/Configurations/DebugRelease.xcconfig:
2029 * TestWebKitAPI/Configurations/Base.xcconfig:
2030 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2031 * WebEditingTester/Configurations/Base.xcconfig:
2032 * WebEditingTester/Configurations/DebugRelease.xcconfig:
2033 * WebKitTestRunner/Configurations/Base.xcconfig:
2034 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2035 * WebKitTestRunner/iOS.xcconfig: Removed.
2037 2015-09-25 Eric Carlson <eric.carlson@apple.com>
2039 Clean up user media request internal API
2040 https://bugs.webkit.org/show_bug.cgi?id=149527
2042 Reviewed by Tim Horton.
2044 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2045 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2047 * WebKitTestRunner/TestController.cpp:
2048 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2050 2015-09-25 Simon Fraser <simon.fraser@apple.com>
2052 [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2053 https://bugs.webkit.org/show_bug.cgi?id=149577
2055 Reviewed by Tim Horton.
2057 When calling testRunner.runUIScript() from a page load event, the script could run
2058 in the UI process before the current remote layer tree transaction had been handled
2059 there. This meant that runUIScript() could query state which was about to change.
2061 Fix by delaying the execution of the UI script until a layer tree transaction has
2062 been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2064 * WebKitTestRunner/TestInvocation.cpp:
2065 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2066 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2067 * WebKitTestRunner/TestInvocation.h:
2069 2015-09-25 Alexey Proskuryakov <ap@apple.com>
2071 [Mac] Media tests start to time out after a few days of bot uptime
2072 https://bugs.webkit.org/show_bug.cgi?id=149468
2074 Reviewed by Darin Adler.
2076 Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2077 as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2078 all temporary and cache files go to a custom location.
2080 * Scripts/webkitpy/port/base.py:
2081 * Scripts/webkitpy/port/driver.py:
2082 * Scripts/webkitpy/port/mac.py:
2083 * Scripts/webkitpy/port/win.py:
2084 (WinPort._driver_tempdir_for_environment): Deleted unused function.
2086 2015-09-25 Dan Bernstein <mitz@apple.com>
2088 Removed MiniBrowser.entitlements.
2090 Rubber-stamped by Anders Carlsson.
2092 The entitlements weren’t used anyway.
2094 * MiniBrowser/MiniBrowser.entitlements: Removed.
2095 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2097 2015-09-24 Daniel Bates <dabates@apple.com>
2099 Add WebKitSystemInterface for iOS 9.0
2100 https://bugs.webkit.org/show_bug.cgi?id=149550
2102 Rubber-stamped by Alexey Proskuryakov.
2104 * Scripts/copy-webkitlibraries-to-product-directory:
2106 2015-09-24 Daniel Bates <dabates@apple.com>
2108 Support building for arbitrary architectures
2109 https://bugs.webkit.org/show_bug.cgi?id=149539
2111 Reviewed by Alexey Proskuryakov.
2113 Teach buildbot to pass the architectures associated with the builder to build-webkit
2114 when building on OS X and iOS. As a side effect of this change we now support building
2115 universal binaries when multiples architectures are specified.
2117 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2118 (CompileWebKit.start):
2120 2015-09-24 Daniel Bates <dabates@apple.com>
2122 Fix the build after <http://trac.webkit.org/changeset/190212>
2123 (http://trac.webkit.org/changeset/190212)
2125 I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2127 * BuildSlaveSupport/built-product-archive:
2130 2015-09-24 Daniel Bates <dabates@apple.com>
2132 Support running unit tests on iOS Simulator test bot
2133 https://bugs.webkit.org/show_bug.cgi?id=149536
2135 Reviewed by Alexey Proskuryakov.
2137 Implements support for running unit tests on a iOS test bot. At the time of writing,
2138 the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2140 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2141 (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2142 (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2144 2015-09-24 Daniel Bates <dabates@apple.com>
2146 Add support infrastructure for OpenSource iOS builders and testers
2147 https://bugs.webkit.org/show_bug.cgi?id=149534
2149 Reviewed by Darin Adler.
2151 Towards setting up OpenSource iOS build bots, teach buildbot and its support
2154 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2155 (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2156 --ios-simulator or --device for a builder/tester whose full platform name begins with
2157 "ios-simulator" or "ios", respectively.
2158 (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2159 * BuildSlaveSupport/built-product-archive:
2160 (main): Pass the full platform name to determineWebKitBuildDirectory().
2161 (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2162 command line flag when building for iOS.
2163 (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2164 parameter fullPlatform. This parameter was originally added in r125066 to support the
2165 Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2166 (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2167 * BuildSlaveSupport/clean-build:
2168 (main): Call script webkit-build-directory with the appropriate command line flag when
2170 * BuildSlaveSupport/delete-stale-build-files:
2171 (main): Use the same logic for iOS as we do for Mac.
2172 (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2173 flag when building for iOS.
2174 * BuildSlaveSupport/test-result-archive:
2175 (archiveTestResults): Use the same logic for iOS as we do for Mac.
2177 2015-09-24 Daniel Bates <dabates@apple.com>
2179 Remove Chromium-specific changes to script built-product-archive
2180 https://bugs.webkit.org/show_bug.cgi?id=149530
2182 Rubber-stamped by Csaba Osztrogonác.
2184 Reverts changes made in r113074 and r113067 to support Chromium testers. The
2185 Chromium code has long since been removed from the OpenSource WebKit Project.
2187 * BuildSlaveSupport/built-product-archive:
2188 (createZipManually):
2190 (archiveBuiltProduct):
2192 2015-09-24 Dan Bernstein <mitz@apple.com>
2196 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2198 2015-09-24 Mark Lam <mark.lam@apple.com>
2200 Unreviewed. Make Lucas Forschler a WebKit reviewer.
2202 * Scripts/webkitpy/common/config/contributors.json:
2204 2015-09-24 Carlos Garcia Campos <cgarcia@igalia.com>
2206 Unreviewed. Fix GObject DOM API breaks after r190120.
2208 Bring back code removed in r169931 to handle documentation of
2212 (WebKitDOMDocGenerator):
2213 (WebKitDOMDocGenerator.write_deleted_classes):
2214 (WebKitDOMDocGenerator.generate):
2215 (write_deleted_classes):
2216 (WebKitDOMDocGeneratorSections._deleted_class):
2217 (WebKitDOMDocGeneratorSections._deleted_class.in):
2218 (WebKitDOMDocGeneratorSections.write_deleted_classes):
2219 (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2221 2015-09-23 Myles C. Maxfield <mmaxfield@apple.com>
2223 [Cocoa] [Font Features] Implement font-variant-*
2224 https://bugs.webkit.org/show_bug.cgi?id=148413
2226 Reviewed by Darin Adler.
2228 Update test font to use "lnum" feature.
2230 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2231 (Generator::appendGSUBTable):
2233 2015-09-22 Andy Estes <aestes@apple.com>
2235 ContentFiltering.AllowDownloadAfterAddData is very flaky
2236 https://bugs.webkit.org/show_bug.cgi?id=148885
2237 <rdar://problem/22729563>
2239 Reviewed by Alexey Proskuryakov.
2241 The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2242 but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2243 -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2245 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2248 2015-09-22 Alexey Proskuryakov <ap@apple.com>
2250 Mavericks: Media tests start to time out after a few days of bot uptime
2251 https://bugs.webkit.org/show_bug.cgi?id=149468
2253 Reviewed by Chris Dumez.
2255 * Scripts/webkitpy/port/base.py:
2256 * Scripts/webkitpy/port/driver.py:
2257 * Scripts/webkitpy/port/mac.py:
2259 2015-09-22 Nan Wang <n_wang@apple.com>
2261 Unreviewed, add myself to the committers list.
2263 * Scripts/webkitpy/common/config/contributors.json:
2265 2015-09-21 Simon Fraser <simon.fraser@apple.com>
2267 Remove 'nullable' to fix older iOS builds.
2269 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2270 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2272 2015-09-21 Brent Fulgham <bfulgham@apple.com>
2274 [Win] Show tiled drawing debug overlay on Windows
2275 https://bugs.webkit.org/show_bug.cgi?id=149426
2277 Reviewed by Dean Jackson.
2279 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2280 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2281 * MiniBrowser/win/Common.cpp:
2282 (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2284 * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2286 2015-09-21 Brent Fulgham <bfulgham@apple.com>
2288 [Win] Use command-line argument to launch in regular or High DPI mode.
2289 https://bugs.webkit.org/show_bug.cgi?id=149417
2291 Reviewed by Dean Jackson.
2293 * MiniBrowser/win/Common.cpp:
2294 (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2295 very start of execution, before the MiniBrowser.dll is loaded.
2296 * win/DLLLauncher/DLLLauncherMain.cpp:
2297 (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2298 present. On WinCairo, always use High DPI.
2300 2015-09-21 Ryosuke Niwa <rniwa@webkit.org>
2302 32-bit Mac build fix attempt after r190065.
2304 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2306 2015-09-21 Alexey Proskuryakov <ap@apple.com>
2308 [OS X] Update for Xcode 7.0 on Yosemite
2309 https://bugs.webkit.org/show_bug.cgi?id=149389
2311 Reviewed by Dan Bernstein.
2313 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2314 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2315 Removed unneeded declarations - conforming to a protocol is sufficient.
2317 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2318 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2319 Changed the definitions to be compiled whenever the SDK requires it (so we will have
2320 dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2322 2015-09-21 Simon Fraser <simon.fraser@apple.com>
2324 Add the ability for tests to run script in the UI process in WebKitTestRunner
2325 https://bugs.webkit.org/show_bug.cgi?id=149356
2327 Reviewed by Tim Horton.
2329 This change adds testRunner.runUIScript(script, callback), which allows a test
2330 to execute script in a JSContext which runs in the UI process. That context
2331 has bindings exposed through the UIScriptController interface; currently one test
2332 function, and some iOS-specific functions are included. UIScriptController can be
2333 async with a callback, and runUIScript() itself is asynchronous. When the UI
2334 script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2335 is a string passed back to the web process, and given to the runUIScript()
2338 Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2340 * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2341 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2342 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2343 (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2344 complete, call back into TestRunner.
2345 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2346 (WTR::nextUIScriptCallbackID):
2347 (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2348 (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2349 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2350 * WebKitTestRunner/PlatformWebView.h:
2351 * WebKitTestRunner/TestController.cpp:
2352 (WTR::updateTestOptionsFromTestHeader):
2353 (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2354 (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2355 * WebKitTestRunner/TestInvocation.cpp:
2356 (WTR::TestInvocation::shouldUseFixedLayout):
2357 (WTR::TestInvocation::shouldUseThreadedScrolling):
2358 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2359 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2360 (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2361 (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2362 * WebKitTestRunner/TestInvocation.h:
2363 * WebKitTestRunner/TestOptions.h:
2364 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2365 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2366 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2367 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2368 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2369 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2370 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2371 (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2372 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2373 (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2374 * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2375 (WTR::UIScriptController::doAsyncTask):
2376 (WTR::UIScriptController::zoomToScale):
2377 (WTR::UIScriptController::zoomScale):
2378 (WTR::UIScriptController::minimumZoomScale):
2379 (WTR::UIScriptController::maximumZoomScale):
2380 (WTR::UIScriptController::contentVisibleRect):
2381 * WebKitTestRunner/mac/EventSenderProxy.mm:
2382 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2383 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2384 * WebKitTestRunner/mac/TestControllerMac.mm:
2385 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2386 (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2387 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2388 * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2389 (UIScriptContext::UIScriptContext):
2390 (UIScriptContext::~UIScriptContext):
2391 (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2392 asynchronous, call the callback.
2393 (UIScriptContext::nextTaskCallbackID):
2394 (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2395 that has a callback). Has to store the callbackID of the script, so code called from the completion
2396 callback knows which UI script invoked it.
2397 (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2398 (UIScriptContext::uiScriptComplete):
2399 (UIScriptContext::objectFromRect): Make a JS object from a rect.
2400 * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2401 (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2402 * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2403 (WTR::UIScriptController::UIScriptController):
2404 (WTR::UIScriptController::makeWindowObject):
2405 (WTR::UIScriptController::wrapperClass):
2406 (WTR::UIScriptController::doAsyncTask):
2407 (WTR::UIScriptController::zoomToScale):
2408 (WTR::UIScriptController::zoomScale):
2409 (WTR::UIScriptController::minimumZoomScale):
2410 (WTR::UIScriptController::maximumZoomScale):
2411 (WTR::UIScriptController::contentVisibleRect):
2412 (WTR::UIScriptController::uiScriptComplete):
2413 * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2414 (WTR::UIScriptController::create):
2415 * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2417 2015-09-21 Tim Horton <timothy_horton@apple.com>
2419 Turn on threaded scrolling by default in the tests
2420 https://bugs.webkit.org/show_bug.cgi?id=149377
2422 Reviewed by Simon Fraser.
2424 * WebKitTestRunner/mac/TestControllerMac.mm:
2425 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2426 (WTR::shouldUseThreadedScrolling): Deleted.
2427 Turn on threaded scrolling by default.
2429 2015-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
2431 [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2432 https://bugs.webkit.org/show_bug.cgi?id=149252
2434 Reviewed by Darin Adler.
2436 In case of glib tests the test runner notifies about tests
2437 crashing, but for google tests we don't get any feedback, which
2438 means that in case of a test crashing we get a list of **PASS**
2439 messages and at the summary we are notified that the test suite
2440 has failed, but it's impossible to know which test cases have failed.
2442 * Scripts/run-gtk-tests:
2443 (TestRunner._run_google_test): Add a **CRASH** message if test
2446 2015-09-20 Alexey Proskuryakov <ap@apple.com>
2448 WebKitTestRunner can leak user content script results between tests
2449 https://bugs.webkit.org/show_bug.cgi?id=149391
2451 Reviewed by Sam Weinig.
2453 Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2454 about:blank, and thus about:blank doesn't have unintended side effects.
2456 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2457 (WTR::InjectedBundle::beginTesting):
2458 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2459 (WTR::InjectedBundlePage::resetAfterTest):
2461 2015-09-20 Alexey Proskuryakov <ap@apple.com>
2463 [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2464 https://bugs.webkit.org/show_bug.cgi?id=149384
2466 Reviewed by Chris Fleizach.
2468 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2469 (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2470 (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2471 regardless of whether someone else holds a reference (we also call -stopListening in
2474 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2475 (AccessibilityController::platformResetToConsistentState):
2476 (AccessibilityController::addNotificationListener):
2479 2015-09-20 Youenn Fablet <youenn.fablet@crf.canon.fr>
2481 Remove XHR_TIMEOUT compilation guard
2482 https://bugs.webkit.org/show_bug.cgi?id=149260
2484 Reviewed by Benjamin Poulain.
2486 * Scripts/webkitperl/FeatureList.pm:
2488 2015-09-19 Dan Bernstein <mitz@apple.com>
2490 Attempted build fix.
2492 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2494 2015-09-18 Commit Queue <commit-queue@webkit.org>
2496 Unreviewed, rolling out r189908.
2497 https://bugs.webkit.org/show_bug.cgi?id=149368
2499 Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2503 "printing does not use minimum page zoom factor"
2504 https://bugs.webkit.org/show_bug.cgi?id=108507
2505 http://trac.webkit.org/changeset/189908
2507 2015-09-18 Andy Estes <aestes@apple.com>
2509 [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2510 https://bugs.webkit.org/show_bug.cgi?id=149360
2512 Reviewed by Tim Horton.
2516 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2517 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2518 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2519 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2520 (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2522 * TestWebKitAPI/ios/pages.pages: Added.
2524 2015-09-18 Nan Wang <n_wang@apple.com>
2526 AX: Implement ARIA 1.1 @aria-current on iOS
2527 https://bugs.webkit.org/show_bug.cgi?id=149297
2529 Reviewed by Chris Fleizach.
2531 Added support to test aria-current on iOS.
2533 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2534 (AccessibilityUIElement::stringAttributeValue):
2535 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2536 (WTR::AccessibilityUIElement::stringAttributeValue):
2538 2015-09-18 Alexey Proskuryakov <ap@apple.com>
2540 iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2541 https://bugs.webkit.org/show_bug.cgi?id=149352
2543 Reviewed by Simon Fraser.
2545 * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2546 m_context can be null. This may indicate a bug in webkitpy too, but
2547 WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2548 wrong with opening and immediately closing it.
2550 2015-09-18 Daniel Bates <dabates@apple.com>
2552 isGitSVNDirectory() returns true when Git is not installed
2553 https://bugs.webkit.org/show_bug.cgi?id=149351
2555 Reviewed by Alexey Proskuryakov.
2557 Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2558 Git is not installed on the machine.
2560 * Scripts/VCSUtils.pm:
2561 (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2562 status code 0 (success).
2564 2015-09-18 Alex Christensen <achristensen@webkit.org>
2566 Prevent build-webkit from building four times on Windows
2567 https://bugs.webkit.org/show_bug.cgi?id=149336
2569 Reviewed by Brent Fulgham.
2571 * Scripts/build-webkit:
2572 Move the Windows code out of the for loop iterating over each subdirectory to be build.
2573 They're built all at once.
2574 * Scripts/webkitdirs.pm:
2575 (buildVisualStudioProject):
2576 (cmakeGeneratedBuildfile):
2577 Don't generate the Visual Studio solution if it already exists.
2578 It will run CMake again if necessary.
2580 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2582 [iOS WK2] WTR fails to set the key window in the UIKit sense
2583 https://bugs.webkit.org/show_bug.cgi?id=149325
2585 Reviewed by Tim Horton.
2587 -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2588 This causes UIKit to bypass code that actually sets the key window, resulting in
2589 [UIAppliation sharedApplication].keyWindow always being nil.
2591 Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2592 -[WebKitTestRunnerWindow isKeyWindow] call super.
2594 * WebKitTestRunner/PlatformWebView.h:
2595 (WTR::PlatformWebView::setWindowIsKey): Deleted.
2596 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2597 (WTR::PlatformWebView::setWindowIsKey):
2598 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2599 (WTR::PlatformWebView::setWindowIsKey):
2600 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2601 (-[WebKitTestRunnerWindow isKeyWindow]):
2602 (WTR::PlatformWebView::PlatformWebView):
2603 (WTR::PlatformWebView::~PlatformWebView):
2604 (WTR::PlatformWebView::setWindowIsKey):
2605 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2606 (WTR::PlatformWebView::setWindowIsKey):
2608 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2610 [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2611 https://bugs.webkit.org/show_bug.cgi?id=149321
2613 Reviewed by Tim Horton.
2615 InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
2616 enabled the "testing" viewport configuration, which disables page scaling.
2618 If we're running viewport tests, we want the normal web page configuration.
2619 Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2620 based on whether the test is in a "viewport" directory.
2622 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2623 (WTR::InjectedBundle::beginTesting):
2624 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2625 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2626 * WebKitTestRunner/TestInvocation.cpp:
2627 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2628 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2629 (WTR::TestInvocation::shouldMakeViewportFlexible):
2630 (WTR::TestInvocation::invoke):
2631 * WebKitTestRunner/TestInvocation.h:
2632 * WebKitTestRunner/ios/TestControllerIOS.mm:
2633 (WTR::TestController::platformConfigureViewForTest):
2634 (WTR::shouldMakeViewportFlexible): Deleted.
2636 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2638 Give iOS WebKitTestRunner a launch storyboard
2639 https://bugs.webkit.org/show_bug.cgi?id=149314
2641 Reviewed by Dan Bates.
2643 Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2644 that it's been built for specific device configurations, and puts the window
2645 at the top of the screen. This simplifies coordinate conversions in a future patch.
2647 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2648 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2649 * WebKitTestRunner/ios/Launch.storyboard: Added.
2651 2015-09-17 Myles C. Maxfield <mmaxfield@apple.com>
2653 Update licence in r189890
2654 https://bugs.webkit.org/show_bug.cgi?id=149306
2656 Reviewed by Dean Jackson.
2658 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2659 * FontWithFeatures/FontWithFeatures/FontCreator.h:
2660 * FontWithFeatures/FontWithFeatures/main.cpp:
2662 2015-09-17 Mark Lam <mark.lam@apple.com>
2664 Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2665 https://bugs.webkit.org/show_bug.cgi?id=149285
2667 Reviewed by Saam Barati.
2669 Just need to add an option to pass --no-jit to run-jsc-stress-test.
2671 * Scripts/run-javascriptcore-tests:
2672 (runJSCStressTests):
2674 2015-09-17 Alex Christensen <achristensen@webkit.org>
2676 Switch AppleWin build to use CMake
2677 https://bugs.webkit.org/show_bug.cgi?id=149163
2679 Reviewed by Brent Fulgham.
2681 * Scripts/build-webkit:
2682 * Scripts/run-api-tests:
2685 (prepareEnvironmentForRunningTestTool):
2687 (testToolPath): Deleted.
2688 Run the API tests as separate executables on Windows.
2689 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2690 * Scripts/webkitdirs.pm:
2691 (checkRequiredSystemConfig):
2692 (jhbuildWrapperPrefixIfNeeded):
2693 (generateBuildSystemFromCMakeProject):
2694 Fix configuration quirks.
2696 2015-09-17 Dean Johnson <dean_johnson@apple.com>
2698 Added toggle options for hiding and showing certain platform families on the dashboard.
2699 https://bugs.webkit.org/show_bug.cgi?id=148403
2701 Reviewed by David Kilzer.
2703 This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2704 individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2705 families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2706 in lieu of an "all" button in the toggle menu.
2708 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2709 (parsePlatformFamily): Helper function to parse out a platform family.
2710 (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2711 page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2712 (updateToggleButtons): Updates the status of the toggle buttons.
2713 (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2714 (documentReady): Added creation of toggle buttons.
2715 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2716 (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2717 (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2718 (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
2719 this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2720 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2721 (QueueView): Updated to use hiddenPlatformFamilies.
2722 (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2723 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2724 (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2725 (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2726 (Settings.prototype.toggleHiddenPlatform): Deleted.
2727 (Settings.prototype.clearHiddenPlatforms): Deleted.
2728 (Settings.prototype.toggleShowPlatformFamily): Deleted.
2729 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2730 (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2731 (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2732 (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2733 (table.queue-grid tr.headers th):
2734 (div.settingsWrapper.hide):
2735 (div.settingsWrapper):
2736 (div.familyToggleWrapper):
2737 (div.platformFamilyToggleButton):
2738 (div.platformFamilyShowToggleButton:not(:last-child)):
2740 (div.accessibilityButton):
2741 (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2742 (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2743 (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2744 platformFamilyToggleButton and settingsWrapper class.
2745 (.accessibilityButton): Deleted.
2747 2015-09-17 Tim Horton <timothy_horton@apple.com>
2749 Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2750 https://bugs.webkit.org/show_bug.cgi?id=148904
2752 Reviewed by Myles Maxfield.
2754 * WebKitTestRunner/TestController.cpp:
2755 (WTR::parseBooleanTestHeaderValue):
2756 (WTR::updateViewOptionsFromTestHeader):
2757 Check for the key "useThreadedScrolling".
2758 Add some code to check for "true" and "false" for boolean options.
2760 (WTR::TestController::viewOptionsForTest):
2761 Apply the test's overrides last, even after the platform's.
2763 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
2765 printing does not use minimum page zoom factor
2766 https://bugs.webkit.org/show_bug.cgi?id=108507
2768 Reviewed by Darin Adler.
2770 WebKitTestRunner always takes the snapshots from the UI process
2771 (expect for IOS), so in the case of printing, the layout in the
2772 web view is not the expected one. When printing, we need to take
2773 the snapshot in the web process and ensure it's rendered with a
2776 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2777 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2778 kWKSnapshotOptionsPrinting option to
2779 WKBundlePageCreateSnapshotWithOptions() when printing. When not
2780 printing, don't even create the snapshot, since it will be ignored
2781 by the UI process that always creates its own from the WebView (expect for IOS platform)
2782 * WebKitTestRunner/TestInvocation.cpp:
2783 (WTR::TestInvocation::dumpResults): Use always the snapshot image
2784 received from the web process if any when comparing pixel
2785 results. Now we only receive a snapshot from the web process in
2786 case of printing, or when platform is IOS. Otherwhise, generate
2787 the snapshot from the WebView as usual.
2788 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2789 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2790 is created by the caller now, but the CG implementation needs to
2791 know if it's a Web or UI process snapshot.
2792 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2793 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2794 cairo surface for the given image.
2795 * WebKitTestRunner/cg/TestInvocationCG.cpp:
2796 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2797 CGContext for the given image.
2799 2015-09-16 Myles C. Maxfield <mmaxfield@apple.com>
2801 Create a font which can be used for testing font features
2802 https://bugs.webkit.org/show_bug.cgi?id=149237
2804 Reviewed by Simon Fraser.
2806 This patch adds a new project in the Tools/ directory which generates a font which can
2807 be used for testing font features. This is a standalone project consisting of two files:
2808 1. A file which actually generates the byte vector representing the font. This file has
2809 a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2810 specific, and only relies on the C++ STL.
2811 2. A file with a main() which calls generateFont() and writes out the font, as well as
2812 uses the font to render some demonstration text into a .png file. This file is platform
2815 The font itself only supports the following characters:
2816 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2817 However, the shape of these letters are either an X or a check mark.
2819 The letter "A" always is a check mark.
2820 The letter "B" always is an X.
2821 Without any font features turned on, the rest of the letters are shown as X.
2823 Each font feature has an letter associated with it. When the font feature is enabled,
2824 that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2827 Here are the mappings of font features to letters:
2859 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2860 * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2862 (roundDownToPowerOfTwo):
2863 (isFourByteAligned):
2866 (writeCFFEncodedNumber):
2867 (CFFBuilder::CFFBuilder):
2868 (CFFBuilder::takeResult):
2869 (CFFBuilder::moveTo):
2870 (CFFBuilder::lineTo):
2871 (CFFBuilder::curveToCubic):
2872 (CFFBuilder::closePath):
2873 (CFFBuilder::writePoint):
2874 (generateBoxCharString):
2875 (generateCheckCharString):
2876 (generateXCharString):
2877 (charStringForGlyph):
2878 (Generator::generate):
2879 (Generator::Placeholder::Placeholder):
2880 (Generator::Placeholder::populate):
2881 (Generator::Placeholder::~Placeholder):
2882 (Generator::placeholder):
2883 (Generator::append16):
2884 (Generator::append32):
2885 (Generator::append32BitCode):
2886 (Generator::overwrite16):
2887 (Generator::overwrite32):
2888 (Generator::appendCFFTable):
2889 (Generator::appendSubstitutionSubtable):
2890 (Generator::appendScriptSubtable):
2891 (Generator::appendGSUBTable):
2892 (Generator::appendOS2Table):
2893 (Generator::appendFormat12CMAPTable):
2894 (Generator::appendFormat4CMAPTable):
2895 (Generator::appendCMAPTable):
2896 (Generator::appendHEADTable):
2897 (Generator::appendHHEATable):
2898 (Generator::appendHMTXTable):
2899 (Generator::appendMAXPTable):
2900 (Generator::appendNAMETable):
2901 (Generator::appendPOSTTable):
2902 (Generator::calculateChecksum):
2903 (Generator::appendTable):
2905 * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2906 * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2907 (drawTextWithFeature):
2910 2015-09-16 Commit Queue <commit-queue@webkit.org>
2912 Unreviewed, rolling out r189875 and r189878.
2913 https://bugs.webkit.org/show_bug.cgi?id=149235
2915 cygwin cmake build not ready yet (Requested by alexchristensen
2918 Reverted changesets:
2920 "Switch AppleWin build to use CMake"
2921 https://bugs.webkit.org/show_bug.cgi?id=149163
2922 http://trac.webkit.org/changeset/189875
2924 "Cygwin build fix after r189875"
2925 http://trac.webkit.org/changeset/189878
2927 2015-09-16 Alex Christensen <achristensen@webkit.org>
2929 Cygwin build fix after r189875
2931 * Scripts/build-webkit:
2932 * Scripts/webkitdirs.pm:
2933 (jhbuildWrapperPrefixIfNeeded):
2934 (generateBuildSystemFromCMakeProject):
2935 Make things work with cygwin and cmake.
2937 2015-09-16 Alex Christensen <achristensen@webkit.org>
2939 Switch AppleWin build to use CMake
2940 https://bugs.webkit.org/show_bug.cgi?id=149163
2942 Reviewed by Brent Fulgham.
2944 * Scripts/build-webkit:
2946 * Scripts/run-api-tests:
2949 (prepareEnvironmentForRunningTestTool):
2951 (testToolPath): Deleted.
2952 Run the API tests as separate executables on Windows.
2953 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2955 2015-09-16 Alexey Proskuryakov <ap@apple.com>
2957 Add newer build.webkit.org pages to robots.txt
2958 https://bugs.webkit.org/show_bug.cgi?id=149219
2960 Reviewed by Darin Adler.
2962 Indexing bot watcher's dashboard can't be good.
2964 * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2966 2015-09-16 Alex Christensen <achristensen@webkit.org>
2968 Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2970 * BuildSlaveSupport/built-product-archive:
2973 2015-09-16 Csaba Osztrogonác <ossy@webkit.org>
2975 [EFL] Fix the help message of separated web process option of MiniBrowser
2976 https://bugs.webkit.org/show_bug.cgi?id=149212
2978 Reviewed by Gyuyoung Kim.
2980 * MiniBrowser/efl/main.c:
2982 2015-09-16 Alex Christensen <achristensen@webkit.org>
2984 Fix python syntax after r189851.
2986 * BuildSlaveSupport/built-product-archive:
2988 For loops need a colon.
2990 2015-09-15 Alex Christensen <achristensen@webkit.org>
2992 Fix Windows test bots after changing to non-cygwin build
2993 https://bugs.webkit.org/show_bug.cgi?id=149196
2995 Reviewed by Daniel Bates.
2997 * BuildSlaveSupport/built-product-archive:
2999 Using different versions of python makes what I think is https://bugs.python.org/issue15795
3000 prevent us from executing files from the archive on the test bots.
3002 2015-09-15 Ryosuke Niwa <rniwa@webkit.org>
3004 Add ShadowRoot interface and Element.prototype.attachShadow
3005 https://bugs.webkit.org/show_bug.cgi?id=149187
3007 Reviewed by Antti Koivisto.
3009 * Scripts/webkitperl/FeatureList.pm:
3011 2015-09-15 Aakash Jain <aakash_jain@apple.com>
3013 Appscale queue status json output lacks bots
3014 https://bugs.webkit.org/show_bug.cgi?id=149194
3015 <rdar://problem/22171089>
3017 Reviewed by Alexey Proskuryakov.
3019 * QueueStatusServer/handlers/queuestatusjson.py:
3020 (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3021 * QueueStatusServer/index.yaml: Index according to appscale requirements.
3023 2015-09-15 Brent Fulgham <bfulgham@apple.com>
3025 [Win] Provide a means for viewing the layer tree
3026 https://bugs.webkit.org/show_bug.cgi?id=149165
3028 Reviewed by Simon Fraser.
3030 Update MiniBrowser with a new Debug menu option that will
3031 dump the current layer tree to the debug console.
3033 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3034 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3035 * MiniBrowser/win/Common.cpp:
3036 (WndProc): Add handler for 'Print Layer Tree' menu option.
3037 * MiniBrowser/win/MiniBrowser.cpp:
3038 (MiniBrowser::printLayerTree): Added Handler.
3039 * MiniBrowser/win/MiniBrowser.h:
3041 2015-09-14 Myles C. Maxfield <mmaxfield@apple.com>
3043 WebKitTestRunner declarative language setting is broken for iOS
3044 https://bugs.webkit.org/show_bug.cgi?id=149119
3048 In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3049 lost in the final version which got committed. This simply implements the existing
3050 OS X behavior on iOS.
3052 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3053 (WTR::InjectedBundle::platformInitialize):
3055 2015-09-14 Dewei Zhu <dewei_zhu@apple.com>
3057 Unreviewed, add myself to committers list.
3059 * Scripts/webkitpy/common/config/contributors.json:
3061 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
3063 [Cocoa] Allow testing with the system language
3064 https://bugs.webkit.org/show_bug.cgi?id=148671
3066 Reviewed by Anders Carlsson and Alexey Proskuryakov.
3068 React to tests marked with language=lang1,lang2,etc in their header.
3069 Once this information is parsed, pass it to
3070 WKContextConfigurationSetOverrideLanguages().
3072 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3073 (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3075 * WebKitTestRunner/TestController.cpp:
3076 (WTR::TestController::createWebViewWithOptions): Call
3077 WKContextConfigurationSetOverrideLanguages().
3078 (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3079 * WebKitTestRunner/TestOptions.h:
3080 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3081 (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3082 option to restart the web process.
3083 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3084 (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3086 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
3088 [WKTR] Allow changing the WKContextConfiguration between successive tests
3089 https://bugs.webkit.org/show_bug.cgi?id=148833
3091 Reviewed by Tim Horton.
3093 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3094 However, there are certain tests which require specifying options in this object. This patch makes
3095 our existing code for recreating the test runner web view also recreate the WKContext.
3097 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3100 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3101 * WebKitTestRunner/PlatformWebView.h:
3102 (WTR::PlatformWebView::options):
3103 * WebKitTestRunner/TestController.cpp:
3104 (WTR::TestController::initialize):
3105 (WTR::TestController::generateContextConfiguration):
3106 (WTR::TestController::generatePageConfiguration):
3107 (WTR::TestController::createWebViewWithOptions):
3108 (WTR::TestController::ensureViewSupportsOptionsForTest):
3109 (WTR::updateContextConfigurationOptionsFromTestHeader):
3110 (WTR::TestController::contextConfigurationOptionsForTest):
3111 (WTR::TestController::platformCreateWebView):
3112 (WTR::TestController::platformCreateOtherPage):
3113 (WTR::updateViewOptionsFromTestHeader): Deleted.
3114 (WTR::TestController::viewOptionsForTest): Deleted.
3115 * WebKitTestRunner/TestController.h:
3116 (WTR::TestController::injectedBundlePath):
3117 (WTR::TestController::testPluginDirectory):
3118 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3119 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3120 (WTR::TestController::platformCreateWebView):
3121 (WTR::TestController::platformCreateOtherPage):
3122 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3123 (WTR::PlatformWebView::PlatformWebView):
3124 (WTR::PlatformWebView::viewSupportsOptions):
3125 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3126 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3127 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3128 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3129 (WTR::PlatformWebView::PlatformWebView):
3130 (WTR::PlatformWebView::viewSupportsOptions):
3131 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3132 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3133 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3134 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3135 (WTR::PlatformWebView::PlatformWebView):
3136 (WTR::PlatformWebView::viewSupportsOptions):
3137 * WebKitTestRunner/ios/TestControllerIOS.mm:
3138 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3139 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3140 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3141 (WTR::PlatformWebView::PlatformWebView):
3142 (WTR::PlatformWebView::viewSupportsOptions):
3143 * WebKitTestRunner/mac/TestControllerMac.mm:
3144 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3145 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3147 2015-09-11 Michael Saboff <msaboff@apple.com>
3149 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
3150 https://bugs.webkit.org/show_bug.cgi?id=149083
3152 Reviewed by Alexey Proskuryakov.
3154 Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
3156 * DumpRenderTree/mac/LayoutTestHelper.m:
3157 (colorProfileURLForDisplay):
3159 2015-09-11 Saam barati <sbarati@apple.com>
3161 There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
3162 https://bugs.webkit.org/show_bug.cgi?id=149058
3164 Reviewed by Geoffrey Garen.
3166 * Scripts/run-jsc-stress-tests:
3168 2015-09-10 Commit Queue <commit-queue@webkit.org>
3170 Unreviewed, rolling out r189595.
3171 https://bugs.webkit.org/show_bug.cgi?id=149052
3173 The tests still fail (Requested by ap on #webkit).
3177 "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
3179 https://bugs.webkit.org/show_bug.cgi?id=142929
3180 http://trac.webkit.org/changeset/189595
3182 2015-09-10 Alexey Proskuryakov <ap@apple.com>
3184 Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
3185 https://bugs.webkit.org/show_bug.cgi?id=142929
3187 Reviewed by Brent Fulgham.
3189 Silence the logging. We'll track fixing the root cause in Radar.
3191 * Scripts/webkitpy/port/mac.py:
3192 (MacPort.stderr_patterns_to_strip): Added a FIXME.
3194 * Scripts/webkitpy/port/win.py:
3195 (WinPort.logging_patterns_to_strip): Added.
3197 2015-09-09 Andy Estes <aestes@apple.com>
3199 [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
3200 https://bugs.webkit.org/show_bug.cgi?id=149022
3202 Reviewed by Daniel Bates.
3204 Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
3205 did not account for this.
3207 * Scripts/webkitpy/xcode/simulator.py:
3208 (Simulator): Optionally matched a revision at the end of a runtime version number.
3209 * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
3211 2015-09-09 Andy Estes <aestes@apple.com>
3213 [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
3214 https://bugs.webkit.org/show_bug.cgi?id=149029
3215 <rdar://problem/22432624>
3217 Reviewed by Daniel Bates.
3219 * Scripts/webkitpy/xcode/simulator.py:
3220 (Simulator): Taught to parse tvOS runtimes.
3221 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3223 2015-09-09 Alexey Proskuryakov <ap@apple.com>
3225 Fix bit rot on bot watcher's dashboard page
3226 https://bugs.webkit.org/show_bug.cgi?id=149012
3228 Reviewed by Tim Horton.
3230 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3231 The code path used by the metrics page was trying to add properties to an undefined.
3233 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3234 Silence an expection that would occur when the step has no logs. This should never
3235 happen, but it did (perhaps buildbot was misconfigured for a while).
3237 2015-09-09 Alexey Proskuryakov <ap@apple.com>
3239 Update LayoutTestRelay xcconfig file.
3241 Rubber-stamped by Dan Bernstein.
3243 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3245 2015-09-09 Saam barati <sbarati@apple.com>
3247 DFG should have a debugging option that runs a phase that flushes all locals
3248 https://bugs.webkit.org/show_bug.cgi?id=148916
3250 Reviewed by Filip Pizlo.
3252 * Scripts/run-jsc-stress-tests:
3254 2015-09-09 Commit Queue <commit-queue@webkit.org>
3256 Unreviewed, rolling out r189530 and r189534.
3257 https://bugs.webkit.org/show_bug.cgi?id=148996
3259 Caused assertion failures on Yosemite (Requested by litherum
3262 Reverted changesets:
3264 "[WKTR] Allow changing the WKContextConfiguration between
3266 https://bugs.webkit.org/show_bug.cgi?id=148833
3267 http://trac.webkit.org/changeset/189530
3269 "[Cocoa] Fix the tests after r189530"
3270 http://trac.webkit.org/changeset/189534
3272 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
3274 [Cocoa] Fix the tests after r189530
3278 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3279 (WTR::initializeWebViewConfiguration):
3281 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
3283 [WKTR] Allow changing the WKContextConfiguration between successive tests
3284 https://bugs.webkit.org/show_bug.cgi?id=148833
3286 Reviewed by Tim Horton.
3288 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3289 However, there are certain tests which require specifying options in this object. This patch makes
3290 our existing code for recreating the test runner web view also recreate the WKContext.
3292 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3295 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3296 * WebKitTestRunner/PlatformWebView.h:
3297 (WTR::PlatformWebView::options):
3298 * WebKitTestRunner/TestController.cpp:
3299 (WTR::TestController::initialize):
3300 (WTR::TestController::generateContextConfiguration):
3301 (WTR::TestController::generatePageConfiguration):
3302 (WTR::TestController::createWebViewWithOptions):
3303 (WTR::TestController::ensureViewSupportsOptionsForTest):
3304 (WTR::updateContextConfigurationOptionsFromTestHeader):
3305 (WTR::TestController::contextConfigurationOptionsForTest):
3306 (WTR::TestController::platformCreateWebView):
3307 (WTR::TestController::platformCreateOtherPage):
3308 (WTR::updateViewOptionsFromTestHeader): Deleted.
3309 (WTR::TestController::viewOptionsForTest): Deleted.
3310 * WebKitTestRunner/TestController.h:
3311 (WTR::TestController::injectedBundlePath):
3312 (WTR::TestController::testPluginDirectory):
3313 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3314 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3315 (WTR::TestController::platformCreateWebView):
3316 (WTR::TestController::platformCreateOtherPage):
3317 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3318 (WTR::PlatformWebView::PlatformWebView):
3319 (WTR::PlatformWebView::viewSupportsOptions):
3320 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3321 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3322 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3323 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3324 (WTR::PlatformWebView::PlatformWebView):
3325 (WTR::PlatformWebView::viewSupportsOptions):
3326 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3327 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3328 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3329 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3330 (WTR::PlatformWebView::PlatformWebView):
3331 (WTR::PlatformWebView::viewSupportsOptions):
3332 * WebKitTestRunner/ios/TestControllerIOS.mm:
3333 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3334 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3335 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3336 (WTR::PlatformWebView::PlatformWebView):
3337 (WTR::PlatformWebView::viewSupportsOptions):
3338 * WebKitTestRunner/mac/TestControllerMac.mm:
3339 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3340 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3342 2015-09-08 Daniel Bates <dabates@apple.com>
3344 [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
3345 https://bugs.webkit.org/show_bug.cgi?id=148980
3347 Reviewed by Alexey Proskuryakov.
3349 Add setting to enable/disable accelerated drawing so as to support testing
3350 this feature in MiniBrowser on Mac.
3352 * MiniBrowser/mac/SettingsController.h:
3353 * MiniBrowser/mac/SettingsController.m:
3354 (-[SettingsController _populateMenu]): Add menu item.
3355 (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
3356 (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
3357 (-[SettingsController acceleratedDrawingEnabled]): Added.
3358 * MiniBrowser/mac/WK1BrowserWindowController.m:
3359 (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
3360 * MiniBrowser/mac/WK2BrowserWindowController.m:
3361 (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
3363 2015-09-08 Jason Marcell <jmarcell@apple.com>
3365 Unreviewed. Added myself as a commiter in contributors.json.
3367 * Scripts/webkitpy/common/config/contributors.json:
3369 2015-09-08 Keith Miller <keith_miller@apple.com>
3371 Unreviewed, added myself to the list of contributors.
3373 * Scripts/webkitpy/common/config/contributors.json:
3375 2015-09-08 Daniel Bates <dabates@apple.com>
3377 Dashboard: Remove use of z-index for ring overlay; use DOM ordering
3378 https://bugs.webkit.org/show_bug.cgi?id=148921
3380 Reviewed by Alexey Proskuryakov.
3382 The ring image is positioned above the platform icon in markup and we specify the CSS
3383 property z-index for the ring image so that it is painted on top of the platform icon
3384 instead of below it (by DOM ordering). Instead we can take advantage of the transparency
3385 of the ring image, switch the order of these DOM elements and remove the use of the CSS
3386 property z-index to achieve a similar effect.
3388 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3389 (documentReady): Create the platform icon image element before the ring image such that
3390 the ring image is painted on top of the platform icon.
3391 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3392 (table.queue-grid td.logo img.ring): Removed property z-index.
3394 2015-09-08 Daniel Bates <dabates@apple.com>
3396 Dashboard: Remove duplicate gear icon data URLs
3397 https://bugs.webkit.org/show_bug.cgi?id=148920
3399 Reviewed by Alexey Proskuryakov.
3401 Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
3402 background-image associated with each of the three gear icon states: collapsed (.settings), hover
3403 (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
3404 as a mask and make use of the CSS background-color to define the fill color for each of these three
3407 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3408 (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
3409 (.settings:hover): Override CSS background-color for hover state.
3410 (.settings-visible .settings): Override CSS background-color for expanded state.
3412 2015-09-07 Andy Estes <aestes@apple.com>
3414 [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
3415 https://bugs.webkit.org/show_bug.cgi?id=148946
3416 <rdar://problem/22603981>
3418 Reviewed by Dan Bernstein.
3420 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3421 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3423 2015-09-07 Hunseop Jeong <hs85.jeong@samsung.com>
3425 [EFL] Many of the css3/device-adapt/* tests failed after r188548.
3426 https://bugs.webkit.org/show_bug.cgi?id=148927
3428 Reviewed by Csaba Osztrogonác.
3430 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3431 overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
3433 * WebKitTestRunner/TestController.cpp:
3434 (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
3435 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3436 (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
3438 2015-09-07 Andy Estes <aestes@apple.com>
3440 Fix the Production build after r189455.
3442 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
3443 In-App Purchase template instead of the Aggregate template. Whoops.
3445 2015-09-06 Andy Estes <aestes@apple.com>
3447 WebKit.xcworkspace should be be able to build iOS platforms
3448 https://bugs.webkit.org/show_bug.cgi?id=148881
3450 Reviewed by Daniel Bates.
3452 Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
3453 for all supported platforms.
3455 * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
3456 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
3457 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
3458 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
3460 2015-09-06 Andy Estes <aestes@apple.com>
3462 WebKitTestRunner should build for iOS using the default target
3463 https://bugs.webkit.org/show_bug.cgi?id=148918
3465 Reviewed by Daniel Bates.
3467 When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
3468 iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
3469 non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
3471 This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
3472 both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
3473 and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
3474 WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
3475 WebKitTestRunner is skipped when installing on iOS.
3477 The target dependency graph now looks like this:
3481 WebKitTestRunner (Library)
3482 WebKitTestRunnerInjectedBundle
3485 WebKitTestRunner (Library)
3486 WebKitTestRunnerInjectedBundle
3489 * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3490 * Scripts/build-webkittestrunner: Ditto.
3491 * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3492 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3493 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3494 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3495 excluded iOS-only files, and skipped installing on iOS.
3496 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3497 excluded Mac-only files, and skipped installing on Mac.
3498 * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3499 * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3500 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3501 Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3502 new configuration files.
3504 2015-09-05 Joseph Pecoraro <pecoraro@apple.com>
3506 Web Inspector: Improve prepare-ChangeLog for multiple cases
3507 https://bugs.webkit.org/show_bug.cgi?id=148875
3509 Reviewed by Timothy Hatcher.
3511 * Scripts/prepare-ChangeLog:
3512 (get_function_line_ranges_for_javascript):
3513 - We were ignoring everything inside of an anonymous function expression,
3514 such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3515 Better handle this by inserting a few tweaks.
3516 - Allow method syntax outside of classes as long as they are at the global level.
3517 - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3519 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3520 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3521 (Foo.prototype.method1):
3522 (Foo.prototype.method2):
3523 (Foo.prototype.method3.innerFunction):
3524 (Foo.prototype.method3):
3525 (insideGlobalAnonymousFunctionExpression):
3526 (foo.insideGlobalFunctionExpression):
3527 (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3528 (IssueWithMapGetAndSet.prototype.method1):
3529 (IssueWithMapGetAndSet.prototype.method2):
3530 (IssueWithMapGetAndSet.prototype.method3):
3531 (IssueWithMapGetAndSet):
3533 2015-09-05 Yusuke Suzuki <utatane.tea@gmail.com>
3535 [ES6] Enable ES6 Module in JSC shell by default
3536 https://bugs.webkit.org/show_bug.cgi?id=148689
3538 Reviewed by Geoffrey Garen.
3540 * Scripts/run-javascriptcore-tests:
3541 (runJSCStressTests):
3542 * Scripts/run-jsc-stress-tests:
3544 2015-09-04 Basile Clement <basile_clement@apple.com>
3546 Unreviewed, change my email address.
3548 * Scripts/webkitpy/common/config/contributors.json:
3550 2015-09-04 Beth Dakin <bdakin@apple.com>
3552 Should have a test to make sure links don't navigate after a cancelled force
3554 https://bugs.webkit.org/show_bug.cgi?id=148846
3556 Reviewed by Tim Horton.
3558 New EventSender function for a started then cancelled force click.
3559 * WebKitTestRunner/EventSenderProxy.h:
3560 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3561 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3562 (WTR::EventSendingController::mouseForceClick):
3563 (WTR::EventSendingController::startAndCancelMouseForceClick):
3564 (WTR::EventSendingController::mouseForceDown):
3565 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3566 * WebKitTestRunner/TestController.cpp:
3567 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3568 * WebKitTestRunner/mac/EventSenderProxy.mm:
3569 (WTR::EventSenderProxy::mouseForceClick):
3570 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3571 (WTR::EventSenderProxy::mouseForceDown):
3572 (WTR::EventSenderProxy::mouseMoveTo):
3574 2015-09-04 Tim Horton <timothy_horton@apple.com>
3576 Add a test for r179736 (programmatic navigation during swipe causing a crash)
3577 https://bugs.webkit.org/show_bug.cgi?id=148830
3579 Reviewed by Beth Dakin.