Update Bot Watcher's Dashboard for Buildbot 0.9
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
2
3         Update Bot Watcher's Dashboard for Buildbot 0.9
4         https://bugs.webkit.org/show_bug.cgi?id=174777
5
6         Reviewed by Daniel Bates.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
9         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
10         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
11         in a dictionary.
12         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
13         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
14         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
15         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
16         (parseRevisionProperty): Ditto.
17         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
18         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
19         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
20         have changed in Buildbot 0.9.
21         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
22         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
23         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
24         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
25         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
26         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
27         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
28         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
29         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
30         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
31         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
32         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
33         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
34         (BuildbotQueue.prototype.get overviewURL): Ditto.
35         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
36         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
37         Buildbot 0.8 or 0.9.
38         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
39         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
40         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
41         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
42         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
43         Therefore we are fetching information for fixed number of build. 
44         Also iterating the loop incrementally since the build data is already reverse sorted.
45         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
46         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
47         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
48         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
49         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
50
51 2017-08-01  Devin Rousso  <drousso@apple.com>
52
53         Web Inspector: simplify WebInspector with WI
54         https://bugs.webkit.org/show_bug.cgi?id=175058
55
56         Reviewed by Joseph Pecoraro.
57
58         * Scripts/check-inspector-strings:
59         (extract_ui_strings):
60         * Scripts/extract-localizable-js-strings:
61
62 2017-08-01  Youenn Fablet  <youenn@apple.com>
63
64         Layout tests with 'https' suffix should be run over HTTPS
65         https://bugs.webkit.org/show_bug.cgi?id=174992
66
67         Reviewed by Chris Dumez.
68
69         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
70         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
71         Covered by corresponding unit tests.
72
73         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
74         (run_server):
75         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
76         (base_http_url):
77         (base_https_url):
78         (base_url): Deleted.
79         * Scripts/webkitpy/port/base.py:
80         (Port.to.web_platform_test_server_base_http_url):
81         (Port.to):
82         (Port.to.web_platform_test_server_base_https_url):
83         (Port.to.web_platform_test_server_base_url): Deleted.
84         * Scripts/webkitpy/port/driver.py:
85         (Driver.__init__):
86         (Driver.wpt_test_path_to_uri):
87         (Driver):
88         (Driver.http_test_path_to_uri):
89         (Driver.test_to_uri):
90         (Driver.uri_to_test):
91         * Scripts/webkitpy/port/driver_unittest.py:
92         (DriverTest.test_test_to_uri):
93         (DriverTest.test_uri_to_test):
94
95 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
96
97         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
98         https://bugs.webkit.org/show_bug.cgi?id=173998
99
100         Reviewed by Darin Adler.
101
102         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
103         detect mistakes in backward compatibility in the future when we change it.
104
105         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
106         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
107         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
108         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
109         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
110         internal key data slot.
111
112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
113         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
114         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
115         (getNextMessage):
116         (TEST):
117         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
118         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
119         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
120         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
121         These are the pre-baked databases.
122         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
123         This is the actual test that do all the reads and comparisons.
124         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
125         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
126         IndexedDB new stuffs. Then it can be used to bake the database again.
127
128 2017-08-01  Brady Eidson  <beidson@apple.com>
129
130         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
131         https://bugs.webkit.org/show_bug.cgi?id=175030
132
133         Reviewed by Andy Estes.
134
135         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
136         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
137
138 2017-08-01  Brady Eidson  <beidson@apple.com>
139
140         Part 2 of: Rename DatabaseProcess to StorageProcess.
141         https://bugs.webkit.org/show_bug.cgi?id=174880
142
143         Reviewed by Andy Estes.
144
145         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
146         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
147         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
148         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
149         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
150         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
151         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
152         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
153
154 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
155
156         Fix JSCOnly ARM buildbots after r220047
157         https://bugs.webkit.org/show_bug.cgi?id=174993
158
159         Reviewed by Saam Barati.
160
161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
162         (BuildAndRemoteJSCTestsFactory.__init__):
163
164 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
165
166         [WTF] Introduce Private Symbols
167         https://bugs.webkit.org/show_bug.cgi?id=174935
168
169         Reviewed by Darin Adler.
170
171         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
172         (TestWebKitAPI::TEST):
173
174 2017-07-30  Darin Adler  <darin@apple.com>
175
176         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
177         https://bugs.webkit.org/show_bug.cgi?id=130653
178
179         Reviewed by Antti Koivisto.
180
181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
182         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
183         when calling frameDidChangeLocation.
184         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
185         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
186         thus causing mysterious failures of a couple of tests. There are two remaining issues:
187         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
188         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
189         same logic flaw that causes "top loading frame" to get set to one of the subframes in
190         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
191         loading, subframe starts loading. It would be good to clean that up some day, but for now
192         this patch makes the two work identically rather than changing both.
193         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
194
195 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
196
197         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
198         https://bugs.webkit.org/show_bug.cgi?id=174963
199
200         Reviewed by Darin Adler.
201
202         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
203         RetainPtr<>. This patch changes them to all use auto.
204
205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
206         (TestWebKitAPI::TEST):
207
208 2017-07-30  Brady Eidson  <beidson@apple.com>
209
210         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
211         https://bugs.webkit.org/show_bug.cgi?id=174958
212
213         Reviewed by Darin Adler.
214
215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
216         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
217         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
218         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
219         (runUntilTasksInFlight):
220         (TEST):
221
222 2017-07-28  Commit Queue  <commit-queue@webkit.org>
223
224         Unreviewed, rolling out r219990.
225         https://bugs.webkit.org/show_bug.cgi?id=174961
226
227         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
228         estes on #webkit).
229
230         Reverted changeset:
231
232         "Part 2 of: Rename DatabaseProcess to StorageProcess."
233         https://bugs.webkit.org/show_bug.cgi?id=174880
234         http://trac.webkit.org/changeset/219990
235
236 2017-07-28  Brady Eidson  <beidson@apple.com>
237
238         API tests that use URLSchemeHandler are failing.
239         https://bugs.webkit.org/show_bug.cgi?id=174950
240
241         Reviewed by Alex Christensen.
242
243         Fix the NoMIMEType test to be correct.
244
245         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
246         (-[SchemeHandler initWithData:mimeType:]):
247         (-[SchemeHandler webView:startURLSchemeTask:]):
248         (TEST):
249
250 2017-07-28  Daniel Bates  <dabates@apple.com>
251
252         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
253         https://bugs.webkit.org/show_bug.cgi?id=174876
254
255         Reviewed by Alex Christensen.
256
257         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
258         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
259         they provide a more direct way to test the platform abstraction.
260
261         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
262
263         * Scripts/prepare-ChangeLog:
264         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
265         of the current working directory.
266
267 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
268
269         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
270         https://bugs.webkit.org/show_bug.cgi?id=174930
271
272         Unreviewed test fix.
273
274         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
275
276         * Scripts/prepare-ChangeLog:
277         (get_function_line_ranges_for_cpp):
278
279 2017-07-28  JF Bastien  <jfbastien@apple.com>
280
281         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
282         https://bugs.webkit.org/show_bug.cgi?id=174930
283
284         Reviewed by Daniel Bates.
285
286         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
287         here also teach it about const and volatile overloads. I didn't do
288         reference and rvalue reference overloads because we don't really
289         use them, and the current parser throws away those characters and
290         it doesn't seem worth making it more complex.
291
292         * Scripts/prepare-ChangeLog:
293         (get_function_line_ranges_for_cpp):
294         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
295         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
296         (Foo::Arrow::arrow):
297         (Foo::Arrow::otherArrow):
298         (Foo::Arrow::otherArrow const):
299         (Foo::Arrow::otherArrow volatile):
300         (Foo::Arrow::otherArrow const volatile):
301
302 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
303
304         [GTK] Building with ENABLE_VIDEO=OFF fails
305         https://bugs.webkit.org/show_bug.cgi?id=174940
306
307         Reviewed by Alex Christensen.
308
309         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
310         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
311
312         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
313         (methodCallCallback): Add missing USE(GSTREAMER) guard.
314
315 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
316
317         [WPE] Implement EventSenderProxy in WTR
318         https://bugs.webkit.org/show_bug.cgi?id=173419
319
320         Reviewed by Žan Doberšek.
321
322         Add the implementation of EventSenderProxy to the WTR. This
323         allows us to extend the coverage of the test suite in WKWPE.
324
325         * WebKitTestRunner/EventSenderProxy.h:
326         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
327         libxkbcommon needed to deal with key events.
328         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
329         (WTR::EventSenderProxy::EventSenderProxy):
330         (WTR::senderButtonToWPEButton):
331         (WTR::EventSenderProxy::mouseDown):
332         (WTR::EventSenderProxy::mouseUp):
333         (WTR::EventSenderProxy::mouseMoveTo):
334         (WTR::EventSenderProxy::mouseScrollBy):
335         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
336         (WTR::EventSenderProxy::leapForward):
337         (WTR::wkEventModifiersToWPE):
338         (WTR::getXKBKeySymForKeyRef):
339         (WTR::EventSenderProxy::keyDown):
340         (WTR::EventSenderProxy::addTouchPoint):
341         (WTR::EventSenderProxy::updateTouchPoint):
342         (WTR::EventSenderProxy::setTouchModifier):
343         (WTR::EventSenderProxy::setTouchPointRadius):
344         (WTR::EventSenderProxy::getUpdatedTouchEvents):
345         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
346         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
347         (WTR::EventSenderProxy::touchStart):
348         (WTR::EventSenderProxy::touchMove):
349         (WTR::EventSenderProxy::touchEnd):
350         (WTR::EventSenderProxy::touchCancel):
351         (WTR::EventSenderProxy::clearTouchPoints):
352         (WTR::EventSenderProxy::releaseTouchPoint):
353         (WTR::EventSenderProxy::cancelTouchPoint):
354
355 2017-07-27  Brady Eidson  <beidson@apple.com>
356
357         Part 2 of: Rename DatabaseProcess to StorageProcess.
358         https://bugs.webkit.org/show_bug.cgi?id=174880
359
360         Reviewed by Andy Estes.
361
362         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
363         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
364         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
365         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
366         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
367         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
368         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
369         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
370
371 2017-07-26  Mark Lam  <mark.lam@apple.com>
372
373         Add ability to only run specific tests in run-javascriptcore-tests.
374         https://bugs.webkit.org/show_bug.cgi?id=174884
375
376         Reviewed by Saam Barati.
377
378         For example, if we only want to run testapi, we can do so as follows:
379             $ run-javascriptcore-tests --testapi
380
381         Previously, specifying --testapi effectively does nothing because we run all tests
382         by default.  Only --no-testapi had the effect of disabling the test set.  This
383         old behavior for --testapi is not very useful or meaningful.  We're now changing
384         it to mean that we will only run that test.
385
386         With this change, we can also run more than one set of tests.  For example, if we
387         only want to run testmasm and testair, we can do so as follows:
388             $ run-javascriptcore-tests --testmasm --testair
389
390         By default, if no specific test option is specified, run-javascriptcore-tests will
391         run all tests.
392
393         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
394         the mozilla tests (--mozilla-tests) even though both are run via the lower level
395         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
396         the other set will not run.  For example, the following only runs the mozilla tests:
397             $ run-javascriptcore-tests --mozilla-tests
398
399         Note also that --jit-stress-tests is not for choosing a different set of tests.
400         Instead, it is used for determining whether we run JIT'ed test configurations
401         on the jsc stress tests and mozilla tests.  As a result, specifying
402         --jit-stress-tests will not omit other tests.  For example, the following still
403         runs all tests:
404             $ run-javascriptcore-tests --jit-stress-tests
405
406         * Scripts/run-javascriptcore-tests:
407         (defaultStringForTestState):
408         (enableTestOrNot):
409         (runJSCStressTests):
410
411 2017-07-26  Mark Lam  <mark.lam@apple.com>
412
413         Make run-javascriptcore-test run testair, testb3, and testmasm.
414         https://bugs.webkit.org/show_bug.cgi?id=174837
415         <rdar://problem/33522927>
416
417         Reviewed by Saam Barati and Filip Pizlo.
418
419         1. Refactors code for running testapi so that we can use it to run other tests.
420         2. Added running of testmasm, testair, testb3.
421
422         Note: the existing testapi invocation code does not support remote invocation of
423         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
424         and testb3 also do not support remote invocation.  If we wish to add remote
425         invocation support, we should do that in a separate patch.
426
427         * Scripts/run-javascriptcore-tests:
428         (testPath):
429         (runTest):
430         (testapiPath): Deleted.
431
432 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
433
434         Remove duplicate code from Buildbot.js in dashboard
435         https://bugs.webkit.org/show_bug.cgi?id=174870
436
437         Reviewed by Daniel Bates.
438
439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
440         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
441         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
443         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
444
445 2017-07-26  Brady Eidson  <beidson@apple.com>
446
447         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
448         https://bugs.webkit.org/show_bug.cgi?id=174851
449
450         Reviewed by Chris Dumez.
451
452         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
453         (TEST):
454
455 2017-07-26  Brian Burg  <bburg@apple.com>
456
457         Remove WEB_TIMING feature flag
458         https://bugs.webkit.org/show_bug.cgi?id=174795
459
460         Reviewed by Alex Christensen.
461
462         * Scripts/webkitperl/FeatureList.pm:
463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
464
465 2017-07-26  Chris Dumez  <cdumez@apple.com>
466
467         Pressing the Escape key should not be a valid user gesture to enter fullscreen
468         https://bugs.webkit.org/show_bug.cgi?id=174864
469         <rdar://problem/33009088>
470
471         Reviewed by Geoffrey Garen.
472
473         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
474         WKTR.
475
476         * DumpRenderTree/mac/EventSendingController.mm:
477         (-[EventSendingController keyDown:withModifiers:withLocation:]):
478
479 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
480
481         Unreviewed, added Romain Bellessort to contributors.json.
482
483         * Scripts/webkitpy/common/config/contributors.json:
484
485 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
486
487         [WPE] WebGL2 support
488         https://bugs.webkit.org/show_bug.cgi?id=174249
489
490         Reviewed by Alex Christensen.
491
492         * Scripts/webkitperl/FeatureList.pm:
493         Enable WebGL2 for WPE when building through build-webkit.
494
495 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
496
497         Unreviewed. Fix GTK distcheck.
498
499         * gtk/make-dist.py:
500         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
501
502 2017-07-25  Brady Eidson  <beidson@apple.com>
503
504         ResourceLoadStatistics grandfathering happens much too often.
505         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
506
507         Reviewed by Chris Dumez.
508
509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
510         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
511         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
512         (TEST):
513
514 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
515
516         Fix autoinstaller failing on autoinstall_everything
517         https://bugs.webkit.org/show_bug.cgi?id=174830
518
519         Reviewed by Joseph Pecoraro.
520
521         * Scripts/webkitpy/thirdparty/__init__.py:
522         (AutoinstallImportHook.find_module):
523         (AutoinstallImportHook.install_chromedriver):
524         (AutoinstallImportHook.install_geckodriver):
525         (AutoinstallImportHook._install_chromedriver): Deleted.
526         (AutoinstallImportHook._install_geckodriver): Deleted.
527
528 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
529
530         Replace --runtime with something for both ios-simulator and ios-device
531         https://bugs.webkit.org/show_bug.cgi?id=173775
532         <rdar://problem/32952164>
533
534         Reviewed by Aakash Jain.
535
536         Add --version flag for both iOS simulator and iOS device.
537
538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
539         (parse_args): Add --version flag and move --no-install.
540         * Scripts/webkitpy/port/factory.py:
541         (platform_options): Move --no-intall to run_webkit_tests.py.
542         * Scripts/webkitpy/port/ios.py:
543         (IOSPort):
544         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
545         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
546         * Scripts/webkitpy/port/ios_device.py:
547         (IOSDevicePort.ios_version): Consult --version flag before checking connected
548         devices for iOS version.
549         * Scripts/webkitpy/port/ios_device_unittest.py:
550         (IOSDeviceTest.make_port): Set --version option so that we can generate test
551         expectation paths without devices connected.
552         (IOSDeviceTest.test_additional_platform_directory): Deleted.
553         (IOSDeviceTest.test_baseline_searchpath): Deleted.
554         (IOSDeviceTest.test_expectations_ordering): Deleted.
555         * Scripts/webkitpy/port/ios_simulator.py:
556         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
557         flag to specify a runtime.
558         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
559         flag and then use the default runtime.
560
561 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
564         https://bugs.webkit.org/show_bug.cgi?id=174815
565
566         Reviewed by Carlos Alberto Lopez Perez.
567
568         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
569         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
570         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
571         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
572         think), probably because of a newer CMake version.
573
574         * CMakeLists.txt:
575         * TestWebKitAPI/CMakeLists.txt:
576         * TestWebKitAPI/PlatformGTK.cmake:
577
578 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
579
580         Fix BenchmarkRunner to only import selenium when needed
581         https://bugs.webkit.org/show_bug.cgi?id=174808
582
583         Reviewed by Stephanie Lewis.
584
585         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
586         (LinuxChromeDriver.launch_driver):
587         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
588         (LinuxFirefoxDriver.launch_driver):
589         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
590         (OSXChromeDriver.launch_driver):
591         (OSXChromeCanaryDriver.launch_driver):
592         (create_chrome_options):
593         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
594         (OSXFirefoxDriver.launch_driver):
595         (OSXFirefoxNightlyDriver.launch_driver):
596         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
597         (OSXSafariDriver.launch_driver):
598         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
599         (WebDriverBenchmarkRunner._run_one_test):
600
601 2017-07-23  Darin Adler  <darin@apple.com>
602
603         More NeverDestroyed and related cleanup
604         https://bugs.webkit.org/show_bug.cgi?id=174745
605
606         Reviewed by Alex Christensen.
607
608         * DumpRenderTree/JavaScriptThreading.cpp:
609         (javaScriptThreadsMutex): Use NeverDestroyed instead of
610         DEPRECATED_DEFINE_STATIC_LOCAL.
611         (javaScriptThreads): Ditto.
612
613 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
614
615         Subclass Benchmark Runner script for WebDriver support
616         https://bugs.webkit.org/show_bug.cgi?id=174390
617
618         Reviewed by Dewei Zhu, Stephanie Lewis.
619
620         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
621
622         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
623         (BenchmarkBuilder.__init__):
624         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
625         (BenchmarkRunner.__init__):
626         (BenchmarkRunner._find_plan_file):
627         (BenchmarkRunner._run_one_test.and):
628         (BenchmarkRunner.execute):
629         (BenchmarkRunner._get_result): Deleted.
630         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
631         (parse_args):
632         (start):
633         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
634         (WebDriverBenchmarkRunner):
635         (WebDriverBenchmarkRunner._get_result):
636         (WebDriverBenchmarkRunner._run_one_test):
637         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
638         (WebServerBenchmarkRunner):
639         (WebServerBenchmarkRunner.__init__):
640         (WebServerBenchmarkRunner._get_result):
641         (WebServerBenchmarkRunner._run_one_test):
642
643 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
644
645         Add BenchmarkRunner patches with WebDriver support for each testing plan
646         https://bugs.webkit.org/show_bug.cgi?id=174443
647
648         Reviewed by Dewei Zhu, Stephanie Lewis.
649
650         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
651         (BenchmarkBuilder.__enter__):
652         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
653         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
654         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
655         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
656         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
657         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
658         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
659         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
660         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
661         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
662         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
663         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
664         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
665         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
666         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
667         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
668         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
669         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
670         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
671         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
672         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
673         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
674         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
675         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
676         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
677         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
678         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
679         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
680         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
681         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
682         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
683         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
684         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
685
686 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
687
688         Add functions to autoinstaller needed for Benchmark Runner script
689         https://bugs.webkit.org/show_bug.cgi?id=174331
690
691         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
692
693         Adds autoinstaller functions to install selenium and webdriver binaries
694         which will be used by the browser driver part of Benchmark Runner.
695
696         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
697         (BrowserDriver.restore_env):
698         (BrowserDriver):
699         (BrowserDriver.get_webdriver_binary_path):
700         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
701         (LinuxChromeDriver.launch_driver):
702         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
703         (LinuxFirefoxDriver.launch_driver):
704         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
705         (OSXChromeDriver.launch_driver):
706         (OSXChromeCanaryDriver.launch_driver):
707         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
708         (OSXFirefoxDriver.launch_driver):
709         (OSXFirefoxNightlyDriver.launch_driver):
710         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
711         * Scripts/webkitpy/benchmark_runner/utils.py:
712         (get_driver_binary_path):
713         * Scripts/webkitpy/common/system/autoinstall.py:
714         (AutoInstaller._unzip):
715         * Scripts/webkitpy/thirdparty/__init__.py:
716         (AutoinstallImportHook.find_module):
717         (AutoinstallImportHook._install_selenium):
718         (AutoinstallImportHook):
719         (AutoinstallImportHook._install_chromedriver):
720         (AutoinstallImportHook._install_geckodriver):
721         (AutoinstallImportHook.get_latest_pypi_url):
722         (AutoinstallImportHook.install_binary):
723         (autoinstall_everything):
724         (get_driver_filename):
725         (get_os_info):
726
727 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
728
729         Add WebDriver support in browser driver part of BenchmarkRunner
730         https://bugs.webkit.org/show_bug.cgi?id=174445
731
732         Reviewed by Stephanie Lewis.
733
734         Adds a launch_driver function to each BrowserDriver subclass. This
735         function sets up the arguments for the webdriver and launches the
736         webdriver specific to that browser.
737
738         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
739         (BrowserDriver.launch_webdriver):
740         (BrowserDriver):
741         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
742         (LinuxBrowserDriver.launch_webdriver):
743         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
744         (LinuxChromeDriver.launch_url):
745         (LinuxChromeDriver):
746         (LinuxChromeDriver.launch_driver):
747         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
748         (EpiphanyBrowserDriver.launch_url):
749         (EpiphanyBrowserDriver):
750         (EpiphanyBrowserDriver.launch_driver):
751         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
752         (LinuxFirefoxDriver):
753         (LinuxFirefoxDriver.launch_url):
754         (LinuxFirefoxDriver.launch_driver):
755         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
756         (GTKMiniBrowserDriver.launch_url):
757         (GTKMiniBrowserDriver):
758         (GTKMiniBrowserDriver.launch_driver):
759         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
760         (OSXBrowserDriver._launch_webdriver):
761         (OSXBrowserDriver):
762         (OSXBrowserDriver._screen_size):
763         (OSXBrowserDriver._insert_url):
764         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
765         (OSXChromeDriver):
766         (OSXChromeDriver.launch_url):
767         (OSXChromeDriver.launch_driver):
768         (OSXChromeCanaryDriver):
769         (OSXChromeCanaryDriver.launch_url):
770         (OSXChromeCanaryDriver.launch_driver):
771         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
772         (OSXFirefoxDriver):
773         (OSXFirefoxDriver.launch_url):
774         (OSXFirefoxDriver.launch_driver):
775         (OSXFirefoxNightlyDriver):
776         (OSXFirefoxNightlyDriver.launch_url):
777         (OSXFirefoxNightlyDriver.launch_driver):
778         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
779         (OSXSafariDriver.launch_driver):
780
781 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
782
783         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
784         https://bugs.webkit.org/show_bug.cgi?id=174793
785
786         Reviewed by Tim Horton.
787
788         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
789         down. Without r219765, this test will dereference null and crash.
790
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
793         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
794         (TEST):
795
796 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
797
798         [Win] Implement Authentication dialog in MiniBrowser
799         https://bugs.webkit.org/show_bug.cgi?id=174662
800
801         Reviewed by Alex Christensen.
802
803         * MiniBrowser/win/Common.cpp:
804         (CustomUserAgent):
805         (DisplayAuthDialog):
806         (AuthDialogProc):
807         * MiniBrowser/win/MiniBrowserLib.rc:
808         * MiniBrowser/win/MiniBrowserLibResource.h:
809         * MiniBrowser/win/ResourceLoadDelegate.cpp:
810         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
811
812 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
813
814         Handle case where line_numbers is None instead of an array of line numbers
815         https://bugs.webkit.org/show_bug.cgi?id=174775
816
817         Reviewed by Aakash Jain.
818
819         Added files set line_numbers to None in process_file.
820
821         * Scripts/webkitpy/style/filereader.py:
822         (TextFileReader.process_file): Handle case where line_number is set to None.
823         * Scripts/webkitpy/style/main_unittest.py:
824         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
825
826 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
827
828         [WPE] Add libepoxy to the Jhbuild moduleset
829         https://bugs.webkit.org/show_bug.cgi?id=174711
830
831         Reviewed by Carlos Alberto Lopez Perez.
832
833         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
834
835 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
836
837         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
838         https://bugs.webkit.org/show_bug.cgi?id=174780
839
840         Reviewed by Carlos Garcia Campos.
841
842         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
843         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
844         in case the eglplatform.h header doesn't provide that macro. This replicates
845         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
846
847 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
848
849         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
850         https://bugs.webkit.org/show_bug.cgi?id=174758
851
852         Reviewed by Dan Bernstein.
853
854         Migrate position-information-related unit tests from the PositionInformationTests suite to
855         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
859         (TestWebKitAPI::checkElementTypeAndBoundingRect):
860         (TestWebKitAPI::TEST):
861         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
862         * TestWebKitAPI/cocoa/TestWKWebView.h:
863         * TestWebKitAPI/cocoa/TestWKWebView.mm:
864         (-[TestWKWebView activatedElementAtPosition:]):
865
866 2017-07-22  Chris Dumez  <cdumez@apple.com>
867
868         REGRESSION(r204565): WKObject is broken
869         https://bugs.webkit.org/show_bug.cgi?id=174736
870         <rdar://problem/33246169>
871
872         Reviewed by Dan Bernstein.
873
874         Add API test that used to crash.
875
876         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
877         (TestWebKitAPI::TEST):
878
879 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
880
881         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
882         https://bugs.webkit.org/show_bug.cgi?id=174705
883
884         Reviewed by Mark Lam.
885
886         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
887         (TestWebKitAPI::testThreadGroup):
888         (TestWebKitAPI::TEST):
889
890 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
891
892         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
893         https://bugs.webkit.org/show_bug.cgi?id=174724
894
895         Reviewed by Aakash Jain.
896
897         * Scripts/webkitpy/port/ios_simulator.py:
898         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
899         simulator. Errors here should be treated the same as no simulators found.
900
901 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
902
903         [CMake] Add an option to stop build after generating project files
904         https://bugs.webkit.org/show_bug.cgi?id=174664
905
906         Reviewed by Konstantin Tokarev.
907
908         Add "--generate-project-only" to stop build after generating project files.
909
910         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
911         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
912         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
913         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
914         (isGenerateProjectOnly): ditto
915
916 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
917
918         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
919         https://bugs.webkit.org/show_bug.cgi?id=174501
920
921         Reviewed by Darin Adler.
922
923         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
924         (TestWebKitAPI::TEST):
925
926 2017-07-20  David Quesada  <david_quesada@apple.com>
927
928         Add SPI to notify WKNavigationDelegate about client redirects
929         https://bugs.webkit.org/show_bug.cgi?id=174680
930         rdar://problem/33184886
931
932         Reviewed by Brady Eidson.
933
934         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
935         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
936         (TEST):
937         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
938
939 2017-07-20  Brady Eidson  <beidson@apple.com>
940
941         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
942         https://bugs.webkit.org/show_bug.cgi?id=174685
943
944         Reviewed by Andy Estes.
945
946         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
947         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
948
949 2017-07-20  Brady Eidson  <beidson@apple.com>
950
951         Deprecate WebIconDatabase in WebKitLegacy/mac.
952         https://bugs.webkit.org/show_bug.cgi?id=174607
953
954         Reviewed by Alex Christensen.
955
956         * DumpRenderTree/mac/TestRunnerMac.mm:
957
958 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
959
960         lint-test-expectations should be run during style checking
961         https://bugs.webkit.org/show_bug.cgi?id=173559
962         <rdar://problem/32854941>
963
964         Reviewed by Aakash Jain.
965
966         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
967         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
968         prevents identifying errors on specific lines in a file.
969         * Scripts/webkitpy/style/main_unittest.py:
970         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
971         case where a linter error is in the file modified, but the line modified is not related to
972         the linter error.
973
974 2017-07-20  Brady Eidson  <beidson@apple.com>
975
976         Remove WebIconDatabase from WebKitLegacy/win.
977         https://bugs.webkit.org/show_bug.cgi?id=174608
978
979         Reviewed by Alex Christensen.
980
981         * DumpRenderTree/win/DumpRenderTree.cpp:
982         (main):
983         * DumpRenderTree/win/TestRunnerWin.cpp:
984         (TestRunner::setIconDatabaseEnabled):
985
986 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
987
988         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
989         https://bugs.webkit.org/show_bug.cgi?id=174671
990
991         Reviewed by Carlos Garcia Campos.
992
993         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
994         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
995         priority for this source in order to have it dispatched on the same
996         priority as the other WebKit-controlled GSource objects.
997
998 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
999
1000         lint-test-expectations should be run during style checking
1001         https://bugs.webkit.org/show_bug.cgi?id=173559
1002         <rdar://problem/32854941>
1003
1004         Reviewed by Daniel Bates.
1005
1006         Follow up fix addressing style and a few minor bugs.
1007
1008         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1009         (TestExpectationParser.__init__): Use lambda x: x instead of str
1010         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1011         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1012         reduce the calls of _shorten_filename, fix minor bug in appending the current
1013         expectation's line number instead of the previous ones, clarify treatment of None
1014         in file-to-line-number mapping.
1015         (TestExpectations._report_warnings): Collapse call.
1016         * Scripts/webkitpy/style/checkers/test_expectations.py:
1017         (TestExpectationsChecker.lint_test_expectations):
1018         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1019         (TextFileReader.process_file): Add comment explaining treatment of None in
1020         file-to-line-number mapping.
1021         (TextFileReader.delete_file): Collapse call.
1022
1023 2017-07-19  Chris Dumez  <cdumez@apple.com>
1024
1025         Unreviewed attempt to fix API test failure after r219663.
1026
1027         The test was hard-coding an exception string and the string has changed slightly
1028         in r219663.
1029
1030         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1031         (TEST):
1032
1033 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1034
1035         Don't write file URLs to iOS Pasteboard
1036         https://bugs.webkit.org/show_bug.cgi?id=174647
1037         <rdar://problem/33199730>
1038
1039         Reviewed by Wenson Hsieh.
1040
1041         Updating tests to reflect the lack of file URLs for images.
1042
1043         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1044         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1045         (checkEstimatedSize):
1046         (TestWebKitAPI::TEST):
1047
1048 2017-07-19  Brady Eidson  <beidson@apple.com>
1049
1050         iBooks sometimes crashes when closing a book.
1051         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1052
1053         Reviewed by Oliver Hunt.
1054
1055         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1056         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1057         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1058         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1059         (TestWebKitAPI::TEST):
1060
1061         Add a "spin the runloop X number of times" utility:
1062         * TestWebKitAPI/Utilities.h:
1063         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1064         (TestWebKitAPI::Util::spinRunLoop):
1065
1066 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1067
1068         lint-test-expectations should be run during style checking
1069         https://bugs.webkit.org/show_bug.cgi?id=173559
1070         <rdar://problem/32854941>
1071
1072         Reviewed by David Kilzer.
1073
1074         Running the test expectation linter requires reading both files and lines not in the
1075         patch because, for example, deletion of a test can cause a lint failure even though
1076         no test expectations where modified. This means that the linter will occasionally warn
1077         about lines which were not changed in a given patch but whose error is related to a
1078         change made in that patch.
1079
1080         * Scripts/webkitpy/common/system/filesystem_mock.py:
1081         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1082         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1083         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1084         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1085         content, description of the error and the name of the associated test.
1086         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1087         (TestExpectationParser.__init__): Pass shorten_filename function to
1088         TestExpectationsParser to add a deleted file to the related_files dictionary.
1089         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1090         missing path to the related_files dictionary.
1091         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1092         files and line numbers related to this test expectation line. This will allow
1093         tracking linter errors in the style checker occurring across multiple files.
1094         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1095         lines to related_files dictionary.
1096         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1097         (TestExpectations._report_warnings): Construct warning object instead of string
1098         when adding to warnings list.
1099         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1100         clean-up log.
1101         * Scripts/webkitpy/style/checker.py:
1102         (ProcessorBase.do_association_check): Add required function for processor classes.
1103         (StyleProcessor):
1104         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1105         checking for errors between associated files.
1106         * Scripts/webkitpy/style/checkers/test_expectations.py:
1107         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1108         (TestExpectationsChecker):
1109         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1110         of modified files, the current working directory and the host, determine if the linter
1111         warning is associated with the changes.
1112         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1113         style checker.
1114         * Scripts/webkitpy/style/filereader.py:
1115         (TextFileReader):
1116         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1117         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1118         (TextFileReader.process_file): Track both the number of files changed and which lines
1119         in those files were changed.
1120         (TextFileReader.do_association_check): Run the processor's association check on all
1121         modified or deleted files processed by TextFileReader.
1122         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1123         (TextFileReader.count_delete_only_file): Deleted.
1124         * Scripts/webkitpy/style/filereader_unittest.py:
1125         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1126         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1127         * Scripts/webkitpy/style/main.py:
1128         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1129         explicitly run the association check on the file reader.
1130         * Scripts/webkitpy/style/main_unittest.py:
1131         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1132         embedded in the style checker.
1133         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1134         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1135         construct the TextFileReader object with a StyleProcessor used to run style checks on
1136         specific files.
1137         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1138         testing the test expectation linter inside the style checker. This host must contain a
1139         mock file system with the basic structure of test expectations.
1140         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1141         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1142         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1143         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1144         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1145         * Scripts/webkitpy/style/patchreader.py:
1146         (PatchReader.check): Specify which file was deleted, run the association check.
1147         * Scripts/webkitpy/style/patchreader_unittest.py:
1148         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1149         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1150         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1151
1152 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1153
1154         [WTF] Implement WTF::ThreadGroup
1155         https://bugs.webkit.org/show_bug.cgi?id=174081
1156
1157         Reviewed by Mark Lam.
1158
1159         Add WTF::ThreadGroup tests.
1160
1161         * TestWebKitAPI/CMakeLists.txt:
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1164         (TestWebKitAPI::testThreadGroup):
1165         (TestWebKitAPI::TEST):
1166
1167 2017-07-18  Andy Estes  <aestes@apple.com>
1168
1169         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1170         https://bugs.webkit.org/show_bug.cgi?id=174631
1171
1172         Reviewed by Tim Horton.
1173
1174         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1175         * MiniBrowser/Configurations/Base.xcconfig:
1176         * MobileMiniBrowser/Configurations/Base.xcconfig:
1177         * TestWebKitAPI/Configurations/Base.xcconfig:
1178         * WebKitTestRunner/Configurations/Base.xcconfig:
1179
1180 2017-07-18  Andy Estes  <aestes@apple.com>
1181
1182         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1183         https://bugs.webkit.org/show_bug.cgi?id=174631
1184
1185         Reviewed by Sam Weinig.
1186
1187         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1188         * MiniBrowser/Configurations/Base.xcconfig:
1189         * MobileMiniBrowser/Configurations/Base.xcconfig:
1190         * TestWebKitAPI/Configurations/Base.xcconfig:
1191         * WebKitTestRunner/Configurations/Base.xcconfig:
1192
1193 2017-07-18  Daniel Bates  <dabates@apple.com>
1194
1195         lldb: Add type summary for StringView
1196         https://bugs.webkit.org/show_bug.cgi?id=174637
1197
1198         Reviewed by Sam Weinig.
1199
1200         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1201         StringView object will print output that has the form:
1202
1203             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1204               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1205               m_length = 2
1206               m_is8Bit = true
1207               m_underlyingString = 0x0000614000000a90
1208             }
1209
1210         * lldb/lldb_webkit.py:
1211         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1212         (WTFStringView_SummaryProvider):
1213         (WTFStringViewProvider):
1214         (WTFStringViewProvider.__init__):
1215         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1216         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1217         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1218         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1219
1220 2017-07-18  Andy Estes  <aestes@apple.com>
1221
1222         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1223         https://bugs.webkit.org/show_bug.cgi?id=174631
1224
1225         Reviewed by Dan Bernstein.
1226
1227         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1228         * MiniBrowser/Configurations/Base.xcconfig:
1229         * MobileMiniBrowser/Configurations/Base.xcconfig:
1230         * TestWebKitAPI/Configurations/Base.xcconfig:
1231         * WebKitTestRunner/Configurations/Base.xcconfig:
1232
1233 2017-07-18  Devin Rousso  <drousso@apple.com>
1234
1235         Web Inspector: Add memoryCost to Inspector Protocol objects
1236         https://bugs.webkit.org/show_bug.cgi?id=174478
1237
1238         Reviewed by Joseph Pecoraro.
1239
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1242         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1243         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1244         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1245         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1246         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1247         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1248         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1249         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1250         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1251         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1252         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1253         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1254         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1255         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1256         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1257
1258 2017-07-18  Andy Estes  <aestes@apple.com>
1259
1260         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1261         https://bugs.webkit.org/show_bug.cgi?id=174631
1262
1263         Reviewed by Darin Adler.
1264
1265         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1266         * MiniBrowser/Configurations/Base.xcconfig:
1267         * MobileMiniBrowser/Configurations/Base.xcconfig:
1268         * TestWebKitAPI/Configurations/Base.xcconfig:
1269         * WebKitTestRunner/Configurations/Base.xcconfig:
1270
1271 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1272
1273         Unreviewed, fix the iOS build.
1274
1275         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1276
1277         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1278         (TestWebKitAPI::TEST):
1279
1280 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1281
1282         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1283         https://bugs.webkit.org/show_bug.cgi?id=174585
1284         <rdar://problem/33302541>
1285
1286         Reviewed by Tim Horton.
1287
1288         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1289         being dragged when initiating a drag.
1290
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1293         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1294         (TestWebKitAPI::TEST):
1295         * TestWebKitAPI/cocoa/TestWKWebView.h:
1296
1297         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1298
1299         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1300         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1301
1302 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1303
1304         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1305         https://bugs.webkit.org/show_bug.cgi?id=174547
1306
1307         Reviewed by Alex Christensen.
1308
1309         * DumpRenderTree/PlatformWin.cmake:
1310         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1311
1312 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1313
1314         Update style checker to deal with "final"
1315         https://bugs.webkit.org/show_bug.cgi?id=174528
1316
1317         Reviewed by Alex Christensen.
1318         
1319         check-webkit-style shouldn't complain about an open brace to start a
1320         line after a function definition with "final" or "const final".
1321
1322         * Scripts/webkitpy/style/checkers/cpp.py:
1323         (check_braces):
1324         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1325         (CppStyleTest.test_brace_at_begin_of_line):
1326
1327 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1328
1329         Modernize content extension code
1330         https://bugs.webkit.org/show_bug.cgi?id=174588
1331
1332         Reviewed by Sam Weinig.
1333
1334         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1335         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1336         (TestWebKitAPI::testRequest):
1337         (TestWebKitAPI::makeBackend):
1338         (TestWebKitAPI::TEST_F):
1339
1340 2017-07-17  Brady Eidson  <beidson@apple.com>
1341
1342         WKHTTPCookieStore observing only works on the default cookie store.
1343         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1344
1345         Reviewed by Sam Weinig.
1346
1347         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1348         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1349           called for the default store, a non-persistent store, and a custom store.
1350         (TEST):
1351
1352 2017-07-16  Sam Weinig  <sam@webkit.org>
1353
1354         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1355         https://bugs.webkit.org/show_bug.cgi?id=174575
1356
1357         Reviewed by Brady Eidson.
1358
1359         * Scripts/svn-create-patch:
1360         (findModificationType):
1361         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1362         default value of "unknown".
1363
1364         (generateFileList):
1365         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1366         for untracked, which matches our old behavior.
1367
1368 2017-07-17  Charlie Turner  <cturner@igalia.com>
1369
1370         Add some missing build dependencies on Fedora
1371         https://bugs.webkit.org/show_bug.cgi?id=174578
1372
1373         Unreviewed dependency update.
1374
1375         * gtk/install-dependencies:
1376
1377 2017-07-16  Brady Eidson  <beidson@apple.com>
1378
1379         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1380         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1381
1382         Reviewed by Tim Horton.
1383
1384         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1385         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1386         (TEST):
1387
1388 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1389
1390         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1391         https://bugs.webkit.org/show_bug.cgi?id=174540
1392
1393         Reviewed by Michael Catanzaro.
1394
1395         * gtk/generate-inspector-gresource-manifest.py:
1396         (get_filenames): sort list of input files
1397
1398 2017-07-15  Brady Eidson  <beidson@apple.com>
1399
1400         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1401         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1402
1403         Reviewed by Tim Horton.
1404
1405         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1406         (TEST): Make this test more reliable by clearing everything beforehand.
1407
1408 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1409
1410         Make it possible to extend check-webkit-style with Apple-internal checkers
1411         <https://webkit.org/b/174464>
1412         <rdar://problem/25564402>
1413
1414         Reviewed by Darin Adler.
1415
1416         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1417         (_all_categories): Add categories from apple_additions() if it
1418         exists.
1419         (CheckerDispatcher._create_checker): Create python checker
1420         from apple_additions() if it exists.
1421
1422 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1423
1424         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1425         https://bugs.webkit.org/show_bug.cgi?id=174539
1426         <rdar://problem/33307395>
1427
1428         Reviewed by Darin Adler.
1429
1430         Adds a new unit test suite to cover action sheet popover presentation.
1431
1432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1433         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1434         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1435         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1436
1437         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1438
1439         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1440         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1441
1442         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1443
1444         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1445         (TestWebKitAPI::TEST):
1446
1447 2017-07-15  Sam Weinig  <sam@webkit.org>
1448
1449         [Scripts] Make svn-create-patch work better when called in sub directories
1450         https://bugs.webkit.org/show_bug.cgi?id=174551
1451
1452         Reviewed by Darin Adler.
1453
1454         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1455           by ensuring that the prefix is applied as is done in generateDiff.
1456         - Silence output of explanatory lines from svn stat (" > move to ...")
1457           that show up in STDERR when running svn-create-patch.
1458         - Add verbose logging that I found useful while debugging this issue.
1459
1460         * Scripts/svn-create-patch:
1461         (findBaseUrl):
1462         (findMimeType):
1463         (findSourceFileAndRevision):
1464         (generateDiff):
1465         (generateFileList):
1466         (manufacturePatchForAdditionWithHistory):
1467
1468 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1469
1470         Unreviewed build fix after r219537.
1471
1472         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1473
1474 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1475
1476         Add iOS 11 SPI
1477         https://bugs.webkit.org/show_bug.cgi?id=174430
1478         <rdar://problem/33269288>
1479
1480         Reviewed by Tim Horton.
1481
1482         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1483         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1484         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1485
1486 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1487
1488         Failing to install on iPad simulators
1489         https://bugs.webkit.org/show_bug.cgi?id=174532
1490         <rdar://problem/33328347>
1491
1492         Reviewed by Stephanie Lewis.
1493
1494         * Scripts/webkitpy/xcode/simulated_device.py:
1495         (SimulatedDevice.install_app): Place install command in retry try-except block.
1496
1497 2017-07-14  Jeff Miller  <jeffm@apple.com>
1498
1499         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1500         https://bugs.webkit.org/show_bug.cgi?id=174524
1501
1502         Reviewed by Sam Weinig.
1503
1504         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1505         (TEST):
1506         Renamed TestParameter to TestParameter1.
1507         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1508
1509         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1510         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1511         Observe changes for two bundle parameters.
1512
1513         (-[BundleParametersPlugIn dealloc]):
1514         Remove observers for two bundle parameters.
1515
1516 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1517
1518         Unreviewed, rolling out r219510.
1519         https://bugs.webkit.org/show_bug.cgi?id=174525
1520
1521         Need to revert length() == 0 check for null string (Requested
1522         by yusukesuzuki on #webkit).
1523
1524         Reverted changeset:
1525
1526         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1527         static string if StringImpl is static"
1528         https://bugs.webkit.org/show_bug.cgi?id=174501
1529         http://trac.webkit.org/changeset/219510
1530
1531 2017-07-14  Jer Noble  <jer.noble@apple.com>
1532
1533         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1534         https://bugs.webkit.org/show_bug.cgi?id=174514
1535
1536         Reviewed by Sam Weinig.
1537
1538         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1539         (TestWebKitAPI::TEST_F):
1540
1541 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1542
1543         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1544         https://bugs.webkit.org/show_bug.cgi?id=174501
1545
1546         Reviewed by Darin Adler.
1547
1548         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1549         (TestWebKitAPI::TEST):
1550
1551 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1552
1553         Bring mac expectations in-line with other platforms
1554         https://bugs.webkit.org/show_bug.cgi?id=174472
1555         <rdar://problem/33297388>
1556
1557         Reviewed by David Kilzer.
1558
1559         The override order for Mac test expectations does not conform to the pattern used by iOS,
1560         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1561
1562             platform/mac-wk2
1563             platform/wk2
1564             platform/mac-elcapitan
1565             platform/mac-sierra
1566             generic
1567
1568         After this change, El Capitan's baseline search path looks like this:
1569
1570             platform/mac-sierra-wk2
1571             platform/mac-sierra
1572             platform/mac-wk2
1573             platform/wk2
1574             generic
1575
1576         * Scripts/webkitpy/port/mac.py:
1577         (MacPort.__init__): If a specific version is specified in the port name, use that
1578         as the os version.
1579         (MacPort.default_baseline_search_path): Expectation search paths should work the
1580         same way they do on other ports. Port + version overrides port, port overrides generic
1581         and wk1/wk2 should override expectations for the two combined.
1582         * Scripts/webkitpy/port/mac_unittest.py:
1583         (MacTest.test_tests_for_other_platforms): Deleted.
1584         (MacTest._assert_search_path): Deleted.
1585         (MacTest.test_baseline_search_path): Deleted.
1586         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1587         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1588         (test_rebaseline_test_and_print_scm_changes): Ditto.
1589         (test_rebaseline_and_copy_test): Ditto.
1590         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1591         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1592         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1593
1594 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1595
1596         Fix style checker unit test
1597
1598         Unreviewed WebKit2 => WebKit fixup.
1599
1600         * Scripts/webkitpy/style/checker_unittest.py:
1601         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1602
1603 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1604
1605         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1606
1607         Unreviewed build fix.
1608
1609         r219492 missed one hunk from its partial revert of r219489.
1610         This patch reverts that hunk.
1611
1612         * TestWebKitAPI/CMakeLists.txt:
1613
1614 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1615
1616         Use the old WebKit/WebKit2 targets for CMake builds.
1617
1618         Unreviewed build fix.
1619
1620         We can update the target names to match the Framework names in a future patch.
1621         This is a partial revert of r219489.
1622
1623         * TestWebKitAPI/CMakeLists.txt:
1624         WebKitLegacy => WebKit
1625         WebKit => WebKit2
1626
1627 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1628
1629         Fix TestWebKit API.
1630         https://bugs.webkit.org/show_bug.cgi?id=174164
1631         rdar://problem/33137595
1632
1633         Reviewed by Dan Bernstein.
1634
1635         * TestWebKitAPI/CMakeLists.txt:
1636         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1637         * TestWebKitAPI/PlatformGTK.cmake:
1638
1639 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1640
1641         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1642         https://bugs.webkit.org/show_bug.cgi?id=174164
1643         rdar://problem/33137595
1644
1645         Reviewed by Dan Bernstein.
1646
1647         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1648         (ShouldBuildTest):
1649         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1650         * Scripts/build-webkit:
1651         * Scripts/do-file-rename:
1652         * Scripts/do-webcore-rename:
1653         * Scripts/update-webkit-localizable-strings:
1654         * Scripts/webkitpy/common/config/watchlist:
1655         * Scripts/webkitpy/style/checker.py:
1656         * Scripts/webkitpy/style/checkers/featuredefines.py:
1657         * gtk/make-dist.py:
1658         (ensure_version_if_possible):
1659         * gtk/manifest.txt.in:
1660
1661 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1662
1663         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1664         https://bugs.webkit.org/show_bug.cgi?id=174162
1665         rdar://problem/33137594
1666
1667         Reviewed by Dan Bernstein.
1668
1669         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1670
1671         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1672         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1673         * EWSTools/configure-clang-linux.sh:
1674         * Scripts/build-webkit:
1675         * Scripts/do-file-rename:
1676         * Scripts/do-webcore-rename:
1677         * Scripts/update-webkit-localizable-strings:
1678         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1679         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1680         * Scripts/webkitpy/style/checkers/featuredefines.py:
1681         * gtk/manifest.txt.in:
1682
1683 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1684
1685         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1686         https://bugs.webkit.org/show_bug.cgi?id=174438
1687         <rdar://problem/33277112>
1688
1689         Reviewed by Aakash Jain.
1690
1691         Given a patch, this will convert the changes from the path to the new directory structure.
1692
1693         * Scripts/rebase-patch-after-webkit-move: Added.
1694         (append_source): Append 'Source' to the provided path.
1695         (is_editable_line): Return true if a line the script expects to modify.
1696         (needs_rebase): Return if a line needs to be rebased based on it's content.
1697         (rebase_line): Rebase the provided line.
1698         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1699         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1700         were provided.
1701
1702 2017-07-12  Nan Wang  <n_wang@apple.com>
1703
1704         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1705         https://bugs.webkit.org/show_bug.cgi?id=174393
1706         <rdar://problem/33248006>
1707
1708         Reviewed by Chris Fleizach.
1709
1710         * DumpRenderTree/AccessibilityUIElement.cpp:
1711         (textMarkerRangeMatchesTextNearMarkersCallback):
1712         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1713         (AccessibilityUIElement::getJSClass):
1714         * DumpRenderTree/AccessibilityUIElement.h:
1715         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1716         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1717         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1718         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1719         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1720         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1721         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1722         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1723
1724 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1725
1726         Unreviewed, rolling out r219409.
1727
1728         The revision caused the Windows builds to fail.
1729
1730         Reverted changeset:
1731
1732         "AX: [iOS] Implement a way to retrieve a text marker range
1733         with desired text that is closest to a position"
1734         https://bugs.webkit.org/show_bug.cgi?id=174393
1735         http://trac.webkit.org/changeset/219409
1736
1737 2017-07-12  Nan Wang  <n_wang@apple.com>
1738
1739         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1740         https://bugs.webkit.org/show_bug.cgi?id=174393
1741         <rdar://problem/33248006>
1742
1743         Reviewed by Chris Fleizach.
1744
1745         * DumpRenderTree/AccessibilityUIElement.cpp:
1746         (textMarkerRangeMatchesTextNearMarkersCallback):
1747         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1748         (AccessibilityUIElement::getJSClass):
1749         * DumpRenderTree/AccessibilityUIElement.h:
1750         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1751         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1752         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1753         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1754         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1755         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1756         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1757         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1758
1759 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1760
1761         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1762         https://bugs.webkit.org/show_bug.cgi?id=174197
1763
1764         Reviewed by Darin Adler.
1765
1766         This bit me the first time I tried to submit a patch to WebKit, and still I have
1767         to manually edit the ChangeLog every time I use the script.
1768
1769         This generates a more convenient and standard ChangeLog entry.
1770
1771         * Scripts/prepare-ChangeLog:
1772         (generateNewChangeLogs):
1773
1774 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1775
1776         Unreviewed, rolling out r219401.
1777
1778         This revision rolled out the previous patch, but after talking
1779         with reviewer, a rebaseline is what was needed.Rolling back in
1780         before rebaseline.
1781
1782         Reverted changeset:
1783
1784         "Unreviewed, rolling out r219379."
1785         https://bugs.webkit.org/show_bug.cgi?id=174400
1786         http://trac.webkit.org/changeset/219401
1787
1788 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1789
1790         Unreviewed, rolling out r219379.
1791
1792         This revision caused a consistent failure in the test
1793         fast/dom/Window/property-access-on-cached-window-after-frame-
1794         removed.html.
1795
1796         Reverted changeset:
1797
1798         "Remove NAVIGATOR_HWCONCURRENCY"
1799         https://bugs.webkit.org/show_bug.cgi?id=174400
1800         http://trac.webkit.org/changeset/219379
1801
1802 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1803
1804         [WPE] Use libepoxy
1805         https://bugs.webkit.org/show_bug.cgi?id=172104
1806
1807         Reviewed by Michael Catanzaro.
1808
1809         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1810         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1811
1812 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1813
1814         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1815         https://bugs.webkit.org/show_bug.cgi?id=174363
1816
1817         Reviewed by Michael Catanzaro.
1818
1819         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1820         between the GTK+ and WPE port. There's no reason for the two ports to apply
1821         different patches over same versions of GStreamer releases.
1822
1823         This aligns the two ports on this specific issue. Next we'll look into
1824         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1825         to keep these patches in a single place, avoiding duplicate files.
1826
1827         * gtk/jhbuild.modules:
1828         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1829         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1830         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1831         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1832
1833 2017-07-11  Dean Jackson  <dino@apple.com>
1834
1835         Remove NAVIGATOR_HWCONCURRENCY
1836         https://bugs.webkit.org/show_bug.cgi?id=174400
1837
1838         Reviewed by Sam Weinig.
1839
1840         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1841
1842 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1843
1844         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1845         https://bugs.webkit.org/show_bug.cgi?id=174239
1846
1847         Reviewed by Brady Eidson.
1848
1849         Create windows with specific features set and make sure those are properly reflected in the
1850         WKWindowFeatures object.
1851
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1853         (resetToConsistentState):
1854         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1855         (TEST):
1856
1857 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1858
1859         Do not duplicate files when deleting directories with svn 1.9
1860         https://bugs.webkit.org/show_bug.cgi?id=174339
1861         <rdar://problem/33226781>
1862
1863         Reviewed by David Kilzer.
1864
1865         * Scripts/svn-create-patch:
1866         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1867         (generateFileList): Determine which files are deleted because they are part of a
1868         directory being deleted.
1869
1870 2017-07-11  Dean Jackson  <dino@apple.com>
1871
1872         Rolling out r219372.
1873
1874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1875
1876 2017-07-11  Dean Jackson  <dino@apple.com>
1877
1878         Remove NAVIGATOR_HWCONCURRENCY
1879         https://bugs.webkit.org/show_bug.cgi?id=174400
1880
1881         Reviewed by Sam Weinig.
1882
1883         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1884
1885 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1886
1887         Teach build workers to fetch archives from S3.
1888         https://bugs.webkit.org/show_bug.cgi?id=174384
1889
1890         Reviewed by Aakash Jain.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1893         (DownloadBuiltProduct):
1894
1895 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1896
1897         Configure buildbot to transfer all archives to S3.
1898         Previously this was Mac only, but it's time to expand!
1899         https://bugs.webkit.org/show_bug.cgi?id=174378
1900         
1901         Reviewed by Aakash Jain.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1904         (BuildFactory.__init__):
1905
1906 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1907
1908         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1909         https://bugs.webkit.org/show_bug.cgi?id=174350
1910
1911         Reviewed by Xabier Rodriguez-Calvar.
1912
1913         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1914         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1915         patches are removed. The patches for gst-plugins-good are updated, removing
1916         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1917         rtpbin elements that will help with the EMEv3 development.
1918
1919         * wpe/jhbuild.modules:
1920         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1921         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1922         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1923         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1924         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1925         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1926         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1927         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1928         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1929
1930 2017-07-10  John Wilander  <wilander@apple.com>
1931
1932         Resource Load Statistics: Prune statistics in orders of importance
1933         https://bugs.webkit.org/show_bug.cgi?id=174215
1934         <rdar://problem/33164403>
1935
1936         Reviewed by Chris Dumez.
1937
1938         Nest infrastructure. Adds these functions:
1939         1. testRunner.setStatisticsLastSeen()
1940         2. setStatisticsMaxStatisticsEntries()
1941         3. setStatisticsPruneEntriesDownTo()
1942
1943         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1945         (WTR::TestRunner::setStatisticsLastSeen):
1946         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1947         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::setStatisticsLastSeen):
1951         (WTR::TestController::setMaxStatisticsEntries):
1952         (WTR::TestController::setPruneEntriesDownTo):
1953         * WebKitTestRunner/TestController.h:
1954         * WebKitTestRunner/TestInvocation.cpp:
1955         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1956         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1957         (WTR::TestController::setStatisticsLastSeen):
1958         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1959         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1960
1961 2017-07-03  Brian Burg  <bburg@apple.com>
1962
1963         Web Replay: remove some unused code
1964         https://bugs.webkit.org/show_bug.cgi?id=173903
1965
1966         Rubber-stamped by Joseph Pecoraro.
1967
1968         * Scripts/run-input-generator-tests: Removed.
1969         * Scripts/webkitpy/replay/__init__.py: Removed.
1970         * Scripts/webkitpy/replay/main.py: Removed.
1971
1972 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1973
1974         [WPE] Fix layout test baseline and TestExpectations hierarchy
1975         https://bugs.webkit.org/show_bug.cgi?id=174092
1976
1977         Reviewed by Michael Catanzaro.
1978
1979         Like for the GTK+ port, override the default_baseline_search_path() and
1980         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1981         Both methods operate on a short list of search paths that defaults to 'wpe' and
1982         'wk2', along with any other user-specified platform directory.
1983
1984         The test_expectations_file_position() method is overridden for testing purposes,
1985         and relevant unit tests are added.
1986
1987         * Scripts/webkitpy/port/wpe.py:
1988         (WPEPort._search_paths):
1989         (WPEPort):
1990         (WPEPort.default_baseline_search_path):
1991         (WPEPort._port_specific_expectations_files):
1992         (WPEPort.test_expectations_file_position):
1993         * Scripts/webkitpy/port/wpe_unittest.py:
1994         (WPEPortTest.test_default_baseline_search_path):
1995         (WPEPortTest):
1996         (WPEPortTest.test_port_specific_expectations_files):
1997
1998 2017-07-10  Chris Dumez  <cdumez@apple.com>
1999
2000         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2001         https://bugs.webkit.org/show_bug.cgi?id=174301
2002
2003         Reviewed by Brent Fulgham.
2004
2005         Rename some of the testRunner API for clarity and to better match what it calls
2006         internally.
2007
2008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2010         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2011         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2012         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2013         * WebKitTestRunner/TestController.cpp:
2014         (WTR::TestController::statisticsUpdateCookiePartitioning):
2015         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2016         * WebKitTestRunner/TestController.h:
2017         * WebKitTestRunner/TestInvocation.cpp:
2018         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2020         (WTR::TestController::statisticsUpdateCookiePartitioning):
2021         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2022
2023 2017-07-10  Charlie Turner  <cturner@igalia.com>
2024
2025         [GStreamer] Live twitch.tv videos do not play
2026         https://bugs.webkit.org/show_bug.cgi?id=174222
2027
2028         Reviewed by Michael Catanzaro.
2029
2030         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2031         fixes videos not playing on twitch.tv.
2032
2033         * gtk/jhbuild.modules:
2034
2035 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2036
2037         Add WebGL2 configuration option to build-webkit
2038         https://bugs.webkit.org/show_bug.cgi?id=174251
2039
2040         Reviewed by Michael Catanzaro.
2041
2042         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2043         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2044         is marked as enabled for the Apple Cocoa ports.
2045
2046 2017-07-08  Chris Dumez  <cdumez@apple.com>
2047
2048         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2049         https://bugs.webkit.org/show_bug.cgi?id=174290
2050
2051         Reviewed by Brent Fulgham.
2052
2053         Rename testRunner API to match the new internal API names.
2054
2055         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2057         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2058         (WTR::TestRunner::statisticsSubmitTelemetry):
2059         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2060         * WebKitTestRunner/TestController.cpp:
2061         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2062         (WTR::TestController::statisticsSubmitTelemetry):
2063         * WebKitTestRunner/TestController.h:
2064         * WebKitTestRunner/TestInvocation.cpp:
2065         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2066         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2067         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2068         (WTR::TestController::statisticsSubmitTelemetry):
2069
2070 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2071
2072         Drop NOSNIFF compile flag
2073         https://bugs.webkit.org/show_bug.cgi?id=174289
2074
2075         Reviewed by Michael Catanzaro.
2076
2077         * Scripts/webkitperl/FeatureList.pm:
2078         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2079
2080 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2081
2082         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2083         https://bugs.webkit.org/show_bug.cgi?id=174219
2084         <rdar://problem/32083177>
2085
2086         Reviewed by Ryosuke Niwa.
2087
2088         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2089         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2090         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2091         place.
2092
2093         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2094         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2095         no action is taken when dropping.
2096
2097         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2098         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2099         (TestWebKitAPI::TEST):
2100         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2101         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2102         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2103         (-[MockDragDropSession allowsMoveOperation]):
2104         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2105         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2106         (-[DataInteractionSimulator initWithWebView:]):
2107         (-[DataInteractionSimulator runFrom:to:]):
2108         (-[DataInteractionSimulator _advanceProgress]):
2109         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2110         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2111         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2112
2113 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2114
2115         Unreviewed, rolling out r219238, r219239, and r219241.
2116         https://bugs.webkit.org/show_bug.cgi?id=174265
2117
2118         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2119         (Requested by yusukesuzuki on #webkit).
2120
2121         Reverted changesets:
2122
2123         "[WTF] Implement WTF::ThreadGroup"
2124         https://bugs.webkit.org/show_bug.cgi?id=174081
2125         http://trac.webkit.org/changeset/219238
2126
2127         "Unreviewed, build fix after r219238"
2128         https://bugs.webkit.org/show_bug.cgi?id=174081
2129         http://trac.webkit.org/changeset/219239
2130
2131         "Unreviewed, CLoop build fix after r219238"
2132         https://bugs.webkit.org/show_bug.cgi?id=174081
2133         http://trac.webkit.org/changeset/219241
2134
2135 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2136
2137         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2138         https://bugs.webkit.org/show_bug.cgi?id=174250
2139
2140         Reviewed by Carlos Alberto Lopez Perez.
2141
2142         * Scripts/webkitperl/FeatureList.pm:
2143
2144 2017-07-07  Charlie Turner  <cturner@igalia.com>
2145         [GStreamer] vid.me videos do not play
2146         https://bugs.webkit.org/show_bug.cgi?id=172240
2147
2148         Reviewed by Xabier Rodriguez-Calvar.
2149
2150         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2151         have the existing libsoup build against GNOME to avoid header drift
2152         against GStreamer's linked Soup library.
2153
2154         * gtk/jhbuild.modules:
2155
2156 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2157
2158         Write a support script to enable buildbot to upload to S3
2159         https://bugs.webkit.org/show_bug.cgi?id=174196
2160         
2161         Reviewed by Stephanie Lewis.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2164         (uploadToS3):
2165         (archiveExists):
2166
2167 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2168
2169         Enabling uploading archives to S3.
2170         https://bugs.webkit.org/show_bug.cgi?id=174198
2171         
2172         Reviewed by Stephanie Lewis.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2175         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2176         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2177         (TransferToS3): Transfer full and minified archives to S3
2178
2179 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2180
2181         [WTF] Implement WTF::ThreadGroup
2182         https://bugs.webkit.org/show_bug.cgi?id=174081
2183
2184         Reviewed by Mark Lam.
2185
2186         Add WTF::ThreadGroup tests.
2187
2188         * TestWebKitAPI/CMakeLists.txt:
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2190         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2191         (TestWebKitAPI::TEST):
2192
2193 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2194
2195         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2196         https://bugs.webkit.org/show_bug.cgi?id=174150
2197
2198         Reviewed by Mark Lam.
2199
2200         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2201         (TestWebKitAPI::TEST):
2202         * TestWebKitAPI/TestsController.cpp:
2203         (TestWebKitAPI::TestsController::TestsController):
2204
2205 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2206
2207         Enabling uploading archives to S3.
2208         https://bugs.webkit.org/show_bug.cgi?id=174198
2209         
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2213         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2214         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2215         (TransferToS3): Transfer full and minified archives to S3
2216
2217 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2218
2219         [GTK][WPE] kill-old-process should kill more webkit related process
2220         https://bugs.webkit.org/show_bug.cgi?id=174220
2221
2222         Reviewed by Michael Catanzaro.
2223
2224         Generate list of possible webkit-related process names and add
2225         them to the list of process to kill.
2226         Also update the possible system related process for GTK+/WPE.
2227
2228         * BuildSlaveSupport/kill-old-processes:
2229         (listAllWebKitPrograms):
2230         (main):
2231
2232 2017-07-06  Chris Dumez  <cdumez@apple.com>
2233
2234         FileMonitor should not be ref counted
2235         https://bugs.webkit.org/show_bug.cgi?id=174166
2236
2237         Reviewed by Brent Fulgham.
2238
2239         Update the API tests to reflect the API change.
2240
2241         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2242         (TestWebKitAPI::TEST_F):
2243
2244 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2245
2246         Unreviewed, rolling out r219194.
2247         https://bugs.webkit.org/show_bug.cgi?id=174207
2248
2249         it broke some layout tests (Requested by clopez on #webkit).
2250
2251         Reverted changeset:
2252
2253         "[GStreamer] vid.me videos do not play"
2254         https://bugs.webkit.org/show_bug.cgi?id=172240
2255         http://trac.webkit.org/changeset/219194
2256
2257 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2258
2259         Unreviewed, rolling out r219178.
2260
2261         This caused a consistent failure with the API test
2262         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2263
2264         Reverted changeset:
2265
2266         "[WTF] Clean up StringStatics.cpp by using
2267         LazyNeverDestroyed<> for Atoms"
2268         https://bugs.webkit.org/show_bug.cgi?id=174150
2269         http://trac.webkit.org/changeset/219178
2270
2271 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2272
2273         Add CWD to Perl library path (no longer the default since 5.26.0)
2274         https://bugs.webkit.org/show_bug.cgi?id=174200
2275
2276         Reviewed by Michael Catanzaro.
2277
2278         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2279         (SetupGitClone._get_username_and_email):
2280
2281 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2282
2283         Unreviewed, update my email address.
2284
2285         * Scripts/webkitpy/common/config/contributors.json:
2286
2287 2017-07-06  Charlie Turner  <cturner@igalia.com>
2288         [GStreamer] vid.me videos do not play
2289         https://bugs.webkit.org/show_bug.cgi?id=172240
2290
2291         Reviewed by Xabier Rodriguez-Calvar.
2292
2293         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2294         have the existing libsoup build against GNOME to avoid header drift
2295         against GStreamer's linked Soup library.
2296
2297         * gtk/jhbuild.modules:
2298
2299 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2300
2301         [WTF] Move SoftLinking.h into WTF
2302         https://bugs.webkit.org/show_bug.cgi?id=174000
2303
2304         Reviewed by Alex Christensen.
2305
2306         * DumpRenderTree/mac/TestRunnerMac.mm:
2307         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2308         (test_primary_header):
2309         (ErrorCollector.__init__): Deleted.
2310         (ErrorCollector.__call__): Deleted.
2311         (ErrorCollector.results): Deleted.
2312         (ErrorCollector.result_list): Deleted.
2313         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2314         (MockIo.open): Deleted.
2315         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2316         (CppFunctionsTest.test_create_acronym): Deleted.
2317         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2318         (CppFunctionsTest.test_parameter): Deleted.
2319         (CppFunctionsTest.test_single_line_view): Deleted.
2320         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2321         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2322         (CppFunctionsTest.test_parameter_list): Deleted.
2323         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2324         (CppStyleTestBase.process_file_data): Deleted.
2325         (CppStyleTestBase.perform_lint): Deleted.
2326         (CppStyleTestBase.perform_single_line_lint): Deleted.
2327         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2328         (CppStyleTestBase.perform_language_rules_check): Deleted.
2329         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2330         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2331         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2332         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2333         (CppStyleTestBase.perform_header_guard_check): Deleted.
2334         (CppStyleTestBase.assert_lint): Deleted.
2335         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2336         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2337         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2338         (CppStyleTestBase.assert_language_rules_check): Deleted.
2339         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2340         (CppStyleTestBase.assert_header_guard): Deleted.
2341         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2342         (CppStyleTestBase.assert_positions_equal): Deleted.
2343         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2344         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2345         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2346         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2347         (FunctionDetectionTest.test_ignore_macros): Deleted.
2348         (FunctionDetectionTest.test_non_functions): Deleted.
2349         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2350         (FunctionDetectionTest.test_parameter_list): Deleted.
2351         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2352         (CppStyleTest.test_asm_lines_ignored): Deleted.
2353         (CppStyleTest.test_get_line_width): Deleted.
2354         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2355         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2356         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2357         (CppStyleTest.test_position): Deleted.
2358         (CppStyleTest.test_rfind_in_lines): Deleted.
2359         (CppStyleTest.test_close_expression): Deleted.
2360         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2361         (CppStyleTest.test_cstyle_cast): Deleted.
2362         (CppStyleTest.test_runtime_casting): Deleted.
2363         (CppStyleTest.test_runtime_selfinit): Deleted.
2364         (CppStyleTest.test_runtime_rtti): Deleted.
2365         (CppStyleTest.test_static_cast_readability): Deleted.
2366         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2367         (CppStyleTest.void): Deleted.
2368         (CppStyleTest.test_deprecated_cast): Deleted.
2369         (CppStyleTest.test_mock_method): Deleted.
2370         (CppStyleTest.test_sizeof_type): Deleted.
2371         (CppStyleTest.cases): Deleted.
2372         (CppStyleTest.for): Deleted.
2373         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2374         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2375         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2376         (CppStyleTest.test_include_what_you_use): Deleted.
2377         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2378         (CppStyleTest.test_cleanse_line): Deleted.
2379         (CppStyleTest.test_multi_line_comments): Deleted.
2380         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2381         (CppStyleTest.test_multiline_strings): Deleted.
2382         (CppStyleTest.test_platformh_comments): Deleted.
2383         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2384         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2385         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2386         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2387         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2388         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2389         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2390         (CppStyleTest.test_check_posix_threading): Deleted.
2391         (CppStyleTest.test_insecure_string_operations): Deleted.
2392         (CppStyleTest.test_format_strings): Deleted.
2393         (CppStyleTest.test_insecure_temp_file): Deleted.
2394         (CppStyleTest.test_variable_length_array_detection): Deleted.
2395         (CppStyleTest.test_braces): Deleted.
2396         (CppStyleTest.test_check_check): Deleted.
2397         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2398         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2399         (CppStyleTest.test_spacing_for_fncall): Deleted.
2400         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2401         (CppStyleTest.test_spacing_before_braces): Deleted.
2402         (CppStyleTest.test_spacing_between_braces): Deleted.
2403         (CppStyleTest.test_spacing_before_brackets): Deleted.
2404         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2405         (CppStyleTest.test_objective_c_block): Deleted.
2406         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2407         (CppStyleTest.test_spacing_around_else): Deleted.
2408         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2409         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2410         (CppStyleTest.test_operator_methods): Deleted.
2411         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2412         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2413         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2414         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2415         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2416         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2417         (CppStyleTest.test_space_after_comment_marker): Deleted.
2418         (CppStyleTest.test_newline_at_eof): Deleted.
2419         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2420         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2421         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2422         (CppStyleTest.test_invalid_utf8): Deleted.
2423         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2424         (CppStyleTest.test_is_blank_line): Deleted.
2425         (CppStyleTest.test_blank_lines_check): Deleted.
2426         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2427         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2428         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2429         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2430         (CppStyleTest.test_comma): Deleted.
2431         (CppStyleTest.test_declaration): Deleted.
2432         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2433         (CppStyleTest.test_indent): Deleted.
2434         (CppStyleTest.test_indent.Foo): Deleted.
2435         (CppStyleTest.test_not_alabel): Deleted.
2436         (CppStyleTest.test_tab): Deleted.
2437         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2438         (CppStyleTest.test_build_class): Deleted.
2439         (CppStyleTest.test_build_class.definitions): Deleted.
2440         (CppStyleTest.test_build_class.Foo): Deleted.
2441         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2442         (CppStyleTest.test_build_end_comment): Deleted.
2443         (CppStyleTest.test_build_forward_decl): Deleted.
2444         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2445         (CppStyleTest.test_build_header_guard): Deleted.
2446         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2447         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2448         (CppStyleTest.test_build_printf_format): Deleted.
2449         (CppStyleTest.test_runtime_printf_format): Deleted.
2450         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2451         (CppStyleTest.test_build_storage_class): Deleted.
2452         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2453         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2454         (CppStyleTest.test_build_storage_class.after): Deleted.
2455         (CppStyleTest.test_build_storage_class.is): Deleted.
2456         (CppStyleTest.test_legal_copyright): Deleted.
2457         (CppStyleTest.test_invalid_increment): Deleted.
2458         (CppStyleTest.test_enum_bitfields): Deleted.
2459         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2460         (CleansedLinesTest.test_init_empty): Deleted.
2461         (CleansedLinesTest.test_collapse_strings): Deleted.
2462         (OrderOfIncludesTest.tearDown): Deleted.
2463         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2464         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2465         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2466         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2467         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2468         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2469         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2470         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2471         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2472         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2473         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2474         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2475         (OrderOfIncludesTest.test_primary_header): Deleted.
2476         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2477         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2478         (OrderOfIncludesTest.test_classify_include): Deleted.
2479         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2480         (CheckForFunctionLengthsTest.tearDown): Deleted.
2481         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2482         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2483         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2484         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2485         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2486         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2487         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2488         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2489         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2490         (CheckForFunctionLengthsTest.function_body): Deleted.
2491         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2492         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2493         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2494         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2495         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2496         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2497         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2498         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2499         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2500         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2501         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2502         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2503         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2504         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2505         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2506         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2507         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2508         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2509         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2510         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2511         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2512         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2513         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2514         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2515         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2516         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2517         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2518         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2519         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2520         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2521         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2522         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2523         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2524         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2525         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2526         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2527         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2528         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2529         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2530         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2531         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2532         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2533         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2534         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2535         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2536         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2537         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2538         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2539         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2540         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2541         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2542         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2543         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2544         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2545         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2546         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2547         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2548         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2549         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2550         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2551         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2552         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2553         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2554         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2555         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2556         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2557         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2558         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2559         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2560         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2561         (LeakyPatternTest.test_get_dc): Deleted.
2562         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2563         (LeakyPatternTest.test_own_get_dc): Deleted.
2564         (LeakyPatternTest.test_create_dc): Deleted.
2565         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2566         (WebKitStyleTest.test_indentation): Deleted.
2567         (WebKitStyleTest.test_indentation.Foo): Deleted.
2568         (WebKitStyleTest.test_indentation.Document): Deleted.
2569         (WebKitStyleTest.test_spacing): Deleted.
2570         (WebKitStyleTest.test_line_breaking): Deleted.
2571         (WebKitStyleTest.test_braces): Deleted.
2572         (WebKitStyleTest.test_braces.MyClass): Deleted.
2573         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2574         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2575         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2576         (WebKitStyleTest.test_null_false_zero): Deleted.
2577         (WebKitStyleTest.test_directive_indentation): Deleted.
2578         (WebKitStyleTest.test_using_std): Deleted.
2579         (WebKitStyleTest.test_using_namespace): Deleted.
2580         (WebKitStyleTest.test_max_macro): Deleted.
2581         (WebKitStyleTest.test_min_macro): Deleted.
2582         (WebKitStyleTest.test_wtf_move): Deleted.
2583         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2584         (WebKitStyleTest.test_names): Deleted.
2585         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2586         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2587         (WebKitStyleTest.test_names.declarations): Deleted.
2588         (WebKitStyleTest.test_names.struct): Deleted.
2589         (WebKitStyleTest.test_names.VectorType): Deleted.
2590         (WebKitStyleTest.test_parameter_names): Deleted.
2591         (WebKitStyleTest.test_comments): Deleted.
2592         (WebKitStyleTest.test_webkit_export_check): Deleted.
2593         (WebKitStyleTest.test_member_initialization_list): Deleted.
2594         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2595         (WebKitStyleTest.test_other): Deleted.
2596         (CppCheckerTest.mock_handle_style_error): Deleted.
2597         (CppCheckerTest._checker): Deleted.
2598         (CppCheckerTest.test_init): Deleted.
2599         (CppCheckerTest.test_eq): Deleted.
2600         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2601         (CppCheckerTest.test_ne): Deleted.
2602         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2603         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2604         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2605         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2606         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2607         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2608
2609 2017-07-05  Saam Barati  <sbarati@apple.com>
2610
2611         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2612         https://bugs.webkit.org/show_bug.cgi?id=174188
2613         <rdar://problem/30581423>
2614
2615         Reviewed by Mark Lam.
2616
2617         * Scripts/run-jsc-stress-tests:
2618
2619 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2620
2621         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2622         https://bugs.webkit.org/show_bug.cgi?id=174150
2623
2624         Reviewed by Mark Lam.
2625
2626         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2627         (TestWebKitAPI::TEST):
2628
2629 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2630
2631         Remove copy of ICU headers from WebKit
2632         https://bugs.webkit.org/show_bug.cgi?id=116407
2633
2634         Reviewed by Alex Christensen.
2635
2636         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2637         * TestWebKitAPI/Configurations/Base.xcconfig:
2638         * WebKitTestRunner/Configurations/Base.xcconfig:
2639
2640 2017-07-05  Chris Dumez  <cdumez@apple.com>
2641
2642         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2643         https://bugs.webkit.org/show_bug.cgi?id=174163
2644         <rdar://problem/33067518>
2645
2646         Reviewed by Alex Christensen.
2647
2648         Add API test coverage.
2649
2650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2651         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2652         (TEST):
2653
2654 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2655
2656         When dragging a selection, clearing the selection in dragstart should not crash the web process
2657         https://bugs.webkit.org/show_bug.cgi?id=174142
2658         <rdar://problem/33067501>
2659
2660         Reviewed by Tim Horton.
2661
2662         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2663         drag is starting up.
2664
2665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2666         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2667         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2668         (TestWebKitAPI::TEST):
2669
2670 2017-07-05  Daniel Bates  <dabates@apple.com>
2671
2672         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2673         API navigation
2674         https://bugs.webkit.org/show_bug.cgi?id=174170
2675         <rdar://problem/33140328>
2676
2677         Reviewed by Brady Eidson.
2678
2679         Update tests as needed for the behavior change.
2680
2681         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2682         (TEST):
2683
2684 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2685
2686         Add WebKitPrivateFrameworkStubs for iOS 11
2687         https://bugs.webkit.org/show_bug.cgi?id=173988
2688
2689         Reviewed by David Kilzer.
2690
2691         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2692         should use the same directory for private framework stubs.
2693         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2694
2695 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2696
2697         [MediaStream] Protect request and web view during gUM client callback
2698         https://bugs.webkit.org/show_bug.cgi?id=174096
2699         <rdar://problem/32833102>
2700
2701         Reviewed by Youenn Fablet.
2702
2703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2704         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2705
2706 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2707
2708         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2709
2710         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2711
2712 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2713
2714         Unreviewed, rolling out r219128.
2715
2716         Spoke with engineer who originally submitted, Patch for APi
2717         test to follow.
2718
2719         Reverted changeset:
2720
2721         "Unreviewed, rolling out r219070."
2722         https://bugs.webkit.org/show_bug.cgi?id=174082
2723         http://trac.webkit.org/changeset/219128
2724
2725 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2726
2727         Unreviewed, rolling out r219070.
2728
2729         This revision caused consistent failures of the API test
2730         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2731
2732         Reverted changeset:
2733
2734         "Pasting single words copied to UIPasteboard inserts URLs in
2735         editable areas"
2736         https://bugs.webkit.org/show_bug.cgi?id=174082
2737         http://trac.webkit.org/changeset/219070
2738
2739 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2740
2741         Remove unused EFL logo from bot watcher dashboard
2742         https://bugs.webkit.org/show_bug.cgi?id=174136
2743
2744         Reviewed by Alexey Proskuryakov.
2745
2746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2748
2749 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2750
2751         [GTK] Add more GTK bots to dashboard
2752         https://bugs.webkit.org/show_bug.cgi?id=174129
2753
2754         Reviewed by Carlos Alberto Lopez Perez.
2755
2756         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2757         them.
2758
2759         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2760         less-essential GTK bots.
2761
2762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2764         (WebKitBuildbot):
2765
2766 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2767
2768         [WPE] Add WPE to bot watcher dashboard
2769         https://bugs.webkit.org/show_bug.cgi?id=174119
2770
2771         Reviewed by Alexey Proskuryakov.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2776         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2778         (WebKitBuildbot):
2779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2780         (table.queue-grid tr.platform.linux-wpe img.logo):
2781
2782 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2783
2784         https://bugs.webkit.org/show_bug.cgi?id=174105
2785         
2786         Reviewed by Stephanie Lewis.
2787
2788         * BuildSlaveSupport/built-product-archive:
2789         (main): Add a -minify parser option
2790         (createZip): Pass along the optional Minify argument if requested
2791         (minifySource): This will trim down archives, logic limited to Mac platform.
2792
2793 2017-07-03  Matt Rajca  <mrajca@apple.com>
2794
2795         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2796         https://bugs.webkit.org/show_bug.cgi?id=174103
2797
2798         Reviewed by Alex Christensen.
2799
2800         Added an API test.
2801
2802         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2803         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2804         (TEST): Added test.
2805         * TestWebKitAPI/cocoa/TestWKWebView.h:
2806         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2807         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2808
2809 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2810
2811         Unreviewed, rolling out r219103.
2812
2813         Caused multiple build failures.
2814
2815         Reverted changeset:
2816
2817         "Remove copy of ICU headers from WebKit"
2818         https://bugs.webkit.org/show_bug.cgi?id=116407
2819         http://trac.webkit.org/changeset/219103
2820
2821 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2822
2823         Remove copy of ICU headers from WebKit
2824         https://bugs.webkit.org/show_bug.cgi?id=116407
2825
2826         Reviewed by Alex Christensen.
2827
2828         Use WTF's copy of ICU headers.
2829
2830         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2831         * TestWebKitAPI/Configurations/Base.xcconfig:
2832         * WebKitTestRunner/Configurations/Base.xcconfig:
2833
2834 2017-07-03  Brady Eidson  <beidson@apple.com>
2835
2836         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2837         https://bugs.webkit.org/show_bug.cgi?id=174073
2838
2839         Reviewed by Andy Estes.
2840
2841         * DumpRenderTree/mac/TestRunnerMac.mm:
2842         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2843
2844         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2845         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2846
2847 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2848
2849         Unreviewed, rolling out r219083.
2850
2851         The revision caused an API failure on all testing platforms.
2852
2853         Reverted changeset:
2854
2855         "[MediaStream] Protect request and web view during gUM client
2856         callback"
2857         https://bugs.webkit.org/show_bug.cgi?id=174096
2858         http://trac.webkit.org/changeset/219083
2859
2860 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2861
2862         webkitpy: Properly number duplicated crashlogs
2863         https://bugs.webkit.org/show_bug.cgi?id=172002
2864
2865         Reviewed by Aakash Jain.
2866
2867         * Scripts/webkitpy/common/system/crashlogs.py:
2868         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2869         an increasing integer.
2870         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2871         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2872         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2873         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2874
2875 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         WebContent processes crash when the network process crashes with pending connection requests
2878         https://bugs.webkit.org/show_bug.cgi?id=174065
2879         <rdar://problem/30359835>
2880
2881         Reviewed by Tim Horton.
2882
2883         Add a API to ensure UI process tries to relaunch a new network process when the network process
2884         crashes with pending network connection requests.
2885
2886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2887         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2888         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2889         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2890         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2891
2892 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2893
2894         [MediaStream] Protect request and web view during gUM client callback
2895         https://bugs.webkit.org/show_bug.cgi?id=174096
2896         <rdar://problem/32833102>
2897
2898         Reviewed by Youenn Fablet.
2899
2900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2901         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2902
2903 2017-07-03  Andy Estes  <aestes@apple.com>
2904
2905         [Xcode] Add an experimental setting to build with ccache
2906         https://bugs.webkit.org/show_bug.cgi?id=173875
2907
2908         Reviewed by Tim Horton.
2909
2910         On systems that already have ccache(1) installed, this patch adds experimental support for
2911         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2912
2913         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2914         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2915         find the toolchain from which to run clang, and then invokes ccache with the required
2916         arguments.
2917
2918         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2919         precompiled headers to work properly [1].
2920
2921         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2922         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2923         during linking.
2924         
2925         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2926
2927         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2928         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2929         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2930         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2931         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2932         * ccache/README.md: Added.
2933         * ccache/ccache-clang: Added.
2934         * ccache/ccache-clang++: Added.
2935         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2936
2937 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2938
2939         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2940         https://bugs.webkit.org/show_bug.cgi?id=174051
2941
2942         Reviewed by Tim Horton.
2943
2944         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2945         (TestWebKitAPI::TEST_F):
2946
2947 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2948
2949         Unreviewed, rolling out r219024.
2950
2951         This patch cause 3 didferent test to fail.
2952
2953         Reverted changeset:
2954
2955         "REGRESSION(r215096) Queries of URLs with non-special schemes
2956         should not percent-encode single quotes"
2957         https://bugs.webkit.org/show_bug.cgi?id=174051
2958         http://trac.webkit.org/changeset/219024
2959
2960 2017-07-03  Chris Dumez  <cdumez@apple.com>
2961
2962         Drop ResourceLoadStatisticsStore's statisticsLock
2963         https://bugs.webkit.org/show_bug.cgi?id=174080
2964
2965         Reviewed by Brent Fulgham.
2966
2967         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2968
2969         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2970         (WTR::TestController::isStatisticsPrevalentResource):
2971         (WTR::TestController::isStatisticsHasHadUserInteraction):
2972         (WTR::TestController::isStatisticsGrandfathered):
2973
2974 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2975
2976         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2977         https://bugs.webkit.org/show_bug.cgi?id=174082
2978         <rdar://problem/33046992>
2979
2980         Reviewed by Tim Horton.
2981
2982         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2983
2984         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2985         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2986         (TestWebKitAPI::TEST):
2987
2988 2017-07-02  Brady Eidson  <beidson@apple.com>
2989
2990         Add API test for all parts of WebKit1 API related to favicons.
2991         https://bugs.webkit.org/show_bug.cgi?id=174069
2992
2993         Reviewed by Andy Estes.
2994
2995         These two API tests cover all WebKit1 API related to icons.
2996         
2997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2998         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2999         (mainResourceData):
3000         (defaultFaviconData):
3001         (customFaviconData):
3002         (imageFromData):
3003         (+[IconLoadingProtocol canInitWithRequest:]):
3004         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3005         (-[IconLoadingProtocol startLoading]):
3006         (-[IconLoadingProtocol stopLoading]):
3007         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3008         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3009         (TestWebKitAPI::TEST):
3010
3011 2017-07-01  Dan Bernstein  <mitz@apple.com>
3012
3013         [iOS] Remove code only needed when building for iOS 9.x
3014         https://bugs.webkit.org/show_bug.cgi?id=174068
3015
3016         Reviewed by Tim Horton.
3017
3018         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3020         (WTR::initializeWebViewConfiguration):
3021         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3022         (-[HIDEventGenerator _createIOHIDEventType:]):
3023
3024 2017-07-01  Brady Eidson  <beidson@apple.com>
3025
3026         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3027         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3028
3029         Reviewed by Alex Christensen.
3030
3031         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3032
3033 2017-07-01  Dan Bernstein  <mitz@apple.com>
3034
3035         [macOS] Remove code only needed when building for OS X Yosemite
3036         https://bugs.webkit.org/show_bug.cgi?id=174067
3037
3038         Reviewed by Tim Horton.
3039
3040         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3041         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3042         * DumpRenderTree/mac/DumpRenderTree.mm:
3043         (setDefaultsToConsistentValuesForTesting):
3044         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3045         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3046         * MiniBrowser/Configurations/Base.xcconfig:
3047         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3048         * TestWebKitAPI/Configurations/Base.xcconfig:
3049         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3050         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3051         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3052         (TestWebKitAPI::TEST_F):
3053         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3054         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3055         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3056         (TestWebKitAPI::TEST_F):
3057         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3058         (TestWebKitAPI::TEST):
3059         * WebKitTestRunner/Configurations/Base.xcconfig:
3060         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3061         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3062         (WTR::InjectedBundle::platformInitialize):
3063         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3064         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3065
3066 2017-07-01  Chris Dumez  <cdumez@apple.com>
3067
3068         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3069         https://bugs.webkit.org/show_bug.cgi?id=174060
3070
3071         Reviewed by Brent Fulgham.
3072
3073         Port WebKitTestRunner over to the new Cocoa SPI.
3074
3075         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3076         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3077         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3078         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3079         no-ops since this code runs in the WebContent process, not the
3080         UIProcess.
3081
3082         * WebKitTestRunner/TestController.cpp:
3083         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3084
3085 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3086
3087         Unreviewed mac build fix.
3088
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3090         (TestWebKitAPI::TEST):
3091
3092 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3093
3094         Add API to get WKActivatedElementInfo
3095         https://bugs.webkit.org/show_bug.cgi?id=174001
3096         <rdar://problem/29165518>
3097         
3098         Tests for now SPI to get activatedElementInfo.
3099
3100         Reviewed by Tim Horton.
3101
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3104         (TestWebKitAPI::TEST):
3105
3106 2017-06-30  Chris Dumez  <cdumez@apple.com>
3107
3108         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3109         https://bugs.webkit.org/show_bug.cgi?id=174038
3110
3111         Reviewed by Brent Fulgham.
3112
3113         Fix typo in API name.
3114
3115         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3117         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3119         * WebKitTestRunner/TestController.cpp:
3120         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3121         * WebKitTestRunner/TestController.h:
3122         * WebKitTestRunner/TestInvocation.cpp:
3123         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3124
3125 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3126
3127         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3128         https://bugs.webkit.org/show_bug.cgi?id=174051
3129         <rdar://problem/33002846>
3130
3131         Reviewed by Tim Horton.
3132
3133         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3134         (TestWebKitAPI::TEST_F):
3135
3136 2017-06-30  Daniel Bates  <dabates@apple.com>
3137
3138         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3139         https://bugs.webkit.org/show_bug.cgi?id=165160
3140         <rdar://problem/29451999>
3141
3142         Reviewed by Brady Eidson.
3143
3144         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3145         for navigations and window creation.
3146
3147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3148         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3149         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3150         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3151         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3152         (TEST):
3153
3154 2017-06-29  Jer Noble  <jer.noble@apple.com>
3155
3156         Make Legacy EME API controlled by RuntimeEnabled setting.
3157         https://bugs.webkit.org/show_bug.cgi?id=173994
3158
3159         Reviewed by Sam Weinig.
3160
3161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3162
3163 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3164
3165         Follow-up fix for r218996
3166
3167         Unreviewed infrastructure fix.
3168
3169         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3170
3171         * Scripts/webkitpy/port/ios_simulator.py:
3172         (IOSSimulatorPort): Memoize ios_version().
3173
3174 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3177         https://bugs.webkit.org/show_bug.cgi?id=174017
3178         <rdar://problem/32959782>
3179
3180         Reviewed by Simon Fraser.
3181
3182         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3183         changes, the caret would appear outside of the iframe.
3184
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3187         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3188         (checkDragCaretRectIsContainedInRect):
3189         (TestWebKitAPI::TEST):
3190         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3191         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3192         (-[DataInteractionSimulator _resetSimulatedState]):
3193         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3194         (-[DataInteractionSimulator _advanceProgress]):
3195         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3196
3197 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3198
3199         Add support for different versions of iOS when loading test expectations
3200         https://bugs.webkit.org/show_bug.cgi?id=173774
3201         <rdar://problem/32951132>
3202
3203         Rubber-stamped by Aakash Jain.
3204
3205         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3206
3207         * Scripts/webkitpy/port/ios.py:
3208         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3209         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3210         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3211         * Scripts/webkitpy/port/ios_device.py:
3212         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3213         * Scripts/webkitpy/port/ios_device_unittest.py:
3214         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3215         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3216         (IOSDeviceTest.test_expectations_ordering): Ditto.
3217         * Scripts/webkitpy/port/ios_simulator.py:
3218         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3219         ask the platform.
3220
3221 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3222
3223         Fontconfig build breaks with glibc 2.15+
3224         https://bugs.webkit.org/show_bug.cgi?id=174019
3225
3226         Reviewed by Carlos Alberto Lopez Perez.
3227
3228         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3229
3230         * wpe/jhbuild.modules:
3231         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3232
3233 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3234
3235         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3236         https://bugs.webkit.org/show_bug.cgi?id=174010
3237         <rdar://problem/32597802>
3238
3239         Reviewed by Tim Horton.
3240
3241         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3242         snapshot fails for any reason.
3243
3244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3245         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3246         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3247         (TestWebKitAPI::TEST):
3248
3249 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
3250
3251         AX: Cannot call setValue() on contenteditable or ARIA text controls
3252         https://bugs.webkit.org/show_bug.cgi?id=173520
3253
3254         Reviewed by Ryosuke Niwa.
3255
3256         Add setValue() method to WKTR (already existed in DRT).
3257
3258         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3259         (WTR::AccessibilityUIElement::setValue):
3260         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3261         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3262         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3263         (WTR::AccessibilityUIElement::setValue):
3264
3265 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3266
3267         getBoundingClientRect returns wrong value for combination of page zoom and scroll
3268         https://bugs.webkit.org/show_bug.cgi?id=173841
3269         rdar://problem/32983841
3270
3271         Reviewed by Dean Jackson.
3272
3273         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
3274         always did text zooming.
3275
3276         * MiniBrowser/mac/WK1BrowserWindowController.m:
3277         (-[WK1BrowserWindowController zoomIn:]):
3278         (-[WK1BrowserWindowController zoomOut:]):
3279         (-[WK1BrowserWindowController canResetZoom]):
3280         (-[WK1BrowserWindowController resetZoom:]):
3281
3282 2017-06-29  John Wilander  <wilander@apple.com>
3283
3284         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
3285         https://bugs.webkit.org/show_bug.cgi?id=173940
3286         <rdar://problem/33018125>
3287
3288         Reviewed by Brent Fulgham.
3289
3290         This change allows the TestController to turn off
3291         regular resource load statistics telemetry submission
3292         and to manually control when telemetry is calculated
3293         and submitted.
3294
3295         * WebKitTestRunner/TestController.cpp:
3296         (WTR::TestController::initialize):
3297             Turns off automatic resource load statistics telemetry submission.
3298
3299 2017-06-29  Commit Queue  <commit-queue@webkit.org>
3300
3301         Unreviewed, rolling out r218512.
3302         https://bugs.webkit.org/show_bug.cgi?id=173981
3303
3304         "It changes the behavior of the JS API's JSEvaluateScript
3305         which breaks TurboTax" (Requested by saamyjoon on #webkit).
3306
3307         Reverted changeset:
3308
3309         "test262: Completion values for control flow do not match the
3310         spec"
3311         https://bugs.webkit.org/show_bug.cgi?id=171265
3312         http://trac.webkit.org/changeset/218512
3313
3314 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
3315
3316         Add WebKitSystemInterface for iOS 11
3317         https://bugs.webkit.org/show_bug.cgi?id=173936
3318
3319         Reviewed by Lucas Forschler.
3320
3321         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
3322
3323 2017-06-28  Keith Miller  <keith_miller@apple.com>
3324
3325         VMTraps has some races
3326         https://bugs.webkit.org/show_bug.cgi?id=173941
3327
3328         Reviewed by Michael Saboff.
3329
3330         Add new testing mode for testing the Watchdog with our stress
3331         tests.
3332
3333         * Scripts/run-jsc-stress-tests:
3334
3335 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3336
3337         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
3338         https://bugs.webkit.org/show_bug.cgi?id=173877
3339
3340         Reviewed by Brady Eidson.
3341
3342         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
3343         the next tests.
3344
3345         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3346         (testGetFavicon):
3347
3348 2017-06-28  Tim Horton  <timothy_horton@apple.com>
3349
3350         MobileSafari was constantly using 10-15% CPU viewing a PDF
3351         https://bugs.webkit.org/show_bug.cgi?id=173944
3352         <rdar://problem/33039910>
3353
3354         Reviewed by Simon Fraser.
3355
3356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3357         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3358         Add a test that we ever call the stable presentation update callback
3359         when we have a WKPDFView up, instead of infinitely looping.
3360
3361 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3362
3363         Prevent displaying URLs with small capital letters
3364         https://bugs.webkit.org/show_bug.cgi?id=173949
3365         <rdar://problem/32952058>
3366
3367         Reviewed by Brent Fulgham.
3368
3369         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3370         (TestWebKitAPI::TEST):
3371
3372 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3373
3374         Unreviewed test fix.
3375
3376         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
3377
3378         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
3379
3380 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3381
3382         Teach ResourceLoadStatistics to recognize changes in the file system
3383         https://bugs.webkit.org/show_bug.cgi?id=173800
3384         <rdar://problem/32937842>
3385
3386         Reviewed by Chris Dumez.
3387
3388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3389         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
3390         (TestWebKitAPI::FileMonitorTest::tempFilePath):
3391         (TestWebKitAPI::handleFileModification):
3392         (TestWebKitAPI::handleFileDeletion):
3393         (TestWebKitAPI::resetTestState):
3394         (TestWebKitAPI::TEST_F):
3395
3396 2017-06-28  Brady Eidson  <beidson@apple.com>
3397
3398         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
3399         https://bugs.webkit.org/show_bug.cgi?id=173874
3400
3401         Reviewed by Alex Christensen.
3402
3403         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3404
3405 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
3406
3407         Unreviewed, adding Don Olmstead to contributors.json
3408
3409         * Scripts/webkitpy/common/config/contributors.json:
3410
3411 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3412
3413         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
3414         https://bugs.webkit.org/show_bug.cgi?id=173886
3415         <rdar://problem/32543191>
3416
3417         Reviewed by Andy Estes.
3418
3419         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3420         (ParsedRange::ParsedRange):
3421         (-[TestSchemeHandler initWithVideoData:]):
3422         (-[TestSchemeHandler webView:startURLSchemeTask:]):
3423         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
3424         (TEST):
3425
3426 2017-06-27  JF Bastien  <jfbastien@apple.com>
3427
3428         WebAssembly: running out of executable memory should throw OoM
3429         https://bugs.webkit.org/show_bug.cgi?id=171537
3430         <rdar://problem/32963338>
3431
3432         Reviewed by Saam Barati.
3433
3434         * Scripts/run-jsc-stress-tests: add a configuration which runs the
3435         tests under limited executable memory and avoids non-WebAssembly
3436         code generation so that we more reliably run out of executable
3437         memory in WebAssembly.
3438
3439 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3440
3441         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3442         https://bugs.webkit.org/show_bug.cgi?id=173854
3443         <rdar://problem/32236827>
3444
3445         Reviewed by Ryosuke Niwa and Tim Horton.
3446
3447         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
3448
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3450         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
3451         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3452         (TestWebKitAPI::TEST):
3453
3454 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
3455
3456         [PAL] Add symbol export macros for PAL
3457         https://bugs.webkit.org/show_bug.cgi?id=171519
3458
3459         Reviewed by Konstantin Tokarev.
3460
3461         * DumpRenderTree/config.h:
3462         * TestWebKitAPI/CMakeLists.txt:
3463         * TestWebKitAPI/config.h:
3464         * WebKitTestRunner/config.h:
3465
3466 2017-06-27  John Wilander  <wilander@apple.com>
3467
3468         Resource Load Statistics: Add telemetry
3469         https://bugs.webkit.org/show_bug.cgi?id=173499
3470         <rdar://problem/32826094>
3471
3472         Reviewed by Brent Fulgham.
3473
3474         Adds three new testRunner functions:
3475         - installStatisticsDidRunTelemetryCallback()
3476         - statisticsFireTelemetryHandler()
3477         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
3478
3479         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3480         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3481         (WTR::InjectedBundle::didReceiveMessageToPage):
3482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3483         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
3484         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
3485         (WTR::TestRunner::statisticsFireTelemetryHandler):
3486         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3488         * WebKitTestRunner/TestController.cpp:
3489         (WTR::TestController::resetStateToConsistentValues):
3490         (WTR::TestController::statisticsFireTelemetryHandler):
3491         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3492         * WebKitTestRunner/TestController.h:
3493         * WebKitTestRunner/TestInvocation.cpp:
3494         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3495
3496 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
3497
3498         Add missing includes to fix compilation error on FreeBSD
3499         https://bugs.webkit.org/show_bug.cgi?id=172919
3500
3501         Reviewed by Mark Lam.
3502
3503         * ImageDiff/cairo/PlatformImageCairo.cpp:
3504
3505 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3506
3507         Unreviewed, rolling out r218783.
3508
3509         Causing accessibility/mac/setting-attributes-is-
3510         asynchronous.html to crash consistently on mac-wk2 Debug
3511
3512         Reverted changeset:
3513
3514         "AX: Cannot call setValue() on contenteditable or ARIA text
3515         controls"
3516         https://bugs.webkit.org/show_bug.cgi?id=173520
3517         http://trac.webkit.org/changeset/218783
3518
3519 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3520
3521         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3522         https://bugs.webkit.org/show_bug.cgi?id=173825
3523
3524         Reviewed by Saam Barati.
3525
3526         * DumpRenderTree/JavaScriptThreading.cpp:
3527         (runJavaScriptThread):
3528         (startJavaScriptThreads):
3529         * DumpRenderTree/mac/DumpRenderTree.mm:
3530         (runThread):
3531         (runPthread):
3532         (testThreadIdentifierMap):
3533
3534 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3535
3536         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3537         <https://webkit.org/b/173837>
3538
3539         Reviewed by Geoffrey Garen.
3540
3541         The clang static analyzer can't reason about objects that are
3542         assigned to a delegate as +1 retained, and then released
3543         later in a different method when the delegate is cleared.
3544
3545         Instead, use a common idiom where the object setting the
3546         delegate retains it as an instance variable on initialization.
3547         Then the same object clears the delegate and releases its
3548         instance variable during teardown.
3549
3550         Also add EXPECT_TRUE() tests to make sure the delegate objects
3551         match before teardown.
3552
3553         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3554         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3555         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3556         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3557         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3558         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3559
3560 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3561
3562         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3563         <https://webkit.org/b/173836>
3564
3565         Reviewed by Brady Eidson.
3566
3567         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3568         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3569         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3570         objects in this test.
3571
3572 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3573
3574         [ATK] Add support for aria-details and aria-errormessage
3575         https://bugs.webkit.org/show_bug.cgi?id=172588
3576
3577         Reviewed by Chris Fleizach.
3578
3579         Add additional methods to test ARIA properties which are exposed via
3580         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3581         to versions which support the details and error-message relation types.
3582
3583         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3584         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3585         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3586         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3587         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3588         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3589         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3590         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3591         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3592         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3593         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3594         * gtk/jhbuild.modules:
3595