598b7e72078d9dad455a9cc2d6c486e27ef28825
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2
3         Allow clients to override viewport size for CSS viewport units.
4         https://bugs.webkit.org/show_bug.cgi?id=172838
5         <rdar://problem/32523441>
6
7         Reviewed by Tim Horton.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
11         (TEST):
12
13 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
14
15         Get <chrono> out of StdLibExtras.h
16         https://bugs.webkit.org/show_bug.cgi?id=172744
17
18         Reviewed by Zalan Bujtas.
19
20         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
21
22 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
23
24         [WPE] Enable SUBTLE_CRYPTO
25         https://bugs.webkit.org/show_bug.cgi?id=172756
26
27         Reviewed by Michael Catanzaro.
28
29         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
30         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
31         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
32         exhausting entropy when running the crypto layout tests.
33
34 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
35
36         [GTK] Bump GTK+ and its dependencies in jhbuild
37         https://bugs.webkit.org/show_bug.cgi?id=171918
38
39         Reviewed by Carlos Alberto Lopez Perez.
40
41         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
42         (WTR::initializeGtkSettings):
43         * gtk/jhbuild.modules:
44         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
45         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
46
47 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
48
49         [GTK] Bump wayland and weston in jhbuild
50         https://bugs.webkit.org/show_bug.cgi?id=171921
51
52         Reviewed by Carlos Alberto Lopez Perez.
53
54         * gtk/jhbuild.modules:
55         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
56
57 2017-06-01  Andy Estes  <aestes@apple.com>
58
59         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
60         https://bugs.webkit.org/show_bug.cgi?id=172828
61
62         Reviewed by Beth Dakin.
63
64         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
65
66 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
67
68         webkitpy: Remove unneeded simulator teardown
69         https://bugs.webkit.org/show_bug.cgi?id=171891
70
71         Reviewed by Aakash Jain.
72
73         * Scripts/webkitpy/port/ios_simulator.py:
74         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
75         for communication between Python and WebKitTestRunner/DumpRenderTree.
76
77 2017-06-01  Keith Miller  <keith_miller@apple.com>
78
79         Undo rollout in r217638 with bug fix
80         https://bugs.webkit.org/show_bug.cgi?id=172824
81
82         Unreviewed, reland patch with unused set_state code removed.
83
84         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
85         (runThreadMessageTest):
86         (TEST):
87
88 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
89
90         webkitpy: Do not send 0 or -1 as a pid to kill_process
91         https://bugs.webkit.org/show_bug.cgi?id=172818
92
93         Reviewed by Darin Adler.
94
95         Sending a signal to process 0 will result in all processes in the group receiving 
96         the signal. Sending a signal to process -1 will result in all non-system processes
97         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
98         should consider these cases
99
100         * Scripts/webkitpy/common/system/executive.py:
101         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
102         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
103         never be running, although os.kill may succeed.
104         * Scripts/webkitpy/port/simulator_process.py:
105         (SimulatorProcess.stop): Do not kill process if it is undefined.
106
107 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
108
109         JSC EWS bot does not run on WTF only patches
110         https://bugs.webkit.org/show_bug.cgi?id=172777
111         rdar://problem/32495975
112
113         Reviewed by Aakash Jain.
114
115         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
116         (CheckPatchRelevance): Add a missing comma.
117
118 2017-05-31  Commit Queue  <commit-queue@webkit.org>
119
120         Unreviewed, rolling out r217611 and r217631.
121         https://bugs.webkit.org/show_bug.cgi?id=172785
122
123         "caused wasm-hashset-many.html to become flaky." (Requested by
124         keith_miller on #webkit).
125
126         Reverted changesets:
127
128         "Reland r216808, underlying lldb bug has been fixed."
129         https://bugs.webkit.org/show_bug.cgi?id=172759
130         http://trac.webkit.org/changeset/217611
131
132         "Use dispatch queues for mach exceptions"
133         https://bugs.webkit.org/show_bug.cgi?id=172775
134         http://trac.webkit.org/changeset/217631
135
136 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
137
138         EWS bots should reboot themselves more frequently
139         https://bugs.webkit.org/show_bug.cgi?id=172402
140
141         Reviewed by Alexey Proskuryakov.
142
143         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
144
145         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
146
147 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
148
149         Reallocate hardware for iOS bots.
150         https://bugs.webkit.org/show_bug.cgi?id=172657
151
152         Reviewed by Alexey Proskuryakov.
153
154         * BuildSlaveSupport/build.webkit.org-config/config.json:
155
156 2017-05-31  Andy Estes  <aestes@apple.com>
157
158         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
159         https://bugs.webkit.org/show_bug.cgi?id=172366
160
161         Reviewed by Daniel Bates.
162
163         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
164
165 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
166
167         Unreviewed, add Jiewen Tan as a reviewer
168
169         * Scripts/webkitpy/common/config/contributors.json:
170
171 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
172
173         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
174         https://bugs.webkit.org/show_bug.cgi?id=172770
175
176         Reviewed by Michael Catanzaro.
177
178         * MiniBrowser/gtk/BrowserWindow.c:
179         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
180         which caused the body of the if-clause to be accidentally empty.
181
182 2017-05-31  Keith Miller  <keith_miller@apple.com>
183
184         Reland r216808, underlying lldb bug has been fixed.
185         https://bugs.webkit.org/show_bug.cgi?id=172759
186
187         Unreviewed, relanding old patch. See: rdar://problem/31183352
188
189         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
190         (runThreadMessageTest):
191         (TEST):
192
193 2017-05-31  Matt Lewis  <jlewis3@apple.com>
194
195         Unreviewed, rolling out r217603.
196
197         This patch broke the internal builds.
198
199         Reverted changeset:
200
201         "Get <chrono> out of StdLibExtras.h"
202         https://bugs.webkit.org/show_bug.cgi?id=172744
203         http://trac.webkit.org/changeset/217603
204
205 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
206
207         Make ResourceLoadStatistics testing more reliable
208         https://bugs.webkit.org/show_bug.cgi?id=172730
209         <rdar://problem/32028373>
210
211         Reviewed by Andy Estes.
212
213         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
214         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
215
216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
217         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
218
219 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
220
221         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
222         https://bugs.webkit.org/show_bug.cgi?id=172757
223
224         Reviewed by Xabier Rodriguez-Calvar.
225
226         When needed, add the jhbuild wrapper at the beginning of the array
227         that will be invoked to execute the run-jsc-stress-test or testapi
228         commands.
229
230         * Scripts/run-javascriptcore-tests:
231         (runJSCStressTests):
232         * Scripts/webkitdirs.pm:
233         (shouldUseJhbuild):
234
235 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
236
237         Get <chrono> out of StdLibExtras.h
238         https://bugs.webkit.org/show_bug.cgi?id=172744
239
240         Reviewed by Saam Barati.
241
242         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
243
244 2017-05-30  Tim Horton  <timothy_horton@apple.com>
245
246         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
247         https://bugs.webkit.org/show_bug.cgi?id=172735
248         <rdar://problem/32015977>
249
250         Reviewed by Enrica Casucci.
251
252         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
253         (WTR::UIScriptController::applyAutocorrection):
254         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
255         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
256         (WTR::UIScriptController::applyAutocorrection):
257         * TestRunnerShared/UIScriptContext/UIScriptController.h:
258         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
259         (WTR::UIScriptController::applyAutocorrection):
260         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
261         because I don't know how to tap the button in the autocorrection bar from a test.
262
263 2017-05-30  Daniel Bates  <dabates@apple.com>
264
265         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
266         https://bugs.webkit.org/show_bug.cgi?id=172671
267
268         Reviewed by Alex Christensen.
269
270         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
271         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
272
273         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
274         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
275         to trigger a navigation to test it.
276         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
277         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
278
279 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
280
281         webkitpy: Start servers before setting-up for testing
282         https://bugs.webkit.org/show_bug.cgi?id=172176
283         <rdar://problem/32225538>
284
285         Reviewed by Alexey Proskuryakov.
286
287         On-device testing requires that servers are started before ports set-up their
288         test environments.
289
290         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
291         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
292         Servers are unconditionally stopped on exit.
293         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
294         Manager now stops servers.
295         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
296         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
297         * Scripts/webkitpy/layout_tests/controllers/manager.py:
298         (Manager.__init__): Delay construction of the test runner until we can determine
299         if servers need to be started.
300         (Manager.run): Determine if servers need to be started and construct the test runner.
301         Shut servers down when the test run is finished.
302         (Manager._run_tests): Move the determination of servers to run into Manager.run.
303         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
304         (is_wpt_server_running): Server is not running if no config is found.
305         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
306         (PyWebSocket.is_running): Check if this WebSocket server is running.
307         * Scripts/webkitpy/port/base.py:
308         (Port.__init__): Define secure WebSocket server.
309         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
310
311 2017-05-30  Daniel Bates  <dabates@apple.com>
312
313         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
314         https://bugs.webkit.org/show_bug.cgi?id=172603
315         <rdar://problem/32471306>
316
317         Reviewed by Brady Eidson.
318
319         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
320         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
321         unloading is initiated for a page that registered a onbeforeunload handler.
322
323         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
324         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
325         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
326
327         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
328         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
329         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
330         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
331
332         * MiniBrowser/mac/WK2BrowserWindowController.m:
333         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
334         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
335         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
336         (sawDialog):
337         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
338         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
339         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
340
341 2017-05-30  Alex Christensen  <achristensen@webkit.org>
342
343         Update libwebrtc configuration
344         https://bugs.webkit.org/show_bug.cgi?id=172727
345
346         Reviewed by Geoffrey Garen.
347
348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
349
350 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
351
352         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
353         https://bugs.webkit.org/show_bug.cgi?id=172702
354
355         Reviewed by Alex Christensen.
356
357         EGL PlatformDisplay needs to be shut down before existing a
358         program on Windows.
359
360         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
361         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
362         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
363         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
364
365 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
366
367         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
368         https://bugs.webkit.org/show_bug.cgi?id=172709
369
370         Reviewed by Brent Fulgham.
371
372         Exit fullscreen mode after a fullscreen test.
373
374         * DumpRenderTree/win/DumpRenderTree.cpp:
375         (resetWebViewToConsistentStateBeforeTesting):
376
377 2017-05-30  Antti Koivisto  <antti@apple.com>
378
379         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
380         https://bugs.webkit.org/show_bug.cgi?id=172713
381
382         Reviewed by Zalan Bujtas.
383
384         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
385         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
386
387             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
388             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
389             because on Mac WK1 it may get invoked from middle of a layout.
390
391             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
392
393 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
394
395         Add a WPE EWS queue
396         https://bugs.webkit.org/show_bug.cgi?id=172693
397
398         Reviewed by Carlos Garcia Campos.
399
400         * QueueStatusServer/config/queues.py:
401         * QueueStatusServer/model/queues.py: Capitalize the name of the
402         port on the tooltip of the bubbles. Do the same for the GTK port.
403         (Queue.display_name):
404         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
405         for the GTK+ EWS also. Set for both ports as watcher the alias
406         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
407         * Scripts/webkitpy/common/config/ports.py:
408         (DeprecatedPort.port):
409         (WpePort):
410         (WpePort.build_webkit_command):
411         (WpePort.run_webkit_tests_command):
412         * Scripts/webkitpy/common/config/ports_unittest.py:
413         (DeprecatedPortTest):
414         (DeprecatedPortTest.test_wpe_port):
415         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
416         (test_ews_name):
417
418 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
419
420         Unreviewed. Bumping the WPEBackend-mesa dependency version.
421
422         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
423         priorities for IPC communication.
424
425 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
426
427         [JSC] Map and Set constructors should have fast path for cloning
428         https://bugs.webkit.org/show_bug.cgi?id=172413
429
430         Reviewed by Saam Barati.
431
432         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
433         (TestWebKitAPI::TEST):
434
435 2017-05-27  Zalan Bujtas  <zalan@apple.com>
436
437         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
438         https://bugs.webkit.org/show_bug.cgi?id=172676
439
440         Reviewed by Simon Fraser.
441
442         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
443         (TestWebKitAPI::TEST):
444
445 2017-05-26  Zalan Bujtas  <zalan@apple.com>
446
447         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
448         https://bugs.webkit.org/show_bug.cgi?id=172674
449
450         Reviewed by Simon Fraser.
451
452         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
453         (TestWebKitAPI::TEST):
454
455 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
456
457         Add test resources back into TestWebKitAPI Copy Resources phase
458
459         Rubber-stamped by Beth Dakin.
460
461         Add two files back into the Copy Resources phase after they were unintentionally
462         removed in r217447 and r217496.
463
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465
466 2017-05-26  Beth Dakin  <bdakin@apple.com>
467
468         Media documents inside iframes should not get controls in the TouchBar unless the 
469         video is playing
470         https://bugs.webkit.org/show_bug.cgi?id=172620
471         -and corresponding-
472         rdar://problem/32165477
473
474         Reviewed by Jon Lee.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
478         (TestWebKitAPI::TEST):
479         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
480
481 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
482
483         _WKUserStyleSheet and WKUserScript leak string data
484         https://bugs.webkit.org/show_bug.cgi?id=172583
485         <rdar://problem/32395209>
486
487         Reviewed by Sam Weinig.
488
489         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
490         We should not have been adopting an autoreleased object.
491
492 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
493
494         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
495         https://bugs.webkit.org/show_bug.cgi?id=172554
496         <rdar://problem/31247133>
497
498         Reviewed by Simon Fraser.
499
500         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
501         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
502         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
503         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
504         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
505         codepath.
506
507         * DumpRenderTree/TestOptions.h:
508         * DumpRenderTree/TestOptions.mm:
509         (TestOptions::TestOptions):
510         (TestOptions::webViewIsCompatibleWithOptions):
511         * DumpRenderTree/mac/DumpRenderTree.mm:
512         (shouldIgnoreWebCoreNodeLeaks):
513         (allowedFontFamilySet):
514         (-[DRTMockScroller rectForPart:]):
515         (-[DRTMockScroller drawKnob]):
516         (-[DRTMockScroller drawRect:]):
517         (createWebViewAndOffscreenWindow):
518         (initializeGlobalsFromCommandLineOptions):
519         (prepareConsistentTestingEnvironment):
520         (dumpRenderTree):
521         (dumpAudio):
522         (dumpHistoryItem):
523         (dumpBackForwardListForWebView):
524         (resetWebViewToConsistentStateBeforeTesting):
525         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
526         (runTest):
527
528 2017-05-25  Sam Weinig  <sam@webkit.org>
529
530         [WebIDL] Use the term 'operation' more consistently
531         https://bugs.webkit.org/show_bug.cgi?id=172601
532
533         Reviewed by Chris Dumez.
534
535         We were using the term 'operation', a WebIDL term for function-like
536         constructs, inconsistently in the code generator. Now, when we use
537         'operation' when referring to the IDL concept (usually the object the
538         parser produces) and 'function' when referring to code being generated.
539
540         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
541         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
542
543 2017-05-25  Jer Noble  <jer.noble@apple.com>
544
545         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
546
547         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
548
549 2017-05-25  Jer Noble  <jer.noble@apple.com>
550
551         System sleeps while playing to wireless target, ending stream.
552         https://bugs.webkit.org/show_bug.cgi?id=172541
553
554         Reviewed by Eric Carlson.
555
556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
557         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
558         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
559         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
560         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
561         (TestWebKitAPI::simulateKeyDown):
562         (TestWebKitAPI::hasAssertionType):
563         (TestWebKitAPI::TEST):
564
565 2017-05-25  Commit Queue  <commit-queue@webkit.org>
566
567         Unreviewed, rolling out r217423 and r217424.
568         https://bugs.webkit.org/show_bug.cgi?id=172607
569
570         These caused an api failure on all testers. (Requested by
571         mlewis13 on #webkit).
572
573         Reverted changesets:
574
575         "REGRESSION (r216977): 4 leaks introduced in new
576         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
577         https://bugs.webkit.org/show_bug.cgi?id=172558
578         http://trac.webkit.org/changeset/217423
579
580         "REGRESSION (r217423): Fix last-second typo in 'auto'"
581         http://trac.webkit.org/changeset/217424
582
583 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
584
585         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
586         https://bugs.webkit.org/show_bug.cgi?id=172355
587
588         Reviewed by Chris Fleizach.
589
590         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
591         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
592         releases which support the new platform footnote accessibility role.
593
594         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
595         * gtk/jhbuild.modules:
596
597 2017-05-25  David Kilzer  <ddkilzer@apple.com>
598
599         REGRESSION (r217423): Fix last-second typo in 'auto'
600
601         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
602         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
603
604 2017-05-24  David Kilzer  <ddkilzer@apple.com>
605
606         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
607         <https://webkit.org/b/172558>
608
609         Reviewed by Sam Weinig.
610
611         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
612         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
613
614 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
615
616         [CMake] Consolidate CMake code related to Cairo
617         https://bugs.webkit.org/show_bug.cgi?id=172568
618
619         Reviewed by Alex Christensen.
620
621         * DumpRenderTree/config.h:
622         * TestWebKitAPI/config.h:
623
624 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
625
626         Plumb additional image metadata to item providers when beginning data interaction on an image
627         https://bugs.webkit.org/show_bug.cgi?id=172536
628         <rdar://problem/32371300>
629
630         Reviewed by Beth Dakin.
631
632         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
633         source item providers.
634
635         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
636         (checkSuggestedNameAndEstimatedSize):
637         (TestWebKitAPI::TEST):
638
639 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
640
641         [Win] Create unique network storage session for each DRT.
642         https://bugs.webkit.org/show_bug.cgi?id=172540
643
644         Reviewed by Brent Fulgham.
645
646         During layout testing, each DRT instance should have its own network storage session.
647
648         * DumpRenderTree/win/DumpRenderTree.cpp:
649         (prepareConsistentTestingEnvironment):
650
651 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
652
653         Respect image UTIs when writing to item providers when beginning data interaction on an image
654         https://bugs.webkit.org/show_bug.cgi?id=172436
655         <rdar://problem/31786569>
656
657         Reviewed by Beth Dakin.
658
659         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
660         details.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
664         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
665
666         Create a new test page containing a GIF and a file input.
667
668         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
669         (checkTypeIdentifierIsRegisteredAtIndex):
670         (TestWebKitAPI::TEST):
671
672 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
673
674         [Win] Increase test timeout for slow tests.
675         https://bugs.webkit.org/show_bug.cgi?id=172449
676
677         Reviewed by Alexey Proskuryakov.
678
679         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
680         timeout member in the TestRunner class.
681
682         * DumpRenderTree/win/TestRunnerWin.cpp:
683         (TestRunner::setWaitToDump):
684
685 2017-05-15  Matt Rajca  <mrajca@apple.com>
686
687         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
688         https://bugs.webkit.org/show_bug.cgi?id=172138
689
690         Reviewed by Alex Christensen.
691
692         Added API tests.
693
694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
695         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
696         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
697         (TEST):
698         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
699
700 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
701
702         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
703         https://bugs.webkit.org/show_bug.cgi?id=172522
704         rdar://problem/31071812
705
706         Reviewed by Sam Weinig.
707
708         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
709         We set this in the .xib file now.
710
711         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
712
713 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
714
715         Snapshotting via -renderInContext: should do synchronous image decodes
716         https://bugs.webkit.org/show_bug.cgi?id=172485
717         rdar://problem/32276146
718
719         Reviewed by Tim Horton.
720
721         New API test.
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
725         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
726         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
727         (TestWebKitAPI::getPixelIndex):
728         (TestWebKitAPI::TEST):
729
730 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
731
732         Remove dead ENABLE(FONT_LOAD_EVENTS) code
733         https://bugs.webkit.org/show_bug.cgi?id=172517
734
735         Rubber-stamped by Simon Fraser.
736
737         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
738
739 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
740
741         Multiple links should be inserted separately when performing data interaction
742         https://bugs.webkit.org/show_bug.cgi?id=172489
743         <rdar://problem/31510832>
744
745         Reviewed by Dan Bernstein.
746
747         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
748
749         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
750         (TestWebKitAPI::TEST):
751
752 2017-05-23  Tim Horton  <timothy_horton@apple.com>
753
754         REGRESSION: API test WebKit2.WKObject is failing
755         https://bugs.webkit.org/show_bug.cgi?id=172497
756         <rdar://problem/31694641>
757
758         Reviewed by Geoff Garen.
759
760         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
761         (TestWebKitAPI::TEST):
762         Add a test that ensures that we pretend to at least be *some* kind of
763         NSString, which my first fix would not have passed.
764
765 2017-05-23  youenn fablet  <youenn@apple.com>
766
767         There should be an easy way to run HTTP/WPT served tests on a browser
768         https://bugs.webkit.org/show_bug.cgi?id=172068
769
770         Reviewed by Sam Weinig.
771
772         Adding a new script open-layout-test to open a layout-test in a
773         browser and making sure it is served as done through run-webkit-tests.
774         In case tests should be run using a server, detecting whether the
775         server are running. If not, calling run-webkit-httpd to run the
776         servers and open the URL in a browser.
777         Otherwise, open directly the URL.
778
779         Adding an option in run-webkit-httpd to open an URL after having
780         started the servers.
781
782         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
783         This allows running run-webkit-httpd once and not having to restart
784         servers everytime a test should be served.
785
786         Moving most of run-webkit-httpd logic in its own python file to reuse
787         it in open-layout-test script.
788
789         Adding routines to check whether HTTP and WPT servers are running.
790
791         * Scripts/open-layout-test: Added.
792         (parse_args):
793         (main):
794         * Scripts/run-webkit-httpd:
795         (main):
796         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
797         (LayoutTestFinder.find_tests):
798         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
799         (LayoutTestRunner.run_tests):
800         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
801         (parse_args):
802         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
803         (HttpServerBase._is_server_running_on_all_ports):
804         (HttpServerBase):
805         (HttpServerBase._is_running_on_port):
806         (HttpServerBase._check_that_all_ports_are_available):
807         (is_http_server_running):
808         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
809         (parse_args):
810         (main):
811         (run_server):
812         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
813         (is_wpt_server_running):
814         * Scripts/webkitpy/port/base.py:
815         (Port.to.is_http_server_running):
816         (Port.to):
817         (Port.to.is_wpt_server_running):
818         (Port.to.start_web_platform_test_server):
819         * Scripts/webkitpy/port/driver.py:
820         (DriverProxy.is_web_platform_test):
821         (DriverProxy):
822         (DriverProxy.is_webkit_specific_web_platform_test):
823
824 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
825
826         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
827         https://bugs.webkit.org/show_bug.cgi?id=171984
828
829         Reviewed by Antti Koivisto.
830
831         * DumpRenderTree/mac/DumpRenderTree.mm:
832         (enableExperimentalFeatures):
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::resetPreferencesToConsistentValues):
835
836 2017-05-20  Alex Christensen  <achristensen@webkit.org>
837
838         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
839         https://bugs.webkit.org/show_bug.cgi?id=172406
840         <rdar://32109532>
841
842         Reviewed by Brady Eidson.
843
844         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
845         (TestWebKitAPI::checkBuffer):
846         (TestWebKitAPI::TEST_F):
847
848 2017-05-22  Jason Marcell  <jmarcell@apple.com>
849
850         Do not enter Subversion-specific logic when parsing Git-based Trac data.
851         https://bugs.webkit.org/show_bug.cgi?id=172433
852         <rdar://problem/32234188>
853
854         Reviewed by Alexey Proskuryakov.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
857         (Trac.prototype._convertCommitInfoElementToObject):
858
859 2017-05-22  Tim Horton  <timothy_horton@apple.com>
860
861         ExplicitSnapshotsChangeUponNavigation API test often fails
862         https://bugs.webkit.org/show_bug.cgi?id=172475
863         <rdar://problem/31688322>
864
865         Reviewed by Simon Fraser.
866
867         * TestWebKitAPI/cocoa/TestWKWebView.mm:
868         (-[TestWKWebView _setUpTestWindow:]):
869         Make TestWKWebView's window layer-backed. This is now the default,
870         and it's also easy to accidentally write a test that depends on it
871         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
872         which becomes layer backed, just like the WKWebView, but with no
873         common layer-backed ancestor).
874
875 2017-05-22  youenn fablet  <youenn@apple.com>
876
877         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
878         https://bugs.webkit.org/show_bug.cgi?id=172426
879
880         Reviewed by Chris Dumez.
881
882         * Scripts/webkitpy/w3c/test_importer.py:
883         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
884
885 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
886
887         Unreviewed, change my status to reviewer and fill "expertise" field
888
889         * Scripts/webkitpy/common/config/contributors.json:
890
891 2017-05-22  Tomas Popela  <tpopela@redhat.com>
892
893         Remove some of the EFL port leftovers
894         https://bugs.webkit.org/show_bug.cgi?id=172440
895
896         Reviewed by Carlos Garcia Campos.
897
898         * BuildSlaveSupport/built-product-archive:
899         (archiveBuiltProduct):
900         (extractBuiltProduct):
901         * BuildSlaveSupport/test-result-archive:
902         (archiveTestResults):
903         * ImageDiff/PlatformEfl.cmake: Removed.
904         * Scripts/run-efl-tests: Removed.
905         * Scripts/webkit-build-directory:
906         * Scripts/webkitpy/common/config/contributionareas.py:
907         * Scripts/webkitpy/common/config/watchlist:
908         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
909         (parse_args):
910         (_set_up_derived_options):
911         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
912         (PerfTestsRunner.__init__):
913         * Scripts/webkitpy/style/checker.py:
914         * Scripts/webkitpy/style/checker_unittest.py:
915         (GlobalVariablesTest.test_path_rules_specifier):
916         * gtk/manifest.txt.in:
917         * jhbuild/jhbuild-wrapper:
918
919 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
920
921         Unreviewed. Do not include WPE files in GTK+ tarballs.
922
923         * gtk/manifest.txt.in:
924
925 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
926
927         [GTK] Add webkit_context_menu_item_new_from_gaction
928         https://bugs.webkit.org/show_bug.cgi?id=159631
929
930         Reviewed by Michael Catanzaro.
931
932         Update context menu tests to check the new GAction API.
933
934         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
935         (testContextMenuPopulateMenu):
936
937 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
938
939         [GTK] Remove Firefox user agent quirk for Google domains
940         https://bugs.webkit.org/show_bug.cgi?id=171941
941
942         Reviewed by Carlos Garcia Campos.
943
944         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
945         (TestWebKitAPI::TEST):
946         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
947
948 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
949
950         [GTK] gtkdoc-fixxref needs --module argument to work
951         https://bugs.webkit.org/show_bug.cgi?id=172415
952
953         Reviewed by Michael Catanzaro.
954
955         * gtk/gtkdoc.py:
956         (GTKDoc._run_gtkdoc_fixxref):
957
958 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
959
960         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
961         https://bugs.webkit.org/show_bug.cgi?id=172416
962
963         Reviewed by Daniel Bates.
964
965         * Scripts/make-new-script-test:
966
967 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
968
969         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
970         https://bugs.webkit.org/show_bug.cgi?id=172267
971
972         Reviewed by Per Arne Vollan.
973
974         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
975         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
976         should link only with WebKit.
977
978         Unfortunately, there is a layer violation at the moment.
979         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
980         in WebKit. This change contains a stub of loadResourceIntoBuffer
981         in TestWebCoreLib for the workaround.
982
983         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
984         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
985         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
986         (loadResourceIntoBuffer): Added a stub.
987
988 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
989
990         Fix dump-class-layout to handle different file architectures
991         https://bugs.webkit.org/show_bug.cgi?id=172392
992
993         Reviewed by Zalan Bujtas.
994
995         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
996         and use the first architecture reported. Also add a "--architecture" argument
997         to allow the user to specify an architecture.
998
999         * Scripts/dump-class-layout:
1000         (import_lldb):
1001         (verify_type_recursive):
1002         (get_first_file_architecture):
1003         (dump_class):
1004         (main):
1005         (find_build_directory): Deleted.
1006
1007 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1008
1009         Unreviewed infrastructure fix.
1010
1011         * Scripts/webkitpy/port/ios_simulator.py:
1012         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
1013
1014 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1015
1016         webkitpy: Use simctl boot to run multiple simulators at once
1017         https://bugs.webkit.org/show_bug.cgi?id=172374
1018
1019         Reviewed by Alexey Proskuryakov.
1020
1021         * Scripts/webkitpy/common/system/platforminfo.py:
1022         (PlatformInfo.xcode_version): Return the current version of Xcode.
1023         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1024         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
1025         * Scripts/webkitpy/port/ios_simulator.py:
1026         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
1027         run multiple Simulator.app instances.
1028         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
1029         versions of Xcode.
1030         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
1031         an older version of Xcode.
1032
1033 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1034
1035         Unreviewed, fix the build on the latest internal SDK.
1036
1037         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1038         (TestWebKitAPI::TEST):
1039
1040 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
1041
1042         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
1043         https://bugs.webkit.org/show_bug.cgi?id=172369
1044
1045         Reviewed by Mark Lam.
1046         
1047         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
1048         would be a good idea to write this down.
1049
1050         * Scripts/run-jsc-stress-tests:
1051
1052 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1053
1054         webkitpy: Layout tests which have no output will succeed
1055         https://bugs.webkit.org/show_bug.cgi?id=172322
1056         <rdar://problem/32258350>
1057
1058         Reviewed by David Kilzer.
1059
1060         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1061         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
1062         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1063         (determine_result_type): FailureNotTested means that the test could not be loaded. This
1064         is classified as a MISSING failure.
1065         (FailureNotTested): Added.
1066         (FailureNotTested.message):
1067
1068 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1069
1070         Add SixSpeed benchmark to PerformanceTests
1071         https://bugs.webkit.org/show_bug.cgi?id=172326
1072
1073         Reviewed by Sam Weinig.
1074
1075         * Scripts/run-jsc-benchmarks:
1076
1077 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         [WK1] MiniBrowser should navigate when handling a dropped URL
1080         https://bugs.webkit.org/show_bug.cgi?id=172350
1081
1082         Reviewed by Tim Horton.
1083
1084         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
1085
1086         * MiniBrowser/mac/WK1BrowserWindowController.m:
1087         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
1088
1089 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
1092         https://bugs.webkit.org/show_bug.cgi?id=172077
1093
1094         Reviewed by Chris Dumez.
1095
1096         Fixed perftest.py by updating the lines to ignore in Speedometer.
1097
1098         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
1099
1100         * Scripts/webkitpy/performance_tests/perftest.py:
1101         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
1102         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1103         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
1104         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
1105         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1106         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
1107
1108 2017-05-18  Andy Estes  <aestes@apple.com>
1109
1110         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1111         https://bugs.webkit.org/show_bug.cgi?id=172305
1112
1113         Reviewed by Anders Carlsson.
1114
1115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1116
1117 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1118
1119         Selection around attachment elements should not persist when beginning a drag
1120         https://bugs.webkit.org/show_bug.cgi?id=172319
1121         <rdar://problem/32283008>
1122
1123         Reviewed by Tim Horton.
1124
1125         Tests that temporary selection around an attachment does not persist longer than it needs to.
1126
1127         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1128         (TestWebKitAPI::TEST):
1129
1130 2017-05-18  John Wilander  <wilander@apple.com>
1131
1132         Resource Load Statistics: Grandfather domains for existing data records
1133         https://bugs.webkit.org/show_bug.cgi?id=172155
1134         <rdar://problem/24913532>
1135
1136         Reviewed by Alex Christensen.
1137
1138         Adds test infrastructure needed for the added functionality.
1139
1140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1141         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1142         (WTR::InjectedBundle::didReceiveMessageToPage):
1143         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1144         (WTR::TestRunner::setStatisticsGrandfathered):
1145         (WTR::TestRunner::isStatisticsGrandfathered):
1146         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1147         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1148         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1149         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1150         * WebKitTestRunner/TestController.cpp:
1151         (WTR::TestController::setStatisticsGrandfathered):
1152         (WTR::TestController::isStatisticsGrandfathered):
1153         (WTR::TestController::setStatisticsGrandfatheringTime):
1154         * WebKitTestRunner/TestController.h:
1155         * WebKitTestRunner/TestInvocation.cpp:
1156         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1157
1158 2017-05-18  Saam Barati  <sbarati@apple.com>
1159
1160         WebAssembly: perform stack checks
1161         https://bugs.webkit.org/show_bug.cgi?id=165546
1162         <rdar://problem/29760307>
1163
1164         Reviewed by Filip Pizlo.
1165
1166         Add some new testing modes for using and not using fast TLS wasm contexts.
1167
1168         * Scripts/run-jsc-stress-tests:
1169
1170 2017-05-18  Daniel Bates  <dabates@apple.com>
1171
1172         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
1173         window CSP when object-src 'none' is set
1174         https://bugs.webkit.org/show_bug.cgi?id=172038
1175         <rdar://problem/32258262>
1176
1177         Reviewed by Andy Estes.
1178
1179         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
1180         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
1181
1182         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1183         (NPP_New):
1184
1185 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
1186
1187         [Win] Many layout tests are failing.
1188         https://bugs.webkit.org/show_bug.cgi?id=172286
1189
1190         Reviewed by Brent Fulgham.
1191
1192         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
1193  
1194         * DumpRenderTree/win/TestRunnerWin.cpp:
1195         (TestRunner::grantWebNotificationPermission):
1196         (TestRunner::denyWebNotificationPermission):
1197         (TestRunner::removeAllWebNotificationPermissions):
1198         (TestRunner::simulateWebNotificationClick):
1199
1200 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
1201
1202         [Win] Remove usage of _snprintf
1203         https://bugs.webkit.org/show_bug.cgi?id=172251
1204
1205         Reviewed by Per Arne Vollan.
1206
1207         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1208         * MiniBrowser/win/PageLoadTestClient.cpp:
1209         (PageLoadTestClient::dumpRunStatistics):
1210
1211 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1212
1213         Unreviewed, rolling out r217014.
1214
1215         This change caused mac-wk2 LayoutTests to exit early due to
1216         crashes.
1217
1218         Reverted changeset:
1219
1220         "Resource Load Statistics: Grandfather domains for existing
1221         data records"
1222         https://bugs.webkit.org/show_bug.cgi?id=172155
1223         http://trac.webkit.org/changeset/217014
1224
1225 2017-05-17  John Wilander  <wilander@apple.com>
1226
1227         Resource Load Statistics: Grandfather domains for existing data records
1228         https://bugs.webkit.org/show_bug.cgi?id=172155
1229         <rdar://problem/24913532>
1230
1231         Reviewed by Alex Christensen.
1232
1233         Adds test infrastructure needed for the added functionality.
1234
1235         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1237         (WTR::InjectedBundle::didReceiveMessageToPage):
1238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1239         (WTR::TestRunner::setStatisticsGrandfathered):
1240         (WTR::TestRunner::isStatisticsGrandfathered):
1241         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1242         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1243         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1244         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1245         * WebKitTestRunner/TestController.cpp:
1246         (WTR::TestController::setStatisticsGrandfathered):
1247         (WTR::TestController::isStatisticsGrandfathered):
1248         (WTR::TestController::setStatisticsGrandfatheringTime):
1249         * WebKitTestRunner/TestController.h:
1250         * WebKitTestRunner/TestInvocation.cpp:
1251         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1252
1253 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1254
1255         Fix ios-simulator API test after r216977
1256         https://bugs.webkit.org/show_bug.cgi?id=171987
1257
1258         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1259         (TEST):
1260         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
1261         not as urgent as having the rest of this working. Notably the ephemeral part of the
1262         test works, so something is just wrong with the persistent part.
1263
1264 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1265
1266         Unreviewed, rolling out r216955.
1267
1268         This change caused strange behavior with web-platform-tests
1269         locally and on EWS.
1270
1271         Reverted changeset:
1272
1273         "webkitpy: Start servers before setting-up for testing"
1274         https://bugs.webkit.org/show_bug.cgi?id=172176
1275         http://trac.webkit.org/changeset/216955
1276
1277 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1278
1279         A URL type is vended for a non-URL plain text string when starting data interaction
1280         https://bugs.webkit.org/show_bug.cgi?id=172228
1281         <rdar://problem/32166729>
1282
1283         Reviewed by Andy Estes.
1284
1285         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
1286         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
1287         still vended when beginning data interaction on something that resembles a link.
1288
1289         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1290
1291 2017-05-17  David Kilzer  <ddkilzer@apple.com>
1292
1293         BlobDataFileReference::generateReplacementFile() should use mkstemp()
1294         <https://webkit.org/b/172192>
1295
1296         Reviewed by Brent Fulgham.
1297
1298         * Scripts/webkitpy/style/checkers/cpp.py:
1299         (check_language): Add check for mktemp.
1300         (CppChecker): Add 'security/temp_file' category.
1301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1302         (CppStyleTest.test_insecure_temp_file): Add test.
1303
1304 2017-05-17  Devin Rousso  <drousso@apple.com>
1305
1306         Unreviewed, change my email.
1307
1308         * Scripts/webkitpy/common/config/contributors.json:
1309
1310 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1311
1312         Unreviewed, rolling out r216974.
1313
1314         Revision caused consistent timeouts on all platforms.
1315
1316         Reverted changeset:
1317
1318         "Add a RuntimeEnabledFeature for display: contents, defaulted
1319         to false."
1320         https://bugs.webkit.org/show_bug.cgi?id=171984
1321         http://trac.webkit.org/changeset/216974
1322
1323 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1324
1325         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
1326         https://bugs.webkit.org/show_bug.cgi?id=171987
1327
1328         Reviewed by Brady Eidson.
1329
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1331         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1332         (TEST):
1333
1334 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1335
1336         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1337         https://bugs.webkit.org/show_bug.cgi?id=171984
1338
1339         Reviewed by Antti Koivisto.
1340
1341         * DumpRenderTree/mac/DumpRenderTree.mm:
1342         (enableExperimentalFeatures):
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::TestController::resetPreferencesToConsistentValues):
1345
1346 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
1347
1348         Fix the build
1349
1350         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1351         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1352
1353 2017-05-16  Tim Horton  <timothy_horton@apple.com>
1354
1355         PageVisibilityStateWithWindowChanges tests sometimes time out
1356         https://bugs.webkit.org/show_bug.cgi?id=172202
1357         <rdar://problem/29653266>
1358
1359         Reviewed by Dean Jackson.
1360
1361         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1362         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1363         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
1364
1365 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
1366
1367         webkitpy: Start servers before setting-up for testing
1368         https://bugs.webkit.org/show_bug.cgi?id=172176
1369         <rdar://problem/32225538>
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         On-device testing requires that servers are started before ports set-up their
1374         test environments.
1375
1376         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1377         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
1378         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
1379         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1380         (Manager.__init__): Delay construction of the test runner until we can determine
1381         if servers need to be started.
1382         (Manager.run): Determine if servers need to be started and construct the test runner.
1383         (Manager._run_tests): Move the determination of servers to run into Manager.run.
1384
1385 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
1386
1387         Unreviewed, adding myself to contributors.json
1388
1389         * Scripts/webkitpy/common/config/contributors.json:
1390
1391 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
1392
1393         [GTK] Tests that always pass when run alone, but fail in the bots
1394         https://bugs.webkit.org/show_bug.cgi?id=168572
1395
1396         Reviewed by Michael Catanzaro.
1397
1398         PlatformWebView::viewSupportsOptions() is basically a comparison
1399         that checks that the passed options are the ones supported by the
1400         web view. There is no reason for them to be implemented for each
1401         platform differently. In fact doing so causes issues each time a
1402         new option is added, if the corresponding platform implementation
1403         is not updated accordingly.
1404
1405         A consequence of not updating the viewSupportOptions()
1406         implementations when new options are added is that tests that need
1407         these options might fail if they are executed after a test that
1408         didn't need the option, as the webview will be reused even if the
1409         option is not supported. This cannot be spotted when running the
1410         tests individually. See bug #165133 for other example of the same
1411         problem.
1412
1413         Remove the platform implementations and make the comparison a
1414         method of the TestOptions structure, so that the check is in one
1415         place. For the time being, only include in the comparison the
1416         options that were checked in the mac platform, which seem to be
1417         the only ones relevant this far (unless newer ones have also been
1418         forgotten).
1419
1420         * WebKitTestRunner/PlatformWebView.h:
1421         (WTR::PlatformWebView::viewSupportsOptions): Use the method
1422         defined below.
1423         * WebKitTestRunner/TestOptions.h:
1424         (WTR::TestOptions::hasSameInitializationOptions): Added.
1425         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1426         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1427         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1428         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1429         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1430         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1431         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
1432         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1433
1434 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
1435
1436         [JSC] Build testapi in non Apple ports
1437         https://bugs.webkit.org/show_bug.cgi?id=172103
1438
1439         Reviewed by Filip Pizlo.
1440
1441         Now testapi is drived in JSCOnly, GTK and WPE ports too.
1442
1443         * Scripts/build-jsc:
1444         * Scripts/run-javascriptcore-tests:
1445
1446 2017-05-15  Youenn Fablet  <youenn@apple.com>
1447
1448         WPT test importer should not account for slow manual tests
1449         https://bugs.webkit.org/show_bug.cgi?id=172127
1450
1451         Reviewed by Ryosuke Niwa.
1452
1453         Making sure manual tests are not triggering updating tests-options.json file.
1454
1455         * Scripts/webkitpy/w3c/test_importer.py:
1456         (TestImporter.find_importable_tests):
1457         (TestImporter._already_identified_as_resource_file):
1458         (TestImporter.update_tests_options):
1459         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1460         (test_manual_slow_test):
1461
1462 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
1463
1464         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
1465         https://bugs.webkit.org/show_bug.cgi?id=172142
1466
1467         Reviewed by Tim Horton.
1468
1469         * Scripts/webkitpy/xcode/simulator.py:
1470         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
1471         around runtime identifiers.
1472         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
1473
1474 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1475
1476         Update ARES-6 plan file to use the latest version
1477         https://bugs.webkit.org/show_bug.cgi?id=172139
1478
1479         Reviewed by Keith Miller.
1480
1481         Include r216538.
1482
1483         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1484
1485 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
1486
1487         Disable Picture In Picture API tests on unsupported platforms.
1488         https://bugs.webkit.org/show_bug.cgi?id=172125
1489         rdar://problem/32199477
1490
1491         Reviewed by Simon Fraser.
1492
1493         The callbacks and allowing picture-in-picture require new SPI.
1494
1495         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1496
1497 2017-05-15  Brady Eidson  <beidson@apple.com>
1498
1499         [ios-simulator] API test WKWebView.ClearAppCache is failing.
1500         https://bugs.webkit.org/show_bug.cgi?id=172120
1501
1502         Unreviewed test gardening.
1503
1504         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1505         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
1506           Restoring that code fixes this.
1507
1508 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
1509
1510         Null deref under WebContentReader::readURL when interacting with a file URL
1511         https://bugs.webkit.org/show_bug.cgi?id=172045
1512         <rdar://problem/25880647>
1513
1514         Reviewed by Wenson Hsieh.
1515
1516         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1517         (TestWebKitAPI::TEST):
1518         The text of the file URL is pasted because a textual version of it gets
1519         onto the pasteboard. However, this test would have crashed before. Also
1520         tests that we don't make an <a>.
1521
1522 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
1523
1524         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
1525         https://bugs.webkit.org/show_bug.cgi?id=172071
1526
1527         Reviewed by Alexey Proskuryakov.
1528
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         (resetWebPreferencesToConsistentValues):
1531
1532 2017-05-14  Chris Dumez  <cdumez@apple.com>
1533
1534         Drop PassRefPtr class from WTF
1535         https://bugs.webkit.org/show_bug.cgi?id=172091
1536
1537         Reviewed by Alex Christensen.
1538
1539         Drop API test coverage.
1540
1541         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1542         (TestWebKitAPI::TEST):
1543         (TestWebKitAPI::passWithPassRefPtr): Deleted.
1544
1545 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
1546
1547         [MediaStream] deviceId constraint doesn't work with getUserMedia
1548         https://bugs.webkit.org/show_bug.cgi?id=171877
1549         <rdar://problem/31899730>
1550
1551         Reviewed by Jer Noble.
1552
1553         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
1554         implement the "checkUserMediaPermission" callback.
1555         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1556         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1557         (TestWebKitAPI::checkUserMediaPermissionCallback):
1558         (TestWebKitAPI::TEST):
1559
1560         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
1561         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1562
1563 2017-05-13  Chris Dumez  <cdumez@apple.com>
1564
1565         Stop using RefPtr::release()
1566         https://bugs.webkit.org/show_bug.cgi?id=172074
1567
1568         Reviewed by Geoffrey Garen.
1569
1570         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1571         (TestWebKitAPI::TEST):
1572
1573 2017-05-13  Commit Queue  <commit-queue@webkit.org>
1574
1575         Unreviewed, rolling out r216808.
1576         https://bugs.webkit.org/show_bug.cgi?id=172075
1577
1578         caused lldb to hang when debugging (Requested by smfr on
1579         #webkit).
1580
1581         Reverted changeset:
1582
1583         "Use Mach exceptions instead of signals where possible"
1584         https://bugs.webkit.org/show_bug.cgi?id=171865
1585         http://trac.webkit.org/changeset/216808
1586
1587 2017-05-12  Alex Christensen  <achristensen@webkit.org>
1588
1589         Rename WKContentExtension to WKContentRuleList
1590         https://bugs.webkit.org/show_bug.cgi?id=172053
1591         <rdar://problem/32141005>
1592
1593         Reviewed by Geoffrey Garen.
1594
1595         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
1596         (WKContentRuleListStoreTest::SetUp):
1597         (TEST_F):
1598         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1599         (WKContentExtensionStoreTest::SetUp): Deleted.
1600         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
1601
1602 2017-05-12  Keith Miller  <keith_miller@apple.com>
1603
1604         Use Mach exceptions instead of signals where possible
1605         https://bugs.webkit.org/show_bug.cgi?id=171865
1606
1607         Reviewed by Mark Lam.
1608
1609         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1610         (runThreadMessageTest):
1611         (TEST):
1612
1613 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1614
1615         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
1616         https://bugs.webkit.org/show_bug.cgi?id=172048
1617         rdar://problem/32163054
1618
1619         Reviewed by Simon Fraser.
1620
1621         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
1622
1623         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1625         (hasVideoInPictureInPictureDidChange):
1626         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1627         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
1628         (TestWebKitAPI::TEST):
1629
1630 2017-05-12  Brady Eidson  <beidson@apple.com>
1631
1632         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1633         https://bugs.webkit.org/show_bug.cgi?id=172030
1634
1635         Unreviewed - Test gardening
1636
1637         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
1638         before the test starts.
1639
1640         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1641         (defaultWebsiteCacheDirectory):
1642         (defaultApplicationCacheDirectory):
1643         (TEST):
1644         (defaultWebsiteDataDirectory): Deleted.
1645
1646 2017-05-12  David Quesada  <david_quesada@apple.com>
1647
1648         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
1649         https://bugs.webkit.org/show_bug.cgi?id=172000
1650         rdar://problem/32144756
1651
1652         Reviewed by Simon Fraser.
1653
1654         Added API tests to verify that WKWebView provides the expected value for
1655         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
1656         inside a scrollview but not clipped, clipped by an ancestor scrollview,
1657         clipped by the webview's _enclosingViewForExposedRectComputation)
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
1661         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
1662         (TestWebKitAPI::TEST):
1663
1664 2017-05-12  Brady Eidson  <beidson@apple.com>
1665
1666         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1667         https://bugs.webkit.org/show_bug.cgi?id=172030
1668
1669         Unreviewed - Test gardening, in effect...
1670
1671         More exploration as to why this continues to fail on the bots.
1672         
1673         This change should give us a smoking gun.
1674         
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1676         (TEST):
1677
1678 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1679
1680         [GTK] Fix compile warnings in PlatformImageCairo.cpp
1681         https://bugs.webkit.org/show_bug.cgi?id=171850
1682
1683         Reviewed by Michael Catanzaro.
1684
1685         * ImageDiff/cairo/PlatformImageCairo.cpp:
1686         (ImageDiff::PlatformImage::createFromStdin):
1687         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1688
1689 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1690
1691         Add UIClient callback for when picture-in-picture is activated.
1692         https://bugs.webkit.org/show_bug.cgi?id=172023
1693
1694         Reviewed by Simon Fraser.
1695
1696         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
1697
1698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1699         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
1700         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
1701         (onLoadedCompletedCallback):
1702         (waitUntilOnLoadIsCompleted):
1703         (didFinishLoadForFrame):
1704         (setHasVideoInPictureInPicture):
1705         (TestWebKitAPI::TEST):
1706
1707 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1708
1709         Unreviewed follow-up to r216776.
1710
1711         * Scripts/webkitpy/port/base.py:
1712         (Port.path_to_crash_logs): Raise not implemented.
1713         * Scripts/webkitpy/port/test.py:
1714         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
1715         * Scripts/webkitpy/port/win.py:
1716         (WinPort.path_to_crash_logs): Ditto.
1717
1718 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
1719
1720         Bot watcher's dashboard shows results links twice sometimes
1721         https://bugs.webkit.org/show_bug.cgi?id=172043
1722
1723         Reviewed by Tim Horton.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1726         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1727
1728 2017-05-12  Brady Eidson  <beidson@apple.com>
1729
1730         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1731         https://bugs.webkit.org/show_bug.cgi?id=172030
1732
1733         Unreviewed - Test gardening, in effect...
1734
1735         This failure is only being seen by the bots.
1736         
1737         I believe this test is utterly broken in the first place; when it checks the .wal file's
1738         size that is not actually an indicator that the records were deleted.
1739         
1740         But that isn't what's coming up as failure on the bots.
1741         
1742         This patch is an attempt to:
1743         1 - More forcefully clear the Website data directory of leftovers before the test starts.
1744         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
1745
1746         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1747         (defaultWebsiteDataDirectory):
1748         (defaultApplicationCacheDirectory):
1749         (TEST):
1750
1751 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1752
1753         webkitpy: Pass directory with crash logs into CrashLogs
1754         https://bugs.webkit.org/show_bug.cgi?id=172033
1755         <rdar://problem/32157616>
1756
1757         Reviewed by Daniel Bates.
1758
1759         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
1760         the location of crash logs.
1761
1762         * Scripts/webkitpy/common/system/crashlogs.py:
1763         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
1764         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
1765         generating one.
1766         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
1767         self._results_directory.
1768         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
1769         generating one.
1770         (CrashLogs._log_directory_darwin): Moved to port.
1771         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
1772         to the crash log is no longer owned by CrashLogs.
1773         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
1774         directory for uploading crash logs. Note that crash logs are only supported on Mac
1775         and Windows.
1776         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
1777         * Scripts/webkitpy/port/base.py:
1778         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
1779         to be in the results directory.
1780         * Scripts/webkitpy/port/darwin.py:
1781         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
1782         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
1783         (DarwinPort._get_crash_log): Ditto.
1784         * Scripts/webkitpy/port/darwin_testcase.py:
1785         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
1786         the path to crash logs.
1787         * Scripts/webkitpy/port/ios_device.py:
1788         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
1789         * Scripts/webkitpy/port/ios_device_unittest.py:
1790         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
1791         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
1792         * Scripts/webkitpy/port/mac.py: Ditto.
1793         * Scripts/webkitpy/port/test.py:
1794         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
1795         * Scripts/webkitpy/port/win.py:
1796         (WinPort._get_crash_log): Ditto.
1797         * Scripts/webkitpy/tool/commands/queries.py:
1798         (execute): Construct a port object since this is the object which owns the path to crash logs.
1799
1800 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
1803
1804         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
1805         URL parameter using the default value "about:blank" when not provided.
1806
1807         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1808         (testWebViewCreateNavigationData):
1809
1810 2017-05-11  Youenn Fablet  <youenn@apple.com>
1811
1812         Allow WPT server to serve specific WebKit test
1813         https://bugs.webkit.org/show_bug.cgi?id=171479
1814
1815         Reviewed by Ryosuke Niwa.
1816
1817         Adding a new mount point to WPT server.
1818         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
1819
1820         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
1821
1822         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1823         (Manager.__init__):
1824         (Manager._is_http_test):
1825         (Manager._needs_web_platform_test):
1826         (Manager._run_tests):
1827         (Manager._is_web_platform_test): Deleted.
1828         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1829         (build_routes):
1830         (main):
1831         * Scripts/webkitpy/port/driver.py:
1832         (Driver):
1833         (Driver.is_webkit_specific_web_platform_test):
1834         (Driver.test_to_uri):
1835         (Driver._command_from_driver_input):
1836
1837 2017-05-11  Brady Eidson  <beidson@apple.com>
1838
1839         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
1840         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
1841
1842         Reviewed by Andy Estes.
1843         Informal review by Maureen Daum.
1844
1845         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1846         (TEST):
1847
1848 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1849
1850         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
1851         https://bugs.webkit.org/show_bug.cgi?id=171989
1852
1853         Reviewed by Brian Burg.
1854
1855         * lldb/lldb_webkit.py:
1856         (WTFStringImplProvider.get_data8):
1857         (WTFStringImplProvider.get_data16):
1858         m_data8 and m_data16 are now part of the superclass StringImplShape
1859         instead of directly in StringImpl. So first get the shape by getting
1860         index 0, and the data properties are the same offset within that.
1861
1862 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1863
1864         Remove Vibration API
1865         https://bugs.webkit.org/show_bug.cgi?id=171766
1866
1867         Rubber-stamped by Alexey Proskuryakov.
1868
1869         * Scripts/webkitperl/FeatureList.pm:
1870
1871 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1872
1873         Add WPE release bots
1874         https://bugs.webkit.org/show_bug.cgi?id=171973
1875
1876         Reviewed by Žan Doberšek.
1877
1878         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
1879         It also adds a new WPE buildbot category.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/config.json:
1882         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1883         (InstallWpeDependencies):
1884         (appendCustomBuildFlags):
1885         (Factory.__init__):
1886         (loadBuilderConfig):
1887         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1888         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1889
1890 2017-05-09  Sam Weinig  <sam@webkit.org>
1891
1892         Remove support for legacy Notifications
1893         https://bugs.webkit.org/show_bug.cgi?id=171487
1894
1895         Reviewed by Jon Lee.
1896
1897         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1898         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1899         * Scripts/webkitperl/FeatureList.pm:
1900         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1901         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1902
1903 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1904
1905         Remove user agent quirk for Slack
1906         https://bugs.webkit.org/show_bug.cgi?id=171869
1907
1908         Reviewed by Carlos Garcia Campos.
1909
1910         Remove the corresponding test.
1911
1912         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1913         (TestWebKitAPI::TEST):
1914
1915 2017-05-10  Commit Queue  <commit-queue@webkit.org>
1916
1917         Unreviewed, rolling out r216578.
1918         https://bugs.webkit.org/show_bug.cgi?id=171920
1919
1920         Broke the GTK+ build with Wayland enabled (Requested by KaL on
1921         #webkit).
1922
1923         Reverted changeset:
1924
1925         "[GTK] Bump GTK+ and its dependencies in jhbuild"
1926         https://bugs.webkit.org/show_bug.cgi?id=171918
1927         http://trac.webkit.org/changeset/216578
1928
1929 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1930
1931         [GTK] Bump GTK+ and its dependencies in jhbuild
1932         https://bugs.webkit.org/show_bug.cgi?id=171918
1933
1934         Reviewed by Carlos Alberto Lopez Perez.
1935
1936         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1937         (WTR::initializeGtkSettings):
1938         * gtk/jhbuild.modules:
1939         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1940         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1941
1942 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
1943
1944         [Win] Set CMake args in build-webkit
1945         https://bugs.webkit.org/show_bug.cgi?id=171436
1946
1947         Reviewed by Per Arne Vollan.
1948
1949         * Scripts/build-webkit:
1950
1951 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1952
1953         ImageDiff: Add CG implementation for new ImageDiff
1954         https://bugs.webkit.org/show_bug.cgi?id=170608
1955
1956         Reviewed Alex Christensen.
1957
1958         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1959         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
1960         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
1961         * ImageDiff/CMakeLists.txt:
1962         * ImageDiff/Cairo.cmake:
1963         * ImageDiff/ImageDiff.cpp:
1964         (main):
1965         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1966         * ImageDiff/PlatformImage.cpp:
1967         * ImageDiff/PlatformImage.h:
1968         * ImageDiff/cairo/PlatformImageCairo.cpp:
1969         * ImageDiff/cg/ImageDiff.cpp: Removed.
1970         * ImageDiff/cg/PlatformImageCG.cpp: Added.
1971         (ImageDiff::PlatformImage::createFromStdin):
1972         (ImageDiff::PlatformImage::createFromDiffData):
1973         (ImageDiff::PlatformImage::PlatformImage):
1974         (ImageDiff::PlatformImage::~PlatformImage):
1975         (ImageDiff::PlatformImage::width):
1976         (ImageDiff::PlatformImage::height):
1977         (ImageDiff::PlatformImage::rowBytes):
1978         (ImageDiff::PlatformImage::hasAlpha):
1979         (ImageDiff::PlatformImage::pixels):
1980         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1981
1982 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
1983
1984         Enable FTL JIT by default on AArch64
1985         https://bugs.webkit.org/show_bug.cgi?id=144039
1986
1987         Reviewed by Yusuke Suzuki.
1988
1989         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
1990         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
1991         as an unsupported FTL platform.
1992         * Scripts/webkitdirs.pm:
1993         (isARM64): Returns 1 if the determined architecture is 'arm64'.
1994         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
1995
1996 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
1997
1998         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
1999         https://bugs.webkit.org/show_bug.cgi?id=170857
2000         <rdar://problem/31635373>
2001
2002         Reviewed by Aakash Jain.
2003
2004         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
2005         code to search for crash logs.
2006
2007         * Scripts/webkitpy/port/darwin.py:
2008         (DarwinPort._get_crash_log): Moved from MacPort.
2009         * Scripts/webkitpy/port/darwin_testcase.py:
2010         (DarwinTest.test_get_crash_log): Moved from MacTest.
2011         * Scripts/webkitpy/port/ios_device.py:
2012         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
2013         devices must search for crash-logs remotely.
2014         * Scripts/webkitpy/port/ios_simulator.py:
2015         (IOSSimulatorPort._get_crash_log): Deleted.
2016         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2017         (IOSSimulatorTest.test_get_crash_log): Deleted.
2018         * Scripts/webkitpy/port/mac.py:
2019         (MacPort._get_crash_log): Moved to DarwinPort
2020         * Scripts/webkitpy/port/mac_unittest.py:
2021         (MacTest.test_get_crash_log): Moved to DarwinTest.
2022
2023 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2024
2025         build ImageDiff with host SDK from Make
2026         https://bugs.webkit.org/show_bug.cgi?id=171835
2027
2028         Reviewed by Alexey Proskuryakov.
2029
2030         ImageDiff should be built for the default SDK and default architecture when
2031         the SDKROOT is set to either iOS device or iOS simulator. Check the
2032         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
2033
2034         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
2035         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
2036
2037 2017-05-09  Matt Lewis  <jlewis3@apple.com>
2038
2039         Unreviewed, adding myself to contributors.json
2040
2041         * Scripts/webkitpy/common/config/contributors.json:
2042
2043 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2044
2045         REGRESSION: ImageDiff not building with make
2046         https://bugs.webkit.org/show_bug.cgi?id=171788
2047
2048         Reviewed by Alex Christensen.
2049
2050         * Makefile: Build ImageDiff for all platforms.
2051
2052 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2053
2054         [Win] ImageDiff isn't built since Bug 168945
2055         https://bugs.webkit.org/show_bug.cgi?id=171847
2056
2057         Reviewed by Alex Christensen.
2058
2059         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
2060         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
2061         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
2062
2063 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
2064
2065         Upstream the WPE port
2066         https://bugs.webkit.org/show_bug.cgi?id=171110
2067
2068         Reviewed by Alex Christensen.
2069
2070         webkit-dev thread:
2071         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
2072
2073         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
2074         In-file changes removed from this ChangeLog entry for brevity.
2075
2076         * BuildSlaveSupport/built-product-archive:
2077         * BuildSlaveSupport/test-result-archive:
2078         * CMakeLists.txt:
2079         * ImageDiff/PlatformWPE.cmake: Added.
2080         * Scripts/build-dumprendertree:
2081         * Scripts/build-webkit:
2082         * Scripts/build-webkittestrunner:
2083         * Scripts/update-webkit-libs-jhbuild:
2084         * Scripts/update-webkitwpe-libs: Added.
2085         * Scripts/webkitdirs.pm:
2086         * Scripts/webkitperl/FeatureList.pm:
2087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2088         * Scripts/webkitpy/port/factory.py:
2089         * Scripts/webkitpy/port/wpe.py: Added.
2090         * TestWebKitAPI/PlatformWPE.cmake: Added.
2091         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2092         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
2093         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2094         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2095         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2096         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2097         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2099         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2100         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
2101         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
2102         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
2103         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2104         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2105         * WebKitTestRunner/PlatformWPE.cmake: Added.
2106         * WebKitTestRunner/PlatformWebView.h:
2107         * WebKitTestRunner/TestController.cpp:
2108         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
2109         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
2110         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
2111         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
2112         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
2113         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2114         * jhbuild/jhbuild-wrapper:
2115         * wpe/generate-inspector-gresource-manifest.py: Added.
2116         * wpe/jhbuild.modules: Added.
2117         * wpe/jhbuildrc: Added.
2118         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
2119         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2120         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
2121         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
2122         * wpe/patches/glib-warning-fix.patch: Added.
2123         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
2124         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
2125         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2126         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2127         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
2128
2129 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2130
2131         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
2132         https://bugs.webkit.org/show_bug.cgi?id=169421
2133         <rdar://problem/30950171>
2134
2135         Reviewed by Tim Horton.
2136
2137         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2138         (createBitmapContextFromWebView): Implement for IOSurface.
2139         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2140         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
2141
2142 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2143
2144         buildbot: Cleanup simulators after running tests
2145         https://bugs.webkit.org/show_bug.cgi?id=171679
2146
2147         Reviewed by Aakash Jain.
2148
2149         simctl is partitioned for each user. Since kill-old-processes
2150         is run as root, we need to specify the buildbot user when tearing
2151         down simulators between steps.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2154         (KillOldProcesses): Pass buildbot user to kill-old-processes.
2155         * BuildSlaveSupport/kill-old-processes:
2156         (main): Specify the user for simctl if one has been provided.
2157
2158 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2159
2160         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
2161         https://bugs.webkit.org/show_bug.cgi?id=171681
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         * gtk/install-dependencies:
2166
2167 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
2170
2171         Glib uses now Unicode quotes in error messages.
2172
2173         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2174         (testWebKitConsoleMessageNetworkError):
2175
2176 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
2179
2180         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
2181         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
2182         characters to the input. Also fix typo in the function name.
2183
2184         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2185         (testWebViewJavaScriptDialogs):
2186
2187 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2188
2189         [GTK] Cannot sign in with new Google sign-in page
2190         https://bugs.webkit.org/show_bug.cgi?id=171770
2191
2192         Unreviewed. This just adds a test.
2193
2194         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2195         (TestWebKitAPI::TEST):
2196
2197 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2198
2199         [iOS WK2] Make rotation tests more reliable
2200         https://bugs.webkit.org/show_bug.cgi?id=171778
2201
2202         Reviewed by Tim Horton.
2203
2204         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
2205         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
2206         with override layout parameters, and an override orientation, and these caused viewport
2207         size to leak into later tests, and WebCore orientation to not get reset correctly.
2208
2209         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
2210         an override orientation was set, and would never re-register, causing lost orientationchanged
2211         events.
2212
2213         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
2214         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
2215
2216         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
2217         the WebProcess is caught up before proceeding with the test.
2218
2219         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2220         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2221         * WebKitTestRunner/ios/TestControllerIOS.mm:
2222         (WTR::TestController::platformResetStateToConsistentValues):
2223         (WTR::TestController::platformConfigureViewForTest):
2224
2225 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
2226
2227         [Mac][cmake] Buildfix after r216047
2228         https://bugs.webkit.org/show_bug.cgi?id=171769
2229
2230         Unreviewed buildfix.
2231
2232         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2233
2234 2017-05-05  Brady Eidson  <beidson@apple.com>
2235
2236         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
2237         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
2238
2239         Reviewed by Andy Estes.
2240
2241         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2242         (TEST):
2243
2244 2017-05-05  Brian Burg  <bburg@apple.com>
2245
2246         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
2247         https://bugs.webkit.org/show_bug.cgi?id=171748
2248         <rdar://problem/32027327>
2249
2250         Reviewed by Michael Catanzaro.
2251
2252         Remove temporary workaround now that the assertion failure is fixed.
2253
2254         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2255         (TEST):
2256
2257 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
2258
2259         Make it possible to test rotation in iOS WebKitTestRunner
2260         https://bugs.webkit.org/show_bug.cgi?id=171755
2261
2262         Reviewed by Tim Horton.
2263
2264         Add to UIScriptController:
2265             void simulateRotation(DeviceOrientation orientation, object callback);
2266             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
2267
2268         The former just does a view resize, as a simple WKWebView app would do. The second does
2269         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
2270         layout size and interface orientation. The two behaviors produce different resize and
2271         orientationchange events and sizes, and both need to be tested.
2272
2273         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
2274         which is now a custom subclass (PlatformWebViewController).
2275
2276         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2277         (WTR::UIScriptController::simulateRotation):
2278         (WTR::UIScriptController::simulateRotationLikeSafari):
2279         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2280         (WTR::UIScriptController::simulateRotation):
2281         (WTR::UIScriptController::simulateRotationLikeSafari):
2282         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2283         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2284         (WTR::toDeviceOrientation):
2285         (WTR::UIScriptController::simulateRotation):
2286         (WTR::UIScriptController::simulateRotationLikeSafari):
2287         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2288         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2289         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2290         (-[TestRunnerWKWebView dealloc]):
2291         (-[TestRunnerWKWebView _didEndRotation]):
2292         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2293         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2294         (WTR::PlatformWebView::PlatformWebView):
2295         * WebKitTestRunner/ios/TestControllerIOS.mm:
2296         (WTR::TestController::platformResetStateToConsistentValues):
2297         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2298         (WTR::toUIDeviceOrientation):
2299         (WTR::UIScriptController::simulateRotation):
2300         (WTR::UIScriptController::simulateRotationLikeSafari):
2301         (WTR::UIScriptController::platformClearAllCallbacks):
2302         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2303         (WTR::UIScriptController::simulateRotation):
2304         (WTR::UIScriptController::simulateRotationLikeSafari):
2305
2306 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2307
2308         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2309         https://bugs.webkit.org/show_bug.cgi?id=168945
2310         <rdar://problem/30745695>
2311
2312         Reviewed by David Kilzer.
2313
2314         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2315         target SDK. These two changes must happen simultaneously because some archives will
2316         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2317
2318         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2319         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2320         tools directory still includes ImageDiff.
2321         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2322         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2323         * Scripts/webkitpy/port/darwin.py: 
2324         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2325         locally or when running archives.
2326         * Scripts/webkitpy/port/image_diff.py:
2327         (IOSSimulatorImageDiffer): Deleted.
2328         * Scripts/webkitpy/port/ios_simulator.py:
2329         (IOSSimulatorPort.diff_image): Deleted.
2330
2331 2017-05-05  Brian Burg  <bburg@apple.com>
2332
2333         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
2334         https://bugs.webkit.org/show_bug.cgi?id=171748
2335
2336         Unreviewed test gardening.
2337
2338         The assertion failure will be investigated separately in order to avoid rolling out
2339         the fix for "secure" cookies. This assertion fails even without r216258 applied.
2340
2341         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2342         (TEST):
2343
2344 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2345
2346         Unreviewed, rolling out r216260.
2347
2348         Breaks internal iOS testers
2349
2350         Reverted changeset:
2351
2352         "Use ImageDiff built by host SDK and remove ImageDiff from
2353         DumpRenderTree"
2354         https://bugs.webkit.org/show_bug.cgi?id=168945
2355         http://trac.webkit.org/changeset/216260
2356
2357 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2358
2359         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2360         https://bugs.webkit.org/show_bug.cgi?id=168945
2361         <rdar://problem/30745695>
2362
2363         Reviewed by David Kilzer.
2364
2365         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2366         target SDK. These two changes must happen simultaneously because some archives will
2367         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2368
2369         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2370         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2371         tools directory still includes ImageDiff.
2372         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2373         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2374         * Scripts/webkitpy/port/darwin.py: 
2375         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2376         locally or when running archives.
2377         * Scripts/webkitpy/port/image_diff.py:
2378         (IOSSimulatorImageDiffer): Deleted.
2379         * Scripts/webkitpy/port/ios_simulator.py:
2380         (IOSSimulatorPort.diff_image): Deleted.
2381
2382 2017-05-05  Brian Burg  <bburg@apple.com>
2383
2384         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
2385         https://bugs.webkit.org/show_bug.cgi?id=171700
2386         <rdar://problem/32017975>
2387
2388         Reviewed by Brady Eidson.
2389
2390         Fix a mistake in the test that should have caught this bug.
2391
2392         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2393         (TEST):
2394         The assertions that were meant to check round-tripping were actually checking
2395         the properties of the original cookie objects, not the round-tripped ones.
2396         This test now fails without the bugfix and passes when it is applied.
2397
2398 2017-05-05  Daniel Bates  <dabates@apple.com>
2399
2400         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
2401         https://bugs.webkit.org/show_bug.cgi?id=171698
2402
2403         Reviewed by Darin Adler.
2404
2405         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
2406         so that we get pretty diff output when the actual string differs from the expected
2407         string as opposed to seeing a boolean result. The former makes makes it straightforward
2408         to diagnose a regression without reading the code for the test or instrumenting it to
2409         determine the actual string that was compared.
2410
2411         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2412         (TestWebKitAPI::TEST):
2413         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2414         (TestWebKitAPI::TEST_F):
2415         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2416         (TestWebKitAPI::TEST_F):
2417
2418 2017-05-05  Chris Dumez  <cdumez@apple.com>
2419
2420         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
2421         https://bugs.webkit.org/show_bug.cgi?id=171624
2422
2423         Reviewed by Dan Bernstein.
2424
2425         Extend API test coverage to cover crashes in addition to terminations requested by the client.
2426
2427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2428         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
2429         (TestWebKitAPI::webProcessWasTerminatedByClient):
2430         (TestWebKitAPI::webProcessCrashed):
2431         (TestWebKitAPI::TEST):
2432
2433 2017-05-04  Mark Lam  <mark.lam@apple.com>
2434
2435         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
2436         https://bugs.webkit.org/show_bug.cgi?id=171716
2437         <rdar://problem/30878027>
2438
2439         Reviewed by Saam Barati.
2440
2441         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
2442         does JS conversion and therefore, potentially JS allocations) and accessing
2443         methods of internal JS data structures (which may do JS invocation, etc).
2444
2445         * DumpRenderTree/TestRunner.cpp:
2446         (setAudioResultCallback):
2447
2448 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2449
2450         buildbot: Cleanup simulators after running tests
2451         https://bugs.webkit.org/show_bug.cgi?id=171679
2452         <rdar://problem/31994361>
2453
2454         Reviewed by Aakash Jain.
2455
2456         We shutdown the simulator process between tests, but in some cases, this is not
2457         sufficient. Explicitly shutdown every booted simulator.
2458
2459         * BuildSlaveSupport/kill-old-processes:
2460         (main): Shutdown all booted simulators.
2461
2462 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2463
2464         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
2465         https://bugs.webkit.org/show_bug.cgi?id=171644
2466
2467         Reviewed by Michael Catanzaro.
2468
2469         Check that only one WebKitWebContext can have automation enabled.
2470
2471         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2472         (testAutomationSessionRequestSession):
2473
2474 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2475
2476         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
2477         https://bugs.webkit.org/show_bug.cgi?id=171724
2478
2479         Reviewed by Michael Catanzaro.
2480
2481         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
2482
2483         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2484         (WTR::timeoutSource):
2485
2486 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2487
2488         Unreviewed. Fix wrong assert after r215176.
2489
2490         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
2491         could also be RGB24 when created from a web view snapshot.
2492
2493         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2494         (WTR::computeMD5HashStringForCairoSurface):
2495
2496 2017-05-04  Brian Burg  <bburg@apple.com>
2497
2498         lldb_webkit.py should provide a type summary for WebCore::URL
2499         https://bugs.webkit.org/show_bug.cgi?id=171670
2500
2501         Reviewed by Jer Noble.
2502
2503         Just print out the underlying string using the WTFString provider.
2504
2505         * lldb/lldb_webkit.py:
2506         (__lldb_init_module):
2507         (WebCoreURL_SummaryProvider):
2508         (WebCoreURLProvider):
2509         (WebCoreURLProvider.__init__):
2510         (WebCoreURLProvider.to_string):
2511
2512 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2513
2514         Unreviewed, rolling out r216206.
2515         https://bugs.webkit.org/show_bug.cgi?id=171714
2516
2517         Multiple LayoutTests crashing in Document::page() (Requested
2518         by ap on #webkit).
2519
2520         Reverted changeset:
2521
2522         "Remove support for legacy Notifications"
2523         https://bugs.webkit.org/show_bug.cgi?id=171487
2524         http://trac.webkit.org/changeset/216206
2525
2526 2017-05-04  Mark Lam  <mark.lam@apple.com>
2527
2528         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
2529         https://bugs.webkit.org/show_bug.cgi?id=171702
2530
2531         Reviewed by Filip Pizlo.
2532
2533         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
2534         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
2535         confirm that the test will detect a regression.  Unfortunately, I forgot to
2536         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
2537         This patch fixes that.
2538
2539         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2540         (TestWebKitAPI::neverDestroyedString):
2541
2542 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
2543
2544         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
2545         https://bugs.webkit.org/show_bug.cgi?id=170195
2546
2547         Unreviewed test gardening.
2548
2549         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2550         (TEST):
2551
2552 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2553
2554         [Win] Remove redundant macros that are set in the CMake config
2555         https://bugs.webkit.org/show_bug.cgi?id=171571
2556
2557         Reviewed by Brent Fulgham.
2558
2559         * DumpRenderTree/config.h:
2560         * MiniBrowser/win/stdafx.h:
2561         * TestWebKitAPI/config.h:
2562
2563 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2564
2565         Add testRunner.display() to force displaying the web page for testing
2566         https://bugs.webkit.org/show_bug.cgi?id=171694
2567
2568         Reviewed by Simon Fraser.
2569
2570         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
2571         drawing the web page but without track repaints.
2572
2573         * DumpRenderTree/TestRunner.cpp:
2574         (displayCallback):
2575         (TestRunner::staticFunctions):
2576         * DumpRenderTree/TestRunner.h:
2577         * DumpRenderTree/mac/TestRunnerMac.mm:
2578         (TestRunner::display):
2579         * DumpRenderTree/win/TestRunnerWin.cpp:
2580         (TestRunner::display):
2581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2582         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2583         (WTR::TestRunner::display):
2584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2585
2586 2017-05-04  Mark Lam  <mark.lam@apple.com>
2587
2588         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
2589         https://bugs.webkit.org/show_bug.cgi?id=171586
2590         <rdar://problem/31873190>
2591
2592         Reviewed by Yusuke Suzuki.
2593
2594         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
2595
2596         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2597         (TestWebKitAPI::neverDestroyedString):
2598         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
2599         (TestWebKitAPI::TEST):
2600
2601 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2602
2603         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
2604         https://bugs.webkit.org/show_bug.cgi?id=171585
2605         <rdar://problem/31544320>
2606
2607         Reviewed by Beth Dakin and Zalan Bujtas.
2608
2609         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
2610         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
2611         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
2612         operation rather than a copy.
2613
2614         See WebCore ChangeLog for more details.
2615
2616         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
2617                 DataInteractionSimulator.ContentEditableToTextarea
2618                 DataInteractionSimulator.ContentEditableMoveParagraphs
2619                 DataInteractionSimulator.TextAreaToInput
2620
2621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
2623         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2624         (TestWebKitAPI::TEST):
2625         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2626         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2627         (-[DataInteractionSimulator initWithWebView:]):
2628         (-[DataInteractionSimulator dealloc]):
2629         (-[DataInteractionSimulator _advanceProgress]):
2630         (-[DataInteractionSimulator waitForInputSession]):
2631         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
2632         (-[DataInteractionSimulator _webView:didStartInputSession:]):
2633
2634 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2635
2636         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
2637         https://bugs.webkit.org/show_bug.cgi?id=171641
2638
2639         Reviewed by Simon Fraser.
2640
2641         The plan is to add back the TestRunner.display() which does the display
2642         only without track repaints.
2643
2644         * DumpRenderTree/DumpRenderTree.h:
2645         * DumpRenderTree/TestRunner.cpp:
2646         (displayAndTrackRepaintsCallback):
2647         (TestRunner::staticFunctions):
2648         (displayCallback): Deleted.
2649         (displayInvalidatedRegionCallback): Deleted.
2650         * DumpRenderTree/TestRunner.h:
2651         * DumpRenderTree/mac/DumpRenderTree.mm:
2652         (displayWebView):
2653         (displayAndTrackRepaintsWebView):
2654         * DumpRenderTree/mac/TestRunnerMac.mm:
2655         (TestRunner::displayAndTrackRepaints):
2656         (TestRunner::display): Deleted.
2657         * DumpRenderTree/win/TestRunnerWin.cpp:
2658         (TestRunner::displayAndTrackRepaints):
2659         (TestRunner::display): Deleted.
2660         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2661         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2662         (WTR::TestRunner::displayAndTrackRepaints):
2663         (WTR::TestRunner::display): Deleted.
2664         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2665
2666 2017-05-04  Brady Eidson  <beidson@apple.com>
2667
2668         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
2669         https://bugs.webkit.org/show_bug.cgi?id=171513
2670
2671         Unreviewed gardening.
2672
2673         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2674         (TEST): Skip the failing parts of the test on iOS for now.
2675
2676 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
2677
2678         Make ImageDiff stand-alone
2679         https://bugs.webkit.org/show_bug.cgi?id=168939
2680
2681         Reviewed by David Kilzer.
2682
2683         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
2684         stand-alone project. Note that this change does not eliminate the ImageDiff inside
2685         the DumpRenderTree project.
2686
2687         * ImageDiff/ImageDiff.xcodeproj: Added.
2688         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
2689         * ImageDiff/Makefile: Use ImageDiff project.
2690         * ImageDiff/PlatformMac.cmake: Added.
2691         * ImageDiff/PlatformWin.cmake: Added.
2692         * ImageDiff/cg: Added.
2693         * ImageDiff/cg/Configurations: Added.
2694         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
2695         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
2696         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
2697         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
2698         (createImageFromStdin): Stop using RetainPtr.
2699         (createDifferenceImage): Ditto.
2700         (main): Ditto.
2701         * Scripts/build-imagediff: Stop building WTF and bmalloc.
2702
2703 2017-05-04  Sam Weinig  <sam@webkit.org>
2704
2705         Remove support for legacy Notifications
2706         https://bugs.webkit.org/show_bug.cgi?id=171487
2707
2708         Reviewed by Jon Lee.
2709
2710         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2711         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2712         * Scripts/webkitperl/FeatureList.pm:
2713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2714         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
2715
2716 2017-05-04  Andy Estes  <aestes@apple.com>
2717
2718         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
2719         https://bugs.webkit.org/show_bug.cgi?id=171673
2720
2721         Reviewed by Dan Bernstein.
2722
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2724         (TEST):
2725         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2726         (TEST):
2727         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2728         (TEST):
2729         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2730         (TEST):
2731         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
2732         (TEST):
2733         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2734         (configurationWithContentFilterSettings):
2735         (-[LazilyLoadPlatformFrameworksController init]):
2736         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2737         (TEST):
2738         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2739         (runTestWithWidth):
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
2741         (TEST):
2742         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2743         (TestWebKitAPI::TEST):
2744         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2745         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2746         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
2747         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
2748         +_test_configurationWithTestPlugInClassName:
2749
2750 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
2751
2752         [MediaStream] Allow host application to enable/disable media capture
2753         https://bugs.webkit.org/show_bug.cgi?id=171292
2754         <rdar://problem/31821492>
2755
2756         Reviewed by Jer Noble.
2757
2758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2759         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2760         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2761         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2762         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2763         (MediaCaptureDisabledTest::SetUp):
2764         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2765         (TEST_F):
2766         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2767
2768 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
2769
2770         Unreviewed, Adding self to contributors.json
2771
2772         * Scripts/webkitpy/common/config/contributors.json: Added name.
2773
2774 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
2775
2776         Fix compilation with ICU 59.1
2777         https://bugs.webkit.org/show_bug.cgi?id=171612
2778
2779         Reviewed by Mark Lam.
2780
2781         ICU 59.1 has broken source compatibility. Now it defines UChar as
2782         char16_t, which does not allow automatic type conversion from unsigned
2783         short in C++ code.
2784
2785         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2786         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
2787
2788 2017-05-04  Andy Estes  <aestes@apple.com>
2789
2790         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
2791         https://bugs.webkit.org/show_bug.cgi?id=171646
2792         <rdar://problem/30306321>
2793
2794         Reviewed by Tim Horton.
2795
2796         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2797         (runTestWithWidth):
2798         (TEST):
2799         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
2800         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
2801         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2802         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
2803         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2804         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
2805
2806 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
2807
2808         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
2809         https://bugs.webkit.org/show_bug.cgi?id=171649
2810
2811         Reviewed by Carlos Garcia Campos.
2812
2813         Add two patches picked from the upstream repository to fix building of
2814         the Fontconfig module in JHBuild. Additionally, this needed a patch to
2815         add "autogen.sh" as it is not included in release tarballs. Also:
2816         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
2817         being regenerated (which is needed) so this is disabled for the
2818         Fontconfig module.
2819
2820         * gtk/jhbuild.modules:
2821         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
2822         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
2823         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
2824
2825 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2826
2827         Unreviewed, rolling out r216172.
2828         https://bugs.webkit.org/show_bug.cgi?id=171654
2829
2830         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
2831         implementation. (Requested by ddkilzer on #webkit).
2832
2833         Reverted changeset:
2834
2835         "[MediaStream] Allow host application to enable/disable media
2836         capture"
2837         https://bugs.webkit.org/show_bug.cgi?id=171292
2838         http://trac.webkit.org/changeset/216172
2839
2840 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2841
2842         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
2843         https://bugs.webkit.org/show_bug.cgi?id=171595
2844
2845         Reviewed by Xabier Rodriguez-Calvar.
2846
2847         * gtk/jhbuild.modules:
2848         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2849         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2850         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
2851         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
2852         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2853         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2854         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2855
2856 2017-05-03  Saam Barati  <sbarati@apple.com>
2857
2858         How we build polymorphic cases is wrong when making a call from Wasm
2859         https://bugs.webkit.org/show_bug.cgi?id=171527
2860
2861         Reviewed by JF Bastien.
2862
2863         * Scripts/run-jsc-stress-tests:
2864
2865 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2866
2867         [MediaStream] Allow host application to enable/disable media capture
2868         https://bugs.webkit.org/show_bug.cgi?id=171292
2869         <rdar://problem/31821492>
2870
2871         Reviewed by Jer Noble.
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2875         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2876         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2877         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2878         (MediaCaptureDisabledTest::SetUp):
2879         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2880         (TEST_F):
2881         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2882
2883 2017-05-03  John Wilander  <wilander@apple.com>
2884
2885         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
2886         https://bugs.webkit.org/show_bug.cgi?id=171584
2887         <rdar://problem/24702576>
2888
2889         Reviewed by Brent Fulgham.
2890
2891         New function to call the clear function that takes a modifiedSince parameter.
2892
2893         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2895         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2896         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2899         * WebKitTestRunner/TestController.h:
2900         * WebKitTestRunner/TestInvocation.cpp:
2901         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2902
2903 2017-05-03  Commit Queue  <commit-queue@webkit.org>
2904
2905         Unreviewed, rolling out r216160 and r216161.
2906         https://bugs.webkit.org/show_bug.cgi?id=171640
2907
2908         These changes broke the iOS build. (Requested by mlewis13 on
2909         #webkit).
2910
2911         Reverted changesets:
2912
2913         "[MediaStream] Allow host application to enable/disable media
2914         capture"
2915         https://bugs.webkit.org/show_bug.cgi?id=171292
2916         http://trac.webkit.org/changeset/216160
2917
2918         "[MediaStream] Allow host application to enable/disable media
2919         capture"
2920         https://bugs.webkit.org/show_bug.cgi?id=171292
2921         http://trac.webkit.org/changeset/216161
2922
2923 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2924
2925         [MediaStream] Allow host application to enable/disable media capture
2926         https://bugs.webkit.org/show_bug.cgi?id=171292
2927         <rdar://problem/31821492>
2928
2929         Reviewed by Jer Noble.
2930
2931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2932         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2933         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2934         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2935         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2936         (MediaCaptureDisabledTest::SetUp):
2937         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2938         (TEST_F):
2939         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2940
2941 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
2942
2943         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
2944         https://bugs.webkit.org/show_bug.cgi?id=171350
2945         <rdar://problem/28600836>
2946
2947         Patched by Brady Eidson.
2948
2949         Reviewed by Brent Fulgham.
2950
2951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2952         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
2953         (TestWebKitAPI::runJavaScriptAlert):
2954         (TestWebKitAPI::decidePolicyForNavigationAction):
2955         (TestWebKitAPI::decidePolicyForNavigationResponse):
2956         (TestWebKitAPI::TEST):
2957         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
2958
2959 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
2960
2961         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
2962         https://bugs.webkit.org/show_bug.cgi?id=171619
2963         https://bugs.webkit.org/show_bug.cgi?id=170195
2964
2965         Reviewed by Tim Horton.
2966
2967         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
2968
2969         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2970         (TEST):
2971
2972 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2973
2974         YouTube user agent quirk breaks new YouTube
2975         https://bugs.webkit.org/show_bug.cgi?id=171603
2976
2977         Reviewed by Carlos Garcia Campos.
2978
2979         Remove the YouTube quirk test.
2980
2981         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2982         (TestWebKitAPI::TEST):
2983
2984 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
2985
2986         Async image decoding should be disabled for snapshots, printing and preview
2987         https://bugs.webkit.org/show_bug.cgi?id=171467
2988
2989         Reviewed by Simon Fraser.
2990
2991         Add a API test for snapshotting with large images. Ensure the images are
2992         drawn correctly which implies they should have been synchronously decoded.
2993
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2995         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
2996         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
2997         (TEST):
2998
2999 2017-05-03  Chris Dumez  <cdumez@apple.com>
3000
3001         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
3002         https://bugs.webkit.org/show_bug.cgi?id=171565
3003         <rdar://problem/31204417>
3004
3005         Reviewed by Sam Weinig.
3006
3007         Add API test coverage.
3008
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
3011         (TestWebKitAPI::didFinishNavigation):
3012         (TestWebKitAPI::didCrashWithReason):
3013         (TestWebKitAPI::TEST):
3014
3015 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3016
3017         check-webkit-style should also keep js-test-post[-async].js in sync
3018         <https://webkit.org/b/171568>
3019
3020         Reviewed by Joseph Pecoraro.
3021
3022         * Scripts/webkitpy/style/checker.py:
3023         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
3024         JavaScript files not to be skipped.
3025         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
3026         (CheckerDispatcher._create_checker): Update to use
3027         _NEVER_SKIPPED_JS_FILES.
3028
3029         * Scripts/webkitpy/style/checkers/jstest.py:
3030         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
3031         This is the list of files containing functions that need to be
3032         kept in sync.
3033         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
3034         we can keep more sets of files in sync between
3035         LayoutTests/resources and LayoutTests/http/tests/resources.
3036         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
3037         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
3038         (JSTestChecker.check_js_test_files): Add 'file_group' argument
3039         for list of files to check instead of using
3040         KEEP_JS_TEST_FILES_IN_SYNC.
3041         (JSTestChecker.check_js_test_functions): Update for
3042         ALL_JS_TEST_FUNCTION_FILES rename.
3043
3044         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
3045         (JSTestCheckerTestCase):
3046         (JSTestCheckerTestCase.test_map_functions_to_dict):
3047         - Add test case for map_functions_to_dict() in jstest.py.
3048
3049 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
3050
3051         ews should indicate in logs when it fails to fetch the attachment
3052         https://bugs.webkit.org/show_bug.cgi?id=171583
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3057         (Bugzilla.fetch_attachment): Added log statement.
3058
3059 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3060
3061         Rolling out jstest_unittest.py so it can be reviewed
3062
3063         Follow-up fix for:
3064         check-webkit-style should keep JavaScript test functions in sync
3065         <https://webkit.org/b/171424>
3066
3067         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
3068
3069 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3070
3071         check-webkit-style should keep JavaScript test functions in sync
3072         <https://webkit.org/b/171424>
3073
3074         Reviewed by Joseph Pecoraro.
3075
3076         Add a new JSTestChecker for check-webkit-style that keeps these
3077         two files in sync:
3078
3079             LayoutTests/http/tests/resources/js-test-pre.js
3080             LayoutTests/resources/js-test-pre.js
3081
3082         And keeps implementations of shouldBe(), shouldNotBe(),
3083         shouldNotThrow(), and shouldThrow() in sync across multiple
3084         files (with the ability to add more functions later):
3085
3086             JSTests/stress/resources/standalone-pre.js
3087             LayoutTests/http/tests/resources/js-test-pre.js
3088             LayoutTests/resources/js-test-pre.js
3089             LayoutTests/resources/js-test.js
3090             LayoutTests/resources/standalone-pre.js
3091
3092         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
3093         import for JSTestChecker.
3094         (_NEVER_SKIPPED_FILES): Add array of file names that are never
3095         skipped regardless of other rules.
3096         (_all_categories): Add JSTestChecker categories.
3097         (CheckerDispatcher.should_skip_without_warning): Use
3098         _NEVER_SKIPPED_FILES.
3099         (CheckerDispatcher._create_checker): Return JSTestChecker for
3100         the files to check.
3101
3102         * Scripts/webkitpy/style/checkers/jstest.py: Add.
3103         (map_functions_to_dict): Parse JavaScript source by splitting on
3104         /^function\s+/ regex.  This is good enough for the sanity checks
3105         to keep function implementations in sync.
3106         (strip_blank_lines_and_comments): Strips blank lines and lines
3107         with comments from the end of a chunk of text representing a
3108         function.
3109         (JSTestChecker): New checker.
3110         (JSTestChecker.__init__):
3111         (JSTestChecker.check):
3112         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
3113         (JSTestChecker.check_js_test_functions): Keeps individual
3114         functions in sync.
3115
3116         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
3117         case.
3118         (JSTestTestCase):
3119         (JSTestTestCase.test_map_functions_to_dict):
3120
3121 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
3122
3123         AX: Update implementation of aria-orientation
3124         https://bugs.webkit.org/show_bug.cgi?id=171166
3125
3126         Reviewed by Chris Fleizach.
3127
3128         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
3129         are both absent from the state set. Before we were returning an empty string
3130         which was not consistent with what the Mac port does, thus making shared tests
3131         harder.
3132
3133         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3134         (WTR::AccessibilityUIElement::orientation):
3135
3136 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3137
3138         Stop using sprintf() in JavaScriptCore debugger
3139         <https://webkit.org/b/171512>
3140
3141         Reviewed by Keith Miller.
3142
3143         * Scripts/webkitpy/style/checker.py:
3144         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
3145         Source/JavaScriptCore/disassembler/udis86/ is generated code.
3146
3147 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
3148
3149         Expose viewport-fit instead of clip-to-safe-area
3150         https://bugs.webkit.org/show_bug.cgi?id=171503
3151         <rdar://problem/31918249>
3152
3153         Reviewed by Simon Fraser.
3154
3155         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3156         (WTR::UIScriptController::setSafeAreaInsets):
3157         (WTR::UIScriptController::setObscuredInsets): Deleted.
3158         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3159         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3160         (WTR::UIScriptController::setSafeAreaInsets):
3161         (WTR::UIScriptController::setObscuredInsets): Deleted.
3162         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3163         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3164         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3165         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
3166         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
3167         * WebKitTestRunner/ios/TestControllerIOS.mm:
3168         (WTR::TestController::platformResetStateToConsistentValues):
3169         * WebKitTestRunner/ios/UIKitSPI.h:
3170         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3171         (WTR::UIScriptController::setSafeAreaInsets):
3172         (WTR::UIScriptController::setObscuredInsets): Deleted.
3173         Expose a safe area inset setter instead of obscured insets.
3174
3175 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3176
3177         Unreviewed, fix the build on a new internal SDK
3178
3179         Replace usages of NSItemProviderRepresentationVisibilityAll with
3180         UIItemProviderRepresentationOptionsVisibilityAll.
3181
3182         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3183         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
3184         (TestWebKitAPI::TEST):
3185
3186 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3187
3188         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
3189         <https://webkit.org/b/171493>
3190
3191         Reviewed by Dan Bernstein.
3192
3193         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3194         Remove UIKit soft-link since TestWebKitAPI links to
3195         UIKit.framework.
3196         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
3197         UIWindow and UIWebView classes directly.
3198         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3199         Remove UIKit soft-link since TestWebKitAPI links to
3200         UIKit.framework.
3201         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
3202         class directly.
3203
3204 2017-05-01  Brady Eidson  <beidson@apple.com>
3205
3206         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
3207         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
3208
3209         Reviewed by Andy Estes.
3210
3211         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3212         (-[SchemeHandler webView:startURLSchemeTask:]):
3213         (-[SchemeHandler webView:stopURLSchemeTask:]):
3214         (-[SchemeHandler webView:startTask:]): Deleted.
3215         (-[SchemeHandler webView:stopTask:]): Deleted.
3216
3217 2017-05-01  Jason Marcell  <jmarcell@apple.com>
3218
3219         Add a new function for getting the Git hash for a pure git directory.
3220         https://bugs.webkit.org/show_bug.cgi?id=171450
3221
3222         Reviewed by David Kilzer.
3223
3224         * Scripts/VCSUtils.pm:
3225         (gitHashForDirectory):
3226
3227 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3228
3229         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
3230         https://bugs.webkit.org/show_bug.cgi?id=171496
3231
3232         Reviewed by Chris Fleizach.
3233
3234         Add new attribute names so that the values of the object attributes can be tested.
3235
3236         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3237         (WTR::AccessibilityUIElement::numberAttributeValue):
3238
3239 2017-05-01  Beth Dakin  <bdakin@apple.com>
3240
3241         On-screen panel for candidate bar is in the wrong place when the caret is at the 
3242         start of a paragraph
3243         https://bugs.webkit.org/show_bug.cgi?id=171453
3244         -and corresponding-
3245         rdar://problem/29779764
3246
3247         Reviewed by Tim Horton.
3248
3249         This test hard-codes the y-coordinate for the expected candidateRect. 
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3251         (TEST):
3252
3253 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3254
3255         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
3256         <https://webkit.org/b/171494>
3257
3258         Reviewed by Brent Fulgham.
3259
3260         * Scripts/webkitpy/style/checkers/cpp.py:
3261         (check_language): Change categories for certain checkers from
3262         'runtime/printf' to 'security/printf' so they are no longer
3263         filtered.
3264         (CppChecker.categories): Add 'security/printf'.
3265         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3266         (CppStyleTest.test_insecure_string_operations): Add new test for
3267         sprintf(), strcat() and strcpy().
3268         (CppStyleTest.test_format_strings): Update test results for new
3269         'security/printf' category use.
3270
3271 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3272
3273         AX: [GTK] Add support to query for aria-current
3274         https://bugs.webkit.org/show_bug.cgi?id=149016
3275
3276         Reviewed by Chris Fleizach.
3277
3278         Implement support for "AXARIACurrent" string attribute value.
3279
3280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3281
3282 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3283
3284         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
3285
3286         Unreviewed.
3287
3288         Follow-up fix for:
3289         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3290         https://bugs.webkit.org/show_bug.cgi?id=171486
3291
3292         * Scripts/webkitpy/style/checkers/cpp.py:
3293         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
3294         match and capture the function name.  The latter also mistakenly
3295         matches C-preprocessor directives.
3296         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
3297         is a requirement for the CppChecker class.
3298
3299 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3300
3301         [GTK] Add automation session API
3302         https://bugs.webkit.org/show_bug.cgi?id=171428
3303
3304         Reviewed by Carlos Alberto Lopez Perez.
3305
3306         Add an automation mode to MiniBrowser using the new API and add a unit test too.
3307
3308         * MiniBrowser/gtk/BrowserWindow.c:
3309         (webViewTitleChanged):
3310         (webViewDecidePolicy):
3311         (newTabCallback):
3312         (openPrivateWindow):
3313         (browserWindowFinalize):
3314         (browser_window_init):
3315         (browser_window_get_or_create_web_view_for_automation):
3316         * MiniBrowser/gtk/BrowserWindow.h:
3317         * MiniBrowser/gtk/main.c:
3318         (createBrowserTab):
3319         (createWebViewForAutomationCallback):
3320         (automationStartedCallback):
3321         (main):
3322         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3323         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
3324         (testAutomationSessionRequestSession):
3325         (beforeAll):
3326         (afterAll):
3327
3328 2017-04-30  Dan Bernstein  <mitz@apple.com>
3329
3330         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3331         https://bugs.webkit.org/show_bug.cgi?id=171486
3332
3333         Reviewed by Sam Weinig.
3334
3335         * Scripts/webkitpy/style/checkers/cpp.py:
3336         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
3337           alloc…Instance() instead.
3338         (check_style): Invoke new check.
3339
3340 2017-04-30  Brady Eidson  <beidson@apple.com>
3341
3342         More fixing after r215991
3343         https://bugs.webkit.org/show_bug.cgi?id=171483
3344
3345         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3346         (TEST):
3347
3348 2017-04-30  Brady Eidson  <beidson@apple.com>
3349
3350         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
3351         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
3352
3353         Reviewed by Geoff Garen (and kind of Andy Estes).
3354
3355         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3356         (TEST):
3357
3358 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3359
3360         [ATK] Implement support for aria-autocomplete
3361         https://bugs.webkit.org/show_bug.cgi?id=171167
3362
3363         Reviewed by Chris Fleizach.
3364
3365         Add "AXSupportsAutoCompletion" attribute so the presence of
3366         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
3367
3368         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3369         (WTR::AccessibilityUIElement::boolAttributeValue):
3370
3371 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3372
3373         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
3374         https://bugs.webkit.org/show_bug.cgi?id=171170
3375
3376         Reviewed by Chris Fleizach.
3377
3378         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
3379
3380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3381         (WTR::AccessibilityUIElement::boolAttributeValue):
3382
3383 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3384
3385         [ATK] Emit object:state-changed:busy event when aria-busy value changes
3386         https://bugs.webkit.org/show_bug.cgi?id=171181
3387
3388         Reviewed by Chris Fleizach.
3389
3390         Add handler for AXElementBusyChanged notifications.
3391
3392         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3393
3394 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
3395
3396         Use PEP8 style guide for raising exceptions in webkitpy.
3397         https://bugs.webkit.org/show_bug.cgi?id=171439
3398
3399         Reviewed by Daniel Bates.
3400
3401         As per https://www.python.org/dev/peps/pep-0008/
3402         "When raising an exception in Python 2, use raise ValueError('message') 
3403         instead of the older form raise ValueError, 'message'"
3404
3405         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
3406         * Scripts/webkitpy/common/thread/messagepump.py: Same.
3407         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
3408         * Scripts/webkitpy/tool/commands/queues.py: Same.
3409         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
3410         * Scripts/webkitpy/tool/multicommandtool.py: Same.
3411         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
3412
3413 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
3414
3415         Add system trace points for Document::updateTouchEventRegions()
3416         https://bugs.webkit.org/show_bug.cgi?id=171470
3417         rdar://problem/31901239
3418
3419         Reviewed by Tim Horton.
3420
3421         Add trace markers for updateTouchEventRegions.
3422
3423         * Tracing/SystemTracePoints.plist:
3424
3425 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3426
3427         webkitpy: Add apple_additions to webkitpy to insert Internal tools
3428         https://bugs.webkit.org/show_bug.cgi?id=170461
3429         <rdar://problem/31433077>
3430
3431         Reviewed by Daniel Bates.
3432
3433         Allow a package to be pulled in by run-webkit-tests which provides an interface to
3434         run layout tests on an iOS device.  If this package is not available, throw an
3435         exception when attempting to run layout tests on an iOS device.
3436
3437         * Scripts/webkitpy/port/config.py:
3438         (apple_additions): Import apple_additions package.
3439         * Scripts/webkitpy/port/device.py:
3440         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
3441         installed on a device.
3442         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
3443         host, the bundle id of the app to be used for testing and a path to the layout test
3444         directory to be mounted on the device.
3445         (Device.finished_testing):
3446         * Scripts/webkitpy/port/factory.py:
3447         (platform_options): Add apple_additions platform options if apple_additions exists.
3448         * Scripts/webkitpy/port/ios.py:
3449         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
3450         to forward, the bundle ID of the testing app and the layout tests directory to
3451         each device.
3452         * Scripts/webkitpy/port/ios_device.py:
3453         (IOSDevicePort):
3454         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
3455         processes to be run.
3456         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
3457         a single device is used, it is still accessed through an array.
3458         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
3459         for worker number map.
3460         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
3461         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
3462         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
3463         (IOSDevicePort.look_for_new_crash_logs): Ditto.
3464         (IOSDevicePort.look_for_new_samples): Ditto.
3465         (IOSDevicePort.sample_process): Ditto.
3466         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
3467         (IOSDevicePort._create_devices): Check that devices are available for testing and check
3468         that we have enough devices for each child process.
3469         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
3470         * Scripts/webkitpy/port/ios_device_unittest.py:
3471         (IOSDeviceTest.test_operating_system):
3472         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
3473         (IOSDeviceTest.test_sample_process): Ditto.
3474         (IOSDeviceTest.test_sample_process_exception): Ditto.
3475
3476 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3477
3478         Fix and re-enable data interaction unit tests
3479         https://bugs.webkit.org/show_bug.cgi?id=171446
3480         <rdar://problem/31820646>
3481
3482         Reviewed by Tim Horton.
3483
3484         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
3485         registering with the UIItemProvider, and instead just register data directly via
3486         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
3487
3488         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3489         (TestWebKitAPI::TEST):
3490         (temporaryURLForDataInteractionFileLoad): Deleted.
3491         (cleanUpDataInteractionTemporaryPath): Deleted.
3492         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
3493         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3494         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3495
3496 2017-04-28  Brady Eidson  <beidson@apple.com>
3497
3498         Teach the DatabaseProcess to be fully SessionID aware
3499         https://bugs.webkit.org/show_bug.cgi?id=171451
3500
3501         Reviewed by Geoffrey Garen.
3502
3503         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3504
3505 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3506
3507         Unreviewed follow-up to r214705.
3508
3509         shut.copytree will fail if given a file as an argument instead of a directory.
3510
3511         * Scripts/webkitpy/common/system/filesystem.py:
3512         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
3513         when source is a file.
3514         (FileSystem.copy_from_base_host): Ditto.
3515
3516 2017-04-28  Chris Dumez  <cdumez@apple.com>
3517
3518         Update DOMTokenList.replace() to match the latest DOM specification
3519         https://bugs.webkit.org/show_bug.cgi?id=171388
3520
3521         Reviewed by Alex Christensen.
3522
3523         Add API test coverage for new Vector API.
3524
3525         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3526         (TestWebKitAPI::TEST):
3527
3528 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3529
3530         WebKitTestRunner/DumpRenderTree prevent device from sleeping
3531         https://bugs.webkit.org/show_bug.cgi?id=170731
3532
3533         Reviewed by Alex Christensen.
3534
3535         While running layout tests on a device, the device should not be put asleep.
3536
3537         * DumpRenderTree/mac/DumpRenderTree.mm:
3538         (dumpRenderTree): Disable idle timer.
3539         * WebKitTestRunner/ios/TestControllerIOS.mm:
3540         (WTR::TestController::platformInitialize): Ditto.
3541
3542 2017-04-28  Brady Eidson  <beidson@apple.com>
3543
3544         Start of support for multiple WebsiteDataStore/SessionIDs per process
3545         https://bugs.webkit.org/show_bug.cgi?id=171422
3546
3547         Reviewed by Geoffrey Garen.
3548
3549         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3550         (TEST):
3551
3552 2017-04-28  Youenn Fablet  <youenn@apple.com>
3553
3554         Adding a runtime flag specific to MediaDevices
3555         https://bugs.webkit.org/show_bug.cgi?id=171433
3556
3557         Reviewed by Geoffrey Garen.
3558
3559         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
3560         Setting media devices runtime flag to true for WTR and DRT.
3561
3562         * DumpRenderTree/mac/DumpRenderTree.mm:
3563         (enableExperimentalFeatures):
3564         (resetWebPreferencesToConsistentValues):
3565         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3566         (TestWebKitAPI::TEST):
3567         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3568         (TestWebKitAPI::TEST):
3569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3570         (WTR::InjectedBundle::beginTesting):
3571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3572         (WTR::TestRunner::setMediaDevicesEnabled):
3573         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
3574         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
3575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3576         * WebKitTestRunner/TestController.cpp:
3577         (WTR::TestController::resetPreferencesToConsistentValues):
3578
3579 2017-04-28  Dean Jackson  <dino@apple.com>
3580
3581         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
3582         https://bugs.webkit.org/show_bug.cgi?id=171441
3583         <rdar://problem/31826915>
3584
3585         Reviewed by Tim Horton.
3586
3587         Add an API test for GPUCommandQueue, exercising creation
3588         and setting the label.
3589
3590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3591         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
3592         (TestWebKitAPI::TEST_F):
3593
3594 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3595
3596         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
3597         https://bugs.webkit.org/show_bug.cgi?id=171188
3598
3599         Reviewed by Chris Fleizach.
3600
3601         Add "AXModal" attribute string so that we can test the state's exposure.
3602
3603         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3604         (WTR::AccessibilityUIElement::boolAttributeValue):
3605
3606 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3607
3608         [ATK] GridCellRole should implement AtkTableCell (regression?)
3609         https://bugs.webkit.org/show_bug.cgi?id=171179
3610
3611         Reviewed by Chris Fleizach.
3612
3613         Add new "AXInterfaceTableCell" attribute so that we can test whether or
3614         not there is an implementation of AtkTableCell (i.e. without risking false
3615         negatives from bugs in the interface's implementation).
3616
3617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3618         (WTR::AccessibilityUIElement::boolAttributeValue):
3619
3620 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3621
3622         Move UUID from WebCore/platform to WTF
3623         https://bugs.webkit.org/show_bug.cgi?id=171372
3624
3625         Reviewed by Michael Catanzaro.
3626
3627         * WebKitTestRunner/TestController.cpp:
3628
3629 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3630
3631         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
3632         https://bugs.webkit.org/show_bug.cgi?id=171399
3633
3634         Reviewed by Brady Eidson.
3635
3636         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
3637         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3638         (TEST):
3639
3640 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
3641
3642         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
3643         https://bugs.webkit.org/show_bug.cgi?id=167914
3644
3645         Unreviewed test gardening.
3646
3647         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
3648         (TEST):
3649
3650 2017-04-26  Saam Barati  <sbarati@apple.com>
3651
3652         Add some more testing modes for Wasm tests now that we have tier up
3653         https://bugs.webkit.org/show_bug.cgi?id=171360
3654
3655         Reviewed by Keith Miller.
3656
3657         Lets enable the FTL on all Wasm tests. Let's also run each
3658         test with and without CJIT.
3659
3660         * Scripts/run-jsc-stress-tests:
3661
3662 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
3663
3664         JSC EWS Patch Relevance skips few JSC scripts
3665         https://bugs.webkit.org/show_bug.cgi?id=171351
3666
3667         Reviewed by Alexey Proskuryakov.
3668
3669         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3670         (CheckPatchRelevance): Added few jsc related scripts.
3671
3672 2017-04-26  Youenn Fablet  <youenn@apple.com>
3673
3674         Test importer should delete obsolete files based on w3c-import.log
3675         https://bugs.webkit.org/show_bug.cgi?id=171348
3676
3677         Reviewed by Chris Dumez.
3678
3679         * Scripts/webkitpy/w3c/test_importer.py:
3680         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
3681         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
3682         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3683         (test_remove_obsolete_content):
3684
3685 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
3686
3687         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
3688         <rdar://problem/31816459>
3689
3690         Unreviewed infrastructure fix.
3691
3692         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
3693         DYLD_FRAMEWORK_PATH when installing an app.
3694
3695         * Scripts/webkitpy/port/ios.py:
3696         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
3697
3698 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
3699
3700         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
3701         https://bugs.webkit.org/show_bug.cgi?id=171163
3702
3703         Reviewed by Chris Fleizach.
3704
3705         Add support for state-change notifications for ATK_STATE_ACTIVE.
3706
3707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3708
3709 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
3710
3711         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
3712         https://bugs.webkit.org/show_bug.cgi?id=171293
3713
3714         Reviewed by Aakash Jain.
3715
3716         We should make an effort to teardown simulators which we booted even when an exception is
3717         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
3718         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
3719         torn down.
3720
3721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3722         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
3723         * Scripts/webkitpy/port/ios_simulator.py:
3724         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
3725         iOS simulators and teardown and managed devices.
3726         (IOSSimulatorPort._create_simulators): Register teardown function.
3727         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
3728         (IOSSimulatorPort._remove_device): Deleted.
3729
3730 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
3731
3732         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
3733         https://bugs.webkit.org/show_bug.cgi?id=171164
3734
3735         Reviewed by Chris Fleizach.
3736
3737         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
3738         AtkStateSet; not what is found in the AtkObject's attributes.
3739
3740         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3741         (WTR::AccessibilityUIElement::hasPopup):
3742
3743 2017-04-25  Alex Christensen  <achristensen@webkit.org>
3744
3745         Encoded filename should be decoded for WKContentExtension.identifier
3746         https://bugs.webkit.org/show_bug.cgi?id=171316
3747
3748         Reviewed by Andy Estes.
3749
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
3752         (TEST_F):
3753         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
3754
3755 2017-04-25  Alex Christensen  <achristensen@webkit.org>
3756
3757         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
3758         https://bugs.webkit.org/show_bug.cgi?id=171297
3759         <rdar://problem/31530719>
3760
3761         Reviewed by Geoffrey Garen.
3762
3763         * TestWebKitAPI/PlatformWebView.h:
3764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3765         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
3766         (TestWebKitAPI::didFinishLoadForFrame):
3767         (TestWebKitAPI::mouseDidMoveOverElement):
3768         (TestWebKitAPI::setClients):
3769         (TestWebKitAPI::TEST):
3770         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3771         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3772         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3773
3774 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3775
3776         Unreviewed, temporarily disable the data interaction unit tests.
3777
3778         The API around data interaction will change significantly in the near future, and
3779         these tests will begin to fail. These will be reenabled once the bots are on an SDK
3780         that supports the updated data interaction API.
3781
3782         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3783         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3784         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3785
3786 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
3787
3788         Limit allowed size of document.title to avoid locking WebKit clients
3789         https://bugs.webkit.org/show_bug.cgi?id=165113
3790         <rdar://problem/28324389>
3791
3792         Reviewed by Darin Adler.
3793
3794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3795         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
3796         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
3797         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
3798
3799 2017-04-25  John Wilander  <wilander@apple.com>
3800
3801         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
3802         https://bugs.webkit.org/show_bug.cgi?id=171295
3803         <rdar://problem/31823818>
3804
3805         Reviewed by Brent Fulgham.
3806
3807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3809         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
3810         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
3811         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
3812         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3813         * WebKitTestRunner/TestController.cpp:
3814         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
3815         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
3816         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
3817         * WebKitTestRunner/TestController.h:
3818         * WebKitTestRunner/TestInvocation.cpp:
3819         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3820
3821 2017-04-25  Tim Horton  <timothy_horton@apple.com>
3822
3823         Try to fix the WKTR build after r215758
3824
3825         * Scripts/build-webkittestrunner:
3826
3827 2017-04-25  Daniel Bates  <dabates@apple.com>
3828
3829         Remove more EFL code
3830         https://bugs.webkit.org/show_bug.cgi?id=171288
3831
3832         Rubber-stamped by Simon Fraser.
3833
3834         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
3835         that was part of the EFL port.
3836
3837         * CMakeLists.txt:
3838         * DumpRenderTree/AccessibilityController.h:
3839         * DumpRenderTree/AccessibilityUIElement.cpp:
3840         (AccessibilityUIElement::getJSClass):
3841         * DumpRenderTree/AccessibilityUIElement.h:
3842         * DumpRenderTree/DumpRenderTree.h:
3843         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3844         * ImageDiff/efl/ImageDiff.cpp: Removed.
3845         * MiniBrowser/efl/CMakeLists.txt: Removed.
3846         * MiniBrowser/efl/main.c: Removed.
3847         * Scripts/build-dumprendertree:
3848         * Scripts/build-jsc:
3849         * Scripts/build-webkit:
3850         * Scripts/build-webkittestrunner:
3851         * Scripts/run-minibrowser:
3852         * Scripts/update-webkit-libs-jhbuild:
3853         * Scripts/update-webkitefl-libs: Removed.
3854         * Scripts/webkitdirs.pm:
3855         (argumentsForConfiguration):
3856         (extractNonMacOSHostConfiguration):
3857         (executableProductDir):
3858         (builtDylibPathForName):
3859         (determinePortName):
3860         (launcherPath):
3861         (launcherName):
3862         (getJhbuildPath):
3863         (wrapperPrefixIfNeeded):
3864         (generateBuildSystemFromCMakeProject):
3865         (buildCMakeProjectOrExit):
3866         (isEfl): Deleted.
3867         * Scripts/webkitperl/FeatureList.pm:
3868         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3869         * Scripts/webkitpy/common/config/ports.py:
3870         (DeprecatedPort.port):
3871         (GtkWK2Port.run_webkit_tests_command):
3872         (EflWK2Port): Deleted.
3873         (EflWK2Port.build_webkit_command): Deleted.
3874         * Scripts/webkitpy/port/builders.py:
3875         * Scripts/webkitpy/port/efl.py: Removed.
3876         * Scripts/webkitpy/port/efl_unittest.py: Removed.
3877         * Scripts/webkitpy/port/factory.py:
3878         (platform_options):
3879         (PortFactory):
3880         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3881         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3882         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3883         (TestRebaselineTest.test_baseline_directory):
3884         (TestRebaselineExpectations.test_rebaseline_expectations):
3885         * TestWebKitAPI/PlatformEfl.cmake: Removed.
3886         * TestWebKitAPI/PlatformWebView.h:
3887         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3888         (TestWebKitAPI::TEST):
3889         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
3890         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
3891         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
3892         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
3893         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
3894         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
3895         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
3896         * TestWebKitAPI/efl/main.cpp: Removed.
3897         * WebKitTestRunner/EventSenderProxy.h:
3898         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3899         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3900         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3901         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3902         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3903         (WTR::EventSendingController::contextClick):
3904         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3905         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3906         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3907         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3908         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
3909         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
3910         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
3911         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
3912         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
3913         * WebKitTestRunner/PlatformEfl.cmake: Removed.
3914         * WebKitTestRunner/PlatformWebView.h:
3915         * WebKitTestRunner/TestController.cpp:
3916         (WTR::TestController::resetStateToConsistentValues):
3917         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
3918         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
3919         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
3920         * WebKitTestRunner/efl/main.cpp: Removed.
3921         * efl/install-dependencies: Removed.
3922         * efl/jhbuild-optional.modules: Removed.
3923         * efl/jhbuild.modules: Removed.
3924         * efl/jhbuildrc: Removed.
3925         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
3926         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
3927         * efl/patches/gst-libav.patch: Removed.
3928         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
3929         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3930         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3931         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
3932         * gtk/manifest.txt.in:
3933
3934 2017-04-25  Daniel Bates  <dabates@apple.com>
3935
3936         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
3937         https://bugs.webkit.org/show_bug.cgi?id=136452
3938         <rdar://problem/23412620>
3939
3940         Reviewed by Brent Fulgham.
3941
3942         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
3943
3944         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
3945         as the EFL port is no longer in the WebKit OpenSource repository.
3946         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3947
3948 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3949
3950         Unreviewed follow-up to r215739 and r215740.
3951
3952         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
3953         This (and r215740) was supposed to land in r215739, but I managed to
3954         specify the previous version of the patch.
3955
3956 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3957
3958         Unreviewed follow-up to r215739.
3959
3960         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
3961         libgcrypt patch that enforces the use of /dev/urandom.
3962
3963 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3964
3965         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
3966         https://bugs.webkit.org/show_bug.cgi?id=171270
3967
3968         Reviewed by Michael Catanzaro.
3969
3970         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
3971         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
3972         that use systems that don't yet provide libgcrypt >= 1.7.0.
3973
3974 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3975
3976         [GTK] Improve an unit test for the JHBuild wrapper.
3977         https://bugs.webkit.org/show_bug.cgi?id=168036
3978
3979         Unreviewed follow-up patch after r215727
3980
3981         * Scripts/webkitpy/port/base_unittest.py:
3982         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
3983         wasn't there before calling MockFileSystem.maybe_make_directory(), and
3984         also that it exists after calling it.
3985
3986 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3987
3988         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
3989         https://bugs.webkit.org/show_bug.cgi?id=168036
3990
3991         Reviewed by Michael Catanzaro.
3992
3993         Call ImageDiff with the JHBuild wrapper if we should use it.
3994         Also add some unit tests for the JHBuild wrapper feature.
3995
3996         * Scripts/webkitpy/port/base.py:
3997         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
3998         * Scripts/webkitpy/port/base_unittest.py:
3999         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
4000         * Scripts/webkitpy/port/image_diff.py:
4001         (ImageDiffer._start): The actual fix, use the wrapper if we should.
4002         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
4003         * Scripts/webkitpy/port/port_testcase.py:
4004         (PortTestCase):
4005         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
4006         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
4007         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
4008
4009 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4010
4011         Support reading NSURL titles from the pasteboard when performing data interaction
4012         https://bugs.webkit.org/show_bug.cgi?id=171156
4013         <rdar://problem/31356937>
4014
4015         Reviewed by Tim Horton.
4016
4017         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
4018
4019         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4020         (TestWebKitAPI::TEST):
4021
4022 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
4023
4024         Respect fidelity order when reading web content from item providers
4025         https://bugs.webkit.org/show_bug.cgi?id=171155
4026         <rdar://problem/31356937>
4027
4028         Reviewed by Tim Horton.
4029
4030         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
4031         more details.
4032
4033         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4034         (TestWebKitAPI::TEST):
4035
4036 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4037
4038         SyntaxError fix after r215702.
4039         https://bugs.webkit.org/show_bug.cgi?id=168944
4040
4041         Unreviewed "build" fix.
4042
4043         * BuildSlaveSupport/built-product-archive:
4044         (archiveBuiltProduct):
4045
4046 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
4047
4048         Package ImageDiff built with host SDK
4049         https://bugs.webkit.org/show_bug.cgi?id=168944
4050         <rdar://problem/30745642>
4051
4052         Reviewed by David Kilzer.
4053
4054         iOS Simulator and iOS device should archive the ImageDiff built for the host
4055         machine.
4056
4057         * BuildSlaveSupport/built-product-archive:
4058         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
4059         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
4060
4061 2017-04-24  Keith Miller  <keith_miller@apple.com>
4062
4063         ThreadMessage API tests failing on release bots
4064         https://bugs.webkit.org/show_bug.cgi?id=171246
4065
4066         Reviewed by Saam Barati.
4067
4068         Need to make sure that C++ doesn't optimize away our spin loop.
4069
4070         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
4071         (runThreadMessageTest):
4072         (TEST):
4073
4074 2017-04-24  Alex Christensen  <achristensen@webkit.org>
4075
4076         Reduce copies and allocations in SharedBuffer::append
4077         https://bugs.webkit.org/show_bug.cgi?id=170956
4078
4079         Reviewed by Andreas Kling.
4080
4081         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
4082         (TestWebKitAPI::TEST_F):
4083
4084 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4085
4086         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
4087         https://bugs.webkit.org/show_bug.cgi?id=166680
4088
4089         Reviewed by Michael Catanzaro.
4090
4091         Update remote inspector unit tests.
4092
4093         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
4094         (main):
4095         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
4096         (connectToInspectorServer):
4097         (waitUntilInspectorServerIsReady):
4098         (startTestServer):
4099         (testInspectorServerPageList):
4100         (beforeAll):
4101
4102 2017-04-23  Youenn Fablet  <youenn@apple.com>
4103
4104         Add a tool to update expected.txt files from EWS bot results
4105         https://bugs.webkit.org/show_bug.cgi?id=169538
4106
4107         Reviewed by Ryosuke Niwa.
4108
4109         This script updates expected-txt files from bugzilla posted EWS results.
4110         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
4111         have results different from the generic baseline.
4112
4113         * Scripts/update-test-expectations-from-bugzilla: Added.
4114         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
4115         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
4116         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
4117
4118 2017-04-22  Youenn Fablet  <youenn@apple.com>
4119
4120         Add an option to import tip-of-tree WPT tests
4121         https://bugs.webkit.org/show_bug.cgi?id=171152
4122
4123         Reviewed by Joseph Pecoraro.
4124
4125         Adding a '-t' option to import tip of tree WPT tests.
4126         Updating importer based on the fact that csswg-test is no longer a thing. 
4127
4128         * Scripts/webkitpy/w3c/test_downloader.py:
4129         (TestDownloader.download_tests):
4130         * Scripts/webkitpy/w3c/test_importer.py:
4131         (configure_logging):
4132         (TestImporter.do_import):
4133         (TestImporter.write_import_log):
4134
4135 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4136
4137         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
4138         https://bugs.webkit.org/show_bug.cgi?id=171177
4139         <rdar://problem/31765379>
4140
4141         Reviewed by Andy Estes.
4142
4143         Tests uploading a JSON file to a file input.
4144
4145         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4146         (TestWebKitAPI::TEST):
4147
4148 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4149
4150         Support writing link titles to the pasteboard when beginning data interaction on a link
4151         https://bugs.webkit.org/show_bug.cgi?id=171154
4152         <rdar://problem/31356937>
4153
4154         Reviewed by Andy Estes.
4155
4156         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
4157         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
4158         matching the title of the link.
4159
4160         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4161         (TestWebKitAPI::TEST):
4162
4163 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4164
4165         Unreviewed, rolling out r215608.
4166
4167         Hundreds of test failures on GTK bot
4168
4169         Reverted changeset:
4170
4171         "Reduce copies and allocations in SharedBuffer::append"
4172         https://bugs.webkit.org/show_bug.cgi?id=170956
4173         http://trac.webkit.org/changeset/215608
4174
4175 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4176
4177         [WK2] Add delegate hooks for overriding unhanded data interaction operations
4178         https://bugs.webkit.org/show_bug.cgi?id=171005
4179         <rdar://problem/31669646>
4180
4181         Reviewed by Tim Horton.
4182
4183         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
4184         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
4185         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
4186
4187         New API test:
4188         DataInteractionTests.OverrideDataInteractionOperation
4189
4190         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4191         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
4192         (TestWebKitAPI::TEST):
4193         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4194         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4195         (-[DataInteractionSimulator initWithWebView:]):
4196         (-[DataInteractionSimulator dealloc]):
4197         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
4198         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
4199         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
4200
4201 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
4202
4203         Temporarily disable two flaky API tests.
4204
4205         Unreviewed test gardening.
4206
4207         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
4208         (TEST):
4209         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
4210         (TEST):
4211
4212 2017-04-21  Keith Miller  <keith_miller@apple.com>
4213
4214         Unreviewed, rolling out r215634.
4215
4216         underlying build issues should have been fixed
4217
4218         Reverted changeset:
4219
4220         "Unreviewed, rolling out r215620 and r215623."
4221         https://bugs.webkit.org/show_bug.cgi?id=171139
4222         http://trac.webkit.org/changeset/215634
4223
4224 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
4225
4226         Bubbles on dashboard doesn't turn red for test262 failures
4227         https://bugs.webkit.org/show_bug.cgi?id=171129
4228
4229         Reviewed by Alexey Proskuryakov.
4230
4231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
4232
4233 2017-04-21  Commit Queue  <commit-queue@webkit.org>
4234
4235         Unreviewed, rolling out r215620 and r215623.
4236         https://bugs.webkit.org/show_bug.cgi?id=171139
4237
4238         broke arm64 build (Requested by keith_miller on #webkit).
4239
4240         Reverted changesets:
4241
4242         "Add signaling API"
4243         https://bugs.webkit.org/show_bug.cgi?id=170976
4244         http://trac.webkit.org/changeset/215620
4245
4246         "Unreviewed, fix Cloop build."
4247         http://trac.webkit.org/changeset/215623
4248
4249 2017-04-20  Keith Miller  <keith_miller@apple.com>
4250
4251         Add signaling API
4252         https://bugs.webkit.org/show_bug.cgi?id=170976
4253
4254         Reviewed by Filip Pizlo.
4255
4256         Add tests for ThreadMessages.
4257
4258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4259         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
4260         (runThreadMessageTest):
4261         (TEST):
4262
4263 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
4264
4265         commit-log-editor should respect the git editor if one is set
4266         https://bugs.webkit.org/show_bug.cgi?id=171085
4267         <rdar://problem/31745506>
4268
4269         Reviewed by Daniel Bates.
4270
4271         * Scripts/commit-log-editor:
4272         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
4273         deciding which editor to present. We examine the global editor preference since that may be
4274         set automatically by installers or third-party tools.
4275
4276 2017-04-21  Alex Christensen  <achristensen@webkit.org>
4277
4278         Reduce copies and allocations in SharedBuffer::append
4279         https://bugs.webkit.org/show_bug.cgi?id=170956
4280
4281         Reviewed by Andreas Kling.
4282
4283         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
4284         (TestWebKitAPI::TEST_F):
4285
4286 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
4287
4288         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
4289         https://bugs.webkit.org/show_bug.cgi?id=171071
4290
4291         Reviewed by Michael Catanzaro.
4292
4293         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
4294         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
4295         be available for all ports.
4296
4297         * DumpRenderTree/PlatformMac.cmake:
4298         * MiniBrowser/mac/CMakeLists.txt:
4299         * MiniBrowser/win/CMakeLists.txt:
4300         * TestWebKitAPI/PlatformJSCOnly.cmake:
4301         * TestWebKitAPI/PlatformMac.cmake:
4302         * TestWebKitAPI/PlatformWin.cmake:
4303         * WebKitTestRunner/PlatformMac.cmake:
4304
4305 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
4306
4307         Test262 bot does not go red with failures
4308         https://bugs.webkit.org/show_bug.cgi?id=171044
4309
4310         Reviewed by Aakash Jain.
4311
4312         The piped output of run-jsc-stress-tests is different from
4313         its non-piped output. Switch to parsing the correct output.
4314
4315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4316         (RunTest262Tests.countFailures):
4317         Just count the number of lines that start with "FAIL:".
4318
4319         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4320         (RunTest262TestsTest.test_no_regressions_output):
4321         (test_failure_output):
4322         (test_failures_output):
4323         Updated tests with new sample output produced partially from bots and
4324         locally. In cases of failure the return code of run-jsc-stress-tests
4325         is still 0 so update the expected return code in the tests.
4326
4327 2017-04-20  Brady Eidson  <beidson@apple.com>
4328
4329         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
4330         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
4331
4332         Reviewed by Andy Estes.
4333
4334         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: