Move run-bindings-tests implementation to webkitpy/bindings/main.py
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-02  Kentaro Hara  <haraken@chromium.org>
2
3         Move run-bindings-tests implementation to webkitpy/bindings/main.py
4         https://bugs.webkit.org/show_bug.cgi?id=73619
5
6         Reviewed by Adam Barth.
7
8         As run-bindings-tests has been growing, this patch just moves its implementation
9         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
10
11         No change in behavior.
12
13         * Scripts/run-bindings-tests:
14         (main):
15         * Scripts/webkitpy/bindings/__init__.py: Added.
16         * Scripts/webkitpy/bindings/main.py: Added.
17         (BindingsTests.__init__):
18         (BindingsTests.generate_from_idl):
19         (BindingsTests.generate_supplemental_dependency):
20         (BindingsTests.detect_changes):
21         (BindingsTests.run_tests):
22
23 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
24
25         Tools/Scripts: eliminate find_test_files from Port class.
26         https://bugs.webkit.org/show_bug.cgi?id=73553
27
28         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
29         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
30         Also I'll move _is_test_file() and related functions close to Port.tests().
31
32         Reviewed by Dirk Pranke.
33
34         * Scripts/webkitpy/layout_tests/port/base.py:
35         (Port.tests):
36         (Port.is_reference_html_file):
37         (Port._has_supported_extension):
38         (Port._is_test_file):
39         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
40         (PortTest.test_find_no_paths_specified):
41         (PortTest.test_find_one_test):
42         (PortTest.test_find_glob):
43         (PortTest.test_find_with_skipped_directories):
44         (PortTest.test_find_with_skipped_directories_2):
45         (PortTest.test_is_test_file):
46         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
47         (_default_tests_paths):
48         (ChromiumGpuLinuxPort.tests):
49         (ChromiumGpuCgMacPort.tests):
50         (ChromiumGpuMacPort.tests):
51         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
52         (ChromiumGpuTest.test_default_tests_paths.test_paths):
53         (ChromiumGpuTest.test_default_tests_paths):
54         (ChromiumGpuTest.test_test_files.test_paths):
55         (ChromiumGpuTest):
56         (ChromiumGpuTest.test_test_files):
57         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
58         (get_tests_run.RecordingTestDriver.run_test):
59         * Scripts/webkitpy/tool/commands/rebaseline.py:
60         (OptimizeBaselines._optimize_baseline):
61         (OptimizeBaselines.execute):
62         (AnalyzeBaselines._analyze_baseline):
63         (AnalyzeBaselines.execute):
64
65 2011-12-01  Hajime Morrita  <morrita@chromium.org>
66
67         JS_INLINE and WTF_INLINE should be visible from WebCore
68         https://bugs.webkit.org/show_bug.cgi?id=73191
69
70         Reviewed by Kevin Ollivier.
71
72         Removed macro definitions which is now provided by Platform.h
73
74         * DumpRenderTree/chromium/config.h:
75         * DumpRenderTree/config.h:
76         * TestWebKitAPI/config.h:
77         * WebKitTestRunner/config.h:
78
79 2011-12-01  Hayato Ito  <hayato@chromium.org>
80
81         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
82         https://bugs.webkit.org/show_bug.cgi?id=73406
83
84         Reviewed by Ryosuke Niwa.
85
86         WebKitPort's image_diff uses tolerance='0.1' in default.
87         When reftests fail, we should use tolerace=0 when diff-ing images.
88
89         Since ImageDiff on chromium port doesn't use tolerance value as of now,
90         this change doesn't affect chromium port's behavior.
91
92         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
93         (write_test_result):
94         * Scripts/webkitpy/layout_tests/port/base.py:
95         (Port.diff_image):
96         * Scripts/webkitpy/layout_tests/port/chromium.py:
97         (ChromiumPort.diff_image):
98         * Scripts/webkitpy/layout_tests/port/test.py:
99         (TestPort.diff_image):
100         * Scripts/webkitpy/layout_tests/port/webkit.py:
101         (WebKitPort.diff_image):
102         (WebKitPort._start_image_diff_process):
103         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
104         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
105
106 2011-12-01  Adam Klein  <adamk@chromium.org>
107
108         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
109         https://bugs.webkit.org/show_bug.cgi?id=73599
110
111         Reviewed by Ojan Vafai.
112
113         * TestResultServer/static-dashboards/builders.js:
114         * TestResultServer/static-dashboards/dashboard_base.js:
115         ():
116         (htmlForTestTypeSwitcher):
117         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
118         (testHtmlForTestTypeSwitcherGroup):
119
120 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Parse reftest.list and extract types of ref tests
123         https://bugs.webkit.org/show_bug.cgi?id=66837
124
125         Reviewed by Dirk Pranke.
126
127         Add support for reftest.list to base port.
128
129         * Scripts/webkitpy/common/find_files.py:
130         (find):
131         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
132         (SingleTestRunner.__init__):
133         * Scripts/webkitpy/layout_tests/port/base.py:
134         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
135         to a dictionary of {test path: ("==" or "!=", reference file path)}
136         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
137         (Port._reference_file_for): Added; obtains the reference file name given a test name.
138         (Port.is_reftest): Added; Calls _reference_file_for.
139         (Port.reftest_expected_filename): Calls _reference_file_for.
140         (Port.reftest_expected_mismatch_filename): Ditto.
141         (Port.find_test_files):
142         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
143         -expected, -expected-mismach, -ref, or -notref as a reference file.
144         (_is_test_file):
145         (_parse_reftest_list): Added.
146         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
147         (PortTest.test_is_test_file):
148         (PortTest.test_parse_reftest_list):
149         * Scripts/webkitpy/layout_tests/port/dryrun.py:
150         (DryrunDriver.run_test):
151         * Scripts/webkitpy/layout_tests/port/test.py:
152         (unit_test_filesystem.add_test_file):
153         (unit_test_filesystem.add_file):
154         (unit_test_filesystem):
155         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
156         (get_tests_run.RecordingTestDriver.run_test):
157         (MainTest.test_unexpected_failures):
158         (MainTest.test_missing_and_unexpected_results):
159         (EndToEndTest.test_end_to_end):
160         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
161         (Rebaseliner._compile_rebaselining_tests):
162
163 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
164
165         Unreviewed, rolling out r101711.
166         http://trac.webkit.org/changeset/101711
167         https://bugs.webkit.org/show_bug.cgi?id=73605
168
169         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
170
171         * Scripts/webkitpy/style/checker.py:
172         (_all_categories):
173         (FileType):
174         (CheckerDispatcher._file_type):
175         (CheckerDispatcher._create_checker):
176         * Scripts/webkitpy/style/checker_unittest.py:
177         (CheckerDispatcherDispatchTest.assert_checker_cpp):
178         (CheckerDispatcherDispatchTest.test_cpp_paths):
179         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
180         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
181
182 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
183
184         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
185
186         * Scripts/webkitpy/common/config/watchlist:
187
188 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
189
190         [GTK] Read fonts from the jhbuild root
191         https://bugs.webkit.org/show_bug.cgi?id=73487
192
193         Reviewed by Gustavo Noronha Silva.
194
195         Read fonts from the jhbuild root instead of from the system. This will ensure
196         that all testers use the same fonts instead of leaving this up to luck.
197
198         * DumpRenderTree/gtk/DumpRenderTree.cpp:
199         (initializeFonts): Load fonts from jhbuild root.
200         * Scripts/webkitpy/layout_tests/port/gtk.py:
201         (GtkPort.setup_environ_for_server): Pass an environment variable containing
202         the path to the jhbuild root.
203         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
204         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
205
206 2011-12-01  Adam Roben  <aroben@apple.com>
207
208         Teach check-webkit-style how to check the syntax of JSON files
209
210         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
211
212         Reviewed by Darin Adler.
213
214         * Scripts/webkitpy/style/checker.py:
215         (_all_categories): Added JSONChecker's categories to the set of all categories.
216         (FileType): Added a JSON type. Incremented other types.
217         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
218         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
219
220         * Scripts/webkitpy/style/checker_unittest.py:
221         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
222         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
223
224         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
225         which would have matched our other checkers, because I couldn't figure out how to call
226         "json.loads" without hitting namespace conflicts.)
227         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
228         just the modified lines from a patch.
229         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
230         exception.
231         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
232         try to extract a line number.
233
234         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
235         (MockErrorHandler.__init__):
236         (MockErrorHandler.turn_off_line_filtering):
237         (MockErrorHandler.__call__):
238         Helper class. Copied from xml_unittest.py.
239
240         (JSONCheckerTest.test_line_number_from_json_exception): Test the
241         line_number_from_json_exception helper method.
242
243         (JSONCheckerTest.assert_no_error):
244         (JSONCheckerTest.assert_error):
245         Helper methods to assert that we did or didn't get an error.
246
247         (JSONCheckerTest.mock_handle_style_error): Helper method.
248
249         (JSONCheckerTest.test_conflict_marker):
250         (JSONCheckerTest.test_single_quote):
251         (JSONCheckerTest.test_init):
252         (JSONCheckerTest.test_missing_closing_brace):
253         (JSONCheckerTest.test_no_error):
254         Test various cases.
255
256 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
257
258         [GTK] Add a helper function to find the current executable's path
259         https://bugs.webkit.org/show_bug.cgi?id=73473
260
261         Reviewed by Gustavo Noronha Silva.
262
263         Update MiniBrowser to not pass the binary directory as an environment variable.
264         This means that you can move the binaries around without it breaking.
265
266         * MiniBrowser/gtk/main.c:
267         (main): No longer set the environment variable.
268         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
269         * WebKitTestRunner/gtk/main.cpp:  Ditto.
270
271 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
272
273         Unreviewed. Fix bad file =(.
274
275         * gtk/jhbuild.modules:
276         * Scripts/webkitdirs.pm:
277         (runAutogenForAutotoolsProject):
278
279 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
280
281         [GTK] Add freetype to our jhbuild setup
282         https://bugs.webkit.org/show_bug.cgi?id=73488
283
284         Reviewed by Martin Robinson.
285
286         This adds the first library to our jhbuild setup, and makes sure
287         build-webkit calls autogen.sh and make with jhbuild, so that the
288         environment is properly set.
289
290         * Scripts/webkitdirs.pm:
291         (saveSum):
292         (hashFile):
293         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
294         call autogen under jhbuild run;
295         (mustRunAutogen): generalized the arguments change checking to also force
296         running autogen when jhbuild files change;
297         (buildAutotoolsProject): run make under jhbuild;
298         * gtk/jhbuild.modules: add freetype.
299
300 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
301
302         Fix WebKitTestRunner compile warnings with XCode 3.2
303         https://bugs.webkit.org/show_bug.cgi?id=73378
304
305         Reviewed by Chris Fleizach.
306
307         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
308         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
309         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
310         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
311         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
312         (WTR::AccessibilityUIElement::AccessibilityUIElement):
313         (WTR::AccessibilityUIElement::verticalScrollbar):
314
315 2011-12-01  Adam Roben  <aroben@apple.com>
316
317         Allow committers to use their Trac credentials to force builds on the buildbots
318
319         Fixes <http://webkit.org/b/73353>
320
321         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
322         three files to do its job: a config file that contains a list of WebKit committer usernames,
323         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
324         those two files.
325
326         Reviewed by Darin Adler.
327
328         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
329         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
330         whether credentials were valid or not.
331         (CommitterAuth.__init__): Just store the path to auth.json.
332         (CommitterAuth.auth_json): Load, parse, and return auth.json.
333         (CommitterAuth.auth_json_filename): Return the path to auth.json.
334         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
335         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
336         checking those conditions.
337         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
338         false otherwise or if an exception was thrown.
339         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
340         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
341
342         (CommitterAuth.open_auth_json_file):
343         (CommitterAuth.open_trac_credentials_file):
344         (CommitterAuth.open_webkit_committers_file):
345         Open the specified file. These are mostly useful for testing purposes.
346
347         (CommitterAuth.trac_credentials_filename):
348         (CommitterAuth.webkit_committers_filename):
349         Return the path to the specified file by retrieving it from auth.json.
350
351         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
352         of WebKit committers from it.
353
354         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
355         (CMStringIO.__enter__):
356         (CMStringIO.__exit__):
357         Helper class that makes it possible to use StringIO with the "with" statement.
358
359         (open_override): Helper context manager for overriding the global "open" function
360         temporarily.
361
362         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
363         tests.
364         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
365         "open" to test that the expected path was opened.
366         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
367         successfully.
368         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
369         somehow have no Trac account can't authenticate.
370
371         (CommitterAuthTest.test_fail_to_open_auth_json_file):
372         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
373         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
374         Test what happens when we can't open the three files we depend upon.
375
376         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
377         an authentication class.
378
379         (CommitterAuthTest.test_invalid_auth_json_file):
380         (CommitterAuthTest.test_invalid_committers_file):
381         (CommitterAuthTest.test_invalid_trac_credentials_file):
382         (CommitterAuthTest.test_missing_auth_json_keys):
383         Test what happens when the three files we depend upon are invalid in some way.
384
385         (CommitterAuthTest.test_open_auth_json_file):
386         (CommitterAuthTest.test_open_trac_credentials_file):
387         (CommitterAuthTest.test_open_webkit_committers_file):
388         Test that we open the expected paths.
389
390         (CommitterAuthTest.test_trac_credentials_filename):
391         (CommitterAuthTest.test_webkit_committers_filename):
392         Test that we extract filenames out of auth.json correctly.
393
394         (CommitterAuthTest.test_non_committer_fails):
395         (CommitterAuthTest.test_unknown_user_fails):
396         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
397         (CommitterAuthTest.test_wrong_password_fails):
398         Test various failed authentication attempts.
399
400         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
401         committers out of the committers file correctly.
402
403         (CommitterAuthTest.fake_auth_json_file):
404         (CommitterAuthTest.invalid_auth_json_file):
405         (CommitterAuthTest.fake_committers_file):
406         (CommitterAuthTest.invalid_committers_file):
407         (CommitterAuthTest.fake_htdigest_file):
408         (CommitterAuthTest.invalid_htdigest_file):
409         Return various fake files for testing.
410
411         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
412         to be used for authentication in the web interface, and specify that only authenticated
413         users may force builds.
414
415 2011-12-01  Adam Roben  <aroben@apple.com>
416
417         Add an HTDigestParser class to webkitpy
418
419         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
420
421         This class can be used to parse Apache's htdigest files and check whether a given
422         username/realm/password tuple is present in the file. Eventually this will be used for
423         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
424
425         Reviewed by Eric Seidel.
426
427         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
428         (HTDigestParser.__init__): Stores the parsed representation of the file.
429         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
430         password and returns whether the resulting tuple is present in the file.
431         (HTDigestParser.entries): Just returns the parsed representation of the file.
432         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
433         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
434         whole file as invalid and all authentication attempts will fail.
435
436         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
437         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
438         optionally appended with some extra data, generates the expected entries.
439         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
440         authenticate, and tuples not present cannot.
441         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
442         fake_htdigest_file.
443
444         (HTDigestParserTest.test_empty_file):
445         (HTDigestParserTest.test_too_few_colons):
446         (HTDigestParserTest.test_too_many_colons):
447         (HTDigestParserTest.test_invalid_hash):
448         Test various forms of invalid files.
449
450         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
451
452 2011-12-01  Philippe Normand  <pnormand@igalia.com>
453
454         [GTK] Make the new 64-bit Release bot part of the core set
455         https://bugs.webkit.org/show_bug.cgi?id=73570
456
457         Reviewed by Adam Roben.
458
459         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
460         Debug bot which was already part of the core set. The GTK
461         gardeners are willing to actively maintain it.
462
463         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
464         (BuildBot.__init__):
465         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
466         (test_builder_name_regexps):
467
468 2011-12-01  Philippe Normand  <pnormand@igalia.com>
469
470         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
471         https://bugs.webkit.org/show_bug.cgi?id=73547
472
473         Reviewed by Adam Roben.
474
475         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
476         the 32-bit Debug configuration to 64-bit Release. The new slave is
477         a 64-bit machine already. The 32-bit slave will be shut down.
478
479 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
480
481         [GTK] build-jsc should not trigger gtkdoc generation
482         https://bugs.webkit.org/show_bug.cgi?id=73552
483
484         Reviewed by Philippe Normand.
485
486         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
487         that build-jsc does not try to generate gtkdoc.
488
489         * Scripts/webkitdirs.pm:
490         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
491
492 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
493
494         tests_run0.txt gets clobbered when re-running failing tests
495         https://bugs.webkit.org/show_bug.cgi?id=63844
496
497         Reviewed by Dirk Pranke.
498
499         * Scripts/webkitpy/layout_tests/controllers/manager.py:
500         (Manager.results_directory):
501         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
502         (AbstractWorker.__init__):
503         (_ManagerConnection.start_worker):
504         (_InlineManager.start_worker):
505         (_MultiProcessManager.start_worker):
506         (_WorkerConnection.__init__):
507         (_InlineWorkerConnection.__init__):
508         (_MultiProcessWorkerConnection.__init__):
509         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
510         (_TestWorker.__init__):
511         (_TestsMixin.test_cancel):
512         (_TestsMixin.test_done):
513         (_TestsMixin.test_unknown_message):
514         (InterfaceTest.test_managerconnection_is_abstract):
515         (InterfaceTest.test_workerconnection_is_abstract):
516         * Scripts/webkitpy/layout_tests/controllers/worker.py:
517         (Worker.__init__):
518         (Worker.safe_init):
519         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
520         (MainTest.test_retries_directory):
521
522 2011-12-01  Adam Roben  <aroben@apple.com>
523
524         Buildbot fix
525
526         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
527         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
528         it possible for build steps to reference things like the buildbotURL property of the config.
529
530 2011-11-30  Adam Roben  <aroben@apple.com>
531
532         Use curl for downloading builds to test slaves
533
534         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
535         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
536         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
537         overhead (courtesy of the Twisted framework).
538
539         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
540         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
541         This should make the test slaves quite a bit faster, and should ease the CPU load on
542         build.webkit.org a bit.
543
544         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
545
546         Reviewed by Mark Rowe.
547
548         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
549         to Test slaves. It's run just before DownloadBuiltProduct.
550         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
551         download.
552         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
553         FileDownload used to do this for us automatically.
554
555 2011-11-21  Philippe Normand  <pnormand@igalia.com>
556
557         [GTK] enable-webaudio websetting
558         https://bugs.webkit.org/show_bug.cgi?id=69836
559
560         Reviewed by Martin Robinson.
561
562         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
563         (LayoutTestController::overridePreference): Update WebKitGTK
564         enable-webaudio setting when a layout test requests it.
565
566 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
567
568         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
569         https://bugs.webkit.org/show_bug.cgi?id=73079
570
571         The idea is to have performance tests for WebInspector.
572         I was suggested to put these tests into PerformanceTests/inspector.
573         They produce output in a format that is suitable for chromium perf bot drawing scripts.
574
575         I'd like to reuse code for scanning folders for test files.
576         Because of the fact that original test_files.py has common and layout specific parts
577         I decided to extract the generic part and put it into webkitpy/common
578         I think the two packages with name test_files look strange but I have no idea about a better name.
579
580         Reviewed by Dirk Pranke.
581
582         * Scripts/run-inspector-perf-tests.py: Added.
583         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
584         (find):
585         (_normalize):
586         * Scripts/webkitpy/common/find_files_unittest.py: Added.
587         (MockWinFileSystem.join):
588         (MockWinFileSystem):
589         (MockWinFileSystem.normpath):
590         (TestWinNormalize.assert_filesystem_normalizes):
591         (TestWinNormalize.test_mocked_win):
592         (TestWinNormalize):
593         (TestWinNormalize.test_win):
594         * Scripts/webkitpy/layout_tests/port/base.py:
595         (Port.tests):
596         (Port.find_test_files):
597         (Port._driver_class):
598         (is_reference_html_file):
599         (_has_supported_extension):
600         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
601         (PortTest.test_find_no_paths_specified):
602         (PortTest.test_find_one_test):
603         (PortTest.test_find_glob):
604         (PortTest.test_find_with_skipped_directories):
605         (PortTest.test_find_with_skipped_directories_2):
606         (PortTest):
607         (PortTest.test_is_test_file):
608         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
609         (_tests):
610         * Scripts/webkitpy/layout_tests/port/test.py:
611         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
612         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
613         * Scripts/webkitpy/performance_tests/__init__.py: Added.
614         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
615         (PerfTestsRunner.__init__):
616         (PerfTestsRunner._parse_args):
617         (PerfTestsRunner._collect_tests._is_test_file):
618         (PerfTestsRunner._collect_tests):
619         (PerfTestsRunner.run):
620         (PerfTestsRunner._run_tests_set):
621         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
622         (MainTest.TestPort):
623         (MainTest.TestPort.create_driver):
624         (MainTest.TestDriver.run_test):
625         (MainTest.TestDriver):
626         (MainTest.TestDriver.stop):
627         (MainTest.create_runner):
628         (MainTest.run_test):
629         (MainTest.test_run_passing_test):
630         (MainTest.test_run_silent_test):
631         (MainTest.test_run_failed_test):
632         (MainTest.test_run_tonguey_test):
633         (MainTest.test_run_timeout_test):
634         (MainTest.test_run_crash_test):
635         (MainTest.test_run_test_set):
636         (MainTest.test_collect_tests):
637         (MainTest):
638         (MainTest.test_parse_args):
639         * Scripts/webkitpy/tool/commands/rebaseline.py:
640         (OptimizeBaselines.execute):
641         (AnalyzeBaselines.execute):
642
643 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
644
645         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
646         https://bugs.webkit.org/show_bug.cgi?id=70838
647
648         Reviewed by James Robinson.
649
650         * DumpRenderTree/chromium/TestShell.cpp:
651         (TestShell::resetWebSettings):
652         * DumpRenderTree/chromium/TestShell.h:
653         (TestShell::threadedCompositingEnabled):
654         * DumpRenderTree/chromium/WebPreferences.cpp:
655         (WebPreferences::reset):
656         (WebPreferences::applyTo):
657         * DumpRenderTree/chromium/WebPreferences.h:
658         * DumpRenderTree/chromium/WebViewHost.cpp:
659         (WebViewHost::WebViewHost):
660         (WebViewHost::~WebViewHost):
661
662 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
663
664         AX: Nodes are reporting that focus can be set when they really can't
665         https://bugs.webkit.org/show_bug.cgi?id=72791
666
667         Reviewed by Beth Dakin.
668
669         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
670         (AccessibilityUIElement::isFocusable):
671         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
672         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
673         (WTR::AccessibilityUIElement::isFocusable):
674
675 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
676
677         Moved myself to the reviewers list.
678
679         * Scripts/webkitpy/common/config/committers.py:
680
681 2011-11-30  David Levin  <levin@chromium.org>
682
683         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
684         https://bugs.webkit.org/show_bug.cgi?id=73415
685
686         Reviewed by Darin Fisher.
687
688         * DumpRenderTree/chromium/WebViewHost.cpp:
689         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
690         it being moved to a new interface and having the parameter removed.
691         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
692
693 2011-11-30  Adam Roben  <aroben@apple.com>
694
695         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
696
697         This will make it a lot easier to investigate build failures on the bots.
698
699         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
700
701         Reviewed by Eric Seidel.
702
703         * Scripts/webkitpy/common/system/executive_mock.py:
704         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
705         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
706         seen in practice.
707
708         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
709         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
710         The Printer was modifying the root logger in way that would cause my new tests in
711         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
712         seem important to the functioning of this test, and passing False makes Printer not modify
713         the root logger.
714
715         * Scripts/webkitpy/layout_tests/port/webkit.py:
716         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
717         up when --verbose is passed but not otherwise.
718         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
719         output at the ERROR level so it will always show up.
720
721         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
722         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
723         cases. Test that the build scripts' output is logged when --verbose is passed or the build
724         fails.
725
726 2011-11-30  Adam Roben  <aroben@apple.com>
727
728         Add a way to set OutputCapture's log level
729
730         This will be used by some unit tests I'm planning to add.
731
732         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
733
734         Reviewed by Eric Seidel.
735
736         * Scripts/webkitpy/common/system/outputcapture.py:
737         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
738         level we ever used before this patch.
739         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
740         being tested uses. Sets the log level for any current or future logging handlers.
741         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
742
743         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
744         (OutputCaptureTest.setUp): Create an OutputCapture to test.
745         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
746         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
747         was logged.
748         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
749         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
750         level.
751
752 2011-11-29  Beth Dakin  <bdakin@apple.com>
753
754         https://bugs.webkit.org/show_bug.cgi?id=72751
755         WebKit2.MouseMoveAfterCrash API test is failing 
756
757         Reviewed by Sam Weinig.
758
759         Like DumpRenderTree, the NSWindow should act as an active window.
760         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
761         (-[ActiveOffscreenWindow isKeyWindow]):
762         (TestWebKitAPI::PlatformWebView::PlatformWebView):
763
764 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
765
766         Add step to update gtk dependencies to the buildbot
767         https://bugs.webkit.org/show_bug.cgi?id=73455
768
769         Reviewed by Martin Robinson.
770
771         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
772
773 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
774
775         [Qt] Add a fullscreen option to MiniBrowser.
776         https://bugs.webkit.org/show_bug.cgi?id=73445
777
778         Reviewed by Noam Rosenthal.
779
780         This bypasses the compositor on the N9 to increase performances
781         and remove the huge useless gray bar part of the window frame
782         at the bottom.
783
784         * MiniBrowser/qt/BrowserWindow.cpp:
785         (BrowserWindow::BrowserWindow):
786         * MiniBrowser/qt/MiniBrowserApplication.cpp:
787         (printHelp):
788         (MiniBrowserApplication::handleUserOptions):
789         * MiniBrowser/qt/MiniBrowserApplication.h:
790         (WindowOptions::setStartFullScreen):
791         (WindowOptions::startFullScreen):
792
793 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
794
795         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
796         https://bugs.webkit.org/show_bug.cgi?id=73425
797
798         Reviewed by Gustavo Noronha Silva.
799
800         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
801         ensure that the jhbuild root is up-to-date. Currently the only module is
802         the font module.
803
804         * Scripts/update-webkitgtk-libs: Added.
805         * gtk/common.py: Added a helper to get the number of CPUs.
806         * gtk/jhbuild.modules: Added.
807         * gtk/jhbuildrc: Added.
808
809 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
810
811         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
812
813         Reviewed by Csaba Osztrogonác.
814
815         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
816         instead of one that pulls in JavaScriptCore headers.
817         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
818         with load(javascriptcore).
819
820 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
821
822         Unreviewed, rolling out r101440 and r101442.
823         http://trac.webkit.org/changeset/101440
824         http://trac.webkit.org/changeset/101442
825         https://bugs.webkit.org/show_bug.cgi?id=73429
826
827         multiple crashes on layout tests (Requested by hayato on
828         #webkit).
829
830         * DumpRenderTree/chromium/TestShell.cpp:
831         (TestShell::resetWebSettings):
832         * DumpRenderTree/chromium/TestShell.h:
833         * DumpRenderTree/chromium/WebPreferences.cpp:
834         (WebPreferences::reset):
835         (WebPreferences::applyTo):
836         * DumpRenderTree/chromium/WebPreferences.h:
837         * DumpRenderTree/chromium/WebViewHost.cpp:
838         (WebViewHost::WebViewHost):
839         (WebViewHost::~WebViewHost):
840
841 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
842
843         [Chromium] Fix broken DRT build for Aura Linux
844         https://bugs.webkit.org/show_bug.cgi?id=72667
845
846         Reviewed by Tony Chang.
847
848         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
849
850         The following changes have been made:
851
852           1. Renamed TestShellAndroid to TestShellLinux.
853           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
854           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
855
856         * DumpRenderTree/DumpRenderTree.gypi:
857         * DumpRenderTree/chromium/EventSender.cpp:
858         (EventSender::keyDown):
859         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
860         * DumpRenderTree/chromium/TestShellGtk.cpp:
861         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
862         (AlarmHandler):
863         (TestShell::waitTestFinished):
864         (setupFontconfig):
865         (platformInit):
866         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
867         (checkLayoutTestSystemDependencies):
868         (openStartupDialog):
869
870 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
871
872         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
873         https://bugs.webkit.org/show_bug.cgi?id=73328
874
875         Reviewed by Kent Tamura.
876
877         * DumpRenderTree/chromium/LayoutTestController.cpp:
878         (LayoutTestController::enableFixedLayoutMode):
879         (LayoutTestController::setFixedLayoutSize):
880
881 2011-11-29  Hayato Ito  <hayato@chromium.org>
882
883         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
884         https://bugs.webkit.org/show_bug.cgi?id=73381
885
886         Reviewed by Ryosuke Niwa.
887
888         This is a quick fix for the breakage of tests on non-chromium port.
889         We should implement diff_image later on non-chromium ports.
890
891         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
892         (write_test_result):
893
894 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
895
896         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
897         https://bugs.webkit.org/show_bug.cgi?id=72489
898
899         Reviewed by Eric Seidel.
900
901         Before the this fix always added "qt" option for the option list
902         * Scripts/run-webkit-tests:
903         * Scripts/webkitpy/layout_tests/port/qt.py:
904
905 2011-11-29  David Levin  <levin@chromium.org>
906
907         Add a way to revert a variable to its previous value after leaving a scope.
908         https://bugs.webkit.org/show_bug.cgi?id=73371
909
910         Reviewed by Adam Barth.
911
912         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
913         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
915         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
916         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
917         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
918
919 2011-11-28  Kentaro Hara  <haraken@chromium.org>
920
921         Implement [Supplemental] IDL and support it in run-bindings-tests
922         https://bugs.webkit.org/show_bug.cgi?id=73162
923
924         Reviewed by Adam Barth.
925
926         run-bindings-tests supports the [Supplemental] IDL in the following way.
927             (1) It creates a file |x| listing all IDL files.
928             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
929             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
930                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
931                 including all attributes in IDL files that are supplementing the IDL file |z|.
932
933         * Scripts/run-bindings-tests:
934         (generate_from_idl):
935         (generate_supplemental_dependency):
936         (detect_changes):
937         (run_tests):
938         (main):
939
940 2011-11-18  Nat Duca  <nduca@chromium.org>
941
942         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
943         https://bugs.webkit.org/show_bug.cgi?id=70838
944
945         Reviewed by James Robinson.
946
947         * DumpRenderTree/chromium/TestShell.cpp:
948         (TestShell::resetWebSettings):
949         * DumpRenderTree/chromium/TestShell.h:
950         (TestShell::threadedCompositingEnabled):
951         * DumpRenderTree/chromium/WebPreferences.cpp:
952         (WebPreferences::reset):
953         (WebPreferences::applyTo):
954         * DumpRenderTree/chromium/WebPreferences.h:
955         * DumpRenderTree/chromium/WebViewHost.cpp:
956         (WebViewHost::WebViewHost):
957         (WebViewHost::~WebViewHost):
958
959 2011-11-29  Ojan Vafai  <ojan@chromium.org>
960
961         List of builders in the flakiness dashboard is out of date
962         https://bugs.webkit.org/show_bug.cgi?id=73347
963
964         Reviewed by Adam Barth.
965
966         The chromium gpu bots no longer run layout tests, so kill that
967         group entirely.
968
969         * TestResultServer/static-dashboards/builders.js:
970         * TestResultServer/static-dashboards/dashboard_base.js:
971
972 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
973
974         [Qt] Don't hard-code the list of WebKit2 generated sources
975
976         The generated sources are... wait for it... generated. So
977         use the generator itself to figure out which sources we need
978         to compile.
979
980         Reviewed by Simon Hausmann.
981
982         * qmake/mkspecs/features/default_post.prf:
983
984 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
985
986         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
987         https://bugs.webkit.org/show_bug.cgi?id=73216
988
989         Reviewed by Philippe Normand.
990
991         Add a script that tries to sniff out 'make dist' problems without running
992         'make dist.' 'make distcheck' takes a very long time to run and this should
993         reduce the amount of times it needs to be run consecutively.
994
995         * gtk/common.py:
996         (get_build_path.is_valid_build_directory): Guess the source directory
997         by the existence of the GNUmakefile instead of the .libs directory. This
998         allows one to run the script after running autogen.sh but before fully
999         building.
1000         * gtk/find-make-dist-errors: Added.
1001
1002 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1003
1004         [Qt] Remove use of internal headers in the MiniBrowser
1005
1006         Reviewed by Simon Hausmann.
1007
1008         * MiniBrowser/qt/MiniBrowser.pro:
1009
1010 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
1011
1012         [Qt] Fix debug-shlib build without webkit2
1013
1014         Reviewed by Tor Arne Vestbø.
1015
1016         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
1017
1018 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
1019
1020         [Qt][WK2] Unreviewed buildfix after r101307.
1021
1022         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
1023
1024 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
1025
1026         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
1027         https://bugs.webkit.org/show_bug.cgi?id=72848
1028
1029         Add option to build-webkit.
1030
1031         Reviewed by Dimitri Glazkov.
1032
1033         * Scripts/build-webkit:
1034
1035 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1036
1037         gtest normalization in the test results server is sometimes wrong
1038         https://bugs.webkit.org/show_bug.cgi?id=73262
1039
1040         Reviewed by Tony Chang.
1041
1042         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
1043         entries in the incremental JSON, one of the entries will have the correct data
1044         from the run and the other will have dummy no-data values. Make sure to
1045         always pick the one with real data.
1046
1047         * TestResultServer/model/jsonresults.py:
1048         (JsonResults._remove_gtest_modifiers):
1049         * TestResultServer/model/jsonresults_unittest.py:
1050         (JsonResultsTest.test_remove_gtest_modifiers):
1051
1052 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1053
1054         Some of the results.json files have results/times entries at the directory level
1055         https://bugs.webkit.org/show_bug.cgi?id=73261
1056
1057         Reviewed by Tony Chang.
1058
1059         This is just a bug that got introduced in a temporary push of the results server.
1060         This patch repairs the broken files. After all the bots have cycled, we can simplify
1061         this code to just assert that results/times are not at the directory level.
1062
1063         Also, when catching exceptions, log the full stacktrace.
1064
1065         * TestResultServer/model/jsonresults.py:
1066         (_is_directory):
1067         (JsonResults._load_json):
1068         (JsonResults._merge_tests):
1069         (JsonResults.merge):
1070         * TestResultServer/model/jsonresults_unittest.py:
1071         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
1072
1073 2011-11-28  Tony Chang  <tony@chromium.org>
1074
1075         ews bots should pass --force to update-webkit-chromium
1076         https://bugs.webkit.org/show_bug.cgi?id=73230
1077
1078         Reviewed by Adam Barth.
1079
1080         This makes it less likely for gclient changes to break the bots (e.g.,
1081         if a DEPS repository moves or is switched to a branch).
1082
1083         Also pass --force when using |build-webkit --update-chromium| since this
1084         appears to only be used by the bots.
1085
1086         Take 2: Add Options.non_interactive to update.py's options() method.
1087
1088         * Scripts/update-webkit:
1089         * Scripts/webkitdirs.pm:
1090         (determineIsChromium): Add --force-update to update-webkit --chromium.
1091         (forceChromiumUpdate):
1092         (buildChromium): Pass --force to update-webkit-chromium.
1093         * Scripts/webkitpy/tool/steps/update.py:
1094         (Update.run): Add --force-update if non-interactive (i.e., bots).
1095         * Scripts/webkitpy/tool/steps/update_unittest.py:
1096
1097 2011-11-28  Tony Chang  <tony@chromium.org>
1098
1099         Revert r101279, broke the ews and cq bots.
1100
1101         * Scripts/update-webkit:
1102         * Scripts/webkitdirs.pm:
1103         (determineIsChromium):
1104         (buildChromium):
1105         * Scripts/webkitpy/common/config/ports.py:
1106         (WebKitPort.update_webkit_command):
1107         (ChromiumPort.update_webkit_command):
1108         * Scripts/webkitpy/common/config/ports_mock.py:
1109         (MockPort.update_webkit_command):
1110         * Scripts/webkitpy/tool/steps/update.py:
1111         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
1112
1113 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1114
1115         testlistjson on the test results server doesn't understand hierarchical results format
1116         https://bugs.webkit.org/show_bug.cgi?id=73246
1117
1118         Reviewed by Tony Chang.
1119
1120         * TestResultServer/model/jsonresults.py:
1121         (JsonResults._delete_results_and_times):
1122         Instead of just getting the top-level keys, we now walk the tests tree and
1123         delete the results and times values.
1124
1125         * TestResultServer/model/jsonresults_unittest.py:
1126         Simplify the test harness to take in the same JSON format for the tests
1127         that the actual results.json uses instead of something very similar but
1128         needlessly different. This also allows for testing the broken case of
1129         results and times values being at non-leaf level.
1130
1131 2011-11-28  Tony Chang  <tony@chromium.org>
1132
1133         ews bots should pass --force to update-webkit-chromium
1134         https://bugs.webkit.org/show_bug.cgi?id=73230
1135
1136         Reviewed by Adam Barth.
1137
1138         This makes it less likely for gclient changes to break the bots (e.g.,
1139         if a DEPS repository moves or is switched to a branch).
1140
1141         Also pass --force when using |build-webkit --update-chromium| since this
1142         appears to only be used by the bots.
1143
1144         * Scripts/update-webkit:
1145         * Scripts/webkitdirs.pm:
1146         (determineIsChromium): Add --force-update to update-webkit --chromium.
1147         (forceChromiumUpdate):
1148         (buildChromium): Pass --force to update-webkit-chromium.
1149         * Scripts/webkitpy/tool/steps/update.py:
1150         (Update.run): Add --force-update if non-interactive (i.e., bots).
1151         * Scripts/webkitpy/tool/steps/update_unittest.py:
1152
1153 2011-11-28  Michael Saboff  <msaboff@apple.com>
1154
1155         Fixed help message for --exclude-kraken to say that
1156         it excludes Kraken and not SunSpider.
1157
1158         Rubber-stamped by Filip Pizlo.
1159
1160         * Scripts/bencher:
1161
1162 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1163
1164         Unreviewed, rolling out r101273.
1165         http://trac.webkit.org/changeset/101273
1166         https://bugs.webkit.org/show_bug.cgi?id=73244
1167
1168         multiple test failures and timeouts (Requested by tony^work on
1169         #webkit).
1170
1171         * DumpRenderTree/DumpRenderTree.gypi:
1172         * DumpRenderTree/chromium/EventSender.cpp:
1173         (EventSender::keyDown):
1174         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1175         (AlarmHandler):
1176         (TestShell::waitTestFinished):
1177         (platformInit):
1178         (openStartupDialog):
1179         (checkLayoutTestSystemDependencies):
1180         * DumpRenderTree/chromium/TestShellGtk.cpp:
1181         (AlarmHandler):
1182         (setupFontconfig):
1183         (TestShell::waitTestFinished):
1184         (platformInit):
1185         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
1186         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1187
1188 2011-11-28  John Yani  <vanuan@gmail.com>
1189
1190         new-run-webkit-tests is locale dependent
1191         https://bugs.webkit.org/show_bug.cgi?id=68691
1192
1193         Reviewed and modified by Eric Seidel.
1194
1195         This is a simpler version of John's patch which I'm landing.
1196         This just engages the hacks from the Host constructor on a global
1197         basis.
1198
1199         * Scripts/webkitpy/common/host.py:
1200         (Host.__init__):
1201         (Host._engage_awesome_locale_hacks):
1202
1203 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
1204
1205         [Chromium] Fix broken DRT build for Aura Linux
1206         https://bugs.webkit.org/show_bug.cgi?id=72667
1207
1208         Reviewed by Tony Chang.
1209
1210         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
1211
1212         The following changes have been made:
1213
1214           1. Renamed TestShellAndroid to TestShellLinux.
1215           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
1216           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
1217
1218         * DumpRenderTree/DumpRenderTree.gypi:
1219         * DumpRenderTree/chromium/EventSender.cpp:
1220         (EventSender::keyDown):
1221         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1222         * DumpRenderTree/chromium/TestShellGtk.cpp:
1223         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1224         (AlarmHandler):
1225         (TestShell::waitTestFinished):
1226         (setupFontconfig):
1227         (platformInit):
1228         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
1229         (checkLayoutTestSystemDependencies):
1230         (openStartupDialog):
1231
1232 2011-11-28  Eric Seidel  <eric@webkit.org>
1233
1234         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1235         https://bugs.webkit.org/show_bug.cgi?id=71983
1236
1237         Reviewed by Adam Barth.
1238
1239         We'll add more code to Environment overtime,
1240         allowing us to mock out more of our direct interactions with os.environ.
1241
1242         This patch also makes run_command print the passed in environment.
1243
1244         * Scripts/webkitpy/common/host_mock.py:
1245         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1246         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1247         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1248         * Scripts/webkitpy/common/system/executive.py:
1249         * Scripts/webkitpy/common/system/executive_mock.py:
1250         * Scripts/webkitpy/layout_tests/port/webkit.py:
1251         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1252         * Scripts/webkitpy/tool/commands/download_unittest.py:
1253         * Scripts/webkitpy/tool/steps/build.py:
1254
1255 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1256
1257         [Qt] Build system fixes against V8.
1258
1259         Reviewed by Tor Arne Vestbø.
1260
1261         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
1262         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
1263         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
1264
1265 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1266
1267         Make sure the useFixedLayout feature is consistently handled
1268         https://bugs.webkit.org/show_bug.cgi?id=73212
1269
1270         Reviewed by Simon Hausmann.
1271
1272         The web page parameters are set to our Qt defaults and are now altered
1273         in the WebKitTestRunner.
1274
1275         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1276         (WTR::WrapperWindow::WrapperWindow):
1277
1278 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1279
1280         [Qt] WTF should be built as separate static library
1281         https://bugs.webkit.org/show_bug.cgi?id=73201
1282
1283         Reviewed by Tor Arne Vestbø.
1284
1285         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
1286         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
1287         thus wtf dependency.
1288         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
1289         * WebKitTestRunner/Target.pri: Ditto.
1290         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
1291         consider wtf, too.
1292         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
1293         moved into wtf.prf.
1294         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
1295         link in libwtf.
1296         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
1297
1298 2011-11-28  Kentaro Hara  <haraken@chromium.org>
1299
1300         run-bindings-tests shows diff error for a newly added binding test
1301         https://bugs.webkit.org/show_bug.cgi?id=73179
1302
1303         Reviewed by Adam Barth.
1304
1305         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
1306         run-bindings-tests just shows diff error because reference files
1307         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
1308
1309             FAIL: (V8) V8TestSupplemental.h
1310             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
1311
1312         Instead, this patch treats a non-existent reference file as an empty file and
1313         shows the result of the newly added binding test, like this:
1314
1315             FAIL: (V8) V8TestSupplemental.h
1316             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
1317             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
1318             @@ -0,0 +1,84 @@
1319             +/*
1320             +    This file is part of the WebKit open source project.
1321             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
1322             +
1323             (omitted)
1324
1325         * Scripts/run-bindings-tests:
1326         (detect_changes): Just added an -N option to the diff command.
1327
1328 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
1329
1330         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
1331         https://bugs.webkit.org/show_bug.cgi?id=73165
1332
1333         Reviewed by Philippe Normand.
1334
1335         Fix some syntax errors in this script and remove an unused variable.
1336
1337         * gtk/generate-gtkdoc:
1338         (get_webkit2_options.src_path): 
1339         (get_webkit2_options):
1340         (get_webkit1_options.src_path):
1341
1342 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
1343
1344         [wx] Unreviewed build fix. Enable the inspector.
1345         
1346         * waf/build/settings.py:
1347
1348 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
1349
1350         Try to fix the build after r101174.
1351
1352         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
1353
1354 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
1355
1356         [GTK] Integrate build-gtkdoc into build-webkit and make
1357         https://bugs.webkit.org/show_bug.cgi?id=72626
1358
1359         Reviewed by Philippe Normand.
1360
1361         * GNUmakefile.am: Added support for new scripts and "make docs".
1362         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
1363         (buildAutotoolsProject):
1364         * gtk/generate-gtkdoc: Added.
1365         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
1366
1367 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1368
1369         [Qt] Add support for using OWRT with Qt5
1370         https://bugs.webkit.org/show_bug.cgi?id=72947
1371
1372         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
1373
1374         Reviewed by Csaba Osztrogonác.
1375
1376         * Scripts/old-run-webkit-tests:
1377
1378 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
1379
1380         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
1381         https://bugs.webkit.org/show_bug.cgi?id=73126
1382
1383         No need to have a separate client call for this. The front-end can store messages
1384         which arrive before front-end loaded and dispatch them later. This happens in layout
1385         tests only by the way as all other messages should be initiated by the front-end code.
1386
1387         Reviewed by Pavel Feldman.
1388
1389         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1390         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1391         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1392         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1393
1394 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1395
1396         Replace subprocess.call() with subprocess.Popen()
1397         https://bugs.webkit.org/show_bug.cgi?id=73105
1398
1399         Reviewed by Adam Barth.
1400
1401         Currently, the stdout and stderr of the child processes of run-bindings-tests
1402         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
1403         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
1404         between a parent process and a child process. This patch replaces subprocess.call() with
1405         subprocess.Popen() and synchronizes the stdout and stderr between them.
1406         This patch also makes output messages of run-bindings-tests more readable.
1407
1408         With this patch, the output messages of run-bindings-tests look like as follows:
1409
1410             PASS: (CPP) WebDOMTestObj.h
1411             PASS: (CPP) WebDOMTestObj.cpp
1412             FAIL: (CPP) WebDOMTestInterface.h
1413             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
1414             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
1415             @@ -23,7 +23,7 @@
1416              #ifndef WebDOMTestInterface_h
1417              #define WebDOMTestInterface_h
1418
1419             -#if ENABLE(Condition1) || ENABLE(Condition2)
1420             +#if ENABLE(Condition1) || ENABLE(Condition3)
1421
1422              #include <WebDOMObject.h>
1423              #include <WebDOMString.h>
1424              @@ -53,5 +53,5 @@
1425              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
1426
1427              #endif
1428             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
1429             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
1430             PASS: (CPP) WebDOMFloat64Array.cpp
1431             PASS: (CPP) WebDOMFloat64Array.h
1432
1433             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
1434
1435         * Scripts/run-bindings-tests:
1436         (generate_from_idl):
1437         (detect_changes):
1438         (run_tests):
1439         (main):
1440
1441 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1442
1443         Fix the current working directory of run-bindings-tests
1444         https://bugs.webkit.org/show_bug.cgi?id=73106
1445
1446         Reviewed by Adam Barth.
1447
1448         Currently, run-bindings-tests outputs the following error
1449         (although it outputs "all tests passed!" in the end):
1450
1451             Testing the ObjC generator on TestObj.idl
1452             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
1453             gcc: warning: '-x objective-c' after last input file has no effect
1454             gcc: no input files
1455
1456         This is because CodeGeneratorObjC.pm assumes that the current working directory
1457         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
1458         Thus, this patch changes it to WebKit/Source/.
1459
1460         * Scripts/run-bindings-tests:
1461         (generate_from_idl):
1462         (main):
1463
1464 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1465
1466         [Qt] Get rid of the buildDirForSource() function in the build system
1467
1468         At some point the plan was to allow for running qmake on sub-trees
1469         of the sources, into the top level build directory, but this is no
1470         longer possible, so no reason to keep the convenience function around.
1471
1472         Reviewed by Simon Hausmann.
1473
1474         * WebKitTestRunner/DerivedSources.pri:
1475         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1476         * qmake/mkspecs/features/default_post.prf:
1477         * qmake/mkspecs/features/default_pre.prf:
1478         * qmake/mkspecs/features/functions.prf:
1479         * qmake/mkspecs/features/javascriptcore.prf:
1480         * qmake/mkspecs/features/webcore.prf:
1481         * qmake/mkspecs/features/webkit2.prf:
1482
1483 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1484
1485         Unreviewed, rolling out r101107.
1486         http://trac.webkit.org/changeset/101107
1487         https://bugs.webkit.org/show_bug.cgi?id=73062
1488
1489         Breaks the commit-queue (Requested by abarth on #webkit).
1490
1491         * Scripts/webkitpy/common/host.py:
1492         (Host._engage_awesome_windows_hacks):
1493         * Scripts/webkitpy/common/host_mock.py:
1494         (MockHost.__init__):
1495         * Scripts/webkitpy/common/system/environment.py: Removed.
1496         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
1497         * Scripts/webkitpy/common/system/executive.py:
1498         (Executive._run_command_with_teed_output):
1499         (Executive.run_and_throw_if_fail):
1500         * Scripts/webkitpy/common/system/executive_mock.py:
1501         (MockExecutive.run_and_throw_if_fail):
1502         (MockExecutive.run_command):
1503         * Scripts/webkitpy/layout_tests/port/webkit.py:
1504         (WebKitPort._driver_build_script_name):
1505         (WebKitPort._run_script):
1506         (WebKitPort._build_driver):
1507         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1508         (test_build_driver):
1509         * Scripts/webkitpy/tool/commands/download_unittest.py:
1510         * Scripts/webkitpy/tool/steps/build.py:
1511         (Build.build):
1512
1513 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1514
1515         Unreviewed, rolling out r101110.
1516         http://trac.webkit.org/changeset/101110
1517         https://bugs.webkit.org/show_bug.cgi?id=73057
1518
1519         The bots have now cycled and this patch is no longer needed.
1520
1521         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1522         (Manager._upload_json_files):
1523
1524 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1525
1526         Temporarily save the incremental results json in order to identify bug
1527         https://bugs.webkit.org/show_bug.cgi?id=73057
1528
1529         Reviewed by Dean Jackson.
1530
1531         The test results server needed to be rolled back from tip of tree
1532         due to a JSON merging bug. It's hard to identify what the bug is without
1533         the raw data.
1534
1535         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1536         (Manager._upload_json_files):
1537
1538 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1539
1540         Merging two version 4 results hits an error in the test results server
1541         https://bugs.webkit.org/show_bug.cgi?id=73042
1542
1543         Reviewed by Adam Barth.
1544
1545         The old code assumed that if the aggregate results value was not a leaf
1546         value that the incremental results would exist, which is just totally
1547         wrong. Added a test for that case as well.
1548
1549         * TestResultServer/model/jsonresults.py:
1550         (JsonResults._merge_tests):
1551         * TestResultServer/model/jsonresults_unittest.py:
1552         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
1553         (JsonResultsTest.test_merge_build_directory_hierarchy):
1554
1555 2011-11-23  Eric Seidel  <eric@webkit.org>
1556
1557         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1558         https://bugs.webkit.org/show_bug.cgi?id=71983
1559
1560         Reviewed by Adam Barth.
1561
1562         We'll add more code to Environment overtime,
1563         allowing us to mock out more of our direct interactions with os.environ.
1564
1565         This patch also makes run_command print the passed in environment.
1566
1567         * Scripts/webkitpy/common/host_mock.py:
1568         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1569         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1570         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1571         * Scripts/webkitpy/common/system/executive.py:
1572         * Scripts/webkitpy/common/system/executive_mock.py:
1573         * Scripts/webkitpy/layout_tests/port/webkit.py:
1574         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1575         * Scripts/webkitpy/tool/commands/download_unittest.py:
1576         * Scripts/webkitpy/tool/steps/build.py:
1577
1578 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1579
1580         [Qt] Re-generate QtWebKit API forwarding headers when API changes
1581
1582         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
1583         so we need sync.profile to live in the same directory as the project file
1584         that will be touched when adding/removing API (api.pri in our case).
1585
1586         Since the WebKit2 APIs live in a separate static library, we have to
1587         add the project file for WebKit2 as a dependency of the api.pri file
1588         as well, so that any changes to the WebKit2 API will still trigger a
1589         run of qmake (and then syncqt).
1590
1591         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
1592         that the forwarding headers are still generated in the root build dir,
1593         not in the Source dir along with the internal forwarding headers.
1594
1595         Reviewed by Andreas Kling.
1596
1597         * qmake/mkspecs/features/default_pre.prf:
1598         * qmake/mkspecs/features/functions.prf:
1599
1600 2011-11-23  Johnny Ding  <jnd@chromium.org>
1601
1602         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
1603         https://bugs.webkit.org/show_bug.cgi?id=72950
1604
1605         Reviewed by Tony Chang.
1606
1607         * DumpRenderTree/chromium/LayoutTestController.cpp:
1608         (LayoutTestController::queueLoadHTMLString):
1609
1610 2011-11-23  Adam Barth  <abarth@webkit.org>
1611
1612         garden-o-matic should display a message if it can't find results to display
1613         https://bugs.webkit.org/show_bug.cgi?id=72991
1614
1615         Reviewed by Dimitri Glazkov.
1616
1617         Not all failures (e.g., TIMEOUT) have results that we can display.
1618         This patch adds a short message so that the user can see that we're
1619         done trying to load the results.
1620
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1624
1625 2011-11-23  Adam Barth  <abarth@webkit.org>
1626
1627         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
1628         https://bugs.webkit.org/show_bug.cgi?id=72992
1629
1630         Reviewed by Dimitri Glazkov.
1631
1632         This patch also prepares us to list other sorts of failures, like
1633         performance and unit test.
1634
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1639
1640 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
1641
1642         Add new Chromium tests to the flakiness dashboard
1643         https://bugs.webkit.org/show_bug.cgi?id=72997
1644
1645         Reviewed by Ojan Vafai.
1646
1647         * TestResultServer/static-dashboards/dashboard_base.js:
1648         ():
1649
1650 2011-11-23  Adam Barth  <abarth@webkit.org>
1651
1652         garden-o-matic should support AUDIO failures
1653         https://bugs.webkit.org/show_bug.cgi?id=69477
1654
1655         Reviewed by Dimitri Glazkov.
1656
1657         This is a first iteration at supporting AUDIO failures in
1658         garden-o-matic.  We'll probably need to iterate a bit when we have a
1659         real audio failure in the tree to play with.  For example, we'll
1660         probably want to add and <audio> element to the "Examine" view to hear
1661         the differences, but that all can be done in a subsequent patch.
1662
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1664
1665 2011-11-23  Scott Graham  <scottmg@chromium.org>
1666
1667         Adding gamepad support
1668         https://bugs.webkit.org/show_bug.cgi?id=69451
1669
1670         Reviewed by Darin Fisher.
1671
1672         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
1673         gamepad data that will be retrieved when JS code pulls via API access.
1674
1675         * DumpRenderTree/DumpRenderTree.gypi:
1676         * DumpRenderTree/chromium/GamepadController.cpp: Added.
1677         (GamepadController::GamepadController):
1678         (GamepadController::bindToJavascript):
1679         (GamepadController::reset):
1680         (GamepadController::connect):
1681         (GamepadController::disconnect):
1682         (GamepadController::setId):
1683         (GamepadController::setButtonCount):
1684         (GamepadController::setButtonData):
1685         (GamepadController::setAxisCount):
1686         (GamepadController::setAxisData):
1687         (GamepadController::fallbackCallback):
1688         * DumpRenderTree/chromium/GamepadController.h: Added.
1689         * DumpRenderTree/chromium/TestShell.cpp:
1690         (TestShell::TestShell):
1691         (TestShell::resetTestController):
1692         (TestShell::bindJSObjectsToWindow):
1693         * DumpRenderTree/chromium/TestShell.h:
1694         (TestShell::gamepadController):
1695
1696 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1697
1698         [CMake] Move the top-level logic to the top-level directory.
1699         https://bugs.webkit.org/show_bug.cgi?id=72685
1700
1701         Reviewed by Brent Fulgham.
1702
1703         * CMakeLists.txt: Added.
1704         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
1705         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
1706         * Scripts/webkitdirs.pm:
1707         (generateBuildSystemFromCMakeProject):
1708         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
1709
1710 2011-11-17  Vincent Scheib  <scheib@chromium.org>
1711
1712         Pointer Lock: Initial Tests for navigator.webkitPonter
1713         https://bugs.webkit.org/show_bug.cgi?id=72659
1714
1715         Reviewed by Darin Fisher.
1716
1717         * DumpRenderTree/chromium/TestShell.cpp:
1718         (TestShell::TestShell):
1719             Enabling PointerLock in TestShell
1720
1721 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
1722
1723         Update flakiness dashboard for new Chromium builders and tests
1724         https://bugs.webkit.org/show_bug.cgi?id=72931
1725
1726         Reviewed by Ojan Vafai.
1727
1728         * TestResultServer/static-dashboards/builders.js:
1729         * TestResultServer/static-dashboards/dashboard_base.js:
1730
1731 2011-11-22  Adam Roben  <aroben@apple.com>
1732
1733         Remove some debugging code I accidentally left in r101005
1734
1735         * Scripts/prepare-ChangeLog:
1736         (get_function_line_ranges_for_python):
1737
1738 2011-11-22  Adam Roben  <aroben@apple.com>
1739
1740         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
1741
1742         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
1743         classes/methods in Python source files
1744
1745         Reviewed by Dan Bates.
1746
1747         * Scripts/prepare-ChangeLog:
1748         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
1749         or that use python as their interpreter. Modified the code that extracts the interpreter to
1750         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
1751         scripts.
1752         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
1753         for class/def lines and generate ranges based on them.
1754
1755 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
1756
1757         [GTK] Enable WebSocket hybi tests
1758         https://bugs.webkit.org/show_bug.cgi?id=72870
1759
1760         Reviewed by Xan Lopez.
1761
1762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1763         (resetDefaultsToConsistentValues):
1764         Reset the setting value to the default value (true).
1765         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1766         (LayoutTestController::overridePreference):
1767         Change the setting value through a function in DumpRenderTreeSupportGtk.
1768
1769 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
1770
1771         ChangeLogEntry should be able to parse entries with multiple authors
1772         https://bugs.webkit.org/show_bug.cgi?id=72690
1773
1774         Reviewed by Eric Seidel.
1775
1776         Support multi-author change log entries in ChangeLogEntry. Split author names using
1777         the same logic as splitting reviewer names. _authors now stores list of dictionaries
1778         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
1779         accounts because some contributors are never listed in committers.py. 
1780
1781         * Scripts/webkitpy/common/checkout/changelog.py:
1782         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1783         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
1784         throws an exception when the argument is None.
1785
1786 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
1787
1788         [Qt] Speed up debug builds.
1789         https://bugs.webkit.org/show_bug.cgi?id=72882
1790
1791         Reviewed by Tor Arne Vestbø.
1792
1793         Introduce a special type of build that replaces the static jsc/wc/wk2
1794         static libraries with shared libraries, that individually are much faster
1795         to link and don't require relinking into the big library when changing just
1796         one file in one module. It can be enabled with
1797         --qmakearg="CONFIG+=force_static_libs_as_shared"
1798
1799         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
1800         disable symbol visibility, static linkage and enable rpath.
1801         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
1802         we need to link the convenience libraries together or not and renamed linkStaticLibrary
1803         to just linkLibrary (because linkage is not necessarily static).
1804         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
1805         link against jsc/wc/wk2 when linking app code against QtWebKit.
1806         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
1807         function.
1808         * qmake/mkspecs/features/webcore.prf: Ditto.
1809         * qmake/mkspecs/features/webkit2.prf: Ditto.
1810
1811 2011-11-21  Adam Klein  <adamk@chromium.org>
1812
1813         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
1814         https://bugs.webkit.org/show_bug.cgi?id=72898
1815
1816         Reviewed by Ojan Vafai.
1817
1818         Also removed a comment that was going to be more trouble to keep up to
1819         date than seemed worthwhile (the code is now the documentation).
1820
1821         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1822
1823 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1824
1825         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
1826         https://bugs.webkit.org/show_bug.cgi?id=72895
1827
1828         Reviewed by Chris Fleizach.
1829
1830         * DumpRenderTree/chromium/WebViewHost.cpp:
1831         (WebViewHost::postAccessibilityNotification):
1832
1833 2011-11-21  Philippe Normand  <pnormand@igalia.com>
1834
1835         Unreviewed, run-gtk-tests temporary workaround after r98500.
1836
1837         * Scripts/run-gtk-tests: Try to find the build directory like in
1838         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
1839
1840 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [GTK] Add a way to skip unit tests in the bots
1843         https://bugs.webkit.org/show_bug.cgi?id=72879
1844
1845         Reviewed by Philippe Normand.
1846
1847         Rewrite the script in python to make it easier for everybody to
1848         change it and add support for skipping tests.
1849
1850         * Scripts/run-gtk-tests:
1851
1852 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
1853
1854         [EFL] Add more appcache functions to ewk_settings.
1855         https://bugs.webkit.org/show_bug.cgi?id=72143
1856
1857         Reviewed by Kenneth Rohde Christiansen.
1858
1859         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1860         (LayoutTestController::clearAllApplicationCaches):
1861         (LayoutTestController::setAppCacheMaximumSize): Use the right
1862         function, this is not related to the memory cache, but rather to the
1863         appcache.
1864
1865 2011-11-18  Adam Roben  <aroben@apple.com>
1866
1867         Make NRWT consider all lines of output from parse-malloc-history, not just the first
1868
1869         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
1870         found" even when there are more than 1 unique leaks
1871
1872         Reviewed by Darin Adler.
1873
1874         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1875         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
1876         "^" will be considered to match the beginning of any line, not only the beginning of the
1877         string.
1878
1879         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1880         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
1881         fake output and updated expectations to match.
1882
1883 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
1884
1885         [Qt] Clean up MiniBrowser project file after recent changes
1886         https://bugs.webkit.org/show_bug.cgi?id=72869
1887
1888         Reviewed by Simon Hausmann.
1889
1890         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
1891
1892         * MiniBrowser/qt/MiniBrowser.pro:
1893
1894 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1895
1896         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1897         https://bugs.webkit.org/show_bug.cgi?id=72479
1898
1899         Reviewed by Chris Fleizach.
1900
1901         * DumpRenderTree/AccessibilityUIElement.cpp:
1902         (getIsSelectedOptionActiveCallback):
1903         (AccessibilityUIElement::getJSClass):
1904         * DumpRenderTree/AccessibilityUIElement.h:
1905         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1906         (AccessibilityUIElement::AccessibilityUIElement):
1907         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
1908         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1909         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1910         (AccessibilityUIElement::isSelectedOptionActive):
1911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1912         (AccessibilityUIElement::isSelectedOptionActive):
1913         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1914         (AccessibilityUIElement::isSelectedOptionActive):
1915
1916 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
1917
1918         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
1919         https://bugs.webkit.org/show_bug.cgi?id=72859
1920
1921         Reviewed by Eric Seidel.
1922         
1923         * Scripts/new-run-webkit-websocketserver:
1924
1925 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
1926
1927         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
1928         https://bugs.webkit.org/show_bug.cgi?id=72655
1929
1930         Reviewed by Hajime Morita.
1931
1932         Fixed the calculation of offset.
1933
1934         * DumpRenderTree/chromium/WebViewHost.cpp:
1935         (WebViewHost::finishLastTextCheck):
1936
1937 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1938
1939         Change the final place where we use version 3 of the results json output
1940         https://bugs.webkit.org/show_bug.cgi?id=72838
1941
1942         Reviewed by Adam Barth.
1943
1944         This converts the json from being a flat map of test name --> results
1945         to being hierarchical by directory. This will make the json files 
1946         considerably smaller.
1947
1948         Also cleaned up some functions that were returning/checking boolean values
1949         that were always True.
1950
1951         * TestResultServer/model/jsonresults.py:
1952         * TestResultServer/model/jsonresults_unittest.py:
1953
1954 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1955
1956         Include the master name when querying the test results server.
1957         This will soon be required since leaving the master name out mean
1958         that multiple files could match the query.
1959
1960         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1961
1962 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1963
1964         Fix jsonp callback code to add the callback if json content
1965         is not jsonp.
1966         * TestResultServer/handlers/testfilehandler.py:
1967
1968 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
1969
1970         Modify dashboard_base.js to optionally accept version 4 results json.
1971
1972         Reviewed by Ojan Vafai.
1973
1974         * TestResultServer/static-dashboards/dashboard_base.js:
1975         (ADD_RESULTS):
1976         (flattenTrie):
1977         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1978         (testFlattenTrie):
1979
1980 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1981
1982         Stop storing results files as jsonp in the test results server
1983         https://bugs.webkit.org/show_bug.cgi?id=72814
1984
1985         Reviewed by Adam Barth.
1986
1987         * TestResultServer/model/jsonresults.py:
1988         * TestResultServer/model/jsonresults_unittest.py:
1989
1990 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1991
1992         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
1993         https://bugs.webkit.org/show_bug.cgi?id=72813
1994
1995         Reviewed by Adam Barth.
1996
1997         Once this lands, we can start storing pure json in the test results server and then
1998         we can delete the code with all the FIXMEs added here.
1999
2000         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2001         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2002         Only add jsonp for full_results.json.
2003         * TestResultServer/model/jsonresults.py:
2004         * TestResultServer/model/jsonresults_unittest.py:
2005         Accept pure json uploads.
2006         * TestResultServer/static-dashboards/dashboard_base.js:
2007         (appendJSONScriptElementFor):
2008         Use the callback parameter so that the server can start returning pure json if it's left out.
2009
2010 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2011
2012         Allow json NRWT downloads to be pure json and not jsonp
2013         https://bugs.webkit.org/show_bug.cgi?id=72809
2014
2015         Reviewed by Adam Barth.
2016
2017         I'm moving the server to storing and serving up raw json instead of jsonp.
2018         You can still get the jsonp by passing a "callback" parameter, but there's no
2019         need for run-webkit-tests to get jsonp when all it wants is the raw json.
2020
2021         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2022         Make the wrapper stripping only happen if the json is actually wrapped.
2023         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2024
2025 2011-11-18  Daniel Bates  <dbates@rim.com>
2026
2027         Add CMake build infrastructure for the BlackBerry port
2028         https://bugs.webkit.org/show_bug.cgi?id=72768
2029
2030         Reviewed by Antonio Gomes.
2031
2032         Add optional --blackberry command line argument to build-webkit to build the
2033         BlackBerry port.
2034
2035         * Scripts/build-webkit:
2036         * Scripts/webkitdirs.pm:
2037         (determineBaseProductDir):
2038         (argumentsForConfiguration):
2039         (builtDylibPathForName):
2040         (determineIsQt):
2041         (isBlackBerry): Added.
2042         (determineIsBlackBerry): Added.
2043         (blackberryTargetArchitecture): Added.
2044         (isAppleWebKit):
2045
2046 2011-11-18  James Robinson  <jamesr@chromium.org>
2047
2048         Unreviewed, rolling out r100835.
2049         http://trac.webkit.org/changeset/100835
2050         https://bugs.webkit.org/show_bug.cgi?id=72778
2051
2052         Broke some page scale tests
2053
2054         * DumpRenderTree/chromium/EventSender.cpp:
2055         (EventSender::scalePageBy):
2056
2057 2011-11-18  Adam Barth  <abarth@webkit.org>
2058
2059         Prepare to move manual-tests out of WebCore
2060         https://bugs.webkit.org/show_bug.cgi?id=72782
2061
2062         Reviewed by Eric Seidel.
2063
2064         Update this file to refer to the new location of ManualTests.
2065
2066         * Scripts/webkitpy/common/config/build.py:
2067
2068 2011-11-18  James Robinson  <jamesr@chromium.org>
2069
2070         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
2071         https://bugs.webkit.org/show_bug.cgi?id=72778
2072
2073         Reviewed by Kenneth Russell.
2074
2075         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
2076
2077         * DumpRenderTree/chromium/EventSender.cpp:
2078         (EventSender::scalePageBy):
2079
2080 2011-11-18  Scott Graham  <scottmg@chromium.org>
2081
2082         IDL changes for gamepad support
2083         https://bugs.webkit.org/show_bug.cgi?id=71753
2084
2085         Reviewed by Adam Barth.
2086
2087         Runtime enable gamepad in chromium test shell.
2088
2089         * DumpRenderTree/chromium/TestShell.cpp:
2090         (TestShell::TestShell):
2091
2092 2011-10-27  Darin Fisher  <darin@chromium.org>
2093
2094         [chromium] Improve fullscreen API
2095         https://bugs.webkit.org/show_bug.cgi?id=70477
2096
2097         Reviewed by Adam Barth.
2098
2099         Implement enter/exitFullScreen.  The implementation is asynchronous,
2100         via postDelayedTask, to simulate how the browser actually behaves.
2101
2102         * DumpRenderTree/chromium/WebViewHost.cpp:
2103         (WebViewHost::enterFullScreen):
2104         (WebViewHost::exitFullScreen):
2105         (WebViewHost::setAddressBarURL):
2106         (WebViewHost::enterFullScreenNow):
2107         (WebViewHost::exitFullScreenNow):
2108         * DumpRenderTree/chromium/WebViewHost.h:
2109
2110 2011-11-18  Adam Roben  <aroben@apple.com>
2111
2112         Ignore an ANGLE leak that is not WebKit's fault
2113
2114         * Scripts/old-run-webkit-tests:
2115         (countAndPrintLeaks):
2116         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2117         (LeakDetector._callstacks_to_exclude_from_leaks):
2118         Added ScanFromString to the call stacks to exclude on all OS versions.
2119
2120 2011-11-18  Adam Roben  <aroben@apple.com>
2121
2122         Ignore another Lion-specific leak that is not WebKit's fault
2123
2124         * Scripts/old-run-webkit-tests:
2125         (countAndPrintLeaks):
2126         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2127         (LeakDetector._callstacks_to_exclude_from_leaks):
2128         Added SecTransformExecute to the call stacks to exclude.
2129
2130 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
2131
2132         [Qt] Enable WebSocket hybi tests
2133         https://bugs.webkit.org/show_bug.cgi?id=72687
2134
2135         Reviewed by Simon Hausmann.
2136
2137         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
2138
2139         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2140         (WebCore::WebPage::resetSettings):
2141         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2142         (LayoutTestController::overridePreference):
2143
2144 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
2145
2146         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
2147         https://bugs.webkit.org/show_bug.cgi?id=72707
2148
2149         Reviewed by Philippe Normand.
2150
2151         Make new-run-webkit-tests use the right path to locate the test
2152         plugin used by WebKitTestRunner.
2153
2154         * Scripts/webkitpy/layout_tests/port/gtk.py:
2155
2156 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
2157
2158         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
2159         https://bugs.webkit.org/show_bug.cgi?id=72697
2160
2161         Reviewed by Kenneth Rohde Christiansen.
2162
2163         * Tools.pro: Make WTR linux only for the moment.
2164         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
2165         * WebKitTestRunner/Target.pri: Ditto.
2166         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
2167         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
2168
2169 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2170
2171         [Qt] Change default size of the MiniBrowser
2172
2173         Reviewed by Simon Hausmann.
2174
2175         As we lay out desktop pages using the width of 980, change our default
2176         size to 980x735 so that we are not scaling down by default.
2177
2178         * MiniBrowser/qt/MiniBrowserApplication.h:
2179         (WindowOptions::WindowOptions):
2180
2181 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2182
2183         [EFL] Clean up the use of DATA_DIR in the buildsystem
2184         https://bugs.webkit.org/show_bug.cgi?id=72681
2185
2186         Reviewed by Daniel Bates.
2187
2188         Instead of adding -DDATA_DIR in all scopes, only define it in
2189         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
2190         it.
2191
2192         We can then define DATA_DIR to the generated theme directory for
2193         EWebLauncher, since it's what we want here.
2194
2195         * CMakeListsEfl.txt:
2196
2197 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2198
2199         [EFL] Move platform includes last in DRT's include directories.
2200         https://bugs.webkit.org/show_bug.cgi?id=72684
2201
2202         Reviewed by Daniel Bates.
2203
2204         This is the first step in fixing the build when a platform include (in
2205         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
2206         is included instead of WebKit's.
2207
2208         * DumpRenderTree/efl/CMakeLists.txt:
2209
2210 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
2211
2212         fuzzy_match doesn't recognize "Dan B" or "hyatt"
2213         https://bugs.webkit.org/show_bug.cgi?id=72636
2214
2215         Reviewed by Eric Seidel.
2216
2217         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
2218         and user names of email addreses such as rniwa in rniwa@webkit.org.
2219
2220         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
2221
2222         * Scripts/webkitpy/common/config/committers.py:
2223         * Scripts/webkitpy/common/config/committers_unittest.py:
2224
2225 2011-11-17  Eric Seidel  <eric@webkit.org>
2226
2227         Remove support for running check-webkit-style w/o a webkit checkout
2228         https://bugs.webkit.org/show_bug.cgi?id=72678
2229
2230         Reviewed by Adam Barth.
2231
2232         After talking to Dave Levin we've decided to remove this
2233         code.  I know of no users of check-webkit-style w/o a webkit checkout
2234         and this needlessly adds complexity.
2235
2236         * Scripts/webkitpy/style/main.py:
2237
2238 2011-11-17  Eric Seidel  <eric@webkit.org>
2239
2240         Remove more direct uses of os.path
2241         https://bugs.webkit.org/show_bug.cgi?id=72677
2242
2243         Reviewed by Adam Barth.
2244
2245         Remove more uses of os.path, including refactoring
2246         CommitterValidator to use a Host object instead of
2247         manual hacks to emulate what SCM and FileSystem provide.
2248
2249         * Scripts/webkitpy/common/checkout/changelog.py:
2250         * Scripts/webkitpy/common/config/committervalidator.py:
2251         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2252         * Scripts/webkitpy/common/system/filesystem_mock.py:
2253          - Turns out none of our unittests actually looked at this path.
2254            now I've made it be a valid path.
2255         * Scripts/webkitpy/tool/bot/feeders.py:
2256         * Scripts/webkitpy/tool/commands/queues.py:
2257
2258 2011-11-17  Eric Seidel  <eric@webkit.org>
2259
2260         Teach TextFileReader about FileSystem
2261         https://bugs.webkit.org/show_bug.cgi?id=72673
2262
2263         Reviewed by Adam Barth.
2264
2265         Unfortunately TextFileReader doesn't use FileSystem
2266         everywhere yet, so we can't move the unittests to
2267         using MockFileSystem, but we're close.
2268
2269         * Scripts/webkitpy/style/filereader.py:
2270         * Scripts/webkitpy/style/filereader_unittest.py:
2271         * Scripts/webkitpy/style/main.py:
2272
2273 2011-11-17  Eric Seidel  <eric@webkit.org>
2274
2275         Give check-webkit-style a Host
2276         https://bugs.webkit.org/show_bug.cgi?id=72670
2277
2278         Reviewed by Adam Barth.
2279
2280         * Scripts/webkitpy/common/checkout/scm/detection.py:
2281         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2282          - We don't run these unittests, but this one was looking for the wrong exception.
2283         * Scripts/webkitpy/style/main.py:
2284         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2285          - This was create a new scm object even though it already had one?
2286
2287 2011-11-17  Eric Seidel  <eric@webkit.org>
2288
2289         Move check-webkit-style change_directory code to more modern mocks
2290         https://bugs.webkit.org/show_bug.cgi?id=72664
2291
2292         Reviewed by Adam Barth.
2293
2294         * Scripts/check-webkit-style:
2295         * Scripts/webkitpy/style/main.py:
2296         * Scripts/webkitpy/style/main_unittest.py:
2297
2298 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
2299
2300         [GTK] enable ref tests
2301         https://bugs.webkit.org/show_bug.cgi?id=72601
2302
2303         Re-enable ref tests. Run the driver under evenly numbered display if performing
2304         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
2305         being run in an already used Xvfb instance if pixel tests are disabled.
2306
2307         Reviewed by Tony Chang.
2308
2309         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
2310         after the process is killed
2311
2312 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2313
2314         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
2315         https://bugs.webkit.org/show_bug.cgi?id=72620
2316
2317         Reviewed by David Levin.
2318
2319         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
2320         adding the suffix the cpp file. One example of false positive
2321         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
2322
2323         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
2324         basename contains the cpp's basename.
2325         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2326
2327 2011-11-17  Eric Seidel  <eric@webkit.org>
2328
2329         Move check-webkit-style's guts into webkitpy/style/main.py
2330         https://bugs.webkit.org/show_bug.cgi?id=72657
2331
2332         Reviewed by Adam Barth.
2333
2334         * Scripts/check-webkit-style:
2335         * Scripts/webkitpy/style/main.py:
2336
2337 2011-11-17  Eric Seidel  <eric@webkit.org>
2338
2339         new-run-webkit-tests is locale dependent
2340         https://bugs.webkit.org/show_bug.cgi?id=68691
2341
2342         Reviewed by Adam Barth.
2343
2344         Make NRWT use a clean environment, just like ORWT did.
2345
2346         * Scripts/webkitpy/layout_tests/port/base.py:
2347         * Scripts/webkitpy/layout_tests/port/chromium.py:
2348         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2349         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2350         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2351         * Scripts/webkitpy/layout_tests/port/efl.py:
2352         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2353         * Scripts/webkitpy/layout_tests/port/mac.py:
2354         * Scripts/webkitpy/layout_tests/port/qt.py:
2355         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2356         * Scripts/webkitpy/layout_tests/port/webkit.py:
2357         * Scripts/webkitpy/layout_tests/port/win.py:
2358
2359 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
2360
2361         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
2362         https://bugs.webkit.org/show_bug.cgi?id=72615
2363
2364         Reviewed by James Robinson.
2365
2366         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2367
2368 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
2369
2370         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
2371         https://bugs.webkit.org/show_bug.cgi?id=72595
2372
2373         Reviewed by Noam Rosenthal.
2374
2375         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2376         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
2377         ensure the registration of the DRTNode JS bindings.
2378         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2379         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
2380         registration of QWebElement (now done implicitly through QWebPage ->
2381         QtWebElementRunTime::initialize code path)
2382
2383 2011-11-17  Adam Roben  <aroben@apple.com>
2384
2385         Fix a crash-inducing typo I introduced in r100648
2386
2387         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
2388         handling a crashing test
2389
2390         Reviewed by Adam Barth.
2391
2392         * Scripts/webkitpy/layout_tests/port/chromium.py:
2393         (ChromiumDriver.run_test): Get the driver name from the port.
2394
2395         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2396         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
2397         right crashed process name.
2398
2399 2011-11-17  Adam Roben  <aroben@apple.com>
2400
2401         Fix NRWT's parsing of the number of excluded leaks
2402
2403         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
2404         leaks were excluded
2405
2406         Reviewed by Adam Barth.
2407
2408         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2409         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
2410         regular expression match, not the entire matched string.
2411
2412         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2413         (LeakDetectorTest): Added some example output that shows how things look when leaks are
2414         excluded.
2415         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
2416         correctly.
2417
2418 2011-11-17  Adam Roben  <aroben@apple.com>
2419
2420         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
2421
2422         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
2423         when web process crashes, but WebProcess crash log should get saved instead
2424
2425         Reviewed by Eric Seidel.
2426
2427         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2428         (write_test_result): Simplified a little to share more code between the case where we
2429         crashed when running the test and where we crashed when checking the expected rendering for
2430         a reftest. Changed to pass the crashed process name down to write_crash_report.
2431         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
2432         along to CrashLogs.find_newest_log rather than always using the driver name.
2433
2434         * Scripts/webkitpy/layout_tests/port/chromium.py:
2435         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
2436         crashed.
2437
2438         * Scripts/webkitpy/layout_tests/port/test.py:
2439         (TestInstance.__init__): Initialize new web_process_crash attribute.
2440         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
2441         test this patch adds.
2442         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
2443         specifies that the driver crashed or the web process crashed.
2444
2445         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2446         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
2447         which we pretend the web process crashed rather than the driver process.
2448
2449         (MainTest.test_run_singly_actually_runs_tests):
2450         (MainTest.test_unexpected_failures):
2451         (EndToEndTest.test_end_to_end):
2452         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
2453
2454 2011-11-17  Tony Chang  <tony@chromium.org>
2455
2456         [chromium] stop spamming features warning on every build
2457         https://bugs.webkit.org/show_bug.cgi?id=72629
2458
2459         Reviewed by Ojan Vafai.
2460
2461         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
2462         $mediaStreamSupport is on by default for chromium, make the default
2463         for $blobSupport also on.
2464
2465         * Scripts/build-webkit:
2466
2467 2011-11-17  Adam Roben  <aroben@apple.com>
2468
2469         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
2470
2471         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
2472         that are supposed to be ignored
2473
2474         Reviewed by Adam Barth.
2475
2476         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2477         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
2478         required when passing arguments via the shell (which we aren't doing here). It is not
2479         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
2480
2481         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2482         (LeakDetectorTest.test_leaks_args): Updated expectations.
2483
2484 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2485
2486         Unreviewed, run-bindings-tests fix after r91028.
2487
2488         * Scripts/run-bindings-tests: Use scm.detection module.
2489
2490 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
2491
2492         Silence a warning about control reaching the end of a non-void function
2493         https://bugs.webkit.org/show_bug.cgi?id=72616
2494
2495         Reviewed by Tony Gentilcore.
2496
2497         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2498         (AccessibilityUIElement::verticalScrollbar):
2499
2500 2011-11-17  Adam Roben  <aroben@apple.com>
2501
2502         Ignore some leaks in frameworks we link against on Lion
2503
2504         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
2505         aren't WebKit's fault
2506
2507         Reviewed by Antti Koivisto.
2508
2509         * Scripts/old-run-webkit-tests:
2510         (countAndPrintLeaks):
2511         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2512         (LeakDetector._callstacks_to_exclude_from_leaks):
2513         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
2514
2515         * Scripts/webkitpy/layout_tests/port/mac.py:
2516         (MacPort.is_lion): Added.
2517
2518         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2519         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
2520         methods.
2521
2522 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2523
2524         [GTK] Disable ref tests
2525         https://bugs.webkit.org/show_bug.cgi?id=72599
2526
2527         Reviewed by Xan Lopez.
2528
2529         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
2530         tests to avoid massive flakiness.
2531
2532 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2533
2534         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
2535
2536         A new extension object has been added to QQuickWebView (the same approach should be used
2537         for other API classes that need experimental APIs). The QML extension mechanism is then
2538         built on top of the experimental object.
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=72522
2541
2542         Reviewed by Simon Hausmann.
2543
2544         * MiniBrowser/qt/BrowserWindow.cpp:
2545         (BrowserWindow::BrowserWindow):
2546         (BrowserWindow::webView):
2547         * MiniBrowser/qt/BrowserWindow.h:
2548         * MiniBrowser/qt/UrlLoader.cpp:
2549         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2550         * qmake/mkspecs/features/default_post.prf:
2551         * qmake/mkspecs/features/default_pre.prf:
2552         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
2553         * qmake/mkspecs/features/qtwebkit.prf:
2554
2555 2011-11-17  Adam Barth  <abarth@webkit.org>
2556
2557         Move test_results_uploader.py out of layout_package
2558         https://bugs.webkit.org/show_bug.cgi?id=72590
2559
2560         Reviewed by Eric Seidel.
2561
2562         Most of the lines of code in this file are wrong, but I've restrained
2563         myself and only changed a few of them to generalized this class to the
2564         common package.
2565
2566         This is part of a series of patches to remove layout_package.
2567
2568         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
2569         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2570         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
2571
2572 2011-11-17  Adam Barth  <abarth@webkit.org>
2573
2574         Unreviewed. Fix style nits in printing.py.
2575
2576         * Scripts/webkitpy/layout_tests/views/printing.py:
2577
2578 2011-11-17  Adam Barth  <abarth@webkit.org>
2579
2580         Minor style nits in run_webkit_tests.py
2581         https://bugs.webkit.org/show_bug.cgi?id=72583
2582
2583         Reviewed by Eric Seidel.
2584
2585         This patch just fixes some minor style issues as I work my way back
2586         into this code.
2587
2588         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2589
2590 2011-11-17  Adam Barth  <abarth@webkit.org>
2591
2592         Move test_result_writer out of layout_package
2593         https://bugs.webkit.org/show_bug.cgi?id=72586
2594
2595         Rubber-stamped by Eric Seidel.
2596
2597         This is part of a series of patches to remove layout_package.
2598
2599         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2600         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
2601         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
2602         * Scripts/webkitpy/tool/commands/rebaseline.py:
2603
2604 2011-11-17  Adam Barth  <abarth@webkit.org>
2605
2606         svn-apply shouldn't magically move files into Source anymore
2607         https://bugs.webkit.org/show_bug.cgi?id=72579
2608
2609         Reviewed by Eric Seidel.
2610
2611         The Source directory has existed for long enough that we don't need
2612         svn-apply to magically re-write old-style patches anymore.
2613
2614         * Scripts/VCSUtils.pm:
2615         (parseGitDiffHeader):
2616         (parseSvnDiffHeader):
2617
2618 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2619
2620         Add a list of contribution areas
2621         https://bugs.webkit.org/show_bug.cgi?id=72566
2622
2623         Reviewed by Eric Seidel.
2624
2625         Added ContributionAreas class.
2626
2627         * Scripts/webkitpy/common/config/contributionareas.py: Added.
2628         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
2629
2630 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2631
2632         Refactor ChangeLogTest.test_parse_reviewer_text
2633         https://bugs.webkit.org/show_bug.cgi?id=72572
2634
2635         Reviewed by Eric Seidel.
2636
2637         Refactored the test code by introduing two helper functions.
2638
2639         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2640
2641 2011-11-16  Eric Seidel  <eric@webkit.org>
2642
2643         Add SCMDetector object to make scm detection mockable
2644         https://bugs.webkit.org/show_bug.cgi?id=72247
2645
2646         Reviewed by Adam Barth.
2647
2648         I think SCM detection may eventually be rolled into Checkout,
2649         but this patch at least makes it possible to mock code-paths
2650         which rely on scm detection.
2651         In the process of replacing callers of these free-functions
2652         I found that one of the functions was no longer used,
2653         and that one of the callers could instead just use the SCM
2654         object it already had access to through port.host.scm().
2655         I also discovered that I was not calling Host._initialize_scm()
2656         and thus host.scm() was always returning None!
2657
2658         * Scripts/check-webkit-style:
2659         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2660         * Scripts/webkitpy/common/checkout/deps.py:
2661         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2662         * Scripts/webkitpy/common/checkout/scm/detection.py:
2663         * Scripts/webkitpy/common/checkout/scm/git.py:
2664         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2665         * Scripts/webkitpy/common/checkout/scm/svn.py:
2666         * Scripts/webkitpy/common/host.py:
2667         * Scripts/webkitpy/common/host_mock.py:
2668         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2669         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2670         * Scripts/webkitpy/layout_tests/port/base.py:
2671         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2673         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2674         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2675
2676 2011-11-16  Mark Rowe  <mrowe@apple.com>
2677
2678         Fix the build.
2679
2680         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
2681         Apply the workaround that we use in other projects to WebKitTestRunner.
2682
2683         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
2684         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2685         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
2686
2687 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2688
2689         [Qt] Fix build after WTR AX support
2690         https://bugs.webkit.org/show_bug.cgi?id=72560
2691
2692         Reviewed by Geoffrey Garen.
2693
2694         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2695         * WebKitTestRunner/InjectedBundle/Target.pri:
2696
2697 2011-11-16  Tony Chang  <tony@chromium.org>
2698
2699         repurpose the flexbox bot for grid layout
2700         https://bugs.webkit.org/show_bug.cgi?id=72557
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         Since new flexbox is enabled everywhere, we don't need this bot
2705         anymore.  However, work on grid layout has begun, so we can use this
2706         bot to compile with ENABLE_CSS_GRID_LAYOUT.
2707
2708         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
2709         the bot on the waterfall, I will change the slave config to enable
2710         the compile flag and tests.
2711
2712 2011-11-11  Adrienne Walker  <enne@google.com>
2713
2714         [chromium] Expose mock scrollbars to window.internals
2715         https://bugs.webkit.org/show_bug.cgi?id=72195
2716
2717         Reviewed by James Robinson.
2718
2719         Because mock scrollbars are a global setting, reset between runs.
2720
2721         * DumpRenderTree/chromium/WebPreferences.cpp:
2722         (WebPreferences::applyTo):
2723
2724 2011-11-16  James Robinson  <jamesr@chromium.org>
2725
2726         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
2727         https://bugs.webkit.org/show_bug.cgi?id=72562
2728
2729         Reviewed by Dirk Pranke.
2730
2731         * DumpRenderTree/chromium/TestShell.cpp:
2732         (TestShell::runFileTest):
2733
2734 2011-11-16  Tony Chang  <tony@chromium.org>
2735
2736         [NRWT] speculative fix for multiple subprocess test on cygwin
2737         https://bugs.webkit.org/show_bug.cgi?id=72518
2738
2739         Reviewed by Adam Barth.
2740
2741         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
2742             tries to emulate posix fd behavior.
2743         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2744
2745 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2746
2747         Revert r100509; change was committed twice (first time as r100491).
2748         Unreviewed, build fix.
2749
2750         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2751
2752 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2753
2754         Run a dummy test in the gpu configurations if there's nothing to do.
2755         https://bugs.webkit.org/show_bug.cgi?id=72498
2756
2757         Reviewed by James Robinson.
2758
2759         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2760
2761 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         contributors_by_fuzzy_match is super slow
2764         https://bugs.webkit.org/show_bug.cgi?id=72540
2765
2766         Reviewed by Eric Seidel.
2767
2768         Make contributors_by_name do case insensitive search using a dictionary.
2769
2770         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
2771         because that's the most common case.
2772
2773         * Scripts/webkitpy/common/config/committers.py:
2774         * Scripts/webkitpy/common/config/committers_unittest.py:
2775
2776 2011-11-16  David Levin  <levin@chromium.org>
2777
2778         check-webkit-style should recognize functions even if they have OVERRIDE after them.
2779         https://bugs.webkit.org/show_bug.cgi?id=72515
2780
2781         Reviewed by Adam Barth.
2782
2783         * Scripts/webkitpy/style/checkers/cpp.py:
2784         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2785
2786 2011-11-16  Tony Chang  <tony@chromium.org>
2787
2788         [NRWT] refactor drivers to require pixel_tests param
2789         https://bugs.webkit.org/show_bug.cgi?id=72517
2790
2791         Reviewed by Ojan Vafai.
2792
2793         No tests, just a refactoring.
2794
2795         * Scripts/webkitpy/layout_tests/port/chromium.py:
2796         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2797         * Scripts/webkitpy/layout_tests/port/webkit.py:
2798         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2799
2800 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2801
2802         Run a dummy test in the gpu configurations if there's nothing to do.
2803         https://bugs.webkit.org/show_bug.cgi?id=72498
2804
2805         Reviewed by James Robinson.
2806
2807         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2808
2809 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
2810
2811         WebKitTestRunner needs to support accessibility-related DRT APIs
2812         https://bugs.webkit.org/show_bug.cgi?id=42131
2813
2814         Reviewed by Beth Dakin.
2815
2816         Port the AX code in DRT to WKTestRunner by using IDL.
2817
2818         * DumpRenderTree/AccessibilityUIElement.cpp:
2819         (horizontalScrollbarCallback):
2820         (verticalScrollbarCallback):
2821         (AccessibilityUIElement::horizontalScrollbar):
2822         (AccessibilityUIElement::verticalScrollbar):
2823         (AccessibilityUIElement::getJSClass):
2824         * DumpRenderTree/AccessibilityUIElement.h:
2825         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2826         (AccessibilityUIElement::horizontalScrollbar):
2827         (AccessibilityUIElement::verticalScrollbar):
2828         * WebKitTestRunner/DerivedSources.make:
2829         * WebKitTestRunner/GNUmakefile.am:
2830         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
2831         (WTR::AccessibilityController::create):
2832         (WTR::AccessibilityController::AccessibilityController):
2833         (WTR::AccessibilityController::~AccessibilityController):
2834         (WTR::AccessibilityController::makeWindowObject):
2835         (WTR::AccessibilityController::wrapperClass):
2836         (WTR::AccessibilityController::rootElement):
2837         (WTR::AccessibilityController::focusedElement):
2838         (WTR::AccessibilityController::elementAtPoint):
2839         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
2840         (WTR::AccessibilityController::logFocusEvents):
2841         (WTR::AccessibilityController::logValueChangeEvents):
2842         (WTR::AccessibilityController::logScrollingStartEvents):
2843         (WTR::AccessibilityController::logAccessibilityEvents):
2844         (WTR::AccessibilityController::addNotificationListener):
2845         (WTR::AccessibilityController::notificationReceived):
2846         (WTR::AccessibilityController::resetToConsistentState):
2847         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
2848         (WTR::AccessibilityTextMarker::create):
2849         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2850         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
2851         (WTR::AccessibilityTextMarker::platformTextMarker):
2852         (WTR::AccessibilityTextMarker::wrapperClass):
2853         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
2854         (WTR::AccessibilityTextMarker::isEqual):
2855         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
2856         (WTR::AccessibilityTextMarkerRange::create):
2857         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2858         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2859         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
2860         (WTR::AccessibilityTextMarkerRange::wrapperClass):
2861         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
2862         (WTR::AccessibilityTextMarkerRange::isEqual):
2863         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
2864         (WTR::AccessibilityUIElement::create):
2865         (WTR::AccessibilityUIElement::wrapperClass):
2866         (WTR::AccessibilityUIElement::isValid):
2867         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2868         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2869         (WTR::AccessibilityUIElement::isEqual):
2870         (WTR::AccessibilityUIElement::elementAtPoint):
2871         (WTR::AccessibilityUIElement::childAtIndex):
2872         (WTR::AccessibilityUIElement::indexOfChild):
2873         (WTR::AccessibilityUIElement::childrenCount):
2874         (WTR::AccessibilityUIElement::titleUIElement):
2875         (WTR::AccessibilityUIElement::parentElement):
2876         (WTR::AccessibilityUIElement::takeFocus):
2877         (WTR::AccessibilityUIElement::takeSelection):
2878         (WTR::AccessibilityUIElement::addSelection):
2879         (WTR::AccessibilityUIElement::removeSelection):
2880         (WTR::AccessibilityUIElement::allAttributes):
2881         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2882         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2883         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2884         (WTR::AccessibilityUIElement::attributesOfChildren):
2885         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2886         (WTR::AccessibilityUIElement::increment):
2887         (WTR::AccessibilityUIElement::decrement):
2888         (WTR::AccessibilityUIElement::showMenu):
2889         (WTR::AccessibilityUIElement::press):
2890         (WTR::AccessibilityUIElement::stringAttributeValue):
2891         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2892         (WTR::AccessibilityUIElement::numberAttributeValue):
2893         (WTR::AccessibilityUIElement::boolAttributeValue):
2894         (WTR::AccessibilityUIElement::isAttributeSupported):
2895         (WTR::AccessibilityUIElement::isAttributeSettable):
2896         (WTR::AccessibilityUIElement::isActionSupported):
2897         (WTR::AccessibilityUIElement::role):
2898         (WTR::AccessibilityUIElement::subrole):
2899         (WTR::AccessibilityUIElement::roleDescription):
2900         (WTR::AccessibilityUIElement::title):
2901         (WTR::AccessibilityUIElement::description):
2902         (WTR::AccessibilityUIElement::language):
2903         (WTR::AccessibilityUIElement::stringValue):
2904         (WTR::AccessibilityUIElement::accessibilityValue):
2905         (WTR::AccessibilityUIElement::helpText):
2906         (WTR::AccessibilityUIElement::orientation):
2907         (WTR::AccessibilityUIElement::x):
2908         (WTR::AccessibilityUIElement::y):
2909         (WTR::AccessibilityUIElement::width):
2910         (WTR::AccessibilityUIElement::height):
2911         (WTR::AccessibilityUIElement::intValue):
2912         (WTR::AccessibilityUIElement::minValue):
2913         (WTR::AccessibilityUIElement::maxValue):
2914         (WTR::AccessibilityUIElement::valueDescription):
2915         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2916         (WTR::AccessibilityUIElement::selectedTextRange):
2917         (WTR::AccessibilityUIElement::isEnabled):
2918         (WTR::AccessibilityUIElement::isRequired):
2919         (WTR::AccessibilityUIElement::isFocused):
2920         (WTR::AccessibilityUIElement::isFocusable):
2921         (WTR::AccessibilityUIElement::isSelected):
2922         (WTR::AccessibilityUIElement::isSelectable):
2923         (WTR::AccessibilityUIElement::isMultiSelectable):
2924         (WTR::AccessibilityUIElement::setSelectedChild):
2925         (WTR::AccessibilityUIElement::selectedChildrenCount):
2926         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2927         (WTR::AccessibilityUIElement::isExpanded):
2928         (WTR::AccessibilityUIElement::isChecked):
2929         (WTR::AccessibilityUIElement::isVisible):
2930         (WTR::AccessibilityUIElement::isOffScreen):
2931         (WTR::AccessibilityUIElement::isCollapsed):
2932         (WTR::AccessibilityUIElement::isIgnored):
2933         (WTR::AccessibilityUIElement::hasPopup):
2934         (WTR::AccessibilityUIElement::hierarchicalLevel):
2935         (WTR::AccessibilityUIElement::clickPointX):
2936         (WTR::AccessibilityUIElement::clickPointY):
2937         (WTR::AccessibilityUIElement::documentEncoding):
2938         (WTR::AccessibilityUIElement::documentURI):
2939         (WTR::AccessibilityUIElement::url):
2940         (WTR::AccessibilityUIElement::speak):
2941         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2942         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2943         (WTR::AccessibilityUIElement::attributesOfColumns):
2944         (WTR::AccessibilityUIElement::attributesOfRows):
2945         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2946         (WTR::AccessibilityUIElement::attributesOfHeader):
2947         (WTR::AccessibilityUIElement::indexInTable):
2948         (WTR::AccessibilityUIElement::rowIndexRange):
2949         (WTR::AccessibilityUIElement::columnIndexRange):
2950         (WTR::AccessibilityUIElement::rowCount):
2951         (WTR::AccessibilityUIElement::columnCount):
2952         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2953         (WTR::AccessibilityUIElement::disclosedByRow):
2954         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2955         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2956         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2957         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2958         (WTR::AccessibilityUIElement::ariaDropEffects):
2959         (WTR::AccessibilityUIElement::lineForIndex):
2960         (WTR::AccessibilityUIElement::rangeForLine):
2961         (WTR::AccessibilityUIElement::boundsForRange):
2962         (WTR::AccessibilityUIElement::setSelectedTextRange):
2963         (WTR::AccessibilityUIElement::stringForRange):
2964         (WTR::AccessibilityUIElement::attributedStringForRange):
2965         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2966         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2967         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2968         (WTR::AccessibilityUIElement::horizontalScrollbar):
2969         (WTR::AccessibilityUIElement::verticalScrollbar):
2970         (WTR::AccessibilityUIElement::addNotificationListener):
2971         (WTR::AccessibilityUIElement::removeNotificationListener):
2972         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2973         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2974         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2975         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2976         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2977         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2978         (WTR::AccessibilityUIElement::textMarkerForPoint):
2979         (WTR::AccessibilityUIElement::previousTextMarker):
2980         (WTR::AccessibilityUIElement::nextTextMarker):
2981         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2982         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
2983         (WTR::AccessibilityUIElement::platformUIElement):
2984         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
2985         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
2986         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
2987         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
2988         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2989         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2990         (WTR::InjectedBundle::beginTesting):
2991         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2992         (WTR::InjectedBundle::accessibilityController):
2993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2994         (WTR::InjectedBundlePage::didClearWindowForFrame):
2995         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2996         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
2997         (WTR::LayoutTestController::platformName):
2998         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
2999         (WTR::AccessibilityTextMarker::isEqual):
3000         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
3001         (WTR::AccessibilityTextMarkerRange::isEqual):
3002         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
3003         (+[NSString stringWithJSStringRef:]):
3004         (-[NSString createJSStringRef]):
3005         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
3006         (-[AccessibilityNotificationHandler dealloc]):
3007         (-[AccessibilityNotificationHandler _notificationReceived:]):
3008         (-[AccessibilityNotificationHandler setCallback:]):
3009         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3010         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
3011         (WTR::AccessibilityUIElement::isEqual):
3012         (WTR::descriptionOfValue):
3013         (WTR::attributesOfElement):
3014         (WTR::concatenateAttributeAndValue):
3015         (WTR::convertNSArrayToVector):
3016         (WTR::descriptionOfElements):
3017         (WTR::AccessibilityUIElement::getLinkedUIElements):
3018         (WTR::AccessibilityUIElement::getDocumentLinks):
3019         (WTR::AccessibilityUIElement::getChildren):
3020         (WTR::AccessibilityUIElement::getChildrenWithRange):
3021         (WTR::AccessibilityUIElement::childrenCount):
3022         (WTR::AccessibilityUIElement::elementAtPoint):
3023         (WTR::AccessibilityUIElement::indexOfChild):
3024         (WTR::AccessibilityUIElement::childAtIndex):
3025         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3026         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3027         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3028         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3029         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3030         (WTR::AccessibilityUIElement::selectedChildrenCount):
3031         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3032         (WTR::AccessibilityUIElement::titleUIElement):
3033         (WTR::AccessibilityUIElement::parentElement):
3034         (WTR::AccessibilityUIElement::disclosedByRow):
3035         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
3036         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
3037         (WTR::AccessibilityUIElement::attributesOfChildren):
3038         (WTR::AccessibilityUIElement::allAttributes):
3039         (WTR::AccessibilityUIElement::stringAttributeValue):
3040         (WTR::AccessibilityUIElement::numberAttributeValue):
3041         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3042         (WTR::AccessibilityUIElement::boolAttributeValue):
3043         (WTR::AccessibilityUIElement::isAttributeSettable):
3044         (WTR::AccessibilityUIElement::isAttributeSupported):
3045         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
3046         (WTR::AccessibilityUIElement::role):
3047         (WTR::AccessibilityUIElement::subrole):
3048         (WTR::AccessibilityUIElement::roleDescription):
3049         (WTR::AccessibilityUIElement::title):
3050         (WTR::AccessibilityUIElement::description):
3051         (WTR::AccessibilityUIElement::orientation):
3052         (WTR::AccessibilityUIElement::stringValue):
3053         (WTR::AccessibilityUIElement::language):
3054         (WTR::AccessibilityUIElement::helpText):
3055         (WTR::AccessibilityUIElement::x):
3056         (WTR::AccessibilityUIElement::y):
3057         (WTR::AccessibilityUIElement::width):
3058         (WTR::AccessibilityUIElement::height):
3059         (WTR::AccessibilityUIElement::clickPointX):
3060         (WTR::AccessibilityUIElement::clickPointY):
3061         (WTR::AccessibilityUIElement::intValue):
3062         (WTR::AccessibilityUIElement::minValue):
3063         (WTR::AccessibilityUIElement::maxValue):
3064         (WTR::AccessibilityUIElement::valueDescription):
3065         (WTR::AccessibilityUIElement::insertionPointLineNumber):
3066         (WTR::AccessibilityUIElement::isActionSupported):
3067         (WTR::AccessibilityUIElement::isEnabled):
3068         (WTR::AccessibilityUIElement::isRequired):
3069         (WTR::AccessibilityUIElement::isFocused):
3070         (WTR::AccessibilityUIElement::isSelected):
3071         (WTR::AccessibilityUIElement::isExpanded):
3072         (WTR::AccessibilityUIElement::isChecked):
3073         (WTR::AccessibilityUIElement::hierarchicalLevel):
3074         (WTR::AccessibilityUIElement::speak):
3075         (WTR::AccessibilityUIElement::ariaIsGrabbed):
3076         (WTR::AccessibilityUIElement::ariaDropEffects):
3077         (WTR::AccessibilityUIElement::lineForIndex):
3078         (WTR::AccessibilityUIElement::rangeForLine):
3079         (WTR::AccessibilityUIElement::boundsForRange):
3080         (WTR::AccessibilityUIElement::stringForRange):
3081         (WTR::AccessibilityUIElement::attributedStringForRange):
3082         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3083         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3084         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3085         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3086         (WTR::AccessibilityUIElement::attributesOfColumns):
3087         (WTR::AccessibilityUIElement::attributesOfRows):
3088         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3089         (WTR::AccessibilityUIElement::attributesOfHeader):
3090         (WTR::AccessibilityUIElement::rowCount):
3091         (WTR::AccessibilityUIElement::columnCount):
3092         (WTR::AccessibilityUIElement::indexInTable):
3093         (WTR::AccessibilityUIElement::rowIndexRange):
3094         (WTR::AccessibilityUIElement::columnIndexRange):
3095         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3096         (WTR::AccessibilityUIElement::horizontalScrollbar):
3097         (WTR::AccessibilityUIElement::verticalScrollbar):
3098         (WTR::AccessibilityUIElement::selectedTextRange):
3099         (WTR::AccessibilityUIElement::setSelectedTextRange):
3100         (WTR::AccessibilityUIElement::increment):
3101         (WTR::AccessibilityUIElement::decrement):
3102         (WTR::AccessibilityUIElement::showMenu):
3103         (WTR::AccessibilityUIElement::press):
3104         (WTR::AccessibilityUIElement::setSelectedChild):
3105         (WTR::AccessibilityUIElement::accessibilityValue):
3106         (WTR::AccessibilityUIElement::documentEncoding):
3107         (WTR::AccessibilityUIElement::documentURI):
3108         (WTR::AccessibilityUIElement::url):
3109         (WTR::AccessibilityUIElement::addNotificationListener):
3110         (WTR::AccessibilityUIElement::removeNotificationListener):
3111         (WTR::AccessibilityUIElement::isFocusable):
3112         (WTR::AccessibilityUIElement::isSelectable):
3113         (WTR::AccessibilityUIElement::isMultiSelectable):
3114         (WTR::AccessibilityUIElement::isVisible):
3115         (WTR::AccessibilityUIElement::isOffScreen):
3116         (WTR::AccessibilityUIElement::isCollapsed):
3117         (WTR::AccessibilityUIElement::isIgnored):
3118         (WTR::AccessibilityUIElement::hasPopup):
3119         (WTR::AccessibilityUIElement::takeFocus):
3120         (WTR::AccessibilityUIElement::takeSelection):
3121         (WTR::AccessibilityUIElement::addSelection):
3122         (WTR::AccessibilityUIElement::removeSelection):
3123         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3124         (WTR::AccessibilityUIElement::textMarkerRangeLength):
3125         (WTR::AccessibilityUIElement::previousTextMarker):
3126         (WTR::AccessibilityUIElement::nextTextMarker):
3127         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3128         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3129         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3130         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3131         (WTR::AccessibilityUIElement::textMarkerForPoint):
3132         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3133         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3134         (WTR::LayoutTestController::platformName):
3135         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3136         (WTR::LayoutTestController::platformName):
3137         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3138         (WTR::LayoutTestController::platformName):
3139         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3140         * WebKitTestRunner/win/InjectedBundle.vcproj:
3141
3142 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3143
3144         [Qt] Fix use of config.tests
3145
3146         We were checking @buildArgs to determine if the optional argument was
3147         passed or not, but this is not the right way to do that in Perl. The
3148         right way is to not use a prototype for the function, and to pass
3149         the list as a reference (to avoid list expansion). That way we can
3150         check the number of arguments, and choose the right code path based
3151         on that.
3152
3153         We were also missing a default-value of 0 for any feature that's not
3154         set in features.prf.
3155
3156         Reviewed by Kenneth Rohde Christiansen.
3157
3158         * Scripts/build-webkit:
3159         * Scripts/webkitdirs.pm:
3160         (qtFeatureDefaults):
3161         (buildQMakeProject):
3162
3163 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3164
3165         [Qt] Prospective fix for broken plugin tests
3166
3167         Don't hide symbols for the NPAPI test plugin
3168
3169         Rubber-stamped by Andreas Kling.
3170
3171         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3172
3173 2011-11-16  Adam Roben  <aroben@apple.com>
3174
3175         Move filenames/line numbers off to the right edge in Leaks Viewer
3176
3177         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
3178         because filenames/line numbers are right next to function names
3179
3180         Reviewed by Andreas Kling.
3181
3182         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
3183         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
3184         function name. Use the filename as the profile node's URL (we don't have enough info to
3185         compute a real URL currently) and the line number as the profile node's line number so the
3186         Inspector code will put them on the right side of the callstack graph.
3187
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3189         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
3190         passed here, just filenames.
3191
3192         (WebInspector.linkifyURLAsNode):
3193         (WebInspector.linkifyResourceAsNode):
3194         Copied and slightly modified from inspector.js.
3195
3196 2011-11-16  Adam Roben  <aroben@apple.com>
3197
3198         Make Leaks Viewer load builds from the new Lion Leaks bot
3199
3200         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
3201
3202         Reviewed by Andreas Kling.
3203
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3205         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
3206         SnowLeopard one.
3207
3208 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3209
3210         [EFL] Clean up the offline apps-related functions in ewk_settings.
3211         https://bugs.webkit.org/show_bug.cgi?id=72132
3212
3213         Reviewed by Kenneth Rohde Christiansen.
3214
3215         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
3216         prefixes for code that is related only to the HTML5 app cache
3217         features.
3218
3219         Use `ewk_settings_application_cache' and
3220         `ewk_view_setting_application_cache' instead.
3221
3222         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3223         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3224
3225 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3226
3227         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
3228
3229         Reviewed by Tor Arne Vestbø.
3230
3231         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
3232         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
3233         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
3234         removes the .so.0.0.0 and just produces .so.
3235
3236 2011-11-16  Peter Beverloo  <peter@chromium.org>
3237
3238         Explicitly include unistd.h in TestNetscapePlugIn
3239         https://bugs.webkit.org/show_bug.cgi?id=72385
3240
3241         This is needed for the sleep() call in the indicateTestFailure method,
3242         which seems to be implicitly available for other platforms. This is not
3243         the case on Android.
3244
3245         Reviewed by Steve Block.
3246
3247         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3248
3249 2011-11-16  Peter Beverloo  <peter@chromium.org>
3250
3251         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
3252         https://bugs.webkit.org/show_bug.cgi?id=72384
3253
3254         Update to Android NDK r7, which was released last Friday. This adds
3255         support for RTTI and the -mimplicit-it gcc flag, which are required to
3256         respectively build ICU and Skia.
3257
3258         Reviewed by Steve Block.
3259
3260         * Scripts/update-webkit-chromium:
3261         * Scripts/webkitdirs.pm:
3262         (buildChromiumMakefile):
3263
3264 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
3265
3266         Unreviewed, rolling out r100266.
3267         http://trac.webkit.org/changeset/100266
3268
3269         Broke WTR.
3270
3271         * qmake/mkspecs/features/default_post.prf:
3272
3273 2011-11-16  Eric Seidel  <eric@webkit.org>
3274
3275         check-webkit-style broken by r99773: "Could not determine the port"
3276         https://bugs.webkit.org/show_bug.cgi?id=72275
3277
3278         Reviewed by Adam Barth.
3279
3280         I will continue engaging hacks, until windows improves.
3281
3282         * Scripts/webkitpy/common/host.py:
3283          - Host uses self.executive instead of self._executive like Port does.
3284          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
3285
3286 2011-11-16  Eric Seidel  <eric@webkit.org>
3287
3288         check-webkit-style broken by r99773: "Could not determine the port"
3289         https://bugs.webkit.org/show_bug.cgi?id=72275
3290
3291         Reviewed by Adam Barth.
3292
3293         Engage windows hacks harder.
3294
3295         This is a speculative fix for ChromiumWin.  We're now
3296         creating an SCM object much earlier, so we need to
3297         engage our "awesome" windows hacks earlier.
3298
3299         * Scripts/webkitpy/common/host.py:
3300         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3301
3302 2011-11-15  Darin Adler  <darin@apple.com>
3303
3304         DRT's uiElementAttributeValueCallback function is leaky
3305         https://bugs.webkit.org/show_bug.cgi?id=72453
3306
3307         Reviewed by Dan Bernstein.
3308
3309         * DumpRenderTree/AccessibilityUIElement.cpp:
3310         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
3311
3312 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
3313
3314         Implement edit-distance based reviewer recognition algorithm
3315         https://bugs.webkit.org/show_bug.cgi?id=72351
3316
3317         Reviewed by Eric Seidel.
3318
3319         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
3320         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
3321         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
3322         "build fix" to a reviewer's name (e.g. with with edit distance 9).
3323
3324         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
3325         the edit distance is implemented in edit_distance.py.
3326
3327         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
3328         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
3329
3330         * Scripts/webkitpy/common/checkout/changelog.py:
3331         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3332         * Scripts/webkitpy/common/config/committers.py:
3333         * Scripts/webkitpy/common/config/committers_unittest.py:
3334         * Scripts/webkitpy/common/editdistance.py: Added.
3335         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
3336         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3337         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
3338
3339 2011-11-15  Tony Chang  <tony@chromium.org>
3340
3341         Skip a failing webkitpy test on cygwin.
3342
3343         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3344
3345 2011-11-15  Sam Weinig  <sam@webkit.org>
3346
3347         TestWebKitAPI should not put its resources in the root products directory
3348         https://bugs.webkit.org/show_bug.cgi?id=72446
3349
3350         Reviewed by Anders Carlsson.
3351
3352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3353         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
3354         directory.
3355
3356         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3357         (TEST_F):
3358         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3361         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3362         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3363         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
3364         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3365         (TestWebKitAPI::Util::createURLForResource):
3366         Update calls to retrieve files from the bundle to look in the newly
3367         created subdirectory.
3368
3369 2011-11-15  Tony Chang  <tony@chromium.org>
3370
3371         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
3372
3373         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3374
3375 2011-11-15  Tony Chang  <tony@chromium.org>
3376
3377         Unreviewed, fix test-webkitpy tests.  Move the check for image results
3378         earlier.
3379
3380         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3381         * Scripts/webkitpy/layout_tests/port/webkit.py:
3382
3383 2011-11-15  James Robinson  <jamesr@chromium.org>
3384
3385         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
3386         https://bugs.webkit.org/show_bug.cgi?id=72444
3387
3388         Reviewed by Adam Barth.
3389
3390         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3391
3392 2011-11-15  Tony Chang  <tony@chromium.org>
3393
3394         Unreviewed, better fix for ref tests failures on SL Intel bot.
3395         Revert the previous change and return None if pixel results from
3396         either the test page or the expected page is missing.
3397
3398         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3399         * Scripts/webkitpy/layout_tests/port/webkit.py:
3400
3401 2011-11-15  James Robinson  <jamesr@chromium.org>
3402
3403         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
3404         https://bugs.webkit.org/show_bug.cgi?id=72402
3405
3406         Reviewed by Dirk Pranke.
3407
3408         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
3409         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
3410         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
3411         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
3412         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
3413         compositing enabled.
3414
3415         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
3416         patch should not impact any tests.
3417
3418         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3419         (main):
3420         * DumpRenderTree/chromium/TestShell.cpp:
3421         (TestShell::TestShell):
3422         (TestShell::resetWebSettings):
3423         * DumpRenderTree/chromium/TestShell.h:
3424         (TestShell::setAcceleratedCompositingForVideoEnabled):
3425         * DumpRenderTree/chromium/WebPreferences.cpp:
3426         (WebPreferences::reset):
3427         (WebPreferences::applyTo):
3428         * DumpRenderTree/chromium/WebPreferences.h:
3429         * Scripts/webkitpy/layout_tests/port/chromium.py:
3430         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3431         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3432
3433 2011-11-15  Tony Chang  <tony@chromium.org>
3434
3435         Unreviewed, try to fix ref tests failures on SL Intel bot.
3436         It looks like ImageDiff isn't returning an image diff.
3437
3438         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3439
3440 2011-11-15  Tony Chang  <tony@chromium.org>
3441
3442         Unreviewed fix of ref-tests on GTK+.
3443         If a driver is never started, _xvfb_process is never set.
3444
3445         * Scripts/webkitpy/layout_tests/port/gtk.py:
3446
3447 2011-11-14  Tony Chang  <tony@chromium.org>
3448
3449         [NRWT] Reftests should run even when pixel tests are disabled.
3450         https://bugs.webkit.org/show_bug.cgi?id=60605
3451
3452         Reviewed by Dirk Pranke.
3453
3454         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
3455             Also add an assert to make sure we get image hashes back when running ref tests.
3456         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
3457         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3458         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
3459         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
3460             of starting a pixel driver if needed.  It handles the logic of sending the test
3461             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
3462         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3463         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
3464         * Scripts/webkitpy/layout_tests/port/webkit.py:
3465         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
3466         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
3467
3468 2011-11-15  David Kilzer  <ddkilzer@apple.com>
3469
3470         Don't use File::Slurp for run-leaks unit tests
3471         <http://webkit.org/b/72356>
3472
3473         Reviewed by Daniel Bates.
3474
3475         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
3476         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3477         Extracted common package logic into RunLeaks.pm.  Fixed call to
3478         RunLeaks::parseLeaksOutput().
3479         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3480         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3481
3482 2011-11-15  Peter Kasting  <pkasting@google.com>
3483
3484         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
3485         https://bugs.webkit.org/show_bug.cgi?id=72349
3486
3487         Reviewed by Adam Roben.
3488
3489         * Scripts/VCSUtils.pm:
3490         (isSVNDirectory):
3491
3492 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3493
3494         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
3495
3496         Reviewed by Tor Arne Vestbø.
3497
3498         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
3499         magic here where we handle all TEMPLATE = lib .pro files.
3500
3501 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3502
3503         [Qt] Unreviewed prospective --minimal build fix.
3504
3505         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
3506         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
3507
3508 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3509
3510         [Qt] Unreviewed --minimal build fix.
3511
3512         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
3513         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
3514         to make moc's preprocessor abort.
3515
3516 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
3517
3518         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
3519         https://bugs.webkit.org/show_bug.cgi?id=72156
3520
3521         Reviewed by Daniel Bates.
3522
3523         Similar to --makearg and --qmakearg, --cmakearg lets one pass
3524         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
3525
3526         * Scripts/build-webkit:
3527         * Scripts/webkitdirs.pm:
3528         (generateBuildSystemFromCMakeProject):
3529
3530 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
3531
3532         Improve ChangeLogEntry's reviewer parsing algorithm part 2
3533         https://bugs.webkit.org/show_bug.cgi?id=72340
3534
3535         Reviewed by Eric Seidel.
3536
3537         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
3538         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
3539
3540         * Scripts/webkitpy/common/checkout/changelog.py:
3541         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3542
3543 2011-11-14  Eric Seidel  <eric@webkit.org>
3544
3545         check-webkit-style broken by r99773: "Could not determine the port"
3546         https://bugs.webkit.org/show_bug.cgi?id=72275
3547
3548         Reviewed by Adam Barth.
3549
3550         The TestExpectationsChecker was using a generic try/except block
3551         which caught all exceptions, so we didn't notice that failing
3552         to pass a Host to PortFactory was causing an exception in port instantiation.
3553         I've factored out the "lookup the port" logic into a separate function
3554         which I've now unittested.  This should fix the bug and prevent
3555         others like it from occuring the the future.
3556
3557         * Scripts/webkitpy/style/checkers/test_expectations.py:
3558         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3559
3560 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
3561
3562         Add --css-grid-layout to build-webkit and the build systems
3563         https://bugs.webkit.org/show_bug.cgi?id=72320
3564
3565         Reviewed by Ojan Vafai.
3566
3567         * Scripts/build-webkit:
3568         Added the option.
3569
3570 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3571
3572         Unreviewed, rolling out r100192.
3573         http://trac.webkit.org/changeset/100192
3574         https://bugs.webkit.org/show_bug.cgi?id=72328
3575
3576         Caused infinite tests to fail (Requested by abarth on
3577         #webkit).
3578
3579         * Scripts/webkitpy/layout_tests/port/base.py:
3580         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3581
3582 2011-11-14  Tony Chang  <tony@chromium.org>
3583
3584         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
3585         https://bugs.webkit.org/show_bug.cgi?id=72196
3586
3587         Reviewed by Ojan Vafai.
3588
3589         * Scripts/build-webkit:
3590
3591 2011-11-14  John Yani  <vanuan@gmail.com>
3592
3593         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
3594         Override LOCALE to en_US.
3595
3596         Reviewed by Eric Seidel.
3597
3598         * Scripts/webkitpy/layout_tests/port/base.py:
3599
3600 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
3601
3602         [Chromium] build-webkit silently drops the features flags
3603         https://bugs.webkit.org/show_bug.cgi?id=72293
3604
3605         Reviewed by Tony Chang.
3606
3607         Chromium still ignores @features but now we give a warning!
3608
3609         * Scripts/build-webkit: Check if one of the features is different
3610         from the default and print a warning in this case.
3611