Remove NodeListsNodeData when it's no longer needed
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove NodeListsNodeData when it's no longer needed
4         https://bugs.webkit.org/show_bug.cgi?id=107074
5
6         Reviewed by Darin Adler.
7
8         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
9
10         * Scripts/webkitpy/performance_tests/perftest.py:
11         (PerfTest):
12
13 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
14
15         Ref test images are upside-down in WebKit2
16         https://bugs.webkit.org/show_bug.cgi?id=105457
17
18         Reviewed by Sam "Speedy" Weinig.
19         
20         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
21         from the window snapshot contained a flipped copy of the image, causing all ref
22         and pixel images to be upside-down.
23
24         * WebKitTestRunner/cg/TestInvocationCG.cpp:
25         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
26
27 2013-01-17  Timothy Loh  <timloh@google.com>
28
29         Replaced specifiers variable with is_debug in builders.py
30         https://bugs.webkit.org/show_bug.cgi?id=107057
31
32         Reviewed by Dirk Pranke.
33
34         Replaced specifiers variable with is_debug in builders.py to simplify
35         Bug 106259. The other specifiers are not used elsewhere in the code.
36         Fixed builder_name_for_port_name to return a debug builder if we don't
37         have a release builder.
38
39         * Scripts/webkitpy/layout_tests/port/builders.py:
40         (all_port_names):
41         (builder_name_for_port_name):
42         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
43         (TestRebaselineExpectations.test_rebaseline_expectations):
44
45 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
46
47         [GTK] Build with LevelDB when IndexedDB is enabled
48         https://bugs.webkit.org/show_bug.cgi?id=103220
49
50         Reviewed by Gustavo Noronha Silva.
51
52         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
53         as it does not conform to WebKit style.
54
55 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
56
57         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
58         https://bugs.webkit.org/show_bug.cgi?id=107119
59
60         Reviewed by Laszlo Gombos.
61
62         Do not use ASSERT on ecore_evas_init(), since the expression inside
63         the macro compiles out of release builds.
64
65         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
66         * TestWebKitAPI/efl/PlatformWebView.cpp:
67         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
68
69 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
70
71         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
72         https://bugs.webkit.org/show_bug.cgi?id=104545
73
74         Reviewed by Yury Semikhatsky.
75
76         Adopt signature changes.
77
78         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
79         (ProfilerAgent.getCPUProfile): Renamed.
80         (ProfilerAgent.getHeapSnapshot): Added.
81
82 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
83
84         [GTK][EFL] NWRT should check that Xvfb is installed
85         https://bugs.webkit.org/show_bug.cgi?id=71767
86
87         Reviewed by Dirk Pranke.
88
89         EFL and GTK ports now check that Xvfb is installed before running
90         layout tests. The command line used to check whether Xvfb is present
91         is a simple `which Xvfb` that should return 0 as the exit code upon
92         success.
93
94         * Scripts/webkitpy/layout_tests/port/efl.py:
95         (EflPort.show_results_html_file):
96         (EflPort):
97         (EflPort.check_sys_deps):
98         * Scripts/webkitpy/layout_tests/port/gtk.py:
99         (GtkPort.check_sys_deps):
100         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
101         (XvfbDriver):
102         (XvfbDriver.check_xvfb):
103
104 2013-01-16  Alan Cutter  <alancutter@chromium.org>
105
106         sheriffbot can't tell me who "kov" is
107         https://bugs.webkit.org/show_bug.cgi?id=106184
108
109         Reviewed by Eric Seidel.
110
111         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
112
113         * Scripts/webkitpy/common/config/committers.py:
114         (Account.matches_glob):
115         (CommitterList.contributors_by_search_string):
116         * Scripts/webkitpy/common/config/committers_unittest.py:
117         (CommittersTest.test_committer_lookup):
118         * Scripts/webkitpy/tool/bot/irc_command.py:
119         (Whois):
120
121 2013-01-16  David Kilzer  <ddkilzer@apple.com>
122
123         Use xcrun to find path to make for Mac port
124         <http://webkit.org/b/107091>
125
126         Reviewed by Dan Bernstein.
127
128         * Scripts/webkitpy/layout_tests/port/mac.py:
129         (MacPort._build_java_test_support): Call self.make_command().
130         (MacPort.make_command): Add.  Call xcrun_find().
131         (MacPort.nm_command): Use self.xcrun_find().
132         (MacPort.xcrun_find): Add.  Extract from nm_command().
133
134 2013-01-16  Sam Weinig  <sam@webkit.org>
135
136         Make debug-safari --target-web-process work again
137         https://bugs.webkit.org/show_bug.cgi?id=107088
138
139         Reviewed by Anders Carlsson.
140
141         * Scripts/webkitdirs.pm:
142         (execMacWebKitAppForDebugging):
143         The shim is now called SecItemShim.
144
145 2013-01-16  Alan Cutter  <alancutter@chromium.org>
146
147         GCE build scripts don't take working directory into account when calling findzone.sh
148         https://bugs.webkit.org/show_bug.cgi?id=106962
149
150         Reviewed by Adam Barth.
151
152         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
153         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
154         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
155
156 2013-01-16  Alan Cutter  <alancutter@chromium.org>
157
158         start-queue.sh does not pass remaining parameters correctly
159         https://bugs.webkit.org/show_bug.cgi?id=107054
160
161         Reviewed by Adam Barth.
162
163         start-queue.sh now passes all remaining params to the webkit-patch command.
164         Previously only one additional queue parameter could be sent.
165
166         * EWSTools/start-queue.sh:
167
168 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
169
170         check-webkit-style script cannot running in Chinese windows.
171         https://bugs.webkit.org/show_bug.cgi?id=87548
172
173         Reviewed by Darin Adler.
174
175         * Scripts/webkitpy/common/system/platforminfo.py:
176         (PlatformInfo._win_version_tuple_from_cmd):
177
178 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
179
180         Delete an extraneous print statement.
181         https://bugs.webkit.org/show_bug.cgi?id=106562
182
183         Delete the extraneous print statement introduced in r139841.
184
185         * Scripts/webkitpy/layout_tests/views/printing.py:
186         (Printer.print_found):
187
188 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
189
190         Please reinstate --pixel
191         https://bugs.webkit.org/show_bug.cgi?id=101995
192
193         Reviewed by Dirk Pranke.
194
195         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
196         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
197         Some developers are still used to these options that were available in the ORWT.
198
199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
200         (parse_args):
201
202 2013-01-16  Eric Seidel  <eric@webkit.org>
203
204         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
205         https://bugs.webkit.org/show_bug.cgi?id=99512
206
207         Reviewed by Darin Adler.
208
209         * Scripts/run-sunspider:
210
211 2013-01-16  Eric Seidel  <eric@webkit.org>
212
213         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
214         https://bugs.webkit.org/show_bug.cgi?id=106036
215
216         Reviewed by Darin Adler.
217
218         * Scripts/webkitpy/webkitpy.pyproj: Removed.
219         * Scripts/webkitpy/webkitpy.sln: Removed.
220
221 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
222
223         [Chromium] Remove hardcoded chromium_*.jar in gyp files
224         https://bugs.webkit.org/show_bug.cgi?id=104049
225
226         Reviewed by Eric Seidel.
227
228         Targets with dependencies (direct/indirect) on a java target receive
229         the chromium_*.jar paths in the variable input_jars_paths. Targets
230         should use that rather than hardcoding where they think the jar will
231         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
232         than as --jars to generate_native_test.py.
233
234         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
235         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
236
237 2013-01-16  Dan Carney  <dcarney@google.com>
238
239         [chromium] move setMockDeviceOrientation to TestRunner library
240         https://bugs.webkit.org/show_bug.cgi?id=106895
241
242         Reviewed by Jochen Eisinger.
243
244         * DumpRenderTree/chromium/DRTTestRunner.cpp:
245         (DRTTestRunner::DRTTestRunner):
246         * DumpRenderTree/chromium/DRTTestRunner.h:
247         (DRTTestRunner):
248         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
249         (WebKit):
250         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
251         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
252         (WebTestRunner::TestRunner::TestRunner):
253         (WebTestRunner::TestRunner::setMockDeviceOrientation):
254         (WebTestRunner):
255         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
256         (TestRunner):
257         * DumpRenderTree/chromium/WebViewHost.cpp:
258         (WebViewHost::setDeviceOrientation):
259         * DumpRenderTree/chromium/WebViewHost.h:
260         (WebViewHost):
261
262 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
263
264         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
265         https://bugs.webkit.org/show_bug.cgi?id=106904
266
267         Reviewed by Adam Barth.
268
269         * DumpRenderTree/chromium/DRTTestRunner.cpp:
270         (DRTTestRunner::DRTTestRunner):
271         (DRTTestRunner::notifyDone):
272         (DRTTestRunner::reset):
273         * DumpRenderTree/chromium/DRTTestRunner.h:
274         (DRTTestRunner):
275         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
276         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
277         (WebTestRunner::WebTestDelegate::setFocus):
278         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
279         (WebTestRunner::WebTestDelegate::pathToLocalResource):
280         (WebTestRunner::WebTestDelegate::setLocale):
281         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
282         (WebTestRunner::TestRunner::TestRunner):
283         (WebTestRunner::TestRunner::reset):
284         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
285         (WebTestRunner):
286         (WebTestRunner::TestRunner::setWindowIsKey):
287         (WebTestRunner::TestRunner::pathToLocalResource):
288         (WebTestRunner::TestRunner::setBackingScaleFactor):
289         (WebTestRunner::TestRunner::setPOSIXLocale):
290         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
291         (WebTestRunner::TestRunner::taskList):
292         (TestRunner):
293         * DumpRenderTree/chromium/WebViewHost.cpp:
294         (WebViewHost::setDeviceScaleFactor):
295         (WebViewHost::setFocus):
296         (WebViewHost::setAcceptAllCookies):
297         (WebViewHost::pathToLocalResource):
298         (WebViewHost::setLocale):
299         * DumpRenderTree/chromium/WebViewHost.h:
300         (WebViewHost):
301
302 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
303
304         [GTK] build-webkit fails if the jhbuild wrapper is not used
305         https://bugs.webkit.org/show_bug.cgi?id=106769
306
307         Reviewed by Martin Robinson.
308
309         Return an empty array instead of "" in
310         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
311         will not be recognized as a valid command when the returned array
312         is directly passed to perl's system() call.
313
314         * Scripts/webkitdirs.pm:
315         (jhbuildWrapperPrefixIfNeeded):
316
317 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
318
319         [chromium] add title text direction attribute to TestRunner
320         https://bugs.webkit.org/show_bug.cgi?id=106907
321
322         Reviewed by Adam Barth.
323
324         * DumpRenderTree/chromium/DRTTestRunner.cpp:
325         (DRTTestRunner::DRTTestRunner):
326         (DRTTestRunner::reset):
327         * DumpRenderTree/chromium/DRTTestRunner.h:
328         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
329         (WebTestRunner::WebTestRunner::setTitleTextDirection):
330         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
331         (WebTestRunner::TestRunner::TestRunner):
332         (WebTestRunner::TestRunner::reset):
333         (WebTestRunner::TestRunner::setTitleTextDirection):
334         (WebTestRunner):
335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
336         (TestRunner):
337         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
338         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
339         * DumpRenderTree/chromium/WebViewHost.cpp:
340         (WebViewHost::didReceiveTitle):
341
342 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
343
344         NRWT still confused about test count with --repeat-each and --iterations
345         https://bugs.webkit.org/show_bug.cgi?id=106562
346
347         Reviewed by Dirk Pranke.
348
349         Fix the printed unique test count and skipped count. This
350         seems to have broken in r127688 ("NRWT lies about the number
351         of tests that it's skipping when used with --repeat-each").
352
353         Also add a test for print_found()
354
355         * Scripts/webkitpy/layout_tests/views/printing.py:
356         (Printer.print_found):
357         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
358         (Testprinter.test_details):
359         (Testprinter):
360         (Testprinter.test_found):
361
362 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
363
364         Unreviewed follow-up to r139769.
365
366         Note that omitting the WebKit1 code from the build now
367         works for GTK as well.
368
369         * Scripts/build-webkit:
370
371 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
372
373         test-webkitpy: truncate output to the terminal width when necessary
374         https://bugs.webkit.org/show_bug.cgi?id=106973
375
376         Reviewed by Ojan Vafai.
377
378         this implements the same logic for test-webkitpy that we have
379         for run-webkit-tests (and ninja).
380
381         No tests written as this is exercised by running test-webkitpy itself.
382
383         * Scripts/webkitpy/test/printer.py:
384         (Printer.configure):
385         (Printer._test_line):
386
387 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
388
389         remove extraneous output in test-webkitpy
390         https://bugs.webkit.org/show_bug.cgi?id=106971
391
392         Reviewed by Ojan Vafai.
393
394         We weren't ignoring or capturing the echoed output from
395         these two tests, and getting noise in the logs as a result.
396
397         * Scripts/webkitpy/common/system/executive_unittest.py:
398         (ExecutiveTest.test_auto_stringify_args):
399         (ExecutiveTest.test_popen_args):
400
401 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
402
403         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
404         https://bugs.webkit.org/show_bug.cgi?id=106974
405
406         Reviewed by Ryosuke Niwa.
407
408         I forgot to stub out the call to check to ensure that the ports were
409         available, so this test could fail if something was listening on 8000 or
410         8443 on the machine.
411
412         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
413         (TestHttpServer.test_win32_start_and_stop):
414
415 2013-01-15  Levi Weintraub  <leviw@chromium.org>
416
417         Unreviewed, rolling out r139792.
418         http://trac.webkit.org/changeset/139792
419         https://bugs.webkit.org/show_bug.cgi?id=106970
420
421         Broke the windows build.
422
423         * DumpRenderTree/chromium/DRTTestRunner.cpp:
424         (DRTTestRunner::DRTTestRunner):
425         (DRTTestRunner::notifyDone):
426         (DRTTestRunner::reset):
427         (DRTTestRunner::setAlwaysAcceptCookies):
428         (DRTTestRunner::setWindowIsKey):
429         (DRTTestRunner::pathToLocalResource):
430         (DRTTestRunner::setPOSIXLocale):
431         (InvokeCallbackTask):
432         (InvokeCallbackTask::InvokeCallbackTask):
433         (InvokeCallbackTask::runIfValid):
434         (DRTTestRunner::setBackingScaleFactor):
435         * DumpRenderTree/chromium/DRTTestRunner.h:
436         (DRTTestRunner):
437         (DRTTestRunner::taskList):
438         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
439         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
440         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
441         (WebTestRunner::TestRunner::TestRunner):
442         (WebTestRunner::TestRunner::reset):
443         (WebTestRunner::TestRunner::setDatabaseQuota):
444         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
445         (TestRunner):
446         * DumpRenderTree/chromium/WebViewHost.cpp:
447         (WebViewHost::setPendingExtraData):
448         (WebViewHost::setDeviceScaleFactor):
449         * DumpRenderTree/chromium/WebViewHost.h:
450         (WebViewHost):
451
452 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
453
454         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
455
456         * Scripts/webkitpy/common/config/ports.py:
457         (MacWK2Port):
458
459 2013-01-15  Alan Cutter  <alancutter@chromium.org>
460
461         Extend sheriffbot's "help" command to be able to get help on individual commands
462         https://bugs.webkit.org/show_bug.cgi?id=106629
463
464         Reviewed by Eric Seidel.
465
466         Added a help command to sheriffbot.
467         Fixed some style issues and ordered the commands alphabetically.
468
469         * Scripts/webkitpy/tool/bot/irc_command.py:
470         (IRCCommand):
471         (IRCCommand.execute):
472         (IRCCommand.usage):
473         (IRCCommand.help):
474         (CreateBug):
475         (CreateBug.execute):
476         (Help):
477         (Help.execute):
478         (Help._post_command_help):
479         (Hi):
480         (Hi.execute):
481         (Restart):
482         (RollChromiumDEPS):
483         (RollChromiumDEPS._parse_args):
484         (RollChromiumDEPS._expand_irc_nickname):
485         (RollChromiumDEPS.execute):
486         (Rollout):
487         (Rollout._extract_revisions):
488         (Rollout.execute):
489         (Sheriffs):
490         (Sheriffs.execute):
491         (Whois):
492         (Whois.execute):
493         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
494         (IRCBotTest.test_help):
495
496 2013-01-15  Enrica Casucci  <enrica@apple.com>
497
498         Add a new set of WebKit2 APIs for text search and
499         search results management.
500         https://bugs.webkit.org/show_bug.cgi?id=106834.
501         <rdar://problem/12597159>
502
503         Added new test for the new WebKit2 API for
504         text search.
505         
506         Reviewed by Simon Fraser.
507
508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
509         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
510
511 2013-01-15  Levi Weintraub  <leviw@chromium.org>
512
513         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
514         https://bugs.webkit.org/show_bug.cgi?id=106904
515
516         Reverting 139794. It broke the build. It appears that a header file,
517         WebTextDirection.h, was left out.
518
519         * DumpRenderTree/chromium/DRTTestRunner.cpp:
520         (DRTTestRunner::DRTTestRunner):
521         (DRTTestRunner::reset):
522         * DumpRenderTree/chromium/DRTTestRunner.h:
523         (DRTTestRunner::setTitleTextDirection):
524         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
525         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
526         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
527         (WebTestRunner::TestRunner::TestRunner):
528         (WebTestRunner::TestRunner::reset):
529         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
530         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
531         (TestRunner):
532         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
533         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
534         * DumpRenderTree/chromium/WebViewHost.cpp:
535         (WebViewHost::didReceiveTitle):
536
537 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
538
539         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
540         https://bugs.webkit.org/show_bug.cgi?id=106904
541
542         Reviewed by Adam Barth.
543
544         * DumpRenderTree/chromium/DRTTestRunner.cpp:
545         (DRTTestRunner::DRTTestRunner):
546         (DRTTestRunner::notifyDone):
547         (DRTTestRunner::reset):
548         * DumpRenderTree/chromium/DRTTestRunner.h:
549         (DRTTestRunner):
550         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
551         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
552         (WebTestRunner::WebTestDelegate::setFocus):
553         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
554         (WebTestRunner::WebTestDelegate::pathToLocalResource):
555         (WebTestRunner::WebTestDelegate::setLocale):
556         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
557         (WebTestRunner::TestRunner::TestRunner):
558         (WebTestRunner::TestRunner::reset):
559         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
560         (WebTestRunner):
561         (WebTestRunner::TestRunner::setWindowIsKey):
562         (WebTestRunner::TestRunner::pathToLocalResource):
563         (WebTestRunner::TestRunner::setBackingScaleFactor):
564         (WebTestRunner::TestRunner::setPOSIXLocale):
565         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
566         (WebTestRunner::TestRunner::taskList):
567         (TestRunner):
568         * DumpRenderTree/chromium/WebViewHost.cpp:
569         (WebViewHost::setDeviceScaleFactor):
570         (WebViewHost::setFocus):
571         (WebViewHost::setAcceptAllCookies):
572         (WebViewHost::pathToLocalResource):
573         (WebViewHost::setLocale):
574         * DumpRenderTree/chromium/WebViewHost.h:
575         (WebViewHost):
576
577 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
578
579         Tests with WontFix expectation are (indirectly) skipped
580         https://bugs.webkit.org/show_bug.cgi?id=105860
581
582         Reviewed by Dirk Pranke.
583
584         Only skip the WontFix expectation if there are no other layout test
585         expectations (like Failure, ImageOnlyFailure) listed for the test.
586         This makes it possible to run an expected failure for which there
587         is no reason or interest to fix. There are some ports that would like
588         to exercise this behavior as well as specific test cases that should use
589         such expectations.
590
591         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
592         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
593         WONTFIX test if there are no expectations listed. The warning is adjusted
594         to reflect the new behavior.
595         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
596         and adjust test cases for these changes.
597         (ExpectationSyntaxTests.test_wontfix):
598         (SemanticTests.test_skip_and_wontfix):
599
600 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
601
602         [chromium] add title text direction attribute to TestRunner
603         https://bugs.webkit.org/show_bug.cgi?id=106907
604
605         Reviewed by Adam Barth.
606
607         * DumpRenderTree/chromium/DRTTestRunner.cpp:
608         (DRTTestRunner::DRTTestRunner):
609         (DRTTestRunner::reset):
610         * DumpRenderTree/chromium/DRTTestRunner.h:
611         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
612         (WebTestRunner::WebTestRunner::setTitleTextDirection):
613         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
614         (WebTestRunner::TestRunner::TestRunner):
615         (WebTestRunner::TestRunner::reset):
616         (WebTestRunner::TestRunner::setTitleTextDirection):
617         (WebTestRunner):
618         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
619         (TestRunner):
620         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
621         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
622         * DumpRenderTree/chromium/WebViewHost.cpp:
623         (WebViewHost::didReceiveTitle):
624
625 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
626
627         nrwt: change the default # of locked shards on chromium_win to 1
628         https://bugs.webkit.org/show_bug.cgi?id=106938
629
630         Reviewed by Eric Seidel.
631
632         It looks like LigHTTPd might be buggy or unstable if we are
633         running multiple http tests in parallel; see
634         http://code.google.com/p/chromium/issues/detail?id=169530 for more
635         context as well. This change will stop running http tests in parallel
636         and we can see if this fixes things.
637
638         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
639         (ChromiumWinPort.default_max_locked_shards):
640         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
641         (ChromiumWinTest.test_path_to_image_diff):
642         (ChromiumWinTest):
643         (ChromiumWinTest.test_default_max_locked_shards):
644
645 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
646
647         [chromium] move WebDatabase related methods to TestRunner library
648         https://bugs.webkit.org/show_bug.cgi?id=106905
649
650         Reviewed by Adam Barth.
651
652         * DumpRenderTree/chromium/DRTTestRunner.cpp:
653         (DRTTestRunner::DRTTestRunner):
654         (DRTTestRunner::reset):
655         * DumpRenderTree/chromium/DRTTestRunner.h:
656         (DRTTestRunner):
657         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
658         (WebTestRunner::WebTestDelegate::clearAllDatabases):
659         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
660         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
661         (WebTestRunner::TestRunner::TestRunner):
662         (WebTestRunner::TestRunner::reset):
663         (WebTestRunner::TestRunner::clearAllDatabases):
664         (WebTestRunner):
665         (WebTestRunner::TestRunner::setDatabaseQuota):
666         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
667         (TestRunner):
668         * DumpRenderTree/chromium/WebViewHost.cpp:
669         (WebViewHost::clearAllDatabases):
670         (WebViewHost::setDatabaseQuota):
671         * DumpRenderTree/chromium/WebViewHost.h:
672         (WebViewHost):
673
674 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
675
676         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
677         functionality match the name.
678         https://bugs.webkit.org/show_bug.cgi?id=106870
679
680         Reviewed by Adam Barth.
681
682         * Scripts/webkitpy/tool/commands/download.py:
683         (Clean):
684         (Update):
685         (Build):
686         (BuildAndTest):
687         (CheckStyle):
688         (BuildAttachment):
689         (BuildAndTestAttachment):
690         (AbstractPatchApplyingCommand):
691         (ApplyWatchList):
692         (AbstractPatchLandingCommand):
693         (CreateRollout):
694         * Scripts/webkitpy/tool/steps/__init__.py:
695         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
696         (CleanWorkingDirectory.options):
697         (CleanWorkingDirectory.run):
698         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
699         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
700         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
701
702 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
703
704         [Autotools] Add support for WebKit2-only builds
705         https://bugs.webkit.org/show_bug.cgi?id=106889
706
707         Reviewed by Gustavo Noronha Silva.
708
709         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
710         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
711         building the GTK port through build-webkit.
712         * Scripts/webkitdirs.pm:
713         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
714         arguments when not building WebKit1.
715         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
716         through the Autotools build system.
717
718 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
719
720         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
721         https://bugs.webkit.org/show_bug.cgi?id=106197
722
723         Reviewed by Martin Robinson.
724
725         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
726         features. Enable them on GTK, meaning they will be enabled in development builds
727         (i.e. when building with build-webkit).
728
729 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
730
731         [GTK] Enable CSS Image Resolution feature
732         https://bugs.webkit.org/show_bug.cgi?id=99038
733
734         Reviewed by Gustavo Noronha Silva.
735
736         Enable the CSS Image Resolution feature for the development
737         builds of the GTK port.
738
739         * Scripts/webkitperl/FeatureList.pm:
740
741 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
742
743         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
744         https://bugs.webkit.org/show_bug.cgi?id=106579
745
746         Reviewed by Gustavo Noronha Silva.
747
748         The --enable-unstable-features flag is not required to be passed anymore
749         to the configure script as it was removed in r138252.
750
751         * Scripts/webkitdirs.pm:
752         (buildAutotoolsProject):
753
754 2013-01-15  Tony Chang  <tony@chromium.org>
755
756         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
757
758         * Scripts/webkitpy/layout_tests/servers/http_server.py:
759         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
760         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
761         (TestHttpServer.test_win32_start_and_stop):
762
763 2013-01-15  Joshua Bell  <jsbell@chromium.org>
764
765         Unreviewed. Adding Michael Pruett as contributor.
766
767         * Scripts/webkitpy/common/config/committers.py:
768
769 2013-01-15  Victor Carbune  <victor@rosedu.org>
770
771         Unreviewed. Update my email addresses.
772
773         * Scripts/webkitpy/common/config/committers.py:
774
775 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
776
777         [GTK] Waiting on the gdb process will lead to deadlock
778         https://bugs.webkit.org/show_bug.cgi?id=106906
779
780         Reviewed by Philippe Normand.
781
782         Use communicate() rather than wait() on the Popen object that's running the gdb
783         command. This avoids the deadlock that occurs on the GTK builders.
784
785         * Scripts/webkitpy/layout_tests/port/gtk.py:
786         (GtkPort._get_gdb_output):
787
788 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
789
790         [GTK] Limit the number of frames printed out when backtracing with gdb
791         https://bugs.webkit.org/show_bug.cgi?id=106901
792
793         Reviewed by Philippe Normand.
794
795         Printing an unlimited number of frames when dumping the gdb backtracing
796         output can cause timeouts in the builders. This patch limits the number
797         of frames that are printed out to 1024.
798
799         * Scripts/webkitpy/layout_tests/port/gtk.py:
800         (GtkPort._get_gdb_output):
801
802 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
803
804         [Qt] Fix ImageDiff's image format conversion
805         https://bugs.webkit.org/show_bug.cgi?id=106880
806
807         Reviewed by Csaba Osztrogonác.
808
809         Besides actually doing the conversion this also silences the suspicious warning:
810         "ignoring return value of function declared with warn_unused_result attribute".
811
812         * ImageDiff/qt/ImageDiff.cpp:
813         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
814         copy of the image in the given format and does not alter the image itself.
815
816 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
817
818         [chromium] move remaining methods that just set a boolean flag to TestRunner library
819         https://bugs.webkit.org/show_bug.cgi?id=106823
820
821         Reviewed by Darin Fisher.
822
823         * DumpRenderTree/chromium/DRTTestRunner.cpp:
824         (DRTTestRunner::DRTTestRunner):
825         (DRTTestRunner::reset):
826         * DumpRenderTree/chromium/DRTTestRunner.h:
827         (DRTTestRunner):
828         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
829         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
830         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
831         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
832         (WebTestRunner::WebTestRunner::testRepaint):
833         (WebTestRunner::WebTestRunner::sweepHorizontally):
834         (WebTestRunner::WebTestRunner::isPrinting):
835         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
836         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
837         (WebTestRunner::TestRunner::TestRunner):
838         (WebTestRunner::TestRunner::reset):
839         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
840         (WebTestRunner):
841         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
842         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
843         (WebTestRunner::TestRunner::testRepaint):
844         (WebTestRunner::TestRunner::sweepHorizontally):
845         (WebTestRunner::TestRunner::isPrinting):
846         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
847         (WebTestRunner::TestRunner::dumpBackForwardList):
848         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
849         (WebTestRunner::TestRunner::dumpSelectionRect):
850         (WebTestRunner::TestRunner::repaintSweepHorizontally):
851         (WebTestRunner::TestRunner::setPrinting):
852         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
853         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
854         (TestRunner):
855
856 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
857
858         nrwt: stub out show_results_html for mock ports
859         https://bugs.webkit.org/show_bug.cgi?id=106848
860
861         Reviewed by Ojan Vafai.
862
863         We were accidentally using the underlying ports'
864         show_results_html_file() implementation, which would, unsurprisingly,
865         fail in many cases (e.g., running mock-efl on the mac).
866
867         No test added since we don't generally add tests for the mock
868         implementation.
869
870         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
871         (MockDRTPort.show_results_html_file):
872
873 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
874
875         Changing clean_working_directory/clean_local_commits and related
876         functions to have consistent naming.
877
878         https://bugs.webkit.org/show_bug.cgi?id=104198
879
880         Reviewed by Adam Barth.
881
882         * Scripts/webkitpy/common/checkout/scm/git.py:
883         * Scripts/webkitpy/common/checkout/scm/scm.py:
884         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
885         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
886         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
887         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
888
889 2013-01-14  Alan Cutter  <alancutter@chromium.org>
890
891         Fix EWS GCE build scripts to detect which zone is available
892         https://bugs.webkit.org/show_bug.cgi?id=106524
893
894         Reviewed by Adam Barth.
895
896         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
897         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
898         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
899         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
900
901 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
902
903         Adding an error string to AmbiguousCommitError.
904         https://bugs.webkit.org/show_bug.cgi?id=106846
905
906         Reviewed by Adam Barth.
907
908         * Scripts/webkitpy/common/checkout/scm/git.py:
909         (AmbiguousCommitError.__init__):
910
911 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
912
913         kill whole lighttpd process tree for chromium win
914         https://bugs.webkit.org/show_bug.cgi?id=106838
915
916         Reviewed by Tony Chang.
917
918         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
919         I think a test is causing a httpd server child process to wedge and
920         killing the parent httpd server process isn't sufficient to ensure
921         that the children are also killed.
922
923         * Scripts/webkitpy/layout_tests/servers/http_server.py:
924         (Lighttpd._check_and_kill):
925         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
926         (TestHttpServer.test_start_cmd):
927         (TestHttpServer):
928         (TestHttpServer.test_win32_start_and_stop):
929         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
930         (TestHttpServer.test_win32_start_and_stop.mock_returns):
931         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
932
933 2013-01-14  Nico Weber  <thakis@chromium.org>
934
935         [chromium] Enable `update-webkit --chromium --ninja` on windows
936         https://bugs.webkit.org/show_bug.cgi?id=106836
937
938         Reviewed by Eric Seidel.
939
940         After running this, build-webkit --chromium will use ninja to build.
941         Apparently there are some minor issues with that still, so it's
942         not quite ready for use yet.
943
944         * Scripts/webkitdirs.pm:
945         (determineIsChromiumNinja):
946         (buildChromium):
947
948 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
949
950         nrwt: use the same search path for baselines and TestExpectations on apple mac
951         https://bugs.webkit.org/show_bug.cgi?id=105599
952
953         Reviewed by Ryosuke Niwa.
954
955         Bug 105583 revealed some confusion due to the fact that the Apple
956         Mac port used a different list of directories to search for baselines
957         and TestExpectations files (actually, pretty much every port does).
958
959         It seems like a good idea to use the same list for both by default, but
960         making this happen will affect every port in slightly different ways, so
961         we'll try this on the Apple Mac port first.
962
963         Note that the effective changes for this are that:
964         1) The apple mac port will look in platform/wk2 for baselines where
965         it didn't before (it will look after looking in mac-wk2 but before
966         the non-wk2 dirs)
967         2) The apple mac-snowleopard port will use the expectations in
968         mac-lion as well as the expectations in mac-snowleopard, although
969         I'm not even sure if mac-snowleopard is still supported ...
970
971         * Scripts/webkitpy/layout_tests/port/mac.py:
972         (MacPort.default_baseline_search_path):
973         (MacPort.expectations_files):
974         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
975         (test_baseline_search_path):
976
977 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
978
979         AX: Need to implement ColorWellRole
980         https://bugs.webkit.org/show_bug.cgi?id=106756
981
982         Reviewed by Chris Fleizach.
983
984         Returns a string representation of the value of a color
985         when the role is Color Well, to make it easy to write layout
986         tests for color controls.
987
988         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
989
990 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
991
992         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
993         https://bugs.webkit.org/show_bug.cgi?id=106682
994
995         Reviewed by Chris Fleizach.
996
997         Modify Chromium's DRT implementation of intValue to return a
998         different value depending on the role.
999
1000         There are actually platform-specific differences in what should
1001         be returned in the "value" of an object, so Chromium normally keeps
1002         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1003         but this is a fine simplification to make cross-platform tests easier.
1004
1005         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1006         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1007
1008 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1009
1010         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1011         https://bugs.webkit.org/show_bug.cgi?id=106785
1012
1013         Reviewed by Adam Barth.
1014
1015         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1016         (DRTTestRunner::DRTTestRunner):
1017         (DRTTestRunner::reset):
1018         * DumpRenderTree/chromium/DRTTestRunner.h:
1019         (DRTTestRunner):
1020         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1021         (WebTestProxyBase):
1022         (WebTestRunner::WebTestProxy::setStatusText):
1023         (WebTestRunner::WebTestProxy::didStopLoading):
1024         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1025         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1026         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1027         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1028         (WebTestRunner::TestRunner::TestRunner):
1029         (WebTestRunner::TestRunner::reset):
1030         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1031         (WebTestRunner):
1032         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1033         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1034         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1035         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1036         (TestRunner):
1037         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1038         (WebTestRunner::WebTestProxyBase::setStatusText):
1039         (WebTestRunner):
1040         (WebTestRunner::WebTestProxyBase::didStopLoading):
1041         * DumpRenderTree/chromium/WebViewHost.cpp:
1042         (WebViewHost::didStopLoading):
1043         * DumpRenderTree/chromium/WebViewHost.h:
1044         (WebViewHost):
1045
1046 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1047
1048         Web Inspector: devtools front-end doesn't have focus in TestShell
1049         https://bugs.webkit.org/show_bug.cgi?id=106778
1050
1051         Reviewed by Pavel Feldman.
1052
1053         Focus devTools window after loadURL method.
1054
1055         * DumpRenderTree/chromium/TestShell.cpp:
1056         (TestShell::runFileTest):
1057
1058 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1059
1060         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1061         https://bugs.webkit.org/show_bug.cgi?id=106573
1062
1063         Reviewed by Philippe Normand.
1064
1065         Similarly to what's been described in bug 106569, we're building
1066         from release tarballs, so there's no reason to regenerate the
1067         autoconf-related stuff with autogen.sh, especially since we might
1068         run into trouble with automake 1.13 and deprecated macros.
1069
1070         * efl/jhbuild.modules:
1071
1072 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1073
1074         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
1075         https://bugs.webkit.org/show_bug.cgi?id=104909
1076
1077         Reviewed by Simon Hausmann.
1078
1079         To be able to build redistribuable binary packages, Qt's configure switches
1080         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
1081         dynamically link to optional system libraries.
1082         QtWebKit is doing its own configure checks for those libraries, thus adding a
1083         runtime dependency that might not be fulfilled if the packager's machine had
1084         those libraries while the user's machine won't.
1085
1086         Since in most cases where WebKit will want to use those system libraries, Qt will
1087         also be using them, remove these configure tests from WebKit.
1088
1089         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
1090         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
1091         * qmake/config.tests/libpng/libpng.cpp: Removed.
1092         * qmake/config.tests/libpng/libpng.pro: Removed.
1093         * qmake/mkspecs/features/features.prf:
1094
1095 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1096
1097         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
1098         https://bugs.webkit.org/show_bug.cgi?id=106574
1099
1100         Reviewed by Laszlo Gombos.
1101
1102         Rely on a more recent stable release, which includes support for
1103         Lua 5.2 in Edje and other assorted minor fixes.
1104
1105         While here, also use the "configure" script to build the libraries
1106         instead of relying on autogen.sh, which is not really needed with
1107         a release tarball and may have problems with automake 1.13.
1108
1109         * efl/jhbuild.modules:
1110
1111 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1112
1113         Web Inspector: fix DRT to deliver simulated events to devtools front-end
1114         https://bugs.webkit.org/show_bug.cgi?id=106650
1115
1116         Reviewed by Pavel Feldman.
1117
1118         Add separated m_devToolsTestInterfaces object to testShell which is
1119         bind to devTools webview.
1120
1121         * DumpRenderTree/chromium/TestShell.cpp:
1122         (TestShell::initialize):
1123         (TestShell::createMainWindow):
1124         (TestShell::~TestShell):
1125         (TestShell::showDevTools):
1126         (TestShell::resetTestController):
1127         (TestShell::bindJSObjectsToWindow):
1128         (TestShell::createNewWindow):
1129         * DumpRenderTree/chromium/TestShell.h:
1130         (TestShell):
1131
1132 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1133
1134         Sheriffbot command aliases need test cases
1135         https://bugs.webkit.org/show_bug.cgi?id=106754
1136
1137         Reviewed by Eric Seidel.
1138
1139         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1140         (SheriffBotTest.test_command_aliases):
1141
1142 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1143
1144         Allow users to misspell the "sheriffs" command in sheriffbot
1145         https://bugs.webkit.org/show_bug.cgi?id=106628
1146
1147         Reviewed by Steve Block.
1148
1149         * Scripts/webkitpy/tool/bot/irc_command.py:
1150
1151 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1152
1153         Make "gardeners" an alias for "sheriffs" in sherrifbot
1154         https://bugs.webkit.org/show_bug.cgi?id=106627
1155
1156         Reviewed by Eric Seidel.
1157
1158         * Scripts/webkitpy/tool/bot/irc_command.py:
1159
1160 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
1161
1162         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
1163         https://bugs.webkit.org/show_bug.cgi?id=105380
1164
1165         Reviewed by Eric Seidel.
1166
1167         Fix a regression introduced in r137692 where we were double-encoding
1168         the arguments to popen(); this was only an issue on windows, where
1169         we would try to encode something to mbcs, then try to encode it
1170         to unicode as if the input as ascii.
1171
1172         * Scripts/webkitpy/common/system/executive.py:
1173         (Executive.run_command):
1174
1175 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1176
1177         State who told sheriffbot to roll the Chromium deps and to what revision
1178         https://bugs.webkit.org/show_bug.cgi?id=106626
1179
1180         Reviewed by Eric Seidel.
1181
1182         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
1183
1184         * Scripts/webkitpy/tool/bot/irc_command.py:
1185         (RollChromiumDEPS._expand_irc_nickname):
1186         (RollChromiumDEPS.execute):
1187         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1188         (IRCCommandTest.test_roll_chromium_deps):
1189         * Scripts/webkitpy/tool/bot/sheriff.py:
1190         (Sheriff.post_chromium_deps_roll):
1191         * Scripts/webkitpy/tool/commands/roll.py:
1192         (RollChromiumDEPS._prepare_state):
1193         (PostChromiumDEPSRoll):
1194         (PostChromiumDEPSRoll._prepare_state):
1195         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1196         (PostRollCommandsTest.test_prepare_state):
1197         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1198         (PrepareChangeLogForDEPSRoll.run):
1199
1200 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1201
1202         Add Alan Cutter as contributor
1203         https://bugs.webkit.org/show_bug.cgi?id=106747
1204
1205         Reviewed by Eric Seidel.
1206
1207         * Scripts/webkitpy/common/config/committers.py:
1208
1209 2013-01-13  Jonathan Liu  <net147@gmail.com>
1210
1211         Fix CONFIG missing link_pkgconfig on Windows
1212         https://bugs.webkit.org/show_bug.cgi?id=106647
1213
1214         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1215         properly on Windows because they are added to PKGCONFIG but
1216         CONFIG does not contain link_pkgconfig.
1217
1218         This is because link_pkgconfig is added in unix/default_pre.prf
1219         which is only used for UNIX platforms. To fix this, move it to
1220         the general default_pre.prf.
1221
1222         Reviewed by Simon Hausmann.
1223
1224         * qmake/mkspecs/features/default_pre.prf:
1225         * qmake/mkspecs/features/unix/default_pre.prf:
1226
1227 2013-01-12  Nico Weber  <thakis@chromium.org>
1228
1229         nrwt/chromium: Don't prefer chromium over webkit build directories
1230         https://bugs.webkit.org/show_bug.cgi?id=105597
1231
1232         Reviewed by Dirk Pranke.
1233
1234         Rely on the new timestamp logic instead. Requested by dpranke in
1235         https://bugs.webkit.org/show_bug.cgi?id=105498
1236
1237         * Scripts/webkitpy/layout_tests/port/chromium.py:
1238         (ChromiumPort._static_build_path):
1239         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1240         (ChromiumLinuxPortTest.test_build_path):
1241         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1242         (ChromiumMacPortTest.test_build_path):
1243         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1244         (ChromiumWinTest.test_build_path):
1245
1246 2013-01-12  Nico Weber  <thakis@chromium.org>
1247
1248         Use ninja by default on Linux for build-webkit --chromium, bot edition
1249         https://bugs.webkit.org/show_bug.cgi?id=104434
1250
1251         Reviewed by Eric Seidel.
1252
1253         r139557 changed update-webkit to pick ninja by default on linux, but
1254         the bots run update-webkit-chromium directly so they didn't see this.
1255         Move the default for ninja into update-webkit-chromium so that it's
1256         picked up by the bots, and let update-webkit forward non-default
1257         options to there.
1258
1259         This way, the default is in one place only and both developers (who
1260         usually use update-webkit which then shells out to
1261         updat-webkit-chromium) and bots (which use update-webkit-chromium
1262         directly) see the same behavior.
1263
1264         * Scripts/update-webkit:
1265         * Scripts/update-webkit-chromium:
1266
1267 2013-01-12  Nico Weber  <thakis@chromium.org>
1268
1269         Make ninja the default build system on Linux for build-webkit --chromium
1270         https://bugs.webkit.org/show_bug.cgi?id=104434
1271
1272         Reviewed by Eric Seidel.
1273
1274         * Scripts/update-webkit:
1275
1276 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1277
1278         Migrate the remaining bots in EC2 to Google Compute Engine
1279         https://bugs.webkit.org/show_bug.cgi?id=106005
1280
1281         Reviewed by Eric Seidel.
1282
1283         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1284
1285         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1286         * EWSTools/boot.sh:
1287         * EWSTools/build-repo.sh:
1288         * EWSTools/start-queue.sh:
1289
1290 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1291
1292         [chromium] move inspector related methods to TestRunner library
1293         https://bugs.webkit.org/show_bug.cgi?id=106654
1294
1295         Reviewed by Adam Barth.
1296
1297         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1298         (DRTTestRunner::DRTTestRunner):
1299         * DumpRenderTree/chromium/DRTTestRunner.h:
1300         (DRTTestRunner):
1301         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1302         (WebTestRunner::WebTestDelegate::showDevTools):
1303         (WebTestRunner::WebTestDelegate::closeDevTools):
1304         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1305         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1306         (WebTestRunner::TestRunner::TestRunner):
1307         (WebTestRunner::TestRunner::showWebInspector):
1308         (WebTestRunner):
1309         (WebTestRunner::TestRunner::closeWebInspector):
1310         (WebTestRunner::TestRunner::evaluateInWebInspector):
1311         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1312         (TestRunner):
1313         * DumpRenderTree/chromium/WebViewHost.cpp:
1314         (WebViewHost::showDevTools):
1315         (WebViewHost::closeDevTools):
1316         (WebViewHost::evaluateInWebInspector):
1317         * DumpRenderTree/chromium/WebViewHost.h:
1318         (WebViewHost):
1319
1320 2013-01-11  Julie Parent  <jparent@chromium.org>
1321
1322         Builder should not be a valid parameter for stats dashboard
1323         https://bugs.webkit.org/show_bug.cgi?id=106698
1324
1325         Reviewed by Dirk Pranke.
1326         
1327         Since builder is a dashboard specific parameter, dashboard_base
1328         should not be handling it in handleValidHashParameterWrapper, rather,
1329         each specific dashboard should in its handleValidHashParameter function.
1330     
1331         Note that the FIXME in dashboard_base about this was actually wrong -
1332         we don't want to move it to g_crossDashboardState, because it isn't
1333         actually cross dashboard state.
1334         
1335         In fact, flakiness and treemap have the code in 
1336         handleValidHashParameter, but it is currently dead code because 
1337         dashboard_base gets to it first.
1338         
1339         Added the proper handling to timeline_explorer, since builder is
1340         valid there.
1341
1342         * TestResultServer/static-dashboards/dashboard_base.js:
1343         * TestResultServer/static-dashboards/timeline_explorer.html:
1344
1345 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1346
1347         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1348         https://bugs.webkit.org/show_bug.cgi?id=106688
1349
1350         Reviewed by Eric Seidel.
1351
1352         Update the regular expression used to strip the garbage at the beginning.
1353
1354         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1355         (RunWebKitTests.nrwt_log_message_regexp):
1356
1357 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1358
1359         TestRunner leaks when running tests
1360         https://bugs.webkit.org/show_bug.cgi?id=106683
1361
1362         Reviewed by Simon Fraser.
1363
1364         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1365         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1366         tests.
1367
1368         * DumpRenderTree/TestRunner.cpp:
1369         (TestRunner::makeWindowObject):
1370
1371 2013-01-11  Julie Parent  <jparent@chromium.org>
1372
1373         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1374         https://bugs.webkit.org/show_bug.cgi?id=106247
1375
1376         Old code nulled out the loader instance when it completed loading and
1377         then later used the fact that it was null to determine if it had loaded
1378         or not.  This is not only unintuitive, but it also prevents using the
1379         loader object later on.
1380         
1381         Added new method, used it, added unit test for it.
1382         
1383         Reviewed by Dirk Pranke.
1384
1385         * TestResultServer/static-dashboards/dashboard_base.js:
1386         (resourceLoadingComplete):
1387         (handleLocationChange):
1388         * TestResultServer/static-dashboards/loader.js:
1389         (.):
1390         * TestResultServer/static-dashboards/loader_unittests.js:
1391
1392 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1393
1394         Try CRLF to LF change in r139407 again.
1395
1396         * BuildSlaveSupport/delete-stale-build-files:
1397         (main):
1398         (webkitBuildDirectory):
1399         * BuildSlaveSupport/kill-old-processes:
1400         (main):
1401
1402 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1403
1404         [GTK] Disable the unit tests timeout when running from make check
1405         https://bugs.webkit.org/show_bug.cgi?id=106670
1406
1407         Reviewed by Philippe Normand.
1408
1409         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1410
1411 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1412
1413         Yet another unreviewed fix after r139431.
1414
1415         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1416         the correct order.
1417
1418 2013-01-11  Dan Carney  <dcarney@google.com>
1419
1420         [chromium] move some whitespace and resize related methods to TestRunner library
1421         https://bugs.webkit.org/show_bug.cgi?id=106655
1422
1423         Reviewed by Jochen Eisinger.
1424
1425         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1426         (DRTTestRunner::DRTTestRunner):
1427         * DumpRenderTree/chromium/DRTTestRunner.h:
1428         (DRTTestRunner):
1429         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1430         (WebKit):
1431         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1432         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1433         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1434         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1435         (WebTestRunner::TestRunner::TestRunner):
1436         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1437         (WebTestRunner):
1438         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1439         (WebTestRunner::TestRunner::enableAutoResizeMode):
1440         (WebTestRunner::TestRunner::disableAutoResizeMode):
1441         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1442         (TestRunner):
1443         * DumpRenderTree/chromium/WebViewHost.cpp:
1444         (WebViewHost::setClientWindowRect):
1445         * DumpRenderTree/chromium/WebViewHost.h:
1446         (WebViewHost):
1447
1448 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1449
1450         Unreviewed. Update my e-mail addresses.
1451
1452         * Scripts/webkitpy/common/config/committers.py:
1453
1454 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1455
1456         Another unreviewed fix after r139431.
1457
1458         In a way, this is also a generic bug fix, since previously isEfl()
1459         would fail when called from run-efl-tests and we thus did not use
1460         jhbuild to run our tests. This now resulted in us calling
1461         "jhbuild-wrapper run" without specifying a platform.
1462
1463         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1464         to work.
1465
1466 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1467
1468         [Qt][WK1] Web Audio support
1469         https://bugs.webkit.org/show_bug.cgi?id=106651
1470
1471         Reviewed by Jocelyn Turcotte.
1472
1473         Implements support for dumping audio data in DumpRenderTree.
1474
1475         Adds WebAudio to toggleable features in QtTestBrowser.
1476
1477         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1478         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1479
1480         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1481         (WebCore::DumpRenderTree::dump):
1482         * DumpRenderTree/qt/TestRunnerQt.cpp:
1483         (TestRunner::reset):
1484         (TestRunner::overridePreference):
1485         (TestRunner::setAudioData):
1486         * DumpRenderTree/qt/TestRunnerQt.h:
1487         (TestRunner::shouldDumpAsAudio):
1488         (TestRunner::audioData):
1489         (TestRunner):
1490         * QtTestBrowser/launcherwindow.cpp:
1491         (LauncherWindow::applyPrefs):
1492         (LauncherWindow::createChrome):
1493         (LauncherWindow::toggleWebAudio):
1494         * QtTestBrowser/launcherwindow.h:
1495         (WindowOptions::WindowOptions):
1496         (WindowOptions):
1497         (LauncherWindow):
1498         * qmake/mkspecs/features/features.prf:
1499         * qmake/mkspecs/features/features.pri:
1500
1501 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1502
1503         Unreviewed jhbuild-related fix after r139431.
1504
1505         * Scripts/webkitpy/layout_tests/port/efl.py:
1506         (EflPort.__init__): Pass a string to set_option_default(), since
1507         shlex.split() will be called on it later.
1508
1509 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1510
1511         Unreviewed typo fixes after r139431.
1512
1513         * Scripts/run-javascriptcore-tests:
1514
1515 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1516
1517         [jhbuild] Remove the "run-with-jhbuild" scripts.
1518         https://bugs.webkit.org/show_bug.cgi?id=106572
1519
1520         Reviewed by Martin Robinson.
1521
1522         Both ports which use jhbuild were mostly duplicating the
1523         `run-with-jhbuild' script in their own directories for no clear reason.
1524
1525         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1526         so just start using that directly and get rid of a useless middle man.
1527
1528         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1529         instead.
1530
1531         * Scripts/run-javascriptcore-tests:
1532         * Scripts/run-launcher:
1533         * Scripts/webkitdirs.pm:
1534         (runAutogenForAutotoolsProjectIfNecessary):
1535         (buildAutotoolsProject):
1536         (jhbuildWrapperPrefixIfNeeded):
1537         (generateBuildSystemFromCMakeProject):
1538         (buildCMakeGeneratedProject):
1539         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1540         (run):
1541         * Scripts/webkitpy/layout_tests/port/efl.py:
1542         (EflPort.__init__):
1543         (EflPort._image_diff_command):
1544         * efl/run-with-jhbuild: Removed.
1545         * gtk/run-with-jhbuild: Removed.
1546
1547 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1548
1549         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1550         https://bugs.webkit.org/show_bug.cgi?id=106636
1551
1552         Reviewed by Adam Barth.
1553
1554         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1555
1556         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1557         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1558         * EWSTools/screen-config:
1559         * EWSTools/start-queue.sh:
1560
1561 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1562
1563         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1564         https://bugs.webkit.org/show_bug.cgi?id=106622
1565
1566         Reviewed by Simon Fraser.
1567
1568         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1569         Also escape clang\+\+ correctly in kill-old-processes.
1570
1571         * BuildSlaveSupport/delete-stale-build-files:
1572         * BuildSlaveSupport/kill-old-processes:
1573
1574 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1575
1576         Build fix after r139357. It was missing a comma.
1577
1578         * QueueStatusServer/model/queues.py:
1579         (Queue):
1580
1581 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1582
1583         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1584         https://bugs.webkit.org/show_bug.cgi?id=106420
1585
1586         Reviewed by Eric Seidel.
1587
1588         * Scripts/webkitpy/common/checkout/scm/git.py:
1589         (Git.push_local_commits_to_server):
1590         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1591         * Scripts/webkitpy/common/checkout/scm/svn.py:
1592         (SVNRepository):
1593         (SVNRepository.has_authorization_for_realm):
1594
1595 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1596
1597         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1598         https://bugs.webkit.org/show_bug.cgi?id=106552
1599
1600         Reviewed by Laszlo Gombos.
1601
1602         Use tarballs for gstreamer instead of git in EFL's jhbuild
1603         to work around intermittent network issues on our build
1604         bots. Tarballs are fully cached and require no network
1605         operation if their checksum matches.
1606
1607         * efl/jhbuild.modules:
1608
1609 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1610
1611         Add Mac WK2 EWS bots
1612         https://bugs.webkit.org/show_bug.cgi?id=106590
1613
1614         Reviewed by Adam Barth.
1615
1616         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1617         Also add a deprecated MacWK2Port class.
1618
1619         * QueueStatusServer/model/queues.py:
1620         (Queue):
1621         * Scripts/webkitpy/common/config/ports.py:
1622         (DeprecatedPort.port):
1623         (MacWK2Port):
1624         (MacWK2Port.run_webkit_tests_command):
1625         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1626         (MacEWS):
1627         (MacWK2EWS):
1628         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1629         (_test_ewses):
1630
1631 2013-01-10  Dan Carney  <dcarney@google.com>
1632
1633         [chromium] move webpermissionclient related methods to TestRunner library
1634         https://bugs.webkit.org/show_bug.cgi?id=106548
1635
1636         Reviewed by Jochen Eisinger.
1637
1638         * DumpRenderTree/DumpRenderTree.gypi:
1639         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1640         (DRTTestRunner::DRTTestRunner):
1641         (DRTTestRunner::reset):
1642         * DumpRenderTree/chromium/DRTTestRunner.h:
1643         (DRTTestRunner):
1644         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1645         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1646         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1647         (WebKit):
1648         (WebTestRunner::WebTestRunner::webPermissions):
1649         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1650         (WebTestRunner::TestRunner::TestRunner):
1651         (WebTestRunner::TestRunner::setDelegate):
1652         (WebTestRunner):
1653         (WebTestRunner::TestRunner::reset):
1654         (WebTestRunner::TestRunner::webPermissions):
1655         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1656         (WebTestRunner::TestRunner::setImagesAllowed):
1657         (WebTestRunner::TestRunner::setScriptsAllowed):
1658         (WebTestRunner::TestRunner::setStorageAllowed):
1659         (WebTestRunner::TestRunner::setPluginsAllowed):
1660         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1661         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1662         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1663         (WebTestRunner):
1664         (TestRunner):
1665         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1666         (WebTestRunner):
1667         (WebTestRunner::WebPermissions::WebPermissions):
1668         (WebTestRunner::WebPermissions::~WebPermissions):
1669         (WebTestRunner::WebPermissions::allowImage):
1670         (WebTestRunner::WebPermissions::allowScriptFromSource):
1671         (WebTestRunner::WebPermissions::allowStorage):
1672         (WebTestRunner::WebPermissions::allowPlugins):
1673         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1674         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1675         (WebTestRunner::WebPermissions::setImagesAllowed):
1676         (WebTestRunner::WebPermissions::setScriptsAllowed):
1677         (WebTestRunner::WebPermissions::setStorageAllowed):
1678         (WebTestRunner::WebPermissions::setPluginsAllowed):
1679         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1680         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1681         (WebTestRunner::WebPermissions::setDelegate):
1682         (WebTestRunner::WebPermissions::setDumpCallbacks):
1683         (WebTestRunner::WebPermissions::reset):
1684         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1685         (WebTestRunner):
1686         (WebPermissions):
1687         * DumpRenderTree/chromium/TestShell.cpp:
1688         (TestShell::initialize):
1689         (TestShell::resetTestController):
1690         (TestShell::createNewWindow):
1691         * DumpRenderTree/chromium/TestShell.h:
1692         (TestShell):
1693         * DumpRenderTree/chromium/WebViewHost.cpp:
1694         (WebViewHost::normalizeLayoutTestURL):
1695         * DumpRenderTree/chromium/WebViewHost.h:
1696         (WebViewHost):
1697
1698 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1699
1700         Split EWS tool cold-boot.sh into modular components
1701         https://bugs.webkit.org/show_bug.cgi?id=106527
1702
1703         Reviewed by Adam Barth.
1704
1705         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1706         Updated GCE bot build scripts to match.
1707         Unable to test scripts directly as they depend on being in the repository to work!
1708
1709         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1710         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1711         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1712         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1713         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1714
1715 2013-01-10  Julie Parent  <jparent@chromium.org>
1716
1717         Dashboard Cleanup: Do not generate the page if we are about to reload.
1718         https://bugs.webkit.org/show_bug.cgi?id=106584
1719
1720         Reviewed by Dirk Pranke.
1721
1722         Move the logic to determine if we should generate the page into
1723         parseParameters() since that is where we have the knowledge to
1724         determine it, and return that value to handleLocationChange, 
1725         rather than passing the changed parameters back to handleLocationChange
1726         and having it make the decision.
1727         
1728         This is logically equivalent, save one case: when we are about to do
1729         a reload, we know that there is no reason to generate the page.  Old
1730         code was causing an extra page generation in this case.
1731         
1732         * TestResultServer/static-dashboards/dashboard_base.js:
1733         (parseParameters):
1734         (handleLocationChange):
1735
1736 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1737
1738         [jhbuild] Use the "configure" script to build glib
1739         https://bugs.webkit.org/show_bug.cgi?id=106569
1740
1741         Reviewed by Martin Robinson.
1742
1743         So far both EFL and GTK have been using autogen.sh to build glib.
1744         While that does work most of the time, it's not really needed since
1745         we are downloading and building stable releases from tarballs.
1746         Additionally, autogen.sh fails to work with automake 1.13 due to the
1747         usage of some macros that have been removed (this has already been
1748         fixed in glib master).
1749
1750         * efl/jhbuild.modules:
1751         * gtk/jhbuild.modules:
1752
1753 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1754
1755         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1756         (Missed a couple)
1757         https://bugs.webkit.org/show_bug.cgi?id=106536
1758
1759         Reviewed by Eric Seidel.
1760
1761         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1762
1763 2013-01-10  Tony Chang  <tony@chromium.org>
1764
1765         Speed up supplemental dependency computation
1766         https://bugs.webkit.org/show_bug.cgi?id=106503
1767
1768         Reviewed by Adam Barth.
1769
1770         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1771
1772         * WebKitTestRunner/CMakeLists.txt:
1773
1774 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1775
1776         Remove the ENABLE_ANIMATION_API feature define occurences
1777         https://bugs.webkit.org/show_bug.cgi?id=106544
1778
1779         Reviewed by Simon Fraser.
1780
1781         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1782         feature define handling still lingers in various build systems and configurations
1783         but is of no use, so it should be removed.
1784
1785         * Scripts/webkitperl/FeatureList.pm:
1786         * qmake/mkspecs/features/features.pri:
1787
1788 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1789
1790         [GTK] Add support for loading web process extensions
1791         https://bugs.webkit.org/show_bug.cgi?id=105631
1792
1793         Reviewed by Gustavo Noronha Silva.
1794
1795         * MiniBrowser/gtk/GNUmakefile.am:
1796         * MiniBrowser/gtk/main.c:
1797         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1798         bundle lib from build dir.
1799         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1800         located in WebProcess/InjectedBundle/API/gtk.
1801         * gtk/generate-gtkdoc:
1802         (get_webkit2_options): Scan also files in
1803         WebProcess/InjectedBundle/API/gtk to generate API docs.
1804         (get_webkit2_options.injected_bundle_src_path): Helper function to
1805         build paths in WebProcess/InjectedBundle/API/gtk.
1806
1807 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1808
1809         [EFL][WK2] Writing immediately to created windows (open) fails
1810         https://bugs.webkit.org/show_bug.cgi?id=105276
1811
1812         Reviewed by Kenneth Rohde Christiansen.
1813
1814         Do not reset 'about:blank' url for the new pages in mini browser.
1815
1816         * MiniBrowser/efl/main.c:
1817         (window_create):
1818
1819 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1820
1821         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1822         https://bugs.webkit.org/show_bug.cgi?id=106536
1823
1824         Reviewed by Eric Seidel.
1825
1826         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1827
1828 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1829
1830         Converting to unittest2 so we can use assertItemsEqual, making tests
1831         not dependent on order of items.
1832         https://bugs.webkit.org/show_bug.cgi?id=106532
1833
1834         Before:
1835         Ran 1733 tests in 38.385s
1836         FAILED (failures=1, errors=22)
1837
1838         After:
1839         Ran 1733 tests in 32.298s
1840         FAILED (failures=0, errors=22)
1841
1842         Reviewed by Eric Seidel.
1843
1844         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1845         * Scripts/webkitpy/thirdparty/__init__.py:
1846         (AutoinstallImportHook._install_unittest2):
1847
1848 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1849
1850         [EFL] Add gstreamer 1.0.5 to jhbuild
1851         https://bugs.webkit.org/show_bug.cgi?id=106178
1852
1853         Reviewed by Laszlo Gombos.
1854
1855         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1856
1857         * efl/jhbuild.modules:
1858
1859 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1860
1861         Updated parameters in GCE build scripts so they now work.
1862         https://bugs.webkit.org/show_bug.cgi?id=106523
1863
1864         Reviewed by Adam Barth.
1865
1866         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1867         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1868         * EWSTools/cold-boot.sh:
1869
1870 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1871
1872         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1873         https://bugs.webkit.org/show_bug.cgi?id=106520
1874
1875         Reviewed by James Robinson.
1876
1877         Part of a larger refactoring series. See tracking bug 82948.
1878
1879         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1880         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1881
1882 2013-01-09  Julie Parent  <jparent@chromium.org>
1883
1884         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1885         https://bugs.webkit.org/show_bug.cgi?id=106514
1886
1887         This is old code, as these can no longer get out of sync.
1888         permmaLinkURLHash is generated from currentState, which is set only
1889         from the location.  The commment about how these can get out of sync
1890         refers to a function that no longer exists.
1891         
1892         Reviewed by Dirk Pranke.
1893
1894         * TestResultServer/static-dashboards/dashboard_base.js:
1895         (handleLocationChange):
1896
1897 2013-01-09  Julie Parent  <jparent@chromium.org>
1898
1899         Dashboard Cleanup: Reload the page as soon as we know we need to.
1900         https://bugs.webkit.org/show_bug.cgi?id=106515
1901
1902         No need to continue parsing all of the data once we know that
1903         we need to do a reload.
1904         
1905         Reviewed by Dirk Pranke.
1906
1907         * TestResultServer/static-dashboards/dashboard_base.js:
1908         (parseParameters):
1909
1910 2013-01-09  Eric Seidel  <eric@webkit.org>
1911
1912         run-perf-tests --chromium-android --profile should show symbols for the kernel
1913         https://bugs.webkit.org/show_bug.cgi?id=106498
1914
1915         Reviewed by Adam Barth.
1916
1917         Turns out this was easy, once I finally read the output from "perf report".
1918         It appears there may be a bug in "perf record" on android, as it complains
1919         about not being able to read from /proc/kallsyms even when
1920         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1921         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1922         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1923         and then flip it back to whatever the device had.
1924
1925         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1926         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1927         to symbol names.  Its world-readable, but will return all 0s if you
1928         don't have permission to see the kernel symbols.  kptr_restrict
1929         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1930         1 is only a specific group, and 2 is "no one, not even root".
1931         By default kptr_restrict is 2 on Android it seems.
1932         More kptr_restrict docs: http://lwn.net/Articles/420403/
1933
1934         I also took this opportunity to clean up how the perf record command
1935         was built for use/display in AndroidPerf.profile_after_exit and
1936         change to always using long-form names for the arguments (to hopefully help readability).
1937
1938         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1939         (AndroidPerf.__init__):
1940         (profile_after_exit):
1941         (ChromiumAndroidDriver.__init__):
1942         (ChromiumAndroidDriver._update_kallsyms_cache):
1943         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1944
1945 2013-01-09  Julie Parent  <jparent@chromium.org>
1946
1947         Dashboard cleanup: remove dead code.
1948         https://bugs.webkit.org/show_bug.cgi?id=106509
1949
1950         Reviewed by Dirk Pranke.
1951
1952         * TestResultServer/static-dashboards/dashboard_base.js:
1953         (parseParameters):
1954
1955 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1956
1957         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1958         https://bugs.webkit.org/show_bug.cgi?id=105638
1959
1960         Reviewed by Martin Robinson.
1961
1962         The test was failing for two reasons:
1963         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1964           not ignoring the ARIA labelled-by property
1965         - AccessibilityController::accessibleElementById() was not implemented
1966
1967         Because getting an element by ID cannot be done in the UIProcess, the
1968         decision was made to expose the element's ID as an accessible attribute
1969         of the object.
1970
1971         In addition, fixing the bug in AccessibilityRenderObject made it possible
1972         to eliminate the Gtk platform-specific expectations for another test.
1973
1974         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1975         (childElementById): Added. Walks the tree looking for the AtkObject
1976         Attribute which exposes the HTML element's ID.
1977         (AccessibilityController::accessibleElementById): Implemented.
1978         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1979         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1980         when there is no title, as is done with the Mac port.
1981         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1982         (WTR):
1983         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1984         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1985         Attribute which exposes the HTML element's ID.
1986         (WTR):
1987         (WTR::AccessibilityController::accessibleElementById): Implemented.
1988         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1989         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1990         even when there is no title, as is done with the Mac port.
1991
1992 2013-01-09  Gregg Tavares  <gman@google.com>
1993
1994         Add Gregg Tavares as a committer
1995         https://bugs.webkit.org/show_bug.cgi?id=106492
1996
1997         Unreviewed.
1998
1999         * Scripts/webkitpy/common/config/committers.py:
2000
2001 2013-01-09  Roger Fong  <roger_fong@apple.com>
2002
2003         Enable seamless iFrames for Windows DRT.
2004         https://bugs.webkit.org/show_bug.cgi?id=106468.
2005
2006         Rubberstamped by Timothy Horton.
2007
2008         * DumpRenderTree/win/DumpRenderTree.cpp:
2009         (resetDefaultsToConsistentValues):
2010
2011 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2012
2013         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2014         https://bugs.webkit.org/show_bug.cgi?id=93979
2015
2016         Reviewed by Benjamin Poulain.
2017
2018         Implement eventSender.scheduleAsynchronousKeyDown() in
2019         WebKitTestRunner.
2020
2021         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2022         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2023         (WTR::createKeyDownMessageBody):
2024         (WTR::EventSendingController::keyDown):
2025         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2026         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2027         (EventSendingController):
2028         * WebKitTestRunner/TestController.cpp:
2029         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2030         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2031         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2032         * WebKitTestRunner/TestController.h:
2033         (TestController):
2034
2035 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2036
2037         [chromium] move resource load callback dumping to TestRunner library
2038         https://bugs.webkit.org/show_bug.cgi?id=106449
2039
2040         Reviewed by Adam Barth.
2041
2042         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2043         (DRTTestRunner::DRTTestRunner):
2044         (DRTTestRunner::reset):
2045         * DumpRenderTree/chromium/DRTTestRunner.h:
2046         (DRTTestRunner):
2047         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2048         (WebKit):
2049         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2050         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2051         (WebKit):
2052         (WebTestProxyBase):
2053         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2054         (WebTestRunner::WebTestProxy::willRequestResource):
2055         (WebTestRunner::WebTestProxy::willSendRequest):
2056         (WebTestRunner::WebTestProxy::didReceiveResponse):
2057         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2058         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2059         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2060         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2061         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
2062         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
2063         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2064         (WebTestRunner::TestRunner::TestRunner):
2065         (WebTestRunner::TestRunner::reset):
2066         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
2067         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
2068         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
2069         (WebTestRunner):
2070         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
2071         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
2072         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
2073         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2074         (TestRunner):
2075         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2076         (WebTestRunner::WebTestProxyBase::reset):
2077         (WebTestRunner):
2078         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2079         (WebTestRunner::WebTestProxyBase::willRequestResource):
2080         (WebTestRunner::WebTestProxyBase::willSendRequest):
2081         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
2082         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
2083         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
2084         * DumpRenderTree/chromium/WebViewHost.cpp:
2085         (WebViewHost::willSendRequest):
2086         (WebViewHost::makeURLErrorDescription):
2087         (WebViewHost::reset):
2088         * DumpRenderTree/chromium/WebViewHost.h:
2089         (WebViewHost):
2090
2091 2013-01-09  Dan Carney  <dcarney@google.com>
2092
2093         [chromium] move dumpcreateview methods to testrunner library
2094         https://bugs.webkit.org/show_bug.cgi?id=106434
2095
2096         Reviewed by Adam Barth.
2097
2098         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2099         (DRTTestRunner::DRTTestRunner):
2100         (DRTTestRunner::reset):
2101         * DumpRenderTree/chromium/DRTTestRunner.h:
2102         (DRTTestRunner):
2103         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2104         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
2105         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2106         (WebTestRunner::TestRunner::TestRunner):
2107         (WebTestRunner::TestRunner::reset):
2108         (WebTestRunner::TestRunner::shouldDumpCreateView):
2109         (WebTestRunner):
2110         (WebTestRunner::TestRunner::dumpCreateView):
2111         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2112         (TestRunner):
2113
2114 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
2115
2116         webkitpy cleanup: Merge additional_comment_text into comment_text
2117         https://bugs.webkit.org/show_bug.cgi?id=106421
2118
2119         Reviewed by Adam Barth.
2120
2121         * Scripts/webkitpy/common/config/committervalidator.py:
2122         (CommitterValidator.reject_patch_from_commit_queue):
2123         (CommitterValidator.reject_patch_from_review_queue):
2124         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2125         (Bugzilla.set_flag_on_attachment):
2126         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2127         (MockBugzilla.set_flag_on_attachment):
2128         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2129         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2130         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2131         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2132
2133 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2134
2135         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
2136         https://bugs.webkit.org/show_bug.cgi?id=106464
2137
2138         Reviewed by Martin Robinson.
2139
2140         Current version in jhbuild.modules (2.26.0) is giving trouble to
2141         when trying to build WebKitGTK from scratch, due to a segmentation
2142         fault error in gdk-pixbuf-query-loader during the 'make'
2143         phase. Raising the version to 2.26.5 fixes this issue.
2144
2145         * gtk/jhbuild.modules: Version raised, checksums updated.
2146
2147 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
2148
2149         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
2150         https://bugs.webkit.org/show_bug.cgi?id=90968.
2151
2152         Reviewed by Csaba Osztrogonác.
2153
2154         Added functionality in DRT and WTR to use any timeout value while running
2155         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
2156         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
2157         to indicate whether the current port supports setting timeout value
2158         per test (it's False by default; I enabled it only on Qt).
2159         Also corrected a typo in driver.py
2160
2161         * DumpRenderTree/DumpRenderTree.h:
2162         (TestCommand::TestCommand):
2163         (TestCommand):
2164         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2165         (parseInputLine):
2166         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2167         (WebCore::DumpRenderTree::processLine):
2168         * Scripts/webkitpy/layout_tests/port/base.py:
2169         (Port.supports_per_test_timeout):
2170         * Scripts/webkitpy/layout_tests/port/driver.py:
2171         (Driver.run_test):
2172         (Driver._command_from_driver_input):
2173         * Scripts/webkitpy/layout_tests/port/qt.py:
2174         (QtPort.supports_per_test_timeout):
2175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2176         (WTR::InjectedBundle::InjectedBundle):
2177         (WTR::InjectedBundle::didReceiveMessage):
2178         (WTR::InjectedBundle::beginTesting):
2179         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2180         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2181         (WTR::TestRunner::setCustomTimeout):
2182         (WTR):
2183         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2184         (TestRunner):
2185         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
2186         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2187         * WebKitTestRunner/TestController.cpp:
2188         (WTR::TestController::TestController):
2189         (WTR::TestController::getCustomTimeout):
2190         (WTR):
2191         (WTR::TestCommand::TestCommand):
2192         (TestCommand):
2193         (WTR::parseInputLine):
2194         (WTR::TestController::runTest):
2195         (WTR::TestController::runUntil):
2196         * WebKitTestRunner/TestController.h:
2197         (TestController):
2198         * WebKitTestRunner/TestInvocation.cpp:
2199         (WTR::TestInvocation::TestInvocation):
2200         (WTR::TestInvocation::setCustomTimeout):
2201         (WTR):
2202         (WTR::TestInvocation::invoke):
2203         * WebKitTestRunner/TestInvocation.h:
2204         (TestInvocation):
2205
2206 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2207
2208         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
2209         https://bugs.webkit.org/show_bug.cgi?id=106290
2210
2211         Reviewed by Martin Robinson.
2212
2213         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2214         the macro isn't enabled.
2215
2216         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2217
2218 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2219
2220         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2221         https://bugs.webkit.org/show_bug.cgi?id=103653
2222
2223         Reviewed by Anders Carlsson.
2224
2225         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2226         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2227         client callback.
2228
2229         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2230         methods to the JavaScript API.
2231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2232         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2233         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2234         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2236         (TestRunner): Added new declarations for the above.
2237         * WebKitTestRunner/TestController.cpp:
2238         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2239         callback.
2240         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2241         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2242         the authentication information passed from the InjectedBundle.
2243         * WebKitTestRunner/TestController.h:
2244         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2245         to communicate with the TestController.
2246         (WTR::TestController::setAuthenticationUsername): Ditto.
2247         (WTR::TestController::setAuthenticationPassword): Ditto.
2248         (TestController):
2249         * WebKitTestRunner/TestInvocation.cpp:
2250         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2251         information from the InjectedBundle.
2252         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2253         text to the TestInvocation text output.
2254         * WebKitTestRunner/TestInvocation.h:
2255         (TestInvocation): Added declaration for new method.
2256
2257 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2258
2259         Add myself as a watcher for Web Geolocation
2260
2261         Unreviewed.
2262
2263         * Scripts/webkitpy/common/config/watchlist:
2264
2265 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2266
2267         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2268         https://bugs.webkit.org/show_bug.cgi?id=106364
2269
2270         Reviewed by Eric Seidel.
2271
2272         When the setup_test_run method is called on the subclasses of the base Port
2273         interface, the parent method should also be called via super(), despite the
2274         parent method not doing anything at the moment.
2275
2276         The according calls to super() are required in the ChromiumPort, EflPort
2277         and GtkPort implementations.
2278
2279         * Scripts/webkitpy/layout_tests/port/chromium.py:
2280         (ChromiumPort.setup_test_run):
2281         * Scripts/webkitpy/layout_tests/port/efl.py:
2282         (EflPort.setup_test_run):
2283         * Scripts/webkitpy/layout_tests/port/gtk.py:
2284         (GtkPort.setup_test_run):
2285
2286 2013-01-08  Julie Parent  <jparent@chromium.org>
2287
2288         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2289         https://bugs.webkit.org/show_bug.cgi?id=106356
2290
2291         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2292         dashboard_base, assigned by Loader, and used only by dashboard_base to
2293         create error messages.  Moved the variables to be privates on the Loader
2294         object, moved error message creation to _getLoadingErrorMessages on the
2295         Loader object, and now pass the errors back to dashboard base via the
2296         resourceLoadingComplete callback.
2297         
2298         Also removed the now unused clearError function, it was only being used
2299         by unit tests to clean up global state.
2300         
2301         Reviewed by Dirk Pranke.
2302
2303         * TestResultServer/static-dashboards/dashboard_base.js:
2304         (resourceLoadingComplete):
2305         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2306         * TestResultServer/static-dashboards/loader.js:
2307         (.):
2308         * TestResultServer/static-dashboards/loader_unittests.js:
2309
2310 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2311
2312         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2313         https://bugs.webkit.org/show_bug.cgi?id=106354
2314
2315         Reviewed by Eric Seidel.
2316
2317         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2318         instead of those two inheriting from it. Also add a mock object of the
2319         sanitizer that's used in unit tests.
2320
2321         * Scripts/webkitpy/layout_tests/port/efl.py:
2322         (EflPort):
2323         (EflPort.__init__):
2324         (EflPort.setup_test_run):
2325         (EflPort.clean_up_test_run):
2326         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2327         importing order.
2328         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2329         * Scripts/webkitpy/layout_tests/port/gtk.py:
2330         (GtkPort):
2331         (GtkPort.__init__):
2332         (GtkPort.setup_test_run):
2333         (GtkPort.clean_up_test_run):
2334         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2335         importing order.
2336         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2337         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2338         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2339         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2340         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2341         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2342         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2343         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2344
2345 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2346
2347         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2348         https://bugs.webkit.org/show_bug.cgi?id=106324
2349
2350         Reviewed by Adam Barth.
2351
2352         Since the frame load callbacks are part of the WebFrameClient, the
2353         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2354         methods.
2355
2356         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2357         (DRTTestRunner::DRTTestRunner):
2358         (DRTTestRunner::reset):
2359         * DumpRenderTree/chromium/DRTTestRunner.h:
2360         (DRTTestRunner):
2361         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2362         (WebTestInterfaces):
2363         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2364         (WebKit):
2365         (WebTestProxyBase):
2366         (WebTestRunner):
2367         (WebTestRunner::WebTestProxy::WebTestProxy):
2368         (WebTestProxy):
2369         (WebTestRunner::WebTestProxy::didInvalidateRect):
2370         (WebTestRunner::WebTestProxy::didScrollRect):
2371         (WebTestRunner::WebTestProxy::scheduleComposite):
2372         (WebTestRunner::WebTestProxy::scheduleAnimation):
2373         (WebTestRunner::WebTestProxy::setWindowRect):
2374         (WebTestRunner::WebTestProxy::show):
2375         (WebTestRunner::WebTestProxy::didAutoResize):
2376         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2377         (WebTestRunner::WebTestProxy::startDragging):
2378         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2379         (WebTestRunner::WebTestProxy::shouldEndEditing):
2380         (WebTestRunner::WebTestProxy::shouldInsertNode):
2381         (WebTestRunner::WebTestProxy::shouldInsertText):
2382         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2383         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2384         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2385         (WebTestRunner::WebTestProxy::didBeginEditing):
2386         (WebTestRunner::WebTestProxy::didChangeSelection):
2387         (WebTestRunner::WebTestProxy::didChangeContents):
2388         (WebTestRunner::WebTestProxy::didEndEditing):
2389         (WebTestRunner::WebTestProxy::registerIntentService):
2390         (WebTestRunner::WebTestProxy::dispatchIntent):
2391         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2392         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2393         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2394         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2395         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2396         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2397         (WebTestRunner::WebTestProxy::didReceiveTitle):
2398         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2399         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2400         (WebTestRunner::WebTestProxy::didFailLoad):
2401         (WebTestRunner::WebTestProxy::didFinishLoad):
2402         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2403         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2404         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2405         (WebTestRunner::WebTestProxy::didDetectXSS):
2406         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2407         (WebTestRunner::WebTestRunner::setTestIsRunning):
2408         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2409         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2410         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2411         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2412         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2413         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2414         (WebTestRunner::TestRunner::TestRunner):
2415         (WebTestRunner::TestRunner::reset):
2416         (WebTestRunner::TestRunner::setTestIsRunning):
2417         (WebTestRunner):
2418         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2419         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2420         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2421         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2422         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2423         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2424         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2425         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2426         (WebTestRunner::TestRunner::dumpTitleChanges):
2427         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2428         (TestRunner):
2429         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2430         (WebTestInterfaces::Internal):
2431         (WebTestRunner::WebTestInterfaces::Internal::webView):
2432         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2433         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2434         (WebTestRunner):
2435         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2436         (WebTestRunner::WebTestInterfaces::setWebView):
2437         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2438         (WebTestRunner::WebTestInterfaces::webView):
2439         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2440         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2441         (WebTestRunner):
2442         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2443         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2444         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2445         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2446         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2447         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2448         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2449         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2450         (WebTestRunner::WebTestProxyBase::didFailLoad):
2451         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2452         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2453         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2454         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2455         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2456         * DumpRenderTree/chromium/TestShell.cpp:
2457         (TestShell::runFileTest):
2458         (TestShell::testFinished):
2459         * DumpRenderTree/chromium/TestShell.h:
2460         (TestShell):
2461         * DumpRenderTree/chromium/WebViewHost.cpp:
2462         (WebViewHost::didStartProvisionalLoad):
2463         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2464         (WebViewHost::didFailProvisionalLoad):
2465         (WebViewHost::didCommitProvisionalLoad):
2466         (WebViewHost::didReceiveTitle):
2467         (WebViewHost::didFailLoad):
2468         (WebViewHost::didFinishLoad):
2469         * DumpRenderTree/chromium/WebViewHost.h:
2470         (WebViewHost):
2471
2472 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2473
2474         [GTK] Lower the default timeout value for WebKitTestRunner
2475         https://bugs.webkit.org/show_bug.cgi?id=106353
2476
2477         Reviewed by Dirk Pranke.
2478
2479         The default timeout value for WebKitTestRunner should be lowered.
2480         The current value (80 seconds) is irrational and just leads to producing
2481         text failures for layout tests that genuinely time out. This just leads
2482         to more deviation from the GTK WK1 port in terms of test expectations.
2483
2484         The value used is the same as when running the DumpRenderTree, that's
2485         6 seconds in release builds and 12 seconds in debug builds.
2486
2487         * Scripts/webkitpy/layout_tests/port/gtk.py:
2488         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2489         (GtkPortTest.test_default_timeout_ms):
2490
2491 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2492
2493         test-webkitpy shows failure output on my linux box
2494         https://bugs.webkit.org/show_bug.cgi?id=101261
2495
2496         Reviewed by Eric Seidel.
2497
2498         Mock out the PulseAudioSanitizer methods when creating testing instances
2499         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2500         PulseAudio output when the sanitizer was trying to unload modules which
2501         were already unloaded by another unit test that was being run in parallel.
2502
2503         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2504         (EflPortTest):
2505         (EflPortTest.make_port):
2506         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2507         (GtkPortTest):
2508         (GtkPortTest.make_port):
2509
2510 2013-01-08  Julie Parent  <jparent@chromium.org>
2511
2512         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2513         https://bugs.webkit.org/show_bug.cgi?id=106254
2514
2515         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2516         only to figure out if we should call addBuilderLoadErrors during
2517         handleLocationChange, which was called when the loader completed and on
2518         any hash change, but we only ever wanted to call addBuilderLoadErrors
2519         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2520         resourceLoadingComplete rather than handleLocationChange, so now we
2521         only call it when we want to, and the check can go away completely.
2522
2523         Reviewed by Dirk Pranke.
2524
2525         * TestResultServer/static-dashboards/dashboard_base.js:
2526         (addBuilderLoadErrors):
2527         (resourceLoadingComplete):
2528         (handleLocationChange):
2529         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2530
2531 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2532
2533         Add aboxhall@chromium.org to accessibility watchlist.
2534
2535         Unreviewed.
2536
2537         * Scripts/webkitpy/common/config/watchlist:
2538
2539 2013-01-08  Dan Winship  <danw@gnome.org>
2540
2541         Add Apache 2.4 support for Fedora 18
2542         https://bugs.webkit.org/show_bug.cgi?id=104478
2543
2544         Reviewed by Martin Robinson.
2545
2546         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2547         need a separate config.
2548
2549         * Scripts/webkitpy/layout_tests/port/base.py:
2550         (Port._apache_version):
2551         (Port._apache_config_file_name_for_platform):
2552         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2553         * Scripts/run-webkit-httpd:
2554         * Scripts/webkitperl/httpd.pm:
2555         (getApacheVersion):
2556         (getDefaultConfigForTestDirectory):
2557         (getHTTPDConfigPathForTestDirectory):
2558
2559 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2560
2561         Make the override-feature-defines script compatible with Python v3
2562         https://bugs.webkit.org/show_bug.cgi?id=105742
2563
2564         Reviewed by Martin Robinson.
2565
2566         Instead of printing output through a statement, use the print function and format
2567         the output using the str.format method. This makes the script runnable with Python v3.
2568
2569         * gtk/override-feature-defines:
2570         (adjust_feature_defines_makefile):
2571
2572 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2573
2574         [Qt] Fix libxml2 config test
2575         https://bugs.webkit.org/show_bug.cgi?id=106317
2576
2577         Reviewed by Simon Hausmann.
2578
2579         Don't assume standard include/libxml2, libxml-2.0.pc should know
2580         where it's headers are.
2581
2582         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2583
2584 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2585
2586         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2587         https://bugs.webkit.org/show_bug.cgi?id=106195
2588
2589         Reviewed by Philippe Normand.
2590
2591         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2592         to make the Python code compatible with Python 3. This includes modifying
2593         print statements, exception handling, dictionary iteration and
2594         byte-sequence-to-string conversion.
2595
2596         * gtk/common.py:
2597         (get_build_path):
2598         (pkg_config_file_variable):
2599         (gtk_version_of_pkg_config_file):
2600         * gtk/generate-gtkdoc:
2601         (print_missing_api):
2602         * gtk/gtkdoc.py:
2603         (GTKDoc.__init__):
2604         (GTKDoc._run_command):
2605
2606 2013-01-02  Steve Block  <steveblock@chromium.org>
2607
2608         Add chromium.org email address for Steve Block.
2609
2610         Unreviewed.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2615
2616         Rationalize closure call heuristics and profiling
2617         https://bugs.webkit.org/show_bug.cgi?id=106270
2618
2619         Reviewed by Oliver Hunt.
2620         
2621         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2622         all generated code ('display *' or 'd *').
2623
2624         * Scripts/display-profiler-output:
2625
2626 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2627
2628         Sorted more xcodeproj files.
2629
2630         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2632         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2633
2634 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2635
2636         Sorted xcodeproj files.
2637
2638         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2639         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2640
2641 2013-01-07  Dan Bernstein  <mitz@apple.com>
2642
2643         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2644         https://bugs.webkit.org/show_bug.cgi?id=106261
2645
2646         Reviewed by Simon Fraser.
2647
2648         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2649
2650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2651         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2652         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2653         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2654         (TestWebKitAPI):
2655         (TestWebKitAPI::TEST):
2656
2657 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2658
2659         Add the Apple MountainLion bots to garden-o-matic.
2660         Eventually, we really should move away from hardcoding
2661         the list of bots.
2662
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2664
2665 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2666
2667         [chromium] move web audio related methods to testrunner library
2668         https://bugs.webkit.org/show_bug.cgi?id=106211
2669
2670         Reviewed by Adam Barth.
2671
2672         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2673         (DRTTestRunner::DRTTestRunner):
2674         (DRTTestRunner::reset):
2675         * DumpRenderTree/chromium/DRTTestRunner.h:
2676         (DRTTestRunner):
2677         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2678         (WebKit):
2679         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2680         (WebTestRunner::WebTestRunner::audioData):
2681         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2682         (WebTestRunner::TestRunner::TestRunner):
2683         (WebTestRunner::TestRunner::reset):
2684         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2685         (WebTestRunner):
2686         (WebTestRunner::TestRunner::audioData):
2687         (WebTestRunner::TestRunner::setAudioData):
2688         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2689         (TestRunner):
2690         * DumpRenderTree/chromium/TestShell.cpp:
2691         (TestShell::dump):
2692
2693 2013-01-07  Mike West  <mkwst@chromium.org>
2694
2695         Make the IFRAME_SEAMLESS flag runtime-enabled.
2696         https://bugs.webkit.org/show_bug.cgi?id=106213
2697
2698         Reviewed by Ojan Vafai.
2699
2700         * DumpRenderTree/chromium/TestShell.cpp:
2701         (TestShell::TestShell):
2702         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2703         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2704         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2705         (resetDefaultsToConsistentValues):
2706         * DumpRenderTree/mac/DumpRenderTree.mm:
2707         (resetDefaultsToConsistentValues):
2708         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2709         (WebCore::WebPage::resetSettings):
2710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2711         (WTR::InjectedBundle::beginTesting):
2712             Ensure that seamless IFrames are enabled for layout tests in each of
2713             the ports that support seamless IFrames.
2714
2715 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2716
2717         [chromium] move dumpAsText and friends to the TestRunner library
2718         https://bugs.webkit.org/show_bug.cgi?id=106222
2719
2720         Reviewed by Adam Barth.
2721
2722         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2723
2724         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2725         (DRTTestRunner::DRTTestRunner):
2726         (DRTTestRunner::reset):
2727         * DumpRenderTree/chromium/DRTTestRunner.h:
2728         (DRTTestRunner):
2729         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2730         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2731         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2732         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2733         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2734         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2735         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2736         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2737         (WebTestRunner::TestRunner::TestRunner):
2738         (WebTestRunner::TestRunner::reset):
2739         (WebTestRunner::TestRunner::shouldDumpAsText):
2740         (WebTestRunner):
2741         (WebTestRunner::TestRunner::setShouldDumpAsText):
2742         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2743         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2744         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2745         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2746         (WebTestRunner::TestRunner::dumpAsText):
2747         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2748         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2749         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2750         (TestRunner):
2751
2752 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         Build fix attempt after r138810.
2755
2756         Apparently python 2.6 is really bad at floating point computation.
2757
2758         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2759         (MainTest.test_run_memory_test):
2760
2761 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2764         https://bugs.webkit.org/show_bug.cgi?id=106172
2765
2766         Reviewed by Tony Chang.
2767
2768         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2769         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2770         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2771         test on perf-o-matic and perf. test's results page.
2772
2773         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2774
2775         * Scripts/webkitpy/performance_tests/perftest.py:
2776         (PerfTestMetric): Added.
2777         (PerfTestMetric.__init__): Added.
2778         (PerfTestMetric.metric): Added.
2779         (PerfTestMetric.has_values): Added.
2780         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2781         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2782         conversions to be done on the client side (perf-o-matic and results page).
2783         (PerfTestMetric.append): Added.
2784         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2785         a result for this metric.
2786         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2787         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2788
2789         (PerfTest._create_driver): Extracted from PerfTest.run.
2790         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2791         as needed.
2792         (PerfTest._run_with_driver):
2793         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2794         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2795         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2796
2797         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2798         from other perf tests, there isn't much point in sharing the code here.
2799
2800         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2801         statistics for the measured values.
2802
2803         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2804         (TestPerfTestMetric): Added.
2805         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2806         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2807         (TestPerfTestMetric.test_has_values): Added.
2808         (TestPerfTestMetric.test_append): Added.
2809         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2810         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2811
2812         (TestPerfTest._assert_results_are_correct): Updated as needed.
2813         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2814         in PerfTest.run now after generating the results dictionary.
2815         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2816
2817 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2818
2819         Support size_t multiplication and division operators on LayoutUnit
2820         https://bugs.webkit.org/show_bug.cgi?id=83848
2821
2822         Reviewed by Emil A Eklund.
2823
2824         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2825         Added some simple tests for the new operators using size_t.
2826
2827 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2828
2829         [Qt] run-webkit-tests cleanup for parallel NRWT
2830         https://bugs.webkit.org/show_bug.cgi?id=106220
2831
2832         Reviewed by Dirk Pranke.
2833
2834         * Scripts/run-webkit-tests:
2835         (useNewRunWebKitTests):
2836         * Scripts/webkitpy/layout_tests/port/qt.py:
2837         (QtPort):
2838         (QtPort.default_child_processes):
2839
2840 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2841
2842         Create a GStreamerAudio watchlist and add myself to it.
2843
2844         Unreviewed.
2845
2846         * Scripts/webkitpy/common/config/watchlist:
2847
2848 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2849
2850         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2851         Also removed the empty mac directory.
2852
2853         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2854         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2855         * BuildSlaveSupport/mac: Removed.
2856         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2857
2858 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2859
2860         Add a script to delete stale zero-byte build files
2861         https://bugs.webkit.org/show_bug.cgi?id=106131
2862
2863         Reviewed by Tony Chang.
2864
2865         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2866
2867         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2868         (DeleteStaleBuildFiles): Added.
2869         (Factory.__init__): Add DeleteStaleBuildFiles step.
2870         * BuildSlaveSupport/delete-stale-build-files: Added.
2871         (main): Delete zero-byte files except ones intentionally generated by our build process.
2872         (webkitBuildDirectory): Copied from build-product-archive.
2873
2874 2013-01-04  Michael Pruett  <michael@68k.org>
2875
2876         [GTK] Fix build error on GTK due to r138836
2877         https://bugs.webkit.org/show_bug.cgi?id=106154
2878
2879         Reviewed by Kentaro Hara.
2880
2881         * GNUmakefile.am:
2882
2883 2013-01-04  Dan Bernstein  <mitz@apple.com>
2884
2885         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2886         https://bugs.webkit.org/show_bug.cgi?id=106121
2887
2888         Reviewed by Adele Peterson.
2889
2890         Added test for -[DOMTHMLTableCellElement _cellAbove].
2891
2892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2893         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2894         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2895         (TestWebKitAPI):
2896         (TestWebKitAPI::expectCellAboveCell):
2897         (TestWebKitAPI::TEST):
2898         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2899
2900 2013-01-04  Eric Seidel  <eric@webkit.org>
2901
2902         FlakyTestReporter should be re-enabled and taught how to post patches
2903         https://bugs.webkit.org/show_bug.cgi?id=103839
2904
2905         Reviewed by Adam Barth.
2906
2907         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2908         It also adds a real Port object to the EWS and CommitQueue objects
2909         using a new PatchProcessingQueue superclass.
2910         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2911         but works for this purpose.
2912         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2913         to resolve a FIXME.
2914
2915         This required some hacks/shiming between the non-specific "old"
2916         port names which the EWS system is currently using, and the new
2917         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2918
2919         Hopefully this will fix the flaky test reporter and results uploading.
2920         Certainly it's another small step towards getting rid of the old ports.py
2921         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2922
2923         Now that DeprecatedPort is no longer used for the results directory
2924         I removed all the explicit results-dir code which webkit-patch was using
2925         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2926
2927         * Scripts/webkitpy/common/config/ports.py:
2928         (DeprecatedPort.run_perl_unittests_command):
2929         * Scripts/webkitpy/common/config/ports_mock.py:
2930         (MockPort.name):
2931         * Scripts/webkitpy/common/system/outputcapture.py:
2932         (OutputCapture.assert_outputs):
2933         * Scripts/webkitpy/layout_tests/port/apple.py:
2934         (ApplePort.determine_full_port_name):
2935         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2936         (LayoutTestResultsReader.__init__):
2937         (LayoutTestResultsReader):
2938         (LayoutTestResultsReader._read_file_contents):
2939         (LayoutTestResultsReader._create_layout_test_results):
2940         (LayoutTestResultsReader._create_unit_test_results):
2941         (LayoutTestResultsReader.results):
2942         (LayoutTestResultsReader.archive):
2943         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2944         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2945         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2946         (test_missing_unit_test_results_path):
2947         (test_layout_test_results):
2948         (test_archive_last_layout_test_results):
2949         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2950         (AbstractEarlyWarningSystem):
2951         (AbstractEarlyWarningSystem.__init__):
2952         (AbstractEarlyWarningSystem.begin_work_queue):
2953         (AbstractEarlyWarningSystem.run_command):
2954         * Scripts/webkitpy/tool/commands/queues.py:
2955         (AbstractPatchQueue.work_item_log_path):
2956         (PatchProcessingQueue):
2957         (PatchProcessingQueue._new_port_name_from_old):
2958         (PatchProcessingQueue.begin_work_queue):
2959         (PatchProcessingQueue._upload_results_archive_for_patch):
2960         (CommitQueue):
2961         (CommitQueue.begin_work_queue):
2962         (CommitQueue.run_command):
2963         (AbstractReviewQueue):
2964         (AbstractReviewQueue.__init__):
2965         (AbstractReviewQueue.begin_work_queue):
2966         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2967         (AbstractPatchQueueTest.test_next_patch):
2968         (PatchProcessingQueueTest):
2969         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2970         * Scripts/webkitpy/tool/steps/runtests.py:
2971         (RunTests.run):
2972         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2973
2974 2013-01-04  Dana Jansens  <danakj@chromium.org>
2975
2976         [chromium] Remove lost-compositor-context layout tests
2977         https://bugs.webkit.org/show_bug.cgi?id=106089
2978
2979         Reviewed by James Robinson.
2980
2981         Remove the loseCompositorContext() test function.
2982
2983         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2984         (WebTestRunner::TestRunner::TestRunner):
2985         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2986         (TestRunner):
2987
2988 2013-01-04  Adam Klein  <adamk@chromium.org>
2989
2990         Remove ENABLE_MUTATION_OBSERVERS #define
2991         https://bugs.webkit.org/show_bug.cgi?id=105459
2992
2993         Reviewed by Ryosuke Niwa.
2994
2995         * Scripts/webkitperl/FeatureList.pm:
2996         * qmake/mkspecs/features/features.pri:
2997
2998 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2999
3000         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
3001         https://bugs.webkit.org/show_bug.cgi?id=106078
3002
3003         Reviewed by Tony Chang.
3004
3005         This patch updates values for individual iterations in dummy performance tests used in
3006         perftest_unittest.py and perftest_integrationtest.py so that they match up with
3007         statistics such as stdev and median reported in those tests. This change is required
3008         to resolve the bug 97510.
3009
3010         This patch also refactors integration tests by extracting *TestData classes that
3011         centralizes the definitions of each dummy performance test's text (DRT output),
3012         runner output, and parsed results (JSON) so that we may share more data between
3013         python tests.
3014
3015         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3016         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
3017         Use self.assertAlmostEqual when comparing the standard deviation.
3018         (MainTest.test_parse_output):
3019         (test_parse_output_with_failing_line):
3020         (test_parse_output_with_description): Use _assert_results_are_correct.
3021         (test_parse_output_with_subtests): Ditto.
3022
3023         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3024         (InspectorPassTestData): Extracted from tests below.
3025         (EventTargetWrapperTestData): Ditto.
3026         (SomeParserTestData): Ditto.
3027         (MemoryTestData): Ditto.
3028         (TestDriver.run_test): Moved test definitions out of the method.
3029         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
3030         (MainTest._load_output_json): Extracted from create_runner.
3031         (MainTest.create_runner):
3032         (MainTest.test_run_test_set_for_parser_tests):
3033         (MainTest.test_run_memory_test):
3034         (MainTest._test_run_with_json_output):
3035         (MainTest.test_run_with_json_output):
3036         (MainTest.test_run_with_description):
3037         (MainTest.test_run_generates_json_by_default):
3038         (MainTest.test_run_merges_output_by_default):
3039         (MainTest.test_run_respects_reset_results):
3040         (MainTest.test_run_generates_and_show_results_page):
3041         (MainTest.test_run_with_slave_config_json):
3042         (MainTest.test_run_with_multiple_repositories):
3043
3044 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
3045
3046         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
3047         https://bugs.webkit.org/show_bug.cgi?id=106045
3048
3049         Reviewed by Carlos Garcia Campos.
3050
3051         Update test results to confirm that compositions without preedits do not trigger
3052         a composition confirmation.
3053
3054         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3055         (TestWebKitAPI::verifyCanceledComposition):
3056
3057 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
3058
3059         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
3060         https://bugs.webkit.org/show_bug.cgi?id=105958
3061
3062         Reviewed by Alexey Proskuryakov.
3063
3064         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
3065
3066         * WebKitTestRunner/mac/EventSenderProxy.mm:
3067         (KeyMappingEntry):
3068         (WTR):
3069         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
3070
3071 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
3072
3073         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
3074         https://bugs.webkit.org/show_bug.cgi?id=106073
3075
3076         Reviewed by Ryosuke Niwa.
3077
3078         Check that the element being compared to is not nil. 
3079         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
3080         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
3081         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
3082         sometimes before on parallel WebKitTestRunner runs.
3083
3084         * DumpRenderTree/AccessibilityUIElement.cpp:
3085         (AccessibilityUIElement::isEqual):
3086         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3087         (WTR::AccessibilityUIElement::isEqual):
3088
3089 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3090
3091         Downloads can be flaky, so try downloading multiple times.
3092         https://bugs.webkit.org/show_bug.cgi?id=105976
3093
3094         Reviewed by Eric Seidel.
3095
3096         * Scripts/webkitpy/common/system/autoinstall.py:
3097         (AutoInstaller._download_to_stream):
3098
3099 2013-01-03  Eric Seidel  <eric@webkit.org>
3100
3101         Rename Tool.port to deprecated_port in preparation for removing more callers
3102         https://bugs.webkit.org/show_bug.cgi?id=106076
3103
3104         Reviewed by Ryosuke Niwa.
3105
3106         This resolves a long-standing FIXME to rename this method. :)
3107
3108         * Scripts/webkitpy/tool/bot/botinfo.py:
3109         (BotInfo.summary_text):
3110         * Scripts/webkitpy/tool/bot/irc_command.py:
3111         (Rollout._update_working_copy):
3112         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3113         (LayoutTestResultsReader._create_layout_test_results):
3114         (LayoutTestResultsReader._create_unit_test_results):
3115         (LayoutTestResultsReader._results_directory):
3116         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3117         (test_missing_unit_test_results_path):
3118         * Scripts/webkitpy/tool/main.py:
3119         (WebKitPatch.deprecated_port):
3120         * Scripts/webkitpy/tool/mocktool.py:
3121         (MockTool.deprecated_port):
3122         * Scripts/webkitpy/tool/steps/build.py:
3123         (Build.build):
3124         * Scripts/webkitpy/tool/steps/checkstyle.py:
3125         (CheckStyle.run):
3126         * Scripts/webkitpy/tool/steps/commit.py:
3127         (Commit._check_test_expectations):
3128         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3129         (PrepareChangeLog.run):
3130         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3131         (PrepareChangeLogForDEPSRoll.run):
3132         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3133         (PrepareChangeLogForRevert.run):
3134         * Scripts/webkitpy/tool/steps/runtests.py:
3135         (RunTests.run):
3136         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3137         (StepsTest.test_runtests_args):
3138         * Scripts/webkitpy/tool/steps/update.py:
3139         (Update._update_command):
3140
3141 2013-01-03  Eric Seidel  <eric@webkit.org>
3142
3143         Add myself to the webkitpy watchlist.
3144
3145         Unreviewed.
3146
3147         * Scripts/webkitpy/common/config/watchlist:
3148
3149 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3150
3151         Cleanup perftest* tests and add a test for computing statistics
3152         https://bugs.webkit.org/show_bug.cgi?id=105685
3153
3154         Reviewed by Eric Seidel.
3155
3156         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
3157         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
3158
3159         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
3160
3161         * Scripts/webkitpy/performance_tests/perftest.py:
3162         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
3163         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
3164         accurate result for the mean.
3165         (PageLoadingPerfTest.run_single):
3166         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3167         (MainTest.test_compute_statistics):
3168         (MainTest.test_compute_statistics.compute_statistics): Added.
3169         (TestPageLoadingPerfTest.test_run): floatify values.
3170         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
3171         correctly recognizes them as integers.
3172
3173         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
3174         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
3175         (TestDriver): Moved out of MainTest.
3176         (MainTest): Got rid of assertWritten and all unit tests.
3177         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
3178         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3179         (MainTest.test_run_test_set_for_parser_tests):
3180         (MainTest.test_run_memory_test):
3181         (MainTest._test_run_with_json_output):
3182         (MainTest.test_run_generates_json_by_default):
3183         (MainTest.test_run_merges_output_by_default):
3184         (MainTest.test_run_respects_reset_results):
3185         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
3186         parsing output JSON files. Just verify that the output path is correct instead.
3187         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3188         (MainTest): Removed all integration tests.
3189         (MainTest.create_runner): Simplified.
3190
3191 2013-01-03  Julie Parent  <jparent@chromium.org>
3192
3193         Dashboard cleanup: remove usage of global g_defaultBuilderName
3194         https://bugs.webkit.org/show_bug.cgi?id=106043
3195
3196         Use now public defaultBuilder() from the BuilderGroup, rather
3197         than global variable.
3198
3199         Also eliminates the setup() and initBuilders() functions since we
3200         no longer need to track the global.
3201
3202         Reviewed by Adam Barth.
3203
3204         * TestResultServer/static-dashboards/builders.js:
3205         (BuilderGroup.prototype.defaultBuilder):
3206         (BuilderGroup.prototype.master):
3207         * TestResultServer/static-dashboards/dashboard_base.js:
3208         (parseParameters):
3209         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3210         (updateDefaultBuilderState):
3211         * TestResultServer/static-dashboards/loader.js:
3212         (.):
3213         * TestResultServer/static-dashboards/loader_unittests.js:
3214
3215 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3216
3217         Disable an intermittently failing unit test for now.
3218         The failure is tracked by the bug 106051.
3219
3220         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3221         (TestWebKitAPI::TEST):
3222
3223 2013-01-03  Dan Bernstein  <mitz@apple.com>
3224
3225         No way to obtain a DOMNode given a JS wrapper for a Node
3226         https://bugs.webkit.org/show_bug.cgi?id=106033
3227
3228         Added a test for +[DOMNode _nodeFromJSWrapper:].
3229
3230         Reviewed by Sam Weinig.
3231
3232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3233         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3234         (TestWebKitAPI):
3235         (TestWebKitAPI::TEST):
3236
3237 2013-01-03  Emil A Eklund  <eae@chromium.org>
3238
3239         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3240         https://bugs.webkit.org/show_bug.cgi?id=105961
3241
3242         Reviewed by Levi Weintraub.
3243         
3244         Add tests for LayoutUnit::ceil and floor.
3245
3246         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3247         (TestWebKitAPI::TEST):
3248         (TestWebKitAPI):
3249
3250 2013-01-03  Julie Parent  <jparent@chromium.org>
3251
3252         Add unit test for default builder for the dashboards.
3253         https://bugs.webkit.org/show_bug.cgi?id=105972
3254
3255         Reviewed by Dirk Pranke.
3256
3257         * TestResultServer/static-dashboards/loader_unittests.js:
3258
3259 2013-01-03  Tony Chang  <tony@chromium.org>
3260
3261         Generate internal.settings from Settings.in
3262         https://bugs.webkit.org/show_bug.cgi?id=104740
3263
3264         Reviewed by Adam Barth.
3265
3266         * GNUmakefile.am: Compile new generated files on GTK+.
3267         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3268         with both extra_sources and add_output_to_sources=false will still
3269         compile the files in extra_sources. This makes it possible to compile
3270         InternalSettingsGenerated.cpp and not be confused by
3271         InternalSettingsGenerated.idl.
3272
3273 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3274
3275         [style] WebIDL-reflecting uppercase enums reported as style violation
3276         https://bugs.webkit.org/show_bug.cgi?id=105832
3277
3278         Reviewed by Tony Chang.
3279
3280         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3281         indicates this. In enums spanning over multiple lines, the comment is expected
3282         on the first line. In enums placed in one line, the comment is expected at the
3283         end of that line.
3284
3285         WebIDL-reflecting enum values are required to be written in uppercase and as such
3286         violate the common rule of these values being written in InterCaps. Annotating
3287         enums this way makes it possible to avoid false style violation reports.
3288
3289         The comment is of form '// Web(?:Kit)?IDL enum'.
3290
3291         * Scripts/webkitpy/style/checkers/cpp.py:
3292         (_EnumState.__init__):
3293         (_EnumState.process_clean_line):
3294         (check_enum_casing):
3295         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3296         (NoNonVirtualDestructorsTest.test_enum_casing):
3297
3298 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3299
3300         Adding favicon.ico to the garden-o-matic.
3301         https://bugs.webkit.org/show_bug.cgi?id=105982
3302
3303         Reviewed by Adam Barth.
3304
3305         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3307
3308 2013-01-03  Jonathan Liu  <net147@gmail.com>
3309
3310         [Qt] Fix library linking order
3311         https://bugs.webkit.org/show_bug.cgi?id=105818
3312
3313         Some Qt libraries are linked before the private static libraries
3314         that depend on them which results in QtWebKit failing to link.
3315
3316         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3317         module to ensure the Qt libraries are linked after the private
3318         static libraries that depend on them.
3319
3320         Reviewed by Tor Arne Vestbø.
3321
3322         * qmake/mkspecs/features/default_post.prf:
3323
3324 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3325
3326         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3327         https://bugs.webkit.org/show_bug.cgi?id=102209
3328
3329         Reviewed by Gyuyoung Kim.
3330
3331         Set tooltip on the elm_window instead of ewk_view, and add delay to
3332         show the tooltip window.
3333
3334         Setting tooltip on the ewk_view makes elementary error message because
3335         ewk_view is not an elementary widget. To remove the error message,
3336         tooltip should be set on the elm_window.
3337
3338         Most browsers show the tooltip after a mouse pointer stays on an
3339         element object that has tooltip text.
3340         But elm_tooltip widget itself doesn't have delay or handle mouse
3341         events to show/hide.
3342
3343         So additional codes are added to show/hide tooltip widget along with
3344         mouse events.
3345           1) When a mouse pointer stays for a second on an element which has
3346              tooltip text, then tooltip widget is displayed.
3347           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3348              widget.
3349
3350         * MiniBrowser/efl/main.c:
3351         (_Tooltip_Information):
3352         (_Browser_Window):
3353         (on_tooltip_show):
3354         (window_tooltip_hide):
3355         (window_tooltip_update):
3356         (on_mouse_in):
3357         (on_mouse_move):
3358         (on_mouse_out):
3359         (window_free):
3360         (on_tooltip_text_set):
3361         (on_tooltip_text_unset):
3362         (window_create):
3363
3364 2013-01-02  Tony Chang  <tony@chromium.org>
3365
3366         Unreviewed, rolling out r138661.
3367         http://trac.webkit.org/changeset/138661
3368         https://bugs.webkit.org/show_bug.cgi?id=104740
3369
3370         Compile problems on EFL
3371
3372         * GNUmakefile.am:
3373         * qmake/mkspecs/features/default_post.prf:
3374
3375 2013-01-02  Tony Chang  <tony@chromium.org>
3376
3377         Generate internal.settings from Settings.in
3378         https://bugs.webkit.org/show_bug.cgi?id=104740
3379
3380         Reviewed by Adam Barth.
3381
3382         * GNUmakefile.am: Compile new generated files on GTK+.
3383         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3384         with both extra_sources and add_output_to_sources=false will still
3385         compile the files in extra_sources. This makes it possible to compile
3386         InternalSettingsGenerated.cpp and not be confused by
3387         InternalSettingsGenerated.idl.
3388
3389 2013-01-02  Adam Barth  <abarth@webkit.org>
3390
3391         Remove old-run-webkit-tests support from webkitpy
3392         https://bugs.webkit.org/show_bug.cgi?id=105619
3393
3394         Reviewed by Eric Seidel.
3395
3396         This patch removes support for webkitpy parsing the
3397         old-run-webkit-tests results format. There doesn't seem to be any
3398         reason to keep this code around anymore now that most bots have
3399         switched to new-run-webkit-tests.
3400
3401         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3402         (Builder.fetch_layout_test_results):
3403         * Scripts/webkitpy/common/net/layouttestresults.py:
3404         (path_for_layout_test):
3405         (LayoutTestResults.results_from_string):
3406         (LayoutTestResults):
3407         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3408         (LayoutTestResultsTest.test_results_from_string):
3409         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3410         (test_flaky_test_failure):
3411         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3412         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3413         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3414         (PatchAnalysisTask._test_patch):
3415         * Scripts/webkitpy/tool/commands/queuestest.py:
3416         (QueuesTest.assert_queue_outputs):
3417
3418 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3419
3420         [Qt][WK2] Add simple UI to find text from page
3421         https://bugs.webkit.org/show_bug.cgi?id=96481
3422
3423         Reviewed by Jocelyn Turcotte.
3424
3425         Find bar that slides between navigation bar and WebView.
3426
3427         * MiniBrowser/qt/BrowserWindow.cpp:
3428         (BrowserWindow::toggleFind):
3429         * MiniBrowser/qt/BrowserWindow.h:
3430         (BrowserWindow):
3431         * MiniBrowser/qt/MiniBrowser.qrc:
3432         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3433         (MiniBrowserApplication::notify):
3434         * MiniBrowser/qt/icons/find.png: Added.
3435         * MiniBrowser/qt/qml/BrowserWindow.qml:
3436
3437 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3438
3439         Regression(r138603): Caused 2 webkitpy tests to fail
3440         https://bugs.webkit.org/show_bug.cgi?id=105913
3441
3442         Reviewed by Kentaro Hara.
3443
3444         Fix 2 webkitpy tests that started to fail after
3445         r138603.
3446
3447         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3448         (IRCCommandTest._sheriff_test_data_url): Make sure the
3449         returned test file URL is valid no matter what the
3450         current working directory is.
3451         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3452         (IRCBotTest.test_help): Add "sheriffs" command to the
3453         list of available commands.
3454
3455 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3456
3457         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3458         https://bugs.webkit.org/show_bug.cgi?id=105897
3459
3460         Reviewed by Alexey Proskuryakov.
3461
3462         Dump in WebKitTestRunner the message that is expected by layout tests
3463         when the missing plugin button is clicked.
3464
3465         * WebKitTestRunner/TestController.cpp:
3466         (WTR::TestController::createWebViewWithOptions):
3467         (WTR::TestController::unavailablePluginButtonClicked):
3468         (WTR):
3469         * WebKitTestRunner/TestController.h:
3470         (TestController):
3471
3472 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3473
3474         [EFL] Enable MHTML feature
3475         https://bugs.webkit.org/show_bug.cgi?id=105815
3476
3477         Reviewed by Laszlo Gombos.
3478
3479         Enable MHTML feature for EFL port by default.
3480
3481         * Scripts/webkitperl/FeatureList.pm:
3482
3483 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3484
3485         sheriff-bot should know who the gardeners/sheriffs are
3486         https://bugs.webkit.org/show_bug.cgi?id=105698
3487
3488         Reviewed by Eric Seidel.
3489
3490         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3491
3492         * Scripts/webkitpy/tool/bot/irc_command.py:
3493         (Current):
3494         (Current._retrieve_webkit_sheriffs):
3495         (Current.execute):
3496         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3497         (IRCCommandTest.test_current):
3498         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3499         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3500         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3501         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3502         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3503
3504 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3505
3506         [GTK] Move ImageDiff to the Tools directory root
3507         https://bugs.webkit.org/show_bug.cgi?id=105421
3508
3509         Reviewed by Kenneth Rohde Christiansen.
3510
3511         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3512         * GNUmakefile.am:
3513         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3514
3515 2012-12-30  Mike West  <mkwst@chromium.org>
3516
3517         Add myself to watchlists for CSP and console logs.
3518         https://bugs.webkit.org/show_bug.cgi?id=105874
3519
3520         Reviewed by Dirk Pranke.
3521
3522         Because I really, really, really need more email.
3523
3524         * Scripts/webkitpy/common/config/committers.py:
3525             Add mkwst+watchlist@chromium.org as a contributor.
3526         * Scripts/webkitpy/common/config/watchlist:
3527             Create watchlist categories for 1) the various mechanisms used to
3528             generate console messages, and 2) CSP usage and files.
3529
3530 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3531
3532         [EFL] Enable TEMPLATE_ELEMENT feature
3533         https://bugs.webkit.org/show_bug.cgi?id=105865
3534         
3535         Reviewed by Laszlo Gombos.
3536
3537         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3538
3539 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3540
3541         Unreviewed GTK gardening of the unit tests.
3542
3543         Skip the TestInspectorServer unit test that's timing out completely.
3544
3545         * Scripts/run-gtk-tests:
3546         (TestRunner):
3547
3548 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3549
3550         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3551         https://bugs.webkit.org/show_bug.cgi?id=105855
3552
3553         Reviewed by Vsevolod Vlasov.
3554
3555         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3556         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3557
3558         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3559         (ReportMemoryUsageVisitor):
3560         (clang::AddMemberCallVisitor::VisitCallExpr):
3561         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3562         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3563
3564 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3565
3566         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3567         https://bugs.webkit.org/show_bug.cgi?id=105852
3568
3569         Reviewed by Alexander Pavlov.
3570
3571         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3572         (clang):
3573         (AddMemberCallVisitor):
3574         (ReportMemoryUsageVisitor):
3575         (clang::ReportMemoryUsageAction::ParseArgs):
3576         (clang::AddMemberCallVisitor::VisitCallExpr):
3577         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3578         (clang::ReportMemoryUsageVisitor::emitWarning):
3579         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3580         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3581         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3582
3583 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3584
3585         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3586         https://bugs.webkit.org/show_bug.cgi?id=105835
3587
3588         Reviewed by Dirk Pranke.
3589
3590         The BeautifulSoup module is a third-party import and as such we don't have much control
3591         over its testing. Because of that it should be omitted from code coverage checking.
3592
3593         * Scripts/webkitpy/test/main.py:
3594         (Tester._run_tests):
3595
3596 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3597
3598         [GTK][WK2] Add support for IME Composition
3599         https://bugs.webkit.org/show_bug.cgi?id=65093
3600
3601         Reviewed by Carlos Garcia Campos.
3602
3603         Update unit tests for GtkInputMethodFilter to note whether or not an event
3604         was a fake event synthesized for composition purposes. This is now used
3605         for WebKit2.
3606
3607         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3608         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3609         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3610         (TestWebKitAPI::TEST):
3611         * gtk/generate-gtkdoc:
3612         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3613         generation.
3614
3615 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3616
3617         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3618         https://bugs.webkit.org/show_bug.cgi?id=105800
3619
3620         Reviewed by Yury Semikhatsky.
3621
3622         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3623         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3624         (clang):
3625
3626 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
3627
3628         Create a GTK build system watchlist and add myself to it
3629         https://bugs.webkit.org/show_bug.cgi?id=105769
3630
3631         Reviewed by Dirk Pranke.
3632
3633         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
3634         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
3635         omitted on purpose due to relatively high change rate they are exposed to.
3636
3637         The new watchlist would be of use to me as the GTK build system recently went
3638         through a series of changes that included a changed policy on adding configuration
3639         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
3640         mailing list about this change will be published later, but I'd also like to be