1 2014-05-06 David Kilzer <ddkilzer@apple.com>
3 Add Makefile targets for copying static libraries (LLVM and WKSI)
4 <http://webkit.org/b/132619>
8 * Scripts/copy-webkitlibraries-to-product-directory: Set a
9 sensible default for product directory if not specified on
10 either the command-line or in the environment (by Xcode) by
11 calling productDir() in webkitdirs.pm.
13 2014-05-06 Brady Eidson <beidson@apple.com>
15 Add WK2 SPI to prevent the previous back/forward item from remaining in the list
16 <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
18 Reviewed by Sam Weinig.
20 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
23 (TestWebKitAPI::itemURLLastComponentIsString):
24 (TestWebKitAPI::didFinishLoadForFrame):
25 (TestWebKitAPI::willGoToBackForwardListItem):
26 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
27 (TestWebKitAPI::setPageLoaderClient):
28 (TestWebKitAPI::TEST):
29 * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
30 * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
32 * WebKitTestRunner/TestController.cpp:
33 (WTR::TestController::createWebViewWithOptions): Update for new client layout.
35 2014-05-06 Darin Adler <darin@apple.com>
39 * DumpRenderTree/mac/TestRunnerMac.mm:
40 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
41 Updated since I changed testRunner into a pointer instead of a reference.
42 Updated argument names to avoid conflict with field names.
43 (-[APITestDelegateIPhone run]): Ditto.
44 (-[APITestDelegateIPhone _cleanUp]): Ditto.
46 2014-05-06 Commit Queue <commit-queue@webkit.org>
48 Unreviewed, rolling out r168304.
49 https://bugs.webkit.org/show_bug.cgi?id=132607
51 Broke the build (Requested by KaL on #webkit).
55 "[GTK][CMake] Unable to do make install"
56 https://bugs.webkit.org/show_bug.cgi?id=130188
57 http://trac.webkit.org/changeset/168304
59 2014-05-04 Darin Adler <darin@apple.com>
61 RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
62 https://bugs.webkit.org/show_bug.cgi?id=80222
64 Reviewed by Alexey Proskuryakov.
66 * DumpRenderTree/mac/TestRunnerMac.mm:
67 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
68 do more work here so we don't use RetainPtr local variables.
69 (-[APITestDelegateIPhone dealloc]): Added.
70 (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
71 created. Updated for changes to member names and types.
72 (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
73 updated for changes to member names and types. Changed to two word spelling.
74 (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
75 name of _cleanUp method.
76 (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
78 (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
80 2014-05-05 Benjamin Poulain <benjamin@webkit.org>
82 Clean up Image Document and tweak the layout and viewport
83 https://bugs.webkit.org/show_bug.cgi?id=132552
85 Reviewed by Anders Carlsson.
87 * DumpRenderTree/mac/DumpRenderTree.mm:
88 (resetWebPreferencesToConsistentValues):
89 Update the default settings to have something consistent with WebKit2.
91 2014-05-05 Martin Robinson <mrobinson@igalia.com>
93 [GTK][CMake] Unable to do make install
94 https://bugs.webkit.org/show_bug.cgi?id=130188
96 Reviewed by Carlos Garcia Campos.
98 * Scripts/webkitdirs.pm:
99 (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
100 will give an early signal that a change has broken the documentation.
102 2014-05-05 Pratik Solanki <psolanki@apple.com>
104 Update framework locations in package-root
105 https://bugs.webkit.org/show_bug.cgi?id=132571
107 Reviewed by Simon Fraser.
109 * Scripts/package-root:
111 2014-05-05 Ryuan Choi <ryuan.choi@samsung.com>
113 [EFL][WK2] Refactor favicon database APIs
114 https://bugs.webkit.org/show_bug.cgi?id=132519
116 Reviewed by Gyuyoung Kim.
118 * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
119 (update_view_favicon):
120 (on_icon_changed_cb):
124 (on_view_favicon_changed): Deleted.
126 2014-05-02 Mark Rowe <mrowe@apple.com>
128 <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
130 Reviewed by Dan Bernstein.
132 * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
133 when determining which LLVM archive to extract.
135 2014-05-02 Jeremy Jones <jeremyj@apple.com>
137 Add Jeremy as a committer.
138 https://bugs.webkit.org/show_bug.cgi?id=132492
140 Reviewed by Jer Noble.
142 Add myself as a committer.
144 * Scripts/webkitpy/common/config/contributors.json:
146 2014-05-02 Jeremy Jones <jeremyj@apple.com>
148 Add Jeremy as a committer.
149 https://bugs.webkit.org/show_bug.cgi?id=132492
151 Reviewed by Jer Noble.
153 Add Jeremy Jones to the committers file.
155 * Scripts/webkitpy/common/config/contributors.json:
157 2014-05-02 Brian J. Burg <burg@cs.washington.edu>
159 Hard to figure out how to run a single test with run-api-tests
160 https://bugs.webkit.org/show_bug.cgi?id=116332
162 Reviewed by Alexey Proskuryakov.
164 * Scripts/run-api-tests: add two examples to the help message.
166 2014-05-02 Simon Fraser <simon.fraser@apple.com>
168 Fix several memory leaks found by code inspection
169 https://bugs.webkit.org/show_bug.cgi?id=132472
171 Reviewed by Geoffrey Garen.
175 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
176 (TestWebKitAPI::TEST):
177 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
178 (WTR::InjectedBundlePage::willSendRequestForFrame):
179 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
180 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
182 2014-05-02 Filip Pizlo <fpizlo@apple.com>
184 DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
185 https://bugs.webkit.org/show_bug.cgi?id=132446
187 Reviewed by Mark Hahnenberg.
189 Test the FTL by default now that it's enabled by default.
191 * Scripts/run-javascriptcore-tests:
193 2014-05-01 Ryuan Choi <ryuan.choi@samsung.com>
195 [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
196 https://bugs.webkit.org/show_bug.cgi?id=132240
198 Reviewed by Anders Carlsson.
200 Removed ewk_view_setting_tiled_backingstore related code.
202 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
203 (DumpRenderTreeChrome::createView):
204 (shouldUseTiledBackingStore): Deleted.
205 * EWebLauncher/main.c:
207 (parseUserArguments):
209 2014-05-01 Anders Carlsson <andersca@apple.com>
211 window.testRunner.keepWebHistory() should update the UI process state
212 https://bugs.webkit.org/show_bug.cgi?id=132440
214 Reviewed by Dan Bernstein.
216 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
217 (WTR::InjectedBundle::postSetAddsVisitedLinks):
218 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
219 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
220 (WTR::TestRunner::keepWebHistory):
221 * WebKitTestRunner/TestInvocation.cpp:
222 (WTR::TestInvocation::invoke):
223 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
225 2014-05-01 David Kilzer <ddkilzer@apple.com>
227 Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
228 <http://webkit.org/b/132432>
230 Reviewed by Tim Horton.
232 * Scripts/webkitperl/FeatureList.pm: Remove support for
233 --plugin-proxy-for-video switch.
235 2014-04-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
237 Kernel sysctl interface hw.activecpu don't exists on Linux.
238 https://bugs.webkit.org/show_bug.cgi?id=132286
240 Reviewed by Filip Pizlo.
242 * Scripts/run-jsc-stress-tests: Redirect stderr to null when
243 calling sysctl over hw.activecpu
245 2014-04-30 Anders Carlsson <andersca@apple.com>
247 Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
248 https://bugs.webkit.org/show_bug.cgi?id=132399
249 <rdar://problem/15920046>
251 Reviewed by Dan Bernstein.
253 * Scripts/check-for-webkit-framework-include-consistency:
254 Allos WAK headers in WebKitLegacy as well as WebKit.
256 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
257 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
258 Update header imports.
260 2014-04-30 Simon Fraser <simon.fraser@apple.com>
262 [iOS WK2] Add test URL to crash reports for the UI process, clean up project
263 https://bugs.webkit.org/show_bug.cgi?id=131954
265 Reviewed by Darin Adler.
267 WebKitTestRunner was adding application-specific information to crash reports
268 to log the test path, but only in the web process. Fix it to also do this
269 for the UI process, for both iOS and OS X.
271 Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
274 Factored crash reprorter-related code into CrashReporterInfo, and call it from
275 a new TestController::platformWillRunTest() function on Mac and iOS.
277 Also remove Xcode-added unit test junk from the project.
279 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
280 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
281 * WebKitTestRunner/TestController.cpp:
282 (WTR::TestController::runTest):
283 * WebKitTestRunner/TestController.h:
284 * WebKitTestRunner/TestInvocation.cpp:
285 (WTR::TestInvocation::url):
286 * WebKitTestRunner/TestInvocation.h:
287 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
288 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
289 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
290 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
291 * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
292 * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
293 (WTR::testPathFromURL):
294 (WTR::setCrashReportApplicationSpecificInformationToURL):
295 * WebKitTestRunner/efl/TestControllerEfl.cpp:
296 (WTR::TestController::platformWillRunTest):
297 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
298 (WTR::TestController::platformWillRunTest):
299 * WebKitTestRunner/ios/TestControllerIOS.mm:
300 (WTR::TestController::platformWillRunTest):
301 (WTR::TestController::setHidden):
302 * WebKitTestRunner/mac/TestControllerMac.mm:
303 (WTR::TestController::platformWillRunTest):
305 2014-04-30 Simon Fraser <simon.fraser@apple.com>
307 Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
309 Reviewed by Tim Horton.
311 * DumpRenderTree/mac/DumpRenderTree.mm:
312 (resetWebPreferencesToConsistentValues):
313 (prepareConsistentTestingEnvironment):
315 2014-04-30 Anders Carlsson <andersca@apple.com>
317 check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
318 https://bugs.webkit.org/show_bug.cgi?id=132397
320 Reviewed by Dan Bernstein.
322 * Scripts/check-for-inappropriate-macros-in-external-headers:
324 2014-04-29 Martin Robinson <mrobinson@igalia.com>
326 [GTK] Make it easier to run CMake for downstreams
327 https://bugs.webkit.org/show_bug.cgi?id=132370
329 Reviewed by Carlos Garcia Campos.
331 * Scripts/webkitdirs.pm:
332 (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
335 2014-04-29 Stephanie Lewis <slewis@apple.com>
337 <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
339 Rubber stamped by Jessie Berlin.
341 JSON.pm was removed from our tools setup.
343 * Scripts/generate-coverage-data:
345 2014-04-29 Filip Pizlo <fpizlo@apple.com>
347 Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
348 https://bugs.webkit.org/show_bug.cgi?id=112840
350 Rubber stamped by Geoffrey Garen.
352 * Scripts/build-jsc: Enable it on Mac.
353 * Scripts/build-webkit: Enable it on Mac.
354 * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
356 2014-04-28 Sam Weinig <sam@webkit.org>
358 REGRESSION (r167751): svn-create-patch is very slow
359 https://bugs.webkit.org/show_bug.cgi?id=132300
361 Reviewed by Alexey Proskuryakov.
363 * Scripts/svn-create-patch:
364 Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
365 by calling `svn-create-patch --style`.
367 2014-04-29 Enrique Ocaña González <eocanha@igalia.com>
369 Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
370 https://bugs.webkit.org/show_bug.cgi?id=132190
372 Reviewed by Gustavo Noronha Silva.
374 * Scripts/webkitdirs.pm:
375 (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
376 if ninja is in the path.
377 (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
378 to the previous ninja generator if not.
380 2014-04-29 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
382 check-webkit-style should understand --git-index
383 https://bugs.webkit.org/show_bug.cgi?id=125364
385 Reviewed by Csaba Osztrogonác.
387 * Scripts/webkitpy/common/checkout/scm/git.py:
388 (Git.create_patch): The command now supports the --cached option.
389 * Scripts/webkitpy/style/main.py:
390 (CheckWebKitStyle.main): Passing the --git-index option.
391 * Scripts/webkitpy/style/optparser.py:
392 (CommandOptionValues.__init__): The git-index option is switched off by default.
393 (CommandOptionValues.__eq__): Equality check for the new option.
394 (ArgumentParser._create_option_parser):Adding the --git-index option
395 (ArgumentParser.parse):
396 * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
397 (CommandOptionValuesTest.test_init):
398 (CommandOptionValuesTest.test_eq):
400 2014-04-28 Michael Saboff <msaboff@apple.com>
402 Crash in platform/mac/accessibility/table-visible-rows.html
403 https://bugs.webkit.org/show_bug.cgi?id=132146
405 Reviewed by Filip Pizlo.
407 Instead of creating a local JSValueRef array on the stack and passing that to
408 JSObjectMakeArray(), changed to create an empty JSArray and then populate the
409 values using the JSObjectSetPropertyAtIndex() API.
411 * DumpRenderTree/AccessibilityUIElement.cpp:
412 (elementsForRangeCallback):
413 (convertElementsToObjectArray):
414 * DumpRenderTree/mac/TestRunnerMac.mm:
416 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
417 (WTR::EventSendingController::contextClick):
418 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
419 (WTR::stringArrayToJS):
420 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
421 (WTR::convertElementsToObjectArray):
423 2014-04-28 Filip Pizlo <fpizlo@apple.com>
425 Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
426 "no-cjit" runs force the old-school threshold.
428 Rubber stamped by Mark Hahnenberg.
430 * Scripts/run-jsc-stress-tests:
432 2014-04-28 Carlos Alberto Lopez Perez <clopez@igalia.com>
434 [GTK] install-dependencies should also install ruby-json and ruby-highline
435 https://bugs.webkit.org/show_bug.cgi?id=132292
437 Reviewed by Philippe Normand.
439 * gtk/install-dependencies: Install ruby json and highline packages.
441 2014-04-27 Joonghun Park <jh718.park@samsung.com>
443 [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
444 https://bugs.webkit.org/show_bug.cgi?id=132176
446 Reviewed by Gyuyoung Kim.
448 EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
449 and turn off indexedDB feature until the sqlite implementation is introduced.
451 * Scripts/webkitperl/FeatureList.pm:
453 2014-04-25 James Craig <jcraig@apple.com>
455 Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
456 https://bugs.webkit.org/show_bug.cgi?id=132209
458 Reviewed by Daniel Bates.
460 Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
461 Run check-webkit-style before generating changelogs to avoid additional spurious errors.
463 * Scripts/prepare-ChangeLog:
466 2014-04-25 Michael Saboff <msaboff@apple.com>
468 Crash in platform/mac/accessibility/table-visible-rows.html
469 https://bugs.webkit.org/show_bug.cgi?id=132146
471 Reviewed by Mark Lam.
473 Changed to use a local JSValueRef array temporary instead of a
474 std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
475 JSValues are visited during garbage collection when the stack is scanned. Otherwise,
476 the temporary values could be collected.
478 * DumpRenderTree/AccessibilityUIElement.cpp:
479 (convertElementsToObjectArray):
480 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
481 (WTR::EventSendingController::contextClick):
482 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
483 (WTR::convertElementsToObjectArray):
485 2014-04-24 Eduardo Lima Mitev <elima@igalia.com>
487 Unreviewed GTK gardening
489 * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
492 2014-04-24 László Langó <llango.u-szeged@partner.samsung.com>
494 prepare-ChangeLog reports as deleted methods that has not been removed.
495 https://bugs.webkit.org/show_bug.cgi?id=131733
497 Reviewed by Ryosuke Niwa.
499 * Scripts/prepare-ChangeLog:
500 (originalFile): Set merge base to origin/master by default.
502 2014-04-23 James Craig <jcraig@apple.com>
504 prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
505 https://bugs.webkit.org/show_bug.cgi?id=131115
507 Reviewed by Daniel Bates.
509 Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
511 * Scripts/commit-log-editor: Added --no-style.
512 * Scripts/prepare-ChangeLog: Primary patch.
513 (main): Primary patch.
514 (createPatchCommand): Added --no-style.
515 * Scripts/svn-create-patch: Primary patch.
516 * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
517 * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
518 (SVN.create_patch): Added --no-style.
520 2014-04-23 Anders Carlsson <andersca@apple.com>
522 Try to fix iOS build.
524 * DumpRenderTree/mac/DumpRenderTree.mm:
526 2014-04-23 Alexey Proskuryakov <ap@apple.com>
528 Eliminate internals.setMockScrollbarsEnabled()
529 https://bugs.webkit.org/show_bug.cgi?id=132085
531 Reviewed by Tim Horton.
533 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
534 No need to reset the preference, there is no way it can change.
536 2014-04-23 James Craig <jcraig@apple.com>
538 Unreviewed. Moving myself from Contributors to Committers list.
540 * Scripts/webkitpy/common/config/contributors.json:
542 2014-04-23 Tim Horton <timothy_horton@apple.com>
544 Mock scrollbars don't always work in DumpRenderTree
545 https://bugs.webkit.org/show_bug.cgi?id=132082
547 Reviewed by Alexey Proskuryakov.
549 * DumpRenderTree/mac/DumpRenderTree.mm:
550 (prepareConsistentTestingEnvironment):
551 Set the mock scrollbar setting before creating the WebView, as this setting
552 cannot be dynamically changed, so any scrollbars that are created during
553 WebView initialization and are not replaced before snapshotting will end
554 up being platform scrollbars instead of mock ones.
555 WebKitTestRunner already sets this preference before creating WKViews,
556 so we're just matching its behavior.
558 2014-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
560 [GTK] ShadowRoot API was removed in r164131
561 https://bugs.webkit.org/show_bug.cgi?id=132059
563 Reviewed by Gustavo Noronha Silva.
565 Add WebKitDOMShadowRoot to the list of deleted classes to generate
569 (WebKitDOMDocGenerator):
571 2014-04-23 Lorenzo Tilve <ltilve@igalia.com>
573 [GTK] run-webkit-tests script is failing to invoke run-launcher
574 https://bugs.webkit.org/show_bug.cgi?id=132051
576 Reviewed by Philippe Normand.
578 After the WK1 support was dropped, if run-webkit-tests is executed
579 without --no-show-results parameter, the launcher is being called
580 using a -2 parameter that is it causing the run-launcher to break.
582 * Scripts/webkitpy/port/gtk.py:
583 (GtkPort.show_results_html_file):
585 2014-04-22 Tim Horton <timothy_horton@apple.com>
587 DumpRenderTree generates black snapshots on some platforms
588 https://bugs.webkit.org/show_bug.cgi?id=132029
589 <rdar://problem/16679363>
591 Reviewed by Simon Fraser.
593 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
594 (createBitmapContextFromWebView):
595 DRT checks with the WebView to determine whether it can use the window's
596 backing store directly or (because of compositing) needs to take a WindowServer
597 snapshot. However, on some platforms and in some situations, the window can
598 be layer backed without the WebView necessarily currently being composited.
599 We should check with the window in addition to the WebView before going
600 ahead and using its backing store.
602 2014-04-22 Tim Horton <timothy_horton@apple.com>
604 DumpRenderTree generates white snapshots on some platforms
605 https://bugs.webkit.org/show_bug.cgi?id=132026
606 <rdar://problem/16679363>
608 Reviewed by Simon Fraser.
610 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
611 Link DRT against QuartzCore.
613 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
614 (createBitmapContextFromWebView):
615 Force CoreAnimation to synchronously update layers in a more explicit
616 way that doesn't depend on AppKit behavior. This is very similar to what
617 WebKitTestRunner does (indirectly) during its force repaint.
619 2014-04-22 Brent Fulgham <bfulgham@apple.com>
621 [Win] Support Python 2.7 in Cygwin
622 https://bugs.webkit.org/show_bug.cgi?id=132023
624 Reviewed by Michael Saboff.
626 * Scripts/webkitdirs.pm:
627 (checkInstalledTools): Remove check for Python 2.7, since
628 it now works properly.
630 2014-04-22 Filip Pizlo <fpizlo@apple.com>
632 Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
633 https://bugs.webkit.org/show_bug.cgi?id=130867
634 <rdar://problem/16432456>
636 Reviewed by Mark Hahnenberg.
638 * Scripts/build-webkit:
639 * Scripts/copy-webkitlibraries-to-product-directory:
641 2014-04-22 Gustavo Noronha Silva <gns@gnome.org>
643 [GTK] Fails to build documentation when output is redirected
644 https://bugs.webkit.org/show_bug.cgi?id=131178
646 Reviewed by Martin Robinson.
648 * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
649 explicitly to avoid encoding issues when they are redirected.
651 2014-04-22 ChangSeok Oh <changseok.oh@collabora.com>
653 [GTK] YCM choose a newer compile_commands.json in between Release or Debug
654 https://bugs.webkit.org/show_bug.cgi?id=131911
656 Reviewed by Martin Robinson.
658 common.get_build_path returns release path even though Debug configuration
659 is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
661 * gtk/ycm_extra_conf.py:
662 (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
665 2014-04-21 Brent Fulgham <bfulgham@apple.com>
667 Unreviewed build fix.
669 * DumpRenderTree/mac/EventSendingController.mm:
670 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
671 Correct a typo that prevented tests from working properly.
673 2014-04-21 Martin Robinson <mrobinson@igalia.com>
675 [GTK] Should have the ability to output composited contents during layout testing
676 https://bugs.webkit.org/show_bug.cgi?id=131864
678 Reviewed by Philippe Normand.
680 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
681 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
682 to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
683 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
684 (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
686 2014-04-21 Sam Weinig <sam@webkit.org>
688 Attempt to fix the tests.
690 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
691 (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
692 Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
694 2014-04-21 Filip Pizlo <fpizlo@apple.com>
696 Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
697 being the same as a "quick run", which is meant for genuinely slow tests).
699 * Scripts/run-jsc-stress-tests:
701 2014-04-21 Darin Adler <darin@apple.com>
704 https://bugs.webkit.org/show_bug.cgi?id=131928
706 Reviewed by Benjamin Poulain.
708 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
710 2014-04-20 Dan Bernstein <mitz@apple.com>
712 Fixed a test timing out after r167572.
714 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
715 (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
716 -webView:didFinishLoadingNavigation:.
718 2014-04-20 Commit Queue <commit-queue@webkit.org>
720 Unreviewed, rolling out r167510.
721 https://bugs.webkit.org/show_bug.cgi?id=131915
723 broke GTK Debug bot (Requested by philn on #webkit).
727 "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
728 it when running layout tests"
729 https://bugs.webkit.org/show_bug.cgi?id=131472
730 http://trac.webkit.org/changeset/167510
732 2014-04-18 Martin Robinson <mrobinson@igalia.com>
734 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
735 https://bugs.webkit.org/show_bug.cgi?id=131472
737 Reviewed by Philippe Normand.
739 * Scripts/webkitpy/port/gtk.py:
740 (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
741 when running WebKitTestRunner with run-webkit-tests.
742 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
744 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
745 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
746 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
749 2014-04-18 Alexey Proskuryakov <ap@apple.com>
751 DownloadDecideDestinationCrash API test uses an incorrect value for path
752 https://bugs.webkit.org/show_bug.cgi?id=131845
753 <rdar://problem/15925560>
755 Reviewed by Enrica Casucci.
757 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
758 (TestWebKitAPI::decideDestinationWithSuggestedFilename):
760 2014-04-17 Alexey Proskuryakov <ap@apple.com>
762 [Mac] AttributedStringTest API tests fail with async text input
763 https://bugs.webkit.org/show_bug.cgi?id=131833
765 Reviewed by Enrica Casucci.
767 Don't run sync NSTextInputClient tests where we don't implement these calls.
769 * TestWebKitAPI/Tests/mac/AttributedString.mm:
770 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
771 (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
772 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
773 (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
774 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
775 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
777 2014-04-18 Philippe Normand <pnormand@igalia.com>
779 Remove NETWORK_INFO support
780 https://bugs.webkit.org/show_bug.cgi?id=131841
782 Reviewed by Gyuyoung Kim.
784 * Scripts/webkitperl/FeatureList.pm:
786 2014-04-17 ChangSeok Oh <changseok.oh@collabora.com>
788 [GTK] YouCompleteMe doesn't work for cmake build system.
789 https://bugs.webkit.org/show_bug.cgi?id=131591
791 Reviewed by Martin Robinson.
793 Add cmake build system support for YouCompleteMe. It should work regardless of
794 using make or ninja. In addition, autotools related code is removed since it's
795 not used anymore in WebKit.
797 * Scripts/webkitdirs.pm:
798 (generateBuildSystemFromCMakeProject):
799 * gtk/ycm_extra_conf.py:
800 (transform_relative_paths_to_absolute_paths):
803 2014-04-17 Anders Carlsson <andersca@apple.com>
807 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
808 (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
809 (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
811 2014-04-17 Anders Carlsson <andersca@apple.com>
813 Remove unused API enums
814 https://bugs.webkit.org/show_bug.cgi?id=131836
816 Reviewed by Tim Horton.
818 * MiniBrowser/mac/WK2BrowserWindowController.m:
819 (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
821 2014-04-16 Brent Fulgham <bfulgham@apple.com>
823 [Win] A few final cleanups to the DataObject classes.
824 https://bugs.webkit.org/show_bug.cgi?id=131784
826 Reviewed by Anders Carlsson.
828 * DumpRenderTree/win/DRTDataObject.cpp:
829 (DRTDataObject::clearData): Use 'last()' method.
830 * DumpRenderTree/win/UIDelegate.cpp:
831 (DRTUndoStack::pop): Use 'takeLast()' method.
833 2014-04-17 Andres Gomez <agomez@igalia.com>
835 [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
836 https://bugs.webkit.org/show_bug.cgi?id=131365
838 Reviewed by Brent Fulgham.
840 The cygwin installer is now downloading the wanted versions for
841 the local installation given to the setup wizard.
843 * CygwinDownloader/cygwin-downloader.py:
844 * CygwinDownloader/cygwin-downloader.zip:
846 2014-04-17 Adrian Perez de Castro <aperez@igalia.com>
848 [GTK] Make run-webkit-tests always use WKTR
849 https://bugs.webkit.org/show_bug.cgi?id=131737
851 Reviewed by Darin Adler.
853 Now that the GTK+ port only has support for WebKit2, instruct
854 run-webkit-tests to always use WKTR. This avoids needing to pass
855 flag "-2" every time.
857 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
858 (_set_up_derived_options): Always set webkit_test_runner when
859 the platform is GTK+.
861 2014-04-17 Brendan Long <b.long@cablelabs.com>
863 [Gtk] Install ninja-build in Tools/gtk/install-dependencies
864 https://bugs.webkit.org/show_bug.cgi?id=131760
866 Reviewed by Philippe Normand.
868 * gtk/install-dependencies: Install ninja-build when it's available.
870 2014-04-16 peavo@outlook.com <peavo@outlook.com>
872 [Win] run-javascriptcore-tests fails to run.
873 https://bugs.webkit.org/show_bug.cgi?id=131761
875 Reviewed by Brent Fulgham.
877 * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
879 2014-04-16 Andres Gomez <agomez@igalia.com>
881 [Win] Pass default parameters to cygwin setup wizard
882 https://bugs.webkit.org/show_bug.cgi?id=131361
884 Reviewed by Brent Fulgham.
886 Added some parameters to the cygwin setup wizard so the user
887 doesn't really have to do any interaction.
889 * CygwinDownloader/cygwin-downloader.py:
890 * CygwinDownloader/cygwin-downloader.zip:
892 2014-04-15 Brent Fulgham <bfulgham@apple.com>
894 [Win] Eliminate use of deleteAllValues in Windows Files
895 https://bugs.webkit.org/show_bug.cgi?id=131631
897 Reviewed by Darin Adler.
899 Switch to std::unique_ptr for memory lifetime. Get rid of
900 deleteAllValues now that it is no longer needed. Use ranged
901 for loops where possible.
903 * DumpRenderTree/win/DRTDataObject.cpp:
904 (WCEnumFormatEtc::WCEnumFormatEtc):
905 (DRTDataObject::~DRTDataObject):
906 (DRTDataObject::GetData):
907 (DRTDataObject::QueryGetData):
908 (DRTDataObject::SetData):
909 (DRTDataObject::clearData):
910 * DumpRenderTree/win/DRTDataObject.h:
911 * DumpRenderTree/win/UIDelegate.cpp:
912 (DRTUndoObject::DRTUndoObject):
913 (DRTUndoObject::~DRTUndoObject):
914 (DRTUndoStack::~DRTUndoStack):
915 (DRTUndoStack::clear):
917 (DRTUndoManager::DRTUndoManager):
918 (DRTUndoManager::redo):
919 (DRTUndoManager::undo):
920 (UIDelegate::UIDelegate):
921 (UIDelegate::resetUndoManager):
922 * DumpRenderTree/win/UIDelegate.h:
924 2014-04-16 Carlos Alberto Lopez Perez <clopez@igalia.com>
926 [GTK] Unreviewed GTK gardening.
928 Update list of skipped unit tests:
930 Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
932 Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
933 and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
935 * Scripts/run-gtk-tests:
938 2014-04-16 Tim Horton <timothy_horton@apple.com>
940 check-webkit-style doesn't check code style in .mm or .m files
941 https://bugs.webkit.org/show_bug.cgi?id=131708
943 Reviewed by Darin Adler.
945 * Scripts/webkitpy/style/checker.py:
946 * Scripts/webkitpy/style/checker_unittest.py:
947 (CheckerDispatcherDispatchTest.test_cpp_paths):
948 (CheckerDispatcherDispatchTest.test_text_paths):
949 Check .mm and .m files as C++.
951 * Scripts/webkitpy/style/checkers/cpp.py:
953 Add an override for our ordinary "missing spaces around =" for @synthesize,
954 which should look like "@synthesize propertyName=_varName;"
956 Add an override for "missing space before {" for blocks' "^{".
958 Don't follow the "extra space before [" rule for Objective-C, because
959 it breaks this rule in a multitude of ways because of method calls.
962 Don't complain about { not being on the end of the previous line if
963 the previous line starts with "- (" or "+ (", which would indicate a
964 Objective-C method definition.
966 2014-04-16 Darin Adler <darin@apple.com>
968 Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
969 https://bugs.webkit.org/show_bug.cgi?id=131735
971 Reviewed by Alexey Proskuryakov.
973 * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
974 Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
975 is on the right. This can be confusing since our JavaScript test framework does it the opposite
976 way, but gtest works better this way.
978 2014-04-15 Hyowon Kim <hw1008.kim@samsung.com>
980 [EFL] Fix problems with the pixel dump.
981 https://bugs.webkit.org/show_bug.cgi?id=131265
983 Reviewed by Gyuyoung Kim.
985 Painting and compositing paths of WebKit-EFL were totally modified from r166768.
986 However pixel dump codes still call deprecated functions like ewk_view_paint(),
987 which causes that nothing is drawn.
989 This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
990 One of new functions is AcceleratedCompositingContext::extractImageData(),
991 which replaces deprecated function calls. Besides the extractImageData() is invoked by
992 ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
994 * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
995 (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
997 2014-04-15 Filip Pizlo <fpizlo@apple.com>
999 Update LLVM export scrpt to handle the build directory being different from the
1002 Rubber stamped by Geoffrey Garen.
1004 * Scripts/export-llvm-build:
1006 2014-04-15 Ryosuke Niwa <rniwa@webkit.org>
1008 Update the hyperlink to waterfall views of perf bots on build.webkit.org
1009 https://bugs.webkit.org/show_bug.cgi?id=131695
1011 Reviewed by Antti Koivisto.
1015 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1017 2014-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
1019 [GTK] Reduce the binary size by compressing the text based web inspector resources
1020 https://bugs.webkit.org/show_bug.cgi?id=121545
1022 Reviewed by Gustavo Noronha Silva.
1024 Compress text based files when compiling inspector resources. It
1025 reduces the binary size in 3MB.
1027 * gtk/generate-inspector-gresource-manifest.py:
1028 (find_all_files_in_directory):
1031 2014-04-14 Alexey Proskuryakov <ap@apple.com>
1033 Remove Gtk WebKit1 tester.
1035 Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1036 results over and over as fast as it could.
1038 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1041 2014-04-14 Alexey Proskuryakov <ap@apple.com>
1043 Wrong link for webkitpy tests results in dashboard popover
1044 https://bugs.webkit.org/show_bug.cgi?id=131664
1046 Reviewed by Timothy Hatcher.
1048 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1049 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1052 2014-04-14 Alexey Proskuryakov <ap@apple.com>
1054 Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1056 I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1058 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1059 (CommitMessageForThisCommitTest):
1061 2014-04-14 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
1063 Fix commit-log-editor bug revealed by r165447
1064 https://bugs.webkit.org/show_bug.cgi?id=130676
1066 Reviewed by Csaba Osztrogonác.
1068 * Scripts/commit-log-editor:
1069 (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1070 Add \n before the first block too, because the longest common prefix now ends with only one newline.
1071 (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1072 now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1074 2014-04-13 Darin Adler <darin@apple.com>
1076 userVisibleString should not try to "encode" host names
1077 https://bugs.webkit.org/show_bug.cgi?id=131587
1078 rdar://problem/14686849
1080 Reviewed by Alexey Proskuryakov.
1082 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1084 * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1085 Coverage is tiny at this point; we could add a lot more cases!
1087 2014-04-13 Jaehun Lim <ljaehun.lim@samsung.com>
1089 Use #include instead of #import
1090 https://bugs.webkit.org/show_bug.cgi?id=131604
1092 Reviewed by Darin Adler.
1094 Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1096 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1098 2014-04-12 Filip Pizlo <fpizlo@apple.com>
1100 Make slow-stress tests run faster by running fewer VM variants.
1102 Rubber stamped by Geoffrey Garen.
1104 * Scripts/run-javascriptcore-tests:
1105 * Scripts/run-jsc-stress-tests:
1107 2014-04-10 Zan Dobersek <zdobersek@igalia.com>
1109 [CMake] Add missing WTF unit tests
1110 https://bugs.webkit.org/show_bug.cgi?id=131459
1112 Reviewed by Martin Robinson.
1114 * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1115 that should be compiled into the TestWTF binary.
1117 2014-04-10 Brendan Long <b.long@cablelabs.com>
1119 [Gtk] run-launcher doesn't work by default
1120 https://bugs.webkit.org/show_bug.cgi?id=131494
1122 Reviewed by Philippe Normand.
1124 * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1125 * Scripts/webkitdirs.pm:
1126 (launcherName): Same.
1127 * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1129 (get_build_path.is_valid_build_directory): Same.
1130 * gtk/manifest.txt: Same.
1132 2014-04-09 Commit Queue <commit-queue@webkit.org>
1134 Unreviewed, rolling out r167046.
1135 https://bugs.webkit.org/show_bug.cgi?id=131479
1137 Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1142 "Remove "System Font" from whitelisted DRT fonts and char
1144 https://bugs.webkit.org/show_bug.cgi?id=131411
1145 http://trac.webkit.org/changeset/167046
1147 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
1149 Remove "System Font" from whitelisted DRT fonts and char width calculations
1150 https://bugs.webkit.org/show_bug.cgi?id=131411
1152 Reviewed by Tim Horton.
1154 Covered by existing tests.
1156 * DumpRenderTree/mac/DumpRenderTree.mm:
1157 (allowedFontFamilySet):
1159 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
1161 systemHiddenFontFamilySet in DRT is unnecessary
1162 https://bugs.webkit.org/show_bug.cgi?id=131414
1164 Reviewed by Tim Horton.
1166 It doesn't seem to affect test results on my machine.
1168 * DumpRenderTree/mac/DumpRenderTree.mm:
1169 (drt_NSFontManager_availableFonts):
1170 (systemHiddenFontFamilySet): Deleted.
1172 2014-04-09 Brent Fulgham <bfulgham@apple.com>
1174 [Win] Unreviewed test fix: Don't double-release BSTR.
1176 * DumpRenderTree/win/DumpRenderTree.cpp:
1177 (dump): Remove unneeded call to SysFreeString now that we are
1178 using _bstr_t for this variable.
1180 2014-04-09 Brent Fulgham <bfulgham@apple.com>
1182 [Win] Various DumpRenderTree Fixes.
1183 https://bugs.webkit.org/show_bug.cgi?id=131446.
1185 Reviewed by Tim Horton.
1187 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1188 (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1189 (AccessibilityUIElement::description): Ditto.
1190 (AccessibilityUIElement::helpText): Ditto.
1191 (AccessibilityUIElement::intValue): Ditto.
1192 (AccessibilityUIElement::isPressActionSupported): Ditto.
1193 (AccessibilityUIElement::accessibilityValue): Ditto.
1194 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1195 (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1196 (DRTDesktopNotificationPresenter::AddRef): Ditto.
1197 (DRTDesktopNotificationPresenter::Release): Ditto.
1198 (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1199 (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1200 (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1201 (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1202 (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1203 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1204 * DumpRenderTree/win/DumpRenderTree.cpp:
1205 (dumpFrameScrollPosition): Ditto.
1206 (dumpFramesAsText): Ditto.
1207 (compareHistoryItems): Ditto.
1208 (dumpHistoryItem): Ditto.
1210 (resetDefaultsToConsistentValues): Ditto.
1211 (resetWebViewToConsistentStateBeforeTesting): Ditto.
1213 (createWebViewAndOffscreenWindow): Ditto.
1214 * DumpRenderTree/win/EditingDelegate.cpp:
1215 (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1216 (EditingDelegate::AddRef): Ditto.
1217 (EditingDelegate::Release): Ditto.
1218 (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1219 (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1220 (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1221 (EditingDelegate::shouldInsertNode): Ditto.
1222 (EditingDelegate::shouldInsertText): Ditto.
1223 (EditingDelegate::shouldDeleteDOMRange): Ditto.
1224 (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1225 (EditingDelegate::shouldApplyStyle): Ditto.
1226 (EditingDelegate::shouldChangeTypingStyle): Ditto.
1227 (EditingDelegate::doPlatformCommand): Ditto.
1228 (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1229 (EditingDelegate::webViewDidChange): Ditto.
1230 (EditingDelegate::webViewDidEndEditing): Ditto.
1231 (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1232 (EditingDelegate::webViewDidChangeSelection): Ditto.
1233 (EditingDelegate::checkSpellingOfString): Ditto.
1234 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1235 (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1236 (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1237 (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1238 (FrameLoadDelegate::AddRef): Ditto.
1239 (FrameLoadDelegate::Release): Ditto.
1240 (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1241 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1242 (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1243 (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1244 (FrameLoadDelegate::didReceiveTitle): Ditto.
1245 (FrameLoadDelegate::didChangeIcons): Ditto.
1246 (delegatesWithDelayedWork): Ditto.
1247 (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1248 (FrameLoadDelegate::didFailLoadWithError): Ditto.
1249 (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1250 (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1251 (FrameLoadDelegate::willCloseFrame): Ditto.
1252 (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1253 (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1254 (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1255 (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1256 (FrameLoadDelegate::didRunInsecureContent): Ditto.
1257 * DumpRenderTree/win/FrameLoadDelegate.h:
1258 * DumpRenderTree/win/HistoryDelegate.cpp:
1259 (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1260 (HistoryDelegate::updateHistoryTitle): Ditto.
1261 (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1262 * DumpRenderTree/win/PolicyDelegate.cpp:
1264 (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1265 (PolicyDelegate::AddRef): Ditto.
1266 (PolicyDelegate::Release): Ditto.
1267 (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1268 (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1269 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1270 (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1271 (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1272 (ResourceLoadDelegate::AddRef): Ditto.
1273 (ResourceLoadDelegate::Release): Ditto.
1274 (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1275 (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1276 (ResourceLoadDelegate::willSendRequest): Ditto.
1277 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1278 (ResourceLoadDelegate::didReceiveResponse): Ditto.
1279 (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1280 (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1281 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1282 (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1283 (TestRunner::setUserStyleSheetLocation): Ditto.
1284 (TestRunner::execCommand): Ditto.
1285 (TestRunner::overridePreference): Ditto.
1286 (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1287 * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1288 (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1289 (TextInputController::insertText): Ditto.
1290 * DumpRenderTree/win/UIDelegate.cpp:
1291 (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1292 (UIDelegate::AddRef): Ditto.
1293 (UIDelegate::Release): Ditto.
1294 (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1295 (UIDelegate::trackCustomPopupMenu): Ditto.
1296 (UIDelegate::registerUndoWithTarget): Ditto.
1297 (UIDelegate::removeAllActionsWithTarget): Ditto.
1298 (UIDelegate::setActionTitle): Ditto.
1299 (UIDelegate::undo): Ditto.
1300 (UIDelegate::redo): Ditto.
1301 (UIDelegate::canUndo): Ditto.
1302 (UIDelegate::canRedo): Ditto.
1303 (UIDelegate::printFrame): Ditto.
1304 (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1305 (UIDelegate::webViewHeaderHeight): Ditto.
1306 (UIDelegate::webViewFooterHeight): Ditto.
1307 (UIDelegate::drawHeaderInRect): Ditto.
1308 (UIDelegate::drawFooterInRect): Ditto.
1309 (UIDelegate::webViewPrintingMarginRect): Ditto.
1310 (UIDelegate::canRunModal): Ditto.
1311 (UIDelegate::createModalDialog): Ditto.
1312 (UIDelegate::runModal): Ditto.
1313 (UIDelegate::isMenuBarVisible): Ditto.
1314 (UIDelegate::setMenuBarVisible): Ditto.
1315 (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1316 (UIDelegate::paintCustomScrollbar): Ditto.
1317 (UIDelegate::paintCustomScrollCorner): Ditto.
1318 (UIDelegate::setFrame): Ditto.
1319 (UIDelegate::webViewFrame): Ditto.
1320 (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1321 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1322 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1323 (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1324 (UIDelegate::webViewAddMessageToConsole): Ditto.
1325 (UIDelegate::doDragDrop): Ditto.
1326 (UIDelegate::webViewGetDlgCode): Ditto.
1327 (UIDelegate::createWebViewWithRequest): Ditto.
1328 (UIDelegate::webViewClose): Ditto.
1329 (UIDelegate::webViewFocus): Ditto.
1330 (UIDelegate::webViewUnfocus): Ditto.
1331 (UIDelegate::webViewPainted): Ditto.
1332 (UIDelegate::exceededDatabaseQuota): Ditto.
1333 (UIDelegate::embeddedViewWithArguments): Ditto.
1334 (UIDelegate::webViewClosing): Ditto.
1335 (UIDelegate::webViewSetCursor): Ditto.
1336 (UIDelegate::webViewDidInvalidate): Ditto.
1337 (UIDelegate::setStatusText): Ditto.
1338 (UIDelegate::desktopNotificationsDelegate): Ditto.
1339 (UIDelegate::drawBackground): Ditto.
1340 (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1341 (UIDelegate::didPressMissingPluginButton): Ditto.
1342 * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1343 (LoadItem::invoke): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1344 (LoadHTMLStringItem::invoke): Ditto.
1345 (ScriptItem::invoke): Ditto.
1347 2014-04-09 Gergo Balogh <gbalogh.u-szeged@partner.samsung.com>
1349 Stylechecker: False positive on inline asm code.
1350 https://bugs.webkit.org/show_bug.cgi?id=130570
1352 Reviewed by Csaba Osztrogonác.
1354 Disable stylechecking in asm blocks.
1356 * Scripts/webkitpy/style/checkers/cpp.py:
1359 (_InlineASMState.__init__):
1360 (_InlineASMState.process_line):
1361 (_InlineASMState.isInside):
1363 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1364 (WebKitStyleTest.test_member_initialization_list):
1366 2014-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
1368 [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1369 https://bugs.webkit.org/show_bug.cgi?id=131029
1371 Reviewed by Philippe Normand.
1373 Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1374 tests and remove the getWebKit1TestResoucesDir() method.
1376 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1377 (testDownloadLocalFile): Use Test::getResourcesDir().
1378 (testDownloadLocalFileError): Ditto.
1379 (serverCallback): Ditto.
1380 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1381 (serverCallback): Ditto.
1382 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1383 (httpServerCallback): Ditto.
1384 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1385 (serverCallback): Ditto.
1386 * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1387 * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1388 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1389 (Test::getWebKit1TestResoucesDir): Deleted.
1391 2014-04-09 Alexey Proskuryakov <ap@apple.com>
1393 [WK2] HTTP authentication regression tests fail
1394 https://bugs.webkit.org/show_bug.cgi?id=81627
1395 <rdar://problem/11079296>
1397 Reviewed by Anders Carlsson.
1399 * WebKitTestRunner/TestController.h:
1400 * WebKitTestRunner/TestController.cpp:
1401 (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1402 to pageLoaderClient structure.
1403 (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1404 for password based authentication (we do get server trust challenges on some tests,
1405 which WKTR can't handle).
1406 When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1407 calls won't be made, at least on CFNetwork based platforms.
1408 (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1409 to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1410 make sense to associate auth requests with individual resources - there can be
1411 multiple resources loading at once from the same protection space, so WebKit1 API
1412 that had a resource identifier was inherently racy.
1414 2014-04-09 Ryuan Choi <ryuan.choi@samsung.com>
1416 [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1417 https://bugs.webkit.org/show_bug.cgi?id=131427
1419 Reviewed by Gyuyoung Kim.
1421 Since r166973, font path was changed.
1423 * DumpRenderTree/PlatformEfl.cmake:
1424 * WebKitTestRunner/PlatformEfl.cmake:
1426 2014-04-08 Geoffrey Garen <ggaren@apple.com>
1428 Fix the build-jsc build
1429 https://bugs.webkit.org/show_bug.cgi?id=131410
1431 Reviewed by Michael Saboff.
1433 * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1436 2014-04-08 Martin Robinson <mrobinson@igalia.com>
1438 [GTK] Remove WebKit1 unit tests
1439 https://bugs.webkit.org/show_bug.cgi?id=131359
1441 Reviewed by Anders Carlsson.
1443 Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1444 entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1445 they were inadvertently left in http://trac.webkit.org/changeset/166504.
1447 * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1448 * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1449 * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1450 * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1451 * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1452 * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1453 * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1454 * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1455 * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1456 * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1457 * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1458 * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1459 * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1460 * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1461 * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1462 * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1463 * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1464 * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1465 * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1466 * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1467 * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1468 * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1469 * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1470 * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1471 * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1472 * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1473 * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1474 * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1475 * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1476 * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1477 * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1478 * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1479 * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1480 * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1481 * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1482 * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1483 * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1484 * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1486 2014-04-08 Brent Fulgham <bfulgham@apple.com>
1488 Unreviewed gardening (Take 2): Prevent users from attempting
1489 to build with known invalid cURL.
1491 * Scripts/webkitdirs.pm:
1492 (checkInstalledTools): Check for 7.34.0 (the broken version), not
1493 7.33.0 (the known good version).
1495 2014-04-08 Martin Robinson <mrobinson@igalia.com>
1497 [GTK] Remove DumpRenderTree and GtkLauncher
1498 https://bugs.webkit.org/show_bug.cgi?id=131373
1500 Reviewed by Andreas Kling.
1502 Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1503 no longer necessary now that WebKit1 GTK+ will be removed.
1506 * DumpRenderTree/PlatformGTK.cmake: Removed.
1507 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1508 * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1509 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1510 * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1511 * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1512 * DumpRenderTree/gtk/EventSender.cpp: Removed.
1513 * DumpRenderTree/gtk/EventSender.h: Removed.
1514 * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1515 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1516 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1517 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1518 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1519 * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1520 * DumpRenderTree/gtk/TextInputController.h: Removed.
1521 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1522 * GtkLauncher/CMakeLists.txt: Removed.
1523 * GtkLauncher/LauncherInspectorWindow.c: Removed.
1524 * GtkLauncher/LauncherInspectorWindow.h: Removed.
1525 * GtkLauncher/main.c: Removed.
1526 * GtkLauncher/simple.svg: Removed.
1527 * GtkLauncher/text.html: Removed.
1528 * WebKitTestRunner/PlatformGTK.cmake:
1529 * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1530 * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1531 * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1533 2014-04-08 Mark Rowe <mrowe@apple.com>
1535 XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1536 <https://webkit.org/b/131388> / <rdar://problem/16291687>
1538 Reviewed by Alexey Proskuryakov.
1540 * Scripts/webkitdirs.pm:
1541 (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1542 (execMacWebKitAppForDebugging): Ditto.
1544 2014-04-08 Geoffrey Garen <ggaren@apple.com>
1546 Build bmalloc on iOS too
1547 https://bugs.webkit.org/show_bug.cgi?id=131381
1549 Reviewed by Andreas Kling.
1551 * Scripts/build-webkit:
1553 2014-04-08 Brent Fulgham <bfulgham@apple.com>
1555 Unreviewed gardening: Prevent users from attempting
1556 to build with known invalid cURL.
1558 * Scripts/webkitdirs.pm:
1559 (checkInstalledTools): Block build attempts with bad
1562 2014-04-07 Geoffrey Garen <ggaren@apple.com>
1564 Build bmalloc on Mac
1565 https://bugs.webkit.org/show_bug.cgi?id=131333
1567 Reviewed by Mark Rowe.
1569 * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1570 (Note: Just testing Mac is not good enough because in this
1571 script 'Mac' means 'Mac or iOS'.)
1573 2014-03-30 Filip Pizlo <fpizlo@apple.com>
1575 Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1576 https://bugs.webkit.org/show_bug.cgi?id=130951
1578 Reviewed by Geoffrey Garen.
1580 * Scripts/run-javascriptcore-tests:
1582 2014-04-06 Darin Adler <darin@apple.com>
1584 Rework CSS calc logic, fixing some reference count mistakes in Length
1585 https://bugs.webkit.org/show_bug.cgi?id=131280
1587 Reviewed by Andreas Kling.
1589 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1590 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1592 2014-04-04 Brian J. Burg <burg@cs.washington.edu>
1594 Enable WEB_REPLAY for PLATFORM(MAC)
1595 https://bugs.webkit.org/show_bug.cgi?id=130700
1597 Reviewed by Timothy Hatcher.
1599 * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1601 2014-04-05 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1603 [CMake] Include X11's include dirs in TestNetscapePlugin
1604 https://bugs.webkit.org/show_bug.cgi?id=131270
1606 Reviewed by Martin Robinson.
1608 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1609 TestNetscapePlugin includes WebCore code that includes X headers.
1611 2014-04-05 David Kilzer <ddkilzer@apple.com>
1613 REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1614 <http://webkit.org/b/130986>
1616 * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1617 prefix to TileCache class names in exception list.
1619 2014-04-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
1621 [GTK] kill-old-processes should kill dbus-daemon processes
1622 https://bugs.webkit.org/show_bug.cgi?id=127352
1624 Reviewed by Martin Robinson.
1626 * BuildSlaveSupport/kill-old-processes:
1629 2014-04-04 Andres Gomez <agomez@igalia.com>
1631 [Win] Update obsolete packages in cygwin
1632 https://bugs.webkit.org/show_bug.cgi?id=126264
1634 Reviewed by Brent Fulgham.
1636 Removed "apache" and "minires" as the first has been replaced by
1637 "lighttpd" and the second is now integrated into
1638 "cygwin". Replaced the transitional and now obsolete "gcc" package
1639 with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1640 since the newer version available is "2.7.3" which breaks the
1641 build due to some funniness with environment variable handling.
1643 * CygwinDownloader/cygwin-downloader.py:
1644 * CygwinDownloader/cygwin-downloader.zip:
1646 2014-04-03 Joseph Pecoraro <pecoraro@apple.com>
1648 check-webkit-style: Improve warnings on Objective-C @property syntax
1649 https://bugs.webkit.org/show_bug.cgi?id=131200
1651 Reviewed by Dan Bernstein.
1653 * Scripts/webkitpy/style/checkers/cpp.py:
1656 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1657 (CppStyleTest.test_spacing_in_objective_c_properties):
1659 2014-04-03 Santosh Mahto <santoshbit2007@gmail.com>
1661 Unreviewed. Moving my name to commiter section
1663 * Scripts/webkitpy/common/config/contributors.json:
1665 2014-04-03 Santosh Mahto <santoshbit2007@gmail.com>
1667 Unreviewed. Add myself as a committer.
1669 * Scripts/webkitpy/common/config/contributors.json:
1671 2014-04-03 Andrzej Badowski <a.badowski@samsung.com>
1673 [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1674 https://bugs.webkit.org/show_bug.cgi?id=130391
1676 Reviewed by Gyuyoung Kim.
1678 Change the implementation of the zoom functionality from ewk_view_scale_set
1679 to ewk_view_page_zoom_set.
1681 * MiniBrowser/efl/main.c:
1683 2014-04-03 Manuel Rego Casasnovas <rego@igalia.com>
1685 [webkitpy] perf profiler does not understand --call-graph argument
1686 https://bugs.webkit.org/show_bug.cgi?id=131132
1688 Reviewed by Ryosuke Niwa.
1690 New versions of perf profiler have changed the argument from --call-graph to -g.
1692 * Scripts/webkitpy/common/system/profiler.py:
1693 (Perf.wrapper_arguments): Use -g instead of --call-graph.
1694 * Scripts/webkitpy/port/driver_unittest.py:
1695 (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1697 2014-04-03 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1699 Add EFL WK2 performance bot to build.webkit.org
1700 https://bugs.webkit.org/show_bug.cgi?id=131034
1702 Fix after r166707, use "Perf" instead of "perf" for consistency.
1704 Reviewed by Csaba Osztrogonác.
1706 * BuildSlaveSupport/build.webkit.org-config/config.json:
1708 2014-04-03 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1710 Add EFL WK2 performance bot to build.webkit.org
1711 https://bugs.webkit.org/show_bug.cgi?id=131034
1713 Reviewed by Csaba Osztrogonác.
1715 * BuildSlaveSupport/build.webkit.org-config/config.json:
1717 2014-04-02 Ryuan Choi <ryuan.choi@samsung.com>
1719 [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1720 https://bugs.webkit.org/show_bug.cgi?id=131151
1722 Reviewed by Gyuyoung Kim.
1724 * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1725 (TouchEventInfo::TouchEventInfo):
1727 (addTouchPointCallback):
1728 (updateTouchPointCallback):
1729 (cancelTouchPointCallback):
1730 (releaseTouchPointCallback):
1732 2014-04-02 David Kilzer <ddkilzer@apple.com>
1734 filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1735 <http://webkit.org/b/131045>
1737 Reviewed by Daniel Bates.
1739 * Scripts/filter-build-webkit:
1740 (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1741 of clang, plus debug data for all DVTAssertions.
1743 2014-04-01 Dean Jackson <dino@apple.com>
1745 Load Media Controls js/css from bundle
1746 https://bugs.webkit.org/show_bug.cgi?id=131086
1748 Reviewed by Eric Carlson.
1750 We're now putting CSS files into the bundle, so remove the test for them.
1752 * Scripts/check-for-inappropriate-files-in-framework:
1754 2014-04-02 Martin Hock <mhock@apple.com>
1756 Unify private browsing with sessions.
1757 https://bugs.webkit.org/show_bug.cgi?id=130099
1759 Reviewed by Alexey Proskuryakov.
1761 Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1762 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1764 (TestWebKitAPI::didNavigateWithNavigationData):
1765 (TestWebKitAPI::didSameDocumentNavigationForFrame):
1766 (TestWebKitAPI::TEST):
1768 * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1769 (TestWebKitAPI::didNavigateWithoutNavigationData):
1770 (TestWebKitAPI::didNavigateWithNavigationData):
1771 (TestWebKitAPI::didSameDocumentNavigationForFrame):
1772 (TestWebKitAPI::TEST):
1774 2014-04-02 Martin Robinson <mrobinson@igalia.com>
1776 REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1777 https://bugs.webkit.org/show_bug.cgi?id=130343
1779 Reviewed by Gustavo Noronha Silva.
1781 * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1782 of directories on the command line and look for all appropriate files in those directories for the
1783 GResource archive. Also make archive paths relative to those directories.
1784 (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1785 (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1787 2014-04-02 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1789 [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1790 https://bugs.webkit.org/show_bug.cgi?id=131106
1792 Reviewed by Csaba Osztrogonác.
1794 * Scripts/webkitpy/tool/commands/download.py:
1795 (AbstractRolloutPrepCommand._prepare_state):
1796 * Scripts/webkitpy/tool/commands/download_unittest.py:
1797 (test_prepare_rollout):
1798 (test_create_rollout):
1799 (test_create_rollout_resolved):
1802 2014-04-02 Krzysztof Wolanski <k.wolanski@samsung.com>
1804 [EFL] Add option to use separate web process for new window in MiniBrowser
1805 https://bugs.webkit.org/show_bug.cgi?id=130190
1807 Reviewed by Gyuyoung Kim.
1809 New created window (CTRL + n) will be open in separated web process.
1810 This option is enabled by adding a flag (S/separate-process) with launching
1813 * MiniBrowser/efl/main.c:
1816 2014-04-02 Carlos Garcia Campos <cgarcia@igalia.com>
1818 [GTK] Move NEWS file to a new location
1819 https://bugs.webkit.org/show_bug.cgi?id=130901
1821 Reviewed by Brent Fulgham.
1823 * gtk/manifest.txt: Update the NEWS file path.
1825 2014-04-01 Anders Carlsson <andersca@apple.com>
1829 * MiniBrowser/mac/WK2BrowserWindowController.m:
1830 (-[WK2BrowserWindowController awakeFromNib]):
1831 (-[WK2BrowserWindowController dealloc]):
1832 (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1834 2014-04-01 Brent Fulgham <bfulgham@apple.com>
1836 Unreviewed test gardening.
1838 * Scripts/webkitpy/port/base_unittest.py:
1839 (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1841 2014-04-01 Zoltan Horvath <zoltan@webkit.org>
1843 [CSS Exclusions] Remove exclusions parsing support
1844 https://bugs.webkit.org/show_bug.cgi?id=131046
1846 Reviewed by David Hyatt.
1848 * Scripts/webkitperl/FeatureList.pm:
1850 2014-04-01 Manuel Rego Casasnovas <rego@igalia.com>
1852 [GTK] Remove last reference to GTK+ WK1 EWS
1853 https://bugs.webkit.org/show_bug.cgi?id=131058
1855 Reviewed by Martin Robinson.
1857 In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1859 * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1861 2014-04-01 Lucas Forschler <lforschler@apple.com>
1863 Add a 32bit JSC builder/tester.
1864 https://bugs.webkit.org/show_bug.cgi?id=131054
1866 Reviewed by Michael Saboff.
1868 * BuildSlaveSupport/build.webkit.org-config/config.json:
1869 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1872 (Run32bitJSCTests.countFailures):
1873 (BuildAndTest32bitJSCFactory):
1874 (BuildAndTest32bitJSCFactory.__init__):
1876 2014-04-01 Martin Robinson <mrobinson@igalia.com>
1878 [GTK] No longer build WebKit1 gtkdoc
1879 https://bugs.webkit.org/show_bug.cgi?id=130970
1881 Reviewed by Anders Carlsson.
1884 (gtk_version_of_pkg_config_file): Deleted.
1885 * gtk/generate-gtkdoc:
1886 (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1887 was only applicable for WebKit1.
1888 (get_generator_for_config): No longer look for the WebKit1 configuration file.
1890 2014-04-01 Mario Sanchez Prada <mario.prada@samsung.com>
1892 [GTK] Running minibrowser with url crashes in debug build
1893 https://bugs.webkit.org/show_bug.cgi?id=130492
1895 Reviewed by Martin Robinson.
1897 Update "uri-scheme" test not to use invalid URIs in it, so we
1898 don't get a mistmatch when comparing the original URI stored in
1899 the test class with the one returned by the WebKitWebView.
1901 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1902 (testWebContextURIScheme): Update the test.
1904 2014-04-01 Mihai Tica <mitica@adobe.com>
1906 Unreviewed: Add myself as a commiter to the contributors list.
1908 * Scripts/webkitpy/common/config/contributors.json:
1910 2014-03-31 Ryuan Choi <ryuan.choi@samsung.com>
1912 [EFL][WK2] Extract the control of page background out of color_set
1913 https://bugs.webkit.org/show_bug.cgi?id=127539
1915 Reviewed by Gyuyoung Kim.
1917 Added an option(C) to change background color.
1919 * MiniBrowser/efl/main.c:
1923 2014-03-31 Ryuan Choi <ryuan.choi@samsung.com>
1925 Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1927 * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1929 2014-03-31 Brent Fulgham <bfulgham@apple.com>
1931 Unreviewed test correction after r166530.
1933 * DumpRenderTree/mac/DumpRenderTree.mm:
1934 (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1935 fine-grained setting for swipe tests. This prevents existing tests from breaking.
1937 2014-03-31 Carlos Alberto Lopez Perez <clopez@igalia.com>
1939 Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1940 https://bugs.webkit.org/show_bug.cgi?id=130987
1942 r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1943 trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1945 Reviewed by Martin Robinson.
1947 * BuildSlaveSupport/build.webkit.org-config/config.json:
1949 2014-03-31 Dean Jackson <dino@apple.com>
1951 Remove WEB_ANIMATIONS
1952 https://bugs.webkit.org/show_bug.cgi?id=130989
1954 Reviewed by Simon Fraser.
1956 Remove this feature flag until we plan to implement.
1958 * Scripts/webkitperl/FeatureList.pm:
1960 2014-03-31 Brent Fulgham <bfulgham@apple.com>
1962 Reduced Latched Scroll Test Flakiness
1963 https://bugs.webkit.org/show_bug.cgi?id=130983
1965 Reviewed by Darin Adler.
1967 * DumpRenderTree/mac/DumpRenderTree.mm:
1968 (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1969 * DumpRenderTree/mac/EventSendingController.mm:
1970 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1971 with high resolution flags turned on.
1972 * WebKitTestRunner/mac/EventSenderProxy.mm:
1973 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1975 2014-03-31 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
1977 run-webkit-tests should have a --no-timeout option
1978 https://bugs.webkit.org/show_bug.cgi?id=128286
1980 Reviewed by Joseph Pecoraro.
1982 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1983 (Worker._run_test): Renaming _run_test_with_timeout()
1984 (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1985 (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1986 (Worker._run_test_in_this_thread):
1987 (Worker._run_test_with_timeout): Deleted.
1988 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1989 (parse_args): Added the --no-timeout option
1991 2014-03-31 Samuel White <samuel_white@apple.com>
1993 AX: Need ability to get line range for text marker.
1994 https://bugs.webkit.org/show_bug.cgi?id=130906
1996 Reviewed by Chris Fleizach.
1998 Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2000 * DumpRenderTree/AccessibilityUIElement.cpp:
2001 (lineTextMarkerRangeForTextMarkerCallback):
2002 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2003 (AccessibilityUIElement::getJSClass):
2004 * DumpRenderTree/AccessibilityUIElement.h:
2005 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2006 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2007 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2008 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2009 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2010 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2011 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2012 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2013 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2014 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2015 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2016 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2018 2014-03-31 Filip Pizlo <fpizlo@apple.com>
2020 More validation for FTL inline caches
2021 https://bugs.webkit.org/show_bug.cgi?id=130948
2023 Reviewed by Geoffrey Garen.
2025 * Scripts/run-jsc-stress-tests:
2027 2014-03-31 Carlos Garcia Campos <cgarcia@igalia.com>
2029 [GTK] Do not run WebKit1 unit tests by default
2030 https://bugs.webkit.org/show_bug.cgi?id=130968
2032 Reviewed by Martin Robinson.
2034 * Scripts/run-gtk-tests:
2037 2014-03-31 Martin Robinson <mrobinson@igalia.com>
2039 [GTK] Remove scripts code only applicable to autotools
2040 https://bugs.webkit.org/show_bug.cgi?id=130841
2042 Reviewed by Anders Carlsson.
2044 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2045 (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2046 * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2047 * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2048 * gtk/find-make-dist-errors: Removed.
2049 * gtk/generate-feature-defines-files: Removed.
2050 * gtk/manifest.txt: No longer need to consider autotools files.
2052 2014-03-30 Andy Estes <aestes@apple.com>
2054 Fix two failing layout tests on Mountain Lion after r166466.
2056 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2057 (-[DownloadDelegate _downloadDidStart:]):
2059 2014-03-30 Andy Estes <aestes@apple.com>
2061 [Cocoa] Add an originatingWebView property to _WKDownload
2062 https://bugs.webkit.org/show_bug.cgi?id=130945
2064 Reviewed by Anders Carlsson.
2066 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2067 (-[DownloadDelegate _downloadDidStart:]):
2068 (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2069 (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2072 2014-03-28 Filip Pizlo <fpizlo@apple.com>
2074 Land the stackmap register liveness glue with the uses of the liveness disabled
2075 https://bugs.webkit.org/show_bug.cgi?id=130924
2077 Reviewed by Oliver Hunt.
2079 * Scripts/run-jsc-stress-tests:
2081 2014-03-29 Alexey Proskuryakov <ap@apple.com>
2083 Update WebKit1.StringTruncator for Mountain Lion.
2085 * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2086 due to different font metrics on 10.8.
2088 2014-03-28 Darin Adler <darin@apple.com>
2090 Fix recently-introduced off-by-one error in centerTruncateToBuffer
2091 https://bugs.webkit.org/show_bug.cgi?id=130889
2093 Reviewed by Alexey Proskuryakov.
2095 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2096 * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2097 WebStringTruncator methods; should be good for a start. These are dependent on the
2098 metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2100 2014-03-28 Martin Hock <mhock@apple.com>
2102 Unreviewed. Add myself as a committer.
2104 * Scripts/webkitpy/common/config/contributors.json:
2106 2014-03-28 Martin Robinson <mrobinson@igalia.com>
2108 Remove WebKit1 GTK+ bots
2109 https://bugs.webkit.org/show_bug.cgi?id=130904
2111 Reviewed by Anders Carlsson.
2113 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2114 all bots are testing WebKit2 only.
2115 * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2116 * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2117 * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2118 * Scripts/webkitpy/port/builders.py: Ditto.
2119 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2120 * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2122 2014-03-28 Timothy Hatcher <timothy@apple.com>
2124 Remove Brian Burg's apple.com email address.
2126 * Scripts/webkitpy/common/config/contributors.json:
2128 2014-03-28 David Kilzer <ddkilzer@apple.com>
2130 bisect-builds should print Trac 'changeset' URL if only one build is detected
2131 <http://webkit.org/b/130903>
2133 Reviewed by Dan Bernstein.
2135 * Scripts/bisect-builds:
2136 (printTracLink): Print a direct link to the Trac 'changeset'
2137 URL if there is only one revision in the range.
2139 2014-03-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2141 [EFL] Bump glib version from 2.36 to 2.38
2142 https://bugs.webkit.org/show_bug.cgi?id=130886
2144 Reviewed by Csaba Osztrogonác.
2146 There is a build break on EFL port when using glib 2.36 ver. To fix it,
2147 we need to bump glib version up to 2.38 as gtk port.
2149 * efl/jhbuild.modules:
2151 2014-03-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
2153 <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2155 Provide an implementation of WKContextHistoryClient that logs when called for tests in
2156 the globalhistory directory.
2158 Reviewed by Sam Weinig.
2160 * WebKitTestRunner/TestController.cpp:
2161 (WTR::TestController::TestController):
2162 (WTR::TestController::initialize): Set the history client.
2163 (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2164 (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2165 of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2166 and we don't yet have API to access the data in question.
2167 (WTR::TestController::didPerformClientRedirect):
2168 (WTR::TestController::didPerformServerRedirect):
2169 (WTR::TestController::didUpdateHistoryTitle):
2170 * WebKitTestRunner/TestController.h:
2171 (WTR::TestController::setShouldLogHistoryClientCallbacks):
2172 * WebKitTestRunner/TestInvocation.cpp:
2173 (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2174 (WTR::TestInvocation::invoke):
2176 2014-03-27 Filip Pizlo <fpizlo@apple.com>
2178 Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2180 * Scripts/build-webkit:
2181 * Scripts/copy-webkitlibraries-to-product-directory:
2183 2014-03-27 Filip Pizlo <fpizlo@apple.com>
2185 Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2186 https://bugs.webkit.org/show_bug.cgi?id=130867
2187 <rdar://problem/16432456>
2189 Reviewed by Mark Hahnenberg.
2191 * Scripts/build-webkit:
2192 * Scripts/copy-webkitlibraries-to-product-directory:
2194 2014-03-26 Andy Estes <aestes@apple.com>
2196 [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2197 https://bugs.webkit.org/show_bug.cgi?id=130805
2199 Reviewed by Dan Bernstein.
2201 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2202 (-[DownloadDelegate _download:didReceiveResponse:]):
2203 (-[DownloadDelegate _downloadDidFinish:]):
2206 (-[FailingDownloadDelegate _downloadDidFinish:]):
2207 (-[FailingDownloadDelegate _download:didFailWithError:]):
2208 (-[FailingDownloadDelegate _downloadDidCancel:]):
2209 (-[CancelledDownloadDelegate _downloadDidStart:]):
2210 (-[CancelledDownloadDelegate _downloadDidFinish:]):
2211 (-[CancelledDownloadDelegate _download:didFailWithError:]):
2212 (-[CancelledDownloadDelegate _downloadDidCancel:]):
2213 (-[DownloadDelegate initWithSourceURL:]): Deleted.
2214 (-[DownloadDelegate sourceURL]): Deleted.
2215 (runTestWithNavigationDelegate): Deleted.
2217 2014-03-26 Anders Carlsson <andersca@apple.com>
2219 Change MiniBrowser to hold on to window controllers instead of windows
2220 https://bugs.webkit.org/show_bug.cgi?id=130797
2222 Reviewed by Oliver Hunt.
2224 * MiniBrowser/mac/AppDelegate.h:
2225 * MiniBrowser/mac/AppDelegate.m:
2226 (-[BrowserAppDelegate init]):
2227 (-[BrowserAppDelegate newWindow:]):
2228 (-[BrowserAppDelegate browserWindowWillClose:]):
2229 (-[BrowserAppDelegate applicationWillTerminate:]):
2230 (-[BrowserAppDelegate frontmostBrowserWindowController]):
2232 2014-03-26 Commit Queue <commit-queue@webkit.org>
2234 Unreviewed, rolling out r166264.
2235 https://bugs.webkit.org/show_bug.cgi?id=130785
2237 Broke some window.opener tests for WK2 Mavericks (Requested by
2238 brrian__ on #webkit).
2242 "Web Replay: resource unique identifiers should be unique-per-
2243 frame, not globally"
2244 https://bugs.webkit.org/show_bug.cgi?id=130632
2245 http://trac.webkit.org/changeset/166264
2247 2014-03-26 Zoltan Horvath <zoltan@webkit.org>
2249 [CSS Shapes] Remove shape-inside support
2250 https://bugs.webkit.org/show_bug.cgi?id=130698
2252 Reviewed by David Hyatt.
2254 * Scripts/webkitperl/FeatureList.pm:
2256 2014-02-27 Gurpreet Kaur <k.gurpreet@samsung.com>
2258 Unreviewed. Add myself as a committer.
2260 * Scripts/webkitpy/common/config/contributors.json:
2262 2014-03-26 Tomas Popela <tpopela@redhat.com>
2264 run-launcher is Perl script so use elsif and not elif
2265 https://bugs.webkit.org/show_bug.cgi?id=130771
2267 Reviewed by Carlos Garcia Campos.
2269 * Scripts/run-launcher:
2271 2014-03-26 Krzysztof Czech <k.czech@samsung.com>
2273 [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2274 https://bugs.webkit.org/show_bug.cgi?id=130575
2276 Reviewed by Mario Sanchez Prada.
2278 Change ATK version to 2.11.92. Adjust current implementation.
2280 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2281 (AccessibilityUIElement::intValue):
2282 (AccessibilityUIElement::minValue):
2283 (AccessibilityUIElement::maxValue):
2284 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2285 (WTR::AccessibilityUIElement::intValue):
2286 (WTR::AccessibilityUIElement::minValue):
2287 (WTR::AccessibilityUIElement::maxValue):
2288 * efl/jhbuild.modules:
2289 * gtk/jhbuild.modules:
2291 2014-03-12 Philippe Normand <pnormand@igalia.com>
2293 [GTK] The gnumake package is no longer needed in jhbuild
2294 https://bugs.webkit.org/show_bug.cgi?id=130121
2296 Reviewed by Martin Robinson.
2298 For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2299 for a debug build cmake/system-gnumake worked just fine for me.
2301 * gtk/jhbuild.modules: Removed gnumake.
2302 * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2303 * gtk/patches/make-3.82-parallel-build.patch: Removed.
2305 2014-03-25 Andy Estes <aestes@apple.com>
2307 Fix a failing API test on Mountain Lion and remove temporary debug logging.
2309 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2310 (-[DownloadDelegate _download:didReceiveData:]):
2311 (-[DownloadDelegate _downloadDidFinish:]):
2313 2014-03-25 Brian Burg <bburg@apple.com>
2315 Web Replay: resource unique identifiers should be unique-per-frame, not globally
2316 https://bugs.webkit.org/show_bug.cgi?id=130623
2318 Reviewed by Timothy Hatcher.
2320 The resource loader callback dumping routines assumed that resource identifiers
2321 were globally unique. Its map of resource identifiers to URLs must also track the
2322 frame associated with the resource.
2324 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2325 (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2326 opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2327 stable as long as the frame is valid.
2328 (WTR::InjectedBundlePage::didInitiateLoadForResource):
2329 (WTR::InjectedBundlePage::willSendRequestForFrame):
2330 (WTR::InjectedBundlePage::didReceiveResponseForResource):
2331 (WTR::InjectedBundlePage::didFinishLoadForResource):
2332 (WTR::InjectedBundlePage::didFailLoadForResource):
2334 2014-03-25 Andy Estes <aestes@apple.com>
2336 Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2338 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2339 (-[DownloadDelegate _download:didReceiveResponse:]):
2340 (-[DownloadDelegate _download:didReceiveData:]):
2342 2014-03-25 Andy Estes <aestes@apple.com>
2344 Add some debug logging to an API test that's failing on Mountain Lion.
2346 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2347 (-[DownloadDelegate _download:didReceiveResponse:]):
2348 (-[DownloadDelegate _downloadDidFinish:]):
2350 2014-03-25 Anders Carlsson <andersca@apple.com>
2352 Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2353 https://bugs.webkit.org/show_bug.cgi?id=130732
2355 Reviewed by Tim Horton.
2357 * MiniBrowser/mac/WK2BrowserWindowController.m:
2358 (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2360 2014-03-25 Martin Robinson <mrobinson@igalia.com>
2362 [GTK] Remove the autotools build
2363 https://bugs.webkit.org/show_bug.cgi?id=130717
2365 Reviewed by Anders Carlsson.
2367 * DumpRenderTree/config.h: Remove references to the autotools configure file.
2368 * GNUmakefile.am: Removed.
2369 * GtkLauncher/GNUmakefile.am: Removed.
2370 * GtkLauncher/main.c: Remove references to the autotools configure file.
2371 * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2372 * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2373 * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2374 * MiniBrowser/gtk/GNUmakefile.am: Removed.
2375 * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2376 * Scripts/build-webkit: No longer handle autotools.
2377 * Scripts/run-gtk-tests: Ditto.
2378 (TestRunner._setup_testing_environment):
2379 * Scripts/run-launcher: Ditto.
2380 * Scripts/webkitdirs.pm: Ditto.
2381 * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2382 * Scripts/webkitpy/common/config/contributors.json: Ditto.
2383 * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2384 * Scripts/webkitpy/style/checker.py:
2385 * TestWebKitAPI/GNUmakefile.am: Removed.
2386 * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2387 * WebKitTestRunner/GNUmakefile.am: Removed.
2388 * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2389 * gtk/GNUmakefile.am: Removed.
2390 * gtk/common.py: Remove checks for the autotools build.
2391 * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2393 2014-03-25 László Langó <llango.u-szeged@partner.samsung.com>
2395 prepare-ChangeLog throws false positive warnings for modified files.
2396 https://bugs.webkit.org/show_bug.cgi?id=130687
2398 Reviewed by Darin Adler.
2400 * Scripts/prepare-ChangeLog:
2401 (originalFile): Ignore git commit paremeter.
2402 We don't need this to get the unmodified file.
2403 (extractLineRangeBeforeChange):
2404 Simplify the if statement. Follow-up after r166189.
2406 2014-03-25 Gabor Rapcsanyi <rgabor@webkit.org>
2408 [EFL] Add ARM64 build support
2409 https://bugs.webkit.org/show_bug.cgi?id=130506
2411 Rubber stamped by Gyuyoung Kim.
2413 * Scripts/webkitdirs.pm:
2414 (isARM): Detect aarch64 as ARM.
2416 2014-03-25 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2418 [webkitpy] Improve _parse_bug_description to recognize more descriptions
2419 https://bugs.webkit.org/show_bug.cgi?id=130137
2421 Reviewed by Csaba Osztrogonác.
2423 * Scripts/webkitpy/common/checkout/changelog.py:
2424 (ChangeLogEntry._parse_bug_description):
2425 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2426 (test_parse_log_entries_from_changelog):
2427 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2428 (CheckoutTest.test_commit_info_for_revision):
2430 2014-03-24 Andy Estes <aestes@apple.com>
2432 Fix the iOS build of TestWebKitAPI.
2434 * TestWebKitAPI/Configurations/Base.xcconfig:
2435 * TestWebKitAPI/PlatformUtilities.h:
2437 2014-03-24 László Langó <llango.u-szeged@partner.samsung.com>
2439 Fix prepare-ChangeLog after r166156.
2440 https://bugs.webkit.org/show_bug.cgi?id=130674
2442 Reviewed by Darin Adler.
2444 * Scripts/prepare-ChangeLog:
2445 (generateFunctionLists):
2446 (extractLineRangeBeforeChange):
2448 2014-03-24 Andy Estes <aestes@apple.com>
2450 [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2451 https://bugs.webkit.org/show_bug.cgi?id=129322
2453 Reviewed by Anders Carlsson.
2455 Add an API test suite for _WKDownload.
2457 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2459 (-[DownloadDelegate initWithSourceURL:]):
2460 (-[DownloadDelegate sourceURL]):
2461 (-[DownloadDelegate _downloadDidStart:]):
2462 (-[DownloadDelegate _download:didReceiveResponse:]):
2463 (-[DownloadDelegate _download:didReceiveData:]):
2464 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2465 (-[DownloadDelegate _downloadDidFinish:]):
2467 (runTestWithNavigationDelegate):
2468 (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2469 (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2471 2014-03-24 Joseph Pecoraro <pecoraro@apple.com>
2473 filter-build-webkit: reduce unfiltered output
2474 https://bugs.webkit.org/show_bug.cgi?id=130485
2476 Reviewed by Brent Fulgham.
2478 * Scripts/filter-build-webkit:
2481 2014-03-24 László Langó <llango.u-szeged@partner.samsung.com>
2483 prepare-ChangeLog should list functions that have been removed too.
2484 https://bugs.webkit.org/show_bug.cgi?id=130508
2486 Reviewed by Darin Adler.
2488 The prepare-ChangeLog does not list the deleted functions in the Changelog.
2489 We have to read the functions and the line ranges of them from the source
2490 before the change, then search for overlaps between them and the changed
2491 line ranges from diff.
2493 * Scripts/prepare-ChangeLog:
2494 (originalFile): Get original source command.
2495 (generateFunctionLists): Collect deleted functions too.
2496 (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2497 (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2498 deleted functions ranges too.
2499 (extractLineRange): Renamed to extractLineRangeAfterChange.
2501 2014-03-23 Hyowon Kim <hw1008.kim@samsung.com>
2503 Move all EFL typedefs into EflTypedefs.h.
2504 https://bugs.webkit.org/show_bug.cgi?id=130511
2506 Reviewed by Gyuyoung Kim.
2508 * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2509 * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2510 * WebKitTestRunner/PlatformWebView.h: Ditto.
2512 2014-03-21 Simon Fraser <simon.fraser@apple.com>
2514 Don't flush compositing layers within FrameView::willPaintContents()
2515 https://bugs.webkit.org/show_bug.cgi?id=130627
2516 <rdar://problem/16368869>
2518 Reviewed by Sam Weinig.
2520 Fix DRT to correctly render tests with layers now that FrameView::paintContents
2523 Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2524 into an explicit function called before dumping.
2526 Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2527 are flushed to CA. They will be pushed to the window by snapshotting.
2529 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2530 Fix weird path to IOKit.framework.
2531 * DumpRenderTree/mac/DumpRenderTree.mm:
2534 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2535 (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2536 (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2538 2014-03-21 David Kilzer <ddkilzer@apple.com>
2540 fix-blink-patch: tool to fix up renamed directory paths in Blink
2541 <http://webkit.org/b/130609>
2543 Reviewed by Ryosuke Niwa.
2545 Usage: cat blink.patch | fix-blink-patch | svn-apply
2547 * Scripts/fix-blink-patch: Added.
2549 2014-03-21 Darin Adler <darin@apple.com>
2551 Remove use of deprecatedCharacters in WebKit API tests
2552 https://bugs.webkit.org/show_bug.cgi?id=130602
2554 Reviewed by Antti Koivisto.
2556 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2557 (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2558 (TestWebKitAPI::expectEmpty): Use characters8.
2559 (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2561 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2562 Removed the test that is entirely about 16-bit conversion since that's basically a test of
2563 the deprecatedCharacters function itself, which we are about to delete.
2565 2014-03-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2567 [webkitpy] Fix has_valid_reviewer()
2568 https://bugs.webkit.org/show_bug.cgi?id=130589
2570 Reviewed by Csaba Osztrogonác.
2572 * Scripts/webkitpy/common/checkout/changelog.py:
2573 (ChangeLogEntry.has_valid_reviewer):
2574 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2575 (test_has_valid_reviewer):
2576 * Scripts/webkitpy/common/config/committers.py:
2577 (CommitterList._reviewer_only):
2578 (CommitterList.committer_by_name):
2579 (CommitterList.reviewer_by_email):
2581 (CommitterList.reviewer_by_name):
2583 2014-03-21 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
2585 Add cache support for jhbuild
2586 https://bugs.webkit.org/show_bug.cgi?id=130588
2588 Reviewed by Csaba Osztrogonác.
2590 * jhbuild/jhbuildrc_common.py:
2591 (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2593 2014-03-21 Xabier Rodriguez Calvar <calvaris@igalia.com>
2595 [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2596 https://bugs.webkit.org/show_bug.cgi?id=130504
2598 Reviewed by Martin Robinson.
2600 * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2601 CMake if not specified.
2602 * Scripts/webkitdirs.pm:
2603 (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2604 (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2606 2014-03-21 Andreas Kling <akling@apple.com>
2608 RetainPtr API test should use CFArray instead of CFString for testing.
2609 <rdar://problem/16384899>
2613 * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2614 (TestWebKitAPI::TEST):
2615 * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2616 (TestWebKitAPI::TEST):
2618 2014-03-20 Hyowon Kim <hw1008.kim@samsung.com>
2620 Move to using std::unique_ptr for EFL objects.
2621 https://bugs.webkit.org/show_bug.cgi?id=129853
2623 Reviewed by Gyuyoung Kim.
2625 EflUniquePtr is a template alias of std::unique_ptr
2626 with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2627 This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2629 * DumpRenderTree/efl/DumpRenderTree.cpp:
2631 * ImageDiff/efl/ImageDiff.cpp:
2635 2014-03-20 Ryuan Choi <ryuan.choi@samsung.com>
2637 Unreviewed buildfix after r165983 for non Cocoa platforms
2639 Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2641 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2642 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2643 * WebKitTestRunner/TestController.cpp:
2645 2014-03-20 Zan Dobersek <zdobersek@igalia.com>
2647 [GTK][CMake] Add support for building with Clang
2648 https://bugs.webkit.org/show_bug.cgi?id=130260
2650 Reviewed by Martin Robinson.
2652 * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2653 built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2654 included GTest framework headers.
2655 * gtk/generate-gtkdoc:
2656 (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2657 in case of using Clang since that is now set by the CMake rule.
2659 2014-03-19 Simon Fraser <simon.fraser@apple.com>
2661 Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2662 https://bugs.webkit.org/show_bug.cgi?id=130476
2664 Reviewed by Anders Carlsson.
2666 Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2668 * MiniBrowser/mac/WK1BrowserWindowController.m:
2669 (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2671 * MiniBrowser/mac/WK2BrowserWindowController.m:
2672 (-[WK2BrowserWindowController awakeFromNib]):
2673 (-[WK2BrowserWindowController validateMenuItem:]):
2674 (-[WK2BrowserWindowController reload:]):
2676 (-[WK2BrowserWindowController toggleZoomMode:]):
2677 (-[WK2BrowserWindowController resetZoom:]):
2678 (-[WK2BrowserWindowController canResetZoom]):
2679 (-[WK2BrowserWindowController currentZoomFactor]):
2680 (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2681 (-[WK2BrowserWindowController canZoomIn]):
2682 (-[WK2BrowserWindowController canZoomOut]):
2684 2014-03-19 Alexey Proskuryakov <ap@apple.com>
2686 REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2687 https://bugs.webkit.org/show_bug.cgi?id=130463
2689 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2691 2014-03-18 Samuel White <samuel_white@apple.com>
2693 AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2694 https://bugs.webkit.org/show_bug.cgi?id=130250
2696 Reviewed by Chris Fleizach.
2698 Added ability to toggle enhanced accessibility on and off to support tests that require it.
2700 * DumpRenderTree/AccessibilityController.cpp:
2701 (enableEnhancedAccessibilityCallback):
2702 (getEnhancedAccessibilityEnabledCallback):
2703 (AccessibilityController::getJSClass):
2704 * DumpRenderTree/AccessibilityController.h:
2705 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2706 (AccessibilityController::enableEnhancedAccessibility):
2707 (AccessibilityController::enhancedAccessibilityEnabled):
2708 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2709 (AccessibilityController::enableEnhancedAccessibility):
2710 (AccessibilityController::enhancedAccessibilityEnabled):
2711 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2712 (AccessibilityController::enableEnhancedAccessibility):
2713 (AccessibilityController::enhancedAccessibilityEnabled):
2714 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2715 (AccessibilityController::enableEnhancedAccessibility):
2716 (AccessibilityController::enhancedAccessibilityEnabled):
2717 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2718 (WTR::AccessibilityController::enableEnhancedAccessibility):
2719 (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2720 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2721 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2723 2014-03-18 Filip Pizlo <fpizlo@apple.com>
2725 Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2728 * Scripts/webkitpy/common/config/contributors.json:
2730 2014-03-18 Joseph Pecoraro <pecoraro@apple.com>
2732 Web Inspector: Remove stale ReportMemoryUsagePlugin
2733 https://bugs.webkit.org/show_bug.cgi?id=130405
2735 Reviewed by Andreas Kling.
2737 This clang plugin looks like it was used for the old Inspector memory
2738 instrumentation that was removed. So the tool can be removed.
2740 * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2741 * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2742 * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2743 * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2745 2014-03-18 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2747 webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2748 https://bugs.webkit.org/show_bug.cgi?id=130220
2750 Reviewed by Csaba Osztrogonác.
2752 * Scripts/webkitpy/common/checkout/changelog.py:
2753 (ChangeLog.set_reviewer):
2754 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2755 (test_set_reviewer):
2757 2014-03-17 Filip Pizlo <fpizlo@apple.com>
2761 Rubber stamped by Dan Bernstein.
2763 * Tools/Scripts/build-webkit:
2765 2014-03-17 Simon Fraser <simon.fraser@apple.com>
2767 Renable pagination mode in WK2 MiniBrowser
2768 https://bugs.webkit.org/show_bug.cgi?id=130374
2770 Reviewed by Anders Carlsson.
2772 Put the implementation of togglePaginationMode: back, and correctly
2773 enable the menu item.
2775 * MiniBrowser/mac/WK2BrowserWindowController.m:
2776 (-[WK2BrowserWindowController validateMenuItem:]):
2777 (-[WK2BrowserWindowController isPaginated]):
2778 (-[WK2BrowserWindowController togglePaginationMode:]):
2780 2014-03-18 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2782 Add --reset option to Tools/Scripts/set-webkit-configuration script
2783 https://bugs.webkit.org/show_bug.cgi?id=130401
2785 Reviewed by Csaba Osztrogonác.
2787 * Scripts/set-webkit-configuration:
2789 2014-03-18 Alberto Garcia <berto@igalia.com>
2791 [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2792 https://bugs.webkit.org/show_bug.cgi?id=130388
2794 Reviewed by Sergio Villar Senin.
2796 * Scripts/webkitdirs.pm:
2797 (shouldRemoveCMakeCache): make sure that the build directory
2798 exists before attempting to create a file in it.
2800 2014-03-18 Robert Plociennik <r.plociennik@samsung.com>
2802 [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2803 https://bugs.webkit.org/show_bug.cgi?id=130336
2805 Reviewed by Gyuyoung Kim.
2807 Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2808 requires a space between literal and string macro [-Wliteral-suffix]'
2809 warning treated as error.
2811 This patch applies a solution from r162448 to the EFL port.
2813 * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2814 * efl/jhbuild.modules: Added appropriate patch section.
2816 2014-03-17 Ryosuke Niwa <rniwa@webkit.org>
2818 webkitpy test rebaseline.
2820 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2821 (MainTest.test_default_args):
2823 2014-03-17 Ryosuke Niwa <rniwa@webkit.org>
2825 --profile should imply --test-runner-count=1 in run-perf-tests
2826 https://bugs.webkit.org/show_bug.cgi?id=130375
2828 Reviewed by Benjamin Poulain.
2830 Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2832 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2833 (PerfTestsRunner._parse_args): Use -1 as the default value.
2834 (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2835 then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2838 2014-03-17 Simon Fraser <simon.fraser@apple.com>
2840 Address some style nits.
2842 * MiniBrowser/mac/WK2BrowserWindowController.m:
2844 2014-03-17 Simon Fraser <simon.fraser@apple.com>
2846 Add transparent window support back into MiniBrowser
2847 https://bugs.webkit.org/show_bug.cgi?id=130363
2849 Reviewed by Anders Carlsson.
2851 Re-enable transparent window support for WK2.
2853 * MiniBrowser/mac/WK2BrowserWindowController.m:
2854 (-[WK2BrowserWindowController validateMenuItem:]):
2855 (-[WK2BrowserWindowController toggleTransparentWindow:]):
2857 2014-03-17 Simon Fraser <simon.fraser@apple.com>
2859 Fix the 32-bit build; make the open panel make a WK1 window.
2861 * MiniBrowser/mac/AppDelegate.m:
2862 (-[BrowserAppDelegate openDocument:]):
2864 2014-03-17 Simon Fraser <simon.fraser@apple.com>
2866 Convert MiniBrowser to use WKWebView API
2867 https://bugs.webkit.org/show_bug.cgi?id=130061
2869 Reviewed by Anders Carlsson.
2871 Convert the MiniBrowser WK2 window to use WebKit2 API as much
2874 Some functionality was removed temporarily:
2875 - text zoom, page zoom
2878 - transparent window
2880 - window.open support
2881 - beforeUnload panel
2884 * MiniBrowser/mac/AppDelegate.h:
2885 * MiniBrowser/mac/AppDelegate.m:
2886 (-[BrowserAppDelegate init]):
2887 (-[BrowserAppDelegate newWindow:]):
2888 (-[BrowserAppDelegate applicationWillTerminate:]):
2889 (-[BrowserAppDelegate openDocument:]):
2890 * MiniBrowser/mac/WK2BrowserWindowController.h:
2891 * MiniBrowser/mac/WK2BrowserWindowController.m:
2892 (-[WK2BrowserWindowController awakeFromNib]):
2893 (-[WK2BrowserWindowController dealloc]):
2894 (-[WK2BrowserWindowController fetch:]):
2895 (-[WK2BrowserWindowController validateMenuItem:]):
2896 (-[WK2BrowserWindowController reload:]):
2897 (-[WK2BrowserWindowController goBack:]):
2898 (-[WK2BrowserWindowController goForward:]):
2899 (-[WK2BrowserWindowController toggleZoomMode:]):
2900 (-[WK2BrowserWindowController resetZoom:]):
2901 (-[WK2BrowserWindowController canResetZoom]):
2902 (-[WK2BrowserWindowController dumpSourceToConsole:]):
2903 (-[WK2BrowserWindowController togglePaginationMode:]):
2904 (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2905 (-[WK2BrowserWindowController windowShouldClose:]):
2906 (-[WK2BrowserWindowController applicationTerminating]):
2907 (-[WK2BrowserWindowController currentZoomFactor]):
2908 (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2909 (-[WK2BrowserWindowController toggleTransparentWindow:]):
2910 (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2911 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2912 (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2913 (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2914 (-[WK2BrowserWindowController find:]):
2915 (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2916 (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2917 (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2918 (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2919 (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2920 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2921 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2922 * WebKitTestRunner/PlatformWebView.h:
2923 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2924 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2926 2014-03-17 Zan Dobersek <zdobersek@igalia.com>
2928 Use RunLoop objects through references instead of pointers
2929 https://bugs.webkit.org/show_bug.cgi?id=130313
2931 Reviewed by Andreas Kling.
2933 Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2934 return RunLoop reference instead of a pointer.
2936 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2940 2014-03-17 Tim Horton <timothy_horton@apple.com>
2942 sort-export-file --help doesn't work (missing 'use')
2943 https://bugs.webkit.org/show_bug.cgi?id=130338
2945 Reviewed by Anders Carlsson.
2947 * Scripts/sort-export-file:
2948 Add a missing 'use', and fix a typo in an error message.
2950 2014-03-17 Martin Robinson <mrobinson@igalia.com>
2952 [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2953 https://bugs.webkit.org/show_bug.cgi?id=130155
2955 Reviewed by Philippe Normand.
2957 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2959 2014-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
2961 [GTK] MiniBrowser fails to load injected bundle lib
2962 https://bugs.webkit.org/show_bug.cgi?id=130332
2964 Reviewed by Anders Carlsson.
2966 This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2968 * MiniBrowser/gtk/main.c:
2969 (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2972 2014-03-16 Kim Byung Jun <bj1987.kim@samsung.com>
2974 [EFL] Enable TOUCH_SLIDER macro
2975 https://bugs.webkit.org/show_bug.cgi?id=130185
2977 Reviewed by Gyuyoung Kim.
2979 * Scripts/webkitperl/FeatureList.pm:
2981 2014-03-16 Zan Dobersek <zdobersek@igalia.com>
2983 [GTK][CMake] Build with -fno-rtti
2984 https://bugs.webkit.org/show_bug.cgi?id=130261
2986 Reviewed by Martin Robinson.
2988 * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2989 defined to 0 to prevent typeid use in included GTest headers.
2991 2014-03-16 Brian Burg <bburg@apple.com>
2993 Web Inspector: vended backend commands file should be generated as part of the build
2994 https://bugs.webkit.org/show_bug.cgi?id=130110
2996 Reviewed by Timothy Hatcher.
2998 * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3000 2014-03-16 Diego Pino García <dpino@igalia.com>
3002 [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3003 https://bugs.webkit.org/show_bug.cgi?id=128999
3005 Reviewed by Philippe Normand.
3007 * MiniBrowser/gtk/BrowserWindow.c:
3009 (reloadPageIgnoringCache):
3010 (browser_window_init):
3012 2014-03-15 Martin Robinson <mrobinson@igalia.com>
3014 [GTK] Improve ninja detection in webkitdirs.pm
3015 https://bugs.webkit.org/show_bug.cgi?id=129902
3017 Reviewed by Daniel Bates.
3019 * Scripts/webkitdirs.pm:
3020 (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3021 us to look for ninja-build as well.
3023 2014-03-14 Maciej Stachowiak <mjs@apple.com>
3025 Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3026 https://bugs.webkit.org/show_bug.cgi?id=130276
3027 <rdar://problem/16266927>
3029 Reviewed by Simon Fraser.
3031 * BuildSlaveSupport/build-launcher-app:
3032 * BuildSlaveSupport/build-launcher-dmg:
3033 * DumpRenderTree/DumpRenderTree.h:
3034 * DumpRenderTree/DumpRenderTreePrefix.h:
3035 * DumpRenderTree/GCController.cpp:
3036 * DumpRenderTree/GCController.h:
3037 * DumpRenderTree/JavaScriptThreading.cpp:
3038 * DumpRenderTree/JavaScriptThreading.h:
3039 * DumpRenderTree/PixelDumpSupport.cpp:
3040 * DumpRenderTree/PixelDumpSupport.h:
3041 * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3042 * DumpRenderTree/TestRunner.cpp:
3043 * DumpRenderTree/TestRunner.h:
3044 * DumpRenderTree/WorkQueue.cpp:
3045 * DumpRenderTree/WorkQueue.h:
3046 * DumpRenderTree/WorkQueueItem.h:
3047 * DumpRenderTree/atk/AccessibilityCallbacks.h:
3048 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3049 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3050 * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3051 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3052 * DumpRenderTree/cg/PixelDumpSupportCG.h:
3053 * DumpRenderTree/efl/EditingCallbacks.cpp:
3054 * DumpRenderTree/efl/EditingCallbacks.h:
3055 * DumpRenderTree/efl/EventSender.cpp:
3056 * DumpRenderTree/efl/EventSender.h:
3057 * DumpRenderTree/efl/GCControllerEfl.cpp:
3058 * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3059 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3060 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3061 * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3062 * DumpRenderTree/gtk/EditingCallbacks.cpp:
3063 * DumpRenderTree/gtk/EditingCallbacks.h:
3064 * DumpRenderTree/gtk/EventSender.cpp:
3065 * DumpRenderTree/gtk/EventSender.h:
3066 * DumpRenderTree/gtk/GCControllerGtk.cpp:
3067 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3068 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3069 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3070 * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3071 * DumpRenderTree/gtk/TextInputController.cpp:
3072 * DumpRenderTree/gtk/TextInputController.h:
3073 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3074 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3075 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3076 * DumpRenderTree/mac/AppleScriptController.h:
3077 * DumpRenderTree/mac/AppleScriptController.m:
3078 * DumpRenderTree/mac/CheckedMalloc.cpp:
3079 * DumpRenderTree/mac/CheckedMalloc.h:
3080 * DumpRenderTree/mac/DumpRenderTree.mm:
3081 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3082 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3083 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3084 * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3085 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3086 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3087 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3088 * DumpRenderTree/mac/EditingDelegate.h:
3089 * DumpRenderTree/mac/EditingDelegate.mm:
3090 * DumpRenderTree/mac/EventSendingController.h:
3091 * DumpRenderTree/mac/EventSendingController.mm:
3092 * DumpRenderTree/mac/FrameLoadDelegate.h:
3093 * DumpRenderTree/mac/FrameLoadDelegate.mm:
3094 * DumpRenderTree/mac/GCControllerMac.mm:
3095 * DumpRenderTree/mac/MockWebNotificationProvider.h:
3096 * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3097 * DumpRenderTree/mac/NavigationController.h:
3098 * DumpRenderTree/mac/NavigationController.m:
3099 * DumpRenderTree/mac/ObjCController.h:
3100 * DumpRenderTree/mac/ObjCController.m:
3101 * DumpRenderTree/mac/ObjCPlugin.h:
3102 * DumpRenderTree/mac/ObjCPlugin.m:
3103 * DumpRenderTree/mac/ObjCPluginFunction.h:
3104 * DumpRenderTree/mac/ObjCPluginFunction.m:
3105 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3106 * DumpRenderTree/mac/PolicyDelegate.h:
3107 * DumpRenderTree/mac/PolicyDelegate.mm:
3108 * DumpRenderTree/mac/ResourceLoadDelegate.h:
3109 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3110 * DumpRenderTree/mac/TestRunnerMac.mm:
3111 * DumpRenderTree/mac/TextInputController.h:
3112 * DumpRenderTree/mac/TextInputController.m:
3113 * DumpRenderTree/mac/UIDelegate.h:
3114 * DumpRenderTree/mac/UIDelegate.mm:
3115 * DumpRenderTree/mac/WorkQueueItemMac.mm:
3116 * DumpRenderTree/win/DRTDataObject.cpp:
3117 * DumpRenderTree/win/DRTDataObject.h:
3118 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3119 * DumpRenderTree/win/DRTDropSource.cpp:
3120 * DumpRenderTree/win/DRTDropSource.h:
3121 * DumpRenderTree/win/DraggingInfo.h:
3122 * DumpRenderTree/win/DumpRenderTree.cpp:
3123 * DumpRenderTree/win/DumpRenderTreeWin.h:
3124 * DumpRenderTree/win/EditingDelegate.cpp:
3125 * DumpRenderTree/win/EditingDelegate.h:
3126 * DumpRenderTree/win/EventSender.cpp:
3127 * DumpRenderTree/win/EventSender.h:
3128 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3129 * DumpRenderTree/win/FrameLoadDelegate.h:
3130 * DumpRenderTree/win/GCControllerWin.cpp:
3131 * DumpRenderTree/win/HistoryDelegate.cpp:
3132 * DumpRenderTree/win/HistoryDelegate.h:
3133 * DumpRenderTree/win/MD5.cpp:
3134 * DumpRenderTree/win/MD5.h:
3135 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3136 * DumpRenderTree/win/PolicyDelegate.cpp:
3137 * DumpRenderTree/win/PolicyDelegate.h:
3138 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3139 * DumpRenderTree/win/ResourceLoadDelegate.h:
3140 * DumpRenderTree/win/TestRunnerWin.cpp:
3141 * DumpRenderTree/win/TextInputController.cpp:
3142 * DumpRenderTree/win/TextInputController.h:
3143 * DumpRenderTree/win/TextInputControllerWin.cpp:
3144 * DumpRenderTree/win/UIDelegate.cpp:
3145 * DumpRenderTree/win/UIDelegate.h:
3146 * DumpRenderTree/win/WorkQueueItemWin.cpp:
3147 * EWebLauncher/main.c:
3148 * GtkLauncher/main.c:
3149 * ImageDiff/efl/ImageDiff.cpp:
3150 * ImageDiff/gtk/ImageDiff.cpp:
3151 * MiniBrowser/gtk/main.c:
3152 * Scripts/SpacingHeuristics.pm:
3153 * Scripts/VCSUtils.pm:
3154 * Scripts/bisect-builds:
3155 * Scripts/build-dumprendertree:
3156 * Scripts/build-jsc:
3157 * Scripts/build-webkit:
3158 * Scripts/check-dom-results:
3159 * Scripts/check-for-exit-time-destructors:
3160 * Scripts/check-for-global-initializers:
3161 * Scripts/commit-log-editor:
3162 * Scripts/compare-timing-files:
3163 * Scripts/debug-minibrowser:
3164 * Scripts/debug-safari:
3165 * Scripts/do-file-rename:
3166 * Scripts/find-extra-includes:
3167 * Scripts/generate-coverage-data:
3168 * Scripts/make-script-test-wrappers:
3169 * Scripts/malloc-tree:
3170 * Scripts/old-run-webkit-tests:
3171 * Scripts/parse-malloc-history:
3172 * Scripts/report-include-statistics:
3173 * Scripts/resolve-ChangeLogs:
3174 * Scripts/run-bindings-tests:
3175 * Scripts/run-iexploder-tests:
3176 * Scripts/run-javascriptcore-tests:
3178 * Scripts/run-launcher:
3179 * Scripts/run-leaks:
3180 * Scripts/run-mangleme-tests:
3181 * Scripts/run-minibrowser:
3182 * Scripts/run-pageloadtest:
3183 * Scripts/run-regexp-tests:
3184 * Scripts/run-safari:
3185 * Scripts/run-sunspider:
3186 * Scripts/run-webkit-app:
3188 * Scripts/set-webkit-configuration:
3189 * Scripts/sort-Xcode-project-file:
3190 * Scripts/sort-export-file:
3191 * Scripts/split-file-by-class:
3192 * Scripts/sunspider-compare-results:
3193 * Scripts/svn-apply:
3194 * Scripts/svn-create-patch:
3195 * Scripts/svn-unapply:
3196 * Scripts/test-webkit-scripts:
3197 * Scripts/update-javascriptcore-test-results:
3198 * Scripts/update-webkit:
3199 * Scripts/update-webkit-auxiliary-libs:
3200 * Scripts/update-webkit-dependency:
3201 * Scripts/update-webkit-localizable-strings:
3202 * Scripts/update-webkit-support-libs:
3203 * Scripts/update-webkit-wincairo-libs:
3204 * Scripts/webkit-build-directory:
3205 * Scripts/webkitdirs.pm:
3206 (installedSafariPath):
3207 * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3208 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3209 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3210 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3211 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3212 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3213 * Scripts/webkitperl/features.pm:
3214 * Scripts/webkitperl/httpd.pm:
3215 * Scripts/webkitpy/bindings/main.py:
3216 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3217 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3218 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3219 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3220 * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3221 * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3222 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3223 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3224 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3225 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3226 * WebKitTestRunner/PixelDumpSupport.cpp:
3227 * WebKitTestRunner/PixelDumpSupport.h:
3228 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3229 * WinLauncher/WinLauncher.cpp:
3230 * WinLauncher/WinLauncher.h:
3231 * WinLauncher/stdafx.cpp:
3232 * WinLauncher/stdafx.h:
3234 2014-03-14 Filip Pizlo <fpizlo@apple.com>
3236 Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3237 https://bugs.webkit.org/show_bug.cgi?id=130265
3239 Reviewed by Michael Saboff.
3241 * Scripts/build-webkit:
3242 * Scripts/copy-webkitlibraries-to-product-directory:
3244 2014-03-14 Landry Breuil <landry@openbsd.org>
3246 Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3247 Also allow to set MAKE in the environment.
3248 https://bugs.webkit.org/show_bug.cgi?id=129991
3250 Reviewed by Andreas Kling.
3252 * Scripts/webkitdirs.pm:
3253 (determineArchitecture):
3254 (determineNumberOfCPUs):
3256 (buildAutotoolsProject):
3257 * Scripts/webkitpy/common/system/platforminfo.py:
3258 (PlatformInfo.__init__):
3259 (PlatformInfo.is_openbsd):
3261 (PlatformInfo.is_netbsd):
3262 (PlatformInfo._determine_os_name):
3264 2014-03-14 Dean Jackson <dino@apple.com>
3266 Remove libWebKitSystemInterfaceLion.a
3267 https://bugs.webkit.org/show_bug.cgi?id=130254
3269 Reviewed by Geoffrey Garen and Andreas Kling.
3271 No need to copy the Lion libraries into the build.
3273 * Scripts/copy-webkitlibraries-to-product-directory:
3275 2014-03-14 Jinwoo Song <jinwoo7.song@samsung.com>
3277 [EFL][MiniBrowser] Revise help messages of command line parameters
3278 https://bugs.webkit.org/show_bug.cgi?id=130222
3280 Reviewed by Csaba Osztrogonác.
3282 Correct the default value description and make help messages to be consistent.
3284 * MiniBrowser/efl/main.c:
3286 2014-03-12 Sergio Villar Senin <svillar@igalia.com>
3288 Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3289 https://bugs.webkit.org/show_bug.cgi?id=129612
3291 Reviewed by Darin Adler.
3293 For new code use static NeverDestroyed<T> instead.
3295 * DumpRenderTree/JavaScriptThreading.cpp:
3296 (javaScriptThreadsMutex):
3297 (javaScriptThreads):
3298 * DumpRenderTree/efl/EventSender.cpp:
3300 (delayedEventQueue):
3301 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3302 (delegatesWithDelayedWork):
3303 * Scripts/check-for-exit-time-destructors:
3304 * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3305 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3308 2014-03-13 Sanghyup Lee <sh53.lee@samsung.com>
3310 [EFL][WK2] Fix compilation warning in Minibrowser
3311 https://bugs.webkit.org/show_bug.cgi?id=130132
3313 Reviewed by Csaba Osztrogonác.
3315 Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3317 * MiniBrowser/efl/main.c:
3318 (on_download_request):
3320 2014-03-13 Filip Pizlo <fpizlo@apple.com>
3322 FTL should support IsBlah
3323 https://bugs.webkit.org/show_bug.cgi?id=130202
3325 Reviewed by Geoffrey Garen.
3327 Running existing JSRegress tests with noInline gives us coverage for these
3328 changes. Chances are, this will also give coverage for other interesting things
3331 * Scripts/run-jsc-stress-tests:
3333 2014-03-12 Brian Burg <bburg@apple.com>
3335 Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3336 https://bugs.webkit.org/show_bug.cgi?id=129744
3338 Reviewed by Timothy Hatcher.
3340 * DumpRenderTree/TestRunner.cpp:
3341 (evaluateInWebInspectorCallback):
3342 * DumpRenderTree/TestRunner.h:
3343 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3344 (TestRunner::evaluateInWebInspector):
3345 * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3346 (TestRunner::evaluateInWebInspector):
3347 * DumpRenderTree/mac/TestRunnerMac.mm:
3348 (TestRunner::evaluateInWebInspector):
3349 * DumpRenderTree/win/TestRunnerWin.cpp:
3350 (TestRunner::evaluateInWebInspector):
3351 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3352 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3353 (WTR::TestRunner::evaluateInWebInspector):
3354 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3356 2014-03-13 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
3358 [GTK] build-webkit shouldn't show error message when ninja isn't installed
3359 https://bugs.webkit.org/show_bug.cgi?id=130129
3361 Reviewed by Csaba Osztrogonác.
3363 * Scripts/webkitdirs.pm:
3364 (canUseNinja): Redirecting stderr to /dev/null
3366 2014-03-13 Andres Gomez <agomez@igalia.com>
3368 [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3369 https://bugs.webkit.org/show_bug.cgi?id=130092
3371 Reviewed by Csaba Osztrogonác.
3373 Added "python-dev" as dependency for deb based distros. It is
3374 already present for rpm based distros. This dependency will allow
3375 libxml2 to generate its python bindings, needed by gtk-doc.
3377 * gtk/install-dependencies:
3379 2014-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
3381 Unreviewed. Fix GTK+ cmake build after r165488.
3383 * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3385 2014-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
3387 [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3388 https://bugs.webkit.org/show_bug.cgi?id=130014
3390 Reviewed by Martin Robinson.
3392 Include cmake or autotools config header.
3394 * MiniBrowser/gtk/BrowserDownloadsBar.c:
3395 * MiniBrowser/gtk/BrowserSearchBar.c:
3396 * MiniBrowser/gtk/BrowserWindow.c:
3397 * MiniBrowser/gtk/main.c:
3399 2014-03-12 Commit Queue <commit-queue@webkit.org>
3401 Unreviewed, rolling out r165471.
3402 https://bugs.webkit.org/show_bug.cgi?id=130139
3404 Didn't really fix the issue and broke another bot (Requested
3405 by mrobinson on #webkit).
3409 "[CMake] Newer versions of CMake cannot find older versions of
3411 https://bugs.webkit.org/show_bug.cgi?id=130107
3412 http://trac.webkit.org/changeset/165471
3414 2014-03-11 Filip Pizlo <fpizlo@apple.com>
3416 It should be possible to build WebKit with FTL on iOS
3417 https://bugs.webkit.org/show_bug.cgi?id=130116
3419 Reviewed by Dan Bernstein.
3421 * Scripts/build-webkit:
3422 * Scripts/copy-webkitlibraries-to-product-directory:
3424 2014-03-12 Brent Fulgham <bfulgham@apple.com>
3426 [Win] Remove use of QTSDK
3427 https://bugs.webkit.org/show_bug.cgi?id=130049
3429 Reviewed by Darin Adler.
3431 * DumpRenderTree/win/DumpRenderTree.cpp:
3432 (initialize): Remove QuickTime code.
3433 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3434 building QTMovieWin.
3436 2014-03-12 Martin Robinson <mrobinson@igalia.com>
3438 [GTK][CMAKE] Too verbose build output
3439 https://bugs.webkit.org/show_bug.cgi?id=130076
3441 Reviewed by Carlos Garcia Campos.
3443 Instead of building with cmake --build which isn't smart about pretty printing and
3444 colors, we build with a script which calls the proper build command.
3446 * Scripts/webkitdirs.pm:
3447 (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3448 the CMake configuration pass.
3450 2014-03-11 Martin Robinson <mrobinson@igalia.com>
3452 [CMake] Newer versions of CMake cannot find older versions of Freetype
3453 https://bugs.webkit.org/show_bug.cgi?id=130107
3455 Reviewed by Gustavo Noronha Silva.
3457 * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3458 to CMake during jhbuild initialization.
3460 2014-03-12 Zalan Bujtas <zalan@apple.com>
3462 Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3463 https://bugs.webkit.org/show_bug.cgi?id=129961
3465 Reviewed by Simon Fraser.
3467 Now scaled content can go through the window capturing mechanism too for compositing content.
3468 AppleMagnifiedMode is redundant.
3470 * DumpRenderTree/mac/DumpRenderTree.mm:
3471 (setDefaultsToConsistentValuesForTesting):
3473 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3474 (createBitmapContextFromWebView):
3475 * WebKitTestRunner/PlatformWebView.h:
3476 * WebKitTestRunner/cg/TestInvocationCG.cpp:
3477 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3478 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3479 (WTR::PlatformWebView::didInitializeClients):
3480 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3481 (WTR::PlatformWebView::forceWindowFramesChanged):
3482 * WebKitTestRunner/mac/main.mm:
3483 (setDefaultsToConsistentValuesForTesting):
3485 2014-03-12 Anton Obzhirov <a.obzhirov@samsung.com>
3487 Unreviewed. Add myself as a committer.
3489 * Scripts/webkitpy/common/config/contributors.json:
3491 2014-03-12 Ryuan Choi <ryuan.choi@samsung.com>
3493 Unreviewed build fix on the EFL port when used lower version of ATK
3495 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3496 (WTR::AccessibilityUIElement::y): Fixed typo.
3498 2014-03-11 Myles C. Maxfield <mmaxfield@apple.com>
3500 Some images are blank in the rebaseline server UI
3501 https://bugs.webkit.org/show_bug.cgi?id=130104
3503 Reviewed by Tim Horton.
3505 Let the server check for images in the 'retries' directory
3506 if it can't find an image otherwise.
3508 * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3509 (RebaselineHTTPRequestHandler.test_result):
3511 2014-03-11 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3513 [GTK][CMake] --update-gtk has no effect
3514 https://bugs.webkit.org/show_bug.cgi?id=130088
3516 Reviewed by Philippe Normand.
3518 * Scripts/webkitdirs.pm:
3519 (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3522 2014-03-10 Myles C. Maxfield <mmaxfield@apple.com>
3524 Add "System Font" to the list of whitelisted DRT fonts
3525 https://bugs.webkit.org/show_bug.cgi?id=130046
3527 Reviewed by Darin Adler.
3529 * DumpRenderTree/mac/DumpRenderTree.mm:
3530 (allowedFontFamilySet):
3531 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3533 2014-03-11 Martin Robinson <mrobinson@igalia.com>
3535 [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3536 https://bugs.webkit.org/show_bug.cgi?id=130064
3538 Reviewed by Philippe Normand.
3540 * efl/jhbuildrc: Remove duplicated code.
3541 * gtk/jhbuildrc: Remove duplicated code.
3542 * jhbuild/jhbuildrc_common.py:
3543 (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3544 GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3545 and is apparently necessary for GTK+.
3547 2014-03-11 László Langó <llango.u-szeged@partner.samsung.com>
3549 check-webkit-style failed to complain about missing braces
3550 https://bugs.webkit.org/show_bug.cgi?id=34189
3552 Reviewed by Ryosuke Niwa.
3554 * Scripts/webkitpy/style/checkers/cpp.py:
3556 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3557 (WebKitStyleTest.test_braces):
3559 2014-03-11 László Langó <llango.u-szeged@partner.samsung.com>
3561 Remove Qt cruft from style checker.
3562 https://bugs.webkit.org/show_bug.cgi?id=130085
3564 Reviewed by Csaba Osztrogonác.
3566 There is no 'foreach' keyword in c++. That was a Qt feature
3567 added in: http://trac.webkit.org/changeset/46113
3568 Qt was removed from WebKit, so we should remove the checks
3569 of this keyword from check-webkit-style scripts.
3571 * Scripts/webkitpy/style/checkers/cpp.py:
3572 (check_spacing_for_function_call):
3575 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3576 (CppStyleTest.test_mismatching_spaces_in_parens):
3577 (CppStyleTest.test_spacing_for_fncall):
3578 (WebKitStyleTest.test_braces):
3580 2014-03-11 Martin Hodovan <mhodovan@inf.u-szeged.hu>
3582 [GTK] update-webkitgtk-libs needs itstool
3583 https://bugs.webkit.org/show_bug.cgi?id=130082
3585 After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3586 itstool is a dependency of building gtk-doc from version 1.19, so it should
3587 be added to Tools/gtk/install-dependencies script, too.
3589 Reviewed by Philippe Normand.
3591 * gtk/install-dependencies:
3593 2014-03-11 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3595 webkitbot rollout ChangeLogs should be nicer
3596 https://bugs.webkit.org/show_bug.cgi?id=122654
3598 Reviewed by Csaba Osztrogonác.
3600 Added bug urls and descriptions of rolled out patches to the rollout changelog
3601 if they are present in the original changelog. Additionally removed the list of
3602 changed files and functions.
3604 * Scripts/webkitpy/common/checkout/changelog.py:
3605 (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3606 * Scripts/webkitpy/common/checkout/checkout.py:
3607 (Checkout._changelog_data_for_revision): Store bug description.
3608 * Scripts/webkitpy/common/checkout/checkout_mock.py:
3609 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3610 (CheckoutTest.test_commit_info_for_revision):
3611 * Scripts/webkitpy/common/checkout/commitinfo.py:
3612 (CommitInfo.bug_description): Added.
3613 (CommitInfo.to_json):
3614 * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3615 (CommitInfoTest.test_commit_info_creation):
3616 * Scripts/webkitpy/tool/commands/download.py:
3617 (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3618 out patches for creating rollout changelog.
3619 (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3620 caused the regression is stored in state["bug_blocked"] now.
3621 * Scripts/webkitpy/tool/commands/download_unittest.py:
3622 (test_prepare_rollout):
3623 (test_create_rollout_multiple_revision):
3624 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3625 (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3626 rolled out patches to the changelog.
3627 (PrepareChangeLogForRevert.run):
3628 * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3629 (UpdateChangeLogsForRevertTest):
3630 (test_message_for_revert):
3631 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3632 (ReopenBugAfterRollout.run):
3634 2014-03-11 Krzysztof Czech <k.czech@samsung.com>
3636 [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3637 https://bugs.webkit.org/show_bug.cgi?id=130021
3639 Reviewed by Mario Sanchez Prada.
3641 Replace deprecated functions to use new API from ATK 2.11.90.
3643 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3644 (AccessibilityUIElement::x):
3645 (AccessibilityUIElement::y):
3646 (AccessibilityUIElement::width):
3647 (AccessibilityUIElement::height):
3648 (AccessibilityUIElement::clickPointX):
3649 (AccessibilityUIElement::clickPointY):
3650 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3651 (WTR::AccessibilityUIElement::x):
3652 (WTR::AccessibilityUIElement::y):
3653 (WTR::AccessibilityUIElement::width):
3654 (WTR::AccessibilityUIElement::height):
3655 (WTR::AccessibilityUIElement::clickPointX):
3656 (WTR::AccessibilityUIElement::clickPointY):
3658 2014-03-11 Krzysztof Czech <k.czech@samsung.com>
3660 [ATK] Expose aria-posinset and aria-setsize through object attributes
3661 https://bugs.webkit.org/show_bug.cgi?id=130011
3663 Reviewed by Chris Fleizach.
3665 Added missing implementation of numberAttributeValue both to WKTR and DRT.
3667 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3668 (AccessibilityUIElement::numberAttributeValue):
3669 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3670 (WTR::AccessibilityUIElement::numberAttributeValue):
3672 2014-03-10 Brent Fulgham <bfulgham@apple.com>