Unreviewed, rolling out r148158.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Commit Queue  <rniwa@webkit.org>
2
3         Unreviewed, rolling out r148158.
4         http://trac.webkit.org/changeset/148158
5         https://bugs.webkit.org/show_bug.cgi?id=114405
6
7         We need to migrate status data (Requested by rniwa on
8         #webkit).
9
10         * Scripts/webkitpy/common/net/statusserver.py:
11         (StatusServer):
12
13 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
14
15         Mass remove all the empty directories
16
17         Rubberstamped by Ryosuke Niwa.
18
19         * BuildSlaveSupport/gtk/crashmon/log: Removed.
20         * BuildSlaveSupport/gtk/xvfb/log: Removed.
21         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
22         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
23         * MiniBrowser/gtk/WebBundle: Removed.
24         * MiniBrowser/win: Removed.
25         * QtTestPlatformPlugin/mac: Removed.
26         * Scripts/webkitpy/tool/bot/testdata: Removed.
27         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
28         * efl/ImageDiff: Removed.
29         * iExploder/htdocs: Removed.
30         * iExploder/iexploder-1.7.2/output: Removed.
31         * iExploder/tools: Removed.
32         * qmake/config.tests/libexecdir: Removed.
33         * qmake/config.tests/libjpeg: Removed.
34         * qmake/config.tests/libpng: Removed.
35
36 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
37
38         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
39         https://bugs.webkit.org/show_bug.cgi?id=114397
40
41         Reviewed by Benjamin Poulain.
42
43         * Scripts/webkitpy/common/net/statusserver.py:
44         (StatusServer):
45
46 2013-04-10  Adam Barth  <abarth@webkit.org>
47
48         Remove abarth from watchlists
49         https://bugs.webkit.org/show_bug.cgi?id=114390
50
51         Reviewed by Ryosuke Niwa.
52
53         I'm trying to cut down on the amount of bugmail I get so that I'll have
54         more of a chance to notice a piece of bugmail directed at me.
55
56         * Scripts/webkitpy/common/config/watchlist:
57
58 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
59
60         webkit-test-results.appspot.com loads the dashboard for Chromium by default
61         https://bugs.webkit.org/show_bug.cgi?id=114381
62
63         Reviewed by Benjamin Poulain.
64
65         Changed the defaults.
66
67         * TestResultServer/static-dashboards/builders.js:
68         * TestResultServer/static-dashboards/dashboard_base.js:
69         (currentBuilderGroupCategory):
70
71 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
72
73         Remove Chromium EWS bots from the queue status server
74         https://bugs.webkit.org/show_bug.cgi?id=113988
75
76         Reviewed by Benjamin Poulain.
77
78         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
79
80         * QueueStatusServer/app.yaml:
81         * QueueStatusServer/config/queues.py:
82         * QueueStatusServer/model/queues.py:
83         (Queue.short_name):
84         (Queue.display_name):
85         * QueueStatusServer/model/queues_unittest.py:
86         (QueueTest.test_short_name):
87         (QueueTest.test_display_name):
88         (QueueTest.test_name_with_underscores):
89         * QueueStatusServer/templates/activebots.html:
90
91 2013-04-10  Ojan Vafai  <ojan@chromium.org>
92
93         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
94         https://bugs.webkit.org/show_bug.cgi?id=114370
95
96         Reviewed by Ryosuke Niwa.
97
98         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
99         Unfortunately, there's no way to test this until this is committed and there is
100         a master restart.
101
102         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
108         * TestResultServer/generate_builders_json.py:
109         * TestResultServer/static-dashboards/dashboard_base.js:
110         * TestResultServer/static-dashboards/loader.js:
111
112 2013-04-10  Glenn Adams  <glenn@skynav.com>
113
114         [Qt] Fix regression to test-webkitpy.
115         https://bugs.webkit.org/show_bug.cgi?id=114368
116
117         Reviewed by Ryosuke Niwa.
118
119         * Scripts/webkitpy/layout_tests/port/factory.py:
120         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
121         (PortFactory.get): Remove obsolete chromium port related code.
122         * Scripts/webkitpy/layout_tests/port/mac.py:
123         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
124
125 2013-04-10  Anders Carlsson  <andersca@apple.com>
126
127         Remove unneeded headers from FrameLoader.h
128         https://bugs.webkit.org/show_bug.cgi?id=114223
129
130         Reviewed by Geoffrey Garen.
131
132         Add back headers implicitly included by other headers.
133
134         * WebKitTestRunner/WorkQueueManager.cpp:
135
136 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
137
138         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
139         https://bugs.webkit.org/show_bug.cgi?id=114365
140
141         Reviewed by Martin Robinson.
142
143         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
144         The patch addresses crashes in the tally_event_reply method. It is already committed into the
145         at-spi2-atk source tree and will be available with the next stable release, after which the
146         patch should be removed and the dependency version bumped.
147
148         * gtk/jhbuild.modules:
149         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
150
151 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
152
153         [WinCairo] Unreviewed build fix. Correct DropBox download link.
154
155         * Scripts/update-webkit-wincairo-libs: Revise download URL to
156         match change in DropBox server behavior.
157
158 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
159
160         Removed an annoying message from svn-create-patch
161         https://bugs.webkit.org/show_bug.cgi?id=114332
162
163         Reviewed by Alexey Proskuryakov.
164
165         I see this message basically every time I write a patch, so it must not
166         be true.
167
168         * Scripts/svn-create-patch:
169         (generateDiff):
170
171 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
172
173         [GTK] Add support for Page Visibility
174         https://bugs.webkit.org/show_bug.cgi?id=97324
175
176         Reviewed by Sam Weinig.
177
178         Implemented test runner API for page visibility layout tests.
179
180         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
181         (TestRunner::resetPageVisibility):
182         (TestRunner::setPageVisibility):
183         * Scripts/webkitperl/FeatureList.pm:
184
185 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
186
187         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
188         https://bugs.webkit.org/show_bug.cgi?id=114342
189
190         Reviewed by Gyuyoung Kim.
191
192         Commit 148033 only added an implementation for the Mac port, which made
193         other ports fail most tests since loading the injected bundle failed
194         with a missing symbol.
195
196         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
197         (WTR::AccessibilityUIElement::pathDescription):
198
199 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
200
201         [EFL] Add spell checking option to MiniBrowser
202         https://bugs.webkit.org/show_bug.cgi?id=114282
203
204         Reviewed by Ryosuke Niwa.
205
206         Spell checking is enabled by adding a flag (t/text-checking)
207         with launching MiniBrowser.
208
209         * MiniBrowser/efl/main.c:
210         (window_create):
211         (elm_main):
212
213 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
214
215         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
216         https://bugs.webkit.org/show_bug.cgi?id=113281
217
218         Reviewed by Darin Adler.
219
220         * Scripts/run-gtk-tests:
221         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
222
223 2013-04-09  Glenn Adams  <glenn@skynav.com>
224
225         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
226
227         Unreviewed.
228
229         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
230         (RunTest.test_build_check):
231
232 2013-04-09  Glenn Adams  <glenn@skynav.com>
233
234         [webkitpy] Remove chromium ports.
235         https://bugs.webkit.org/show_bug.cgi?id=114326
236
237         Reviewed by Dirk Pranke.
238
239         As a side effect, also:
240
241         - remove chromium builders from webkitpy.layout_tests.port.builders
242         - remove chromium builders from rebaseline
243         - rewrite chromium dependent tests in rebaseline_unittest
244         - remove chromium platform from garden-o-matic
245         - select apple platform as default platform in garden-o-matic
246         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
247
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
250         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
251         (BaselineOptimizerTest.test_move_baselines):
252         (BaselineOptimizerTest.test_efl):
253         (BaselineOptimizerTest.test_no_add_mac_future):
254         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
255         (BaselineOptimizerTest.test_common_directory_includes_root):
256         (BaselineOptimizerTest.test_complex_shadowing):
257         (BaselineOptimizerTest.test_virtual_ports_filtered):
258         * Scripts/webkitpy/layout_tests/port/builders.py:
259         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
260         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
261         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
262         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
263         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
264         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
265         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
266         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
267         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
268         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
269         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
270         * Scripts/webkitpy/layout_tests/port/factory.py:
271         (platform_options):
272         (PortFactory):
273         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
274         (FactoryTest.test_qt):
275         (FactoryTest.test_get_from_builder_name):
276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
277         (RunTest.test_build_check):
278         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
279         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
280         * Scripts/webkitpy/tool/commands/rebaseline.py:
281         (Rebaseline._builders_to_pull_from):
282         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
283         (_BaseTestCase):
284         (_BaseTestCase.setUp):
285         (TestRebaselineTest.setUp):
286         (TestRebaselineTest.test_baseline_directory):
287         (test_rebaseline_updates_expectations_file):
288         (test_rebaseline_does_not_include_overrides):
289         (test_rebaseline_test):
290         (test_rebaseline_test_and_print_scm_changes):
291         (test_rebaseline_and_copy_test):
292         (test_rebaseline_and_copy_test_no_existing_result):
293         (test_rebaseline_and_copy_test_with_lion_result):
294         (test_rebaseline_and_copy_no_overwrite_test):
295         (TestRebaselineExpectations.test_rebaseline_expectations):
296
297 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
298
299         newcommitbot (WKR) requires a subversion checkout
300         https://bugs.webkit.org/show_bug.cgi?id=114309
301
302         Reviewed by Benjamin Poulain.
303
304         Directly talk to the subversion server instead of relying on a local checkout.
305         This allows us to run WKR off of a git clone.
306
307         * Scripts/webkitpy/tool/commands/newcommitbot.py:
308         (NewCommitBot.next_work_item):
309         (NewCommitBot.process_work_item):
310
311 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
312
313         webkitbot refers to sheriffbot in help
314         https://bugs.webkit.org/show_bug.cgi?id=114307
315
316         Reviewed by Benjamin Poulain.
317
318         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
319
320         * Scripts/webkitpy/tool/bot/irc_command.py:
321         (Help):
322         (Help.execute):
323         (RollChromiumDEPS.execute):
324         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
325         (IRCBotTest.test_help):
326         * Scripts/webkitpy/tool/bot/sheriff.py:
327         (Sheriff.name):
328
329 2013-04-06  Roger Fong  <roger_fong@apple.com>
330
331         Kill old processes between runs on WinEWS bots.
332         Temporarily disable tests to let bots catch up again.
333
334         * EWSTools/start-queue-win.sh:
335         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
336         (WinEWS):
337
338 2013-04-09  Glenn Adams  <glenn@skynav.com>
339
340         [webkitpy] Remove chromium deprecated port support.
341         https://bugs.webkit.org/show_bug.cgi?id=114228
342
343         Reviewed by Ryosuke Niwa.
344
345         * Scripts/webkitpy/common/config/ports.py:
346         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
347         (ChromiumPort): Removed.
348         (ChromiumAndroidPort): Removed.
349         (ChromiumXVFBPort): Removed.
350         * Scripts/webkitpy/common/config/ports_unittest.py:
351         (DeprecatedPortTest.test_chromium_port): Removed.
352         (DeprecatedPortTest.test_chromium_android_port): Removed.
353         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
354         * Scripts/webkitpy/tool/steps/update_unittest.py:
355         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
356         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
357
358 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
359
360         AX: The bounding paths should be made available through accessibility
361         https://bugs.webkit.org/show_bug.cgi?id=113817
362
363         Reviewed by David Kilzer.
364
365         Add a pathDescription property for testing so that it's possible
366         to verify that a path is being returned correctly.
367
368         * DumpRenderTree/AccessibilityUIElement.cpp:
369         (getPathDescriptionCallback):
370         (AccessibilityUIElement::pathDescription):
371         (AccessibilityUIElement::getJSClass):
372         * DumpRenderTree/AccessibilityUIElement.h:
373         (AccessibilityUIElement):
374         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
375         (_CGPathEnumerationIteration):
376         (AccessibilityUIElement::pathDescription):
377         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
378         (AccessibilityUIElement::pathDescription):
379         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
380         (WTR::AccessibilityUIElement::pathDescription):
381         (WTR):
382         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
383         (AccessibilityUIElement):
384         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
385         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
386         (WTR::AccessibilityUIElement::pathDescription):
387         (WTR):
388
389 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
390
391         [EFL] Declare TEST_THEME_DIR in a single place.
392         https://bugs.webkit.org/show_bug.cgi?id=114285
393
394         Reviewed by Anders Carlsson.
395
396         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
397
398         * DumpRenderTree/efl/CMakeLists.txt:
399         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
400         (DumpRenderTreeChrome::createView):
401         (DumpRenderTreeChrome::createInspectorView):
402         (DumpRenderTreeChrome::initialize):
403         (DumpRenderTreeChrome::onDownloadRequest):
404         * EWebLauncher/CMakeLists.txt:
405         * EWebLauncher/main.c:
406         (findThemePath):
407         * EWebLauncher/url_bar.c:
408         (url_bar_add):
409         * MiniBrowser/efl/CMakeLists.txt:
410         * MiniBrowser/efl/main.c:
411         (window_create):
412         * TestWebKitAPI/PlatformEfl.cmake:
413         * TestWebKitAPI/efl/PlatformWebView.cpp:
414         (TestWebKitAPI::PlatformWebView::PlatformWebView):
415         * WebKitTestRunner/PlatformEfl.cmake:
416         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
417         (WTR::PlatformWebView::PlatformWebView):
418
419 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
420
421         [GTK][AC] upversion of clutter and its dependecy
422         https://bugs.webkit.org/show_bug.cgi?id=114016
423
424         Reviewed by Gustavo Noronha Silva.
425
426         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
427
428         * gtk/jhbuild-optional.modules:
429
430 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
431
432         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
433         https://bugs.webkit.org/show_bug.cgi?id=89875
434
435         Reviewed by Maciej Stachowiak.
436
437         Add unit tests to verify if the handling of the open, openat, creat syscall
438         is being done right. We check if the Read/Write/ReadAndWrite permissions
439         are respected, if the canonical path is being resolved and if
440         the permissions are falling back to the topmost parent directory with a
441         policy set when the directory being opened has no policy.
442
443         We also test if any attempt of blocking SIGSYS is silently ignored.
444         SIGSYS cannot be blocked because in it's handler is where we hook
445         syscalls to the broker process.
446
447         Also added libseccomp to EFL's jhbuild to make the life of developers
448         willing to help easier.
449
450         * Scripts/webkitperl/FeatureList.pm:
451         * TestWebKitAPI/PlatformEfl.cmake:
452         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
453         (TestWebKitAPI):
454         (SeccompEnvironment):
455         (TestWebKitAPI::SeccompEnvironment::SetUp):
456         (TestWebKitAPI::SeccompEnvironment::TearDown):
457         (TestWebKitAPI::dummyHandler):
458         (TestWebKitAPI::TEST):
459         (TestWebKitAPI::stressTest):
460         * efl/jhbuild.modules:
461         * qmake/mkspecs/features/features.pri:
462
463 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
464
465         REGRESSION: Autocorrection doesn't work in DumpRenderTree
466         https://bugs.webkit.org/show_bug.cgi?id=113846
467
468         Reviewed by Alexey Proskuryakov.
469
470         The problem was that we were replacing NSSpellCheck's dictionary with our own
471         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
472
473         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
474         and "would" respectively in DumpRenderTree.
475
476         * DumpRenderTree/mac/DumpRenderTree.mm:
477         (resetDefaultsToConsistentValues):
478
479 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
480
481         Remove the gyp files for Tools
482         https://bugs.webkit.org/show_bug.cgi?id=114248
483
484         Reviewed by Ryosuke Niwa.
485
486         * DumpRenderTree/DumpRenderTree.gyp: Removed.
487         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
488         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
489         * DumpRenderTree/DumpRenderTree.gypi: Removed.
490         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
491         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
492         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
493         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
494
495 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
496
497         WKR (new-commit-bot) is too slow
498         https://bugs.webkit.org/show_bug.cgi?id=110087
499
500         Reviewed by Geoffrey Garen.
501
502         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
503         Just run "svn log -r <revision>" instead to cut down the delay.
504
505         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
506
507         * Scripts/webkitpy/tool/commands/newcommitbot.py:
508         (NewCommitBot):
509         (NewCommitBot.next_work_item):
510         (NewCommitBot._is_empty_log):
511         (NewCommitBot._update_checkout):
512
513 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
514
515         Build fix. Can't remove appendCustomBuildFlags.
516
517         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
518         (appendCustomBuildFlags):
519
520 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
521
522         Remove Chromium builders from build.webkit.org
523         https://bugs.webkit.org/show_bug.cgi?id=113990
524
525         Reviewed by Benjamin Poulain.
526
527         Removed.
528
529         * BuildSlaveSupport/build.webkit.org-config/config.json:
530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
531         (InstallGtkDependencies):
532         (RunUnitTests.start):
533         (RunWebKit2Tests.start):
534         (Factory.__init__):
535         (unitTestsSupported):
536         (TestFactory.__init__):
537         (BuildAndTestFactory.__init__):
538         (BuildAndPerfTestFactory.__init__):
539         (BuildAndPerfTestWebKit2Factory.__init__):
540         (DownloadAndPerfTestFactory.__init__):
541         (loadBuilderConfig):
542         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
543
544 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
545
546         Remove HTML Notification
547         https://bugs.webkit.org/show_bug.cgi?id=114231
548
549         Reviewed by Ryosuke Niwa.
550
551         * qmake/mkspecs/features/features.pri:
552
553 2013-04-08  Glenn Adams  <glenn@skynav.com>
554
555         Remove chromium EWS support, and fix broken test.
556         https://bugs.webkit.org/show_bug.cgi?id=114221
557
558         Reviewed by Ryosuke Niwa.
559
560         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
561         (AbstractChromiumEWS): Removed.
562         (ChromiumLinuxEWS): Removed.
563         (ChromiumLinuxDebugEWS): Removed.
564         (ChromiumWindowsEWS): Removed.
565         (ChromiumAndroidEWS): Removed.
566         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
567         (EarlyWarningSystemTest): Fix misspelled class name.
568         (test_ewses): Fix entry point name to ensure test is run.
569
570 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
571
572         [WIN] Remove WebKit2 source code
573         https://bugs.webkit.org/show_bug.cgi?id=114096
574
575         Reviewed by Anders Carlsson.
576
577         Remove the windows specific parts of the MiniBrowser.
578
579         * MiniBrowser/MiniBrowser.vcproj: Removed.
580         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
581         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
582         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
583         * MiniBrowser/win/BrowserView.cpp: Removed.
584         * MiniBrowser/win/BrowserView.h: Removed.
585         * MiniBrowser/win/BrowserWindow.cpp: Removed.
586         * MiniBrowser/win/BrowserWindow.h: Removed.
587         * MiniBrowser/win/MiniBrowser.cpp: Removed.
588         * MiniBrowser/win/MiniBrowser.h: Removed.
589         * MiniBrowser/win/MiniBrowser.rc: Removed.
590         * MiniBrowser/win/main.cpp: Removed.
591         * MiniBrowser/win/resource.h: Removed.
592         * MiniBrowser/win/stdafx.cpp: Removed.
593         * MiniBrowser/win/stdafx.h: Removed.
594
595 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
596
597         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
598
599         * Scripts/webkitpy/common/config/irc.py:
600
601 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
602
603         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
604         https://bugs.webkit.org/show_bug.cgi?id=113139
605
606         Reviewed by Anders Carlsson.
607
608         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
609         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
610         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
611         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
612         (ToStringAndValueOfObject):
613         (ToStringAndValueOfObject::ToStringAndValueOfObject):
614         (ScriptableObject):
615         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
616         (ToStringAndValueOfObject::ScriptableObject::invoke):
617         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
618         (ToStringAndValueOfObject::NPP_GetValue):
619         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
620         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
621         * GNUmakefile.am:
622
623 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
624
625         [GTK] Bump gnome-themes-standard to 3.6.0
626         https://bugs.webkit.org/show_bug.cgi?id=114155
627
628         Reviewed by Martin Robinson.
629
630         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
631         dependency of gnome-themes-standard accordingly.
632
633 2013-04-08  David Levin  <levin@chromium.org>
634
635         Remove my watchlist entries.
636         https://bugs.webkit.org/show_bug.cgi?id=114180
637
638         Reviewed by Adam Barth.
639
640         * Scripts/webkitpy/common/config/committers.py:
641         * Scripts/webkitpy/common/config/watchlist:
642
643 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
644
645         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
646         https://bugs.webkit.org/show_bug.cgi?id=114161
647
648         Reviewed by Gyuyoung Kim.
649
650         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
651         as it is crashing due to Bug 111074.
652
653         * TestWebKitAPI/PlatformEfl.cmake:
654
655 2013-04-07  David Kilzer  <ddkilzer@apple.com>
656
657         Remove the rest of SVG_DOM_OBJC_BINDINGS
658         <http://webkit.org/b/114112>
659
660         Reviewed by Geoffrey Garen.
661
662         * Scripts/webkitperl/FeatureList.pm:
663         - Remove --svg-dom-objc-bindings switch.
664         * qmake/mkspecs/features/features.pri:
665         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
666
667 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
668
669         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
670         https://bugs.webkit.org/show_bug.cgi?id=114089
671
672         Reviewed by Chris Fleizach.
673
674         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
675         * DumpRenderTree/AccessibilityController.cpp:
676         * DumpRenderTree/AccessibilityUIElement.cpp:
677         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
678         (DumpRenderTreeChrome::DumpRenderTreeChrome):
679         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
680         (DumpRenderTreeChrome):
681
682 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
683
684         Build fix after r147857, remove remaining USE(JSC) guards.
685
686         Unreviewed.
687
688         * DumpRenderTree/config.h:
689         * TestWebKitAPI/config.h:
690         * WebKitTestRunner/config.h:
691
692 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
693
694         Rename sheriffbot to webkitbot
695         https://bugs.webkit.org/show_bug.cgi?id=114109
696
697         Reviewed by Benjamin Poulain.
698
699         Renamed since sheriffbot will be used in Blink.
700
701         * Scripts/webkitpy/tool/commands/sheriffbot.py:
702         (SheriffBot):
703         (SheriffBot.begin_work_queue):
704
705 2013-04-06  Oliver Hunt  <oliver@apple.com>
706
707         Unify the many and varied stack trace mechanisms, and make the result sane.
708         https://bugs.webkit.org/show_bug.cgi?id=114072
709
710         Reviewed by Filip Pizlo.
711
712         The commandline jsc executable no longer requires arguments, so
713         I've made run-jsc work without them.
714
715         * Scripts/run-jsc:
716
717 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
718
719         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
720         https://bugs.webkit.org/show_bug.cgi?id=114086
721
722         Reviewed by Tim Horton.
723
724         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
725
726 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
727
728         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
729         https://bugs.webkit.org/show_bug.cgi?id=114083
730
731         Reviewed by Ryosuke Niwa.
732
733         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
734         in TestWebKitAPI and WebKitTestRunner.
735
736         * TestWebKitAPI/config.h:
737         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
738         (TestWebKitAPI::InjectedBundleController::platformInitialize):
739         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
740         (WTR::InjectedBundle::platformInitialize):
741
742 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
743
744         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
745         https://bugs.webkit.org/show_bug.cgi?id=114094
746
747         Reviewed by Anders Carlsson.
748
749         * Scripts/run-jsc:
750
751 2013-04-05  Ojan Vafai  <ojan@chromium.org>
752
753         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
754         https://bugs.webkit.org/show_bug.cgi?id=114080
755
756         Reviewed by Ryosuke Niwa.
757
758         This way, the WebKit and Blink dashboard code can change as appropriate without
759         needing to consider the other project's needs. This still doesn't update the
760         buildbots to upload to the new location, or the dashboard code to pull the
761         results.json files from the new location, but it at least allows for changing the
762         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
763
764         * TestResultServer/app.yaml:
765
766 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
767
768         Re-enable testing on the commit queue
769         https://bugs.webkit.org/show_bug.cgi?id=114078
770
771         Reviewed by Darin Adler.
772
773         Re-enabled the feature and the associated tests.
774
775         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
776         (CommitQueueTask.run):
777         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
778         (CommitQueueTaskTest._run_through_task):
779         * Scripts/webkitpy/tool/commands/queues_unittest.py:
780         (CommitQueueTest._mock_test_result):
781
782 2013-04-05  Oliver Hunt  <oliver@apple.com>
783
784         Unify the many and varied stack trace mechanisms, and make the result sane.
785         https://bugs.webkit.org/show_bug.cgi?id=114072
786
787         Reviewed by Filip Pizlo.
788
789         The commandline jsc executable no longer requires arguments, so
790         I've made run-jsc work without them.
791
792         * Scripts/run-jsc:
793
794 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
795
796         AX: Make SVG Group containers accessible elements
797         https://bugs.webkit.org/show_bug.cgi?id=113939
798
799         Reviewed by Simon Fraser.
800
801         Implement axController.elementAtPoint for iOS.
802         Implement a correct version of clickPoint for iOS.
803
804         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
805         (AccessibilityController::elementAtPoint):
806         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
807         (AccessibilityUIElement::clickPointX):
808         (AccessibilityUIElement::clickPointY):
809
810 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
811
812         Unreviewed, rolling out r147773 and r147774.
813         http://trac.webkit.org/changeset/147773
814         http://trac.webkit.org/changeset/147774
815         https://bugs.webkit.org/show_bug.cgi?id=114056
816
817         Causing some exceptions on AppEngine I don't understand
818         (Requested by rniwa on #webkit).
819
820         * QueueStatusServer/config/queues.py:
821         * QueueStatusServer/model/queues.py:
822         (Queue.short_name):
823         (Queue.display_name):
824         * QueueStatusServer/model/queues_unittest.py:
825         (QueueTest.test_short_name):
826         (QueueTest.test_display_name):
827         (QueueTest.test_name_with_underscores):
828
829 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
830
831         Fixed run-bindings-tests by removing V8
832         https://bugs.webkit.org/show_bug.cgi?id=114053
833
834         Reviewed by Benjamin Poulain.
835
836         * Scripts/run-bindings-tests:
837         (main):
838
839 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
840
841         Build fix.
842
843         * QueueStatusServer/model/queues.py:
844         (Queue.short_name):
845         (Queue.display_name):
846
847 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
848
849         Remove Chromium EWS bots from the queue status server
850         https://bugs.webkit.org/show_bug.cgi?id=113988
851
852         Reviewed by Benjamin Poulain.
853
854         Removed Chromium EWS bots.
855
856         * QueueStatusServer/config/queues.py:
857         * QueueStatusServer/model/queues.py:
858         (Queue.short_name):
859         (Queue.display_name):
860         * QueueStatusServer/model/queues_unittest.py:
861         (QueueTest.test_short_name):
862         (QueueTest.test_display_name):
863         (QueueTest.test_name_with_underscores):
864
865 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
866
867         [EFL] Enable indexed database
868         https://bugs.webkit.org/show_bug.cgi?id=107248
869
870         Reviewed by Alexis Menard.
871
872         * Scripts/webkitperl/FeatureList.pm:
873
874 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
875
876         Remove vestiges of Chromium bits from watchlists.
877         https://bugs.webkit.org/show_bug.cgi?id=114047
878
879         Reviewed by Ryosuke Niwa.
880
881         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
882
883 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
884
885         Add James Craig to the contributors list.
886
887         * Scripts/webkitpy/common/config/committers.py:
888
889 2013-04-04  Kent Tamura  <tkent@chromium.org>
890
891         Remove ChromiumPublicApi pattern, and cc/message rules for it.
892
893         * Scripts/webkitpy/common/config/watchlist:
894
895 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
896
897         Temporarily disable the Python unittests broken by the commit queue not running layout tests
898         https://bugs.webkit.org/show_bug.cgi?id=113997
899
900         Reviewed by Ryosuke Niwa.
901
902         Disable the tests until Ryosuke gets the time and hardware to have
903         a testing commit-queue.
904
905         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
906         (CommitQueueTaskTest):
907         * Scripts/webkitpy/tool/commands/queues_unittest.py:
908         (CommitQueueTest):
909
910 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
911
912         Remove Chromium builders from build.webkit.org
913         https://bugs.webkit.org/show_bug.cgi?id=113990
914
915         Reviewed by Benjamin Poulain.
916
917         Land the part to disable triggering of Chromium builders first so that we may start
918         deleting more Chromium code that breaks the update step.
919
920         * BuildSlaveSupport/build.webkit.org-config/config.json:
921
922 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
923
924         Remove Chromium's DumpRenderTree
925         https://bugs.webkit.org/show_bug.cgi?id=113989
926
927         Reviewed by Kent Tamura.
928
929         On second thought, let's not go to Camelot. It is a silly place.
930
931         * DumpRenderTree/mac/DumpRenderTree.mm:
932         (resetDefaultsToConsistentValues):
933
934 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
935
936         Nixed the defunct chromium folder from DumpRenderTree
937         https://bugs.webkit.org/show_bug.cgi?id=113993
938
939         Reviewed by Ryosuke Niwa.
940
941         * DumpRenderTree/chromium: Removed.
942         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
943         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
944         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
945         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
946         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
947         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
948         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
949         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
950         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
951         * DumpRenderTree/chromium/MockPlatform.h: Removed.
952         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
953         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
954         * DumpRenderTree/chromium/Task.cpp: Removed.
955         * DumpRenderTree/chromium/Task.h: Removed.
956         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
957         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
958         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
959         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
960         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
961         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
962         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
963         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
964         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
965         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
966         * DumpRenderTree/chromium/TestRunner: Removed.
967         * DumpRenderTree/chromium/TestRunner/public: Removed.
968         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
969         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
970         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
971         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
972         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
973         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
974         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
975         * DumpRenderTree/chromium/TestRunner/src: Removed.
976         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
977         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
978         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
979         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
980         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
981         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
982         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
983         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
984         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
985         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
986         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
987         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
988         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
989         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
990         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
991         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
992         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
993         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
994         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
995         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
996         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
997         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
998         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
999         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1000         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1001         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1002         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1003         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1004         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1005         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1006         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1007         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1008         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1009         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1010         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1011         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1012         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1013         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1014         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1015         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1016         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1017         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1018         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1019         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1020         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1021         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1022         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1023         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1024         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1025         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1026         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1027         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1028         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1029         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1030         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1031         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1032         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1033         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1034         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1035         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1036         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1037         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1038         * DumpRenderTree/chromium/TestShell.h: Removed.
1039         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1040         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1041         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1042         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1043         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1044         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1045         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1046         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1047         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1048         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1049         * DumpRenderTree/chromium/config.h: Removed.
1050         * DumpRenderTree/chromium/fonts.conf: Removed.
1051
1052 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1053
1054         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1055
1056         Rubber stamped by Benjamin Poulain.
1057
1058         * RebaselineQueueServer: Removed.
1059         * RebaselineQueueServer/app.yaml: Removed.
1060         * RebaselineQueueServer/handlers: Removed.
1061         * RebaselineQueueServer/handlers/__init__.py: Removed.
1062         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1063         * RebaselineQueueServer/handlers/pages.py: Removed.
1064         * RebaselineQueueServer/index.yaml: Removed.
1065         * RebaselineQueueServer/main.py: Removed.
1066         * RebaselineQueueServer/model: Removed.
1067         * RebaselineQueueServer/model/__init__.py: Removed.
1068         * RebaselineQueueServer/model/queueentry.py: Removed.
1069         * RebaselineQueueServer/static: Removed.
1070         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1071         * RebaselineQueueServer/static/styles.css: Removed.
1072         * RebaselineQueueServer/templates: Removed.
1073         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1074         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1075         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1076         * RebaselineQueueServer/templates/home.html: Removed.
1077
1078 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1079
1080         Fix setup-commit-queue and temporarily disable testing on commit-queue
1081         https://bugs.webkit.org/show_bug.cgi?id=113979
1082
1083         Reviewed by Benjamin Poulain.
1084
1085         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1086         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1087
1088         * EWSTools/setup-commit-queue.sh:
1089         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1090         (CommitQueueTask.run):
1091
1092 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1093
1094         temporarily make flakiness dashboard work again webkit.org bots
1095         https://bugs.webkit.org/show_bug.cgi?id=113972
1096
1097         Reviewed by Ojan Vafai.
1098
1099         This patch disables the chromium.org layout test bots TestExpectations
1100         parsing temporarily until we can work out the right way to split into
1101         two instances for webkit.org and chromium.org and figure out which
1102         code to delete where :).
1103
1104         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1105
1106 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1107
1108         Fix webkitpy tests after r147678.
1109
1110         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1111         (CommitQueueTest.test_commit_queue):
1112         (test_manual_reject_during_processing):
1113
1114 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1115
1116         The commit queue should use Mac MountainLion port
1117         https://bugs.webkit.org/show_bug.cgi?id=113971
1118
1119         Reviewed by Lucas Forschler.
1120
1121         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1122         * Scripts/webkitpy/tool/commands/queues.py:
1123         (CommitQueue):
1124
1125 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1126
1127         turn off running tests on chromium linux EWS bots
1128         https://bugs.webkit.org/show_bug.cgi?id=113959
1129
1130         Reviewed by Geoffrey Garen.
1131
1132         Now that the Chromium port is no longer being maintained
1133         there's little point in running the tests. Soon we should
1134         just shut this bot off altogether.
1135
1136         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1137         (ChromiumLinuxEWS):
1138
1139 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1140
1141         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1142
1143         * Scripts/webkitpy/common/config/watchlist:
1144
1145 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1146
1147         Indentation fix to get webkit-patch working again after r147625
1148
1149         Unreviewed.
1150
1151         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1152         (MacEWS):
1153         (MacWK2EWS):
1154
1155 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1156
1157         Turn tests back on for Mac WK1/WK2 EWS.
1158         
1159         Unreviewed.
1160         
1161         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1162         (MacEWS):
1163         (MacWK2EWS):
1164
1165 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1166
1167         [GTK][WK2] MiniBrowser custom URI scheme support
1168         https://bugs.webkit.org/show_bug.cgi?id=112419
1169
1170         Reviewed by Carlos Garcia Campos.
1171
1172         Add support for about URIs in MiniBrowser. An example about page is show
1173         with URI "about:minibrowser", the rest of the cases it will show a
1174         proper message explaining that the about page didn't exist.
1175
1176         Internally it uses "minibrowser-about" prefix instead of "about", but
1177         from the user point of view it works with "about" prefix.
1178
1179         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1180         (getInternalURI): Method to convert URIs from "about" prefix to
1181         "minibrowser-about".
1182         (getExternalURI): Opposite method.
1183         (webViewURIChanged): Use "about" prefix to show the URI to users.
1184         (webViewEnterFullScreen): Ditto.
1185         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1186         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1187         (aboutURISchemeRequestCallback): Callback to manage about calls.
1188         (main): Register the URI scheme to manage about URIs.
1189
1190 2013-04-03  Roger Fong  <roger_fong@apple.com>
1191
1192         Re-enable WinEWS tests.
1193
1194         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1195         (WinEWS):
1196
1197 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1198
1199         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1200         https://bugs.webkit.org/show_bug.cgi?id=113883
1201
1202         Reviewed by Martin Robinson.
1203
1204         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1205         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1206         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1207
1208 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1209
1210         [GTK] Include Pango in jhbuild-optional.modules
1211         https://bugs.webkit.org/show_bug.cgi?id=113878
1212
1213         Reviewed by Martin Robinson.
1214
1215         Since r147547 Pango 1.32.0 is required. Including the module in the
1216         JHBuild optional moduleset.
1217
1218         * gtk/jhbuild-optional.modules: Add Pango module.
1219
1220 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1221
1222         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1223         https://bugs.webkit.org/show_bug.cgi?id=113864
1224
1225         Moving setDefersLoading from TestRunnerQt to TestRunner
1226         requires access to the non-Qt TestRunner.
1227         As long as we instantiate both TestRunner and TestRunnerQt,
1228         we need a separate getter for the non-Qt TestRunner instance.
1229
1230         Reviewed by Simon Hausmann.
1231
1232         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1233         (WebPage::resetSettings):
1234         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1235         (DumpRenderTree::jscTestRunner):
1236         * DumpRenderTree/qt/TestRunnerQt.cpp:
1237         (TestRunner::setDefersLoading):
1238             Moving setDefersLoading from TestRunnerQt
1239             to TestRunner.
1240         * DumpRenderTree/qt/TestRunnerQt.h:
1241         (TestRunnerQt):
1242
1243 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1244
1245         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1246         https://bugs.webkit.org/show_bug.cgi?id=104779
1247
1248         Reviewed by Carlos Garcia Campos.
1249
1250         * Scripts/run-gtk-tests:
1251         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1252         passing in current trunk.
1253
1254 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1255
1256         Fix HAVE(QTTESTSUPPORT) logic
1257
1258         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1259         resulting in HAVE(QTTESTSUPPORT) never being true.
1260         Move that logic down in sanitizeFeatures.
1261
1262         Rubber-stamped by Tor Arne Vestbø.
1263
1264         * qmake/mkspecs/features/features.prf:
1265
1266 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1267
1268         [GTK] Bump required versions of some dependencies
1269         https://bugs.webkit.org/show_bug.cgi?id=113282
1270
1271         Reviewed by Martin Robinson.
1272
1273         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1274
1275 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1276
1277         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1278         https://bugs.webkit.org/show_bug.cgi?id=113809
1279
1280         Reviewed by Philippe Normand.
1281
1282         Newer Linux kernels have removed some deprecated macros from v4l2
1283         headers, causing gst-plugins-good's build to break. We don't need it
1284         right now, so just disable it.
1285
1286         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1287
1288 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1289
1290         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1291         https://bugs.webkit.org/show_bug.cgi?id=113535
1292
1293         Reviewed by Simon Hausmann.
1294
1295         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1296
1297         * qmake/mkspecs/features/features.prf:
1298
1299 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1300
1301         [Qt] Move logic of simple forwarding functions to TestRunner.
1302         https://bugs.webkit.org/show_bug.cgi?id=113863
1303
1304         Reviewed by Simon Hausmann.
1305
1306         * DumpRenderTree/qt/TestRunnerQt.cpp:
1307         (TestRunner::setTextDirection):
1308         (TestRunner::goBack):
1309         (TestRunner::evaluateScriptInIsolatedWorld):
1310         (TestRunner::addUserStyleSheet):
1311         * DumpRenderTree/qt/TestRunnerQt.h:
1312         (TestRunnerQt):
1313
1314 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1315
1316         [Qt] Disable media support using QuickTime if deployment target != SDK
1317
1318         We link to a single libWebKitSystemInterface static lib, so unless the
1319         deployment target matches the SDK let's not pretend like we'll be able
1320         to run on anything lower than the SDK version.
1321
1322         Reviewed by Simon Hausmann.
1323
1324         * qmake/mkspecs/features/features.prf:
1325
1326 2013-04-02  James Craig  <james@cookiecrook.com>
1327
1328         AXRoleDescripton for DL is "list"; should be "description list"
1329         https://bugs.webkit.org/show_bug.cgi?id=111665
1330
1331         Reviewed by Chris Fleizach.
1332
1333         Defining the role and description strings.
1334
1335         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1336
1337 2013-04-02  Roger Fong  <roger_fong@apple.com>
1338
1339         Unreviewed. Disable running tests on Win EWS queue.
1340
1341         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1342         (WinEWS):
1343
1344 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1345
1346         Disable running tests on the MAC WK2 EWS queue.
1347         
1348         Unreviewed.
1349         
1350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1351         (MacWK2EWS):
1352
1353 2013-04-02  Julie Parent  <jparent@chromium.org>
1354
1355         Dashboard refactor: Move dashboard specific history related features to History.
1356         https://bugs.webkit.org/show_bug.cgi?id=113717
1357
1358         Reviewed by Ojan Vafai.
1359         
1360         Each dashboard now creates its own History object, with a custom
1361         configuration. This changes from just overriding global functions
1362         to passing in callbacks for generatePage, handleValidHashParameter,
1363         and handleQueryParameterChange. Same with passing in defaultStateValues
1364         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1365         variables.
1366         
1367         All functions related to these features are now (mostly) private
1368         function on History. 
1369         
1370         Loader no longer needs a loadingComplete callback, since it can just
1371         initialize the history object itself.
1372
1373         * TestResultServer/static-dashboards/aggregate_results.js:
1374         (handleValidHashParameter):
1375         * TestResultServer/static-dashboards/dashboard_base.js:
1376         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1377         (generatePage):
1378         (.switch.return):
1379         (handleQueryParameterChange):
1380         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1381         (resetGlobals):
1382         * TestResultServer/static-dashboards/history.js:
1383         (.):
1384         * TestResultServer/static-dashboards/loader.js:
1385         (.):
1386         * TestResultServer/static-dashboards/loader_unittests.js:
1387         * TestResultServer/static-dashboards/timeline_explorer.js:
1388         (generatePage):
1389         (initCurrentBuilderTestResults):
1390         * TestResultServer/static-dashboards/treemap.js:
1391         (generatePage):
1392         (.switch.return):
1393         (handleQueryParameterChange):
1394
1395 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1396
1397         Unreviewed, rolling out r147401.
1398         http://trac.webkit.org/changeset/147401
1399         https://bugs.webkit.org/show_bug.cgi?id=113767
1400
1401         The patch makes it extremely hard to set up the dependencies
1402         properly on the GTK builders (Requested by zdobersek on
1403         #webkit).
1404
1405         * gtk/jhbuild.modules:
1406
1407 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1408
1409         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1410         https://bugs.webkit.org/show_bug.cgi?id=113382
1411
1412         Reviewed by Gyuyoung Kim.
1413
1414         Do not show the empty tooltip box if the text is null.
1415
1416         * MiniBrowser/efl/main.c:
1417         (popup_menu_populate):
1418
1419 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1420
1421         [GTK] Bump required versions of some dependencies
1422         https://bugs.webkit.org/show_bug.cgi?id=113282
1423
1424         Reviewed by Martin Robinson.
1425
1426         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1427
1428 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1429
1430         Unreviewed, rolling out r147319.
1431         http://trac.webkit.org/changeset/147319
1432         https://bugs.webkit.org/show_bug.cgi?id=113707
1433
1434         The unit test is still failing on the buildbot (Requested by
1435         zdobersek on #webkit).
1436
1437         * Scripts/run-gtk-tests:
1438         (TestRunner):
1439
1440 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1441
1442         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1443         https://bugs.webkit.org/show_bug.cgi?id=104779
1444
1445         Reviewed by Carlos Garcia Campos.
1446
1447         * Scripts/run-gtk-tests:
1448         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1449         passing in current trunk.
1450
1451 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1452
1453         Unreviewed, rolling out r147289.
1454         http://trac.webkit.org/changeset/147289
1455         https://bugs.webkit.org/show_bug.cgi?id=113678
1456
1457         broke Win7 (dbg) build (Requested by shinyak|gardener on
1458         #webkit).
1459
1460         * DumpRenderTree/DumpRenderTree.gypi:
1461         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1462         (WebTestRunner):
1463         (WebUserMediaClientMock):
1464         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1465         (WebTestRunner::WebUserMediaClientMock::taskList):
1466         * Scripts/webkitpy/style/checkers/cpp.py:
1467         (check_function_definition):
1468
1469 2013-03-31  Adam Barth  <abarth@webkit.org>
1470
1471         configure-svn-config.sh fails
1472         https://codereview.chromium.org/13392007/
1473
1474         Reviewed by Eric Seidel.
1475
1476         This script was trying to use "svn checkout" to dowload a file from
1477         svn.webkit.org, but "svn checkout" only works with directories.
1478         Instead, we should use "svn export".
1479
1480         * EWSTools/configure-svn-config.sh:
1481
1482 2013-03-31  Wei Jia  <wjia@chromium.org>
1483
1484         Allow WebUserMediaClientMock to be used by client
1485         https://bugs.webkit.org/show_bug.cgi?id=113633
1486
1487         Reviewed by Adam Barth.
1488
1489         Export WebUserMediaClientMock.
1490         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1491
1492         * DumpRenderTree/DumpRenderTree.gypi:
1493         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1494         (WebUserMediaClientMock):
1495         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1496         * Scripts/webkitpy/style/checkers/cpp.py:
1497         (check_function_definition):
1498
1499 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1500
1501         Expose FeatureObserver data to WebKit clients
1502         https://bugs.webkit.org/show_bug.cgi?id=113613
1503
1504         Reviewed by Sam Weinig.
1505
1506         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1507         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1508
1509 2013-03-29  Greg Hughes  <ghughes@apple.com>
1510
1511         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1512         https://bugs.webkit.org/show_bug.cgi?id=112276
1513
1514         Reviewed by Chris Fleizach.
1515
1516         Added support to test accessibility search predicates with multiple keys.  
1517
1518         * DumpRenderTree/AccessibilityUIElement.cpp:
1519         (uiElementForSearchPredicateCallback):
1520         * DumpRenderTree/AccessibilityUIElement.h:
1521         (AccessibilityUIElement):
1522         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1523         (AccessibilityUIElement::uiElementForSearchPredicate):
1524         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1525         (AccessibilityUIElement::uiElementForSearchPredicate):
1526         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1527         (AccessibilityUIElement::uiElementForSearchPredicate):
1528         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1529         (AccessibilityUIElement::uiElementForSearchPredicate):
1530         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1531         (AccessibilityUIElement::uiElementForSearchPredicate):
1532         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1533         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1534         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1535         (AccessibilityUIElement):
1536         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1538         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1539         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1540         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1541
1542 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1543
1544         Fix a typo in r147147 to fix Mac EWS.
1545
1546         * Scripts/webkitpy/tool/commands/queues.py:
1547         (PatchProcessingQueue._new_port_name_from_old):
1548
1549 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1550
1551         [EFL] Build break with latest EFL libraries after r146265
1552         https://bugs.webkit.org/show_bug.cgi?id=113558
1553
1554         Unreviewed build fix.
1555
1556         * TestWebKitAPI/PlatformWebView.h:
1557         * WebKitTestRunner/PlatformWebView.h:
1558
1559 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1560
1561         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1562
1563         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1564         in libgcrypt build.
1565
1566 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1567
1568         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1569
1570         Unreviewed.
1571
1572         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1573         (MacEWS):
1574
1575 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1576
1577         Use the right OS name on Mac EWS instead of mac-future.
1578
1579         Rubber-stamped by Dirk Pranke.
1580
1581         * Scripts/webkitpy/tool/commands/queues.py:
1582         (PatchProcessingQueue._new_port_name_from_old):
1583         (PatchProcessingQueue.begin_work_queue):
1584         (PatchProcessingQueue._upload_results_archive_for_patch):
1585
1586 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1587
1588         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1589         https://bugs.webkit.org/show_bug.cgi?id=112546
1590
1591         Reviewed by Martin Robinson.
1592
1593         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1594         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1595
1596 2013-03-28  Ming Xie  <mxie@blackberry.com>
1597
1598         [BlackBerry] Committer Email Updates
1599         https://bugs.webkit.org/show_bug.cgi?id=113435
1600
1601         Reviewed by Rob Buis.
1602
1603         Add the @blackberry.com email address for all our BlackBerry
1604         WebKit committers. This is the first step for our email address
1605         migration.
1606
1607         * Scripts/webkitpy/common/config/committers.py:
1608
1609 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1610
1611         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1612         https://bugs.webkit.org/show_bug.cgi?id=113508
1613
1614         Reviewed by Martin Robinson.
1615
1616         Prevent the GStreamer plugin scanner to load system-wide
1617         plugins. Only the ones built in JHBuild should be loaded and used
1618         at runtime.
1619
1620         * efl/jhbuildrc:
1621         * gtk/jhbuildrc:
1622
1623 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1624
1625         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1626         https://bugs.webkit.org/show_bug.cgi?id=113386
1627
1628         Reviewed by Carlos Garcia Campos.
1629
1630         * Scripts/webkitdirs.pm:
1631         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1632         version to 3.0. Reflect this change so the builtDylibPathForName
1633         function doesn't fail to report the library as found.
1634
1635 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1636
1637         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1638         https://bugs.webkit.org/show_bug.cgi?id=113484
1639
1640         Unreviewed build fix.
1641
1642         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1643
1644         * TestWebKitAPI/CMakeLists.txt:
1645         * WebKitTestRunner/CMakeLists.txt:
1646
1647 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1648
1649         Revision for the internal jhbuild is too old
1650         https://bugs.webkit.org/show_bug.cgi?id=113324
1651
1652         Reviewed by Martin Robinson.
1653
1654         Update the minimum required version to a point where jhbuild won't
1655         fail installing packages when trying to remove a symlink to a directory.
1656
1657         * jhbuild/jhbuild-wrapper: Updated revision.
1658
1659 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1660
1661         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1662         https://bugs.webkit.org/show_bug.cgi?id=113203
1663
1664         Reviewed by Philippe Normand.
1665
1666         We build our libsoup without GNOME support. gst-plugins-good does separate
1667         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1668         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1669         build failures as the headers of those diverge. We do not use souphttpsrc, so
1670         disable it when building gst-plugins-good.
1671
1672         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1673
1674 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1675
1676         Build fix after r146852. Please another reference to the Lion leaks builder.
1677
1678         * BuildSlaveSupport/build.webkit.org-config/config.json:
1679
1680 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1681
1682         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1683         https://bugs.webkit.org/show_bug.cgi?id=113421
1684
1685         Reviewed by Dirk Pranke.
1686
1687         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1688         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1689         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1690         in the GTK-specific TestExpectations files.
1691
1692         To avoid this only enable the warnings only when not using WKTR.
1693
1694         * Scripts/webkitpy/layout_tests/port/gtk.py:
1695         (GtkPort.warn_if_bug_missing_in_test_expectations):
1696
1697 2013-03-27  Antti Koivisto  <antti@apple.com>
1698
1699         Fix Zalan's email.
1700
1701         * Scripts/webkitpy/common/config/committers.py:
1702
1703 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1704
1705         master.cfg cleanup
1706         https://bugs.webkit.org/show_bug.cgi?id=113195
1707
1708         Reviewed by Ryosuke Niwa.
1709
1710         * BuildSlaveSupport/build.webkit.org-config/config.json:
1711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1712
1713 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1714
1715         master.cfg fine-tuning for Qt Mountain Lion Release bot
1716         https://bugs.webkit.org/show_bug.cgi?id=113191
1717
1718         Reviewed by Ryosuke Niwa.
1719
1720         * BuildSlaveSupport/build.webkit.org-config/config.json:
1721           - Rename the slave due to its location change.
1722           - Update the platform of the slave.
1723         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1724         (RunQtAPITests): Enable running WK2 API tests on Qt.
1725         (RunQtAPITests.start):
1726         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1727         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1728
1729 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1730
1731         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1732         https://bugs.webkit.org/show_bug.cgi?id=113403
1733
1734         Reviewed by Kenneth Rohde Christiansen.
1735
1736         As of Evas 1.7.5, when Wayland is detected on the system, support for
1737         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1738         The code, however, seems to depend on a few other flags which must be
1739         explicitly enabled.
1740
1741         If those additional GL-related options are passed, we end up
1742         having issues on the WebKit side, so disable Wayland support for
1743         now.
1744
1745         * efl/jhbuild.modules:
1746
1747 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1748
1749         Unreviewed, rolling out r146864.
1750         http://trac.webkit.org/changeset/146864
1751         https://bugs.webkit.org/show_bug.cgi?id=113391
1752
1753         causes crashes on Wk2 EFL release bot (Requested by drott on
1754         #webkit).
1755
1756         * Scripts/webkitperl/FeatureList.pm:
1757
1758 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1759
1760         [jhbuild] Correctly specify an alternate number of make jobs.
1761         https://bugs.webkit.org/show_bug.cgi?id=113396
1762
1763         Reviewed by Philippe Normand.
1764
1765         So far, we were using the `MAKEFLAGS' environment variable to pass the
1766         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1767         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1768
1769         We now behave more closely to the rest of the WebKit tools by first
1770         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1771         not set, just letting jhbuild itself figure out how many jobs to use.
1772
1773         * efl/jhbuildrc:
1774         * gtk/jhbuildrc:
1775
1776 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1777
1778         [Qt] Remove Qt specific WorkQueueItem definitions.
1779         https://bugs.webkit.org/show_bug.cgi?id=112891
1780
1781         This patch is preparation work for removing
1782         WorkQueue related code from TestRunnerQt and
1783         replacing it with generic TestRunner code.
1784
1785         Reviewed by Benjamin Poulain.
1786
1787         * DumpRenderTree/qt/TestRunnerQt.cpp:
1788         (TestRunnerQt::queueBackNavigation):
1789         (TestRunnerQt::queueForwardNavigation):
1790         (TestRunnerQt::queueLoadHTMLString):
1791         (TestRunnerQt::queueReload):
1792         (TestRunnerQt::queueLoadingScript):
1793         (TestRunnerQt::queueNonLoadingScript):
1794         (TestRunner::queueLoad):
1795         * DumpRenderTree/qt/TestRunnerQt.h:
1796         (TestRunnerQt):
1797         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1798         (LoadItem::invoke):
1799         (LoadHTMLStringItem::invoke):
1800         (LoadAlternateHTMLStringItem::invoke):
1801         (ReloadItem::invoke):
1802         (ScriptItem::invoke):
1803         (BackForwardItem::invoke):
1804         * DumpRenderTree/qt/WorkQueueItemQt.h:
1805         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1806         (LoadAlternateHTMLStringItem):
1807
1808 2013-03-26  Julie Parent  <jparent@chromium.org>
1809
1810         Flakiness dashboard: simplify logic around which tests to show.
1811         https://bugs.webkit.org/show_bug.cgi?id=113250
1812
1813         Reviewed by Ojan Vafai.
1814         
1815         The different filters for showing results are only used for layout
1816         tests, otherwise, we show everything.
1817         
1818         Change the defaults to false (what layout tests used), and only
1819         look at the values when viewing layout tests.
1820
1821         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1822         (htmlForTestsWithExpectationsButNoFailures):
1823         (shouldHideTest):
1824
1825 2013-03-26  Isaac Levy  <ilevy@google.com>
1826
1827         Update bots on test-results.appspot
1828         https://bugs.webkit.org/show_bug.cgi?id=113333
1829
1830         Reviewed by Ojan Vafai.
1831
1832         * TestResultServer/static-dashboards/builders.jsonp:
1833
1834 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1835
1836         Unreviewed GTK gardening.
1837
1838         * Scripts/run-gtk-tests:
1839         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1840
1841 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1842
1843         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1844         https://bugs.webkit.org/show_bug.cgi?id=113287
1845
1846         Reviewed by Jocelyn Turcotte.
1847
1848         * Scripts/run-qtwebkit-tests:
1849         (Options.__init__):
1850
1851 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1852
1853         [EFL] Enable IndexedDB by default
1854         https://bugs.webkit.org/show_bug.cgi?id=107248
1855
1856         Reviewed by Laszlo Gombos.
1857
1858         * Scripts/webkitperl/FeatureList.pm:
1859         Enable IndexedDB by default on EFL.
1860
1861 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1862
1863         Sheriffbot should explain rollout failures in a human readable form.
1864         https://bugs.webkit.org/show_bug.cgi?id=107092
1865
1866         Reviewed by Ryosuke Niwa.
1867
1868         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1869
1870         * Scripts/webkitpy/tool/bot/irc_command.py:
1871         (Rollout._check_diff_failure):
1872         (Rollout.execute):
1873         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1874         (IRCCommandTest.test_rollout):
1875
1876 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1877
1878         Unreviewed GTK gardening.
1879
1880         * Scripts/run-gtk-tests:
1881         (TestRunner): Skipping a failing unit test after r146518.
1882
1883 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1884
1885         Remove Lion leaks builder
1886         https://bugs.webkit.org/show_bug.cgi?id=113252
1887
1888         Reviewed by Andreas Kling.
1889
1890         Removed.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/config.json:
1893
1894 2013-03-25  Kent Tamura  <tkent@chromium.org>
1895
1896         Rename ENABLE_INPUT_TYPE_DATETIME
1897         https://bugs.webkit.org/show_bug.cgi?id=113254
1898
1899         Reviewed by Kentaro Hara.
1900
1901         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1902         Actually I'd like to remove the code, but we shouldn't remove it yet
1903         because we shipped products with it on some platforms.
1904
1905         * Scripts/webkitperl/FeatureList.pm:
1906         * qmake/mkspecs/features/features.pri:
1907
1908 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1909
1910         Remove one more line that was intended to be removed in r146657.
1911
1912         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1913         (summarize_results):
1914
1915 2013-03-25  Roger Fong  <roger_fong@apple.com>
1916
1917         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1918         Re-enable WinEWS tests.
1919
1920         * Scripts/webkitpy/common/config/ports.py:
1921         (WinPort.run_bindings_tests_command):
1922         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1923         (WinEWS):
1924
1925 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1926
1927         Unreviewed, rolling out r146793.
1928         http://trac.webkit.org/changeset/146793
1929         https://bugs.webkit.org/show_bug.cgi?id=113248
1930
1931         Fix did not work (Requested by rfong on #webkit).
1932
1933         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1934         (WinEWS):
1935
1936 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1937
1938         REGRESSION(r146657): Test failures reported incorrectly
1939         https://bugs.webkit.org/show_bug.cgi?id=113223
1940
1941         Reviewed by Dirk Pranke.
1942
1943         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1944
1945         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1946         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1947
1948         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1949         (Manager.run):
1950
1951         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1952         (RunDetails.__init__):
1953         (summarize_results): Remove the line I intended to remove in r146657.
1954
1955         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1956         (logging_run): Return details instead of the exit code.
1957         (run_and_capture): Ditto.
1958
1959         (RunTest.test_full_results_html):
1960         (RunTest.test_hung_thread):
1961         (RunTest.test_no_tests_found):
1962         (RunTest.test_no_tests_found_2):
1963         (RunTest.test_repeat_each_iterations_num_tests):
1964         (RunTest.test_run_singly_actually_runs_tests):
1965         (RunTest.test_test_list):
1966         (RunTest.test_missing_and_unexpected_results):
1967         (RunTest.test_pixel_test_directories):
1968         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1969         (RunTest.test_crash_with_stderr):
1970         (RunTest.test_no_image_failure_with_image_diff):
1971         (RunTest.test_crash_log):
1972         (RunTest.test_exit_after_n_failures_upload):
1973         (RunTest.test_results_directory_absolute):
1974         (RunTest.test_results_directory_relative):
1975         (RunTest.test_retrying_and_flaky_tests):
1976         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1977         (RunTest.test_retrying_uses_retries_directory):
1978         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1979         (RunTest.test_output_diffs):
1980         (EndToEndTest.test_reftest_with_two_notrefs):
1981         (RebaselineTest.test_reset_results):
1982         (RebaselineTest.test_missing_results):
1983         (RebaselineTest.test_new_baseline):
1984
1985         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1986         (BuildBotPrinter.print_results):
1987         (BuildBotPrinter.print_unexpected_results):
1988         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1989         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1990
1991 2013-03-25  Julie Parent  <jparent@chromium.org>
1992
1993         Dashboard refactor: Move cross dashboard history related code into history.js.
1994         https://bugs.webkit.org/show_bug.cgi?id=113104
1995
1996         Reviewed by Ojan Vafai.
1997
1998         All functions relating to cross dashboard behavior move from being
1999         globals to methods on the history.History object. Names stay the same,
2000         except many are made private, ones that should have been constants now
2001         are, and the long standing TODO to change "currentState" to 
2002         dashboardSpecificState is done.
2003         
2004         We now create a global history object in dashboard_base, as an 
2005         intermediate measure.  Once the dashboard specific code is
2006         added to history, each DB will need to create its own, and this
2007         global will be eliminated.
2008         
2009         * TestResultServer/static-dashboards/aggregate_results.js:
2010         (handleValidHashParameter):
2011         (htmlForBuilder):
2012         (rawValuesHTML):
2013         * TestResultServer/static-dashboards/dashboard_base.js:
2014         (parseDashboardSpecificParameters):
2015         (defaultValue):
2016         (currentBuilderGroupCategory):
2017         (currentBuilderGroupName):
2018         (handleLocationChange):
2019         (expectationsMap):
2020         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2021         (generatePage):
2022         (.switch.return):
2023         (platformAndBuildType):
2024         (individualTests):
2025         (substringList):
2026         (processMissingAndExtraExpectations):
2027         (pathToFailureLog):
2028         (showPopupForBuild):
2029         (htmlForTestsWithExpectationsButNoFailures):
2030         (shouldHideTest):
2031         (isCrossBuilderView):
2032         (tableHeaders):
2033         (htmlForSingleTestRow):
2034         (htmlForTableColumnHeader):
2035         (generatePageForExpectationsUpdate):
2036         (handleUpdate):
2037         (nextUpdate):
2038         (setUpdateIndex):
2039         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2040         (.appendExpectationsItem):
2041         (loadExpectations):
2042         (.dummyNode.onload):
2043         (loadExpectationsLayoutTests):
2044         (appendExpectations):
2045         (htmlForNavBar):
2046         (checkBoxToToggleState):
2047         (linkHTMLToToggleState):
2048         (generatePageForBuilder):
2049         (isInvalidKeyForCrossBuilderView):
2050         (handleQueryParameterChange):
2051         (showLegend):
2052         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2053         (resetGlobals):
2054         (test):
2055         * TestResultServer/static-dashboards/history.js:
2056         (.):
2057         * TestResultServer/static-dashboards/history_unittests.js:
2058         * TestResultServer/static-dashboards/loader.js:
2059         (.):
2060         * TestResultServer/static-dashboards/loader_unittests.js:
2061         * TestResultServer/static-dashboards/timeline_explorer.js:
2062         (generatePage):
2063         (initCurrentBuilderTestResults):
2064         (selectBuild):
2065         (showResultsDelta):
2066         * TestResultServer/static-dashboards/treemap.js:
2067         (generatePage):
2068         (.switch.return):
2069         (handleFocus):
2070         * TestResultServer/static-dashboards/ui.js:
2071
2072 2013-03-25  Roger Fong  <roger_fong@apple.com>
2073
2074         Unreviewed. Enable WinEWS tests again.
2075
2076         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2077         (WinEWS):
2078
2079 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2080
2081         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2082         https://bugs.webkit.org/show_bug.cgi?id=112166
2083
2084         HarfBuzz 0.9.14 merged my patch for icu detection without
2085         pkg-config files, as needed by for example Ubuntu 12.04.
2086         This obsoletes our local workaround. Removed it for GTK and EFL.
2087
2088         Reviewed by Martin Robinson.
2089
2090         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2091         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2092         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2093         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2094
2095 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2096
2097         Unreviewed.  Move self from contributor to committer list.
2098
2099         * Scripts/webkitpy/common/config/committers.py:
2100
2101 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2102
2103         EWS should use a human readable port name when uploading layout test archives
2104         https://bugs.webkit.org/show_bug.cgi?id=113099
2105
2106         Reviewed by Dirk Pranke.
2107
2108         Use new port's object's name() method to report human readable port names.
2109         This will also help us resolving the bug to apply layout test results posted by EWS.
2110
2111         * Scripts/webkitpy/tool/bot/botinfo.py:
2112         (BotInfo.__init__): Take port's name.
2113         (BotInfo.summary_text):
2114
2115         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2116         (BotInfoTest.test_summary_text):
2117
2118         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2119         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2120
2121         * Scripts/webkitpy/tool/commands/queues.py:
2122         (PatchProcessingQueue.__init__): Initialize self._port.
2123         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2124         and use that for the attachment filename and the comment posted.
2125
2126         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2127         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2128         "mac-snowleopard" as expected for TestPort.
2129
2130 2013-03-22  Roger Fong  <roger_fong@apple.com>
2131
2132         Unreviewed. Turn off EWS test on Win again.
2133         The battle continues.
2134
2135         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2136         (WinEWS):
2137
2138 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2139
2140         NRWT: Enable pixel tests when retrying tests
2141         https://bugs.webkit.org/show_bug.cgi?id=112898
2142
2143         Reviewed by Dirk Pranke.
2144
2145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2146         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2147         if we've forced pixel tests in the retry.
2148         (Manager._run_tests):
2149         (Manager._clean_up_run): Fixed the capitalizations.
2150         (Manager._force_pixel_tests_if_needed): Added.
2151
2152         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2153         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2154         'image_diff_percent' if it doesn't already exist.
2155
2156         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2157         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2158         treat this as a regular regression instead of a flakiness.
2159
2160         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2161         run had image diffs.
2162
2163         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2164         (summarized_results):
2165
2166         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2167         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2168         Also removed some dead code.
2169
2170         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2171         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2172         is set and pixel_tests_enabled is set to false.
2173         (EndToEndTest.test_reftest_with_two_notrefs):
2174
2175 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2176
2177         Make it possible to run layout tests on Retina MBP
2178         https://bugs.webkit.org/show_bug.cgi?id=93673
2179
2180         Reviewed by Ryosuke Niwa.
2181
2182         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2183         windows on 2x machines still run at 1x.
2184
2185         * DumpRenderTree/mac/DumpRenderTree.mm:
2186         (createWebViewAndOffscreenWindow):
2187         Reset the window resolution to 1x on creation.
2188         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2189         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2190         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2191         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2192         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2193         (WTR::PlatformWebView::PlatformWebView):
2194         Add NSWindow details, reset the window resolution to 1x on creation.
2195
2196 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2197
2198         Leak bots shouldn't build
2199         https://bugs.webkit.org/show_bug.cgi?id=112774
2200
2201         Reviewed by Simon Fraser.
2202
2203         Since leak bots use regular debug builds, there is no need to build on these bots.
2204         Simply downloading builds will dramatically improve the cycle time of these bots.
2205
2206         * BuildSlaveSupport/build.webkit.org-config/config.json:
2207         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2208         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2209         TestFactory instead of BuildAndTestFactory.
2210
2211 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2212
2213         [Qt] Fix the TestWebKitAPI build
2214         https://bugs.webkit.org/show_bug.cgi?id=113044
2215
2216         Reviewed by Tor Arne Vestbø.
2217
2218         The generate-forwarding-headers script would only be run
2219         after the targets in InjectedBundle.pri since the second
2220         addStrictSubdirOrderBetween call in
2221         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2222         the derived_sources -> injected_bundle order in SUBDIRS.
2223
2224         Fix it by only moving the dependent target at the end of
2225         SUBDIRS, don't touch its dependency.
2226
2227         * qmake/mkspecs/features/functions.prf:
2228
2229 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2230
2231         [EFL][WK2] View is not focused when fullscreen mode toggled
2232         https://bugs.webkit.org/show_bug.cgi?id=113009
2233
2234         Reviewed by Laszlo Gombos.
2235
2236         Set focus on view when fullscreen mode enabled/disabled
2237         by FullScreen API.
2238
2239         * MiniBrowser/efl/main.c:
2240         (on_fullscreen_accept):
2241         (on_fullscreen_deny):
2242
2243 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2244
2245         nrwt is no longer saving retry results in the retries/ subdirectory
2246         https://bugs.webkit.org/show_bug.cgi?id=112995
2247
2248         Reviewed by Ojan Vafai.
2249
2250         I think this has been broken a long time, unfortunately. This
2251         patch should fix that.
2252
2253         In order to do so, I had to pass the directory to use from
2254         the Worker object through the SingleTestWriter to the
2255         TestResultWriter. While I was plumbing that through, I rationalized
2256         the order of the parameter arguments a bit ...
2257
2258         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2259         (Worker._run_single_test):
2260         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2261         (run_single_test):
2262         (SingleTestRunner.__init__):
2263         (SingleTestRunner._run_compare_test):
2264         (SingleTestRunner._run_rebaseline):
2265         (SingleTestRunner._run_reftest):
2266         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2267         (write_test_result):
2268         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2269         (TestResultWriterTest.test_reftest_diff_image):
2270         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2271         (RunTest.test_retrying_uses_retries_directory):
2272
2273 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2274
2275         JSC profiler should have an at-a-glance report of the success of DFG optimization
2276         https://bugs.webkit.org/show_bug.cgi?id=112988
2277
2278         Reviewed by Geoffrey Garen.
2279
2280         * Scripts/display-profiler-output:
2281
2282 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2283
2284         [chromium] Linux ASAN WebKit canary is running out of memory
2285         https://bugs.webkit.org/show_bug.cgi?id=112978
2286
2287         Reviewed by Tony Chang.
2288
2289         Running the AddressSanitizer on a crash takes a lot of
2290         memory, so we should serialize access to it to avoid running
2291         out of memory on a machine.
2292
2293         * Scripts/webkitpy/layout_tests/port/chromium.py:
2294         (ChromiumPort._get_crash_log):
2295         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2296         (HttpLock.__init__):
2297         (HttpLock.wait_for_httpd_lock):
2298
2299 2013-03-21  Min Qin  <qinmin@chromium.org>
2300
2301         Cleanup android media layout test code
2302         https://bugs.webkit.org/show_bug.cgi?id=112944
2303
2304         Reviewed by Adam Barth.
2305
2306         Chromium change: https://codereview.chromium.org/12892010/
2307         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2308         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2309         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2310         Instead, we should switch to use content shell for layout tests.
2311
2312         * DumpRenderTree/chromium/TestShell.cpp:
2313         (TestShell::resetTestController):
2314
2315 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2316
2317         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2318         https://bugs.webkit.org/show_bug.cgi?id=112953
2319
2320         Reviewed by Tony Chang.
2321
2322         When I created the DumpRenderTree_resources target in r144863 I
2323         forgot to declare the needed dependencies on the other resource
2324         targets. Due to a quirk of ordering, this appears to have been fine
2325         w/ ninja but not w/ Xcode (which is still being used on the chromium
2326         mac valgrind bots). Declaring the dependencies fixes the build
2327         failures.
2328
2329         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2330
2331 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2332
2333         [WinCairo] Correct assert in Empty BitmapImage Test.
2334         https://bugs.webkit.org/show_bug.cgi?id=112934
2335
2336         Reviewed by Tim Horton.
2337
2338         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2339         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2340         to avoid ref counting assertion when leaving test scope.
2341
2342 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2343
2344         [GTK] generate-feature-defines-files is incompatible with Python3
2345         https://bugs.webkit.org/show_bug.cgi?id=112956
2346
2347         Reviewed by Martin Robinson.
2348
2349         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2350         method on the dictionary objects when iterating through said dictionaries.
2351
2352         * gtk/generate-feature-defines-files:
2353         (write_feature_defines_header):
2354         (write_flattened_feature_defines_file):
2355
2356 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2357
2358         kill-old-processes spits out error messages on Mac
2359         https://bugs.webkit.org/show_bug.cgi?id=112878
2360
2361         Reviewed by Jessie Berlin.
2362
2363         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2364         included in the list of options grep --help shows.
2365
2366         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2367
2368         * BuildSlaveSupport/kill-old-processes:
2369         (main):
2370
2371 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2372
2373         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2374         https://bugs.webkit.org/show_bug.cgi?id=112597
2375
2376         Reviewed by Xan Lopez.
2377
2378         These were introduced for the Chromium port in r105295. We need
2379         dummy implementations in order to compile the BlackBerry port.
2380
2381         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2382         (AccessibilityUIElement::scrollToMakeVisible):
2383         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2384         (AccessibilityUIElement::scrollToGlobalPoint):
2385
2386 2013-03-21  Roger Fong  <roger_fong@apple.com>
2387
2388         Re-enable WinEWS tests following r146376.
2389
2390         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2391         (WinEWS):
2392
2393 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2394
2395         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2396
2397         * Scripts/webkitpy/common/config/committers.py:
2398
2399 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2400
2401         [GTK] Missing atk in install-dependencies script
2402         https://bugs.webkit.org/show_bug.cgi?id=112272
2403
2404         Reviewed by Gustavo Noronha Silva.
2405
2406         * gtk/install-dependencies: Add missing atk dependency.
2407
2408 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2409
2410         [GTK] Missing backslash in install-dependencies script
2411         https://bugs.webkit.org/show_bug.cgi?id=112907
2412
2413         Reviewed by Philippe Normand.
2414
2415         * gtk/install-dependencies: Add missing backslash to dependencies
2416         list.
2417
2418 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         EWS bots have stopped uploading results to bugzilla
2421         https://bugs.webkit.org/show_bug.cgi?id=101091
2422
2423         Reviewed by Adam Barth.
2424
2425         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2426         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2427         this relative file path resoled to a file inside a non-existent directory for "zip".
2428
2429         Fixed the bug by resolving both test results directory and zip archive paths in
2430         LayoutTestResultsReader.archive.
2431
2432         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2433         in the future.
2434
2435         * Scripts/webkitpy/common/system/filesystem_mock.py:
2436         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2437
2438         * Scripts/webkitpy/common/system/workspace.py:
2439         (Workspace.create_zip): Log the source path when "zip" failed.
2440
2441         * Scripts/webkitpy/common/system/workspace_mock.py:
2442         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2443
2444         * Scripts/webkitpy/common/system/workspace_unittest.py:
2445         (WorkspaceTest.test_create_zip_exception): Test that.
2446
2447         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2448         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2449         This is the actual bug fix.
2450
2451         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2452         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2453
2454 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2455
2456         [chromium] move WebThemeEngine implementations to TestRunner library
2457         https://bugs.webkit.org/show_bug.cgi?id=112751
2458
2459         Reviewed by Adam Barth.
2460
2461         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2462         * DumpRenderTree/DumpRenderTree.gypi:
2463         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2464         (WebKit):
2465         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2466         (WebTestRunner::TestInterfaces::themeEngine):
2467         (WebTestRunner):
2468         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2469         (WebKit):
2470         (TestInterfaces):
2471         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2472         (WebTestRunner::WebTestInterfaces::themeEngine):
2473         (WebTestRunner):
2474         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2475         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2476         (WebTestRunner):
2477         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2478         (WebTestRunner::WebTestThemeControlWin::box):
2479         (WebTestRunner::WebTestThemeControlWin::line):
2480         (WebTestRunner::WebTestThemeControlWin::triangle):
2481         (WebTestRunner::WebTestThemeControlWin::roundRect):
2482         (WebTestRunner::WebTestThemeControlWin::oval):
2483         (WebTestRunner::WebTestThemeControlWin::circle):
2484         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2485         (WebTestRunner::WebTestThemeControlWin::markState):
2486         (WebTestRunner::WebTestThemeControlWin::draw):
2487         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2488         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2489         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2490         (WebTestRunner):
2491         (WebTestThemeControlWin):
2492         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2493         (WebTestRunner):
2494         (WebTestThemeEngineMac):
2495         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2496         (+[FakeActiveWindow alwaysActiveWindow]):
2497         (+[FakeActiveWindow alwaysInactiveWindow]):
2498         (-[FakeActiveWindow initWithActiveControls:]):
2499         (-[FakeActiveWindow _hasActiveControls]):
2500         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2501         (WebTestRunner):
2502         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2503         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2504         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2505         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2506         (WebTestRunner):
2507         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2508         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2509         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2510         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2511         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2512         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2513         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2514         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2515         (WebTestRunner::WebTestThemeEngineWin::getSize):
2516         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2517         (WebTestRunner):
2518         (WebTestThemeEngineWin):
2519         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2520         * DumpRenderTree/chromium/TestShell.cpp:
2521         (TestShell::initialize):
2522         * DumpRenderTree/chromium/TestShell.h:
2523         (WebKit):
2524         * DumpRenderTree/chromium/TestShellMac.mm:
2525         (platformInit):
2526         * DumpRenderTree/chromium/TestShellWin.cpp:
2527         (platformInit):
2528         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2529
2530 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2531
2532         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2533
2534         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2535         New property sheet that does not link against CoreFoundation and
2536         CFNetwork.
2537         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2538         Use new TestWebKitAPICommonWinCairo property sheet.
2539         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2540         Ditto.
2541
2542 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2543
2544         [WinCairo] Unreviewed build fix for VS2010.
2545
2546         Had to add WinCairo-specific property sheets to deal with some
2547         library and path differences with the main Apple port.
2548
2549         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2550         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2551         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2552         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2553         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2554         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2555
2556 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2557
2558         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2559         https://bugs.webkit.org/show_bug.cgi?id=112849
2560
2561         Reviewed by Sam Weinig.
2562
2563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2565         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2566
2567 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2568
2569         [WinCairo] Build WebKit Tools under VS2010
2570         https://bugs.webkit.org/show_bug.cgi?id=112821
2571
2572         Reviewed by Tim Horton.
2573
2574         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2575         Add WinCairo-specific build target.
2576         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2577         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2578         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2579         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2580         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2581         Add WinCairo-specific build target.
2582         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2583         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2584         Add WinCairo-specific build target.
2585         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2586         WinCairo-specific build target.
2587         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2588         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2589         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2590         specific build target.
2591         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2592         WinCairo-specific build target.
2593         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2594         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2595         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2596
2597 2013-03-20  Roger Fong  <roger_fong@apple.com>
2598
2599         API test gardening AppleWin port.
2600
2601         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2602
2603         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2604         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2605
2606 2013-03-20  Roger Fong  <roger_fong@apple.com>
2607
2608         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2609
2610         * EWSTools/start-queue-win.sh:
2611
2612 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2613
2614         Unreviewed, add myself to committers.py.
2615
2616 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2617
2618         Unreviewed. Adding another email for me.
2619
2620         * Scripts/webkitpy/common/config/committers.py:
2621
2622 2013-03-20  Justin Novosad  <junov@google.com>
2623
2624         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2625         https://bugs.webkit.org/show_bug.cgi?id=112605
2626
2627         Reviewed by James Robinson.
2628
2629         Deleting all the code that was used for propagating and supporting
2630         the Chromium setting for disabling deferred 2d canvas rendering.
2631
2632         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2633         (main):
2634         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2635         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2636         (WebTestRunner::WebPreferences::reset):
2637         (WebTestRunner::WebPreferences::applyTo):
2638         * DumpRenderTree/chromium/TestShell.cpp:
2639         (TestShell::TestShell):
2640         (TestShell::resetWebSettings):
2641         (TestShell::runFileTest):
2642         * DumpRenderTree/chromium/TestShell.h:
2643         (TestShell):
2644
2645 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2646
2647         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2648         https://bugs.webkit.org/show_bug.cgi?id=112699.
2649
2650         Reviewed by Adam Barth.
2651
2652         * Scripts/webkitpy/layout_tests/port/qt.py:
2653         (QtPort._search_paths):
2654         (QtPort._port_specific_expectations_files):
2655         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2656         (QtPortTest):
2657         (QtPortTest._assert_search_path):
2658         (QtPortTest._assert_expectations_files):
2659
2660 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2661
2662         [Qt] Enable kerning by default
2663         https://bugs.webkit.org/show_bug.cgi?id=112704
2664
2665         Reviewed by Jocelyn Turcotte.
2666
2667         Disable kerning by default, since some reference test expectations
2668         expect kerning to be default off.
2669
2670         * DumpRenderTree/qt/TestRunnerQt.cpp:
2671         (TestRunnerQt::reset):
2672         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2673         (WTR::activateFonts):
2674
2675 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2676
2677         [Qt] Remove empty function stubs from TestRunnerQt.
2678         https://bugs.webkit.org/show_bug.cgi?id=112799
2679
2680         We are reducing the code in TestRunnerQt step by step,
2681         in order to finally replace all of it with the generic
2682         TestRunner implementation.
2683         This patch removes several simple function stubs that
2684         currently do not implement any actual functionality.
2685
2686         Reviewed by Kenneth Rohde Christiansen.
2687
2688         * DumpRenderTree/qt/TestRunnerQt.cpp:
2689         * DumpRenderTree/qt/TestRunnerQt.h:
2690         (TestRunnerQt):
2691
2692 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2693
2694         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2695         https://bugs.webkit.org/show_bug.cgi?id=112687
2696
2697         Reviewed by Kenneth Rohde Christiansen.
2698
2699         Hide the SearchBar by default on window creation.
2700
2701         * MiniBrowser/efl/main.c:
2702         (window_create):
2703
2704 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2705
2706         Unreviewed, rolling out r146304.
2707         http://trac.webkit.org/changeset/146304
2708         https://bugs.webkit.org/show_bug.cgi?id=112788
2709
2710         to many expectations to update (Requested by antonm on
2711         #webkit).
2712
2713         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2714         * DumpRenderTree/DumpRenderTree.gypi:
2715         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2716         (WebKit):
2717         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2718         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2719         (TestInterfaces):
2720         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2721         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2722         * DumpRenderTree/chromium/TestShell.cpp:
2723         (TestShell::initialize):
2724         * DumpRenderTree/chromium/TestShell.h:
2725         (WebKit):
2726         * DumpRenderTree/chromium/TestShellMac.mm:
2727         (platformInit):
2728         * DumpRenderTree/chromium/TestShellWin.cpp:
2729         (platformInit):
2730         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2731         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2732         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2733         (WebThemeControlDRTWin::box):
2734         (WebThemeControlDRTWin::line):
2735         (WebThemeControlDRTWin::triangle):
2736         (WebThemeControlDRTWin::roundRect):
2737         (WebThemeControlDRTWin::oval):
2738         (WebThemeControlDRTWin::circle):
2739         (WebThemeControlDRTWin::nestedBoxes):
2740         (WebThemeControlDRTWin::markState):
2741         (WebThemeControlDRTWin::draw):
2742         (WebThemeControlDRTWin::drawTextField):
2743         (WebThemeControlDRTWin::drawProgressBar):
2744         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2745         (WebThemeControlDRTWin):
2746         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2747         (WebThemeEngineDRTMac):
2748         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2749         (+[FakeActiveWindow alwaysActiveWindow]):
2750         (+[FakeActiveWindow alwaysInactiveWindow]):
2751         (-[FakeActiveWindow initWithActiveControls:]):
2752         (-[FakeActiveWindow _hasActiveControls]):
2753         (WebThemeEngineDRTMac::paintScrollbarThumb):
2754         (stateToHIEnableState):
2755         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2756         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2757         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2758         (webRectToSkIRect):
2759         (drawControl):
2760         (drawTextField):
2761         (drawProgressBar):
2762         (WebThemeEngineDRTWin::paintButton):
2763         (WebThemeEngineDRTWin::paintMenuList):
2764         (WebThemeEngineDRTWin::paintScrollbarArrow):
2765         (WebThemeEngineDRTWin::paintScrollbarThumb):
2766         (WebThemeEngineDRTWin::paintScrollbarTrack):
2767         (WebThemeEngineDRTWin::paintSpinButton):
2768         (WebThemeEngineDRTWin::paintTextField):
2769         (WebThemeEngineDRTWin::paintTrackbar):
2770         (WebThemeEngineDRTWin::paintProgressBar):
2771         (WebThemeEngineDRTWin::getSize):
2772         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2773         (WebThemeEngineDRTWin):
2774         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2775
2776 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2777
2778         [Qt] Support -webkit-font-smoothing
2779         https://bugs.webkit.org/show_bug.cgi?id=106009
2780
2781         Reviewed by Jocelyn Turcotte.
2782
2783         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2784
2785         * DumpRenderTree/qt/TestRunnerQt.cpp:
2786         (TestRunnerQt::reset):
2787
2788 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2789
2790         [GTK] accessibility/aria-scrollbar-role.html is failing
2791         https://bugs.webkit.org/show_bug.cgi?id=98358
2792
2793         Reviewed by Martin Robinson.
2794
2795         Adds support for checking accessibility object's orientation.
2796         Orientation is checked by retrieving proper state of accessibility object.
2797
2798         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2799         (checkElementState):
2800         (AccessibilityUIElement::orientation):
2801         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2802         (WTR::AccessibilityUIElement::orientation):
2803
2804 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2805
2806         [chromium] move WebThemeEngine implementations to TestRunner library
2807         https://bugs.webkit.org/show_bug.cgi?id=112751
2808
2809         Reviewed by Adam Barth.
2810
2811         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2812         * DumpRenderTree/DumpRenderTree.gypi:
2813         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2814         (WebKit):
2815         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2816         (WebTestRunner::TestInterfaces::themeEngine):
2817         (WebTestRunner):
2818         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2819         (WebKit):
2820         (TestInterfaces):
2821         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2822         (WebTestRunner::WebTestInterfaces::themeEngine):
2823         (WebTestRunner):
2824         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2825         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2826         (WebTestRunner):
2827         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2828         (WebTestRunner::WebTestThemeControlWin::box):
2829         (WebTestRunner::WebTestThemeControlWin::line):
2830         (WebTestRunner::WebTestThemeControlWin::triangle):
2831         (WebTestRunner::WebTestThemeControlWin::roundRect):
2832         (WebTestRunner::WebTestThemeControlWin::oval):
2833         (WebTestRunner::WebTestThemeControlWin::circle):
2834         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2835         (WebTestRunner::WebTestThemeControlWin::markState):
2836         (WebTestRunner::WebTestThemeControlWin::draw):
2837         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2838         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2839         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2840         (WebTestRunner):
2841         (WebTestThemeControlWin):
2842         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2843         (WebTestRunner):
2844         (WebTestThemeEngineMac):
2845         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2846         (+[FakeActiveWindow alwaysActiveWindow]):
2847         (+[FakeActiveWindow alwaysInactiveWindow]):
2848         (-[FakeActiveWindow initWithActiveControls:]):
2849         (-[FakeActiveWindow _hasActiveControls]):
2850         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2851         (WebTestRunner):
2852         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2853         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2854         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2855         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2856         (WebTestRunner):
2857         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2858         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2859         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2860         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2861         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2862         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2863         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2864         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2865         (WebTestRunner::WebTestThemeEngineWin::getSize):
2866         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2867         (WebTestRunner):
2868         (WebTestThemeEngineWin):
2869         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2870         * DumpRenderTree/chromium/TestShell.cpp:
2871         (TestShell::initialize):
2872         * DumpRenderTree/chromium/TestShell.h:
2873         (WebKit):
2874         * DumpRenderTree/chromium/TestShellMac.mm:
2875         (platformInit):
2876         * DumpRenderTree/chromium/TestShellWin.cpp:
2877         (platformInit):
2878         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2879
2880 2013-03-19  Tony Chang  <tony@chromium.org>
2881
2882         Move testRunner.setTouchDragDropEnabled to internals.settings
2883         https://bugs.webkit.org/show_bug.cgi?id=112739
2884
2885         Reviewed by Adam Barth.
2886
2887         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2888         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2889         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2890         (TestRunner): Remove unnecessary code.
2891         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2892         (WebTestRunner::WebPreferences::reset):
2893         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2894
2895 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2896
2897         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2898         https://bugs.webkit.org/show_bug.cgi?id=112754
2899
2900         Reviewed by Darin Fisher.
2901
2902         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2903         now that it's always defined.
2904
2905         * DumpRenderTree/chromium/WebViewHost.cpp:
2906         * DumpRenderTree/chromium/WebViewHost.h:
2907         (WebViewHost):
2908
2909 2013-03-19  Kenneth Russell  <kbr@google.com>
2910
2911         Unreviewed, rolling out r146290.
2912         http://trac.webkit.org/changeset/146290
2913         https://bugs.webkit.org/show_bug.cgi?id=112751
2914
2915         Broke Chromium Mac build.
2916
2917         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2918         * DumpRenderTree/DumpRenderTree.gypi:
2919         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2920         (WebKit):
2921         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2922         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2923         (TestInterfaces):
2924         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2925         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2926         * DumpRenderTree/chromium/TestShell.cpp:
2927         (TestShell::initialize):
2928         * DumpRenderTree/chromium/TestShell.h:
2929         (WebKit):
2930         * DumpRenderTree/chromium/TestShellMac.mm:
2931         (platformInit):
2932         * DumpRenderTree/chromium/TestShellWin.cpp:
2933         (platformInit):
2934         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2935         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2936         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2937         (WebThemeControlDRTWin::box):
2938         (WebThemeControlDRTWin::line):
2939         (WebThemeControlDRTWin::triangle):
2940         (WebThemeControlDRTWin::roundRect):
2941         (WebThemeControlDRTWin::oval):
2942         (WebThemeControlDRTWin::circle):
2943         (WebThemeControlDRTWin::nestedBoxes):
2944         (WebThemeControlDRTWin::markState):
2945         (WebThemeControlDRTWin::draw):
2946         (WebThemeControlDRTWin::drawTextField):
2947         (WebThemeControlDRTWin::drawProgressBar):
2948         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2949         (WebThemeControlDRTWin):
2950         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2951         (WebThemeEngineDRTMac):
2952         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2953         (+[FakeActiveWindow alwaysActiveWindow]):
2954         (+[FakeActiveWindow alwaysInactiveWindow]):
2955         (-[FakeActiveWindow initWithActiveControls:]):
2956         (-[FakeActiveWindow _hasActiveControls]):
2957         (WebThemeEngineDRTMac::paintScrollbarThumb):
2958         (stateToHIEnableState):
2959         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2960         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2961         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2962         (webRectToSkIRect):
2963         (drawControl):
2964         (drawTextField):
2965         (drawProgressBar):
2966         (WebThemeEngineDRTWin::paintButton):
2967         (WebThemeEngineDRTWin::paintMenuList):
2968         (WebThemeEngineDRTWin::paintScrollbarArrow):
2969         (WebThemeEngineDRTWin::paintScrollbarThumb):
2970         (WebThemeEngineDRTWin::paintScrollbarTrack):
2971         (WebThemeEngineDRTWin::paintSpinButton):
2972         (WebThemeEngineDRTWin::paintTextField):
2973         (WebThemeEngineDRTWin::paintTrackbar):
2974         (WebThemeEngineDRTWin::paintProgressBar):
2975         (WebThemeEngineDRTWin::getSize):
2976         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2977         (WebThemeEngineDRTWin):
2978         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2979
2980 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2981
2982         [EFL] canvas-fallback-content.html is failing
2983         https://bugs.webkit.org/show_bug.cgi?id=111998
2984
2985         Reviewed by Chris Fleizach.
2986
2987         Adds support for getting platform name.
2988
2989         * DumpRenderTree/TestRunner.cpp:
2990         (TestRunner::staticValues):
2991         * DumpRenderTree/TestRunner.h:
2992         (TestRunner):
2993         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2994         (TestRunner::platformName):
2995
2996 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2997
2998         [chromium] move WebThemeEngine implementations to TestRunner library
2999         https://bugs.webkit.org/show_bug.cgi?id=112751
3000
3001         Reviewed by Adam Barth.
3002
3003         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3004         * DumpRenderTree/DumpRenderTree.gypi:
3005         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3006         (WebKit):
3007         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3008         (WebTestRunner::TestInterfaces::themeEngine):
3009         (WebTestRunner):
3010         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3011         (WebKit):
3012         (TestInterfaces):
3013         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3014         (WebTestRunner::WebTestInterfaces::themeEngine):
3015         (WebTestRunner):
3016         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3017         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3018         (WebTestRunner):
3019         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3020         (WebTestRunner::WebTestThemeControlWin::box):
3021         (WebTestRunner::WebTestThemeControlWin::line):
3022         (WebTestRunner::WebTestThemeControlWin::triangle):
3023         (WebTestRunner::WebTestThemeControlWin::roundRect):
3024         (WebTestRunner::WebTestThemeControlWin::oval):
3025         (WebTestRunner::WebTestThemeControlWin::circle):
3026         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3027         (WebTestRunner::WebTestThemeControlWin::markState):
3028         (WebTestRunner::WebTestThemeControlWin::draw):
3029         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3030         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3031         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3032         (WebTestRunner):
3033         (WebTestThemeControlWin):
3034         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3035         (WebTestRunner):
3036         (WebTestThemeEngineMac):
3037         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3038         (+[FakeActiveWindow alwaysActiveWindow]):
3039         (+[FakeActiveWindow alwaysInactiveWindow]):
3040         (-[FakeActiveWindow initWithActiveControls:]):
3041         (-[FakeActiveWindow _hasActiveControls]):
3042         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3043         (WebTestRunner):
3044         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3045         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3046         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3047         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3048         (WebTestRunner):
3049         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3050         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3051         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3052         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3053         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3054         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3055         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3056         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3057         (WebTestRunner::WebTestThemeEngineWin::getSize):
3058         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3059         (WebTestRunner):
3060         (WebTestThemeEngineWin):
3061         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3062         * DumpRenderTree/chromium/TestShell.cpp:
3063         (TestShell::initialize):
3064         * DumpRenderTree/chromium/TestShell.h:
3065         (WebKit):
3066         * DumpRenderTree/chromium/TestShellMac.mm:
3067         (platformInit):
3068         * DumpRenderTree/chromium/TestShellWin.cpp:
3069         (platformInit):
3070         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3071
3072 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3073
3074         [EFL][WK2] Separate WebView further from EwkView
3075         https://bugs.webkit.org/show_bug.cgi?id=111591
3076
3077         Reviewed by Caio Marcelo de Oliveira Filho.
3078
3079         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3080         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3081         since we can afford it having EWKViewGetWKView() private API to access WKView.
3082
3083         * TestWebKitAPI/PlatformWebView.h:
3084         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3085         (TestWebKitAPI::TEST):
3086         * TestWebKitAPI/efl/PlatformWebView.cpp:
3087         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3088         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3089         (TestWebKitAPI::PlatformWebView::resizeTo):
3090         (TestWebKitAPI::PlatformWebView::page):
3091         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3092         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3093         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3094         * WebKitTestRunner/PlatformWebView.h:
3095         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3096         (WTR::EventSenderProxy::dispatchEvent):
3097         (WTR::EventSenderProxy::keyDown):
3098         (WTR::EventSenderProxy::sendTouchEvent):
3099         (WTR::EventSenderProxy::setTouchModifier):
3100         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3101         (WTR::PlatformWebView::PlatformWebView):
3102         (WTR::PlatformWebView::~PlatformWebView):
3103         (WTR::PlatformWebView::resizeTo):
3104         (WTR::PlatformWebView::page):
3105         (WTR::PlatformWebView::focus):
3106         (WTR::PlatformWebView::windowSnapshotImage):
3107
3108 2013-03-19  Roger Fong  <roger_fong@apple.com>
3109
3110         Changes to VS2010 project files should only trigger builds on Windows bots.
3111         https://bugs.webkit.org/show_bug.cgi?id=112731
3112
3113         Reviewed by Timothy Horton.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3116         (_should_file_trigger_build):
3117
3118 2013-03-19  Roger Fong  <roger_fong@apple.com>
3119
3120         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3121
3122         * Scripts/webkitpy/tool/steps/runtests.py:
3123         (RunTests.run):
3124         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3125         (RunTestsTest.test_webkit_run_unit_tests):
3126
3127 2013-03-19  Julie Parent  <jparent@chromium.org>
3128
3129         Dashboards: Introduce history namespace and unit tests.
3130         https://bugs.webkit.org/show_bug.cgi?id=112645
3131
3132         Reviewed by Ojan Vafai.
3133         
3134         Laying the framework for introducing the new history object and
3135         namespace.  This moves only static functions into the history
3136         namespace, and moves corresponding unit tests into seperate
3137         unit test file.
3138
3139         * TestResultServer/static-dashboards/aggregate_results.html:
3140         * TestResultServer/static-dashboards/dashboard_base.js:
3141         (parseCrossDashboardParameters):
3142         (parseDashboardSpecificParameters):
3143         (parseParameters):
3144         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3145         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3146         (.switch.return):
3147         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3148         * TestResultServer/static-dashboards/history.js: Added.
3149         * TestResultServer/static-dashboards/history_unittests.js: Added.
3150         * TestResultServer/static-dashboards/loader.js:
3151         (.):
3152         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3153         * TestResultServer/static-dashboards/run-unittests.html:
3154         * TestResultServer/static-dashboards/timeline_explorer.html:
3155         * TestResultServer/static-dashboards/timeline_explorer.js:
3156         * TestResultServer/static-dashboards/treemap.html:
3157         * TestResultServer/static-dashboards/treemap.js:
3158         (.switch.return):
3159         * TestResultServer/static-dashboards/ui.js:
3160
3161 2013-03-19  Daniel Bates  <dbates@webkit.org>
3162
3163         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3164         https://bugs.webkit.org/show_bug.cgi?id=112732
3165
3166         Reviewed by Eric Seidel.
3167
3168         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3169         of an existing file cannot be applied.
3170
3171         In particular, svn-{apply, unapply} compensate for differences in line endings
3172         by converting the line endings in a diff to match the line endings in the target
3173         file. The diff(1) command precedes the last line of a diff that adds a newline
3174         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3175         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3176         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3177         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3178         the newline characters in this special character sequence to match the line endings
3179         in the target file.
3180
3181         * Scripts/VCSUtils.pm:
3182         (parseDiff):
3183         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3184         Added tests:
3185             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3186             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3187             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3188             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3189         (escapeNewLineCharacters): Added.
3190         (toMacLineEndings): Added.
3191
3192 2013-03-19  James Robinson  <jamesr@chromium.org>
3193
3194         [chromium] Remove compositor settings that don't go through WebKit
3195         https://bugs.webkit.org/show_bug.cgi?id=112718
3196
3197         Reviewed by Adam Barth.
3198
3199         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3200         (main):
3201         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3202         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3203         (WebTestRunner::WebPreferences::reset):
3204         (WebTestRunner::WebPreferences::applyTo):
3205         * DumpRenderTree/chromium/TestShell.cpp:
3206         (TestShell::TestShell):
3207         (TestShell::resetWebSettings):
3208         * DumpRenderTree/chromium/TestShell.h:
3209         (TestShell):
3210
3211 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3212
3213         Unreviewed, rolling out r146101.
3214         https://bugs.webkit.org/show_bug.cgi?id=111884
3215
3216         re-enable custom freetype on asan; this needs to be on
3217         now that the bot is running lucid.
3218
3219         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3220
3221 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3222
3223         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3224         https://bugs.webkit.org/show_bug.cgi?id=112365
3225
3226         Reviewed by Benjamin Poulain.
3227
3228         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3229         harcoding it in wtf/Platform.h
3230
3231         * Scripts/webkitperl/FeatureList.pm:
3232
3233 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3234
3235         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3236         https://bugs.webkit.org/show_bug.cgi?id=94782
3237
3238         Based on patch by Csaba Osztrogonác.
3239         Reviewed by Jocelyn Turcotte.
3240
3241         The diff image is generated with bright red indicating errors, but letting the base image
3242         shine through so the context of the error-pixel can be identified.
3243
3244         * DumpRenderTree/qt/ImageDiff.cpp:
3245         (main):
3246
3247 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3248
3249         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3250
3251         Rubber-stamped by Csaba Osztrogonác.
3252
3253         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3254         since the latter might not cover the former.
3255
3256         * QtTestBrowser/launcherwindow.cpp:
3257         (LauncherWindow::print):
3258
3259 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3260
3261         Style tweeks to default.css.
3262         
3263         Rubber-stamped by David Kilzer.
3264         
3265         Give visited links a different color to other links, so you can
3266         see which builds you've viewed.
3267         
3268         Make the <small> text less tiny.
3269
3270         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3271         (small):
3272         (a:link,a:visited,a:active):
3273         (a:visited):
3274
3275 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3276
3277         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3278         https://bugs.webkit.org/show_bug.cgi?id=112494
3279
3280         Reviewed by Dirk Pranke.
3281
3282         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3283         Also merged two pairs of methods to cleanup the code.
3284
3285         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3286         (PerfTestsRunner.run): Merged _upload_and_show_results.
3287         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3288
3289 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3290
3291         [chromium] build xdisplaycheck when building DRT
3292         https://bugs.webkit.org/show_bug.cgi?id=112636
3293
3294         Reviewed by Tony Chang.
3295
3296         It appears that we need xdisplaycheck to be built in order for
3297         Xvfb to be started correctly on the bots, and DRT was missing
3298         a dependency on it. This may be the cause of the ASAN bot not
3299         starting up properly (it only builds DRT).
3300
3301         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3302
3303 2013-03-18  David Levin  <levin@chromium.org>
3304
3305         Implement icon change notification dump for Chromium's test shell.
3306         https://bugs.webkit.org/show_bug.cgi?id=112614
3307
3308         This was previously implemented for some other platforms in r58111
3309         and r116547.
3310
3311         In r122806, fast/dom/icon-url-property.html stopped using it, but
3312         it is useful for tests, so I plan to re-add it to that test again.
3313
3314         Reviewed by Jochen Eisinger.
3315
3316         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3317         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3318          icon change notifications from WebKit may be logged in test output.
3319         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3320         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3321         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3322         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3323         (WebTestRunner):
3324         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3325         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3326         (TestRunner):
3327         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3328         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3329         (WebTestRunner):
3330         * DumpRenderTree/chromium/WebViewHost.cpp:
3331         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3332         * DumpRenderTree/chromium/WebViewHost.h:
3333         (WebViewHost):
3334
3335 2013-03-18  Julie Parent  <jparent@chromium.org>
3336
3337         Cleanup: Move js for treemap and aggregate_results into own js files.
3338         https://bugs.webkit.org/show_bug.cgi?id=112618
3339
3340         Reviewed by Dirk Pranke.
3341         
3342         No functional changes, just moving the code into separate js file
3343         rather than inlined in the html, so we can test it, make it more
3344         modular, etc.  Other dashboard types are already done this way.
3345
3346         * TestResultServer/static-dashboards/aggregate_results.html:
3347         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3348         (generatePage):
3349         (handleValidHashParameter):
3350         (htmlForBuilder):
3351         (rawValuesHTML):
3352         (chartHTML):
3353         (filteredValues):
3354         (chart):
3355         (htmlForRevisionRows):
3356         (wrapHTMLInTable):
3357         (htmlForSummaryTable):
3358         (valuesPerExpectation):
3359         (htmlForTestType):
3360         (htmlForTableRow):
3361         (extendedEncode):
3362         * TestResultServer/static-dashboards/treemap.html:
3363         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3364         (humanReadableTime):
3365         (convertToWebTreemapFormat):
3366         (reverseSortByAverage):
3367         (generatePage):
3368         (focusPath):
3369         (.switch.return):
3370         (handleQueryParameterChange):
3371         (extractName):
3372         (fullName):
3373         (handleFocus.):
3374         (handleFocus):
3375
3376 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3377
3378         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3379         https://bugs.webkit.org/show_bug.cgi?id=112622
3380
3381         Reviewed by Dirk Pranke.
3382
3383         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3384         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3385
3386 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3387
3388         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3389         https://bugs.webkit.org/show_bug.cgi?id=112619
3390
3391         Reviewed by Dirk Pranke.
3392
3393         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3394         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3395
3396         * Scripts/webkitpy/layout_tests/port/gtk.py:
3397         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3398         Port._webkit_baseline_path method.
3399         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3400         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3401         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3402         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3403         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3404         that are expected based on the builder name.
3405
3406 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3407
3408         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3409         https://bugs.webkit.org/show_bug.cgi?id=112571
3410
3411         Reviewed by Adam Barth.
3412
3413         Update function declarations for new WebFileSystemType enum. (All
3414         changes are behind an #ifdef so we can sync required changes in embedders.)
3415
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::openFileSystem):
3418         (WebViewHost::deleteFileSystem):
3419         * DumpRenderTree/chromium/WebViewHost.h:
3420         (WebViewHost):
3421
3422 2013-03-18  Julie Parent  <jparent@chromium.org>
3423
3424         Cleanup: Move timeline_exporer js out of html file into js.
3425         https://bugs.webkit.org/show_bug.cgi?id=112188
3426
3427         Reviewed by Dirk Pranke.
3428         
3429         Moves the javascript out of the html file and into a new js file.
3430         This follows the format of flakiness_dashboard.{html|js}.
3431         
3432         Also moves code from dashboard_base that is used only by this one
3433         dashboard, and makes it private to the dashboard.
3434
3435         * TestResultServer/static-dashboards/dashboard_base.js:
3436         * TestResultServer/static-dashboards/timeline_explorer.html:
3437         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3438         (generatePage):
3439         (initCurrentBuilderTestResults):
3440         (shouldShowWebKitRevisionsOnly):
3441         (updateTimelineForBuilder.):
3442         (updateTimelineForBuilder):
3443         (selectBuild):
3444         (updateBuildIndicator):
3445         (.addRow):
3446         (.addNumberRow):
3447         (.inspectorNode.getElementsByTagName.0.onclick):
3448         (.inspectorNode.getElementsByTagName.1.onclick):
3449         (.inspectorNode.getElementsByTagName.2.onclick):
3450         (updateBuildInspector):
3451         (showResultsDelta):
3452         (decompressResults.addFlakyDelta):
3453         (decompressResults):
3454
3455 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3456
3457         Unreviewed, rolling out r145272.
3458         http://trac.webkit.org/changeset/145272
3459         https://bugs.webkit.org/show_bug.cgi?id=111884
3460
3461         Turns out the ASAN build is still broken; possibly there's
3462         something still setting LD_LIBRARY_PATH, or possibly there's
3463         something else wrong. In the meantime, we need it to work again.
3464
3465         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3466
3467 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3468
3469         delete-stale-build-files is too aggressive
3470         https://bugs.webkit.org/show_bug.cgi?id=112595
3471
3472         Reviewed by Tim Horton.
3473
3474         It appears that whitelisting file extensions to keep is not a good idea.
3475         Blacklist files to delete instead, and only delete .o files for now.
3476         We can add more file extensions as needed.
3477
3478         * BuildSlaveSupport/delete-stale-build-files:
3479
3480 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3481
3482         Disable accessibility notifications after each test
3483         https://bugs.webkit.org/show_bug.cgi?id=112579
3484
3485         Reviewed by Tim Horton.
3486         
3487         In WebKitTestRunner, if any tests triggered accessibility notifications,
3488         the global notification handler would thereafter be active, and fire
3489         notifications for all subsequent tests.
3490         
3491         Fix by implementing AccessibilityController::resetToConsistentState() for
3492         Mac, and using it to clear the global notification handler.
3493
3494         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3495         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3496         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3497         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3498         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3499         (e.g. because of -autorelease).
3500         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3501         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3502         if there is one.
3503         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3504         Add -stopObserving
3505         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3506         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3507         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3508         center.
3509
3510 2013-03-18  Dana Jansens  <danakj@chromium.org>
3511
3512         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3513         https://bugs.webkit.org/show_bug.cgi?id=112392
3514
3515         Reviewed by James Robinson.
3516
3517         Removes the command line flag option from DRT.
3518
3519         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3520         (main):
3521
3522 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3523
3524         [GTK] plugins/plugin-clip-subframe.html is failing
3525         https://bugs.webkit.org/show_bug.cgi?id=112570
3526
3527         Reviewed by Martin Robinson.
3528
3529         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3530
3531 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3532
3533         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3534         https://bugs.webkit.org/show_bug.cgi?id=112442
3535
3536         Reviewed by Gustavo Noronha Silva.
3537
3538         * GtkLauncher/main.c:
3539         (reloadCb):
3540         (createToolbar):
3541         (createWindow):
3542
3543 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3544
3545         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3546         https://bugs.webkit.org/show_bug.cgi?id=112205
3547
3548         Disable this API test until Geoff can fix it.
3549
3550         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3551         (TestWebKitAPI::TEST):
3552
3553 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3554
3555         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3556         https://bugs.webkit.org/show_bug.cgi?id=112478
3557
3558         Reviewed by Tony Chang.
3559
3560         There is nothing that ensures that the log messages from the plugin
3561         come in before the layout test finished loading.
3562
3563         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3564         (PassDifferentNPPStruct::NPP_SetWindow):
3565         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3566         (NPP_SetWindow):
3567
3568 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3569
3570         Have the mac port support per_test_timeout in webkitpy
3571         https://bugs.webkit.org/show_bug.cgi?id=112466
3572
3573         Reviewed by Dirk Pranke.
3574         
3575         Both WTR and DRT handle --timeout arguments, so we can
3576         have the scripts pass the timeout values down to the tools.
3577
3578         * Scripts/webkitpy/layout_tests/port/mac.py:
3579         (MacPort.supports_per_test_timeout):
3580
3581 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3582
3583         Remove setAsynchronousSpellCheckingEnabled from test runners
3584         https://bugs.webkit.org/show_bug.cgi?id=112362
3585
3586         Reviewed by Tony Chang.
3587
3588         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3589         in internals.settings, so all ports can share it.
3590
3591         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3592         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3593         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3594         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3595         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3596         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3597         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3598         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3599         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3600         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3601         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3602         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3603
3604 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3605
3606         Fix the stupid unit tests.
3607
3608         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3609         (test_sample_process):
3610
3611 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3612
3613         Collect samples for unresponsive web processes
3614         https://bugs.webkit.org/show_bug.cgi?id=112409
3615
3616         Reviewed by Tim Horton.
3617         
3618         When we detect that a subprocess was unresponsive, run the 'sample'
3619         tool on that process, for the Mac port.
3620         
3621         The sample will be linked to from the results.html page, next
3622         to the crash log link.
3623
3624         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3625         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3626         look for samples on disk.
3627         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3628         (TestResultWriter):
3629         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3630         -sample.txt files, and have it copy their contents to a new file
3631         next to the test that spawned them (as we do for crash logs).
3632         * Scripts/webkitpy/layout_tests/port/base.py:
3633         (Port.look_for_new_samples): Base class does nothing for sampling.
3634         * Scripts/webkitpy/layout_tests/port/driver.py:
3635         (Driver._check_for_driver_crash): Kick off a sample if we detected
3636         that the subprocess was unresponsive.
3637         * Scripts/webkitpy/layout_tests/port/mac.py:
3638         (MacPort.sample_file_path): Utility to generate the file path
3639         to the generated sample files at the top level of layout-test-results.
3640         (MacPort.look_for_new_crash_logs): Fix typo
3641         (MacPort.look_for_new_samples): New function to find sample files.
3642         (MacPort.sample_process): Use the utility function to get the file path.
3643
3644 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3645
3646         [Qt] Remove simple getters and setters from TestRunnerQt</