Add myself to committers.py
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-28  Raymond Toy  <rtoy@google.com>
2
3         Add myself to committers.py
4         https://bugs.webkit.org/show_bug.cgi?id=107992
5
6         Reviewed by kbr@google.com.
7
8         * Scripts/webkitpy/common/config/committers.py:
9
10 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
11
12         [Mac] Update PageVisibilityState when WebView is hidden / visible
13         https://bugs.webkit.org/show_bug.cgi?id=107509
14
15         Reviewed by Sam Weinig.
16
17         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
18         automatically changes between hidden and visible as the view is added
19         and removed from window, or when it is in a window that changes
20         visibility, for instance by minimizing / deminimizing.
21
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
24         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
25         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
26         (runJavaScriptAlert):
27         (PageVisibilityStateWithWindowChanges):
28         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
29         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
30         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
31         (TestWebKitAPI::TEST_F):
32         Test visibility state of a page in a WebView/WKView with different window states.
33
34         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
35         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
36         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
37         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
38         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
39         Add a WK1 and WK2 teardownView to balance initializeView.
40
41 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
42
43         Improve PageVisibility API with enums
44         https://bugs.webkit.org/show_bug.cgi?id=107364
45
46         Reviewed by Sam Weinig.
47
48         * DumpRenderTree/mac/TestRunnerMac.mm:
49         (TestRunner::resetPageVisibility):
50         (TestRunner::setPageVisibility):
51         Update the WK1 test code to use the new WK1 enums.
52
53         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
54         (WTR::InjectedBundle::setVisibilityState):
55         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
56         (InjectedBundle):
57         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
58         (WTR::TestRunner::setPageVisibility):
59         (WTR::TestRunner::resetPageVisibility):
60         * WebKitTestRunner/TestController.cpp:
61         (WTR::TestController::setVisibilityState):
62         * WebKitTestRunner/TestController.h:
63         (TestController):
64         * WebKitTestRunner/TestInvocation.cpp:
65         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
66         Update the WK2 test code to use the new WK2 API and enums.
67
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
70         (TestWebKitAPI):
71         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
72         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
73         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
74         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
75         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
76         (TestWebKitAPI::didRunStep4InStatePreview):
77         (TestWebKitAPI::TEST):
78         Test the new WK2 API with all enum types.
79
80 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
81
82         [chromium] remove temporary define used for updating TestRunner API
83
84         Unreviewed. Clean-up change.
85
86         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
87
88 2013-01-28  James Craig  <james@cookiecrook.com>
89
90         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
91         https://bugs.webkit.org/show_bug.cgi?id=107650
92
93         Reviewed by Chris Fleizach.
94
95         Updating accessibility strings and accessors for DL/DT/DD.
96
97         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
98         (createDescriptionList):
99         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
100         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
101
102 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
103
104         [GTK][WTR] Update layoutTestController.pathToLocalResource
105         https://bugs.webkit.org/show_bug.cgi?id=107538
106
107         Reviewed by Martin Robinson.
108
109         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
110         (WTR::TestRunner::pathToLocalResource): Update implementation based on
111         DRT code.
112
113 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
114
115         [GTK][WTR] Move getTopLevelPath() to utilities file
116         https://bugs.webkit.org/show_bug.cgi?id=107541
117
118         Reviewed by Martin Robinson.
119
120         * WebKitTestRunner/GNUmakefile.am: Add new files.
121         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
122         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
123         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
124         (WTR):
125         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
126         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
127         (WTR): Add new method header and documentation.
128
129 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
130
131         [EFL] Include Ecore_Getopt.h in MiniBrowser.
132         https://bugs.webkit.org/show_bug.cgi?id=108067
133
134         Reviewed by Kenneth Rohde Christiansen.
135
136         Be explicit and include Ecore_Getopt.h since we use it for parsing
137         command line options. It is safer than relying on other headers
138         including it for us.
139
140         * MiniBrowser/efl/main.c:
141
142 2013-01-28  Renata Hodovan  <reni@webkit.org>
143
144         [WK2] Putting QtWebProcess into a chrooted sandbox
145         https://bugs.webkit.org/show_bug.cgi?id=90005
146
147         Reviewed by Anders Carlsson and  Zoltan Herczeg.
148
149         Add feature flag for suid sandbox in linux.
150
151         * Scripts/webkitperl/FeatureList.pm:
152
153 2013-01-27  David Farler  <dfarler@apple.com>
154
155         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
156         https://bugs.webkit.org/show_bug.cgi?id=108028
157
158         Reviewed by Dan Bernstein.
159
160         * DumpRenderTree/Makefile: Reverted.
161         * Makefile: Reverted.
162         * Scripts/webkitdirs.pm: Reverted.
163
164 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
165
166         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
167         https://bugs.webkit.org/show_bug.cgi?id=106740
168
169         Reviewed by Benjamin Poulain.
170
171         * DumpRenderTree/config.h:
172         * WinLauncher/stdafx.h:
173
174 2013-01-26  David Farler  <dfarler@apple.com>
175
176         Makefiles should work for arbitrary SDKs and architectures on Apple ports
177         https://bugs.webkit.org/show_bug.cgi?id=107863
178
179         Reviewed by David Kilzer.
180
181         * Makefile:
182         Added temporary filters for projects not yet building on iOS.
183         * DumpRenderTree/Makefile:
184         Building with iOS SDKs -> -target All-iOS
185         * Scripts/webkitdirs.pm:
186         (determineConfiguration):
187         Added --configuration switch detection.
188         (determineArchitecture):
189         Added --architecture and ARCH=(.*) switch detection.
190         (argumentsForConfiguration):
191         (determineXcodeSDK):
192         Look for --device, --simulator, and --sdk switches.
193         (xcodeSDK):
194         Added.
195         (XcodeOptions):
196         Determine Xcode SDK and generate -arch switches.
197
198 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
199
200         [chromium] move tracking of the top loading frame to TestRunner library
201         https://bugs.webkit.org/show_bug.cgi?id=107948
202
203         Reviewed by Adam Barth.
204
205         * DumpRenderTree/chromium/DRTTestRunner.cpp:
206         (DRTTestRunner::WorkQueue::processWorkSoon):
207         (DRTTestRunner::WorkQueue::processWork):
208         (DRTTestRunner::completeNotifyDone):
209         * DumpRenderTree/chromium/DRTTestRunner.h:
210         (DRTTestRunner):
211         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
212         (WebTestProxyBase):
213         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
214         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
215         (WebTestRunner::WebTestRunner::topLoadingFrame):
216         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
217         (WebTestRunner::TestRunner::TestRunner):
218         (WebTestRunner::TestRunner::reset):
219         (WebTestRunner::TestRunner::setTopLoadingFrame):
220         (WebTestRunner):
221         (WebTestRunner::TestRunner::topLoadingFrame):
222         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
223         (TestRunner):
224         (WebTestRunner::TestRunner::locationChangeDone):
225         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
226         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
227         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
228         (WebTestRunner::WebTestProxyBase::didFailLoad):
229         (WebTestRunner::WebTestProxyBase::didFinishLoad):
230         (WebTestRunner::WebTestProxyBase::locationChangeDone):
231         (WebTestRunner):
232         * DumpRenderTree/chromium/WebViewHost.cpp:
233         (WebViewHost::reset):
234         (WebViewHost::updateURL):
235         * DumpRenderTree/chromium/WebViewHost.h:
236         (WebViewHost):
237
238 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
239
240         Unreviewed, rolling out r140774.
241         http://trac.webkit.org/changeset/140774
242         https://bugs.webkit.org/show_bug.cgi?id=107932
243
244          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
245         and fastScrollingForFixedPosition are failing (Requested by
246         keishi on #webkit).
247
248         * DumpRenderTree/chromium/WebViewHost.cpp:
249         (WebViewHost::initializeLayerTreeView):
250         (WebViewHost::setWebWidget):
251
252 2013-01-25  Alan Cutter  <alancutter@chromium.org>
253
254         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
255         https://bugs.webkit.org/show_bug.cgi?id=107905
256
257         Reviewed by Eric Seidel.
258
259         Added line to EWS loop to clear /tmp of known Chromium test leak.
260         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
261
262         * EWSTools/start-queue.sh:
263
264 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
265
266         Update Anne's email address
267         https://bugs.webkit.org/show_bug.cgi?id=107866
268
269         Reviewed by Adam Barth.
270
271         * Scripts/webkitpy/common/config/committers.py:
272
273 2013-01-24  Alan Cutter  <alancutter@chromium.org>
274
275         HTTP 500 error between QueueStatusServer and bot(s)
276         https://bugs.webkit.org/show_bug.cgi?id=107184
277
278         Reviewed by Adam Barth.
279
280         Removed the use of memcache which was the source of the exception.
281
282         * QueueStatusServer/handlers/updatestatus.py:
283         (UpdateStatus.post):
284         * QueueStatusServer/model/attachment.py:
285         (Attachment):
286         (Attachment.summary):
287
288 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
289
290         Unreviewed, rolling out r140653.
291         http://trac.webkit.org/changeset/140653
292         https://bugs.webkit.org/show_bug.cgi?id=107916
293
294         Causes a temp file leak on the bots (Requested by abarth on
295         #webkit).
296
297         * DumpRenderTree/chromium/TestShell.cpp:
298         (TestShell::resetTestController):
299
300 2013-01-24  Eric Seidel  <eric@webkit.org>
301
302         Skip haslanded_unittest.py on systems which do not have interdiff installed
303         https://bugs.webkit.org/show_bug.cgi?id=106402
304
305         Unreviewed.
306
307         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
308         (HasLandedTest):
309
310 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
311
312         Disable the failing webkitpy test for now.
313
314         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
315
316 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
317
318         Fixing the diff_parser to correctly identify git diffs even with leading comments.
319         https://bugs.webkit.org/show_bug.cgi?id=107871
320
321         Reviewed by Eric Seidel.
322
323         * Scripts/webkitpy/common/checkout/diff_parser.py:
324         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
325         * Scripts/webkitpy/tool/steps/haslanded.py:
326
327 2013-01-24  James Robinson  <jamesr@chromium.org>
328
329         [chromium] Remove dead transitional code from WebViewImpl
330         https://bugs.webkit.org/show_bug.cgi?id=107889
331
332         Reviewed by Adrienne Walker.
333
334         * DumpRenderTree/chromium/WebViewHost.cpp:
335         (WebViewHost::initializeLayerTreeView):
336         (WebViewHost::setWebWidget):
337
338 2013-01-24  Joshua Bell  <jsbell@chromium.org>
339
340         Add watchlist for IndexedDB development, and add myself and others.
341
342         Unreviewed.
343
344         * Scripts/webkitpy/common/config/watchlist:
345
346 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
347
348         Abstract the logic for appending a UChar32 onto StringBuilder
349         https://bugs.webkit.org/show_bug.cgi?id=107505
350
351         Reviewed by Darin Adler.
352
353         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
354         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
355
356 2013-01-24  Erik Arvidsson  <arv@chromium.org>
357
358         Unreviewed, rolling out r140703.
359         http://trac.webkit.org/changeset/140703
360         https://bugs.webkit.org/show_bug.cgi?id=107556
361
362         r140561 was not the reason for the Android breakage
363
364         * DumpRenderTree/chromium/TestShell.cpp:
365         (TestShell::~TestShell):
366         (TestShell::closeWindow):
367         * DumpRenderTree/chromium/WebViewHost.cpp:
368         (WebViewHost::WebViewHost):
369         (WebViewHost::~WebViewHost):
370         (WebViewHost::shutdown):
371         * DumpRenderTree/chromium/WebViewHost.h:
372         (WebViewHost):
373
374 2013-01-24  Dean Jackson  <dino@apple.com>
375
376         Allow some plugin snapshot UI content to come from Injected Bundle
377         https://bugs.webkit.org/show_bug.cgi?id=107852
378
379         Reviewed by Anders Carlsson.
380
381         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
382         plugInExtraStyleSheet.
383
384         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
385         (WTR::InjectedBundlePage::InjectedBundlePage):
386
387 2013-01-24  Erik Arvidsson  <arv@chromium.org>
388
389         Unreviewed, rolling out r140561.
390         http://trac.webkit.org/changeset/140561
391         https://bugs.webkit.org/show_bug.cgi?id=107556
392
393         Suspected to break Android which prevens WebKit roll
394
395         * DumpRenderTree/chromium/TestShell.cpp:
396         (TestShell::~TestShell):
397         (TestShell::closeWindow):
398         * DumpRenderTree/chromium/WebViewHost.cpp:
399         (WebViewHost::WebViewHost):
400         (WebViewHost::~WebViewHost):
401         * DumpRenderTree/chromium/WebViewHost.h:
402         (WebViewHost):
403
404 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
405
406         Adding "has-landed" command to webkit-patch which compares a
407         committed patch to the changes which exist locally (ignoring the
408         ChangeLog file).
409
410         https://bugs.webkit.org/show_bug.cgi?id=106402
411
412         Reviewed by Eric Seidel.
413
414         * Scripts/webkitpy/common/checkout/diff_parser.py:
415         (git_diff_to_svn_diff):
416         * Scripts/webkitpy/common/net/bugzilla/bug.py:
417         (Bug.commit_revision):
418         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
419         (BugTest.test_is_in_comments):
420         (BugTest):
421         (BugTest.test_commit_revision):
422         * Scripts/webkitpy/tool/commands/upload.py:
423         (HasLanded):
424         * Scripts/webkitpy/tool/steps/__init__.py:
425         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
426         (HasLanded):
427         (HasLanded.convert_to_svn):
428         (HasLanded.strip_change_log):
429         (run):
430
431         * Scripts/webkitpy/common/net/bugzilla/bug.py:
432         (Bug.commit_revision):
433         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
434         (BugTest.test_is_in_comments):
435         (BugTest):
436         (BugTest.test_commit_revision):
437         * Scripts/webkitpy/tool/commands/upload.py:
438         (HasLanded):
439         * Scripts/webkitpy/tool/steps/__init__.py:
440         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
441         (HasLanded):
442         (HasLanded.convert_to_svn):
443         (HasLanded.strip_change_log):
444         (HasLanded.diff_diff):
445         (HasLanded.run):
446         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
447         (HasLandedTest):
448         (HasLandedTest.test_run):
449         (test_convert_to_svn_and_strip_change_log):
450
451 2013-01-24  Dan Carney  <dcarney@google.com>
452
453         [chromium] move most WebViewHost printf calls to WebTestProxy
454         https://bugs.webkit.org/show_bug.cgi?id=107553
455
456         Reviewed by Jochen Eisinger.
457
458         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
459         (WebKit):
460         (WebTestProxyBase):
461         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
462         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
463         (WebTestRunner::WebTestProxy::runModalAlertDialog):
464         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
465         (WebTestRunner::WebTestProxy::runModalPromptDialog):
466         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
467         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
468         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
469         (WebTestRunner::WebTestProxyBase::reset):
470         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
471         (WebTestRunner):
472         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
473         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
474         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
475         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
476         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
477         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
478         * DumpRenderTree/chromium/TestShell.cpp:
479         (TestShell::showDevTools):
480         * DumpRenderTree/chromium/WebViewHost.cpp:
481         (WebViewHost::didAddMessageToConsole):
482         (WebViewHost::runModalAlertDialog):
483         (WebViewHost::runModalConfirmDialog):
484         (WebViewHost::runModalPromptDialog):
485         (WebViewHost::runModalBeforeUnloadDialog):
486         (WebViewHost::unableToImplementPolicyWithError):
487         (WebViewHost::reset):
488         * DumpRenderTree/chromium/WebViewHost.h:
489         (WebViewHost):
490
491 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
492
493         [Chromium] Give webkit_support a chance to reset state between layout test runs
494         https://bugs.webkit.org/show_bug.cgi?id=107132
495
496         Reviewed by Adam Barth.
497
498         We currently only have need for this on OS(ANDROID), but now it
499         would be useful to have a hook for resetting state on all
500         platforms. Will soon be using this for IDBFactory initialization.
501
502         * DumpRenderTree/chromium/TestShell.cpp:
503         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
504
505 2013-01-23  Alan Cutter  <alancutter@chromium.org>
506
507         QueueStatusServer crashes in production on next-patch
508         https://bugs.webkit.org/show_bug.cgi?id=107775
509
510         Reviewed by Adam Barth.
511
512         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
513
514         * QueueStatusServer/app.yaml:
515         * QueueStatusServer/model/patchlog.py:
516         (PatchLog.calculate_wait_duration):
517         (PatchLog.calculate_process_duration):
518         (PatchLog):
519         (PatchLog._time_delta_to_seconds):
520
521 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
522
523         The previous patch wasn't complete. Finish reverting r139998 for real.
524
525         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
526         (ProfilerAgent.getProfile):
527
528 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
529
530         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
531
532         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
533         (ProfilerAgent.getProfile):
534
535 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
536
537         [Chromium] Remove unused header files in chromium/public/platform/
538         https://bugs.webkit.org/show_bug.cgi?id=107741
539
540         Reviewed by James Robinson.
541
542         These header files have migrated to the new Platform directory.
543         This patch updates the remaining #include references and removes
544         the old files that did nothing but redirect to the new ones.
545
546         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
547         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
548
549 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
550
551         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
552         https://bugs.webkit.org/show_bug.cgi?id=107727
553
554         Reviewed by Gustavo Noronha Silva.
555
556         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
557         We are using the git repository now that github has deprecated the downloads feature.
558
559 2013-01-23  Tony Chang  <tony@chromium.org>
560
561         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
562
563         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
564         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
565         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
566         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
567
568 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
569
570         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
571         https://bugs.webkit.org/show_bug.cgi?id=107145
572
573         Reviewed by Adam Barth.
574
575         Part of a larger refactoring series; see tracking bug 82948.
576         
577         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
578         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
579         * DumpRenderTree/chromium/DRTDevToolsClient.h:
580         * DumpRenderTree/chromium/DRTTestRunner.cpp:
581         * DumpRenderTree/chromium/DRTTestRunner.h:
582         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
583         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
584         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
585         * DumpRenderTree/chromium/NotificationPresenter.cpp:
586         * DumpRenderTree/chromium/TestNavigationController.h:
587         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
588         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
589         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
590         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
591         (WebTestRunner):
592         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
593         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
594         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
595         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
596         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
597         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
598         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
599         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
600         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
601         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
602         * DumpRenderTree/chromium/TestShell.cpp:
603         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
604         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
605         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
606         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
607         * DumpRenderTree/chromium/WebViewHost.cpp:
608
609 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
610
611         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
612         https://bugs.webkit.org/show_bug.cgi?id=107556
613
614         Reviewed by Tony Chang.
615
616         WebViewHost initiates a navigation to about:blank in its destructor.
617         However, since WebTestProxy inherits from WebViewHost, at this point
618         the WebViewClient and WebFrameClient interfaces are already partially
619         destructed resulting in the use after free.
620
621         This does not affect the chromium implementation since it doesn't
622         invoke WebKit API methods in its destructor.
623
624         * DumpRenderTree/chromium/TestShell.cpp:
625         (TestShell::~TestShell):
626         (TestShell::closeWindow):
627         * DumpRenderTree/chromium/WebViewHost.cpp:
628         (WebViewHost::WebViewHost):
629         (WebViewHost::~WebViewHost):
630         (WebViewHost::shutdown):
631         * DumpRenderTree/chromium/WebViewHost.h:
632         (WebViewHost):
633
634 2013-01-23  Andrei Bucur  <abucur@adobe.com>
635
636         [CSS Regions] Create Regions watchlist
637         https://bugs.webkit.org/show_bug.cgi?id=107281
638
639         Reviewed by Adam Barth.
640
641         This patch adds 4 new definitions:
642         - RegionsDevelopment - used to track the development progress for regions
643         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
644         - RegionsUsage - used to track changes that make use of regions in all the code base
645
646         For now, the Adobe internal tracker is the only email address listening for these patterns.
647
648         * Scripts/webkitpy/common/config/watchlist:
649
650 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
651
652         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
653         https://bugs.webkit.org/show_bug.cgi?id=107523
654
655         Reviewed by Yury Semikhatsky.
656
657         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
658         (DRTDevToolsClient::isUnderTest):
659         (DRTDevToolsClient::call):
660         * DumpRenderTree/chromium/DRTDevToolsClient.h:
661         (DRTDevToolsClient):
662
663 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
664
665         Removing command line shortening as it makes it difficult to see the command during errors.
666         https://bugs.webkit.org/show_bug.cgi?id=107643
667
668         Reviewed by Eric Seidel.
669
670         * Scripts/webkitpy/common/system/executive.py:
671         (ScriptError):
672         (ScriptError.__init__):
673         * Scripts/webkitpy/common/system/executive_unittest.py:
674
675 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
676
677         Adding myself as contributor in committers.py (as requested by eseidel).
678         https://bugs.webkit.org/show_bug.cgi?id=107647
679
680         Reviewed by Eric Seidel.
681
682         * Scripts/webkitpy/common/config/committers.py:
683
684 2013-01-22  Alan Cutter  <alancutter@chromium.org>
685
686         Add monitoring of patches and queues to the QueueStatusServer
687         https://bugs.webkit.org/show_bug.cgi?id=107612
688
689         Reviewed by Adam Barth.
690
691         Created classes for recording events into the datastore and integrated them into the existing handlers.
692         Code for presenting the recorded data will come in a separate patch.
693
694         * QueueStatusServer/app.yaml:
695         * QueueStatusServer/config/__init__.py: Added.
696         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
697         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
698         * QueueStatusServer/handlers/nextpatch.py:
699         (NextPatch.get):
700         (NextPatch._assign_patch):
701         * QueueStatusServer/handlers/releasepatch.py:
702         (ReleasePatch.post):
703         * QueueStatusServer/handlers/updatestatus.py:
704         (UpdateStatus.post):
705         * QueueStatusServer/handlers/updateworkitems.py:
706         (UpdateWorkItems._parse_work_items_string):
707         (UpdateWorkItems):
708         (UpdateWorkItems._update_work_items_from_request):
709         (UpdateWorkItems._queue_from_request):
710         (UpdateWorkItems.post):
711         * QueueStatusServer/loggers/__init__.py: Added.
712         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
713         (RecordBotEvent):
714         (RecordBotEvent.activity):
715         * QueueStatusServer/loggers/recordpatchevent.py: Added.
716         (RecordPatchEvent):
717         (RecordPatchEvent.added):
718         (RecordPatchEvent.retrying):
719         (RecordPatchEvent.started):
720         (RecordPatchEvent.stopped):
721         (RecordPatchEvent.updated):
722         (RecordPatchEvent._get_patches_waiting):
723         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
724         (PatchLog):
725         (PatchLog.lookup):
726         (PatchLog.calculate_wait_duration):
727         (PatchLog.calculate_process_duration):
728         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
729         (QueueLog):
730         (QueueLog.get_current):
731         (QueueLog.create_key):
732         * QueueStatusServer/model/queuestatus.py:
733         (QueueStatus.is_retry_request):
734
735 2013-01-22  Timothy Loh  <timloh@chromium.com>
736
737         prepare-Changelog should support updating the list of changed files
738         https://bugs.webkit.org/show_bug.cgi?id=74358
739
740         Reviewed by Eric Seidel.
741
742         Needing to re-make ChangeLog entries when the list of files/functions
743         changes is a bit annoying, it'd be nice to have this more automated.
744         This patch makes `webkit-patch update' update the date line and bug
745         description if needed, and if the list of changed files/functions has
746         changed, either updates the list (if there are no annotations), or
747         otherwise appends the new list below.
748
749         * Scripts/webkitpy/tool/steps/preparechangelog.py:
750         (PrepareChangeLog._resolve_existing_entry):
751         (PrepareChangeLog):
752         (PrepareChangeLog._merge_entries):
753         (PrepareChangeLog.run):
754         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
755         (PrepareChangeLogTest.test_resolve_existing_entry):
756         (make_entry):
757         (test_ensure_bug_url):
758
759 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
760
761         Use Python 2.7 unittest syntax in our unittests
762         https://bugs.webkit.org/show_bug.cgi?id=105607
763
764         Reviewed by Eric Seidel.
765
766         * Scripts/webkitpy/**/*_unittest.py:
767
768 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
769
770         Convert disable-msg to disable for new pylint.
771         https://bugs.webkit.org/show_bug.cgi?id=107627
772
773         Reviewed by Eric Seidel.
774
775         * Scripts/webkitpy/common/checkout/scm/svn.py:
776         (SVNRepository.has_authorization_for_realm):
777         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
778         (Builder.force_build):
779         * Scripts/webkitpy/common/system/executive_mock.py:
780         (MockExecutive2.run_command):
781         * Scripts/webkitpy/layout_tests/port/base.py:
782         (Port.reference_files):
783         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
784         (ChromiumPortTestCase.test_default_configuration):
785         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
786         (PortTestCase.test_expectations_ordering):
787         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
788         (HttpServerBase._check_that_all_ports_are_available):
789         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
790         (AbstractLocalServerCommand.execute):
791         * Scripts/webkitpy/tool/commands/download.py:
792         (AbstractPatchProcessingCommand):
793         * Scripts/webkitpy/tool/commands/rebaseline.py:
794         (AbstractRebaseliningCommand):
795         (AbstractParallelRebaselineCommand):
796         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
797         (_BaseTestCase.setUp):
798         (TestAnalyzeBaselines.setUp):
799
800 2013-01-22  Frank Farzan  <frankf@chromium.org>
801
802         Flakiness dashboard: update builders.jsonp
803         https://bugs.webkit.org/show_bug.cgi?id=107610
804
805         Reviewed by Ojan Vafai.
806
807         * TestResultServer/static-dashboards/builders.jsonp:
808
809 2013-01-22  Frank Farzan  <frankf@chromium.org>
810
811         Add Android instrumentation tests from ChromiumLinux waterfall
812         https://bugs.webkit.org/show_bug.cgi?id=107597
813
814         Reviewed by Ojan Vafai.
815
816         * TestResultServer/static-dashboards/builders.js:
817         (loadBuildersList):
818
819 2013-01-21  Kentaro Hara  <haraken@chromium.org>
820
821         Implement UIEvent constructor
822         https://bugs.webkit.org/show_bug.cgi?id=107430
823
824         Reviewed by Adam Barth.
825
826         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
827
828         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
829         which is enabled on Safari and Chromium for now.
830
831         * Scripts/webkitperl/FeatureList.pm:
832
833 2013-01-22  Timothy Loh  <timloh@chromium.com>
834
835         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
836         https://bugs.webkit.org/show_bug.cgi?id=107478
837
838         Reviewed by Eric Seidel.
839
840         On the road to resolving Bug 74358, we need a few more functions in
841         changelog.py.
842         To make things easier to mock, change @staticmethods to @classmethods.
843
844         * Scripts/webkitpy/common/checkout/changelog.py:
845         (ChangeLogEntry):
846         (ChangeLogEntry._parse_reviewer_text):
847         (ChangeLogEntry._split_contributor_names):
848         (ChangeLogEntry._parse_author_name_and_email):
849         (ChangeLogEntry._parse_author_text):
850         (ChangeLogEntry._parse_touched_functions):
851         (ChangeLogEntry._parse_bug_description):
852         (ChangeLogEntry._parse_entry):
853         (ChangeLogEntry.date_line):
854         (ChangeLogEntry.bug_description):
855         (ChangeLogEntry.touched_functions):
856         (ChangeLogEntry.touched_files_text):
857         (ChangeLogEntry.is_touched_files_text_clean):
858         (ChangeLog):
859         (ChangeLog.parse_latest_entry_from_file):
860         (ChangeLog._separate_revision_and_line):
861         (ChangeLog.parse_entries_from_file):
862         (ChangeLog.set_short_description_and_bug_url):
863         (ChangeLog.delete_entries):
864         (ChangeLog.prepend_text):
865         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
866         (test_parse_log_entries_from_changelog):
867         (test_latest_entry_parse):
868         (test_set_short_description_and_bug_url):
869         (test_delete_entries):
870         (test_prepend_text):
871
872 2013-01-22  Lucas Forschler  <lforschler@apple.com>
873
874         Create a MAC EWS startup shell script.
875
876         Reviewed by Ryosuke Niwa.
877
878         * EWSTools/start-queue-mac.sh: Added.
879
880 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
881
882         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
883         https://bugs.webkit.org/show_bug.cgi?id=107230
884
885         Reviewed by David Kilzer.
886
887         * DumpRenderTree/mac/TestRunnerMac.mm:
888         (TestRunner::resetPageVisibility):
889         Fix a typo in the original implementation. resetPageVisibility should
890         pass initialState YES so an event is not dispatched, which causes
891         issues in multiple tests. This now matches other ports.
892
893 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
894
895         [GTK] Enable CSS Image Orientation feature
896         https://bugs.webkit.org/show_bug.cgi?id=99040
897
898         Reviewed by Martin Robinson.
899
900         Enable the CSS Image Orientation feature in the development
901         builds of the GTK port. The feature is still disabled in the release
902         builds.
903
904         * Scripts/webkitperl/FeatureList.pm:
905
906 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
907
908         [GTK] Enable the <template> element support in development builds
909         https://bugs.webkit.org/show_bug.cgi?id=106575
910
911         Reviewed by Martin Robinson.
912
913         Enable the <template> element support in the development builds of the GTK port.
914
915         * Scripts/webkitperl/FeatureList.pm:
916
917 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
918
919         Prettify the output of the override-feature-defines script
920         https://bugs.webkit.org/show_bug.cgi?id=106542
921
922         Reviewed by Martin Robinson.
923
924         The output now clearly lists the feature defines being overridden
925         along with the default and overriding values for each feature define.
926
927         * gtk/override-feature-defines:
928         (adjust_feature_defines_makefile):
929         (adjust_feature_defines_makefile.override_feature_define):
930
931 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
932
933         Remove uses of deprecated unittest.TestCase aliases
934         https://bugs.webkit.org/show_bug.cgi?id=102252
935
936         Reviewed by Adam Barth.
937
938         Replace the deprecated assertEquals method of the TestCase interface
939         used in some webkitpy unittests with the assertEqual method.
940
941         * Scripts/webkitpy/common/system/profiler_unittest.py:
942         (ProfilerFactoryTest._assert_default_profiler_name):
943         (ProfilerFactoryTest.test_default_profiler_output):
944         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
945         (GtkPortTest.test_expectations_files):
946         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
947         (TestHttpServer.test_win32_start_and_stop):
948
949 2013-01-22  Jer Noble  <jer.noble@apple.com>
950
951         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
952         https://bugs.webkit.org/show_bug.cgi?id=107562
953
954         Rubber-stamped by Alexy Proskuryakov.
955
956         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
957
958         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
959         (WTR::PlatformWebView::PlatformWebView):
960         (WTR::PlatformWebView::viewSupportsOptions):
961
962 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
963
964         One is not allowed to use commit-queue to make oneself a committer.
965
966         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
967
968 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
969
970         Add myself to commiters.py
971         https://bugs.webkit.org/show_bug.cgi?id=107546
972
973         Reviewed by Kentaro Hara.
974
975         * Scripts/webkitpy/common/config/committers.py:
976
977 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
978
979         [GTK] Implement TestRunner::setTextDirection
980         https://bugs.webkit.org/show_bug.cgi?id=107131
981
982         Reviewed by Philippe Normand.
983
984         * DumpRenderTree/gtk/DumpRenderTree.cpp:
985         (resetDefaultsToConsistentValues): Reset direction to default value.
986         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
987         (TestRunner::setTextDirection): Implement method using
988         gtk_widget_set_direction.
989
990 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
991
992         [chromium] move spell checking mocks to TestRunner library
993         https://bugs.webkit.org/show_bug.cgi?id=107455
994
995         Reviewed by Kent Tamura.
996
997         The content module doesn't provide its own WebSpellCheckClient.
998
999         * DumpRenderTree/DumpRenderTree.gypi:
1000         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1001         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
1002         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1003         (WebKit):
1004         (WebTestRunner):
1005         (WebTestProxyBase):
1006         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1007         (WebTestRunner):
1008         (WebTestRunner::makeMenuItemStringsFor):
1009         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
1010         (MockGrammarCheck::checkGrammarOfString):
1011         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
1012         (WebKit):
1013         (MockGrammarCheck):
1014         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
1015         (MockSpellCheck::MockSpellCheck):
1016         (MockSpellCheck::~MockSpellCheck):
1017         (isNotASCIIAlpha):
1018         (MockSpellCheck::spellCheckWord):
1019         (MockSpellCheck::fillSuggestionList):
1020         (MockSpellCheck::initializeIfNeeded):
1021         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
1022         (MockSpellCheck):
1023         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
1024         (WebTestRunner::SpellCheckClient::SpellCheckClient):
1025         (WebTestRunner):
1026         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
1027         (WebTestRunner::SpellCheckClient::setDelegate):
1028         (WebTestRunner::SpellCheckClient::spellCheck):
1029         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
1030         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
1031         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
1032         (WebTestRunner::SpellCheckClient::autoCorrectWord):
1033         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
1034         (WebTestRunner):
1035         (SpellCheckClient):
1036         (WebTestRunner::SpellCheckClient::taskList):
1037         (WebTestRunner::SpellCheckClient::mockSpellCheck):
1038         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1039         (TestDelegate):
1040         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1041         (WebTestInterfaces::Internal):
1042         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1043         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1044         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1045         (WebTestRunner::WebTestProxyBase::setDelegate):
1046         (WebTestRunner::WebTestProxyBase::spellCheckClient):
1047         (WebTestRunner):
1048         * DumpRenderTree/chromium/WebViewHost.cpp:
1049         (WebViewHost::WebViewHost):
1050         (WebViewHost::setWebWidget):
1051         * DumpRenderTree/chromium/WebViewHost.h:
1052         (WebViewHost):
1053
1054 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
1055
1056         [EFL] Adds Accessibility support to wk1
1057         https://bugs.webkit.org/show_bug.cgi?id=107440
1058
1059         Reviewed by Gyuyoung Kim.
1060
1061         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
1062
1063 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
1064
1065         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
1066         https://bugs.webkit.org/show_bug.cgi?id=107506
1067
1068         Reviewed by Dan Bernstein.
1069
1070         * MiniBrowser/mac/WK1BrowserWindowController.m:
1071         (-[WK1BrowserWindowController dealloc]):
1072
1073 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
1074
1075         Add build flag for Canvas's Path object (disabled by default)
1076         https://bugs.webkit.org/show_bug.cgi?id=107473
1077
1078         Reviewed by Dean Jackson.
1079
1080         Add CANVAS_PATH build flag to build systems.
1081
1082         * Scripts/webkitperl/FeatureList.pm:
1083
1084 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
1085
1086         [EFL][WK2] Add APIs to set/get view source mode
1087         https://bugs.webkit.org/show_bug.cgi?id=106633
1088
1089         Reviewed by Gyuyoung Kim.
1090
1091         Added a shotcut 'F8' in Minibrowser to display a source code
1092         of the web page in a new window.
1093
1094        * MiniBrowser/efl/main.c:
1095         (on_key_down):
1096         (on_window_create):
1097         (window_create):
1098         (elm_main):
1099
1100 2013-01-21  Nico Weber  <thakis@chromium.org>
1101
1102         [chromium] Don't archive generated source files.
1103         https://bugs.webkit.org/show_bug.cgi?id=106736
1104
1105         Reviewed by Eric Seidel.
1106
1107         They shouldn't be needed to run tests. They don't need a lot of space,
1108         but add many lines to the "extracting" stdout. This attempts to reduce
1109         that noise a bit.
1110
1111         * BuildSlaveSupport/built-product-archive:
1112         (archiveBuiltProduct):
1113
1114 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
1115
1116         Mac DumpRenderTree's installSignalHandlers() is unreachable code
1117         https://bugs.webkit.org/show_bug.cgi?id=107383
1118
1119         Reviewed by Sam Weinig.
1120
1121         The CrashHandler of DumpRenderTree were originally used for restoring
1122         the color profile of the main display even if DRT crashes.
1123
1124         That feature was later limited to pixel tests only in r29999.
1125
1126         In r104351, the DRT was changed to use device color space. Making the crash
1127         handlers useless, but they were left in the code since the error reporting
1128         code was still reachable.
1129
1130         Later, r124581 refactored the code and dumpPixelsForCurrentTest
1131         is being used before being assigned its value.
1132         This did cause any regression because the code had become useless with the previous change.
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         Remove crashHandler() and installSignalHandlers() as they have become useless and
1136         have been unreachable code for 6 months.
1137         (dumpRenderTree):
1138         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
1139         at those points.
1140
1141 2013-01-21  Nico Weber  <thakis@chromium.org>
1142
1143         Make ninja the default build system for build-webkit --chromium on mac
1144         https://bugs.webkit.org/show_bug.cgi?id=106737
1145
1146         Reviewed by Eric Seidel.
1147
1148         * Scripts/update-webkit-chromium:
1149
1150 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1151
1152         Regression(r140262): Causes a lot of flakiness
1153         https://bugs.webkit.org/show_bug.cgi?id=107454
1154
1155         Reviewed by Alexey Proskuryakov.
1156
1157         r140262 introduced a lot of flakiness due to fixed layout mode
1158         not getting disabled on the view after being enabled for
1159         specific test cases. This patch makes sure fixed layout mode
1160         properly gets reset in WebKitTestRunner to avoid flakiness.
1161
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::updateLayoutType):
1164
1165 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
1166
1167         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
1168         https://bugs.webkit.org/show_bug.cgi?id=107421
1169
1170         Unreviewed build fix.
1171
1172         * Scripts/run-gtk-tests:
1173         (TestRunner): skip Resource tests.
1174
1175 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1176
1177         [EFL][WKTR] platformRunUntil() should keep the main loop running
1178         https://bugs.webkit.org/show_bug.cgi?id=107442
1179
1180         Reviewed by Noam Rosenthal.
1181
1182         EFL's implementation of platformRunUntil() should keep the main loop
1183         running and avoid calling sleep() between calls to
1184         ecore_main_loop_iterate(). This call to sleep seems to be a source
1185         of deadlocks (see Bug 106884).
1186
1187         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1188         (WTR::TestController::platformRunUntil):
1189
1190 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
1191
1192         QtTestBrowser should provide way to clear selected elements
1193         https://bugs.webkit.org/show_bug.cgi?id=107437
1194
1195         Reviewed by Simon Hausmann.
1196
1197         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
1198         Invoke the clearSelection prior to highlighting new elements.
1199
1200         * QtTestBrowser/launcherwindow.cpp:
1201         (ElementHighlight):
1202         (LauncherWindow::createChrome):
1203         (LauncherWindow::selectElements):
1204         (LauncherWindow::clearSelection):
1205         * QtTestBrowser/launcherwindow.h:
1206         (LauncherWindow):
1207
1208 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
1209
1210         [chromium] move methods interacting with willSendRequest to TestRunner
1211         https://bugs.webkit.org/show_bug.cgi?id=107270
1212
1213         Reviewed by Kent Tamura.
1214
1215         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1216         (DRTTestRunner::DRTTestRunner):
1217         (DRTTestRunner::waitForPolicyDelegate):
1218         * DumpRenderTree/chromium/DRTTestRunner.h:
1219         (DRTTestRunner):
1220         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1221         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1222         (WebTestRunner::WebTestRunner::httpHeadersToClear):
1223         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
1224         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
1225         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1226         (WebTestRunner::TestRunner::TestRunner):
1227         (WebTestRunner::TestRunner::reset):
1228         (WebTestRunner::TestRunner::httpHeadersToClear):
1229         (WebTestRunner):
1230         (WebTestRunner::TestRunner::shouldBlockRedirects):
1231         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
1232         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
1233         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1234         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
1235         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1236         (TestRunner):
1237         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1238         (WebTestRunner::WebTestProxyBase::willSendRequest):
1239         * DumpRenderTree/chromium/WebViewHost.cpp:
1240         (WebViewHost::willSendRequest):
1241         (WebViewHost::reset):
1242         * DumpRenderTree/chromium/WebViewHost.h:
1243         (WebViewHost):
1244
1245 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
1246
1247         [GTK] Stop building WebKit2 on GTK EWSs
1248         https://bugs.webkit.org/show_bug.cgi?id=107435
1249
1250         Reviewed by Philippe Normand.
1251
1252         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
1253         so stop building it on GTK EWSs.
1254
1255         * Scripts/webkitpy/common/config/ports.py:
1256         (GtkPort.build_webkit_command):
1257         * Scripts/webkitpy/common/config/ports_unittest.py:
1258         (DeprecatedPortTest.test_gtk_port):
1259
1260 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
1261
1262         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1263         https://bugs.webkit.org/show_bug.cgi?id=107120
1264
1265         Reviewed by Adam Barth.
1266
1267         Updating mock to use the new states.
1268
1269         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1270         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1271         (MockWebRTCPeerConnectionHandler::initialize):
1272         (MockWebRTCPeerConnectionHandler::updateICE):
1273
1274 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1275
1276         Extend diff_parser to support the --full-index output.
1277         https://bugs.webkit.org/show_bug.cgi?id=107408
1278
1279         Reviewed by Maciej Stachowiak.
1280
1281         * Scripts/webkitpy/common/checkout/diff_parser.py:
1282         (git_diff_to_svn_diff):
1283         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1284         (DiffParserTest):
1285         (DiffParserTest.test_git_diff_to_svn_diff):
1286         (git_diff_to_svn_diff):
1287
1288 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1289
1290         Dragging over an element with scrollbars should scroll the element when dragging near edges
1291         https://bugs.webkit.org/show_bug.cgi?id=39725
1292
1293         Reviewed by Hajime Morita.
1294
1295         This patch introduces canceling drag-and-drop by escape key for testing
1296         behavior after cancellation drag-and-drop.
1297
1298         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1299         (WebTestRunner):
1300         (WebTestRunner::EventSender::doMouseUp):
1301         (WebTestRunner::EventSender::finishDragAndDrop):
1302         (WebTestRunner::EventSender::keyDown):
1303         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1304         (EventSender):
1305         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1306
1307 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1308
1309         [chromium] move frame generation related methods to TestRunner
1310         https://bugs.webkit.org/show_bug.cgi?id=107268
1311
1312         Reviewed by Adam Barth.
1313
1314         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1315         (DRTTestRunner::DRTTestRunner):
1316         (DRTTestRunner::setWillSendRequestReturnsNull):
1317         * DumpRenderTree/chromium/DRTTestRunner.h:
1318         (DRTTestRunner):
1319         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1320         (WebTestRunner::WebTestDelegate::display):
1321         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1322         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1323         (WebTestRunner::TestRunner::TestRunner):
1324         (WebTestRunner::TestRunner::display):
1325         (WebTestRunner):
1326         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1327         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1328         (TestRunner):
1329         * DumpRenderTree/chromium/WebViewHost.cpp:
1330         (WebViewHost::display):
1331         (WebViewHost::displayInvalidatedRegion):
1332         * DumpRenderTree/chromium/WebViewHost.h:
1333
1334 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1335
1336         [chromium] move speech related methods to TestRunner library
1337         https://bugs.webkit.org/show_bug.cgi?id=107266
1338
1339         Reviewed by Adam Barth.
1340
1341         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1342         (DRTTestRunner::DRTTestRunner):
1343         (DRTTestRunner::displayInvalidatedRegion):
1344         * DumpRenderTree/chromium/DRTTestRunner.h:
1345         (DRTTestRunner):
1346         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1347         (WebTestDelegate):
1348         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1349         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1350         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1351         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1352         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1353         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1354         (WebTestRunner::TestRunner::TestRunner):
1355         (WebTestRunner):
1356         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1357         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1358         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1359         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1360         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1361         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1362         (TestRunner):
1363         * DumpRenderTree/chromium/WebViewHost.cpp:
1364         (WebViewHost::addMockSpeechInputResult):
1365         (WebViewHost::setMockSpeechInputDumpRect):
1366         (WebViewHost::addMockSpeechRecognitionResult):
1367         (WebViewHost::setMockSpeechRecognitionError):
1368         (WebViewHost::wasMockSpeechRecognitionAborted):
1369         * DumpRenderTree/chromium/WebViewHost.h:
1370
1371 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1372
1373         [chromium] move notification related methods to TestRunner
1374         https://bugs.webkit.org/show_bug.cgi?id=107269
1375
1376         Reviewed by Adam Barth.
1377
1378         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1379         (DRTTestRunner::DRTTestRunner):
1380         * DumpRenderTree/chromium/DRTTestRunner.h:
1381         (DRTTestRunner):
1382         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1383         (WebTestDelegate):
1384         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1385         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1386         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1387         (WebTestRunner::TestRunner::TestRunner):
1388         (WebTestRunner):
1389         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1390         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1391         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1392         (TestRunner):
1393         * DumpRenderTree/chromium/WebViewHost.cpp:
1394         (WebViewHost::grantWebNotificationPermission):
1395         (WebViewHost::simulateLegacyWebNotificationClick):
1396         * DumpRenderTree/chromium/WebViewHost.h:
1397
1398 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1399
1400         [chromium] move geolocation related methods to TestRunner
1401         https://bugs.webkit.org/show_bug.cgi?id=107267
1402
1403         Reviewed by Adam Barth.
1404
1405         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1406         (DRTTestRunner::DRTTestRunner):
1407         * DumpRenderTree/chromium/DRTTestRunner.h:
1408         (DRTTestRunner):
1409         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1410         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1411         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1412         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1413         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1414         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1415         (WebTestRunner::TestRunner::TestRunner):
1416         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1417         (WebTestRunner):
1418         (WebTestRunner::TestRunner::setGeolocationPermission):
1419         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1420         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1421         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1422         (TestRunner):
1423         * DumpRenderTree/chromium/WebViewHost.cpp:
1424         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1425         (WebViewHost::setGeolocationPermission):
1426         (WebViewHost::setMockGeolocationPosition):
1427         (WebViewHost::setMockGeolocationPositionUnavailableError):
1428         * DumpRenderTree/chromium/WebViewHost.h:
1429
1430 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1431
1432         Unreviewed build fix for Qt WK2 after r140258.
1433         Use the size_t type instead of unsigned for the variable
1434         which holds the position of the first null character in the
1435         console message.
1436
1437         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1438         (WTR::InjectedBundlePage::willAddMessageToConsole):
1439
1440 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1441
1442         Unreviewed, rolling out r140260.
1443         http://trac.webkit.org/changeset/140260
1444         https://bugs.webkit.org/show_bug.cgi?id=107387
1445
1446         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1447         nothing else) (Requested by thakis__ on #webkit).
1448
1449         * Scripts/update-webkit-chromium:
1450
1451 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1452
1453         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1454         https://bugs.webkit.org/show_bug.cgi?id=106890
1455
1456         Reviewed by Kenneth Rohde Christiansen.
1457
1458         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1459
1460         * WebKitTestRunner/TestInvocation.cpp:
1461         (WTR::shouldUseFixedLayout):
1462         (WTR):
1463         (WTR::updateLayoutType):
1464
1465 2013-01-19  Nico Weber  <thakis@chromium.org>
1466
1467         Make ninja the default build system for build-webkit --chromium on mac
1468         https://bugs.webkit.org/show_bug.cgi?id=106737
1469
1470         Reviewed by Eric Seidel.
1471
1472         * Scripts/update-webkit-chromium:
1473
1474 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1475
1476         [WK2] svg/dom/fuzz-path-parser.html is failing
1477         https://bugs.webkit.org/show_bug.cgi?id=107133
1478
1479         Reviewed by Alexey Proskuryakov.
1480
1481         Console messages can contain null characters before the end of string.
1482         Appending such message to the StringBuilder as a WTFString appends the
1483         complete string, including the null character. This later cuts off everything
1484         after the null character when the string is being printed out to the test
1485         output.
1486
1487         To avoid this, truncate the string up to the first null character. This
1488         preserves the newline character appended immediately after this and
1489         stops giving incorrect output.
1490
1491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1492         (WTR::InjectedBundlePage::willAddMessageToConsole):
1493
1494 2013-01-19  Eric Seidel  <eric@webkit.org>
1495
1496         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1497         https://bugs.webkit.org/show_bug.cgi?id=107367
1498
1499         Reviewed by Ryosuke Niwa.
1500
1501         Using srcdoc instead of document.write changes the error output
1502         ever so slightly.  Clearly we were already trying to ignore these
1503         messages, just not succeeding.  This change makes this new test "pass" correctly.
1504
1505         * Scripts/webkitpy/performance_tests/perftest.py:
1506         (PerfTest):
1507
1508 2013-01-18  Dan Winship  <danw@gnome.org>
1509
1510         REGRESSION (r139071): run-webkit-httpd complains at launch
1511         https://bugs.webkit.org/show_bug.cgi?id=107310
1512
1513         Reviewed by Alexey Proskuryakov.
1514
1515         * Scripts/webkitperl/httpd.pm:
1516         (getApacheVersion): use preferred perl syntax
1517
1518 2013-01-18  Julie Parent  <jparent@chromium.org>
1519
1520         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1521         https://bugs.webkit.org/show_bug.cgi?id=107336
1522
1523         We need to have 'group' listed as a parameter, else we never parse it,
1524         as we only parse parameters with defaults.
1525         
1526         Reviewed by Ojan Vafai.
1527
1528         * TestResultServer/static-dashboards/dashboard_base.js:
1529
1530 2013-01-18  Emil A Eklund  <eae@chromium.org>
1531
1532         Update LayoutUnit rounding unit test
1533         https://bugs.webkit.org/show_bug.cgi?id=107322
1534
1535         Reviewed by Levi Weintraub.
1536         
1537         Update the LayoutUnitRounding test to use fromFloatRound for
1538         values that cannot accurately be represented as a LayoutUnit
1539         (the default behavior is to floor the value to the nearest
1540         LayoutUnit).
1541
1542         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1543         (TestWebKitAPI::TEST):
1544
1545 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1546
1547         VCSUtils.pm: Stop calling git repo-config.
1548         https://bugs.webkit.org/show_bug.cgi?id=107294
1549
1550         Reviewed by Dirk Pranke.
1551
1552         The `repo-config' git command has been deprecated since early
1553         2008, and recent versions have started warning it is deprecated.
1554
1555         Basically revert r27870 and use the `config' command all the time.
1556
1557         * Scripts/VCSUtils.pm:
1558         (gitConfig):
1559
1560 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1561
1562         LayoutUnit should round half consistently, not away from zero
1563         https://bugs.webkit.org/show_bug.cgi?id=107208
1564
1565         Reviewed by Eric Seidel.
1566
1567         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1568         cover this change in rounding behavior.
1569
1570 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1571
1572         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1573         https://bugs.webkit.org/show_bug.cgi?id=107234
1574
1575         Reviewed by Simon Fraser.
1576
1577         * DumpRenderTree/mac/DumpRenderTree.mm:
1578         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1579         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1580         (WTR::PlatformWebView::PlatformWebView): Ditto.
1581
1582 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1583
1584         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1585         https://bugs.webkit.org/show_bug.cgi?id=107251
1586
1587         Reviewed by Simon Fraser.
1588
1589         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1590
1591         * DumpRenderTree/mac/DumpRenderTree.mm:
1592         (dumpRenderTree):
1593         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1594         (WTR::InjectedBundle::platformInitialize):
1595
1596 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1597
1598         [GTK] Enable indexed database for development builds
1599         https://bugs.webkit.org/show_bug.cgi?id=107299
1600
1601         Reviewed by Gustavo Noronha Silva.
1602
1603         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1604         for GTK+ development builds.
1605
1606 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1607
1608         AX: Improve table-guessing heuristics
1609         https://bugs.webkit.org/show_bug.cgi?id=107042
1610
1611         Reviewed by Chris Fleizach.
1612
1613         Implement parentElementCallback on Chromium to make testing easier.
1614
1615         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1616         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1617
1618 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1619
1620         [GTK] Add property for IndexedDB database path to WebKitGTK+
1621         https://bugs.webkit.org/show_bug.cgi?id=106136
1622
1623         Reviewed by Gustavo Noronha Silva.
1624
1625         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1626         before falling back to the old default. This is necessary because
1627         indexed database tests require that each DRT shard is using a different
1628         IDB database location.
1629
1630         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1631         (temporaryDatabaseDirectory): Added this helper for getting the
1632         database directory.
1633         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1634
1635 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1636
1637         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1638         https://bugs.webkit.org/show_bug.cgi?id=107264
1639
1640         Reviewed by Laszlo Gombos.
1641
1642         Enable API test InjectedBundleFrameHitTest for hit-testing,
1643         since it is now passing on both Debug and Release builds.
1644
1645         * TestWebKitAPI/CMakeLists.txt:
1646         * TestWebKitAPI/PlatformEfl.cmake:
1647
1648 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1649
1650         [GTK] Implement TestRunner::addUserScript
1651         https://bugs.webkit.org/show_bug.cgi?id=107275
1652
1653         Reviewed by Philippe Normand.
1654
1655         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1656         (TestRunner::addUserScript): Implement method using
1657         DumpRenderTreeSupportGtk::addUserScript.
1658
1659 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1660
1661         Unreviewed, add my secondary email address to the list.
1662
1663         * Scripts/webkitpy/common/config/committers.py:
1664
1665 2013-01-18  Dan Carney  <dcarney@google.com>
1666
1667         [chromium] move pointerlock functions to TestRunner library
1668         https://bugs.webkit.org/show_bug.cgi?id=107241
1669
1670         Reviewed by Jochen Eisinger.
1671
1672         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1673         (DRTTestRunner::DRTTestRunner):
1674         * DumpRenderTree/chromium/DRTTestRunner.h:
1675         (DRTTestRunner):
1676         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1677         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1678         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1679         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1680         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1681         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1682         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1683         (WebTestRunner::TestRunner::TestRunner):
1684         (WebTestRunner):
1685         (WebTestRunner::TestRunner::didAcquirePointerLock):
1686         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1687         (WebTestRunner::TestRunner::didLosePointerLock):
1688         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1689         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1690         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1691         (TestRunner):
1692         * DumpRenderTree/chromium/WebViewHost.h:
1693         (WebViewHost):
1694
1695 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1696
1697         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1698         https://bugs.webkit.org/show_bug.cgi?id=106774
1699
1700         Reviewed by Martin Robinson.
1701
1702         In order to fix a long standing linespacing/font ascent & descent issue
1703         we found that FreeType commit b0962ac34e660 solves that problem.
1704         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1705         maintainer recommending several security updates after that said commit.
1706
1707         Also, in order to avoid extra rebaselining, let's activate subpixel
1708         layout at the same time.
1709
1710         * efl/jhbuild.modules: New freetype 2.4.11
1711
1712 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1713
1714         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1715         https://bugs.webkit.org/show_bug.cgi?id=107107
1716         PR 282192
1717
1718         Reviewed by Rob Buis.
1719
1720         The DRT application will convert relative/absolute file path to
1721         file://<real-file-path> format, so we only check for http/file prefix.
1722
1723         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1724         (BlackBerry::WebKit::isFullUrl):
1725         (WebKit):
1726         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1727
1728 2013-01-17  Frank Farzan  <frankf@chromium.org>
1729
1730         Flakiness dashboard: Add ChromiumFYI master
1731         https://bugs.webkit.org/show_bug.cgi?id=107180
1732
1733         Reviewed by Ojan Vafai.
1734
1735         This is needed to enable Chrome Android bots
1736         to upload results for instrumentation tests.
1737
1738         * TestResultServer/generate_builders_json.py:
1739         (main):
1740         * TestResultServer/static-dashboards/builders.jsonp:
1741
1742 2013-01-17  Frank Farzan  <frankf@chromium.org>
1743
1744         Add Chrome on Android instrumentation test types to flakiness dashboard
1745         https://bugs.webkit.org/show_bug.cgi?id=106964
1746
1747         Reviewed by Ojan Vafai.
1748
1749         Specifically, add these test types:
1750         
1751          androidwebview_instrumentation_tests
1752          chromiumtestshell_instrumentation_tests
1753          contentshell_instrumentation_tests
1754         
1755         Also, add ChromiumFYI to the list of masters.
1756
1757         * TestResultServer/static-dashboards/builders.js:
1758         (loadBuildersList):
1759         * TestResultServer/static-dashboards/dashboard_base.js:
1760         (currentBuilderGroupCategory):
1761
1762 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1763
1764         Fixing webkitpy's SCM unit tests.
1765         https://bugs.webkit.org/show_bug.cgi?id=106429
1766
1767         Reviewed by Eric Seidel.
1768
1769         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1770         (SCMDetectorTest.test_detect_scm_system):
1771         * Scripts/webkitpy/common/checkout/scm/git.py:
1772         (Git.in_working_directory):
1773         (Git.read_git_config):
1774         (Git._assert_can_squash):
1775         (Git.remote_branch_ref):
1776         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1777         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1778         (GitTestWithMock):
1779         (GitTestWithMock.make_scm):
1780         (GitTestWithMock.test_create_patch):
1781         * Scripts/webkitpy/common/system/outputcapture.py:
1782         (OutputCapture.assert_outputs):
1783         (OutputCaptureTestCaseBase):
1784         * Scripts/webkitpy/test/printer.py:
1785         (Printer.configure):
1786
1787 2013-01-17  Julie Parent  <jparent@chromium.org>
1788
1789         Flakiness dashboard assumes there must be ToT tests
1790         https://bugs.webkit.org/show_bug.cgi?id=107155
1791
1792         Remove group as a default parameter, since we can't actually know
1793         the name of a group initially.  Instead, introduces 
1794         currentBuilderGroupName which returns the current builder group
1795         if it has been explicitly set, or picks the first one available
1796         as a default. Allows us to remove some extra code tracking this
1797         stuff as well.
1798         
1799         Reviewed by Ojan Vafai.
1800
1801         * TestResultServer/static-dashboards/dashboard_base.js:
1802         (parseCrossDashboardParameters):
1803         (currentBuilderGroupName):
1804         (currentBuilderGroup):
1805         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1806         (platformAndBuildType):
1807         * TestResultServer/static-dashboards/loader.js:
1808         (.):
1809
1810 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1811
1812         Remove NodeListsNodeData when it's no longer needed
1813         https://bugs.webkit.org/show_bug.cgi?id=107074
1814
1815         Reviewed by Darin Adler.
1816
1817         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1818
1819         * Scripts/webkitpy/performance_tests/perftest.py:
1820         (PerfTest):
1821
1822 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1823
1824         Ref test images are upside-down in WebKit2
1825         https://bugs.webkit.org/show_bug.cgi?id=105457
1826
1827         Reviewed by Sam "Speedy" Weinig.
1828         
1829         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1830         from the window snapshot contained a flipped copy of the image, causing all ref
1831         and pixel images to be upside-down.
1832
1833         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1834         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1835
1836 2013-01-17  Timothy Loh  <timloh@google.com>
1837
1838         Replaced specifiers variable with is_debug in builders.py
1839         https://bugs.webkit.org/show_bug.cgi?id=107057
1840
1841         Reviewed by Dirk Pranke.
1842
1843         Replaced specifiers variable with is_debug in builders.py to simplify
1844         Bug 106259. The other specifiers are not used elsewhere in the code.
1845         Fixed builder_name_for_port_name to return a debug builder if we don't
1846         have a release builder.
1847
1848         * Scripts/webkitpy/layout_tests/port/builders.py:
1849         (all_port_names):
1850         (builder_name_for_port_name):
1851         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1852         (TestRebaselineExpectations.test_rebaseline_expectations):
1853
1854 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1855
1856         [GTK] Build with LevelDB when IndexedDB is enabled
1857         https://bugs.webkit.org/show_bug.cgi?id=103220
1858
1859         Reviewed by Gustavo Noronha Silva.
1860
1861         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1862         as it does not conform to WebKit style.
1863
1864 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1865
1866         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1867         https://bugs.webkit.org/show_bug.cgi?id=107119
1868
1869         Reviewed by Laszlo Gombos.
1870
1871         Do not use ASSERT on ecore_evas_init(), since the expression inside
1872         the macro compiles out of release builds.
1873
1874         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1875         * TestWebKitAPI/efl/PlatformWebView.cpp:
1876         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1877
1878 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1879
1880         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1881         https://bugs.webkit.org/show_bug.cgi?id=104545
1882
1883         Reviewed by Yury Semikhatsky.
1884
1885         Adopt signature changes.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1888         (ProfilerAgent.getCPUProfile): Renamed.
1889         (ProfilerAgent.getHeapSnapshot): Added.
1890
1891 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1892
1893         [GTK][EFL] NWRT should check that Xvfb is installed
1894         https://bugs.webkit.org/show_bug.cgi?id=71767
1895
1896         Reviewed by Dirk Pranke.
1897
1898         EFL and GTK ports now check that Xvfb is installed before running
1899         layout tests. The command line used to check whether Xvfb is present
1900         is a simple `which Xvfb` that should return 0 as the exit code upon
1901         success.
1902
1903         * Scripts/webkitpy/layout_tests/port/efl.py:
1904         (EflPort.show_results_html_file):
1905         (EflPort):
1906         (EflPort.check_sys_deps):
1907         * Scripts/webkitpy/layout_tests/port/gtk.py:
1908         (GtkPort.check_sys_deps):
1909         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1910         (XvfbDriver):
1911         (XvfbDriver.check_xvfb):
1912
1913 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1914
1915         sheriffbot can't tell me who "kov" is
1916         https://bugs.webkit.org/show_bug.cgi?id=106184
1917
1918         Reviewed by Eric Seidel.
1919
1920         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1921
1922         * Scripts/webkitpy/common/config/committers.py:
1923         (Account.matches_glob):
1924         (CommitterList.contributors_by_search_string):
1925         * Scripts/webkitpy/common/config/committers_unittest.py:
1926         (CommittersTest.test_committer_lookup):
1927         * Scripts/webkitpy/tool/bot/irc_command.py:
1928         (Whois):
1929
1930 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1931
1932         Use xcrun to find path to make for Mac port
1933         <http://webkit.org/b/107091>
1934
1935         Reviewed by Dan Bernstein.
1936
1937         * Scripts/webkitpy/layout_tests/port/mac.py:
1938         (MacPort._build_java_test_support): Call self.make_command().
1939         (MacPort.make_command): Add.  Call xcrun_find().
1940         (MacPort.nm_command): Use self.xcrun_find().
1941         (MacPort.xcrun_find): Add.  Extract from nm_command().
1942
1943 2013-01-16  Sam Weinig  <sam@webkit.org>
1944
1945         Make debug-safari --target-web-process work again
1946         https://bugs.webkit.org/show_bug.cgi?id=107088
1947
1948         Reviewed by Anders Carlsson.
1949
1950         * Scripts/webkitdirs.pm:
1951         (execMacWebKitAppForDebugging):
1952         The shim is now called SecItemShim.
1953
1954 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1955
1956         GCE build scripts don't take working directory into account when calling findzone.sh
1957         https://bugs.webkit.org/show_bug.cgi?id=106962
1958
1959         Reviewed by Adam Barth.
1960
1961         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1962         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1963         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1964
1965 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1966
1967         start-queue.sh does not pass remaining parameters correctly
1968         https://bugs.webkit.org/show_bug.cgi?id=107054
1969
1970         Reviewed by Adam Barth.
1971
1972         start-queue.sh now passes all remaining params to the webkit-patch command.
1973         Previously only one additional queue parameter could be sent.
1974
1975         * EWSTools/start-queue.sh:
1976
1977 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1978
1979         check-webkit-style script cannot running in Chinese windows.
1980         https://bugs.webkit.org/show_bug.cgi?id=87548
1981
1982         Reviewed by Darin Adler.
1983
1984         * Scripts/webkitpy/common/system/platforminfo.py:
1985         (PlatformInfo._win_version_tuple_from_cmd):
1986
1987 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1988
1989         Delete an extraneous print statement.
1990         https://bugs.webkit.org/show_bug.cgi?id=106562
1991
1992         Delete the extraneous print statement introduced in r139841.
1993
1994         * Scripts/webkitpy/layout_tests/views/printing.py:
1995         (Printer.print_found):
1996
1997 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1998
1999         Please reinstate --pixel
2000         https://bugs.webkit.org/show_bug.cgi?id=101995
2001
2002         Reviewed by Dirk Pranke.
2003
2004         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
2005         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
2006         Some developers are still used to these options that were available in the ORWT.
2007
2008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2009         (parse_args):
2010
2011 2013-01-16  Eric Seidel  <eric@webkit.org>
2012
2013         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
2014         https://bugs.webkit.org/show_bug.cgi?id=99512
2015
2016         Reviewed by Darin Adler.
2017
2018         * Scripts/run-sunspider:
2019
2020 2013-01-16  Eric Seidel  <eric@webkit.org>
2021
2022         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
2023         https://bugs.webkit.org/show_bug.cgi?id=106036
2024
2025         Reviewed by Darin Adler.
2026
2027         * Scripts/webkitpy/webkitpy.pyproj: Removed.
2028         * Scripts/webkitpy/webkitpy.sln: Removed.
2029
2030 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
2031
2032         [Chromium] Remove hardcoded chromium_*.jar in gyp files
2033         https://bugs.webkit.org/show_bug.cgi?id=104049
2034
2035         Reviewed by Eric Seidel.
2036
2037         Targets with dependencies (direct/indirect) on a java target receive
2038         the chromium_*.jar paths in the variable input_jars_paths. Targets
2039         should use that rather than hardcoding where they think the jar will
2040         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
2041         than as --jars to generate_native_test.py.
2042
2043         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2044         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2045
2046 2013-01-16  Dan Carney  <dcarney@google.com>
2047
2048         [chromium] move setMockDeviceOrientation to TestRunner library
2049         https://bugs.webkit.org/show_bug.cgi?id=106895
2050
2051         Reviewed by Jochen Eisinger.
2052
2053         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2054         (DRTTestRunner::DRTTestRunner):
2055         * DumpRenderTree/chromium/DRTTestRunner.h:
2056         (DRTTestRunner):
2057         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2058         (WebKit):
2059         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
2060         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2061         (WebTestRunner::TestRunner::TestRunner):
2062         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2063         (WebTestRunner):
2064         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2065         (TestRunner):
2066         * DumpRenderTree/chromium/WebViewHost.cpp:
2067         (WebViewHost::setDeviceOrientation):
2068         * DumpRenderTree/chromium/WebViewHost.h:
2069         (WebViewHost):
2070
2071 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2072
2073         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2074         https://bugs.webkit.org/show_bug.cgi?id=106904
2075
2076         Reviewed by Adam Barth.
2077
2078         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2079         (DRTTestRunner::DRTTestRunner):
2080         (DRTTestRunner::notifyDone):
2081         (DRTTestRunner::reset):
2082         * DumpRenderTree/chromium/DRTTestRunner.h:
2083         (DRTTestRunner):
2084         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2085         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2086         (WebTestRunner::WebTestDelegate::setFocus):
2087         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2088         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2089         (WebTestRunner::WebTestDelegate::setLocale):
2090         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2091         (WebTestRunner::TestRunner::TestRunner):
2092         (WebTestRunner::TestRunner::reset):
2093         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2094         (WebTestRunner):
2095         (WebTestRunner::TestRunner::setWindowIsKey):
2096         (WebTestRunner::TestRunner::pathToLocalResource):
2097         (WebTestRunner::TestRunner::setBackingScaleFactor):
2098         (WebTestRunner::TestRunner::setPOSIXLocale):
2099         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2100         (WebTestRunner::TestRunner::taskList):
2101         (TestRunner):
2102         * DumpRenderTree/chromium/WebViewHost.cpp:
2103         (WebViewHost::setDeviceScaleFactor):
2104         (WebViewHost::setFocus):
2105         (WebViewHost::setAcceptAllCookies):
2106         (WebViewHost::pathToLocalResource):
2107         (WebViewHost::setLocale):
2108         * DumpRenderTree/chromium/WebViewHost.h:
2109         (WebViewHost):
2110
2111 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
2112
2113         [GTK] build-webkit fails if the jhbuild wrapper is not used
2114         https://bugs.webkit.org/show_bug.cgi?id=106769
2115
2116         Reviewed by Martin Robinson.
2117
2118         Return an empty array instead of "" in
2119         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
2120         will not be recognized as a valid command when the returned array
2121         is directly passed to perl's system() call.
2122
2123         * Scripts/webkitdirs.pm:
2124         (jhbuildWrapperPrefixIfNeeded):
2125
2126 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2127
2128         [chromium] add title text direction attribute to TestRunner
2129         https://bugs.webkit.org/show_bug.cgi?id=106907
2130
2131         Reviewed by Adam Barth.
2132
2133         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2134         (DRTTestRunner::DRTTestRunner):
2135         (DRTTestRunner::reset):
2136         * DumpRenderTree/chromium/DRTTestRunner.h:
2137         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2138         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2139         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2140         (WebTestRunner::TestRunner::TestRunner):
2141         (WebTestRunner::TestRunner::reset):
2142         (WebTestRunner::TestRunner::setTitleTextDirection):
2143         (WebTestRunner):
2144         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2145         (TestRunner):
2146         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2147         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2148         * DumpRenderTree/chromium/WebViewHost.cpp:
2149         (WebViewHost::didReceiveTitle):
2150
2151 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2152
2153         NRWT still confused about test count with --repeat-each and --iterations
2154         https://bugs.webkit.org/show_bug.cgi?id=106562
2155
2156         Reviewed by Dirk Pranke.
2157
2158         Fix the printed unique test count and skipped count. This
2159         seems to have broken in r127688 ("NRWT lies about the number
2160         of tests that it's skipping when used with --repeat-each").
2161
2162         Also add a test for print_found()
2163
2164         * Scripts/webkitpy/layout_tests/views/printing.py:
2165         (Printer.print_found):
2166         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2167         (Testprinter.test_details):
2168         (Testprinter):
2169         (Testprinter.test_found):
2170
2171 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2172
2173         Unreviewed follow-up to r139769.
2174
2175         Note that omitting the WebKit1 code from the build now
2176         works for GTK as well.
2177
2178         * Scripts/build-webkit:
2179
2180 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2181
2182         test-webkitpy: truncate output to the terminal width when necessary
2183         https://bugs.webkit.org/show_bug.cgi?id=106973
2184
2185         Reviewed by Ojan Vafai.
2186
2187         this implements the same logic for test-webkitpy that we have
2188         for run-webkit-tests (and ninja).
2189
2190         No tests written as this is exercised by running test-webkitpy itself.
2191
2192         * Scripts/webkitpy/test/printer.py:
2193         (Printer.configure):
2194         (Printer._test_line):
2195
2196 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2197
2198         remove extraneous output in test-webkitpy
2199         https://bugs.webkit.org/show_bug.cgi?id=106971
2200
2201         Reviewed by Ojan Vafai.
2202
2203         We weren't ignoring or capturing the echoed output from
2204         these two tests, and getting noise in the logs as a result.
2205
2206         * Scripts/webkitpy/common/system/executive_unittest.py:
2207         (ExecutiveTest.test_auto_stringify_args):
2208         (ExecutiveTest.test_popen_args):
2209
2210 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2211
2212         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
2213         https://bugs.webkit.org/show_bug.cgi?id=106974
2214
2215         Reviewed by Ryosuke Niwa.
2216
2217         I forgot to stub out the call to check to ensure that the ports were
2218         available, so this test could fail if something was listening on 8000 or
2219         8443 on the machine.
2220
2221         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2222         (TestHttpServer.test_win32_start_and_stop):
2223
2224 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2225
2226         Unreviewed, rolling out r139792.
2227         http://trac.webkit.org/changeset/139792
2228         https://bugs.webkit.org/show_bug.cgi?id=106970
2229
2230         Broke the windows build.
2231
2232         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2233         (DRTTestRunner::DRTTestRunner):
2234         (DRTTestRunner::notifyDone):
2235         (DRTTestRunner::reset):
2236         (DRTTestRunner::setAlwaysAcceptCookies):
2237         (DRTTestRunner::setWindowIsKey):
2238         (DRTTestRunner::pathToLocalResource):
2239         (DRTTestRunner::setPOSIXLocale):
2240         (InvokeCallbackTask):
2241         (InvokeCallbackTask::InvokeCallbackTask):
2242         (InvokeCallbackTask::runIfValid):
2243         (DRTTestRunner::setBackingScaleFactor):
2244         * DumpRenderTree/chromium/DRTTestRunner.h:
2245         (DRTTestRunner):
2246         (DRTTestRunner::taskList):
2247         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2248         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2249         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2250         (WebTestRunner::TestRunner::TestRunner):
2251         (WebTestRunner::TestRunner::reset):
2252         (WebTestRunner::TestRunner::setDatabaseQuota):
2253         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2254         (TestRunner):
2255         * DumpRenderTree/chromium/WebViewHost.cpp:
2256         (WebViewHost::setPendingExtraData):
2257         (WebViewHost::setDeviceScaleFactor):
2258         * DumpRenderTree/chromium/WebViewHost.h:
2259         (WebViewHost):
2260
2261 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
2262
2263         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2264
2265         * Scripts/webkitpy/common/config/ports.py:
2266         (MacWK2Port):
2267
2268 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2269
2270         Extend sheriffbot's "help" command to be able to get help on individual commands
2271         https://bugs.webkit.org/show_bug.cgi?id=106629
2272
2273         Reviewed by Eric Seidel.
2274
2275         Added a help command to sheriffbot.
2276         Fixed some style issues and ordered the commands alphabetically.
2277
2278         * Scripts/webkitpy/tool/bot/irc_command.py:
2279         (IRCCommand):
2280         (IRCCommand.execute):
2281         (IRCCommand.usage):
2282         (IRCCommand.help):
2283         (CreateBug):
2284         (CreateBug.execute):
2285         (Help):
2286         (Help.execute):
2287         (Help._post_command_help):
2288         (Hi):
2289         (Hi.execute):
2290         (Restart):
2291         (RollChromiumDEPS):
2292         (RollChromiumDEPS._parse_args):
2293         (RollChromiumDEPS._expand_irc_nickname):
2294         (RollChromiumDEPS.execute):
2295         (Rollout):
2296         (Rollout._extract_revisions):
2297         (Rollout.execute):
2298         (Sheriffs):
2299         (Sheriffs.execute):
2300         (Whois):
2301         (Whois.execute):
2302         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2303         (IRCBotTest.test_help):
2304
2305 2013-01-15  Enrica Casucci  <enrica@apple.com>
2306
2307         Add a new set of WebKit2 APIs for text search and
2308         search results management.
2309         https://bugs.webkit.org/show_bug.cgi?id=106834.
2310         <rdar://problem/12597159>
2311
2312         Added new test for the new WebKit2 API for
2313         text search.
2314         
2315         Reviewed by Simon Fraser.
2316
2317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2318         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2319
2320 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2321
2322         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2323         https://bugs.webkit.org/show_bug.cgi?id=106904
2324
2325         Reverting 139794. It broke the build. It appears that a header file,
2326         WebTextDirection.h, was left out.
2327
2328         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2329         (DRTTestRunner::DRTTestRunner):
2330         (DRTTestRunner::reset):
2331         * DumpRenderTree/chromium/DRTTestRunner.h:
2332         (DRTTestRunner::setTitleTextDirection):
2333         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2334         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2336         (WebTestRunner::TestRunner::TestRunner):
2337         (WebTestRunner::TestRunner::reset):
2338         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2339         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2340         (TestRunner):
2341         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2342         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2343         * DumpRenderTree/chromium/WebViewHost.cpp:
2344         (WebViewHost::didReceiveTitle):
2345
2346 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2347
2348         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2349         https://bugs.webkit.org/show_bug.cgi?id=106904
2350
2351         Reviewed by Adam Barth.
2352
2353         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2354         (DRTTestRunner::DRTTestRunner):
2355         (DRTTestRunner::notifyDone):
2356         (DRTTestRunner::reset):
2357         * DumpRenderTree/chromium/DRTTestRunner.h:
2358         (DRTTestRunner):
2359         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2360         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2361         (WebTestRunner::WebTestDelegate::setFocus):
2362         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2363         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2364         (WebTestRunner::WebTestDelegate::setLocale):
2365         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2366         (WebTestRunner::TestRunner::TestRunner):
2367         (WebTestRunner::TestRunner::reset):
2368         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2369         (WebTestRunner):
2370         (WebTestRunner::TestRunner::setWindowIsKey):
2371         (WebTestRunner::TestRunner::pathToLocalResource):
2372         (WebTestRunner::TestRunner::setBackingScaleFactor):
2373         (WebTestRunner::TestRunner::setPOSIXLocale):
2374         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2375         (WebTestRunner::TestRunner::taskList):
2376         (TestRunner):
2377         * DumpRenderTree/chromium/WebViewHost.cpp:
2378         (WebViewHost::setDeviceScaleFactor):
2379         (WebViewHost::setFocus):
2380         (WebViewHost::setAcceptAllCookies):
2381         (WebViewHost::pathToLocalResource):
2382         (WebViewHost::setLocale):
2383         * DumpRenderTree/chromium/WebViewHost.h:
2384         (WebViewHost):
2385
2386 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2387
2388         Tests with WontFix expectation are (indirectly) skipped
2389         https://bugs.webkit.org/show_bug.cgi?id=105860
2390
2391         Reviewed by Dirk Pranke.
2392
2393         Only skip the WontFix expectation if there are no other layout test
2394         expectations (like Failure, ImageOnlyFailure) listed for the test.
2395         This makes it possible to run an expected failure for which there
2396         is no reason or interest to fix. There are some ports that would like
2397         to exercise this behavior as well as specific test cases that should use
2398         such expectations.
2399
2400         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2401         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2402         WONTFIX test if there are no expectations listed. The warning is adjusted
2403         to reflect the new behavior.
2404         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2405         and adjust test cases for these changes.
2406         (ExpectationSyntaxTests.test_wontfix):
2407         (SemanticTests.test_skip_and_wontfix):
2408
2409 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2410
2411         [chromium] add title text direction attribute to TestRunner
2412         https://bugs.webkit.org/show_bug.cgi?id=106907
2413
2414         Reviewed by Adam Barth.
2415
2416         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2417         (DRTTestRunner::DRTTestRunner):
2418         (DRTTestRunner::reset):
2419         * DumpRenderTree/chromium/DRTTestRunner.h:
2420         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2421         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2422         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2423         (WebTestRunner::TestRunner::TestRunner):
2424         (WebTestRunner::TestRunner::reset):
2425         (WebTestRunner::TestRunner::setTitleTextDirection):
2426         (WebTestRunner):
2427         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2428         (TestRunner):
2429         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2430         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2431         * DumpRenderTree/chromium/WebViewHost.cpp:
2432         (WebViewHost::didReceiveTitle):
2433
2434 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2435
2436         nrwt: change the default # of locked shards on chromium_win to 1
2437         https://bugs.webkit.org/show_bug.cgi?id=106938
2438
2439         Reviewed by Eric Seidel.
2440
2441         It looks like LigHTTPd might be buggy or unstable if we are
2442         running multiple http tests in parallel; see
2443         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2444         context as well. This change will stop running http tests in parallel
2445         and we can see if this fixes things.
2446
2447         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2448         (ChromiumWinPort.default_max_locked_shards):
2449         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2450         (ChromiumWinTest.test_path_to_image_diff):
2451         (ChromiumWinTest):
2452         (ChromiumWinTest.test_default_max_locked_shards):
2453
2454 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2455
2456         [chromium] move WebDatabase related methods to TestRunner library
2457         https://bugs.webkit.org/show_bug.cgi?id=106905
2458
2459         Reviewed by Adam Barth.
2460
2461         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2462         (DRTTestRunner::DRTTestRunner):
2463         (DRTTestRunner::reset):
2464         * DumpRenderTree/chromium/DRTTestRunner.h:
2465         (DRTTestRunner):
2466         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2467         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2468         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2469         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2470         (WebTestRunner::TestRunner::TestRunner):
2471         (WebTestRunner::TestRunner::reset):
2472         (WebTestRunner::TestRunner::clearAllDatabases):
2473         (WebTestRunner):
2474         (WebTestRunner::TestRunner::setDatabaseQuota):
2475         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2476         (TestRunner):
2477         * DumpRenderTree/chromium/WebViewHost.cpp:
2478         (WebViewHost::clearAllDatabases):
2479         (WebViewHost::setDatabaseQuota):
2480         * DumpRenderTree/chromium/WebViewHost.h:
2481         (WebViewHost):
2482
2483 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2484
2485         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2486         functionality match the name.
2487         https://bugs.webkit.org/show_bug.cgi?id=106870
2488
2489         Reviewed by Adam Barth.
2490
2491         * Scripts/webkitpy/tool/commands/download.py:
2492         (Clean):
2493         (Update):
2494         (Build):
2495         (BuildAndTest):
2496         (CheckStyle):
2497         (BuildAttachment):
2498         (BuildAndTestAttachment):
2499         (AbstractPatchApplyingCommand):
2500         (ApplyWatchList):
2501         (AbstractPatchLandingCommand):
2502         (CreateRollout):
2503         * Scripts/webkitpy/tool/steps/__init__.py:
2504         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2505         (CleanWorkingDirectory.options):
2506         (CleanWorkingDirectory.run):
2507         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2508         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2509         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2510
2511 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2512
2513         [Autotools] Add support for WebKit2-only builds
2514         https://bugs.webkit.org/show_bug.cgi?id=106889
2515
2516         Reviewed by Gustavo Noronha Silva.
2517
2518         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2519         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2520         building the GTK port through build-webkit.
2521         * Scripts/webkitdirs.pm:
2522         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2523         arguments when not building WebKit1.
2524         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2525         through the Autotools build system.
2526
2527 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2528
2529         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2530         https://bugs.webkit.org/show_bug.cgi?id=106197
2531
2532         Reviewed by Martin Robinson.
2533
2534         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2535         features. Enable them on GTK, meaning they will be enabled in development builds
2536         (i.e. when building with build-webkit).
2537
2538 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2539
2540         [GTK] Enable CSS Image Resolution feature
2541         https://bugs.webkit.org/show_bug.cgi?id=99038
2542
2543         Reviewed by Gustavo Noronha Silva.
2544
2545         Enable the CSS Image Resolution feature for the development
2546         builds of the GTK port.
2547
2548         * Scripts/webkitperl/FeatureList.pm:
2549
2550 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2551
2552         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2553         https://bugs.webkit.org/show_bug.cgi?id=106579
2554
2555         Reviewed by Gustavo Noronha Silva.
2556
2557         The --enable-unstable-features flag is not required to be passed anymore
2558         to the configure script as it was removed in r138252.
2559
2560         * Scripts/webkitdirs.pm:
2561         (buildAutotoolsProject):
2562
2563 2013-01-15  Tony Chang  <tony@chromium.org>
2564
2565         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2566
2567         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2568         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2569         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2570         (TestHttpServer.test_win32_start_and_stop):
2571
2572 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2573
2574         Unreviewed. Adding Michael Pruett as contributor.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2013-01-15  Victor Carbune  <victor@rosedu.org>
2579
2580         Unreviewed. Update my email addresses.
2581
2582         * Scripts/webkitpy/common/config/committers.py:
2583
2584 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2585
2586         [GTK] Waiting on the gdb process will lead to deadlock
2587         https://bugs.webkit.org/show_bug.cgi?id=106906
2588
2589         Reviewed by Philippe Normand.
2590
2591         Use communicate() rather than wait() on the Popen object that's running the gdb
2592         command. This avoids the deadlock that occurs on the GTK builders.
2593
2594         * Scripts/webkitpy/layout_tests/port/gtk.py:
2595         (GtkPort._get_gdb_output):
2596
2597 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2598
2599         [GTK] Limit the number of frames printed out when backtracing with gdb
2600         https://bugs.webkit.org/show_bug.cgi?id=106901
2601
2602         Reviewed by Philippe Normand.
2603
2604         Printing an unlimited number of frames when dumping the gdb backtracing
2605         output can cause timeouts in the builders. This patch limits the number
2606         of frames that are printed out to 1024.
2607
2608         * Scripts/webkitpy/layout_tests/port/gtk.py:
2609         (GtkPort._get_gdb_output):
2610
2611 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2612
2613         [Qt] Fix ImageDiff's image format conversion
2614         https://bugs.webkit.org/show_bug.cgi?id=106880
2615
2616         Reviewed by Csaba Osztrogonác.
2617
2618         Besides actually doing the conversion this also silences the suspicious warning:
2619         "ignoring return value of function declared with warn_unused_result attribute".
2620
2621         * ImageDiff/qt/ImageDiff.cpp:
2622         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2623         copy of the image in the given format and does not alter the image itself.
2624
2625 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2626
2627         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2628         https://bugs.webkit.org/show_bug.cgi?id=106823
2629
2630         Reviewed by Darin Fisher.
2631
2632         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2633         (DRTTestRunner::DRTTestRunner):
2634         (DRTTestRunner::reset):
2635         * DumpRenderTree/chromium/DRTTestRunner.h:
2636         (DRTTestRunner):
2637         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2638         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2639         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2640         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2641         (WebTestRunner::WebTestRunner::testRepaint):
2642         (WebTestRunner::WebTestRunner::sweepHorizontally):
2643         (WebTestRunner::WebTestRunner::isPrinting):
2644         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2645         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2646         (WebTestRunner::TestRunner::TestRunner):
2647         (WebTestRunner::TestRunner::reset):
2648         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2649         (WebTestRunner):
2650         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2651         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2652         (WebTestRunner::TestRunner::testRepaint):
2653         (WebTestRunner::TestRunner::sweepHorizontally):
2654         (WebTestRunner::TestRunner::isPrinting):
2655         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2656         (WebTestRunner::TestRunner::dumpBackForwardList):
2657         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2658         (WebTestRunner::TestRunner::dumpSelectionRect):
2659         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2660         (WebTestRunner::TestRunner::setPrinting):
2661         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2662         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2663         (TestRunner):
2664
2665 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2666
2667         nrwt: stub out show_results_html for mock ports
2668         https://bugs.webkit.org/show_bug.cgi?id=106848
2669
2670         Reviewed by Ojan Vafai.
2671
2672         We were accidentally using the underlying ports'
2673         show_results_html_file() implementation, which would, unsurprisingly,
2674         fail in many cases (e.g., running mock-efl on the mac).
2675
2676         No test added since we don't generally add tests for the mock
2677         implementation.
2678
2679         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2680         (MockDRTPort.show_results_html_file):
2681
2682 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2683
2684         Changing clean_working_directory/clean_local_commits and related
2685         functions to have consistent naming.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=104198
2688
2689         Reviewed by Adam Barth.
2690
2691         * Scripts/webkitpy/common/checkout/scm/git.py:
2692         * Scripts/webkitpy/common/checkout/scm/scm.py:
2693         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2694         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2695         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2696         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2697
2698 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2699
2700         Fix EWS GCE build scripts to detect which zone is available
2701         https://bugs.webkit.org/show_bug.cgi?id=106524
2702
2703         Reviewed by Adam Barth.
2704
2705         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2706         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2707         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2708         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2709
2710 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2711
2712         Adding an error string to AmbiguousCommitError.
2713         https://bugs.webkit.org/show_bug.cgi?id=106846
2714
2715         Reviewed by Adam Barth.
2716
2717         * Scripts/webkitpy/common/checkout/scm/git.py:
2718         (AmbiguousCommitError.__init__):
2719
2720 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2721
2722         kill whole lighttpd process tree for chromium win
2723         https://bugs.webkit.org/show_bug.cgi?id=106838
2724
2725         Reviewed by Tony Chang.
2726
2727         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2728         I think a test is causing a httpd server child process to wedge and
2729         killing the parent httpd server process isn't sufficient to ensure
2730         that the children are also killed.
2731
2732         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2733         (Lighttpd._check_and_kill):
2734         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2735         (TestHttpServer.test_start_cmd):
2736         (TestHttpServer):
2737         (TestHttpServer.test_win32_start_and_stop):
2738         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2739         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2740         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2741
2742 2013-01-14  Nico Weber  <thakis@chromium.org>
2743
2744         [chromium] Enable `update-webkit --chromium --ninja` on windows
2745         https://bugs.webkit.org/show_bug.cgi?id=106836
2746
2747         Reviewed by Eric Seidel.
2748
2749         After running this, build-webkit --chromium will use ninja to build.
2750         Apparently there are some minor issues with that still, so it's
2751         not quite ready for use yet.
2752
2753         * Scripts/webkitdirs.pm:
2754         (determineIsChromiumNinja):
2755         (buildChromium):
2756
2757 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2758
2759         nrwt: use the same search path for baselines and TestExpectations on apple mac
2760         https://bugs.webkit.org/show_bug.cgi?id=105599
2761
2762         Reviewed by Ryosuke Niwa.
2763
2764         Bug 105583 revealed some confusion due to the fact that the Apple
2765         Mac port used a different list of directories to search for baselines
2766         and TestExpectations files (actually, pretty much every port does).
2767
2768         It seems like a good idea to use the same list for both by default, but
2769         making this happen will affect every port in slightly different ways, so
2770         we'll try this on the Apple Mac port first.
2771
2772         Note that the effective changes for this are that:
2773         1) The apple mac port will look in platform/wk2 for baselines where
2774         it didn't before (it will look after looking in mac-wk2 but before
2775         the non-wk2 dirs)
2776         2) The apple mac-snowleopard port will use the expectations in
2777         mac-lion as well as the expectations in mac-snowleopard, although
2778         I'm not even sure if mac-snowleopard is still supported ...
2779
2780         * Scripts/webkitpy/layout_tests/port/mac.py:
2781         (MacPort.default_baseline_search_path):
2782         (MacPort.expectations_files):
2783         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2784         (test_baseline_search_path):
2785
2786 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2787
2788         AX: Need to implement ColorWellRole
2789         https://bugs.webkit.org/show_bug.cgi?id=106756
2790
2791         Reviewed by Chris Fleizach.
2792
2793         Returns a string representation of the value of a color
2794         when the role is Color Well, to make it easy to write layout
2795         tests for color controls.
2796
2797         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2798
2799 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2800
2801         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2802         https://bugs.webkit.org/show_bug.cgi?id=106682
2803
2804         Reviewed by Chris Fleizach.
2805
2806         Modify Chromium's DRT implementation of intValue to return a
2807         different value depending on the role.
2808
2809         There are actually platform-specific differences in what should
2810         be returned in the "value" of an object, so Chromium normally keeps
2811         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2812         but this is a fine simplification to make cross-platform tests easier.
2813
2814         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2815         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2816
2817 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2818
2819         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2820         https://bugs.webkit.org/show_bug.cgi?id=106785
2821
2822         Reviewed by Adam Barth.
2823
2824         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2825         (DRTTestRunner::DRTTestRunner):
2826         (DRTTestRunner::reset):
2827         * DumpRenderTree/chromium/DRTTestRunner.h:
2828         (DRTTestRunner):
2829         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2830         (WebTestProxyBase):
2831         (WebTestRunner::WebTestProxy::setStatusText):
2832         (WebTestRunner::WebTestProxy::didStopLoading):
2833         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2834         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2835         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2836         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2837         (WebTestRunner::TestRunner::TestRunner):
2838         (WebTestRunner::TestRunner::reset):
2839         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2840         (WebTestRunner):
2841         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2842         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2843         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2844         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2845         (TestRunner):
2846         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2847         (WebTestRunner::WebTestProxyBase::setStatusText):
2848         (WebTestRunner):
2849         (WebTestRunner::WebTestProxyBase::didStopLoading):
2850         * DumpRenderTree/chromium/WebViewHost.cpp:
2851         (WebViewHost::didStopLoading):
2852         * DumpRenderTree/chromium/WebViewHost.h:
2853         (WebViewHost):
2854
2855 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2856
2857         Web Inspector: devtools front-end doesn't have focus in TestShell
2858         https://bugs.webkit.org/show_bug.cgi?id=106778
2859
2860         Reviewed by Pavel Feldman.
2861
2862         Focus devTools window after loadURL method.
2863
2864         * DumpRenderTree/chromium/TestShell.cpp:
2865         (TestShell::runFileTest):
2866
2867 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2868
2869         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2870         https://bugs.webkit.org/show_bug.cgi?id=106573
2871
2872         Reviewed by Philippe Normand.
2873
2874         Similarly to what's been described in bug 106569, we're building
2875         from release tarballs, so there's no reason to regenerate the
2876         autoconf-related stuff with autogen.sh, especially since we might
2877         run into trouble with automake 1.13 and deprecated macros.
2878
2879         * efl/jhbuild.modules:
2880
2881 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2882
2883         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2884         https://bugs.webkit.org/show_bug.cgi?id=104909
2885
2886         Reviewed by Simon Hausmann.
2887
2888         To be able to build redistribuable binary packages, Qt's configure switches
2889         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2890         dynamically link to optional system libraries.
2891         QtWebKit is doing its own configure checks for those libraries, thus adding a
2892         runtime dependency that might not be fulfilled if the packager's machine had
2893         those libraries while the user's machine won't.
2894
2895         Since in most cases where WebKit will want to use those system libraries, Qt will
2896         also be using them, remove these configure tests from WebKit.
2897
2898         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2899         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2900         * qmake/config.tests/libpng/libpng.cpp: Removed.
2901         * qmake/config.tests/libpng/libpng.pro: Removed.
2902         * qmake/mkspecs/features/features.prf:
2903
2904 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2905
2906         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2907         https://bugs.webkit.org/show_bug.cgi?id=106574
2908
2909         Reviewed by Laszlo Gombos.
2910
2911         Rely on a more recent stable release, which includes support for
2912         Lua 5.2 in Edje and other assorted minor fixes.
2913
2914         While here, also use the "configure" script to build the libraries
2915         instead of relying on autogen.sh, which is not really needed with
2916         a release tarball and may have problems with automake 1.13.
2917
2918         * efl/jhbuild.modules:
2919
2920 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2921
2922         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2923         https://bugs.webkit.org/show_bug.cgi?id=106650
2924
2925         Reviewed by Pavel Feldman.
2926
2927         Add separated m_devToolsTestInterfaces object to testShell which is
2928         bind to devTools webview.
2929
2930         * DumpRenderTree/chromium/TestShell.cpp:
2931         (TestShell::initialize):
2932         (TestShell::createMainWindow):
2933         (TestShell::~TestShell):
2934         (TestShell::showDevTools):
2935         (TestShell::resetTestController):
2936         (TestShell::bindJSObjectsToWindow):
2937         (TestShell::createNewWindow):
2938         * DumpRenderTree/chromium/TestShell.h:
2939         (TestShell):
2940
2941 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2942
2943         Sheriffbot command aliases need test cases
2944         https://bugs.webkit.org/show_bug.cgi?id=106754
2945
2946         Reviewed by Eric Seidel.
2947
2948         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2949         (SheriffBotTest.test_command_aliases):
2950
2951 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2952
2953         Allow users to misspell the "sheriffs" command in sheriffbot
2954         https://bugs.webkit.org/show_bug.cgi?id=106628
2955
2956         Reviewed by Steve Block.
2957
2958         * Scripts/webkitpy/tool/bot/irc_command.py:
2959
2960 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2961
2962         Make "gardeners" an alias for "sheriffs" in sherrifbot
2963         https://bugs.webkit.org/show_bug.cgi?id=106627
2964
2965         Reviewed by Eric Seidel.
2966
2967         * Scripts/webkitpy/tool/bot/irc_command.py:
2968
2969 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2970
2971         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2972         https://bugs.webkit.org/show_bug.cgi?id=105380
2973
2974         Reviewed by Eric Seidel.
2975
2976         Fix a regression introduced in r137692 where we were double-encoding
2977         the arguments to popen(); this was only an issue on windows, where
2978         we would try to encode something to mbcs, then try to encode it
2979         to unicode as if the input as ascii.
2980
2981         * Scripts/webkitpy/common/system/executive.py:
2982         (Executive.run_command):
2983
2984 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2985
2986         State who told sheriffbot to roll the Chromium deps and to what revision
2987         https://bugs.webkit.org/show_bug.cgi?id=106626
2988
2989         Reviewed by Eric Seidel.
2990
2991         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2992
2993         * Scripts/webkitpy/tool/bot/irc_command.py:
2994         (RollChromiumDEPS._expand_irc_nickname):
2995         (RollChromiumDEPS.execute):
2996         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2997         (IRCCommandTest.test_roll_chromium_deps):
2998         * Scripts/webkitpy/tool/bot/sheriff.py:
2999         (Sheriff.post_chromium_deps_roll):
3000         * Scripts/webkitpy/tool/commands/roll.py:
3001         (RollChromiumDEPS._prepare_state):
3002         (PostChromiumDEPSRoll):
3003         (PostChromiumDEPSRoll._prepare_state):
3004         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3005         (PostRollCommandsTest.test_prepare_state):
3006         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3007         (PrepareChangeLogForDEPSRoll.run):
3008
3009 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3010
3011         Add Alan Cutter as contributor
3012         https://bugs.webkit.org/show_bug.cgi?id=106747
3013
3014         Reviewed by Eric Seidel.
3015
3016         * Scripts/webkitpy/common/config/committers.py:
3017
3018 2013-01-13  Jonathan Liu  <net147@gmail.com>
3019
3020         Fix CONFIG missing link_pkgconfig on Windows
3021         https://bugs.webkit.org/show_bug.cgi?id=106647
3022
3023         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
3024         properly on Windows because they are added to PKGCONFIG but
3025         CONFIG does not contain link_pkgconfig.
3026
3027         This is because link_pkgconfig is added in unix/default_pre.prf
3028         which is only used for UNIX platforms. To fix this, move it to
3029         the general default_pre.prf.
3030
3031         Reviewed by Simon Hausmann.
3032
3033         * qmake/mkspecs/features/default_pre.prf:
3034         * qmake/mkspecs/features/unix/default_pre.prf:
3035
3036 2013-01-12  Nico Weber  <thakis@chromium.org>
3037
3038         nrwt/chromium: Don't prefer chromium over webkit build directories
3039         https://bugs.webkit.org/show_bug.cgi?id=105597
3040
3041         Reviewed by Dirk Pranke.
3042
3043         Rely on the new timestamp logic instead. Requested by dpranke in
3044         https://bugs.webkit.org/show_bug.cgi?id=105498
3045
3046         * Scripts/webkitpy/layout_tests/port/chromium.py:
3047         (ChromiumPort._static_build_path):
3048         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3049         (ChromiumLinuxPortTest.test_build_path):
3050         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3051         (ChromiumMacPortTest.test_build_path):
3052         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3053         (ChromiumWinTest.test_build_path):
3054
3055 2013-01-12  Nico Weber  <thakis@chromium.org>
3056
3057         Use ninja by default on Linux for build-webkit --chromium, bot edition
3058         https://bugs.webkit.org/show_bug.cgi?id=104434
3059
3060         Reviewed by Eric Seidel.
3061
3062         r139557 changed update-webkit to pick ninja by default on linux, but
3063         the bots run update-webkit-chromium directly so they didn't see this.
3064         Move the default for ninja into update-webkit-chromium so that it's
3065         picked up by the bots, and let update-webkit forward non-default
3066         options to there.
3067
3068         This way, the default is in one place only and both developers (who
3069         usually use update-webkit which then shells out to
3070         updat-webkit-chromium) and bots (which use update-webkit-chromium
3071         directly) see the same behavior.
3072
3073         * Scripts/update-webkit:
3074         * Scripts/update-webkit-chromium:
3075
3076 2013-01-12  Nico Weber  <thakis@chromium.org>
3077
3078         Make ninja the default build system on Linux for build-webkit --chromium
3079         https://bugs.webkit.org/show_bug.cgi?id=104434
3080
3081         Reviewed by Eric Seidel.
3082
3083         * Scripts/update-webkit:
3084
3085 2013-01-12  Alan Cutter  <alancutter@chromium.org>
3086
3087         Migrate the remaining bots in EC2 to Google Compute Engine
3088         https://bugs.webkit.org/show_bug.cgi?id=106005
3089
3090         Reviewed by Eric Seidel.
3091
3092         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
3093
3094         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
3095         * EWSTools/boot.sh:
3096         * EWSTools/build-repo.sh:
3097         * EWSTools/start-queue.sh:
3098
3099 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
3100
3101         [chromium] move inspector related methods to TestRunner library
3102         https://bugs.webkit.org/show_bug.cgi?id=106654
3103
3104         Reviewed by Adam Barth.
3105
3106         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3107         (DRTTestRunner::DRTTestRunner):
3108         * DumpRenderTree/chromium/DRTTestRunner.h:
3109         (DRTTestRunner):
3110         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3111         (WebTestRunner::WebTestDelegate::showDevTools):
3112         (WebTestRunner::WebTestDelegate::closeDevTools):
3113         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
3114         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3115         (WebTestRunner::TestRunner::TestRunner):
3116         (WebTestRunner::TestRunner::showWebInspector):
3117         (WebTestRunner):
3118         (WebTestRunner::TestRunner::closeWebInspector):
3119         (WebTestRunner::TestRunner::evaluateInWebInspector):
3120         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3121         (TestRunner):
3122         * DumpRenderTree/chromium/WebViewHost.cpp:
3123         (WebViewHost::showDevTools):
3124         (WebViewHost::closeDevTools):
3125         (WebViewHost::evaluateInWebInspector):
3126         * DumpRenderTree/chromium/WebViewHost.h:
3127         (WebViewHost):
3128
3129 2013-01-11  Julie Parent  <jparent@chromium.org>
3130
3131         Builder should not be a valid parameter for stats dashboard
3132         https://bugs.webkit.org/show_bug.cgi?id=106698
3133
3134         Reviewed by Dirk Pranke.
3135         
3136         Since builder is a dashboard specific parameter, dashboard_base
3137         should not be handling it in handleValidHashParameterWrapper, rather,
3138         each specific dashboard should in its handleValidHashParameter function.
3139     
3140         Note that the FIXME in dashboard_base about this was actually wrong -
3141         we don't want to move it to g_crossDashboardState, because it isn't
3142         actually cross dashboard state.
3143         
3144         In fact, flakiness and treemap have the code in 
3145         handleValidHashParameter, but it is currently dead code because 
3146         dashboard_base gets to it first.
3147         
3148         Added the proper handling to timeline_explorer, since builder is
3149         valid there.
3150
3151         * TestResultServer/static-dashboards/dashboard_base.js:
3152         * TestResultServer/static-dashboards/timeline_explorer.html:
3153
3154 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
3157         https://bugs.webkit.org/show_bug.cgi?id=106688
3158
3159         Reviewed by Eric Seidel.
3160
3161         Update the regular expression used to strip the garbage at the beginning.
3162
3163         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3164         (RunWebKitTests.nrwt_log_message_regexp):
3165
3166 2013-01-11  Pratik Solanki  <psolanki@apple.com>
3167
3168         TestRunner leaks when running tests
3169         https://bugs.webkit.org/show_bug.cgi?id=106683
3170
3171         Reviewed by Simon Fraser.
3172
3173         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
3174         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
3175         tests.
3176
3177         * DumpRenderTree/TestRunner.cpp:
3178         (TestRunner::makeWindowObject):
3179
3180 2013-01-11  Julie Parent  <jparent@chromium.org>
3181
3182         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
3183         https://bugs.webkit.org/show_bug.cgi?id=106247
3184
3185         Old code nulled out the loader instance when it completed loading and
3186         then later used the fact that it was null to determine if it had loaded
3187         or not.  This is not only unintuitive, but it also prevents using the
3188         loader object later on.
3189         
3190         Added new method, used it, added unit test for it.
3191         
3192         Reviewed by Dirk Pranke.
3193
3194         * TestResultServer/static-dashboards/dashboard_base.js:
3195         (resourceLoadingComplete):
3196         (handleLocationChange):
3197         * TestResultServer/static-dashboards/loader.js:
3198         (.):
3199         * TestResultServer/static-dashboards/loader_unittests.js:
3200
3201 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3202
3203         Try CRLF to LF change in r139407 again.
3204
3205         * BuildSlaveSupport/delete-stale-build-files:
3206         (main):
3207         (webkitBuildDirectory):
3208         * BuildSlaveSupport/kill-old-processes:
3209         (main):
3210
3211 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3212
3213         [GTK] Disable the unit tests timeout when running from make check
3214         https://bugs.webkit.org/show_bug.cgi?id=106670
3215
3216         Reviewed by Philippe Normand.
3217
3218         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
3219
3220 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3221
3222         Yet another unreviewed fix after r139431.
3223
3224         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
3225         the correct order.
3226
3227 2013-01-11  Dan Carney  <dcarney@google.com>
3228
3229         [chromium] move some whitespace and resize related methods to TestRunner library
3230         https://bugs.webkit.org/show_bug.cgi?id=106655
3231
3232         Reviewed by Jochen Eisinger.
3233
3234         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3235         (DRTTestRunner::DRTTestRunner):
3236         * DumpRenderTree/chromium/DRTTestRunner.h:
3237         (DRTTestRunner):
3238         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3239         (WebKit):
3240         (WebTestRunner::WebTestDelegate::setClientWindowRect):
3241         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
3242         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
3243         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3244         (WebTestRunner::TestRunner::TestRunner):
3245         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
3246         (WebTestRunner):
3247         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
3248         (WebTestRunner::TestRunner::enableAutoResizeMode):
3249         (WebTestRunner::TestRunner::disableAutoResizeMode):
3250         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3251         (TestRunner):
3252         * DumpRenderTree/chromium/WebViewHost.cpp:
3253         (WebViewHost::setClientWindowRect):
3254         * DumpRenderTree/chromium/WebViewHost.h:
3255         (WebViewHost):
3256
3257 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3258
3259         Unreviewed. Update my e-mail addresses.
3260
3261         * Scripts/webkitpy/common/config/committers.py:
3262
3263 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3264
3265         Another unreviewed fix after r139431.
3266
3267         In a way, this is also a generic bug fix, since previously isEfl()
3268         would fail when called from run-efl-tests and we thus did not use
3269         jhbuild to run our tests. This now resulted in us calling
3270         "jhbuild-wrapper run" without specifying a platform.
3271
3272         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3273         to work.
3274
3275 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3276
3277         [Qt][WK1] Web Audio support
3278         https://bugs.webkit.org/show_bug.cgi?id=106651
3279
3280         Reviewed by Jocelyn Turcotte.
3281
3282         Implements support for dumping audio data in DumpRenderTree.
3283
3284         Adds WebAudio to toggleable features in QtTestBrowser.
3285
3286         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3287         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3288
3289         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3290         (WebCore::DumpRenderTree::dump):
3291         * DumpRenderTree/qt/TestRunnerQt.cpp:
3292         (TestRunner::reset):
3293         (TestRunner::overridePreference):
3294         (TestRunner::setAudioData):
3295         * DumpRenderTree/qt/TestRunnerQt.h:
3296         (TestRunner::shouldDumpAsAudio):
3297         (TestRunner::audioData):
3298         (TestRunner):
3299         * QtTestBrowser/launcherwindow.cpp:
3300         (LauncherWindow::applyPrefs):
3301         (LauncherWindow::createChrome):
3302         (LauncherWindow::toggleWebAudio):
3303         * QtTestBrowser/launcherwindow.h:
3304         (WindowOptions::WindowOptions):
3305         (WindowOptions):
3306         (LauncherWindow):
3307         * qmake/mkspecs/features/features.prf:
3308         * qmake/mkspecs/features/features.pri:
3309
3310 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3311
3312         Unreviewed jhbuild-related fix after r139431.
3313
3314         * Scripts/webkitpy/layout_tests/port/efl.py:
3315         (EflPort.__init__): Pass a string to set_option_default(), since
3316         shlex.split() will be called on it later.
3317
3318 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3319
3320         Unreviewed typo fixes after r139431.
3321
3322         * Scripts/run-javascriptcore-tests:
3323
3324 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3325
3326         [jhbuild] Remove the "run-with-jhbuild" scripts.
3327         https://bugs.webkit.org/show_bug.cgi?id=106572
3328
3329         Reviewed by Martin Robinson.
3330
3331         Both ports which use jhbuild were mostly duplicating the
3332         `run-with-jhbuild' script in their own directories for no clear reason.
3333
3334         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3335         so just start using that directly and get rid of a useless middle man.
3336
3337         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3338         instead.
3339
3340         * Scripts/run-javascriptcore-tests:
3341         * Scripts/run-launcher:
3342         * Scripts/webkitdirs.pm:
3343         (runAutogenForAutotoolsProjectIfNecessary):
3344         (buildAutotoolsProject):
3345         (jhbuildWrapperPrefixIfNeeded):
3346         (generateBuildSystemFromCMakeProject):
3347         (buildCMakeGeneratedProject):
3348         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3349         (run):
3350         * Scripts/webkitpy/layout_tests/port/efl.py:
3351         (EflPort.__init__):
3352         (EflPort._image_diff_command):
3353         * efl/run-with-jhbuild: Removed.
3354         * gtk/run-with-jhbuild: Removed.
3355
3356 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3357
3358         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3359         https://bugs.webkit.org/show_bug.cgi?id=106636
3360
3361         Reviewed by Adam Barth.
3362
3363         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3364
3365         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3366         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3367         * EWSTools/screen-config:
3368         * EWSTools/start-queue.sh:
3369
3370 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3371
3372         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3373         https://bugs.webkit.org/show_bug.cgi?id=106622
3374
3375         Reviewed by Simon Fraser.
3376
3377         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3378         Also escape clang\+\+ correctly in kill-old-processes.
3379
3380         * BuildSlaveSupport/delete-stale-build-files:
3381         * BuildSlaveSupport/kill-old-processes:
3382
3383 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3384
3385         Build fix after r139357. It was missing a comma.
3386
3387         * QueueStatusServer/model/queues.py:
3388         (Queue):
3389
3390 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3391
3392         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3393         https://bugs.webkit.org/show_bug.cgi?id=106420
3394
3395         Reviewed by Eric Seidel.
3396
3397         * Scripts/webkitpy/common/checkout/scm/git.py:
3398         (Git.push_local_commits_to_server):
3399         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3400         * Scripts/webkitpy/common/checkout/scm/svn.py:
3401         (SVNRepository):
3402         (SVNRepository.has_authorization_for_realm):
3403
3404 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3405
3406         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3407         https://bugs.webkit.org/show_bug.cgi?id=106552
3408
3409         Reviewed by Laszlo Gombos.
3410
3411         Use tarballs for gstreamer instead of git in EFL's jhbuild
3412         to work around intermittent network issues on our build
3413         bots. Tarballs are fully cached and require no network
3414         operation if their checksum matches.
3415
3416         * efl/jhbuild.modules:
3417
3418 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3419
3420         Add Mac WK2 EWS bots
3421         https://bugs.webkit.org/show_bug.cgi?id=106590
3422
3423         Reviewed by Adam Barth.
3424
3425         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
3426         Also add a deprecated MacWK2Port class.
3427
3428         * QueueStatusServer/model/queues.py:
3429         (Queue):
3430         * Scripts/webkitpy/common/config/ports.py:
3431         (DeprecatedPort.port):
3432         (MacWK2Port):
3433         (MacWK2Port.run_webkit_tests_command):
3434         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3435         (MacEWS):
3436         (MacWK2EWS):
3437         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3438         (_test_ewses):
3439
3440 2013-01-10  Dan Carney  <dcarney@google.com>
3441
3442         [chromium] move webpermissionclient related methods to TestRunner library
3443         https://bugs.webkit.org/show_bug.cgi?id=106548
3444
3445         Reviewed by Jochen Eisinger.
3446
3447         * DumpRenderTree/DumpRenderTree.gypi:
3448         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3449         (DRTTestRunner::DRTTestRunner):
3450         (DRTTestRunner::reset):
3451         * DumpRenderTree/chromium/DRTTestRunner.h:
3452         (DRTTestRunner):
3453         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3454         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
3455         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3456         (WebKit):
3457         (WebTestRunner::WebTestRunner::webPermissions):
3458         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3459         (WebTestRunner::TestRunner::TestRunner):
3460         (WebTestRunner::TestRunner::setDelegate):
3461         (WebTestRunner):
3462         (WebTestRunner::TestRunner::reset):
3463         (WebTestRunner::TestRunner::webPermissions):
3464         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
3465         (WebTestRunner::TestRunner::setImagesAllowed):
3466         (WebTestRunner::TestRunner::setScriptsAllowed):
3467         (WebTestRunner::TestRunner::setStorageAllowed):
3468         (WebTestRunner::TestRunner::setPluginsAllowed):
3469         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
3470         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
3471         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3472         (WebTestRunner):
3473         (TestRunner):
3474         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
3475         (WebTestRunner):
3476         (WebTestRunner::WebPermissions::WebPermissions):
3477         (WebTestRunner::WebPermissions::~WebPermissions):
3478         (WebTestRunner::WebPermissions::allowImage):
3479         (WebTestRunner::WebPermissions::allowScriptFromSource):
3480         (WebTestRunner::WebPermissions::allowStorage):
3481         (WebTestRunner::WebPermissions::allowPlugins):
3482         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
3483         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
3484         (WebTestRunner::WebPermissions::setImagesAllowed):
3485         (WebTestRunner::WebPermissions::setScriptsAllowed):
3486         (WebTestRunner::WebPermissions::setStorageAllowed):
3487         (WebTestRunner::WebPermissions::setPluginsAllowed):
3488         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
3489         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
3490         (WebTestRunner::WebPermissions::setDelegate):
3491         (WebTestRunner::WebPermissions::setDumpCallbacks):
3492         (WebTestRunner::WebPermissions::reset):
3493         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
3494         (WebTestRunner):
3495         (WebPermissions):
3496         * DumpRenderTree/chromium/TestShell.cpp:
3497         (TestShell::initialize):
3498         (TestShell::resetTestController):
3499         (TestShell::createNewWindow):
3500         * DumpRenderTree/chromium/TestShell.h:
3501         (TestShell):
3502         * DumpRenderTree/chromium/WebViewHost.cpp:
3503         (WebViewHost::normalizeLayoutTestURL):
3504         * DumpRenderTree/chromium/WebViewHost.h:
3505         (WebViewHost):
3506
3507 2013-01-10  Alan Cutter  <alancutter@chromium.org>
3508
3509         Split EWS tool cold-boot.sh into modular components
3510         https://bugs.webkit.org/show_bug.cgi?id=106527
3511
3512         Reviewed by Adam Barth.
3513
3514         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
3515         Updated GCE bot build scripts to match.
3516         Unable to test scripts directly as they depend on being in the repository to work!
3517
3518         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3519         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3520         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3521         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
3522         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
3523
3524 2013-01-10  Julie Parent  <jparent@chromium.org>
3525
3526         Dashboard Cleanup: Do not generate the page if we are about to reload.
3527         https://bugs.webkit.org/show_bug.cgi?id=106584
3528
3529         Reviewed by Dirk Pranke.
3530
3531         Move the logic to determine if we should generate the page into
3532         parseParameters() since that is where we have the knowledge to
3533         determine it, and return that value to handleLocationChange, 
3534         rather than passing the changed parameters back to handleLocationChange
3535         and having it make the decision.
3536         
3537         This is logically equivalent, save one case: when we are about to do
3538         a reload, we know that there is no reason to generate the page.  Old
3539         code was causing an extra page generation in this case.
3540         
3541         * TestResultServer/static-dashboards/dashboard_base.js:
3542         (parseParameters):
3543         (handleLocationChange):
3544
3545 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3546
3547         [jhbuild] Use the "configure" script to build glib
3548         https://bugs.webkit.org/show_bug.cgi?id=106569
3549
3550         Reviewed by Martin Robinson.
3551
3552         So far both EFL and GTK have been using autogen.sh to build glib.
3553         While that does work most of the time, it's not really needed since
3554         we are downloading and building stable releases from tarballs.
3555         Additionally, autogen.sh fails to work with automake 1.13 due to the
3556         usage of some macros that have been removed (this has already been
3557         fixed in glib master).
3558
3559         * efl/jhbuild.modules:
3560         * gtk/jhbuild.modules:
3561
3562 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3563
3564         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3565         (Missed a couple)
3566         https://bugs.webkit.org/show_bug.cgi?id=106536
3567
3568         Reviewed by Eric Seidel.
3569
3570         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3571
3572 2013-01-10  Tony Chang  <tony@chromium.org>
3573
3574         Speed up supplemental dependency computation
3575         https://bugs.webkit.org/show_bug.cgi?id=106503
3576
3577         Reviewed by Adam Barth.
3578
3579         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
3580
3581         * WebKitTestRunner/CMakeLists.txt:
3582
3583 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
3584
3585         Remove the ENABLE_ANIMATION_API feature define occurences
3586         https://bugs.webkit.org/show_bug.cgi?id=106544
3587
3588         Reviewed by Simon Fraser.
3589
3590         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
3591         feature define handling still lingers in various build systems and configurations
3592         but is of no use, so it should be removed.
3593
3594         * Scripts/webkitperl/FeatureList.pm:
3595         * qmake/mkspecs/features/features.pri:
3596
3597 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3598
3599         [GTK] Add support for loading web process extensions
3600         https://bugs.webkit.org/show_bug.cgi?id=105631
3601
3602         Reviewed by Gustavo Noronha Silva.
3603
3604         * MiniBrowser/gtk/GNUmakefile.am:
3605         * MiniBrowser/gtk/main.c:
3606         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
3607         bundle lib from build dir.
3608         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
3609         located in WebProcess/InjectedBundle/API/gtk.
3610         * gtk/generate-gtkdoc:
3611         (get_webkit2_options): Scan also files in
3612         WebProcess/InjectedBundle/API/gtk to generate API docs.
3613         (get_webkit2_options.injected_bundle_src_path): Helper function to
3614         build paths in WebProcess/InjectedBundle/API/gtk.
3615
3616 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3617
3618         [EFL][WK2] Writing immediately to created windows (open) fails
3619         https://bugs.webkit.org/show_bug.cgi?id=105276
3620
3621         Reviewed by Kenneth Rohde Christiansen.
3622
3623         Do not reset 'about:blank' url for the new pages in mini browser.
3624
3625         * MiniBrowser/efl/main.c:
3626         (window_create):
3627
3628 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3629
3630         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3631         https://bugs.webkit.org/show_bug.cgi?id=106536
3632
3633         Reviewed by Eric Seidel.
3634
3635         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3636
3637 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3638
3639         Converting to unittest2 so we can use assertItemsEqual, making tests
3640         not dependent on order of items.
3641         https://bugs.webkit.org/show_bug.cgi?id=106532
3642
3643         Before:
3644         Ran 1733 tests in 38.385s
3645         FAILED (failures=1, errors=22)
3646
3647         After:
3648         Ran 1733 tests in 32.298s
3649         FAILED (failures=0, errors=22)
3650
3651         Reviewed by Eric Seidel.
3652
3653         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3654         * Scripts/webkitpy/thirdparty/__init__.py:
3655         (AutoinstallImportHook._install_unittest2):
3656
3657 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3658
3659         [EFL] Add gstreamer 1.0.5 to jhbuild
3660         https://bugs.webkit.org/show_bug.cgi?id=106178
3661
3662         Reviewed by Laszlo Gombos.
3663
3664         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
3665
3666         * efl/jhbuild.modules:
3667
3668 2013-01-09  Alan Cutter  <alancutter@chromium.org>
3669
3670         Updated parameters in GCE build scripts so they now work.
3671         https://bugs.webkit.org/show_bug.cgi?id=106523
3672
3673         Reviewed by Adam Barth.
3674
3675         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3676         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3677         * EWSTools/cold-boot.sh:
3678
3679 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
3680
3681         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
3682         https://bugs.webkit.org/show_bug.cgi?id=106520
3683
3684         Reviewed by James Robinson.
3685
3686         Part of a larger refactoring series. See tracking bug 82948.
3687
3688         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3689         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: