575de6b36c0f36fff10ed1cd91c5f7919380d42f
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-23  Johnny Ding  <jnd@chromium.org>
2
3         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
4         https://bugs.webkit.org/show_bug.cgi?id=72950
5
6         Reviewed by Tony Chang.
7
8         * DumpRenderTree/chromium/LayoutTestController.cpp:
9         (LayoutTestController::queueLoadHTMLString):
10
11 2011-11-23  Adam Barth  <abarth@webkit.org>
12
13         garden-o-matic should display a message if it can't find results to display
14         https://bugs.webkit.org/show_bug.cgi?id=72991
15
16         Reviewed by Dimitri Glazkov.
17
18         Not all failures (e.g., TIMEOUT) have results that we can display.
19         This patch adds a short message so that the user can see that we're
20         done trying to load the results.
21
22         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
23         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
24         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
25
26 2011-11-23  Adam Barth  <abarth@webkit.org>
27
28         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
29         https://bugs.webkit.org/show_bug.cgi?id=72992
30
31         Reviewed by Dimitri Glazkov.
32
33         This patch also prepares us to list other sorts of failures, like
34         performance and unit test.
35
36         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
37         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
38         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
39         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
40
41 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
42
43         Add new Chromium tests to the flakiness dashboard
44         https://bugs.webkit.org/show_bug.cgi?id=72997
45
46         Reviewed by Ojan Vafai.
47
48         * TestResultServer/static-dashboards/dashboard_base.js:
49         ():
50
51 2011-11-23  Adam Barth  <abarth@webkit.org>
52
53         garden-o-matic should support AUDIO failures
54         https://bugs.webkit.org/show_bug.cgi?id=69477
55
56         Reviewed by Dimitri Glazkov.
57
58         This is a first iteration at supporting AUDIO failures in
59         garden-o-matic.  We'll probably need to iterate a bit when we have a
60         real audio failure in the tree to play with.  For example, we'll
61         probably want to add and <audio> element to the "Examine" view to hear
62         the differences, but that all can be done in a subsequent patch.
63
64         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
65
66 2011-11-23  Scott Graham  <scottmg@chromium.org>
67
68         Adding gamepad support
69         https://bugs.webkit.org/show_bug.cgi?id=69451
70
71         Reviewed by Darin Fisher.
72
73         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
74         gamepad data that will be retrieved when JS code pulls via API access.
75
76         * DumpRenderTree/DumpRenderTree.gypi:
77         * DumpRenderTree/chromium/GamepadController.cpp: Added.
78         (GamepadController::GamepadController):
79         (GamepadController::bindToJavascript):
80         (GamepadController::reset):
81         (GamepadController::connect):
82         (GamepadController::disconnect):
83         (GamepadController::setId):
84         (GamepadController::setButtonCount):
85         (GamepadController::setButtonData):
86         (GamepadController::setAxisCount):
87         (GamepadController::setAxisData):
88         (GamepadController::fallbackCallback):
89         * DumpRenderTree/chromium/GamepadController.h: Added.
90         * DumpRenderTree/chromium/TestShell.cpp:
91         (TestShell::TestShell):
92         (TestShell::resetTestController):
93         (TestShell::bindJSObjectsToWindow):
94         * DumpRenderTree/chromium/TestShell.h:
95         (TestShell::gamepadController):
96
97 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
98
99         [CMake] Move the top-level logic to the top-level directory.
100         https://bugs.webkit.org/show_bug.cgi?id=72685
101
102         Reviewed by Brent Fulgham.
103
104         * CMakeLists.txt: Added.
105         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
106         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
107         * Scripts/webkitdirs.pm:
108         (generateBuildSystemFromCMakeProject):
109         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
110
111 2011-11-17  Vincent Scheib  <scheib@chromium.org>
112
113         Pointer Lock: Initial Tests for navigator.webkitPonter
114         https://bugs.webkit.org/show_bug.cgi?id=72659
115
116         Reviewed by Darin Fisher.
117
118         * DumpRenderTree/chromium/TestShell.cpp:
119         (TestShell::TestShell):
120             Enabling PointerLock in TestShell
121
122 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
123
124         Update flakiness dashboard for new Chromium builders and tests
125         https://bugs.webkit.org/show_bug.cgi?id=72931
126
127         Reviewed by Ojan Vafai.
128
129         * TestResultServer/static-dashboards/builders.js:
130         * TestResultServer/static-dashboards/dashboard_base.js:
131
132 2011-11-22  Adam Roben  <aroben@apple.com>
133
134         Remove some debugging code I accidentally left in r101005
135
136         * Scripts/prepare-ChangeLog:
137         (get_function_line_ranges_for_python):
138
139 2011-11-22  Adam Roben  <aroben@apple.com>
140
141         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
142
143         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
144         classes/methods in Python source files
145
146         Reviewed by Dan Bates.
147
148         * Scripts/prepare-ChangeLog:
149         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
150         or that use python as their interpreter. Modified the code that extracts the interpreter to
151         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
152         scripts.
153         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
154         for class/def lines and generate ranges based on them.
155
156 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
157
158         [GTK] Enable WebSocket hybi tests
159         https://bugs.webkit.org/show_bug.cgi?id=72870
160
161         Reviewed by Xan Lopez.
162
163         * DumpRenderTree/gtk/DumpRenderTree.cpp:
164         (resetDefaultsToConsistentValues):
165         Reset the setting value to the default value (true).
166         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
167         (LayoutTestController::overridePreference):
168         Change the setting value through a function in DumpRenderTreeSupportGtk.
169
170 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
171
172         ChangeLogEntry should be able to parse entries with multiple authors
173         https://bugs.webkit.org/show_bug.cgi?id=72690
174
175         Reviewed by Eric Seidel.
176
177         Support multi-author change log entries in ChangeLogEntry. Split author names using
178         the same logic as splitting reviewer names. _authors now stores list of dictionaries
179         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
180         accounts because some contributors are never listed in committers.py. 
181
182         * Scripts/webkitpy/common/checkout/changelog.py:
183         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
184         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
185         throws an exception when the argument is None.
186
187 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
188
189         [Qt] Speed up debug builds.
190         https://bugs.webkit.org/show_bug.cgi?id=72882
191
192         Reviewed by Tor Arne Vestbø.
193
194         Introduce a special type of build that replaces the static jsc/wc/wk2
195         static libraries with shared libraries, that individually are much faster
196         to link and don't require relinking into the big library when changing just
197         one file in one module. It can be enabled with
198         --qmakearg="CONFIG+=force_static_libs_as_shared"
199
200         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
201         disable symbol visibility, static linkage and enable rpath.
202         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
203         we need to link the convenience libraries together or not and renamed linkStaticLibrary
204         to just linkLibrary (because linkage is not necessarily static).
205         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
206         link against jsc/wc/wk2 when linking app code against QtWebKit.
207         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
208         function.
209         * qmake/mkspecs/features/webcore.prf: Ditto.
210         * qmake/mkspecs/features/webkit2.prf: Ditto.
211
212 2011-11-21  Adam Klein  <adamk@chromium.org>
213
214         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
215         https://bugs.webkit.org/show_bug.cgi?id=72898
216
217         Reviewed by Ojan Vafai.
218
219         Also removed a comment that was going to be more trouble to keep up to
220         date than seemed worthwhile (the code is now the documentation).
221
222         * TestResultServer/static-dashboards/flakiness_dashboard.html:
223
224 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
225
226         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
227         https://bugs.webkit.org/show_bug.cgi?id=72895
228
229         Reviewed by Chris Fleizach.
230
231         * DumpRenderTree/chromium/WebViewHost.cpp:
232         (WebViewHost::postAccessibilityNotification):
233
234 2011-11-21  Philippe Normand  <pnormand@igalia.com>
235
236         Unreviewed, run-gtk-tests temporary workaround after r98500.
237
238         * Scripts/run-gtk-tests: Try to find the build directory like in
239         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
240
241 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
242
243         [GTK] Add a way to skip unit tests in the bots
244         https://bugs.webkit.org/show_bug.cgi?id=72879
245
246         Reviewed by Philippe Normand.
247
248         Rewrite the script in python to make it easier for everybody to
249         change it and add support for skipping tests.
250
251         * Scripts/run-gtk-tests:
252
253 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
254
255         [EFL] Add more appcache functions to ewk_settings.
256         https://bugs.webkit.org/show_bug.cgi?id=72143
257
258         Reviewed by Kenneth Rohde Christiansen.
259
260         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
261         (LayoutTestController::clearAllApplicationCaches):
262         (LayoutTestController::setAppCacheMaximumSize): Use the right
263         function, this is not related to the memory cache, but rather to the
264         appcache.
265
266 2011-11-18  Adam Roben  <aroben@apple.com>
267
268         Make NRWT consider all lines of output from parse-malloc-history, not just the first
269
270         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
271         found" even when there are more than 1 unique leaks
272
273         Reviewed by Darin Adler.
274
275         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
276         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
277         "^" will be considered to match the beginning of any line, not only the beginning of the
278         string.
279
280         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
281         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
282         fake output and updated expectations to match.
283
284 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
285
286         [Qt] Clean up MiniBrowser project file after recent changes
287         https://bugs.webkit.org/show_bug.cgi?id=72869
288
289         Reviewed by Simon Hausmann.
290
291         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
292
293         * MiniBrowser/qt/MiniBrowser.pro:
294
295 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
296
297         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
298         https://bugs.webkit.org/show_bug.cgi?id=72479
299
300         Reviewed by Chris Fleizach.
301
302         * DumpRenderTree/AccessibilityUIElement.cpp:
303         (getIsSelectedOptionActiveCallback):
304         (AccessibilityUIElement::getJSClass):
305         * DumpRenderTree/AccessibilityUIElement.h:
306         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
307         (AccessibilityUIElement::AccessibilityUIElement):
308         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
309         * DumpRenderTree/chromium/AccessibilityUIElement.h:
310         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
311         (AccessibilityUIElement::isSelectedOptionActive):
312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
313         (AccessibilityUIElement::isSelectedOptionActive):
314         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
315         (AccessibilityUIElement::isSelectedOptionActive):
316
317 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
318
319         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
320         https://bugs.webkit.org/show_bug.cgi?id=72859
321
322         Reviewed by Eric Seidel.
323         
324         * Scripts/new-run-webkit-websocketserver:
325
326 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
327
328         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
329         https://bugs.webkit.org/show_bug.cgi?id=72655
330
331         Reviewed by Hajime Morita.
332
333         Fixed the calculation of offset.
334
335         * DumpRenderTree/chromium/WebViewHost.cpp:
336         (WebViewHost::finishLastTextCheck):
337
338 2011-11-20  Ojan Vafai  <ojan@chromium.org>
339
340         Change the final place where we use version 3 of the results json output
341         https://bugs.webkit.org/show_bug.cgi?id=72838
342
343         Reviewed by Adam Barth.
344
345         This converts the json from being a flat map of test name --> results
346         to being hierarchical by directory. This will make the json files 
347         considerably smaller.
348
349         Also cleaned up some functions that were returning/checking boolean values
350         that were always True.
351
352         * TestResultServer/model/jsonresults.py:
353         * TestResultServer/model/jsonresults_unittest.py:
354
355 2011-11-20  Ojan Vafai  <ojan@chromium.org>
356
357         Include the master name when querying the test results server.
358         This will soon be required since leaving the master name out mean
359         that multiple files could match the query.
360
361         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
362
363 2011-11-19  Ojan Vafai  <ojan@chromium.org>
364
365         Fix jsonp callback code to add the callback if json content
366         is not jsonp.
367         * TestResultServer/handlers/testfilehandler.py:
368
369 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
370
371         Modify dashboard_base.js to optionally accept version 4 results json.
372
373         Reviewed by Ojan Vafai.
374
375         * TestResultServer/static-dashboards/dashboard_base.js:
376         (ADD_RESULTS):
377         (flattenTrie):
378         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
379         (testFlattenTrie):
380
381 2011-11-19  Ojan Vafai  <ojan@chromium.org>
382
383         Stop storing results files as jsonp in the test results server
384         https://bugs.webkit.org/show_bug.cgi?id=72814
385
386         Reviewed by Adam Barth.
387
388         * TestResultServer/model/jsonresults.py:
389         * TestResultServer/model/jsonresults_unittest.py:
390
391 2011-11-19  Ojan Vafai  <ojan@chromium.org>
392
393         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
394         https://bugs.webkit.org/show_bug.cgi?id=72813
395
396         Reviewed by Adam Barth.
397
398         Once this lands, we can start storing pure json in the test results server and then
399         we can delete the code with all the FIXMEs added here.
400
401         * Scripts/webkitpy/layout_tests/controllers/manager.py:
402         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
403         Only add jsonp for full_results.json.
404         * TestResultServer/model/jsonresults.py:
405         * TestResultServer/model/jsonresults_unittest.py:
406         Accept pure json uploads.
407         * TestResultServer/static-dashboards/dashboard_base.js:
408         (appendJSONScriptElementFor):
409         Use the callback parameter so that the server can start returning pure json if it's left out.
410
411 2011-11-19  Ojan Vafai  <ojan@chromium.org>
412
413         Allow json NRWT downloads to be pure json and not jsonp
414         https://bugs.webkit.org/show_bug.cgi?id=72809
415
416         Reviewed by Adam Barth.
417
418         I'm moving the server to storing and serving up raw json instead of jsonp.
419         You can still get the jsonp by passing a "callback" parameter, but there's no
420         need for run-webkit-tests to get jsonp when all it wants is the raw json.
421
422         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
423         Make the wrapper stripping only happen if the json is actually wrapped.
424         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
425
426 2011-11-18  Daniel Bates  <dbates@rim.com>
427
428         Add CMake build infrastructure for the BlackBerry port
429         https://bugs.webkit.org/show_bug.cgi?id=72768
430
431         Reviewed by Antonio Gomes.
432
433         Add optional --blackberry command line argument to build-webkit to build the
434         BlackBerry port.
435
436         * Scripts/build-webkit:
437         * Scripts/webkitdirs.pm:
438         (determineBaseProductDir):
439         (argumentsForConfiguration):
440         (builtDylibPathForName):
441         (determineIsQt):
442         (isBlackBerry): Added.
443         (determineIsBlackBerry): Added.
444         (blackberryTargetArchitecture): Added.
445         (isAppleWebKit):
446
447 2011-11-18  James Robinson  <jamesr@chromium.org>
448
449         Unreviewed, rolling out r100835.
450         http://trac.webkit.org/changeset/100835
451         https://bugs.webkit.org/show_bug.cgi?id=72778
452
453         Broke some page scale tests
454
455         * DumpRenderTree/chromium/EventSender.cpp:
456         (EventSender::scalePageBy):
457
458 2011-11-18  Adam Barth  <abarth@webkit.org>
459
460         Prepare to move manual-tests out of WebCore
461         https://bugs.webkit.org/show_bug.cgi?id=72782
462
463         Reviewed by Eric Seidel.
464
465         Update this file to refer to the new location of ManualTests.
466
467         * Scripts/webkitpy/common/config/build.py:
468
469 2011-11-18  James Robinson  <jamesr@chromium.org>
470
471         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
472         https://bugs.webkit.org/show_bug.cgi?id=72778
473
474         Reviewed by Kenneth Russell.
475
476         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
477
478         * DumpRenderTree/chromium/EventSender.cpp:
479         (EventSender::scalePageBy):
480
481 2011-11-18  Scott Graham  <scottmg@chromium.org>
482
483         IDL changes for gamepad support
484         https://bugs.webkit.org/show_bug.cgi?id=71753
485
486         Reviewed by Adam Barth.
487
488         Runtime enable gamepad in chromium test shell.
489
490         * DumpRenderTree/chromium/TestShell.cpp:
491         (TestShell::TestShell):
492
493 2011-10-27  Darin Fisher  <darin@chromium.org>
494
495         [chromium] Improve fullscreen API
496         https://bugs.webkit.org/show_bug.cgi?id=70477
497
498         Reviewed by Adam Barth.
499
500         Implement enter/exitFullScreen.  The implementation is asynchronous,
501         via postDelayedTask, to simulate how the browser actually behaves.
502
503         * DumpRenderTree/chromium/WebViewHost.cpp:
504         (WebViewHost::enterFullScreen):
505         (WebViewHost::exitFullScreen):
506         (WebViewHost::setAddressBarURL):
507         (WebViewHost::enterFullScreenNow):
508         (WebViewHost::exitFullScreenNow):
509         * DumpRenderTree/chromium/WebViewHost.h:
510
511 2011-11-18  Adam Roben  <aroben@apple.com>
512
513         Ignore an ANGLE leak that is not WebKit's fault
514
515         * Scripts/old-run-webkit-tests:
516         (countAndPrintLeaks):
517         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
518         (LeakDetector._callstacks_to_exclude_from_leaks):
519         Added ScanFromString to the call stacks to exclude on all OS versions.
520
521 2011-11-18  Adam Roben  <aroben@apple.com>
522
523         Ignore another Lion-specific leak that is not WebKit's fault
524
525         * Scripts/old-run-webkit-tests:
526         (countAndPrintLeaks):
527         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
528         (LeakDetector._callstacks_to_exclude_from_leaks):
529         Added SecTransformExecute to the call stacks to exclude.
530
531 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
532
533         [Qt] Enable WebSocket hybi tests
534         https://bugs.webkit.org/show_bug.cgi?id=72687
535
536         Reviewed by Simon Hausmann.
537
538         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
539
540         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
541         (WebCore::WebPage::resetSettings):
542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
543         (LayoutTestController::overridePreference):
544
545 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
546
547         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
548         https://bugs.webkit.org/show_bug.cgi?id=72707
549
550         Reviewed by Philippe Normand.
551
552         Make new-run-webkit-tests use the right path to locate the test
553         plugin used by WebKitTestRunner.
554
555         * Scripts/webkitpy/layout_tests/port/gtk.py:
556
557 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
558
559         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
560         https://bugs.webkit.org/show_bug.cgi?id=72697
561
562         Reviewed by Kenneth Rohde Christiansen.
563
564         * Tools.pro: Make WTR linux only for the moment.
565         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
566         * WebKitTestRunner/Target.pri: Ditto.
567         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
568         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
569
570 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
571
572         [Qt] Change default size of the MiniBrowser
573
574         Reviewed by Simon Hausmann.
575
576         As we lay out desktop pages using the width of 980, change our default
577         size to 980x735 so that we are not scaling down by default.
578
579         * MiniBrowser/qt/MiniBrowserApplication.h:
580         (WindowOptions::WindowOptions):
581
582 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
583
584         [EFL] Clean up the use of DATA_DIR in the buildsystem
585         https://bugs.webkit.org/show_bug.cgi?id=72681
586
587         Reviewed by Daniel Bates.
588
589         Instead of adding -DDATA_DIR in all scopes, only define it in
590         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
591         it.
592
593         We can then define DATA_DIR to the generated theme directory for
594         EWebLauncher, since it's what we want here.
595
596         * CMakeListsEfl.txt:
597
598 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
599
600         [EFL] Move platform includes last in DRT's include directories.
601         https://bugs.webkit.org/show_bug.cgi?id=72684
602
603         Reviewed by Daniel Bates.
604
605         This is the first step in fixing the build when a platform include (in
606         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
607         is included instead of WebKit's.
608
609         * DumpRenderTree/efl/CMakeLists.txt:
610
611 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
612
613         fuzzy_match doesn't recognize "Dan B" or "hyatt"
614         https://bugs.webkit.org/show_bug.cgi?id=72636
615
616         Reviewed by Eric Seidel.
617
618         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
619         and user names of email addreses such as rniwa in rniwa@webkit.org.
620
621         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
622
623         * Scripts/webkitpy/common/config/committers.py:
624         * Scripts/webkitpy/common/config/committers_unittest.py:
625
626 2011-11-17  Eric Seidel  <eric@webkit.org>
627
628         Remove support for running check-webkit-style w/o a webkit checkout
629         https://bugs.webkit.org/show_bug.cgi?id=72678
630
631         Reviewed by Adam Barth.
632
633         After talking to Dave Levin we've decided to remove this
634         code.  I know of no users of check-webkit-style w/o a webkit checkout
635         and this needlessly adds complexity.
636
637         * Scripts/webkitpy/style/main.py:
638
639 2011-11-17  Eric Seidel  <eric@webkit.org>
640
641         Remove more direct uses of os.path
642         https://bugs.webkit.org/show_bug.cgi?id=72677
643
644         Reviewed by Adam Barth.
645
646         Remove more uses of os.path, including refactoring
647         CommitterValidator to use a Host object instead of
648         manual hacks to emulate what SCM and FileSystem provide.
649
650         * Scripts/webkitpy/common/checkout/changelog.py:
651         * Scripts/webkitpy/common/config/committervalidator.py:
652         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
653         * Scripts/webkitpy/common/system/filesystem_mock.py:
654          - Turns out none of our unittests actually looked at this path.
655            now I've made it be a valid path.
656         * Scripts/webkitpy/tool/bot/feeders.py:
657         * Scripts/webkitpy/tool/commands/queues.py:
658
659 2011-11-17  Eric Seidel  <eric@webkit.org>
660
661         Teach TextFileReader about FileSystem
662         https://bugs.webkit.org/show_bug.cgi?id=72673
663
664         Reviewed by Adam Barth.
665
666         Unfortunately TextFileReader doesn't use FileSystem
667         everywhere yet, so we can't move the unittests to
668         using MockFileSystem, but we're close.
669
670         * Scripts/webkitpy/style/filereader.py:
671         * Scripts/webkitpy/style/filereader_unittest.py:
672         * Scripts/webkitpy/style/main.py:
673
674 2011-11-17  Eric Seidel  <eric@webkit.org>
675
676         Give check-webkit-style a Host
677         https://bugs.webkit.org/show_bug.cgi?id=72670
678
679         Reviewed by Adam Barth.
680
681         * Scripts/webkitpy/common/checkout/scm/detection.py:
682         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
683          - We don't run these unittests, but this one was looking for the wrong exception.
684         * Scripts/webkitpy/style/main.py:
685         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
686          - This was create a new scm object even though it already had one?
687
688 2011-11-17  Eric Seidel  <eric@webkit.org>
689
690         Move check-webkit-style change_directory code to more modern mocks
691         https://bugs.webkit.org/show_bug.cgi?id=72664
692
693         Reviewed by Adam Barth.
694
695         * Scripts/check-webkit-style:
696         * Scripts/webkitpy/style/main.py:
697         * Scripts/webkitpy/style/main_unittest.py:
698
699 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
700
701         [GTK] enable ref tests
702         https://bugs.webkit.org/show_bug.cgi?id=72601
703
704         Re-enable ref tests. Run the driver under evenly numbered display if performing
705         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
706         being run in an already used Xvfb instance if pixel tests are disabled.
707
708         Reviewed by Tony Chang.
709
710         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
711         after the process is killed
712
713 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
714
715         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
716         https://bugs.webkit.org/show_bug.cgi?id=72620
717
718         Reviewed by David Levin.
719
720         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
721         adding the suffix the cpp file. One example of false positive
722         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
723
724         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
725         basename contains the cpp's basename.
726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
727
728 2011-11-17  Eric Seidel  <eric@webkit.org>
729
730         Move check-webkit-style's guts into webkitpy/style/main.py
731         https://bugs.webkit.org/show_bug.cgi?id=72657
732
733         Reviewed by Adam Barth.
734
735         * Scripts/check-webkit-style:
736         * Scripts/webkitpy/style/main.py:
737
738 2011-11-17  Eric Seidel  <eric@webkit.org>
739
740         new-run-webkit-tests is locale dependent
741         https://bugs.webkit.org/show_bug.cgi?id=68691
742
743         Reviewed by Adam Barth.
744
745         Make NRWT use a clean environment, just like ORWT did.
746
747         * Scripts/webkitpy/layout_tests/port/base.py:
748         * Scripts/webkitpy/layout_tests/port/chromium.py:
749         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
750         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
751         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
752         * Scripts/webkitpy/layout_tests/port/efl.py:
753         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
754         * Scripts/webkitpy/layout_tests/port/mac.py:
755         * Scripts/webkitpy/layout_tests/port/qt.py:
756         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
757         * Scripts/webkitpy/layout_tests/port/webkit.py:
758         * Scripts/webkitpy/layout_tests/port/win.py:
759
760 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
761
762         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
763         https://bugs.webkit.org/show_bug.cgi?id=72615
764
765         Reviewed by James Robinson.
766
767         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
768
769 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
770
771         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
772         https://bugs.webkit.org/show_bug.cgi?id=72595
773
774         Reviewed by Noam Rosenthal.
775
776         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
777         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
778         ensure the registration of the DRTNode JS bindings.
779         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
780         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
781         registration of QWebElement (now done implicitly through QWebPage ->
782         QtWebElementRunTime::initialize code path)
783
784 2011-11-17  Adam Roben  <aroben@apple.com>
785
786         Fix a crash-inducing typo I introduced in r100648
787
788         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
789         handling a crashing test
790
791         Reviewed by Adam Barth.
792
793         * Scripts/webkitpy/layout_tests/port/chromium.py:
794         (ChromiumDriver.run_test): Get the driver name from the port.
795
796         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
797         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
798         right crashed process name.
799
800 2011-11-17  Adam Roben  <aroben@apple.com>
801
802         Fix NRWT's parsing of the number of excluded leaks
803
804         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
805         leaks were excluded
806
807         Reviewed by Adam Barth.
808
809         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
810         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
811         regular expression match, not the entire matched string.
812
813         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
814         (LeakDetectorTest): Added some example output that shows how things look when leaks are
815         excluded.
816         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
817         correctly.
818
819 2011-11-17  Adam Roben  <aroben@apple.com>
820
821         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
822
823         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
824         when web process crashes, but WebProcess crash log should get saved instead
825
826         Reviewed by Eric Seidel.
827
828         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
829         (write_test_result): Simplified a little to share more code between the case where we
830         crashed when running the test and where we crashed when checking the expected rendering for
831         a reftest. Changed to pass the crashed process name down to write_crash_report.
832         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
833         along to CrashLogs.find_newest_log rather than always using the driver name.
834
835         * Scripts/webkitpy/layout_tests/port/chromium.py:
836         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
837         crashed.
838
839         * Scripts/webkitpy/layout_tests/port/test.py:
840         (TestInstance.__init__): Initialize new web_process_crash attribute.
841         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
842         test this patch adds.
843         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
844         specifies that the driver crashed or the web process crashed.
845
846         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
847         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
848         which we pretend the web process crashed rather than the driver process.
849
850         (MainTest.test_run_singly_actually_runs_tests):
851         (MainTest.test_unexpected_failures):
852         (EndToEndTest.test_end_to_end):
853         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
854
855 2011-11-17  Tony Chang  <tony@chromium.org>
856
857         [chromium] stop spamming features warning on every build
858         https://bugs.webkit.org/show_bug.cgi?id=72629
859
860         Reviewed by Ojan Vafai.
861
862         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
863         $mediaStreamSupport is on by default for chromium, make the default
864         for $blobSupport also on.
865
866         * Scripts/build-webkit:
867
868 2011-11-17  Adam Roben  <aroben@apple.com>
869
870         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
871
872         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
873         that are supposed to be ignored
874
875         Reviewed by Adam Barth.
876
877         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
878         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
879         required when passing arguments via the shell (which we aren't doing here). It is not
880         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
881
882         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
883         (LeakDetectorTest.test_leaks_args): Updated expectations.
884
885 2011-11-17  Philippe Normand  <pnormand@igalia.com>
886
887         Unreviewed, run-bindings-tests fix after r91028.
888
889         * Scripts/run-bindings-tests: Use scm.detection module.
890
891 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
892
893         Silence a warning about control reaching the end of a non-void function
894         https://bugs.webkit.org/show_bug.cgi?id=72616
895
896         Reviewed by Tony Gentilcore.
897
898         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
899         (AccessibilityUIElement::verticalScrollbar):
900
901 2011-11-17  Adam Roben  <aroben@apple.com>
902
903         Ignore some leaks in frameworks we link against on Lion
904
905         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
906         aren't WebKit's fault
907
908         Reviewed by Antti Koivisto.
909
910         * Scripts/old-run-webkit-tests:
911         (countAndPrintLeaks):
912         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
913         (LeakDetector._callstacks_to_exclude_from_leaks):
914         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
915
916         * Scripts/webkitpy/layout_tests/port/mac.py:
917         (MacPort.is_lion): Added.
918
919         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
920         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
921         methods.
922
923 2011-11-17  Philippe Normand  <pnormand@igalia.com>
924
925         [GTK] Disable ref tests
926         https://bugs.webkit.org/show_bug.cgi?id=72599
927
928         Reviewed by Xan Lopez.
929
930         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
931         tests to avoid massive flakiness.
932
933 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
934
935         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
936
937         A new extension object has been added to QQuickWebView (the same approach should be used
938         for other API classes that need experimental APIs). The QML extension mechanism is then
939         built on top of the experimental object.
940
941         https://bugs.webkit.org/show_bug.cgi?id=72522
942
943         Reviewed by Simon Hausmann.
944
945         * MiniBrowser/qt/BrowserWindow.cpp:
946         (BrowserWindow::BrowserWindow):
947         (BrowserWindow::webView):
948         * MiniBrowser/qt/BrowserWindow.h:
949         * MiniBrowser/qt/UrlLoader.cpp:
950         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
951         * qmake/mkspecs/features/default_post.prf:
952         * qmake/mkspecs/features/default_pre.prf:
953         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
954         * qmake/mkspecs/features/qtwebkit.prf:
955
956 2011-11-17  Adam Barth  <abarth@webkit.org>
957
958         Move test_results_uploader.py out of layout_package
959         https://bugs.webkit.org/show_bug.cgi?id=72590
960
961         Reviewed by Eric Seidel.
962
963         Most of the lines of code in this file are wrong, but I've restrained
964         myself and only changed a few of them to generalized this class to the
965         common package.
966
967         This is part of a series of patches to remove layout_package.
968
969         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
971         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
972
973 2011-11-17  Adam Barth  <abarth@webkit.org>
974
975         Unreviewed. Fix style nits in printing.py.
976
977         * Scripts/webkitpy/layout_tests/views/printing.py:
978
979 2011-11-17  Adam Barth  <abarth@webkit.org>
980
981         Minor style nits in run_webkit_tests.py
982         https://bugs.webkit.org/show_bug.cgi?id=72583
983
984         Reviewed by Eric Seidel.
985
986         This patch just fixes some minor style issues as I work my way back
987         into this code.
988
989         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
990
991 2011-11-17  Adam Barth  <abarth@webkit.org>
992
993         Move test_result_writer out of layout_package
994         https://bugs.webkit.org/show_bug.cgi?id=72586
995
996         Rubber-stamped by Eric Seidel.
997
998         This is part of a series of patches to remove layout_package.
999
1000         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1001         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1002         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1003         * Scripts/webkitpy/tool/commands/rebaseline.py:
1004
1005 2011-11-17  Adam Barth  <abarth@webkit.org>
1006
1007         svn-apply shouldn't magically move files into Source anymore
1008         https://bugs.webkit.org/show_bug.cgi?id=72579
1009
1010         Reviewed by Eric Seidel.
1011
1012         The Source directory has existed for long enough that we don't need
1013         svn-apply to magically re-write old-style patches anymore.
1014
1015         * Scripts/VCSUtils.pm:
1016         (parseGitDiffHeader):
1017         (parseSvnDiffHeader):
1018
1019 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1020
1021         Add a list of contribution areas
1022         https://bugs.webkit.org/show_bug.cgi?id=72566
1023
1024         Reviewed by Eric Seidel.
1025
1026         Added ContributionAreas class.
1027
1028         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1029         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1030
1031 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1032
1033         Refactor ChangeLogTest.test_parse_reviewer_text
1034         https://bugs.webkit.org/show_bug.cgi?id=72572
1035
1036         Reviewed by Eric Seidel.
1037
1038         Refactored the test code by introduing two helper functions.
1039
1040         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1041
1042 2011-11-16  Eric Seidel  <eric@webkit.org>
1043
1044         Add SCMDetector object to make scm detection mockable
1045         https://bugs.webkit.org/show_bug.cgi?id=72247
1046
1047         Reviewed by Adam Barth.
1048
1049         I think SCM detection may eventually be rolled into Checkout,
1050         but this patch at least makes it possible to mock code-paths
1051         which rely on scm detection.
1052         In the process of replacing callers of these free-functions
1053         I found that one of the functions was no longer used,
1054         and that one of the callers could instead just use the SCM
1055         object it already had access to through port.host.scm().
1056         I also discovered that I was not calling Host._initialize_scm()
1057         and thus host.scm() was always returning None!
1058
1059         * Scripts/check-webkit-style:
1060         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1061         * Scripts/webkitpy/common/checkout/deps.py:
1062         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1063         * Scripts/webkitpy/common/checkout/scm/detection.py:
1064         * Scripts/webkitpy/common/checkout/scm/git.py:
1065         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1066         * Scripts/webkitpy/common/checkout/scm/svn.py:
1067         * Scripts/webkitpy/common/host.py:
1068         * Scripts/webkitpy/common/host_mock.py:
1069         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1070         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1071         * Scripts/webkitpy/layout_tests/port/base.py:
1072         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1073         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1074         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1075         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1076
1077 2011-11-16  Mark Rowe  <mrowe@apple.com>
1078
1079         Fix the build.
1080
1081         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1082         Apply the workaround that we use in other projects to WebKitTestRunner.
1083
1084         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1085         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1086         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1087
1088 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1089
1090         [Qt] Fix build after WTR AX support
1091         https://bugs.webkit.org/show_bug.cgi?id=72560
1092
1093         Reviewed by Geoffrey Garen.
1094
1095         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1096         * WebKitTestRunner/InjectedBundle/Target.pri:
1097
1098 2011-11-16  Tony Chang  <tony@chromium.org>
1099
1100         repurpose the flexbox bot for grid layout
1101         https://bugs.webkit.org/show_bug.cgi?id=72557
1102
1103         Reviewed by Ryosuke Niwa.
1104
1105         Since new flexbox is enabled everywhere, we don't need this bot
1106         anymore.  However, work on grid layout has begun, so we can use this
1107         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1108
1109         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1110         the bot on the waterfall, I will change the slave config to enable
1111         the compile flag and tests.
1112
1113 2011-11-11  Adrienne Walker  <enne@google.com>
1114
1115         [chromium] Expose mock scrollbars to window.internals
1116         https://bugs.webkit.org/show_bug.cgi?id=72195
1117
1118         Reviewed by James Robinson.
1119
1120         Because mock scrollbars are a global setting, reset between runs.
1121
1122         * DumpRenderTree/chromium/WebPreferences.cpp:
1123         (WebPreferences::applyTo):
1124
1125 2011-11-16  James Robinson  <jamesr@chromium.org>
1126
1127         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1128         https://bugs.webkit.org/show_bug.cgi?id=72562
1129
1130         Reviewed by Dirk Pranke.
1131
1132         * DumpRenderTree/chromium/TestShell.cpp:
1133         (TestShell::runFileTest):
1134
1135 2011-11-16  Tony Chang  <tony@chromium.org>
1136
1137         [NRWT] speculative fix for multiple subprocess test on cygwin
1138         https://bugs.webkit.org/show_bug.cgi?id=72518
1139
1140         Reviewed by Adam Barth.
1141
1142         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1143             tries to emulate posix fd behavior.
1144         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1145
1146 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1147
1148         Revert r100509; change was committed twice (first time as r100491).
1149         Unreviewed, build fix.
1150
1151         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1152
1153 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Run a dummy test in the gpu configurations if there's nothing to do.
1156         https://bugs.webkit.org/show_bug.cgi?id=72498
1157
1158         Reviewed by James Robinson.
1159
1160         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1161
1162 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1163
1164         contributors_by_fuzzy_match is super slow
1165         https://bugs.webkit.org/show_bug.cgi?id=72540
1166
1167         Reviewed by Eric Seidel.
1168
1169         Make contributors_by_name do case insensitive search using a dictionary.
1170
1171         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1172         because that's the most common case.
1173
1174         * Scripts/webkitpy/common/config/committers.py:
1175         * Scripts/webkitpy/common/config/committers_unittest.py:
1176
1177 2011-11-16  David Levin  <levin@chromium.org>
1178
1179         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1180         https://bugs.webkit.org/show_bug.cgi?id=72515
1181
1182         Reviewed by Adam Barth.
1183
1184         * Scripts/webkitpy/style/checkers/cpp.py:
1185         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1186
1187 2011-11-16  Tony Chang  <tony@chromium.org>
1188
1189         [NRWT] refactor drivers to require pixel_tests param
1190         https://bugs.webkit.org/show_bug.cgi?id=72517
1191
1192         Reviewed by Ojan Vafai.
1193
1194         No tests, just a refactoring.
1195
1196         * Scripts/webkitpy/layout_tests/port/chromium.py:
1197         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1198         * Scripts/webkitpy/layout_tests/port/webkit.py:
1199         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1200
1201 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1202
1203         Run a dummy test in the gpu configurations if there's nothing to do.
1204         https://bugs.webkit.org/show_bug.cgi?id=72498
1205
1206         Reviewed by James Robinson.
1207
1208         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1209
1210 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1211
1212         WebKitTestRunner needs to support accessibility-related DRT APIs
1213         https://bugs.webkit.org/show_bug.cgi?id=42131
1214
1215         Reviewed by Beth Dakin.
1216
1217         Port the AX code in DRT to WKTestRunner by using IDL.
1218
1219         * DumpRenderTree/AccessibilityUIElement.cpp:
1220         (horizontalScrollbarCallback):
1221         (verticalScrollbarCallback):
1222         (AccessibilityUIElement::horizontalScrollbar):
1223         (AccessibilityUIElement::verticalScrollbar):
1224         (AccessibilityUIElement::getJSClass):
1225         * DumpRenderTree/AccessibilityUIElement.h:
1226         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1227         (AccessibilityUIElement::horizontalScrollbar):
1228         (AccessibilityUIElement::verticalScrollbar):
1229         * WebKitTestRunner/DerivedSources.make:
1230         * WebKitTestRunner/GNUmakefile.am:
1231         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1232         (WTR::AccessibilityController::create):
1233         (WTR::AccessibilityController::AccessibilityController):
1234         (WTR::AccessibilityController::~AccessibilityController):
1235         (WTR::AccessibilityController::makeWindowObject):
1236         (WTR::AccessibilityController::wrapperClass):
1237         (WTR::AccessibilityController::rootElement):
1238         (WTR::AccessibilityController::focusedElement):
1239         (WTR::AccessibilityController::elementAtPoint):
1240         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1241         (WTR::AccessibilityController::logFocusEvents):
1242         (WTR::AccessibilityController::logValueChangeEvents):
1243         (WTR::AccessibilityController::logScrollingStartEvents):
1244         (WTR::AccessibilityController::logAccessibilityEvents):
1245         (WTR::AccessibilityController::addNotificationListener):
1246         (WTR::AccessibilityController::notificationReceived):
1247         (WTR::AccessibilityController::resetToConsistentState):
1248         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1249         (WTR::AccessibilityTextMarker::create):
1250         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1251         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1252         (WTR::AccessibilityTextMarker::platformTextMarker):
1253         (WTR::AccessibilityTextMarker::wrapperClass):
1254         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1255         (WTR::AccessibilityTextMarker::isEqual):
1256         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1257         (WTR::AccessibilityTextMarkerRange::create):
1258         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1259         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1260         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1261         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1262         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1263         (WTR::AccessibilityTextMarkerRange::isEqual):
1264         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1265         (WTR::AccessibilityUIElement::create):
1266         (WTR::AccessibilityUIElement::wrapperClass):
1267         (WTR::AccessibilityUIElement::isValid):
1268         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1269         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1270         (WTR::AccessibilityUIElement::isEqual):
1271         (WTR::AccessibilityUIElement::elementAtPoint):
1272         (WTR::AccessibilityUIElement::childAtIndex):
1273         (WTR::AccessibilityUIElement::indexOfChild):
1274         (WTR::AccessibilityUIElement::childrenCount):
1275         (WTR::AccessibilityUIElement::titleUIElement):
1276         (WTR::AccessibilityUIElement::parentElement):
1277         (WTR::AccessibilityUIElement::takeFocus):
1278         (WTR::AccessibilityUIElement::takeSelection):
1279         (WTR::AccessibilityUIElement::addSelection):
1280         (WTR::AccessibilityUIElement::removeSelection):
1281         (WTR::AccessibilityUIElement::allAttributes):
1282         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1283         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1284         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1285         (WTR::AccessibilityUIElement::attributesOfChildren):
1286         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1287         (WTR::AccessibilityUIElement::increment):
1288         (WTR::AccessibilityUIElement::decrement):
1289         (WTR::AccessibilityUIElement::showMenu):
1290         (WTR::AccessibilityUIElement::press):
1291         (WTR::AccessibilityUIElement::stringAttributeValue):
1292         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1293         (WTR::AccessibilityUIElement::numberAttributeValue):
1294         (WTR::AccessibilityUIElement::boolAttributeValue):
1295         (WTR::AccessibilityUIElement::isAttributeSupported):
1296         (WTR::AccessibilityUIElement::isAttributeSettable):
1297         (WTR::AccessibilityUIElement::isActionSupported):
1298         (WTR::AccessibilityUIElement::role):
1299         (WTR::AccessibilityUIElement::subrole):
1300         (WTR::AccessibilityUIElement::roleDescription):
1301         (WTR::AccessibilityUIElement::title):
1302         (WTR::AccessibilityUIElement::description):
1303         (WTR::AccessibilityUIElement::language):
1304         (WTR::AccessibilityUIElement::stringValue):
1305         (WTR::AccessibilityUIElement::accessibilityValue):
1306         (WTR::AccessibilityUIElement::helpText):
1307         (WTR::AccessibilityUIElement::orientation):
1308         (WTR::AccessibilityUIElement::x):
1309         (WTR::AccessibilityUIElement::y):
1310         (WTR::AccessibilityUIElement::width):
1311         (WTR::AccessibilityUIElement::height):
1312         (WTR::AccessibilityUIElement::intValue):
1313         (WTR::AccessibilityUIElement::minValue):
1314         (WTR::AccessibilityUIElement::maxValue):
1315         (WTR::AccessibilityUIElement::valueDescription):
1316         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1317         (WTR::AccessibilityUIElement::selectedTextRange):
1318         (WTR::AccessibilityUIElement::isEnabled):
1319         (WTR::AccessibilityUIElement::isRequired):
1320         (WTR::AccessibilityUIElement::isFocused):
1321         (WTR::AccessibilityUIElement::isFocusable):
1322         (WTR::AccessibilityUIElement::isSelected):
1323         (WTR::AccessibilityUIElement::isSelectable):
1324         (WTR::AccessibilityUIElement::isMultiSelectable):
1325         (WTR::AccessibilityUIElement::setSelectedChild):
1326         (WTR::AccessibilityUIElement::selectedChildrenCount):
1327         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1328         (WTR::AccessibilityUIElement::isExpanded):
1329         (WTR::AccessibilityUIElement::isChecked):
1330         (WTR::AccessibilityUIElement::isVisible):
1331         (WTR::AccessibilityUIElement::isOffScreen):
1332         (WTR::AccessibilityUIElement::isCollapsed):
1333         (WTR::AccessibilityUIElement::isIgnored):
1334         (WTR::AccessibilityUIElement::hasPopup):
1335         (WTR::AccessibilityUIElement::hierarchicalLevel):
1336         (WTR::AccessibilityUIElement::clickPointX):
1337         (WTR::AccessibilityUIElement::clickPointY):
1338         (WTR::AccessibilityUIElement::documentEncoding):
1339         (WTR::AccessibilityUIElement::documentURI):
1340         (WTR::AccessibilityUIElement::url):
1341         (WTR::AccessibilityUIElement::speak):
1342         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1343         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1344         (WTR::AccessibilityUIElement::attributesOfColumns):
1345         (WTR::AccessibilityUIElement::attributesOfRows):
1346         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1347         (WTR::AccessibilityUIElement::attributesOfHeader):
1348         (WTR::AccessibilityUIElement::indexInTable):
1349         (WTR::AccessibilityUIElement::rowIndexRange):
1350         (WTR::AccessibilityUIElement::columnIndexRange):
1351         (WTR::AccessibilityUIElement::rowCount):
1352         (WTR::AccessibilityUIElement::columnCount):
1353         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1354         (WTR::AccessibilityUIElement::disclosedByRow):
1355         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1356         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1357         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1358         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1359         (WTR::AccessibilityUIElement::ariaDropEffects):
1360         (WTR::AccessibilityUIElement::lineForIndex):
1361         (WTR::AccessibilityUIElement::rangeForLine):
1362         (WTR::AccessibilityUIElement::boundsForRange):
1363         (WTR::AccessibilityUIElement::setSelectedTextRange):
1364         (WTR::AccessibilityUIElement::stringForRange):
1365         (WTR::AccessibilityUIElement::attributedStringForRange):
1366         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1367         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1368         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1369         (WTR::AccessibilityUIElement::horizontalScrollbar):
1370         (WTR::AccessibilityUIElement::verticalScrollbar):
1371         (WTR::AccessibilityUIElement::addNotificationListener):
1372         (WTR::AccessibilityUIElement::removeNotificationListener):
1373         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1374         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1375         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1376         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1377         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1378         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1379         (WTR::AccessibilityUIElement::textMarkerForPoint):
1380         (WTR::AccessibilityUIElement::previousTextMarker):
1381         (WTR::AccessibilityUIElement::nextTextMarker):
1382         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1384         (WTR::AccessibilityUIElement::platformUIElement):
1385         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1386         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1387         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1388         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1389         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1390         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1391         (WTR::InjectedBundle::beginTesting):
1392         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1393         (WTR::InjectedBundle::accessibilityController):
1394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1395         (WTR::InjectedBundlePage::didClearWindowForFrame):
1396         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1397         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1398         (WTR::LayoutTestController::platformName):
1399         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1400         (WTR::AccessibilityTextMarker::isEqual):
1401         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1402         (WTR::AccessibilityTextMarkerRange::isEqual):
1403         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1404         (+[NSString stringWithJSStringRef:]):
1405         (-[NSString createJSStringRef]):
1406         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1407         (-[AccessibilityNotificationHandler dealloc]):
1408         (-[AccessibilityNotificationHandler _notificationReceived:]):
1409         (-[AccessibilityNotificationHandler setCallback:]):
1410         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1411         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1412         (WTR::AccessibilityUIElement::isEqual):
1413         (WTR::descriptionOfValue):
1414         (WTR::attributesOfElement):
1415         (WTR::concatenateAttributeAndValue):
1416         (WTR::convertNSArrayToVector):
1417         (WTR::descriptionOfElements):
1418         (WTR::AccessibilityUIElement::getLinkedUIElements):
1419         (WTR::AccessibilityUIElement::getDocumentLinks):
1420         (WTR::AccessibilityUIElement::getChildren):
1421         (WTR::AccessibilityUIElement::getChildrenWithRange):
1422         (WTR::AccessibilityUIElement::childrenCount):
1423         (WTR::AccessibilityUIElement::elementAtPoint):
1424         (WTR::AccessibilityUIElement::indexOfChild):
1425         (WTR::AccessibilityUIElement::childAtIndex):
1426         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1427         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1428         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1429         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1430         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1431         (WTR::AccessibilityUIElement::selectedChildrenCount):
1432         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1433         (WTR::AccessibilityUIElement::titleUIElement):
1434         (WTR::AccessibilityUIElement::parentElement):
1435         (WTR::AccessibilityUIElement::disclosedByRow):
1436         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1437         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1438         (WTR::AccessibilityUIElement::attributesOfChildren):
1439         (WTR::AccessibilityUIElement::allAttributes):
1440         (WTR::AccessibilityUIElement::stringAttributeValue):
1441         (WTR::AccessibilityUIElement::numberAttributeValue):
1442         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1443         (WTR::AccessibilityUIElement::boolAttributeValue):
1444         (WTR::AccessibilityUIElement::isAttributeSettable):
1445         (WTR::AccessibilityUIElement::isAttributeSupported):
1446         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1447         (WTR::AccessibilityUIElement::role):
1448         (WTR::AccessibilityUIElement::subrole):
1449         (WTR::AccessibilityUIElement::roleDescription):
1450         (WTR::AccessibilityUIElement::title):
1451         (WTR::AccessibilityUIElement::description):
1452         (WTR::AccessibilityUIElement::orientation):
1453         (WTR::AccessibilityUIElement::stringValue):
1454         (WTR::AccessibilityUIElement::language):
1455         (WTR::AccessibilityUIElement::helpText):
1456         (WTR::AccessibilityUIElement::x):
1457         (WTR::AccessibilityUIElement::y):
1458         (WTR::AccessibilityUIElement::width):
1459         (WTR::AccessibilityUIElement::height):
1460         (WTR::AccessibilityUIElement::clickPointX):
1461         (WTR::AccessibilityUIElement::clickPointY):
1462         (WTR::AccessibilityUIElement::intValue):
1463         (WTR::AccessibilityUIElement::minValue):
1464         (WTR::AccessibilityUIElement::maxValue):
1465         (WTR::AccessibilityUIElement::valueDescription):
1466         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1467         (WTR::AccessibilityUIElement::isActionSupported):
1468         (WTR::AccessibilityUIElement::isEnabled):
1469         (WTR::AccessibilityUIElement::isRequired):
1470         (WTR::AccessibilityUIElement::isFocused):
1471         (WTR::AccessibilityUIElement::isSelected):
1472         (WTR::AccessibilityUIElement::isExpanded):
1473         (WTR::AccessibilityUIElement::isChecked):
1474         (WTR::AccessibilityUIElement::hierarchicalLevel):
1475         (WTR::AccessibilityUIElement::speak):
1476         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1477         (WTR::AccessibilityUIElement::ariaDropEffects):
1478         (WTR::AccessibilityUIElement::lineForIndex):
1479         (WTR::AccessibilityUIElement::rangeForLine):
1480         (WTR::AccessibilityUIElement::boundsForRange):
1481         (WTR::AccessibilityUIElement::stringForRange):
1482         (WTR::AccessibilityUIElement::attributedStringForRange):
1483         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1484         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1485         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1486         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1487         (WTR::AccessibilityUIElement::attributesOfColumns):
1488         (WTR::AccessibilityUIElement::attributesOfRows):
1489         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1490         (WTR::AccessibilityUIElement::attributesOfHeader):
1491         (WTR::AccessibilityUIElement::rowCount):
1492         (WTR::AccessibilityUIElement::columnCount):
1493         (WTR::AccessibilityUIElement::indexInTable):
1494         (WTR::AccessibilityUIElement::rowIndexRange):
1495         (WTR::AccessibilityUIElement::columnIndexRange):
1496         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1497         (WTR::AccessibilityUIElement::horizontalScrollbar):
1498         (WTR::AccessibilityUIElement::verticalScrollbar):
1499         (WTR::AccessibilityUIElement::selectedTextRange):
1500         (WTR::AccessibilityUIElement::setSelectedTextRange):
1501         (WTR::AccessibilityUIElement::increment):
1502         (WTR::AccessibilityUIElement::decrement):
1503         (WTR::AccessibilityUIElement::showMenu):
1504         (WTR::AccessibilityUIElement::press):
1505         (WTR::AccessibilityUIElement::setSelectedChild):
1506         (WTR::AccessibilityUIElement::accessibilityValue):
1507         (WTR::AccessibilityUIElement::documentEncoding):
1508         (WTR::AccessibilityUIElement::documentURI):
1509         (WTR::AccessibilityUIElement::url):
1510         (WTR::AccessibilityUIElement::addNotificationListener):
1511         (WTR::AccessibilityUIElement::removeNotificationListener):
1512         (WTR::AccessibilityUIElement::isFocusable):
1513         (WTR::AccessibilityUIElement::isSelectable):
1514         (WTR::AccessibilityUIElement::isMultiSelectable):
1515         (WTR::AccessibilityUIElement::isVisible):
1516         (WTR::AccessibilityUIElement::isOffScreen):
1517         (WTR::AccessibilityUIElement::isCollapsed):
1518         (WTR::AccessibilityUIElement::isIgnored):
1519         (WTR::AccessibilityUIElement::hasPopup):
1520         (WTR::AccessibilityUIElement::takeFocus):
1521         (WTR::AccessibilityUIElement::takeSelection):
1522         (WTR::AccessibilityUIElement::addSelection):
1523         (WTR::AccessibilityUIElement::removeSelection):
1524         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1525         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1526         (WTR::AccessibilityUIElement::previousTextMarker):
1527         (WTR::AccessibilityUIElement::nextTextMarker):
1528         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1529         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1530         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1531         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1532         (WTR::AccessibilityUIElement::textMarkerForPoint):
1533         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1534         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1535         (WTR::LayoutTestController::platformName):
1536         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1537         (WTR::LayoutTestController::platformName):
1538         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1539         (WTR::LayoutTestController::platformName):
1540         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1541         * WebKitTestRunner/win/InjectedBundle.vcproj:
1542
1543 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1544
1545         [Qt] Fix use of config.tests
1546
1547         We were checking @buildArgs to determine if the optional argument was
1548         passed or not, but this is not the right way to do that in Perl. The
1549         right way is to not use a prototype for the function, and to pass
1550         the list as a reference (to avoid list expansion). That way we can
1551         check the number of arguments, and choose the right code path based
1552         on that.
1553
1554         We were also missing a default-value of 0 for any feature that's not
1555         set in features.prf.
1556
1557         Reviewed by Kenneth Rohde Christiansen.
1558
1559         * Scripts/build-webkit:
1560         * Scripts/webkitdirs.pm:
1561         (qtFeatureDefaults):
1562         (buildQMakeProject):
1563
1564 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1565
1566         [Qt] Prospective fix for broken plugin tests
1567
1568         Don't hide symbols for the NPAPI test plugin
1569
1570         Rubber-stamped by Andreas Kling.
1571
1572         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1573
1574 2011-11-16  Adam Roben  <aroben@apple.com>
1575
1576         Move filenames/line numbers off to the right edge in Leaks Viewer
1577
1578         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1579         because filenames/line numbers are right next to function names
1580
1581         Reviewed by Andreas Kling.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1584         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1585         function name. Use the filename as the profile node's URL (we don't have enough info to
1586         compute a real URL currently) and the line number as the profile node's line number so the
1587         Inspector code will put them on the right side of the callstack graph.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1590         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1591         passed here, just filenames.
1592
1593         (WebInspector.linkifyURLAsNode):
1594         (WebInspector.linkifyResourceAsNode):
1595         Copied and slightly modified from inspector.js.
1596
1597 2011-11-16  Adam Roben  <aroben@apple.com>
1598
1599         Make Leaks Viewer load builds from the new Lion Leaks bot
1600
1601         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1602
1603         Reviewed by Andreas Kling.
1604
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1606         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1607         SnowLeopard one.
1608
1609 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1610
1611         [EFL] Clean up the offline apps-related functions in ewk_settings.
1612         https://bugs.webkit.org/show_bug.cgi?id=72132
1613
1614         Reviewed by Kenneth Rohde Christiansen.
1615
1616         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1617         prefixes for code that is related only to the HTML5 app cache
1618         features.
1619
1620         Use `ewk_settings_application_cache' and
1621         `ewk_view_setting_application_cache' instead.
1622
1623         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1624         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1625
1626 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1627
1628         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1629
1630         Reviewed by Tor Arne Vestbø.
1631
1632         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1633         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1634         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1635         removes the .so.0.0.0 and just produces .so.
1636
1637 2011-11-16  Peter Beverloo  <peter@chromium.org>
1638
1639         Explicitly include unistd.h in TestNetscapePlugIn
1640         https://bugs.webkit.org/show_bug.cgi?id=72385
1641
1642         This is needed for the sleep() call in the indicateTestFailure method,
1643         which seems to be implicitly available for other platforms. This is not
1644         the case on Android.
1645
1646         Reviewed by Steve Block.
1647
1648         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1649
1650 2011-11-16  Peter Beverloo  <peter@chromium.org>
1651
1652         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1653         https://bugs.webkit.org/show_bug.cgi?id=72384
1654
1655         Update to Android NDK r7, which was released last Friday. This adds
1656         support for RTTI and the -mimplicit-it gcc flag, which are required to
1657         respectively build ICU and Skia.
1658
1659         Reviewed by Steve Block.
1660
1661         * Scripts/update-webkit-chromium:
1662         * Scripts/webkitdirs.pm:
1663         (buildChromiumMakefile):
1664
1665 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1666
1667         Unreviewed, rolling out r100266.
1668         http://trac.webkit.org/changeset/100266
1669
1670         Broke WTR.
1671
1672         * qmake/mkspecs/features/default_post.prf:
1673
1674 2011-11-16  Eric Seidel  <eric@webkit.org>
1675
1676         check-webkit-style broken by r99773: "Could not determine the port"
1677         https://bugs.webkit.org/show_bug.cgi?id=72275
1678
1679         Reviewed by Adam Barth.
1680
1681         I will continue engaging hacks, until windows improves.
1682
1683         * Scripts/webkitpy/common/host.py:
1684          - Host uses self.executive instead of self._executive like Port does.
1685          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1686
1687 2011-11-16  Eric Seidel  <eric@webkit.org>
1688
1689         check-webkit-style broken by r99773: "Could not determine the port"
1690         https://bugs.webkit.org/show_bug.cgi?id=72275
1691
1692         Reviewed by Adam Barth.
1693
1694         Engage windows hacks harder.
1695
1696         This is a speculative fix for ChromiumWin.  We're now
1697         creating an SCM object much earlier, so we need to
1698         engage our "awesome" windows hacks earlier.
1699
1700         * Scripts/webkitpy/common/host.py:
1701         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1702
1703 2011-11-15  Darin Adler  <darin@apple.com>
1704
1705         DRT's uiElementAttributeValueCallback function is leaky
1706         https://bugs.webkit.org/show_bug.cgi?id=72453
1707
1708         Reviewed by Dan Bernstein.
1709
1710         * DumpRenderTree/AccessibilityUIElement.cpp:
1711         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1712
1713 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1714
1715         Implement edit-distance based reviewer recognition algorithm
1716         https://bugs.webkit.org/show_bug.cgi?id=72351
1717
1718         Reviewed by Eric Seidel.
1719
1720         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1721         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1722         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1723         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1724
1725         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1726         the edit distance is implemented in edit_distance.py.
1727
1728         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1729         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1730
1731         * Scripts/webkitpy/common/checkout/changelog.py:
1732         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1733         * Scripts/webkitpy/common/config/committers.py:
1734         * Scripts/webkitpy/common/config/committers_unittest.py:
1735         * Scripts/webkitpy/common/editdistance.py: Added.
1736         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1737         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1738         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1739
1740 2011-11-15  Tony Chang  <tony@chromium.org>
1741
1742         Skip a failing webkitpy test on cygwin.
1743
1744         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1745
1746 2011-11-15  Sam Weinig  <sam@webkit.org>
1747
1748         TestWebKitAPI should not put its resources in the root products directory
1749         https://bugs.webkit.org/show_bug.cgi?id=72446
1750
1751         Reviewed by Anders Carlsson.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1755         directory.
1756
1757         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1758         (TEST_F):
1759         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1760         (TestWebKitAPI::TEST):
1761         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1762         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1763         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1764         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1765         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1766         (TestWebKitAPI::Util::createURLForResource):
1767         Update calls to retrieve files from the bundle to look in the newly
1768         created subdirectory.
1769
1770 2011-11-15  Tony Chang  <tony@chromium.org>
1771
1772         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1773
1774         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1775
1776 2011-11-15  Tony Chang  <tony@chromium.org>
1777
1778         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1779         earlier.
1780
1781         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1782         * Scripts/webkitpy/layout_tests/port/webkit.py:
1783
1784 2011-11-15  James Robinson  <jamesr@chromium.org>
1785
1786         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1787         https://bugs.webkit.org/show_bug.cgi?id=72444
1788
1789         Reviewed by Adam Barth.
1790
1791         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1792
1793 2011-11-15  Tony Chang  <tony@chromium.org>
1794
1795         Unreviewed, better fix for ref tests failures on SL Intel bot.
1796         Revert the previous change and return None if pixel results from
1797         either the test page or the expected page is missing.
1798
1799         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1800         * Scripts/webkitpy/layout_tests/port/webkit.py:
1801
1802 2011-11-15  James Robinson  <jamesr@chromium.org>
1803
1804         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1805         https://bugs.webkit.org/show_bug.cgi?id=72402
1806
1807         Reviewed by Dirk Pranke.
1808
1809         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1810         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1811         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1812         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1813         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1814         compositing enabled.
1815
1816         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1817         patch should not impact any tests.
1818
1819         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1820         (main):
1821         * DumpRenderTree/chromium/TestShell.cpp:
1822         (TestShell::TestShell):
1823         (TestShell::resetWebSettings):
1824         * DumpRenderTree/chromium/TestShell.h:
1825         (TestShell::setAcceleratedCompositingForVideoEnabled):
1826         * DumpRenderTree/chromium/WebPreferences.cpp:
1827         (WebPreferences::reset):
1828         (WebPreferences::applyTo):
1829         * DumpRenderTree/chromium/WebPreferences.h:
1830         * Scripts/webkitpy/layout_tests/port/chromium.py:
1831         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1832         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1833
1834 2011-11-15  Tony Chang  <tony@chromium.org>
1835
1836         Unreviewed, try to fix ref tests failures on SL Intel bot.
1837         It looks like ImageDiff isn't returning an image diff.
1838
1839         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1840
1841 2011-11-15  Tony Chang  <tony@chromium.org>
1842
1843         Unreviewed fix of ref-tests on GTK+.
1844         If a driver is never started, _xvfb_process is never set.
1845
1846         * Scripts/webkitpy/layout_tests/port/gtk.py:
1847
1848 2011-11-14  Tony Chang  <tony@chromium.org>
1849
1850         [NRWT] Reftests should run even when pixel tests are disabled.
1851         https://bugs.webkit.org/show_bug.cgi?id=60605
1852
1853         Reviewed by Dirk Pranke.
1854
1855         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1856             Also add an assert to make sure we get image hashes back when running ref tests.
1857         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1858         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1859         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1860         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1861             of starting a pixel driver if needed.  It handles the logic of sending the test
1862             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1863         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1864         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1865         * Scripts/webkitpy/layout_tests/port/webkit.py:
1866         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1868
1869 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1870
1871         Don't use File::Slurp for run-leaks unit tests
1872         <http://webkit.org/b/72356>
1873
1874         Reviewed by Daniel Bates.
1875
1876         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1877         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1878         Extracted common package logic into RunLeaks.pm.  Fixed call to
1879         RunLeaks::parseLeaksOutput().
1880         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1881         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1882
1883 2011-11-15  Peter Kasting  <pkasting@google.com>
1884
1885         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1886         https://bugs.webkit.org/show_bug.cgi?id=72349
1887
1888         Reviewed by Adam Roben.
1889
1890         * Scripts/VCSUtils.pm:
1891         (isSVNDirectory):
1892
1893 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1894
1895         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1896
1897         Reviewed by Tor Arne Vestbø.
1898
1899         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1900         magic here where we handle all TEMPLATE = lib .pro files.
1901
1902 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1903
1904         [Qt] Unreviewed prospective --minimal build fix.
1905
1906         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1907         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1908
1909 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1910
1911         [Qt] Unreviewed --minimal build fix.
1912
1913         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1914         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1915         to make moc's preprocessor abort.
1916
1917 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1918
1919         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1920         https://bugs.webkit.org/show_bug.cgi?id=72156
1921
1922         Reviewed by Daniel Bates.
1923
1924         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1925         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1926
1927         * Scripts/build-webkit:
1928         * Scripts/webkitdirs.pm:
1929         (generateBuildSystemFromCMakeProject):
1930
1931 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1932
1933         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1934         https://bugs.webkit.org/show_bug.cgi?id=72340
1935
1936         Reviewed by Eric Seidel.
1937
1938         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1939         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1940
1941         * Scripts/webkitpy/common/checkout/changelog.py:
1942         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1943
1944 2011-11-14  Eric Seidel  <eric@webkit.org>
1945
1946         check-webkit-style broken by r99773: "Could not determine the port"
1947         https://bugs.webkit.org/show_bug.cgi?id=72275
1948
1949         Reviewed by Adam Barth.
1950
1951         The TestExpectationsChecker was using a generic try/except block
1952         which caught all exceptions, so we didn't notice that failing
1953         to pass a Host to PortFactory was causing an exception in port instantiation.
1954         I've factored out the "lookup the port" logic into a separate function
1955         which I've now unittested.  This should fix the bug and prevent
1956         others like it from occuring the the future.
1957
1958         * Scripts/webkitpy/style/checkers/test_expectations.py:
1959         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1960
1961 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1962
1963         Add --css-grid-layout to build-webkit and the build systems
1964         https://bugs.webkit.org/show_bug.cgi?id=72320
1965
1966         Reviewed by Ojan Vafai.
1967
1968         * Scripts/build-webkit:
1969         Added the option.
1970
1971 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1972
1973         Unreviewed, rolling out r100192.
1974         http://trac.webkit.org/changeset/100192
1975         https://bugs.webkit.org/show_bug.cgi?id=72328
1976
1977         Caused infinite tests to fail (Requested by abarth on
1978         #webkit).
1979
1980         * Scripts/webkitpy/layout_tests/port/base.py:
1981         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1982
1983 2011-11-14  Tony Chang  <tony@chromium.org>
1984
1985         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1986         https://bugs.webkit.org/show_bug.cgi?id=72196
1987
1988         Reviewed by Ojan Vafai.
1989
1990         * Scripts/build-webkit:
1991
1992 2011-11-14  John Yani  <vanuan@gmail.com>
1993
1994         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1995         Override LOCALE to en_US.
1996
1997         Reviewed by Eric Seidel.
1998
1999         * Scripts/webkitpy/layout_tests/port/base.py:
2000
2001 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2002
2003         [Chromium] build-webkit silently drops the features flags
2004         https://bugs.webkit.org/show_bug.cgi?id=72293
2005
2006         Reviewed by Tony Chang.
2007
2008         Chromium still ignores @features but now we give a warning!
2009
2010         * Scripts/build-webkit: Check if one of the features is different
2011         from the default and print a warning in this case.
2012
2013 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2014
2015         run-leaks does not work on Lion?
2016         <http://webkit.org/b/71059>
2017         <rdar://problem/10428527>
2018
2019         Reviewed by Adam Roben.
2020
2021         The output of leaks(1) changed again in Lion to move the
2022         "leaks Report Version: 2.0" line from the first line of the
2023         output to just above the "Process " lines that run-leaks is
2024         interested in parsing.  This required using a more generic
2025         algorithm to find the start of the "Process " lines.
2026
2027         * Scripts/run-leaks:
2028         (parseLeaksOutput): Make the code to skip headers more generic.
2029         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2030         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2031         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2032
2033 2011-11-14  Lei Zhang  <thestig@chromium.org>
2034
2035         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2036         https://bugs.webkit.org/show_bug.cgi?id=72088
2037
2038         Reviewed by Tony Chang.
2039
2040         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2041
2042 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2043
2044         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2045         https://bugs.webkit.org/show_bug.cgi?id=72147
2046
2047         Reviewed by Adam Barth.
2048
2049         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2050
2051 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2052
2053         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2054
2055         Reviewed by Simon Hausmann.
2056
2057         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2058
2059 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2060
2061         [Qt] Disable plugins on X11 for WK2
2062
2063         Reviewed by Kenneth Rohde Christiansen.
2064
2065         Currently plugins are in-process and they crash in the likely case of
2066         a plugin installation that uses Qt 4, which beautifully clashes with the
2067         Qt 5 based QtWebProcess.
2068
2069         * qmake/mkspecs/features/features.prf:
2070
2071 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2072
2073         [Qt] Add support for config tests for Qt 5
2074
2075         This allows us to build and run configure-tests at build
2076         time to determine if a given platform feature is available.
2077
2078         Reviewed by Simon Hausmann.
2079
2080         * Scripts/build-webkit:
2081         * Scripts/webkitdirs.pm:
2082         (qtFeatureDefaults):
2083         * qmake/configure.pro: Added.
2084         * qmake/mkspecs/features/features.prf:
2085         * qmake/sync.profile: Added.
2086
2087 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2088
2089         [Qt] Remove the QStyle dependency in Qt's mobile theme
2090         https://bugs.webkit.org/show_bug.cgi?id=67773
2091
2092         This refactoring splits up RenderThemeQt with two
2093         subclasses, a QStyle-backed one, and a Mobile version
2094         that uses the old mobile theme for now.
2095
2096         QStyle availability is detected at compile time, and
2097         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2098         environment variable.
2099
2100         Reviewed by Simon Hausmann.
2101
2102         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2103         (WTR::activateFonts):
2104         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2105         based on availability of QtWidgets.
2106         * qmake/mkspecs/features/webcore.prf: cleanup.
2107
2108 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2109
2110         Unreviewed, rolling out r100116.
2111         http://trac.webkit.org/changeset/100116
2112
2113         r100104 was rolled out, so no longer needed
2114
2115         * Scripts/run-bindings-tests:
2116
2117 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2118
2119         Unreviewed, rolling out r100104.
2120         http://trac.webkit.org/changeset/100104
2121         https://bugs.webkit.org/show_bug.cgi?id=72247
2122
2123         broke windows builds
2124
2125         * Scripts/check-webkit-style:
2126         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2127         * Scripts/webkitpy/common/checkout/deps.py:
2128         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2129         * Scripts/webkitpy/common/checkout/scm/detection.py:
2130         * Scripts/webkitpy/common/checkout/scm/git.py:
2131         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2132         * Scripts/webkitpy/common/checkout/scm/svn.py:
2133         * Scripts/webkitpy/common/host.py:
2134         * Scripts/webkitpy/common/host_mock.py:
2135         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2136         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2137         * Scripts/webkitpy/layout_tests/port/base.py:
2138         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2140         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2141         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2142
2143 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2144
2145         Unreviewed, build fix after r100104. run-binding-tests broke.
2146
2147         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2148
2149 2011-11-13  Eric Seidel  <eric@webkit.org>
2150
2151         Add SCMDetector object to make scm detection mockable
2152         https://bugs.webkit.org/show_bug.cgi?id=72247
2153
2154         Reviewed by Adam Barth.
2155
2156         I think SCM detection may eventually be rolled into Checkout,
2157         but this patch at least makes it possible to mock code-paths
2158         which rely on scm detection.
2159         In the process of replacing callers of these free-functions
2160         I found that one of the functions was no longer used,
2161         and that one of the callers could instead just use the SCM
2162         object it already had access to through port.host.scm().
2163         I also discovered that I was not calling Host._initialize_scm()
2164         and thus host.scm() was always returning None!
2165
2166         * Scripts/check-webkit-style:
2167         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2168         * Scripts/webkitpy/common/checkout/deps.py:
2169         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2170         * Scripts/webkitpy/common/checkout/scm/detection.py:
2171         * Scripts/webkitpy/common/checkout/scm/git.py:
2172         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2173         * Scripts/webkitpy/common/checkout/scm/svn.py:
2174         * Scripts/webkitpy/common/host.py:
2175         * Scripts/webkitpy/common/host_mock.py:
2176         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2177         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2178         * Scripts/webkitpy/layout_tests/port/base.py:
2179         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2181         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2182         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2183
2184 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2185
2186         command line control of webcore log channels in chromium DumpRenderTree
2187         https://bugs.webkit.org/show_bug.cgi?id=72126
2188         
2189         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2190         what chromium takes.
2191
2192         Reviewed by Kent Tamura.
2193
2194         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2195         (main):
2196
2197 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2198
2199         [Qt] Fix minor config typo in the build tool documentation
2200         https://bugs.webkit.org/show_bug.cgi?id=72194
2201
2202         Reviewed by Andreas Kling.
2203
2204         * qmake/README:
2205
2206 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2207
2208         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2209         https://bugs.webkit.org/show_bug.cgi?id=49257
2210
2211         Adds the remaining missing layout test functionality for printing.
2212
2213         Reviewed by Darin Fisher.
2214
2215         * DumpRenderTree/chromium/LayoutTestController.cpp:
2216         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2217         (parsePageNumber): Method to parse JS arguments for a page number
2218         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2219         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2220         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2221         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2222         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2223
2224 2011-11-11  Darin Adler  <darin@apple.com>
2225
2226         Remove all releaseRef implementations except for RetainPtr
2227         https://bugs.webkit.org/show_bug.cgi?id=71423
2228
2229         Reviewed by Julien Chaffraix.
2230
2231         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2232         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2233
2234 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2235
2236         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2237         https://bugs.webkit.org/show_bug.cgi?id=72090
2238
2239         Reviewed by Eric Seidel.
2240
2241         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2242         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2243
2244         yay! r100002.
2245
2246         * Scripts/webkitpy/common/checkout/changelog.py:
2247         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2248
2249 2011-11-11  Tony Chang  <tony@chromium.org>
2250
2251         Remove --force from gclient sync.  The bots seem to have made it past
2252         the update step.
2253
2254         * Scripts/update-webkit:
2255
2256 2011-11-11  Tony Chang  <tony@chromium.org>
2257
2258         Add --force to gclient sync. Once the cq bots cycle, we can remove
2259         this since it slows down the normal sync.
2260
2261         * Scripts/update-webkit:
2262
2263 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2264
2265         When --force is used, also use --reset
2266         https://bugs.webkit.org/show_bug.cgi?id=72129
2267
2268         Reviewed by Dimitri Glazkov.
2269
2270         * Scripts/update-webkit-chromium:
2271
2272 2011-11-11  Tony Chang  <tony@chromium.org>
2273
2274         allow two chromium drivers to run at the same time in NRWT
2275         https://bugs.webkit.org/show_bug.cgi?id=72067
2276
2277         Reviewed by Dirk Pranke.
2278
2279         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
2280             posix prevents the subprocesses from sharing the same fd for stdin.
2281             Sharing the same fd prevents us from closing the files unless all references
2282             to the fd are closed.
2283         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
2284             to adding a test for this, speed up a test (from 3sec to 0) by fixing
2285             the timeout override. It looks like it regressed in r95875.
2286
2287 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2288
2289         Unreviewed, rolling out r99964.
2290         http://trac.webkit.org/changeset/99964
2291         https://bugs.webkit.org/show_bug.cgi?id=72124
2292
2293         Broke too many Qt tests (Requested by tronical_ on #webkit).
2294
2295         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2296         (WTR::activateFonts):
2297         * qmake/mkspecs/features/features.prf:
2298         * qmake/mkspecs/features/webcore.prf:
2299
2300 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2301
2302         [Qt] Remove the QStyle dependency in Qt's mobile theme
2303         https://bugs.webkit.org/show_bug.cgi?id=67773
2304
2305         This refactoring splits up RenderThemeQt with two
2306         subclasses, a QStyle-backed one, and a Mobile version
2307         that uses the old mobile theme for now.
2308
2309         QStyle availability is detected at compile time, and
2310         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2311         environment variable.
2312
2313         Reviewed by Simon Hausmann.
2314
2315         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2316         (WTR::activateFonts):
2317         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2318         based on availability of QtWidgets.
2319         * qmake/mkspecs/features/webcore.prf: cleanup.
2320
2321 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2322
2323         [Qt] Add missing include to PlatformWebViewQt
2324
2325         Reviewed by Simon Hausmann.
2326
2327         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2328
2329 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2330
2331         [Qt] Fix incremental builds on Windows after buildsystem refactor
2332
2333         The qmake rules to ensure that we run make on the derived sources
2334         before running qmake on the target were inside a unix-scope, which
2335         resulted in flakey builds on Windows.
2336
2337         We now generate a rule on all platforms that ensures that "make qmake"
2338         will always run make on the derived sources. In addition, on platforms
2339         that have GNU make (where "make incremental" does not run "make qmake",
2340         but only "make"), we add a similar rule that ensures that any time the
2341         target makefile is regenerated we first run qmake and make on the derived
2342         sources. This rule relies on GNU make's order-only-prerequisites to
2343         not trigger a qmake-run of the target every time we run make.
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=71778
2346
2347         Reviewed by Simon Hausmann.
2348
2349         * qmake/mkspecs/features/functions.prf:
2350
2351 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2352
2353         [Qt][WK2] Remove QWebNavigationController
2354         https://bugs.webkit.org/show_bug.cgi?id=72113
2355
2356         Reviewed by Andreas Kling.
2357
2358         Adapt to the move of the QWebNavigationController functions/properties to
2359         QQuickWebView.
2360
2361         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2362         * MiniBrowser/qt/qml/BrowserWindow.qml:
2363
2364 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2365
2366         [Qt] Build system tweak
2367
2368         Reviewed by Tor Arne Vestbø.
2369
2370         Be a good qmake citizen, return true from our linkStaticLibrary
2371         "test" function.
2372
2373         * qmake/mkspecs/features/functions.prf:
2374
2375 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2376
2377         [Qt] Add support for QT += webkit-private
2378
2379         Reviewed by Tor Arne Vestbø.
2380
2381         * qmake/qt_webkit.pri: Declare private headers.
2382
2383 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2384
2385         Unreviewed, build fix attempt after r99907. Since that revision
2386         GTK layout tests were not running at all...
2387
2388         * Scripts/webkitpy/layout_tests/port/gtk.py:
2389
2390 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2391
2392         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2393         https://bugs.webkit.org/show_bug.cgi?id=72001
2394
2395         Reviewed by Dirk Pranke.
2396
2397         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2398
2399 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2400
2401         bencher script should support remote benchmarking
2402         https://bugs.webkit.org/show_bug.cgi?id=71618
2403
2404         Rubber-stamped by Geoff Garen.
2405         
2406         Added the following features:
2407         
2408         - Benchmark report tells you the hostname and machine model (according to
2409           'sysctl hw.model') of the machine you did the run on, and svn revision number
2410           (according to 'svn info') of the VMs you're testing.
2411         
2412         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2413           acceptable, in addition to just host, in which case your username is used)
2414           and it automatically packages the build directories of the VMs you're testing,
2415           sends them to the remote machine along with your copy of the bencher script
2416           and all of the options you passed.  This pretty much seamlessly allows you
2417           to run a set of benchmarks on any machine that is sufficiently compatible with
2418           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2419           must now include a tempPath setting that tells bencher where to put files
2420           when that machine is used as a slave in a remote benchmarking run.
2421           
2422         - Added yet another way of specifying which benchmarks to run. This was sort of
2423           necessary for --remote to work as expected. Previously, you either said what
2424           suites to exclude (for example --exclude-sunspider) or that you only wanted
2425           to run one suite to the exclusion of others (--sunspider-only). But it's
2426           often better to just be able to specify the list of suites you want. This is
2427           now supported. You can say, for example, --v8 --sunspider, which means, just
2428           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2429           still supported.
2430
2431         * Scripts/bencher:
2432
2433 2011-11-10  Tony Chang  <tony@chromium.org>
2434
2435         Lazily start DRT instances in NRWT
2436         https://bugs.webkit.org/show_bug.cgi?id=72038
2437
2438         Reviewed by Eric Seidel.
2439
2440         Just a refactoring, no new tests.
2441
2442         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2443         * Scripts/webkitpy/layout_tests/port/chromium.py:
2444         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2445         * Scripts/webkitpy/layout_tests/port/test.py:
2446         * Scripts/webkitpy/layout_tests/port/webkit.py:
2447
2448 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2449
2450         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2451         https://bugs.webkit.org/show_bug.cgi?id=72057
2452
2453         Reviewed by Eric Seidel.
2454
2455         Make the regular expression more explicit.
2456
2457         * Scripts/webkitpy/common/checkout/changelog.py:
2458         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2459
2460 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2461
2462         [Qt] X11 plugins need to be reworked for Qt5
2463         https://bugs.webkit.org/show_bug.cgi?id=70023
2464
2465         Reviewed by Simon Hausmann.
2466
2467         Rework our basic plugin support in a way that does
2468         not need a bridge between Qt and X. The solution is
2469         based on getting the content drawed by the plugin
2470         from the server as an image and creating a QImage
2471         from it.
2472
2473         * qmake/mkspecs/features/features.prf: Enable X11
2474         plugins if Qt is built with the xcb-xlib backend.
2475
2476 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2477
2478         [Qt] Fix keyboard related layout tests after API refactoring
2479
2480         Reviewed by Tor Arne Vestbø.
2481
2482         Send key events to the handling page item, not the view.
2483
2484         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2485         (WTR::PlatformWebView::sendEvent):
2486         (WTR::PlatformWebView::postEvent):
2487
2488 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2489
2490         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2491         https://bugs.webkit.org/show_bug.cgi?id=71940
2492
2493         Reviewed by Philippe Normand.
2494
2495         * GNUmakefile.am:
2496         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2497         ENABLE_* variables are part of the environment.
2498
2499 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2500
2501         [Qt] Fix focus related layout tests after API refactoring
2502
2503         Reviewed by Tor Arne Vestbø.
2504
2505         Make sure the focus is set on the page now, not on the view
2506         (which doesn't actually handle the focus).
2507
2508         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2509         (WTR::WrapperWindow::WrapperWindow):
2510         (WTR::WrapperWindow::handleStatusChanged):
2511
2512 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2513
2514         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2515         https://bugs.webkit.org/show_bug.cgi?id=71355
2516
2517         Reviewed by Kenneth Rohde Christiansen.
2518
2519         Make MiniBrowser and WebKitTestRunner work again after the
2520         merge.
2521
2522         * MiniBrowser/qt/BrowserWindow.cpp:
2523         (BrowserWindow::BrowserWindow):
2524         (BrowserWindow::webView):
2525         * MiniBrowser/qt/MiniBrowser.pro:
2526         * MiniBrowser/qt/MiniBrowser.qrc:
2527         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2528         * MiniBrowser/qt/main.cpp:
2529         * MiniBrowser/qt/qml/BrowserWindow.qml:
2530         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2531         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2532         * WebKitTestRunner/PlatformWebView.h:
2533         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2534         (WTR::PlatformWebView::PlatformWebView):
2535
2536 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2537
2538         [Qt] Change semantics of the haveQt() function to match API promises
2539
2540         Having Qt 5 does not imply that we have Qt 4, from an API point of
2541         view, as a major version can in theory break BC/SC. Our minimum
2542         version of Qt 4 will always be the latest released version of Qt 4,
2543         so the only place we should use haveQt(4, x) is when checking for
2544         the minimum requirements.
2545
2546         Reviewed by Simon Hausmann.
2547
2548         * qmake/mkspecs/features/default_pre.prf:
2549         * qmake/mkspecs/features/features.prf:
2550         * qmake/mkspecs/features/functions.prf:
2551
2552 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2553
2554         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2555         https://bugs.webkit.org/show_bug.cgi?id=69411
2556
2557         Reviewed by Martin Robinson.
2558
2559         * WebKitTestRunner/EventSenderProxy.h:
2560         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2561         * WebKitTestRunner/TestController.cpp:
2562         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2563         use the EventSender instead of WebProcess Event Simulation.
2564         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2565         (WTR::WTREventQueueItem::WTREventQueueItem):
2566         (WTR::EventSenderProxy::EventSenderProxy):
2567         (WTR::getMouseButtonModifiers):
2568         (WTR::eventSenderButtonToGDKButton):
2569         (WTR::EventSenderProxy::createMouseButtonEvent):
2570         (WTR::EventSenderProxy::updateClickCountForButton):
2571         (WTR::EventSenderProxy::replaySavedEvents):
2572         (WTR::EventSenderProxy::sendOrQueueEvent):
2573         (WTR::webkitModifiersToGDKModifiers):
2574         (WTR::getGDKKeySymForKeyRef):
2575         (WTR::EventSenderProxy::keyDown):
2576         (WTR::EventSenderProxy::mouseDown):
2577         (WTR::EventSenderProxy::mouseUp):
2578         (WTR::EventSenderProxy::mouseMoveTo):
2579         (WTR::EventSenderProxy::mouseScrollBy):
2580         (WTR::EventSenderProxy::leapForward):
2581
2582 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2583
2584         [Qt] Enable exports and constructor functions in static libs
2585
2586         Reviewed by Tor Arne Vestbø.
2587
2588         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2589         mac/win32-msvc equivalents when linking static libraries into a shared
2590         library or executable.
2591
2592 2011-11-09  Hayato Ito  <hayato@chromium.org>
2593
2594         [NRWT] Make results.html aware of reference filename in reftests.
2595         https://bugs.webkit.org/show_bug.cgi?id=71574
2596
2597         Reviewed by Ryosuke Niwa.
2598
2599         If a reference filename is different from the default one, include that in result summary
2600         so results.html can link to the correct reference file.
2601
2602         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2603         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2604
2605 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2606
2607         [wx] Unreviewed build fix. Update project files and
2608         add LTC stubs for new methods.
2609
2610         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2611         (LayoutTestController::addChromeInputField):
2612         (LayoutTestController::removeChromeInputField):
2613         (LayoutTestController::focusWebView):
2614         (LayoutTestController::setBackingScaleFactor):
2615         * waf/build/settings.py:
2616
2617 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2618
2619         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2620
2621         * wx/install-unix-extras:
2622
2623 2011-11-09  Eric Seidel  <eric@webkit.org>
2624
2625         Remove the concept of platform-dependent unittests
2626         https://bugs.webkit.org/show_bug.cgi?id=71963
2627
2628         Unreviewed.  Fix test-webkitpy on cygwin.
2629
2630         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2631
2632 2011-11-09  Dana Jansens  <danakj@chromium.org>
2633
2634         Add cc-bugs group to watch changes in chromium graphics
2635         https://bugs.webkit.org/show_bug.cgi?id=71690
2636
2637         Reviewed by David Levin.
2638
2639         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2640         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2641         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2642         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2643
2644 2011-11-09  Eric Seidel  <eric@webkit.org>
2645
2646         Remove more platform-dependent unittests
2647         https://bugs.webkit.org/show_bug.cgi?id=71971
2648
2649         Reviewed by Adam Barth.
2650
2651         Tests which only run on a couple platforms will break.
2652         All tests should run on all platforms where possible.
2653
2654         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2655         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2656         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2657         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2658
2659 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2660
2661         Merge in results to the test results server even if build numbers conflict
2662         https://bugs.webkit.org/show_bug.cgi?id=71967
2663
2664         Reviewed by Tony Chang.
2665
2666         This was initially meant to be a sanity check that we don't
2667         enter duplicate runs, but it turns out that we can reasonably get
2668         in these situations when a builder is clobbered (e.g. the build
2669         numbers start over again from 0).
2670
2671         * TestResultServer/model/jsonresults.py:
2672         * TestResultServer/model/jsonresults_unittest.py:
2673
2674 2011-11-09  Eric Seidel  <eric@webkit.org>
2675
2676         Remove the concept of platform-dependent unittests
2677         https://bugs.webkit.org/show_bug.cgi?id=71963
2678
2679         Reviewed by Adam Barth.
2680
2681         These have been the source of never-ending sadness.
2682         We'd change behavior and forget to update results in
2683         some unittests because they were only run on certain platforms.
2684         This change removes a large source of these platform-dependent
2685         unittests, which was caused by the port_maker stuff.
2686
2687         It's possible that this change will break test-webkitpy
2688         on some platforms, but that will be a one-time cost.
2689         I will fix the breakage by removing the platform-dependantness
2690         of any such broken tests.
2691
2692         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2693         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2694         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2695         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2696         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2697         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2698         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2699         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2700         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2701         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2702         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2703         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2704         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2705
2706 2011-11-09  Eric Seidel  <eric@webkit.org>
2707
2708         Make the Port object have a Host
2709         https://bugs.webkit.org/show_bug.cgi?id=71961
2710
2711         Reviewed by Adam Barth.
2712
2713         This has been a long time coming.
2714         Now that Port has a Host object, it's very easy
2715         to write unittests which use a properly mocked Port.
2716         Soon we will remove the executive, filesystem and user
2717         members of Port and get everything through the Host.
2718
2719         Note how in many callsites we're actually removing
2720         explicit mocks, since we're now always going to get the
2721         correct Executive/User/FileSystem from the
2722         Host and callsites don't need to be careful to pass each one.
2723
2724         This is prep-work for adding a new Environment member to
2725         Host and needing to be able to access the Environment
2726         member from Port functions w/o needing to pass an Environment
2727         object (or appropriate Mock) every place we create a Port object.
2728         Now that we have a single Host object to reach out through, its
2729         simple to add additional functionality (like Environment) while
2730         keeping our unittests properly mocked.
2731
2732         * Scripts/webkitpy/common/host.py:
2733         * Scripts/webkitpy/common/net/credentials_unittest.py:
2734         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2735         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2736         * Scripts/webkitpy/layout_tests/port/apple.py:
2737         * Scripts/webkitpy/layout_tests/port/base.py:
2738         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2739         * Scripts/webkitpy/layout_tests/port/chromium.py:
2740         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2741         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2742         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2743         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2744         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2745         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2746         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2747         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2748         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2749         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2750         * Scripts/webkitpy/layout_tests/port/efl.py:
2751         * Scripts/webkitpy/layout_tests/port/factory.py:
2752         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2753         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2754         * Scripts/webkitpy/layout_tests/port/gtk.py:
2755         * Scripts/webkitpy/layout_tests/port/mac.py:
2756         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2757         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2758         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2759         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2760         * Scripts/webkitpy/layout_tests/port/qt.py:
2761         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2762         * Scripts/webkitpy/layout_tests/port/test.py:
2763         * Scripts/webkitpy/layout_tests/port/webkit.py:
2764         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2765         * Scripts/webkitpy/layout_tests/port/win.py:
2766         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2767         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2768         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2769         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2770         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2771
2772 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2773
2774         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2775         https://bugs.webkit.org/show_bug.cgi?id=71561
2776
2777         Reviewed by Dimitri Glazkov.
2778
2779         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2780         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2781
2782 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2783
2784         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2785         https://bugs.webkit.org/show_bug.cgi?id=66772
2786
2787         Reviewed by Simon Fraser.
2788
2789         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2790         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2791
2792         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2793         in the FrameLoadDelegate and print the output in response to the notification.
2794
2795         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2796         (-[FrameLoadDelegate init]):
2797         (-[FrameLoadDelegate dealloc]):
2798         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2799
2800 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2801
2802         [GTK][DRT] window internals object is not reset after each test
2803         https://bugs.webkit.org/show_bug.cgi?id=71890
2804
2805         Reviewed by Martin Robinson.
2806
2807         Call WebCoreTestSupport::resetInternalsObject without going
2808         through DumpRenderTreeSupport.
2809
2810         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2811         (runTest):
2812
2813 2011-11-09  Beth Dakin  <bdakin@apple.com>
2814
2815         Build fix.
2816
2817         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2818         (AccessibilityUIElement::uiElementAttributeValue):
2819
2820 2011-11-09  Beth Dakin  <bdakin@apple.com>
2821
2822         Speculative build fix.
2823
2824         * DumpRenderTree/AccessibilityUIElement.h:
2825
2826 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2827
2828         Unreviewed build fix.
2829
2830         * DumpRenderTree/AccessibilityUIElement.cpp:
2831         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2832         A bad merge added this check that is making the bots sad.
2833
2834 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2835
2836         AX: crash when accessing selectedTab in a tab list
2837         https://bugs.webkit.org/show_bug.cgi?id=70938
2838
2839         Reviewed by Beth Dakin.
2840
2841         Add the ability to retrieve an element through an arbitrary attribute.
2842
2843         * DumpRenderTree/AccessibilityUIElement.cpp:
2844         (uiElementAttributeValueCallback):
2845         (AccessibilityUIElement::uiElementAttributeValue):
2846         (AccessibilityUIElement::getJSClass):
2847         * DumpRenderTree/AccessibilityUIElement.h:
2848         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2849         (AccessibilityUIElement::uiElementAttributeValue):
2850
2851 2011-11-09  Andy Wingo  <wingo@igalia.com>
2852
2853         Add webkitdirs.pm:getArchitecture implementation for GTK
2854         https://bugs.webkit.org/show_bug.cgi?id=71370
2855
2856         Reviewed by Xan Lopez.
2857
2858         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2859         implementation for ports using autotools, so that a vanilla
2860         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2861         to build-jsc on x86-64 machines.
2862
2863 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2864
2865         Unreviewed, rolling out r99707.
2866         http://trac.webkit.org/changeset/99707
2867
2868         Re-enable until we can disable it together with tests in one
2869         shot.
2870
2871         * qmake/mkspecs/features/features.prf:
2872
2873 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2874
2875         [Qt] Disable use of QtUiTools if the library/module is not found
2876
2877         We rely on the lookup order of prf files to inject our own uitools.prf
2878         that will verify that QtUiTools is in fact present before allowing the
2879         CONFIG += uitools to have any effect.
2880
2881         Reviewed by Simon Hausmann.
2882
2883         * DumpRenderTree/qt/DumpRenderTree.pro:
2884         * QtTestBrowser/QtTestBrowser.pro:
2885         * qmake/mkspecs/features/uitools.prf: Added.
2886
2887 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2888
2889         Unreviewed, rolling out r99701.
2890         http://trac.webkit.org/changeset/99701
2891
2892         Breaks Qt mac build
2893
2894         * qmake/mkspecs/features/functions.prf:
2895
2896 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2897
2898         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2899
2900         Reviewed by Tor Arne Vestbø.
2901
2902         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2903         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2904         is not up to the task of full XSLT support, so we should disable it.
2905
2906 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2907
2908         [Qt] Enable exports and constructor functions in static libs
2909
2910         Reviewed by Tor Arne Vestbø.
2911
2912         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2913         mac/win32-msvc equivalents when linking static libraries into a shared
2914         library or executable.
2915
2916 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2917
2918         [GTK][DRT] window internals object is not reset after each test
2919         https://bugs.webkit.org/show_bug.cgi?id=71890
2920
2921         Reviewed by Xan Lopez.
2922
2923         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2924         (runTest): reset the Internals object after each test.
2925
2926 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2927
2928         [Qt] Detect presence of QtUiTools and enable it only when available
2929
2930         The disable_uitools option was a workaround for missing detection.
2931
2932         Reviewed by Simon Hausmann.
2933
2934         * QtTestBrowser/QtTestBrowser.pro:
2935         * qmake/mkspecs/features/default_post.prf:
2936         * qmake/mkspecs/features/default_pre.prf:
2937
2938 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2939
2940         [Qt] Don't override config for the build_pass of debug_and_release
2941
2942         Qmake will parse the profile once for each configuration (debug and
2943         release), with the build_pass option set. In that situation we don't
2944         want to override what qmake is setting explicitly, otherwise the
2945         debug-step will end up hitting all the release-scopes.
2946
2947         Reviewed by Simon Hausmann.
2948
2949         * qmake/mkspecs/features/default_pre.prf:
2950
2951 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2952
2953         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2954
2955         * qmake/mkspecs/features/functions.prf:
2956
2957 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2958
2959         [Qt] Centralize duplicated code for linking the static libs
2960
2961         Reviewed by Tor Arne Vestbø.
2962
2963         * qmake/mkspecs/features/functions.prf:
2964         * qmake/mkspecs/features/javascriptcore.prf:
2965         * qmake/mkspecs/features/webcore.prf:
2966         * qmake/mkspecs/features/webkit2.prf:
2967
2968 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2969
2970         [Qt] Build system cleanup
2971         https://bugs.webkit.org/show_bug.cgi?id=71815
2972
2973         Reviewed by Kenneth Rohde Christiansen.
2974
2975         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2976         static library.
2977         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2978         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2979
2980 2011-11-08  Hayato Ito  <hayato@chromium.org>
2981
2982         [NRWT] Make single_test_runner aware of reference filename of test_input.
2983         https://bugs.webkit.org/show_bug.cgi?id=71567
2984
2985         Reviewed by Ryosuke Niwa.
2986
2987         Make single_test_runner honor a reference filename of given test_input so that
2988         we can use any file as reference html, instead of depending on implicit naming convention.
2989         The typical use case is to support w3c reftests.
2990
2991         No tests since no functional changes until there is a client.
2992         Test should be easily written with future clients.
2993
2994         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2995         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2996         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2997         * Scripts/webkitpy/layout_tests/models/test_input.py:
2998
2999 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=71839
3002         Update the leaks bot OS to Lion.
3003         Update the config.json to reflect the update.
3004
3005         Reviewed by Stephanie Lewis.
3006
3007         * BuildSlaveSupport/build.webkit.org-config/config.json:
3008
3009 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3010
3011         Unreviewed, rolling out r99626.
3012         http://trac.webkit.org/changeset/99626
3013         https://bugs.webkit.org/show_bug.cgi?id=71866
3014
3015         "C++ exceptions cannot be disabled without influencing the
3016         Objective-C exceptions" (Requested by benjaminp on #webkit).
3017
3018         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3019
3020 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3021
3022         [Mac] Disable C++ exceptions from DumpRenderTree
3023         https://bugs.webkit.org/show_bug.cgi?id=71834
3024
3025         Reviewed by Darin Adler.
3026
3027         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3028         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3029         which leads to crashes long after the exception was raised.
3030
3031         This patch disabled C++ exceptions in order to catch the problems where
3032         they happen when a C++ exception is raised.
3033
3034         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3035
3036 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3037
3038         Moved myself to the reviewer list (yay!).
3039
3040         * Scripts/webkitpy/common/config/committers.py:
3041
3042 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3043
3044         Added myself as a committer.
3045
3046         * Scripts/webkitpy/common/config/committers.py:
3047
3048 2011-11-08  Andy Wingo  <wingo@igalia.com>
3049
3050         Skip some ECMAScript tests that fail on Linux in some time zones.
3051         https://bugs.webkit.org/show_bug.cgi?id=71371
3052
3053         Reviewed by Martin Robinson.
3054
3055         * Scripts/run-javascriptcore-tests: Skip some more tests.
3056
3057 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3058
3059         [Qt] Unreviewed trivial fix after build system refactoring.
3060
3061         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3062
3063 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3064
3065         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3066
3067         If a pro file needs to access the OBJECTS_DIR it should use the
3068         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3069         after defaults_post has been processed.
3070
3071         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3072         the command line will override whatever we set in defaults_pre.
3073
3074         Reviewed by Simon Hausmann.
3075
3076         * qmake/mkspecs/features/default_post.prf:
3077         * qmake/mkspecs/features/default_pre.prf:
3078
3079 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3080
3081         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3082
3083         Reviewed by Simon Hausmann.
3084
3085         * qmake/mkspecs/features/default_post.prf:
3086
3087 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3088
3089         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3090         https://bugs.webkit.org/show_bug.cgi?id=71680
3091
3092         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3093         complete urls in MiniBrowser.
3094
3095         Reviewed by Tor Arne Vestbø.
3096
3097         * MiniBrowser/qt/BrowserWindow.cpp:
3098         (BrowserWindow::BrowserWindow):
3099         (BrowserWindow::load):
3100         * MiniBrowser/qt/qml/BrowserWindow.qml:
3101         * MiniBrowser/qt/utils.cpp:
3102         (Utils::urlFromUserInput):
3103         * MiniBrowser/qt/utils.h:
3104         (Utils::Utils):
3105
3106 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3107
3108         Added myself as a committer.
3109
3110         * Scripts/webkitpy/common/config/committers.py:
3111
3112 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3113
3114         Unreviewed webkitpy test fix after r99512.
3115
3116         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3117         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3118
3119 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3120
3121         Added myself as a committer.
3122
3123         * Scripts/webkitpy/common/config/committers.py:
3124
3125 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3126
3127         Unreviewed, rolling out r99470.
3128         http://trac.webkit.org/changeset/99470
3129         https://bugs.webkit.org/show_bug.cgi?id=71740
3130
3131         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3132
3133         * Scripts/webkitpy/common/config/watchlist:
3134
3135 2011-11-07  Tony Chang  <tony@chromium.org>
3136
3137         [chromium] update flakiness dashboard to reflect current bots
3138
3139         Reviewed by Ojan Vafai.
3140
3141         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3142             bots and merged linux debug bots into a single bot.
3143         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3144         (setupExpectationsTest):
3145
3146 2011-11-07  Dana Jansens  <danakj@chromium.org>
3147
3148         Add cc-bugs group to watch changes in chromium graphics
3149         https://bugs.webkit.org/show_bug.cgi?id=71690
3150
3151         Reviewed by James Robinson.
3152
3153         * Scripts/webkitpy/common/config/watchlist:
3154
3155 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3156
3157         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
3158         https://bugs.webkit.org/show_bug.cgi?id=70912
3159
3160         Reviewed by Ojan Vafai.
3161
3162         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
3163         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
3164
3165 2011-11-07  Eric Seidel  <eric@webkit.org>
3166
3167         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
3168         https://bugs.webkit.org/show_bug.cgi?id=62199
3169
3170         Reviewed by Dirk Pranke.
3171
3172         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3174         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3175
3176 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
3177
3178         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
3179         https://bugs.webkit.org/show_bug.cgi?id=71485
3180
3181         Reviewed by Darin Fisher.
3182
3183         * DumpRenderTree/chromium/EventSender.cpp:
3184         (EventSender::scalePageBy):
3185         * DumpRenderTree/chromium/TestShell.cpp:
3186         (TestShell::resetTestController):
3187
3188 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3189
3190         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
3191
3192         Allows us to not package up the whole Source/JavaScriptCore directory for the
3193         buildbots.
3194
3195         Reviewed-by Simon Hausmann.
3196
3197         * BuildSlaveSupport/built-product-archive:
3198         * Scripts/webkitdirs.pm:
3199         (jscProductDir):
3200
3201 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3202
3203         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
3204
3205         Reviewed-by Simon Hausmann.
3206
3207         * qmake/mkspecs/features/default_post.prf:
3208
3209 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3210
3211         [Qt] Sanitize qmake paths correctly before comparing
3212
3213         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
3214         which caused us to always generate derived webcore sources, but never build
3215         them. The bug has been fixed, and we now also sanitize paths for the injected
3216         bundle derived sources.
3217
3218         Reviewed by Simon Hausmann.
3219
3220         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3221         * qmake/mkspecs/features/functions.prf:
3222
3223 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3224
3225         [Qt] Print right order for changing feature defines
3226
3227         Reviewed by Simon Hausmann.
3228
3229         * Scripts/webkitdirs.pm:
3230         (buildQMakeProject):
3231
3232 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
3233
3234         [Qt] Unreviewed trivial fix after build system refactoring.
3235
3236         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
3237
3238 2011-11-06  Eric Seidel  <eric@webkit.org>
3239
3240         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3241         https://bugs.webkit.org/show_bug.cgi?id=66078
3242
3243         Unreviewed.  Add an assert about the type of "args"
3244         to our Executive Mocks and fix a piece of code
3245         from this patch which was hitting that assert
3246         when executing for real.
3247
3248         * Scripts/webkitpy/common/system/executive_mock.py:
3249         * Scripts/webkitpy/layout_tests/port/webkit.py:
3250
3251 2011-11-06  Eric Seidel  <eric@webkit.org>
3252
3253         Split chunk handling out of prepare_lists_and_print_output to make it more readable
3254         https://bugs.webkit.org/show_bug.cgi?id=71629
3255
3256         Reviewed by Adam Barth.
3257
3258         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3259
3260 2011-11-06  Eric Seidel  <eric@webkit.org>
3261
3262         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3263         https://bugs.webkit.org/show_bug.cgi?id=66078
3264
3265         Reviewed by Adam Barth.
3266
3267         The runtime feature detection was fixed to work in bug 64472.
3268         In this bug I moved the symbol-based feature detection from
3269         popen() to Executive.run_command and cleaned up the callers
3270         and unittests to make sure that we're correctly parsing the
3271         nm output correctly.  The old code happened to work even though
3272         the runtime-features path was using "str in list" and the
3273         symbol features path was using "str in str" and it just happened
3274         to do what we wanted to.  Now runtime features and symbol feature
3275         blacklists are computed separately (and with better documentation).
3276
3277         This system remains confusing, partially because these are black-lists
3278         which are amended to whatever static blacklist may exist for the
3279         port as part of a Skipped list file.
3280
3281         For example, notice how the runtime feature list only has directory
3282         blacklists for a couple features.  If all features are off,
3283         how do we skip enough tests with only 2 entries in the blacklist map?
3284         The answer is that Windows is the only port to use runtime feature
3285         detection, and the win/Skipped file turns off all the other features
3286         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
3287         which use symbol-based feature detection turn of mathml, wcss, etc
3288         using the blacklists found in _missing_symbol_to_skipped_tests.
3289
3290         I also noticed a couple places where we still referenced xhtmlmp
3291         even though support for such has been removed from WebKit.  Removed those.
3292
3293         This should result in no functional change.
3294
3295         * Scripts/webkitpy/layout_tests/port/gtk.py:
3296          - Use self._filesystem instead of os.path
3297         * Scripts/webkitpy/layout_tests/port/webkit.py:
3298         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3299
3300 2011-11-06  Dan Bernstein  <mitz@apple.com>
3301
3302         Made show-pretty-diff work when the input path contains spaces.
3303
3304         Reviewed by Anders Carlsson.
3305
3306         * Scripts/show-pretty-diff:
3307
3308 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
3309
3310         [chromium] Use the security origin instead of the URL when checking notification permissions
3311         https://bugs.webkit.org/show_bug.cgi?id=71590
3312
3313         Reviewed by Adam Barth.
3314
3315         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3316         (NotificationPresenter::checkPermission):
3317         * DumpRenderTree/chromium/NotificationPresenter.h:
3318
3319 2011-11-05  Darin Adler  <darin@apple.com>
3320
3321         Fix a small leak in Mac version of LayoutTestController
3322         https://bugs.webkit.org/show_bug.cgi?id=71615
3323
3324         Reviewed by Mark Rowe.
3325
3326         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3327         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
3328         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
3329
3330 2011-11-04  Eric Seidel  <eric@webkit.org>
3331
3332         Upgrade to the latest Mechanize
3333         https://bugs.webkit.org/show_bug.cgi?id=71594
3334
3335         Reviewed by Adam Barth.
3336
3337         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3338         Mechanize is no longer two separate libraries, so importing it is much simpler.
3339
3340         * Scripts/webkitpy/thirdparty/__init__.py:
3341
3342 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3343
3344         Crash in ScrollAnimator.cpp
3345         https://bugs.webkit.org/show_bug.cgi?id=69865
3346
3347         The code in ScrollAnimator assumes that horizontal per-page mouse
3348         wheel events cannot happen, which is not true. This patch adds layout
3349         tests for all paging wheel event situations and fixes the broken
3350         horizontal case.
3351
3352         Reviewed by Anders Carlsson
3353
3354         * DumpRenderTree/chromium/EventSender.cpp:
3355         (EventSender::handleMouseWheel): Added the ability to specify that a
3356         mouse wheel event should be paging.
3357
3358 2011-11-04  Eric Seidel  <eric@webkit.org>
3359
3360         Remove deprecated free functions in port.factory
3361         https://bugs.webkit.org/show_bug.cgi?id=71494
3362
3363         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3364
3365         * Scripts/new-run-webkit-httpd:
3366
3367 2011-11-04  Adam Roben  <aroben@apple.com>
3368
3369         Remove Leopard-specific code from build.webkit.org
3370
3371         We don't have any Leopard bots anymore.
3372
3373         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3374
3375         Reviewed by Mark Rowe.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3378         and StopATSServer steps.
3379         (unitTestsSupported): Removed check for mac-leopard.
3380         (TestFactory.__init__): Removed Leopard-specific steps.
3381
3382 2011-11-04  Eric Seidel  <eric@webkit.org>
3383
3384         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3385         https://bugs.webkit.org/show_bug.cgi?id=71549
3386
3387         Reviewed by Adam Barth.
3388
3389         Several members of Host didn't really belong there
3390         and were instead specific to WebKitPatch, so I've moved
3391         them up onto that class.
3392
3393         * Scripts/webkitpy/common/host.py:
3394         * Scripts/webkitpy/common/host_mock.py:
3395         * Scripts/webkitpy/tool/main.py:
3396         * Scripts/webkitpy/tool/mocktool.py:
3397         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3398
3399 2011-11-04  Tony Chang  <tony@chromium.org>
3400
3401         garden-o-matic: bring back party time!
3402         https://bugs.webkit.org/show_bug.cgi?id=71582
3403
3404         Reviewed by Adam Barth.
3405
3406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3412
3413 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3414
3415         [EFL] DRT: Fix the order of the items in the dumped history list.
3416         https://bugs.webkit.org/show_bug.cgi?id=71562
3417
3418         It did not make much sense to hold the history list in a map, as we do not need
3419         the keys. And the printed items must be sorted by target, which is more easily
3420         done with a vector.
3421
3422         Should make tests such as http/tests/navigation/error404-frames.html pass.
3423
3424         Reviewed by Antonio Gomes.
3425
3426         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3427         (compareHistoryItemsByTarget):
3428         (dumpHistoryItem):
3429
3430 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3431
3432         [Qt] Remove ENABLE_SQLITE from qmake files
3433         https://bugs.webkit.org/show_bug.cgi?id=71546
3434
3435         Reviewed by Simon Hausmann.
3436
3437         * qmake/mkspecs/features/features.prf:
3438         * qmake/mkspecs/features/webcore.prf:
3439
3440 2011-11-04  Adam Barth  <abarth@webkit.org>
3441
3442         watchlist for WebIDL shouldn't trigger on Internals.idl
3443         https://bugs.webkit.org/show_bug.cgi?id=70657
3444
3445         Reviewed by David Levin.
3446
3447         Internals.idl isn't part of the Web-facing IDL in the project.
3448
3449         * Scripts/webkitpy/common/config/watchlist:
3450
3451 2011-11-04  Anders Carlsson  <andersca@apple.com>
3452
3453         Fix WKTR crash when running NPN_ConvertPoint test.
3454
3455         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3456
3457         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3458         (ConvertPoint::NPP_SetWindow):
3459
3460 2011-11-04  Anders Carlsson  <andersca@apple.com>
3461
3462         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3463         https://bugs.webkit.org/show_bug.cgi?id=71570
3464
3465         Reviewed by Simon Fraser.
3466
3467         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3468         (PluginTest::NPP_SetWindow):
3469         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3470         Remove the NPP parameter from NPP_SetWindow.
3471
3472         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3473         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3474         Remove the NPP parameter from NPP_SetWindow.
3475
3476         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3477         (PassDifferentNPPStruct::NPP_SetWindow):
3478         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3479
3480         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3481         (ConvertPoint::NPP_SetWindow):
3482         Run the test from NPP_SetWindow and call notifyDone() when done.
3483
3484         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3485         (NPP_SetWindow):
3486         Remove unnecessary parameter.
3487
3488 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3489
3490         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3491
3492         Rubber-stamped by Tor Arne Vestbø.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3495         changed slightly after the refactoring.
3496
3497 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3498
3499         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3500
3501         Reviewed by Simon Hausmann.
3502
3503         * qmake/mkspecs/features/default_pre.prf:
3504
3505 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3506
3507         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3508
3509         Reviewed by Simmon Hausmann.
3510
3511         * qmake/mkspecs/features/default_pre.prf:
3512
3513 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3514
3515         [Qt] Disable STDIN check before cleaning build dir
3516
3517         It didn't work on the bots.
3518
3519         Reviewed by Ossy.
3520
3521         * Scripts/webkitdirs.pm:
3522
3523 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3524
3525         [Qt] Don't build all of webkit when running build-jsc
3526
3527         In case the whole webkit project was built, but we then subsequently
3528         want to build only JSC, we need to run make in the proper subdirectory.
3529
3530         This also means the incremental target needs to be added to all
3531         makefiles.
3532
3533         Reviewed by Simmon Hausmann.
3534
3535         * Scripts/webkitdirs.pm:
3536         (buildQMakeProject):
3537         * qmake/mkspecs/features/default_post.prf:
3538
3539 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3540
3541         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3542
3543         Reviewed by Tor Arne Vestbø.
3544
3545         * Scripts/webkitdirs.pm:
3546         (jscProductDir): jsc path changed.
3547
3548 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3549
3550         [Qt] Error out early if trying to build against Qt < 4.8
3551
3552         Reviewed by Simon Hausmann.
3553
3554         * qmake/mkspecs/features/default_pre.prf:
3555
3556 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3557
3558         Fix run-launcher for Qt and Gtk.
3559
3560         Rubber-stamped by Tor Arne Vestbø.
3561
3562         * Scripts/webkitdirs.pm:
3563         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3564
3565 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3566
3567         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3568
3569         Reviewed by Simon Hausmann.
3570
3571         * Scripts/build-webkit:
3572
3573 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3574
3575         [GTK] Use web view title as window title in MiniBrowser
3576         https://bugs.webkit.org/show_bug.cgi?id=71544
3577
3578         Reviewed by Philippe Normand.
3579
3580         * MiniBrowser/gtk/BrowserWindow.c:
3581         (webViewURIChanged): Removed extra space.
3582         (webViewTitleChanged): Set window title using
3583         webkit_web_view_get_title().
3584         (browser_window_init): Set initial default window title.
3585         (browserWindowConstructed): Connect to WebView notify::title
3586         signal.
3587
3588 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3589
3590         [Qt] Refactor and clean up the qmake build system
3591
3592         The qmake build system has accumulated a bit of cruft and redundancy
3593         over time. There's also a fairly tight coupling between how to build
3594         the various targets, and _what_ to build, making it harder to add new
3595         rules or sources. This patch aims to elevate these issues somewhat.
3596
3597         This is a short-list of the changes:
3598
3599           * The rules for how to build targets are now mostly contained as
3600             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3601             allows us to do pre- and post-processing of each project file,
3602             which helps to clean up the actual project files.
3603
3604           * Derived sources are no longer generated as a separate make-step
3605             but is part of each target's project file as a subdir. Makefile
3606             rules are used to ensure that we run make on the derived sources
3607             before running qmake on the actual target makefile. This makes
3608             it easier to keep a proper dependency between derived sources
3609             and the target.
3610
3611           * We use GNU make and the compiler to generate dependencies on
3612             UNIX-based systems running Qt 5. This allows us to lessen the
3613             need to run qmake, which should reduce compile time.
3614
3615           * WebKit2 is now build by default if building with Qt 5. It can
3616             be disabled by passing --no-webkit2 to build-webkit.
3617
3618         The result of these changes are hopefully a cleaner and easier
3619         build system to modify, and faster build times due to no longer
3620         running qmake on every single build. It's also a first step
3621         towards possibly generating the list of sources using another
3622         build system.
3623
3624         https://bugs.webkit.org/show_bug.cgi?id=71222
3625
3626         Reviewed by Simon Hausmann.
3627
3628         * DerivedSources.pro: Removed.
3629         * DumpRenderTree/qt/DumpRenderTree.pro:
3630         * DumpRenderTree/qt/ImageDiff.pro:
3631         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3632         * MiniBrowser/qt/MiniBrowser.pro:
3633         * QtTestBrowser/QtTestBrowser.pro:
3634         * QtTestBrowser/launcherwindow.cpp:
3635         (LauncherWindow::initializeView):
3636         (LauncherWindow::createChrome):
3637         (LauncherWindow::screenshot):
3638         * QtTestBrowser/launcherwindow.h:
3639         (WindowOptions::WindowOptions):
3640         * Scripts/build-webkit:
3641         (unlinkZeroFiles):
3642         * Scripts/webkitdirs.pm:
3643         (qtFeatureDefaults):
3644         (promptUser):
3645         (buildQMakeProject):
3646         * Tools.pro:
3647         * WebKitTestRunner/DerivedSources.pri: Added.
3648         * WebKitTestRunner/DerivedSources.pro: Removed.
3649         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3650         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3651         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3652         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3653         * WebKitTestRunner/Target.pri: Added.
3654         * WebKitTestRunner/WebKitTestRunner.pro:
3655         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3656         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3657         * qmake/README: Added.
3658         * qmake/mkspecs/features/default_post.prf: Added.
3659         * qmake/mkspecs/features/default_pre.prf: Added.
3660         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3661         * qmake/mkspecs/features/functions.prf: Added.
3662         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3663         * qmake/mkspecs/features/mac/default_post.prf: Added.
3664         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3665         * qmake/mkspecs/features/minimal_qt.prf: Added.
3666         * qmake/mkspecs/features/qtwebkit.prf: Added.
3667         * qmake/mkspecs/features/rpath.prf: Added.
3668         * qmake/mkspecs/features/unix/default_post.prf: Added.
3669         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3670         * qmake/mkspecs/features/valgrind.prf: Added.
3671         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3672         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3673         * qmake/mkspecs/features/win32/default_post.prf: Added.
3674         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3675         * qmake/syncqt-4.8: Added.
3676         (showUsage):
3677         ():
3678         (copyFile):
3679         (symlinkFile):
3680
3681 2011-11-04  Eric Seidel  <eric@webkit.org>
3682
3683         Remove deprecated free functions in port.factory
3684         https://bugs.webkit.org/show_bug.cgi?id=71494
3685
3686         Unreviewed.  Fixing exception seen when running test-webkitpy.
3687
3688         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3689         unittest, since that script is nearly ready to be deleted.  But I added
3690         it back at the last second and failed to run the tests. :(
3691         This fixes the exception the bots were seeing.
3692
3693         * Scripts/webkitpy/style/checkers/test_expectations.py:
3694         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3695         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3696
3697 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3698
3699         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3700         https://bugs.webkit.org/show_bug.cgi?id=71163
3701
3702         Reviewed by Ryosuke Niwa.
3703
3704         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3705         (WebPreferences::applyTo):
3706
3707 2011-11-03  Eric Seidel  <eric@webkit.org>
3708
3709         Remove deprecated free functions in port.factory
3710         https://bugs.webkit.org/show_bug.cgi?id=71494
3711
3712         Reviewed by Adam Barth.
3713
3714         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3715         free functions in factory.py.  To remove these required fixing all callsites
3716         to use MockHost, Host, or PortFactory where appropriate.  After this change
3717         we're only left with a handfull of places where we inappropraitely use a
3718         real Executive, FileSystem or User object during unittesting.
3719
3720         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3721          - These PortFactory overrides were from an earlier edition of my previous patch
3722            in the end, I removed MockPortFactory so all tests ended up with this same
3723            real PortFactory() with a MockHost.  This was simply redundent code.
3724         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3725          - Use MockHost to get a mocked-out PortFactory.
3726         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3727          - This code has no access to a Host object, so we just use a default PortFactory
3728            for now.  This will still incorrectly create real Executive/FileSystem objects
3729            durring unittesting, which is wrong. :(
3730         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3731          - Use a MockHost to get a mocked PortFactory.
3732         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3733          - Use a MockHost to get a mocked PortFactory.
3734         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3735          - ditto.
3736         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3737          - ditto.
3738         * Scripts/webkitpy/layout_tests/port/__init__.py:
3739          - factory.get no longer exists.  Yay!
3740         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3741          - Use a MockHost to get a mocked PortFactory.
3742            To do this efficiently, I created a helper function
3743            and combined all these (mostly redundant) tests into one test
3744            with several calls to the helper function.
3745         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3746          - Pass MockUser and MockExecutive in these port testing subclasses.
3747          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3748         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3749          - Awesome windows hacks should only happen on win32.  Once we started
3750            using MockExecutives these 'svn help' commands started printing in
3751            other tests, which is how I found this bug.
3752         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3753          - DryRunPort has no Host, so just use a PortFactory() directly.
3754            This will do the wrong thing if we're unittesting the DryRun port
3755            but it's no worse than the existing code.
3756         * Scripts/webkitpy/layout_tests/port/factory.py:
3757          - Remove the free functions.
3758          - Fix argument overriding to be able to override None.
3759         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3760          - Use a mocked-out PortFactory during testing.
3761         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3762          - Pass MockExecutive and MockUser to these manual Port instantiations.
3763         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3764          - No access to a Host object here, so just using PortFactory directly.
3765            This is wrong, but no more wrong than the existing code was.
3766         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3767          - Use a MockHost to get a mocked out PortFactory.
3768         * Scripts/webkitpy/layout_tests/port/test.py:
3769          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3770         * Scripts/webkitpy/layout_tests/port/win.py:
3771          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3772            now that we're actually passing MockExecutive to most Port instantiations during testing.
3773         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3774          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3776          - Host is the future.
3777         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3778          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3779            we don't need to pass MockUser explicitly, it does that automatically for us.
3780         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3781          - Use a MockHost to get a mocked out PortFactory.
3782         * Scripts/webkitpy/style/checkers/test_expectations.py:
3783          - We don't have access to a Host object, so using PortFactory() directly.
3784         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3785          - Remove unused variable.
3786         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3787          - Host isn't accessible here, so using PortFactory() directly, which
3788            although unfortunate is no worse than before.
3789         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3790          - Testing is much easier when you don't need to hack global state...
3791         * Scripts/webkitpy/tool/commands/expectations.py:
3792          - Use the port_factory on the tool.
3793         * Scripts/webkitpy/tool/commands/rebaseline.py:
3794          - ditto.
3795         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3796          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3797            the arguments in the right order.  Fixing that made it use a MockFileSystem
3798            (like it had been trying to), which then required us to actually populate
3799            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3800         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3801          - Get the port_factory from the tool.
3802         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3803          - Ditto.
3804         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3805          - Use a MockHost to get a mocked out Port object.
3806
3807 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3808
3809         [EFL] DRT: Allow choosing which backing store to use.
3810         https://bugs.webkit.org/show_bug.cgi?id=70532
3811
3812         Reviewed by Antonio Gomes.
3813
3814         This change makes it possible to change the backing store used by DRT
3815         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3816         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3817
3818         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3819         (DumpRenderTreeChrome::createView):
3820         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3821         (shouldUseSingleBackingStore):
3822         (chooseAndInitializeAppropriateSmartClass):
3823         (drtViewAdd):
3824         * DumpRenderTree/efl/DumpRenderTreeView.h:
3825
3826 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3827
3828         JS Test Harness: Remove more link tags
3829         https://bugs.webkit.org/show_bug.cgi?id=71339
3830
3831         Reviewed by Ojan Vafai.
3832
3833         * Scripts/make-new-script-test:
3834         (writeTestFile): Don't output <link>
3835
3836 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3837
3838         Reviewed by Martin Robinson.
3839
3840         [GTK] arguments passed to build-jsc are not taken into account
3841         https://bugs.webkit.org/show_bug.cgi?id=58333
3842
3843         * Scripts/build-jsc:
3844
3845 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3846
3847         [GTK] Show url of history items in a status bar in MiniBrowser
3848         https://bugs.webkit.org/show_bug.cgi?id=71474
3849
3850         Reviewed by Martin Robinson.
3851
3852         * MiniBrowser/gtk/BrowserWindow.c:
3853         (browserWindowSetStatusText): Set status text and show/hide the
3854         status label.
3855         (resetStatusText): Reset status text when history menu is hidden.
3856         (browserWindowHistoryItemSelected): Show url of currently selected
3857         history item.
3858         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3859         menu to reset the status text.
3860         (browserWindowConstructed): Use GtkOverlay if available to show
3861         status text.
3862
3863 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3864
3865         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3866         https://bugs.webkit.org/show_bug.cgi?id=71466
3867
3868         Reviewed by Martin Robinson.
3869
3870         * MiniBrowser/gtk/BrowserWindow.c:
3871         (browserWindowHistoryItemActivated): Go to selected back formard
3872         list item using webkit_web_view_go_to_back_forward_list_item()
3873         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3874         given GList of WebKitBackForwardListItems.
3875         (browserWindowUpdateNavigationActions): Enable/disable back and
3876         forward buttons depending on whether it's possible to go
3877         back/forward. Create a menu for back and forward toolbar buttons.
3878         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3879         (browserWindowConstructed): Connect to WebKitBackForwardList
3880         changed signal.
3881
3882 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3883
3884         [Qt] Remove Maemo specific code paths
3885         https://bugs.webkit.org/show_bug.cgi?id=71476
3886
3887         Reviewed by Kenneth Rohde Christiansen.
3888
3889         * QtTestBrowser/launcherwindow.cpp:
3890         (LauncherWindow::~LauncherWindow):
3891         (LauncherWindow::init):
3892         (LauncherWindow::showLinkHover):
3893         (LauncherWindow::selectElements):
3894         (LauncherWindow::showFPS):
3895         (LauncherWindow::updateFPS):
3896         * QtTestBrowser/launcherwindow.h:
3897         (WindowOptions::WindowOptions):
3898         * QtTestBrowser/locationedit.cpp:
3899         * QtTestBrowser/locationedit.h:
3900
3901 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3902
3903         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3904         https://bugs.webkit.org/show_bug.cgi?id=71461
3905
3906         Reviewed by Martin Robinson.
3907
3908         * MiniBrowser/gtk/BrowserWindow.c:
3909         (resetEntryProgress): Reset the entry progress after a while when
3910         load has been completed.
3911         (webViewLoadProgressChanged): Update location entry progress.
3912         (browserWindowConstructed): Connect to WebView
3913         notify::estimated-load-progress signal.
3914
3915 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3916
3917         [GTK] Remove WebKit2 C API from MiniBrowser
3918         https://bugs.webkit.org/show_bug.cgi?id=71459
3919
3920         Reviewed by Martin Robinson.
3921
3922         Use the GTK+ API instead to add minimum functionality. The other
3923         features will be ported to GTK+ API in following patches.
3924
3925         * MiniBrowser/gtk/BrowserWindow.c:
3926         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3927         (goBackCallback): Use webkit_web_view_go_back().
3928         (goForwardCallback): Use webkit_web_view_go_forward().
3929         (webViewURIChanged): Update location entry with current uri using
3930         webkit_web_view_get_uri().
3931         (browserWindowFinalize):
3932         (browserWindowGetProperty):
3933         (browserWindowSetProperty):
3934         (browser_window_init):
3935         (browserWindowConstructed): Connect to notify::uri signal of
3936         WebView to be notified when the URI changes.
3937         (browser_window_class_init):
3938         (browser_window_new): Use WebKitWebView.
3939         (browser_window_get_view): Use WebKitWebView
3940         * MiniBrowser/gtk/BrowserWindow.h:
3941         * MiniBrowser/gtk/GNUmakefile.am:
3942         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3943         * MiniBrowser/gtk/main.c:
3944         (loadURI): Use webkit_web_view_new().
3945         (main):
3946
3947 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3948
3949         [Qt] Unable to start MiniBrowser after run-webkit-tests
3950         https://bugs.webkit.org/show_bug.cgi?id=71469
3951
3952         Reviewed by Csaba Osztrogonác.
3953
3954         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3955         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3956         line arguments.
3957
3958 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3959
3960         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3961         https://bugs.webkit.org/show_bug.cgi?id=71445
3962
3963         Reviewed by Martin Robinson.
3964
3965         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3966         (initializeFonts): set directoriesDescription only when needed.
3967         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3968         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3969         refactored the font files loading code to avoid copy/pastes, ease
3970         maintenance and future font directories additions.
3971
3972 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3973
3974         [GTK] Remove GtkLauncher2
3975         https://bugs.webkit.org/show_bug.cgi?id=71449
3976
3977         Reviewed by Martin Robinson.
3978
3979         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3980         made sense when we wanted to implement the exactly same wk1 API
3981         for wk2. Now the code would require an ifdef for most the api, so
3982         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3983         GTK+ API.
3984
3985         * GNUmakefile.am:
3986         * GtkLauncher/main.c:
3987         (notifyProgressCb):
3988         (closeWebViewCb):
3989         (createBrowser):
3990         (addWebSettingsGroupToContext):
3991         (main):
3992
3993 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3994
3995         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3996         https://bugs.webkit.org/show_bug.cgi?id=71359
3997
3998         Reviewed by Martin Robinson.
3999
4000         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4001         (initializeFonts): Add the new font path for Debian fonts and
4002         refactored the font files loading code to avoid copy/pastes, ease
4003         maintenance and future font directories additions.
4004
4005 2011-11-02  Eric Seidel  <eric@webkit.org>
4006
4007         Move Mocks into _mock files near their implementations
4008         https://bugs.webkit.org/show_bug.cgi?id=71425
4009
4010         Reviewed by Adam Barth.
4011
4012         This entire change is splitting mocktool.py into separate _mock.py files
4013         and placing them next to their real implementations.
4014
4015         I also deleted MockPortFactory (since it was wrong) and was just hiding
4016         the fact that the "skipped-ports" command was broken (and has been for a long time).
4017         So I made MockHost use a real PortFactory (passed a MockHost) and changed
4018         the skipped-ports implementation to use modern PortFactory methods.
4019
4020         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4021         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
4022         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4023         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
4024         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
4025         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4026         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
4027         * Scripts/webkitpy/common/host.py:
4028         * Scripts/webkitpy/common/host_mock.py: Added.
4029         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
4030         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4031         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
4032         * Scripts/webkitpy/common/net/credentials_unittest.py:
4033         * Scripts/webkitpy/common/net/failuremap_unittest.py:
4034         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
4035         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
4036         * Scripts/webkitpy/common/net/statusserver_unittest.py:
4037         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
4038         * Scripts/webkitpy/common/system/executive.py:
4039         * Scripts/webkitpy/common/system/executive_mock.py:
4040         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
4041         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
4042         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
4043         * Scripts/webkitpy/common/system/workspace_unittest.py:
4044         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
4045         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4046         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
4047         * Scripts/webkitpy/layout_tests/port/__init__.py:
4048         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4049         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
4050         * Scripts/webkitpy/layout_tests/port/factory.py:
4051         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4052         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4053         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
4054         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
4055         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4056         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4057         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4058         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4059         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4060         * Scripts/webkitpy/test/main.py:
4061         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
4062         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4063         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4064         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4065         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4066         * Scripts/webkitpy/tool/mocktool.py:
4067         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4068
4069 2011-11-02  Dan Bernstein  <mitz@apple.com>
4070
4071         Fixed the build and removed another copy to ColorBits.ttf.
4072
4073         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4074         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4075         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
4076
4077 2011-11-02  Dan Bernstein  <mitz@apple.com>
4078
4079         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
4080         https://bugs.webkit.org/show_bug.cgi?id=71424
4081
4082         Reviewed by Sam Weinig.
4083
4084         Removed the ColorBits font and the code to register it in the process
4085         running the tests. The font was only used by the aforementioned test,
4086         which is now being removed.
4087
4088         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
4089         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
4090         * DumpRenderTree/mac/DumpRenderTree.mm:
4091         (allowedFontFamilySet):
4092         (activateTestingFonts):
4093         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4094         (WTR::inititializeFontConfigSetting):
4095         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4096         (WTR::allowedFontFamilySet):
4097         (WTR::activateFonts):
4098
4099 2011-11-02  Dan Bernstein  <mitz@apple.com>
4100
4101         Fix an intermittent hang in RenderedImageFromDOMRange.
4102
4103         Reviewed by Anders Carlsson.
4104
4105         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4106         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
4107         immediately if there are no sources by passing a date in the distant past.
4108
4109 2011-11-02  Adam Roben  <aroben@apple.com>
4110
4111         Add git-add-reviewer
4112
4113         I've been using this script for a while to add reviewers to git commits in my local
4114         repository before pushing them to the Subversion repository. Basic usage is:
4115
4116         git-add-reviewer HEAD^ "Joe Schmoe"
4117         or
4118         git-add-reviewer -i trunk
4119
4120         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
4121         git commits
4122
4123         Reviewed by Sam Weinig.
4124
4125         * Scripts/git-add-reviewer: Added.
4126         (top level): Parse options, check that the working tree is clean, then run in either
4127         interactive or non-interactive mode as appropriate.
4128         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
4129         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
4130         editor exits, we check out the commit just before the earliest one we're modifying. Then
4131         for each commit, we check it out, update the reviewer, and amend the commit to contain the
4132         new reviewer. Finally, we update the branch that was originally checked out to point to the
4133         last amended commit.
4134         (nonInteractive): Check out the commit to modify, write the current commit message to the
4135         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
4136         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
4137         a usage message and exit.
4138         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
4139         and index are clean.
4140         (fail): Print out the specified error message, if any, and return false. This function is
4141         used as a return value in various error cases throughout the script.
4142         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
4143         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
4144         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
4145         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
4146
4147         (addReviewerToChangeLog):
4148         (addReviewerToCommitMessage):
4149         These just call through to addReviewerToFile.
4150
4151         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
4152         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
4153         temp file, then move the temp file over the original file and stage it for the next commit.
4154         (head): Returns the name of the currently-checked-out branch.
4155         (isAncestor): Returns true if the first commit is an ancestor of the second.
4156         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
4157         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
4158         (resetToCommit): Checks out the given commit, throwing away any local changes.
4159         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
4160         the specified file.
4161         (rebaseOntoHead): Rebases the specified branch onto HEAD.
4162         (checkout): Checks out the given commit.
4163         (getConfigValue): Reads the specified config variable from git-config.
4164
4165 2011-11-02  Dean Jackson  <dino@apple.com>
4166
4167         Add ENABLE_CSS_SHADERS flag
4168         https://bugs.webkit.org/show_bug.cgi?id=71394
4169
4170         Reviewed by Sam Weinig.
4171
4172         * Scripts/build-webkit:
4173
4174 2011-10-31  Eric Seidel  <eric@webkit.org>
4175
4176         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
4177         https://bugs.webkit.org/show_bug.cgi?id=71237
4178
4179         Reviewed by Adam Barth.
4180
4181         Calling the static version of factory.get() with proper mocking
4182         requires passsing an explict filesystem, executive, etc.
4183         So instead, we use a PortFactory instance and pass it a Host pointer.
4184         I had to add a MockHost since we'd not needed a non-host tool before now.
4185
4186         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4187         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4188         * Scripts/webkitpy/tool/commands/rebaseline.py:
4189         * Scripts/webkitpy/tool/mocktool.py:
4190
4191 2011-11-02  Anders Carlsson  <andersca@apple.com>
4192
4193         Update for the WebKit2 API fixage.
4194
4195         * MiniBrowser/mac/BrowserWindowController.m:
4196         (-[BrowserWindowController awakeFromNib]):
4197         * WebKitTestRunner/TestController.cpp:
4198         (WTR::TestController::initialize):
4199
4200 2011-11-02  Anders Carlsson  <andersca@apple.com>
4201
4202         Fix build.
4203
4204         Add new functions to the page loader client.
4205
4206         * MiniBrowser/mac/BrowserWindowController.m:
4207         (-[BrowserWindowController awakeFromNib]):
4208         * WebKitTestRunner/TestController.cpp:
4209         (WTR::TestController::initialize):
4210
4211 2011-11-02  Dan Bernstein  <mitz@apple.com>
4212
4213         <rdar://problem/10336700> Add API to get rendered text image without having to select it
4214         https://bugs.webkit.org/show_bug.cgi?id=71407
4215
4216         Reviewed by Simon Fraser.
4217
4218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4219         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
4220         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
4221         (TestWebKitAPI::TEST):
4222
4223 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
4224
4225         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
4226         https://bugs.webkit.org/show_bug.cgi?id=71351
4227
4228         Reviewed by Darin Adler.
4229
4230         Add the delimiter "/" at the end of the path instead of adding +1 when using
4231         the path.
4232
4233         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4234         (-[NSURL _drt_descriptionSuitableForTestResult]):
4235
4236 2011-11-02  Tom Sepez  <tsepez@chromium.org>
4237
4238         XSSAuditor is silent
4239         https://bugs.webkit.org/show_bug.cgi?id=70973
4240
4241         Reviewed by Adam Barth.
4242
4243         * DumpRenderTree/chromium/WebViewHost.cpp:
4244         (WebViewHost::didDetectXSS):
4245         * DumpRenderTree/chromium/WebViewHost.h:
4246         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4247         (-[FrameLoadDelegate webView:didDetectXSS:]):
4248         * MiniBrowser/mac/BrowserWindowController.m:
4249         (didDetectXSSForFrame):
4250         (-[BrowserWindowController awakeFromNib]):
4251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4252         (WTR::InjectedBundlePage::InjectedBundlePage):
4253         (WTR::InjectedBundlePage::didDetectXSSForFrame):
4254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4255
4256 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
4257
4258         [Qt] REGRESSION: 5 editing tests fail
4259         https://bugs.webkit.org/show_bug.cgi?id=71117
4260
4261         Reviewed by Andreas Kling.
4262
4263         Make sure that the view is properly focused, in order to get the
4264         didBeginEditing DRT calls.
4265
4266         This requires activating the window (the call will result in a FocusIn
4267         event to the window as well as setting QGuiApplication::focusWindow())
4268         as well as enabling the focus on the view item. The signature of
4269         setFocus has changed to take a boolean.
4270
4271         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4272         (WTR::WrapperWindow::handleStatusChanged):
4273
4274 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
4275
4276         [chromium] Add per-script font&nb