Web Inspector: UI performance: introduce heap size tracking stats.
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Web Inspector: UI performance: introduce heap size tracking stats.
4         https://bugs.webkit.org/show_bug.cgi?id=68901
5
6         It is interesting how much the heap memory is used by Inspector in order of running the test.
7
8         Reviewed by Yury Semikhatsky.
9
10         * DumpRenderTree/chromium/TestShell.cpp:
11         (TestShell::showDevTools):
12         (TestShell::closeDevTools):
13
14 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15
16         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
17
18         QWidget and friends now live in the QtWidgets library. We update
19         includes in implementation files and private headers to us the
20         non-module-prefixed path, and leave the lookup for the include
21         path. For public headers we have to ifdef the includes as the
22         user might now have the modules we need in his QT config.
23
24         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
25         have to update our code and use windowHandle() for setting the
26         parent relationships.
27
28         https://bugs.webkit.org/show_bug.cgi?id=68687
29
30         Reviewed by Andreas Kling.
31
32         * DumpRenderTree/qt/DumpRenderTree.pro:
33         * DumpRenderTree/qt/ImageDiff.pro:
34         * MiniBrowser/qt/BrowserView.cpp:
35         * MiniBrowser/qt/BrowserView.h:
36         * MiniBrowser/qt/BrowserWindow.cpp:
37         * MiniBrowser/qt/BrowserWindow.h:
38         * MiniBrowser/qt/MiniBrowser.pro:
39         * MiniBrowser/qt/MiniBrowserApplication.h:
40         * MiniBrowser/qt/main.cpp:
41         * QtTestBrowser/QtTestBrowser.pro:
42         * QtTestBrowser/launcherwindow.cpp:
43         * QtTestBrowser/launcherwindow.h:
44         * QtTestBrowser/locationedit.h:
45         * QtTestBrowser/main.cpp:
46         * QtTestBrowser/mainwindow.cpp:
47         * QtTestBrowser/mainwindow.h:
48         * QtTestBrowser/webinspector.h:
49         * QtTestBrowser/webpage.cpp:
50         * QtTestBrowser/webview.cpp:
51         * WebKitTestRunner/PlatformWebView.h:
52         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
53
54 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
55
56         [Qt][WK2] Add support for hover API in Qt WebKit2
57         https://bugs.webkit.org/show_bug.cgi?id=68369
58
59         Reviewed by Andreas Kling.
60
61         Change the statusbar to show the link URL when hovering links in
62         MiniBrowser using QDesktopWebView.
63
64         * MiniBrowser/qt/BrowserWindow.cpp:
65         (BrowserWindow::BrowserWindow):
66         (BrowserWindow::onLinkHovered):
67         * MiniBrowser/qt/BrowserWindow.h:
68
69 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
70
71         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
72         https://bugs.webkit.org/show_bug.cgi?id=68864
73
74         Reviewed by Adam Barth.
75
76         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
77         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
78         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
79         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
80
81 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
82
83         [Qt][WK2] One more unreviewed buildfix after r96005.
84
85         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
86
87 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
88
89         [Qt][WK2] Unreviewed buildfix after r96005.
90
91         * WebKitTestRunner/qt/TestInvocationQt.cpp:
92         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
93
94 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
95
96         garden-o-matic should be pretty in Open Sans.
97         https://bugs.webkit.org/show_bug.cgi?id=68845
98
99         Reviewed by Adam Barth.
100
101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
102
103 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
104
105         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
106         https://bugs.webkit.org/show_bug.cgi?id=68841
107
108         Reviewed by Adam Barth.
109
110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
113
114 2011-09-26  David Levin  <levin@chromium.org>
115
116         watchlist: Add parsing for definition section.
117         https://bugs.webkit.org/show_bug.cgi?id=68850
118
119         Reviewed by Adam Barth.
120
121         * Scripts/webkitpy/common/watchlist/watchlist.py:
122         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
123         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
124
125 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
126
127         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
128
129         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
130         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
131         * WebKitTestRunner/win/TestInvocationWin.cpp:
132         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
133
134 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
135
136         Repaint tests don't work in WebKit2
137         https://bugs.webkit.org/show_bug.cgi?id=68453
138
139         Reviewed by Sam Weinig.
140         
141         Convert DumpRenderTree to use use the repaint rects
142         exposed via WebKit API when generating the repaint test
143         overlay.
144         
145         Fix WebKitTestRunner to work with repaint tests, again
146         using the repaint rects exposed from WK2.
147         
148         In both cases, layoutTestController.display() now just
149         forces a display of the web view, and turns on repaint
150         rect tracking on the main FrameView.
151         
152         Later, when pixel results are requested, the alpha overlay
153         that shows the repaint rects is generated using the list
154         of rects supplied by WebCore.
155
156         * DumpRenderTree/mac/DumpRenderTree.mm:
157         (resetDefaultsToConsistentValues):
158         (resetWebViewToConsistentStateBeforeTesting):
159         (displayWebView):
160         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
161         (paintRepaintRectOverlay):
162         (createBitmapContextFromWebView):
163         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
164         (WTR::InjectedBundle::beginTesting):
165         (WTR::InjectedBundle::done):
166         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
167         (WTR::InjectedBundle::setRepaintRects):
168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
169         (WTR::InjectedBundlePage::reset):
170         (WTR::InjectedBundlePage::dump):
171         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
172         (WTR::LayoutTestController::display):
173         * WebKitTestRunner/TestInvocation.cpp:
174         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
175         * WebKitTestRunner/TestInvocation.h:
176         * WebKitTestRunner/cg/TestInvocationCG.cpp:
177         (WTR::paintRepaintRectOverlay):
178         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
179
180 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
181
182         Get hover'ed element URL from HitTest.
183
184         mouseDidMoveOverElement now gets the hover'ed element link using
185         WKHitTestResult API's.
186         https://bugs.webkit.org/show_bug.cgi?id=68426 
187
188         Reviewed by Anders Carlsson.
189
190         * MiniBrowser/gtk/BrowserWindow.c:
191         (mouseDidMoveOverElement):
192
193 2011-09-26  David Levin  <levin@chromium.org>
194
195         Add skeleton parsing for a WatchList.
196         https://bugs.webkit.org/show_bug.cgi?id=68823
197
198         Reviewed by Adam Barth.
199
200         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
201         Parses the top level watch list sections -- none are defined yet -- and
202         throws an exception if an invalid one is listed.
203         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
204         Verify the exception for an invalid section in a watch list.
205         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
206
207 2011-09-26  Adam Roben  <aroben@apple.com>
208
209         Clean up code imported from WebKitAPITest
210
211         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
212         TestWebKitAPI conventions
213
214         Reviewed by David Levin.
215
216         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
217         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
218         namespace name.
219
220         (TestWebKitAPI::WebViewDestruction::SetUp):
221         (TestWebKitAPI::WebViewDestruction::webViewCount):
222         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
223         (TestWebKitAPI::WebViewDestruction::runMessagePump):
224         (TestWebKitAPI::WebViewDestruction::TearDown):
225         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
226         Moved functionality from free functions into these new test fixtures.
227
228         * TestWebKitAPI/win/HostWindow.cpp:
229         * TestWebKitAPI/win/HostWindow.h:
230         Prefixed Win32 API calls with ::. Updated namespace name.
231
232 2011-09-23  Adam Roben  <aroben@apple.com>
233
234         Merge WebKitAPITest into TestWebKitAPI
235
236         This also means that our formerly-WebKitAPITest tests will be run on the bots!
237
238         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
239         them more idiomatic in a separate pass.
240
241         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
242         functionality (and names!)
243
244         Reviewed by Anders Carlsson.
245
246         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
247         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
248         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
249
250         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
251
252         * TestWebKitAPI/win/main.cpp:
253         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
254
255         * WebKitAPITest: Removed this directory and its contents.
256
257 2011-09-23  Adam Roben  <aroben@apple.com>
258
259         Remove two failing WebKitAPITest tests
260
261         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
262
263         Reviewed by Anders Carlsson.
264
265         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
266         MainFrameAfterClose tests.
267
268 2011-09-25  Adam Barth  <abarth@webkit.org>
269
270         Finish removing PLATFORM(BREWMP) by removing associated code
271         https://bugs.webkit.org/show_bug.cgi?id=68779
272
273         Reviewed by Sam Weinig.
274
275         * Scripts/webkitpy/common/config/build.py:
276         * waf/build/settings.py:
277
278 2011-09-21  Ai Makabi  <makabi@google.com>
279
280         Provides a simple LRU cache class in Python.
281
282         https://bugs.webkit.org/show_bug.cgi?id=67823
283
284         Reviewed by Tony Chang.
285
286         * Scripts/webkitpy/common/lru_cache.py:
287         * Scripts/webkitpy/common/lru_cache_unittest.py:
288
289 2011-09-25  Adam Barth  <abarth@webkit.org>
290
291         Remove PLATFORM(HAIKU) and associated code
292         https://bugs.webkit.org/show_bug.cgi?id=68774
293
294         Reviewed by Sam Weinig.
295
296         * Scripts/webkitpy/common/config/build.py:
297         * waf/build/settings.py:
298
299 2011-09-24  Adam Barth  <abarth@webkit.org>
300
301         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
302         https://bugs.webkit.org/show_bug.cgi?id=68767
303
304         Reviewed by Eric Seidel.
305
306         * Scripts/build-webkit:
307
308 2011-09-24  Adam Barth  <abarth@webkit.org>
309
310         Remove ENABLE(WCSS) and associated code
311         https://bugs.webkit.org/show_bug.cgi?id=68759
312
313         Reviewed by Darin Adler.
314
315         * Scripts/build-webkit:
316         * Scripts/old-run-webkit-tests:
317         * Scripts/webkitperl/features.pm:
318         (hasFeature):
319         * Scripts/webkitpy/layout_tests/port/webkit.py:
320         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
321
322 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
323
324         Fixed GTK compilation after r95878, the operator== was defined
325         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
326
327         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
328
329 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
330
331         [DRT] Include the right config file for EFL's DRT.
332         https://bugs.webkit.org/show_bug.cgi?id=67042
333
334         Reviewed by Martin Robinson.
335
336         Ports which use CMake as their buildsystem (such as the EFL one) also
337         have config.h files, but they are named differently, so include the
338         right one depending on the buildsystem being used.
339
340         * DumpRenderTree/config.h:
341
342 2011-09-23  Adam Klein  <adamk@chromium.org>
343
344         Add ENABLE_MUTATION_OBSERVERS feature flag
345         https://bugs.webkit.org/show_bug.cgi?id=68732
346
347         Reviewed by Ojan Vafai.
348
349         This flag will guard an implementation of the "Mutation Observers" proposed in
350         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
351
352         * Scripts/build-webkit:
353
354 2011-09-23  Chang Shu  <cshu@webkit.org>
355
356         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
357         https://bugs.webkit.org/show_bug.cgi?id=68556
358
359         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
360
361         Reviewed by Darin Adler.
362
363         * WebKitTestRunner/EventSenderProxy.h:
364         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
365         * WebKitTestRunner/PlatformWebView.h:
366         * WebKitTestRunner/mac/EventSenderProxy.mm:
367         (WTR::EventSenderProxy::EventSenderProxy):
368         (WTR::EventSenderProxy::leapForward):
369         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
370         (WTR::EventSenderProxy::EventSenderProxy):
371         (WTR::getMouseButton):
372         (WTR::getModifiers):
373         (WTR::EventSenderProxy::updateClickCountForButton):
374         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
375         (WTR::EventSenderProxy::mouseDown):
376         (WTR::EventSenderProxy::mouseUp):
377         (WTR::EventSenderProxy::mouseMoveTo):
378         (WTR::EventSenderProxy::leapForward):
379         (WTR::EventSenderProxy::sendOrQueueEvent):
380         (WTR::EventSenderProxy::replaySavedEvents):
381         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
382         (WTR::PlatformWebView::postEvent):
383         * WebKitTestRunner/qt/WebKitTestRunner.pro:
384
385 2011-09-23  Lei Zhang  <thestig@chromium.org>
386
387         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
388         https://bugs.webkit.org/show_bug.cgi?id=68026
389
390         Reviewed by Dirk Pranke.
391
392         * Scripts/webkitpy/layout_tests/port/chromium.py:
393
394 2011-09-23  Elliot Poger  <epoger@google.com>
395
396         update layout_tests to account for new default of use_skia=1
397         https://bugs.webkit.org/show_bug.cgi?id=68698
398
399         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
400         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
401         (Chromium-on-Mac now uses the Skia graphics library instead of
402         Core Graphics).
403
404         Also updates layout_test code to work with that change.
405
406         Reviewed by Mihai Parparita.
407
408         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
409         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
410
411 2011-09-23  Mark Rowe  <mrowe@apple.com>
412
413         Fix the build.
414         
415         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
416         the WTF namespace.
417
418 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
419
420         enable NRWT for run-webkit-tests on Lion
421         https://bugs.webkit.org/show_bug.cgi?id=68673
422
423         Reviewed by Eric Seidel.
424
425         * Scripts/run-webkit-tests:
426         (useNewRunWebKitTests):
427
428 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
429
430         Add unit test for existing StringBuilder
431         https://bugs.webkit.org/show_bug.cgi?id=67080
432
433         Reviewed by Darin Adler.
434
435         * TestWebKitAPI/TestWebKitAPI.gypi:
436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
437         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
438         (operator<<):
439         (TestWebKitAPI::expectBuilderContent):
440         (TestWebKitAPI::expectEmpty):
441         (TestWebKitAPI::TEST):
442
443 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
444
445         [EFL] Use ewk_view to navigate in history instead of ewk_history.
446         https://bugs.webkit.org/show_bug.cgi?id=68455
447
448         Reviewed by Antonio Gomes.
449
450         BackForwardItem::invoke() was using ewk_history functions to navigate
451         in history; however, this will only call WebCore::BackForwardListImpl
452         and not move between pages at all. We now call ewk_view_navigate and
453         its siblings to make sure the navigation actually happens.
454
455         This should make tests like fast/dom/navigation-type-back-forward.html
456         stop timing out.
457
458         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
459         (BackForwardItem::invoke):
460
461 2011-09-22  Dean Jackson  <dino@apple.com>
462
463         Add ENABLE_CSS_FILTERS
464         https://bugs.webkit.org/show_bug.cgi?id=68652
465
466         Reviewed by Simon Fraser.
467
468         * Scripts/build-webkit:
469
470 2011-09-22  Anders Carlsson  <andersca@apple.com>
471
472         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
473         https://bugs.webkit.org/show_bug.cgi?id=68660
474
475         Reviewed by Adam Barth.
476
477         * WebKitTestRunner/mac/EventSenderProxy.mm:
478         (WTR::EventSenderProxy::mouseUp):
479
480 2011-09-22  Adam Roben  <aroben@apple.com>
481
482         Remove FindSafari
483
484         It isn't used or built anymore.
485
486         Fixes <http://webkit.org/b/68628>
487
488         Reviewed by Darin Adler.
489
490         * FindSafari: Removed this directory and its contents.
491
492 2011-09-22  Adam Roben  <aroben@apple.com>
493
494         Remove FindSafari from all our .sln files
495
496         It isn't used anymore, so there's no point in building it.
497
498         Part of <http://webkit.org/b/68628> Remove FindSafari
499
500         Reviewed by Steve Falkenburg.
501
502         * DumpRenderTree/DumpRenderTree.sln:
503         * WebKitTestRunner/WebKitTestRunner.sln:
504
505 2011-09-22  Adam Roben  <aroben@apple.com>
506
507         Remove all uses of FindSafari
508
509         It isn't really needed anymore.
510
511         Fixes <http://webkit.org/b/68626>.
512
513         Reviewed by Darin Adler.
514
515         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
516
517         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
518         WebKit, but now we use WebKit.exe for that.
519
520         * Scripts/webkitdirs.pm:
521         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
522         do the same thing.
523
524         (readRegistryString):
525         (writeRegistryString):
526         Moved here from old-run-webkit-tests.
527
528 2011-09-22  Adam Roben  <aroben@apple.com>
529
530         Use the "direct object" form of system() to run WebKit.exe
531
532         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
533         path to WebKit.exe.
534
535         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
536         %WEBKITOUTPUTDIR%
537
538         Reviewed by Steve Falkenburg.
539
540         * Scripts/webkitdirs.pm:
541         (runSafari):
542
543 2011-09-22  Adam Roben  <aroben@apple.com>
544
545         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
546
547         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
548         spaces in the path to the WebKit source tree
549
550         Reviewed by John Sullivan.
551
552         * Scripts/webkitdirs.pm:
553         (setupCygwinEnv):
554
555 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
556
557         [Qt] Use same DPI for application font as rest of app in DRT and WTR
558
559         QApplication will initialize the default application font based
560         on the application DPI at construction time, but we then override
561         the application DPI using QX11Info (hard-coding it to 96 for
562         consistency). This hard-coding is not reflected in the application
563         font, so we explicitly have update the font ourselves.
564
565         The 6 test results that are updated were originally produced with
566         a DPI of 75, as this is the default fallback DPI when a QFont is
567         constructed before QApplication. This was wrong, and the results
568         are updated to match a DPI of 96.
569
570         Reviewed by Csaba Osztrogonác.
571
572         * DumpRenderTree/qt/main.cpp:
573         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
574
575 2011-09-21  Anna Cavender  <annacc@chromium.org>
576
577         Update committers.py with a new contributor contact        
578         https://bugs.webkit.org/show_bug.cgi?id=68565
579
580         Reviewed by Eric Carlson.
581
582         * Scripts/webkitpy/common/config/committers.py:
583
584 2011-09-21  Chang Shu  <cshu@webkit.org>
585
586         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
587         https://bugs.webkit.org/show_bug.cgi?id=68108
588
589         This patch implements the event sender mouse events through WebKit2 UIProcess which is
590         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
591         platform as the first step so the existing code is still kept for other platforms.
592
593         Reviewed by Darin Adler.
594
595         * WebKitTestRunner/EventSenderProxy.h:
596         (WTR::EventSenderProxy::EventSenderProxy):
597         (WTR::EventSenderProxy::leapForward):
598         (WTR::EventSenderProxy::currentEventTime):
599         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
600         (WTR::EventSendingController::EventSendingController):
601         (WTR::EventSendingController::mouseDown):
602         (WTR::EventSendingController::mouseUp):
603         (WTR::EventSendingController::mouseMoveTo):
604         (WTR::EventSendingController::leapForward):
605         (WTR::EventSendingController::keyDown):
606         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
607         * WebKitTestRunner/TestController.cpp:
608         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
609         * WebKitTestRunner/mac/EventSenderProxy.mm:
610         (WTR::eventTypeForMouseButtonAndAction):
611         (WTR::operator==):
612         (WTR::EventSenderProxy::updateClickCountForButton):
613         (WTR::EventSenderProxy::mouseDown):
614         (WTR::EventSenderProxy::mouseUp):
615         (WTR::EventSenderProxy::mouseMoveTo):
616         (WTR::EventSenderProxy::keyDown):
617         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
618         (WTR::EventSenderProxy::keyDown):
619         (WTR::EventSenderProxy::mouseDown):
620         (WTR::EventSenderProxy::mouseUp):
621         (WTR::EventSenderProxy::mouseMoveTo):
622
623 2011-09-21  Dan Bernstein  <mitz@apple.com>
624
625         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
626         https://bugs.webkit.org/show_bug.cgi?id=68451
627
628         Reviewed by Darin Adler.
629
630         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
631         Objective-C classes with names not having one of a list of prefixes
632         passed on the command line.
633
634 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
635
636         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
637         https://bugs.webkit.org/show_bug.cgi?id=68206
638
639         Reviewed by Tony Chang.
640
641         * Scripts/webkitdirs.pm:
642         (determineBaseProductDir): add support for chromium-mac
643         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
644         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
645
646 2011-09-21  Adam Barth  <abarth@webkit.org>
647
648         garden-o-matic command should explain that it is starting a local server
649         https://bugs.webkit.org/show_bug.cgi?id=68486
650
651         Reviewed by Dimitri Glazkov.
652
653         In the user study, both participants didn't understand why the
654         garden-o-matic command appeared to hang.  This patch adds an
655         explaination of what's going on.  It also adds a confirmation prompt
656         before launching the browser to give the user a chance to read the
657         text.  If that's too much of a speed bump, we can iterate.
658
659         * Scripts/webkitpy/tool/commands/gardenomatic.py:
660
661 2011-09-21  Chang Shu  <cshu@webkit.org>
662
663         [Qt] Implement KeyDown function for WebKit2 EventSender.
664         https://bugs.webkit.org/show_bug.cgi?id=56485
665
666         Implement the KeyDown function on Qt platform.
667
668         Reviewed by Andreas Kling.
669
670         * WebKitTestRunner/PlatformWebView.h:
671         * WebKitTestRunner/TestController.cpp:
672         (WTR::TestController::TestController):
673         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
674         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
675         (WTR::getModifiers):
676         (WTR::EventSenderProxy::keyDown):
677         (buildModifierFlags):
678         (EventSenderProxy::keyDown):
679         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
680         (WTR::PlatformWebView::sendEvent):
681         * WebKitTestRunner/qt/WebKitTestRunner.pro:
682
683 2011-09-20  Adam Barth  <abarth@webkit.org>
684
685         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
686         https://bugs.webkit.org/show_bug.cgi?id=68496
687
688         Reviewed by Dimitri Glazkov.
689
690         This patch adds a bunch of sorting to make sure things happen in a
691         predictable order in both JavaScriptCore and V8.  We've talked before
692         about whether these two JavaScript engines should enumerate
693         dictionaries in the same order, but the consensus has been that they
694         shouldn't.  Personally, I disagree with that consensus, but such is life.
695
696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
700
701 2011-09-20  Adam Barth  <abarth@webkit.org>
702
703         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
704         https://bugs.webkit.org/show_bug.cgi?id=68495
705
706         Reviewed by Dimitri Glazkov.
707
708         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
709
710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
711
712 2011-09-20  Eric Seidel  <eric@webkit.org>
713
714         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
715         https://bugs.webkit.org/show_bug.cgi?id=65781
716
717         Reviewed by Ryosuke Niwa.
718
719         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
720         to resolve the passed in url relative to the absolute url for the test.
721         For http tests, since the test url is an http url, we can't resolve relative
722         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
723         for resolving.
724
725         I believe this is a better approach than the on used in the Qt and Chromium DRT's
726         (which resolves the path relative to the built location of the DRT executable)
727         and we should move this new code into a shared location in a follow-up patch.
728
729         It turns out that there was a second use for pathToLocalResource, used by one
730         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
731         To support this test I made the new pathToLocalResource smart enough to map
732         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
733
734         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
735         (LayoutTestController::pathToLocalResource):
736         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
737
738 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
739
740         Need to specify a django version, instead of using default
741         https://bugs.webkit.org/show_bug.cgi?id=68398
742
743         Reviewed by Eric Seidel.
744
745         * QueueStatusServer/__init__.py:
746         * QueueStatusServer/main.py:
747
748 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
749
750         Update committers.py with a few more contributor contacts
751         https://bugs.webkit.org/show_bug.cgi?id=68487
752
753         Reviewed by Eric Seidel.
754
755         * Scripts/webkitpy/common/config/committers.py:
756
757 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
758
759         Fix webkitpy unit tests after 95547 and 95549
760         https://bugs.webkit.org/show_bug.cgi?id=68483
761
762         Reviewed by Adam Barth.
763         
764         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
765
766         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
767         parse_entries_from_file(), use StringIO and entry.reviewer_text().
768         While testing parse_latest_entry_from_file(), expect the correct
769         touched_files() list.
770
771 2011-09-20  Adam Barth  <abarth@webkit.org>
772
773         garden-o-matic makes it hard to compare images when scroll bars appear
774         https://bugs.webkit.org/show_bug.cgi?id=68482
775
776         Reviewed by Eric Seidel.
777
778         Because we autoscale image width, the images rescale if we overflow
779         vertically and get a scrollbar.  That makes it hard to compare two sets
780         of images.  This patch reserves space for the scrollbar so we won't
781         have the layout change.
782
783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
784
785 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
786
787         Unreviewed, rolling out r95565.
788         http://trac.webkit.org/changeset/95565
789         https://bugs.webkit.org/show_bug.cgi?id=68470
790
791         Broke builds (Requested by andersca on #webkit).
792
793         * MiniBrowser/gtk/BrowserWindow.c:
794         (mouseDidMoveOverElement):
795
796 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
797
798         Get hover'ed element URL from HitTest.
799         
800         mouseDidMoveOverElement now gets the hover'ed element link using
801         WKHitTestResult API's.
802         https://bugs.webkit.org/show_bug.cgi?id=68426
803
804         Reviewed by Anders Carlsson.
805
806         * MiniBrowser/gtk/BrowserWindow.c:
807         (mouseDidMoveOverElement):
808
809 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
810
811         Changelog class should have a method to return all entries
812         https://bugs.webkit.org/show_bug.cgi?id=68399
813         
814         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
815         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
816
817         Reviewed by Ryosuke Niwa.
818
819         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
820         and adapt it to become a generator.
821         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
822
823 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
824
825         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
826         https://bugs.webkit.org/show_bug.cgi?id=51159
827
828         Permit any URL with a local scheme to set a user style sheet. Allow qrc
829         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
830         
831         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
832
833         Reviewed by Kenneth Rohde Christiansen.
834
835         * DumpRenderTree/qt/DumpRenderTree.pro:
836         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
837         * DumpRenderTree/qt/resources/user.css: Added.
838         (body):
839         * WebKitTestRunner/qt/WebKitTestRunner.pro:
840         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
841         * WebKitTestRunner/qt/resources/user.css: Added.
842         (body):
843
844 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
845
846         ChangeLogEntry class should contain a list of touched files
847         https://bugs.webkit.org/show_bug.cgi?id=68115
848
849         Reviewed by Eric Seidel.
850         
851         Add method to return the list of files touched in a ChangeLog entry.
852
853         * Scripts/webkitpy/common/checkout/changelog.py: Add
854         touched_files_regexp and touched_files() method.
855         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
856         unit tests for touched_files() method.
857
858 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
859
860         Unreviewed, rolling out r95526 and r95541.
861         http://trac.webkit.org/changeset/95526
862         http://trac.webkit.org/changeset/95541
863         https://bugs.webkit.org/show_bug.cgi?id=68443
864
865         It broke 6 tests (Requested by ossy_ on #webkit).
866
867         * DumpRenderTree/qt/main.cpp:
868         (main):
869         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
870         (WTR::activateFonts):
871
872 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
873
874         Fix patch and bug numbering in the mocktool simulation code
875         https://bugs.webkit.org/show_bug.cgi?id=68374
876
877         Reviewed by Adam Barth.
878
879         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
880         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
881         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
882         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
883         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
884         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
885         * Scripts/webkitpy/tool/commands/download_unittest.py:
886         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
887         * Scripts/webkitpy/tool/commands/queries_unittest.py:
888         * Scripts/webkitpy/tool/commands/queues_unittest.py:
889         * Scripts/webkitpy/tool/commands/queuestest.py:
890         * Scripts/webkitpy/tool/commands/upload_unittest.py:
891         * Scripts/webkitpy/tool/mocktool.py:
892         * Scripts/webkitpy/tool/steps/steps_unittest.py:
893         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
894
895 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
896
897         [Qt] Don't override default QApplication font for DRT and WTR
898
899         Revision 95526 moved the relevant code below the QApplication
900         constructor, to fix a potential crash, and that made the code
901         take effect, breaking 6 tests.
902
903         We should rely on the QWebSettings to set default fonts, and
904         this QApplication::setFont() is a relic from when we didn't
905         have that option, so we remove the code.
906
907         Reviewed by Csaba Osztrogonác.
908
909         * DumpRenderTree/qt/main.cpp:
910         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
911
912 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
913
914         WebKitTestRunner: Provide usage if run without arguments
915
916         If WTR is run without either one or more filenames, or
917         a '-' to indicate server mode, we don't need to start
918         up the test machinery. Doing so might actually crash,
919         as we'll exit the application immedeatly after anyways.
920
921         Reviewed by Simon Hausmann.
922
923         * WebKitTestRunner/TestController.cpp:
924         (WTR::TestController::initialize):
925
926 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
927
928         [Qt] Don't use QFont before initializing QApplication
929
930         Could potentially result in crash.
931
932         Reviewed by Simon Hausmann.
933
934         * DumpRenderTree/qt/main.cpp:
935         (main):
936
937 2011-09-19  Adam Barth  <abarth@webkit.org>
938
939         Always enable ENABLE(EVENTSOURCE)
940         https://bugs.webkit.org/show_bug.cgi?id=68414
941
942         Reviewed by Eric Seidel.
943
944         * Scripts/build-webkit:
945
946 2011-09-19  David Levin  <levin@chromium.org>
947
948         Sheriffbot rollout should be more intuitive.
949         https://bugs.webkit.org/show_bug.cgi?id=68415
950
951         Reviewed by Adam Barth.
952
953         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
954         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
955           and a few others cases.
956         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
957
958 2011-09-19  David Levin  <levin@chromium.org>
959
960         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
961         https://bugs.webkit.org/show_bug.cgi?id=68391
962
963         Reviewed by Darin Adler.
964
965         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
966         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
967
968 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
969
970         Style checker should not check public Qt WK2 API for parameter_name.
971         https://bugs.webkit.org/show_bug.cgi?id=68359
972
973         Reviewed by Andreas Kling.
974
975         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
976         Add an exception in the style checker to disable the check. Also added the test for it.
977
978         * Scripts/webkitpy/style/checker.py:
979         * Scripts/webkitpy/style/checker_unittest.py:
980
981 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
982
983         GTK DRT leaks memory while comparing history items
984         https://bugs.webkit.org/show_bug.cgi?id=68086
985
986         Reviewed by Martin Robinson.
987         
988         webkit_web_history_item_get_target() returns a g_strdup()'d string,
989         so memory must be freed before compareHistoryItems() returns.
990
991         * DumpRenderTree/gtk/DumpRenderTree.cpp:
992         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
993
994 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
995
996         Buildbot marks a nrwt bot red when tests are missing results
997         https://bugs.webkit.org/show_bug.cgi?id=64812
998
999         Reviewed by Ryosuke Niwa.
1000
1001         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1002         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1003
1004 2011-09-19  Jessie Berlin  <jberlin@apple.com>
1005
1006         Sites that use history pushState or replaceState are recorded in history in Private Browsing
1007         mode.
1008         https://bugs.webkit.org/show_bug.cgi?id=68208
1009
1010         Reviewed by Brady Eidson.
1011
1012         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1013         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1014
1015         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1016         (TestWebKitAPI::didNavigateWithNavigationData):
1017         This is a context history client callback, so it should not be called when in Private
1018         Browsing. Add a call to FAIL().
1019         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1020         This is a page load client callback that happens after the didNavigateWithNavigationData
1021         callback. End the test.
1022         (TestWebKitAPI::TEST):
1023         Enable Private Browsing and load a page that uses history.pushState.
1024
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1027         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1028         Ditto.
1029         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1030         Ditto.
1031         * TestWebKitAPI/win/copy-resources.cmd:
1032         Ditto.
1033
1034 2011-09-16  Elliot Poger  <epoger@google.com>
1035
1036         add non-CG Webkit-Mac builds to flakiness dashboard
1037         https://bugs.webkit.org/show_bug.cgi?id=68265
1038
1039         Reviewed by Adam Barth.
1040
1041         As Chromium-on-Mac approaches the switchover from Core Graphics to
1042         Skia, we need to add the Skia version to the flakiness dashboard.
1043
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1045         * TestResultServer/static-dashboards/builders.js:
1046         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1047
1048 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1049
1050         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1051         https://bugs.webkit.org/show_bug.cgi?id=68071
1052
1053         Reviewed by Adam Barth.
1054
1055         * DumpRenderTree/chromium/WebPermissions.cpp:
1056         (WebPermissions::allowImage):
1057         * DumpRenderTree/chromium/WebPermissions.h:
1058
1059 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1060
1061         update-webkit-chromium should retry the gclient call if it fails once
1062         https://bugs.webkit.org/show_bug.cgi?id=68252
1063
1064         Reviewed by Adam Barth.
1065
1066         * Scripts/update-webkit-chromium:
1067
1068 2011-09-16  Rob Buis  <rbuis@rim.com>
1069
1070         Add Eli's rim address and change the nick.
1071
1072         * Scripts/webkitpy/common/config/committers.py:
1073
1074 2011-09-16  Anders Carlsson  <andersca@apple.com>
1075
1076         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1077         https://bugs.webkit.org/show_bug.cgi?id=68269
1078
1079         Reviewed by Geoffrey Garen.
1080
1081         Update client function signatures.
1082
1083         * MiniBrowser/gtk/BrowserWindow.c:
1084         (browserWindowUIClientInit):
1085         * MiniBrowser/mac/BrowserWindowController.m:
1086         (mouseDidMoveOverElement):
1087         (-[BrowserWindowController awakeFromNib]):
1088         * MiniBrowser/win/BrowserView.cpp:
1089         (BrowserView::create):
1090         * WebKitTestRunner/TestController.cpp:
1091         (WTR::TestController::createOtherPage):
1092         (WTR::TestController::initialize):
1093
1094 2011-09-16  Anders Carlsson  <andersca@apple.com>
1095
1096         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1097         https://bugs.webkit.org/show_bug.cgi?id=68266
1098
1099         Reviewed by John Sullivan.
1100
1101         * MiniBrowser/mac/BrowserWindowController.m:
1102         (mouseDidMoveOverElement):
1103
1104 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1105
1106         Add Vincent Scheib to the committers list.
1107
1108         * Scripts/webkitpy/common/config/committers.py:
1109
1110 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1111
1112         Unreviewed, rolling out r95285.
1113         http://trac.webkit.org/changeset/95285
1114         https://bugs.webkit.org/show_bug.cgi?id=68247
1115
1116         It broke a webkitpy test (Requested by ossy on #webkit).
1117
1118         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1119
1120 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1121
1122         Buildbot marks a nrwt bot red when tests are missing results
1123         https://bugs.webkit.org/show_bug.cgi?id=64812
1124
1125         Reviewed by Dirk Pranke.
1126
1127         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1128
1129 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1130
1131         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1132         https://bugs.webkit.org/show_bug.cgi?id=68178
1133
1134         Reviewed by Xan Lopez.
1135
1136         Add a work-around to enable WebKit2 when using build-webkit.
1137
1138         * Scripts/webkitdirs.pm:
1139         (buildAutotoolsProject): 
1140
1141 2011-09-15  James Robinson  <jamesr@chromium.org>
1142
1143         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1144
1145         * Scripts/webkitpy/common/config/committers.py:
1146
1147 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1148
1149         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1150         https://bugs.webkit.org/show_bug.cgi?id=68003
1151
1152         Reviewed by Adam Barth.
1153
1154         * Scripts/webkitpy/tool/mocktool.py:
1155         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1156         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1157
1158 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1159
1160         Python version check is confusing in test-webkitpy
1161         https://bugs.webkit.org/show_bug.cgi?id=68004
1162
1163         Reviewed by Adam Barth.
1164
1165         * Scripts/test-webkitpy:
1166
1167 2011-09-15  Eric Seidel  <eric@webkit.org>
1168
1169         Reviewed by Adam Barth.
1170
1171         webkit-patch should be able to find users and add them to bugzilla groups
1172         https://bugs.webkit.org/show_bug.cgi?id=63351
1173
1174         These are both very basic commands.  But it's now possible to find
1175         all users matching a regexp, as well as add all users matching a regexp
1176         to a set of groups.
1177
1178         bugzilla.py already knew how to find users (for validate-committer-lists)
1179         but now it has the ability to modify the user records.
1180
1181         I split some of the logic out into a new EditUsersParser class
1182         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
1183
1184         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1185         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1186         * Scripts/webkitpy/tool/commands/__init__.py:
1187         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
1188         * Scripts/webkitpy/tool/commands/findusers.py: Added.
1189
1190 2011-09-15  Eric Seidel  <eric@webkit.org>
1191
1192         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
1193         https://bugs.webkit.org/show_bug.cgi?id=68182
1194
1195         Reviewed by Adam Barth.
1196
1197         * Scripts/build-webkit:
1198         * waf/build/settings.py:
1199
1200 2011-09-15  Eric Seidel  <eric@webkit.org>
1201
1202         Unreviewed.  Make contributor email look-up case-insensitive.
1203
1204         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
1205         was missing from committers.py due to case sensitivity.
1206
1207         This also includes a test expectations update to committers_unittest.py
1208         after my previous change.
1209
1210         * Scripts/webkitpy/common/config/committers.py:
1211         * Scripts/webkitpy/common/config/committers_unittest.py:
1212         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1213
1214 2011-09-15  Eric Seidel  <eric@webkit.org>
1215
1216         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
1217
1218         Add a bunch of email aliases to committers.py for regular contributors
1219         who are committing using other email addresses than they have listed in the file.
1220
1221         * Scripts/webkitpy/common/config/committers.py:
1222
1223 2011-09-15  Eric Seidel  <eric@webkit.org>
1224
1225         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
1226         https://bugs.webkit.org/show_bug.cgi?id=68022
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         * Scripts/build-webkit:
1231         * waf/build/settings.py:
1232
1233 2011-09-15  Anders Carlsson  <andersca@apple.com>
1234
1235         Fix Mac build by including config.h where needed.
1236
1237         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1238         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1239         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1240         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1241         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1242         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1243         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1244         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1245         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1246         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1247         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1248         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1249         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1250         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
1251         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1252         * TestWebKitAPI/mac/main.mm:
1253
1254 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1255
1256         Let TestWebKitAPI work for chromium
1257         https://bugs.webkit.org/show_bug.cgi?id=67756
1258
1259         Reviewed by Sam Weinig.
1260
1261         * Scripts/build-api-tests:
1262         * Scripts/run-api-tests:
1263         (isSupportedPlatform):
1264         (runTest):
1265         (populateTests):
1266         * Scripts/webkitdirs.pm:
1267         (determineBaseProductDir):
1268         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1269         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1270         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1271         * TestWebKitAPI/InjectedBundleController.cpp:
1272         * TestWebKitAPI/InjectedBundleMain.cpp:
1273         * TestWebKitAPI/JavaScriptTest.cpp:
1274         * TestWebKitAPI/PlatformUtilities.cpp:
1275         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
1276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1277         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
1278         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1279         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1280         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1281         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1282         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1283         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1284         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1285         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1286         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1287         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1288         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1289         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1290         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1291         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1292         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1293         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1294         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1295         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1296         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1297         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1298         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1299         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1300         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1301         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1302         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
1303         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1304         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1305         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1306         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1307         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
1308         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1309         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1310         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1311         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1312         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1313         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1314         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1315         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1316         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1317         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1318         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1319         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1320         * TestWebKitAPI/TestsController.cpp:
1321         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
1322         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
1323         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1324         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1325         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1326         * TestWebKitAPI/win/main.cpp:
1327
1328 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
1329
1330         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
1331         https://bugs.webkit.org/show_bug.cgi?id=68145
1332
1333         This will allow for other classes in DumpRenderTree to reuse this functionality
1334
1335         Reviewed by David Levin.
1336
1337         * DumpRenderTree/chromium/TestShell.cpp:
1338         (normalizeLayoutTestURLInternal):
1339         (dumpHistoryItem):
1340         (TestShell::normalizeLayoutTestURL):
1341         * DumpRenderTree/chromium/TestShell.h:
1342
1343 2011-09-14  Ada Chan  <adachan@apple.com>
1344
1345         Add test for WKBundleFrameCopyWebArchive().
1346         https://bugs.webkit.org/show_bug.cgi?id=67857
1347
1348         Reviewed by Anders Carlsson.
1349
1350         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
1351         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
1352         the returned data is a valid webarchive.
1353         (TestWebKitAPI::setInjectedBundleClient):
1354         (TestWebKitAPI::didFinishLoadForFrame):
1355         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
1356         injected bundle for the webarchive and check the returned webarchive.
1357         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
1358         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
1359         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
1360         the web archive.
1361
1362         Add files to project.
1363         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
1364         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366
1367 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
1368
1369         committers.py should support multiple IRC nicknames
1370         https://bugs.webkit.org/show_bug.cgi?id=68110
1371
1372         Reviewed by Eric Seidel.
1373
1374         Add multiple IRC nickname support to committers.py
1375
1376         * Scripts/webkitpy/common/config/committers.py:
1377         * Scripts/webkitpy/common/config/committers_unittest.py:
1378         * Scripts/webkitpy/tool/bot/irc_command.py:
1379         * Scripts/webkitpy/tool/bot/sheriff.py:
1380
1381 2011-09-14  Jon Lee  <jonlee@apple.com>
1382
1383         Implement globalFlag for WebKitTestRunner
1384         https://bugs.webkit.org/show_bug.cgi?id=68033
1385         <rdar://problem/10119204>
1386
1387         Reviewed by Sam Weinig.
1388
1389         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
1390         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1391         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
1392         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
1393         (WTR::LayoutTestController::globalFlag): simple getter
1394         (WTR::LayoutTestController::setGlobalFlag): simple setter
1395
1396 2011-09-13  Eric Seidel  <eric@webkit.org>
1397
1398         Remove ENABLE_SVG_USE as <use> is required by HTML5
1399         https://bugs.webkit.org/show_bug.cgi?id=68019
1400
1401         Reviewed by Ryosuke Niwa.
1402
1403         * Scripts/build-webkit:
1404         * waf/build/settings.py:
1405
1406 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
1407
1408         Remove Jan Erik Hanssen (added in my r95078) from the list for now
1409         since I can't confirm acceptable his committership.
1410
1411         * Scripts/webkitpy/common/config/committers.py:
1412
1413 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
1414
1415         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
1416         https://bugs.webkit.org/show_bug.cgi?id=68066
1417
1418         Reviewed by Adam Barth.
1419
1420         * DumpRenderTree/chromium/WebViewHost.cpp:
1421         * DumpRenderTree/chromium/WebViewHost.h:
1422
1423 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         committers.py is missing some contributors
1426         https://bugs.webkit.org/show_bug.cgi?id=68059
1427
1428         Reviewed by Adam Barth.
1429
1430         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
1431
1432         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
1433
1434         * Scripts/webkitpy/common/config/committers.py:
1435
1436 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         Fix webkit python test after r95061.
1439
1440         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1441
1442 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
1443
1444         Add myself as a contributor. No review needed.
1445
1446         * Scripts/webkitpy/common/config/committers.py:
1447
1448 2011-09-13  Adam Barth  <abarth@webkit.org>
1449
1450         garden-o-matic has unfriendly error messages when the local server is not available
1451         https://bugs.webkit.org/show_bug.cgi?id=68042
1452
1453         Reviewed by Dimitri Glazkov.
1454
1455         This patch moves us from using alert to showing the error inline in the
1456         progress dialog.
1457
1458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1463
1464 2011-09-13  Adam Barth  <abarth@webkit.org>
1465
1466         FailureGrid in garden-o-matic should link to the builder's waterfall page
1467         https://bugs.webkit.org/show_bug.cgi?id=68036
1468
1469         Reviewed by Dimitri Glazkov.
1470
1471         One of the users in the user study thought the configurations names in
1472         the failure grid would link to the underlying bots.  That makes sense,
1473         so this patch adds the behavior.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1479
1480 2011-09-13  Adam Barth  <abarth@webkit.org>
1481
1482         garden-o-matic should be able to mark failures as expected
1483         https://bugs.webkit.org/show_bug.cgi?id=68027
1484
1485         Reviewed by Dimitri Glazkov.
1486
1487         All the back-end infrastructure exists for this operation.  This patch
1488         just adds some UI to the front-end and wires that UI up to the back
1489         end.  This exact UI will likely need some more polish, but this should
1490         be a reasonable first cut.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1497
1498 2011-09-13  Adam Barth  <abarth@webkit.org>
1499
1500         garden-o-matic should tell you about the progress of your rebaseline
1501         https://bugs.webkit.org/show_bug.cgi?id=67967
1502
1503         Reviewed by Dimitri Glazkov.
1504
1505         This patch adds ui.MessageBox, which is a light wrapper around jQuery
1506         UI's dialog widget.  We then use ui.MessageBox to show status messages
1507         about in-progress rebaselines.  As each baseline is downloaded, the
1508         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
1509
1510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1516
1517 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
1518
1519         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
1520         https://bugs.webkit.org/show_bug.cgi?id=68024
1521
1522         Reviewed by Gustavo Noronha Silva.
1523         
1524         Using g_list_count() and g_list_nth_data() together on a loop is
1525         inneficient since they're both O(n). Iterate over lists in a saner
1526         way.
1527
1528         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1529         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
1530         iterate on it using g_list_next(). Free the list after done with it.
1531         (dumpBackForwardListForWebView): Instead of appending (which is
1532         expensive in GLists) history items and then iterating from the tail
1533         of the itemsToPrint list, prepend items and walk forwards as usual.
1534         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
1535         remove the (unneeded) viewList variable.
1536
1537 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1538
1539         Add Eric's IRC nick.
1540
1541         * Scripts/webkitpy/common/config/committers.py:
1542
1543 2011-09-13  Anders Carlsson  <andersca@apple.com>
1544
1545         Disable C++ exceptions when building with clang
1546         https://bugs.webkit.org/show_bug.cgi?id=68031
1547         <rdar://problem/9556880>
1548
1549         Reviewed by Mark Rowe.
1550
1551         * MiniBrowser/Configurations/Base.xcconfig:
1552         * TestWebKitAPI/Configurations/Base.xcconfig:
1553         * WebKitTestRunner/Configurations/Base.xcconfig:
1554
1555 2011-09-13  Ojan Vafai  <ojan@chromium.org>
1556
1557         [chromium] fix flakiness dashboard for chromium interactive tests
1558         https://bugs.webkit.org/show_bug.cgi?id=68029
1559
1560         Reviewed by Tony Chang.
1561
1562         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1563         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1564
1565 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1566
1567         Add Alice and Aryeh to the list of contributors.
1568
1569         * Scripts/webkitpy/common/config/committers.py:
1570
1571 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1572
1573         sheriffbot whois should also tell us email addresses
1574         https://bugs.webkit.org/show_bug.cgi?id=67975
1575
1576         Reviewed by Eric Seidel and David Levin.
1577
1578         Taught sheriffbot how to tell us contributor's email addresses.
1579
1580         * Scripts/webkitpy/tool/bot/irc_command.py:
1581         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1582
1583 2011-09-13  Eric Seidel  <eric@webkit.org>
1584
1585         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
1586         https://bugs.webkit.org/show_bug.cgi?id=68018
1587
1588         Reviewed by Ryosuke Niwa.
1589
1590         * Scripts/build-webkit:
1591         * waf/build/settings.py:
1592
1593 2011-09-13  Chang Shu  <cshu@webkit.org>
1594
1595         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
1596         https://bugs.webkit.org/show_bug.cgi?id=57515
1597
1598         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
1599         TestController synchronously. The latter then sends simulated event to WebKit2 module,
1600         which is synchronous, too.
1601
1602         Reviewed by Darin Adler.
1603
1604         * WebKitTestRunner/EventSenderProxy.h: Added.
1605         (WTR::EventSenderProxy::EventSenderProxy):
1606         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1607         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1608         (WTR::EventSendingController::keyDown):
1609         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1610         * WebKitTestRunner/PlatformWebView.h:
1611         (WTR::PlatformWebView::platformWindow):
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::TestController):
1614         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1615         * WebKitTestRunner/TestController.h:
1616         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1617         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
1618         (WTR::buildModifierFlags):
1619         (WTR::EventSenderProxy::keyDown):
1620
1621 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
1622
1623         [EFL] DRT: Add DumpRenderTreeEfl.h
1624         https://bugs.webkit.org/show_bug.cgi?id=63993
1625
1626         Reviewed by Eric Seidel.
1627         
1628         This header contains some global variables used by EFL's
1629         DumpRenderTree implementation.
1630
1631         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
1632         appropriate.
1633         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1634
1635 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1636
1637         [EFL] Send the right key names for PageUp and PageDown.
1638         https://bugs.webkit.org/show_bug.cgi?id=67044
1639
1640         Reviewed by Kenneth Rohde Christiansen.
1641
1642         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1643         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1644         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1645         such as editing/input/page-up-down-scrolls.html were timing out due to
1646         the right key down events not being sent.
1647
1648         * DumpRenderTree/efl/EventSender.cpp:
1649         (keyPadNameFromJSValue):
1650         (keyNameFromJSValue):
1651
1652 2011-09-12  Eric Seidel  <eric@webkit.org>
1653
1654         sheriffbot whois is case sensitive
1655         https://bugs.webkit.org/show_bug.cgi?id=67972
1656
1657         Reviewed by Adam Barth.
1658
1659         I also fixed a typo in the "More than 5 contributors" message
1660         from my previous commit.
1661
1662         * Scripts/webkitpy/common/config/committers.py:
1663         * Scripts/webkitpy/common/config/committers_unittest.py:
1664         * Scripts/webkitpy/tool/bot/irc_command.py:
1665         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1666
1667 2011-09-12  Eric Seidel  <eric@webkit.org>
1668
1669         sheriffbot whois should be smarter
1670         https://bugs.webkit.org/show_bug.cgi?id=67971
1671
1672         Reviewed by Adam Barth.
1673
1674         This makes sheriffbot whois basically grep the committers list
1675         making it much easier to find a contributor by name.
1676
1677         Unfortunately the current unittests depend on the real committers.py
1678         file, so as we add more eric's to the project, this unittest result will
1679         change.  I think that's OK for now.  We'll fix it when it breaks.
1680
1681         * Scripts/webkitpy/common/config/committers.py:
1682         * Scripts/webkitpy/tool/bot/irc_command.py:
1683         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1684
1685 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1686
1687         Unreviewed, rolling out r94976.
1688         http://trac.webkit.org/changeset/94976
1689         https://bugs.webkit.org/show_bug.cgi?id=67953
1690
1691         Broke a bunch of security/load& tests (Requested by rniwa on
1692         #webkit).
1693
1694         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1695         (LayoutTestController::pathToLocalResource):
1696
1697 2011-09-12  Eric Seidel  <eric@webkit.org>
1698
1699         Rubber-stamped by Adam Barth.
1700
1701         Remove the "the tree is burning!" warning previously shown
1702         when landing patches.  It was a dream.  But it's just noise now.
1703
1704         Some bots will require a restart to notice the removal of the option
1705         so I've left the --ignore-builders option in for now.
1706
1707         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1708         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1709         * Scripts/webkitpy/tool/commands/download.py:
1710         * Scripts/webkitpy/tool/commands/download_unittest.py:
1711         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1712         * Scripts/webkitpy/tool/steps/__init__.py:
1713         * Scripts/webkitpy/tool/steps/commit.py:
1714         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1715         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1716
1717 2011-09-12  Eric Seidel  <eric@webkit.org>
1718
1719         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1720         https://bugs.webkit.org/show_bug.cgi?id=65781
1721
1722         Reviewed by Ryosuke Niwa.
1723
1724         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1725         to resolve the passed in url relative to the absolute url for the test.
1726
1727         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1728         (which resolves the path relative to the built location of the DRT executable)
1729         and we should move this new code into a shared location in a follow-up patch.
1730
1731         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1732         (LayoutTestController::pathToLocalResource):
1733
1734 2011-09-12  Eric Seidel  <eric@webkit.org>
1735
1736         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1737         https://bugs.webkit.org/show_bug.cgi?id=67530
1738
1739         Reviewed by Adam Barth.
1740
1741         I believe I've fixed the bug in the original patch which prompted the rollout.
1742         The previous patch was using the wrong deadline for the initial read,
1743         subtracting time.time() twice from the deadline value.
1744
1745         * Scripts/webkitpy/layout_tests/port/webkit.py:
1746         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1747
1748 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1749
1750         [Qt][WK2] WebKitTestRunner does not produce crash logs
1751         https://bugs.webkit.org/show_bug.cgi?id=67714
1752
1753         Reviewed by Chang Shu.
1754
1755         Added a simple way of generating backtrace on crash
1756         to the web process. The implementation is similar what
1757         we have in DRT. It depends on GNU libc functionality
1758         so it is only enabled where we are running in such an environment.
1759
1760         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1761         (WTR::printBacktrace):
1762         (WTR::crashHandler):
1763         (WTR::InjectedBundle::platformInitialize):
1764
1765 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1766
1767         Added my IRC nick to the committers file.
1768
1769         * Scripts/webkitpy/common/config/committers.py:
1770
1771 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1772
1773         The executable allocator makes it difficult to free individual
1774         chunks of executable memory
1775         https://bugs.webkit.org/show_bug.cgi?id=66363
1776
1777         Reviewed by Oliver Hunt.
1778         
1779         Introduced a best-fit, balanced-tree based allocator. The allocator
1780         required a balanced tree that does not allocate memory and that
1781         permits the removal of individual nodes directly (as opposed to by
1782         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1783         Changed all references to executable code to use a reference counted
1784         handle.
1785
1786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1787         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1788         (TestWebKitAPI::TEST_F):
1789         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1790         (TestWebKitAPI::Pair::findExact):
1791         (TestWebKitAPI::Pair::remove):
1792         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1793         (TestWebKitAPI::Pair::assertFoundAndRemove):
1794         (TestWebKitAPI::Pair::assertEqual):
1795         (TestWebKitAPI::Pair::assertSameValuesForKey):
1796         (TestWebKitAPI::Pair::testDriver):
1797         (TestWebKitAPI::TEST_F):
1798
1799 2011-09-10  Andy Estes  <aestes@apple.com>
1800
1801         Move myself from committers_unable_to_review to reviewers_list.
1802
1803         * Scripts/webkitpy/common/config/committers.py:
1804
1805 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1806
1807         [wx] Unreviewed build fix. MSW build fixes.
1808
1809         * DumpRenderTree/config.h:
1810         * waf/build/wxpresets.py:
1811
1812 2011-09-10  Andreas Kling  <kling@webkit.org>
1813
1814         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1815         https://bugs.webkit.org/show_bug.cgi?id=59328
1816
1817         Reviewed by Kenneth Rohde Christiansen.
1818
1819         * MiniBrowser/mac/BrowserWindowController.m:
1820         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1821
1822 2011-09-10  Adam Barth  <abarth@webkit.org>
1823
1824         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1825         and does not have access to notImplemented().
1826
1827         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1828         (openStartupDialog):
1829
1830 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1831
1832         Add a script to create a monolithic script-test
1833         https://bugs.webkit.org/show_bug.cgi?id=67747
1834
1835         Reviewed by Darin Adler.
1836
1837         * Scripts/make-new-script-test: Added.
1838
1839 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1840
1841         Adding myself to the reviewers list.
1842
1843         * Scripts/webkitpy/common/config/committers.py:
1844
1845 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1846
1847         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1848         https://bugs.webkit.org/show_bug.cgi?id=67855
1849
1850         Reviewed by Dirk Pranke.
1851
1852         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1853         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1854
1855         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858
1859 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1860
1861         Add myself to committers.py
1862         https://bugs.webkit.org/show_bug.cgi?id=67853
1863
1864         Reviewed by Darin Adler.
1865
1866         * Scripts/webkitpy/common/config/committers.py:
1867
1868 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1869
1870         [Qt] Remove common.pri
1871         https://bugs.webkit.org/show_bug.cgi?id=67814
1872
1873         Reviewed by Andreas Kling.
1874
1875         * Tools.pro:
1876
1877 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1878
1879         [NRWT] the nrwt check httpd with --no-http option
1880         https://bugs.webkit.org/show_bug.cgi?id=67835
1881
1882         Reviewed by Tony Chang.
1883
1884         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1885         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1886
1887 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1888
1889         [chromium] Implement DRT support for Android.
1890         https://bugs.webkit.org/show_bug.cgi?id=67590
1891
1892         Reviewed by Tony Chang.
1893
1894         Add 2 mechanism to make DRT interaction more robust on Android:
1895         - Send 'QUIT' to DRT to make it stop.
1896         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1897         input commands before it starts.
1898         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1899         and <clocale> for 'LC_ALL' to compile on Android.
1900
1901         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1902         as signal() man page recommends using sigaction().
1903
1904         * DumpRenderTree/DumpRenderTree.gypi:
1905         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1906         (main):
1907         * DumpRenderTree/chromium/LayoutTestController.cpp:
1908         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1909         (AlarmHandler):
1910         (TestShell::waitTestFinished):
1911         (platformInit):
1912         (openStartupDialog):
1913         (checkLayoutTestSystemDependencies):
1914         * DumpRenderTree/chromium/TestShellGtk.cpp:
1915         (AlarmHandler):
1916         (TestShell::waitTestFinished):
1917
1918 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1919
1920         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1921
1922         * waf/build/settings.py:
1923
1924 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1925
1926         Unreviewed, rolling out r94851.
1927         http://trac.webkit.org/changeset/94851
1928         https://bugs.webkit.org/show_bug.cgi?id=67847
1929
1930         It broke a webkitpy test (Requested by ossy on #webkit).
1931
1932         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1933
1934 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1935
1936         [NRWT] the nrwt check httpd with --no-http option
1937         https://bugs.webkit.org/show_bug.cgi?id=67835
1938
1939         Reviewed by Csaba Osztrogonác.
1940
1941         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1942
1943 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1944
1945         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1946         https://bugs.webkit.org/show_bug.cgi?id=67794
1947         <rdar://problem/9892024>
1948         
1949         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1950
1951         Reviewed by Brady Eidson.
1952
1953         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1954         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1955         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1956         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1957             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1958             didPerformServerRedirect.
1959
1960         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1961         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1962             our InjectedBundleTest.
1963         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1964             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1965             the request.
1966         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1967
1968         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1969         
1970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1971         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1972         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1973         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1974
1975 2011-09-08  David Levin  <levin@chromium.org>
1976
1977         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1978         https://bugs.webkit.org/show_bug.cgi?id=67797
1979
1980         Reviewed by Eric Seidel.
1981
1982         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1983         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1984
1985 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1986
1987         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1988         https://bugs.webkit.org/show_bug.cgi?id=67723
1989
1990         Reviewed by Adam Barth.
1991
1992         * DumpRenderTree/chromium/EventSender.h:
1993         * DumpRenderTree/chromium/LayoutTestController.cpp:
1994         (LayoutTestController::LayoutTestController):
1995         (LayoutTestController::enableFixedLayoutMode):
1996         (LayoutTestController::setFixedLayoutSize):
1997         * DumpRenderTree/chromium/LayoutTestController.h:
1998
1999 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2000
2001         Add standalone script that filters the output of build-webkit to be more human-readable
2002         https://bugs.webkit.org/show_bug.cgi?id=44081
2003
2004         Reviewed by Daniel Bates.
2005
2006         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
2007         a build script (e.g. build-webkit) and it spits out a prettier version.
2008         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
2009         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
2010
2011 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2012
2013         Add myself to committers.py                 
2014         https://bugs.webkit.org/show_bug.cgi?id=67696
2015
2016         Reviewed by Kent Tamura.
2017
2018         * Scripts/webkitpy/common/config/committers.py:
2019
2020 2011-09-07  Adam Barth  <abarth@webkit.org>
2021
2022         rebaseline button in garden-o-matic details view should work
2023         https://bugs.webkit.org/show_bug.cgi?id=67738
2024
2025         Reviewed by Dimitri Glazkov.
2026
2027         This patch wires up the rebaseline button in garden-o-matic results
2028         details view.  The button is current per-test, so there isn't a way to
2029         rebaseline individual bots.  This is a place to start.  If we decide we
2030         want per-bot rebaselining, we'll need to think of some better UI.
2031
2032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2036
2037 2011-09-07  Eric Seidel  <eric@webkit.org>
2038
2039         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2040         https://bugs.webkit.org/show_bug.cgi?id=67737
2041
2042         Reviewed by Adam Barth.
2043
2044         I got a little over-eager when deprecating host.port_factory in the previous commit.
2045         Turns out that Host.port_factory was already the "modern" port/factory.py
2046         it was just the Module object.  I un-deprecated the variable, and changed it from
2047         being the module to being an actual PortFactory, passing it a host object.
2048         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2049         when instantiating a new Port object.
2050         This magically fixed the test_rebaseline test, since its now no longer talking
2051         to the real filesystem.
2052
2053         * Scripts/webkitpy/common/host.py:
2054         * Scripts/webkitpy/layout_tests/port/factory.py:
2055         * Scripts/webkitpy/tool/commands/queries.py:
2056         * Scripts/webkitpy/tool/mocktool.py:
2057
2058 2011-09-07  Eric Seidel  <eric@webkit.org>
2059
2060         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2061         https://bugs.webkit.org/show_bug.cgi?id=67734
2062
2063         Reviewed by Adam Barth.
2064
2065         Right now every place that creates a Port object has to be very careful
2066         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2067         The correct fix is for port/factory.py (which creates most port objects)
2068         to know how to pass these in automatically.  However, currently all port/factory.py
2069         functions are free functions instead of being on an object.  This patch
2070         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2071
2072         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2073         pass along the proper scm/user/filesystem to the Port object.
2074
2075         * Scripts/webkitpy/common/host.py:
2076         * Scripts/webkitpy/layout_tests/port/factory.py:
2077         * Scripts/webkitpy/tool/commands/queries.py:
2078         * Scripts/webkitpy/tool/mocktool.py:
2079
2080 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2081
2082         Unreviewed, rolling out r94441.
2083         http://trac.webkit.org/changeset/94441
2084         https://bugs.webkit.org/show_bug.cgi?id=67731
2085
2086         "MacEWSes are backed up due to new machines not able to reach
2087         git.webkit.org.  Disabling tests for now" (Requested by
2088         eseidel2 on #webkit).
2089
2090         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2091
2092 2011-09-07  Elliot Poger  <epoger@google.com>
2093
2094         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2095         https://bugs.webkit.org/show_bug.cgi?id=67324
2096
2097         Reviewed by Dirk Pranke.
2098
2099         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2100         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2101         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2102         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2103         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2104
2105 2011-09-07  Eric Boren  <borenet@gmail.com>
2106
2107         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2108         https://bugs.webkit.org/show_bug.cgi?id=66800
2109
2110         Reviewed by Darin Fisher.
2111
2112         * DumpRenderTree/chromium/EventSender.cpp:
2113         (EventSender::sendCurrentTouchEvent):
2114
2115 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2116
2117         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2118         https://bugs.webkit.org/show_bug.cgi?id=67254
2119
2120         Reviewed by Csaba Osztrogonác.
2121
2122         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2123         derived from the running location of DumpRenderTree binary.
2124
2125         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2126         (LayoutTestController::pathToLocalResource):
2127         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2128
2129 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2130
2131         REGRESSION(r94288) build-webkit doesn't work on Symbian
2132         https://bugs.webkit.org/show_bug.cgi?id=67706
2133
2134         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2135         (buildQMakeProject):
2136
2137 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2138
2139         REGRESSION(r94288) build-webkit doesn't work on Windows
2140         https://bugs.webkit.org/show_bug.cgi?id=67646
2141
2142         Roll back r94655 with a small fix.
2143
2144         * Scripts/webkitdirs.pm:
2145         (buildQMakeProject):
2146
2147 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2148
2149         Unreviewed, rolling out r94635.
2150         http://trac.webkit.org/changeset/94635
2151         https://bugs.webkit.org/show_bug.cgi?id=67704
2152
2153         Linux Touch build is failing to compile this change.
2154         (Requested by loislo on #webkit).
2155
2156         * DumpRenderTree/chromium/EventSender.cpp:
2157         (EventSender::sendCurrentTouchEvent):
2158
2159 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2160
2161         Unreviewed, rolling out r94655.
2162         http://trac.webkit.org/changeset/94655
2163         https://bugs.webkit.org/show_bug.cgi?id=67703
2164
2165         It broke Leopard debug bot (Requested by ossy on #webkit).
2166
2167         * Scripts/webkitdirs.pm:
2168
2169 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2170
2171         REGRESSION(r94288) build-webkit doesn't work on Windows
2172         https://bugs.webkit.org/show_bug.cgi?id=67646
2173
2174         Reviewed by Csaba Osztrogonác.
2175
2176         * Scripts/webkitdirs.pm:
2177
2178 2011-09-06  Eric Boren  <borenet@gmail.com>
2179
2180         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2181         https://bugs.webkit.org/show_bug.cgi?id=66800
2182
2183         Reviewed by Darin Fisher.
2184
2185         * DumpRenderTree/chromium/EventSender.cpp:
2186         (EventSender::sendCurrentTouchEvent):
2187
2188 2011-09-06  Adam Barth  <abarth@webkit.org>
2189
2190         garden-o-matic details view should having working rebaseline and next/previous buttons
2191         https://bugs.webkit.org/show_bug.cgi?id=67659
2192
2193         Reviewed by Dimitri Glazkov.
2194
2195         This patch wires up basic back/forward buttons that let you traverse
2196         through the results we're examining in the details view.  This ended up
2197         being more code than I expected, but I wanted to keep all the state
2198         information in the DOM itself.
2199
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2203
2204 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
2205
2206         fix MockFileSystem.glob(), refactor filesystem tests
2207         https://bugs.webkit.org/show_bug.cgi?id=67462
2208
2209         Reviewed by Eric Seidel.
2210
2211         In debugging why my proposed change for MockFileSystem.glob()
2212         in bug 66228 didn't work, I stumbled across two real bugs
2213         that cancelled each other out for the unit tests. I fixed those
2214         (glob shouldn't recurse into subdirs, and we weren't populating
2215         self.dirs from self.files properly).
2216
2217         I have also created a "mixin" class for tests that can be shared
2218         between the real filesystem and the mock filesystem - MockFileSystem
2219         is being used enough it needs its own tests.
2220
2221         * Scripts/webkitpy/common/system/filesystem_mock.py:
2222         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
2223         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2224
2225 2011-09-06  Anders Carlsson  <andersca@apple.com>
2226
2227         Move NPAPI headers in bridge to plugins
2228         https://bugs.webkit.org/show_bug.cgi?id=67661
2229
2230         Update forwarding headers.
2231
2232         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2233         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2234
2235 2011-09-06  Tony Chang  <tony@chromium.org>
2236
2237         [chromium] Check in 'build' for compiled binaries first
2238         https://bugs.webkit.org/show_bug.cgi?id=67549
2239
2240         Reviewed by Dirk Pranke.
2241
2242         I'm working on moving the windows build output to a common location
2243         rather than relative to the sln file.  Because of that, we need to
2244         check those build locations first for DumpRenderTree.exe.
2245
2246         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2247
2248 2011-09-06  Adam Barth  <abarth@webkit.org>
2249
2250         Use a hierarchial structure for the garden-o-matic results view
2251         https://bugs.webkit.org/show_bug.cgi?id=67620
2252
2253         Reviewed by Dimitri Glazkov.
2254
2255         This patch re-organizes the results view to use a hierachial structure
2256         for selection.  At the top-level are sections for each test.  Expanding
2257         the test section shows a tab selector for builders.
2258
2259         This structure prepares us for wiring up various actions to this view.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2262         (.):
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2264         ():
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2266         (.):
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2269         (.results-view>.toolbar):
2270         (.results-view>.toolbar ul.actions):
2271         (.results-view>.toolbar ul.actions li):
2272         (.results-grid table):
2273         (.results-grid table td, .results-view table th):
2274         (.results-grid table th):
2275         (.results-grid .text-result):
2276         (.results-grid .image-result):
2277
2278 2011-09-06  Adam Barth  <abarth@webkit.org>
2279
2280         garden-o-matic's base.probe generates spam in the JavaScript console
2281         https://bugs.webkit.org/show_bug.cgi?id=67622
2282
2283         Reviewed by Dimitri Glazkov.
2284
2285         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
2286         instead of HTMLScriptElement to test whether results exist.  This
2287         reduces the console.log spam and saves bandwidth because we can use a
2288         HEAD request instead of a GET request.
2289
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2291
2292 2011-09-05  Adam Barth  <abarth@webkit.org>
2293
2294         Add a tab to garden-o-matic for viewing expected failures
2295         https://bugs.webkit.org/show_bug.cgi?id=67619
2296
2297         Reviewed by Dimitri Glazkov.
2298
2299         This patch adds a basic tab to garden-o-matic that shows all the tests
2300         failing on the bots, including the expected failures.  This patch
2301         mostly involves refactoring existing classes to allow new subclasses.
2302
2303         This view is useful for when gardeners mark tests as expected to fail
2304         and then rebaseline them later.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
2310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2313
2314 2011-09-05  Adam Barth  <abarth@webkit.org>
2315
2316         Fix global variable leak in garden-o-matic
2317         https://bugs.webkit.org/show_bug.cgi?id=67617
2318
2319         Reviewed by Dimitri Glazkov.
2320
2321         Caught by running the unit tests with noglobals turned on.
2322
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2324
2325 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
2326
2327         [Qt][WK2] Add pixel test support
2328         https://bugs.webkit.org/show_bug.cgi?id=66283
2329
2330         Reviewed by Andreas Kling.
2331
2332         Implemented pixel result generation by reusing the logic
2333         that we have in DumpRenderTree.
2334         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2335         (WTR::dumpImage):
2336         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2337
2338 2011-09-04  Robin Dunn  <robin@alldunn.com>
2339
2340         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
2341         https://bugs.webkit.org/show_bug.cgi?id=67577
2342
2343         Reviewed by Kevin Ollivier.
2344
2345         * waf/build/settings.py:
2346
2347 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
2348
2349         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
2350
2351         * waf/build/settings.py:
2352
2353 2011-09-03  Dan Bernstein  <mitz@apple.com>
2354
2355         32-bit build fix.
2356
2357         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2358         (TestWebKitAPI::Util::toSTD):
2359
2360 2011-09-03  Dan Bernstein  <mitz@apple.com>
2361
2362         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
2363         https://bugs.webkit.org/show_bug.cgi?id=67559
2364
2365         Reviewed by Darin Adler.
2366
2367         * DumpRenderTree/mac/DumpRenderTree.mm:
2368         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
2369         the call to it.
2370         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
2371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
2372         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
2373         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
2374         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2375         (TestWebKitAPI::Util::toSTD): Added.
2376
2377 2011-09-03  Adam Barth  <abarth@webkit.org>
2378
2379         garden-o-matic results view should have a better results selector
2380         https://bugs.webkit.org/show_bug.cgi?id=67542
2381
2382         Reviewed by Dimitri Glazkov.
2383
2384         This patch adds a basic grid-based results selector to the results
2385         view.  Currently, this grid just shows how the tests fail on the
2386         various bots.  A future patch will let you select which failure to view
2387         and to mark the failures for rebaselining.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2391           - Add some more basic functions for manipulating dictionaries.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2395
2396 2011-09-03  Adam Barth  <abarth@webkit.org>
2397
2398         garden-o-matic results view should show Actual and Expected results for text failures
2399         https://bugs.webkit.org/show_bug.cgi?id=67536
2400
2401         Reviewed by Eric Seidel.
2402
2403         In the past, we didn't show actual and expected text results (we just
2404         showed the diff) because we didn't have the awesome six-by-two results
2405         grid.  Now that we do, we can move show these results.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2409           - Fixed some typos that were preventing these unit tests from running.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2411         (.):
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2413           - Report -actual.txt and -expected.txt as possible results URLs.
2414
2415 2011-09-03  Adam Barth  <abarth@webkit.org>
2416
2417         garden-o-matic shows "ghost" failures that are already fixed
2418         https://bugs.webkit.org/show_bug.cgi?id=67535
2419
2420         Reviewed by Eric Seidel.
2421
2422         About 10% of writes fail to stick on test-results.appspot.com.  This
2423         patch causes us to fetch the full_results.json blob directly from
2424         build.chromium.org rather than relying upon AppEngine.
2425
2426         Unforuntately, we still need to get historical information from
2427         AppEngine.  That will take several patches to fix becuase I need to
2428         change the bots to write the full_results.json file to the
2429         build-specific directory in addition to the zip file.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2434
2435 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2436
2437         Unreviewed, rolling out r94458.
2438         http://trac.webkit.org/changeset/94458
2439         https://bugs.webkit.org/show_bug.cgi?id=67558
2440
2441         Caused appcache test to fail on various bots (Requested by
2442         rniwa on #webkit).
2443
2444         * Scripts/webkitpy/layout_tests/port/webkit.py:
2445         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2446
2447 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2448
2449         Unreviewed, rolling out r94453.
2450         http://trac.webkit.org/changeset/94453
2451         https://bugs.webkit.org/show_bug.cgi?id=67557
2452
2453         Caused appcache test to fail on various bots (Requested by
2454         rniwa on #webkit).
2455
2456         * Scripts/webkitpy/layout_tests/port/webkit.py:
2457
2458 2011-09-02  Michael Saboff  <msaboff@apple.com>
2459
2460         Add JSC:RegExp functional tests
2461         https://bugs.webkit.org/show_bug.cgi?id=67339
2462
2463         New perl script to build JavaScriptCore and run the RegExp tests.
2464
2465         Reviewed by Gavin Barraclough.
2466
2467         * Scripts/run-regexp-tests: Added.
2468
2469 2011-09-02  Michael Saboff  <msaboff@apple.com>
2470
2471         Add JSC:RegExp functional tests
2472         https://bugs.webkit.org/show_bug.cgi?id=67339
2473
2474         New perl script to build JavaScriptCore and run the RegExp tests.
2475
2476         Reviewed by Gavin Barraclough.
2477
2478         * Scripts/run-regexp-tests: Added.
2479
2480 2011-09-02  Eric Seidel  <eric@webkit.org>
2481
2482         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2483         https://bugs.webkit.org/show_bug.cgi?id=67530
2484
2485         Unreviewed.  Fixing typo from previous commit.
2486
2487         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
2488         which exercises the code I previously made a typo in.
2489
2490         * Scripts/webkitpy/layout_tests/port/webkit.py:
2491         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2492
2493 2011-09-02  Eric Seidel  <eric@webkit.org>
2494
2495         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2496         https://bugs.webkit.org/show_bug.cgi?id=67530
2497
2498         Reviewed by Adam Barth.
2499
2500         No functional change, just reshuffling code.
2501
2502         * Scripts/webkitpy/layout_tests/port/webkit.py:
2503
2504 2011-09-02  Darin Adler  <darin@apple.com>
2505
2506         Added Subversion ignore for .pyc generated files.
2507
2508         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
2509         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
2510         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
2511
2512 2011-09-02  Adam Barth  <abarth@webkit.org>
2513
2514         Enable testing on mac-ews
2515         https://bugs.webkit.org/show_bug.cgi?id=67505
2516
2517         Reviewed by Eric Seidel.
2518
2519         This patch enables testing on the Mac EWS, which should help
2520         contributors not turn the Mac bots red.
2521
2522         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2523
2524 2011-09-01  Beth Dakin  <bdakin@apple.com>
2525
2526         https://bugs.webkit.org/show_bug.cgi?id=67451
2527         Add a test for going back to a cached page after changing the device scale factor
2528
2529         Reviewed by Adam Roben.
2530
2531         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
2534         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2535         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
2536         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2537         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
2538         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
2539         (TestWebKitAPI::TEST_F):
2540
2541         Added new function to WebKitAgnosticTest to goBack. Separated 
2542         waitForLoadToFinish() into its own function (instead of being a part of 
2543         loadAndWaitUntilFinished()) so that it can be called from goBack as 
2544         well. Also added initializeView() so we can set the cache model.
2545         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
2546         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
2547         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2548         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
2549         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2550         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2551         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
2552         (TestWebKitAPI::WebKitAgnosticTest::goBack):
2553         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
2554
2555 2011-09-02  Anders Carlsson  <andersca@apple.com>
2556
2557         Build fix.
2558
2559         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
2560         (PrivateBrowsing::ScriptableObject::pluginTest):
2561
2562 2011-09-02  Anders Carlsson  <andersca@apple.com>
2563
2564         Move private browsing test to a PluginTest subclass
2565         https://bugs.webkit.org/show_bug.cgi?id=67498
2566
2567         Reviewed by Darin Adler.
2568
2569         * DumpRenderTree/DumpRenderTree.gypi:
2570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2571         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2572         (pluginGetProperty):
2573         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2574         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2575         (PluginTest::NPP_SetValue):
2576         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2577         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
2578         (PrivateBrowsing::PrivateBrowsing):
2579         (PrivateBrowsing::privateBrowsingEnabled):
2580         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
2581         (PrivateBrowsing::ScriptableObject::hasProperty):
2582         (PrivateBrowsing::ScriptableObject::getProperty):
2583         (PrivateBrowsing::ScriptableObject::pluginTest):
2584         (PrivateBrowsing::NPP_New):
2585         (PrivateBrowsing::NPP_GetValue):
2586         (PrivateBrowsing::NPP_SetValue):
2587         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2588         (NPP_New):
2589         (NPP_SetValue):
2590         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2591         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2592         * GNUmakefile.am:
2593
2594 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
2595
2596         [Qt] Build dependency problems
2597         https://bugs.webkit.org/show_bug.cgi?id=38054
2598
2599         Trivial fix after r94288.
2600
2601         Rubber-stamped by Andras Becsi.
2602
2603         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
2604         (buildQMakeProject):
2605
2606 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
2607
2608         Remove my old e-mail address and add my new one.
2609
2610         Rubber-stamped by Tor Arne Vestbø.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2011-09-02  Philippe Normand  <pnormand@igalia.com>
2615
2616         [GTK] run-gtk-tests leaves a zombie Xvfb process
2617         https://bugs.webkit.org/show_bug.cgi?id=67389
2618
2619         Reviewed by Martin Robinson.
2620
2621         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
2622         child process instead of doing shell redirection.
2623
2624 2011-09-01  Mark Rowe  <mrowe@apple.com>
2625
2626         Fix the build by adding some more missing return types.
2627
2628         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2629         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2630
2631 2011-09-01  Eric Seidel  <eric@webkit.org>
2632
2633         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2634         https://bugs.webkit.org/show_bug.cgi?id=66228
2635
2636         Reviewed by Dirk Pranke.
2637
2638         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2639         The LeaksViewer tool globs for all *-leaks.txt files.
2640         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2641
2642         In order to test this I had to fix a limitation in our MockFileSystem.glob
2643         method.  However, doing so uncovered a typo and bug in the integration tests.
2644         I've disabled the offending integration tests.
2645
2646         * Scripts/webkitpy/common/system/filesystem_mock.py:
2647         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2648         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2649
2650 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2651
2652         Adds a LayoutTestController method to make it possible to test
2653         starting speech input via an API call.
2654         https://bugs.webkit.org/show_bug.cgi?id=60170
2655
2656         Reviewed by Dimitri Glazkov.
2657
2658         * DumpRenderTree/LayoutTestController.h:
2659         * DumpRenderTree/chromium/LayoutTestController.cpp:
2660         (LayoutTestController::LayoutTestController):
2661         (LayoutTestController::startSpeechInput):
2662         * DumpRenderTree/chromium/LayoutTestController.h:
2663         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2664         (LayoutTestController::startSpeechInput):
2665         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2666         (LayoutTestController::startSpeechInput):
2667         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2668         (LayoutTestController::startSpeechInput):
2669         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2670         (LayoutTestController::startSpeechInput):
2671         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2672         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2673         (LayoutTestController::startSpeechInput):
2674         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2675         (LayoutTestController::startSpeechInput):
2676
2677 2011-09-01  Tim Horton  <hortont424@gmail.com>
2678
2679         Fix TestWebKitAPI build on clang-2.0
2680
2681         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2682
2683 2011-09-01  Adam Barth  <abarth@webkit.org>
2684
2685         Remove unused "extension" parameter from rebaseline gardeningserver handler
2686         https://bugs.webkit.org/show_bug.cgi?id=67384
2687
2688         Reviewed by James Robinson.
2689
2690         This parameter hasn't done anything in a while.
2691
2692         * Scripts/webkitpy/tool/commands/rebaseline.py:
2693         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2694         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2695
2696 2011-09-01  Eric Seidel  <eric@webkit.org>
2697
2698         Unreviewed.
2699
2700         Fix a typo in unittests.  Unfortunately fixing it
2701         caused several assertions.  Just disabling the test
2702         instead, since it was providing no value before due to the typo.
2703
2704         * Scripts/webkitpy/layout_tests/port/test.py:
2705
2706 2011-09-01  Adam Barth  <abarth@webkit.org>
2707
2708         Add a "rebaseline" button to the garden-o-matic summary page
2709         https://bugs.webkit.org/show_bug.cgi?id=67382
2710
2711         Reviewed by Dimitri Glazkov.
2712
2713         As much as we might wish folks to not rebaseline entire test groups at
2714         once, the truth is that doing so is a common operation.  Adding a
2715         button for this operation is likely to make folks happy.
2716
2717         This patch also cleans up a bunch of plumbing surrounding failureInfo
2718         objects.
2719
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2730
2731 2011-09-01  Adam Barth  <abarth@webkit.org>
2732
2733         garden-o-matic should let the gardener assign blame for a group of test failures
2734         https://bugs.webkit.org/show_bug.cgi?id=67379
2735
2736         Reviewed by Dimitri Glazkov.
2737
2738         If a group of test failures has a large revision range, the gardener
2739         might wish to blame a specific revision for the failure.  Currently,
2740         this only effect of assigning blame in this way is to hide the other
2741         suspect commits.
2742
2743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2746
2747 2011-09-01  Adam Barth  <abarth@webkit.org>
2748
2749         Hide garden-o-matic failure table until hover
2750         https://bugs.webkit.org/show_bug.cgi?id=67376
2751
2752         Reviewed by Dimitri Glazkov.
2753
2754         This patch removes the failure table for build failures (because it
2755         does not make sense) and hides the failure table for test groups until
2756         the user hovers over the test failure block, reducing visual noise.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2761
2762 2011-09-01  Adam Barth  <abarth@webkit.org>
2763
2764         Switch garden-o-matic from commitData.title to commitData.summary
2765         https://bugs.webkit.org/show_bug.cgi?id=67375
2766
2767         Reviewed by Dimitri Glazkov.
2768
2769         commitData.title is a string provided by Trac, which isn't great in all
2770         cases.  commitData.summary is my attempt to find the most important
2771         one-line summary of the commit.  This patch switches garden-o-matic
2772         over to summary.
2773
2774         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2775         and reduce visual noise.
2776
2777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2780
2781 2011-09-01  Adam Barth  <abarth@webkit.org>
2782
2783         Group failing tests in garden-o-matic if there are more than three in a folder
2784         https://bugs.webkit.org/show_bug.cgi?id=67373
2785
2786         Reviewed by Dimitri Glazkov.
2787
2788         Sometimes a failure will cause many tests in a given directory to fail.
2789         When that happens, it's better to list the directory as a single item
2790         (with a count) rather than spamming all the test names.
2791
2792         (This patch also updates a bunch of unit test expected results after my last commit.)
2793
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2799
2800 2011-09-01  Adam Barth  <abarth@webkit.org>
2801
2802         Lower the visual noise from the failing builders display
2803         https://bugs.webkit.org/show_bug.cgi?id=67369
2804
2805         Reviewed by Dimitri Glazkov.
2806
2807         This patch ensures that the "Building" row in the failing builders
2808         display is always last and dims it by 50% to reduce visual noise.  This
2809         lets the gardener focus on the actual failures.
2810
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2814
2815 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2816
2817         [Qt] Build dependency problems
2818         https://bugs.webkit.org/show_bug.cgi?id=38054
2819
2820         Make clean build after the defines are changed.
2821
2822         Reviewed by Csaba Osztrogonác.
2823
2824         * Scripts/webkitdirs.pm:
2825         (buildQMakeProject):
2826
2827 2011-08-31  Adam Barth  <abarth@webkit.org>
2828
2829         Move DumpRenderTree to WebKitPlatformSupport
2830         https://bugs.webkit.org/show_bug.cgi?id=67331
2831
2832         Reviewed by Darin Fisher.
2833
2834         This patch update DumpRenderTree to account for the WebKitClient =>
2835         WebKitPlatformSupport rename.
2836
2837         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2838         (NotificationPresenter::show):
2839         * DumpRenderTree/chromium/Task.cpp:
2840         (postTask):
2841
2842 2011-08-31  Eric Seidel  <eric@webkit.org>
2843
2844         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2845         https://bugs.webkit.org/show_bug.cgi?id=67314
2846
2847         Reviewed by Adam Barth.
2848
2849         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2850         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2851         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2852
2853         I also moved a bunch of code into dashboard.css which belonged there.
2854
2855         * QueueStatusServer/handlers/activebots.py: Added.
2856         * QueueStatusServer/main.py:
2857         * QueueStatusServer/stylesheets/dashboard.css:
2858         (.queue_bubble):
2859         (.queue_name):
2860         (.last_heard_from):
2861         (.status_text):
2862         (.alive):
2863         (.behind):
2864         (.dead):
2865         * QueueStatusServer/templates/activebots.html: Added.
2866         * QueueStatusServer/templates/dashboard.html:
2867         * QueueStatusServer/templates/recentstatus.html:
2868
2869 2011-08-31  Oliver Hunt  <oliver@apple.com>
2870
2871         Move CheckedArithmeticOperations.cpp to the intended location
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2875
2876 2011-08-31  Elliot Poger  <epoger@google.com>
2877
2878         add unittest to validate the complete set of Chromium configurations
2879         https://bugs.webkit.org/show_bug.cgi?id=67211
2880
2881         Reviewed by Adam Barth.
2882
2883         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2884
2885 2011-08-31  Nico Weber  <thakis@chromium.org>
2886
2887         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2888         https://bugs.webkit.org/show_bug.cgi?id=67297
2889
2890         Reviewed by Tony Chang.
2891
2892         Explicitly disable smooth scrolling in chromium's DRT.
2893
2894         * DumpRenderTree/chromium/WebPreferences.cpp:
2895         (WebPreferences::applyTo):
2896
2897 2011-08-31  Oliver Hunt  <oliver@apple.com>
2898
2899         Add Checked<> tests to windows build
2900
2901         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2902
2903 2011-08-30  Oliver Hunt  <oliver@apple.com>
2904
2905         Add support for checked arithmetic
2906         https://bugs.webkit.org/show_bug.cgi?id=67095
2907
2908         Reviewed by Sam Weinig.
2909
2910         Add test cases for Checked<>
2911
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2914
2915 2011-08-31  Adam Barth  <abarth@webkit.org>
2916
2917         Move summary.html to garden-o-matic.html.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2923
2924 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2925
2926         [chromium] DRT linux should pass nativeKeyCode to plugins
2927         https://bugs.webkit.org/show_bug.cgi?id=66679
2928
2929         Reviewed by Tony Chang.
2930
2931         * DumpRenderTree/chromium/EventSender.cpp:
2932         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2933         (simulated) nativeKeyCode for the given input keyboard code.
2934
2935 2011-08-31  Adam Barth  <abarth@webkit.org>
2936
2937         Tighen up UI for garden-o-matic tab strip
2938         https://bugs.webkit.org/show_bug.cgi?id=67266
2939
2940         Reviewed by Dimitri Glazkov.
2941
2942         This patch add CSS to move the tab strip to the edges of the page and
2943         to remove some gratuitous border-radius.
2944
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2947
2948 2011-08-31  Adam Barth  <abarth@webkit.org>
2949
2950         garden-o-matic results view shouldn't be horrifically ugly
2951         https://bugs.webkit.org/show_bug.cgi?id=67264
2952
2953         Reviewed by Dimitri Glazkov.
2954
2955         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2960
2961 2011-08-31  Adam Barth  <abarth@webkit.org>
2962
2963         garden-o-matic needs a tabstrip
2964         https://bugs.webkit.org/show_bug.cgi?id=67263
2965
2966         Reviewed by Dimitri Glazkov.
2967
2968         This patch adds a basic tabstrip to garden-o-matic.  The results
2969         details view now opens in the "Results" tab, and the user can flip back
2970         and forth between the Summary and the Results tab quickly.  There's
2971         also a stub for a "Commits" tab, which is disabled.
2972
2973         This patch isn't the most beautiful in the world, but it gets the ball
2974         rolling on a multi-modal UI.
2975
2976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2981
2982 2011-08-31  Ai Makabi  <makabi@google.com>
2983
2984         Extract reference links from reftest test file.
2985         https://bugs.webkit.org/show_bug.cgi?id=66838
2986
2987         Reviewed by Shinichiro Hamaji.
2988
2989         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2990         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2991         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2992
2993 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2994
2995         [webkitpy] missing log import in common/net/resultsjsonparser.py
2996         https://bugs.webkit.org/show_bug.cgi?id=65606
2997
2998         Reviewed by Martin Robinson.
2999
3000         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
3001
3002 2011-08-30  Philippe Normand  <pnormand@igalia.com>
3003
3004         [stylechecker] complains about NULL usage in some gst_structure_ calls
3005         https://bugs.webkit.org/show_bug.cgi?id=67194
3006
3007         Reviewed by Martin Robinson.
3008
3009         Don't warn about NULL in some gst_structure_ calls. 0 can't be
3010         used for these, a proper sentinel is required.
3011
3012         * Scripts/webkitpy/style/checkers/cpp.py:
3013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3014
3015 2011-08-30  Adam Barth  <abarth@webkit.org>
3016
3017         Remove old-style UI from garden-o-matic
3018         https://bugs.webkit.org/show_bug.cgi?id=67257
3019
3020         Reviewed by Dimitri Glazkov.
3021
3022         This code is nowhere near as awesome as the new hotness.  Let's remove
3023         it so it doesn't weigh us down.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
3031
3032 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3033
3034         [WebSocket] update pywebsocket to 0.6b5.
3035         https://bugs.webkit.org/show_bug.cgi?id=66924
3036
3037         Reviewed by Kent Tamura.
3038
3039         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3040         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
3041         0.6b3 or later supports a closing handshake handler and it is useful to
3042         verify client's closing handshake implementation.
3043         0.6b4 supports AbortedByUserException. It is useful to eliminate
3044         unnecessary server warning messages on intended abnormal closures.
3045         0.6b5 supports Python 2.5.1 or Mac 10.5.
3046
3047         * Scripts/webkitpy/thirdparty/__init__.py:
3048         Update download URL and directory path.
3049
3050 2011-08-30  Dan Bernstein  <mitz@apple.com>
3051
3052         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
3053         https://bugs.webkit.org/show_bug.cgi?id=67230
3054
3055         Reviewed by Darin Adler.
3056
3057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3058         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
3059         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
3060         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
3061         (TestWebKitAPI::TEST):
3062
3063 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
3064
3065         Add MediaSource API to HTMLMediaElement
3066         https://bugs.webkit.org/show_bug.cgi?id=64731
3067
3068         Reviewed by Eric Carlson.
3069
3070         * Scripts/build-webkit:
3071
3072 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3073
3074         Emit last progress notification before calling dispatchDidFinishLoad
3075         https://bugs.webkit.org/show_bug.cgi?id=28851
3076
3077         Reviewed by Adam Barth.
3078
3079         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
3080         Chromium and GTK ports. The first two were simple changes.
3081
3082         Some refactoring was needed in GTK port to assure that the dumps are emitted
3083         correctly and the processing after the page load finished is in the right place.
3084
3085         To detect the load finished, we use the callback for the "load-status" notifier
3086         signal of the top loading frame. And we use the deprecated "load-finished" signal
3087         for dumping (if enabled) the progress finished expected output.
3088
3089         * DumpRenderTree/LayoutTestController.cpp:
3090         (LayoutTestController::LayoutTestController):
3091         (dumpProgressFinishedCallbackCallback):
3092         (LayoutTestController::staticFunctions):
3093         * DumpRenderTree/LayoutTestController.h:
3094         (LayoutTestController::dumpProgressFinishedCallback):
3095         (LayoutTestController::setDumpProgressFinishedCallback):
3096         * DumpRenderTree/chromium/LayoutTestController.cpp:
3097         (LayoutTestController::LayoutTestController):
3098         (LayoutTestController::dumpProgressFinishedCallback):
3099         (LayoutTestController::reset):
3100         * DumpRenderTree/chromium/LayoutTestController.h:
3101         (LayoutTestController::shouldDumpProgressFinishedCallback):
3102         (LayoutTestController::setShouldDumpProgressFinishedCallback):
3103         * DumpRenderTree/chromium/WebViewHost.cpp:
3104         (WebViewHost::didStopLoading):
3105         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3106         (webViewLoadFinished):
3107         (topLoadingFrameLoadFinished):
3108         (webFrameLoadStatusNotified):
3109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3110         (LayoutTestController::reset):
3111         (LayoutTestController::dumpProgressFinishedCallback):
3112         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3113
3114 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
3115
3116         JavaScriptCore does not have a good mechanism for performance
3117         regression testing
3118         https://bugs.webkit.org/show_bug.cgi?id=67177
3119
3120         Reviewed by Darin Adler.
3121         
3122         Added a new script, which allows for testing one, two, or more VMs
3123         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
3124         are interleaved at random to minimize systematics.  The results
3125         that bencher prints includes all possible relevant information about
3126         how bencher was invoked.  Bencher can be easily used to measure
3127         performance changes down to fractions of a percent.
3128         
3129         Bencher also includes experimental support for running benchmarks in
3130         a DumpRenderTree release build.  This works in SunSpider and V8, but
3131         not yet in Kraken.  Running benchmarks in DumpRenderTree more
3132         closely mimics the performance when running in browser.
3133
3134         * Scripts/bencher: Added.
3135
3136 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
3137
3138         DumpRenderTree should begin each test with an empty cookie store
3139         https://bugs.webkit.org/show_bug.cgi?id=63545
3140         <rdar://problem/5666907>
3141
3142         Reviewed by Darin Adler.
3143
3144         * DumpRenderTree/mac/DumpRenderTree.mm:
3145         (resetDefaultsToConsistentValues):
3146         (setDefaultsToConsistentValuesForTesting):
3147         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3148         (LayoutTestController::setAlwaysAcceptCookies):
3149         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3150         (WTR::InjectedBundle::beginTesting):
3151         Use new SPIs to manipulate sessions.
3152
3153 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3154
3155         Unreviewed, rolling out r94055 and r94057.
3156         http://trac.webkit.org/changeset/94055
3157         http://trac.webkit.org/changeset/94057
3158         https://bugs.webkit.org/show_bug.cgi?id=67191
3159
3160         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
3161
3162         * Scripts/webkitpy/thirdparty/__init__.py:
3163
3164 2011-08-30  Adam Barth  <abarth@webkit.org>
3165
3166         Chromium Android should not be a core builder
3167         https://bugs.webkit.org/show_bug.cgi?id=67184
3168
3169         Reviewed by Ryosuke Niwa.
3170
3171         This bot hasn't been consistently green yet because it has never actually run!
3172
3173         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3174         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3175
3176 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3177
3178         [WebSocket] update pywebsocket to 0.6b4.
3179         https://bugs.webkit.org/show_bug.cgi?id=66924
3180
3181         Reviewed by Kent Tamura.
3182
3183         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3184         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
3185         0.6b3 or later supports a closing handshake handler and it is useful to
3186         verify client's closing handshake implementation.
3187         0.6b4 supports AbortedByUserException. It is useful to eliminate
3188         unnecessary server warning messages on intended abnormal closures.
3189
3190         * Scripts/webkitpy/thirdparty/__init__.py:
3191         Update download URL and directory path.
3192
3193 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
3194
3195         sheriffbot "usage" help statements are wrong
3196         https://bugs.webkit.org/show_bug.cgi?id=67170
3197
3198         Reviewed by Adam Barth.
3199
3200         * Scripts/webkitpy/tool/bot/irc_command.py:
3201         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3202         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3203
3204 2011-08-29  Adam Barth  <abarth@webkit.org>
3205
3206         Add support for chomium-mac (non-CoreGraphics) baselines
3207         https://bugs.webkit.org/show_bug.cgi?id=67163
3208
3209         Reviewed by Eric Seidel.
3210
3211         This patch teaches the non-CG chromium-mac bots to look at non-CG
3212         baselines.  However, the patch still leaves CG as the default set of
3213         baselines.
3214
3215         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3216         * Scripts/webkitpy/common/config/build.py:
3217         * Scripts/webkitpy/common/config/build_unittest.py:
3218         * Scripts/webkitpy/layout_tests/port/builders.py:
3219         * Scripts/webkitpy/layout_tests/port/chromium.py:
3220         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3221         * Scripts/webkitpy/layout_tests/port/factory.py:
3222         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3223         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3224         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3225         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3226
3227 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
3228
3229         Small fix in chromium port of new-run-webkit-tests.
3230         https://bugs.webkit.org/show_bug.cgi?id=67078
3231
3232         Reviewed by Dirk Pranke.
3233
3234         * Scripts/webkitpy/layout_tests/port/chromium.py:
3235
3236 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3237
3238         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
3239         r93999.
3240         http://trac.webkit.org/changeset/93987
3241         http://trac.webkit.org/changeset/93992
3242         http://trac.webkit.org/changeset/93995
3243         http://trac.webkit.org/changeset/93998
3244         http://trac.webkit.org/changeset/93999
3245         https://bugs.webkit.org/show_bug.cgi?id=67147
3246
3247         Many failing tests (Requested by ap on #webkit).
3248
3249         * DumpRenderTree/mac/DumpRenderTree.mm:
3250         (setDefaultsToConsistentValuesForTesting):
3251         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3252         (WTR::InjectedBundle::beginTesting):
3253
3254 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
3255
3256         DumpRenderTree should begin each test with an empty cookie store
3257         https://bugs.webkit.org/show_bug.cgi?id=63545
3258         <rdar://problem/5666907>
3259
3260         Reviewed by Darin Adler.
3261
3262         * DumpRenderTree/mac/DumpRenderTree.mm:
3263         (setDefaultsToConsistentValuesForTesting):
3264         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3265         (WTR::InjectedBundle::beginTesting):
3266         Tell WebCore to use a temporary session, starting with a clean cookie store.
3267
3268 2011-08-23  Chris Marrin  <cmarrin@apple.com>
3269
3270         [mac] requestAnimationFrame support for mac port
3271         https://bugs.webkit.org/show_bug.cgi?id=59146
3272
3273         Reviewed by Simon Fraser.
3274
3275         Add support for request-animation-callback flag
3276
3277         * Scripts/build-webkit:
3278
3279 2011-08-27  Peter Beverloo  <peter@chromium.org>
3280
3281         Add a build bot for Chromium with OS(ANDROID)
3282         https://bugs.webkit.org/show_bug.cgi?id=66687
3283
3284         Reviewed by Adam Barth.
3285
3286         * BuildSlaveSupport/build.webkit.org-config/config.json:
3287
3288 2011-08-27  Peter Beverloo  <peter@chromium.org>
3289
3290         Update the master build bot configuration script to properly
3291         deal with the --chromium-android switch.
3292         https://bugs.webkit.org/show_bug.cgi?id=66687
3293
3294         The --chromium-android switch is needed when running
3295         update-webkit-chromium and build-webkit, as it'll tell the
3296         scripts to pull in the right dependencies and cross-compile
3297         WebKit using the Android NDK.
3298
3299         Reviewed by Adam Barth.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3302
3303 2011-08-27  Peter Beverloo  <peter@chromium.org>
3304
3305         Teach the update and build scripts how to handle dependencies
3306         and cross-compiling rules for the Chromium port on OS(ANDROID).
3307         https://bugs.webkit.org/show_bug.cgi?id=66687
3308
3309         Reviewed by Adam Barth.
3310
3311         * Scripts/build-webkit:
3312         * Scripts/update-webkit:
3313         * Scripts/update-webkit-chromium:
3314         * Scripts/webkitdirs.pm:
3315         (argumentsForConfiguration):
3316         (isChromium):
3317         (isChromiumAndroid):
3318         (determineIsChromiumAndroid):
3319         (buildChromium):
3320
3321 2011-08-26  Adam Barth  <abarth@webkit.org>
3322
3323         garden-o-matic should let me know that I need to run the local server
3324         https://bugs.webkit.org/show_bug.cgi?id=66985
3325
3326         Reviewed by Dimitri Glazkov.
3327
3328         The patch triggers an alert dialog whenever the user tries to use a
3329         feature that requires the local server.
3330
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3334
3335 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3336
3337         garden-o-matic summary view should have pretty commit data information.
3338         https://bugs.webkit.org/show_bug.cgi?id=67069
3339
3340         Reviewed by Adam Barth.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
3344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
3346
3347 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3348
3349         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
3350         https://bugs.webkit.org/show_bug.cgi?id=67066
3351
3352         Reviewed by Adam Barth.
3353
3354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
3355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3356
3357 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
3358
3359         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
3360         https://bugs.webkit.org/show_bug.cgi?id=67041
3361
3362         Reviewed by Martin Robinson.
3363
3364         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
3365         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
3366         when the GTK+ port was being built.
3367
3368         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3369
3370 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3371
3372         Clean up and line up layout in garden-o-matic summary view.
3373         https://bugs.webkit.org/show_bug.cgi?id=67057
3374
3375         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
3376         2) Rearranged DOM structure a bit to accommodate recent changes;
3377         3) Added minimal CSS to line things up.
3378
3379         Reviewed by Adam Barth.
3380
3381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
3383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
3386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
3388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
3389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3391
3392 2011-08-26  Alice Liu  <alice.liu@apple.com>
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=66823
3395         Add the request info to the WebPageProxy::CreateNewPage message
3396
3397         Reviewed by Anders Carlsson.
3398
3399         Update function declarations with additional parameter:
3400         * MiniBrowser/gtk/BrowserWindow.c:
3401         (createNewPage):
3402         * MiniBrowser/mac/BrowserWindowController.m:
3403         (createNewPage):
3404         * MiniBrowser/win/BrowserView.cpp:
3405         (createNewPage):
3406         * WebKitTestRunner/TestController.cpp:
3407         (WTR::TestController::createOtherPage):
3408         * WebKitTestRunner/TestController.h:
3409
3410 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
3411
3412         Make show-pretty-diff work on linux
3413         https://bugs.webkit.org/show_bug.cgi?id=67017
3414
3415         Reviewed by Adam Barth.
3416
3417         * Scripts/show-pretty-diff:
3418
3419 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3420
3421         Reorganize garden-o-matic CSS files to match JS-built views.
3422         https://bugs.webkit.org/show_bug.cgi?id=66998
3423
3424         Reviewed by Adam Barth.
3425
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3432
3433 2011-08-25  Adam Barth  <abarth@webkit.org>
3434
3435         garden-o-matic should be able to roll out patches
3436         https://bugs.webkit.org/show_bug.cgi?id=66982
3437
3438         Reviewed by Dimitri Glazkov.
3439
3440         This patch just wires the rollout event through the controller to the
3441         local server, which is already set up to perform rollouts.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3447
3448 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3449
3450         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
3451         https://bugs.webkit.org/show_bug.cgi?id=66951
3452
3453         Reviewed by Andreas Kling.
3454
3455         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
3456         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
3457
3458         * MiniBrowser/qt/BrowserView.cpp:
3459         (BrowserView::resizeEvent):
3460
3461 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3462
3463         garden-o-matic summary view should provide information on builders still in flight.
3464         https://bugs.webkit.org/show_bug.cgi?id=66992
3465
3466         Reviewed by Adam Barth.
3467
3468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3473
3474 2011-08-25  Adam Barth  <abarth@webkit.org>
3475
3476         webkit-patch rebaseline-expectations don't work when run outside the root
3477         https://bugs.webkit.org/show_bug.cgi?id=66966
3478
3479         Reviewed by Eric Seidel.
3480
3481         Turns out tool.path() used to be relative, which caused problems when
3482         running webkit-patch outside the root directory.  This patch makes it
3483         absolute.  I checked all callers, and they all appear to want this
3484         behavior.
3485
3486         It was unclear to me how to test this change because we only really
3487         have a testing strategy for webkitpy, not for the main script.
3488
3489         * Scripts/webkit-patch:
3490
3491 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3492
3493         garden-o-matic summary needs a mock view that could be used for working on styling
3494         https://bugs.webkit.org/show_bug.cgi?id=66971
3495
3496         Reviewed by Adam Barth.
3497
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
3500
3501 2011-08-25  Anders Carlsson  <andersca@apple.com>
3502
3503         Return the correct value for NPNVsupportsCarbonBool
3504         https://bugs.webkit.org/show_bug.cgi?id=66964
3505
3506         Add a test.
3507
3508         Reviewed by Adam Roben.
3509
3510         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3511         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
3512         (SupportsCarbonEventModel::SupportsCarbonEventModel):
3513         (SupportsCarbonEventModel::testConvert):
3514         (SupportsCarbonEventModel::runTest):
3515         (SupportsCarbonEventModel::NPP_New):
3516
3517 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3518
3519         garden-o-matic summary view should not be broken.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3522         (table.comparison): Added more specificity.
3523
3524 2011-08-25  Adam Barth  <abarth@webkit.org>
3525
3526         This command has been broken for a while.  This patch updates the
3527         callsite to the new API.
3528
3529         * Scripts/webkitpy/tool/commands/rebaseline.py:
3530
3531 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3532
3533         garden-o-matic needs a way to report where and how tests are failing in the summary view.
3534         https://bugs.webkit.org/show_bug.cgi?id=66955
3535
3536         Introduce FailureGrid, your one-stop failure-indicating destination. 
3537
3538         Reviewed by Adam Barth.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
3541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
3542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
3546
3547 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3548
3549         Add myself to the committers list
3550         https://bugs.webkit.org/show_bug.cgi?id=66941
3551
3552         Reviewed by Andreas Kling.
3553
3554         * Scripts/webkitpy/common/config/committers.py:
3555
3556 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3557
3558         Unreviewed, rolling out r93767.
3559         http://trac.webkit.org/changeset/93767
3560         https://bugs.webkit.org/show_bug.cgi?id=66931
3561
3562         Broke Qt bot. (Requested by yutak on #webkit).
3563
3564         * Scripts/webkitpy/thirdparty/__init__.py:
3565
3566 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
3567
3568         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
3569         https://bugs.webkit.org/show_bug.cgi?id=66924
3570
3571         Reviewed by Kent Tamura.
3572
3573         * Scripts/webkitpy/thirdparty/__init__.py:
3574
3575 2011-08-24  Adam Barth  <abarth@webkit.org>
3576
3577         The user can't close the details view in garden-o-matic
3578         https://bugs.webkit.org/show_bug.cgi?id=66911
3579
3580         Reviewed by Dimitri Glazkov.
3581
3582         In addition to adding a close button, this patch changes the test
3583         selector to use a <select> element and refactors the test selector to
3584         share code with the builder selector.
3585
3586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3590
3591 2011-08-24  James Robinson  <jamesr@chromium.org>
3592
3593         [chromium] Stacktrace not in test output when a test crashes
3594         https://bugs.webkit.org/show_bug.cgi?id=66806
3595
3596         Reviewed by Dirk Pranke.
3597
3598         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
3599         trace.
3600
3601         * Scripts/webkitpy/layout_tests/port/chromium.py:
3602
3603 2011-08-24  Adam Barth  <abarth@webkit.org>
3604
3605         Remove empty directory.
3606
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
3608
3609 2011-08-24  Adam Barth  <abarth@webkit.org>
3610
3611         Finish writing up details-view in garden-o-matic
3612         https://bugs.webkit.org/show_bug.cgi?id=66891
3613
3614         Reviewed by Dimitri Glazkov.
3615
3616         This patch mostly just copies a bunch of CSS from main.css to
3617         summary.css.  Presumably we'll delete main.css soon.
3618
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3624
3625 2011-08-24  James Robinson  <jamesr@chromium.org>
3626
3627         Some compositing LayoutTests flakily crashing on Mac 10.6
3628         https://bugs.webkit.org/show_bug.cgi?id=66740
3629
3630         Reviewed by Adam Barth.
3631
3632         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3633         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3634         chromium configuration.
3635
3636         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3637         (NPP_Destroy):
3638
3639 2011-08-24  Anton D'Auria  <adauria@apple.com>
3640
3641         No review necessary.
3642
3643         Adding myself to list of committers.
3644
3645         * Scripts/webkitpy/common/config/committers.py:
3646
3647 2011-08-24  Avi Drissman  <avi@google.com>
3648
3649         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3650         https://bugs.webkit.org/show_bug.cgi?id=66875
3651
3652         Reviewed by James Robinson.
3653
3654         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3655         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3656
3657 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3658
3659         Make notifications appear in time order again.
3660         https://bugs.webkit.org/show_bug.cgi?id=66815
3661
3662         Reviewed by Adam Barth.
3663