Tools/ChangeLog

   1 2012-02-20  Philippe Normand  <pnormand@igalia.com>
   2
   3         [GTK] FullScreen signals
   4         https://bugs.webkit.org/show_bug.cgi?id=76181
   5
   6         Reviewed by Martin Robinson.
   7
   8         Use the two new entering/leaving fullscreen signals to hide/show
   9         the tool bar, the status bar and ask the user's permission before
  10         entering fullscreen.
  11
  12         * GtkLauncher/main.c:
  13         (webViewFullscreenMessageWindowClose):
  14         (webViewWindowStateEvent):
  15         (hide_widget):
  16         (show_widget):
  17         (webViewEnteringFullScreen):
  18         (webViewLeavingFullScreen):
  19         (createBrowser):
  20         (createWindow):
  21
  22 2012-02-22  Rob Flack  <flackr@chromium.org>
  23
  24         Update Linux ChromiumOS builders in flakiness dashboard.
  25         https://bugs.webkit.org/show_bug.cgi?id=79238
  26
  27         Reviewed by Ojan Vafai.
  28
  29         * TestResultServer/static-dashboards/builders.js:
  30
  31 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
  32
  33         webkitpy: test_function_length_check_definition_huge_lines is slow
  34         https://bugs.webkit.org/show_bug.cgi?id=79185
  35
  36         Reviewed by Adam Barth.
  37
  38         This test takes ~3 seconds to run, apparently because we're
  39         running a test on a 10,000 line function :). Dropping the
  40         function length to 640 still exercises the code path and
  41         provides a 10x speedup.
  42
  43         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  44         (CppStyleTest):
  45         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
  46
  47 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
  48
  49         webkitpy: speed up FileLockTest.test_lock_lifecycle
  50         https://bugs.webkit.org/show_bug.cgi?id=79189
  51
  52         Reviewed by Adam Barth.
  53
  54         The unit test had a second lock trying to acquire a
  55         lock already held, and a hard-coded timeout of one second.
  56         I have changed the timeouts to a tenth of a second (which
  57         is probably still fine) and changed the hard-spin on
  58         the lock to a slow-spin every hundredth of a second.
  59
  60         * Scripts/webkitpy/common/system/file_lock.py:
  61         (FileLock.acquire_lock):
  62         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
  63         (FileLockTest.setUp):
  64         (FileLockTest.test_stuck_lock):
  65
  66 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
  67
  68         build-webkit should use environment variable at number of CPU
  69         detection on all platform
  70         https://bugs.webkit.org/show_bug.cgi?id=79227
  71
  72         Reviewed by Martin Robinson.
  73
  74         * Scripts/webkitdirs.pm:
  75         (determineNumberOfCPUs):
  76
  77 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
  78
  79         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
  80         https://bugs.webkit.org/show_bug.cgi?id=78960
  81
  82         Reviewed by Csaba Osztrogonác.
  83
  84         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  85         (LayoutTestController::overridePreference):
  86
  87 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
  88
  89         [chromium] Build WebKit with MEDIA_STREAM disabled.
  90         https://bugs.webkit.org/show_bug.cgi?id=79214
  91
  92         Reviewed by Kent Tamura.
  93
  94         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  95         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  96         * DumpRenderTree/chromium/WebViewHost.cpp:
  97         (WebViewHost::createMediaPlayer):
  98         * DumpRenderTree/chromium/WebViewHost.h:
  99         (WebViewHost):
 100
 101 2012-02-22  Zeno Albisser  <zeno@webkit.org>
 102
 103         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
 104         https://bugs.webkit.org/show_bug.cgi?id=79124
 105
 106         WebKitTestRunnerPrefix.h should also be included
 107         when building with clang.
 108
 109         Reviewed by Kenneth Rohde Christiansen.
 110
 111         * WebKitTestRunner/Target.pri:
 112
 113 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
 114
 115         <style scoped>: Add runtime-flag
 116         https://bugs.webkit.org/show_bug.cgi?id=79074
 117
 118         Enable the runtime-flag for DRT.
 119
 120         Reviewed by Dimitri Glazkov.
 121
 122         * DumpRenderTree/chromium/TestShell.cpp:
 123         (TestShell::TestShell):
 124
 125 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 126
 127         Unreviewed, rolling out r107351.
 128         http://trac.webkit.org/changeset/107351
 129         https://bugs.webkit.org/show_bug.cgi?id=53600
 130
 131         Several issues introduced in WebKitGTK+ API
 132
 133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 134         (createWebView):
 135         * GtkLauncher/main.c:
 136         (createWebViewCb):
 137         (createBrowser):
 138         (createWindow):
 139         (main):
 140
 141 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
 142
 143         JSC should be a triple-tier VM
 144         https://bugs.webkit.org/show_bug.cgi?id=75812
 145         <rdar://problem/10079694>
 146
 147         Reviewed by Gavin Barraclough.
 148
 149         Changed EFL's build system to include a new directory in JavaScriptCore.
 150
 151         * DumpRenderTree/efl/CMakeLists.txt:
 152
 153 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
 154
 155         [chromium] Fix image drag out on Chromium
 156         https://bugs.webkit.org/show_bug.cgi?id=79158
 157
 158         Reviewed by Tony Chang.
 159
 160         * DumpRenderTree/chromium/EventSender.cpp:
 161         (EventSender::dumpFilenameBeingDragged):
 162         (EventSender::beginDragWithFiles):
 163         * DumpRenderTree/chromium/WebViewHost.cpp:
 164         (addDRTFakeFileToDataObject):
 165
 166 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 167
 168         webkitpy: speed up hot filesystem_mock functions
 169         https://bugs.webkit.org/show_bug.cgi?id=79159
 170
 171         Reviewed by Adam Barth.
 172
 173         Profiling run_webkit_tests_integrationtest.py revealed that
 174         isdir(), normpath(), and join() are called a lot and were very
 175         slow.This patch speeds them up substantially, shaving 20 seconds
 176         off of the execution time.
 177
 178         * Scripts/webkitpy/common/system/filesystem_mock.py:
 179         (MockFileSystem.isdir):
 180         (MockFileSystem._slow_but_correct_join):
 181         (MockFileSystem.join):
 182         (MockFileSystem.listdir):
 183         (MockFileSystem._slow_but_correct_normpath):
 184         (MockFileSystem.normpath):
 185         (MockFileSystem.write_binary_file):
 186         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
 187         (MockFileSystemTest.quick_check):
 188         (MockFileSystemTest):
 189         (MockFileSystemTest.test_join):
 190         (MockFileSystemTest.test_normpath):
 191         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
 192         (get_test_config): Call write_binary_file() instead of updating
 193           filesystem.files directly, so that we create directories as
 194           needed.
 195
 196 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 197
 198         nrwt: make the delay between starting workers configurable per-port
 199         https://bugs.webkit.org/show_bug.cgi?id=79148
 200
 201         Reviewed by Eric Seidel.
 202
 203         Because of bug 79147, we have to sleep a bit in between starting
 204         DRTs; however, doing so across the board slows down the Test
 205         port. Making this configurable shaves 10 seconds off of
 206         run_webkit_tests_integrationtest.py
 207
 208         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 209         (Manager._run_tests):
 210         * Scripts/webkitpy/layout_tests/port/base.py:
 211         (Port.worker_startup_delay_secs):
 212         * Scripts/webkitpy/layout_tests/port/test.py:
 213         (TestPort.worker_startup_delay_secs):
 214
 215 2012-02-21  Jon Lee  <jonlee@apple.com>
 216
 217         Bring notifications support to WK1 mac
 218         https://bugs.webkit.org/show_bug.cgi?id=78783
 219         <rdar://problem/10610578>
 220
 221         Reviewed by Anders Carlsson.
 222
 223         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
 224         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 225         (-[UIDelegate timerFired]):
 226
 227 2012-02-21  Kentaro Hara  <haraken@chromium.org>
 228
 229         Enable the IDL attribute checker in run-bindings-tests
 230         https://bugs.webkit.org/show_bug.cgi?id=79091
 231
 232         Reviewed by Adam Barth.
 233
 234         We have enabled the IDL attribute checker in Chromium in r108322.
 235         This patch enables the IDL attribute checker in run-bindings-tests.
 236
 237         No tests. I manually checked that [Custommm], [CallWith=],
 238         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
 239         run-bindings-tests failures.
 240
 241         * Scripts/webkitpy/bindings/main.py:
 242         (BindingsTests.generate_supplemental_dependency):
 243
 244 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
 245
 246         Add rafaelw as a committer.
 247
 248         Unreviewed.
 249
 250         * Scripts/webkitpy/common/config/committers.py:
 251
 252 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 253
 254         webkitpy: update names after deleting message_broker
 255         https://bugs.webkit.org/show_bug.cgi?id=79000
 256
 257         Reviewed by Eric Seidel.
 258
 259         Part 3 of 3 in deleting message_broker.py; this change just
 260         adjusts the names for the newly merged symbols so that they are
 261         private as appropriate.
 262
 263         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 264         (get):
 265         (_Broker):
 266         (_BrokerConnection):
 267         (_BrokerConnection.__init__):
 268         (AbstractWorker.__init__):
 269         (_ManagerConnection):
 270         (_ManagerConnection.__init__):
 271         (_WorkerConnection):
 272         (_WorkerConnection.__init__):
 273
 274 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 275
 276         webkitpy: merge message_broker.py into manager_worker_broker.py
 277         https://bugs.webkit.org/show_bug.cgi?id=78999
 278
 279         Reviewed by Tony Chang.
 280
 281         This is pretty much a straight cut-and-paste of one file into
 282         another (broken up so that docstrings and imports are in the
 283         right place).
 284
 285         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 286         (BrokerClient):
 287         (BrokerClient.is_done):
 288         (BrokerClient.name):
 289         (Broker):
 290         (Broker.__init__):
 291         (Broker.add_topic):
 292         (Broker._get_queue_for_topic):
 293         (Broker.post_message):
 294         (Broker.run_message_loop):
 295         (Broker.run_all_pending):
 296         (Broker._run_loop):
 297         (Broker._dispatch_message):
 298         (_Message):
 299         (_Message.loads):
 300         (_Message.__init__):
 301         (_Message.dumps):
 302         (_Message.__repr__):
 303         (BrokerConnection):
 304         (BrokerConnection.__init__):
 305         (BrokerConnection.run_message_loop):
 306         (BrokerConnection.post_message):
 307         (BrokerConnection.raise_exception):
 308         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
 309
 310 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 311
 312         webkitpy: prepare to delete message_broker.py
 313         https://bugs.webkit.org/show_bug.cgi?id=78997
 314
 315         Reviewed by Eric Seidel.
 316
 317         This is part 1 of 3 changes to fix bug 78187. This change
 318         prepares the code for merging message_broker.py into
 319         manager_worker_broker.py; the tests in message_broker_unittest
 320         are merged into manager_worker_broker_unittest, the symbols
 321         needed by the tests are exported from manager_worker_broker.py,
 322         and manager_worker_broker itself is updated to refer to the
 323         symbols directly (without the module prefix).
 324
 325         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 326         (get):
 327         (AbstractWorker):
 328         (AbstractWorker.__init__):
 329         (_ManagerConnection):
 330         (_ManagerConnection.__init__):
 331         (_WorkerConnection):
 332         (_WorkerConnection.__init__):
 333         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 334         (InterfaceTest.test_brokerclient_is_abstract):
 335         (InterfaceTest.test_brokerclient_is_abstract.methods):
 336         (MessageTest):
 337         (MessageTest.test__no_body):
 338         (MessageTest.test__body):
 339         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
 340
 341 2012-02-21  Sam Weinig  <sam@webkit.org>
 342
 343         Attempt to fix the Snow Leopard build.
 344
 345         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 346         * MiniBrowser/Configurations/Base.xcconfig:
 347         * TestWebKitAPI/Configurations/Base.xcconfig:
 348         * WebKitTestRunner/Configurations/Base.xcconfig:
 349
 350 2012-02-21  Sam Weinig  <sam@webkit.org>
 351
 352         Use libc++ when building with Clang on Mac
 353         https://bugs.webkit.org/show_bug.cgi?id=78981
 354
 355         Reviewed by Dan Bernstein.
 356
 357         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 358         * MiniBrowser/Configurations/Base.xcconfig:
 359         * TestWebKitAPI/Configurations/Base.xcconfig:
 360         * WebKitTestRunner/Configurations/Base.xcconfig:
 361
 362 2012-02-21  Adam Roben  <aroben@apple.com>
 363
 364         Roll out r108309, r108323, and r108326
 365
 366         They broke the 32-bit Lion build.
 367
 368         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
 369
 370         * DumpRenderTree/efl/CMakeLists.txt:
 371
 372 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
 373
 374         [Qt][WK2] Get rid of the dependency to QtWidgets
 375         https://bugs.webkit.org/show_bug.cgi?id=76276
 376
 377         Reviewed by Simon Hausmann.
 378
 379         * MiniBrowser/qt/MiniBrowser.pro:
 380         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 381         (MiniBrowserApplication::MiniBrowserApplication):
 382         (MiniBrowserApplication::notify):
 383         (MiniBrowserApplication::sendTouchEvent):
 384         * MiniBrowser/qt/MiniBrowserApplication.h:
 385         (MiniBrowserApplication):
 386         * QtTestBrowser/locationedit.h:
 387         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 388         (WTR::activateFonts):
 389         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 390
 391 2012-02-20  Adam Barth  <abarth@webkit.org>
 392
 393         mastercfg_unittest.py fails without simplejson
 394         https://bugs.webkit.org/show_bug.cgi?id=79070
 395
 396         Reviewed by Csaba Osztrogonác.
 397
 398         Now that we require Python 2.6 (and higher) we can import json rather
 399         than simplejson.  We still need to use the simplejson name because
 400         that's what the master.cfg script expects.
 401
 402         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 403         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
 404
 405 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
 406
 407         JSC should be a triple-tier VM
 408         https://bugs.webkit.org/show_bug.cgi?id=75812
 409         <rdar://problem/10079694>
 410
 411         Reviewed by Gavin Barraclough.
 412
 413         Changed EFL's build system to include a new directory in JavaScriptCore.
 414
 415         * DumpRenderTree/efl/CMakeLists.txt:
 416
 417 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
 418
 419         Update pywebsocket to 0.7.2
 420         https://bugs.webkit.org/show_bug.cgi?id=79066
 421
 422         This version includes vendor-prefixed deflate-frame extension support.
 423
 424         Reviewed by Kent Tamura.
 425
 426         * Scripts/webkitpy/thirdparty/__init__.py:
 427         (AutoinstallImportHook._install_pywebsocket):
 428
 429 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 430
 431         [UNIX] Plugin information fields are not interpreted as UTF-8
 432         https://bugs.webkit.org/show_bug.cgi?id=78635
 433
 434         Reviewed by Gustavo Noronha Silva.
 435
 436         Interpret plugin metadata as UTF8 aways. This matches the behavior
 437         of Chromium and the Totem plugin.
 438
 439         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 440         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
 441
 442 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 443
 444         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
 445         https://bugs.webkit.org/show_bug.cgi?id=78935
 446
 447         Reviewed by Gustavo Noronha Silva.
 448
 449         Move the TestNetscapePlugin headers to a more appropriate directory and update
 450         the build files to match.
 451
 452         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
 453         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
 454         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
 455         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
 456         * GNUmakefile.am: Ditto.
 457
 458 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
 459
 460         Add a new API for the Vibration API(W3C).
 461         https://bugs.webkit.org/show_bug.cgi?id=72010
 462
 463         Reviewed by Hajime Morita.
 464
 465         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
 466
 467 2012-02-20  János Badics  <dicska@gmail.com>
 468
 469         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
 470         https://bugs.webkit.org/show_bug.cgi?id=71816
 471
 472         RunQtAPITests will notify if a timeout occurs during testing.
 473         Added unittest to the master.cfg
 474
 475         Reviewed by Csaba Osztrogonác.
 476
 477         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 478         (RunQtAPITests.evaluateCommand):
 479         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 480         (RunQtAPITestsTest):
 481         (RunQtAPITestsTest.assertResults):
 482         (RunQtAPITestsTest.test_timeout):
 483         (test_success):
 484         (test_failure):
 485         (test_timeout_and_failure):
 486
 487 2012-02-20  Andy Wingo  <wingo@igalia.com>
 488
 489         Add wingo as a committer.
 490
 491         Unreviewed.
 492
 493         * Scripts/webkitpy/common/config/committers.py: Add myself to the
 494         committers list.
 495
 496 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
 497
 498         [chromium] check that we're not running multiple modal dialogs at the same time
 499         https://bugs.webkit.org/show_bug.cgi?id=78486
 500
 501         Reviewed by Kent Tamura.
 502
 503         * DumpRenderTree/chromium/TestShell.cpp:
 504         (TestShell::TestShell):
 505         * DumpRenderTree/chromium/TestShell.h:
 506         (TestShell::setIsDisplayingModalDialog):
 507         (TestShell::isDisplayingModalDialog):
 508         (TestShell):
 509         * DumpRenderTree/chromium/WebViewHost.cpp:
 510         (WebViewHost::runModal):
 511
 512 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 513
 514         Fix WebKit2GTK+ for 'make distcheck'.
 515
 516         Instead of conditionally including WebKit2 GNUmakefiles, always
 517         include them and conditionally activate the final targets.
 518
 519         * MiniBrowser/gtk/GNUmakefile.am:
 520         * WebKitTestRunner/GNUmakefile.am:
 521
 522 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 523
 524         Enable video option for EFL port in build-webkit.
 525         https://bugs.webkit.org/show_bug.cgi?id=79006
 526
 527         Reviewed by Daniel Bates.
 528
 529         * Scripts/build-webkit:
 530
 531 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
 532
 533         [EFL] Use modifier keys to execute pre-rendering.
 534         https://bugs.webkit.org/show_bug.cgi?id=77933
 535
 536         Reviewed by Chang Shu.
 537
 538         Use modifier key to execute pre-rendering instead of using reserved function keys.
 539
 540         * EWebLauncher/main.c:
 541         (on_key_down):
 542
 543 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
 544
 545         Fix one more dangling reference to worker_connection.name, delete unused code.
 546
 547         Unreviewed, build fix.
 548
 549         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 550         (Manager.update):
 551         (_WorkerState.__init__):
 552
 553 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
 554
 555         Add a change that should've been in r108005.
 556
 557         Unreviewed, build fix.
 558
 559         In the refactoring/cleanup in r108005 I should've changed the
 560         implementation of WorkerConnection to make it match BrokerClient
 561         (and everything else) so that objects had a name() method
 562         instead of a name property.
 563
 564         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 565         (Manager._run_tests):
 566         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 567         (_WorkerConnection.__init__):
 568         (_WorkerConnection.name):
 569         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 570         (_TestWorker.__init__):
 571         (_TestsMixin.name):
 572         (_TestsMixin.test_name):
 573         (_TestsMixin.test_cancel):
 574         (_TestsMixin.test_unknown_message):
 575
 576 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
 577
 578         webkitpy: remove webkitpy.common.array_stream
 579         https://bugs.webkit.org/show_bug.cgi?id=78952
 580
 581         Reviewed by Eric Seidel.
 582
 583         Turns out array_stream didn't really do anything that StringIO
 584         didn't do (at least as of Python 2.6). This change removes it
 585         and updates all of the callers. Where possible, I changed the
 586         test assertions in order to capture the intent more clearly,
 587         e.g., instead of calling self.assertTrue('foo' in stream.get()),
 588         we have self.assertContainsLine(stream, 'foo'), and instead of
 589         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
 590         the latter isn't that much more readable, but StringIO doesn't
 591         export an empty() method.
 592
 593         * Scripts/webkitpy/common/array_stream.py: Removed.
 594         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
 595         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 596         (passing_run):
 597         (run_and_capture):
 598         (StreamTestingMixin):
 599         (StreamTestingMixin.assertContains):
 600         (StreamTestingMixin.assertContainsLine):
 601         (StreamTestingMixin.assertEmpty):
 602         (StreamTestingMixin.assertNotEmpty):
 603         (LintTest):
 604         (LintTest.test_lint_test_files):
 605         (LintTest.test_lint_test_files__errors):
 606         (MainTest):
 607         (MainTest.test_child_process_1):
 608         (MainTest.test_child_processes_2):
 609         (MainTest.test_child_processes_min):
 610         (MainTest.test_help_printing):
 611         (MainTest.test_hung_thread):
 612         (MainTest.test_no_tests_found):
 613         (MainTest.test_no_tests_found_2):
 614         (MainTest.test_repeat_each_iterations_num_tests):
 615         (MainTest.test_test_list):
 616         (MainTest.test_unexpected_failures):
 617         (MainTest.test_worker_model__inline_with_child_processes):
 618         (MainTest.test_additional_platform_directory):
 619         (RebaselineTest):
 620         (RebaselineTest.assertBaselines):
 621         (RebaselineTest.test_reset_results):
 622         (RebaselineTest.test_missing_results):
 623         (RebaselineTest.test_new_baseline):
 624         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
 625         (MeteredStream.update):
 626         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
 627         (TestMeteredStream.test_regular):
 628         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
 629         (TestUtilityFunctions.assertEmpty):
 630         (TestUtilityFunctions):
 631         (TestUtilityFunctions.assertNotEmpty):
 632         (TestUtilityFunctions.assertWritten):
 633         (TestUtilityFunctions.test_configure_logging):
 634         (Testprinter.assertEmpty):
 635         (Testprinter):
 636         (Testprinter.assertNotEmpty):
 637         (Testprinter.assertWritten):
 638         (Testprinter.reset):
 639         (Testprinter.get_printer):
 640         (Testprinter.test_help_printer):
 641         (Testprinter.do_switch_tests.do_helper):
 642         (Testprinter.test_print_one_line_summary):
 643         (Testprinter.test_print_test_result):
 644         (Testprinter.test_print_progress):
 645         (Testprinter.test_write_nothing):
 646         (Testprinter.test_write_misc):
 647         (Testprinter.test_write_everything):
 648         (Testprinter.test_write_verbose):
 649         (Testprinter.test_print_unexpected_results):
 650         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
 651         (MainTest.assertWritten):
 652         (create_runner):
 653         (test_run_test_set):
 654         (test_run_test_set_kills_drt_per_run):
 655         (test_run_test_set_for_parser_tests):
 656         (test_run_test_set_with_json_output):
 657         (test_run_test_set_with_json_source):
 658         (test_run_test_set_with_multiple_repositories):
 659         (test_upload_json):
 660
 661 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
 662
 663         [wx] Add the WebCore/page/scrolling directory to the build dirs.
 664
 665         * waf/build/settings.py:
 666
 667 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
 668
 669         [wx] Unreviewed build fix. Don't error out or hang if we have
 670         downloaded dependencies but server update check fails.
 671
 672         * waf/build/build_utils.py:
 673         (download_if_newer):
 674
 675 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
 676
 677         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
 678         https://bugs.webkit.org/show_bug.cgi?id=69444
 679
 680         Reviewed by Tony Chang.
 681
 682         Currently if a test's image checksum doesn't match the checksum
 683         in the baseline, but the images themselves match according to
 684         ImageDiff, new-run-webkit-tests ignores the problem. This is
 685         probably bad, but it's not yet clear what the right thing to do
 686         is. This patch will log a warning to stderr, at least (but the
 687         test will still pass).
 688
 689         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 690         (SingleTestRunner._compare_image):
 691         (SingleTestRunner._run_reftest):
 692         * Scripts/webkitpy/layout_tests/port/test.py:
 693         (unit_test_list):
 694         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 695
 696 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
 697
 698         NRWT does not report failure for a skipped test
 699         https://bugs.webkit.org/show_bug.cgi?id=78750
 700
 701         Reviewed by Eric Seidel.
 702
 703         If a test is listed in a Skipped file and you run it anyway
 704         with --force, and the test fails, currently NRWT will print
 705         "test ran as expected"; this is confusing, because you probably
 706         expect the test to fail and yet this might lead you to think the
 707         test passed. This patch changes the expected behavior to "PASS",
 708         so tests that fail will be reported.
 709
 710         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 711         (result_was_expected):
 712         (TestExpectationParser):
 713         (TestExpectationParser.expectation_for_skipped_test):
 714         (TestExpectations):
 715         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
 716         (test_add_skipped_tests):
 717         * Scripts/webkitpy/layout_tests/port/test.py:
 718         (unit_test_list): Add some tests that are expected to be in a Skipped file.
 719         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
 720
 721 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
 722
 723         webkitpy: fix test code after bug 78181
 724         https://bugs.webkit.org/show_bug.cgi?id=78870
 725
 726         Reviewed by Adam Barth.
 727
 728         I forgot to update the test code as per Tony's suggestion in
 729         bug 78181 (r108005). This change does that, and in doing so
 730         it revealed a subtle bug in _InlineWorkerConnection.run() that
 731         I am fixing as part of this (_alive would not be cleared if an
 732         exception was thrown).
 733
 734         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 735         (_InlineWorkerConnection.run):
 736         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 737         (_TestWorker.__init__):
 738         (_TestWorker.handle_stop):
 739         (_TestWorker.handle_test):
 740         (_TestWorker.run):
 741         (_TestsMixin.handle_exception):
 742         (_TestsMixin.test_unknown_message):
 743
 744 2012-02-17  Adam Roben  <aroben@apple.com>
 745
 746         Mac build fix after r108119
 747
 748         * DumpRenderTree/mac/DumpRenderTree.mm:
 749         (runThread):
 750         (runPthread):
 751         (testThreadIdentifierMap):
 752         Updated to match current WTF threading APIs.
 753
 754 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
 755
 756         revert r107147 - breaks webkit-patch on Mac SL
 757         https://bugs.webkit.org/show_bug.cgi?id=78866
 758
 759         Reviewed by Adam Barth.
 760
 761         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
 762         which is the version that ships on Mac SL. Reverting this
 763         change until we no longer have to worry about that version.
 764
 765         * Scripts/webkitpy/common/system/autoinstall.py:
 766         (AutoInstaller):
 767         (AutoInstaller._extract_all): Added a comment about SL.
 768         (AutoInstaller._unzip):
 769
 770 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
 771
 772         CSS regions enabled by default
 773         https://bugs.webkit.org/show_bug.cgi?id=78525
 774
 775         Reviewed by David Hyatt.
 776
 777         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
 778         CSSRegions are still enabled by default.
 779         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
 780
 781         * DumpRenderTree/chromium/LayoutTestController.cpp:
 782         (LayoutTestController::overridePreference):
 783         * DumpRenderTree/chromium/WebPreferences.cpp:
 784         (WebPreferences::reset):
 785         (WebPreferences::applyTo):
 786         * DumpRenderTree/chromium/WebPreferences.h:
 787         (WebPreferences):
 788         * DumpRenderTree/mac/DumpRenderTree.mm:
 789         (resetDefaultsToConsistentValues):
 790
 791 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
 792
 793         Some API tests erroneously use = instead of == (causing build failures)
 794         https://bugs.webkit.org/show_bug.cgi?id=78915
 795
 796         Reviewed by Sam Weinig.
 797
 798         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
 799         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
 800         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
 801
 802 2012-02-17  Peter Beverloo  <peter@chromium.org>
 803
 804         [Chromium] Include TestShellLinux.cpp in the build for Android
 805         https://bugs.webkit.org/show_bug.cgi?id=78865
 806
 807         Reviewed by Eric Seidel.
 808
 809         Android will be re-using the TestShellLinux.cpp file. I already
 810         added this r104033, but it seems to have gotten lost in the
 811         recent refactorings.
 812
 813         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
 814
 815 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 816
 817         Unreviewed, disable video build on EFL until it can be
 818         supported by EFL build bot.
 819
 820         * Scripts/build-webkit:
 821
 822 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
 823
 824         [GTK] Implement zoom in/out in MiniBrowser
 825         https://bugs.webkit.org/show_bug.cgi?id=75253
 826
 827         Reviewed by Gustavo Noronha Silva.
 828
 829         * MiniBrowser/gtk/BrowserWindow.c:
 830         (browserWindowCanZoomIn):
 831         (browserWindowCanZoomOut):
 832         (browserWindowUpdateZoomActions):
 833         (webViewZoomLevelChanged):
 834         (zoomInCallback):
 835         (zoomOutCallback):
 836         (browser_window_init):
 837         (browserWindowConstructed):
 838
 839 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
 840
 841         layoutTestController.display() is flaky for SVG tests
 842         https://bugs.webkit.org/show_bug.cgi?id=78021
 843
 844         Reviewed by Adam Roben.
 845
 846         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
 847         Size the web view before running the test, not when dumping.
 848         All platforms handle this correctly now.
 849
 850         * DumpRenderTree/win/DumpRenderTree.cpp:
 851         (dump):
 852         (sizeWebViewForCurrentTest):
 853         (runTest):
 854
 855 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 856
 857         [GTK] Make install is broken when building without --enable-gtk-doc
 858         https://bugs.webkit.org/show_bug.cgi?id=78828
 859
 860         Reviewed by Martin Robinson.
 861
 862         * gtk/generate-gtkdoc:
 863         (rebase_installed_docs): Check documentation has been generated
 864         before trying to rebase it.
 865
 866 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
 867
 868         nrwt: simplify worker interface
 869         https://bugs.webkit.org/show_bug.cgi?id=78181
 870
 871         Reviewed by Tony Chang.
 872
 873         This change moves code in name(), is_done(), run(), and cancel()
 874         from Worker to AbstractWorker, since the logic is pretty much
 875         boilerplate code that any implementation would want to use.
 876
 877         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 878         (get.should):
 879         (AbstractWorker.__init__):
 880         (AbstractWorker):
 881         (AbstractWorker.name):
 882         (AbstractWorker.stop_handling_messages):
 883         (AbstractWorker.run):
 884         (AbstractWorker.is_done):
 885         (AbstractWorker.cancel):
 886         * Scripts/webkitpy/layout_tests/controllers/worker.py:
 887         (Worker.__init__):
 888         (Worker.run):
 889         (Worker.handle_stop):
 890
 891 2012-02-16  Michael Saboff  <msaboff@apple.com>
 892
 893         ENH: Add ability to run subset of JavaScript layout tests with JSC
 894         https://bugs.webkit.org/show_bug.cgi?id=78764
 895
 896         Reviewed by Gavin Barraclough.
 897
 898         New simple test drive shell script that runs a defined
 899         list of javascript tests using jsc and the standalone-{pre,post}.js
 900         wrappers.
 901
 902         * Scripts/run-fast-jsc: Added.
 903
 904 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
 905
 906         Add new Qt performance tester bot to build.webkit.org
 907         https://bugs.webkit.org/show_bug.cgi?id=78795
 908
 909         Reviewed by Adam Roben.
 910
 911         * BuildSlaveSupport/build.webkit.org-config/config.json:
 912
 913 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
 914
 915         Disable inspector on WinCE.
 916
 917         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
 918
 919         * Scripts/build-webkit:
 920
 921 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
 922
 923         WinCE build fix after r107656.
 924
 925         Disable FTPDIR on WinCE, since it does not compile there.
 926
 927         * Scripts/build-webkit:
 928
 929 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
 930
 931         Build fix after r107863.
 932
 933         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
 934
 935 2012-02-15  Tony Chang  <tony@chromium.org>
 936
 937         [chromium] add linux dbg back to garden-o-matic
 938         https://bugs.webkit.org/show_bug.cgi?id=78752
 939
 940         Reviewed by Adam Barth.
 941
 942         This reflects the current linux debug bot name (there's only one bot).
 943         I'm also remove the mac clang builder since it doesn't exist (mac
 944         always uses clang now).
 945
 946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 947         * Scripts/webkitpy/layout_tests/port/builders.py:
 948
 949 2012-02-15  Sam Weinig  <sam@webkit.org>
 950
 951         Add style check for ctype functions that are generally frowned upon in WebKit
 952         https://bugs.webkit.org/show_bug.cgi?id=78748
 953
 954         Reviewed by Anders Carlsson.
 955
 956         Not every platform has DisallowCType.h to check for uses of the ctype.h
 957         functions, so add a style check for them as well.
 958
 959         * Scripts/webkitpy/style/checkers/cpp.py:
 960         (check_ctype_functions):
 961         (check_style):
 962         (CppChecker):
 963         Add check.
 964
 965         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 966         (WebKitStyleTest.test_ctype_fucntion):
 967         Add checker.
 968
 969 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
 970
 971         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
 972         https://bugs.webkit.org/show_bug.cgi?id=76546
 973
 974         Reviewed by Simon Hausmann.
 975
 976         Resize the web view programatically because the declarative property binding
 977         does not work. Seems like our qml environment is not initialized fully but it
 978         needs more investigation.
 979
 980         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 981         (WTR::WrapperWindow::handleStatusChanged):
 982         (WTR::PlatformWebView::resizeTo):
 983
 984 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
 985
 986         webkitpy: add a worker_args concept to start_worker()
 987         https://bugs.webkit.org/show_bug.cgi?id=78572
 988
 989         Reviewed by Tony Chang.
 990
 991         This change replaces the three NRWT-specific arguments passed
 992         through the broker to the worker with a generic WorkerArguments
 993         wrapper class and a separate set_inline_arguments() call that can
 994         be used to pass additional data to the worker when it is running
 995         in the same process as the manager (this is needed for testing).
 996         With the addition of set_inline_arguments() we also no longer
 997         need to pass an optional argument to the worker.run() call.
 998
 999         Note that this method is *only* implemented on inline workers,
1000         so calling this on a regular (child process) worker will result
1001         in a runtime error.
1002
1003         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1004         (Manager._run_tests):
1005         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1006         (AbstractWorker.__init__):
1007         (AbstractWorker.run):
1008         (_ManagerConnection.start_worker):
1009         (_InlineManager.start_worker):
1010         (_InlineManager.set_inline_arguments):
1011         (_InlineManager.run_message_loop):
1012         (_MultiProcessManager.start_worker): Reworked signature.
1013         (_WorkerConnection.__init__):
1014         (_InlineWorkerConnection.__init__):
1015         (_InlineWorkerConnection.set_inline_arguments): New method.
1016         (_InlineWorkerConnection):
1017         (_InlineWorkerConnection.run):
1018         (_Process.run):
1019         (_MultiProcessWorkerConnection.__init__):
1020         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1021         (_TestWorker.__init__):
1022         (_TestWorker.set_inline_arguments):
1023         (_TestWorker.handle_test):
1024         (_TestWorker.run):
1025         (_TestsMixin.test_cancel):
1026         (_TestsMixin.test_done):
1027         (_TestsMixin.test_unknown_message):
1028         (InlineBrokerTests): New class for more testing.
1029         (InlineBrokerTests.setUp):
1030         (InlineBrokerTests.test_inline_arguments): New test.
1031         (InterfaceTest.test_managerconnection_is_abstract):
1032         (InterfaceTest.test_workerconnection_is_abstract):
1033         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1034         (WorkerArguments):
1035         (WorkerArguments.__init__):
1036         (Worker.__init__):
1037         (Worker.set_inline_arguments):
1038         (Worker):
1039         (Worker.run):
1040         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1041         (WorkerTest.test_default_platform_in_worker):
1042
1043 2012-02-15  Adam Klein  <adamk@chromium.org>
1044
1045         Unreviewed, rolling out r107704.
1046         http://trac.webkit.org/changeset/107704
1047         https://bugs.webkit.org/show_bug.cgi?id=78486
1048
1049         Caused layout test crashes in debug builds.
1050
1051         Specific crashing tests:
1052
1053         fast/events/show-modal-dialog-onblur-onfocus.html
1054         fast/harness/show-modal-dialog.html
1055         inspector/console/console-long-eval-crash.html
1056
1057         * DumpRenderTree/chromium/TestShell.cpp:
1058         (TestShell::TestShell):
1059         * DumpRenderTree/chromium/TestShell.h:
1060         (TestShell):
1061         * DumpRenderTree/chromium/WebViewHost.cpp:
1062         (WebViewHost::runModal):
1063
1064 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1065
1066         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1067         https://bugs.webkit.org/show_bug.cgi?id=76347
1068
1069         Reviewed by Kenneth Rohde Christiansen.
1070
1071         * MiniBrowser/qt/MiniBrowser.qrc:
1072         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
1073         * MiniBrowser/qt/qml/BrowserWindow.qml:
1074         * MiniBrowser/qt/qml/DialogLineInput.qml:
1075
1076 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1077
1078         [Qt] Fix WebGL in QtTestBrowser
1079
1080         Reviewed by Tor Arne Vestbø.
1081
1082         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1083         the options for enabling GL we also pass them on properly.
1084
1085 2012-02-14  Sam Weinig  <sam@webkit.org>
1086
1087         Add #include of unistd.h on the mac for getcwd.
1088
1089         Reviewed by Anders Carlsson.
1090
1091         This is necessary when building with libc++.
1092
1093         * WebKitTestRunner/TestInvocation.cpp:
1094
1095 2012-02-14  Sam Weinig  <sam@webkit.org>
1096
1097         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1098         https://bugs.webkit.org/show_bug.cgi?id=78663
1099
1100         Reviewed by Anders Carlsson.
1101
1102         * DumpRenderTree/DumpRenderTreePrefix.h:
1103         * DumpRenderTree/cg/ImageDiffCG.cpp:
1104
1105 2012-02-14  Adam Barth  <abarth@webkit.org>
1106
1107         Implement an adb-based driver for the ChromiumAndroidPort
1108         https://bugs.webkit.org/show_bug.cgi?id=78627
1109
1110         Reviewed by Eric Seidel.
1111
1112         This driver mostly just wires up the ChromiumDriver through adb.  In
1113         some cases, it translates protocol elements, such as URIs, so that the
1114         rest of webkitpy is insulated from the "remoteness" of the target device.
1115
1116         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1117         (ChromiumAndroidPort.start_helper):
1118         (ChromiumAndroidPort._driver_class):
1119         (ChromiumAndroidPort._update_version):
1120         (ChromiumAndroidPort._get_stderr):
1121         (ChromiumAndroidPort):
1122         (ChromiumAndroidPort._get_last_stacktrace):
1123         (ChromiumAndroidPort._teardown_performance):
1124         (ChromiumAndroidDriver):
1125         (ChromiumAndroidDriver.__init__):
1126         (ChromiumAndroidDriver._start):
1127         (ChromiumAndroidDriver.run_test):
1128         (ChromiumAndroidDriver.stop):
1129         (ChromiumAndroidDriver._test_shell_command):
1130         (ChromiumAndroidDriver._write_command_and_read_line):
1131         (ChromiumAndroidDriver._output_image):
1132         (ChromiumAndroidDriver._has_crash_hint):
1133
1134 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1135
1136         webkitpy: the real_name() method in the Port class is no longer needed
1137         https://bugs.webkit.org/show_bug.cgi?id=78651
1138
1139         Reviewed by Eric Seidel.
1140
1141         The change in bug 78565 / r107718 made it no longer necessary
1142         (we can use options.platform instead).
1143
1144         * Scripts/webkitpy/layout_tests/port/base.py:
1145         (Port.name):
1146         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1147         (MockDRTPort.__init__):
1148
1149 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1150
1151         webkitpy: clean up options, port handling in manager_worker_broker
1152         https://bugs.webkit.org/show_bug.cgi?id=78568
1153
1154         Reviewed by Tony Chang.
1155
1156         manager_worker_broker no longer needs options or port objects
1157         directly, so we make them only be passed in start_worker().
1158
1159         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1160         (Manager._run_tests):
1161         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1162         (get):
1163         (_ManagerConnection.__init__):
1164         (_ManagerConnection.start_worker):
1165         (_InlineManager.__init__):
1166         (_InlineManager.start_worker):
1167         (_InlineManager.run_message_loop):
1168         (_MultiProcessManager.__init__):
1169         (_MultiProcessManager):
1170         (_MultiProcessManager.start_worker):
1171         (_InlineWorkerConnection.__init__):
1172         (_InlineWorkerConnection.run):
1173         (_Process.__init__):
1174         (_MultiProcessWorkerConnection.__init__):
1175         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1176         (make_broker):
1177         (_TestWorker.run):
1178         (_TestsMixin.test_cancel):
1179         (_TestsMixin.test_done):
1180         (_TestsMixin.test_unknown_message):
1181         (MultiProcessBrokerTests.setUp):
1182         (InterfaceTest.test_managerconnection_is_abstract):
1183         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1184         (Broker.__init__):
1185
1186 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1187
1188         nrwt: add a unit test for regression introduced in bug 78565
1189         https://bugs.webkit.org/show_bug.cgi?id=78646
1190
1191         Reviewed by Tony Chang.
1192
1193         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1194         (FakeConnection):
1195         (FakeConnection.run_message_loop):
1196         (FakeConnection.post_message):
1197         (WorkerTest):
1198         (WorkerTest.test_default_platform_in_worker):
1199
1200 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1201
1202         NRWT is broken for the default port
1203         https://bugs.webkit.org/show_bug.cgi?id=78640
1204
1205         Reviewed by Tony Chang.
1206
1207         The change in r107718 (bug 78565) broke NRWT if you didn't
1208         specify any sort of --platform flag or equivalent. I didn't
1209         catch this because it's a full integration test (which we don't
1210         have an automated test for) and I missed this command line
1211         variant when testing interactively.
1212
1213         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1214         (Worker.run):
1215
1216 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1217
1218         Last character display for passwords in Android.
1219         https://bugs.webkit.org/show_bug.cgi?id=78532
1220
1221         Reviewed by Adam Barth.
1222
1223         * DumpRenderTree/chromium/WebPreferences.cpp:
1224         (WebPreferences::applyTo):
1225
1226 2012-02-14  Adam Barth  <abarth@webkit.org>
1227
1228         Finish implementing start_helper for ChromiumAndroidPort
1229         https://bugs.webkit.org/show_bug.cgi?id=78582
1230
1231         Reviewed by Eric Seidel.
1232
1233         This patch contains the remaining odds and ends for the start_helper function.
1234
1235         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1236         (ChromiumAndroidPort.start_helper):
1237         (ChromiumAndroidPort._synchronize_datetime):
1238         (ChromiumAndroidPort):
1239         (ChromiumAndroidPort._check_version):
1240         (ChromiumAndroidPort._run_adb_command):
1241         (ChromiumAndroidPort._copy_device_file):
1242
1243 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1244
1245         webkitpy: create ports in Workers, not in manager_worker_broker
1246         https://bugs.webkit.org/show_bug.cgi?id=78565
1247
1248         Reviewed by Tony Chang.
1249
1250         We will now create the Port object (if necessary) in the Worker
1251         directly, so that the manager_worker_broker module doesn't need
1252         all of this layout_test-specific logic. Part of the fixes for
1253         bug 78171.
1254
1255         These changes are all well-tested by the existing tests in
1256         run_webkit_tests_integrationtest.py.
1257
1258         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1259         (_Process.run):
1260         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1261         (Worker.__init__):
1262         (Worker.safe_init):
1263         (Worker.run):
1264         (Worker.cleanup):
1265         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1266         (parse_args):
1267         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1268
1269 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1270
1271         [chromium] check that we're not running multiple modal dialogs at the same time
1272         https://bugs.webkit.org/show_bug.cgi?id=78486
1273
1274         Reviewed by Kent Tamura.
1275
1276         * DumpRenderTree/chromium/TestShell.cpp:
1277         (TestShell::TestShell):
1278         * DumpRenderTree/chromium/TestShell.h:
1279         (TestShell::setIsDisplayingModalDialog):
1280         (TestShell::isDisplayingModalDialog):
1281         (TestShell):
1282         * DumpRenderTree/chromium/WebViewHost.cpp:
1283         (WebViewHost::runModal):
1284
1285 2012-02-14  Adam Barth  <abarth@webkit.org>
1286
1287         Enable the GPU codepath in the chromium-android port
1288         https://bugs.webkit.org/show_bug.cgi?id=78580
1289
1290         Reviewed by James Robinson.
1291
1292         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1293         Android always uses the GPU codepath, so we set the GPU flags on the
1294         main chromium-android port instead.
1295
1296         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1297         (ChromiumAndroidPort.__init__):
1298
1299 2012-02-14  Adam Barth  <abarth@webkit.org>
1300
1301         NRWT should expose --adb-args flag for Android
1302         https://bugs.webkit.org/show_bug.cgi?id=78579
1303
1304         Reviewed by Eric Seidel.
1305
1306         This flag is already wired up to the ChromiumAndroidPort.
1307
1308         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1309         (parse_args):
1310
1311 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1312
1313         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1314         https://bugs.webkit.org/show_bug.cgi?id=78541
1315         <rdar://problem/10036695>
1316
1317         Reviewed by Kent Tamura.
1318
1319         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1320         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1321         After each test, reset to using new protocol.
1322
1323 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1324
1325         Convert svg/animations to use SMIL methods for driving the timeline
1326         https://bugs.webkit.org/show_bug.cgi?id=78422
1327
1328         Reviewed by Dirk Schulze.
1329
1330         Remove no longer needed SVG specific animation sampling functionality from DRT.
1331         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1332
1333         * DumpRenderTree/LayoutTestController.cpp:
1334         (LayoutTestController::staticFunctions):
1335         * DumpRenderTree/LayoutTestController.h:
1336         (LayoutTestController):
1337         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1338         * DumpRenderTree/chromium/LayoutTestController.cpp:
1339         (LayoutTestController::LayoutTestController):
1340         * DumpRenderTree/chromium/LayoutTestController.h:
1341         (LayoutTestController):
1342         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1343         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1344         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1345         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1346         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1347         (LayoutTestController):
1348         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1349         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1350
1351 2012-02-13  Rob Flack  <flackr@chromium.org>
1352
1353         Add Linux ChromiumOS test results to flakiness dashboard.
1354         https://bugs.webkit.org/show_bug.cgi?id=78495
1355
1356         Reviewed by Ojan Vafai.
1357
1358         * TestResultServer/static-dashboards/builders.js:
1359         * TestResultServer/static-dashboards/dashboard_base.js:
1360
1361 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1362
1363         [GTK] Mutation Observers build is broken
1364         https://bugs.webkit.org/show_bug.cgi?id=78433
1365
1366         Reviewed by Martin Robinson.
1367
1368         Enabled mutation observers as a default feature for GTK port, too.
1369
1370         * Scripts/build-webkit:
1371
1372 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1373
1374         Allow to configure ENABLE_FTPDIR in build-webkit
1375         https://bugs.webkit.org/show_bug.cgi?id=65098
1376
1377         Reviewed by Eric Seidel.
1378
1379         Allow to disable ENABLE_FTPDIR by command line.
1380         Remove ENABLE_FTPDIR from --minimal build
1381
1382         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1383         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1384         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1385
1386 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1387
1388         Add shinyak as committer.
1389
1390         Unreviewed.
1391
1392         * Scripts/webkitpy/common/config/committers.py:
1393
1394 2012-02-13  Adam Barth  <abarth@webkit.org>
1395
1396         Implement start/stop_helper for ChromiumAndroidPort
1397         https://bugs.webkit.org/show_bug.cgi?id=78558
1398
1399         Reviewed by Dirk Pranke.
1400
1401         These functions (and their dependencies) set up the Android device for
1402         testing.
1403
1404         This patch also includes a few tweaks on the previous patch recommended
1405         by dpranke.
1406
1407         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1408         (ChromiumAndroidPort.__init__):
1409         (ChromiumAndroidPort.start_helper):
1410         (ChromiumAndroidPort.stop_helper):
1411         (ChromiumAndroidPort._shut_down_http_server):
1412         (ChromiumAndroidPort):
1413         (ChromiumAndroidPort._push_executable):
1414         (ChromiumAndroidPort._push_fonts):
1415         (ChromiumAndroidPort._restore_system_font):
1416         (ChromiumAndroidPort._push_test_resources):
1417         (ChromiumAndroidPort._push_to_device):
1418         (ChromiumAndroidPort._pull_from_device):
1419         (ChromiumAndroidPort._kill_device_process):
1420         (ChromiumAndroidPort._setup_performance):
1421         (ChromiumAndroidPort._teardown_performance):
1422         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1423         (ChromiumAndroidPortTest):
1424         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1425         (PortTestCase):
1426         (PortTestCase.make_port):
1427         (PortTestCase.test_default_worker_model):
1428
1429 2012-02-13  Adam Barth  <abarth@webkit.org>
1430
1431         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1432         https://bugs.webkit.org/show_bug.cgi?id=78550
1433
1434         Reviewed by Eric Seidel.
1435
1436         Much of this code just forwards to the "host" port, which seems like a
1437         reasonable thing to do.
1438
1439         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1440         (ChromiumAndroidPort.__init__):
1441         (ChromiumAndroidPort.stop_helper):
1442         (ChromiumAndroidPort):
1443         (ChromiumAndroidPort._build_path):
1444         (ChromiumAndroidPort._path_to_apache):
1445         (ChromiumAndroidPort._path_to_apache_config_file):
1446         (ChromiumAndroidPort._path_to_driver):
1447         (ChromiumAndroidPort._path_to_helper):
1448         (ChromiumAndroidPort._path_to_image_diff):
1449         (ChromiumAndroidPort._path_to_lighttpd):
1450         (ChromiumAndroidPort._path_to_lighttpd_modules):
1451         (ChromiumAndroidPort._path_to_lighttpd_php):
1452         (ChromiumAndroidPort._path_to_wdiff):
1453         (ChromiumAndroidPort._shut_down_http_server):
1454         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1455         (ChromiumAndroidPortTest):
1456         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1457         (PortTestCase):
1458         (PortTestCase.make_port):
1459         (PortTestCase.test_default_worker_model):
1460
1461 2012-02-13  Adam Barth  <abarth@webkit.org>
1462
1463         chromium_android.py should implement "virtual" methods from ChromiumPort
1464         https://bugs.webkit.org/show_bug.cgi?id=78545
1465
1466         Reviewed by Dirk Pranke.
1467
1468         This patch adds basic implementations that specialize a bunch of
1469         functions from ChromiumPort.
1470
1471         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1472         (ChromiumAndroidPort):
1473         (ChromiumAndroidPort.__init__):
1474         (ChromiumAndroidPort.default_child_processes):
1475         (ChromiumAndroidPort.baseline_search_path):
1476         (ChromiumAndroidPort.check_build):
1477         (ChromiumAndroidPort.check_sys_deps):
1478         (ChromiumAndroidPort.default_worker_model):
1479         (ChromiumAndroidPort.test_expectations):
1480         (ChromiumAndroidPort.start_http_server):
1481         (ChromiumAndroidPort.stop_http_server):
1482         (ChromiumAndroidPort.start_helper):
1483         (ChromiumAndroidPort.stop_helper):
1484
1485 2012-02-13  Adam Barth  <abarth@webkit.org>
1486
1487         Add a skeleton ChromiumAndroid port to webkitpy
1488         https://bugs.webkit.org/show_bug.cgi?id=78543
1489
1490         Reviewed by Eric Seidel.
1491
1492         This patch just adds an empty ChromiumAndroid port object to webkitpy
1493         and wires it up to the factory objects.  An actual implementation will
1494         follow.
1495
1496         * Scripts/webkitpy/layout_tests/port/chromium.py:
1497         (ChromiumPort):
1498         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1499         (ChromiumAndroidPort):
1500         (ChromiumAndroidPort.__init__):
1501         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1502         (ChromiumPortTest.test_all_test_configurations):
1503         * Scripts/webkitpy/layout_tests/port/factory.py:
1504         (PortFactory):
1505
1506 2012-02-13  Adam Barth  <abarth@webkit.org>
1507
1508         NRWT's HTTP servers should support additional directories for resources
1509         https://bugs.webkit.org/show_bug.cgi?id=78528
1510
1511         Reviewed by Eric Seidel.
1512
1513         This functionality will be used by the Chromium-Android port.
1514
1515         * Scripts/webkitpy/layout_tests/port/base.py:
1516         (Port.to.start_http_server):
1517         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1518         (LayoutTestApacheHttpd.__init__):
1519         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1520         (Lighttpd.__init__):
1521         (Lighttpd._prepare_config):
1522
1523 2012-02-13  Ami Fischman  <fischman@chromium.org>
1524
1525         Add fischman as committer.
1526
1527         Unreviewed
1528
1529         * Scripts/webkitpy/common/config/committers.py:
1530
1531 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1532
1533         [EFL] Drop support for the Curl network backend.
1534         https://bugs.webkit.org/show_bug.cgi?id=77874
1535
1536         Reviewed by Eric Seidel.
1537
1538         Nobody seems to be maintaining the Curl backend in WebCore, the
1539         EFL port developers all seem to be using the Soup backend and the
1540         port itself has many features which are only implemented for the
1541         latter.
1542
1543         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
1544         and always add the required include directories.
1545         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
1546         include directories and link to them.
1547
1548 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
1549
1550         [WebSocket] Update pywebsocket to 0.7.1
1551         https://bugs.webkit.org/show_bug.cgi?id=78484
1552
1553         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
1554
1555         Reviewed by Kent Tamura.
1556
1557         * Scripts/webkitpy/thirdparty/__init__.py:
1558         (AutoinstallImportHook._install_pywebsocket):
1559
1560 2012-02-12  Kangil Han  <kangil.han@samsung.com>
1561
1562         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
1563         https://bugs.webkit.org/show_bug.cgi?id=78091
1564
1565         Reviewed by Hajime Morita.
1566
1567         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
1568         This patch will activate around 1,900 test cases from skipped list in EFL port.
1569
1570         * DumpRenderTree/efl/EventSender.cpp:
1571         (textZoom):
1572         (pageZoom):
1573         (textZoomInCallback):
1574         (textZoomOutCallback):
1575         (zoomPageInCallback):
1576         (zoomPageOutCallback):
1577
1578 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
1579
1580         KeywordLookupGenerator.py script fails in some cases
1581         https://bugs.webkit.org/show_bug.cgi?id=77886
1582
1583         Reviewed by Benjamin Poulain.
1584
1585         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
1586         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
1587         (GlobalVariablesTest.test_path_rules_specifier):
1588
1589 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1590
1591         Add toText and isTextNode helpers in Text class.
1592         https://bugs.webkit.org/show_bug.cgi?id=78140
1593
1594         Unit test case for the new style checker introduced.
1595
1596         Reviewed by Adam Barth.
1597
1598         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1599         (CppStyleTest):
1600         (CppStyleTest.test_static_cast_readability): Added a unit test case.
1601
1602 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1603
1604         Enable features supported by EFL port in build-webkit.
1605         https://bugs.webkit.org/show_bug.cgi?id=78348
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         Sync build-webkit with OptionEfl.cmake, as some features enabled in
1610         OptionEfl.cmake are not enabled in build-webkit.
1611
1612         * Scripts/build-webkit:
1613
1614 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1615
1616         Add toText and isTextNode helpers in Text class.
1617         https://bugs.webkit.org/show_bug.cgi?id=78140
1618
1619         Added a style checker to use toText rather than static_cast<Text*>.
1620
1621         Reviewed by Adam Barth.
1622
1623         * Scripts/webkitpy/style/checkers/cpp.py:
1624         (check_language): Style checker for static_cast<Text*>.
1625
1626 2012-02-12  Philippe Normand  <pnormand@igalia.com>
1627
1628         Unreviewed, disable Mutation observers build on GTK until it can
1629         actually build.
1630
1631         * Scripts/build-webkit:
1632
1633 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
1634
1635         Add back WTFURL to WebKit
1636         https://bugs.webkit.org/show_bug.cgi?id=77291
1637
1638         Reviewed by Adam Barth.
1639
1640         Add a flag to build-webkit to easily build WebKit with WTFURL.
1641
1642         * Scripts/build-webkit:
1643
1644 2012-02-10  Adam Klein  <adamk@chromium.org>
1645
1646         Enable MUTATION_OBSERVERS by default on all platforms
1647         https://bugs.webkit.org/show_bug.cgi?id=78196
1648
1649         Reviewed by Ojan Vafai.
1650
1651         * Scripts/build-webkit:
1652
1653 2012-02-10  Adam Barth  <abarth@webkit.org>
1654
1655         Move garden-o-matic's All Failures out of experimental
1656         https://bugs.webkit.org/show_bug.cgi?id=78395
1657
1658         Reviewed by Dimitri Glazkov.
1659
1660         Several folks have tried this feature and found it useful.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1663
1664 2012-02-10  Tim Horton  <timothy_horton@apple.com>
1665
1666         NRWT should categorize options in --help
1667         https://bugs.webkit.org/show_bug.cgi?id=76221
1668
1669         Reviewed by Eric Seidel.
1670
1671         Use optparse's OptionGroup mechanism to logically group NRWT's options,
1672         providing a better experience when scanning all the options.
1673
1674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1675         (parse_args):
1676
1677 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1678
1679         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1680         https://bugs.webkit.org/show_bug.cgi?id=77450
1681
1682         Reviewed by Csaba Osztrogonác.
1683
1684         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1685         to qt-5.0-wk2 and qt-5.0-wk1.
1686
1687         * Scripts/old-run-webkit-tests:
1688         (buildPlatformResultHierarchy):
1689         (readSkippedFiles):
1690         * Scripts/webkitpy/layout_tests/port/qt.py:
1691         (QtPort._wk2_port_name):
1692         (QtPort._skipped_file_search_paths):
1693         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1694         (QtPortTest.test_baseline_search_path):
1695         * Scripts/webkitpy/layout_tests/port/webkit.py:
1696         (WebKitPort._wk2_port_name):
1697
1698 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1699
1700         [GTK] EWS command-line option to run the tests
1701         https://bugs.webkit.org/show_bug.cgi?id=78211
1702
1703         Reviewed by Adam Barth.
1704
1705         New --run-tests option (defaults to False) for the EWS commands.
1706
1707         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1708         (AbstractEarlyWarningSystem):
1709         (AbstractEarlyWarningSystem.__init__):
1710         (AbstractEarlyWarningSystem.review_patch):
1711         (ChromiumLinuxEWS):
1712         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1713         (EarlyWarningSytemTest._test_builder_ews):
1714
1715 2012-02-09  Eric Seidel  <eric@webkit.org>
1716
1717         Rename compare_text and compare_audio to make it clear that they're !=
1718         https://bugs.webkit.org/show_bug.cgi?id=78301
1719
1720         Reviewed by Adam Barth.
1721
1722         I also removed the maybe_create_directory function which was redundant.
1723
1724         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1725         (Manager.set_up_run):
1726         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1727         (TestResultWriter._make_output_directory):
1728         * Scripts/webkitpy/layout_tests/port/base.py:
1729         (Port.do_text_results_differ):
1730         (Port.do_audio_results_differ):
1731         (Port.diff_text):
1732         (Port.driver_name):
1733         (Port.skips_perf_test):
1734         * Scripts/webkitpy/layout_tests/port/win.py:
1735         (WinPort.do_text_results_differ):
1736         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1737         (WinPortTest.test_do_text_results_differ):
1738         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1739         (LayoutTestApacheHttpd.__init__):
1740         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1741         (HttpServerBase.__init__):
1742         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1743         (Rebaseliner._diff_baselines):
1744
1745 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1746
1747         [GTK] Add DRT support for modal dialogs
1748         https://bugs.webkit.org/show_bug.cgi?id=53600
1749
1750         Reviewed by Martin Robinson.
1751
1752         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1753         Most significantly, when creating a new web view in GtkLauncher, the window
1754         of the web view opener is passed around. In DumpRenderTree, the window of
1755         the main web view is always considered as the opener. This is required so
1756         the modal dialog's toplevel can be made transient for the opener's toplevel.
1757
1758         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1759         (webViewRunModalDialog):
1760         (createWebView):
1761         * GtkLauncher/main.c:
1762         (createWebViewCb):
1763         (runModalDialogCb):
1764         (createBrowser):
1765         (createWindow):
1766         (main):
1767
1768 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1769
1770         [Gtk] security/set-form-autocomplete-attribute.html fails
1771         https://bugs.webkit.org/show_bug.cgi?id=78261
1772
1773         Reviewed by Martin Robinson.
1774
1775         Use the new helper in DumpRenderTreeSupportGtk to properly
1776         test whether an element performs autocompletion.
1777
1778         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1779         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1780
1781 2012-02-09  James Robinson  <jamesr@chromium.org>
1782
1783         [chromium] Enable mock scrollbars for compositing layout tests
1784         https://bugs.webkit.org/show_bug.cgi?id=78299
1785
1786         Reviewed by Dirk Pranke.
1787
1788         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1789         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1790         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1791
1792         * DumpRenderTree/chromium/TestShell.cpp:
1793         (TestShell::runFileTest):
1794         * DumpRenderTree/chromium/WebPreferences.cpp:
1795         (WebPreferences::reset):
1796         (WebPreferences::applyTo):
1797         * DumpRenderTree/chromium/WebPreferences.h:
1798         (WebPreferences):
1799
1800 2012-02-09  Eric Seidel  <eric@webkit.org>
1801
1802         Remove more uses of "os" from our webkitpy code
1803         https://bugs.webkit.org/show_bug.cgi?id=78292
1804
1805         Reviewed by Adam Barth.
1806
1807         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1808         (MockCheckout.__init__):
1809         (MockCheckout.is_path_to_changelog):
1810         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1811         * Scripts/webkitpy/common/system/filesystem_mock.py:
1812         (MockFileSystem._split):
1813         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1814         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1815         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1816         * Scripts/webkitpy/layout_tests/port/webkit.py:
1817         * Scripts/webkitpy/tool/bot/queueengine.py:
1818         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1819         * Scripts/webkitpy/tool/commands/download.py:
1820         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1821         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1822         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1823         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1824         * Scripts/webkitpy/tool/commands/upload.py:
1825         (CreateBug.prompt_for_bug_title_and_comment):
1826         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1827         * Scripts/webkitpy/tool/steps/attachtobug.py:
1828         (AttachToBug.run):
1829         * Scripts/webkitpy/tool/steps/checkstyle.py:
1830         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1831         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1832         * Scripts/webkitpy/tool/steps/editchangelog.py:
1833         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1834         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1835         (PrepareChangeLogTest.test_ensure_bug_url):
1836         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1837         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1838         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1839         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1840
1841 2012-02-09  Eric Seidel  <eric@webkit.org>
1842
1843         Remove the cr-mac-ews (it's long been dead)
1844         https://bugs.webkit.org/show_bug.cgi?id=78267
1845
1846         Reviewed by Adam Barth.
1847
1848         * QueueStatusServer/model/queues.py:
1849         (Queue):
1850         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1851         (ChromiumWindowsEWS):
1852         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1853         (EarlyWarningSytemTest._test_builder_ews):
1854         (EarlyWarningSytemTest._test_testing_ews):
1855
1856 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1857
1858         some tests in webkitpy are being run three times
1859         https://bugs.webkit.org/show_bug.cgi?id=78283
1860
1861         Reviewed by Ryosuke Niwa.
1862
1863         It turns out that if you import a class derived from
1864         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1865         the unittest framework treats it as if the class was defined in
1866         the file (as well in the original file). This led us to running
1867         the tests in ChangeLogTest three times.
1868
1869         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1870         (PrepareChangeLogTest):
1871         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1872         (_assert_message_for_revert_output):
1873
1874 2012-02-09  Adam Barth  <abarth@webkit.org>
1875
1876         Remove extraneous line in previous patch.  I forgot to remove this
1877         before landing.
1878
1879         * Scripts/webkitpy/layout_tests/port/driver.py:
1880         (DriverProxy.start):
1881
1882 2012-02-09  Adam Barth  <abarth@webkit.org>
1883
1884         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1885         https://bugs.webkit.org/show_bug.cgi?id=78271
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         This lets me attach instruments to profile the performance of the test.
1890
1891         * Scripts/webkitpy/layout_tests/port/chromium.py:
1892         (ChromiumDriver.start):
1893         * Scripts/webkitpy/layout_tests/port/driver.py:
1894         (Driver.start):
1895         (DriverProxy.start):
1896         * Scripts/webkitpy/layout_tests/port/server_process.py:
1897         (ServerProcess.start):
1898         * Scripts/webkitpy/layout_tests/port/test.py:
1899         (TestDriver.start):
1900         * Scripts/webkitpy/layout_tests/port/webkit.py:
1901         (WebKitDriver.start):
1902         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1903         (get_tests_run.RecordingTestDriver.start):
1904         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1905         (PerfTestsRunner._parse_args):
1906         (PerfTestsRunner._run_tests_set):
1907         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1908         (start):
1909         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1910         (test_run_test_set_kills_drt_per_run):
1911         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1912         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1913
1914 2012-02-09  Adam Barth  <abarth@webkit.org>
1915
1916         run-perf-tests --chromium should run the chromium port
1917         https://bugs.webkit.org/show_bug.cgi?id=78266
1918
1919         Reviewed by Ryosuke Niwa.
1920
1921         This patch makes run-perf-tests work more like run-webkit-tests.
1922
1923         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1924         (PerfTestsRunner._parse_args):
1925
1926 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1927
1928         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1929         https://bugs.webkit.org/show_bug.cgi?id=77466
1930
1931         Reviewed by Dirk Pranke.
1932
1933         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1934         is set or if we should raise an error. A unit test was added.
1935
1936         * Scripts/webkitpy/layout_tests/port/qt.py:
1937         (QtPort.operating_system):
1938         (QtPort):
1939         (QtPort.check_sys_deps):
1940         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1941         (QtPortTest.test_operating_system):
1942         (QtPortTest):
1943         (QtPortTest.test_check_sys_deps):
1944
1945 2012-02-09  Eric Seidel  <eric@webkit.org>
1946
1947         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1948         https://bugs.webkit.org/show_bug.cgi?id=78263
1949
1950         Reviewed by Adam Barth.
1951
1952         * Scripts/webkitpy/common/config/ports.py:
1953         (DeprecatedPort):
1954         (DeprecatedPort.name):
1955         (DeprecatedPort.flag):
1956         (DeprecatedPort.script_path):
1957         (DeprecatedPort.script_shell_command):
1958         (DeprecatedPort.port):
1959         (DeprecatedPort.makeArgs):
1960         (DeprecatedPort.update_webkit_command):
1961         (DeprecatedPort.check_webkit_style_command):
1962         (DeprecatedPort.prepare_changelog_command):
1963         (DeprecatedPort.build_webkit_command):
1964         (DeprecatedPort.run_javascriptcore_tests_command):
1965         (DeprecatedPort.run_webkit_unit_tests_command):
1966         (DeprecatedPort.run_webkit_tests_command):
1967         (DeprecatedPort.run_python_unittests_command):
1968         (DeprecatedPort.run_perl_unittests_command):
1969         (DeprecatedPort.layout_tests_results_path):
1970         (MacPort):
1971         (WinPort):
1972         (GtkPort):
1973         (GtkPort.build_webkit_command):
1974         (GtkPort.run_webkit_tests_command):
1975         (QtPort):
1976         (QtPort.build_webkit_command):
1977         (EflPort):
1978         (EflPort.build_webkit_command):
1979         (ChromiumPort):
1980         (ChromiumPort.update_webkit_command):
1981         (ChromiumPort.build_webkit_command):
1982         (ChromiumPort.run_webkit_tests_command):
1983         (ChromiumPort.run_javascriptcore_tests_command):
1984         (ChromiumXVFBPort):
1985         (ChromiumXVFBPort.run_webkit_tests_command):
1986         * Scripts/webkitpy/common/config/ports_unittest.py:
1987         (DeprecatedPortTest):
1988         (DeprecatedPortTest.test_mac_port):
1989         (DeprecatedPortTest.test_gtk_port):
1990         (DeprecatedPortTest.test_qt_port):
1991         (DeprecatedPortTest.test_chromium_port):
1992         (DeprecatedPortTest.test_chromium_xvfb_port):
1993         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1994         (AbstractEarlyWarningSystem.__init__):
1995         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1996         * Scripts/webkitpy/tool/main.py:
1997         (WebKitPatch):
1998         (WebKitPatch.handle_global_options):
1999         * Scripts/webkitpy/tool/steps/abstractstep.py:
2000         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2001         (StepsTest.test_runtests_args):
2002
2003 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2004
2005         [chromium] always initialize makeArgs in buildChromiumNinja
2006         https://bugs.webkit.org/show_bug.cgi?id=78231
2007
2008         Reviewed by Tony Gentilcore.
2009
2010         * Scripts/webkitdirs.pm:
2011         (buildChromiumNinja):
2012
2013 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2014
2015         [GTK] Show url of current hovered link in MiniBrowser
2016         https://bugs.webkit.org/show_bug.cgi?id=78098
2017
2018         Reviewed by Martin Robinson.
2019
2020         * MiniBrowser/gtk/BrowserWindow.c:
2021         (webViewMouseTargetChanged): Check whether hit test result is a
2022         link and use the url to update the status bar text.
2023         (browserWindowConstructed): Connect to
2024         WebKitWebView::mouse-target-changed signal.
2025
2026 2012-02-09  Rob Buis  <rbuis@rim.com>
2027
2028         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2029         https://bugs.webkit.org/show_bug.cgi?id=78042
2030
2031         Reviewed by Antonio Gomes.
2032
2033         Upstream final part of our DRT implementation.
2034
2035         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2036         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2037         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2038         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2039         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2040
2041 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2042
2043         kill-old-processes should kill gcc and clang
2044         https://bugs.webkit.org/show_bug.cgi?id=78189
2045
2046         Reviewed by Eric Seidel.
2047
2048         Added a bunch of processes names of gcc and clang to the list.
2049
2050         * BuildSlaveSupport/kill-old-processes:
2051
2052 2012-02-07  MORITA Hajime  <morrita@google.com>
2053
2054         Replacement text should be available from the marker.
2055         https://bugs.webkit.org/show_bug.cgi?id=77934
2056
2057         Made the mock requestCheckingOfText() implementation to return
2058         a replacement text for each misspelled word if available.
2059
2060         Reviewed by Kent Tamura.
2061
2062         * DumpRenderTree/chromium/WebViewHost.cpp:
2063         (WebViewHost::finishLastTextCheck):
2064
2065 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2066
2067         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2068         https://bugs.webkit.org/show_bug.cgi?id=78146
2069
2070         Reviewed by Ryosuke Niwa.
2071
2072         Our DumpRenderTree should support --no-timeout and --timeout options in order
2073         to be able to use run-perf-tests and have a Performance Bot.
2074         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2075         and the necessary code to handle such command line arguments to our DumpRenderTree.
2076
2077         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2078         (WebCore::DumpRenderTree::setTimeout):
2079         (WebCore):
2080         (WebCore::DumpRenderTree::setShouldTimeout):
2081         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2082         (DumpRenderTree):
2083         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2084         (LayoutTestController::LayoutTestController):
2085         (LayoutTestController::waitUntilDone):
2086         (LayoutTestController::notifyDone):
2087         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2088         (LayoutTestController::setTimeout):
2089         (LayoutTestController::setShouldTimeout):
2090         (LayoutTestController):
2091         * DumpRenderTree/qt/main.cpp:
2092         (isOption):
2093         (printUsage):
2094         (main):
2095
2096 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2097
2098         Rubber-stamped by Martin Robinson.
2099
2100         * gtk/common.py:
2101         (get_build_path): Move test for current directory being a valid
2102         directory up so it takes precedence over WebKitBuild/Release and
2103         WebKitBuild/Debug when they exist as well.
2104
2105 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2106
2107         [GTK] doc rebasing does not respect DESTDIR
2108         https://bugs.webkit.org/show_bug.cgi?id=78177
2109
2110         Reviewed by Martin Robinson.
2111
2112         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2113         calling it for rebasing.
2114         * gtk/generate-gtkdoc:
2115         (get_common_options): Handle the new --virtual-root option.
2116         * gtk/gtkdoc.py:
2117         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2118         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2119
2120 2012-02-08  Adam Barth  <abarth@webkit.org>
2121
2122         Remove Python 2.5 support from WebKit
2123         https://bugs.webkit.org/show_bug.cgi?id=71593
2124
2125         Reviewed by Eric Seidel.
2126
2127         This is the last vestige of our Python 2.5 support.
2128
2129         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2130         (AbstractQueueTest.test_log_from_script_error_for_upload):
2131
2132 2012-02-08  Adam Barth  <abarth@webkit.org>
2133
2134         version_check.py should inform users that we don't support Python 2.5 anymore
2135         https://bugs.webkit.org/show_bug.cgi?id=78179
2136
2137         Reviewed by Eric Seidel.
2138
2139         We don't support Python 2.5 anymore.
2140
2141         * Scripts/webkitpy/common/version_check.py:
2142
2143 2012-02-08  Adam Barth  <abarth@webkit.org>
2144
2145         test_configuration.py shouldn't re-implement itertools
2146         https://bugs.webkit.org/show_bug.cgi?id=78178
2147
2148         Reviewed by Eric Seidel.
2149
2150         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2151         (TestConfigurationConverter.to_specifiers_list):
2152         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2153         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2154         (TestConfigurationConverter):
2155
2156 2012-02-08  Adam Barth  <abarth@webkit.org>
2157
2158         webkitpy should reply upon the multiprocessing package existing
2159         https://bugs.webkit.org/show_bug.cgi?id=78176
2160
2161         Reviewed by Eric Seidel.
2162
2163         Now that we don't support Python 2.5, this import can't fail.
2164
2165         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2166         (get):
2167         (_Process):
2168         (_Process.__init__):
2169         (_Process.run):
2170         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2171         (FunctionTests.test_get__processes):
2172         (MultiProcessBrokerTests.setUp):
2173         * Scripts/webkitpy/layout_tests/port/base.py:
2174         (Port.__init__):
2175         (Port.default_worker_model):
2176         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2177         (ChromiumMacPort.check_build):
2178         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2179         (PortTestCase.test_default_worker_model):
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2181
2182 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2183
2184         Unreviewed typo fix that makes docs build again for the gtk2-based
2185         library.
2186
2187         * gtk/generate-gtkdoc:
2188
2189 2012-02-08  Adam Barth  <abarth@webkit.org>
2190
2191         Don't re-implement ZipFile.extractall
2192         https://bugs.webkit.org/show_bug.cgi?id=78173
2193
2194         Reviewed by Eric Seidel.
2195
2196         We can use ZipFile.extractall now that we don't support Python 2.5.
2197
2198         * Scripts/webkitpy/common/system/autoinstall.py:
2199         (AutoInstaller._extract_targz):
2200         (AutoInstaller._unzip):
2201
2202 2012-02-08  Adam Barth  <abarth@webkit.org>
2203
2204         Remove the ospath compat shim from webkitpy
2205         https://bugs.webkit.org/show_bug.cgi?id=78170
2206
2207         Reviewed by Eric Seidel.
2208
2209         We no longer need this compat shim now that we don't support Python 2.5.
2210
2211         * Scripts/webkitpy/common/checkout/scm/git.py:
2212         * Scripts/webkitpy/common/checkout/scm/svn.py:
2213         * Scripts/webkitpy/common/system/filesystem.py:
2214         (FileSystem.relpath):
2215         * Scripts/webkitpy/common/system/filesystem_mock.py:
2216         (MockFileSystem.relpath):
2217         * Scripts/webkitpy/common/system/ospath.py: Removed.
2218         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2219
2220 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2221
2222         Build fix attempt after r107053.
2223
2224         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2225         (test_collect_tests):
2226
2227 2012-02-08  Adam Barth  <abarth@webkit.org>
2228
2229         Remove simplejson because it's no longer used by webkitpy
2230         https://bugs.webkit.org/show_bug.cgi?id=78164
2231
2232         Reviewed by Eric Seidel.
2233
2234         All the importers of this code were removed in a previous patch.
2235
2236         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2237         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2238         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2239         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2240         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2241         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2242         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2243         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2244         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2245         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2246         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2247
2248 2012-02-08  Adam Barth  <abarth@webkit.org>
2249
2250         webkitpy still imports simplejson
2251         https://bugs.webkit.org/show_bug.cgi?id=78161
2252
2253         Reviewed by Eric Seidel.
2254
2255         We no longer support Python 2.5, so we can rely upon Python's built-in
2256         JSON package.
2257
2258         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2259         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2260         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2262         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2263         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2264         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2265         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2266         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2267         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2268         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2269
2270 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2271
2272         [GTK] Fails to build docs with non-standard build directories
2273         https://bugs.webkit.org/show_bug.cgi?id=78118
2274
2275         * gtk/common.py:
2276         (get_build_path): add comment to document changes done in r107098,
2277         as requested by the reviewer and forgotten by me.
2278
2279 2012-02-08  Adam Barth  <abarth@webkit.org>
2280
2281         Stop importing with_statement from the mysterious future
2282         https://bugs.webkit.org/show_bug.cgi?id=78156
2283
2284         Reviewed by Eric Seidel.
2285
2286         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2287         is no longer the __future__.)
2288
2289         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2290         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2291         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2292         * Scripts/webkitpy/common/net/credentials_unittest.py:
2293         * Scripts/webkitpy/common/net/file_uploader.py:
2294         * Scripts/webkitpy/common/newstringio_unittest.py:
2295         * Scripts/webkitpy/common/system/autoinstall.py:
2296         * Scripts/webkitpy/common/system/crashlogs.py:
2297         * Scripts/webkitpy/common/system/fileset.py:
2298         * Scripts/webkitpy/common/system/filesystem.py:
2299         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2300         * Scripts/webkitpy/common/system/path.py:
2301         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2302         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2303         * Scripts/webkitpy/layout_tests/port/base.py:
2304         (of):
2305         * Scripts/webkitpy/layout_tests/port/gtk.py:
2306         * Scripts/webkitpy/layout_tests/port/test.py:
2307         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2308         * Scripts/webkitpy/style/filereader_unittest.py:
2309         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2310         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2311         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2312         * Scripts/webkitpy/tool/commands/queues.py:
2313         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2314         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2315
2316 2012-02-08  Rob Buis  <rbuis@rim.com>
2317
2318         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2319         https://bugs.webkit.org/show_bug.cgi?id=78042
2320
2321         Reviewed by Antonio Gomes.
2322
2323         Upstream more parts of our DRT implementation.
2324
2325         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2326         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2327         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2328         * DumpRenderTree/blackberry/EventSender.h: Added.
2329         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2330         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2331
2332 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2333
2334         check-webkit-style failing with "Path does not exist."
2335         https://bugs.webkit.org/show_bug.cgi?id=77873
2336
2337         Reviewed by Ojan Vafai.
2338
2339         This change fixes the way the style checker determines which
2340         Port class to use for a given test_expectations.txt path; the
2341         previous version used a heuristic that didn't really work in the
2342         first place.
2343
2344         * Scripts/webkitpy/style/checkers/test_expectations.py:
2345         (TestExpectationsChecker._determine_port_from_expectations_path):
2346         (TestExpectationsChecker.__init__):
2347         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2348         (TestExpectationsTestCase._expect_port_for_expectations_path):
2349         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2350
2351 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2352
2353         nrwt: make --skip-pixel-test-if-no-baseline option
2354         https://bugs.webkit.org/show_bug.cgi?id=70484
2355
2356         Reviewed by Dirk Pranke.
2357
2358         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2359         (SingleTestRunner.__init__):
2360         (SingleTestRunner._should_fetch_expected_checksum):
2361         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2362         (Worker.handle_test_list):
2363         * Scripts/webkitpy/layout_tests/models/test_input.py:
2364         (TestInput.__init__):
2365         * Scripts/webkitpy/layout_tests/port/webkit.py:
2366         (WebKitDriver.cmd_line):
2367         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2368         (_set_up_derived_options):
2369         (parse_args):
2370         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2371         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2372         * WebKitTestRunner/TestController.cpp:
2373         (WTR::TestController::TestController):
2374         (WTR::TestController::initialize):
2375         (WTR::TestController::runTest):
2376         * WebKitTestRunner/TestController.h:
2377         (TestController):
2378         * WebKitTestRunner/TestInvocation.cpp:
2379         (WTR::TestInvocation::TestInvocation):
2380         (WTR::TestInvocation::setIsPixelTest):
2381         * WebKitTestRunner/TestInvocation.h:
2382         (WTR::TestInvocation::setSkipPixelTestOption):
2383         (TestInvocation):
2384
2385 2012-02-08  Rob Buis  <rbuis@rim.com>
2386
2387         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2388         https://bugs.webkit.org/show_bug.cgi?id=78042
2389
2390         Reviewed by Antonio Gomes.
2391
2392         Add implementation for our DumpRenderTree solution.
2393
2394         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2395         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2396
2397 2012-02-08  Antti Koivisto  <antti@apple.com>
2398
2399         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2400         https://bugs.webkit.org/show_bug.cgi?id=78080
2401
2402         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2403
2404         Add API test.
2405
2406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2407         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2408         (TestWebKitAPI):
2409         (TestWebKitAPI::TEST):
2410
2411 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2412
2413         [GTK] Fails to build docs with non-standard build directories
2414         https://bugs.webkit.org/show_bug.cgi?id=78118
2415
2416         Reviewed by Martin Robinson.
2417
2418         * gtk/common.py:
2419         (get_build_path): also try the current directory as a valid build
2420         dir, which makes non-standard build directories such as build-2.0
2421         and build-3.0 work
2422
2423 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2424
2425         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2426         https://bugs.webkit.org/show_bug.cgi?id=78099
2427
2428         Reviewed by Martin Robinson.
2429
2430         * MiniBrowser/gtk/BrowserWindow.c:
2431         (webViewDecidePolicy): Check whether it's a link clicked with the
2432         middle mouse button and load the request in a new window.
2433         (browserWindowConstructed): Connect to
2434         WebKitWebView::decide-policy signal.
2435
2436 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2437
2438         Revert a part of the change in r106687 as a build fix.
2439
2440         Since Chromium port doesn't checkout the entire WebKit trunk,
2441         we can't run "svn info" on webkit_base.
2442
2443         * Scripts/webkitpy/layout_tests/port/base.py:
2444         (Port.repository_paths):
2445
2446 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2447
2448         run-perf-tests doesn't recognize paths that start with PerformanceTests
2449         https://bugs.webkit.org/show_bug.cgi?id=78012
2450
2451         Reviewed by Adam Barth.
2452
2453         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2454
2455         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2456         (PerfTestsRunner):
2457         (PerfTestsRunner._collect_tests):
2458         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2459         (test_collect_tests):
2460         (test_collect_tests.add_file):
2461
2462 2012-02-07  Justin Novosad  <junov@chromium.org>
2463
2464         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2465         https://bugs.webkit.org/show_bug.cgi?id=78039
2466
2467         Reviewed by Stephen White.
2468
2469         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2470
2471         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2472         (main):
2473         * DumpRenderTree/chromium/TestShell.cpp:
2474         (TestShell::TestShell):
2475         (TestShell::resetWebSettings):
2476         (TestShell::runFileTest):
2477         * DumpRenderTree/chromium/TestShell.h:
2478         (TestShell::setDeferred2dCanvasEnabled):
2479         (TestShell):
2480         * DumpRenderTree/chromium/WebPreferences.cpp:
2481         (WebPreferences::reset):
2482         (WebPreferences::applyTo):
2483         * DumpRenderTree/chromium/WebPreferences.h:
2484         (WebPreferences):
2485
2486 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2487
2488         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2489         https://bugs.webkit.org/show_bug.cgi?id=77928
2490
2491         Reviewed by Daniel Bates.
2492
2493         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2494         built in source directory. It is better to set common places in order to maintain executable
2495         and libraries. *bin* is for executable and *lib* is for library.
2496
2497         * DumpRenderTree/efl/CMakeLists.txt:
2498         * EWebLauncher/CMakeLists.txt:
2499         * Scripts/run-launcher:
2500         * Scripts/webkitdirs.pm:
2501         (jscProductDir):
2502         * Scripts/webkitpy/layout_tests/port/efl.py:
2503         (EflPort._path_to_driver):
2504         (EflPort._path_to_image_diff):
2505
2506 2012-02-07  Adam Klein  <adamk@chromium.org>
2507
2508         Add JSC support for delivering mutations when the outermost script context exits
2509         https://bugs.webkit.org/show_bug.cgi?id=70289
2510
2511         Reviewed by Eric Seidel.
2512
2513         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2514         eventSender.scheduleAsynchronousKeyDown.
2515         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2516         (+[EventSendingController webScriptNameForSelector:]):
2517         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2518         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2519         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2520
2521 2012-02-07  Chris Rogers  <crogers@google.com>
2522
2523         Add Chris Rogers to reviewers section
2524         https://bugs.webkit.org/show_bug.cgi?id=78016
2525
2526         Reviewed by Adam Barth.
2527
2528         * Scripts/webkitpy/common/config/committers.py:
2529
2530 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2531
2532         layoutTestController.display() is flaky for SVG tests
2533         https://bugs.webkit.org/show_bug.cgi?id=78021
2534
2535         Reviewed by Dan Bernstein.
2536
2537         Fix race condition in repaint rect tracking. When running a test using the repaint.js
2538         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
2539         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
2540         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
2541         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
2542         the repaint test already run, thus invalidating the previously tracked repaint rects.
2543
2544         * DumpRenderTree/mac/DumpRenderTree.mm:
2545         (dump):
2546         (runTest):
2547
2548 2012-02-07  Hans Wennborg  <hans@chromium.org>
2549
2550         Chromium: remove WebSpeechInputResult::set
2551         https://bugs.webkit.org/show_bug.cgi?id=77977
2552
2553         Reviewed by Darin Fisher.
2554
2555         It was renamed to assign() in r106475.
2556
2557         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2558         (makeRectResult):
2559
2560 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2561
2562         [Qt] Give emulated touch-point a radius
2563         https://bugs.webkit.org/show_bug.cgi?id=77985
2564
2565         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
2566
2567         Reviewed by Kenneth Rohde Christiansen.
2568
2569         * MiniBrowser/qt/BrowserWindow.cpp:
2570         (BrowserWindow::updateVisualMockTouchPoints):
2571         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2572         (MiniBrowserApplication::notify):
2573         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2574
2575 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
2576
2577         [GTK] Include gdk-pixbuf in the jhbuild modules
2578         https://bugs.webkit.org/show_bug.cgi?id=77980
2579
2580         Reviewed by Gustavo Noronha Silva.
2581
2582         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
2583
2584 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
2585
2586         [Qt] Prevent early test termination with newer Qt 5
2587         https://bugs.webkit.org/show_bug.cgi?id=77945
2588
2589         Reviewed by Csaba Osztrogonác.
2590
2591         QTBUG-24120 tracks a regression in Qt that would make layout tests
2592         terminate early. This patch works around it in a Qt 4 + 5 safe manner
2593         by disabling the quitOnLastWindowClosed feature, which we don't want/need
2594         for DRT anyway.
2595
2596         * DumpRenderTree/qt/main.cpp:
2597         (main): Don't quit on last window closed.
2598
2599 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2600
2601         Fix some miscellaneous 'make dist' error for WebKitGTK+.
2602
2603         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
2604         files should not be distributed.
2605
2606 2012-02-02  Hajime Morrita  <morrita@chromium.org>
2607
2608         [PerformanceTests] Each Dromaeo test needs its landing html.
2609         https://bugs.webkit.org/show_bug.cgi?id=77504
2610
2611         Reviewed by Ryosuke Niwa.
2612
2613         Added an ignorable pattern which happens in some Dromaeo tests.
2614
2615         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2616         (PerfTestsRunner):
2617
2618 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
2619
2620         [GTK] Add missing pango include dir to fix build
2621         https://bugs.webkit.org/show_bug.cgi?id=77832
2622
2623         Reviewed by Martin Robinson.
2624
2625         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2626
2627 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2628
2629         [GTK] Fix remaining errors in GTK+ WebKit2 API
2630         https://bugs.webkit.org/show_bug.cgi?id=77890
2631
2632         Reviewed by Gustavo Noronha Silva.
2633
2634         Verify that WebKit2 GTK+ test files are not skipped during style checks.
2635         Skip soup_server_new when checking for NULL versus 0 usage.
2636
2637         * Scripts/webkitpy/style/checker_unittest.py:
2638         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2639         * Scripts/webkitpy/style/checkers/cpp.py:
2640         (check_for_null):
2641
2642 2012-02-06  Eric Seidel  <eric@webkit.org>
2643
2644         webkit-patch apply-from-bug should be able to apply non-reviewed patches
2645         https://bugs.webkit.org/show_bug.cgi?id=77883
2646
2647         Reviewed by Adam Barth.
2648
2649         This is very helpful if you use bugzilla as a replacement for git-stash.
2650         Makes it simpler to re-apply the patch w/o having to look up the patch id.
2651
2652         * Scripts/webkitpy/tool/commands/download.py:
2653         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2654         * Scripts/webkitpy/tool/commands/download_unittest.py:
2655         (DownloadCommandsTest.test_apply_from_bug):
2656
2657 2012-02-06  Philippe Normand  <pnormand@igalia.com>
2658
2659         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
2660         https://bugs.webkit.org/show_bug.cgi?id=77866
2661
2662         Reviewed by Martin Robinson.
2663
2664         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
2665         errors in some gstreamer source code files defining new GStreamer elements.
2666         * Scripts/webkitpy/style/checker_unittest.py:
2667         (GlobalVariablesTest.test_path_rules_specifier):
2668
2669 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2670
2671         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
2672         https://bugs.webkit.org/show_bug.cgi?id=77869
2673
2674         Reviewed by Philippe Normand.
2675
2676         * gtk/gtkdoc.py:
2677         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2678
2679 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2680
2681         [Qt] Don't version QtWebKit.experimental.
2682         https://bugs.webkit.org/show_bug.cgi?id=77739
2683
2684         Reviewed by Tor Arne Vestbø.
2685
2686         * MiniBrowser/qt/qml/BrowserWindow.qml:
2687
2688 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2689
2690         [GTK] Fix several gtkdoc-fixxref warnings
2691         https://bugs.webkit.org/show_bug.cgi?id=77613
2692
2693         Reviewed by Martin Robinson.
2694
2695         * gtk/generate-gtkdoc:
2696         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2697         of ignored files, since it's private.
2698         * gtk/gtkdoc.py:
2699         (GTKDoc._ignored_files_basenames): Helper function that returns a
2700         string with the list of ignored files basenames separated by a
2701         spaces, as expected by several gtkdoc commands.
2702         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2703         --ignore-headers option.
2704         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2705         --ignore-files option.
2706
2707 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2708
2709         [GTK] Fix xrefs after installing API documentation
2710         https://bugs.webkit.org/show_bug.cgi?id=77551
2711
2712         Reviewed by Martin Robinson.
2713
2714         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2715         api docs.
2716         * gtk/common.py:
2717         (prefix_of_pkg_config_file): Get the prefix variable of the given
2718         pkg-config file.
2719         (gtk_version_of_pkg_config_file): Get the gtk version required by
2720         the given pkg-config file.
2721         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2722         installed documentation.
2723         (get_gtkdoc_module_paths): Get paths where API doc is installed
2724         for the dependencies of the given pkg-config file.
2725         (get_common_xref_deps): Get API doc directories of dependencies
2726         common to WebKit1 and WebKit2.
2727         (get_webkit2_options): Add cross_reference_deps option.
2728         (get_webkit1_options): Ditto
2729         (rebase_installed_docs): Helper function to create a generator for
2730         the given pkg-config file and options and call rebase_installed_docs.
2731         * gtk/gtkdoc.py:
2732         (GTKDoc.__init__): Initialize cross_reference_deps.
2733         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2734         dependencies.
2735         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2736         links of installed documentation.
2737         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2738         file.
2739
2740 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2741
2742         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2743         https://bugs.webkit.org/show_bug.cgi?id=77672
2744
2745         Reviewed by Dirk Pranke.
2746
2747         Test repetitions must be taken into account when working out
2748         the statistics shown by run-webkit-tests.
2749
2750         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2751         (Manager.prepare_lists_and_print_output):
2752         (Manager._print_result_summary):
2753         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2754         (ResultSummary.__init__):
2755         (ResultSummary.add):
2756         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2757         (MainTest.test_repeat_each_iterations_num_tests):
2758
2759 2012-02-05  Dan Bernstein  <mitz@apple.com>
2760
2761         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2762         https://bugs.webkit.org/show_bug.cgi?id=77823
2763
2764         Reviewed by Anders Carlsson.
2765
2766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2767         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2768
2769 2012-02-04  Dan Bernstein  <mitz@apple.com>
2770
2771         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2772         https://bugs.webkit.org/show_bug.cgi?id=77822
2773
2774         Reviewed by Sam Weinig.
2775
2776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2777         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2778
2779 2012-02-04  Sam Weinig  <sam@webkit.org>
2780
2781         Add ability to send WKURLRequests in WebKit2 API user messages
2782         https://bugs.webkit.org/show_bug.cgi?id=77819
2783
2784         Reviewed by Anders Carlsson.
2785
2786         Add testing for round-tripping WKTypes from the UIProcess,
2787         to the WebProcess, and back.
2788
2789         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2790           More can easily be added.
2791
2792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2794         (TestWebKitAPI):
2795         (WebKit2UserMessageRoundTripTest):
2796         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2797         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2798         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2799         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2800         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2801         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2802         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2803         (TestWebKitAPI::TEST_F):
2804         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2805         (TestWebKitAPI):
2806         (UserMessageTest):
2807         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2808         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2809         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2810         (TestWebKitAPI::PlatformWebView::resizeTo):
2811         (TestWebKitAPI):
2812         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2813         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2814
2815 2012-02-04  Dan Bernstein  <mitz@apple.com>
2816
2817         <rdar://problem/10772406> WKPreferences instances cannot be copied
2818         https://bugs.webkit.org/show_bug.cgi?id=77816
2819
2820         Reviewed by Sam Weinig.
2821
2822         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2823         (TestWebKitAPI::TEST):
2824
2825 2012-02-04  Adam Barth  <abarth@webkit.org>
2826
2827         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2828         https://bugs.webkit.org/show_bug.cgi?id=77802
2829
2830         Reviewed by Eric Seidel.
2831
2832         This patch refactors our directory grouping code into base.js where it
2833         can be shared between failures.js and notifications.js.  It then adds
2834         an Examine action to each group of failures that triggers the "results"
2835         view.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2843
2844 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2845
2846         check-webkit-style is throwing an exception
2847         https://bugs.webkit.org/show_bug.cgi?id=77744
2848
2849         Reviewed by David Levin.
2850
2851         If the test_list is None, then we don't need to check for unsupported
2852         feature tests to skip.
2853
2854         * Scripts/webkitpy/layout_tests/port/webkit.py:
2855         (WebKitPort._has_test_in_directories):
2856         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2857         (test_skipped_tests_for_unsupported_features_empty_test_list):
2858
2859 2012-02-03  Adam Barth  <abarth@webkit.org>
2860
2861         List of all failures in garden-o-matic should actually list all the failures
2862         https://bugs.webkit.org/show_bug.cgi?id=77796
2863
2864         Reviewed by Eric Seidel.
2865
2866         This patch wires a bit more data into the new "All Failures" tab.  I've
2867         also iterated on how we enable this experimental feature.  The tab is
2868         still just a dumb list, but we'll make it smarter.
2869
2870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2874
2875 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         Windows build fix after r106692.
2878
2879         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2880         (PortTest.test_reference_files):
2881
2882 2012-02-03  Beth Dakin  <bdakin@apple.com>
2883
2884         https://bugs.webkit.org/show_bug.cgi?id=77782
2885         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
2886         once on some pages with frames
2887         -and corresponding-
2888         <rdar://problem/10798474>
2889
2890         Reviewed by Sam Weinig.
2891
2892         One new test.
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2895         (TestWebKitAPI):
2896         (TestWebKitAPI::didForceRepaint):
2897         (TestWebKitAPI::didFinishLoadForFrame):
2898         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2899         (TestWebKitAPI::setPageLoaderClient):
2900         (TestWebKitAPI::TEST):
2901         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2902         (TestWebKitAPI):
2903         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2904         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2905         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2906         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2907
2908 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2909
2910         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2911         https://bugs.webkit.org/show_bug.cgi?id=77781
2912
2913         Reviewed by Eric Seidel.
2914
2915         This change fixes a couple of issues discovered while debugging
2916         test-webkitpy; both calling exit() instead of sys.exit() --
2917         which is discouraged in program code instead of the interpreter
2918         -- and a particular usage of outputcapture were stdin to get whacked
2919         and preventing debugging.
2920
2921         This change introduces a couple of common _exit() methods that
2922         will standardize how webkit-patch exit's, in case we need to do
2923         something different in the future.
2924
2925         * Scripts/webkitpy/common/system/deprecated_logging.py:
2926         (error):
2927         * Scripts/webkitpy/common/system/outputcapture.py:
2928         (OutputCapture.assert_outputs):
2929         * Scripts/webkitpy/tool/bot/queueengine.py:
2930         (QueueEngine.exit_after_handled_error):
2931         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2932         (AbstractSequencedCommand.execute):
2933         * Scripts/webkitpy/tool/commands/queues.py:
2934         (StyleQueue.handle_script_error):
2935         * Scripts/webkitpy/tool/commands/upload.py:
2936         (MarkBugFixed.execute):
2937         * Scripts/webkitpy/tool/multicommandtool.py:
2938         (Command._exit):
2939         * Scripts/webkitpy/tool/steps/abstractstep.py:
2940         (AbstractStep._exit):
2941         * Scripts/webkitpy/tool/steps/checkstyle.py:
2942         (CheckStyle.run):
2943         * Scripts/webkitpy/tool/steps/commit.py:
2944         (Commit._check_test_expectations):
2945         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2946         (ConfirmDiff.run):
2947
2948 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2949
2950         Perf bot build fix.
2951
2952         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2953         (PerfTestsRunner._generate_json):
2954
2955 2012-02-03  Adam Barth  <abarth@webkit.org>
2956
2957         Add a blank "Expected Failures" tab to garden-o-matic
2958         https://bugs.webkit.org/show_bug.cgi?id=77793
2959
2960         Reviewed by Eric Seidel.
2961
2962         This tab will help us explore and manage our expected failures.  The
2963         tab is hidden by default via a new "experimental features" flag.
2964
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2970         (#unexpected):
2971         (#onebar.partytime #unexpected):
2972
2973 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2974
2975         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2976         https://bugs.webkit.org/show_bug.cgi?id=77785
2977
2978         Fix the build bots.
2979
2980         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2981
2982         * Scripts/update-webkit-support-libs:
2983         (downloadExpectedVersionNumber):
2984
2985 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2986
2987         Add a Mac Lion Performance bot.
2988         https://bugs.webkit.org/show_bug.cgi?id=77765
2989
2990         Reviewed by Adam Roben.
2991
2992         This will update the master configuration in the following ways:
2993             Add a new performance slave (apple-xseve-11)
2994             Add a new Factory to download a build and run perf tests.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/config.json:
2997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2998         (DownloadAndPerfTestFactory):
2999         (DownloadAndPerfTestFactory.__init__):
3000
3001 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3002
3003         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3004         https://bugs.webkit.org/show_bug.cgi?id=77752
3005
3006         Reviewed by James Robinson.
3007
3008         Delete unneeded file accidentally checked in in r106481.
3009
3010         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3011
3012 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3013
3014         Ref Tests should support plain SVG files
3015         https://bugs.webkit.org/show_bug.cgi?id=77685
3016
3017         Reviewed by Tony Chang.
3018
3019         Don't assume reference files always use .html as the extension.
3020         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3021
3022         Also fix various bugs in MockFileSystem and TestPort.
3023
3024         * Scripts/webkitpy/common/system/filesystem_mock.py:
3025         (MockFileSystem.isdir):
3026         * Scripts/webkitpy/layout_tests/port/base.py:
3027         (Port.reference_files):
3028         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3029         (PortTest.test_is_test_file):
3030         (PortTest.test_reference_files):
3031         * Scripts/webkitpy/layout_tests/port/test.py:
3032         (TestInstance.__init__):
3033
3034 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3035
3036         perf-o-matic should store chromium svn revision
3037         https://bugs.webkit.org/show_bug.cgi?id=77725
3038
3039         Reviewed by Dirk Pranke.
3040
3041         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3042         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3043         is implemented in terms of newly added svn_revision.
3044
3045         * Scripts/webkitpy/common/checkout/scm/git.py:
3046         (Git.svn_revision):
3047         * Scripts/webkitpy/common/checkout/scm/scm.py:
3048         (SCM.head_svn_revision):
3049         (SCM):
3050         (SCM.svn_revision):
3051         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3052         (MockSCM.svn_revision):
3053         * Scripts/webkitpy/common/checkout/scm/svn.py:
3054         (SVN.svn_revision):
3055         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3056         (JSONLayoutResultsGenerator.__init__):
3057         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3058         (JSONResultsGeneratorBase._insert_generic_metadata):
3059         * Scripts/webkitpy/layout_tests/port/base.py:
3060         (Port.repository_paths):
3061         * Scripts/webkitpy/layout_tests/port/chromium.py:
3062         (ChromiumPort.repository_paths):
3063         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3064         (PerfTestsRunner._generate_json):
3065         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3066         (test_run_test_set_with_json_output):
3067         (test_run_test_set_with_json_source):
3068         (test_run_test_set_with_multiple_repositories):
3069
3070 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3071
3072         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3073         https://bugs.webkit.org/show_bug.cgi?id=77632
3074
3075         Reviewed by Kenneth Rohde Christiansen.
3076
3077         * MiniBrowser/qt/BrowserWindow.cpp:
3078         (BrowserWindow::BrowserWindow):
3079         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3080         (MiniBrowserApplication::sendTouchEvent):
3081         (MiniBrowserApplication::handleUserOptions):
3082         * MiniBrowser/qt/MiniBrowserApplication.h:
3083         (WindowOptions):
3084         (WindowOptions::WindowOptions):
3085         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3086         (WTR::PlatformWebView::PlatformWebView):
3087         * WebKitTestRunner/qt/main.cpp:
3088         (main):
3089         * qmake/mkspecs/features/default_post.prf:
3090
3091 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3092
3093         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3094         https://bugs.webkit.org/show_bug.cgi?id=77723
3095
3096         Reviewed by Tor Arne Vestbø.
3097
3098         * Tools.pro: Compile WTR again on all platforms with WK2.
3099
3100 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3101
3102         Ensure that inspector disabled build works
3103         https://bugs.webkit.org/show_bug.cgi?id=77604
3104
3105         Reviewed by Tor Arne Vestbø.
3106
3107         * qmake/mkspecs/features/features.prf:
3108
3109 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3110
3111         [chromium] add support for --makeargs to the ninja-based build
3112         https://bugs.webkit.org/show_bug.cgi?id=77688
3113
3114         Reviewed by Adam Barth.
3115
3116         * Scripts/webkitdirs.pm:
3117         (buildChromiumNinja):
3118
3119 2012-02-02  Eric Seidel  <eric@webkit.org>
3120
3121         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3122         https://bugs.webkit.org/show_bug.cgi?id=75145
3123
3124         Reviewed by Dirk Pranke.
3125
3126         * Scripts/webkitpy/layout_tests/port/mac.py:
3127         (MacPort.default_child_processes):
3128         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3129         (test_operating_system):
3130         (test_default_child_processes):
3131
3132 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3133
3134        nrwt shouldn't blow up when there are errors in test_expectations.txt
3135        https://bugs.webkit.org/show_bug.cgi?id=73603
3136
3137        Reviewed by Ojan Vafai.
3138
3139        This change removes the distinction between 'errors' and 'warnings'
3140        in the test expectations parser. Now, any problem is a
3141        'warning', and if we are linting the file, warnings become fatal (errors).
3142
3143         This will allow a normal run-webkit-tests run to proceed even if
3144         there are bad lines.
3145
3146         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3147         (ParseError.__init__):
3148         (ParseError.__str__):
3149         (ParseError.__repr__):
3150         (TestExpectationSerializer.to_string):
3151         (TestExpectationParser._parse_modifiers):
3152         (TestExpectationParser._parse_expectations):
3153         (TestExpectationParser._check_modifiers_against_expectations):
3154         (TestExpectationParser._tokenize):
3155         (TestExpectationLine.__init__):
3156         (TestExpectationLine.is_invalid):
3157         (TestExpectationsModel.add_expectation_line):
3158         (TestExpectationsModel._already_seen_better_match):
3159         (TestExpectations.__init__):
3160         (TestExpectations._report_warnings):
3161         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3162         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3163         (assert_bad_expectations):
3164         (test_parse_warning):
3165         (test_overrides__duplicate):
3166         (ExpectationSyntaxTests.test_missing_expectation):
3167         (ExpectationSyntaxTests.test_missing_colon):
3168         (ExpectationSyntaxTests.test_too_many_colons):
3169         (ExpectationSyntaxTests.test_too_many_equals_signs):
3170         (ExpectationSyntaxTests.test_unrecognized_expectation):
3171         (SemanticTests.test_bug_format):
3172         (SemanticTests.test_bad_bugid):
3173         (SemanticTests.test_slow_and_timeout):
3174         (test_ambiguous):
3175         (test_more_modifiers):
3176         (test_order_in_file):
3177         (test_macro_overrides):
3178         (RebaseliningTest.assertRemove):
3179         (TestExpectationParserTests.test_tokenize_blank):
3180         (TestExpectationParserTests.test_tokenize_missing_colon):
3181         (TestExpectationParserTests.test_tokenize_extra_colon):
3182         (TestExpectationParserTests.test_tokenize_empty_comment):
3183         (TestExpectationParserTests.test_tokenize_comment):
3184         (TestExpectationParserTests.test_tokenize_missing_equal):
3185         (TestExpectationParserTests.test_tokenize_extra_equal):
3186         (TestExpectationParserTests.test_tokenize_valid):
3187         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3188         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3189         (TestExpectationSerializerTests.test_unparsed_to_string):
3190         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3191         (lint):
3192         * Scripts/webkitpy/style/checkers/test_expectations.py:
3193         (TestExpectationsChecker.check_test_expectations):
3194
3195 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3196
3197         Unreviewed, rolling out r106543.
3198         http://trac.webkit.org/changeset/106543
3199         https://bugs.webkit.org/show_bug.cgi?id=77671
3200
3201         Made tests less stable (Requested by rniwa on #webkit).
3202
3203         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3204         (PerfTestsRunner):
3205         (PerfTestsRunner.__init__):
3206         (PerfTestsRunner._run_tests_set):
3207         (PerfTestsRunner._run_single_test):
3208         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3209         (MainTest.TestDriver.run_test):
3210         (run_test):
3211
3212 2012-02-02  Beth Dakin  <bdakin@apple.com>
3213
3214         https://bugs.webkit.org/show_bug.cgi?id=77664
3215         Add API tests for didNewFirstVisuallyNonEmptyLayout
3216
3217         Reviewed by Darin Adler.
3218
3219         Two new tests.
3220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3221         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
3222         (TestWebKitAPI):
3223         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3224         (TestWebKitAPI::setPageLoaderClient):
3225         (TestWebKitAPI::TEST):
3226         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
3227         (TestWebKitAPI):
3228         (TestWebKitAPI::didForceRepaint):
3229         (TestWebKitAPI::didFinishLoadForFrame):
3230         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3231         (TestWebKitAPI::setPageLoaderClient):
3232         (TestWebKitAPI::TEST):
3233         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
3234         (TestWebKitAPI):
3235         (NewFirstVisuallyNonEmptyLayoutFailsTest):
3236         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
3237         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3238         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
3239         (TestWebKitAPI):
3240         (NewFirstVisuallyNonEmptyLayoutTest):
3241         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
3242         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3243
3244 2012-02-02  Michael Saboff  <msaboff@apple.com>
3245
3246         Add Michael Saboff to reviewers list.
3247
3248         Rubber-stamped by Gavin Barraclough.
3249
3250         * Scripts/webkitpy/common/config/committers.py:
3251
3252 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3253
3254         Add myself as a committer
3255
3256         Unreviewed
3257
3258         * Scripts/webkitpy/common/config/committers.py:
3259
3260 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3261
3262         [PerformanceTests] tests have dependencies
3263         https://bugs.webkit.org/show_bug.cgi?id=77506
3264
3265         Reviewed by Hajime Morita.
3266
3267         Load an initialization page before each test after starting a DRT so that
3268         warming up DRT won't affect the performance test results.
3269
3270         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3271         (PerfTestsRunner):
3272         (PerfTestsRunner.__init__):
3273         (PerfTestsRunner._run_tests_set):
3274         (PerfTestsRunner._run_single_test):
3275         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3276         (MainTest.TestDriver.run_test):
3277         (test_initial_page_loaded):
3278         (test_initial_page_loaded.run_test):
3279
3280 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3281
3282         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
3283
3284         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3285         (PerfTestsRunner._run_tests_set):
3286         (PerfTestsRunner._run_single_test):
3287         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3288         (create_runner):
3289         (test_run_passing_test):
3290         (test_run_silent_test):
3291         (test_run_failed_test):
3292         (test_run_tonguey_test):
3293         (test_run_timeout_test):
3294         (test_run_crash_test):
3295         (test_run_test_set_kills_drt_per_run):
3296         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3297         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3298         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3299
3300 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
3301
3302         Webkit generate-coverage-data script needs update to use new test script
3303         https://bugs.webkit.org/show_bug.cgi?id=77597
3304
3305         Reviewed by Dirk Schulze.
3306
3307         * Scripts/generate-coverage-data:
3308
3309 2012-02-01  Adam Barth  <abarth@webkit.org>
3310
3311         Update the tests to show that the mac-ews processes patches from
3312         non-committers.
3313
3314         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3315         (EarlyWarningSytemTest.test_committer_only_ewses):
3316         (EarlyWarningSytemTest.test_builder_ewses):
3317
3318 2012-02-01  Adam Barth  <abarth@webkit.org>
3319
3320         Mac-ews logs are huge
3321         https://bugs.webkit.org/show_bug.cgi?id=77045
3322
3323         Reviewed by Eric Seidel.
3324
3325         In order to get the cr-linux-ews bot to run tests on EC2, we created
3326         the chromium-xvfb port, which contained a number of tweaks to the
3327         Chromium port's behavior.  This patch refactors those tweaks so they
3328         can be shared with the mac-ews, mostly by moving them into the
3329         non-interactive mode of RunTests.
3330
3331         * Scripts/webkitpy/common/config/ports.py:
3332         (WebKitPort):
3333         (WebKitPort.layout_tests_results_path):
3334         (ChromiumPort.run_javascriptcore_tests_command):
3335         (ChromiumXVFBPort):
3336         (ChromiumXVFBPort.run_webkit_tests_command):
3337         * Scripts/webkitpy/common/config/ports_mock.py:
3338         (MockPort):
3339         (MockPort.layout_tests_results_path):
3340         * Scripts/webkitpy/common/config/ports_unittest.py:
3341         (WebKitPortTest.test_chromium_xvfb_port):
3342         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3343         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3344         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3345         (CommitQueueTest.test_commit_queue):
3346         (test_rollout):
3347         (test_manual_reject_during_processing):
3348         * Scripts/webkitpy/tool/steps/runtests.py:
3349         (RunTests.run):
3350         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3351         (RunTestsTest.test_no_unit_tests):
3352         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3353         (StepsTest.test_runtests_args):
3354
3355 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3356
3357         Roll out r106442. It made some tests more stable but others less stable.
3358
3359         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3360         (PerfTestsRunner._run_tests_set):
3361         (PerfTestsRunner._run_single_test):
3362         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3363         (create_runner):
3364         (test_run_passing_test):
3365         (test_run_silent_test):
3366         (test_run_failed_test):
3367         (test_run_tonguey_test):
3368         (test_run_timeout_test):
3369         (test_run_crash_test):
3370         (test_run_test_set):
3371
3372 2012-02-01  Lucas Forschler  <lforschler@apple.com>
3373
3374         Enable EWS for non-contributers.
3375         https://bugs.webkit.org/show_bug.cgi?id=77576
3376
3377         Reviewed by Adam Barth.
3378
3379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3380         (MacEWS):
3381
3382 2012-02-01  Beth Dakin  <bdakin@apple.com>
3383
3384         https://bugs.webkit.org/show_bug.cgi?id=77383
3385         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
3386         -and corresponding-
3387         <rdar://problem/10709560>
3388
3389         Reviewed by Sam Weinig.
3390
3391         WebKit2's WebLoaderClient has a temporary new function that must be accounted
3392         for.
3393         * MiniBrowser/mac/BrowserWindowController.m:
3394         (-[BrowserWindowController awakeFromNib]):
3395         * WebKitTestRunner/TestController.cpp:
3396         (WTR::TestController::initialize):
3397
3398 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
3399
3400         TestWebKitAPI isn't being built on chromium bots any more
3401         https://bugs.webkit.org/show_bug.cgi?id=77563
3402
3403         Reviewed by Dimitri Glazkov.
3404
3405         I accidentally dropped it in the refactoring in r105449.
3406
3407         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
3408
3409 2012-02-01  Hans Wennborg  <hans@chromium.org>
3410
3411         Rename WebSpeechInputResult::set() to assign()
3412         https://bugs.webkit.org/show_bug.cgi?id=77540
3413
3414         Reviewed by Darin Fisher.
3415
3416         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3417         (MockWebSpeechInputController::addMockRecognitionResult):
3418         (MockWebSpeechInputController::speechTaskFired):
3419
3420 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3421
3422         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
3423         https://bugs.webkit.org/show_bug.cgi?id=77542
3424
3425         Reviewed by Martin Robinson.
3426
3427         * gtk/generate-gtkdoc: Check first whether there's
3428         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
3429         instead.
3430         (get_webkit2_options): Return just the options since the
3431         pkg_config_path doesn't depend on options
3432         (get_webkit1_options): Ditto.
3433         (generate_doc): Helper function to create a generator and generate
3434         documentation for the given pkg-config file with the given options.
3435         * gtk/gtkdoc.py:
3436         (GTKDoc.__init__): Don't use ** for args parameter, since it's
3437         used as a dict and never expanded.
3438         (PkgConfigGTKDoc.__init__): Ditto.
3439
3440 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3441
3442         [GTK] API documentation is not installed even when building with --enable-gtk-doc
3443         https://bugs.webkit.org/show_bug.cgi?id=77094
3444
3445         Reviewed by Martin Robinson.
3446
3447         * GNUmakefile.am: Add install-data-local and uninstall-local rules
3448         to install/uninstall WebKit1 and WebKit2 API documentation.
3449
3450 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3451
3452         Unreviewed, rolling out r106460.
3453         http://trac.webkit.org/changeset/106460
3454         https://bugs.webkit.org/show_bug.cgi?id=77552
3455
3456         It break unit tests if WEBKIT_TESTFONTS isn't defined.
3457         (Requested by Ossy on #webkit).
3458
3459         * Scripts/webkitpy/layout_tests/port/qt.py:
3460
3461 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3462
3463         [Qt] Automatic clean build feature always do clean build with --no-webkit2
3464         https://bugs.webkit.org/show_bug.cgi?id=74519
3465
3466         Reviewed by Tor Arne Vestbø.
3467
3468         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
3469
3470         * qmake/mkspecs/features/features.prf:
3471
3472 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3473
3474         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
3475         https://bugs.webkit.org/show_bug.cgi?id=77466
3476
3477         Reviewed by Kenneth Rohde Christiansen.
3478
3479         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
3480         is set or if we should raise an error.
3481
3482         * Scripts/webkitpy/layout_tests/port/qt.py:
3483         (QtPort.setup_environ_for_server):
3484
3485 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3486
3487         Reviewed by Martin Robinson.
3488
3489         [GTK] Improve FrameLoader signals. Resource loading
3490         https://bugs.webkit.org/show_bug.cgi?id=49543
3491
3492         Support for the new loader signals in DRT.
3493
3494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3495         (urlPath):
3496         (willSendRequestCallback):
3497         (urlSuitableForTestResult):
3498         (descriptionSuitableForTestResult):
3499         (didReceiveResponse):
3500         (didFinishLoading):
3501         (didFailLoadingWithError):
3502         (createWebView):
3503
3504 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3505
3506         run-perf-tests should restart DRT for each test
3507         https://bugs.webkit.org/show_bug.cgi?id=77506
3508
3509         Reviewed by Adam Barth.
3510
3511         Always restart DRT when running performance tests in order to minimize the dependency between tests.
3512
3513         * Scripts/webkitpy/layout_tests/port/chromium.py:
3514         (ChromiumDriver.stop):
3515         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3516         (PerfTestsRunner._run_tests_set):
3517         (PerfTestsRunner._run_single_test):
3518         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3519         (create_runner):
3520         (test_run_passing_test):
3521         (test_run_silent_test):
3522         (test_run_failed_test):
3523         (test_run_tonguey_test):
3524         (test_run_timeout_test):
3525         (test_run_crash_test):
3526         (test_run_test_set_kills_drt_per_run):
3527         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3528         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3529         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3530
3531 2012-01-31  Hans Wennborg  <hans@chromium.org>
3532
3533         Speech Input: Report speech element rect relative to window rather than frame
3534         https://bugs.webkit.org/show_bug.cgi?id=76443
3535
3536         Reviewed by Darin Fisher.
3537
3538         Update LayoutTestController to allow for retrieving the speech
3539         element's position used in a request.
3540
3541         In Chromium this is handled by the MockWebSpeechInputController;
3542         adding stubs for the other implementations.
3543
3544         * DumpRenderTree/LayoutTestController.cpp:
3545         (setMockSpeechInputDumpRectCallback):
3546         (LayoutTestController::staticFunctions):
3547         * DumpRenderTree/LayoutTestController.h:
3548         (LayoutTestController):
3549         * DumpRenderTree/chromium/LayoutTestController.cpp:
3550         (LayoutTestController::LayoutTestController):
3551         (LayoutTestController::setMockSpeechInputDumpRect):
3552         * DumpRenderTree/chromium/LayoutTestController.h:
3553         (LayoutTestController):
3554         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3555         (MockWebSpeechInputController::setDumpRect):
3556         (MockWebSpeechInputController::clearResults):
3557         (MockWebSpeechInputController::startRecognition):
3558         (MockWebSpeechInputController::MockWebSpeechInputController):
3559         (makeRectResult):
3560         (MockWebSpeechInputController::speechTaskFired):
3561         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3562         (MockWebSpeechInputController):
3563         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3564         (LayoutTestController::setMockSpeechInputDumpRect):
3565         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3566         (LayoutTestController::setMockSpeechInputDumpRect):
3567         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3568         (LayoutTestController::setMockSpeechInputDumpRect):
3569         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3570         (LayoutTestController::setMockSpeechInputDumpRect):
3571         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3572         (LayoutTestController):
3573         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3574         (LayoutTestController::setMockSpeechInputDumpRect):
3575         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3576         (LayoutTestController::setMockSpeechInputDumpRect):
3577
3578 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
3579
3580         [EFL] Add basic DRT/Efl implementation to support viewport test.
3581         https://bugs.webkit.org/show_bug.cgi?id=77320
3582
3583         Reviewed by Andreas Kling.
3584
3585         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3586         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
3587
3588 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
3589
3590         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
3591         https://bugs.webkit.org/show_bug.cgi?id=77473
3592         <rdar://problem/10751357>
3593
3594         Reviewed by Darin Adler.
3595
3596         * DumpRenderTree/mac/EventSendingController.mm:
3597         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3598         * WebKitTestRunner/mac/EventSenderProxy.mm:
3599         (WTR::EventSenderProxy::keyDown):
3600         Added a new special keyDown value to test this.
3601
3602 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
3603
3604         nrwt: fix the mock port to work with DriverProxy, reftests
3605         https://bugs.webkit.org/show_bug.cgi?id=77170
3606
3607         Reviewed by Eric Seidel.
3608
3609         The DryrunPort used for benchmarking and testing NRWT has been
3610         broken since we added the DriverProxy code. It isn't really
3611         needed any more, so I've removed it.
3612
3613         The MockDRT port was also broken by DriverProxy, and moreover,
3614         never worked w/ reftests. Since we don't exercise this module in
3615         the unit tests, the code had also bitrotted some. I have cleaned
3616         it up and made it use DriverInput and DriverOutput for
3617         consistency.
3618
3619         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3620         (DryRunPort.__init__):
3621         (DryRunPort):
3622         (DryRunPort.real_name):
3623         (DryRunPort.create_driver):
3624         (DryRunPort.driver_cmd_line):
3625         (DryRunPort._driver_class):
3626         (DryrunDriver):
3627         (DryrunDriver.run_test):
3628         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3629         (MockDRTPort.create_driver):
3630         (MockChromiumDRT.run_one_test):
3631
3632 2012-01-31  Ojan Vafai  <ojan@chromium.org>
3633
3634         run-webkit-tests calls out to webkit-build-directory twice
3635         https://bugs.webkit.org/show_bug.cgi?id=77248
3636
3637         Reviewed by Dirk Pranke.
3638
3639         * Scripts/webkit-build-directory:
3640         If called with no arguments, print out both the top-level directory and the
3641         configuration directory
3642
3643         * Scripts/webkitpy/layout_tests/port/config.py:
3644         (Config.build_directory):
3645         When called with no arguments, get and cache both the top-level and configuration directories.
3646
3647         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3648         (main):
3649         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3650         (ConfigTest.assert_configuration):
3651         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3652         (ConfigTest.test_build_directory):
3653         (ConfigTest.test_default_configuration__notfound):
3654         * Scripts/webkitpy/layout_tests/port/webkit.py:
3655         (WebKitPort._build_path):
3656         Cache the build directory in the options object so that other users
3657         of the options object don't need to call out to webkit-build-directory.
3658         Also, properly support the existing --build-directory argument.
3659
3660 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3661
3662         Bump up the timeout for performance tests since DOM/DOMTable.html
3663         and Parser/html5-full-render.html are timing out on the bot.
3664
3665         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3666         (PerfTestsRunner._parse_args):
3667
3668 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
3669
3670         Fix the update_webgl_conformance_tests.py script in order to enable it
3671         to detect the SCM being used correctly.
3672         https://bugs.webkit.org/show_bug.cgi?id=77462
3673
3674         Reviewed by Kenneth Russell.
3675
3676         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3677         (default_out_dir):
3678
3679 2012-01-31  Eric Seidel  <eric@webkit.org>
3680
3681         webkit-patch apply-from-bug should work regardless of your CWD
3682         https://bugs.webkit.org/show_bug.cgi?id=77482
3683
3684         Reviewed by Adam Barth.
3685
3686         webkit-patch only ever works with patches made from the root
3687         directory.  We should pass the CWD to svn-apply in the case
3688         where we're running not from the webkit root.  I believe
3689         this used to work in the past and regressed.
3690
3691         * Scripts/webkitpy/common/checkout/checkout.py:
3692         (Checkout.apply_patch):
3693         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3694         (CheckoutTest.test_apply_patch):
3695
3696 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3697
3698         Unreviewed, rolling out r106302.
3699         http://trac.webkit.org/changeset/106302
3700         https://bugs.webkit.org/show_bug.cgi?id=77472
3701
3702         Broke building DRT before running the tests (Requested by ojan
3703         on #webkit).
3704
3705         * Scripts/webkit-build-directory:
3706         * Scripts/webkitpy/layout_tests/port/config.py: