[XCode] webkit-patch should run sort-Xcode-project-file
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
2
3         [XCode] webkit-patch should run sort-Xcode-project-file
4         https://bugs.webkit.org/show_bug.cgi?id=174036
5         <rdar://problem/33732709>
6
7         Reviewed by Simon Fraser.
8
9         * Scripts/webkitpy/common/config/ports.py:
10         * Scripts/webkitpy/tool/commands/download.py:
11         * Scripts/webkitpy/tool/commands/download_unittest.py:
12         * Scripts/webkitpy/tool/commands/upload.py:
13         * Scripts/webkitpy/tool/commands/upload_unittest.py:
14         * Scripts/webkitpy/tool/steps/__init__.py:
15         * Scripts/webkitpy/tool/steps/options.py:
16         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
17
18 2017-08-07  Devin Rousso  <drousso@apple.com>
19
20         Web Inspector: Preview Canvas path when viewing a recording
21         https://bugs.webkit.org/show_bug.cgi?id=174967
22
23         Reviewed by Brian Burg.
24
25         * DumpRenderTree/TestOptions.h:
26         * DumpRenderTree/TestOptions.mm:
27         (TestOptions::TestOptions):
28         * DumpRenderTree/mac/DumpRenderTree.mm:
29         (setWebPreferencesForTestOptions):
30         * WebKitTestRunner/TestController.cpp:
31         (WTR::TestController::resetPreferencesToConsistentValues):
32         (WTR::updateTestOptionsFromTestHeader):
33         * WebKitTestRunner/TestOptions.h:
34         (WTR::TestOptions::hasSameInitializationOptions const):
35         Add plumbing for new InspectorAdditions runtime flag.
36
37 2017-08-07  obinna obike  <oobike@apple.com>
38
39         Sorted EWS Queues on Patch page
40         https://bugs.webkit.org/show_bug.cgi?id=173667
41
42         Reviewed by Aakash Jain.
43
44         * QueueStatusServer/handlers/patch.py:
45         (Patch.get): Sorted queue_status.
46         * QueueStatusServer/templates/patch.html:
47         Changed queue_status.items to queue_status because it's a list.
48
49 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
50
51         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
52         https://bugs.webkit.org/show_bug.cgi?id=175286
53
54         Reviewed by Myles C. Maxfield.
55
56         * Scripts/webkitpy/style/checkers/cpp.py:
57         (check_braces):
58         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
59         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
60         (WebKitStyleTest.test_braces):
61         (WebKitStyleTest.test_braces.NS_OPTIONS):
62
63 2017-08-07  Brian Burg  <bburg@apple.com>
64
65         Remove CANVAS_PATH compilation guard
66         https://bugs.webkit.org/show_bug.cgi?id=175207
67
68         Reviewed by Sam Weinig.
69
70         * Scripts/webkitperl/FeatureList.pm:
71         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
72
73 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
74
75         [Win] Use Visual Studio 2017 if installed.
76         https://bugs.webkit.org/show_bug.cgi?id=175188
77
78         Reviewed by Sam Weinig.
79
80         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
81
82         * Scripts/webkitdirs.pm:
83         (visualStudioInstallDir):
84         (msBuildInstallDir):
85
86 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
87
88         [GTK][WPE] Add API to provide browser information required by automation
89         https://bugs.webkit.org/show_bug.cgi?id=175130
90
91         Reviewed by Michael Catanzaro.
92
93         * MiniBrowser/gtk/main.c:
94         (automationStartedCallback): Set browser information when a new automation session is started.
95         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
96         (testAutomationSessionApplicationInfo):
97         (beforeAll):
98
99 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
100
101         Unreviewed, rolling out r220295.
102
103         This change introduced 4 errors in webkitpy tests.
104
105         Reverted changeset:
106
107         "[XCode] webkit-patch should run sort-Xcode-project-file"
108         https://bugs.webkit.org/show_bug.cgi?id=174036
109         http://trac.webkit.org/changeset/220295
110
111 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
112
113         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
114
115         Unreviewed test gardening.
116
117         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
118         (TestWebKitAPI::TEST):
119
120 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
121
122         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
123         https://bugs.webkit.org/show_bug.cgi?id=175083
124
125         Reviewed by Oliver Hunt.
126         
127         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
128         to wait for VM destructions to finish before running the next test. This makes it easier to 
129         understand leaks results from workers tests, and leads to fewer reported leaks.
130
131         * DumpRenderTree/mac/DumpRenderTree.mm:
132         (runTest):
133
134 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
135
136         check-webkit-style: fix path-specific rules for WebKit2 rename
137         https://bugs.webkit.org/show_bug.cgi?id=175182
138
139         Reviewed by David Kilzer.
140
141         * Scripts/webkitpy/style/checker.py:
142
143 2017-08-04  Youenn Fablet  <youenn@apple.com>
144
145         [Cache API] Add Cache and CacheStorage IDL definitions
146         https://bugs.webkit.org/show_bug.cgi?id=175201
147
148         Reviewed by Brady Eidson.
149
150         * DumpRenderTree/mac/DumpRenderTree.mm:
151         (enableExperimentalFeatures):
152         (resetWebPreferencesToConsistentValues):
153         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
154         (WTR::InjectedBundle::beginTesting):
155         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
156         (WTR::TestRunner::setCacheAPIEnabled):
157         * WebKitTestRunner/InjectedBundle/TestRunner.h:
158
159 2017-08-04  John Wilander  <wilander@apple.com>
160
161         Resource Load Statistics: Report user interaction immediately, but only when needed
162         https://bugs.webkit.org/show_bug.cgi?id=175090
163         <rdar://problem/33685546>
164
165         Reviewed by Chris Dumez.
166
167         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
168         (WTR::InjectedBundle::beginTesting):
169             Now calls WebCore::ResourceLoadObserver::clearState().
170
171 2017-08-04  Tim Horton  <timothy_horton@apple.com>
172
173         Add an API test for r220286
174         https://bugs.webkit.org/show_bug.cgi?id=175206
175
176         Reviewed by Simon Fraser.
177
178         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
179         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
180         (createAnimatedResizeWebView):
181         (TEST):
182         Add a test to ensure that we don't call
183         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
184         animated resize.
185
186 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
187
188         [XCode] webkit-patch should run sort-Xcode-project-file
189         https://bugs.webkit.org/show_bug.cgi?id=174036
190
191         Reviewed by Simon Fraser.
192
193         * Scripts/webkitpy/common/config/ports.py:
194         * Scripts/webkitpy/tool/commands/download.py:
195         * Scripts/webkitpy/tool/commands/upload.py:
196         * Scripts/webkitpy/tool/steps/__init__.py:
197         * Scripts/webkitpy/tool/steps/options.py:
198         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
199
200 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
201
202         REGRESSION(r219857): run-benchmark --allplans broken
203         https://bugs.webkit.org/show_bug.cgi?id=175186
204
205         Reviewed by Saam Barati.
206
207         r219857 forgot to update also the calls to BenchmarkRunner() that
208         is done when the script is run with --allplans.
209
210         To fix this (and avoid future issues like this), let's factorize
211         the calls to the benchhmark runner in a run_benchmark_plan()
212         function.
213
214         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
215         (run_benchmark_plan):
216         (start):
217
218 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
219
220         Dashboard bubbles sometimes show failure count instead of crash count
221         https://bugs.webkit.org/show_bug.cgi?id=175157
222         <rdar://problem/33709009>
223
224         Reviewed by Alexey Proskuryakov.
225
226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
227         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
228
229 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
230
231         Add tests for NeverDestroyed
232         https://bugs.webkit.org/show_bug.cgi?id=175146
233
234         Reviewed by Darin Adler.
235
236         * CMakeLists.txt:
237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
238         New files and sort.
239
240         * TestWebKitAPI/Tests/WTF/Logger.h:
241         * TestWebKitAPI/Tests/WTF/Logger.cpp:
242         (TestWebKitAPI::log):
243         (TestWebKitAPI::takeLogStr):
244         * TestWebKitAPI/Tests/WTF/RefLogger.h:
245         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
246         (TestWebKitAPI::log): Deleted.
247         (TestWebKitAPI::takeLogStr): Deleted.
248         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
249
250         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
251         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
252         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
253         (TestWebKitAPI::LifecycleLogger::operator=):
254         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
255         (TestWebKitAPI::LifecycleLogger::setName):
256         (TestWebKitAPI::TEST):
257         Add a class that logs construction / assignment / modifications.
258
259         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
260         (TestWebKitAPI::TEST):
261         (TestWebKitAPI::list):
262         Test construction behavior is as expected both directly and using makeNeverDestroyed.
263
264 2017-08-04  Lucas Forschler  <lforschler@apple.com>
265
266         minification logic is not implemented for ios builds
267         <rdar://problem/33726561>
268
269         Reviewed by Dean Johnson
270
271         * BuildSlaveSupport/built-product-archive:
272         (minifyDirectory): refactor minifySource -> minifyDirectory
273         (archiveBuiltProduct): add ios minification logic
274         (minifySource): Deleted.
275
276 2017-08-04  Matt Lewis  <jlewis3@apple.com>
277
278         Unreviewed, rolling out r220271.
279
280         Rolling out due to Layout Test failing on iOS Simulator.
281
282         Reverted changeset:
283
284         "Remove STREAMS_API compilation guard"
285         https://bugs.webkit.org/show_bug.cgi?id=175165
286         http://trac.webkit.org/changeset/220271
287
288 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
289
290         Unreviewed, rolling out r220268.
291
292         This change caused assertion failures on macOS and iOS Debug
293         WK2.
294
295         Reverted changeset:
296
297         "Resource Load Statistics: Report user interaction
298         immediately, but only when needed"
299         https://bugs.webkit.org/show_bug.cgi?id=175090
300         http://trac.webkit.org/changeset/220268
301
302 2017-08-04  Youenn Fablet  <youenn@apple.com>
303
304         Remove STREAMS_API compilation guard
305         https://bugs.webkit.org/show_bug.cgi?id=175165
306
307         Reviewed by Darin Adler.
308
309         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
310
311 2017-08-04  John Wilander  <wilander@apple.com>
312
313         Resource Load Statistics: Report user interaction immediately, but only when needed
314         https://bugs.webkit.org/show_bug.cgi?id=175090
315         <rdar://problem/33685546>
316
317         Reviewed by Chris Dumez.
318
319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
320         (WTR::InjectedBundle::beginTesting):
321             Now calls WebCore::ResourceLoadObserver::clearState().
322
323 2017-08-03  Brian Burg  <bburg@apple.com>
324
325         Remove ENABLE(WEB_SOCKET) guards
326         https://bugs.webkit.org/show_bug.cgi?id=167044
327
328         Reviewed by Joseph Pecoraro.
329
330         * Scripts/webkitperl/FeatureList.pm:
331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
332
333 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
334
335         REGRESSION(r219850): run-benchmark script broken on Linux
336         https://bugs.webkit.org/show_bug.cgi?id=175126
337
338         Reviewed by Stephanie Lewis.
339
340         The run-benchmark script dynamically generates the list of supported
341         browsers and platforms (currently Linux and OSX) by loading all
342         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
343         and getting the browser_name and platform variables from the
344         classes defined there.
345
346         This means that this classes should not raise an exception when
347         loaded on other platforms or otherwise they will broke the whole
348         script. Its fine if they raise an exception when executing any of
349         the methods they implement, but not when just loading/importing
350         the class.
351
352         Move the argument variable definitions that call on the platform
353         specific OSXBrowserDriver._screen_size() function from beeing
354         variables that are evaluated when loading the file, to be functions
355         that are only evaluated when the actual functionality needs to be
356         executed.
357
358         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
359         (OSXChromeDriver.launch_url):
360         (OSXChromeCanaryDriver.launch_url):
361         (create_args):
362         (create_chrome_options):
363         (create_window_size_arg):
364         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
365         (OSXFirefoxDriver.launch_url):
366         (OSXFirefoxNightlyDriver.launch_url):
367         (OSXFirefoxNightlyDriver.launch_driver):
368         (create_args):
369
370 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
371
372         [PAL] Move spi/cf directory into PAL
373         https://bugs.webkit.org/show_bug.cgi?id=175057
374
375         Reviewed by Antti Koivisto.
376
377         * Scripts/webkitpy/style/checker.py:
378         * Scripts/webkitpy/style/checker_unittest.py:
379         (GlobalVariablesTest.test_path_rules_specifier):
380
381         Ignore "readability/naming/underscores" style errors for sources
382         under the WebCore/PAL/pal/spi directory.
383
384         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
385
386 2017-08-03  Youenn Fablet  <youenn@apple.com>
387
388         Remove FETCH_API compilation guard
389         https://bugs.webkit.org/show_bug.cgi?id=175154
390
391         Reviewed by Chris Dumez.
392
393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
394
395 2017-08-03  Lucas Forschler  <lforschler@apple.com>
396
397         Enable archive minification on iOS builds
398         https://bugs.webkit.org/show_bug.cgi?id=174718
399         
400         Reviewed by Aakash Jain.
401
402         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
403         (BuildFactory.__init__):
404
405 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
406
407         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
408         https://bugs.webkit.org/show_bug.cgi?id=175140
409
410         Reviewed by Alexey Proskuryakov.
411
412         We are having lately issues with JSC tests causing problems on
413         the GTK+ and WPE bots due to the high amount of memory some tests
414         need to run.
415
416         The best thing we can do now is to workaround this by disabling
417         all the tests marked as memoryLimited on the GTK and WPE bots.
418         We may revise this on the future.
419
420         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
421         (RunJavaScriptCoreTests.start):
422
423 2017-08-03  Brady Eidson  <beidson@apple.com>
424
425         Add SW IDLs and stub out basic functionality.
426         https://bugs.webkit.org/show_bug.cgi?id=175115
427
428         Reviewed by Chris Dumez.
429
430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
431
432         * Scripts/webkitpy/bindings/main.py:
433
434 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
435
436         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
437         https://bugs.webkit.org/show_bug.cgi?id=159510
438
439         Reviewed by Daniel Bates.
440
441         Allow any https certificate when running tests.
442
443         * DumpRenderTree/win/DumpRenderTree.cpp:
444         (runTest):
445
446 2017-08-02  Youenn Fablet  <youenn@apple.com>
447
448         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
449         https://bugs.webkit.org/show_bug.cgi?id=175089
450
451         Reviewed by Chris Dumez.
452
453         * DumpRenderTree/TestOptions.mm:
454         (TestOptions::TestOptions): Using absolutePath if available.
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         (computeTestURL): Removing http/tests/ specific URL computation.
457         * Scripts/webkitpy/port/driver.py:
458         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
459
460 2017-08-02  Lucas Forschler  <lforschler@apple.com>
461
462         download-built-product should allow for a proxy option
463         https://bugs.webkit.org/show_bug.cgi?id=174875
464
465         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
466
467         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
468         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
469         
470
471 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
472
473         check-webkit-style: deleting lines in a file runs the linter on the whole file
474         https://bugs.webkit.org/show_bug.cgi?id=175078
475
476         Reviewed by David Kilzer.
477
478         Deleting lines in a file should not cause linter errors to be blamed on the patch.
479         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
480
481         * Scripts/webkitpy/style/checkers/test_expectations.py:
482         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
483         * Scripts/webkitpy/style/main_unittest.py:
484         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
485         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
486         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
487
488 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
489
490         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
491         https://bugs.webkit.org/show_bug.cgi?id=175075
492
493         Reviewed by David Kilzer.
494
495         We have no way of handling text files with illegal unicode characters. Allow the callers of
496         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
497         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
498
499         * Scripts/webkitpy/common/system/filesystem.py:
500         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
501         (FileSystem.write_text_file): Ditto.
502         * Scripts/webkitpy/common/system/filesystem_mock.py:
503         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
504         (MockFileSystem.write_text_file): Ditto.
505         * Scripts/webkitpy/common/system/filesystem_unittest.py:
506         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
507         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
508
509 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
510
511         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
512         https://bugs.webkit.org/show_bug.cgi?id=175072
513
514         Reviewed by Alexey Proskuryakov.
515
516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
517         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
518
519 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
520
521         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
522         https://bugs.webkit.org/show_bug.cgi?id=175019
523
524         Reviewed by Darin Adler.
525
526         * TestWebKitAPI/CMakeLists.txt:
527
528 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
529
530         Enabling uploading archives to S3
531         https://bugs.webkit.org/show_bug.cgi?id=174198
532
533         Unreviewed unit test fix after r219235.
534
535         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
536
537 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
538
539         Fix JSCOnly ARM buildbots after r220047
540         https://bugs.webkit.org/show_bug.cgi?id=174993
541
542         Unreviewed fix after r220087.
543
544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
545         (BuildAndRemoteJSCTestsFactory.__init__):
546
547 2017-08-01  Chris Dumez  <cdumez@apple.com>
548
549         Add initial support for navigator.sendBeacon
550         https://bugs.webkit.org/show_bug.cgi?id=175007
551         <rdar://problem/33547728>
552
553         Reviewed by Sam Weinig.
554
555         Enable the Beacon API at runtime in the context of layout tests since the
556         feature is currently disabled by default.
557
558         * DumpRenderTree/mac/DumpRenderTree.mm:
559         (enableExperimentalFeatures):
560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
561         (WTR::InjectedBundle::beginTesting):
562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
563         (WTR::TestRunner::setModernMediaControlsEnabled):
564         (WTR::TestRunner::setBeaconAPIEnabled):
565         * WebKitTestRunner/InjectedBundle/TestRunner.h:
566
567 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
568
569         Update Bot Watcher's Dashboard for Buildbot 0.9
570         https://bugs.webkit.org/show_bug.cgi?id=174777
571
572         Reviewed by Daniel Bates.
573
574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
575         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
576         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
577         in a dictionary.
578         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
579         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
581         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
582         (parseRevisionProperty): Ditto.
583         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
584         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
585         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
586         have changed in Buildbot 0.9.
587         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
588         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
589         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
590         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
591         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
592         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
593         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
594         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
595         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
596         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
598         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
599         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
600         (BuildbotQueue.prototype.get overviewURL): Ditto.
601         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
602         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
603         Buildbot 0.8 or 0.9.
604         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
605         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
606         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
607         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
608         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
609         Therefore we are fetching information for fixed number of build. 
610         Also iterating the loop incrementally since the build data is already reverse sorted.
611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
612         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
613         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
615         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
616
617 2017-08-01  Devin Rousso  <drousso@apple.com>
618
619         Web Inspector: simplify WebInspector with WI
620         https://bugs.webkit.org/show_bug.cgi?id=175058
621
622         Reviewed by Joseph Pecoraro.
623
624         * Scripts/check-inspector-strings:
625         (extract_ui_strings):
626         * Scripts/extract-localizable-js-strings:
627
628 2017-08-01  Youenn Fablet  <youenn@apple.com>
629
630         Layout tests with 'https' suffix should be run over HTTPS
631         https://bugs.webkit.org/show_bug.cgi?id=174992
632
633         Reviewed by Chris Dumez.
634
635         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
636         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
637         Covered by corresponding unit tests.
638
639         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
640         (run_server):
641         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
642         (base_http_url):
643         (base_https_url):
644         (base_url): Deleted.
645         * Scripts/webkitpy/port/base.py:
646         (Port.to.web_platform_test_server_base_http_url):
647         (Port.to):
648         (Port.to.web_platform_test_server_base_https_url):
649         (Port.to.web_platform_test_server_base_url): Deleted.
650         * Scripts/webkitpy/port/driver.py:
651         (Driver.__init__):
652         (Driver.wpt_test_path_to_uri):
653         (Driver):
654         (Driver.http_test_path_to_uri):
655         (Driver.test_to_uri):
656         (Driver.uri_to_test):
657         * Scripts/webkitpy/port/driver_unittest.py:
658         (DriverTest.test_test_to_uri):
659         (DriverTest.test_uri_to_test):
660
661 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
662
663         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
664         https://bugs.webkit.org/show_bug.cgi?id=173998
665
666         Reviewed by Darin Adler.
667
668         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
669         detect mistakes in backward compatibility in the future when we change it.
670
671         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
672         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
673         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
674         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
675         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
676         internal key data slot.
677
678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
680         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
681         (getNextMessage):
682         (TEST):
683         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
684         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
685         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
686         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
687         These are the pre-baked databases.
688         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
689         This is the actual test that do all the reads and comparisons.
690         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
691         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
692         IndexedDB new stuffs. Then it can be used to bake the database again.
693
694 2017-08-01  Brady Eidson  <beidson@apple.com>
695
696         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
697         https://bugs.webkit.org/show_bug.cgi?id=175030
698
699         Reviewed by Andy Estes.
700
701         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
702         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
703
704 2017-08-01  Brady Eidson  <beidson@apple.com>
705
706         Part 2 of: Rename DatabaseProcess to StorageProcess.
707         https://bugs.webkit.org/show_bug.cgi?id=174880
708
709         Reviewed by Andy Estes.
710
711         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
712         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
713         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
714         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
715         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
716         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
717         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
718         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
719
720 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
721
722         Fix JSCOnly ARM buildbots after r220047
723         https://bugs.webkit.org/show_bug.cgi?id=174993
724
725         Reviewed by Saam Barati.
726
727         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
728         (BuildAndRemoteJSCTestsFactory.__init__):
729
730 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
731
732         [WTF] Introduce Private Symbols
733         https://bugs.webkit.org/show_bug.cgi?id=174935
734
735         Reviewed by Darin Adler.
736
737         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
738         (TestWebKitAPI::TEST):
739
740 2017-07-30  Darin Adler  <darin@apple.com>
741
742         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
743         https://bugs.webkit.org/show_bug.cgi?id=130653
744
745         Reviewed by Antti Koivisto.
746
747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
748         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
749         when calling frameDidChangeLocation.
750         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
751         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
752         thus causing mysterious failures of a couple of tests. There are two remaining issues:
753         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
754         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
755         same logic flaw that causes "top loading frame" to get set to one of the subframes in
756         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
757         loading, subframe starts loading. It would be good to clean that up some day, but for now
758         this patch makes the two work identically rather than changing both.
759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
760
761 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
762
763         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
764         https://bugs.webkit.org/show_bug.cgi?id=174963
765
766         Reviewed by Darin Adler.
767
768         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
769         RetainPtr<>. This patch changes them to all use auto.
770
771         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
772         (TestWebKitAPI::TEST):
773
774 2017-07-30  Brady Eidson  <beidson@apple.com>
775
776         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
777         https://bugs.webkit.org/show_bug.cgi?id=174958
778
779         Reviewed by Darin Adler.
780
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
783         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
784         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
785         (runUntilTasksInFlight):
786         (TEST):
787
788 2017-07-28  Commit Queue  <commit-queue@webkit.org>
789
790         Unreviewed, rolling out r219990.
791         https://bugs.webkit.org/show_bug.cgi?id=174961
792
793         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
794         estes on #webkit).
795
796         Reverted changeset:
797
798         "Part 2 of: Rename DatabaseProcess to StorageProcess."
799         https://bugs.webkit.org/show_bug.cgi?id=174880
800         http://trac.webkit.org/changeset/219990
801
802 2017-07-28  Brady Eidson  <beidson@apple.com>
803
804         API tests that use URLSchemeHandler are failing.
805         https://bugs.webkit.org/show_bug.cgi?id=174950
806
807         Reviewed by Alex Christensen.
808
809         Fix the NoMIMEType test to be correct.
810
811         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
812         (-[SchemeHandler initWithData:mimeType:]):
813         (-[SchemeHandler webView:startURLSchemeTask:]):
814         (TEST):
815
816 2017-07-28  Daniel Bates  <dabates@apple.com>
817
818         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
819         https://bugs.webkit.org/show_bug.cgi?id=174876
820
821         Reviewed by Alex Christensen.
822
823         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
824         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
825         they provide a more direct way to test the platform abstraction.
826
827         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
828
829         * Scripts/prepare-ChangeLog:
830         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
831         of the current working directory.
832
833 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
834
835         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
836         https://bugs.webkit.org/show_bug.cgi?id=174930
837
838         Unreviewed test fix.
839
840         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
841
842         * Scripts/prepare-ChangeLog:
843         (get_function_line_ranges_for_cpp):
844
845 2017-07-28  JF Bastien  <jfbastien@apple.com>
846
847         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
848         https://bugs.webkit.org/show_bug.cgi?id=174930
849
850         Reviewed by Daniel Bates.
851
852         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
853         here also teach it about const and volatile overloads. I didn't do
854         reference and rvalue reference overloads because we don't really
855         use them, and the current parser throws away those characters and
856         it doesn't seem worth making it more complex.
857
858         * Scripts/prepare-ChangeLog:
859         (get_function_line_ranges_for_cpp):
860         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
861         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
862         (Foo::Arrow::arrow):
863         (Foo::Arrow::otherArrow):
864         (Foo::Arrow::otherArrow const):
865         (Foo::Arrow::otherArrow volatile):
866         (Foo::Arrow::otherArrow const volatile):
867
868 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
869
870         [GTK] Building with ENABLE_VIDEO=OFF fails
871         https://bugs.webkit.org/show_bug.cgi?id=174940
872
873         Reviewed by Alex Christensen.
874
875         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
876         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
877
878         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
879         (methodCallCallback): Add missing USE(GSTREAMER) guard.
880
881 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
882
883         [WPE] Implement EventSenderProxy in WTR
884         https://bugs.webkit.org/show_bug.cgi?id=173419
885
886         Reviewed by Žan Doberšek.
887
888         Add the implementation of EventSenderProxy to the WTR. This
889         allows us to extend the coverage of the test suite in WKWPE.
890
891         * WebKitTestRunner/EventSenderProxy.h:
892         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
893         libxkbcommon needed to deal with key events.
894         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
895         (WTR::EventSenderProxy::EventSenderProxy):
896         (WTR::senderButtonToWPEButton):
897         (WTR::EventSenderProxy::mouseDown):
898         (WTR::EventSenderProxy::mouseUp):
899         (WTR::EventSenderProxy::mouseMoveTo):
900         (WTR::EventSenderProxy::mouseScrollBy):
901         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
902         (WTR::EventSenderProxy::leapForward):
903         (WTR::wkEventModifiersToWPE):
904         (WTR::getXKBKeySymForKeyRef):
905         (WTR::EventSenderProxy::keyDown):
906         (WTR::EventSenderProxy::addTouchPoint):
907         (WTR::EventSenderProxy::updateTouchPoint):
908         (WTR::EventSenderProxy::setTouchModifier):
909         (WTR::EventSenderProxy::setTouchPointRadius):
910         (WTR::EventSenderProxy::getUpdatedTouchEvents):
911         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
912         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
913         (WTR::EventSenderProxy::touchStart):
914         (WTR::EventSenderProxy::touchMove):
915         (WTR::EventSenderProxy::touchEnd):
916         (WTR::EventSenderProxy::touchCancel):
917         (WTR::EventSenderProxy::clearTouchPoints):
918         (WTR::EventSenderProxy::releaseTouchPoint):
919         (WTR::EventSenderProxy::cancelTouchPoint):
920
921 2017-07-27  Brady Eidson  <beidson@apple.com>
922
923         Part 2 of: Rename DatabaseProcess to StorageProcess.
924         https://bugs.webkit.org/show_bug.cgi?id=174880
925
926         Reviewed by Andy Estes.
927
928         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
929         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
930         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
931         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
932         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
933         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
934         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
935         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
936
937 2017-07-26  Mark Lam  <mark.lam@apple.com>
938
939         Add ability to only run specific tests in run-javascriptcore-tests.
940         https://bugs.webkit.org/show_bug.cgi?id=174884
941
942         Reviewed by Saam Barati.
943
944         For example, if we only want to run testapi, we can do so as follows:
945             $ run-javascriptcore-tests --testapi
946
947         Previously, specifying --testapi effectively does nothing because we run all tests
948         by default.  Only --no-testapi had the effect of disabling the test set.  This
949         old behavior for --testapi is not very useful or meaningful.  We're now changing
950         it to mean that we will only run that test.
951
952         With this change, we can also run more than one set of tests.  For example, if we
953         only want to run testmasm and testair, we can do so as follows:
954             $ run-javascriptcore-tests --testmasm --testair
955
956         By default, if no specific test option is specified, run-javascriptcore-tests will
957         run all tests.
958
959         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
960         the mozilla tests (--mozilla-tests) even though both are run via the lower level
961         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
962         the other set will not run.  For example, the following only runs the mozilla tests:
963             $ run-javascriptcore-tests --mozilla-tests
964
965         Note also that --jit-stress-tests is not for choosing a different set of tests.
966         Instead, it is used for determining whether we run JIT'ed test configurations
967         on the jsc stress tests and mozilla tests.  As a result, specifying
968         --jit-stress-tests will not omit other tests.  For example, the following still
969         runs all tests:
970             $ run-javascriptcore-tests --jit-stress-tests
971
972         * Scripts/run-javascriptcore-tests:
973         (defaultStringForTestState):
974         (enableTestOrNot):
975         (runJSCStressTests):
976
977 2017-07-26  Mark Lam  <mark.lam@apple.com>
978
979         Make run-javascriptcore-test run testair, testb3, and testmasm.
980         https://bugs.webkit.org/show_bug.cgi?id=174837
981         <rdar://problem/33522927>
982
983         Reviewed by Saam Barati and Filip Pizlo.
984
985         1. Refactors code for running testapi so that we can use it to run other tests.
986         2. Added running of testmasm, testair, testb3.
987
988         Note: the existing testapi invocation code does not support remote invocation of
989         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
990         and testb3 also do not support remote invocation.  If we wish to add remote
991         invocation support, we should do that in a separate patch.
992
993         * Scripts/run-javascriptcore-tests:
994         (testPath):
995         (runTest):
996         (testapiPath): Deleted.
997
998 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
999
1000         Remove duplicate code from Buildbot.js in dashboard
1001         https://bugs.webkit.org/show_bug.cgi?id=174870
1002
1003         Reviewed by Daniel Bates.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1006         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1007         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1009         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1010
1011 2017-07-26  Brady Eidson  <beidson@apple.com>
1012
1013         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1014         https://bugs.webkit.org/show_bug.cgi?id=174851
1015
1016         Reviewed by Chris Dumez.
1017
1018         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1019         (TEST):
1020
1021 2017-07-26  Brian Burg  <bburg@apple.com>
1022
1023         Remove WEB_TIMING feature flag
1024         https://bugs.webkit.org/show_bug.cgi?id=174795
1025
1026         Reviewed by Alex Christensen.
1027
1028         * Scripts/webkitperl/FeatureList.pm:
1029         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1030
1031 2017-07-26  Chris Dumez  <cdumez@apple.com>
1032
1033         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1034         https://bugs.webkit.org/show_bug.cgi?id=174864
1035         <rdar://problem/33009088>
1036
1037         Reviewed by Geoffrey Garen.
1038
1039         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1040         WKTR.
1041
1042         * DumpRenderTree/mac/EventSendingController.mm:
1043         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1044
1045 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1046
1047         Unreviewed, added Romain Bellessort to contributors.json.
1048
1049         * Scripts/webkitpy/common/config/contributors.json:
1050
1051 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1052
1053         [WPE] WebGL2 support
1054         https://bugs.webkit.org/show_bug.cgi?id=174249
1055
1056         Reviewed by Alex Christensen.
1057
1058         * Scripts/webkitperl/FeatureList.pm:
1059         Enable WebGL2 for WPE when building through build-webkit.
1060
1061 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1062
1063         Unreviewed. Fix GTK distcheck.
1064
1065         * gtk/make-dist.py:
1066         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1067
1068 2017-07-25  Brady Eidson  <beidson@apple.com>
1069
1070         ResourceLoadStatistics grandfathering happens much too often.
1071         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1072
1073         Reviewed by Chris Dumez.
1074
1075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1076         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1077         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1078         (TEST):
1079
1080 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1081
1082         Fix autoinstaller failing on autoinstall_everything
1083         https://bugs.webkit.org/show_bug.cgi?id=174830
1084
1085         Reviewed by Joseph Pecoraro.
1086
1087         * Scripts/webkitpy/thirdparty/__init__.py:
1088         (AutoinstallImportHook.find_module):
1089         (AutoinstallImportHook.install_chromedriver):
1090         (AutoinstallImportHook.install_geckodriver):
1091         (AutoinstallImportHook._install_chromedriver): Deleted.
1092         (AutoinstallImportHook._install_geckodriver): Deleted.
1093
1094 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1095
1096         Replace --runtime with something for both ios-simulator and ios-device
1097         https://bugs.webkit.org/show_bug.cgi?id=173775
1098         <rdar://problem/32952164>
1099
1100         Reviewed by Aakash Jain.
1101
1102         Add --version flag for both iOS simulator and iOS device.
1103
1104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1105         (parse_args): Add --version flag and move --no-install.
1106         * Scripts/webkitpy/port/factory.py:
1107         (platform_options): Move --no-intall to run_webkit_tests.py.
1108         * Scripts/webkitpy/port/ios.py:
1109         (IOSPort):
1110         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1111         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1112         * Scripts/webkitpy/port/ios_device.py:
1113         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1114         devices for iOS version.
1115         * Scripts/webkitpy/port/ios_device_unittest.py:
1116         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1117         expectation paths without devices connected.
1118         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1119         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1120         (IOSDeviceTest.test_expectations_ordering): Deleted.
1121         * Scripts/webkitpy/port/ios_simulator.py:
1122         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1123         flag to specify a runtime.
1124         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1125         flag and then use the default runtime.
1126
1127 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1128
1129         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1130         https://bugs.webkit.org/show_bug.cgi?id=174815
1131
1132         Reviewed by Carlos Alberto Lopez Perez.
1133
1134         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1135         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1136         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1137         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1138         think), probably because of a newer CMake version.
1139
1140         * CMakeLists.txt:
1141         * TestWebKitAPI/CMakeLists.txt:
1142         * TestWebKitAPI/PlatformGTK.cmake:
1143
1144 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1145
1146         Fix BenchmarkRunner to only import selenium when needed
1147         https://bugs.webkit.org/show_bug.cgi?id=174808
1148
1149         Reviewed by Stephanie Lewis.
1150
1151         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1152         (LinuxChromeDriver.launch_driver):
1153         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1154         (LinuxFirefoxDriver.launch_driver):
1155         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1156         (OSXChromeDriver.launch_driver):
1157         (OSXChromeCanaryDriver.launch_driver):
1158         (create_chrome_options):
1159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1160         (OSXFirefoxDriver.launch_driver):
1161         (OSXFirefoxNightlyDriver.launch_driver):
1162         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1163         (OSXSafariDriver.launch_driver):
1164         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1165         (WebDriverBenchmarkRunner._run_one_test):
1166
1167 2017-07-23  Darin Adler  <darin@apple.com>
1168
1169         More NeverDestroyed and related cleanup
1170         https://bugs.webkit.org/show_bug.cgi?id=174745
1171
1172         Reviewed by Alex Christensen.
1173
1174         * DumpRenderTree/JavaScriptThreading.cpp:
1175         (javaScriptThreadsMutex): Use NeverDestroyed instead of
1176         DEPRECATED_DEFINE_STATIC_LOCAL.
1177         (javaScriptThreads): Ditto.
1178
1179 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1180
1181         Subclass Benchmark Runner script for WebDriver support
1182         https://bugs.webkit.org/show_bug.cgi?id=174390
1183
1184         Reviewed by Dewei Zhu, Stephanie Lewis.
1185
1186         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1187
1188         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1189         (BenchmarkBuilder.__init__):
1190         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1191         (BenchmarkRunner.__init__):
1192         (BenchmarkRunner._find_plan_file):
1193         (BenchmarkRunner._run_one_test.and):
1194         (BenchmarkRunner.execute):
1195         (BenchmarkRunner._get_result): Deleted.
1196         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1197         (parse_args):
1198         (start):
1199         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1200         (WebDriverBenchmarkRunner):
1201         (WebDriverBenchmarkRunner._get_result):
1202         (WebDriverBenchmarkRunner._run_one_test):
1203         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1204         (WebServerBenchmarkRunner):
1205         (WebServerBenchmarkRunner.__init__):
1206         (WebServerBenchmarkRunner._get_result):
1207         (WebServerBenchmarkRunner._run_one_test):
1208
1209 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1210
1211         Add BenchmarkRunner patches with WebDriver support for each testing plan
1212         https://bugs.webkit.org/show_bug.cgi?id=174443
1213
1214         Reviewed by Dewei Zhu, Stephanie Lewis.
1215
1216         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1217         (BenchmarkBuilder.__enter__):
1218         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1219         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1220         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1221         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1222         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1223         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1224         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1225         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1226         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1227         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1228         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1229         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1230         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1231         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1232         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1233         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1234         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1235         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1236         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1237         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1238         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1239         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1240         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1241         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1242         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1243         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1244         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1245         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1246         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1247         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1248         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1249         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1250         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1251
1252 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1253
1254         Add functions to autoinstaller needed for Benchmark Runner script
1255         https://bugs.webkit.org/show_bug.cgi?id=174331
1256
1257         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1258
1259         Adds autoinstaller functions to install selenium and webdriver binaries
1260         which will be used by the browser driver part of Benchmark Runner.
1261
1262         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1263         (BrowserDriver.restore_env):
1264         (BrowserDriver):
1265         (BrowserDriver.get_webdriver_binary_path):
1266         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1267         (LinuxChromeDriver.launch_driver):
1268         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1269         (LinuxFirefoxDriver.launch_driver):
1270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1271         (OSXChromeDriver.launch_driver):
1272         (OSXChromeCanaryDriver.launch_driver):
1273         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1274         (OSXFirefoxDriver.launch_driver):
1275         (OSXFirefoxNightlyDriver.launch_driver):
1276         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1277         * Scripts/webkitpy/benchmark_runner/utils.py:
1278         (get_driver_binary_path):
1279         * Scripts/webkitpy/common/system/autoinstall.py:
1280         (AutoInstaller._unzip):
1281         * Scripts/webkitpy/thirdparty/__init__.py:
1282         (AutoinstallImportHook.find_module):
1283         (AutoinstallImportHook._install_selenium):
1284         (AutoinstallImportHook):
1285         (AutoinstallImportHook._install_chromedriver):
1286         (AutoinstallImportHook._install_geckodriver):
1287         (AutoinstallImportHook.get_latest_pypi_url):
1288         (AutoinstallImportHook.install_binary):
1289         (autoinstall_everything):
1290         (get_driver_filename):
1291         (get_os_info):
1292
1293 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1294
1295         Add WebDriver support in browser driver part of BenchmarkRunner
1296         https://bugs.webkit.org/show_bug.cgi?id=174445
1297
1298         Reviewed by Stephanie Lewis.
1299
1300         Adds a launch_driver function to each BrowserDriver subclass. This
1301         function sets up the arguments for the webdriver and launches the
1302         webdriver specific to that browser.
1303
1304         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1305         (BrowserDriver.launch_webdriver):
1306         (BrowserDriver):
1307         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1308         (LinuxBrowserDriver.launch_webdriver):
1309         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1310         (LinuxChromeDriver.launch_url):
1311         (LinuxChromeDriver):
1312         (LinuxChromeDriver.launch_driver):
1313         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1314         (EpiphanyBrowserDriver.launch_url):
1315         (EpiphanyBrowserDriver):
1316         (EpiphanyBrowserDriver.launch_driver):
1317         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1318         (LinuxFirefoxDriver):
1319         (LinuxFirefoxDriver.launch_url):
1320         (LinuxFirefoxDriver.launch_driver):
1321         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1322         (GTKMiniBrowserDriver.launch_url):
1323         (GTKMiniBrowserDriver):
1324         (GTKMiniBrowserDriver.launch_driver):
1325         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1326         (OSXBrowserDriver._launch_webdriver):
1327         (OSXBrowserDriver):
1328         (OSXBrowserDriver._screen_size):
1329         (OSXBrowserDriver._insert_url):
1330         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1331         (OSXChromeDriver):
1332         (OSXChromeDriver.launch_url):
1333         (OSXChromeDriver.launch_driver):
1334         (OSXChromeCanaryDriver):
1335         (OSXChromeCanaryDriver.launch_url):
1336         (OSXChromeCanaryDriver.launch_driver):
1337         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1338         (OSXFirefoxDriver):
1339         (OSXFirefoxDriver.launch_url):
1340         (OSXFirefoxDriver.launch_driver):
1341         (OSXFirefoxNightlyDriver):
1342         (OSXFirefoxNightlyDriver.launch_url):
1343         (OSXFirefoxNightlyDriver.launch_driver):
1344         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1345         (OSXSafariDriver.launch_driver):
1346
1347 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1348
1349         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1350         https://bugs.webkit.org/show_bug.cgi?id=174793
1351
1352         Reviewed by Tim Horton.
1353
1354         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1355         down. Without r219765, this test will dereference null and crash.
1356
1357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1358         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1359         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1360         (TEST):
1361
1362 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1363
1364         [Win] Implement Authentication dialog in MiniBrowser
1365         https://bugs.webkit.org/show_bug.cgi?id=174662
1366
1367         Reviewed by Alex Christensen.
1368
1369         * MiniBrowser/win/Common.cpp:
1370         (CustomUserAgent):
1371         (DisplayAuthDialog):
1372         (AuthDialogProc):
1373         * MiniBrowser/win/MiniBrowserLib.rc:
1374         * MiniBrowser/win/MiniBrowserLibResource.h:
1375         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1376         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1377
1378 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1379
1380         Handle case where line_numbers is None instead of an array of line numbers
1381         https://bugs.webkit.org/show_bug.cgi?id=174775
1382
1383         Reviewed by Aakash Jain.
1384
1385         Added files set line_numbers to None in process_file.
1386
1387         * Scripts/webkitpy/style/filereader.py:
1388         (TextFileReader.process_file): Handle case where line_number is set to None.
1389         * Scripts/webkitpy/style/main_unittest.py:
1390         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1391
1392 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1393
1394         [WPE] Add libepoxy to the Jhbuild moduleset
1395         https://bugs.webkit.org/show_bug.cgi?id=174711
1396
1397         Reviewed by Carlos Alberto Lopez Perez.
1398
1399         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1400
1401 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1402
1403         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1404         https://bugs.webkit.org/show_bug.cgi?id=174780
1405
1406         Reviewed by Carlos Garcia Campos.
1407
1408         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1409         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1410         in case the eglplatform.h header doesn't provide that macro. This replicates
1411         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1412
1413 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1414
1415         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1416         https://bugs.webkit.org/show_bug.cgi?id=174758
1417
1418         Reviewed by Dan Bernstein.
1419
1420         Migrate position-information-related unit tests from the PositionInformationTests suite to
1421         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1425         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1426         (TestWebKitAPI::TEST):
1427         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1428         * TestWebKitAPI/cocoa/TestWKWebView.h:
1429         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1430         (-[TestWKWebView activatedElementAtPosition:]):
1431
1432 2017-07-22  Chris Dumez  <cdumez@apple.com>
1433
1434         REGRESSION(r204565): WKObject is broken
1435         https://bugs.webkit.org/show_bug.cgi?id=174736
1436         <rdar://problem/33246169>
1437
1438         Reviewed by Dan Bernstein.
1439
1440         Add API test that used to crash.
1441
1442         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1443         (TestWebKitAPI::TEST):
1444
1445 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1446
1447         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1448         https://bugs.webkit.org/show_bug.cgi?id=174705
1449
1450         Reviewed by Mark Lam.
1451
1452         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1453         (TestWebKitAPI::testThreadGroup):
1454         (TestWebKitAPI::TEST):
1455
1456 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1457
1458         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1459         https://bugs.webkit.org/show_bug.cgi?id=174724
1460
1461         Reviewed by Aakash Jain.
1462
1463         * Scripts/webkitpy/port/ios_simulator.py:
1464         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1465         simulator. Errors here should be treated the same as no simulators found.
1466
1467 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1468
1469         [CMake] Add an option to stop build after generating project files
1470         https://bugs.webkit.org/show_bug.cgi?id=174664
1471
1472         Reviewed by Konstantin Tokarev.
1473
1474         Add "--generate-project-only" to stop build after generating project files.
1475
1476         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1477         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1478         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1479         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1480         (isGenerateProjectOnly): ditto
1481
1482 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1483
1484         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1485         https://bugs.webkit.org/show_bug.cgi?id=174501
1486
1487         Reviewed by Darin Adler.
1488
1489         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1490         (TestWebKitAPI::TEST):
1491
1492 2017-07-20  David Quesada  <david_quesada@apple.com>
1493
1494         Add SPI to notify WKNavigationDelegate about client redirects
1495         https://bugs.webkit.org/show_bug.cgi?id=174680
1496         rdar://problem/33184886
1497
1498         Reviewed by Brady Eidson.
1499
1500         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1501         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1502         (TEST):
1503         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1504
1505 2017-07-20  Brady Eidson  <beidson@apple.com>
1506
1507         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1508         https://bugs.webkit.org/show_bug.cgi?id=174685
1509
1510         Reviewed by Andy Estes.
1511
1512         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1513         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1514
1515 2017-07-20  Brady Eidson  <beidson@apple.com>
1516
1517         Deprecate WebIconDatabase in WebKitLegacy/mac.
1518         https://bugs.webkit.org/show_bug.cgi?id=174607
1519
1520         Reviewed by Alex Christensen.
1521
1522         * DumpRenderTree/mac/TestRunnerMac.mm:
1523
1524 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1525
1526         lint-test-expectations should be run during style checking
1527         https://bugs.webkit.org/show_bug.cgi?id=173559
1528         <rdar://problem/32854941>
1529
1530         Reviewed by Aakash Jain.
1531
1532         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1533         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1534         prevents identifying errors on specific lines in a file.
1535         * Scripts/webkitpy/style/main_unittest.py:
1536         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1537         case where a linter error is in the file modified, but the line modified is not related to
1538         the linter error.
1539
1540 2017-07-20  Brady Eidson  <beidson@apple.com>
1541
1542         Remove WebIconDatabase from WebKitLegacy/win.
1543         https://bugs.webkit.org/show_bug.cgi?id=174608
1544
1545         Reviewed by Alex Christensen.
1546
1547         * DumpRenderTree/win/DumpRenderTree.cpp:
1548         (main):
1549         * DumpRenderTree/win/TestRunnerWin.cpp:
1550         (TestRunner::setIconDatabaseEnabled):
1551
1552 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1553
1554         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1555         https://bugs.webkit.org/show_bug.cgi?id=174671
1556
1557         Reviewed by Carlos Garcia Campos.
1558
1559         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1560         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1561         priority for this source in order to have it dispatched on the same
1562         priority as the other WebKit-controlled GSource objects.
1563
1564 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1565
1566         lint-test-expectations should be run during style checking
1567         https://bugs.webkit.org/show_bug.cgi?id=173559
1568         <rdar://problem/32854941>
1569
1570         Reviewed by Daniel Bates.
1571
1572         Follow up fix addressing style and a few minor bugs.
1573
1574         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1575         (TestExpectationParser.__init__): Use lambda x: x instead of str
1576         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1577         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1578         reduce the calls of _shorten_filename, fix minor bug in appending the current
1579         expectation's line number instead of the previous ones, clarify treatment of None
1580         in file-to-line-number mapping.
1581         (TestExpectations._report_warnings): Collapse call.
1582         * Scripts/webkitpy/style/checkers/test_expectations.py:
1583         (TestExpectationsChecker.lint_test_expectations):
1584         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1585         (TextFileReader.process_file): Add comment explaining treatment of None in
1586         file-to-line-number mapping.
1587         (TextFileReader.delete_file): Collapse call.
1588
1589 2017-07-19  Chris Dumez  <cdumez@apple.com>
1590
1591         Unreviewed attempt to fix API test failure after r219663.
1592
1593         The test was hard-coding an exception string and the string has changed slightly
1594         in r219663.
1595
1596         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1597         (TEST):
1598
1599 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1600
1601         Don't write file URLs to iOS Pasteboard
1602         https://bugs.webkit.org/show_bug.cgi?id=174647
1603         <rdar://problem/33199730>
1604
1605         Reviewed by Wenson Hsieh.
1606
1607         Updating tests to reflect the lack of file URLs for images.
1608
1609         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1610         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1611         (checkEstimatedSize):
1612         (TestWebKitAPI::TEST):
1613
1614 2017-07-19  Brady Eidson  <beidson@apple.com>
1615
1616         iBooks sometimes crashes when closing a book.
1617         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1618
1619         Reviewed by Oliver Hunt.
1620
1621         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1622         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1623         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1624         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1625         (TestWebKitAPI::TEST):
1626
1627         Add a "spin the runloop X number of times" utility:
1628         * TestWebKitAPI/Utilities.h:
1629         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1630         (TestWebKitAPI::Util::spinRunLoop):
1631
1632 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1633
1634         lint-test-expectations should be run during style checking
1635         https://bugs.webkit.org/show_bug.cgi?id=173559
1636         <rdar://problem/32854941>
1637
1638         Reviewed by David Kilzer.
1639
1640         Running the test expectation linter requires reading both files and lines not in the
1641         patch because, for example, deletion of a test can cause a lint failure even though
1642         no test expectations where modified. This means that the linter will occasionally warn
1643         about lines which were not changed in a given patch but whose error is related to a
1644         change made in that patch.
1645
1646         * Scripts/webkitpy/common/system/filesystem_mock.py:
1647         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1648         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1649         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1650         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1651         content, description of the error and the name of the associated test.
1652         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1653         (TestExpectationParser.__init__): Pass shorten_filename function to
1654         TestExpectationsParser to add a deleted file to the related_files dictionary.
1655         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1656         missing path to the related_files dictionary.
1657         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1658         files and line numbers related to this test expectation line. This will allow
1659         tracking linter errors in the style checker occurring across multiple files.
1660         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1661         lines to related_files dictionary.
1662         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1663         (TestExpectations._report_warnings): Construct warning object instead of string
1664         when adding to warnings list.
1665         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1666         clean-up log.
1667         * Scripts/webkitpy/style/checker.py:
1668         (ProcessorBase.do_association_check): Add required function for processor classes.
1669         (StyleProcessor):
1670         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1671         checking for errors between associated files.
1672         * Scripts/webkitpy/style/checkers/test_expectations.py:
1673         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1674         (TestExpectationsChecker):
1675         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1676         of modified files, the current working directory and the host, determine if the linter
1677         warning is associated with the changes.
1678         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1679         style checker.
1680         * Scripts/webkitpy/style/filereader.py:
1681         (TextFileReader):
1682         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1683         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1684         (TextFileReader.process_file): Track both the number of files changed and which lines
1685         in those files were changed.
1686         (TextFileReader.do_association_check): Run the processor's association check on all
1687         modified or deleted files processed by TextFileReader.
1688         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1689         (TextFileReader.count_delete_only_file): Deleted.
1690         * Scripts/webkitpy/style/filereader_unittest.py:
1691         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1692         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1693         * Scripts/webkitpy/style/main.py:
1694         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1695         explicitly run the association check on the file reader.
1696         * Scripts/webkitpy/style/main_unittest.py:
1697         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1698         embedded in the style checker.
1699         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1700         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1701         construct the TextFileReader object with a StyleProcessor used to run style checks on
1702         specific files.
1703         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1704         testing the test expectation linter inside the style checker. This host must contain a
1705         mock file system with the basic structure of test expectations.
1706         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1707         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1708         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1709         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1710         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1711         * Scripts/webkitpy/style/patchreader.py:
1712         (PatchReader.check): Specify which file was deleted, run the association check.
1713         * Scripts/webkitpy/style/patchreader_unittest.py:
1714         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1715         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1716         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1717
1718 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1719
1720         [WTF] Implement WTF::ThreadGroup
1721         https://bugs.webkit.org/show_bug.cgi?id=174081
1722
1723         Reviewed by Mark Lam.
1724
1725         Add WTF::ThreadGroup tests.
1726
1727         * TestWebKitAPI/CMakeLists.txt:
1728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1729         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1730         (TestWebKitAPI::testThreadGroup):
1731         (TestWebKitAPI::TEST):
1732
1733 2017-07-18  Andy Estes  <aestes@apple.com>
1734
1735         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1736         https://bugs.webkit.org/show_bug.cgi?id=174631
1737
1738         Reviewed by Tim Horton.
1739
1740         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1741         * MiniBrowser/Configurations/Base.xcconfig:
1742         * MobileMiniBrowser/Configurations/Base.xcconfig:
1743         * TestWebKitAPI/Configurations/Base.xcconfig:
1744         * WebKitTestRunner/Configurations/Base.xcconfig:
1745
1746 2017-07-18  Andy Estes  <aestes@apple.com>
1747
1748         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1749         https://bugs.webkit.org/show_bug.cgi?id=174631
1750
1751         Reviewed by Sam Weinig.
1752
1753         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1754         * MiniBrowser/Configurations/Base.xcconfig:
1755         * MobileMiniBrowser/Configurations/Base.xcconfig:
1756         * TestWebKitAPI/Configurations/Base.xcconfig:
1757         * WebKitTestRunner/Configurations/Base.xcconfig:
1758
1759 2017-07-18  Daniel Bates  <dabates@apple.com>
1760
1761         lldb: Add type summary for StringView
1762         https://bugs.webkit.org/show_bug.cgi?id=174637
1763
1764         Reviewed by Sam Weinig.
1765
1766         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1767         StringView object will print output that has the form:
1768
1769             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1770               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1771               m_length = 2
1772               m_is8Bit = true
1773               m_underlyingString = 0x0000614000000a90
1774             }
1775
1776         * lldb/lldb_webkit.py:
1777         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1778         (WTFStringView_SummaryProvider):
1779         (WTFStringViewProvider):
1780         (WTFStringViewProvider.__init__):
1781         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1782         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1783         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1784         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1785
1786 2017-07-18  Andy Estes  <aestes@apple.com>
1787
1788         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1789         https://bugs.webkit.org/show_bug.cgi?id=174631
1790
1791         Reviewed by Dan Bernstein.
1792
1793         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1794         * MiniBrowser/Configurations/Base.xcconfig:
1795         * MobileMiniBrowser/Configurations/Base.xcconfig:
1796         * TestWebKitAPI/Configurations/Base.xcconfig:
1797         * WebKitTestRunner/Configurations/Base.xcconfig:
1798
1799 2017-07-18  Devin Rousso  <drousso@apple.com>
1800
1801         Web Inspector: Add memoryCost to Inspector Protocol objects
1802         https://bugs.webkit.org/show_bug.cgi?id=174478
1803
1804         Reviewed by Joseph Pecoraro.
1805
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1808         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1809         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1810         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1811         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1812         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1813         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1814         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1815         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1816         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1817         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1818         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1819         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1820         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1821         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1822         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1823
1824 2017-07-18  Andy Estes  <aestes@apple.com>
1825
1826         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1827         https://bugs.webkit.org/show_bug.cgi?id=174631
1828
1829         Reviewed by Darin Adler.
1830
1831         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1832         * MiniBrowser/Configurations/Base.xcconfig:
1833         * MobileMiniBrowser/Configurations/Base.xcconfig:
1834         * TestWebKitAPI/Configurations/Base.xcconfig:
1835         * WebKitTestRunner/Configurations/Base.xcconfig:
1836
1837 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1838
1839         Unreviewed, fix the iOS build.
1840
1841         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1842
1843         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1844         (TestWebKitAPI::TEST):
1845
1846 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1847
1848         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1849         https://bugs.webkit.org/show_bug.cgi?id=174585
1850         <rdar://problem/33302541>
1851
1852         Reviewed by Tim Horton.
1853
1854         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1855         being dragged when initiating a drag.
1856
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1858         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1859         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/cocoa/TestWKWebView.h:
1862
1863         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1864
1865         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1866         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1867
1868 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1869
1870         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1871         https://bugs.webkit.org/show_bug.cgi?id=174547
1872
1873         Reviewed by Alex Christensen.
1874
1875         * DumpRenderTree/PlatformWin.cmake:
1876         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1877
1878 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1879
1880         Update style checker to deal with "final"
1881         https://bugs.webkit.org/show_bug.cgi?id=174528
1882
1883         Reviewed by Alex Christensen.
1884         
1885         check-webkit-style shouldn't complain about an open brace to start a
1886         line after a function definition with "final" or "const final".
1887
1888         * Scripts/webkitpy/style/checkers/cpp.py:
1889         (check_braces):
1890         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1891         (CppStyleTest.test_brace_at_begin_of_line):
1892
1893 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1894
1895         Modernize content extension code
1896         https://bugs.webkit.org/show_bug.cgi?id=174588
1897
1898         Reviewed by Sam Weinig.
1899
1900         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1901         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1902         (TestWebKitAPI::testRequest):
1903         (TestWebKitAPI::makeBackend):
1904         (TestWebKitAPI::TEST_F):
1905
1906 2017-07-17  Brady Eidson  <beidson@apple.com>
1907
1908         WKHTTPCookieStore observing only works on the default cookie store.
1909         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1910
1911         Reviewed by Sam Weinig.
1912
1913         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1914         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1915           called for the default store, a non-persistent store, and a custom store.
1916         (TEST):
1917
1918 2017-07-16  Sam Weinig  <sam@webkit.org>
1919
1920         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1921         https://bugs.webkit.org/show_bug.cgi?id=174575
1922
1923         Reviewed by Brady Eidson.
1924
1925         * Scripts/svn-create-patch:
1926         (findModificationType):
1927         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1928         default value of "unknown".
1929
1930         (generateFileList):
1931         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1932         for untracked, which matches our old behavior.
1933
1934 2017-07-17  Charlie Turner  <cturner@igalia.com>
1935
1936         Add some missing build dependencies on Fedora
1937         https://bugs.webkit.org/show_bug.cgi?id=174578
1938
1939         Unreviewed dependency update.
1940
1941         * gtk/install-dependencies:
1942
1943 2017-07-16  Brady Eidson  <beidson@apple.com>
1944
1945         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1946         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1947
1948         Reviewed by Tim Horton.
1949
1950         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1951         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1952         (TEST):
1953
1954 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1955
1956         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1957         https://bugs.webkit.org/show_bug.cgi?id=174540
1958
1959         Reviewed by Michael Catanzaro.
1960
1961         * gtk/generate-inspector-gresource-manifest.py:
1962         (get_filenames): sort list of input files
1963
1964 2017-07-15  Brady Eidson  <beidson@apple.com>
1965
1966         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1967         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1968
1969         Reviewed by Tim Horton.
1970
1971         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1972         (TEST): Make this test more reliable by clearing everything beforehand.
1973
1974 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1975
1976         Make it possible to extend check-webkit-style with Apple-internal checkers
1977         <https://webkit.org/b/174464>
1978         <rdar://problem/25564402>
1979
1980         Reviewed by Darin Adler.
1981
1982         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1983         (_all_categories): Add categories from apple_additions() if it
1984         exists.
1985         (CheckerDispatcher._create_checker): Create python checker
1986         from apple_additions() if it exists.
1987
1988 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1989
1990         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1991         https://bugs.webkit.org/show_bug.cgi?id=174539
1992         <rdar://problem/33307395>
1993
1994         Reviewed by Darin Adler.
1995
1996         Adds a new unit test suite to cover action sheet popover presentation.
1997
1998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1999         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2000         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2001         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2002
2003         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2004
2005         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2006         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2007
2008         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2009
2010         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2011         (TestWebKitAPI::TEST):
2012
2013 2017-07-15  Sam Weinig  <sam@webkit.org>
2014
2015         [Scripts] Make svn-create-patch work better when called in sub directories
2016         https://bugs.webkit.org/show_bug.cgi?id=174551
2017
2018         Reviewed by Darin Adler.
2019
2020         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2021           by ensuring that the prefix is applied as is done in generateDiff.
2022         - Silence output of explanatory lines from svn stat (" > move to ...")
2023           that show up in STDERR when running svn-create-patch.
2024         - Add verbose logging that I found useful while debugging this issue.
2025
2026         * Scripts/svn-create-patch:
2027         (findBaseUrl):
2028         (findMimeType):
2029         (findSourceFileAndRevision):
2030         (generateDiff):
2031         (generateFileList):
2032         (manufacturePatchForAdditionWithHistory):
2033
2034 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2035
2036         Unreviewed build fix after r219537.
2037
2038         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2039
2040 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2041
2042         Add iOS 11 SPI
2043         https://bugs.webkit.org/show_bug.cgi?id=174430
2044         <rdar://problem/33269288>
2045
2046         Reviewed by Tim Horton.
2047
2048         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2049         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2050         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2051
2052 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2053
2054         Failing to install on iPad simulators
2055         https://bugs.webkit.org/show_bug.cgi?id=174532
2056         <rdar://problem/33328347>
2057
2058         Reviewed by Stephanie Lewis.
2059
2060         * Scripts/webkitpy/xcode/simulated_device.py:
2061         (SimulatedDevice.install_app): Place install command in retry try-except block.
2062
2063 2017-07-14  Jeff Miller  <jeffm@apple.com>
2064
2065         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2066         https://bugs.webkit.org/show_bug.cgi?id=174524
2067
2068         Reviewed by Sam Weinig.
2069
2070         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2071         (TEST):
2072         Renamed TestParameter to TestParameter1.
2073         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2074
2075         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2076         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2077         Observe changes for two bundle parameters.
2078
2079         (-[BundleParametersPlugIn dealloc]):
2080         Remove observers for two bundle parameters.
2081
2082 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2083
2084         Unreviewed, rolling out r219510.
2085         https://bugs.webkit.org/show_bug.cgi?id=174525
2086
2087         Need to revert length() == 0 check for null string (Requested
2088         by yusukesuzuki on #webkit).
2089
2090         Reverted changeset:
2091
2092         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2093         static string if StringImpl is static"
2094         https://bugs.webkit.org/show_bug.cgi?id=174501
2095         http://trac.webkit.org/changeset/219510
2096
2097 2017-07-14  Jer Noble  <jer.noble@apple.com>
2098
2099         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2100         https://bugs.webkit.org/show_bug.cgi?id=174514
2101
2102         Reviewed by Sam Weinig.
2103
2104         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2105         (TestWebKitAPI::TEST_F):
2106
2107 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2108
2109         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2110         https://bugs.webkit.org/show_bug.cgi?id=174501
2111
2112         Reviewed by Darin Adler.
2113
2114         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2115         (TestWebKitAPI::TEST):
2116
2117 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2118
2119         Bring mac expectations in-line with other platforms
2120         https://bugs.webkit.org/show_bug.cgi?id=174472
2121         <rdar://problem/33297388>
2122
2123         Reviewed by David Kilzer.
2124
2125         The override order for Mac test expectations does not conform to the pattern used by iOS,
2126         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2127
2128             platform/mac-wk2
2129             platform/wk2
2130             platform/mac-elcapitan
2131             platform/mac-sierra
2132             generic
2133
2134         After this change, El Capitan's baseline search path looks like this:
2135
2136             platform/mac-sierra-wk2
2137             platform/mac-sierra
2138             platform/mac-wk2
2139             platform/wk2
2140             generic
2141
2142         * Scripts/webkitpy/port/mac.py:
2143         (MacPort.__init__): If a specific version is specified in the port name, use that
2144         as the os version.
2145         (MacPort.default_baseline_search_path): Expectation search paths should work the
2146         same way they do on other ports. Port + version overrides port, port overrides generic
2147         and wk1/wk2 should override expectations for the two combined.
2148         * Scripts/webkitpy/port/mac_unittest.py:
2149         (MacTest.test_tests_for_other_platforms): Deleted.
2150         (MacTest._assert_search_path): Deleted.
2151         (MacTest.test_baseline_search_path): Deleted.
2152         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2153         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
2154         (test_rebaseline_test_and_print_scm_changes): Ditto.
2155         (test_rebaseline_and_copy_test): Ditto.
2156         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
2157         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
2158         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
2159
2160 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2161
2162         Fix style checker unit test
2163
2164         Unreviewed WebKit2 => WebKit fixup.
2165
2166         * Scripts/webkitpy/style/checker_unittest.py:
2167         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2168
2169 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2170
2171         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
2172
2173         Unreviewed build fix.
2174
2175         r219492 missed one hunk from its partial revert of r219489.
2176         This patch reverts that hunk.
2177
2178         * TestWebKitAPI/CMakeLists.txt:
2179
2180 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2181
2182         Use the old WebKit/WebKit2 targets for CMake builds.
2183
2184         Unreviewed build fix.
2185
2186         We can update the target names to match the Framework names in a future patch.
2187         This is a partial revert of r219489.
2188
2189         * TestWebKitAPI/CMakeLists.txt:
2190         WebKitLegacy => WebKit
2191         WebKit => WebKit2
2192
2193 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2194
2195         Fix TestWebKit API.
2196         https://bugs.webkit.org/show_bug.cgi?id=174164
2197         rdar://problem/33137595
2198
2199         Reviewed by Dan Bernstein.
2200
2201         * TestWebKitAPI/CMakeLists.txt:
2202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2203         * TestWebKitAPI/PlatformGTK.cmake:
2204
2205 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2206
2207         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2208         https://bugs.webkit.org/show_bug.cgi?id=174164
2209         rdar://problem/33137595
2210
2211         Reviewed by Dan Bernstein.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2214         (ShouldBuildTest):
2215         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2216         * Scripts/build-webkit:
2217         * Scripts/do-file-rename:
2218         * Scripts/do-webcore-rename:
2219         * Scripts/update-webkit-localizable-strings:
2220         * Scripts/webkitpy/common/config/watchlist:
2221         * Scripts/webkitpy/style/checker.py:
2222         * Scripts/webkitpy/style/checkers/featuredefines.py:
2223         * gtk/make-dist.py:
2224         (ensure_version_if_possible):
2225         * gtk/manifest.txt.in:
2226
2227 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2228
2229         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2230         https://bugs.webkit.org/show_bug.cgi?id=174162
2231         rdar://problem/33137594
2232
2233         Reviewed by Dan Bernstein.
2234
2235         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2236
2237         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2238         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2239         * EWSTools/configure-clang-linux.sh:
2240         * Scripts/build-webkit:
2241         * Scripts/do-file-rename:
2242         * Scripts/do-webcore-rename:
2243         * Scripts/update-webkit-localizable-strings:
2244         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2245         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2246         * Scripts/webkitpy/style/checkers/featuredefines.py:
2247         * gtk/manifest.txt.in:
2248
2249 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2250
2251         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2252         https://bugs.webkit.org/show_bug.cgi?id=174438
2253         <rdar://problem/33277112>
2254
2255         Reviewed by Aakash Jain.
2256
2257         Given a patch, this will convert the changes from the path to the new directory structure.
2258
2259         * Scripts/rebase-patch-after-webkit-move: Added.
2260         (append_source): Append 'Source' to the provided path.
2261         (is_editable_line): Return true if a line the script expects to modify.
2262         (needs_rebase): Return if a line needs to be rebased based on it's content.
2263         (rebase_line): Rebase the provided line.
2264         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2265         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2266         were provided.
2267
2268 2017-07-12  Nan Wang  <n_wang@apple.com>
2269
2270         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2271         https://bugs.webkit.org/show_bug.cgi?id=174393
2272         <rdar://problem/33248006>
2273
2274         Reviewed by Chris Fleizach.
2275
2276         * DumpRenderTree/AccessibilityUIElement.cpp:
2277         (textMarkerRangeMatchesTextNearMarkersCallback):
2278         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2279         (AccessibilityUIElement::getJSClass):
2280         * DumpRenderTree/AccessibilityUIElement.h:
2281         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2282         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2283         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2284         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2285         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2286         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2287         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2288         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2289
2290 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2291
2292         Unreviewed, rolling out r219409.
2293
2294         The revision caused the Windows builds to fail.
2295
2296         Reverted changeset:
2297
2298         "AX: [iOS] Implement a way to retrieve a text marker range
2299         with desired text that is closest to a position"
2300         https://bugs.webkit.org/show_bug.cgi?id=174393
2301         http://trac.webkit.org/changeset/219409
2302
2303 2017-07-12  Nan Wang  <n_wang@apple.com>
2304
2305         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2306         https://bugs.webkit.org/show_bug.cgi?id=174393
2307         <rdar://problem/33248006>
2308
2309         Reviewed by Chris Fleizach.
2310
2311         * DumpRenderTree/AccessibilityUIElement.cpp:
2312         (textMarkerRangeMatchesTextNearMarkersCallback):
2313         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2314         (AccessibilityUIElement::getJSClass):
2315         * DumpRenderTree/AccessibilityUIElement.h:
2316         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2317         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2318         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2319         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2321         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2322         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2323         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2324
2325 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2326
2327         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2328         https://bugs.webkit.org/show_bug.cgi?id=174197
2329
2330         Reviewed by Darin Adler.
2331
2332         This bit me the first time I tried to submit a patch to WebKit, and still I have
2333         to manually edit the ChangeLog every time I use the script.
2334
2335         This generates a more convenient and standard ChangeLog entry.
2336
2337         * Scripts/prepare-ChangeLog:
2338         (generateNewChangeLogs):
2339
2340 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2341
2342         Unreviewed, rolling out r219401.
2343
2344         This revision rolled out the previous patch, but after talking
2345         with reviewer, a rebaseline is what was needed.Rolling back in
2346         before rebaseline.
2347
2348         Reverted changeset:
2349
2350         "Unreviewed, rolling out r219379."
2351         https://bugs.webkit.org/show_bug.cgi?id=174400
2352         http://trac.webkit.org/changeset/219401
2353
2354 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2355
2356         Unreviewed, rolling out r219379.
2357
2358         This revision caused a consistent failure in the test
2359         fast/dom/Window/property-access-on-cached-window-after-frame-
2360         removed.html.
2361
2362         Reverted changeset:
2363
2364         "Remove NAVIGATOR_HWCONCURRENCY"
2365         https://bugs.webkit.org/show_bug.cgi?id=174400
2366         http://trac.webkit.org/changeset/219379
2367
2368 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2369
2370         [WPE] Use libepoxy
2371         https://bugs.webkit.org/show_bug.cgi?id=172104
2372
2373         Reviewed by Michael Catanzaro.
2374
2375         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2376         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2377
2378 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2379
2380         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2381         https://bugs.webkit.org/show_bug.cgi?id=174363
2382
2383         Reviewed by Michael Catanzaro.
2384
2385         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2386         between the GTK+ and WPE port. There's no reason for the two ports to apply
2387         different patches over same versions of GStreamer releases.
2388
2389         This aligns the two ports on this specific issue. Next we'll look into
2390         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2391         to keep these patches in a single place, avoiding duplicate files.
2392
2393         * gtk/jhbuild.modules:
2394         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2395         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2396         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2397         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2398
2399 2017-07-11  Dean Jackson  <dino@apple.com>
2400
2401         Remove NAVIGATOR_HWCONCURRENCY
2402         https://bugs.webkit.org/show_bug.cgi?id=174400
2403
2404         Reviewed by Sam Weinig.
2405
2406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2407
2408 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2409
2410         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2411         https://bugs.webkit.org/show_bug.cgi?id=174239
2412
2413         Reviewed by Brady Eidson.
2414
2415         Create windows with specific features set and make sure those are properly reflected in the
2416         WKWindowFeatures object.
2417
2418         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2419         (resetToConsistentState):
2420         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2421         (TEST):
2422
2423 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2424
2425         Do not duplicate files when deleting directories with svn 1.9
2426         https://bugs.webkit.org/show_bug.cgi?id=174339
2427         <rdar://problem/33226781>
2428
2429         Reviewed by David Kilzer.
2430
2431         * Scripts/svn-create-patch:
2432         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2433         (generateFileList): Determine which files are deleted because they are part of a
2434         directory being deleted.
2435
2436 2017-07-11  Dean Jackson  <dino@apple.com>
2437
2438         Rolling out r219372.
2439
2440         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2441
2442 2017-07-11  Dean Jackson  <dino@apple.com>
2443
2444         Remove NAVIGATOR_HWCONCURRENCY
2445         https://bugs.webkit.org/show_bug.cgi?id=174400
2446
2447         Reviewed by Sam Weinig.
2448
2449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2450
2451 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2452
2453         Teach build workers to fetch archives from S3.
2454         https://bugs.webkit.org/show_bug.cgi?id=174384
2455
2456         Reviewed by Aakash Jain.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2459         (DownloadBuiltProduct):
2460
2461 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2462
2463         Configure buildbot to transfer all archives to S3.
2464         Previously this was Mac only, but it's time to expand!
2465         https://bugs.webkit.org/show_bug.cgi?id=174378
2466         
2467         Reviewed by Aakash Jain.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2470         (BuildFactory.__init__):
2471
2472 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2473
2474         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2475         https://bugs.webkit.org/show_bug.cgi?id=174350
2476
2477         Reviewed by Xabier Rodriguez-Calvar.
2478
2479         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2480         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2481         patches are removed. The patches for gst-plugins-good are updated, removing
2482         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2483         rtpbin elements that will help with the EMEv3 development.
2484
2485         * wpe/jhbuild.modules:
2486         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2487         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2488         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2489         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2490         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2491         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2492         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2493         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2494         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2495
2496 2017-07-10  John Wilander  <wilander@apple.com>
2497
2498         Resource Load Statistics: Prune statistics in orders of importance
2499         https://bugs.webkit.org/show_bug.cgi?id=174215
2500         <rdar://problem/33164403>
2501
2502         Reviewed by Chris Dumez.
2503
2504         Nest infrastructure. Adds these functions:
2505         1. testRunner.setStatisticsLastSeen()
2506         2. setStatisticsMaxStatisticsEntries()
2507         3. setStatisticsPruneEntriesDownTo()
2508
2509         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2511         (WTR::TestRunner::setStatisticsLastSeen):
2512         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2513         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2515         * WebKitTestRunner/TestController.cpp:
2516         (WTR::TestController::setStatisticsLastSeen):
2517         (WTR::TestController::setMaxStatisticsEntries):
2518         (WTR::TestController::setPruneEntriesDownTo):
2519         * WebKitTestRunner/TestController.h:
2520         * WebKitTestRunner/TestInvocation.cpp:
2521         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2522         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2523         (WTR::TestController::setStatisticsLastSeen):
2524         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2525         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2526
2527 2017-07-03  Brian Burg  <bburg@apple.com>
2528
2529         Web Replay: remove some unused code
2530         https://bugs.webkit.org/show_bug.cgi?id=173903
2531
2532         Rubber-stamped by Joseph Pecoraro.
2533
2534         * Scripts/run-input-generator-tests: Removed.
2535         * Scripts/webkitpy/replay/__init__.py: Removed.
2536         * Scripts/webkitpy/replay/main.py: Removed.
2537
2538 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2539
2540         [WPE] Fix layout test baseline and TestExpectations hierarchy
2541         https://bugs.webkit.org/show_bug.cgi?id=174092
2542
2543         Reviewed by Michael Catanzaro.
2544
2545         Like for the GTK+ port, override the default_baseline_search_path() and
2546         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2547         Both methods operate on a short list of search paths that defaults to 'wpe' and
2548         'wk2', along with any other user-specified platform directory.
2549
2550         The test_expectations_file_position() method is overridden for testing purposes,
2551         and relevant unit tests are added.
2552
2553         * Scripts/webkitpy/port/wpe.py:
2554         (WPEPort._search_paths):
2555         (WPEPort):
2556         (WPEPort.default_baseline_search_path):
2557         (WPEPort._port_specific_expectations_files):
2558         (WPEPort.test_expectations_file_position):
2559         * Scripts/webkitpy/port/wpe_unittest.py:
2560         (WPEPortTest.test_default_baseline_search_path):
2561         (WPEPortTest):
2562         (WPEPortTest.test_port_specific_expectations_files):
2563
2564 2017-07-10  Chris Dumez  <cdumez@apple.com>
2565
2566         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2567         https://bugs.webkit.org/show_bug.cgi?id=174301
2568
2569         Reviewed by Brent Fulgham.
2570
2571         Rename some of the testRunner API for clarity and to better match what it calls
2572         internally.
2573
2574         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2575         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2576         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2577         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2579         * WebKitTestRunner/TestController.cpp:
2580         (WTR::TestController::statisticsUpdateCookiePartitioning):
2581         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2582         * WebKitTestRunner/TestController.h:
2583         * WebKitTestRunner/TestInvocation.cpp:
2584         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2585         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2586         (WTR::TestController::statisticsUpdateCookiePartitioning):
2587         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2588
2589 2017-07-10  Charlie Turner  <cturner@igalia.com>
2590
2591         [GStreamer] Live twitch.tv videos do not play
2592         https://bugs.webkit.org/show_bug.cgi?id=174222
2593
2594         Reviewed by Michael Catanzaro.
2595
2596         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2597         fixes videos not playing on twitch.tv.
2598
2599         * gtk/jhbuild.modules:
2600
2601 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2602
2603         Add WebGL2 configuration option to build-webkit
2604         https://bugs.webkit.org/show_bug.cgi?id=174251
2605
2606         Reviewed by Michael Catanzaro.
2607
2608         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2609         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2610         is marked as enabled for the Apple Cocoa ports.
2611
2612 2017-07-08  Chris Dumez  <cdumez@apple.com>
2613
2614         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2615         https://bugs.webkit.org/show_bug.cgi?id=174290
2616
2617         Reviewed by Brent Fulgham.
2618
2619         Rename testRunner API to match the new internal API names.
2620
2621         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2622         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2623         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2624         (WTR::TestRunner::statisticsSubmitTelemetry):
2625         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2626         * WebKitTestRunner/TestController.cpp:
2627         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2628         (WTR::TestController::statisticsSubmitTelemetry):
2629         * WebKitTestRunner/TestController.h:
2630         * WebKitTestRunner/TestInvocation.cpp:
2631         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2632         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2633         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2634         (WTR::TestController::statisticsSubmitTelemetry):
2635
2636 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2637
2638         Drop NOSNIFF compile flag
2639         https://bugs.webkit.org/show_bug.cgi?id=174289
2640
2641         Reviewed by Michael Catanzaro.
2642
2643         * Scripts/webkitperl/FeatureList.pm:
2644         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2645
2646 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2647
2648         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2649         https://bugs.webkit.org/show_bug.cgi?id=174219
2650         <rdar://problem/32083177>
2651
2652         Reviewed by Ryosuke Niwa.
2653
2654         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2655         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2656         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2657         place.
2658
2659         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2660         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2661         no action is taken when dropping.
2662
2663         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2664         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2665         (TestWebKitAPI::TEST):
2666         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2667         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2668         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2669         (-[MockDragDropSession allowsMoveOperation]):
2670         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2671         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2672         (-[DataInteractionSimulator initWithWebView:]):
2673         (-[DataInteractionSimulator runFrom:to:]):
2674         (-[DataInteractionSimulator _advanceProgress]):
2675         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2676         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2677         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2678
2679 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2680
2681         Unreviewed, rolling out r219238, r219239, and r219241.
2682         https://bugs.webkit.org/show_bug.cgi?id=174265
2683
2684         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2685         (Requested by yusukesuzuki on #webkit).
2686
2687         Reverted changesets:
2688
2689         "[WTF] Implement WTF::ThreadGroup"
2690         https://bugs.webkit.org/show_bug.cgi?id=174081
2691         http://trac.webkit.org/changeset/219238
2692
2693         "Unreviewed, build fix after r219238"
2694         https://bugs.webkit.org/show_bug.cgi?id=174081
2695         http://trac.webkit.org/changeset/219239
2696
2697         "Unreviewed, CLoop build fix after r219238"
2698         https://bugs.webkit.org/show_bug.cgi?id=174081
2699         http://trac.webkit.org/changeset/219241
2700
2701 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2702
2703         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2704         https://bugs.webkit.org/show_bug.cgi?id=174250
2705
2706         Reviewed by Carlos Alberto Lopez Perez.
2707
2708         * Scripts/webkitperl/FeatureList.pm:
2709
2710 2017-07-07  Charlie Turner  <cturner@igalia.com>
2711         [GStreamer] vid.me videos do not play
2712         https://bugs.webkit.org/show_bug.cgi?id=172240
2713
2714         Reviewed by Xabier Rodriguez-Calvar.
2715
2716         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2717         have the existing libsoup build against GNOME to avoid header drift
2718         against GStreamer's linked Soup library.
2719
2720         * gtk/jhbuild.modules:
2721
2722 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2723
2724         Write a support script to enable buildbot to upload to S3
2725         https://bugs.webkit.org/show_bug.cgi?id=174196
2726         
2727         Reviewed by Stephanie Lewis.
2728
2729         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2730         (uploadToS3):
2731         (archiveExists):
2732
2733 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2734
2735         Enabling uploading archives to S3.
2736         https://bugs.webkit.org/show_bug.cgi?id=174198
2737         
2738         Reviewed by Stephanie Lewis.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2741         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2742         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2743         (TransferToS3): Transfer full and minified archives to S3
2744
2745 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2746
2747         [WTF] Implement WTF::ThreadGroup
2748         https://bugs.webkit.org/show_bug.cgi?id=174081
2749
2750         Reviewed by Mark Lam.
2751
2752         Add WTF::ThreadGroup tests.
2753
2754         * TestWebKitAPI/CMakeLists.txt:
2755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2756         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2757         (TestWebKitAPI::TEST):
2758
2759 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2760
2761         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2762         https://bugs.webkit.org/show_bug.cgi?id=174150
2763
2764         Reviewed by Mark Lam.
2765
2766         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2767         (TestWebKitAPI::TEST):
2768         * TestWebKitAPI/TestsController.cpp:
2769         (TestWebKitAPI::TestsController::TestsController):
2770
2771 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2772
2773         Enabling uploading archives to S3.
2774         https://bugs.webkit.org/show_bug.cgi?id=174198
2775         
2776         Reviewed by Lucas Forschler.
2777
2778         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2779         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2780         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2781         (TransferToS3): Transfer full and minified archives to S3
2782
2783 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2784
2785         [GTK][WPE] kill-old-process should kill more webkit related process
2786         https://bugs.webkit.org/show_bug.cgi?id=174220
2787
2788         Reviewed by Michael Catanzaro.
2789
2790         Generate list of possible webkit-related process names and add
2791         them to the list of process to kill.
2792         Also update the possible system related process for GTK+/WPE.
2793
2794         * BuildSlaveSupport/kill-old-processes:
2795         (listAllWebKitPrograms):
2796         (main):
2797
2798 2017-07-06  Chris Dumez  <cdumez@apple.com>
2799
2800         FileMonitor should not be ref counted
2801         https://bugs.webkit.org/show_bug.cgi?id=174166
2802
2803         Reviewed by Brent Fulgham.
2804
2805         Update the API tests to reflect the API change.
2806
2807         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2808         (TestWebKitAPI::TEST_F):
2809
2810 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2811
2812         Unreviewed, rolling out r219194.
2813         https://bugs.webkit.org/show_bug.cgi?id=174207
2814
2815         it broke some layout tests (Requested by clopez on #webkit).
2816
2817         Reverted changeset:
2818
2819         "[GStreamer] vid.me videos do not play"
2820         https://bugs.webkit.org/show_bug.cgi?id=172240
2821         http://trac.webkit.org/changeset/219194
2822
2823 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2824
2825         Unreviewed, rolling out r219178.
2826
2827         This caused a consistent failure with the API test
2828         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2829
2830         Reverted changeset:
2831
2832         "[WTF] Clean up StringStatics.cpp by using
2833         LazyNeverDestroyed<> for Atoms"
2834         https://bugs.webkit.org/show_bug.cgi?id=174150
2835         http://trac.webkit.org/changeset/219178
2836
2837 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2838
2839         Add CWD to Perl library path (no longer the default since 5.26.0)
2840         https://bugs.webkit.org/show_bug.cgi?id=174200
2841
2842         Reviewed by Michael Catanzaro.
2843
2844         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2845         (SetupGitClone._get_username_and_email):
2846
2847 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2848
2849         Unreviewed, update my email address.
2850
2851         * Scripts/webkitpy/common/config/contributors.json:
2852
2853 2017-07-06  Charlie Turner  <cturner@igalia.com>
2854         [GStreamer] vid.me videos do not play
2855         https://bugs.webkit.org/show_bug.cgi?id=172240
2856
2857         Reviewed by Xabier Rodriguez-Calvar.
2858
2859         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2860         have the existing libsoup build against GNOME to avoid header drift
2861         against GStreamer's linked Soup library.
2862
2863         * gtk/jhbuild.modules:
2864
2865 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2866
2867         [WTF] Move SoftLinking.h into WTF
2868         https://bugs.webkit.org/show_bug.cgi?id=174000
2869
2870         Reviewed by Alex Christensen.
2871
2872         * DumpRenderTree/mac/TestRunnerMac.mm:
2873         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2874         (test_primary_header):
2875         (ErrorCollector.__init__): Deleted.
2876         (ErrorCollector.__call__): Deleted.
2877         (ErrorCollector.results): Deleted.
2878         (ErrorCollector.result_list): Deleted.
2879         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2880         (MockIo.open): Deleted.
2881         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2882         (CppFunctionsTest.test_create_acronym): Deleted.
2883         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2884         (CppFunctionsTest.test_parameter): Deleted.
2885         (CppFunctionsTest.test_single_line_view): Deleted.
2886         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2887         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2888         (CppFunctionsTest.test_parameter_list): Deleted.
2889         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2890         (CppStyleTestBase.process_file_data): Deleted.
2891         (CppStyleTestBase.perform_lint): Deleted.
2892         (CppStyleTestBase.perform_single_line_lint): Deleted.
2893         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2894         (CppStyleTestBase.perform_language_rules_check): Deleted.
2895         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2896         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2897         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2898         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2899         (CppStyleTestBase.perform_header_guard_check): Deleted.
2900         (CppStyleTestBase.assert_lint): Deleted.
2901         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2902         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2903         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2904         (CppStyleTestBase.assert_language_rules_check): Deleted.
2905         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2906         (CppStyleTestBase.assert_header_guard): Deleted.
2907         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2908         (CppStyleTestBase.assert_positions_equal): Deleted.
2909         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2910         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2911         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2912         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2913         (FunctionDetectionTest.test_ignore_macros): Deleted.
2914         (FunctionDetectionTest.test_non_functions): Deleted.
2915         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2916         (FunctionDetectionTest.test_parameter_list): Deleted.
2917         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2918         (CppStyleTest.test_asm_lines_ignored): Deleted.
2919         (CppStyleTest.test_get_line_width): Deleted.
2920         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2921         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2922         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2923         (CppStyleTest.test_position): Deleted.
2924         (CppStyleTest.test_rfind_in_lines): Deleted.
2925         (CppStyleTest.test_close_expression): Deleted.
2926         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2927         (CppStyleTest.test_cstyle_cast): Deleted.
2928         (CppStyleTest.test_runtime_casting): Deleted.
2929         (CppStyleTest.test_runtime_selfinit): Deleted.
2930         (CppStyleTest.test_runtime_rtti): Deleted.
2931         (CppStyleTest.test_static_cast_readability): Deleted.
2932         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2933         (CppStyleTest.void): Deleted.
2934         (CppStyleTest.test_deprecated_cast): Deleted.
2935         (CppStyleTest.test_mock_method): Deleted.
2936         (CppStyleTest.test_sizeof_type): Deleted.
2937         (CppStyleTest.cases): Deleted.
2938         (CppStyleTest.for): Deleted.
2939         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2940         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2941         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2942         (CppStyleTest.test_include_what_you_use): Deleted.
2943         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2944         (CppStyleTest.test_cleanse_line): Deleted.
2945         (CppStyleTest.test_multi_line_comments): Deleted.
2946         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2947         (CppStyleTest.test_multiline_strings): Deleted.
2948         (CppStyleTest.test_platformh_comments): Deleted.
2949         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2950         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2951         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2952         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2953         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2954         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2955         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2956         (CppStyleTest.test_check_posix_threading): Deleted.
2957         (CppStyleTest.test_insecure_string_operations): Deleted.
2958         (CppStyleTest.test_format_strings): Deleted.
2959         (CppStyleTest.test_insecure_temp_file): Deleted.
2960         (CppStyleTest.test_variable_length_array_detection): Deleted.
2961         (CppStyleTest.test_braces): Deleted.
2962         (CppStyleTest.test_check_check): Deleted.
2963         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2964         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2965         (CppStyleTest.test_spacing_for_fncall): Deleted.
2966         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2967         (CppStyleTest.test_spacing_before_braces): Deleted.
2968         (CppStyleTest.test_spacing_between_braces): Deleted.
2969         (CppStyleTest.test_spacing_before_brackets): Deleted.
2970         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2971         (CppStyleTest.test_objective_c_block): Deleted.
2972         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2973         (CppStyleTest.test_spacing_around_else): Deleted.
2974         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2975         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2976         (CppStyleTest.test_operator_methods): Deleted.
2977         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2978         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2979         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2980         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2981         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2982         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2983         (CppStyleTest.test_space_after_comment_marker): Deleted.
2984         (CppStyleTest.test_newline_at_eof): Deleted.
2985         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2986         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2987         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2988         (CppStyleTest.test_invalid_utf8): Deleted.
2989         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2990         (CppStyleTest.test_is_blank_line): Deleted.
2991         (CppStyleTest.test_blank_lines_check): Deleted.
2992         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2993         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2994         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2995         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2996         (CppStyleTest.test_comma): Deleted.
2997         (CppStyleTest.test_declaration): Deleted.
2998         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2999         (CppStyleTest.test_indent): Deleted.
3000         (CppStyleTest.test_indent.Foo): Deleted.
3001         (CppStyleTest.test_not_alabel): Deleted.
3002         (CppStyleTest.test_tab): Deleted.
3003         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
3004         (CppStyleTest.test_build_class): Deleted.
3005         (CppStyleTest.test_build_class.definitions): Deleted.
3006         (CppStyleTest.test_build_class.Foo): Deleted.
3007         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
3008         (CppStyleTest.test_build_end_comment): Deleted.
3009         (CppStyleTest.test_build_forward_decl): Deleted.
3010         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
3011         (CppStyleTest.test_build_header_guard): Deleted.
3012         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
3013         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
3014         (CppStyleTest.test_build_printf_format): Deleted.
3015         (CppStyleTest.test_runtime_printf_format): Deleted.
3016         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
3017         (CppStyleTest.test_build_storage_class): Deleted.
3018         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
3019         (CppStyleTest.test_build_storage_class.declaration): Deleted.
3020         (CppStyleTest.test_build_storage_class.after): Deleted.
3021         (CppStyleTest.test_build_storage_class.is): Deleted.
3022         (CppStyleTest.test_legal_copyright): Deleted.
3023         (CppStyleTest.test_invalid_increment): Deleted.
3024         (CppStyleTest.test_enum_bitfields): Deleted.
3025         (CppStyleTest.test_plain_integral_bitfields): Deleted.
3026         (CleansedLinesTest.test_init_empty): Deleted.
3027         (CleansedLinesTest.test_collapse_strings): Deleted.
3028         (OrderOfIncludesTest.tearDown): Deleted.
3029         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
3030         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
3031         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
3032         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
3033         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
3034         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
3035         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
3036         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
3037         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
3038         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
3039         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
3040         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
3041         (OrderOfIncludesTest.test_primary_header): Deleted.
3042         (OrderOfIncludesTest.test_public_primary_header): Deleted.
3043         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
3044         (OrderOfIncludesTest.test_classify_include): Deleted.
3045         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
3046         (CheckForFunctionLengthsTest.tearDown): Deleted.
3047         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
3048         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
3049         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
3050         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
3051         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
3052         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
3053         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
3054         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
3055         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
3056         (CheckForFunctionLengthsTest.function_body): Deleted.
3057         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
3058         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
3059         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
3060         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
3061         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
3062         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
3063         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
3064         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
3065         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
3066         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
3067         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
3068         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
3069         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
3070         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
3071         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
3072         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
3073         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
3074         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
3075         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
3076         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
3077         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
3078         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
3079         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
3080         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
3081         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
3082         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
3083         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
3084         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
3085         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
3086         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
3087         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
3088         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
3089         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
3090         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
3091         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
3092         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
3093         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
3094         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
3095         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
3096         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
3097         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
3098         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
3099         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
3100         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
3101         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
3102         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
3103         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
3104         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
3105         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
3106         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
3107         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
3108         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
3109         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
3110         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
3111         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
3112         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
3113         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
3114         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
3115         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
3116         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
3117         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
3118         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
3119         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
3120         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
3121         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
3122         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
3123         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
3124         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
3125         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
3126         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
3127         (LeakyPatternTest.test_get_dc): Deleted.
3128         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
3129         (LeakyPatternTest.test_own_get_dc): Deleted.
3130         (LeakyPatternTest.test_create_dc): Deleted.
3131         (LeakyPatternTest.test_create_compatible_dc): Deleted.
3132         (WebKitStyleTest.test_indentation): Deleted.
3133         (WebKitStyleTest.test_indentation.Foo): Deleted.
3134         (WebKitStyleTest.test_indentation.Document): Deleted.
3135         (WebKitStyleTest.test_spacing): Deleted.
3136         (WebKitStyleTest.test_line_breaking): Deleted.
3137         (WebKitStyleTest.test_braces): Deleted.
3138         (WebKitStyleTest.test_braces.MyClass): Deleted.
3139         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
3140         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
3141         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
3142         (WebKitStyleTest.test_null_false_zero): Deleted.
3143         (WebKitStyleTest.test_directive_indentation): Deleted.
3144         (WebKitStyleTest.test_using_std): Deleted.
3145         (WebKitStyleTest.test_using_namespace): Deleted.
3146         (WebKitStyleTest.test_max_macro): Deleted.
3147         (WebKitStyleTest.test_min_macro): Deleted.
3148         (WebKitStyleTest.test_wtf_move): Deleted.
3149         (WebKitStyleTest.test_ctype_fucntion): Deleted.
3150         (WebKitStyleTest.test_names): Deleted.
3151         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
3152         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
3153         (WebKitStyleTest.test_names.declarations): Deleted.
3154         (WebKitStyleTest.test_names.struct): Deleted.
3155         (WebKitStyleTest.test_names.VectorType): Deleted.
3156         (WebKitStyleTest.test_parameter_names): Deleted.
3157         (WebKitStyleTest.test_comments): Deleted.
3158         (WebKitStyleTest.test_webkit_export_check): Deleted.
3159         (WebKitStyleTest.test_member_initialization_list): Deleted.
3160         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
3161         (WebKitStyleTest.test_other): Deleted.
3162         (CppCheckerTest.mock_handle_style_error): Deleted.
3163         (CppCheckerTest._checker): Deleted.
3164         (CppCheckerTest.test_init): Deleted.
3165         (CppCheckerTest.test_eq): Deleted.
3166         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
3167         (CppCheckerTest.test_ne): Deleted.
3168         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3169         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3170         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3171         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3172         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3173         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3174
3175 2017-07-05  Saam Barati  <sbarati@apple.com>
3176
3177         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
3178         https://bugs.webkit.org/show_bug.cgi?id=174188
3179         <rdar://problem/30581423>
3180
3181         Reviewed by Mark Lam.
3182
3183         * Scripts/run-jsc-stress-tests:
3184
3185 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3186
3187         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3188         https://bugs.webkit.org/show_bug.cgi?id=174150
3189
3190         Reviewed by Mark Lam.
3191
3192         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3193         (TestWebKitAPI::TEST):
3194
3195 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3196
3197         Remove copy of ICU headers from WebKit
3198         https://bugs.webkit.org/show_bug.cgi?id=116407
3199
3200         Reviewed by Alex Christensen.
3201
3202         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3203         * TestWebKitAPI/Configurations/Base.xcconfig:
3204         * WebKitTestRunner/Configurations/Base.xcconfig:
3205
3206 2017-07-05  Chris Dumez  <cdumez@apple.com>
3207
3208         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3209         https://bugs.webkit.org/show_bug.cgi?id=174163
3210         <rdar://problem/33067518>
3211
3212         Reviewed by Alex Christensen.
3213
3214         Add API test coverage.
3215
3216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3217         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3218         (TEST):
3219
3220 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3221
3222         When dragging a selection, clearing the selection in dragstart should not crash the web process
3223         https://bugs.webkit.org/show_bug.cgi?id=174142
3224         <rdar://problem/33067501>
3225
3226         Reviewed by Tim Horton.
3227
3228         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3229         drag is starting up.
3230
3231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3233         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3234         (TestWebKitAPI::TEST):
3235
3236 2017-07-05  Daniel Bates  <dabates@apple.com>
3237
3238         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3239         API navigation
3240         https://bugs.webkit.org/show_bug.cgi?id=174170
3241         <rdar://problem/33140328>
3242
3243         Reviewed by Brady Eidson.
3244
3245         Update tests as needed for the behavior change.
3246
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3248         (TEST):
3249
3250 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3251
3252         Add WebKitPrivateFrameworkStubs for iOS 11
3253         https://bugs.webkit.org/show_bug.cgi?id=173988
3254
3255         Reviewed by David Kilzer.
3256
3257         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3258         should use the same directory for private framework stubs.
3259         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3260
3261 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3262
3263         [MediaStream] Protect request and web view during gUM client callback
3264         https://bugs.webkit.org/show_bug.cgi?id=174096
3265         <rdar://problem/32833102>
3266
3267         Reviewed by Youenn Fablet.
3268
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3270         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3271
3272 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3273
3274         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3275
3276         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3277
3278 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3279
3280         Unreviewed, rolling out r219128.
3281
3282         Spoke with engineer who originally submitted, Patch for APi
3283         test to follow.
3284
3285         Reverted changeset:
3286
3287         "Unreviewed, rolling out r219070."
3288         https://bugs.webkit.org/show_bug.cgi?id=174082
3289         http://trac.webkit.org/changeset/219128
3290
3291 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3292
3293         Unreviewed, rolling out r219070.
3294
3295         This revision caused consistent failures of the API test
3296         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3297
3298         Reverted changeset:
3299
3300         "Pasting single words copied to UIPasteboard inserts URLs in
3301         editable areas"
3302         https://bugs.webkit.org/show_bug.cgi?id=174082
3303         http://trac.webkit.org/changeset/219070
3304
3305 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3306
3307         Remove unused EFL logo from bot watcher dashboard
3308         https://bugs.webkit.org/show_bug.cgi?id=174136
3309
3310         Reviewed by Alexey Proskuryakov.
3311
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3314
3315 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3316
3317         [GTK] Add more GTK bots to dashboard
3318         https://bugs.webkit.org/show_bug.cgi?id=174129
3319
3320         Reviewed by Carlos Alberto Lopez Perez.
3321
3322         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3323         them.
3324
3325         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3326         less-essential GTK bots.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3330         (WebKitBuildbot):
3331
3332 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         [WPE] Add WPE to bot watcher dashboard
3335         https://bugs.webkit.org/show_bug.cgi?id=174119
3336
3337         Reviewed by Alexey Proskuryakov.
3338
3339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3344         (WebKitBuildbot):
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3346         (table.queue-grid tr.platform.linux-wpe img.logo):
3347
3348 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3349
3350         https://bugs.webkit.org/show_bug.cgi?id=174105
3351         
3352         Reviewed by Stephanie Lewis.
3353
3354         * BuildSlaveSupport/built-product-archive:
3355         (main): Add a -minify parser option
3356         (createZip): Pass along the optional Minify argument if requested
3357         (minifySource): This will trim down archives, logic limited to Mac platform.
3358
3359 2017-07-03  Matt Rajca  <mrajca@apple.com>
3360
3361         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3362         https://bugs.webkit.org/show_bug.cgi?id=174103
3363
3364         Reviewed by Alex Christensen.
3365
3366         Added an API test.
3367
3368         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3369         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3370         (TEST): Added test.
3371         * TestWebKitAPI/cocoa/TestWKWebView.h:
3372         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3373         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3374
3375 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3376
3377         Unreviewed, rolling out r219103.
3378
3379         Caused multiple build failures.
3380
3381         Reverted changeset:
3382
3383         "Remove copy of ICU headers from WebKit"
3384         https://bugs.webkit.org/show_bug.cgi?id=116407
3385         http://trac.webkit.org/changeset/219103
3386
3387 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3388
3389         Remove copy of ICU headers from WebKit
3390         https://bugs.webkit.org/show_bug.cgi?id=116407
3391
3392         Reviewed by Alex Christensen.
3393
3394         Use WTF's copy of ICU headers.
3395
3396         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3397         * TestWebKitAPI/Configurations/Base.xcconfig:
3398         * WebKitTestRunner/Configurations/Base.xcconfig:
3399
3400 2017-07-03  Brady Eidson  <beidson@apple.com>
3401
3402         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3403         https://bugs.webkit.org/show_bug.cgi?id=174073
3404
3405         Reviewed by Andy Estes.
3406
3407         * DumpRenderTree/mac/TestRunnerMac.mm:
3408         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3409
3410         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3411         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3412
3413 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3414
3415         Unreviewed, rolling out r219083.
3416
3417         The revision caused an API failure on all testing platforms.
3418
3419         Reverted changeset:
3420
3421         "[MediaStream] Protect request and web view during gUM client
3422         callback"
3423         https://bugs.webkit.org/show_bug.cgi?id=174096
3424         http://trac.webkit.org/changeset/219083
3425
3426 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3427
3428         webkitpy: Properly number duplicated crashlogs
3429         https://bugs.webkit.org/show_bug.cgi?id=172002
3430
3431         Reviewed by Aakash Jain.
3432
3433         * Scripts/webkitpy/common/system/crashlogs.py:
3434         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3435         an increasing integer.
3436         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3437         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3438         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3439         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3440
3441 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3442
3443         WebContent processes crash when the network process crashes with pending connection requests
3444         https://bugs.webkit.org/show_bug.cgi?id=174065
3445         <rdar://problem/30359835>
3446
3447         Reviewed by Tim Horton.
3448
3449         Add a API to ensure UI process tries to relaunch a new network process when the network process
3450         crashes with pending network connection requests.
3451
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3454         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3455         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3456         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3457
3458 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3459
3460         [MediaStream] Protect request and web view during gUM client callback
3461         https://bugs.webkit.org/show_bug.cgi?id=174096
3462         <rdar://problem/32833102>
3463
3464         Reviewed by Youenn Fablet.
3465
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3468
3469 2017-07-03  Andy Estes  <aestes@apple.com>
3470
3471         [Xcode] Add an experimental setting to build with ccache
3472         https://bugs.webkit.org/show_bug.cgi?id=173875
3473
3474         Reviewed by Tim Horton.
3475
3476         On systems that already have ccache(1) installed, this patch adds experimental support for
3477         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3478
3479         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3480         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3481         find the toolchain from which to run clang, and then invokes ccache with the required
3482         arguments.
3483
3484         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3485         precompiled headers to work properly [1].
3486
3487         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3488         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3489         during linking.
3490         
3491         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3492
3493         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3494         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3495         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3496         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3497         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3498         * ccache/README.md: Added.
3499         * ccache/ccache-clang: Added.
3500         * ccache/ccache-clang++: Added.
3501         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3502
3503 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3504
3505         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3506         https://bugs.webkit.org/show_bug.cgi?id=174051
3507
3508         Reviewed by Tim Horton.
3509
3510         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3511         (TestWebKitAPI::TEST_F):
3512
3513 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3514
3515         Unreviewed, rolling out r219024.
3516
3517         This patch cause 3 didferent test to fail.
3518
3519         Reverted changeset:
3520
3521         "REGRESSION(r215096) Queries of URLs with non-special schemes
3522         should not percent-encode single quotes"
3523         https://bugs.webkit.org/show_bug.cgi?id=174051
3524         http://trac.webkit.org/changeset/219024
3525
3526 2017-07-03  Chris Dumez  <cdumez@apple.com>
3527
3528         Drop ResourceLoadStatisticsStore's statisticsLock
3529         https://bugs.webkit.org/show_bug.cgi?id=174080
3530
3531         Reviewed by Brent Fulgham.
3532
3533         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3534
3535         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3536         (WTR::TestController::isStatisticsPrevalentResource):
3537         (WTR::TestController::isStatisticsHasHadUserInteraction):
3538         (WTR::TestController::isStatisticsGrandfathered):
3539
3540 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3543         https://bugs.webkit.org/show_bug.cgi?id=174082
3544         <rdar://problem/33046992>
3545
3546         Reviewed by Tim Horton.
3547
3548         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3549
3550         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3551         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3552         (TestWebKitAPI::TEST):
3553
3554 2017-07-02  Brady Eidson  <beidson@apple.com>
3555
3556         Add API test for all parts of WebKit1 API related to favicons.
3557         https://bugs.webkit.org/show_bug.cgi?id=174069
3558
3559         Reviewed by Andy Estes.
3560
3561         These two API tests cover all WebKit1 API related to icons.
3562         
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3565         (mainResourceData):
3566         (defaultFaviconData):
3567         (customFaviconData):
3568         (imageFromData):
3569         (+[IconLoadingProtocol canInitWithRequest:]):
3570         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3571         (-[IconLoadingProtocol startLoading]):
3572         (-[IconLoadingProtocol stopLoading]):
3573         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3574         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3575         (TestWebKitAPI::TEST):
3576
3577 2017-07-01  Dan Bernstein  <mitz@apple.com>
3578
3579         [iOS] Remove code only needed when building for iOS 9.x
3580         https://bugs.webkit.org/show_bug.cgi?id=174068
3581
3582         Reviewed by Tim Horton.
3583
3584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3585         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3586         (WTR::initializeWebViewConfiguration):
3587         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3588         (-[HIDEventGenerator _createIOHIDEventType:]):
3589
3590 2017-07-01  Brady Eidson  <beidson@apple.com>
3591
3592         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3593         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3594
3595         Reviewed by Alex Christensen.
3596
3597         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3598
3599 2017-07-01  Dan Bernstein  <mitz@apple.com>
3600
3601         [macOS] Remove code only needed when building for OS X Yosemite