REGRESSION (r143626): Element shows as garbage in image gallery
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2
3         Fix some compiler warnings (miscellaneous)
4         https://bugs.webkit.org/show_bug.cgi?id=80790
5
6         Reviewed by Rob Buis.
7
8         Fix the following warnings for BlackBerry:
9         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
10         used as truth value [-Wparentheses].
11
12         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
13         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
14
15 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
16
17         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
18         https://bugs.webkit.org/show_bug.cgi?id=115928
19
20         Reviewed by Kenneth Rohde Christiansen.
21
22         WKViewSetThemePath was moved to WKViewEfl.h.
23
24         * TestWebKitAPI/efl/PlatformWebView.cpp:
25
26 2013-05-10  Andreas Kling  <akling@apple.com>
27
28         I accidentally the Java testing.
29
30         * Scripts/webkitpy/port/mac.py:
31
32 2013-05-10  Brian Holt  <brian.holt@samsung.com>
33
34         [GTK] Module Cairo fails to build under jhbuild
35         https://bugs.webkit.org/show_bug.cgi?id=115854
36
37         Reviewed by Martin Robinson.
38
39         Make cairo depend on glib in jhbuild.modules.
40
41         * gtk/jhbuild.modules:
42
43 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
44
45         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
46         https://bugs.webkit.org/show_bug.cgi?id=115904
47
48         Reviewed by Martin Robinson.
49
50         * ImageDiff/gtk/ImageDiff.cpp:
51         (main):
52
53 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
54
55         Add my new address to contributors.json. (Unreviewed)
56
57         * Scripts/webkitpy/common/config/contributors.json:
58
59 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
60
61         Unreviewed. Move myself to the reviewers list.
62
63         * Scripts/webkitpy/common/config/contributors.json:
64
65 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
66
67         Unreviewed. Add my email to a few watchlists.
68
69         * Scripts/webkitpy/common/config/watchlist:
70
71 2013-05-10  Simon Pena  <simon.pena@samsung.com>
72
73         Unicode support missing from string representation of Contributors in committers.py
74         https://bugs.webkit.org/show_bug.cgi?id=115859
75
76         Reviewed by Darin Adler.
77
78         Contributors, in committers.py, provided a string representation in __str__ which
79         didn't support unicode characters, so printing a contributor would fail in that case.
80         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
81         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
82
83         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
84         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
85         representation.
86         (Contributor.__str__):
87         (Contributor):
88         (Contributor.__unicode__):
89         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
90         a contributor with unicode characters can be represented as a string.
91         (CommittersTest):
92         (CommittersTest.test_contributor_encoding):
93
94 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
95
96         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
97         https://bugs.webkit.org/show_bug.cgi?id=92371
98
99         Reviewed by Brent Fulgham.
100
101         Use JavaScriptThreading.cpp where the same functionality is
102         implemented too. This reduces the dependency on the pthread
103         library. Also replace assert() with WebKit ASSERT().
104
105         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
106         * DumpRenderTree/win/DumpRenderTree.cpp:
107         (dumpHistoryItem):
108         (dumpBackForwardList):
109         * DumpRenderTree/win/DumpRenderTree.vcproj:
110
111 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
112
113         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
114         https://bugs.webkit.org/show_bug.cgi?id=92505
115
116         Reviewed by Brent Fulgham.
117
118         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
119         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
120         (javaScriptThreadsMutex):
121         (javaScriptThreads):
122         (runJavaScriptThread):
123         (startJavaScriptThreads):
124         (stopJavaScriptThreads):
125         * DumpRenderTree/pthreads: Removed.
126         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
127
128 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
129
130         Unreviewed. Update Simon Pena email on his behalf.
131
132         * Scripts/webkitpy/common/config/contributors.json:
133
134 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
135
136         Add support for [NoInterfaceObject] Web IDL extended attribute
137         https://bugs.webkit.org/show_bug.cgi?id=115714
138
139         Reviewed by Kentaro Hara.
140
141         Update BindingsTests.generate_supplemental_dependency() to pass an
142         additional windowConstructorsFile argument to preprocess-idls.pl.
143
144         * Scripts/webkitpy/bindings/main.py:
145         (BindingsTests.generate_supplemental_dependency):
146         (BindingsTests.main):
147
148 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
149
150         [GTK][AC] Buildfix after r149694
151         https://bugs.webkit.org/show_bug.cgi?id=115797
152
153         Reviewed by Gustavo Noronha Silva.
154
155         Add CLUTTER_LIBS for linking TestWebCore.
156
157         * TestWebKitAPI/GNUmakefile.am:
158
159 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
160
161         [EFL] Remove unnecessary pkgs in EFL jhbuild
162         https://bugs.webkit.org/show_bug.cgi?id=114908
163
164         Reviewed by Laszlo Gombos.
165
166         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
167         handle them using jhbuild. We can reduce build time when using --update-efl.
168
169         * efl/jhbuild.modules:
170
171 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
172
173         [EFL] Disable SHADOW DOM feature in FeatureList.pm
174         https://bugs.webkit.org/show_bug.cgi?id=115834
175
176         Reviewed by Gyuyoung Kim.
177
178         * Scripts/webkitperl/FeatureList.pm:
179
180 2013-05-08  Lucas Forschler  <lforschler@apple.com>
181
182         Add Scheduler for Mac MtnLion 32bit Release builder.
183         
184         Unreviewed.
185         
186         * BuildSlaveSupport/build.webkit.org-config/config.json:
187
188 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
189
190         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
191         https://bugs.webkit.org/show_bug.cgi?id=115808
192
193         Reviewed by Darin Adler.
194
195         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
196         was left outdated after r127191, when the m_string member was changed
197         from UString to String. This patch calls the right pretty printer for it.
198
199         * gdb/webkit.py:
200         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
201         WTFImplPrettyPrinter.
202
203 2013-05-08  Andy Estes  <aestes@apple.com>
204
205         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
206         https://bugs.webkit.org/show_bug.cgi?id=115790
207
208         Reviewed by Alexey Proskuryakov.
209
210         Added two API tests:
211
212         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
213         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
214
215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
216         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
217         (TestWebKitAPI):
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
220         (TestWebKitAPI):
221         (TestWebKitAPI::decidePolicyForNavigationAction):
222         (CustomProtocolInvalidSchemeTest):
223         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
224
225 2013-05-08  Lucas Forschler  <lforschler@apple.com>
226
227         Teach buildbot how to compile 32-bit on Mac.
228
229         Reviewed by Ryosuke Niwa.
230
231         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
232         (CompileWebKit.start):
233         (ExtractTestResultsAndLeaks):
234
235 2013-05-08  Eli Fidler  <efidler@blackberry.com>
236
237         [BlackBerry] Fix usage of BlackBerry::Platform::String
238         https://bugs.webkit.org/show_bug.cgi?id=115781
239
240         Reviewed by Rob Buis.
241
242         BlackBerry PRs 304193 and 327181
243         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
244
245         We currently have a problem where we're passing UTF-8 encoded data into
246         the char* constructors of BlackBerry::Platform::String. This means the string
247         thinks its data is not UTF-8.
248
249         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
250         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
251         (BlackBerry::WebKit::dumpHistoryItem):
252         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
253         (TestRunner::setUserStyleSheetLocation):
254         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
255         (LoadHTMLStringItem::invoke):
256
257 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
258
259         Tools: add new BlackBerry include dirs.
260         https://bugs.webkit.org/show_bug.cgi?id=115514
261
262         Reviewed by Rob Buis.
263
264         iType include dirs are missing, and HarfBuzz needs to be fixed.
265
266         * Scripts/webkitdirs.pm:
267         (blackberryCMakeArguments):
268
269 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
270
271         [GTK] Plumb the Automake build system for the Battery Status API feature
272         https://bugs.webkit.org/show_bug.cgi?id=115718
273
274         Reviewed by Martin Robinson.
275
276         * Scripts/webkitdirs.pm:
277         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
278         through the --(enable|disable)-battery-status flag passed to configure.
279
280 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
281
282         new-run-webkit-websocketserver doesn't work after Chromium removal
283         https://bugs.webkit.org/show_bug.cgi?id=115816
284
285         Reviewed by Joseph Pecoraro.
286
287         Fix the bug by instantiating the correct port object.
288
289         * Scripts/new-run-webkit-websocketserver:
290         (main):
291
292 2013-05-07  Lucas Forschler  <lforschler@apple.com>
293
294         Configure buildbot for 32bit builder.
295         https://bugs.webkit.org/show_bug.cgi?id=115769
296         
297         Reviewed by Ryosuke Niwa.
298
299         * BuildSlaveSupport/build.webkit.org-config/config.json:
300
301 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
302
303         Unreviewed. Update to show my apple.com address.
304
305         * Scripts/webkitpy/common/config/contributors.json: Added
306         my apple.com e-mail address.
307
308 2013-05-08  David Kilzer  <ddkilzer@apple.com>
309
310         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
311
312         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
313         (concatenateAttributeAndValue): Switch to appendVector().
314
315 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
316
317         [Qt][WTR] Fix the build on Mac after r149692
318
319         Unreviewed build fix.
320
321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
322         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
323
324 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
325
326         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
327         to the watchlist for Accessibility.
328
329         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
330         * Scripts/webkitpy/common/config/watchlist: Added myself.
331
332 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
333
334         [Qt] Build fails with clang
335         https://bugs.webkit.org/show_bug.cgi?id=115741
336
337         Reviewed by Benjamin Poulain.
338
339         Since r149112 std::move is used in AtomicString for compilers that
340         support rvalue references and this requires a standard library
341         implementing c++11 move semantics.
342         We only explicitely require c++11 for WebKit2, but since clang supports
343         rvalue references the build of subtargets using AtomicString fails because
344         of missing std::move.
345         It is safe to add CONFIG += c++11 for the whole project when using clang
346         since we explicitely disable c++11 for ANGLE that had probems with libc++.
347
348         * qmake/mkspecs/features/unix/default_pre.prf:
349
350 2013-05-08  Darin Adler  <darin@apple.com>
351
352         Fix one more place that needed to use adoptCF/NS
353         https://bugs.webkit.org/show_bug.cgi?id=115778
354
355         Reviewed by Benjamin Poulain.
356
357         Not sure why I missed this code last time, but found a bit more code that needs
358         to switch to the newer style adoptCF/NS.
359
360         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
361         (convertWebResourceDataToString): Use adoptCF.
362         (convertWebResourceResponseToDictionary): Ditto.
363         (createXMLStringFromWebArchiveData): Ditto.
364         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
365         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
366
367 2013-05-08  Commit Queue  <commit-queue@webkit.org>
368
369         Unreviewed, rolling out r149271.
370         http://trac.webkit.org/changeset/149271
371         https://bugs.webkit.org/show_bug.cgi?id=115780
372
373         The mangled symbols are now enforced through LDFLAGS
374         (Requested by zdobersek on #webkit).
375
376         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
377
378 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
379
380         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
381         https://bugs.webkit.org/show_bug.cgi?id=115636
382
383         Reviewed by Ryosuke Niwa.
384
385         * TestResultServer/static-dashboards/flakiness_dashboard.js:
386         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
387         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
388         while Chromium-specific, can't be removed just yet as there's more code that uses it.
389
390 2013-05-06  Darin Adler  <darin@apple.com>
391
392         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
393         https://bugs.webkit.org/show_bug.cgi?id=115657
394
395         Reviewed by Sam Weinig.
396
397         This is similar to my last set of changes, but covers code that I missed with
398         global replace using the Safari Xcode workspace.
399
400         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
401         (convertWebResourceDataToString):
402         (convertWebResourceResponseToDictionary):
403         (createXMLStringFromWebArchiveData):
404         * DumpRenderTree/cg/ImageDiffCG.cpp:
405         (createImageFromStdin):
406         (createDifferenceImage):
407         (main):
408         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
409         (printPNG):
410         (dumpBitmap):
411         * DumpRenderTree/cg/PixelDumpSupportCG.h:
412         (BitmapContext::BitmapContext):
413         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
414         (-[MockWebNotificationProvider init]):
415         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
416         (createBitmapContext):
417         * DumpRenderTree/mac/TestRunnerMac.mm:
418         (TestRunner::addDisallowedURL):
419         (TestRunner::applicationCacheDiskUsageForOrigin):
420         (TestRunner::localStorageDiskUsageForOrigin):
421         (TestRunner::clearApplicationCacheForOrigin):
422         (TestRunner::deleteLocalStorageForOrigin):
423         (TestRunner::copyDecodedHostName):
424         (TestRunner::copyEncodedHostName):
425         (TestRunner::queueLoad):
426         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
427         (TestRunner::setMockGeolocationPositionUnavailableError):
428         (TestRunner::setUserStyleSheetLocation):
429         (TestRunner::setValueForUser):
430         (TestRunner::overridePreference):
431         (TestRunner::setPersistentUserStyleSheetLocation):
432         (TestRunner::execCommand):
433         (TestRunner::findString):
434         (TestRunner::isCommandEnabled):
435         (TestRunner::addOriginAccessWhitelistEntry):
436         (TestRunner::removeOriginAccessWhitelistEntry):
437         (TestRunner::addUserScript):
438         (TestRunner::addUserStyleSheet):
439         (TestRunner::evaluateInWebInspector):
440         (TestRunner::evaluateScriptInIsolatedWorld):
441         (TestRunner::apiTestNewWindowDataLoadBaseURL):
442         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
443         (TestRunner::authenticateSession):
444         (TestRunner::grantWebNotificationPermission):
445         (TestRunner::denyWebNotificationPermission):
446         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
447         (createCFURLResponseFromResponseData):
448         * DumpRenderTree/mac/WorkQueueItemMac.mm:
449         (LoadItem::invoke):
450         (LoadHTMLStringItem::invoke):
451         (ScriptItem::invoke):
452         * DumpRenderTree/win/DumpRenderTree.cpp:
453         (substringFromIndex):
454         (urlSuitableForTestResult):
455         (lastPathComponent):
456         (sharedCFURLCache):
457         * DumpRenderTree/win/ImageDiffCairo.cpp:
458         (createImageFromStdin):
459         (main):
460         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
461         (createBitmapContextFromWebView):
462         * DumpRenderTree/win/TestRunnerWin.cpp:
463         (TestRunner::setUserStyleSheetLocation):
464         (TestRunner::setPersistentUserStyleSheetLocation):
465         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
466         (TestWebKitAPI::TEST):
467         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
468         (TestWebKitAPI::TEST):
469         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
474         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
475         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
476         (TestWebKitAPI::createWindow):
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
481         (TestWebKitAPI::AcceptsFirstMouse::runTest):
482         * TestWebKitAPI/Tests/mac/AttributedString.mm:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
491         (TestWebKitAPI::TEST):
492         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
493         (TestWebKitAPI::TEST):
494         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
495         (TestWebKitAPI::TEST):
496         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
497         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
498         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
499         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
500         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
501         (TestWebKitAPI::TEST):
502         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
503         (TestWebKitAPI::TEST):
504         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
505         (TestWebKitAPI::TEST):
506         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
511         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
512         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
513         (TestWebKitAPI::TEST):
514         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
515         (TestWebKitAPI::TEST):
516         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
519         (TestWebKitAPI::TEST):
520         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
523         (TestWebKitAPI::TEST):
524         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
525         (TestWebKitAPI::TEST):
526         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
527         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
528         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
529         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
530         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
531         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
532         (WTR::testPathFromURL):
533         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
534         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
535         * WebKitTestRunner/cg/TestInvocationCG.cpp:
536         (WTR::createCGContextFromImage):
537         (WTR::dumpBitmap):
538         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
539         * WebKitTestRunner/mac/EventSenderProxy.mm:
540         (WTR::EventSenderProxy::mouseScrollBy):
541         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
542         (WTR::PlatformWebView::windowSnapshotImage):
543         * WebKitTestRunner/win/TestControllerWin.cpp:
544         (WTR::TestController::initializeTestPluginDirectory):
545         Use adoptCF and adoptNS.
546
547 2013-05-07  Alex Christensen  <achristensen@apple.com>
548
549         Fix a memory leak introduced in r149692
550         https://bugs.webkit.org/show_bug.cgi?id=115766
551
552         Reviewed by Mark Rowe.
553
554         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
555         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
556
557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
558         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
559         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
560
561 2013-05-07  Darin Adler  <darin@apple.com>
562
563         [Win] Fix storage leak in Windows DumpRenderTree
564         https://bugs.webkit.org/show_bug.cgi?id=115651
565
566         Reviewed by Sam Weinig.
567
568         * DumpRenderTree/win/DumpRenderTree.cpp:
569         (lastPathComponent): Added a missing call to adoptCF.
570
571 2013-05-07  Alex Christensen  <achristensen@apple.com>
572
573         fixed a memory leak introduced by bug 42324 by using a RetainPtr
574         https://bugs.webkit.org/show_bug.cgi?id=115760
575
576         Reviewed by Tim Horton.
577
578         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
579         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
580         fixed memory leak, added UNUSED_PARAM macros
581
582 2013-05-07  Alex Christensen  <achristensen@apple.com>
583
584         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
585         https://bugs.webkit.org/show_bug.cgi?id=42324
586         <rdar://problem/8193633>
587
588         Reviewed by Tim Horton.
589
590         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
591         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
592         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
593         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
594         Added dumpDOMAsWebArchive code that is called when dumping.        
595         (WTR::InjectedBundlePage::dump):
596         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
597         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
598         (InjectedBundlePage):
599         Added dumpDOMAsWebArchive declaration.
600         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
601         (WTR::TestRunner::dumpDOMAsWebArchive):
602         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
603         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
604         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
605         * Tools/WebKitTestRunner/cf: Added.
606         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
607         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
608         (convertMIMEType):
609         (convertWebResourceDataToString):
610         (normalizeHTTPResponseHeaderFields):
611         (normalizeWebResourceURL):
612         (convertWebResourceResponseToDictionary):
613         (compareResourceURLs):
614         (createXMLStringFromWebArchiveData):
615         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
616         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
617         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
618         Copied from Tools/DumpRenderTree/mac for used functions.
619         (createCFURLResponseFromResponseData):
620         (supportedNonImageMIMETypes):
621
622 2013-05-07  Alex Christensen  <achristensen@apple.com>
623
624         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
625         https://bugs.webkit.org/show_bug.cgi?id=115745
626
627         Reviewed by Tim Horton.
628
629         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
630         (compareResourceURLs):
631         Updated style.
632
633 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
634
635         Add an 'isReadOnly' member to IDL parse tree structure
636         https://bugs.webkit.org/show_bug.cgi?id=115704
637
638         Reviewed by Kentaro Hara.
639
640         Use newly added isReadOnly attribute.
641
642         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
643         (_generateHeaderFile):
644         (_generateImplementationFile):
645         (_staticValuesGetterImplementation):
646
647 2013-05-07  Anders Carlsson  <andersca@apple.com>
648
649         Remove AlwaysInline.h from WTF
650         https://bugs.webkit.org/show_bug.cgi?id=115727
651
652         Reviewed by Brent Fulgham.
653
654         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
655         to keep AlwaysInline.h around anymore.
656
657         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
658         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
659
660 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
661
662         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
663         https://bugs.webkit.org/show_bug.cgi?id=114808
664
665         Reviewed by Jocelyn Turcotte.
666
667         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
668         (https://codereview.qt-project.org/#change,54234)
669
670         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
671         (WTR::WrapperWindow::handleStatusChanged):
672
673 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
674
675         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
676
677         * Scripts/webkitpy/common/config/watchlist:
678
679 2013-05-06  Kangil Han  <kangil.han@samsung.com>
680
681         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
682         https://bugs.webkit.org/show_bug.cgi?id=115645
683
684         Reviewed by Gyuyoung Kim.
685
686         To run performance tests in wk1, we need --no-timeout option implementation.
687         So adopt it from gtk+ port.
688
689         * DumpRenderTree/efl/DumpRenderTree.cpp:
690         (shouldSetWaitToDumpWatchdog):
691         (parseCommandLineOptions):
692         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
693         * DumpRenderTree/efl/TestRunnerEfl.cpp:
694         (TestRunner::setWaitToDump):
695
696 2013-05-06  Commit Queue  <commit-queue@webkit.org>
697
698         Unreviewed, rolling out r149547.
699         http://trac.webkit.org/changeset/149547
700         https://bugs.webkit.org/show_bug.cgi?id=115682
701
702         Added unittests that fail on bots and spits out text into
703         stdout (Requested by rniwa on #webkit).
704
705         * Scripts/import-w3c-tests: Removed.
706         * Scripts/webkitpy/w3c/__init__.py: Removed.
707         * Scripts/webkitpy/w3c/test_converter.py: Removed.
708         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
709         * Scripts/webkitpy/w3c/test_importer.py: Removed.
710         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
711         * Scripts/webkitpy/w3c/test_parser.py: Removed.
712         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
713
714 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
715
716         [jhbuild] bump jhbuild version to take advantage of new improvements
717         https://bugs.webkit.org/show_bug.cgi?id=115558
718
719         Reviewed by Martin Robinson.
720
721         One of the important improvements is jhbuild no longer fetches git
722         repositories if they are already at the expected revision, which should
723         make the EWS bots more robust to git servers unavailability.
724
725         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
726
727 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
728
729         [GTK] Add webkit_uri_scheme_request_finish_error
730         https://bugs.webkit.org/show_bug.cgi?id=94316
731
732         Reviewed by Anders Carlsson.
733
734         * MiniBrowser/gtk/main.c:
735         (miniBrowserErrorQuark): Add function to create a global quark for
736         MiniBrowser.
737         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
738         function webkit_uri_scheme_request_finish_error().
739
740 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
741
742         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
743         https://bugs.webkit.org/show_bug.cgi?id=113808
744
745         Reviewed by Rob Buis.
746
747         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
748         to true for BlackBerry.
749
750         * Scripts/webkitperl/FeatureList.pm:
751
752 2013-05-06  Jessie Berlin  <jberlin@apple.com>
753
754         check-webkit-style should complain about a layering violation if platform-specific guards are
755         used in WebCore outside of the platform directory
756         https://bugs.webkit.org/show_bug.cgi?id=115567
757
758         Reviewed by Benjamin Poulain.
759
760         * Scripts/webkitpy/style/checkers/cpp.py:
761         (check_for_webcore_platform_layering_violation):
762         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
763         (process_line):
764         Add the check_for_webcore_platform_layering_violation.
765         (CppChecker):
766         List the new check.
767
768         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
769         (CppStyleTest.test_webcore_platform_layering_violation):
770         Add tests.
771
772 2013-05-06  David Kilzer  <ddkilzer@apple.com>
773
774         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
775         <http://webkit.org/b/115667>
776
777         Reviewed by Dirk Pranke.
778
779         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
780         (Bugzilla._check_create_bug_response): Update regex to work with
781         Bugzilla 3.2.3 and 4.2.5.
782         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
783         (test__check_create_bug_response): Add new test that covers both
784         old and new <title> variations.
785
786 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
787
788         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
789         https://bugs.webkit.org/show_bug.cgi?id=115661
790
791         Reviewed by Ryosuke Niwa.
792
793         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
794         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
795         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
796
797         * TestResultServer/static-dashboards/flakiness_dashboard.js:
798         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
799
800 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
801
802         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
803         https://bugs.webkit.org/show_bug.cgi?id=114603
804
805         Reviewed by Ryosuke Niwa.
806
807         * TestResultServer/generate_builders_json.py:
808         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
809         to represent these to be 'layout-test', for backwards compatibility.
810         (main): Remove all the build.chromium.org masters.
811         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
812         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
813         (GenerateBuildersJsonTest):
814         (GenerateBuildersJsonTest.test_generate_json_data):
815         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
816         test-running builders from the webkit.org master.
817
818 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
819
820         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
821         https://bugs.webkit.org/show_bug.cgi?id=114988
822
823         Reviewed by Ryosuke Niwa.
824
825         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
826         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
827         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
828         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
829         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
830
831 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
832
833         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
834         https://bugs.webkit.org/show_bug.cgi?id=114954
835
836         Reviewed by Ryosuke Niwa.
837
838         * TestResultServer/static-dashboards/flakiness_dashboard.js:
839         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
840         modifier unions in the list of modifiers.
841         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
842         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
843
844 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
845
846         [Flakiness Dashboard] Simplify builder-name-based platform recognition
847         https://bugs.webkit.org/show_bug.cgi?id=114957
848
849         Reviewed by Ryosuke Niwa.
850
851         * TestResultServer/static-dashboards/flakiness_dashboard.js:
852         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
853         (chromiumPlatform): Removed, unnecessary.
854         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
855         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
856         the builder operates with debug builds, no webkit.org builders are named this way.
857         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
858         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
859
860 2013-05-06  Andy Estes  <aestes@apple.com>
861
862         Added two files I neglected to commit in r149589.
863
864         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
865         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
866
867 2013-05-04  Andy Estes  <aestes@apple.com>
868
869         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
870         https://bugs.webkit.org/show_bug.cgi?id=115609
871
872         Reviewed by Oliver Hunt.
873
874         Added an API test.
875
876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
878         (+[TestDelegate shared]):
879         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
880         (-[TestDelegate webView:createWebViewWithRequest:]):
881         (TestWebKitAPI):
882         (TestWebKitAPI::TEST):
883         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
884
885 2013-05-06  Antoine Quint  <graouts@apple.com>
886
887         Manage the presentation of the snapshotted plug-in using JavaScript
888         https://bugs.webkit.org/show_bug.cgi?id=115548
889
890         Reviewed by Dean Jackson.
891
892         Take into account the new plugInExtraScript method added to support
893         the injection of a JS file from the chrome client to customize the
894         rendering of a snapshotted plug-in's shadow tree.
895
896         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
897         (WTR::InjectedBundlePage::InjectedBundlePage):
898
899 2013-05-05  Anders Carlsson  <andersca@apple.com>
900
901         Remove the Vector::append overload that takes a Vector
902         https://bugs.webkit.org/show_bug.cgi?id=115535
903
904         Reviewed by Andreas Kling.
905
906         Use Vector::appendVector instead.
907
908         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
909         (concatenateAttributeAndValue):
910         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
911         (WTR::concatenateAttributeAndValue):
912
913 2013-05-04  Sam Weinig  <sam@webkit.org>
914
915         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
916         <rdar://problem/13702008>
917         https://bugs.webkit.org/show_bug.cgi?id=115607
918
919         Reviewed by Benjamin Poulain.
920
921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
922         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
923         (TestWebKitAPI::didFinishLoadForFrame):
924         (TestWebKitAPI::TEST):
925         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
926
927 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
928
929         Unreviewed.
930
931         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
932
933 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
934
935         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
936
937         * Scripts/webkitpy/common/config/contributors.json:
938
939 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
940
941         [GTK] Catch select.error exceptions in parse_output_lines
942         https://bugs.webkit.org/show_bug.cgi?id=115253
943
944         Reviewed by Gustavo Noronha Silva.
945
946         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
947         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
948         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
949         error code and the error message) and the loop is re-entered.
950
951         * gtk/common.py:
952         (parse_output_lines):
953
954 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
955
956         [GTK] Set up the TestWebCore in TestWebKitAPI
957         https://bugs.webkit.org/show_bug.cgi?id=115237
958
959         Reviewed by Gustavo Noronha Silva.
960
961         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
962         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
963         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
964         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
965         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
966
967         * TestWebKitAPI/GNUmakefile.am:
968
969 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
970
971         Create a script to import W3C tests
972         https://bugs.webkit.org/show_bug.cgi?id=111513
973
974         Reviewed by Dirk Pranke.
975
976         Script to automate the import of W3C tests into WebKit. 
977         For the full description of how it works, see the comments
978         at the top of test_importer.py.
979
980         * Scripts/import-w3c-tests: Added.
981         * Scripts/webkitpy/w3c/__init__.py: Added.
982         * Scripts/webkitpy/w3c/test_converter.py: Added.
983         (TestConverter):
984         (TestConverter.__init__):
985         (TestConverter.load_prefixed_prop_list):
986         (TestConverter.load_file):
987         (TestConverter.convert_for_webkit):
988         (TestConverter.convert_testharness_paths):
989         (TestConverter.convert_prefixed_properties):
990         (TestConverter.scrub_unprefixed_props):
991         (TestConverter.replace_tag):
992         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
993         (TestConverterTest):
994         (TestConverterTest.testLoadPrefixedPropList):
995         (TestConverterTest.test_convertForWebkitNothingToConvert):
996         (test_convertForWebkitHarnessOnly):
997         (test_convertForWebkitPropsOnly):
998         (test_convertForWebkitHarnessAndProps):
999         (test_convertTestHarnessPaths):
1000         (test_convertPrefixedProperties):
1001         (verifyTestHarnessPaths):
1002         (verifyPrefixedProperties):
1003         (generateTestContent):
1004         * Scripts/webkitpy/w3c/test_importer.py: Added.
1005         (main):
1006         (parse_args):
1007         (validate_import_directory):
1008         (TestImporter):
1009         (TestImporter.__init__):
1010         (TestImporter.do_import):
1011         (TestImporter.get_changeset):
1012         (TestImporter.scan_source_directory):
1013         (TestImporter.import_tests):
1014         (TestImporter.setup_destination_directory):
1015         (TestImporter.get_test_status):
1016         (TestImporter.remove_deleted_files):
1017         (TestImporter.write_import_log):
1018         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
1019         (TestImporterTest):
1020         (TestImporterTest.test_ImportDirWithNoTests):
1021         * Scripts/webkitpy/w3c/test_parser.py: Added.
1022         (TestParser):
1023         (TestParser.__init__):
1024         (TestParser.load_file):
1025         (TestParser.analyze_test):
1026         (TestParser.get_reftests):
1027         (TestParser.is_jstest):
1028         (TestParser.get_support_files):
1029         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
1030         (TestParserTest):
1031         (TestParserTest.test_analyzeTestReftestOneMatch):
1032         (test_analyzeTestReftestMultipleMatches):
1033         (test_analyzeTestReftestMatchAndMismatch):
1034         (test_analyzeTestReftestWithRefSupportFiles):
1035         (test_analyzeJSTest):
1036         (test_analyzePixelTestAllTrue):
1037         (test_analyzePixelTestAllFalse):
1038         (test_analyzeNonHTMLFile):
1039
1040 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1041
1042         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
1043
1044         * Scripts/webkitpy/common/config/contributors.json:
1045
1046 2013-05-02  Nico Weber  <thakis@chromium.org>
1047
1048         Remove a stale script file.
1049         https://bugs.webkit.org/show_bug.cgi?id=115521
1050
1051         Reviewed by Anders Carlsson.
1052
1053         This script was added in
1054         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
1055         Bakefile system that was removed in
1056         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
1057         script just asserts when it's run and is useless.
1058
1059         * Scripts/update-sources-list.py: Removed.
1060
1061 2013-05-01  Glenn Adams  <glenn@skynav.com>
1062
1063         [webkitpy] Need abstract base class for commands that analyze commit logs
1064         https://bugs.webkit.org/show_bug.cgi?id=115391
1065
1066         Reviewed by Benjamin Poulain.
1067
1068         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
1069         in preparation for adding two new commands that will reuse this functionality along with
1070         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
1071         https://bugs.webkit.org/show_bug.cgi?id=115388.
1072
1073         No new tests as this patch does not change existing functionality or behavior.
1074
1075         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1076         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
1077         (AbstractCommitLogCommand.__init__):
1078         (AbstractCommitLogCommand._init_options):
1079         (AbstractCommitLogCommand._parse_commit_message):
1080         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
1081         (SuggestNominations.__init__): 
1082         (SuggestNominations._init_options):
1083
1084 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
1085
1086         Web Inspector: Fix check-inspector-strings script and fix localized strings
1087         https://bugs.webkit.org/show_bug.cgi?id=115495
1088
1089         Reviewed by Joseph Pecoraro.
1090
1091         * Scripts/check-inspector-strings:
1092
1093 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1094
1095         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
1096         https://bugs.webkit.org/show_bug.cgi?id=115470
1097
1098         Reviewed by Martin Robinson.
1099
1100         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
1101         not building either of the IOS, Windows or GTK-WK1 platforms.
1102
1103         Up until now the header was included for everything but the IOS and Windows platforms due to
1104         an incorrectly stated condition regarding the GTK platform.
1105
1106         * TestWebKitAPI/config.h:
1107
1108 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1109
1110         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
1111         https://bugs.webkit.org/show_bug.cgi?id=115469
1112
1113         Reviewed by Martin Robinson.
1114
1115         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
1116         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
1117         for the WebKit2 tests and the injected bundle required by them.
1118
1119         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
1120         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
1121         under the WebKit2 code).
1122
1123         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
1124         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
1125         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
1126
1127         * TestWebKitAPI/GNUmakefile.am:
1128
1129 2013-04-30  Glenn Adams  <glenn@skynav.com>
1130
1131         Unreviewed. Add myself to watchlist entries.
1132
1133         * Scripts/webkitpy/common/config/watchlist:
1134
1135 2013-04-30  Glenn Adams  <glenn@skynav.com>
1136
1137         [webkitpy] suggest-nominations doesn't count all qualified patches
1138         https://bugs.webkit.org/show_bug.cgi?id=115285
1139
1140         Reviewed by Benjamin Poulain.
1141
1142         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
1143         nomination. Improve commit log parsing.
1144
1145         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1146         (CommitLogError):
1147         (CommitLogError.__init__):
1148         (CommitLogMissingReviewer):
1149         (CommitLogMissingReviewer.__init__):
1150         (SuggestNominations):
1151         (SuggestNominations.__init__):
1152         (SuggestNominations._recent_commit_messages):
1153         (SuggestNominations._author_name_from_email):
1154         (SuggestNominations._contributor_from_email):
1155         (SuggestNominations._parse_commit_message):
1156         (SuggestNominations._count_commit):
1157         (SuggestNominations._count_recent_patches):
1158         (SuggestNominations._collect_nominations):
1159         (SuggestNominations._print_nominations):
1160         (SuggestNominations.execute):
1161         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1162         (_make_options):
1163         (test_recent_commit_messages):
1164         (test_basic):
1165
1166 2013-04-30  Commit Queue  <rniwa@webkit.org>
1167
1168         Unreviewed, rolling out r149309.
1169         http://trac.webkit.org/changeset/149309
1170         https://bugs.webkit.org/show_bug.cgi?id=115430
1171
1172         The patch does not build on WK1-only builds of the GTK port
1173         (Requested by zdobersek on #webkit).
1174
1175         * TestWebKitAPI/GNUmakefile.am:
1176
1177 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1178
1179         Stop using "in" keyword in IDL files
1180         https://bugs.webkit.org/show_bug.cgi?id=115418
1181
1182         Reviewed by Kentaro Hara.
1183
1184         Remove "in" keyword from IDL files as this is no longer part of the Web
1185         IDL specification.
1186
1187         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1188         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1189         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1190         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1191         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1192         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
1193         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1194         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1195
1196 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1197
1198         [EFL] Enable scaled cursors
1199         https://bugs.webkit.org/show_bug.cgi?id=106242
1200
1201         Reviewed by Gyuyoung Kim.
1202
1203         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
1204
1205         * Scripts/webkitperl/FeatureList.pm:
1206
1207 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1208
1209         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
1210         https://bugs.webkit.org/show_bug.cgi?id=115380
1211
1212         Reviewed by Kentaro Hara.
1213
1214         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
1215         keyword.
1216
1217         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1219
1220 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1221
1222         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
1223         https://bugs.webkit.org/show_bug.cgi?id=114684
1224
1225         Reviewed by Simon Hausmann.
1226
1227         Remove the ANGLE requirement for USE(3D_GRAPHICS).
1228         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
1229
1230         * qmake/mkspecs/features/features.prf:
1231
1232 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1233
1234         [GTK] Disable Shadow DOM feature
1235         https://bugs.webkit.org/show_bug.cgi?id=115374
1236
1237         Reviewed by Martin Robinson.
1238
1239         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
1240
1241         * Scripts/webkitperl/FeatureList.pm:
1242
1243 2013-04-29  Glenn Adams  <glenn@skynav.com>
1244
1245         [webkitpy] Add missing contributor email addresses
1246         https://bugs.webkit.org/show_bug.cgi?id=115394
1247
1248         Reviewed by Ryosuke Niwa.
1249
1250         * Scripts/webkitpy/common/config/contributors.json:
1251
1252 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
1253
1254         Remove all remaining Skia code
1255         https://bugs.webkit.org/show_bug.cgi?id=115263
1256
1257         Reviewed by Benjamin Poulain.
1258
1259         Remove all remaining references to Skia.
1260
1261         * Scripts/webkitdirs.pm:
1262         (blackberryCMakeArguments):
1263         * Scripts/webkitpy/common/config/contributionareas.py:
1264         * Scripts/webkitpy/common/config/watchlist:
1265
1266 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
1267
1268         Get rid of unused options in Tools/Scripts/webkit-build-directory
1269         https://bugs.webkit.org/show_bug.cgi?id=115383
1270
1271         Reviewed by Darin Adler.
1272
1273         * Scripts/webkit-build-directory:
1274
1275 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1276
1277         [WK2][Mac] Test with NetworkProcess enabled.
1278
1279         Fix the build for non-Mac.
1280
1281         * WebKitTestRunner/TestController.cpp:
1282         (WTR::TestController::initialize):
1283
1284 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1285
1286         [WK2][Mac] Test with NetworkProcess enabled.
1287
1288         Reviewed by Sam Weinig.
1289
1290         * WebKitTestRunner/TestController.cpp:
1291         (WTR::TestController::initialize):
1292
1293 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1294
1295         [GTK] Set up the TestWebCore in TestWebKitAPI
1296         https://bugs.webkit.org/show_bug.cgi?id=115237
1297
1298         Reviewed by Gustavo Noronha Silva.
1299
1300         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
1301         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
1302         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
1303         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
1304         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
1305
1306         * TestWebKitAPI/GNUmakefile.am:
1307
1308 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1309
1310         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
1311         https://bugs.webkit.org/show_bug.cgi?id=115236
1312
1313         Reviewed by Gustavo Noronha Silva.
1314
1315         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
1316         under the TestWebKitAPI/Tests/JavaScriptCore directory.
1317
1318         * TestWebKitAPI/GNUmakefile.am:
1319
1320 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1321
1322         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
1323         https://bugs.webkit.org/show_bug.cgi?id=115323
1324
1325         Reviewed by Philippe Normand.
1326
1327         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
1328         Its presence enforces linkers to output mangled symbols when reporting linking failures
1329         due to unresolved references. People trying to fix the build can then simply copy
1330         the printed mangled symbol into the symbols.filter file instead of doing a manual build
1331         or connecting to the builders to discover the mangled version of the missing symbol.
1332
1333         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1334
1335 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1336
1337         Remove Chromium code from Tools/BuildSlaveSupport
1338         https://bugs.webkit.org/show_bug.cgi?id=115325
1339
1340         Reviewed by Benjamin Poulain.
1341
1342         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
1343         covering archiving test results and built products.
1344
1345         * BuildSlaveSupport/built-product-archive:
1346         (archiveBuiltProduct):
1347         (extractBuiltProduct):
1348         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
1349         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
1350         * BuildSlaveSupport/test-result-archive:
1351         (archiveTestResults):
1352
1353 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
1354
1355         Remove support for Chromium from webkitdirs.pm
1356         https://bugs.webkit.org/show_bug.cgi?id=115338
1357
1358         Reviewed by Darin Adler.
1359
1360         * Scripts/webkitdirs.pm:
1361         (determineBaseProductDir):
1362         (argumentsForConfiguration):
1363         (builtDylibPathForName):
1364         (determineIsQt):
1365         (isAppleWebKit):
1366
1367 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1368
1369         Rename TestRunner's setAudioData to setAudioResult
1370         https://bugs.webkit.org/show_bug.cgi?id=115326
1371
1372         Reviewed by Darin Adler.
1373
1374         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
1375         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
1376         affected tests are adjusted accordingly.
1377
1378         * DumpRenderTree/qt/TestRunnerQt.cpp:
1379         (TestRunnerQt::setAudioResult):
1380         * DumpRenderTree/qt/TestRunnerQt.h:
1381         (TestRunnerQt):
1382         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1383         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1384         (WTR::TestRunner::setAudioResult):
1385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1386         (TestRunner):
1387
1388 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1389
1390         [WKTR] Tests dumping audio data shouldn't dump pixels
1391         https://bugs.webkit.org/show_bug.cgi?id=115270
1392
1393         Reviewed by Benjamin Poulain.
1394
1395         Prevent dumping the pixel output when Web Audio tests are dumping output data
1396         as the testing output. Pixel output in these tests has no real meaning and is
1397         as such unnecessary.
1398
1399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1400         (WTR::TestRunner::setAudioData):
1401
1402 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1403
1404         [EFL] Unreviewed Intel bots fix after r149231.
1405
1406         * efl/jhbuild.modules: Disable the libxml Python bindings since the
1407         bots don't have Python's development files installed. libxml should
1408         detect this kind of thing better.
1409
1410 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
1411
1412         [EFL] Build break using jhbuild on ubuntu 13.04
1413         https://bugs.webkit.org/show_bug.cgi?id=115225
1414
1415         Reviewed by Gyuyoung Kim.
1416
1417         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
1418         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
1419         So this patch bumped libxml version to 2.9.1.
1420
1421         * efl/jhbuild.modules:
1422
1423 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
1424
1425         delete-stale-build-files does not clear .d files
1426         http://bugs.webkit.org/show_bug.cgi?id=115293
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         * BuildSlaveSupport/delete-stale-build-files:
1431         (main): Add .d to the file type list
1432
1433 2013-04-26  Roger Fong  <roger_fong@apple.com>
1434
1435         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
1436         Make the DebugSuffix configuration use _debug dependencies.
1437
1438         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1439         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
1440         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1441         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1442         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1443         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1444         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
1445         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1446         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1447         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1448         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1449         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1450         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1451         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1452         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1453         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1454         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1455         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1456         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1457         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
1458         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1459         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1460         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1461         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1462         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1463         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1464         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
1465         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1466         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1467         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1468         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1469         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1470         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1471         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
1472         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1473         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1474         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1475         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1476         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1477         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1478         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1479         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1480         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1481         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
1482         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1483         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1484         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1485         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1486         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1487         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1488         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1489         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1490         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1491         * win/AssembleBuildLogs/AssembleLogs.cmd:
1492         * win/record-memory/record-memory.vcxproj:
1493         * win/record-memory/record-memoryDebug.props:
1494         * win/record-memory/record-memoryDebugWinCairo.props:
1495         * win/record-memory/record-memoryProduction.props:
1496         * win/record-memory/record-memoryRelease.props:
1497         * win/record-memory/record-memoryReleaseWinCairo.props:
1498
1499 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1500
1501         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
1502         https://bugs.webkit.org/show_bug.cgi?id=115233
1503
1504         Reviewed by Martin Robinson.
1505
1506         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
1507         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
1508         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
1509         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
1510         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
1511
1512         * TestWebKitAPI/GNUmakefile.am:
1513
1514 2013-04-25  Andy Estes  <aestes@apple.com>
1515
1516         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
1517         https://bugs.webkit.org/show_bug.cgi?id=115223
1518
1519         Reviewed by Darin Adler.
1520
1521         Added an API test.
1522
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1524         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
1525         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
1526         when it loads a request with a custom protocol.
1527         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
1528         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
1529         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
1530         miscellaneous cleanup.
1531         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
1532         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
1533         (+[TestProtocol canInitWithRequest:]):
1534         (+[TestProtocol canonicalRequestForRequest:]):
1535         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1536         (+[TestProtocol scheme]):
1537         (-[TestProtocol startLoading]):
1538         (-[TestProtocol stopLoading]):
1539
1540 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1541
1542         Remove the remaining Skia #ifdefs
1543         https://bugs.webkit.org/show_bug.cgi?id=114886
1544
1545         Reviewed by Benjamin Poulain.
1546
1547         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1548         (createBitmapContextFromWebView): Remove Skia #ifdef references.
1549
1550 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1551
1552         [BlackBerry] Clean up load interface in WebPage
1553         https://bugs.webkit.org/show_bug.cgi?id=113267
1554
1555         Reviewed by Rob Buis.
1556
1557         Update DumpRenderTree with change of load() interface in WebPage.
1558         RIM Bug# 315535, internally reviewed by Joe Mason.
1559
1560         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1561         (BlackBerry::WebKit::DumpRenderTree::runTest):
1562
1563 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1564
1565         Remove the HeapGraphSerializer unit test
1566         https://bugs.webkit.org/show_bug.cgi?id=115231
1567
1568         Reviewed by Andreas Kling.
1569
1570         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
1571         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
1572
1573         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1574
1575 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1576
1577         Remove support for Chromium from build/update scripts
1578         https://bugs.webkit.org/show_bug.cgi?id=115218
1579
1580         Reviewed by Darin Adler.
1581
1582         * Scripts/build-webkit:
1583         (writeCongrats):
1584         * Scripts/update-webkit:
1585
1586 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1587
1588         Remove support for Chromium from api-test
1589         https://bugs.webkit.org/show_bug.cgi?id=115211
1590
1591         Reviewed by Dirk Pranke.
1592
1593         * Scripts/build-api-tests:
1594         * Scripts/run-api-tests:
1595         (isSupportedPlatform):
1596
1597 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1598
1599         Get rid of Chromium in build-dumprendertree
1600         https://bugs.webkit.org/show_bug.cgi?id=115212
1601
1602         Reviewed by Dirk Pranke.
1603
1604         * Scripts/build-dumprendertree:
1605
1606 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
1607
1608         Pass relatedPage when creating a page in WebKitTestRunner
1609         https://bugs.webkit.org/show_bug.cgi?id=115206
1610
1611         Reviewed by Geoffrey Garen.
1612
1613         To make sure that window.open() opens in the same process even when using multiple processes.
1614
1615         * WebKitTestRunner/PlatformWebView.h:
1616         * WebKitTestRunner/TestController.cpp:
1617         (WTR::TestController::createOtherPage):
1618         (WTR::TestController::createWebViewWithOptions):
1619         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1620         (WTR::PlatformWebView::PlatformWebView):
1621         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1622         (WTR::PlatformWebView::PlatformWebView):
1623         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1624         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1625         (WTR::PlatformWebView::PlatformWebView):
1626         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1627         (WTR::PlatformWebView::PlatformWebView):
1628         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1629         (WTR::PlatformWebView::PlatformWebView):
1630
1631 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1632
1633         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
1634
1635         * Scripts/webkitpy/common/config/contributors.json:
1636
1637 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1638
1639         Build fix. Forgot to merge args.
1640
1641         * Scripts/webkitpy/tool/bot/irc_command.py:
1642         (Hi.execute):
1643
1644 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         webkitbot should recognize its own nickname in greetings.
1647         https://bugs.webkit.org/show_bug.cgi?id=115196
1648
1649         Reviewed by Andreas Kling.
1650
1651         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
1652
1653         * Scripts/webkitpy/tool/bot/irc_command.py:
1654         (Hi.execute):
1655
1656 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
1657
1658         [GTK] Tools/gtk/install-dependencies added ragel dependency
1659         https://bugs.webkit.org/show_bug.cgi?id=115163
1660
1661         Reviewed by Xan Lopez.
1662
1663         The install-dependencies script was missing a dependency on ragel
1664         which is expected when building HarfBuzz.
1665
1666         * gtk/install-dependencies: Added a dependency on ragel for both
1667         apt and yum.
1668
1669 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
1670
1671         [GTK] Remove pango from optional jhbuild dependencies
1672         https://bugs.webkit.org/show_bug.cgi?id=115162
1673
1674         Reviewed by Martin Robinson.
1675
1676         Pango is not needed since revision r148293 that lowers the pango
1677         dependency to 1.30, which is available in most distributions.
1678
1679         * gtk/jhbuild-optional.modules: Removes description of pango module.
1680
1681 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1682
1683         Remove Chromium-specific cases from FeatureList.pm
1684         https://bugs.webkit.org/show_bug.cgi?id=115169
1685
1686         Reviewed by Andreas Kling.
1687
1688         * Scripts/webkitperl/FeatureList.pm:
1689
1690 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1691
1692         Remove checking chromium from run-webkit-tests
1693         https://bugs.webkit.org/show_bug.cgi?id=115139
1694
1695         Reviewed by Benjamin Poulain.
1696
1697         * Scripts/run-webkit-tests:
1698         (useNewRunWebKitTests):
1699
1700 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
1701
1702         Pixel tests in SVG are all broken in WK2
1703         https://bugs.webkit.org/show_bug.cgi?id=114218
1704
1705         Reviewed by Darin Adler.
1706         
1707         Window snapshots in WebKitTestRunner on Mac are window-sized
1708         (800x600), which is wrong for the W3C SVG tests that require a
1709         480x360 snapshot.
1710         
1711         Fix by resizing the window, as well as the web view in
1712         PlatformWebView::resizeTo() so that window snapshots are correctly
1713         sized.
1714         
1715         Also do some drive-by cleanup of the window size constants in both
1716         DRT and WTR to remove magic numbers, and make the code more similar.
1717         
1718         * DumpRenderTree/TestRunner.cpp:
1719         (TestRunner::setShouldPaintBrokenImage):
1720         * DumpRenderTree/TestRunner.h:
1721         * DumpRenderTree/efl/DumpRenderTree.cpp:
1722         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1723         (webInspectorShowWindow):
1724         * DumpRenderTree/mac/DumpRenderTree.mm:
1725         (createWebViewAndOffscreenWindow):
1726         (sizeWebViewForCurrentTest):
1727         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1728         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1729         (createPagedBitmapContext):
1730         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1731         (DumpRenderTree::DumpRenderTree):
1732         (DumpRenderTree::open):
1733         * DumpRenderTree/qt/TestRunnerQt.cpp:
1734         * DumpRenderTree/qt/TestRunnerQt.h:
1735         * DumpRenderTree/win/DumpRenderTree.cpp:
1736         (sizeWebViewForCurrentTest):
1737         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1738         * WebKitTestRunner/TestController.cpp:
1739         (WTR::TestController::resetStateToConsistentValues):
1740         * WebKitTestRunner/TestController.h:
1741         * WebKitTestRunner/TestInvocation.cpp:
1742         (WTR::sizeWebViewForCurrentTest):
1743         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1744         (WTR::PlatformWebView::PlatformWebView):
1745         (WTR::PlatformWebView::resizeTo):
1746
1747 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
1748
1749         [EFL] Fix build error after r148963.
1750         https://bugs.webkit.org/show_bug.cgi?id=115126
1751
1752         Reviewed by Laszlo Gombos.
1753
1754         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
1755
1756         * TestWebKitAPI/PlatformEfl.cmake:
1757
1758 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1759
1760         [GTK] Use stamp files for generate-forwarding-headers makefile rules
1761         https://bugs.webkit.org/show_bug.cgi?id=115118
1762
1763         Reviewed by Martin Robinson.
1764
1765         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
1766         forwarding generator rules and don't call it for soup since there
1767         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
1768
1769         * TestWebKitAPI/GNUmakefile.am:
1770         * WebKitTestRunner/GNUmakefile.am:
1771
1772 2013-04-24  Simon Pena  <simon.pena@samsung.com>
1773
1774         [GTK] Update build dependencies
1775         https://bugs.webkit.org/show_bug.cgi?id=115111
1776
1777         Reviewed by Martin Robinson.
1778
1779         The install-dependencies script was missing a dependency on EGL,
1780         which is expected when building Cairo.
1781
1782         * gtk/install-dependencies: Added a dependency on libegl1-mesa
1783         for both apt and yum.
1784
1785 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1786
1787         Remove the Chromium-specific helper from run_webkit_tests.py
1788         https://bugs.webkit.org/show_bug.cgi?id=114996
1789
1790         Reviewed by Dirk Pranke.
1791
1792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1793         (parse_args):
1794
1795 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
1796
1797         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
1798         https://bugs.webkit.org/show_bug.cgi?id=114850
1799
1800         Reviewed by Andreas Kling.
1801
1802         Revision r148312 fixed WebPageProxy cleanup and also changed the process
1803         termination semantics when requested by the user so that a client is not
1804         notified of a crash anymore, since there was no crash anyway.
1805
1806         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
1807         relied on being notified of a crash after calling WKPageTerminate(). As
1808         a result of not being notified of such non-existent crash, the test would
1809         timeout right after making the terminate call.
1810
1811         This patch adds an InjectedBundle to be used for simulating a crash, by
1812         calling abort() upon receiving a "Crash" message, and thus we are able to
1813         keep testing the crash callback.
1814
1815         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
1816         had been disabled in revisions r148858 and r148855, since it was failing.
1817
1818         * TestWebKitAPI/PlatformEfl.cmake:
1819         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1820         (TestWebKitAPI::TEST):
1821         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
1822         (TestWebKitAPI):
1823         (WKViewClientWebProcessCallbacksTest):
1824         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
1825         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
1826
1827 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1828
1829         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
1830         https://bugs.webkit.org/show_bug.cgi?id=115095
1831
1832         Reviewed by Antonio Gomes.
1833
1834         Use different subfolders under DumpRenderTree Temp folder for every
1835         functionality (icon database, cache, localstorage, ...). This makes
1836         sure there is no conflict between the functionalities.
1837
1838         In EFL's case, libsoup cache was causing problems for the icon
1839         database if sharing the same folder.
1840
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::initialize):
1843
1844 == Rolled over to ChangeLog-2013-04-24 ==