54a6c0a26c8cbfc1b2a4df22677e211eef098e8f
[WebKit-https.git] / Tools / ChangeLog
1 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2
3         Remove forgotten unused Tools/Script/make-gypi script
4         https://bugs.webkit.org/show_bug.cgi?id=117558
5
6         Reviewed by Ryosuke Niwa.
7
8         This script isn't used since the GYP removal from WebKit.
9
10         * Scripts/make-gypi: Removed.
11
12 2013-06-12  Andres Gomez  <agomez@igalia.com>
13
14         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
15         https://bugs.webkit.org/show_bug.cgi?id=117533
16
17         Reviewed by Carlos Garcia Campos.
18
19         MiniBrowser now starts automatically the download of the documents
20         that cannot be shown just by WebKit itself on link left clicking.
21
22         * MiniBrowser/gtk/BrowserWindow.c:
23         (webViewDecidePolicy): handled the
24         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
25
26 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
27
28         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
29         https://bugs.webkit.org/show_bug.cgi?id=116723
30
31         Reviewed by Carlos Garcia Campos.
32
33         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
34         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
35         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
36         not expensive and produces a working archive without problems even on incremental builds.
37
38 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
39
40         [EFL] Window resize should close the popupmenu
41         https://bugs.webkit.org/show_bug.cgi?id=117391
42
43         Reviewed by Christophe Dumez.
44         
45         Added the code to close the popup when main window is resized.
46
47         * MiniBrowser/efl/main.c:
48         (on_window_resize):
49
50 2013-06-11  Alex Christensen  <achristensen@apple.com>
51
52         Removed old broken code coverage tool.
53         https://bugs.webkit.org/show_bug.cgi?id=117520
54
55         Reviewed by Sam Weinig.
56
57         * CodeCoverage: Removed.
58         * CodeCoverage/README: Removed.
59         * CodeCoverage/amber.png: Removed.
60         * CodeCoverage/cov.py: Removed.
61         * CodeCoverage/emerald.png: Removed.
62         * CodeCoverage/gcov.css: Removed.
63         * CodeCoverage/glass.png: Removed.
64         * CodeCoverage/regenerate-coverage-display: Removed.
65         * CodeCoverage/ruby.png: Removed.
66         * CodeCoverage/run-generate-coverage-data: Removed.
67         * CodeCoverage/snow.png: Removed.
68
69 2013-06-11  Timothy Hatcher  <timothy@apple.com>
70
71         Have build-webkit build the WebInspectorUI project.
72
73         * Scripts/build-webkit:
74
75 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
76
77         Add an option to run-webkit-tests to skip java dependency check
78         https://bugs.webkit.org/show_bug.cgi?id=117516
79
80         Reviewed by Andreas Kling.
81
82         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
83         (parse_args):
84         * Scripts/webkitpy/port/mac.py:
85         (MacPort._check_port_build):
86
87 2013-06-11  Alex Christensen  <achristensen@apple.com>
88
89         https://bugs.webkit.org/show_bug.cgi?id=117514
90         Removed extra Xcode code coverage flags.
91
92         Reviewed by Sam Weinig.
93
94         * Scripts/webkitdirs.pm:
95         (XcodeCoverageSupportOptions):
96
97 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
98
99         [Windows] Implement 'attributeValue' accessor to support testing
100         https://bugs.webkit.org/show_bug.cgi?id=117513
101
102         Reviewed by Anders Carlsson.
103
104         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
105         (comparableObject): Move earlier in file.
106         (findAccessibleObjectById): New implemenation.
107         (AccessibilityController::accessibleElementById): New implementation.
108
109 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
110
111         Make WTR use its own temporary directory for application cache
112         https://bugs.webkit.org/show_bug.cgi?id=117143
113
114         Reviewed by Alexey Proskuryakov.
115
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::initialize):
118
119 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
120
121         https://bugs.webkit.org/show_bug.cgi?id=117449
122         Remove dead code for storing fonts in __DATA section
123
124         Reviewed by Dan Bernstein.
125
126         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
127         Don't copy font resources to __DATA, as we don't have any code that reads them
128         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
129
130         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
131         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
132         Removed comments suggesting that we want to restore the old solution.
133
134 2013-06-10  Bear Travis  <betravis@adobe.com>
135
136         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
137         https://bugs.webkit.org/show_bug.cgi?id=117162
138
139         Reviewed by Alexandru Chiculita.
140
141         Adding the WebCore/rendering/shapes directory to the include list.
142
143         * DumpRenderTree/efl/CMakeLists.txt:
144
145 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
146
147         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
148         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
149         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
150         happends in some of the 'accessibility' test cases.
151
152 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
153
154         [WinCairo] TestWebKitAPI fails to link.
155         https://bugs.webkit.org/show_bug.cgi?id=117345
156
157         Reviewed by Brent Fulgham.
158
159         Need to link with WTF.lib.
160
161         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
162
163 2013-06-07  Roger Fong  <roger_fong@apple.com>
164
165         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
166
167         Rubberstamped by Ryousuke Niwa.
168
169         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
170         (RunTest.test_build_check):
171
172 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
173
174         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
175         https://bugs.webkit.org/show_bug.cgi?id=117315
176
177         Reviewed by Benjamin Poulain.
178
179         Qt doesn't use the default values specified on FeatureList since r44681,
180         this patch just remove a bit of noise.
181
182         * Scripts/webkitperl/FeatureList.pm:
183
184 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
185
186         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
187         https://bugs.webkit.org/show_bug.cgi?id=115890
188
189         Reviewed by Christophe Dumez.
190
191         When user clicks HTML5 input type color,
192         color selector window is created on browser object by using elm_colorchooser_add().
193         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
194         The evas_object_color_set() sets a color value returning to browser.
195
196         * MiniBrowser/efl/main.c:
197         (window_free): When we delete parent window, deleting the colorpicker object.
198         (on_color_changed): Change color of rectangle to show color selected by user.
199         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
200         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
201         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
202         (on_color_picker_dismiss): Delete colorpicker object.
203         (on_color_picker_request): Create colorpicker window object.
204         (window_create):
205
206 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
207
208         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
209         https://bugs.webkit.org/show_bug.cgi?id=111066
210
211         Reviewed by Daniel Bates.
212
213         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
214
215         ParseGitDiffHeader() should support the path which line has space characters.
216         To support this, I changed parsing algorithm like the following:
217         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
218         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
219
220         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
221
222         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
223         I added a dummy tab and revision when we convert git diff to svn diff.
224
225         * Scripts/VCSUtils.pm:
226         (parseGitDiffHeader):
227         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
228         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
229         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
230           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
231
232 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
233
234         Add a menu item to MiniBrowser to toggle Transparent windows
235         https://bugs.webkit.org/show_bug.cgi?id=117316
236
237         Reviewed by Anders Carlsson.
238         
239         Add a menu item that toggles "Transparent window" mode, which is exposed
240         via private WebKit API and WebKit2 API.
241
242         * MiniBrowser/mac/BrowserWindowController.h:
243         * MiniBrowser/mac/MainMenu.xib:
244         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
245         * MiniBrowser/mac/WK1BrowserWindowController.m:
246         (-[WK1BrowserWindowController validateMenuItem:]):
247         (-[WK1BrowserWindowController toggleTransparentWindow:]):
248         * MiniBrowser/mac/WK2BrowserWindowController.m:
249         (-[WK2BrowserWindowController validateMenuItem:]):
250         (-[WK2BrowserWindowController toggleTransparentWindow:]):
251         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
252         when testing.
253
254 2013-06-06  Roger Fong  <roger_fong@apple.com>
255
256         Stop copying AAS binaries into build folder.
257         https://bugs.webkit.org/show_bug.cgi?id=117319.
258
259         Rubberstamped by Darin Adler.
260
261         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
262
263 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
264
265         Aligning build-webkit command line switch names to the WebKit flag names
266         https://bugs.webkit.org/show_bug.cgi?id=117254
267
268         Reviewed by Laszlo Gombos.
269
270         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
271
272 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
273
274         AX: iOS ignores ARIA progressbar elements
275         https://bugs.webkit.org/show_bug.cgi?id=116727
276
277         Reviewed by David Kilzer.
278
279         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
280         (AccessibilityUIElement::minValue):
281         (AccessibilityUIElement::maxValue):
282
283 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
284
285         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
286         https://bugs.webkit.org/show_bug.cgi?id=117255
287
288         Reviewed by Daniel Bates.
289
290         Need to update configuration names according to solution file.
291
292         * Scripts/webkitdirs.pm:
293         (determineConfiguration):
294         (determinePassedConfiguration):
295
296 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
297
298         Remove run-performance-tests
299         https://bugs.webkit.org/show_bug.cgi?id=117285
300
301         Reviewed by Andreas Kling.
302         
303         Remove the script since it's not used anywhere.
304
305         * BuildSlaveSupport/run-performance-tests: Removed.
306
307 2013-06-05  Bear Travis  <betravis@adobe.com>
308
309         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
310         https://bugs.webkit.org/show_bug.cgi?id=117172
311
312         Reviewed by Alexandru Chiculita.
313
314         Adding the CSS_SHAPES compile flag.
315
316         * Scripts/webkitperl/FeatureList.pm:
317         * qmake/mkspecs/features/features.pri:
318
319 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
320
321         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
322         to UNIX-style they will not execute properly.
323
324         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
325         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
326
327 2013-06-05  Roger Fong  <roger_fong@apple.com>
328
329         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
330
331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
332         (RunWebKitTests.start):
333
334 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
335
336         [Windows] Switch to NRWT
337         https://bugs.webkit.org/show_bug.cgi?id=117200
338
339         Reviewed by Anders Carlsson.
340
341         * Scripts/run-webkit-tests:
342         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
343
344 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
345
346         Unreviewed name fix after r150662
347
348         My firstname got duplicated when fixing bug 116737.
349
350         * Scripts/webkitpy/common/config/contributors.json:
351
352 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
353
354         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
355         https://bugs.webkit.org/show_bug.cgi?id=117244
356
357         Reviewed by Daniel Bates.
358
359         Fixed a regression introduced by r151196: not only does webkit.org
360         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
361         infrastructure used by ports such as GTK+ and EFL also use on it for
362         things such as jhbuild.
363
364         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
365         both environment variables.
366
367         * Scripts/webkitdirs.pm:
368         (determineBaseProductDir):
369
370 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
371
372         [GTK] Forwarding headers not generated for incremental build
373         https://bugs.webkit.org/show_bug.cgi?id=117198
374
375         Reviewed by Carlos Garcia Campos.
376
377         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
378
379 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
380
381         [Qt][WK2] Fix layout testing with Qt 5.1
382         https://bugs.webkit.org/show_bug.cgi?id=117203
383
384         Reviewed by Jocelyn Turcotte.
385
386         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
387         go into loading state but directly call handler functions for
388         finished state instead of relying on a connection.
389         Our wrapper QQuickView uses a data URI scheme to create the root
390         item for testing which results in a synchronous request when loading
391         the QML data, therefore the state of the QQuickWindow immediately
392         becomes Ready.
393         Since the final initialization of the root item depended on the
394         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
395         up with a partially initialized wrapper window, thus most of our
396         layout tests were failing.
397         For compatibility with pre-5.1 Qt versions keep the old behaviour
398         in case the WrapperWindow is not ready in the constructor yet.
399
400         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
401         (WTR::WrapperWindow::WrapperWindow):
402         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
403         (TestWebKitAPI::WrapperWindow::WrapperWindow):
404
405 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
406
407         Bad value in tests counter at new-run-webkit-tests
408         in --debug-rwt-logging mode
409         https://bugs.webkit.org/show_bug.cgi?id=116858
410
411         Reviewed by Dirk Pranke.
412
413         Fix by moving counter incrementation, from after printing line,
414         to before printing. Also changed variable name.
415
416         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
417         (LayoutTestRunner.run_tests):
418         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
419         (FakePrinter):
420         * Scripts/webkitpy/layout_tests/views/printing.py:
421         (Printer.__init__):
422         (Printer._test_status_line):
423         (Printer.print_started_test):
424         (Printer.print_finished_test):
425         * Scripts/webkitpy/test/printer.py:
426         (Printer.__init__):
427         (Printer.print_finished_test):
428         (Printer._test_line):
429         (Printer.print_result):
430
431 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
432
433         Move MemoryInfo under window.internals
434         https://bugs.webkit.org/show_bug.cgi?id=117197
435
436         Reviewed by Ryosuke Niwa.
437
438         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
439         the Automake build
440         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
441         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
442
443 2013-06-03  Roger Fong  <roger_fong@apple.com>
444
445         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
446         <rdar://problem/14042021>.
447
448         Reviewed by Brent Fulgham.
449
450         * Scripts/build-api-tests:
451         * Scripts/build-dumprendertree:
452         * Scripts/build-webkit:
453         * Scripts/update-webkit-dependency:
454         * Scripts/update-webkit-support-libs:
455         * Scripts/webkitdirs.pm:
456         (determineBaseProductDir):
457         (setupAppleWinEnv):
458         (setupCygwinEnv):
459
460 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
461
462         [Windows] NRWT is not putting crash logs in proper place (corrections)
463         https://bugs.webkit.org/show_bug.cgi?id=117212
464
465         Reviewed by Dirk Pranke.
466
467         * Scripts/webkitpy/common/system/crashlogs.py:
468         (CrashLogs.__init__): Accept a result directory argument in constructor.
469         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
470         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
471         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
472         (CrashLogsTest.test_find_log_win): Simplify test.
473         * Scripts/webkitpy/common/system/executive.py:
474         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
475         * Scripts/webkitpy/port/win.py:
476         (WinPort._get_crash_log): No longer require 'port' argument.
477
478 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
479
480         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
481
482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
483
484 2013-06-04  Greg Hughes  <ghughes@apple.com>
485
486         Add "VisibleOnly" key to search predicate
487         https://bugs.webkit.org/show_bug.cgi?id=115491
488
489         Reviewed by Chris Fleizach.
490
491         Added support for accessibility clients to use the search predicate to find only visible elements
492
493         * DumpRenderTree/AccessibilityUIElement.cpp:
494         (uiElementForSearchPredicateCallback):
495         * DumpRenderTree/AccessibilityUIElement.h:
496         (AccessibilityUIElement):
497         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
498         (AccessibilityUIElement::uiElementForSearchPredicate):
499         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
500         (AccessibilityUIElement::uiElementForSearchPredicate):
501         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
502         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
503         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
504         (AccessibilityUIElement):
505         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
506         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
507         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
508
509 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
510
511         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
512         causing build failure.
513
514         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
515         DOS-style CR/LF endings.
516
517 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
518
519         [Windows] Unreviewed test correction.
520
521         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
522         QuartzCore dll's, which are needed by TestWebKitAPI.
523         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
524         with VS2010 will run when linked against VS2005 support libraries.
525
526 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
527
528         Automatically generate WorkerContext constructor attributes
529         https://bugs.webkit.org/show_bug.cgi?id=117183
530
531         Reviewed by Kentaro Hara.
532
533         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
534         tests.
535
536         * Scripts/webkitpy/bindings/main.py:
537         (BindingsTests.generate_supplemental_dependency):
538         (BindingsTests.main):
539
540 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
541
542         [EFL] File dialog of MiniBrowser have broken background.
543         https://bugs.webkit.org/show_bug.cgi?id=117189
544
545         Reviewed by Christophe Dumez.
546
547         * MiniBrowser/efl/main.c:
548         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
549
550 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
551
552         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
553         https://bugs.webkit.org/show_bug.cgi?id=117184
554
555         Reviewed by Gyuyoung Kim.
556
557         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
558         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
559
560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
561         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
562         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
563
564 2013-06-03  Simon Pena  <simon.pena@samsung.com>
565
566         validate-committer-lists script is now outdated and does not work
567         https://bugs.webkit.org/show_bug.cgi?id=115860
568
569         Reviewed by Brent Fulgham.
570
571         The script validate-committer-lists was outdated, still using the deprecated log
572         system and having the old addresses for the mailing lists, as well as still referring
573         to committers.py, after this was renamed to contributors.json. This patch fixes that
574         so it can be used again.
575
576         * Scripts/validate-committer-lists: Replace calls to log and error with the
577         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
578         to committers.py, which should be contributors.json.
579         (CommitterListFromMailingList):
580         (CommitterListFromMailingList.check_for_emails_missing_from_list):
581         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
582         (CommitterListFromGit._fill_in_emails_for_old_logins):
583         (CommitterListFromGit.print_committers_missing_from_committer_list):
584
585 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
586
587         add a script to dump the tests run most recently by a given worker
588         https://bugs.webkit.org/show_bug.cgi?id=116571
589
590         Reviewed by Brent Fulgham.
591
592         The tests_run*.txt results files in layout-test-results/ were removed
593         in r137356, in favor of collecting more data about how the tests were
594         run and compressing it and storing it in stats.json. However, it was
595         nice to just be able to look at a flat text file.
596
597         This script will extract the tests run by a given worker from a
598         given stats.json file, and should help to address that.
599
600         * Scripts/dump-webkit-tests-run: Added.
601         (main):
602         (convert_trie_to_flat_paths):
603
604 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
605
606         [Windows] NRWT is not putting crash logs in proper place
607         https://bugs.webkit.org/show_bug.cgi?id=117098
608
609         Reviewed by Ryosuke Niwa.
610
611         Provide windows-specific overloads for various Port features needed to create and capture
612         crash logs.  This change makes it possible to view crash logs (when created) as part of the
613         summary report at the end of the NRWT run.
614
615         * Scripts/webkitpy/common/system/crashlogs.py:
616         (CrashLogs.find_newest_log): Add support for win32 crash logs
617         (CrashLogs._find_newest_log_win): Added
618         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
619         (make_mock_crash_report_win): Added
620         (CrashLogsTest.test_find_log_win): Added.
621         * Scripts/webkitpy/common/system/executive.py:
622         (Executive.running_pids): Add support for Cygwin win32 crash logs
623         * Scripts/webkitpy/common/system/executive_mock.py:
624         (MockExecutive.__init__):
625         * Scripts/webkitpy/common/system/filesystem_unittest.py:
626         (RealFileSystemTest.test_read_and_write_file): Add tests for
627         malformed ascii/utf8 handling (i.e., Windows log files)
628         * Scripts/webkitpy/port/base.py:
629         (Port.find_system_pid): Added
630         * Scripts/webkitpy/port/server_process.py:
631         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
632         * Scripts/webkitpy/port/win.py:
633         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
634         for user to hit enter.
635         (WinPort._get_crash_log): Added
636         (WinPort.look_for_new_crash_logs): Added
637         (WinPort.find_system_pid): Added
638         * Scripts/webkitpy/port/win_unittest.py:
639         (WinPortTest.test_get_crash_log): Added test
640
641 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
642
643         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
644         https://bugs.webkit.org/show_bug.cgi?id=116726
645
646         Reviewed by Gyuyoung Kim.
647
648         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
649         the platform (it is not listed in jhbuild moduleset). That version is
650         old-ish and contain deprecated symbols and missing API, that are blocking
651         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
652         moduleset, which is the same version the gtk port uses.
653
654         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
655         why this is needed.
656
657         * efl/jhbuild.modules: Adds ATK module as dependency
658
659 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
660
661         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
662         https://bugs.webkit.org/show_bug.cgi?id=117168
663
664         Reviewed by Martin Robinson.
665
666         The tool generate-gtkdoc internally calls pkg-config.
667         When cross-compiling it shouldn't use pkg-config, but
668         it should use the pkg-config which was detected by
669         the ./configure script (for example this can be
670         i686-w64-mingw32-pkg-config when cross-compiling)
671
672         * GNUmakefile.am:
673         * gtk/gtkdoc.py:
674         (PkgConfigGTKDoc.__init__):
675
676 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
677
678         [Windows] Unreviewed build fix.
679
680         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
681         allow VS2010 builds to use VS2005 runtime libraries as needed.
682
683 2013-06-03  Roger Fong  <roger_fong@apple.com>
684
685         Nuke VS2005 files from the tree.
686         <rdar://problem/14042021>.
687
688         Rubberstamped by Brent Fulgham.
689
690         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
691         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
692         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
693         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
694         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
695         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
696         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
697         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
698         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
699         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
700         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
701         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
702         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
703         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
704         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
705         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
706         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
707         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
708         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
709         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
710         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
711         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
712         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
713         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
714         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
715         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
716         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
717         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
718         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
719         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
720         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
721         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
722         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
723         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
724         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
725         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
726         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
727         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
728         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
729         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
730         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
731         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
732         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
733         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
734         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
735         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
736         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
737         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
738         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
739         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
740         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
741         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
742         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
743         * Scripts/pdevenv: Removed.
744         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
745         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
746         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
747         * WebKitLauncherWin: Removed.
748         * WebKitLauncherWin/Resource.h: Removed.
749         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
750         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
751         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
752         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
753         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
754         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
755         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
756         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
757         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
758         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
759         * WebKitLauncherWin/webkit.ico: Removed.
760         * WinLauncher/WinLauncher.ico: Removed.
761         * WinLauncher/WinLauncher.rc: Removed.
762         * WinLauncher/WinLauncher.vcproj: Removed.
763         * WinLauncher/WinLauncherCommon.vsprops: Removed.
764         * WinLauncher/WinLauncherDebug.vsprops: Removed.
765         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
766         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
767         * WinLauncher/WinLauncherLauncher.rc: Removed.
768         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
769         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
770         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
771         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
772         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
773         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
774         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
775         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
776         * WinLauncher/WinLauncherLauncherResource.h: Removed.
777         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
778         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
779         * WinLauncher/WinLauncherProduction.vsprops: Removed.
780         * WinLauncher/WinLauncherRelease.vsprops: Removed.
781         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
782         * WinLauncher/small.ico: Removed.
783         * record-memory-win: Removed.
784         * record-memory-win/main.cpp: Removed.
785         * record-memory-win/record-memory-win-common.vsprops: Removed.
786         * record-memory-win/record-memory-win.vcproj: Removed.
787         * record-memory-win/record-memory-winDebug.vsprops: Removed.
788         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
789         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
790         * record-memory-win/record-memory-winProduction.vsprops: Removed.
791         * record-memory-win/record-memory-winRelease.vsprops: Removed.
792         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
793
794 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
795
796         AX: MathML multiscripts not exposed in Accessibility
797         https://bugs.webkit.org/show_bug.cgi?id=115069
798
799         Reviewed by Tim Horton.
800
801         Add methods to help output components of math multiscripts for accessibility.
802
803         * DumpRenderTree/AccessibilityUIElement.cpp:
804         (mathPostscriptsDescriptionCallback):
805         (mathPrescriptsDescriptionCallback):
806         (AccessibilityUIElement::getJSClass):
807         * DumpRenderTree/AccessibilityUIElement.h:
808         (AccessibilityUIElement):
809         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
810         (convertMathMultiscriptPairsToString):
811         (AccessibilityUIElement::mathPostscriptsDescription):
812         (AccessibilityUIElement::mathPrescriptsDescription):
813         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
814         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
815         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
816         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
817         (AccessibilityUIElement):
818         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
819         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
820         (WTR::_convertMathMultiscriptPairsToString):
821         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
822         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
823
824 2013-06-03  Commit Queue  <commit-queue@webkit.org>
825
826         Unreviewed, rolling out r151109.
827         http://trac.webkit.org/changeset/151109
828         https://bugs.webkit.org/show_bug.cgi?id=117145
829
830         "Plugins in WK2 aren't implemented yet." (Requested by
831         jturcotte on #webkit).
832
833         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
834         * qmake/mkspecs/features/features.prf:
835         * qmake/mkspecs/features/unix/default_pre.prf:
836
837 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
838
839         [Qt] Re-enable plugins on Mac.
840         https://bugs.webkit.org/show_bug.cgi?id=116622
841
842         Reviewed by Tor Arne Vestbø.
843
844         Plugins on Mac were only enabled if !embedded but the later was set if
845         QPA is enabled, which is the default since Qt 5.0.
846
847         Remove references to 'embedded' and fix various build issues,
848         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
849         months.
850
851         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
852         * qmake/mkspecs/features/features.prf:
853         * qmake/mkspecs/features/unix/default_pre.prf:
854
855 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
856
857         [GTK][WK2] accessibility/placeholder.html is failing
858         https://bugs.webkit.org/show_bug.cgi?id=106344
859
860         Reviewed by Gyuyoung Kim.
861
862         Adds support for retrieving attribute value.
863
864         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
865         (WTR::coreAttributeToAtkAttribute):
866         (WTR::AccessibilityUIElement::stringAttributeValue):
867
868 2013-06-01  Tim Horton  <timothy_horton@apple.com>
869
870         Add a preferred email address and "expertise" for me.
871
872         * Scripts/webkitpy/common/config/contributors.json:
873
874 2013-05-31  Roger Fong  <roger_fong@apple.com>
875
876         Unreviewed. Make windows test bots search in the correct directory for build output.
877
878         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
879         (RunWebKitTests.start):
880         * Scripts/webkitdirs.pm:
881         (determineConfigurationProductDir):
882
883 2013-05-31  Roger Fong  <roger_fong@apple.com>
884
885         Unreviewed. Windows build fix...
886
887         * BuildSlaveSupport/built-product-archive:
888         (createZip):
889
890 2013-05-31  Roger Fong  <roger_fong@apple.com>
891
892         Unreviewed. Windows build fix. One more time!
893
894         * BuildSlaveSupport/built-product-archive:
895         (archiveBuiltProduct):
896         (extractBuiltProduct):
897
898 2013-05-31  Roger Fong  <roger_fong@apple.com>
899
900         Unreviewed. Windows build fix.
901
902         * Scripts/build-webkit:
903
904 2013-05-31  Roger Fong  <roger_fong@apple.com>
905
906         Unreviewed. Windows build fix.
907
908         * Scripts/build-webkit:
909
910 2013-05-31  Roger Fong  <roger_fong@apple.com>
911
912         Make build-webkit output VCExpress 2010 build logs properly.
913         https://bugs.webkit.org/show_bug.cgi?id=117096
914
915         Reviewed by Brent Fulgham.
916
917         Make it so that output from VCExpress is always printed to console.
918         Get build log results from AssembleBuildLogs project output.
919         We don't need those old VCExpress scripts anymore either. 
920
921         * Scripts/build-webkit:
922         * Scripts/print-msvc-project-dependencies: Removed.
923         * Scripts/print-vse-failure-logs: Removed.
924
925 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
926
927         [Windows] Use WinLauncher to display LayoutTest results
928         https://bugs.webkit.org/show_bug.cgi?id=117085
929
930         Reviewed by Oliver Hunt.
931
932         * Scripts/webkitdirs.pm:
933         (runSafari): Use WinLauncher to display content
934         * WinLauncher/WinLauncher.cpp:
935         (dllLauncherEntryPoint): Check for URL argument.
936
937 2013-05-31  Roger Fong  <roger_fong@apple.com>
938
939         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
940
941         * win/AssembleBuildLogs/AssembleLogs.cmd:
942
943 2013-05-31  Commit Queue  <commit-queue@webkit.org>
944
945         Unreviewed, rolling out r151022.
946         http://trac.webkit.org/changeset/151022
947         https://bugs.webkit.org/show_bug.cgi?id=117084
948
949         Also breaks build by introducing duplicate symbols (Requested
950         by bfulgham on #webkit).
951
952         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
953
954 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
955
956         [Windows] Unreviewed build fix to NRWT
957
958         * Scripts/webkitpy/port/win.py:
959         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
960
961 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
962
963         [Windows] Unreviewed build fix after r151012
964
965         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
966         WTF library to support SHA tests
967
968 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
969
970         [Windows] Unreviewed build fix after r151012
971
972         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
973         snprintf definition for Windows.
974
975 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
976
977         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
978         https://bugs.webkit.org/show_bug.cgi?id=116445
979
980         Reviewed by Benjamin Poulain.
981
982         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
983
984         * TestWebKitAPI/CMakeLists.txt:
985         * TestWebKitAPI/GNUmakefile.am:
986         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
987         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
989         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
990         (TestWebKitAPI):
991         (TestWebKitAPI::expectMD5):
992         (TestWebKitAPI::TEST):
993         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
994         (TestWebKitAPI):
995         (TestWebKitAPI::expectSHA1):
996         (TestWebKitAPI::TEST):
997         * TestWebKitAPI/Tests/WTF/WTF.pro:
998         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
999
1000 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1001
1002         [Windows] Unreviewed build correction.
1003
1004         * Scripts/webkitpy/port/win.py:
1005         (WinPort.create_debugger_command_file): The directory needs to be
1006         a string, not a temporary directory object.
1007
1008 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1009
1010         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
1011         https://bugs.webkit.org/show_bug.cgi?id=76935
1012
1013         Reviewed by Ryosuke Niwa.
1014
1015         Extend the WinPort class with commands to set and clean up various registry
1016         values needed to invoke the correct debugger to get crash files.
1017
1018         * Scripts/webkitpy/port/win.py:
1019         (WinPort): Added global caches for registry keys and settings
1020         (WinPort._ntsd_location): Added
1021         (WinPort.create_debugger_command_file): Added
1022         (WinPort.read_registry_string): Added
1023         (WinPort.write_registry_string): Added
1024         (WinPort.setup_crash_log_saving): Added
1025         (WinPort.restore_crash_log_saving): Added
1026         (WinPort.setup_test_run): Added overload to add registry settings.
1027         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
1028
1029 2013-05-30  Roger Fong  <roger_fong@apple.com>
1030
1031         Get rid of JavaScript exports file on AppleWin port.
1032         https://bugs.webkit.org/show_bug.cgi?id=117050.
1033
1034         Reviewed by Darin Adler.
1035
1036         Start linking in WTF.lib now that it's a shared library.
1037
1038         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1039         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1040         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1041
1042 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1043
1044         Web Inspector: tests in PerformanceTests/inspector/ are timing out
1045         https://bugs.webkit.org/show_bug.cgi?id=77024
1046
1047         Reviewed by Andreas Kling.
1048
1049         Remove inspector performance tests since they have been disabled for ages,
1050         and they don't use the standard parser-style performance output.
1051
1052         It's adding a lot of code complexity to our infrastructure.
1053
1054         * Scripts/webkitpy/performance_tests/perftest.py:
1055         (SingleProcessPerfTest.__init__):
1056         (PerfTestFactory):
1057         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1058         (TestPerfTestFactory.test_regular_test):
1059         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1060         (TestDriver.run_test):
1061         (MainTest.run_test):
1062         (MainTest._tests_for_runner):
1063         (MainTest.test_run_test_set_kills_drt_per_run):
1064         (MainTest._test_run_with_json_output):
1065         (MainTest):
1066         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1067
1068 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1069
1070         Remove requires_http_server as Chromium Android was the only port that needed this
1071         https://bugs.webkit.org/show_bug.cgi?id=117018
1072
1073         Reviewed by Benjamin Poulain.
1074
1075         Removed the unused code that existed for Chromium Android port.
1076
1077         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1078         (LayoutTestRunner.run_tests):
1079         (LayoutTestRunner._handle_finished_test_list):
1080         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1081         (Manager._run_tests):
1082         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1083         (PerfTestsRunner._collect_tests):
1084         (PerfTestsRunner.run):
1085         * Scripts/webkitpy/port/base.py:
1086         (Port.to.start_helper):
1087         * Scripts/webkitpy/port/base_unittest.py:
1088         (PortTest.test_build_path):
1089
1090 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1091
1092         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1093         https://bugs.webkit.org/show_bug.cgi?id=113221
1094
1095         Reviewed by Ryosuke Niwa.
1096
1097         Teach prepare-Changelog to not list the names of modified namespaces, 
1098         classes, or structs in C++ files. Thus, if a change is made 
1099         within a namespace/class/struct yet outside a function, it will 
1100         not be reflected in the ChangeLog entry. 
1101         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
1102         for more details on how ChangeLog entries are affected.
1103
1104         * Scripts/prepare-ChangeLog:
1105         (get_function_line_ranges_for_cpp): 
1106         (delete_namespaces_from_ranges_for_cpp): Added.
1107         (is_function_in_namespace): Added.
1108         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1109         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1110
1111 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1112
1113         Cleanup AudioSourceNode.idl from WebKit build.
1114         https://bugs.webkit.org/show_bug.cgi?id=116905.
1115
1116         Reviewed by Darin Adler.
1117
1118         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1119         AudioNode is inherited directly in all the audio source nodes.
1120
1121         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1122
1123 2013-05-29  Andrew Lo  <anlo@rim.com>
1124
1125         Add Andrew Lo to contributors.json
1126         https://bugs.webkit.org/show_bug.cgi?id=116981
1127
1128         Reviewed by Rob Buis.
1129
1130         Adding Andrew Lo to contributors.json.
1131
1132         * Scripts/webkitpy/common/config/contributors.json:
1133
1134 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1135
1136         Unreviewed. Adding myself as a committer.
1137
1138         * Scripts/webkitpy/common/config/contributors.json:
1139
1140 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1141
1142         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1143         https://bugs.webkit.org/show_bug.cgi?id=116683
1144
1145         Reviewed by Noam Rosenthal.
1146
1147         A coordinates conversion test for WKViewUserViewportToContents was
1148         added to WebKit2 API tests.
1149
1150         * TestWebKitAPI/PlatformEfl.cmake:
1151         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1152         (TestWebKitAPI):
1153         (TestWebKitAPI::TEST):
1154
1155 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
1156
1157         Unreviewed. Update my info.
1158
1159         * Scripts/webkitpy/common/config/contributors.json:
1160
1161 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
1162
1163         Unreviewed. Add myself as committer in contributors.json.
1164
1165         * Scripts/webkitpy/common/config/contributors.json:
1166
1167 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1168
1169         Unreviewed. Fix make distcheck.
1170
1171         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
1172         DISTCLEANFILES.
1173
1174 2013-05-29  Mary Wu  <mawu@blackberry.com>
1175
1176         Unreviewed: update my email address in contributors.json.
1177
1178         * Scripts/webkitpy/common/config/contributors.json:
1179
1180 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
1181
1182         Unreviewed: Adding myself to committers list.
1183
1184         * Scripts/webkitpy/common/config/contributors.json:
1185
1186 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
1187
1188         Unreviewed: Adding myself to committers list.
1189
1190         * Scripts/webkitpy/common/config/contributors.json:
1191
1192 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
1193
1194         [Windows] Many CSS2.1 tests fail under NRWT.
1195         https://bugs.webkit.org/show_bug.cgi?id=75707
1196
1197         Reviewed by Darin Adler.
1198
1199         * DumpRenderTree/win/DumpRenderTree.cpp:
1200         (findFontFallback): Added
1201         (addFontFallbackIfPresent): Added
1202         (removeFontFallbackIfPresent): Added
1203         (runTest): Set up/remove font fallbacks when needed.
1204
1205 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
1206
1207         [Windows] NRWT reports failure for 'mac' test cases.
1208         https://bugs.webkit.org/show_bug.cgi?id=116698
1209
1210         Reviewed by Ryosuke Niwa.
1211
1212         The Windows port falls back to the Mac port for many test results,
1213         and so adds the mac and mac-wk2 to its set of fallbacks.
1214         Unfortunately, NRWT thinks that this means that tests in these
1215         folders should be executed, resulting in many failures on
1216         Windows.
1217
1218         This change overloads the '_tests_for_other_platforms' method
1219         to return a subset of the result fallback list so that we do
1220         not attempt to execute Mac tests on Windows.
1221
1222         * Scripts/webkitpy/port/base.py:
1223         (Port.test_search_path): Added. Defaults to just calling the
1224         baseline_search_path method, which is how most ports behave.
1225         (Port._test_for_other_platforms): Modified to call the new
1226         test_search_path method.
1227
1228         * Scripts/webkitpy/port/win.py:
1229         (WinPort.test_search_path): Added custom overload. Strips
1230         out mac-specific test paths.
1231
1232 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
1233
1234         Fix GTK+ CMake build
1235
1236         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
1237         library target is simply "WebKit2."
1238
1239 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
1240
1241         [webkitpy] Explicitly specify the reference file extensions
1242         https://bugs.webkit.org/show_bug.cgi?id=116333
1243
1244         Reviewed by Benjamin Poulain.
1245
1246         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
1247         between valid reference files required by reftests and text baselines that have the same extension as
1248         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
1249         that were until this change recognized as reference files).
1250
1251         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
1252
1253         * Scripts/webkitpy/port/base.py:
1254         (Port.reference_files): Iterate through the _supported_reference_extensions set.
1255         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
1256         _supported_reference_extensions set, containing the extensions allowed for reference files.
1257         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
1258         (Port._has_supported_extension): Use _supported_test_extensions.
1259         * Scripts/webkitpy/port/base_unittest.py:
1260         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
1261         Port.is_reference_html_file method.
1262
1263 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
1266
1267         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1268         (NewCommitBot.next_work_item):
1269
1270 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1271
1272         WKR and webkitbot build fixes.
1273
1274         * Scripts/webkitpy/tool/bot/irc_command.py:
1275         (RollChromiumDEPS.execute):
1276         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1277         (NewCommitBot.next_work_item):
1278
1279 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1280
1281         roll-chromium-deps doesn't repeat the full name.
1282
1283         Rubber-stamped by Andreas Kling.
1284
1285         * Scripts/webkitpy/tool/bot/irc_command.py:
1286         (RollChromiumDEPS.execute):
1287
1288 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1289
1290         Revert another erroneous change.
1291
1292         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1293         (NewCommitBot.next_work_item):
1294
1295 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1296
1297         Revert an erroneous change.
1298
1299         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1300         (SheriffBot):
1301
1302 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1303
1304         Some build fixes for WKR and webkitbot.
1305
1306         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1307         (IRCBotTest.test_help):
1308         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1309         (Agent):
1310         (Agent.__init__):
1311         (Agent.name):
1312         (NewCommitBot):
1313         (NewCommitBot.begin_work_queue):
1314         (NewCommitBot.next_work_item):
1315         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1316         (SheriffBot):
1317
1318 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1319
1320         Teach webkitbot and WKR how to respond to yt?
1321         https://bugs.webkit.org/show_bug.cgi?id=116775
1322
1323         Reviewed by Andreas Kling.
1324
1325         * Scripts/webkitpy/tool/bot/irc_command.py:
1326         (Hi): Fixed the usage string.
1327         (Hi.execute): Made it more generic so that it works in WKR.
1328         (YouThere): Added.
1329         (YouThere.execute): Added.
1330         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1331
1332 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1333
1334         Try to fix the EFL build.
1335         
1336         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1337         (TestRunner::setPageVisibility):
1338
1339 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1340
1341         Unprefix Page Visibility API
1342         https://bugs.webkit.org/show_bug.cgi?id=102340
1343
1344         Reviewed by Tim Horton.
1345         
1346         Rename "preview" state to "unloaded" state, and adjust the tests
1347         to test for it.
1348
1349         * DumpRenderTree/mac/TestRunnerMac.mm:
1350         (TestRunner::setPageVisibility):
1351         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
1352         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1353         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1354         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
1355         (TestWebKitAPI::didRunStep4InStateUnloaded):
1356         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
1357         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1358         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1360         (WTR::TestRunner::setPageVisibility):
1361
1362 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1363
1364         Unreviewed build fix. Don't use new NRWT logic needed
1365         by Windows yet. Activate (and fix test) when we cut over.
1366
1367         * Scripts/webkitpy/port/driver.py:
1368         (Driver._setup_environ_for_driver):
1369         (Driver._start):
1370
1371 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1372
1373         [Windows] Expose database storage and cache locations via preferences.
1374         https://bugs.webkit.org/show_bug.cgi?id=116729
1375
1376         Reviewed by Tim Horton.
1377
1378         Update DumpRenderTree to use CFPreferences to control where WebKit
1379         stores its local databases, URL caches, etc.
1380
1381         * DumpRenderTree/win/DumpRenderTree.cpp:
1382         (libraryPathForDumpRenderTree): Added.
1383         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
1384         * Scripts/webkitpy/port/base.py:
1385         (Port._driver_tempdir): Added (to allow port-specific overload).
1386         (Port._driver_tempdir_for_environment): Ditto
1387         * Scripts/webkitpy/port/driver.py:
1388         (Driver._setup_environ_for_driver): Use new overload to set
1389         environment variable.
1390         (Driver._start): Use new overload for temp directory location.
1391         * Scripts/webkitpy/port/win.py:
1392         (WinPort._driver_tempdir_for_environment): New overload to supply
1393         Windows path to DumpRenderTree environment (while still using
1394         cygwin paths for internal operations.
1395
1396 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1397
1398         Remove custom code for webkitAudioContext global constructor getter
1399         https://bugs.webkit.org/show_bug.cgi?id=116530
1400
1401         Reviewed by Geoffrey Garen.
1402
1403         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
1404         WebAudio feature instead of public ewk_view API since that API was
1405         removed.
1406
1407         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1408         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1409         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1410         (TestRunner::overridePreference):
1411
1412 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
1413
1414         Make team.html have each contributor's area of expertise
1415         https://bugs.webkit.org/show_bug.cgi?id=116737
1416
1417         Reviewed by Benjamin Poulain.
1418
1419         * Scripts/webkitpy/common/config/contributors.json:
1420         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
1421         
1422         Changed formatting of the file because the lines are getting way to
1423         long, and I generated this, so it's easier if the formatting of the
1424         file is regular.
1425
1426 2013-05-24  Simon Pena  <simon.pena@samsung.com>
1427
1428         Update WTF::Vector pretty printers
1429         https://bugs.webkit.org/show_bug.cgi?id=116719
1430
1431         Reviewed by Anders Carlsson.
1432
1433         After r148891, WTF::Vector pretty printers were left outdated, as
1434         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
1435         one as a member. This patch updates the pretty printers so they work
1436         again. 
1437
1438         * gdb/webkit.py:
1439         (WTFVectorPrinter.children):
1440         (WTFVectorPrinter.to_string):
1441
1442 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
1443
1444         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
1445         https://bugs.webkit.org/show_bug.cgi?id=116710
1446
1447         Reviewed by Mark Rowe.
1448
1449         * DumpRenderTree/mac/DumpRenderTree.mm:
1450         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
1451
1452 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
1453
1454         Add missing dependencies to deps script.
1455
1456         [GTK] Missing packages in install-dependencies script.
1457         https://bugs.webkit.org/show_bug.cgi?id=116632
1458
1459         Reviewed by Martin Robinson.
1460
1461         * gtk/install-dependencies:
1462
1463 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1464
1465         [Windows] Unreviewed change for NRWT support.
1466
1467         * Scripts/webkitpy/port/win.py:
1468         (WinPort.default_child_processes): Added a default implementation
1469         that limits NRWT to a single instance.
1470
1471 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1472
1473         Remove meaningless "test_uses_apache" from Python test cases.
1474         https://bugs.webkit.org/show_bug.cgi?id=38756
1475
1476         Reviewed by Ryosuke Niwa.
1477
1478         * Scripts/webkitpy/port/port_testcase.py:
1479         (PortTestCase.test_driver_cmd_line): Remove the meaningless
1480         "test_uses_apache" test case from the Python test infrastructure.
1481         It was hard-coded to true, even though not all ports use
1482         Apache.
1483
1484 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1485
1486         [Windows] Update new-run-webkit-tests for Windows port.
1487         https://bugs.webkit.org/show_bug.cgi?id=38756
1488
1489         Reviewed by Ryosuke Niwa.
1490
1491         * Scripts/new-run-webkit-httpd:
1492         (run): Switch from 'chromium' to 'win'
1493         * Scripts/webkitpy/port/win.py:
1494         (WinPort): Add support methods for lighttpd server.
1495         (WinPort._uses_apache):
1496         (WinPort._path_to_lighttpd):
1497         (WinPort._path_to_lighttpd_modules):
1498         (WinPort._path_to_lighttpd_php):
1499
1500 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1501
1502         Make default bug links in buildbot clickable
1503         https://bugs.webkit.org/show_bug.cgi?id=116673
1504
1505         Reviewed by Ryosuke Niwa.
1506
1507         Use changecommentlink of html.WebStatus to make the links clickable.
1508
1509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1510
1511 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1512
1513         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1514         https://bugs.webkit.org/show_bug.cgi?id=116595
1515
1516         Temporarily skip this test.
1517
1518         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1519         (TestWebKitAPI::TEST):
1520
1521 2013-05-22  Alex Christensen  <achristensen@apple.com>
1522
1523         Unreviewed.  Added myself to contributors.json.
1524
1525         * Scripts/webkitpy/common/config/contributors.json:
1526         Added myself.
1527
1528 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1529
1530         [EFL][WK2] Add sub menus to MiniBrowser
1531         https://bugs.webkit.org/show_bug.cgi?id=114728
1532
1533         Reviewed by Christophe Dumez.
1534
1535         Elementary Ctxpopup widget API does not provide support for submenu item.
1536         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1537         Elementary Menu widget.
1538
1539         * MiniBrowser/efl/main.c:
1540         (_Browser_Window):
1541         (on_window_resize):
1542         (window_free):
1543         (context_menu_item_selected_cb):
1544         (context_menu_populate):
1545         (on_context_menu_show):
1546         (on_context_menu_hide):
1547         (window_create):
1548
1549 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1550
1551         [EFL] Add command line option to MiniBrowser to set cookies policy.
1552         https://bugs.webkit.org/show_bug.cgi?id=115028
1553
1554         Reviewed by Christophe Dumez.
1555
1556         Add command line option to MiniBrowser EFL to set cookies policy:
1557         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1558         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1559
1560         * MiniBrowser/efl/main.c:
1561         (elm_main):
1562
1563 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1564
1565         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1566         https://bugs.webkit.org/show_bug.cgi?id=116585
1567
1568         Reviewed by Alexey Proskuryakov.
1569
1570         willLoadURLRequest and willLoadDataRequest require the API version 6.
1571
1572         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1573
1574 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1575
1576         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1577         https://bugs.webkit.org/show_bug.cgi?id=116516
1578
1579         Reviewed by Alexey Proskuryakov.
1580
1581         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1582
1583         * DumpRenderTree/mac/DumpRenderTree.mm:
1584         (createWebViewAndOffscreenWindow): Match the ordering.
1585         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1586
1587 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1588
1589         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1590         https://bugs.webkit.org/show_bug.cgi?id=116568
1591
1592         Reviewed by Anders Carlsson.
1593
1594         * WebKitTestRunner/WebNotificationProvider.cpp:
1595         (WTR::WebNotificationProvider::~WebNotificationProvider):
1596         * WebKitTestRunner/WebNotificationProvider.h:
1597         When the provider is destroyed, it should no longer be registered with the manager.
1598
1599         * WebKitTestRunner/GeolocationProviderMock.cpp:
1600         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1601         * WebKitTestRunner/GeolocationProviderMock.h:
1602         I wasn't seeing a crash here, but this code has the same issue as notification
1603         provider, so applying the same fix.
1604
1605         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1606         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1607         destructor having fixed the above.
1608
1609 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1610
1611         Unreviewed, rolling out r150386 and r150397.
1612         http://trac.webkit.org/changeset/150386
1613         http://trac.webkit.org/changeset/150397
1614         https://bugs.webkit.org/show_bug.cgi?id=116572
1615
1616         Broke a test; Alex is going to try again later. (Requested by
1617         thorton on #webkit).
1618
1619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1620         (WTR::pathSuitableForTestResult):
1621         (WTR::dumpRequestDescriptionSuitableForTestResult):
1622         (WTR::dumpResponseDescriptionSuitableForTestResult):
1623         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1624         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1625         (WTR::InjectedBundlePage::willSendRequestForFrame):
1626         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1627         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1628         (InjectedBundlePage):
1629
1630 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1631
1632         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1633
1634         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1635         (AbstractCommitLogCommand._recent_commit_messages):
1636
1637 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1638
1639         [GTK] [CMake] Add support for building WebKit2
1640         https://bugs.webkit.org/show_bug.cgi?id=116372
1641
1642         Reviewed by Gustavo Noronha Silva.
1643
1644         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1645         * MiniBrowser/gtk/CMakeLists.txt: Added.
1646
1647 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1648
1649         Revert r149635, it was too optimistic.
1650
1651         Rubber-stamped by Andreas Kling.
1652
1653         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1654         #ifdefs in WebCore code outside of WebCore/platform.
1655
1656         * Scripts/webkitpy/style/checkers/cpp.py:
1657         (check_invalid_increment):
1658         (process_line):
1659         (CppChecker):
1660         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1661         (CppStyleTest.test_plain_integral_bitfields):
1662
1663 2013-05-21  Jer Noble  <jer.noble@apple.com>
1664
1665         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1666
1667         * lldb/lldb_webkit.py:
1668         (WTFVectorProvider.num_children):
1669         (WTFVectorProvider.get_child_index):
1670         (WTFVectorProvider.get_child_at_index):
1671         (WTFVectorProvider.update):
1672
1673 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1674
1675         Expose a way to know when forms are added to a page or when form controls are added to a form
1676         in the injected bundle
1677         https://bugs.webkit.org/show_bug.cgi?id=116334
1678
1679         Reviewed by Alexey Proskuryakov.
1680
1681         Add tests for the new callbacks.
1682
1683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1684         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1685
1686         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1687         (TestWebKitAPI::nullJavaScriptCallback):
1688         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1689         being passed in for the callback.
1690         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1691         After receiving the message that didAssociateFormControls callback was invoked from adding
1692         the form in the onload handler, tell the page to add a password field to the form, which
1693         should also invoke didAssociateFormControls callback.
1694         (TestWebKitAPI::setInjectedBundleClient):
1695         Register to receive messages.
1696         (TestWebKitAPI::TEST):
1697         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1698         been invoked for both adding the form and for adding a password field to the form.
1699
1700         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1701         (TestWebKitAPI::shouldNotifyOnFormChanges):
1702         Return true so the didAssociateFormControls callback is invoked.
1703         (TestWebKitAPI::didAssociateFormControls):
1704         Tell the UI process.
1705         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1706         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1707         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1708
1709         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1710         Add a form in response to the onload event. Add a button that will add the password field
1711         for manual testing.
1712
1713 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1714
1715         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1716         https://bugs.webkit.org/show_bug.cgi?id=106341
1717
1718         Reviewed by Martin Robinson.
1719
1720         Adds support for retrieving accessibility element at exact point.
1721
1722         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1723         (WTR::AccessibilityUIElement::elementAtPoint):
1724
1725 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1726
1727         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1728         https://bugs.webkit.org/show_bug.cgi?id=112913
1729
1730         Reviewed by Martin Robinson.
1731
1732         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1733         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1734         so the leak appears.
1735
1736         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1737         (WTR):
1738         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1739         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1740         (WTR::AccessibilityController::rootElement):
1741         (WTR):
1742         (WTR::AccessibilityController::focusedElement):
1743         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1744         (WTR::checkElementState):
1745         (WTR::indexRangeInTable):
1746         (WTR::alterCurrentValue):
1747         (WTR::AccessibilityUIElement::getChildren):
1748         (WTR::AccessibilityUIElement::getChildrenWithRange):
1749         (WTR::AccessibilityUIElement::childrenCount):
1750         (WTR::AccessibilityUIElement::indexOfChild):
1751         (WTR::AccessibilityUIElement::titleUIElement):
1752         (WTR::AccessibilityUIElement::parentElement):
1753         (WTR::AccessibilityUIElement::allAttributes):
1754         (WTR::AccessibilityUIElement::role):
1755         (WTR::AccessibilityUIElement::title):
1756         (WTR::AccessibilityUIElement::description):
1757         (WTR::AccessibilityUIElement::orientation):
1758         (WTR::AccessibilityUIElement::stringValue):
1759         (WTR::AccessibilityUIElement::language):
1760         (WTR::AccessibilityUIElement::x):
1761         (WTR::AccessibilityUIElement::y):
1762         (WTR::AccessibilityUIElement::width):
1763         (WTR::AccessibilityUIElement::height):
1764         (WTR::AccessibilityUIElement::intValue):
1765         (WTR::AccessibilityUIElement::minValue):
1766         (WTR::AccessibilityUIElement::maxValue):
1767         (WTR::AccessibilityUIElement::isEnabled):
1768         (WTR::AccessibilityUIElement::isFocused):
1769         (WTR::AccessibilityUIElement::isSelected):
1770         (WTR::AccessibilityUIElement::isExpanded):
1771         (WTR::AccessibilityUIElement::isChecked):
1772         (WTR::AccessibilityUIElement::rowCount):
1773         (WTR::AccessibilityUIElement::columnCount):
1774         (WTR::AccessibilityUIElement::rowIndexRange):
1775         (WTR::AccessibilityUIElement::columnIndexRange):
1776         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1777         (WTR::AccessibilityUIElement::increment):
1778         (WTR::AccessibilityUIElement::decrement):
1779         (WTR::AccessibilityUIElement::press):
1780         (WTR::AccessibilityUIElement::documentEncoding):
1781         (WTR::AccessibilityUIElement::documentURI):
1782         (WTR::AccessibilityUIElement::isFocusable):
1783         (WTR::AccessibilityUIElement::isSelectable):
1784         (WTR::AccessibilityUIElement::isMultiSelectable):
1785         (WTR::AccessibilityUIElement::isVisible):
1786
1787 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1788
1789     Rollout 150398.
1790     
1791 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1792
1793         [GTK] Fix concatenations of string literals that are not C++11-compliant
1794         https://bugs.webkit.org/show_bug.cgi?id=116449
1795
1796         Reviewed by Martin Robinson.
1797
1798         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1799         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1800
1801         * ImageDiff/gtk/ImageDiff.cpp:
1802         (printImage):
1803
1804 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1805
1806         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1807         https://bugs.webkit.org/show_bug.cgi?id=116450
1808
1809         Reviewed by Martin Robinson.
1810
1811         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1812         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1813         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1814         TestWebKitAPI programs when compiling them.
1815
1816         * TestWebKitAPI/GNUmakefile.am:
1817
1818 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1819
1820         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1821         https://bugs.webkit.org/show_bug.cgi?id=116492
1822
1823         Reviewed by Dirk Pranke.
1824
1825         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1826
1827         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1828         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1829         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1830         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1831         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1832         to memory pressure on the machine.
1833
1834         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
1835         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
1836         for a subsequent patch just to make things easier to follow.
1837
1838         * Scripts/webkitpy/port/driver.py:
1839         (DriverProxy.__init__):
1840         (DriverProxy.run_test):
1841         (DriverProxy.has_crashed):
1842         (DriverProxy.stop):
1843
1844 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1845
1846         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
1847         https://bugs.webkit.org/show_bug.cgi?id=116423
1848
1849         Reviewed by Ryosuke Niwa.
1850
1851         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/config.json:
1854
1855 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
1856
1857         Remove remaining link-prerender code
1858         https://bugs.webkit.org/show_bug.cgi?id=116429
1859
1860         Reviewed by Darin Adler.
1861
1862         Link prerendering code was removed in r150356.
1863
1864         * Scripts/webkitperl/FeatureList.pm:
1865         * qmake/mkspecs/features/features.pri:
1866
1867 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1868
1869         commit-queue should check for oops in changelog entries
1870         https://bugs.webkit.org/show_bug.cgi?id=116395
1871
1872         Reviewed by Martin Robinson.
1873
1874         Make changelog validation fail when it contains oops!.
1875
1876         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1877         (CommitQueueTask._validate_changelog):
1878         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1879         (CommitQueueTaskTest._run_through_task):
1880         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1881         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1882         (ValidateChangeLogs.options):
1883         (ValidateChangeLogs._check_changelog_diff):
1884         (ValidateChangeLogs._changelog_contains_oops):
1885         (ValidateChangeLogs.run):
1886         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1887         (ValidateChangeLogsTest._assert_start_line_produces_output):
1888         (ValidateChangeLogsTest.test_check_changelog_diff):
1889         (ValidateChangeLogsTest):
1890         (ValidateChangeLogsTest.test_changelog_contains_oops):
1891
1892 2013-05-20  Jessie Berlin  <jberlin@apple.com>
1893
1894         Expose a way to know when forms are added to a page or when form controls are added to a form
1895         in the injected bundle
1896         https://bugs.webkit.org/show_bug.cgi?id=116334
1897
1898         Reviewed by Alexey Proskuryakov.
1899
1900         Add tests for the new callbacks.
1901
1902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1903         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1904
1905         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1906         (TestWebKitAPI::nullJavaScriptCallback):
1907         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1908         being passed in for the callback.
1909         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1910         After receiving the message that didAssociateFormControls callback was invoked from adding
1911         the form in the onload handler, tell the page to add a password field to the form, which
1912         should also invoke didAssociateFormControls callback.
1913         (TestWebKitAPI::setInjectedBundleClient):
1914         Register to receive messages.
1915         (TestWebKitAPI::TEST):
1916         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1917         been invoked for both adding the form and for adding a password field to the form.
1918
1919         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1920         (TestWebKitAPI::shouldNotifyOnFormChanges):
1921         Return true so the didAssociateFormControls callback is invoked.
1922         (TestWebKitAPI::didAssociateFormControls):
1923         Tell the UI process.
1924         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1925         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1926         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1927
1928         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1929         Add a form in response to the onload event. Add a button that will add the password field
1930         for manual testing.
1931
1932 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1933
1934         [EFL][JHBUILD] Make sure eet is built before evas
1935         https://bugs.webkit.org/show_bug.cgi?id=116440
1936
1937         Reviewed by Gyuyoung Kim.
1938
1939         Mark eet as a dependency of evas since evas requires eet to enable some of its
1940         functionality.
1941
1942         * efl/jhbuild.modules:
1943
1944 2013-05-20  Alex Christensen  <achristensen@apple.com>
1945
1946         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1947         https://bugs.webkit.org/show_bug.cgi?id=116125
1948
1949         Reviewed by Tim Horton.
1950
1951         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1952         (WTR::pathSuitableForTestResult):
1953         Changed string operations to match _drt_descriptionSuitableForTestResult.
1954         (WTR::dumpRequestDescriptionSuitableForTestResult):
1955         (WTR::dumpResponseDescriptionSuitableForTestResult):
1956         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1957         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1958         (WTR::InjectedBundlePage::willSendRequestForFrame):
1959         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1960         Pass the main frame's URL to pathSuitableForTestResult.
1961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1962         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1963
1964 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
1965
1966         fix w3c test importer unit tests after r150324
1967         https://bugs.webkit.org/show_bug.cgi?id=116459
1968
1969         Reviewed by Ryosuke Niwa.
1970
1971         This patch fixes the unit tests to not actually call out to
1972         'hg' (by using a mock executive) and also changes the real
1973         directory we crawl from Source/WebCore/css to
1974         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
1975         still change this to a mock filesystem, but that's a separate change.
1976
1977         * Scripts/webkitpy/w3c/test_importer.py:
1978         (main):
1979         (TestImporter.__init__):
1980         (TestImporter.load_changeset):
1981         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1982         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1983         (TestImporterTest.test_import_dir_with_no_tests):
1984
1985 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1986
1987         Unreviewed EFL build fix.
1988
1989         Fix linking errors due to undefined symbols on Ubuntu 13.04.
1990
1991         * DumpRenderTree/efl/CMakeLists.txt:
1992         * EWebLauncher/CMakeLists.txt:
1993         * MiniBrowser/efl/CMakeLists.txt:
1994
1995 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1996
1997         [EFL] Reenabled INDEXED_DATABASE after r150344
1998         https://bugs.webkit.org/show_bug.cgi?id=116430
1999
2000         Reviewed by Gyuyoung Kim.
2001
2002         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
2003         build was fixed in r150344.
2004
2005         * Scripts/webkitperl/FeatureList.pm:
2006
2007 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
2008
2009         [EFL] init/shutdown should be paired in EWebLauncher
2010         https://bugs.webkit.org/show_bug.cgi?id=116427
2011
2012         Reviewed by Christophe Dumez.
2013
2014         Added ecore_file_shutdown() for cleanup of ecore_file.
2015         Removed edje_init and ecore_evas_init because it was in ewk_init().
2016
2017         * EWebLauncher/main.c:
2018         (main):
2019
2020 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
2021
2022         [EFL] Add command line option to MiniBrowser to set user agent
2023         https://bugs.webkit.org/show_bug.cgi?id=116387
2024
2025         Reviewed by Christophe Dumez.
2026
2027         We need this option to compare the rendering differences according to different user agents.
2028
2029         * MiniBrowser/efl/main.c:
2030         (window_create):
2031         (elm_main):
2032
2033 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
2034
2035         Unreviewed, addressing test-webkitpy failures after r150317.
2036
2037         * Scripts/webkitpy/w3c/test_converter.py:
2038         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
2039
2040 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
2041
2042         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
2043         https://bugs.webkit.org/show_bug.cgi?id=114554
2044
2045         Reviewed by Gyuyoung Kim.
2046
2047         Using variables as target names is very uncommon in CMake.
2048         The usual way to specify the name of the resulting binary
2049         is to set the OUTPUT_NAME target property.
2050
2051         * DumpRenderTree/efl/CMakeLists.txt:
2052         * EWebLauncher/CMakeLists.txt:
2053         * ImageDiff/CMakeLists.txt:
2054         * MiniBrowser/efl/CMakeLists.txt:
2055         * TestWebKitAPI/CMakeLists.txt:
2056         * WebKitTestRunner/CMakeLists.txt:
2057         * WebKitTestRunner/PlatformEfl.cmake:
2058         * WinCELauncher/CMakeLists.txt:
2059
2060 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2061
2062         Unreviewed EFL build fix.
2063
2064         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
2065         WK2 build after r150305.
2066
2067         * Scripts/webkitperl/FeatureList.pm:
2068
2069 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
2070
2071         [GTK] Parallel build fails if gtk-doc is enabled
2072         https://bugs.webkit.org/show_bug.cgi?id=116227
2073
2074         Reviewed by Martin Robinson.
2075
2076         * GNUmakefile.am:
2077         Don't use the 'all' target to generate the documentation.
2078         The prerequisites of this target must be files that need to be
2079         built _before_ the actual compilation of WebKit starts. Since the
2080         documentation depends on WebKit being built first, this means in
2081         practice that the code will be built in parallel with the
2082         generation of its dependencies, potentially making the build fail.
2083
2084 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2085
2086         Don't run hg.
2087
2088         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2089         (TestImporterTest):
2090
2091 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2092
2093         Create a script to import W3C tests
2094         https://bugs.webkit.org/show_bug.cgi?id=111513
2095
2096         Reviewed by Ryosuke Niwa.
2097
2098         This patch attempts to re-land the 'import-w3c-tests'
2099         script and accompanying modules.  The tests and code have
2100         been cleaned up so that we do not log anything to stdout/stderr
2101         while running the tests (thanks to outputcapture) and do not
2102         write into the source tree while running the tests, and much
2103         but not all of the code has been converted over to using the webkitpy
2104
2105         * Scripts/import-w3c-tests: Added.
2106         * Scripts/webkitpy/w3c/__init__.py: Added.
2107         * Scripts/webkitpy/w3c/test_converter.py: Added.
2108         (W3CTestConverter):
2109         (W3CTestConverter.__init__):
2110         (W3CTestConverter.path_from_webkit_root):
2111         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2112         (W3CTestConverter.convert_for_webkit):
2113         (W3CTestConverter.convert_css):
2114         (W3CTestConverter.convert_html):
2115         (W3CTestConverter.convert_testharness_paths):
2116         (W3CTestConverter.convert_prefixed_properties):
2117         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2118         (W3CTestConverter.replace_tag):
2119         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2120         (W3CTestConverterTest):
2121         (W3CTestConverterTest.fake_dir_path):
2122         (W3CTestConverterTest.test_read_prefixed_property_list):
2123         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2124         (test_convert_for_webkit_harness_only):
2125         (test_convert_for_webkit_properties_only):
2126         (test_convert_for_webkit_harness_and_properties):
2127         (test_convert_test_harness_paths):
2128         (test_convert_prefixed_properties):
2129         (verify_conversion_happened):
2130         (verify_no_conversion_happened):
2131         (verify_test_harness_paths):
2132         (verify_prefixed_properties):
2133         (generate_test_content):
2134         * Scripts/webkitpy/w3c/test_importer.py: Added.
2135         (main):
2136         (parse_args):
2137         (validate_import_directory):
2138         (TestImporter):
2139         (TestImporter.__init__):
2140         (TestImporter.path_from_webkit_root):
2141         (TestImporter.do_import):
2142         (TestImporter.load_changeset):
2143         (TestImporter.find_importable_tests):
2144         (TestImporter.import_tests):
2145         (TestImporter.setup_destination_directory):
2146         (TestImporter.update_test_status):
2147         (TestImporter.remove_deleted_files):
2148         (TestImporter.write_import_log):
2149         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2150         (TestImporterTest):
2151         (TestImporterTest.test_import_dir_with_no_tests):
2152         * Scripts/webkitpy/w3c/test_parser.py: Added.
2153         (TestParser):
2154         (TestParser.__init__):
2155         (TestParser.load_file):
2156         (TestParser.analyze_test):
2157         (TestParser.reference_links_of_type):
2158         (TestParser.is_jstest):
2159         (TestParser.support_files):
2160         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2161         (TestParserTest):
2162         (TestParserTest.test_analyze_test_reftest_one_match):
2163         (test_analyze_test_reftest_multiple_matches):
2164         (test_analyze_test_reftest_match_and_mismatch):
2165         (test_analyze_test_reftest_with_ref_support_Files):
2166         (test_analyze_jstest):
2167         (test_analyze_pixel_test_all_true):
2168         (test_analyze_pixel_test_all_false):
2169         (test_analyze_non_html_file):
2170
2171 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2172
2173         Leaks builders exit early frequently
2174         https://bugs.webkit.org/show_bug.cgi?id=116355
2175
2176         Reviewed by Stephanie Lewis.
2177
2178         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
2179         we tolerate from 20 to 50.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2182         (RunWebKitTests.start):
2183         * Scripts/webkitpy/port/mac.py:
2184         (MacPort.default_child_processes):
2185
2186 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2187
2188         Remove chrome-channels command from the webkit-patch
2189         https://bugs.webkit.org/show_bug.cgi?id=116303
2190
2191         Reviewed by Ryosuke Niwa.
2192
2193         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
2194         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
2195         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
2196         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
2197         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
2198         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
2199
2200 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2201
2202         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
2203         Part 3 of 3: <http://webkit.org/b/116247>
2204
2205         Reviewed by Benjamin Poulain.
2206
2207         * Scripts/filter-build-webkit: Change while() loop to for() loop
2208         to track $previousLine, then pass $previousLine into
2209         shouldIgnoreLine().
2210         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
2211         line that begins with four spaces if the previous line is a
2212         linker error message.
2213         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2214         - Add "Ignored: " to test descriptions to document expected
2215           behavior.
2216         - Add comment blocks for various groups of tests.
2217         - Expand "Build settings" tests since we're changing the code in
2218           shouldIgnoreLine() that ignores those lines.
2219         - Add tests for undefined symbols error message.
2220         (description): Add.  Extract from global code.
2221
2222 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2223
2224         Add tests for shouldIgnoreLine() in filter-build-webkit
2225         Part 2 of 3: <http://webkit.org/b/116247>
2226
2227         Reviewed by Benjamin Poulain.
2228
2229         * Scripts/filter-build-webkit:
2230         (shouldIgnoreLine): Add.  Extract code from global scope into
2231         subroutine to make it testable.
2232         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
2233         Tests shouldIgnoreLine() using output from a real build
2234         transcript.
2235
2236 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2237
2238         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
2239         https://bugs.webkit.org/show_bug.cgi?id=116341
2240
2241         Reviewed by Brady Eidson.
2242
2243         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2244
2245 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
2246
2247         [Windows] Don't use pdevenv when building with VS2010.
2248         https://bugs.webkit.org/show_bug.cgi?id=116338.
2249
2250         Reviewed by Adam Roben.
2251
2252         * Scripts/webkitdirs.pm:
2253         (setupCygwinEnv): Check if we are using VS2005, and only use
2254         the 'pdevenv' hack if we are. Otherwise, just build with
2255         our standard project since it uses VS2010+'s native
2256         parallel building features.
2257
2258 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2259
2260         Unreviewed. Disable accelerated compositing until we figure out why it does not work
2261         properly in the 64 bits release bot.
2262
2263         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2264         (resetDefaultsToConsistentValues):
2265
2266 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2267
2268         Make filter-build-webkit testable using LoadAsModule
2269         Part 1 of 3: <http://webkit.org/b/116247>
2270
2271         Reviewed by Benjamin Poulain.
2272
2273         * Scripts/filter-build-webkit: Change global variables that are
2274         used in subroutines from 'my' to 'our' to make it possible to
2275         evaluate the script in a package context in LoadAsModule.pm.
2276
2277 2013-05-14  Sam Weinig  <sam@webkit.org>
2278
2279         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
2280         https://bugs.webkit.org/show_bug.cgi?id=116132
2281
2282         Reviewed by Anders Carlsson.
2283
2284         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
2285         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
2286
2287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2288         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
2289         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
2290         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2291
2292 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
2293
2294         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
2295         https://bugs.webkit.org/show_bug.cgi?id=114781
2296
2297         Reviewed by Christophe Dumez.
2298
2299         Add run_before_unload_confirm and
2300         Print the log message with "CONFIRM NAVIGATION: " in console.
2301
2302         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2303         (onBeforeUnloadConfirm):
2304         (drtViewAdd):
2305
2306 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
2307
2308         Fix Analyze ChangeLog's entry processing
2309         https://bugs.webkit.org/show_bug.cgi?id=116219
2310
2311         Reviewed by Ryosuke Niwa.
2312
2313         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2314         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
2315
2316 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
2317
2318         [Qt] UrlLoader::loadNext is broken in MiniBrowser
2319         https://bugs.webkit.org/show_bug.cgi?id=116099
2320
2321         Reviewed by Jocelyn Turcotte.
2322
2323         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
2324         are not available any more. So, UrlLoader::loadNext was broken
2325         because it failed to connect to those signals.
2326
2327         * MiniBrowser/qt/UrlLoader.cpp:
2328         (UrlLoader::UrlLoader):
2329         (UrlLoader::loadingChanged):
2330         * MiniBrowser/qt/UrlLoader.h:
2331         (UrlLoader):
2332
2333 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
2334
2335         [WebSocket] Update pywebsocket to r760
2336         https://bugs.webkit.org/show_bug.cgi?id=115863
2337
2338         Reviewed by Alexey Proskuryakov.
2339
2340         Version r760 supports a newer draft of message compression.
2341         We need this update to finish the permessage compression patch in
2342         bug 98840. This patch also fixes failing unit tests after the update.
2343
2344         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
2345         (StreamBase._read):
2346         (StreamBase._read.of):
2347         (StreamBase._write):
2348         (StreamBase.receive_bytes):
2349         (StreamBase._read_until):
2350         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2351         (parse_frame):
2352         (StreamOptions.__init__):
2353         (Stream.__init__):
2354         (Stream._receive_frame_as_frame_object):
2355         (Stream._get_message_from_frame):
2356         (Stream._process_close_message):
2357         (Stream.close_connection):
2358         (Stream.get_last_received_opcode):
2359         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2360         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
2361         (Dispatcher.do_extra_handshake):
2362         (Dispatcher.transfer_data):
2363         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2364         (ExtensionProcessorInterface.__init__):
2365         (ExtensionProcessorInterface.request):
2366         (ExtensionProcessorInterface):
2367         (ExtensionProcessorInterface.name):
2368         (ExtensionProcessorInterface.check_consistency_with_other_processors):
2369         (ExtensionProcessorInterface.set_active):
2370         (ExtensionProcessorInterface.is_active):
2371         (ExtensionProcessorInterface._get_extension_response_internal):
2372         (ExtensionProcessorInterface.get_extension_response):
2373         (ExtensionProcessorInterface._setup_stream_options_internal):
2374         (ExtensionProcessorInterface.setup_stream_options):
2375         (_log_outgoing_compression_ratio):
2376         (_log_incoming_compression_ratio):
2377         (_parse_window_bits):
2378         (_AverageRatioCalculator):
2379         (_AverageRatioCalculator.__init__):
2380         (_AverageRatioCalculator.add_original_bytes):
2381         (_AverageRatioCalculator.add_result_bytes):
2382         (_AverageRatioCalculator.get_average_ratio):
2383         (DeflateFrameExtensionProcessor):
2384         (DeflateFrameExtensionProcessor.__init__):
2385         (DeflateFrameExtensionProcessor._get_extension_response_internal):
2386         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
2387         (DeflateFrameExtensionProcessor._outgoing_filter):
2388         (DeflateFrameExtensionProcessor._incoming_filter):
2389         (CompressionExtensionProcessorBase.for):
2390         (CompressionExtensionProcessorBase.__init__):
2391         (CompressionExtensionProcessorBase._get_extension_response_internal):
2392         (CompressionExtensionProcessorBase._setup_stream_options_internal):
2393         (PerFrameCompressExtensionProcessor):
2394         (PerMessageDeflateExtensionProcessor):
2395         (PerMessageDeflateExtensionProcessor.__init__):
2396         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
2397         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
2398         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
2399         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
2400         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
2401         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
2402         (PerMessageDeflateExtensionProcessor.set_bfinal):
2403         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
2404         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
2405         (_PerMessageDeflateFramer):
2406         (_PerMessageDeflateFramer.__init__):
2407         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
2408         (_PerMessageDeflateFramer._process_incoming_message):
2409         (_PerMessageDeflateFramer._process_outgoing_message):
2410         (_PerMessageDeflateFramer.setup_stream_options):
2411         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
2412         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
2413         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
2414         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
2415         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
2416         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
2417         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
2418         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
2419         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
2420         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
2421         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
2422         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
2423         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
2424         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
2425         (PerMessageCompressExtensionProcessor):
2426         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
2427         (MuxExtensionProcessor.__init__):
2428         (MuxExtensionProcessor.check_consistency_with_other_processors):
2429         (MuxExtensionProcessor):
2430         (MuxExtensionProcessor._get_extension_response_internal):
2431         (MuxExtensionProcessor._setup_stream_options_internal):
2432         (MuxExtensionProcessor.set_quota):
2433         (MuxExtensionProcessor.quota):
2434         (MuxExtensionProcessor.set_extensions):
2435         (MuxExtensionProcessor.extensions):
2436         (is_compression_extension):
2437         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2438         (validate_subprotocol):
2439         (parse_host_header):
2440         (format_header):
2441         (check_request_line):
2442         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2443         (Handshaker.do_handshake):
2444         (Handshaker._create_handshake_response):
2445         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
2446         (_validate_subprotocol):
2447         (_check_header_lines):
2448         (_build_location):
2449         (Handshaker.do_handshake):
2450         (Handshaker._set_subprotocol):
2451         (Handshaker._set_location):
2452         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
2453         (_create_dispatcher):
2454         (headerparserhandler):
2455         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
2456         (_create_add_channel_response):
2457         (_create_drop_channel):
2458         (_create_flow_control):
2459         (_create_new_channel_slot):
2460         (_create_fallback_new_channel_slot):
2461         (_MuxFramePayloadParser._read_number):
2462         (_MuxFramePayloadParser._read_size_and_contents):
2463         (_MuxFramePayloadParser._read_flow_control):
2464         (_MuxFramePayloadParser._read_new_channel_slot):
2465         (_LogicalConnection.__init__):
2466         (_LogicalConnection.write):
2467         (_LogicalConnection.on_write_data_done):
2468         (_LogicalConnection):
2469         (_LogicalConnection.on_writer_done):
2470         (_InnerMessage):
2471         (_InnerMessage.__init__):
2472         (_InnerMessageBuilder):
2473         (_InnerMessageBuilder.that):
2474         (_InnerMessageBuilder.__init__):
2475         (_InnerMessageBuilder._handle_first):
2476         (_InnerMessageBuilder._process_first_fragmented_control):
2477         (_InnerMessageBuilder._process_first_fragmented_message):
2478         (_InnerMessageBuilder._handle_fragmented_control):
2479         (_InnerMessageBuilder._reassemble_fragmented_control):
2480         (_InnerMessageBuilder._handle_fragmented_message):
2481         (_InnerMessageBuilder._reassemble_fragmented_message):
2482         (_InnerMessageBuilder.build):
2483         (_LogicalStream.__init__):
2484         (_LogicalStream._create_inner_frame):
2485         (_LogicalStream._write_inner_frame):
2486         (_LogicalStream.replenish_send_quota):
2487         (_LogicalStream.send_message):
2488         (_LogicalStream._receive_frame):
2489         (_LogicalStream._get_message_from_frame):
2490         (_LogicalStream.stop_sending):
2491         (_PhysicalConnectionWriter.__init__):
2492         (_PhysicalConnectionWriter._write_data):
2493         (_PhysicalConnectionWriter.run):
2494         (_PhysicalConnectionWriter.stop):
2495         (_Worker.run):
2496         (_MuxHandshaker.__init__):
2497         (_MuxHandshaker._create_stream):
2498         (_MuxHandshaker._create_handshake_response):
2499         (_HandshakeDeltaBase.create_headers):
2500         (_MuxHandler.start):
2501         (_MuxHandler.wait_until_done):
2502         (_MuxHandler.notify_write_data_done):
2503         (_MuxHandler._process_drop_channel):
2504         (_MuxHandler._process_logical_frame):
2505         (_MuxHandler.notify_reader_done):
2506         (_MuxHandler):
2507         (_MuxHandler.notify_writer_done):
2508         (_MuxHandler.fail_physical_connection):
2509         (_MuxHandler.fail_logical_channel):
2510         (use_mux):
2511         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2512         (_StandaloneRequest.get_uri):
2513         (_StandaloneRequest.get_unparsed_uri):
2514         (_StandaloneRequest):
2515         (_StandaloneRequest.is_https):
2516         (_import_ssl):
2517         (_import_pyopenssl):
2518         (_StandaloneSSLConnection.for):
2519         (_StandaloneSSLConnection):
2520         (_StandaloneSSLConnection.__getattribute__):
2521         (_StandaloneSSLConnection.__setattr__):
2522         (_StandaloneSSLConnection.makefile):
2523         (_StandaloneSSLConnection.shutdown):
2524         (_StandaloneSSLConnection.recv):
2525         (WebSocketServer.__init__):
2526         (WebSocketServer._create_sockets):
2527         (WebSocketServer.handle_error):
2528         (WebSocketServer.get_request):
2529         (WebSocketServer.get_request.default_callback):
2530         (WebSocketRequestHandler.parse_request):
2531         (_build_option_parser):
2532         (_main):
2533         (_main.if):
2534         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2535         (RepeatedXorMasker.__init__):
2536         (RepeatedXorMasker._mask_using_swig):
2537         (RepeatedXorMasker):
2538         (RepeatedXorMasker._mask_using_array):
2539         (_Deflater.compress_and_finish):
2540         (_RFC1979Deflater.filter):
2541         (DeflateSocket.send):
2542
2543 2013-05-16  Jonathan Liu  <net147@gmail.com>
2544
2545         Fix testing if program exists in PATH
2546         https://bugs.webkit.org/show_bug.cgi?id=116216
2547
2548         Reviewed by Jocelyn Turcotte.
2549
2550         functions.prf incorrectly uses win_cmd_shell to test whether to
2551         add .exe to the executable name when checking if it exists in
2552         the PATH environment variable. This works correctly when
2553         building using Windows Command Prompt but not under MSYS shell.
2554
2555         To resolve this, check the win32 platform scope instead of
2556         win_cmd_shell so that it correctly adds .exe to the executable
2557         name on Windows regardless of the shell used when testing if
2558         it exists in PATH.
2559
2560         * qmake/mkspecs/features/functions.prf:
2561
2562 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2563
2564         Fix the hard-coded names of EWS bots that run tests.
2565
2566         * Scripts/webkitpy/tool/commands/queues.py:
2567         (CommitQueue.did_pass_testing_ews):
2568
2569 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2570
2571         [GTK] Build Xvfb with jhbuild
2572         https://bugs.webkit.org/show_bug.cgi?id=115907
2573
2574         Reviewed by Martin Robinson.
2575
2576         Build our own Xvfb so that we can avoid problems with the system Xvfb
2577         relying on symbols not present in our jhbuilt libraries such as pixman,
2578         and also to ensure we have the fix for a GLX module crasher.
2579
2580         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2581         (resetDefaultsToConsistentValues): enable accelerated compositing.
2582         * gtk/install-dependencies: list packages required for building Xvfb.
2583         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2584         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2585         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2586         initializing the GLX module for Xvfb.
2587
2588 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2589
2590         [jhbuild] Should remove the sources directory as well when cleaning
2591         https://bugs.webkit.org/show_bug.cgi?id=116229
2592
2593         Reviewed by Martin Robinson.
2594
2595         * Scripts/update-webkit-libs-jhbuild:
2596         (cleanJhbuild): remove the Source directory as well when cleaning.
2597
2598 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2599
2600         [EFL] Remove Intel Wk2 Buildbots from Master
2601         https://bugs.webkit.org/show_bug.cgi?id=116149
2602
2603         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2604         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2605
2606         Reviewed by Benjamin Poulain.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/config.json:
2609
2610 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2611
2612         [Windows] Update various build tools to understand VS2010 environment.
2613         https://bugs.webkit.org/show_bug.cgi?id=116169.
2614
2615         Reviewed by Anders Carlsson.
2616
2617         * Scripts/build-api-tests: Identify VS2010 environment.
2618         * Scripts/build-dumprendertree: Ditto.
2619         * Scripts/build-webkit: Ditto.
2620         * Scripts/webkitdirs.pm:
2621         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2622         range of acceptable SDK's.
2623
2624 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2625
2626         Allow http tests on Arch Linux
2627         https://bugs.webkit.org/show_bug.cgi?id=116155
2628
2629         Reviewed by Ryosuke Niwa.
2630
2631         * Scripts/webkitpy/port/base.py:
2632         (Port._is_arch_based): Added check for /etc/arch-release file.
2633         (Port._apache_config_file_name_for_platform): Call the check.
2634         * Scripts/webkitpy/port/port_testcase.py:
2635         (test_linux_distro_detection): Testcase added.
2636
2637 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2638
2639         Remove a leftover v8 file from the watchlist
2640         https://bugs.webkit.org/show_bug.cgi?id=116158
2641
2642         Reviewed by Csaba Osztrogonác.
2643
2644         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2645
2646 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2647
2648         [GTK] Fails to build while generating gtkdoc
2649         https://bugs.webkit.org/show_bug.cgi?id=115612
2650
2651         Reviewed by Philippe Normand.
2652
2653         Fix typo in the prerequisites of docs-build.stamp.
2654
2655         * GNUmakefile.am:
2656
2657 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2658
2659         Unreviewed, fixing the current test-webkitpy failure.
2660
2661         * Scripts/webkitpy/port/mac_unittest.py:
2662         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2663         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2664
2665 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2666
2667         Fix build after r150090.
2668         https://bugs.webkit.org/show_bug.cgi?id=116129
2669
2670         Unreviewed build fix after r150090.
2671
2672         * WebKitTestRunner/TestInvocation.cpp:
2673         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2674
2675 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2676
2677         [Windows, others] Unreviewed build fix after r150090.
2678
2679         * DumpRenderTree/TestRunner.cpp:
2680         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2681         doesn't exist on other platforms.
2682
2683 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2684
2685         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2686         https://bugs.webkit.org/show_bug.cgi?id=115889
2687
2688         Reviewed by Benjamin Poulain.
2689
2690         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2691         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2692
2693 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2694
2695         [Windows] Identify proper run environment for scripts.
2696         https://bugs.webkit.org/show_bug.cgi?id=116114
2697
2698         Reviewed by David Kilzer.
2699
2700         Determine (based on Visual Studio version) which path to use for
2701         executables (bin versus bin32).
2702
2703         * Scripts/webkitdirs.pm:
2704         (determineVisualStudioInstallDir): Added.
2705         (determineVisualStudioVersion): Added.
2706         (determineConfigurationProductDir): Modified to choose proper bin
2707         or bin32 directory.
2708         (visualStudioVersion): Added
2709         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2710
2711 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2712
2713         [Mac] Add tests for secure event input
2714         https://bugs.webkit.org/show_bug.cgi?id=116121
2715
2716         Reviewed by Mark Rowe.
2717
2718         * DumpRenderTree/TestRunner.cpp:
2719         (getSecureEventInputIsEnabledCallback):
2720         (TestRunner::staticValues):
2721         Expose an accessor for current secure event input state.
2722
2723         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2725         (WTR::TestRunner::secureEventInputIsEnabled):
2726         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2727         * WebKitTestRunner/TestInvocation.cpp:
2728         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2729         Expose an accessor for current secure event input state. This has to be done in
2730         UI process, as this is where it's changed by WebKit.
2731
2732 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2733
2734         [Mac] Add a testing shim for secure event input functions
2735         https://bugs.webkit.org/show_bug.cgi?id=116122
2736
2737         Reviewed by Mark Rowe.
2738
2739         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2740         Inject WebCore testing shim library to override system framework functions.
2741
2742 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2743
2744         [Windows] Switch to embedded manifest commands for launcher executables.
2745         https://bugs.webkit.org/show_bug.cgi?id=116109
2746
2747         Reviewed by Darin Adler.
2748
2749         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2750         now-unused WinLauncher.exe.manifest file.
2751         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2752         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2753         when building with VS2010 or newer.
2754
2755 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2756
2757         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2758         https://bugs.webkit.org/show_bug.cgi?id=116079
2759
2760         Reviewed by David Kilzer.
2761
2762         * Scripts/old-run-webkit-tests:
2763         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2764
2765 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2766
2767         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2768         https://bugs.webkit.org/show_bug.cgi?id=115921
2769
2770         Reviewed by Gustavo Noronha Silva.
2771
2772         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2773         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2774
2775 2013-05-13  Alex Christensen  <achristensen@apple.com>
2776
2777         Added testRunner.setPrinting.
2778         https://bugs.webkit.org/show_bug.cgi?id=42693
2779         rdar://problem/8213845
2780
2781         Reviewed by Darin Adler.
2782
2783         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2784         Added setPrinting JavaScript function.
2785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2786         (WTR::InjectedBundlePage::dump):
2787         Dump the external representation for printing if setPrinting has been called.
2788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2789         (WTR::TestRunner::isPrinting): Added.
2790         (WTR::TestRunner::setPrinting): Added.
2791         Added and initialized m_isPrinting member boolean.
2792
2793 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2794
2795         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2796         https://bugs.webkit.org/show_bug.cgi?id=116016
2797
2798         Reviewed by Dirk Pranke.
2799
2800         Same fix as in the upstream style checker, but without hg support.
2801         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2802
2803         * Scripts/webkitpy/style/checkers/cpp.py:
2804         (FileInfo.repository_name):
2805
2806 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2807
2808         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2809         https://bugs.webkit.org/show_bug.cgi?id=115918
2810
2811         Reviewed by Gustavo Noronha Silva.
2812
2813         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2814         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2815         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2816         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2817         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2818         problems.
2819
2820         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2821         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2822         file paths are constructed and then used to dump the member files from these archives. The member files are
2823         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2824         successfully link.
2825
2826         * TestWebKitAPI/GNUmakefile.am:
2827
2828 2013-05-13  Anders Carlsson  <andersca@apple.com>
2829
2830         Remove UnusedParam.h
2831         https://bugs.webkit.org/show_bug.cgi?id=116029
2832
2833         Reviewed by Andreas Kling.
2834
2835         Stop including UnusedParam.h.
2836
2837         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2838         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2839
2840 2013-05-12  Commit Queue  <commit-queue@webkit.org>
2841
2842         Unreviewed, rolling out r149955.
2843         http://trac.webkit.org/changeset/149955
2844         https://bugs.webkit.org/show_bug.cgi?id=115990
2845
2846         Broke lots of tests (Requested by smfr on #webkit).
2847
2848         * Scripts/webkitpy/port/mac.py:
2849
2850 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2851
2852         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
2853         https://bugs.webkit.org/show_bug.cgi?id=115914
2854
2855         Reviewed by Martin Robinson.
2856
2857         * GtkLauncher/main.c:
2858         (createToolbar):
2859         * MiniBrowser/gtk/BrowserWindow.c:
2860         (_BrowserWindow):
2861         (browserWindowSetStatusText):
2862         (fullScreenMessageTimeoutCallback):
2863         (webViewEnterFullScreen):
2864         (webViewLeaveFullScreen):
2865         (browserWindowFinalize):
2866         (browserWindowConstructed):
2867         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2868         (WTR::EventSenderProxy::mouseScrollBy):
2869         (WTR::EventSenderProxy::continuousMouseScrollBy):
2870
2871 2013-05-11  Anders Carlsson  <andersca@apple.com>
2872
2873         Crash when terminating a process that has not been fully launched
2874         https://bugs.webkit.org/show_bug.cgi?id=115962
2875         <rdar://problem/13660916>
2876
2877         Reviewed by Andreas Kling.
2878
2879         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
2880         before the process has had a chance to be fully launched.
2881
2882         * TestWebKitAPI/GNUmakefile.am:
2883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
2885         (TestWebKitAPI):
2886         (TestWebKitAPI::didFinishLoadForFrame):
2887         (TestWebKitAPI::TEST):
2888         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2889
2890 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2891
2892         Remove Mac OS X Leopard (10.5) support
2893         https://bugs.webkit.org/show_bug.cgi?id=107964
2894
2895         Reviewed by Ryosuke Niwa.
2896
2897         Removed the code for 10.5 and removed if-def for 10.6.
2898
2899         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2900         (convertMIMEType):
2901         (createXMLStringFromWebArchiveData):
2902         * DumpRenderTree/mac/TestRunnerMac.mm:
2903         (TestRunner::authenticateSession):
2904         (TestRunner::setTextDirection):
2905         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2906         (convertMIMEType):
2907         (createXMLStringFromWebArchiveData):
2908
2909 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
2910
2911         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
2912         https://bugs.webkit.org/show_bug.cgi?id=115935
2913
2914         Reviewed by Jer Noble.
2915
2916         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
2917         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
2918         to the new manifest file.
2919         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2920
2921 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2922
2923         Fix some compiler warnings (miscellaneous)
2924         https://bugs.webkit.org/show_bug.cgi?id=80790
2925
2926         Reviewed by Rob Buis.
2927
2928         Fix the following warnings for BlackBerry:
2929         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
2930         used as truth value [-Wparentheses].
2931
2932         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2933         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2934
2935 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2936
2937         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
2938         https://bugs.webkit.org/show_bug.cgi?id=115928
2939
2940         Reviewed by Kenneth Rohde Christiansen.
2941
2942         WKViewSetThemePath was moved to WKViewEfl.h.
2943
2944         * TestWebKitAPI/efl/PlatformWebView.cpp:
2945
2946 2013-05-10  Andreas Kling  <akling@apple.com>
2947
2948         I accidentally the Java testing.
2949
2950         * Scripts/webkitpy/port/mac.py:
2951
2952 2013-05-10  Brian Holt  <brian.holt@samsung.com>
2953
2954         [GTK] Module Cairo fails to build under jhbuild
2955         https://bugs.webkit.org/show_bug.cgi?id=115854
2956
2957         Reviewed by Martin Robinson.
2958
2959         Make cairo depend on glib in jhbuild.modules.
2960
2961         * gtk/jhbuild.modules:
2962
2963 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2964
2965         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
2966         https://bugs.webkit.org/show_bug.cgi?id=115904
2967
2968         Reviewed by Martin Robinson.
2969
2970         * ImageDiff/gtk/ImageDiff.cpp:
2971         (main):
2972
2973 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2974
2975         Add my new address to contributors.json. (Unreviewed)
2976
2977         * Scripts/webkitpy/common/config/contributors.json:
2978
2979 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2980
2981         Unreviewed. Move myself to the reviewers list.
2982
2983         * Scripts/webkitpy/common/config/contributors.json:
2984
2985 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2986
2987         Unreviewed. Add my email to a few watchlists.
2988
2989         * Scripts/webkitpy/common/config/watchlist:
2990
2991 2013-05-10  Simon Pena  <simon.pena@samsung.com>
2992
2993         Unicode support missing from string representation of Contributors in committers.py
2994         https://bugs.webkit.org/show_bug.cgi?id=115859
2995
2996         Reviewed by Darin Adler.
2997
2998         Contributors, in committers.py, provided a string representation in __str__ which
2999         didn't support unicode characters, so printing a contributor would fail in that case.
3000         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
3001         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
3002
3003         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
3004         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
3005         representation.
3006         (Contributor.__str__):
3007         (Contributor):
3008         (Contributor.__unicode__):
3009         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
3010         a contributor with unicode characters can be represented as a string.
3011         (CommittersTest):
3012         (CommittersTest.test_contributor_encoding):
3013
3014 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3015
3016         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
3017         https://bugs.webkit.org/show_bug.cgi?id=92371
3018
3019         Reviewed by Brent Fulgham.
3020
3021         Use JavaScriptThreading.cpp where the same functionality is
3022         implemented too. This reduces the dependency on the pthread
3023         library. Also replace assert() with WebKit ASSERT().
3024
3025         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3026         * DumpRenderTree/win/DumpRenderTree.cpp:
3027         (dumpHistoryItem):
3028         (dumpBackForwardList):
3029         * DumpRenderTree/win/DumpRenderTree.vcproj:
3030
3031 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3032
3033         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
3034         https://bugs.webkit.org/show_bug.cgi?id=92505
3035
3036         Reviewed by Brent Fulgham.
3037
3038         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3039         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
3040         (javaScriptThreadsMutex):
3041         (javaScriptThreads):
3042         (runJavaScriptThread):
3043         (startJavaScriptThreads):
3044         (stopJavaScriptThreads):
3045         * DumpRenderTree/pthreads: Removed.
3046         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
3047
3048 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3049
3050         Unreviewed. Update Simon Pena email on his behalf.
3051
3052         * Scripts/webkitpy/common/config/contributors.json:
3053
3054 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3055
3056         Add support for [NoInterfaceObject] Web IDL extended attribute
3057         https://bugs.webkit.org/show_bug.cgi?id=115714
3058
3059         Reviewed by Kentaro Hara.
3060
3061         Update BindingsTests.generate_supplemental_dependency() to pass an
3062         additional windowConstructorsFile argument to preprocess-idls.pl.
3063
3064         * Scripts/webkitpy/bindings/main.py:
3065         (BindingsTests.generate_supplemental_dependency):
3066         (BindingsTests.main):
3067
3068 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
3069
3070         [GTK][AC] Buildfix after r149694
3071         https://bugs.webkit.org/show_bug.cgi?id=115797
3072
3073         Reviewed by Gustavo Noronha Silva.
3074
3075         Add CLUTTER_LIBS for linking TestWebCore.
3076
3077         * TestWebKitAPI/GNUmakefile.am:
3078
3079 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3080
3081         [EFL] Remove unnecessary pkgs in EFL jhbuild
3082         https://bugs.webkit.org/show_bug.cgi?id=114908
3083
3084         Reviewed by Laszlo Gombos.
3085
3086         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3087         handle them using jhbuild. We can reduce build time when using --update-efl.
3088
3089         * efl/jhbuild.modules:
3090
3091 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3092
3093         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3094         https://bugs.webkit.org/show_bug.cgi?id=115834
3095
3096         Reviewed by Gyuyoung Kim.
3097
3098         * Scripts/webkitperl/FeatureList.pm:
3099
3100 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3101
3102         Add Scheduler for Mac MtnLion 32bit Release builder.
3103         
3104         Unreviewed.
3105         
3106         * BuildSlaveSupport/build.webkit.org-config/config.json:
3107
3108 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3109
3110         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3111         https://bugs.webkit.org/show_bug.cgi?id=115808
3112
3113         Reviewed by Darin Adler.
3114
3115         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3116         was left outdated after r127191, when the m_string member was changed
3117         from UString to String. This patch calls the right pretty printer for it.
3118
3119         * gdb/webkit.py:
3120         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3121         WTFImplPrettyPrinter.
3122
3123 2013-05-08  Andy Estes  <aestes@apple.com>
3124
3125         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3126         https://bugs.webkit.org/show_bug.cgi?id=115790
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         Added two API tests:
3131
3132         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3133         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3134
3135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3136         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3137         (TestWebKitAPI):
3138         (TestWebKitAPI::TEST):
3139         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3140         (TestWebKitAPI):
3141         (TestWebKitAPI::decidePolicyForNavigationAction):
3142         (CustomProtocolInvalidSchemeTest):
3143         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3144
3145 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3146
3147         Teach buildbot how to compile 32-bit on Mac.
3148
3149         Reviewed by Ryosuke Niwa.
3150
3151         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3152         (CompileWebKit.start):
3153         (ExtractTestResultsAndLeaks):
3154
3155 2013-05-08  Eli Fidler  <efidler@blackberry.com>
3156
3157         [BlackBerry] Fix usage of BlackBerry::Platform::String
3158         https://bugs.webkit.org/show_bug.cgi?id=115781
3159
3160         Reviewed by Rob Buis.
3161
3162         BlackBerry PRs 304193 and 327181
3163         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
3164
3165         We currently have a problem where we're passing UTF-8 encoded data into
3166         the char* constructors of BlackBerry::Platform::String. This means the string
3167         thinks its data is not UTF-8.
3168
3169         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3170         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3171         (BlackBerry::WebKit::dumpHistoryItem):
3172         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3173         (TestRunner::setUserStyleSheetLocation):
3174         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3175         (LoadHTMLStringItem::invoke):
3176
3177 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
3178
3179         Tools: add new BlackBerry include dirs.
3180         https://bugs.webkit.org/show_bug.cgi?id=115514
3181
3182         Reviewed by Rob Buis.
3183
3184         iType include dirs are missing, and HarfBuzz needs to be fixed.
3185
3186         * Scripts/webkitdirs.pm:
3187         (blackberryCMakeArguments):
3188
3189 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3190
3191         [GTK] Plumb the Automake build system for the Battery Status API feature
3192         https://bugs.webkit.org/show_bug.cgi?id=115718
3193
3194         Reviewed by Martin Robinson.
3195
3196         * Scripts/webkitdirs.pm:
3197         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
3198         through the --(enable|disable)-battery-status flag passed to configure.
3199
3200 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3201
3202         new-run-webkit-websocketserver doesn't work after Chromium removal
3203         https://bugs.webkit.org/show_bug.cgi?id=115816
3204
3205         Reviewed by Joseph Pecoraro.
3206
3207         Fix the bug by instantiating the correct port object.
3208
3209         * Scripts/new-run-webkit-websocketserver:
3210         (main):
3211
3212 2013-05-07  Lucas Forschler  <lforschler@apple.com>
3213
3214         Configure buildbot for 32bit builder.
3215         https://bugs.webkit.org/show_bug.cgi?id=115769
3216         
3217         Reviewed by Ryosuke Niwa.
3218
3219         * BuildSlaveSupport/build.webkit.org-config/config.json:
3220
3221 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
3222
3223         Unreviewed. Update to show my apple.com address.
3224
3225         * Scripts/webkitpy/common/config/contributors.json: Added
3226         my apple.com e-mail address.
3227
3228 2013-05-08  David Kilzer  <ddkilzer@apple.com>
3229
3230         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
3231
3232         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3233         (concatenateAttributeAndValue): Switch to appendVector().
3234
3235 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3236
3237         [Qt][WTR] Fix the build on Mac after r149692
3238
3239         Unreviewed build fix.
3240
3241         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3242         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3243
3244 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
3245
3246         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
3247         to the watchlist for Accessibility.
3248
3249         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
3250         * Scripts/webkitpy/common/config/watchlist: Added myself.
3251
3252 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3253
3254         [Qt] Build fails with clang
3255         https://bugs.webkit.org/show_bug.cgi?id=115741
3256
3257         Reviewed by Benjamin Poulain.
3258
3259         Since r149112 std::move is used in AtomicString for compilers that
3260         support rvalue references and this requires a standard library
3261         implementing c++11 move semantics.
3262         We only explicitely require c++11 for WebKit2, but since clang supports
3263         rvalue references the build of subtargets using AtomicString fails because
3264         of missing std::move.
3265         It is safe to add CONFIG += c++11 for the whole project when using clang
3266         since we explicitely disable c++11 for ANGLE that had probems with libc++.
3267
3268         * qmake/mkspecs/features/unix/default_pre.prf:
3269
3270 2013-05-08  Darin Adler  <darin@apple.com>
3271
3272         Fix one more place that needed to use adoptCF/NS
3273         https://bugs.webkit.org/show_bug.cgi?id=115778
3274
3275         Reviewed by Benjamin Poulain.
3276
3277         Not sure why I missed this code last time, but found a bit more code that needs
3278         to switch to the newer style adoptCF/NS.
3279
3280         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3281         (convertWebResourceDataToString): Use adoptCF.
3282         (convertWebResourceResponseToDictionary): Ditto.
3283         (createXMLStringFromWebArchiveData): Ditto.
3284         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
3285         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
3286
3287 2013-05-08  Commit Queue  <commit-queue@webkit.org>
3288
3289         Unreviewed, rolling out r149271.
3290         http://trac.webkit.org/changeset/149271
3291         https://bugs.webkit.org/show_bug.cgi?id=115780
3292
3293         The mangled symbols are now enforced through LDFLAGS
3294         (Requested by zdobersek on #webkit).
3295
3296         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3297
3298 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
3299
3300         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
3301         https://bugs.webkit.org/show_bug.cgi?id=115636
3302
3303         Reviewed by Ryosuke Niwa.
3304
3305         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3306         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
3307         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
3308         while Chromium-specific, can't be removed just yet as there's more code that uses it.
3309
3310 2013-05-06  Darin Adler  <darin@apple.com>
3311
3312         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
3313         https://bugs.webkit.org/show_bug.cgi?id=115657
3314
3315         Reviewed by Sam Weinig.
3316
3317         This is similar to my last set of changes, but covers code that I missed with
3318         global replace using the Safari Xcode workspace.
3319
3320         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3321         (convertWebResourceDataToString):
3322         (convertWebResourceResponseToDictionary):
3323         (createXMLStringFromWebArchiveData):
3324         * DumpRenderTree/cg/ImageDiffCG.cpp:
3325         (createImageFromStdin):
3326         (createDifferenceImage):
3327         (main):
3328         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3329         (printPNG):
3330         (dumpBitmap):
3331         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3332         (BitmapContext::BitmapContext):
3333         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3334         (-[MockWebNotificationProvider init]):
3335         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3336         (createBitmapContext):
3337         * DumpRenderTree/mac/TestRunnerMac.mm:
3338         (TestRunner::addDisallowedURL):
3339         (TestRunner::applicationCacheDiskUsageForOrigin):
3340         (TestRunner::localStorageDiskUsageForOrigin):
3341         (TestRunner::clearApplicationCacheForOrigin):
3342         (TestRunner::deleteLocalStorageForOrigin):
3343         (TestRunner::copyDecodedHostName):
3344         (TestRunner::copyEncodedHostName):
3345         (TestRunner::queueLoad):
3346         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3347         (TestRunner::setMockGeolocationPositionUnavailableError):
3348         (TestRunner::setUserStyleSheetLocation):
3349         (TestRunner::setValueForUser):
3350         (TestRunner::overridePreference):
3351         (TestRunner::setPersistentUserStyleSheetLocation):
3352         (TestRunner::execCommand):
3353         (TestRunner::findString):
3354         (TestRunner::isCommandEnabled):
3355         (TestRunner::addOriginAccessWhitelistEntry):
3356         (TestRunner::removeOriginAccessWhitelistEntry):
3357         (TestRunner::addUserScript):
3358         (TestRunner::addUserStyleSheet):
3359         (TestRunner::evaluateInWebInspector):
3360         (TestRunner::evaluateScriptInIsolatedWorld):
3361         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3362         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3363         (TestRunner::authenticateSession):
3364         (TestRunner::grantWebNotificationPermission):
3365         (TestRunner::denyWebNotificationPermission):
3366         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3367         (createCFURLResponseFromResponseData):
3368         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3369         (LoadItem::invoke):
3370         (LoadHTMLStringItem::invoke):
3371         (ScriptItem::invoke):
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (substringFromIndex):
3374         (urlSuitableForTestResult):
3375         (lastPathComponent):
3376         (sharedCFURLCache):
3377         * DumpRenderTree/win/ImageDiffCairo.cpp:
3378         (createImageFromStdin):
3379         (main):
3380         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3381         (createBitmapContextFromWebView):
3382         * DumpRenderTree/win/TestRunnerWin.cpp:
3383         (TestRunner::setUserStyleSheetLocation):
3384         (TestRunner::setPersistentUserStyleSheetLocation):
3385         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3386         (TestWebKitAPI::TEST):
3387         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
3388         (TestWebKitAPI::TEST):
3389         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3390         (TestWebKitAPI::TEST):
3391         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3392         (TestWebKitAPI::TEST):
3393         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3394         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3395         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3396         (TestWebKitAPI::createWindow):
3397         (TestWebKitAPI::TEST):
3398         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3401         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3402         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3403         (TestWebKitAPI::TEST):
3404         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
3405         (TestWebKitAPI::TEST):
3406         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
3407         (TestWebKitAPI::TEST):
3408         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3409         (TestWebKitAPI::TEST):
3410         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
3411         (TestWebKitAPI::TEST):
3412         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3413         (TestWebKitAPI::TEST):
3414         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
3415         (TestWebKitAPI::TEST):
3416         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3417         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3418         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3419         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
3420         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3421         (TestWebKitAPI::TEST):
3422         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3423         (TestWebKitAPI::TEST):
3424         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3425         (TestWebKitAPI::TEST):
3426         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
3427         (TestWebKitAPI::TEST):
3428         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3429         (TestWebKitAPI::TEST):
3430         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3431         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3432         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3435         (TestWebKitAPI::TEST):
3436         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3437         (TestWebKitAPI::TEST):
3438         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3441         (TestWebKitAPI::TEST):
3442         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3443         (TestWebKitAPI::TEST):
3444         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
3445         (TestWebKitAPI::TEST):
3446         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3447         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3448         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3449         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3450         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3451         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
3452         (WTR::testPathFromURL):
3453         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3454         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3455         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3456         (WTR::createCGContextFromImage):
3457         (WTR::dumpBitmap):
3458         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3459         * WebKitTestRunner/mac/EventSenderProxy.mm:
3460         (WTR::EventSenderProxy::mouseScrollBy):
3461         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3462         (WTR::PlatformWebView::windowSnapshotImage):
3463         * WebKitTestRunner/win/TestControllerWin.cpp:
3464         (WTR::TestController::initializeTestPluginDirectory):
3465         Use adoptCF and adoptNS.
3466
3467 2013-05-07  Alex Christensen  <achristensen@apple.com>
3468
3469         Fix a memory leak introduced in r149692
3470         https://bugs.webkit.org/show_bug.cgi?id=115766
3471
3472         Reviewed by Mark Rowe.
3473
3474         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
3475         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
3476
3477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3478         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3479         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
3480
3481 2013-05-07  Darin Adler  <darin@apple.com>
3482
3483         [Win] Fix storage leak in Windows DumpRenderTree
3484         https://bugs.webkit.org/show_bug.cgi?id=115651
3485
3486         Reviewed by Sam Weinig.
3487
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (lastPathComponent): Added a missing call to adoptCF.
3490
3491 2013-05-07  Alex Christensen  <achristensen@apple.com>
3492
3493         fixed a memory leak introduced by bug 42324 by using a RetainPtr
3494         https://bugs.webkit.org/show_bug.cgi?id=115760
3495
3496         Reviewed by Tim Horton.
3497
3498         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3499         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3500         fixed memory leak, added UNUSED_PARAM macros
3501
3502 2013-05-07  Alex Christensen  <achristensen@apple.com>
3503
3504         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
3505         https://bugs.webkit.org/show_bug.cgi?id=42324
3506         <rdar://problem/8193633>
3507
3508         Reviewed by Tim Horton.
3509
3510         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3511         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
3512         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3513         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3514         Added dumpDOMAsWebArchive code that is called when dumping.        
3515         (WTR::InjectedBundlePage::dump):
3516         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
3517         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3518         (InjectedBundlePage):
3519         Added dumpDOMAsWebArchive declaration.
3520         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
3521         (WTR::TestRunner::dumpDOMAsWebArchive):
3522         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
3523         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3524         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
3525         * Tools/WebKitTestRunner/cf: Added.
3526         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
3527         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
3528         (convertMIMEType):
3529         (convertWebResourceDataToString):
3530         (normalizeHTTPResponseHeaderFields):
3531         (normalizeWebResourceURL):
3532         (convertWebResourceResponseToDictionary):
3533         (compareResourceURLs):
3534         (createXMLStringFromWebArchiveData):
3535         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
3536         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
3537         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
3538         Copied from Tools/DumpRenderTree/mac for used functions.
3539         (createCFURLResponseFromResponseData):
3540         (supportedNonImageMIMETypes):
3541
3542 2013-05-07  Alex Christensen  <achristensen@apple.com>
3543
3544         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
3545         https://bugs.webkit.org/show_bug.cgi?id=115745
3546
3547         Reviewed by Tim Horton.
3548
3549         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3550         (compareResourceURLs):
3551         Updated style.
3552
3553 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
3554
3555         Add an 'isReadOnly' member to IDL parse tree structure
3556         https://bugs.webkit.org/show_bug.cgi?id=115704
3557
3558         Reviewed by Kentaro Hara.
3559
3560         Use newly added isReadOnly attribute.
3561
3562         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3563         (_generateHeaderFile):
3564         (_generateImplementationFile):
3565         (_staticValuesGetterImplementation):
3566
3567 2013-05-07  Anders Carlsson  <andersca@apple.com>
3568
3569         Remove AlwaysInline.h from WTF
3570         https://bugs.webkit.org/show_bug.cgi?id=115727
3571
3572         Reviewed by Brent Fulgham.
3573
3574         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
3575         to keep AlwaysInline.h around anymore.
3576
3577         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3578         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3579
3580 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
3581
3582         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
3583         https://bugs.webkit.org/show_bug.cgi?id=114808
3584
3585         Reviewed by Jocelyn Turcotte.
3586
3587         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
3588         (https://codereview.qt-project.org/#change,54234)
3589
3590         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3591         (WTR::WrapperWindow::handleStatusChanged):
3592
3593 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3594
3595         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
3596
3597         * Scripts/webkitpy/common/config/watchlist:
3598
3599 2013-05-06  Kangil Han  <kangil.han@samsung.com>
3600
3601         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
3602         https://bugs.webkit.org/show_bug.cgi?id=115645
3603
3604         Reviewed by Gyuyoung Kim.
3605
3606         To run performance tests in wk1, we need --no-timeout option implementation.
3607         So adopt it from gtk+ port.
3608
3609         * DumpRenderTree/efl/DumpRenderTree.cpp:
3610         (shouldSetWaitToDumpWatchdog):
3611         (parseCommandLineOptions):
3612         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
3613         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3614         (TestRunner::setWaitToDump):
3615
3616 2013-05-06  Commit Queue  <commit-queue@webkit.org>
3617
3618         Unreviewed, rolling out r149547.
3619         http://trac.webkit.org/changeset/149547
3620         https://bugs.webkit.org/show_bug.cgi?id=115682
3621
3622         Added unittests that fail on bots and spits out text into
3623         stdout (Requested by rniwa on #webkit).
3624
3625         * Scripts/import-w3c-tests: Removed.
3626         * Scripts/webkitpy/w3c/__init__.py: Removed.
3627         * Scripts/webkitpy/w3c/test_converter.py: Removed.
3628         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
3629         * Scripts/webkitpy/w3c/test_importer.py: Removed.
3630         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
3631         * Scripts/webkitpy/w3c/test_parser.py: Removed.
3632         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
3633
3634 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
3635
3636         [jhbuild] bump jhbuild version to take advantage of new improvements
3637         https://bugs.webkit.org/show_bug.cgi?id=115558
3638
3639         Reviewed by Martin Robinson.
3640
3641         One of the important improvements is jhbuild no longer fetches git
3642         repositories if they are already at the expected revision, which should
3643         make the EWS bots more robust to git servers unavailability.
3644
3645         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
3646
3647 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
3648
3649         [GTK] Add webkit_uri_scheme_request_finish_error
3650         https://bugs.webkit.org/show_bug.cgi?id=94316
3651
3652         Reviewed by Anders Carlsson.
3653
3654         * MiniBrowser/gtk/main.c:
3655         (miniBrowserErrorQuark): Add function to create a global quark for
3656         MiniBrowser.
3657         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
3658         function webkit_uri_scheme_request_finish_error().
3659
3660 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
3661
3662         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
3663         https://bugs.webkit.org/show_bug.cgi?id=113808
3664
3665         Reviewed by Rob Buis.
3666
3667         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
3668         to true for BlackBerry.
3669
3670         * Scripts/webkitperl/FeatureList.pm:
3671
3672 2013-05-06  Jessie Berlin  <jberlin@apple.com>
3673
3674         check-webkit-style should complain about a layering violation if platform-specific guards are
3675         used in WebCore outside of the platform directory
3676         https://bugs.webkit.org/show_bug.cgi?id=115567
3677
3678         Reviewed by Benjamin Poulain.
3679
3680         * Scripts/webkitpy/style/checkers/cpp.py:
3681         (check_for_webcore_platform_layering_violation):
3682         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
3683         (process_line):
3684         Add the check_for_webcore_platform_layering_violation.
3685         (CppChecker):
3686         List the new check.
3687
3688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3689         (CppStyleTest.test_webcore_platform_layering_violation):
3690         Add tests.
3691
3692 2013-05-06  David Kilzer  <ddkilzer@apple.com>
3693
3694         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
3695         <http://webkit.org/b/115667>
3696
3697         Reviewed by Dirk Pranke.
3698
3699         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3700         (Bugzilla._check_create_bug_response): Update regex to work with
3701         Bugzilla 3.2.3 and 4.2.5.
3702         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3703         (test__check_create_bug_response): Add new test that covers both
3704         old and new <title> variations.
3705
3706 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3707
3708         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
3709         https://bugs.webkit.org/show_bug.cgi?id=115661
3710
3711         Reviewed by Ryosuke Niwa.
3712
3713         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
3714         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
3715         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
3716
3717         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3718         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3719
3720 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3721
3722         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
3723         https://bugs.webkit.org/show_bug.cgi?id=114603
3724
3725         Reviewed by Ryosuke Niwa.
3726
3727         * TestResultServer/generate_builders_json.py:
3728         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
3729         to represent these to be 'layout-test', for backwards compatibility.
3730         (main): Remove all the build.chromium.org masters.
3731         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
3732         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3733         (GenerateBuildersJsonTest):
3734         (GenerateBuildersJsonTest.test_generate_json_data):
3735         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
3736         test-running builders from the webkit.org master.
3737
3738 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3739
3740         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
3741         https://bugs.webkit.org/show_bug.cgi?id=114988
3742
3743         Reviewed by Ryosuke Niwa.
3744
3745         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
3746         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
3747         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
3748         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
3749         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
3750
3751 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3752
3753         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
3754         https://bugs.webkit.org/show_bug.cgi?id=114954
3755
3756         Reviewed by Ryosuke Niwa.
3757
3758         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3759         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
3760         modifier unions in the list of modifiers.
3761         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
3762         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
3763
3764 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3765
3766         [Flakiness Dashboard] Simplify builder-name-based platform recognition
3767         https://bugs.webkit.org/show_bug.cgi?id=114957
3768
3769         Reviewed by Ryosuke Niwa.
3770
3771         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3772         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
3773         (chromiumPlatform): Removed, unnecessary.
3774         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
3775         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
3776         the builder operates with debug builds, no webkit.org builders are named this way.
3777         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3778         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
3779
3780 2013-05-06  Andy Estes  <aestes@apple.com>
3781
3782         Added two files I neglected to commit in r149589.
3783
3784         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
3785         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
3786
3787 2013-05-04  Andy Estes  <aestes@apple.com>
3788
3789         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
3790         https://bugs.webkit.org/show_bug.cgi?id=115609
3791
3792         Reviewed by Oliver Hunt.
3793
3794         Added an API test.
3795
3796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3797         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
3798         (+[TestDelegate shared]):
3799         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3800         (-[TestDelegate webView:createWebViewWithRequest:]):
3801         (TestWebKitAPI):
3802         (TestWebKitAPI::TEST):
3803         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
3804
3805 2013-05-06  Antoine Quint  <graouts@apple.com>
3806
3807         Manage the presentation of the snapshotted plug-in using JavaScript
3808         https://bugs.webkit.org/show_bug.cgi?id=115548
3809
3810         Reviewed by Dean Jackson.
3811
3812         Take into account the new plugInExtraScript method added to support
3813         the injection of a JS file from the chrome client to customize the
3814         rendering of a snapshotted plug-in's shadow tree.
3815
3816         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3817         (WTR::InjectedBundlePage::InjectedBundlePage):
3818
3819 2013-05-05  Anders Carlsson  <andersca@apple.com>
3820
3821         Remove the Vector::append overload that takes a Vector
3822         https://bugs.webkit.org/show_bug.cgi?id=115535
3823
3824         Reviewed by Andreas Kling.
3825
3826         Use Vector::appendVector instead.
3827
3828         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3829         (concatenateAttributeAndValue):
3830         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3831         (WTR::concatenateAttributeAndValue):
3832
3833 2013-05-04  Sam Weinig  <sam@webkit.org>
3834
3835         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
3836         <rdar://problem/13702008>
3837         https://bugs.webkit.org/show_bug.cgi?id=115607
3838
3839         Reviewed by Benjamin Poulain.
3840
3841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3842         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
3843         (TestWebKitAPI::didFinishLoadForFrame):
3844         (TestWebKitAPI::TEST):
3845         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
3846
3847 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3848
3849         Unreviewed.
3850
3851         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
3852
3853 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
3854
3855         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
3856
3857         * Scripts/webkitpy/common/config/contributors.json:
3858
3859 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3860
3861         [GTK] Catch select.error exceptions in parse_output_lines
3862         https://bugs.webkit.org/show_bug.cgi?id=115253
3863
3864         Reviewed by Gustavo Noronha Silva.
3865
3866         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
3867         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
3868         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
3869         error code and the error message) and the loop is re-entered.
3870
3871         * gtk/common.py:
3872         (parse_output_lines):
3873
3874 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3875
3876         [GTK] Set up the TestWebCore in TestWebKitAPI
3877         https://bugs.webkit.org/show_bug.cgi?id=115237
3878
3879         Reviewed by Gustavo Noronha Silva.
3880
3881         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
3882         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
3883         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
3884         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
3885         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
3886
3887         * TestWebKitAPI/GNUmakefile.am:
3888
3889 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
3890
3891         Create a script to import W3C tests
3892         https://bugs.webkit.org/show_bug.cgi?id=111513
3893
3894         Reviewed by Dirk Pranke.
3895
3896         Script to automate the import of W3C tests into WebKit. 
3897         For the full description of how it works, see the comments
3898         at the top of test_importer.py.
3899
3900         * Scripts/import-w3c-tests: Added.
3901         * Scripts/webkitpy/w3c/__init__.py: Added.
3902         * Scripts/webkitpy/w3c/test_converter.py: Added.
3903         (TestConverter):
3904         (TestConverter.__init__):
3905         (TestConverter.load_prefixed_prop_list):
3906         (TestConverter.load_file):
3907         (TestConverter.convert_for_webkit):
3908         (TestConverter.convert_testharness_paths):
3909         (TestConverter.convert_prefixed_properties):
3910         (TestConverter.scrub_unprefixed_props):
3911         (TestConverter.replace_tag):
3912         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
3913         (TestConverterTest):
3914         (TestConverterTest.testLoadPrefixedPropList):
3915         (TestConverterTest.test_convertForWebkitNothingToConvert):
3916         (test_convertForWebkitHarnessOnly):
3917         (test_convertForWebkitPropsOnly):
3918         (test_convertForWebkitHarnessAndProps):
3919         (test_convertTestHarnessPaths):
3920         (test_convertPrefixedProperties):
3921         (verifyTestHarnessPaths):
3922         (verifyPrefixedProperties):
3923         (generateTestContent):
3924         * Scripts/webkitpy/w3c/test_importer.py: Added.
3925         (main):
3926         (parse_args):
3927         (validate_import_directory):
3928         (TestImporter):
3929         (TestImporter.__init__):
3930         (TestImporter.do_import):
3931         (TestImporter.get_changeset):
3932         (TestImporter.scan_source_directory):
3933         (TestImporter.import_tests):
3934         (TestImporter.setup_destination_directory):
3935         (TestImporter.get_test_status):
3936         (TestImporter.remove_deleted_files):
3937         (TestImporter.write_import_log):
3938         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
3939         (TestImporterTest):
3940         (TestImporterTest.test_ImportDirWithNoTests):
3941         * Scripts/webkitpy/w3c/test_parser.py: Added.
3942         (TestParser):
3943         (TestParser.__init__):
3944         (TestParser.load_file):
3945         (TestParser.analyze_test):
3946         (TestParser.get_reftests):
3947         (TestParser.is_jstest):
3948         (TestParser.get_support_files):
3949         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
3950         (TestParserTest):
3951         (TestParserTest.test_analyzeTestReftestOneMatch):
3952         (test_analyzeTestReftestMultipleMatches):
3953         (test_analyzeTestReftestMatchAndMismatch):
3954         (test_analyzeTestReftestWithRefSupportFiles):
3955         (test_analyzeJSTest):
3956         (test_analyzePixelTestAllTrue):
3957         (test_analyzePixelTestAllFalse):
3958         (test_analyzeNonHTMLFile):
3959
3960 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3961
3962         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
3963
3964         * Scripts/webkitpy/common/config/contributors.json:
3965
3966 2013-05-02  Nico Weber  <thakis@chromium.org>
3967
3968         Remove a stale script file.
3969         https://bugs.webkit.org/show_bug.cgi?id=115521
3970
3971         Reviewed by Anders Carlsson.
3972
3973         This script was added in
3974         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
3975         Bakefile system that was removed in
3976         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
3977         script just asserts when it's run and is useless.
3978
3979         * Scripts/update-sources-list.py: Removed.
3980
3981 2013-05-01  Glenn Adams  <glenn@skynav.com>
3982
3983         [webkitpy] Need abstract base class for commands that analyze commit logs
3984         https://bugs.webkit.org/show_bug.cgi?id=115391
3985
3986         Reviewed by Benjamin Poulain.
3987
3988         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
3989         in preparation for adding two new commands that will reuse this functionality along with
3990         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
3991         https://bugs.webkit.org/show_bug.cgi?id=115388.
3992
3993         No new tests as this patch does not change existing functionality or behavior.
3994
3995         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3996         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
3997         (AbstractCommitLogCommand.__init__):
3998         (AbstractCommitLogCommand._init_options):
3999         (AbstractCommitLogCommand._parse_commit_message):
4000         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
4001         (SuggestNominations.__init__): 
4002         (SuggestNominations._init_options):
4003
4004 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
4005
4006         Web Inspector: Fix check-inspector-strings script and fix localized strings
4007         https://bugs.webkit.org/show_bug.cgi?id=115495
4008
4009         Reviewed by Joseph Pecoraro.
4010
4011         * Scripts/check-inspector-strings:
4012
4013 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
4014
4015         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
4016         https://bugs.webkit.org/show_bug.cgi?id=115470
4017
4018         Reviewed by Martin Robinson.
4019
4020         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
4021         not building either of the IOS, Windows or GTK-WK1 platforms.
4022
4023         Up until now the header was included for everything but the IOS and Windows platforms due to
4024         an incorrectly stated condition regarding the GTK platform.
4025
4026         * TestWebKitAPI/config.h:
4027
4028 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
4029
4030         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
4031         https://bugs.webkit.org/show_bug.cgi?id=115469
4032
4033         Reviewed by Martin Robinson.
4034
4035         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
4036         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
4037         for the WebKit2 tests and the injected bundle required by them.
4038
4039         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
4040         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
4041         under the WebKit2 code).
4042
4043         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
4044         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
4045         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
4046
4047         * TestWebKitAPI/GNUmakefile.am:
4048
4049 2013-04-30  Glenn Adams  <glenn@skynav.com>
4050
4051         Unreviewed. Add myself to watchlist entries.
4052
4053         * Scripts/webkitpy/common/config/watchlist:
4054
4055 2013-04-30  Glenn Adams  <glenn@skynav.com>
4056
4057         [webkitpy] suggest-nominations doesn't count all qualified patches
4058         https://bugs.webkit.org/show_bug.cgi?id=115285
4059
4060         Reviewed by Benjamin Poulain.
4061
4062         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
4063         nomination. Improve commit log parsing.
4064
4065         * Scripts/webkitpy/tool/commands/suggestnominations.py:
4066         (CommitLogError):
4067         (CommitLogError.__init__):
4068         (CommitLogMissingReviewer):
4069         (CommitLogMissingReviewer.__init__):
4070         (SuggestNominations):
4071         (SuggestNominations.__init__):
4072         (SuggestNominations._recent_commit_messages):
4073         (SuggestNominations._author_name_from_email):
4074         (SuggestNominations._contributor_from_email):
4075         (SuggestNominations._parse_commit_message):
4076         (SuggestNominations._count_commit):
4077         (SuggestNominations._count_recent_patches):
4078         (SuggestNominations._collect_nominations):
4079         (SuggestNominations._print_nominations):
4080         (SuggestNominations.execute):
4081         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
4082         (_make_options):
4083         (test_recent_commit_messages):
4084         (test_basic):
4085
4086 2013-04-30  Commit Queue  <rniwa@webkit.org>
4087
4088         Unreviewed, rolling out r149309.
4089         http://trac.webkit.org/changeset/149309
4090         https://bugs.webkit.org/show_bug.cgi?id=115430
4091
4092         The patch does not build on WK1-only builds of the GTK port
4093         (Requested by zdobersek on #webkit).
4094
4095         * TestWebKitAPI/GNUmakefile.am:
4096
4097 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4098
4099         Stop using "in" keyword in IDL files
4100         https://bugs.webkit.org/show_bug.cgi?id=115418
4101
4102         Reviewed by Kentaro Hara.
4103
4104         Remove "in" keyword from IDL files as this is no longer part of the Web
4105         IDL specification.
4106
4107         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4108         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
4109         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
4110         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4111         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4112         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
4113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4114         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
4115
4116 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4117
4118         [EFL] Enable scaled cursors
4119         https://bugs.webkit.org/show_bug.cgi?id=106242
4120
4121         Reviewed by Gyuyoung Kim.
4122
4123         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
4124
4125         * Scripts/webkitperl/FeatureList.pm:
4126
4127 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4128
4129         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
4130         https://bugs.webkit.org/show_bug.cgi?id=115380
4131
4132         Reviewed by Kentaro Hara.
4133
4134         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
4135         keyword.
4136
4137         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4138         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4139
4140 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
4141
4142         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
4143         https://bugs.webkit.org/show_bug.cgi?id=114684
4144
4145         Reviewed by Simon Hausmann.
4146
4147         Remove the ANGLE requirement for USE(3D_GRAPHICS).
4148         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
4149
4150         * qmake/mkspecs/features/features.prf:
4151
4152 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
4153
4154         [GTK] Disable Shadow DOM feature
4155         https://bugs.webkit.org/show_bug.cgi?id=115374
4156
4157         Reviewed by Martin Robinson.
4158
4159         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
4160
4161         * Scripts/webkitperl/FeatureList.pm:
4162
4163 2013-04-29  Glenn Adams  <glenn@skynav.com>
4164
4165         [webkitpy] Add missing contributor email addresses
4166         https://bugs.webkit.org/show_bug.cgi?id=115394
4167
4168         Reviewed by Ryosuke Niwa.
4169
4170         * Scripts/webkitpy/common/config/contributors.json:
4171
4172 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
4173
4174         Remove all remaining Skia code
4175         https://bugs.webkit.org/show_bug.cgi?id=115263
4176
4177         Reviewed by Benjamin Poulain.
4178
4179         Remove all remaining references to Skia.
4180
4181         * Scripts/webkitdirs.pm:
4182         (blackberryCMakeArguments):
4183         * Scripts/webkitpy/common/config/contributionareas.py:
4184         * Scripts/webkitpy/common/config/watchlist:
4185
4186 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
4187
4188         Get rid of unused options in Tools/Scripts/webkit-build-directory
4189         https://bugs.webkit.org/show_bug.cgi?id=115383
4190
4191         Reviewed by Darin Adler.
4192
4193         * Scripts/webkit-build-directory:
4194
4195 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
4196
4197         [WK2][Mac] Test with NetworkProcess enabled.
4198
4199         Fix the build for non-Mac.
4200
4201         * WebKitTestRunner/TestController.cpp:
4202         (WTR::TestController::initialize):
4203
4204 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
4205
4206         [WK2][Mac] Test with NetworkProcess enabled.
4207
4208         Reviewed by Sam Weinig.
4209
4210         * WebKitTestRunner/TestController.cpp:
4211         (WTR::TestController::initialize):
4212
4213 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
4214
4215         [GTK] Set up the TestWebCore in TestWebKitAPI
4216         https://bugs.webkit.org/show_bug.cgi?id=115237
4217
4218         Reviewed by Gustavo Noronha Silva.
4219
4220         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
4221         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
4222         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
4223         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
4224         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
4225
4226         * TestWebKitAPI/GNUmakefile.am:
4227
4228 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
4229
4230         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
4231         https://bugs.webkit.org/show_bug.cgi?id=115236
4232
4233         Reviewed by Gustavo Noronha Silva.
4234
4235         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
4236         under the TestWebKitAPI/Tests/JavaScriptCore directory.
4237
4238         * TestWebKitAPI/GNUmakefile.am:
4239
4240 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
4241
4242         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
4243         https://bugs.webkit.org/show_bug.cgi?id=115323
4244
4245         Reviewed by Philippe Normand.
4246
4247         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
4248         Its presence enforces linkers to output mangled symbols when reporting linking failures
4249         due to unresolved references. People trying to fix the build can then simply copy
4250         the printed mangled symbol into the symbols.filter file instead of doing a manual build
4251         or connecting to the builders to discover the mangled version of the missing symbol.
4252
4253         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
4254
4255 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
4256
4257         Remove Chromium code from Tools/BuildSlaveSupport
4258         https://bugs.webkit.org/show_bug.cgi?id=115325
4259
4260         Reviewed by Benjamin Poulain.
4261
4262         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
4263         covering archiving test results and built products.
4264
4265         * BuildSlaveSupport/built-product-archive:
4266         (archiveBuiltProduct):
4267         (extractBuiltProduct):
4268         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
4269         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
4270         * BuildSlaveSupport/test-result-archive:
4271         (archiveTestResults):
4272
4273 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
4274
4275         Remove support for Chromium from webkitdirs.pm
4276         https://bugs.webkit.org/show_bug.cgi?id=115338
4277
4278         Reviewed by Darin Adler.
4279
4280         * Scripts/webkitdirs.pm:
4281         (determineBaseProductDir):
4282         (argumentsForConfiguration):
4283         (builtDylibPathForName):
4284         (determineIsQt):
4285         (isAppleWebKit):
4286
4287 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
4288
4289         Rename TestRunner's setAudioData to setAudioResult
4290         https://bugs.webkit.org/show_bug.cgi?id=115326
4291
4292         Reviewed by Darin Adler.
4293
4294         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
4295         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
4296         affected tests are adjusted accordingly.
4297
4298         * DumpRenderTree/qt/TestRunnerQt.cpp:
4299         (TestRunnerQt::setAudioResult):
4300         * DumpRenderTree/qt/TestRunnerQt.h:
4301         (TestRunnerQt):
4302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4304         (WTR::TestRunner::setAudioResult):
4305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4306         (TestRunner):
4307
4308 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
4309
4310         [WKTR] Tests dumping audio data shouldn't dump pixels
4311         https://bugs.webkit.org/show_bug.cgi?id=115270
4312
4313         Reviewed by Benjamin Poulain.
4314
4315         Prevent dumping the pixel output when Web Audio tests are dumping output data
4316         as the testing output. Pixel output in these tests has no real meaning and is
4317         as such unnecessary.
4318
4319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4320         (WTR::TestRunner::setAudioData):
4321