Unreviewed. Fix GTK distcheck.
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Fix GTK distcheck.
4
5         * gtk/make-dist.py:
6         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
7
8 2017-07-25  Brady Eidson  <beidson@apple.com>
9
10         ResourceLoadStatistics grandfathering happens much too often.
11         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
12
13         Reviewed by Chris Dumez.
14
15         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
17         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
18         (TEST):
19
20 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
21
22         Fix autoinstaller failing on autoinstall_everything
23         https://bugs.webkit.org/show_bug.cgi?id=174830
24
25         Reviewed by Joseph Pecoraro.
26
27         * Scripts/webkitpy/thirdparty/__init__.py:
28         (AutoinstallImportHook.find_module):
29         (AutoinstallImportHook.install_chromedriver):
30         (AutoinstallImportHook.install_geckodriver):
31         (AutoinstallImportHook._install_chromedriver): Deleted.
32         (AutoinstallImportHook._install_geckodriver): Deleted.
33
34 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
35
36         Replace --runtime with something for both ios-simulator and ios-device
37         https://bugs.webkit.org/show_bug.cgi?id=173775
38         <rdar://problem/32952164>
39
40         Reviewed by Aakash Jain.
41
42         Add --version flag for both iOS simulator and iOS device.
43
44         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
45         (parse_args): Add --version flag and move --no-install.
46         * Scripts/webkitpy/port/factory.py:
47         (platform_options): Move --no-intall to run_webkit_tests.py.
48         * Scripts/webkitpy/port/ios.py:
49         (IOSPort):
50         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
51         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
52         * Scripts/webkitpy/port/ios_device.py:
53         (IOSDevicePort.ios_version): Consult --version flag before checking connected
54         devices for iOS version.
55         * Scripts/webkitpy/port/ios_device_unittest.py:
56         (IOSDeviceTest.make_port): Set --version option so that we can generate test
57         expectation paths without devices connected.
58         (IOSDeviceTest.test_additional_platform_directory): Deleted.
59         (IOSDeviceTest.test_baseline_searchpath): Deleted.
60         (IOSDeviceTest.test_expectations_ordering): Deleted.
61         * Scripts/webkitpy/port/ios_simulator.py:
62         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
63         flag to specify a runtime.
64         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
65         flag and then use the default runtime.
66
67 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
70         https://bugs.webkit.org/show_bug.cgi?id=174815
71
72         Reviewed by Carlos Alberto Lopez Perez.
73
74         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
75         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
76         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
77         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
78         think), probably because of a newer CMake version.
79
80         * CMakeLists.txt:
81         * TestWebKitAPI/CMakeLists.txt:
82         * TestWebKitAPI/PlatformGTK.cmake:
83
84 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
85
86         Fix BenchmarkRunner to only import selenium when needed
87         https://bugs.webkit.org/show_bug.cgi?id=174808
88
89         Reviewed by Stephanie Lewis.
90
91         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
92         (LinuxChromeDriver.launch_driver):
93         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
94         (LinuxFirefoxDriver.launch_driver):
95         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
96         (OSXChromeDriver.launch_driver):
97         (OSXChromeCanaryDriver.launch_driver):
98         (create_chrome_options):
99         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
100         (OSXFirefoxDriver.launch_driver):
101         (OSXFirefoxNightlyDriver.launch_driver):
102         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
103         (OSXSafariDriver.launch_driver):
104         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
105         (WebDriverBenchmarkRunner._run_one_test):
106
107 2017-07-23  Darin Adler  <darin@apple.com>
108
109         More NeverDestroyed and related cleanup
110         https://bugs.webkit.org/show_bug.cgi?id=174745
111
112         Reviewed by Alex Christensen.
113
114         * DumpRenderTree/JavaScriptThreading.cpp:
115         (javaScriptThreadsMutex): Use NeverDestroyed instead of
116         DEPRECATED_DEFINE_STATIC_LOCAL.
117         (javaScriptThreads): Ditto.
118
119 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
120
121         Subclass Benchmark Runner script for WebDriver support
122         https://bugs.webkit.org/show_bug.cgi?id=174390
123
124         Reviewed by Dewei Zhu, Stephanie Lewis.
125
126         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
127
128         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
129         (BenchmarkBuilder.__init__):
130         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
131         (BenchmarkRunner.__init__):
132         (BenchmarkRunner._find_plan_file):
133         (BenchmarkRunner._run_one_test.and):
134         (BenchmarkRunner.execute):
135         (BenchmarkRunner._get_result): Deleted.
136         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
137         (parse_args):
138         (start):
139         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
140         (WebDriverBenchmarkRunner):
141         (WebDriverBenchmarkRunner._get_result):
142         (WebDriverBenchmarkRunner._run_one_test):
143         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
144         (WebServerBenchmarkRunner):
145         (WebServerBenchmarkRunner.__init__):
146         (WebServerBenchmarkRunner._get_result):
147         (WebServerBenchmarkRunner._run_one_test):
148
149 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
150
151         Add BenchmarkRunner patches with WebDriver support for each testing plan
152         https://bugs.webkit.org/show_bug.cgi?id=174443
153
154         Reviewed by Dewei Zhu, Stephanie Lewis.
155
156         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
157         (BenchmarkBuilder.__enter__):
158         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
159         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
160         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
161         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
162         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
163         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
164         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
165         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
166         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
167         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
168         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
169         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
170         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
171         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
172         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
173         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
174         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
175         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
176         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
177         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
178         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
179         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
180         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
181         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
182         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
183         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
184         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
185         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
186         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
187         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
188         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
189         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
190         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
191
192 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
193
194         Add functions to autoinstaller needed for Benchmark Runner script
195         https://bugs.webkit.org/show_bug.cgi?id=174331
196
197         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
198
199         Adds autoinstaller functions to install selenium and webdriver binaries
200         which will be used by the browser driver part of Benchmark Runner.
201
202         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
203         (BrowserDriver.restore_env):
204         (BrowserDriver):
205         (BrowserDriver.get_webdriver_binary_path):
206         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
207         (LinuxChromeDriver.launch_driver):
208         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
209         (LinuxFirefoxDriver.launch_driver):
210         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
211         (OSXChromeDriver.launch_driver):
212         (OSXChromeCanaryDriver.launch_driver):
213         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
214         (OSXFirefoxDriver.launch_driver):
215         (OSXFirefoxNightlyDriver.launch_driver):
216         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
217         * Scripts/webkitpy/benchmark_runner/utils.py:
218         (get_driver_binary_path):
219         * Scripts/webkitpy/common/system/autoinstall.py:
220         (AutoInstaller._unzip):
221         * Scripts/webkitpy/thirdparty/__init__.py:
222         (AutoinstallImportHook.find_module):
223         (AutoinstallImportHook._install_selenium):
224         (AutoinstallImportHook):
225         (AutoinstallImportHook._install_chromedriver):
226         (AutoinstallImportHook._install_geckodriver):
227         (AutoinstallImportHook.get_latest_pypi_url):
228         (AutoinstallImportHook.install_binary):
229         (autoinstall_everything):
230         (get_driver_filename):
231         (get_os_info):
232
233 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
234
235         Add WebDriver support in browser driver part of BenchmarkRunner
236         https://bugs.webkit.org/show_bug.cgi?id=174445
237
238         Reviewed by Stephanie Lewis.
239
240         Adds a launch_driver function to each BrowserDriver subclass. This
241         function sets up the arguments for the webdriver and launches the
242         webdriver specific to that browser.
243
244         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
245         (BrowserDriver.launch_webdriver):
246         (BrowserDriver):
247         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
248         (LinuxBrowserDriver.launch_webdriver):
249         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
250         (LinuxChromeDriver.launch_url):
251         (LinuxChromeDriver):
252         (LinuxChromeDriver.launch_driver):
253         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
254         (EpiphanyBrowserDriver.launch_url):
255         (EpiphanyBrowserDriver):
256         (EpiphanyBrowserDriver.launch_driver):
257         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
258         (LinuxFirefoxDriver):
259         (LinuxFirefoxDriver.launch_url):
260         (LinuxFirefoxDriver.launch_driver):
261         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
262         (GTKMiniBrowserDriver.launch_url):
263         (GTKMiniBrowserDriver):
264         (GTKMiniBrowserDriver.launch_driver):
265         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
266         (OSXBrowserDriver._launch_webdriver):
267         (OSXBrowserDriver):
268         (OSXBrowserDriver._screen_size):
269         (OSXBrowserDriver._insert_url):
270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
271         (OSXChromeDriver):
272         (OSXChromeDriver.launch_url):
273         (OSXChromeDriver.launch_driver):
274         (OSXChromeCanaryDriver):
275         (OSXChromeCanaryDriver.launch_url):
276         (OSXChromeCanaryDriver.launch_driver):
277         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
278         (OSXFirefoxDriver):
279         (OSXFirefoxDriver.launch_url):
280         (OSXFirefoxDriver.launch_driver):
281         (OSXFirefoxNightlyDriver):
282         (OSXFirefoxNightlyDriver.launch_url):
283         (OSXFirefoxNightlyDriver.launch_driver):
284         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
285         (OSXSafariDriver.launch_driver):
286
287 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
288
289         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
290         https://bugs.webkit.org/show_bug.cgi?id=174793
291
292         Reviewed by Tim Horton.
293
294         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
295         down. Without r219765, this test will dereference null and crash.
296
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
299         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
300         (TEST):
301
302 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
303
304         [Win] Implement Authentication dialog in MiniBrowser
305         https://bugs.webkit.org/show_bug.cgi?id=174662
306
307         Reviewed by Alex Christensen.
308
309         * MiniBrowser/win/Common.cpp:
310         (CustomUserAgent):
311         (DisplayAuthDialog):
312         (AuthDialogProc):
313         * MiniBrowser/win/MiniBrowserLib.rc:
314         * MiniBrowser/win/MiniBrowserLibResource.h:
315         * MiniBrowser/win/ResourceLoadDelegate.cpp:
316         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
317
318 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
319
320         Handle case where line_numbers is None instead of an array of line numbers
321         https://bugs.webkit.org/show_bug.cgi?id=174775
322
323         Reviewed by Aakash Jain.
324
325         Added files set line_numbers to None in process_file.
326
327         * Scripts/webkitpy/style/filereader.py:
328         (TextFileReader.process_file): Handle case where line_number is set to None.
329         * Scripts/webkitpy/style/main_unittest.py:
330         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
331
332 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
333
334         [WPE] Add libepoxy to the Jhbuild moduleset
335         https://bugs.webkit.org/show_bug.cgi?id=174711
336
337         Reviewed by Carlos Alberto Lopez Perez.
338
339         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
340
341 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
342
343         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
344         https://bugs.webkit.org/show_bug.cgi?id=174780
345
346         Reviewed by Carlos Garcia Campos.
347
348         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
349         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
350         in case the eglplatform.h header doesn't provide that macro. This replicates
351         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
352
353 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
354
355         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
356         https://bugs.webkit.org/show_bug.cgi?id=174758
357
358         Reviewed by Dan Bernstein.
359
360         Migrate position-information-related unit tests from the PositionInformationTests suite to
361         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
362
363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
364         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
365         (TestWebKitAPI::checkElementTypeAndBoundingRect):
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
368         * TestWebKitAPI/cocoa/TestWKWebView.h:
369         * TestWebKitAPI/cocoa/TestWKWebView.mm:
370         (-[TestWKWebView activatedElementAtPosition:]):
371
372 2017-07-22  Chris Dumez  <cdumez@apple.com>
373
374         REGRESSION(r204565): WKObject is broken
375         https://bugs.webkit.org/show_bug.cgi?id=174736
376         <rdar://problem/33246169>
377
378         Reviewed by Dan Bernstein.
379
380         Add API test that used to crash.
381
382         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
383         (TestWebKitAPI::TEST):
384
385 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
386
387         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
388         https://bugs.webkit.org/show_bug.cgi?id=174705
389
390         Reviewed by Mark Lam.
391
392         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
393         (TestWebKitAPI::testThreadGroup):
394         (TestWebKitAPI::TEST):
395
396 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
397
398         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
399         https://bugs.webkit.org/show_bug.cgi?id=174724
400
401         Reviewed by Aakash Jain.
402
403         * Scripts/webkitpy/port/ios_simulator.py:
404         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
405         simulator. Errors here should be treated the same as no simulators found.
406
407 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
408
409         [CMake] Add an option to stop build after generating project files
410         https://bugs.webkit.org/show_bug.cgi?id=174664
411
412         Reviewed by Konstantin Tokarev.
413
414         Add "--generate-project-only" to stop build after generating project files.
415
416         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
417         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
418         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
419         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
420         (isGenerateProjectOnly): ditto
421
422 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
423
424         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
425         https://bugs.webkit.org/show_bug.cgi?id=174501
426
427         Reviewed by Darin Adler.
428
429         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
430         (TestWebKitAPI::TEST):
431
432 2017-07-20  David Quesada  <david_quesada@apple.com>
433
434         Add SPI to notify WKNavigationDelegate about client redirects
435         https://bugs.webkit.org/show_bug.cgi?id=174680
436         rdar://problem/33184886
437
438         Reviewed by Brady Eidson.
439
440         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
441         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
442         (TEST):
443         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
444
445 2017-07-20  Brady Eidson  <beidson@apple.com>
446
447         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
448         https://bugs.webkit.org/show_bug.cgi?id=174685
449
450         Reviewed by Andy Estes.
451
452         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
453         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
454
455 2017-07-20  Brady Eidson  <beidson@apple.com>
456
457         Deprecate WebIconDatabase in WebKitLegacy/mac.
458         https://bugs.webkit.org/show_bug.cgi?id=174607
459
460         Reviewed by Alex Christensen.
461
462         * DumpRenderTree/mac/TestRunnerMac.mm:
463
464 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
465
466         lint-test-expectations should be run during style checking
467         https://bugs.webkit.org/show_bug.cgi?id=173559
468         <rdar://problem/32854941>
469
470         Reviewed by Aakash Jain.
471
472         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
473         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
474         prevents identifying errors on specific lines in a file.
475         * Scripts/webkitpy/style/main_unittest.py:
476         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
477         case where a linter error is in the file modified, but the line modified is not related to
478         the linter error.
479
480 2017-07-20  Brady Eidson  <beidson@apple.com>
481
482         Remove WebIconDatabase from WebKitLegacy/win.
483         https://bugs.webkit.org/show_bug.cgi?id=174608
484
485         Reviewed by Alex Christensen.
486
487         * DumpRenderTree/win/DumpRenderTree.cpp:
488         (main):
489         * DumpRenderTree/win/TestRunnerWin.cpp:
490         (TestRunner::setIconDatabaseEnabled):
491
492 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
493
494         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
495         https://bugs.webkit.org/show_bug.cgi?id=174671
496
497         Reviewed by Carlos Garcia Campos.
498
499         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
500         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
501         priority for this source in order to have it dispatched on the same
502         priority as the other WebKit-controlled GSource objects.
503
504 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
505
506         lint-test-expectations should be run during style checking
507         https://bugs.webkit.org/show_bug.cgi?id=173559
508         <rdar://problem/32854941>
509
510         Reviewed by Daniel Bates.
511
512         Follow up fix addressing style and a few minor bugs.
513
514         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
515         (TestExpectationParser.__init__): Use lambda x: x instead of str
516         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
517         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
518         reduce the calls of _shorten_filename, fix minor bug in appending the current
519         expectation's line number instead of the previous ones, clarify treatment of None
520         in file-to-line-number mapping.
521         (TestExpectations._report_warnings): Collapse call.
522         * Scripts/webkitpy/style/checkers/test_expectations.py:
523         (TestExpectationsChecker.lint_test_expectations):
524         * Scripts/webkitpy/style/filereader.py: Re-write comment.
525         (TextFileReader.process_file): Add comment explaining treatment of None in
526         file-to-line-number mapping.
527         (TextFileReader.delete_file): Collapse call.
528
529 2017-07-19  Chris Dumez  <cdumez@apple.com>
530
531         Unreviewed attempt to fix API test failure after r219663.
532
533         The test was hard-coding an exception string and the string has changed slightly
534         in r219663.
535
536         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
537         (TEST):
538
539 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
540
541         Don't write file URLs to iOS Pasteboard
542         https://bugs.webkit.org/show_bug.cgi?id=174647
543         <rdar://problem/33199730>
544
545         Reviewed by Wenson Hsieh.
546
547         Updating tests to reflect the lack of file URLs for images.
548
549         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
550         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
551         (checkEstimatedSize):
552         (TestWebKitAPI::TEST):
553
554 2017-07-19  Brady Eidson  <beidson@apple.com>
555
556         iBooks sometimes crashes when closing a book.
557         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
558
559         Reviewed by Oliver Hunt.
560
561         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
562         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
563         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
564         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
565         (TestWebKitAPI::TEST):
566
567         Add a "spin the runloop X number of times" utility:
568         * TestWebKitAPI/Utilities.h:
569         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
570         (TestWebKitAPI::Util::spinRunLoop):
571
572 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
573
574         lint-test-expectations should be run during style checking
575         https://bugs.webkit.org/show_bug.cgi?id=173559
576         <rdar://problem/32854941>
577
578         Reviewed by David Kilzer.
579
580         Running the test expectation linter requires reading both files and lines not in the
581         patch because, for example, deletion of a test can cause a lint failure even though
582         no test expectations where modified. This means that the linter will occasionally warn
583         about lines which were not changed in a given patch but whose error is related to a
584         change made in that patch.
585
586         * Scripts/webkitpy/common/system/filesystem_mock.py:
587         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
588         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
589         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
590         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
591         content, description of the error and the name of the associated test.
592         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
593         (TestExpectationParser.__init__): Pass shorten_filename function to
594         TestExpectationsParser to add a deleted file to the related_files dictionary.
595         (TestExpectationParser._check_test_exists): If the test does not exist, add the
596         missing path to the related_files dictionary.
597         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
598         files and line numbers related to this test expectation line. This will allow
599         tracking linter errors in the style checker occurring across multiple files.
600         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
601         lines to related_files dictionary.
602         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
603         (TestExpectations._report_warnings): Construct warning object instead of string
604         when adding to warnings list.
605         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
606         clean-up log.
607         * Scripts/webkitpy/style/checker.py:
608         (ProcessorBase.do_association_check): Add required function for processor classes.
609         (StyleProcessor):
610         (StyleProcessor.do_association_check): Run the TestExpectations linter when
611         checking for errors between associated files.
612         * Scripts/webkitpy/style/checkers/test_expectations.py:
613         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
614         (TestExpectationsChecker):
615         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
616         of modified files, the current working directory and the host, determine if the linter
617         warning is associated with the changes.
618         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
619         style checker.
620         * Scripts/webkitpy/style/filereader.py:
621         (TextFileReader):
622         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
623         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
624         (TextFileReader.process_file): Track both the number of files changed and which lines
625         in those files were changed.
626         (TextFileReader.do_association_check): Run the processor's association check on all
627         modified or deleted files processed by TextFileReader.
628         (TextFileReader.delete_file): Track deleted files in _files dictionary.
629         (TextFileReader.count_delete_only_file): Deleted.
630         * Scripts/webkitpy/style/filereader_unittest.py:
631         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
632         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
633         * Scripts/webkitpy/style/main.py:
634         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
635         explicitly run the association check on the file reader.
636         * Scripts/webkitpy/style/main_unittest.py:
637         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
638         embedded in the style checker.
639         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
640         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
641         construct the TextFileReader object with a StyleProcessor used to run style checks on
642         specific files.
643         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
644         testing the test expectation linter inside the style checker. This host must contain a
645         mock file system with the basic structure of test expectations.
646         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
647         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
648         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
649         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
650         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
651         * Scripts/webkitpy/style/patchreader.py:
652         (PatchReader.check): Specify which file was deleted, run the association check.
653         * Scripts/webkitpy/style/patchreader_unittest.py:
654         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
655         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
656         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
657
658 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
659
660         [WTF] Implement WTF::ThreadGroup
661         https://bugs.webkit.org/show_bug.cgi?id=174081
662
663         Reviewed by Mark Lam.
664
665         Add WTF::ThreadGroup tests.
666
667         * TestWebKitAPI/CMakeLists.txt:
668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
669         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
670         (TestWebKitAPI::testThreadGroup):
671         (TestWebKitAPI::TEST):
672
673 2017-07-18  Andy Estes  <aestes@apple.com>
674
675         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
676         https://bugs.webkit.org/show_bug.cgi?id=174631
677
678         Reviewed by Tim Horton.
679
680         * DumpRenderTree/mac/Configurations/Base.xcconfig:
681         * MiniBrowser/Configurations/Base.xcconfig:
682         * MobileMiniBrowser/Configurations/Base.xcconfig:
683         * TestWebKitAPI/Configurations/Base.xcconfig:
684         * WebKitTestRunner/Configurations/Base.xcconfig:
685
686 2017-07-18  Andy Estes  <aestes@apple.com>
687
688         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
689         https://bugs.webkit.org/show_bug.cgi?id=174631
690
691         Reviewed by Sam Weinig.
692
693         * DumpRenderTree/mac/Configurations/Base.xcconfig:
694         * MiniBrowser/Configurations/Base.xcconfig:
695         * MobileMiniBrowser/Configurations/Base.xcconfig:
696         * TestWebKitAPI/Configurations/Base.xcconfig:
697         * WebKitTestRunner/Configurations/Base.xcconfig:
698
699 2017-07-18  Daniel Bates  <dabates@apple.com>
700
701         lldb: Add type summary for StringView
702         https://bugs.webkit.org/show_bug.cgi?id=174637
703
704         Reviewed by Sam Weinig.
705
706         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
707         StringView object will print output that has the form:
708
709             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
710               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
711               m_length = 2
712               m_is8Bit = true
713               m_underlyingString = 0x0000614000000a90
714             }
715
716         * lldb/lldb_webkit.py:
717         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
718         (WTFStringView_SummaryProvider):
719         (WTFStringViewProvider):
720         (WTFStringViewProvider.__init__):
721         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
722         (WTFStringViewProvider.get_length): Access field StringView.m_length.
723         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
724         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
725
726 2017-07-18  Andy Estes  <aestes@apple.com>
727
728         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
729         https://bugs.webkit.org/show_bug.cgi?id=174631
730
731         Reviewed by Dan Bernstein.
732
733         * DumpRenderTree/mac/Configurations/Base.xcconfig:
734         * MiniBrowser/Configurations/Base.xcconfig:
735         * MobileMiniBrowser/Configurations/Base.xcconfig:
736         * TestWebKitAPI/Configurations/Base.xcconfig:
737         * WebKitTestRunner/Configurations/Base.xcconfig:
738
739 2017-07-18  Devin Rousso  <drousso@apple.com>
740
741         Web Inspector: Add memoryCost to Inspector Protocol objects
742         https://bugs.webkit.org/show_bug.cgi?id=174478
743
744         Reviewed by Joseph Pecoraro.
745
746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
747         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
748         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
749         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
750         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
751         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
752         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
753         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
754         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
755         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
756         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
757         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
758         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
759         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
760         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
761         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
762         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
763
764 2017-07-18  Andy Estes  <aestes@apple.com>
765
766         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
767         https://bugs.webkit.org/show_bug.cgi?id=174631
768
769         Reviewed by Darin Adler.
770
771         * DumpRenderTree/mac/Configurations/Base.xcconfig:
772         * MiniBrowser/Configurations/Base.xcconfig:
773         * MobileMiniBrowser/Configurations/Base.xcconfig:
774         * TestWebKitAPI/Configurations/Base.xcconfig:
775         * WebKitTestRunner/Configurations/Base.xcconfig:
776
777 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
778
779         Unreviewed, fix the iOS build.
780
781         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
782
783         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
784         (TestWebKitAPI::TEST):
785
786 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
787
788         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
789         https://bugs.webkit.org/show_bug.cgi?id=174585
790         <rdar://problem/33302541>
791
792         Reviewed by Tim Horton.
793
794         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
795         being dragged when initiating a drag.
796
797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
798         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
799         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
800         (TestWebKitAPI::TEST):
801         * TestWebKitAPI/cocoa/TestWKWebView.h:
802
803         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
804
805         * TestWebKitAPI/cocoa/TestWKWebView.mm:
806         (-[TestWKWebView synchronouslyLoadHTMLString:]):
807
808 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
809
810         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
811         https://bugs.webkit.org/show_bug.cgi?id=174547
812
813         Reviewed by Alex Christensen.
814
815         * DumpRenderTree/PlatformWin.cmake:
816         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
817
818 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
819
820         Update style checker to deal with "final"
821         https://bugs.webkit.org/show_bug.cgi?id=174528
822
823         Reviewed by Alex Christensen.
824         
825         check-webkit-style shouldn't complain about an open brace to start a
826         line after a function definition with "final" or "const final".
827
828         * Scripts/webkitpy/style/checkers/cpp.py:
829         (check_braces):
830         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
831         (CppStyleTest.test_brace_at_begin_of_line):
832
833 2017-07-17  Alex Christensen  <achristensen@webkit.org>
834
835         Modernize content extension code
836         https://bugs.webkit.org/show_bug.cgi?id=174588
837
838         Reviewed by Sam Weinig.
839
840         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
841         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
842         (TestWebKitAPI::testRequest):
843         (TestWebKitAPI::makeBackend):
844         (TestWebKitAPI::TEST_F):
845
846 2017-07-17  Brady Eidson  <beidson@apple.com>
847
848         WKHTTPCookieStore observing only works on the default cookie store.
849         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
850
851         Reviewed by Sam Weinig.
852
853         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
854         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
855           called for the default store, a non-persistent store, and a custom store.
856         (TEST):
857
858 2017-07-16  Sam Weinig  <sam@webkit.org>
859
860         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
861         https://bugs.webkit.org/show_bug.cgi?id=174575
862
863         Reviewed by Brady Eidson.
864
865         * Scripts/svn-create-patch:
866         (findModificationType):
867         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
868         default value of "unknown".
869
870         (generateFileList):
871         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
872         for untracked, which matches our old behavior.
873
874 2017-07-17  Charlie Turner  <cturner@igalia.com>
875
876         Add some missing build dependencies on Fedora
877         https://bugs.webkit.org/show_bug.cgi?id=174578
878
879         Unreviewed dependency update.
880
881         * gtk/install-dependencies:
882
883 2017-07-16  Brady Eidson  <beidson@apple.com>
884
885         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
886         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
887
888         Reviewed by Tim Horton.
889
890         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
891         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
892         (TEST):
893
894 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
895
896         [GTK] Sort inspector GResource manifest to ensure reproducible builds
897         https://bugs.webkit.org/show_bug.cgi?id=174540
898
899         Reviewed by Michael Catanzaro.
900
901         * gtk/generate-inspector-gresource-manifest.py:
902         (get_filenames): sort list of input files
903
904 2017-07-15  Brady Eidson  <beidson@apple.com>
905
906         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
907         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
908
909         Reviewed by Tim Horton.
910
911         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
912         (TEST): Make this test more reliable by clearing everything beforehand.
913
914 2017-07-15  David Kilzer  <ddkilzer@apple.com>
915
916         Make it possible to extend check-webkit-style with Apple-internal checkers
917         <https://webkit.org/b/174464>
918         <rdar://problem/25564402>
919
920         Reviewed by Darin Adler.
921
922         * Scripts/webkitpy/style/checker.py: Import apple_additions.
923         (_all_categories): Add categories from apple_additions() if it
924         exists.
925         (CheckerDispatcher._create_checker): Create python checker
926         from apple_additions() if it exists.
927
928 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
929
930         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
931         https://bugs.webkit.org/show_bug.cgi?id=174539
932         <rdar://problem/33307395>
933
934         Reviewed by Darin Adler.
935
936         Adds a new unit test suite to cover action sheet popover presentation.
937
938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
939         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
940         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
941         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
942
943         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
944
945         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
946         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
947
948         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
949
950         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
951         (TestWebKitAPI::TEST):
952
953 2017-07-15  Sam Weinig  <sam@webkit.org>
954
955         [Scripts] Make svn-create-patch work better when called in sub directories
956         https://bugs.webkit.org/show_bug.cgi?id=174551
957
958         Reviewed by Darin Adler.
959
960         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
961           by ensuring that the prefix is applied as is done in generateDiff.
962         - Silence output of explanatory lines from svn stat (" > move to ...")
963           that show up in STDERR when running svn-create-patch.
964         - Add verbose logging that I found useful while debugging this issue.
965
966         * Scripts/svn-create-patch:
967         (findBaseUrl):
968         (findMimeType):
969         (findSourceFileAndRevision):
970         (generateDiff):
971         (generateFileList):
972         (manufacturePatchForAdditionWithHistory):
973
974 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
975
976         Unreviewed build fix after r219537.
977
978         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
979
980 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
981
982         Add iOS 11 SPI
983         https://bugs.webkit.org/show_bug.cgi?id=174430
984         <rdar://problem/33269288>
985
986         Reviewed by Tim Horton.
987
988         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
989         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
990         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
991
992 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
993
994         Failing to install on iPad simulators
995         https://bugs.webkit.org/show_bug.cgi?id=174532
996         <rdar://problem/33328347>
997
998         Reviewed by Stephanie Lewis.
999
1000         * Scripts/webkitpy/xcode/simulated_device.py:
1001         (SimulatedDevice.install_app): Place install command in retry try-except block.
1002
1003 2017-07-14  Jeff Miller  <jeffm@apple.com>
1004
1005         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1006         https://bugs.webkit.org/show_bug.cgi?id=174524
1007
1008         Reviewed by Sam Weinig.
1009
1010         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1011         (TEST):
1012         Renamed TestParameter to TestParameter1.
1013         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1014
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1016         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1017         Observe changes for two bundle parameters.
1018
1019         (-[BundleParametersPlugIn dealloc]):
1020         Remove observers for two bundle parameters.
1021
1022 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1023
1024         Unreviewed, rolling out r219510.
1025         https://bugs.webkit.org/show_bug.cgi?id=174525
1026
1027         Need to revert length() == 0 check for null string (Requested
1028         by yusukesuzuki on #webkit).
1029
1030         Reverted changeset:
1031
1032         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1033         static string if StringImpl is static"
1034         https://bugs.webkit.org/show_bug.cgi?id=174501
1035         http://trac.webkit.org/changeset/219510
1036
1037 2017-07-14  Jer Noble  <jer.noble@apple.com>
1038
1039         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1040         https://bugs.webkit.org/show_bug.cgi?id=174514
1041
1042         Reviewed by Sam Weinig.
1043
1044         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1045         (TestWebKitAPI::TEST_F):
1046
1047 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1048
1049         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1050         https://bugs.webkit.org/show_bug.cgi?id=174501
1051
1052         Reviewed by Darin Adler.
1053
1054         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1055         (TestWebKitAPI::TEST):
1056
1057 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1058
1059         Bring mac expectations in-line with other platforms
1060         https://bugs.webkit.org/show_bug.cgi?id=174472
1061         <rdar://problem/33297388>
1062
1063         Reviewed by David Kilzer.
1064
1065         The override order for Mac test expectations does not conform to the pattern used by iOS,
1066         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1067
1068             platform/mac-wk2
1069             platform/wk2
1070             platform/mac-elcapitan
1071             platform/mac-sierra
1072             generic
1073
1074         After this change, El Capitan's baseline search path looks like this:
1075
1076             platform/mac-sierra-wk2
1077             platform/mac-sierra
1078             platform/mac-wk2
1079             platform/wk2
1080             generic
1081
1082         * Scripts/webkitpy/port/mac.py:
1083         (MacPort.__init__): If a specific version is specified in the port name, use that
1084         as the os version.
1085         (MacPort.default_baseline_search_path): Expectation search paths should work the
1086         same way they do on other ports. Port + version overrides port, port overrides generic
1087         and wk1/wk2 should override expectations for the two combined.
1088         * Scripts/webkitpy/port/mac_unittest.py:
1089         (MacTest.test_tests_for_other_platforms): Deleted.
1090         (MacTest._assert_search_path): Deleted.
1091         (MacTest.test_baseline_search_path): Deleted.
1092         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1093         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1094         (test_rebaseline_test_and_print_scm_changes): Ditto.
1095         (test_rebaseline_and_copy_test): Ditto.
1096         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1097         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1098         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1099
1100 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1101
1102         Fix style checker unit test
1103
1104         Unreviewed WebKit2 => WebKit fixup.
1105
1106         * Scripts/webkitpy/style/checker_unittest.py:
1107         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1108
1109 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1110
1111         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1112
1113         Unreviewed build fix.
1114
1115         r219492 missed one hunk from its partial revert of r219489.
1116         This patch reverts that hunk.
1117
1118         * TestWebKitAPI/CMakeLists.txt:
1119
1120 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1121
1122         Use the old WebKit/WebKit2 targets for CMake builds.
1123
1124         Unreviewed build fix.
1125
1126         We can update the target names to match the Framework names in a future patch.
1127         This is a partial revert of r219489.
1128
1129         * TestWebKitAPI/CMakeLists.txt:
1130         WebKitLegacy => WebKit
1131         WebKit => WebKit2
1132
1133 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1134
1135         Fix TestWebKit API.
1136         https://bugs.webkit.org/show_bug.cgi?id=174164
1137         rdar://problem/33137595
1138
1139         Reviewed by Dan Bernstein.
1140
1141         * TestWebKitAPI/CMakeLists.txt:
1142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1143         * TestWebKitAPI/PlatformGTK.cmake:
1144
1145 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1146
1147         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1148         https://bugs.webkit.org/show_bug.cgi?id=174164
1149         rdar://problem/33137595
1150
1151         Reviewed by Dan Bernstein.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1154         (ShouldBuildTest):
1155         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1156         * Scripts/build-webkit:
1157         * Scripts/do-file-rename:
1158         * Scripts/do-webcore-rename:
1159         * Scripts/update-webkit-localizable-strings:
1160         * Scripts/webkitpy/common/config/watchlist:
1161         * Scripts/webkitpy/style/checker.py:
1162         * Scripts/webkitpy/style/checkers/featuredefines.py:
1163         * gtk/make-dist.py:
1164         (ensure_version_if_possible):
1165         * gtk/manifest.txt.in:
1166
1167 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1168
1169         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1170         https://bugs.webkit.org/show_bug.cgi?id=174162
1171         rdar://problem/33137594
1172
1173         Reviewed by Dan Bernstein.
1174
1175         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1178         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1179         * EWSTools/configure-clang-linux.sh:
1180         * Scripts/build-webkit:
1181         * Scripts/do-file-rename:
1182         * Scripts/do-webcore-rename:
1183         * Scripts/update-webkit-localizable-strings:
1184         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1185         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1186         * Scripts/webkitpy/style/checkers/featuredefines.py:
1187         * gtk/manifest.txt.in:
1188
1189 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1190
1191         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1192         https://bugs.webkit.org/show_bug.cgi?id=174438
1193         <rdar://problem/33277112>
1194
1195         Reviewed by Aakash Jain.
1196
1197         Given a patch, this will convert the changes from the path to the new directory structure.
1198
1199         * Scripts/rebase-patch-after-webkit-move: Added.
1200         (append_source): Append 'Source' to the provided path.
1201         (is_editable_line): Return true if a line the script expects to modify.
1202         (needs_rebase): Return if a line needs to be rebased based on it's content.
1203         (rebase_line): Rebase the provided line.
1204         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1205         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1206         were provided.
1207
1208 2017-07-12  Nan Wang  <n_wang@apple.com>
1209
1210         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1211         https://bugs.webkit.org/show_bug.cgi?id=174393
1212         <rdar://problem/33248006>
1213
1214         Reviewed by Chris Fleizach.
1215
1216         * DumpRenderTree/AccessibilityUIElement.cpp:
1217         (textMarkerRangeMatchesTextNearMarkersCallback):
1218         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1219         (AccessibilityUIElement::getJSClass):
1220         * DumpRenderTree/AccessibilityUIElement.h:
1221         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1222         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1223         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1224         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1227         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1228         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1229
1230 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1231
1232         Unreviewed, rolling out r219409.
1233
1234         The revision caused the Windows builds to fail.
1235
1236         Reverted changeset:
1237
1238         "AX: [iOS] Implement a way to retrieve a text marker range
1239         with desired text that is closest to a position"
1240         https://bugs.webkit.org/show_bug.cgi?id=174393
1241         http://trac.webkit.org/changeset/219409
1242
1243 2017-07-12  Nan Wang  <n_wang@apple.com>
1244
1245         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1246         https://bugs.webkit.org/show_bug.cgi?id=174393
1247         <rdar://problem/33248006>
1248
1249         Reviewed by Chris Fleizach.
1250
1251         * DumpRenderTree/AccessibilityUIElement.cpp:
1252         (textMarkerRangeMatchesTextNearMarkersCallback):
1253         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1254         (AccessibilityUIElement::getJSClass):
1255         * DumpRenderTree/AccessibilityUIElement.h:
1256         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1257         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1258         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1259         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1260         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1261         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1262         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1263         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1264
1265 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1266
1267         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1268         https://bugs.webkit.org/show_bug.cgi?id=174197
1269
1270         Reviewed by Darin Adler.
1271
1272         This bit me the first time I tried to submit a patch to WebKit, and still I have
1273         to manually edit the ChangeLog every time I use the script.
1274
1275         This generates a more convenient and standard ChangeLog entry.
1276
1277         * Scripts/prepare-ChangeLog:
1278         (generateNewChangeLogs):
1279
1280 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1281
1282         Unreviewed, rolling out r219401.
1283
1284         This revision rolled out the previous patch, but after talking
1285         with reviewer, a rebaseline is what was needed.Rolling back in
1286         before rebaseline.
1287
1288         Reverted changeset:
1289
1290         "Unreviewed, rolling out r219379."
1291         https://bugs.webkit.org/show_bug.cgi?id=174400
1292         http://trac.webkit.org/changeset/219401
1293
1294 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1295
1296         Unreviewed, rolling out r219379.
1297
1298         This revision caused a consistent failure in the test
1299         fast/dom/Window/property-access-on-cached-window-after-frame-
1300         removed.html.
1301
1302         Reverted changeset:
1303
1304         "Remove NAVIGATOR_HWCONCURRENCY"
1305         https://bugs.webkit.org/show_bug.cgi?id=174400
1306         http://trac.webkit.org/changeset/219379
1307
1308 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1309
1310         [WPE] Use libepoxy
1311         https://bugs.webkit.org/show_bug.cgi?id=172104
1312
1313         Reviewed by Michael Catanzaro.
1314
1315         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1316         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1317
1318 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1319
1320         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1321         https://bugs.webkit.org/show_bug.cgi?id=174363
1322
1323         Reviewed by Michael Catanzaro.
1324
1325         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1326         between the GTK+ and WPE port. There's no reason for the two ports to apply
1327         different patches over same versions of GStreamer releases.
1328
1329         This aligns the two ports on this specific issue. Next we'll look into
1330         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1331         to keep these patches in a single place, avoiding duplicate files.
1332
1333         * gtk/jhbuild.modules:
1334         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1335         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1336         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1337         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1338
1339 2017-07-11  Dean Jackson  <dino@apple.com>
1340
1341         Remove NAVIGATOR_HWCONCURRENCY
1342         https://bugs.webkit.org/show_bug.cgi?id=174400
1343
1344         Reviewed by Sam Weinig.
1345
1346         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1347
1348 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1349
1350         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1351         https://bugs.webkit.org/show_bug.cgi?id=174239
1352
1353         Reviewed by Brady Eidson.
1354
1355         Create windows with specific features set and make sure those are properly reflected in the
1356         WKWindowFeatures object.
1357
1358         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1359         (resetToConsistentState):
1360         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1361         (TEST):
1362
1363 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1364
1365         Do not duplicate files when deleting directories with svn 1.9
1366         https://bugs.webkit.org/show_bug.cgi?id=174339
1367         <rdar://problem/33226781>
1368
1369         Reviewed by David Kilzer.
1370
1371         * Scripts/svn-create-patch:
1372         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1373         (generateFileList): Determine which files are deleted because they are part of a
1374         directory being deleted.
1375
1376 2017-07-11  Dean Jackson  <dino@apple.com>
1377
1378         Rolling out r219372.
1379
1380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1381
1382 2017-07-11  Dean Jackson  <dino@apple.com>
1383
1384         Remove NAVIGATOR_HWCONCURRENCY
1385         https://bugs.webkit.org/show_bug.cgi?id=174400
1386
1387         Reviewed by Sam Weinig.
1388
1389         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1390
1391 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1392
1393         Teach build workers to fetch archives from S3.
1394         https://bugs.webkit.org/show_bug.cgi?id=174384
1395
1396         Reviewed by Aakash Jain.
1397
1398         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1399         (DownloadBuiltProduct):
1400
1401 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1402
1403         Configure buildbot to transfer all archives to S3.
1404         Previously this was Mac only, but it's time to expand!
1405         https://bugs.webkit.org/show_bug.cgi?id=174378
1406         
1407         Reviewed by Aakash Jain.
1408
1409         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1410         (BuildFactory.__init__):
1411
1412 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1413
1414         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1415         https://bugs.webkit.org/show_bug.cgi?id=174350
1416
1417         Reviewed by Xabier Rodriguez-Calvar.
1418
1419         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1420         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1421         patches are removed. The patches for gst-plugins-good are updated, removing
1422         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1423         rtpbin elements that will help with the EMEv3 development.
1424
1425         * wpe/jhbuild.modules:
1426         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1427         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1428         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1429         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1430         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1431         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1432         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1433         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1434         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1435
1436 2017-07-10  John Wilander  <wilander@apple.com>
1437
1438         Resource Load Statistics: Prune statistics in orders of importance
1439         https://bugs.webkit.org/show_bug.cgi?id=174215
1440         <rdar://problem/33164403>
1441
1442         Reviewed by Chris Dumez.
1443
1444         Nest infrastructure. Adds these functions:
1445         1. testRunner.setStatisticsLastSeen()
1446         2. setStatisticsMaxStatisticsEntries()
1447         3. setStatisticsPruneEntriesDownTo()
1448
1449         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1450         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1451         (WTR::TestRunner::setStatisticsLastSeen):
1452         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1453         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1455         * WebKitTestRunner/TestController.cpp:
1456         (WTR::TestController::setStatisticsLastSeen):
1457         (WTR::TestController::setMaxStatisticsEntries):
1458         (WTR::TestController::setPruneEntriesDownTo):
1459         * WebKitTestRunner/TestController.h:
1460         * WebKitTestRunner/TestInvocation.cpp:
1461         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1462         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1463         (WTR::TestController::setStatisticsLastSeen):
1464         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1465         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1466
1467 2017-07-03  Brian Burg  <bburg@apple.com>
1468
1469         Web Replay: remove some unused code
1470         https://bugs.webkit.org/show_bug.cgi?id=173903
1471
1472         Rubber-stamped by Joseph Pecoraro.
1473
1474         * Scripts/run-input-generator-tests: Removed.
1475         * Scripts/webkitpy/replay/__init__.py: Removed.
1476         * Scripts/webkitpy/replay/main.py: Removed.
1477
1478 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1479
1480         [WPE] Fix layout test baseline and TestExpectations hierarchy
1481         https://bugs.webkit.org/show_bug.cgi?id=174092
1482
1483         Reviewed by Michael Catanzaro.
1484
1485         Like for the GTK+ port, override the default_baseline_search_path() and
1486         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1487         Both methods operate on a short list of search paths that defaults to 'wpe' and
1488         'wk2', along with any other user-specified platform directory.
1489
1490         The test_expectations_file_position() method is overridden for testing purposes,
1491         and relevant unit tests are added.
1492
1493         * Scripts/webkitpy/port/wpe.py:
1494         (WPEPort._search_paths):
1495         (WPEPort):
1496         (WPEPort.default_baseline_search_path):
1497         (WPEPort._port_specific_expectations_files):
1498         (WPEPort.test_expectations_file_position):
1499         * Scripts/webkitpy/port/wpe_unittest.py:
1500         (WPEPortTest.test_default_baseline_search_path):
1501         (WPEPortTest):
1502         (WPEPortTest.test_port_specific_expectations_files):
1503
1504 2017-07-10  Chris Dumez  <cdumez@apple.com>
1505
1506         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1507         https://bugs.webkit.org/show_bug.cgi?id=174301
1508
1509         Reviewed by Brent Fulgham.
1510
1511         Rename some of the testRunner API for clarity and to better match what it calls
1512         internally.
1513
1514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1516         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1517         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1519         * WebKitTestRunner/TestController.cpp:
1520         (WTR::TestController::statisticsUpdateCookiePartitioning):
1521         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1522         * WebKitTestRunner/TestController.h:
1523         * WebKitTestRunner/TestInvocation.cpp:
1524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1526         (WTR::TestController::statisticsUpdateCookiePartitioning):
1527         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1528
1529 2017-07-10  Charlie Turner  <cturner@igalia.com>
1530
1531         [GStreamer] Live twitch.tv videos do not play
1532         https://bugs.webkit.org/show_bug.cgi?id=174222
1533
1534         Reviewed by Michael Catanzaro.
1535
1536         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1537         fixes videos not playing on twitch.tv.
1538
1539         * gtk/jhbuild.modules:
1540
1541 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1542
1543         Add WebGL2 configuration option to build-webkit
1544         https://bugs.webkit.org/show_bug.cgi?id=174251
1545
1546         Reviewed by Michael Catanzaro.
1547
1548         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1549         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1550         is marked as enabled for the Apple Cocoa ports.
1551
1552 2017-07-08  Chris Dumez  <cdumez@apple.com>
1553
1554         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1555         https://bugs.webkit.org/show_bug.cgi?id=174290
1556
1557         Reviewed by Brent Fulgham.
1558
1559         Rename testRunner API to match the new internal API names.
1560
1561         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1563         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1564         (WTR::TestRunner::statisticsSubmitTelemetry):
1565         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1566         * WebKitTestRunner/TestController.cpp:
1567         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1568         (WTR::TestController::statisticsSubmitTelemetry):
1569         * WebKitTestRunner/TestController.h:
1570         * WebKitTestRunner/TestInvocation.cpp:
1571         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1572         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1573         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1574         (WTR::TestController::statisticsSubmitTelemetry):
1575
1576 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1577
1578         Drop NOSNIFF compile flag
1579         https://bugs.webkit.org/show_bug.cgi?id=174289
1580
1581         Reviewed by Michael Catanzaro.
1582
1583         * Scripts/webkitperl/FeatureList.pm:
1584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1585
1586 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1587
1588         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1589         https://bugs.webkit.org/show_bug.cgi?id=174219
1590         <rdar://problem/32083177>
1591
1592         Reviewed by Ryosuke Niwa.
1593
1594         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1595         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1596         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1597         place.
1598
1599         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1600         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1601         no action is taken when dropping.
1602
1603         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1604         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1605         (TestWebKitAPI::TEST):
1606         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1607         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1608         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1609         (-[MockDragDropSession allowsMoveOperation]):
1610         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1611         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1612         (-[DataInteractionSimulator initWithWebView:]):
1613         (-[DataInteractionSimulator runFrom:to:]):
1614         (-[DataInteractionSimulator _advanceProgress]):
1615         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1616         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1617         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1618
1619 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1620
1621         Unreviewed, rolling out r219238, r219239, and r219241.
1622         https://bugs.webkit.org/show_bug.cgi?id=174265
1623
1624         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1625         (Requested by yusukesuzuki on #webkit).
1626
1627         Reverted changesets:
1628
1629         "[WTF] Implement WTF::ThreadGroup"
1630         https://bugs.webkit.org/show_bug.cgi?id=174081
1631         http://trac.webkit.org/changeset/219238
1632
1633         "Unreviewed, build fix after r219238"
1634         https://bugs.webkit.org/show_bug.cgi?id=174081
1635         http://trac.webkit.org/changeset/219239
1636
1637         "Unreviewed, CLoop build fix after r219238"
1638         https://bugs.webkit.org/show_bug.cgi?id=174081
1639         http://trac.webkit.org/changeset/219241
1640
1641 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1642
1643         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1644         https://bugs.webkit.org/show_bug.cgi?id=174250
1645
1646         Reviewed by Carlos Alberto Lopez Perez.
1647
1648         * Scripts/webkitperl/FeatureList.pm:
1649
1650 2017-07-07  Charlie Turner  <cturner@igalia.com>
1651         [GStreamer] vid.me videos do not play
1652         https://bugs.webkit.org/show_bug.cgi?id=172240
1653
1654         Reviewed by Xabier Rodriguez-Calvar.
1655
1656         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1657         have the existing libsoup build against GNOME to avoid header drift
1658         against GStreamer's linked Soup library.
1659
1660         * gtk/jhbuild.modules:
1661
1662 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1663
1664         Write a support script to enable buildbot to upload to S3
1665         https://bugs.webkit.org/show_bug.cgi?id=174196
1666         
1667         Reviewed by Stephanie Lewis.
1668
1669         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1670         (uploadToS3):
1671         (archiveExists):
1672
1673 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1674
1675         Enabling uploading archives to S3.
1676         https://bugs.webkit.org/show_bug.cgi?id=174198
1677         
1678         Reviewed by Stephanie Lewis.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1681         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1682         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1683         (TransferToS3): Transfer full and minified archives to S3
1684
1685 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1686
1687         [WTF] Implement WTF::ThreadGroup
1688         https://bugs.webkit.org/show_bug.cgi?id=174081
1689
1690         Reviewed by Mark Lam.
1691
1692         Add WTF::ThreadGroup tests.
1693
1694         * TestWebKitAPI/CMakeLists.txt:
1695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1696         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1697         (TestWebKitAPI::TEST):
1698
1699 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1700
1701         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1702         https://bugs.webkit.org/show_bug.cgi?id=174150
1703
1704         Reviewed by Mark Lam.
1705
1706         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1707         (TestWebKitAPI::TEST):
1708         * TestWebKitAPI/TestsController.cpp:
1709         (TestWebKitAPI::TestsController::TestsController):
1710
1711 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1712
1713         Enabling uploading archives to S3.
1714         https://bugs.webkit.org/show_bug.cgi?id=174198
1715         
1716         Reviewed by Lucas Forschler.
1717
1718         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1719         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1720         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1721         (TransferToS3): Transfer full and minified archives to S3
1722
1723 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1724
1725         [GTK][WPE] kill-old-process should kill more webkit related process
1726         https://bugs.webkit.org/show_bug.cgi?id=174220
1727
1728         Reviewed by Michael Catanzaro.
1729
1730         Generate list of possible webkit-related process names and add
1731         them to the list of process to kill.
1732         Also update the possible system related process for GTK+/WPE.
1733
1734         * BuildSlaveSupport/kill-old-processes:
1735         (listAllWebKitPrograms):
1736         (main):
1737
1738 2017-07-06  Chris Dumez  <cdumez@apple.com>
1739
1740         FileMonitor should not be ref counted
1741         https://bugs.webkit.org/show_bug.cgi?id=174166
1742
1743         Reviewed by Brent Fulgham.
1744
1745         Update the API tests to reflect the API change.
1746
1747         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1748         (TestWebKitAPI::TEST_F):
1749
1750 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1751
1752         Unreviewed, rolling out r219194.
1753         https://bugs.webkit.org/show_bug.cgi?id=174207
1754
1755         it broke some layout tests (Requested by clopez on #webkit).
1756
1757         Reverted changeset:
1758
1759         "[GStreamer] vid.me videos do not play"
1760         https://bugs.webkit.org/show_bug.cgi?id=172240
1761         http://trac.webkit.org/changeset/219194
1762
1763 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1764
1765         Unreviewed, rolling out r219178.
1766
1767         This caused a consistent failure with the API test
1768         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1769
1770         Reverted changeset:
1771
1772         "[WTF] Clean up StringStatics.cpp by using
1773         LazyNeverDestroyed<> for Atoms"
1774         https://bugs.webkit.org/show_bug.cgi?id=174150
1775         http://trac.webkit.org/changeset/219178
1776
1777 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1778
1779         Add CWD to Perl library path (no longer the default since 5.26.0)
1780         https://bugs.webkit.org/show_bug.cgi?id=174200
1781
1782         Reviewed by Michael Catanzaro.
1783
1784         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1785         (SetupGitClone._get_username_and_email):
1786
1787 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1788
1789         Unreviewed, update my email address.
1790
1791         * Scripts/webkitpy/common/config/contributors.json:
1792
1793 2017-07-06  Charlie Turner  <cturner@igalia.com>
1794         [GStreamer] vid.me videos do not play
1795         https://bugs.webkit.org/show_bug.cgi?id=172240
1796
1797         Reviewed by Xabier Rodriguez-Calvar.
1798
1799         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1800         have the existing libsoup build against GNOME to avoid header drift
1801         against GStreamer's linked Soup library.
1802
1803         * gtk/jhbuild.modules:
1804
1805 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1806
1807         [WTF] Move SoftLinking.h into WTF
1808         https://bugs.webkit.org/show_bug.cgi?id=174000
1809
1810         Reviewed by Alex Christensen.
1811
1812         * DumpRenderTree/mac/TestRunnerMac.mm:
1813         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1814         (test_primary_header):
1815         (ErrorCollector.__init__): Deleted.
1816         (ErrorCollector.__call__): Deleted.
1817         (ErrorCollector.results): Deleted.
1818         (ErrorCollector.result_list): Deleted.
1819         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1820         (MockIo.open): Deleted.
1821         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1822         (CppFunctionsTest.test_create_acronym): Deleted.
1823         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1824         (CppFunctionsTest.test_parameter): Deleted.
1825         (CppFunctionsTest.test_single_line_view): Deleted.
1826         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1827         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1828         (CppFunctionsTest.test_parameter_list): Deleted.
1829         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1830         (CppStyleTestBase.process_file_data): Deleted.
1831         (CppStyleTestBase.perform_lint): Deleted.
1832         (CppStyleTestBase.perform_single_line_lint): Deleted.
1833         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1834         (CppStyleTestBase.perform_language_rules_check): Deleted.
1835         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1836         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1837         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1838         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1839         (CppStyleTestBase.perform_header_guard_check): Deleted.
1840         (CppStyleTestBase.assert_lint): Deleted.
1841         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1842         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1843         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1844         (CppStyleTestBase.assert_language_rules_check): Deleted.
1845         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1846         (CppStyleTestBase.assert_header_guard): Deleted.
1847         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1848         (CppStyleTestBase.assert_positions_equal): Deleted.
1849         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1850         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1851         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1852         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1853         (FunctionDetectionTest.test_ignore_macros): Deleted.
1854         (FunctionDetectionTest.test_non_functions): Deleted.
1855         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1856         (FunctionDetectionTest.test_parameter_list): Deleted.
1857         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1858         (CppStyleTest.test_asm_lines_ignored): Deleted.
1859         (CppStyleTest.test_get_line_width): Deleted.
1860         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1861         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1862         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1863         (CppStyleTest.test_position): Deleted.
1864         (CppStyleTest.test_rfind_in_lines): Deleted.
1865         (CppStyleTest.test_close_expression): Deleted.
1866         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1867         (CppStyleTest.test_cstyle_cast): Deleted.
1868         (CppStyleTest.test_runtime_casting): Deleted.
1869         (CppStyleTest.test_runtime_selfinit): Deleted.
1870         (CppStyleTest.test_runtime_rtti): Deleted.
1871         (CppStyleTest.test_static_cast_readability): Deleted.
1872         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1873         (CppStyleTest.void): Deleted.
1874         (CppStyleTest.test_deprecated_cast): Deleted.
1875         (CppStyleTest.test_mock_method): Deleted.
1876         (CppStyleTest.test_sizeof_type): Deleted.
1877         (CppStyleTest.cases): Deleted.
1878         (CppStyleTest.for): Deleted.
1879         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1880         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1881         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1882         (CppStyleTest.test_include_what_you_use): Deleted.
1883         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1884         (CppStyleTest.test_cleanse_line): Deleted.
1885         (CppStyleTest.test_multi_line_comments): Deleted.
1886         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1887         (CppStyleTest.test_multiline_strings): Deleted.
1888         (CppStyleTest.test_platformh_comments): Deleted.
1889         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1890         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1891         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1892         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1893         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1894         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1895         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1896         (CppStyleTest.test_check_posix_threading): Deleted.
1897         (CppStyleTest.test_insecure_string_operations): Deleted.
1898         (CppStyleTest.test_format_strings): Deleted.
1899         (CppStyleTest.test_insecure_temp_file): Deleted.
1900         (CppStyleTest.test_variable_length_array_detection): Deleted.
1901         (CppStyleTest.test_braces): Deleted.
1902         (CppStyleTest.test_check_check): Deleted.
1903         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1904         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1905         (CppStyleTest.test_spacing_for_fncall): Deleted.
1906         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1907         (CppStyleTest.test_spacing_before_braces): Deleted.
1908         (CppStyleTest.test_spacing_between_braces): Deleted.
1909         (CppStyleTest.test_spacing_before_brackets): Deleted.
1910         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1911         (CppStyleTest.test_objective_c_block): Deleted.
1912         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1913         (CppStyleTest.test_spacing_around_else): Deleted.
1914         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1915         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1916         (CppStyleTest.test_operator_methods): Deleted.
1917         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1918         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1919         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1920         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1921         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1922         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1923         (CppStyleTest.test_space_after_comment_marker): Deleted.
1924         (CppStyleTest.test_newline_at_eof): Deleted.
1925         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1926         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1927         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1928         (CppStyleTest.test_invalid_utf8): Deleted.
1929         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1930         (CppStyleTest.test_is_blank_line): Deleted.
1931         (CppStyleTest.test_blank_lines_check): Deleted.
1932         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1933         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1934         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1935         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1936         (CppStyleTest.test_comma): Deleted.
1937         (CppStyleTest.test_declaration): Deleted.
1938         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1939         (CppStyleTest.test_indent): Deleted.
1940         (CppStyleTest.test_indent.Foo): Deleted.
1941         (CppStyleTest.test_not_alabel): Deleted.
1942         (CppStyleTest.test_tab): Deleted.
1943         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1944         (CppStyleTest.test_build_class): Deleted.
1945         (CppStyleTest.test_build_class.definitions): Deleted.
1946         (CppStyleTest.test_build_class.Foo): Deleted.
1947         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1948         (CppStyleTest.test_build_end_comment): Deleted.
1949         (CppStyleTest.test_build_forward_decl): Deleted.
1950         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1951         (CppStyleTest.test_build_header_guard): Deleted.
1952         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1953         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1954         (CppStyleTest.test_build_printf_format): Deleted.
1955         (CppStyleTest.test_runtime_printf_format): Deleted.
1956         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1957         (CppStyleTest.test_build_storage_class): Deleted.
1958         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1959         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1960         (CppStyleTest.test_build_storage_class.after): Deleted.
1961         (CppStyleTest.test_build_storage_class.is): Deleted.
1962         (CppStyleTest.test_legal_copyright): Deleted.
1963         (CppStyleTest.test_invalid_increment): Deleted.
1964         (CppStyleTest.test_enum_bitfields): Deleted.
1965         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1966         (CleansedLinesTest.test_init_empty): Deleted.
1967         (CleansedLinesTest.test_collapse_strings): Deleted.
1968         (OrderOfIncludesTest.tearDown): Deleted.
1969         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1970         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1971         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1972         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1973         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1974         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1975         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1976         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1977         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1978         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1979         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1980         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1981         (OrderOfIncludesTest.test_primary_header): Deleted.
1982         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1983         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1984         (OrderOfIncludesTest.test_classify_include): Deleted.
1985         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1986         (CheckForFunctionLengthsTest.tearDown): Deleted.
1987         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1988         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1989         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1990         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1991         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1992         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1993         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1994         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1995         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1996         (CheckForFunctionLengthsTest.function_body): Deleted.
1997         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1998         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1999         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2000         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2001         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2002         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2003         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2004         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2005         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2006         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2007         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2008         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2009         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2010         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2011         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2012         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2013         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2014         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2015         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2016         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2017         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2018         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2019         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2020         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2021         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2022         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2023         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2024         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2025         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2026         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2027         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2028         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2029         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2030         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2031         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2032         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2033         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2034         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2035         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2036         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2037         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2038         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2039         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2040         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2041         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2042         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2043         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2044         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2045         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2046         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2047         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2048         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2049         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2050         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2051         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2052         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2053         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2054         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2055         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2056         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2057         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2058         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2059         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2060         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2061         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2062         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2063         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2064         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2065         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2066         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2067         (LeakyPatternTest.test_get_dc): Deleted.
2068         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2069         (LeakyPatternTest.test_own_get_dc): Deleted.
2070         (LeakyPatternTest.test_create_dc): Deleted.
2071         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2072         (WebKitStyleTest.test_indentation): Deleted.
2073         (WebKitStyleTest.test_indentation.Foo): Deleted.
2074         (WebKitStyleTest.test_indentation.Document): Deleted.
2075         (WebKitStyleTest.test_spacing): Deleted.
2076         (WebKitStyleTest.test_line_breaking): Deleted.
2077         (WebKitStyleTest.test_braces): Deleted.
2078         (WebKitStyleTest.test_braces.MyClass): Deleted.
2079         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2080         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2081         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2082         (WebKitStyleTest.test_null_false_zero): Deleted.
2083         (WebKitStyleTest.test_directive_indentation): Deleted.
2084         (WebKitStyleTest.test_using_std): Deleted.
2085         (WebKitStyleTest.test_using_namespace): Deleted.
2086         (WebKitStyleTest.test_max_macro): Deleted.
2087         (WebKitStyleTest.test_min_macro): Deleted.
2088         (WebKitStyleTest.test_wtf_move): Deleted.
2089         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2090         (WebKitStyleTest.test_names): Deleted.
2091         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2092         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2093         (WebKitStyleTest.test_names.declarations): Deleted.
2094         (WebKitStyleTest.test_names.struct): Deleted.
2095         (WebKitStyleTest.test_names.VectorType): Deleted.
2096         (WebKitStyleTest.test_parameter_names): Deleted.
2097         (WebKitStyleTest.test_comments): Deleted.
2098         (WebKitStyleTest.test_webkit_export_check): Deleted.
2099         (WebKitStyleTest.test_member_initialization_list): Deleted.
2100         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2101         (WebKitStyleTest.test_other): Deleted.
2102         (CppCheckerTest.mock_handle_style_error): Deleted.
2103         (CppCheckerTest._checker): Deleted.
2104         (CppCheckerTest.test_init): Deleted.
2105         (CppCheckerTest.test_eq): Deleted.
2106         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2107         (CppCheckerTest.test_ne): Deleted.
2108         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2109         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2110         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2111         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2112         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2113         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2114
2115 2017-07-05  Saam Barati  <sbarati@apple.com>
2116
2117         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2118         https://bugs.webkit.org/show_bug.cgi?id=174188
2119         <rdar://problem/30581423>
2120
2121         Reviewed by Mark Lam.
2122
2123         * Scripts/run-jsc-stress-tests:
2124
2125 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2126
2127         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2128         https://bugs.webkit.org/show_bug.cgi?id=174150
2129
2130         Reviewed by Mark Lam.
2131
2132         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2133         (TestWebKitAPI::TEST):
2134
2135 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2136
2137         Remove copy of ICU headers from WebKit
2138         https://bugs.webkit.org/show_bug.cgi?id=116407
2139
2140         Reviewed by Alex Christensen.
2141
2142         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2143         * TestWebKitAPI/Configurations/Base.xcconfig:
2144         * WebKitTestRunner/Configurations/Base.xcconfig:
2145
2146 2017-07-05  Chris Dumez  <cdumez@apple.com>
2147
2148         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2149         https://bugs.webkit.org/show_bug.cgi?id=174163
2150         <rdar://problem/33067518>
2151
2152         Reviewed by Alex Christensen.
2153
2154         Add API test coverage.
2155
2156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2157         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2158         (TEST):
2159
2160 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2161
2162         When dragging a selection, clearing the selection in dragstart should not crash the web process
2163         https://bugs.webkit.org/show_bug.cgi?id=174142
2164         <rdar://problem/33067501>
2165
2166         Reviewed by Tim Horton.
2167
2168         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2169         drag is starting up.
2170
2171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2172         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2173         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2174         (TestWebKitAPI::TEST):
2175
2176 2017-07-05  Daniel Bates  <dabates@apple.com>
2177
2178         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2179         API navigation
2180         https://bugs.webkit.org/show_bug.cgi?id=174170
2181         <rdar://problem/33140328>
2182
2183         Reviewed by Brady Eidson.
2184
2185         Update tests as needed for the behavior change.
2186
2187         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2188         (TEST):
2189
2190 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2191
2192         Add WebKitPrivateFrameworkStubs for iOS 11
2193         https://bugs.webkit.org/show_bug.cgi?id=173988
2194
2195         Reviewed by David Kilzer.
2196
2197         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2198         should use the same directory for private framework stubs.
2199         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2200
2201 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2202
2203         [MediaStream] Protect request and web view during gUM client callback
2204         https://bugs.webkit.org/show_bug.cgi?id=174096
2205         <rdar://problem/32833102>
2206
2207         Reviewed by Youenn Fablet.
2208
2209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2210         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2211
2212 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2213
2214         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2215
2216         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2217
2218 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2219
2220         Unreviewed, rolling out r219128.
2221
2222         Spoke with engineer who originally submitted, Patch for APi
2223         test to follow.
2224
2225         Reverted changeset:
2226
2227         "Unreviewed, rolling out r219070."
2228         https://bugs.webkit.org/show_bug.cgi?id=174082
2229         http://trac.webkit.org/changeset/219128
2230
2231 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2232
2233         Unreviewed, rolling out r219070.
2234
2235         This revision caused consistent failures of the API test
2236         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2237
2238         Reverted changeset:
2239
2240         "Pasting single words copied to UIPasteboard inserts URLs in
2241         editable areas"
2242         https://bugs.webkit.org/show_bug.cgi?id=174082
2243         http://trac.webkit.org/changeset/219070
2244
2245 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2246
2247         Remove unused EFL logo from bot watcher dashboard
2248         https://bugs.webkit.org/show_bug.cgi?id=174136
2249
2250         Reviewed by Alexey Proskuryakov.
2251
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2254
2255 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2256
2257         [GTK] Add more GTK bots to dashboard
2258         https://bugs.webkit.org/show_bug.cgi?id=174129
2259
2260         Reviewed by Carlos Alberto Lopez Perez.
2261
2262         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2263         them.
2264
2265         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2266         less-essential GTK bots.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2270         (WebKitBuildbot):
2271
2272 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2273
2274         [WPE] Add WPE to bot watcher dashboard
2275         https://bugs.webkit.org/show_bug.cgi?id=174119
2276
2277         Reviewed by Alexey Proskuryakov.
2278
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2284         (WebKitBuildbot):
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2286         (table.queue-grid tr.platform.linux-wpe img.logo):
2287
2288 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=174105
2291         
2292         Reviewed by Stephanie Lewis.
2293
2294         * BuildSlaveSupport/built-product-archive:
2295         (main): Add a -minify parser option
2296         (createZip): Pass along the optional Minify argument if requested
2297         (minifySource): This will trim down archives, logic limited to Mac platform.
2298
2299 2017-07-03  Matt Rajca  <mrajca@apple.com>
2300
2301         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2302         https://bugs.webkit.org/show_bug.cgi?id=174103
2303
2304         Reviewed by Alex Christensen.
2305
2306         Added an API test.
2307
2308         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2309         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2310         (TEST): Added test.
2311         * TestWebKitAPI/cocoa/TestWKWebView.h:
2312         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2313         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2314
2315 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2316
2317         Unreviewed, rolling out r219103.
2318
2319         Caused multiple build failures.
2320
2321         Reverted changeset:
2322
2323         "Remove copy of ICU headers from WebKit"
2324         https://bugs.webkit.org/show_bug.cgi?id=116407
2325         http://trac.webkit.org/changeset/219103
2326
2327 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2328
2329         Remove copy of ICU headers from WebKit
2330         https://bugs.webkit.org/show_bug.cgi?id=116407
2331
2332         Reviewed by Alex Christensen.
2333
2334         Use WTF's copy of ICU headers.
2335
2336         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2337         * TestWebKitAPI/Configurations/Base.xcconfig:
2338         * WebKitTestRunner/Configurations/Base.xcconfig:
2339
2340 2017-07-03  Brady Eidson  <beidson@apple.com>
2341
2342         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2343         https://bugs.webkit.org/show_bug.cgi?id=174073
2344
2345         Reviewed by Andy Estes.
2346
2347         * DumpRenderTree/mac/TestRunnerMac.mm:
2348         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2349
2350         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2351         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2352
2353 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2354
2355         Unreviewed, rolling out r219083.
2356
2357         The revision caused an API failure on all testing platforms.
2358
2359         Reverted changeset:
2360
2361         "[MediaStream] Protect request and web view during gUM client
2362         callback"
2363         https://bugs.webkit.org/show_bug.cgi?id=174096
2364         http://trac.webkit.org/changeset/219083
2365
2366 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2367
2368         webkitpy: Properly number duplicated crashlogs
2369         https://bugs.webkit.org/show_bug.cgi?id=172002
2370
2371         Reviewed by Aakash Jain.
2372
2373         * Scripts/webkitpy/common/system/crashlogs.py:
2374         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2375         an increasing integer.
2376         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2377         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2378         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2379         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2380
2381 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2382
2383         WebContent processes crash when the network process crashes with pending connection requests
2384         https://bugs.webkit.org/show_bug.cgi?id=174065
2385         <rdar://problem/30359835>
2386
2387         Reviewed by Tim Horton.
2388
2389         Add a API to ensure UI process tries to relaunch a new network process when the network process
2390         crashes with pending network connection requests.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2394         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2395         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2396         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2397
2398 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2399
2400         [MediaStream] Protect request and web view during gUM client callback
2401         https://bugs.webkit.org/show_bug.cgi?id=174096
2402         <rdar://problem/32833102>
2403
2404         Reviewed by Youenn Fablet.
2405
2406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2407         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2408
2409 2017-07-03  Andy Estes  <aestes@apple.com>
2410
2411         [Xcode] Add an experimental setting to build with ccache
2412         https://bugs.webkit.org/show_bug.cgi?id=173875
2413
2414         Reviewed by Tim Horton.
2415
2416         On systems that already have ccache(1) installed, this patch adds experimental support for
2417         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2418
2419         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2420         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2421         find the toolchain from which to run clang, and then invokes ccache with the required
2422         arguments.
2423
2424         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2425         precompiled headers to work properly [1].
2426
2427         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2428         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2429         during linking.
2430         
2431         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2432
2433         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2434         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2435         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2436         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2437         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2438         * ccache/README.md: Added.
2439         * ccache/ccache-clang: Added.
2440         * ccache/ccache-clang++: Added.
2441         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2442
2443 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2444
2445         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2446         https://bugs.webkit.org/show_bug.cgi?id=174051
2447
2448         Reviewed by Tim Horton.
2449
2450         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2451         (TestWebKitAPI::TEST_F):
2452
2453 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2454
2455         Unreviewed, rolling out r219024.
2456
2457         This patch cause 3 didferent test to fail.
2458
2459         Reverted changeset:
2460
2461         "REGRESSION(r215096) Queries of URLs with non-special schemes
2462         should not percent-encode single quotes"
2463         https://bugs.webkit.org/show_bug.cgi?id=174051
2464         http://trac.webkit.org/changeset/219024
2465
2466 2017-07-03  Chris Dumez  <cdumez@apple.com>
2467
2468         Drop ResourceLoadStatisticsStore's statisticsLock
2469         https://bugs.webkit.org/show_bug.cgi?id=174080
2470
2471         Reviewed by Brent Fulgham.
2472
2473         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2474
2475         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2476         (WTR::TestController::isStatisticsPrevalentResource):
2477         (WTR::TestController::isStatisticsHasHadUserInteraction):
2478         (WTR::TestController::isStatisticsGrandfathered):
2479
2480 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2481
2482         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2483         https://bugs.webkit.org/show_bug.cgi?id=174082
2484         <rdar://problem/33046992>
2485
2486         Reviewed by Tim Horton.
2487
2488         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2489
2490         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2491         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2492         (TestWebKitAPI::TEST):
2493
2494 2017-07-02  Brady Eidson  <beidson@apple.com>
2495
2496         Add API test for all parts of WebKit1 API related to favicons.
2497         https://bugs.webkit.org/show_bug.cgi?id=174069
2498
2499         Reviewed by Andy Estes.
2500
2501         These two API tests cover all WebKit1 API related to icons.
2502         
2503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2504         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2505         (mainResourceData):
2506         (defaultFaviconData):
2507         (customFaviconData):
2508         (imageFromData):
2509         (+[IconLoadingProtocol canInitWithRequest:]):
2510         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2511         (-[IconLoadingProtocol startLoading]):
2512         (-[IconLoadingProtocol stopLoading]):
2513         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2514         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2515         (TestWebKitAPI::TEST):
2516
2517 2017-07-01  Dan Bernstein  <mitz@apple.com>
2518
2519         [iOS] Remove code only needed when building for iOS 9.x
2520         https://bugs.webkit.org/show_bug.cgi?id=174068
2521
2522         Reviewed by Tim Horton.
2523
2524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2526         (WTR::initializeWebViewConfiguration):
2527         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2528         (-[HIDEventGenerator _createIOHIDEventType:]):
2529
2530 2017-07-01  Brady Eidson  <beidson@apple.com>
2531
2532         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2533         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2534
2535         Reviewed by Alex Christensen.
2536
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2538
2539 2017-07-01  Dan Bernstein  <mitz@apple.com>
2540
2541         [macOS] Remove code only needed when building for OS X Yosemite
2542         https://bugs.webkit.org/show_bug.cgi?id=174067
2543
2544         Reviewed by Tim Horton.
2545
2546         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2547         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2548         * DumpRenderTree/mac/DumpRenderTree.mm:
2549         (setDefaultsToConsistentValuesForTesting):
2550         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2551         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2552         * MiniBrowser/Configurations/Base.xcconfig:
2553         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2554         * TestWebKitAPI/Configurations/Base.xcconfig:
2555         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2556         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2557         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2558         (TestWebKitAPI::TEST_F):
2559         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2560         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2561         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2562         (TestWebKitAPI::TEST_F):
2563         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2564         (TestWebKitAPI::TEST):
2565         * WebKitTestRunner/Configurations/Base.xcconfig:
2566         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2567         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2568         (WTR::InjectedBundle::platformInitialize):
2569         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2570         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2571
2572 2017-07-01  Chris Dumez  <cdumez@apple.com>
2573
2574         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2575         https://bugs.webkit.org/show_bug.cgi?id=174060
2576
2577         Reviewed by Brent Fulgham.
2578
2579         Port WebKitTestRunner over to the new Cocoa SPI.
2580
2581         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2582         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2583         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2584         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2585         no-ops since this code runs in the WebContent process, not the
2586         UIProcess.
2587
2588         * WebKitTestRunner/TestController.cpp:
2589         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2590
2591 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2592
2593         Unreviewed mac build fix.
2594
2595         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2596         (TestWebKitAPI::TEST):
2597
2598 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2599
2600         Add API to get WKActivatedElementInfo
2601         https://bugs.webkit.org/show_bug.cgi?id=174001
2602         <rdar://problem/29165518>
2603         
2604         Tests for now SPI to get activatedElementInfo.
2605
2606         Reviewed by Tim Horton.
2607
2608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2609         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2610         (TestWebKitAPI::TEST):
2611
2612 2017-06-30  Chris Dumez  <cdumez@apple.com>
2613
2614         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2615         https://bugs.webkit.org/show_bug.cgi?id=174038
2616
2617         Reviewed by Brent Fulgham.
2618
2619         Fix typo in API name.
2620
2621         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2622         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2623         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2624         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2625         * WebKitTestRunner/TestController.cpp:
2626         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2627         * WebKitTestRunner/TestController.h:
2628         * WebKitTestRunner/TestInvocation.cpp:
2629         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2630
2631 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2632
2633         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2634         https://bugs.webkit.org/show_bug.cgi?id=174051
2635         <rdar://problem/33002846>
2636
2637         Reviewed by Tim Horton.
2638
2639         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2640         (TestWebKitAPI::TEST_F):
2641
2642 2017-06-30  Daniel Bates  <dabates@apple.com>
2643
2644         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2645         https://bugs.webkit.org/show_bug.cgi?id=165160
2646         <rdar://problem/29451999>
2647
2648         Reviewed by Brady Eidson.
2649
2650         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2651         for navigations and window creation.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2654         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2655         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2656         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2657         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2658         (TEST):
2659
2660 2017-06-29  Jer Noble  <jer.noble@apple.com>
2661
2662         Make Legacy EME API controlled by RuntimeEnabled setting.
2663         https://bugs.webkit.org/show_bug.cgi?id=173994
2664
2665         Reviewed by Sam Weinig.
2666
2667         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2668
2669 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2670
2671         Follow-up fix for r218996
2672
2673         Unreviewed infrastructure fix.
2674
2675         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2676
2677         * Scripts/webkitpy/port/ios_simulator.py:
2678         (IOSSimulatorPort): Memoize ios_version().
2679
2680 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2681
2682         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2683         https://bugs.webkit.org/show_bug.cgi?id=174017
2684         <rdar://problem/32959782>
2685
2686         Reviewed by Simon Fraser.
2687
2688         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2689         changes, the caret would appear outside of the iframe.
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2693         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2694         (checkDragCaretRectIsContainedInRect):
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2697         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2698         (-[DataInteractionSimulator _resetSimulatedState]):
2699         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2700         (-[DataInteractionSimulator _advanceProgress]):
2701         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2702
2703 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2704
2705         Add support for different versions of iOS when loading test expectations
2706         https://bugs.webkit.org/show_bug.cgi?id=173774
2707         <rdar://problem/32951132>
2708
2709         Rubber-stamped by Aakash Jain.
2710
2711         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2712
2713         * Scripts/webkitpy/port/ios.py:
2714         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2715         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2716         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2717         * Scripts/webkitpy/port/ios_device.py:
2718         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2719         * Scripts/webkitpy/port/ios_device_unittest.py:
2720         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2721         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2722         (IOSDeviceTest.test_expectations_ordering): Ditto.
2723         * Scripts/webkitpy/port/ios_simulator.py:
2724         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2725         ask the platform.
2726
2727 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2728
2729         Fontconfig build breaks with glibc 2.15+
2730         https://bugs.webkit.org/show_bug.cgi?id=174019
2731
2732         Reviewed by Carlos Alberto Lopez Perez.
2733
2734         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2735
2736         * wpe/jhbuild.modules:
2737         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2738
2739 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2740
2741         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2742         https://bugs.webkit.org/show_bug.cgi?id=174010
2743         <rdar://problem/32597802>
2744
2745         Reviewed by Tim Horton.
2746
2747         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2748         snapshot fails for any reason.
2749
2750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2751         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2752         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2753         (TestWebKitAPI::TEST):
2754
2755 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2756
2757         AX: Cannot call setValue() on contenteditable or ARIA text controls
2758         https://bugs.webkit.org/show_bug.cgi?id=173520
2759
2760         Reviewed by Ryosuke Niwa.
2761
2762         Add setValue() method to WKTR (already existed in DRT).
2763
2764         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2765         (WTR::AccessibilityUIElement::setValue):
2766         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2767         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2768         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2769         (WTR::AccessibilityUIElement::setValue):
2770
2771 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2772
2773         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2774         https://bugs.webkit.org/show_bug.cgi?id=173841
2775         rdar://problem/32983841
2776
2777         Reviewed by Dean Jackson.
2778
2779         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2780         always did text zooming.
2781
2782         * MiniBrowser/mac/WK1BrowserWindowController.m:
2783         (-[WK1BrowserWindowController zoomIn:]):
2784         (-[WK1BrowserWindowController zoomOut:]):
2785         (-[WK1BrowserWindowController canResetZoom]):
2786         (-[WK1BrowserWindowController resetZoom:]):
2787
2788 2017-06-29  John Wilander  <wilander@apple.com>
2789
2790         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2791         https://bugs.webkit.org/show_bug.cgi?id=173940
2792         <rdar://problem/33018125>
2793
2794         Reviewed by Brent Fulgham.
2795
2796         This change allows the TestController to turn off
2797         regular resource load statistics telemetry submission
2798         and to manually control when telemetry is calculated
2799         and submitted.
2800
2801         * WebKitTestRunner/TestController.cpp:
2802         (WTR::TestController::initialize):
2803             Turns off automatic resource load statistics telemetry submission.
2804
2805 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2806
2807         Unreviewed, rolling out r218512.
2808         https://bugs.webkit.org/show_bug.cgi?id=173981
2809
2810         "It changes the behavior of the JS API's JSEvaluateScript
2811         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2812
2813         Reverted changeset:
2814
2815         "test262: Completion values for control flow do not match the
2816         spec"
2817         https://bugs.webkit.org/show_bug.cgi?id=171265
2818         http://trac.webkit.org/changeset/218512
2819
2820 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2821
2822         Add WebKitSystemInterface for iOS 11
2823         https://bugs.webkit.org/show_bug.cgi?id=173936
2824
2825         Reviewed by Lucas Forschler.
2826
2827         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2828
2829 2017-06-28  Keith Miller  <keith_miller@apple.com>
2830
2831         VMTraps has some races
2832         https://bugs.webkit.org/show_bug.cgi?id=173941
2833
2834         Reviewed by Michael Saboff.
2835
2836         Add new testing mode for testing the Watchdog with our stress
2837         tests.
2838
2839         * Scripts/run-jsc-stress-tests:
2840
2841 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2842
2843         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2844         https://bugs.webkit.org/show_bug.cgi?id=173877
2845
2846         Reviewed by Brady Eidson.
2847
2848         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2849         the next tests.
2850
2851         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2852         (testGetFavicon):
2853
2854 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2855
2856         MobileSafari was constantly using 10-15% CPU viewing a PDF
2857         https://bugs.webkit.org/show_bug.cgi?id=173944
2858         <rdar://problem/33039910>
2859
2860         Reviewed by Simon Fraser.
2861
2862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2863         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2864         Add a test that we ever call the stable presentation update callback
2865         when we have a WKPDFView up, instead of infinitely looping.
2866
2867 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2868
2869         Prevent displaying URLs with small capital letters
2870         https://bugs.webkit.org/show_bug.cgi?id=173949
2871         <rdar://problem/32952058>
2872
2873         Reviewed by Brent Fulgham.
2874
2875         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2876         (TestWebKitAPI::TEST):
2877
2878 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2879
2880         Unreviewed test fix.
2881
2882         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2883
2884         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2885
2886 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2887
2888         Teach ResourceLoadStatistics to recognize changes in the file system
2889         https://bugs.webkit.org/show_bug.cgi?id=173800
2890         <rdar://problem/32937842>
2891
2892         Reviewed by Chris Dumez.
2893
2894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2895         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2896         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2897         (TestWebKitAPI::handleFileModification):
2898         (TestWebKitAPI::handleFileDeletion):
2899         (TestWebKitAPI::resetTestState):
2900         (TestWebKitAPI::TEST_F):
2901
2902 2017-06-28  Brady Eidson  <beidson@apple.com>
2903
2904         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2905         https://bugs.webkit.org/show_bug.cgi?id=173874
2906
2907         Reviewed by Alex Christensen.
2908
2909         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2910
2911 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2912
2913         Unreviewed, adding Don Olmstead to contributors.json
2914
2915         * Scripts/webkitpy/common/config/contributors.json:
2916
2917 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2918
2919         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2920         https://bugs.webkit.org/show_bug.cgi?id=173886
2921         <rdar://problem/32543191>
2922
2923         Reviewed by Andy Estes.
2924
2925         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2926         (ParsedRange::ParsedRange):
2927         (-[TestSchemeHandler initWithVideoData:]):
2928         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2929         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2930         (TEST):
2931
2932 2017-06-27  JF Bastien  <jfbastien@apple.com>
2933
2934         WebAssembly: running out of executable memory should throw OoM
2935         https://bugs.webkit.org/show_bug.cgi?id=171537
2936         <rdar://problem/32963338>
2937
2938         Reviewed by Saam Barati.
2939
2940         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2941         tests under limited executable memory and avoids non-WebAssembly
2942         code generation so that we more reliably run out of executable
2943         memory in WebAssembly.
2944
2945 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2946
2947         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2948         https://bugs.webkit.org/show_bug.cgi?id=173854
2949         <rdar://problem/32236827>
2950
2951         Reviewed by Ryosuke Niwa and Tim Horton.
2952
2953         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2954
2955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2956         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2957         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2958         (TestWebKitAPI::TEST):
2959
2960 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2961
2962         [PAL] Add symbol export macros for PAL
2963         https://bugs.webkit.org/show_bug.cgi?id=171519
2964
2965         Reviewed by Konstantin Tokarev.
2966
2967         * DumpRenderTree/config.h:
2968         * TestWebKitAPI/CMakeLists.txt:
2969         * TestWebKitAPI/config.h:
2970         * WebKitTestRunner/config.h:
2971
2972 2017-06-27  John Wilander  <wilander@apple.com>
2973
2974         Resource Load Statistics: Add telemetry
2975         https://bugs.webkit.org/show_bug.cgi?id=173499
2976         <rdar://problem/32826094>
2977
2978         Reviewed by Brent Fulgham.
2979
2980         Adds three new testRunner functions:
2981         - installStatisticsDidRunTelemetryCallback()
2982         - statisticsFireTelemetryHandler()
2983         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2984
2985         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2986         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2987         (WTR::InjectedBundle::didReceiveMessageToPage):
2988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2989         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2990         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2991         (WTR::TestRunner::statisticsFireTelemetryHandler):
2992         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2993         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2994         * WebKitTestRunner/TestController.cpp:
2995         (WTR::TestController::resetStateToConsistentValues):
2996         (WTR::TestController::statisticsFireTelemetryHandler):
2997         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2998         * WebKitTestRunner/TestController.h:
2999         * WebKitTestRunner/TestInvocation.cpp:
3000         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3001
3002 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
3003
3004         Add missing includes to fix compilation error on FreeBSD
3005         https://bugs.webkit.org/show_bug.cgi?id=172919
3006
3007         Reviewed by Mark Lam.
3008
3009         * ImageDiff/cairo/PlatformImageCairo.cpp:
3010
3011 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3012
3013         Unreviewed, rolling out r218783.
3014
3015         Causing accessibility/mac/setting-attributes-is-
3016         asynchronous.html to crash consistently on mac-wk2 Debug
3017
3018         Reverted changeset:
3019
3020         "AX: Cannot call setValue() on contenteditable or ARIA text
3021         controls"
3022         https://bugs.webkit.org/show_bug.cgi?id=173520
3023         http://trac.webkit.org/changeset/218783
3024
3025 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3026
3027         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3028         https://bugs.webkit.org/show_bug.cgi?id=173825
3029
3030         Reviewed by Saam Barati.
3031
3032         * DumpRenderTree/JavaScriptThreading.cpp:
3033         (runJavaScriptThread):
3034         (startJavaScriptThreads):
3035         * DumpRenderTree/mac/DumpRenderTree.mm:
3036         (runThread):
3037         (runPthread):
3038         (testThreadIdentifierMap):
3039
3040 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3041
3042         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3043         <https://webkit.org/b/173837>
3044
3045         Reviewed by Geoffrey Garen.
3046
3047         The clang static analyzer can't reason about objects that are
3048         assigned to a delegate as +1 retained, and then released
3049         later in a different method when the delegate is cleared.
3050
3051         Instead, use a common idiom where the object setting the
3052         delegate retains it as an instance variable on initialization.
3053         Then the same object clears the delegate and releases its
3054         instance variable during teardown.
3055
3056         Also add EXPECT_TRUE() tests to make sure the delegate objects
3057         match before teardown.
3058
3059         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3060         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3061         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3062         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3063         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3064         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3065
3066 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3067
3068         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3069         <https://webkit.org/b/173836>
3070
3071         Reviewed by Brady Eidson.
3072
3073         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3074         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3075         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3076         objects in this test.
3077
3078 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3079
3080         [ATK] Add support for aria-details and aria-errormessage
3081         https://bugs.webkit.org/show_bug.cgi?id=172588
3082
3083         Reviewed by Chris Fleizach.
3084
3085         Add additional methods to test ARIA properties which are exposed via
3086         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3087         to versions which support the details and error-message relation types.
3088
3089         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3090         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3091         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3092         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3093         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3094         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3096         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3097         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3098         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3099         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3100         * gtk/jhbuild.modules:
3101
3102 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3103
3104         Unreviewed. Add libfii to GTK+ install dependencies script.
3105
3106         * gtk/install-dependencies:
3107
3108 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3109
3110         Unreviewed, rolling out r215190.
3111
3112         Broke product select element on GNOME Bugzilla
3113
3114         Reverted changeset:
3115
3116         "[GTK] Misplaced right click menu on web page due to
3117         deprecated gtk_menu_popup()"
3118         https://bugs.webkit.org/show_bug.cgi?id=170553
3119         http://trac.webkit.org/changeset/215190
3120
3121 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3122
3123         Remove Reflect.enumerate
3124         https://bugs.webkit.org/show_bug.cgi?id=173806
3125
3126         Reviewed by Yusuke Suzuki.
3127
3128         * Scripts/run-jsc-stress-tests:
3129
3130 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3131
3132         AX: Cannot call setValue() on contenteditable or ARIA text controls
3133         https://bugs.webkit.org/show_bug.cgi?id=173520
3134
3135         Reviewed by Ryosuke Niwa.
3136
3137         Add setValue() method to WKTR (already existed in DRT).
3138
3139         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3140         (WTR::AccessibilityUIElement::setValue):
3141         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3142         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3143         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3144         (WTR::AccessibilityUIElement::setValue):
3145
3146 2017-06-23  Keith Miller  <keith_miller@apple.com>
3147
3148         Switch VMTraps to use halt instructions rather than breakpoint instructions
3149         https://bugs.webkit.org/show_bug.cgi?id=173677
3150
3151         Reviewed by JF Bastien.
3152
3153         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3154         (TEST):
3155
3156 2017-06-23  Youenn Fablet  <youenn@apple.com>
3157
3158         Set getUserMedia permission to true by default on WTR
3159         https://bugs.webkit.org/show_bug.cgi?id=173610
3160
3161         Reviewed by Alex Christensen.
3162
3163         Adding a way to reset the getUserMedia permission to pending.
3164
3165         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3166         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3167         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3168         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3170         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3171         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::TestController::resetStateToConsistentValues):
3174         (WTR::TestController::setUserMediaPermissionAsUnset):
3175         * WebKitTestRunner/TestController.h:
3176         * WebKitTestRunner/TestInvocation.cpp:
3177         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3178
3179 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3180
3181         Add SPI to WKURLSchemeTask for redirection
3182         https://bugs.webkit.org/show_bug.cgi?id=173730
3183
3184         Reviewed by Brady Eidson.
3185
3186         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3187         (-[SchemeHandler webView:startURLSchemeTask:]):
3188         (-[SchemeHandler webView:stopURLSchemeTask:]):
3189         (TEST):
3190         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3191         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3192         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3193         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3194         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3195
3196 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3197
3198         [WPE] Use JSC API to send script messages from web extension in tests
3199         https://bugs.webkit.org/show_bug.cgi?id=173757
3200
3201         Reviewed by Žan Doberšek.
3202
3203         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3204         to run postMessage().
3205
3206         Fixes: /wpe/WebKitSecurityManager/file-xhr
3207                /wpe/WebKitConsoleMessage/console-api
3208                /wpe/WebKitConsoleMessage/js-exception
3209                /wpe/WebKitConsoleMessage/network-error
3210                /wpe/WebKitConsoleMessage/security-error
3211
3212         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3213         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3214         (beforeAll): Ditto.
3215         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3216         (testWebContextSecurityFileXHR): Ditto.
3217         (beforeAll): Ditto.
3218         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3219         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3220         (pageCreatedCallback): Remove ifdefs.
3221
3222 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3223
3224         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3225
3226         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3227         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3228         doesn't exist yet in WPE.
3229
3230         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3231         (testWebViewJavaScriptDialogs):
3232         (testWebViewWindowProperties):
3233
3234 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3235
3236         [GTK] Upgrade pixman and cairo in jhbuild
3237         https://bugs.webkit.org/show_bug.cgi?id=173710
3238
3239         Reviewed by Carlos Alberto Lopez Perez.
3240
3241         * gtk/jhbuild.modules:
3242
3243 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3244
3245         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3246         https://bugs.webkit.org/show_bug.cgi?id=173711
3247
3248         Reviewed by Carlos Alberto Lopez Perez.
3249
3250         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3251         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3252
3253         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3254         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3255
3256 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3257
3258         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3259         <https://webkit.org/b/173721>
3260
3261         Reviewed by Joseph Pecoraro.
3262
3263         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3264         objects to fix leaks and to avoid the autoreleasepool.
3265
3266         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3267         (TEST):
3268
3269 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3270
3271         Unreviewed, rolling out r218633.
3272
3273         The test is failing frequently on Sierra Debug and Windows
3274
3275         Reverted changeset:
3276
3277         "AX: Cannot call setValue() on contenteditable or ARIA text
3278         controls"
3279         https://bugs.webkit.org/show_bug.cgi?id=173520
3280         http://trac.webkit.org/changeset/218633
3281
3282 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3283
3284         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3285         <https://webkit.org/b/173690>
3286
3287         Reviewed by Chris Dumez.
3288
3289         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3290         ownership of malloc()-ed memory, then frees it when it's
3291         released.  These tests were passing global variables into the
3292         method, which is not malloc()-ed memory, which violates the API
3293         contract.
3294
3295         The fix is to switch to use
3296         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3297         NO for the last argument.
3298
3299         Caught by the clang static analyzer.
3300
3301         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3302         (TEST):
3303         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3304         (TEST):
3305
3306 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         [GTK] Upgrade Harfbuzz to version 1.4.2
3309         https://bugs.webkit.org/show_bug.cgi?id=173592
3310
3311         Reviewed by Carlos Alberto Lopez Perez.
3312
3313         * gtk/jhbuild.modules:
3314
3315 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3316
3317         [WPE] Update WPEBackend-mesa
3318         https://bugs.webkit.org/show_bug.cgi?id=173705
3319
3320         Reviewed by Carlos Alberto Lopez Perez.
3321
3322         A crash has been fixed, needed for unit tests to work.
3323
3324         * wpe/jhbuild.modules:
3325
3326 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3327
3328         Remove unused coordinated graphics C API
3329         https://bugs.webkit.org/show_bug.cgi?id=173706
3330
3331         Reviewed by Žan Doberšek.
3332
3333         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3334         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3335         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3336         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3337         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3338         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3339
3340 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3341
3342         [WPE] Build glib API tests
3343         https://bugs.webkit.org/show_bug.cgi?id=173702
3344
3345         Reviewed by Žan Doberšek.
3346
3347         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3348         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3349         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3350         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3351         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3352         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3353         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3354         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3355         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3356         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3357         and implement the missing features.
3358
3359         * CMakeLists.txt:
3360         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3361         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3362         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3363         (testAutomationSessionRequestSession):
3364         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3365         (testWebKitWebViewSessionState):
3366         (testWebKitWebViewSessionStateWithFormData):
3367         (testWebKitWebViewNavigationAfterSessionRestore):
3368         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3369         (beforeAll):
3370         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3371         (testCookieManagerEphemeral):
3372         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3373         (testBlobDownload):
3374         (beforeAll):
3375         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3376         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3377         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3378         (testProcessPerWebView):
3379         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3380         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3381         (testWebViewCreateNavigationData):
3382         (testWebViewJavaScriptDialogs):
3383         (testWebViewWindowProperties):
3384         (testWebViewMouseTarget):
3385         (testWebViewGeolocationPermissionRequests):
3386         (testWebViewUserMediaPermissionRequests):
3387         (testWebViewAudioOnlyUserMediaPermissionRequests):
3388         (testWebViewFileChooserRequest):
3389         (beforeAll):
3390         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3391         (beforeAll):
3392         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3393         (testPrivateBrowsing):
3394         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3395         (testFindControllerHide):
3396         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3397         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3398         (testWebKitSettings):
3399         (beforeAll):
3400         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3401         (testWebViewNewWithUserContentManager):
3402         (beforeAll):
3403         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3404         (testWebContextEphemeral):
3405         (testWebContextProxySettings):
3406         (beforeAll):
3407         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3408         (testWebViewWebContext):
3409         (testWebViewWebContextLifetime):
3410         (testWebViewEphemeral):
3411         (testWebViewSettings):
3412         (testWebViewCanShowMIMEType):
3413         (testWebViewPageVisibility):
3414         (testWebViewIsPlayingAudio):
3415         (beforeAll):
3416         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3417         (testWebsiteDataEphemeral):
3418         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3419         (documentLoadedCallback):
3420         (pageCreatedCallback):
3421         (methodCallCallback):
3422         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3423         * TestWebKitAPI/glib/CMakeLists.txt:
3424         * TestWebKitAPI/glib/PlatformGTK.cmake:
3425         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3426         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3427         (main):
3428         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3429         (Test::adoptView):
3430         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3431         (WebKitTestBus::run):
3432         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3433         (WebViewTest::~WebViewTest):
3434         (WebViewTest::initializeWebView):
3435         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3436         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3437         (WebViewTest::platformDestroy):
3438         (WebViewTest::platformInitializeWebView):
3439         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3440         (WebViewTest::resizeView):
3441         (WebViewTest::hideView):
3442         (parentWindowMapped):
3443         (WebViewTest::showInWindow):
3444         (WebViewTest::showInWindowAndWaitUntilMapped):
3445         (WebViewTest::mouseMoveTo):
3446         (WebViewTest::clickMouseButton):
3447         (WebViewTest::emitPopupMenuSignal):
3448         (WebViewTest::keyStroke):
3449         (WebViewTest::doMouseButtonEvent):
3450         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3451         (WebViewTest::platformDestroy):
3452         (WebViewTest::platformInitializeWebView):
3453         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3454         (WebViewTest::resizeView):
3455         (WebViewTest::hideView):
3456         (WebViewTest::mouseMoveTo):
3457         (WebViewTest::clickMouseButton):
3458         (WebViewTest::keyStroke):
3459
3460 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3461
3462         [GTK] Move WebKit2 GLib API tests to glib directories
3463         https://bugs.webkit.org/show_bug.cgi?id=173642
3464
3465         Reviewed by Žan Doberšek.
3466
3467         * CMakeLists.txt:
3468         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3469         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3470         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3471         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3472         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3473         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3474         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3475         (testWebKitConsoleMessageNetworkError):
3476         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3477         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3478         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3479         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3480         (testLoadFromGResource):
3481         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3482         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3483         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3484         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3485         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3486         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3487         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3488         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3489         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3490         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3491         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3492         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3493         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3494         (testWebViewRunJavaScript):
3495         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3496         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3497         (registerGResource):
3498         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3499         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3500         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3501         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3502         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3503         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3504         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3505         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3506         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3507         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3508         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3509         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3510         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3511         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3512         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3513         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3514         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3515         (registerGResource):
3516         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3517         (Test::getResourcesDir):
3518         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3519         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3520         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3521         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3522         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3523         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3524
3525 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3526
3527         [WPE] Add initial web extensions API
3528         https://bugs.webkit.org/show_bug.cgi?id=173640
3529
3530         Reviewed by Žan Doberšek.
3531
3532         Add style checker exceptions for WPE web extensions API files.
3533
3534         * Scripts/webkitpy/style/checker.py:
3535
3536 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3537
3538         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3539         https://bugs.webkit.org/show_bug.cgi?id=173659
3540         <rdar://problem/32879788>
3541
3542         Reviewed by Tim Horton.
3543
3544         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3545
3546         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3547
3548         Augment this test page to log dragend and dragstart events on the drag source as well.
3549
3550         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3551         (checkStringArraysAreEqual):
3552         (TestWebKitAPI::TEST):
3553
3554 2017-06-21  Antoine Quint  <graouts@apple.com>
3555
3556         Ensure DRT always logs rAF suspension debugging code
3557         https://bugs.webkit.org/show_bug.cgi?id=173681
3558
3559         Reviewed by Tim "Mr. T" Horton.
3560
3561         * DumpRenderTree/mac/DumpRenderTree.mm:
3562         (resetWebPreferencesToConsistentValues):
3563
3564 2017-06-21  Chris Dumez  <cdumez@apple.com>
3565
3566         Allow constructing a WTF:Function from a function pointer
3567         https://bugs.webkit.org/show_bug.cgi?id=173660
3568
3569         Reviewed by Alex Christensen.
3570
3571         Add API test coverage.
3572
3573         * TestWebKitAPI/Tests/WTF/Function.cpp:
3574         (TestWebKitAPI::returnThree):
3575         (TestWebKitAPI::returnFour):
3576         (TestWebKitAPI::returnPassedValue):
3577         (TestWebKitAPI::TEST):
3578
3579 2017-06-21  Antoine Quint  <graouts@apple.com>
3580
3581         Add logging to identify when the Page suspends scripted animations
3582         https://bugs.webkit.org/show_bug.cgi?id=173626
3583
3584         Reviewed by Tim Horton.
3585
3586         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3587
3588         * DumpRenderTree/mac/DumpRenderTree.mm:
3589         (resetWebPreferencesToConsistentValues):
3590
3591 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3592
3593         AX: Cannot call setValue() on contenteditable or ARIA text controls
3594         https://bugs.webkit.org/show_bug.cgi?id=173520
3595
3596         Reviewed by Ryosuke Niwa.
3597
3598         Add setValue() method to WKTR (already existed in DRT).
3599
3600         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3601         (WTR::AccessibilityUIElement::setValue):
3602         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: