535fd7ebdd5020526a6eede9d11d2aee1ab75f45
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-28  Bastien Nocera <hadess@hadess.net>
2
3         Name all the GLib timeout sources
4         https://bugs.webkit.org/show_bug.cgi?id=123229
5
6         Reviewed by Anders Carlsson.
7
8         Give a name to GLib timeout sources, this is helpful when
9         profiling WebKitGTK applications.
10
11 2013-10-28  Bastien Nocera <hadess@hadess.net>
12
13         Replace 0 timeouts g_timeout_add() by g_idle_add()
14         https://bugs.webkit.org/show_bug.cgi?id=123260
15
16         Reviewed by Carlos Garcia Campos.
17
18         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
19         without the nagging feeling that the wrong API was used.
20
21         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
22         of 0-timer.
23         (topLoadingFrameLoadFinished):
24         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
25         (scheduleAsynchronousClickCallback):
26         (scheduleAsynchronousKeyDownCallback):
27
28 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
29
30         [GTK] [WebKit2] CanHandleRequest API test fails
31         https://bugs.webkit.org/show_bug.cgi?id=88453
32
33         Reviewed by Martin Robinson.
34
35         * Scripts/run-gtk-tests:
36         (TestRunner):
37
38 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
39
40         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
41
42         * Scripts/webkitpy/port/base.py:
43         (Port.repository_paths):
44
45 2013-10-25  Jer Noble  <jer.noble@apple.com>
46
47         [WTF] Add a multiplication operator (and a few others) to MediaTime
48         https://bugs.webkit.org/show_bug.cgi?id=123137
49
50         Reviewed by Eric Carlson.
51
52         Add tests for new MediaTime operators.
53
54         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
55         (TestWebKitAPI::TEST):
56
57 2013-10-24  Mark Rowe  <mrowe@apple.com>
58
59         Remove references to OS X 10.7 from Xcode configuration settings.
60
61         Now that we're not building for OS X 10.7 they're no longer needed.
62
63         Reviewed by Anders Carlsson.
64
65         * DumpRenderTree/mac/Configurations/Base.xcconfig:
66         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
67         * MiniBrowser/Configurations/Base.xcconfig:
68         * MiniBrowser/Configurations/DebugRelease.xcconfig:
69         * TestWebKitAPI/Configurations/Base.xcconfig:
70         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
71         * WebKitLauncher/Configurations/Base.xcconfig:
72         * WebKitTestRunner/Configurations/Base.xcconfig:
73         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
74
75 2013-10-24  Mark Rowe  <mrowe@apple.com>
76
77         <rdar://problem/15312643> Prepare for the mysterious future.
78
79         Reviewed by David Kilzer.
80
81         * DumpRenderTree/mac/Configurations/Base.xcconfig:
82         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
83         * MiniBrowser/Configurations/Base.xcconfig:
84         * MiniBrowser/Configurations/DebugRelease.xcconfig:
85         * TestWebKitAPI/Configurations/Base.xcconfig:
86         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
87         * WebKitLauncher/Configurations/Base.xcconfig:
88         * WebKitTestRunner/Configurations/Base.xcconfig:
89         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
90
91 2013-10-24  Daniel Bates  <dabates@apple.com>
92
93         Crash in WebCore::NavigationScheduler::startTimer()
94         https://bugs.webkit.org/show_bug.cgi?id=123288
95         <rdar://problem/14055644>
96
97         Reviewed by Alexey Proskuryakov.
98
99         Add API test.
100
101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
102         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
103         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
104
105 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
106
107         [GTK] Disable css-image-orientation
108         https://bugs.webkit.org/show_bug.cgi?id=123257
109
110         Reviewed by Martin Robinson.
111
112         CSS image orientation isn't stable yet. So, test regression happen since r157909.
113         This feature should be enabled again after it is stable.
114
115         * Scripts/webkitperl/FeatureList.pm:
116
117 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
118
119         Fix argument passing for jhbuild.
120         https://bugs.webkit.org/show_bug.cgi?id=123253
121
122         Reviewed by Gustavo Noronha Silva.
123
124         The update-webkit-libs-jhbuild previously didn't allowed
125         extra arguments to be passed to jhbuild.
126
127         * Scripts/update-webkit-libs-jhbuild:
128         (runJhbuild):
129         * Scripts/update-webkitefl-libs:
130
131 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
132
133         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
134         https://bugs.webkit.org/show_bug.cgi?id=123251
135
136         Reviewed by Csaba Osztrogonác.
137
138         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
139         compilation warning on 64-Bit.
140
141         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
142         (onExceededDatabaseQuota):
143
144 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
145
146         [EFL] Build break with latest EFL 1.8 libraries.
147         https://bugs.webkit.org/show_bug.cgi?id=123245
148
149         Reviewed by Gyuyoung Kim.
150
151         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
152         Eo typedef and splitted header files which contain version macro.
153
154         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
155         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
156         * WebKitTestRunner/PlatformWebView.h: Ditto.
157
158 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
159
160         [GObject bindings] Make EventTarget interface introspectable
161         https://bugs.webkit.org/show_bug.cgi?id=77835
162
163         Reviewed by Gustavo Noronha Silva.
164
165         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
166         GObject DOM bindings headers.
167
168 2013-10-23  Lucas Forschler  <lforschler@apple.com>
169
170         Add two more mac bots to the Mavericks Test Queue.
171         
172         Unreviewed.
173         
174         * BuildSlaveSupport/build.webkit.org-config/config.json:
175
176 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
177
178         Have a way of dealing with slow tests in run-jsc-stress-tests
179         https://bugs.webkit.org/show_bug.cgi?id=123221
180
181         Reviewed by Mark Hahnenberg.
182         
183         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
184         rather than appended to it. This means that slow tests get queued up first and are less likely
185         to block completion.
186
187         * Scripts/run-jsc-stress-tests:
188
189 2013-10-23  Alex Christensen  <achristensen@webkit.org>
190
191         Explicitly build Win32 or x64 configuration on Windows.
192         https://bugs.webkit.org/show_bug.cgi?id=123206
193
194         Reviewed by Brent Fulgham.
195
196         * Scripts/webkitdirs.pm:
197         (jscPath):
198         (determineConfigurationForVisualStudio):
199         (determinePassedConfiguration):
200         Add |Win32 to the end of 32-bit Visual Studio build configurations.
201         (safariPath):
202         * Scripts/build-webkit:
203         * Scripts/old-run-webkit-tests:
204         * Scripts/run-api-tests:
205         (testToolPath):
206         * Scripts/run-javascriptcore-tests:
207         (testapiPath):
208         * Scripts/run-regexp-tests:
209         (testapiPath):
210         * Scripts/sunspider-compare-results:
211         (pathToBuiltJSC):
212         Use configuration instead of configurationForVisualStudio, which are now always different.
213
214 2013-10-23  Mark Lam  <mark.lam@apple.com>
215
216         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
217         https://bugs.webkit.org/show_bug.cgi?id=123131.
218
219         Reviewed by Geoffrey Garen.
220
221         Updated these files to allow database quotas to grow within a limit for
222         testing purposes.
223
224         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
225         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
226         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
227         (onExceededDatabaseQuota):
228         * DumpRenderTree/mac/UIDelegate.mm:
229         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
230         * DumpRenderTree/win/UIDelegate.cpp:
231         (UIDelegate::exceededDatabaseQuota):
232         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
233         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
234         * WebKitTestRunner/TestController.cpp:
235         (WTR::exceededDatabaseQuota):
236
237 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
238
239         It's valid to have a build ID of 0.
240
241         Reviewed by Tim Hatcher.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
244         (BuildbotIteration):
245
246 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
247
248         Remove Lion bots from the Dashboard.
249
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
251         (WebKitBuildbot):
252
253 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
254
255         [GTK] Expose image links properly
256         https://bugs.webkit.org/show_bug.cgi?id=84044
257
258         Reviewed by Chris Fleizach.
259
260         Expose the accessible URL if present, as yet another attribute
261         for the AccessibilityUIElement wrapper. For coherence with what
262         the Mac port does (and what you would expect as the output of
263         the layout test), we strip the absolute URL path for relative
264         references, if it's the case, leaving the base of the URL path
265         out of the exposed string.
266
267         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
268         (attributesOfElement): Print the AXURL, if available.
269         (AccessibilityUIElement::url): Expose the URL if present. That
270         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
271         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
272         (attributesOfElement): Print the AXURL, if available.
273         (WTR::AccessibilityUIElement::url): Expose the URL if present.
274         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
275
276 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
277
278         Remove Lion bots.
279
280         * BuildSlaveSupport/build.webkit.org-config/config.json:
281
282 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
283
284         Dashboard repaints constantly
285         https://bugs.webkit.org/show_bug.cgi?id=122133
286
287         Reviewed by Tim Horton.
288         
289         Pulsing shadows are really bad for battery life.
290
291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
292         (.status-line.bad .bubble):
293         (.status-line.bad .message):
294
295 2013-10-22  Commit Queue  <commit-queue@webkit.org>
296
297         Unreviewed, rolling out r157835.
298         http://trac.webkit.org/changeset/157835
299         https://bugs.webkit.org/show_bug.cgi?id=123192
300
301         broke 32-bit builds (Requested by smfr on #webkit).
302
303         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
304         (TestWebKitAPI::TEST):
305
306 2013-10-22  Jer Noble  <jer.noble@apple.com>
307
308         [WTF] Add a multiplication operator (and a few others) to MediaTime
309         https://bugs.webkit.org/show_bug.cgi?id=123137
310
311         Reviewed by Eric Carlson.
312
313         Add tests for new MediaTime operators.
314
315         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
316         (TestWebKitAPI::TEST):
317
318 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
319
320         Educate webkitpy about Mavericks.
321
322         Reviewed by Ryosuke Niwa.
323
324         * Scripts/webkitpy/common/system/platforminfo.py:
325         (PlatformInfo._determine_mac_version):
326         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
327         (TestPlatformInfo.test_os_version):
328         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
329         (TestExpectationParser):
330         * Scripts/webkitpy/port/builders.py:
331         * Scripts/webkitpy/port/mac.py:
332         (MacPort):
333         * Scripts/webkitpy/port/mac_unittest.py:
334         (test_versions):
335         (test_baseline_search_path):
336         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
337         (TestRebaselineTest.test_baseline_directory):
338         (TestRebaselineExpectations.test_rebaseline_expectations):
339
340 2013-10-22  Stephanie Lewis  <slewis@apple.com>
341
342         Update the build trigger list for Mavericks.
343
344         Unreviewed.
345
346         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
347         (_should_file_trigger_build):
348
349 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
350
351         Add Mavericks bots to the dashboard.
352
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
354         (WebKitBuildbot):
355
356 2013-10-22  Samuel White  <samuel_white@apple.com>
357
358         AX: Add paramAttrs to fetch start and end text markers in a given rect.
359         https://bugs.webkit.org/show_bug.cgi?id=122164
360
361         Reviewed by Chris Fleizach.
362
363         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
364
365         * DumpRenderTree/AccessibilityUIElement.cpp:
366         (endTextMarkerForBoundsCallback):
367         (startTextMarkerForBoundsCallback):
368         (AccessibilityUIElement::endTextMarkerForBounds):
369         (AccessibilityUIElement::startTextMarkerForBounds):
370         (AccessibilityUIElement::getJSClass):
371         * DumpRenderTree/AccessibilityUIElement.h:
372         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
373         (AccessibilityUIElement::endTextMarkerForBounds):
374         (AccessibilityUIElement::startTextMarkerForBounds):
375         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
376         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
377         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
378         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
379         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
381         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
382         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
383         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
384         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
385         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
386
387 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
388
389         There should be a way to specify additional repository paths in NRWT
390         https://bugs.webkit.org/show_bug.cgi?id=123135
391
392         Reviewed by Alexey Proskuryakov.
393
394         Added --additional-repository-name and --additional-repository-path options to NRWT.
395         These options allow us to submit addtional repository information, such as of Safari's
396         to the new flakiness dashboard.
397
398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
399         (parse_args):
400         * Scripts/webkitpy/port/base.py:
401         (Port.repository_paths):
402
403 2013-10-22  Commit Queue  <commit-queue@webkit.org>
404
405         Unreviewed, rolling out r157774.
406         http://trac.webkit.org/changeset/157774
407         https://bugs.webkit.org/show_bug.cgi?id=123167
408
409         causes python test to fail (Requested by smfr on #webkit).
410
411         * Scripts/webkitpy/layout_tests/controllers/manager.py:
412         (Manager.run):
413         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
414         (TestExpectations.__init__):
415         (TestExpectations._add_expectations):
416         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
417         (parse_args):
418         (_set_up_derived_options):
419
420 2013-10-22  Lucas Forschler  <lforschler@apple.com>
421
422         Prepare WebKit Buildbot master for Mavericks.
423         This adds the following bot configurations:
424             Mavericks Release/Debug builders
425             Mavericks Release/Debug WK1 Testers
426             Mavericks Release/Debug WK2 Testers
427
428         Unreviewed.
429         
430         * BuildSlaveSupport/build.webkit.org-config/config.json:
431
432 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
433
434         Run tests as if they are expected to pass when --force is given.
435         https://bugs.webkit.org/show_bug.cgi?id=112890
436
437         Reviewed by Ryosuke Niwa.
438
439         The --force switch of new-run-webkit-tests is now forces all tests to
440         be run with 'PASS' as expected result.
441
442         * Scripts/webkitpy/layout_tests/controllers/manager.py:
443         (Manager.run):
444         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
445         (TestExpectations.__init__):
446         (TestExpectations._add_expectations):
447         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
448         (parse_args):
449         (_set_up_derived_options):
450
451 2013-10-21  Mark Rowe  <mrowe@apple.com>
452
453         Add a version of WebKitSystemInterface for Mavericks.
454
455         Reviewed by Ryosuke Niwa.
456
457         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
458         * Scripts/copy-webkitlibraries-to-product-directory:
459         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
460
461 2013-10-21  Anders Carlsson  <andersca@apple.com>
462
463         Navigation policy callback not called when performing the same fragment navigation twice
464         https://bugs.webkit.org/show_bug.cgi?id=123121
465         <rdar://problem/15230466>
466
467         Reviewed by Beth Dakin.
468
469         Add a test.
470
471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
472         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
473         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
474         (+[WebKit1FragmentNavigationTestDelegate shared]):
475         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
476         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
477         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
478         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
479         (TestWebKitAPI::TEST):
480
481 2013-10-21  Dan Bernstein  <mitz@apple.com>
482
483         Style checker should allow a space after the @property keyword
484         https://bugs.webkit.org/show_bug.cgi?id=123117
485
486         Reviewed by Anders Carlsson.
487
488         * Scripts/webkitpy/style/checkers/cpp.py:
489         (check_spacing_for_function_call): Allow a space between @property and the following (
490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
491         (CppStyleTest.test_spacing_for_fncall): Added a test case.
492
493 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
494
495         [WinCairo] Build does not start.
496         https://bugs.webkit.org/show_bug.cgi?id=123059
497
498         Reviewed by Csaba Osztrogonác.
499
500         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
501
502         * Scripts/build-webkit:
503
504 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
505
506         [Jhbuild] Bump the required Jhbuild revision
507         https://bugs.webkit.org/show_bug.cgi?id=123089
508
509         Reviewed by Carlos Garcia Campos.
510
511         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
512         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
513         in the Jhbuild source so a more recent revision of it should be used.
514
515 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
516
517         Mac build fix.
518
519         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
520
521 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
522
523         Enable webaudio/ tests on DRT/Mac
524         https://bugs.webkit.org/show_bug.cgi?id=86914
525
526         Reviewed by Darin Adler.
527
528         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
529         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
530         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
531         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
532
533         * DumpRenderTree/TestRunner.cpp:
534         (setAudioResultCallback): 
535         (TestRunner::staticFunctions):
536         * DumpRenderTree/TestRunner.h:
537         (TestRunner::audioResult):
538         (TestRunner::setAudioResult):
539         The function has a different name and argument type now, updated accordingly.
540         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
541
542         * DumpRenderTree/mac/DumpRenderTree.mm:
543         (dumpAudio): Updated for the new name of audioResult accessor.
544         (dump): Print the result in the format webkitpy currently expects.
545
546         * WebKitTestRunner/TestInvocation.cpp:
547         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
548         chunks made no sense.
549
550         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
551         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
552
553         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
554         so that "SourceProvider.h" can be found.
555
556 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
557
558         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
559         https://bugs.webkit.org/show_bug.cgi?id=123070
560
561         Reviewed by Alexey Proskuryakov.
562
563         * Scripts/webkitpy/layout_tests/controllers/manager.py:
564         (Manager.run):
565         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
566         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
567         in the test expectations when this argument is set to true.
568
569 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
570
571         Mac DumpRenderTree builds without NDEBUG even in release mode
572         https://bugs.webkit.org/show_bug.cgi?id=123066
573
574         Reviewed by Dan Bernstein.
575
576         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
577         * DumpRenderTree/mac/Configurations/Base.xcconfig:
578         Use the same pattern as WebCore and WebKitTestRunner.
579
580 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
581
582         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
583         https://bugs.webkit.org/show_bug.cgi?id=123064
584
585         Reviewed by Ryosuke Niwa.
586
587         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
588
589         * Scripts/webkitpy/common/config/ports.py: Added.
590         (DeprecatedPort):
591         (DeprecatedPort.name):
592         (DeprecatedPort.flag):
593         (DeprecatedPort.script_path):
594         (DeprecatedPort.script_shell_command):
595         (DeprecatedPort.port):
596         (DeprecatedPort.makeArgs):
597         (DeprecatedPort.update_webkit_command):
598         (DeprecatedPort.check_webkit_style_command):
599         (DeprecatedPort.prepare_changelog_command):
600         (DeprecatedPort.build_webkit_command):
601         (DeprecatedPort.run_javascriptcore_tests_command):
602         (DeprecatedPort.run_webkit_unit_tests_command):
603         (DeprecatedPort.run_webkit_tests_command):
604         (DeprecatedPort.run_python_unittests_command):
605         (DeprecatedPort.run_perl_unittests_command):
606         (DeprecatedPort.run_bindings_tests_command):
607         (MacPort):
608         (MacWK2Port):
609         (MacWK2Port.run_webkit_tests_command):
610         (WinPort):
611         (WinPort.run_bindings_tests_command):
612         (GtkPort):
613         (GtkPort.build_webkit_command):
614         (GtkPort.run_webkit_tests_command):
615         (GtkWK2Port):
616         (GtkWK2Port.build_webkit_command):
617         (GtkWK2Port.run_webkit_tests_command):
618         (QtPort):
619         (QtPort.build_webkit_command):
620         (QtPort.run_webkit_tests_command):
621         (QtWK2Port):
622         (QtWK2Port.build_webkit_command):
623         (QtWK2Port.run_webkit_tests_command):
624         (EflPort):
625         (EflPort.build_webkit_command):
626         (EflWK2Port):
627         (EflWK2Port.build_webkit_command):
628         * Scripts/webkitpy/common/config/ports_mock.py: Added.
629         (MockPort):
630         (MockPort.name):
631         (MockPort.check_webkit_style_command):
632         (MockPort.update_webkit_command):
633         (MockPort.build_webkit_command):
634         (MockPort.prepare_changelog_command):
635         (MockPort.run_python_unittests_command):
636         (MockPort.run_perl_unittests_command):
637         (MockPort.run_javascriptcore_tests_command):
638         (MockPort.run_webkit_unit_tests_command):
639         (MockPort.run_webkit_tests_command):
640         (MockPort.run_bindings_tests_command):
641         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
642         (DeprecatedPortTest):
643         (DeprecatedPortTest.test_mac_port):
644         (DeprecatedPortTest.test_gtk_port):
645         (DeprecatedPortTest.test_gtk_wk2_port):
646         (DeprecatedPortTest.test_efl_port):
647         (DeprecatedPortTest.test_qt_port):
648         (DeprecatedPortTest.test_qt_wk2_port):
649         * Scripts/webkitpy/port/base.py:
650         (Port._port_flag_for_scripts):
651         (Port._wk2_port_name):
652         * Scripts/webkitpy/port/base_unittest.py:
653         (PortTest.test_build_path):
654         * Scripts/webkitpy/port/efl_unittest.py:
655         (EflPortTest.test_show_results_html_file):
656         * Scripts/webkitpy/port/gtk_unittest.py:
657         (GtkPortTest.test_get_crash_log):
658         * Scripts/webkitpy/port/mac_unittest.py:
659         (test_64bit):
660         * Scripts/webkitpy/port/test.py:
661         (TestPort.virtual_test_suites):
662         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
663         (FlakyTestReporter.__init__):
664         * Scripts/webkitpy/tool/bot/irc_command.py:
665         (Rollout._update_working_copy):
666         * Scripts/webkitpy/tool/commands/download_unittest.py:
667         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
668         (AbstractEarlyWarningSystem.run_command):
669         * Scripts/webkitpy/tool/commands/queues.py:
670         (PatchProcessingQueue.begin_work_queue):
671         (CommitQueue.run_command):
672         * Scripts/webkitpy/tool/main.py:
673         (WebKitPatch.__init__):
674         (WebKitPatch.deprecated_port):
675         (WebKitPatch.handle_global_options):
676         * Scripts/webkitpy/tool/mocktool.py:
677         (MockTool.__init__):
678         (MockTool.deprecated_port):
679         * Scripts/webkitpy/tool/steps/build.py:
680         (Build.build):
681         * Scripts/webkitpy/tool/steps/checkstyle.py:
682         (CheckStyle.run):
683         * Scripts/webkitpy/tool/steps/commit.py:
684         (Commit._check_test_expectations):
685         * Scripts/webkitpy/tool/steps/preparechangelog.py:
686         (PrepareChangeLog.run):
687         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
688         (PrepareChangeLogForRevert.run):
689         * Scripts/webkitpy/tool/steps/runtests.py:
690         (RunTests.run):
691         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
692         (RunTestsTest.test_webkit_run_unit_tests):
693         * Scripts/webkitpy/tool/steps/steps_unittest.py:
694         (StepsTest.test_runtests_args):
695         * Scripts/webkitpy/tool/steps/update.py:
696         (Update._update_command):
697         * Scripts/webkitpy/tool/steps/update_unittest.py:
698         (UpdateTest.test_update_command_non_interactive):
699         (UpdateTest.test_update_command_interactive):
700
701 2013-10-19  Andreas Kling  <akling@apple.com>
702
703         RefPtr::releaseNonNull() incorrectly increments the refcount.
704         <https://webkit.org/b/123063>
705
706         Add an API test to verify that no extra refs are added when calling
707         RefPtr::releaseNonNull().
708
709         Reviewed by Anders Carlsson.
710
711 2013-10-18  Rik Cabanier <cabanier@adobe.com>
712         Add Rik Cabanier to list of committers
713         https://bugs.webkit.org/show_bug.cgi?id=123031
714
715         reviewed by Dirk Schulze.
716
717         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
718
719 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
720
721         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
722         https://bugs.webkit.org/show_bug.cgi?id=122970
723
724         Reviewed by Mario Sanchez Prada.
725
726         Removed an invalid signal to set an object state to layout-complete
727         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
728
729         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
730         (axObjectEventListener): Replaced layout-complete with load-complete.
731         (connectAccessibilityCallbacks): Connect callback to new listener for
732         ATK:AtkDocument:load-complete.
733         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
734         for ATK:AtkDocument:load-complete.
735         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
736         (axObjectEventListener): Replaced layout-complete with load-complete.
737         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
738         Connect callback to new listener for ATK:AtkDocument:load-complete.
739         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
740         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
741
742 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
743
744         [GTK] Generate API documentation for GObject DOM bindings
745         https://bugs.webkit.org/show_bug.cgi?id=121538
746
747         Reviewed by Gustavo Noronha Silva.
748
749         The .symbols file that is now generated for checking GObject DOM
750         bindings API compatibility while building can also be used to
751         generate the files needed to produce the gtk-doc
752         documentation. The new script generate-webkitdom-doc-files can
753         generate the docs.sgml and sections.txt files from the given list
754         of .symbols files.
755
756         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
757         and webkitdomgtk-sections.txt as well as rules to install the
758         generated WebKitDOMGTK documentation.
759         * gtk/generate-gtkdoc:
760         (webkitdom_docs_html_path): New helper function that returns the
761         path where the DOM API documentation has been generated.
762         (get_webkit2_options): Include DOM API docs to the list of xref
763         dependencies.
764         (get_webkit1_options): Ditto.
765         (get_webkitdom_options): Return the gtk-doc options to generate
766         the DOM API docs.
767         (get_webkitdom_options.derived_sources_path):
768         (get_webkitdom_options.src_path):
769         * gtk/generate-webkitdom-doc-files: Added.
770         (WebKitDOMDocGenerator):
771         (WebKitDOMDocGenerator.write_header):
772         (WebKitDOMDocGenerator.write_section):
773         (WebKitDOMDocGenerator.write_footer):
774         (WebKitDOMDocGeneratorDocs):
775         (WebKitDOMDocGeneratorDocs.write_header):
776         (write_section):
777         (write_footer):
778         (WebKitDOMDocGeneratorSections):
779         (WebKitDOMDocGeneratorSections.__init__):
780         (WebKitDOMDocGeneratorSections._dom_class):
781         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
782         (WebKitDOMDocGeneratorSections._symbol_list):
783         (WebKitDOMDocGeneratorSections.write_section):
784
785 2013-10-17  Alex Christensen  <achristensen@webkit.org>
786
787         Run JavaScriptCore tests again on Windows.
788         https://bugs.webkit.org/show_bug.cgi?id=122787
789
790         Reviewed by Tim Horton.
791
792         * Scripts/build-jsc:
793         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
794         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
795         * Scripts/webkitdirs.pm:
796         (determineConfigurationForVisualStudio):
797         (determineConfigurationProductDir):
798         Build directory should end with bin64 and configuration should end with |x64 on Win64.
799         (isAppleWinWebKit):
800         (copyInspectorFrontendFiles):
801         (setPathForRunningWebKitApp):
802         Separated WinCairo directories and options from AppleWin.
803
804 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
805
806         Unreviewed. Add myself as a reviewer.
807
808         * Scripts/webkitpy/common/config/contributors.json:
809
810 2013-10-17  Andreas Kling  <akling@apple.com>
811
812         Make it possible to assign a PassRef to a RefPtr.
813         <https://webkit.org/b/122943>
814
815         Added a small API test for RefPtr=(PassRef) so we know this code
816         will compile (and work.)
817
818         Reviewed by Antti Koivisto.
819
820 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
821
822         We need test coverage for just the Baseline JIT
823         https://bugs.webkit.org/show_bug.cgi?id=122929
824
825         Reviewed by Sam Weinig.
826         
827         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
828         variant.
829
830         * Scripts/run-jsc-stress-tests:
831
832 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
833
834         Support multiple repositories in submitting results to --results-server-host
835         https://bugs.webkit.org/show_bug.cgi?id=122935
836
837         Reviewed by Anders Carlsson.
838
839         Remoevd --got-revision and added the logic to extract revision information
840         from multiple repositories as done in run-perf-tests.
841
842         * Scripts/webkitpy/layout_tests/controllers/manager.py:
843         (Manager.upload_results):
844         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
845         (parse_args):
846
847 2013-10-16  Darin Adler  <darin@apple.com>
848
849         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
850         https://bugs.webkit.org/show_bug.cgi?id=122904
851
852         Reviewed by Anders Carlsson.
853
854         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
855
856 2013-10-16  Darin Adler  <darin@apple.com>
857
858         Need tests for RefPtr self-assignment and self-move-assignment.
859
860         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
861
862 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
863
864         [EFL] Minibrowser can't load child window's location
865         https://bugs.webkit.org/show_bug.cgi?id=122485
866
867         Reviewed by Gyuyoung Kim.
868
869         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
870             followed by an explicit call to ewk_view_url_set() where appropriate.
871         (on_key_down):
872         (on_window_create):
873         (window_create):
874         (elm_main):
875
876 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
877
878         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
879         https://bugs.webkit.org/show_bug.cgi?id=122872
880
881         Reviewed by Anders Carlsson.
882
883         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
884         failing.
885
886 2013-10-15  Dean Jackson  <dino@apple.com>
887
888         Add ENABLE_WEB_ANIMATIONS flag
889         https://bugs.webkit.org/show_bug.cgi?id=122871
890
891         Reviewed by Tim Horton.
892
893         Eventually might be http://dev.w3.org/fxtf/web-animations/
894         but this is just engine-internal work at the moment.
895
896         * Scripts/webkitperl/FeatureList.pm:
897
898 2013-10-15  Darin Adler  <darin@apple.com>
899
900         Add some API tests for Vector, RefPtr, and Ref
901         https://bugs.webkit.org/show_bug.cgi?id=122840
902
903         Reviewed by Andreas Kling.
904
905         * TestWebKitAPI/CMakeLists.txt: Added new files.
906         * TestWebKitAPI/GNUmakefile.am: Ditto.
907         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
908         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
910
911         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
912         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
913         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
914         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
915
916 2013-10-14  Roger Fong  <roger_fong@apple.com>
917
918         Adding myself to CC list for some components.
919
920         * Scripts/webkitpy/common/config/watchlist:
921
922 2013-10-13  Darin Adler  <darin@apple.com>
923
924         Deprecate or remove deleteAllValues functions; there are only a few call sites left
925         https://bugs.webkit.org/show_bug.cgi?id=122738
926
927         Reviewed by Anders Carlsson.
928
929         * DumpRenderTree/win/DRTDataObject.cpp:
930         (DRTDataObject::~DRTDataObject):
931         * DumpRenderTree/win/UIDelegate.cpp:
932         (DRTUndoStack::~DRTUndoStack):
933         (DRTUndoStack::clear):
934         Renamed deleteAllValues to deprecatedDeleteAllValues.
935
936         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
937
938 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
939
940         build.webkit.org/dashboard incorrectly shows interrupted builds as green
941         https://bugs.webkit.org/show_bug.cgi?id=122732
942
943         Reviewed by Tim Hatcher.
944
945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
946         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
947         I don't see it occur any time in recent history, but judging from what happens for
948         status 5 (RETRY), we can just finish this function normally.
949         Record overall text description for iteration as BuildbotIteration.text.
950
951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
952         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
953         but no tests failed, make it yellow, and use buildbot-provided description for it.
954
955 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
956
957         Remove Chromium specific code from flakiness dashboard
958         https://bugs.webkit.org/show_bug.cgi?id=122714
959
960         Reviewed by Sam Weinig.
961
962         Also removed code related to GPU tests and virtual suites.
963         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
964
965         * TestResultServer/model/jsonresults_unittest.py:
966         * TestResultServer/static-dashboards/builders.js:
967         * TestResultServer/static-dashboards/dashboard_base.js:
968         * TestResultServer/static-dashboards/flakiness_dashboard.html:
969         * TestResultServer/static-dashboards/flakiness_dashboard.js:
970         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
971         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
972         * TestResultServer/static-dashboards/history.js:
973         * TestResultServer/static-dashboards/loader.js:
974         * TestResultServer/static-dashboards/ui.js:
975         * TestResultServer/templates/uploadform.html:
976
977 2013-10-11  Timothy Hatcher  <timothy@apple.com>
978
979         Remove preference support for picking the old Web Inspector.
980         https://bugs.webkit.org/show_bug.cgi?id=122655
981
982         Reviewed by Alexey Proskuryakov.
983
984         * WebKitTestRunner/TestController.cpp:
985         (WTR::TestController::resetStateToConsistentValues):
986
987 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
988
989         Fix 64-bit build on everything but Windows.
990
991         Rubber stamped by Brent Fulgham.
992
993         * Scripts/webkitdirs.pm:
994         (argumentsForConfiguration):
995
996 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
997
998         Touch a file to see how auto-update works.
999
1000         Rubber-stamped by Tim Hatcher.
1001
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1003
1004 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1005
1006         LeaksViewer fails to present recent results list if current build is still updating svn
1007         https://bugs.webkit.org/show_bug.cgi?id=122670
1008
1009         Fixed an obvious mistake in the previous patch.
1010
1011         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1012         (RecentBuildsLoader.prototype.start):
1013
1014 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1015
1016         LeaksViewer fails to present recent results list if current build is still updating svn
1017         https://bugs.webkit.org/show_bug.cgi?id=122670
1018
1019         Reviewed by Adam Roben.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1022         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
1023
1024 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
1025
1026         Unreviewed build fix for --64-bit target.
1027
1028         * Scripts/webkitdirs.pm:
1029         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
1030         been removed by this point.
1031         (hasArgument): Remove unused temporary.
1032
1033 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1034
1035         webkit-patch failure-reason has a quite low limit for 'too many failures'
1036         https://bugs.webkit.org/show_bug.cgi?id=122556
1037
1038         Reviewed by Darin Adler.
1039
1040         * Scripts/webkitpy/tool/commands/queries.py:
1041         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
1042         to match what the layout test runners use these days.
1043
1044 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1045
1046         webkit-patch failure-reason should allow specifying failures one is interested in
1047         https://bugs.webkit.org/show_bug.cgi?id=122554
1048
1049         Reviewed by Darin Adler.
1050
1051         * Scripts/webkitpy/tool/commands/queries.py:
1052         (FailureReason):
1053         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
1054         loop if the ones we're interested in been explained.
1055         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1056         (FailureReason.execute): initialize failures to explain and the explained set.
1057
1058 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1059
1060         Make sure that DataTypes.h is in the binary drop.
1061
1062         Rubber stamped by Michael Saboff.
1063
1064         * Scripts/export-llvm-build:
1065
1066 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1067
1068         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1069         https://bugs.webkit.org/show_bug.cgi?id=122566
1070
1071         Reviewed by Mark Rowe.
1072
1073         * Scripts/configure-llvm:
1074
1075 2013-10-10  Mark Rowe  <mrowe@apple.com>
1076
1077         <rdar://problem/13341666> WebKit should always build against an SDK.
1078
1079         Have all projects default to building against the OS X Internal SDK for the Production
1080         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1081         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1082
1083         Reviewed by Dan Bernstein.
1084
1085         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1086         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1087         * MiniBrowser/Configurations/Base.xcconfig:
1088         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1089         * TestWebKitAPI/Configurations/Base.xcconfig:
1090         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1091         * WebKitTestRunner/Configurations/Base.xcconfig:
1092         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1093
1094 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1095
1096         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1097
1098         * Scripts/run-gtk-tests:
1099         (TestRunner): skip TestInspectorServer.
1100
1101 2013-10-10  Andres Gomez  <agomez@igalia.com>
1102
1103         [GTK] Provide search functionality to MiniBrowser
1104         https://bugs.webkit.org/show_bug.cgi?id=117631
1105
1106         Reviewed by Carlos Garcia Campos.
1107
1108         Adds a search bar to MiniBrowser with the minimum functionality
1109         and a new button to the toolbar for showing the new search
1110         bar. Typical keyboard shortcuts are also added.
1111
1112         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1113         (doSearch):
1114         (searchNext):
1115         (searchPrevious):
1116         (searchCloseButtonClickedCallback):
1117         (searchEntryMenuIconPressedCallback):
1118         (searchEntryClearIconReleasedCallback):
1119         (searchEntryChangedCallback):
1120         (searchEntryActivatedCallback):
1121         (searchPrevButtonClickedCallback):
1122         (searchNextButtonClickedCallback):
1123         (searchMenuCheckButtonToggledCallback):
1124         (browser_search_bar_init):
1125         (browserSearchBarFinalize):
1126         (browser_search_bar_class_init):
1127         (browser_search_bar_new):
1128         (browser_search_bar_add_accelerators):
1129         (browser_search_bar_open):
1130         (browser_search_bar_close):
1131         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1132         * MiniBrowser/gtk/BrowserWindow.c:
1133         (webViewEnterFullScreen): Closes new search bar.
1134         (webViewLeaveFullScreen): Opens new search bar if previously
1135         visible.
1136         (searchCallback): Added. Shows and hides the new search bar.
1137         (browser_window_init): Added search button to the toolbar.
1138         (browserWindowConstructed): Creates the new search bar.
1139         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1140
1141 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1142
1143         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1144         https://bugs.webkit.org/show_bug.cgi?id=122552
1145
1146         Reviewed by Darin Adler.
1147
1148         * Scripts/webkitpy/common/checkout/commitinfo.py:
1149         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1150         will cause UnicodeDecodeError for non-ascii characters.
1151
1152 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1153
1154         Would like a link to dashboard from build.webkit.org main page
1155         https://bugs.webkit.org/show_bug.cgi?id=122577
1156
1157         Reviewed by Tim Hatcher.
1158
1159         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1160
1161 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1162
1163         [Win] Check for MathML fonts and warn user if they are missing.
1164         https://bugs.webkit.org/show_bug.cgi?id=122568
1165
1166         Reviewed by Tim Horton.
1167
1168         * Scripts/webkitdirs.pm:
1169         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1170         Windows-specific code I added previously.
1171         (fontExists): Added
1172         (checkInstalledTools): Add check for MathML fonts.
1173
1174 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1175
1176         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1177         https://bugs.webkit.org/show_bug.cgi?id=122471
1178
1179         Reviewed by Tim Hatcher.
1180
1181         Added links to webkitpy, webkitperl and bindings-tests results.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1184         (Buildbot.prototype.apiTestResultsURLForIteration):
1185         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1186         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1187         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1189         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1190
1191 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1192
1193         Move some functions from WebKitBuildbot to Buildbot class.
1194
1195         Suggested by Tim Hatcher.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1198         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1199         (Buildbot.prototype.apiTestResultsURLForIteration):
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1201         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1202
1203 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1204
1205         Add API tests to the Dashbord page.
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=122283
1208
1209         Reviewed by Timothy Hatcher.
1210
1211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1212         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1214         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1215
1216 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1217
1218         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1219
1220         https://bugs.webkit.org/show_bug.cgi?id=122515
1221
1222         Reviewed by Alexey Proskuryakov.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1225         (BuildbotIteration.prototype.update):
1226
1227 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1228
1229         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1230         https://bugs.webkit.org/show_bug.cgi?id=122573
1231
1232         Reviewed by Tim Hatcher.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1235         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1238         (Buildbot.prototype.buildPageURLForIteration): Added.
1239
1240 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1241
1242         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1243         https://bugs.webkit.org/show_bug.cgi?id=122569
1244
1245         Reviewed by Tim Hatcher.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1248         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1249         to be produced by the old Mozilla test harness that we don't use any more.
1250
1251 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1252
1253         Add GTK 64 bits release to the buildbot dashboard
1254         https://bugs.webkit.org/show_bug.cgi?id=122548
1255
1256         Reviewed by Darin Adler.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1260         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1262         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1263
1264 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1265
1266         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1267         https://bugs.webkit.org/show_bug.cgi?id=120638
1268
1269         Reviewed by Gustavo Noronha Silva.
1270
1271         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1272         can check both the old and new APIs to retrieve text at a given offset.
1273
1274 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1275
1276         Improved WinLauncher.
1277         https://bugs.webkit.org/show_bug.cgi?id=122536
1278
1279         Reviewed by Brent Fulgham.
1280
1281         * WinLauncher/PrintWebUIDelegate.cpp:
1282         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1283         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1284         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1285         * WinLauncher/WinLauncher.cpp:
1286         (createCrashReport): Use the executable name instead of "WinLauncher".
1287         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1288         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1289         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1290
1291 2013-10-08  Mark Lam  <mark.lam@apple.com>
1292
1293         Fix ruby LoadError when running run-javascriptcore-tests.
1294         https://bugs.webkit.org/show_bug.cgi?id=122519.
1295
1296         Reviewed by Mark Hahnenberg.
1297
1298         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1299         (versions before 1.9).
1300
1301         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1302         * Scripts/run-jsc-stress-tests:
1303
1304 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1305
1306         Unreviewed, add my new email to contributors.json.
1307
1308         * Scripts/webkitpy/common/config/contributors.json:
1309
1310 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1311
1312         Unreviewed build correction.
1313
1314         * Scripts/webkitpy/port/win.py:
1315         (WinPort.write_registry_value): Use string representation of error message to avoid
1316         format conversion problem.
1317
1318 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1319
1320         [Win] Add checks for proper build and test environment
1321         https://bugs.webkit.org/show_bug.cgi?id=122466
1322
1323         Reviewed by Darin Adler.
1324
1325         This patch makes two changes:
1326         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1327            error messages so that people know what to fix to get things working.
1328         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1329            the various environment settings are properly configured for our test environment.
1330
1331         * Scripts/webkitdirs.pm:
1332         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1333         caused problems in the past.
1334         (setupAppleWinEnv):
1335         * Scripts/webkitpy/port/win.py:
1336         (WinPort):
1337         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1338         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1339         DWORD, etc.)
1340         (WinPort.write_registry_string): Revise to call new generic registry write function.
1341         (WinPort.setup_crash_log_saving): Revise for new API
1342         (WinPort.restore_crash_log_saving): Ditto
1343         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1344         servers from running.
1345         (WinPort.allow_error_dialogs): Ditto.
1346         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1347         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1348
1349 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1350
1351         [GStreamer] enable v4l2 plugin
1352         https://bugs.webkit.org/show_bug.cgi?id=122503
1353
1354         Reviewed by Martin Robinson.
1355
1356         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1357         we updated our GStreamer version to 1.0.8.
1358
1359 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1360
1361         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1362         https://bugs.webkit.org/show_bug.cgi?id=122104
1363
1364         Reviewed by Chris Fleizach.
1365
1366         Updated stringAttributeValue to double check that the exposure of
1367         aria-invalid as a state is consistent with its exposure as a text
1368         attribute as well, when it applies (implementations of AtkText).
1369
1370         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1371         (AccessibilityUIElement::stringAttributeValue): Add double check.
1372         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1373         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1374
1375 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1376
1377         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1378         https://bugs.webkit.org/show_bug.cgi?id=122459
1379
1380         Reviewed by Darin Adler.
1381
1382         * Scripts/run-jsc-stress-tests:
1383
1384 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1385
1386         [buildbot] parse tests that are reported as crashed correctly for GTK+
1387         https://bugs.webkit.org/show_bug.cgi?id=122476
1388
1389         Reviewed by Martin Robinson.
1390
1391         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1392         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1393         as a failure of the API tests.
1394
1395 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1396
1397         Unreviewed. Skipping API test that is causing the next one to crash,
1398         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1399
1400         * Scripts/run-gtk-tests:
1401         (TestRunner):
1402
1403 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1404
1405         [GTK] run-gtk-tests does not distinguish between failure and crashes
1406         https://bugs.webkit.org/show_bug.cgi?id=122135
1407
1408         Reviewed by Martin Robinson.
1409
1410         The GTK+ API test runner does not distinguish between failures and crashes. This change
1411         makes it do that, so it's easier for us to spot the more important/higher priority crash
1412         case.
1413
1414         * Scripts/run-gtk-tests:
1415         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1416         so we have more information on how the process ended.
1417         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1418         (TestRunner.run_tests): report crashes.
1419
1420 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1421
1422         [GTK] Missing packages for APT on install-dependencies
1423         https://bugs.webkit.org/show_bug.cgi?id=121555
1424
1425         Reviewed by Martin Robinson.
1426
1427         * gtk/install-dependencies: add packages that are needed for
1428         building WebKit itself and the jhbuild dependencies.
1429
1430 2013-10-07  Anders Carlsson  <andersca@apple.com>
1431
1432         Fix test failures.
1433
1434         * Scripts/webkitpy/port/base.py:
1435         (Port.to.start_helper):
1436         * Scripts/webkitpy/port/mock_drt.py:
1437         (MockDRTPort.start_helper):
1438
1439 2013-10-07  Anders Carlsson  <andersca@apple.com>
1440
1441         Always force discrete mode when running layout tests
1442         https://bugs.webkit.org/show_bug.cgi?id=122465
1443
1444         Reviewed by Tim Horton.
1445
1446         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1447         
1448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1449         Link with IOKit.
1450
1451         * DumpRenderTree/mac/LayoutTestHelper.m:
1452         (installLayoutTestColorProfile):
1453         Check installColorProfile.
1454
1455         (restoreUserColorProfile):
1456         Check installColorProfile.
1457
1458         (lockDownDiscreteGraphics):
1459         New function to force discrete graphics.
1460
1461         (main):
1462         Add '--install-color-profile' option.
1463
1464         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1465         (Manager._set_up_run):
1466         Always start the helper, but pass self._options.pixel_tests to it.
1467
1468         * Scripts/webkitpy/port/mac.py:
1469         (MacPort.start_helper):
1470         Pass --install-color-profile' to the helper if pixel_tests is true.
1471
1472 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1473
1474         Properly count binding test failures as failures.
1475
1476         Fix the total for multiple failures in different steps too by avoiding undefined.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=122232
1479
1480         Reviewed by Alexey Proskuryakov.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1483         (BuildbotTestResults):
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1485         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1486
1487 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1488
1489         [GTK] Fails to build with jhbuild with newer system glib
1490         https://bugs.webkit.org/show_bug.cgi?id=122132
1491
1492         Reviewed by Martin Robinson.
1493
1494         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1495         started relying on. glib is not a dependency that should change test results, and is provided in
1496         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1497         should not be an issue.
1498
1499         * gtk/jhbuild.modules:
1500
1501 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1502
1503         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1504         https://bugs.webkit.org/show_bug.cgi?id=122437
1505
1506         Reviewed by Antoine Quint.
1507
1508         * Scripts/run-jsc-stress-tests:
1509
1510 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1511
1512         Unreviewed, fix build on old Rubies.
1513
1514         * Scripts/run-jsc-stress-tests:
1515
1516 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1517
1518         Unified test infrastructure via the jsc shell
1519         https://bugs.webkit.org/show_bug.cgi?id=120696
1520
1521         Reviewed by Oliver Hunt.
1522         
1523         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1524         output (silent or noisy) and different styles of test failure (just bad exit code,
1525         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1526         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1527         running in run-jsc-stress-tests.
1528         
1529         Also removes all of the code paths that defended against not having shellwords. Just
1530         install the shellwords gem if you want to run tests.
1531         
1532         Also removes the non-parallel test running code. No reason for it to exist anymore.
1533         
1534         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1535         as part of this patch, and left three more as new bugzillas.
1536
1537         * Scripts/create-mozilla-js-test-list: Added.
1538         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1539         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1540         * Scripts/run-javascriptcore-tests:
1541         * Scripts/run-jsc-stress-tests:
1542
1543 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1544
1545         run-jsc-stress-tests should be less verbose
1546         https://bugs.webkit.org/show_bug.cgi?id=122397
1547
1548         Reviewed by Sam Weinig.
1549         
1550         It now just prints something like:
1551         
1552          965/1831 ....
1553         
1554         Where the first number is the number of tests that completed, the second number is the
1555         number of tests total, and the dots are the number of tests running right now - which is
1556         useful towards the end when you're waiting for the last slow tests to finish.
1557         
1558         It will also print out the output from failing tests and it will print a line for skipped
1559         tests (to annoy you into getting them into a shape where they can be unskipped). For
1560         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1561
1562         * Scripts/run-jsc-stress-tests:
1563
1564 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1565
1566         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1567         https://bugs.webkit.org/show_bug.cgi?id=122385
1568
1569         Reviewed by Sam Wieinig.
1570         
1571         Make tests run via YAML be able to do the parse-for-commands trick that allows
1572         us to skip tests and do other custom per-test stuff.
1573
1574         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1575         * Scripts/run-jsc-stress-tests:
1576
1577 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1578
1579         Unreviewed, fix tests on older Rubies.
1580
1581         * Scripts/run-jsc-stress-tests:
1582
1583 2013-10-05  Anders Carlsson  <andersca@apple.com>
1584
1585         Don't filter the weak symbols.
1586
1587         * Scripts/check-for-weak-vtables-and-externals:
1588
1589 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1590
1591         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1592         https://bugs.webkit.org/show_bug.cgi?id=122376
1593
1594         Reviewed by Mark Hahnenberg.
1595
1596         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1597         * Scripts/run-javascriptcore-tests:
1598         (printThingsFound):
1599         * Scripts/run-jsc-stress-tests:
1600
1601 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1602
1603         It should be even easier to run and debug a failing JSC stress test
1604         https://bugs.webkit.org/show_bug.cgi?id=122337
1605
1606         Reviewed by Oliver Hunt.
1607         
1608         If a test fails, you can now just say:
1609
1610         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1611
1612         and get the reproduction. You don't have to set any environment variables like before.
1613         Also if you want to debug the failing test you can now just say:
1614
1615         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1616
1617         Broadly, any arguments passed to the reproduction script are prepended to the command to
1618         run the test. This is sort of quirky and won't work for some tests (for example the
1619         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1620         them and that's good enough for now.
1621
1622         * Scripts/run-jsc-stress-tests:
1623
1624 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1625
1626         [Windows] Correct run-path when using 64-bit binaries.
1627
1628         Reviewed by David Kilzer.
1629
1630         * Scripts/webkitdirs.pm:
1631         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1632         directory. Otherwise use the existing 'bin32' directory.
1633
1634 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1635
1636         Teach webkitdirs.pm to honor the --64-bit flag
1637         https://bugs.webkit.org/show_bug.cgi?id=122357
1638
1639         Reviewed by David Kilzer.
1640
1641         * Scripts/webkitdirs.pm:
1642         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1643         by the user.
1644         (findMatchingArguments): Added.
1645         (hasArgument): Added.
1646         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1647         findMatchingArguments subroutine.
1648
1649 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1650
1651         Update svn-config for new Visual Studio extensions
1652         https://bugs.webkit.org/show_bug.cgi?id=122344
1653
1654         Reviewed by Brent Fulgham.
1655
1656         * svn-config: Add new Visual Studio extensions.
1657
1658 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1659
1660         Made WinLauncher have better error handling, crash reporting, and modifiability.
1661         https://bugs.webkit.org/show_bug.cgi?id=122319
1662
1663         Reviewed by Brent Fulgham.
1664
1665         * WinLauncher/WinLauncher.cpp:
1666         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1667         Don't display the numerous "Cancelled" messages that are obviously from the user.
1668         (createCrashReport): Added.
1669         (dllLauncherEntryPoint):
1670         Made main loop back into while loop and write a crash report if it crashes.
1671         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1672         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1673         Added WinLauncherReplace.h.
1674         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1675         Added linking to DbgHelp.lib.
1676         * WinLauncher/WinLauncherReplace.h:
1677         Added to make modifying WinLauncher behaviour and appearance easy.
1678         (processCrashDump): Added.
1679
1680 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1681
1682         remove dpranke from webkitpy watchlist
1683         https://bugs.webkit.org/show_bug.cgi?id=122331
1684
1685         Reviewed by Brent Fulgham.
1686
1687         * Scripts/webkitpy/common/config/watchlist:
1688
1689 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1690
1691         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1692         https://bugs.webkit.org/show_bug.cgi?id=122299
1693
1694         Reviewed by Beth Dakin.
1695
1696         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1697         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1698         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1699
1700 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1701
1702         Watchlist is broken after <http://trac.webkit.org/r156880>
1703
1704         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1705
1706 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1707
1708         Remove Qt features from build and test tools
1709         https://bugs.webkit.org/show_bug.cgi?id=122312
1710
1711         Reviewed by Anders Carlsson.
1712
1713         * Scripts/build-dumprendertree:
1714         * Scripts/build-jsc:
1715         * Scripts/build-webkit:
1716         * Scripts/build-webkittestrunner:
1717         * Scripts/old-run-webkit-tests:
1718         (openDumpTool):
1719         (buildPlatformResultHierarchy):
1720         (buildPlatformTestHierarchy):
1721         (readSkippedFiles):
1722         * Scripts/run-launcher:
1723         * Scripts/run-qtwebkit-tests: Removed.
1724         * Scripts/run-webkit-tests:
1725         (useNewRunWebKitTests):
1726         * Scripts/update-webkit:
1727         * Scripts/webkit-build-directory:
1728         * Scripts/webkitdirs.pm:
1729         (argumentsForConfiguration):
1730         (jscProductDir):
1731         (builtDylibPathForName):
1732         (isAppleWebKit):
1733         (launcherPath):
1734         (launcherName):
1735         (checkRequiredSystemConfig):
1736         (setupCygwinEnv):
1737         (copyInspectorFrontendFiles):
1738         (setPathForRunningWebKitApp):
1739         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1740         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1741         (BaselineOptimizerTest.test_mac_future):
1742         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1743         (BaselineOptimizerTest.test_common_directory_includes_root):
1744         (BaselineOptimizerTest.test_virtual_ports_filtered):
1745         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1746         (test_parse_reviewer_text):
1747         * Scripts/webkitpy/common/config/watchlist:
1748         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1749         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1750         * Scripts/webkitpy/port/base.py:
1751         (Port.__init__):
1752         (Port._port_flag_for_scripts):
1753         (Port._wk2_port_name):
1754         * Scripts/webkitpy/port/builders.py:
1755         * Scripts/webkitpy/port/factory.py:
1756         (platform_options):
1757         (PortFactory):
1758         (PortFactory._default_port):
1759         * Scripts/webkitpy/port/factory_unittest.py:
1760         (FactoryTest.test_gtk):
1761         * Scripts/webkitpy/port/qt.py: Removed.
1762         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1763         * Scripts/webkitpy/style/checker.py:
1764         * Scripts/webkitpy/style/checker_unittest.py:
1765         (GlobalVariablesTest.test_path_rules_specifier):
1766         * Scripts/webkitpy/style/checkers/cmake.py:
1767         (CMakeChecker):
1768         * Scripts/webkitpy/style/checkers/cpp.py:
1769         (_classify_include):
1770         (check_include_line):
1771         (check_identifier_name_in_declaration):
1772         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1773         (OrderOfIncludesTest.test_classify_include):
1774         (WebKitStyleTest.test_names):
1775         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1776         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1777         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1778         (TestRebaselineTest.test_baseline_directory):
1779         * Scripts/webkitpy/tool/main.py:
1780         (WebKitPatch):
1781
1782 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1783
1784         Unreviewed. Add myself to some watchlists.
1785
1786         * Scripts/webkitpy/common/config/watchlist:
1787
1788 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1789
1790         Remove Qt builders from the flakiness dashboard.
1791
1792         * TestResultServer/static-dashboards/builders.jsonp:
1793         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1794         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1795         * TestResultServer/static-dashboards/loader_unittests.js:
1796
1797 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1798
1799         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1800         https://bugs.webkit.org/show_bug.cgi?id=122299
1801
1802         Reviewed by Beth Dakin.
1803
1804         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1805         Disable threaded scrolling.
1806
1807         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1808         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1809         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1810
1811 2013-10-03  Anders Carlsson  <andersca@apple.com>
1812
1813         Use numeric strings in the OS version dictionary
1814         https://bugs.webkit.org/show_bug.cgi?id=122300
1815
1816         Reviewed by Mark Rowe.
1817
1818         * Scripts/webkitpy/common/system/platforminfo.py:
1819         (PlatformInfo._determine_mac_version):
1820
1821 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1822
1823         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1824
1825         Rubber-stamped by Tim Horton.
1826
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1828         (LeaksViewer._displayURLPrompt):
1829
1830 2013-10-03  Dan Bernstein  <mitz@apple.com>
1831
1832         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1833         https://bugs.webkit.org/show_bug.cgi?id=122260
1834
1835         Reviewed by Alexey Proskuryakov.
1836
1837         For the API to work, the tests need to be compiled with a newer version of the LLVM
1838         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1839
1840         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1841
1842 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1843
1844         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1845         https://bugs.webkit.org/show_bug.cgi?id=122015
1846
1847         Reviewed by Chris Fleizach.
1848
1849         Adapted DRT and WKTR to check the exposure of the aria-invalid
1850         attribute as a text attribute, instead of an object attribute.
1851
1852         Also, done some refactoring of the code to try to keep things
1853         simpler and more coherent, by defining new helper functions,
1854         simplifying code, moving static variables and functions into
1855         unnammed namespaces and so on, without altering the logic other
1856         than for checking the text attribute for aria-invalid.
1857
1858         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1859         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1860         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1861         Also, never return an empty string if not falling through any of
1862         the cases checked here, and return the original attribute instead.
1863         (atkAttributeValueToCoreAttributeValue): New helper function to
1864         match the attributes values returned by the ATK wrapper with the
1865         values expected by the layout tests. Moved the mappings for the
1866         values of AXSortDirection here as well.
1867         (getAttributeSet): New helper function to retrieve a list of
1868         attributes (an AtkAttributeSet) from an AtkObject using the right
1869         API depending on whether we want the object attributes or the text
1870         attributes (in case the object implements AtkText).
1871         (getAttributeSetValueForId): Simplified by using getAttributeSet
1872         and atkAttributeValueToCoreAttributeValue. Also, added a new
1873         parameter to indicater whether we are interested in object
1874         attributes or text attributes.
1875         (getAtkAttributeSetAsString): Ditto.
1876         (attributesOfElement): Updated to pass the new required parameter
1877         to getAtkAttributeSetAsString, indicating that we want the object
1878         attributes in this case, for backwards compatibility.
1879         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1880         (alterCurrentValue): Ditto.
1881         (AccessibilityUIElement::stringAttributeValue): After moving most
1882         of the code here to the new helper functions, simplified it by
1883         just checking whether the required attribute is provided as an
1884         object attribute or, if that's not the case, as a text attribute.
1885         (AccessibilityUIElement::isAttributeSupported): Ditto.
1886         (AccessibilityUIElement::intValue): Updated to pass the new
1887         required parameter to getAttributeSetValueForId, indicating that
1888         we want the object attributes in this case.
1889         (AccessibilityUIElement::hasPopup): Ditto.
1890
1891         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1892         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1893         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1894         (WTR::getAttributeSet): Ditto.
1895         (WTR::getAttributeSetValueForId): Ditto.
1896         (WTR::getAtkAttributeSetAsString): Ditto.
1897         (WTR::attributesOfElement): Ditto.
1898         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1899         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1900         (WTR::AccessibilityUIElement::intValue): Ditto.
1901         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1902
1903 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1904
1905         EWS build fix after the Qt EWS removal.
1906
1907         * QueueStatusServer/model/attachment.py:
1908         (Attachment._calculate_queue_positions):
1909
1910 2013-10-02  Anders Carlsson  <andersca@apple.com>
1911
1912         Remove Qt code from Tools/
1913         https://bugs.webkit.org/show_bug.cgi?id=122227
1914
1915         Reviewed by Andreas Kling.
1916
1917         * DumpRenderTree/WorkQueue.cpp:
1918         * DumpRenderTree/blackberry/src.pro: Removed.
1919         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1920         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1921         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1922         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1923         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1924         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1925         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1926         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1927         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1928         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1929         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1930         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1931         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1932         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1933         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1934         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1935         * DumpRenderTree/qt/resources/user.css: Removed.
1936         * DumpRenderTree/qt/testplugin.cpp: Removed.
1937         * DumpRenderTree/qt/testplugin.h: Removed.
1938         * ImageDiff/ImageDiff.pro: Removed.
1939         * ImageDiff/qt/ImageDiff.cpp: Removed.
1940         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1941         * MiniBrowser/qt/BrowserWindow.h: Removed.
1942         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1943         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1944         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1945         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1946         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1947         * MiniBrowser/qt/UrlLoader.h: Removed.
1948         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1949         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1950         * MiniBrowser/qt/icons/contents_width.png: Removed.
1951         * MiniBrowser/qt/icons/favicon.png: Removed.
1952         * MiniBrowser/qt/icons/find.png: Removed.
1953         * MiniBrowser/qt/icons/folder.png: Removed.
1954         * MiniBrowser/qt/icons/info.png: Removed.
1955         * MiniBrowser/qt/icons/next.png: Removed.
1956         * MiniBrowser/qt/icons/plus.png: Removed.
1957         * MiniBrowser/qt/icons/previous.png: Removed.
1958         * MiniBrowser/qt/icons/refresh.png: Removed.
1959         * MiniBrowser/qt/icons/stop.png: Removed.
1960         * MiniBrowser/qt/icons/titlebar.png: Removed.
1961         * MiniBrowser/qt/icons/touch.png: Removed.
1962         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1963         * MiniBrowser/qt/icons/up.png: Removed.
1964         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1965         * MiniBrowser/qt/main.cpp: Removed.
1966         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1967         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1968         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1969         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1970         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1971         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1972         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1973         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1974         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1975         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1976         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1977         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1978         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1979         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1980         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1981         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1982         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1983         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1984         * MiniBrowser/qt/raw/Target.pri: Removed.
1985         * MiniBrowser/qt/raw/View.cpp: Removed.
1986         * MiniBrowser/qt/raw/View.h: Removed.
1987         * MiniBrowser/qt/utils.cpp: Removed.
1988         * MiniBrowser/qt/utils.h: Removed.
1989         * QtTestBrowser/QtTestBrowser.pro: Removed.
1990         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1991         * QtTestBrowser/cookiejar.cpp: Removed.
1992         * QtTestBrowser/cookiejar.h: Removed.
1993         * QtTestBrowser/favicon.png: Removed.
1994         * QtTestBrowser/fpstimer.cpp: Removed.
1995         * QtTestBrowser/fpstimer.h: Removed.
1996         * QtTestBrowser/launcherwindow.cpp: Removed.
1997         * QtTestBrowser/launcherwindow.h: Removed.
1998         * QtTestBrowser/locationedit.cpp: Removed.
1999         * QtTestBrowser/locationedit.h: Removed.
2000         * QtTestBrowser/mainwindow.cpp: Removed.
2001         * QtTestBrowser/mainwindow.h: Removed.
2002         * QtTestBrowser/qttestbrowser.cpp: Removed.
2003         * QtTestBrowser/urlloader.cpp: Removed.
2004         * QtTestBrowser/urlloader.h: Removed.
2005         * QtTestBrowser/useragentlist.txt: Removed.
2006         * QtTestBrowser/utils.cpp: Removed.
2007         * QtTestBrowser/utils.h: Removed.
2008         * QtTestBrowser/webinspector.h: Removed.
2009         * QtTestBrowser/webpage.cpp: Removed.
2010         * QtTestBrowser/webpage.h: Removed.
2011         * QtTestBrowser/webview.cpp: Removed.
2012         * QtTestBrowser/webview.h: Removed.
2013         * TestWebKitAPI/DerivedSources.pri: Removed.
2014         * TestWebKitAPI/InjectedBundle.pri: Removed.
2015         * TestWebKitAPI/PlatformWebView.h:
2016         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
2017         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
2018         * TestWebKitAPI/Tests.pri: Removed.
2019         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
2020         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2021         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
2022         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
2023         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
2024         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
2025         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
2026         * TestWebKitAPI/qt/main.cpp: Removed.
2027         * Tools.pro: Removed.
2028         * WebKitTestRunner/DerivedSources.pri: Removed.
2029         * WebKitTestRunner/EventSenderProxy.h:
2030         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
2031         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
2032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2033         (WTR::InjectedBundlePage::resetAfterTest):
2034         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2035         (WTR::InjectedBundlePage::didClearWindowForFrame):
2036         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
2037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2038         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
2039         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
2040         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
2041         * WebKitTestRunner/PlatformWebView.h:
2042         * WebKitTestRunner/Target.pri: Removed.
2043         * WebKitTestRunner/TestController.cpp:
2044         (WTR::TestController::resetStateToConsistentValues):
2045         * WebKitTestRunner/TestController.h:
2046         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
2047         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
2048         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
2049         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
2050         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
2051         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
2052         * WebKitTestRunner/qt/main.cpp: Removed.
2053         * WebKitTestRunner/qt/resources/user.css: Removed.
2054         * qmake/.qmake.cache: Removed.
2055         * qmake/.qmake.conf: Removed.
2056         * qmake/README: Removed.
2057         * qmake/config.tests/README: Removed.
2058         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2059         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2060         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2061         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2062         * qmake/config.tests/glx/glx.cpp: Removed.
2063         * qmake/config.tests/glx/glx.pro: Removed.
2064         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2065         * qmake/config.tests/gnuld/main.cpp: Removed.
2066         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2067         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2068         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2069         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2070         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2071         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2072         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2073         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2074         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2075         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2076         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2077         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2078         * qmake/dump-features.pl: Removed.
2079         * qmake/mkspecs/features/configure.prf: Removed.
2080         * qmake/mkspecs/features/default_post.prf: Removed.
2081         * qmake/mkspecs/features/default_pre.prf: Removed.
2082         * qmake/mkspecs/features/features.prf: Removed.
2083         * qmake/mkspecs/features/features.pri: Removed.
2084         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2085         * qmake/mkspecs/features/functions.prf: Removed.
2086         * qmake/mkspecs/features/gprof.prf: Removed.
2087         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2088         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2089         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2090         * qmake/mkspecs/features/production_build.prf: Removed.
2091         * qmake/mkspecs/features/rpath.prf: Removed.
2092         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2093         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2094         * qmake/mkspecs/features/unix/icc.prf: Removed.
2095         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2096         * qmake/mkspecs/features/valgrind.prf: Removed.
2097         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2098         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2099         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2100         * qmake/mkspecs/modules/angle.prf: Removed.
2101         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2102         * qmake/mkspecs/modules/webcore.prf: Removed.
2103         * qmake/mkspecs/modules/webkit1.prf: Removed.
2104         * qmake/mkspecs/modules/webkit2.prf: Removed.
2105         * qmake/mkspecs/modules/wtf.prf: Removed.
2106
2107 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2108
2109         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
2110         https://bugs.webkit.org/show_bug.cgi?id=121859
2111         <rdar://problem/15069359>
2112
2113         Reviewed by Anders Carlsson.
2114
2115         * WebKitTestRunner/TestInvocation.cpp:
2116         (WTR::shouldUseThreadedScrolling):
2117         (WTR::updateThreadedScrollingForCurrentTest):
2118         (WTR::TestInvocation::invoke):
2119         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2120         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2121         (WTR::PlatformWebView::PlatformWebView):
2122         (WTR::PlatformWebView::viewSupportsOptions):
2123         Rename the tiled drawing switch to threaded scrolling, since that's really
2124         all it switches now that we use tiled drawing everywhere.
2125
2126         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2127         and to more closely match the case we're interested in testing.
2128
2129 2013-10-02  Anders Carlsson  <andersca@apple.com>
2130
2131         Move AHEM____.TTF from qt/fonts/ to fonts/.
2132
2133         Rubber-stamped by Andreas Kling.
2134
2135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2136         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2137
2138 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2139
2140         Remove Qt bots and EWS from trunk.
2141         https://bugs.webkit.org/show_bug.cgi?id=122210.
2142
2143         Reviewed by Allan Sandfeld Jensen.
2144
2145         Remove Qt buil dbots.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/config.json:
2148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2149         (appendCustomBuildFlags):
2150         (RunGtkAPITests.getText2):
2151         (Factory.__init__):
2152         (TestFactory.__init__):
2153         (BuildAndTestFactory.__init__):
2154         (loadBuilderConfig):
2155         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2156
2157 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2158
2159         Remove Qt bots and EWS from trunk.
2160         https://bugs.webkit.org/show_bug.cgi?id=122210.
2161
2162         Reviewed by Allan Sandfeld Jensen.
2163
2164         Remove Qt EWS bots.
2165
2166         * QueueStatusServer/config/queues.py:
2167         * Scripts/webkitpy/common/config/ews.json:
2168
2169 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2170
2171         Fix singular labels for test failures.
2172
2173         https://bugs.webkit.org/show_bug.cgi?id=122200
2174
2175         Reviewed by Joseph Pecoraro.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2178         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2179
2180 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2181
2182         Don't keep appending iterations each time the queue updates.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=122198
2185
2186         Reviewed by Joseph Pecoraro.
2187
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2189         (BuildbotQueue.prototype.update):
2190
2191 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2192
2193         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2194
2195         https://bugs.webkit.org/show_bug.cgi?id=122196
2196
2197         Reviewed by Brent Fulgham.
2198
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2200         (BuildbotIteration):
2201         (BuildbotIteration.prototype.update):
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2203         (BuildbotQueue.prototype.update):
2204         (BuildbotQueue.prototype.sortIterations):
2205
2206 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2207
2208         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2209
2210         Also fix some URLs to not have extras slashes and add a page title.
2211
2212         https://bugs.webkit.org/show_bug.cgi?id=122192
2213
2214         Reviewed by Joseph Pecoraro.
2215
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2217         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2219         (WebKitBuildbot.prototype.buildLogURLForIteration):
2220         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2221         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2223
2224 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2225
2226         [Mac] Set NSApplication current event while sending events directly to views
2227         https://bugs.webkit.org/show_bug.cgi?id=122179
2228
2229         Reviewed by Darin Adler.
2230
2231         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2232         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2233         use the current event.
2234
2235         * DumpRenderTree/mac/EventSendingController.mm:
2236         (-[EventSendingController mouseDown:withModifiers:]):
2237         (-[EventSendingController mouseUp:withModifiers:]):
2238         (-[EventSendingController mouseMoveToX:Y:]):
2239         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2240         (-[EventSendingController contextClick]):
2241         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2242         * WebKitTestRunner/mac/EventSenderProxy.mm:
2243         (WTR::EventSenderProxy::mouseDown):
2244         (WTR::EventSenderProxy::mouseUp):
2245         (WTR::EventSenderProxy::mouseMoveTo):
2246         (WTR::EventSenderProxy::keyDown):
2247         (WTR::EventSenderProxy::mouseScrollBy):
2248         Update the current event. We were already using the SPI in WebKit.
2249
2250 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2251
2252         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2253         https://bugs.webkit.org/show_bug.cgi?id=122183
2254
2255         Reviewed by Timothy Hatcher.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2258         (BuildbotIteration.prototype.update):
2259
2260 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2261
2262         Tweaks to the Buildbot Dashboard
2263
2264         https://bugs.webkit.org/show_bug.cgi?id=122169
2265
2266         Reviewed by Alexey Proskuryakov.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2269         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2271         (BuildbotQueueView.prototype.revisionLinksForIteration):
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2273         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2277         (WebKitBuildbot.prototype.buildLogURLForIteration):
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2279
2280 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2281
2282         Unreviewed, rolling out r156725.
2283         http://trac.webkit.org/changeset/156725
2284         https://bugs.webkit.org/show_bug.cgi?id=122176
2285
2286         broke all the mismatch tests again (Requested by thorton on
2287         #webkit).
2288
2289         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2290         (WTR::PlatformWebView::PlatformWebView):
2291
2292 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2293
2294         Implemented createWebViewWithRequest in WinLauncher.
2295         https://bugs.webkit.org/show_bug.cgi?id=122069
2296
2297         Reviewed by Brent Fulgham.
2298
2299         * WinLauncher/PrintWebUIDelegate.cpp:
2300         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2301         * WinLauncher/PrintWebUIDelegate.h:
2302         Removed createWebViewWithRequest stub.
2303
2304 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2305
2306         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2307         https://bugs.webkit.org/show_bug.cgi?id=122006
2308         <rdar://problem/15095197>
2309
2310         Reviewed by Dean Jackson.
2311
2312         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2313         (WTR::PlatformWebView::PlatformWebView):
2314         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2315         where the window server snapshot API returns blank snapshots.
2316
2317         Re-landing after r156724, this should not break everything now.
2318
2319 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2320
2321         [mac] 1x emulation on Retina hardware shouldn't use SPI
2322         https://bugs.webkit.org/show_bug.cgi?id=122152
2323         <rdar://problem/15119384>
2324
2325         Reviewed by Anders Carlsson.
2326
2327         * DumpRenderTree/mac/DumpRenderTree.mm:
2328         (createWebViewAndOffscreenWindow):
2329         (main):
2330         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2331         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2333         (WTR::PlatformWebView::PlatformWebView):
2334         * WebKitTestRunner/mac/main.mm:
2335         (main):
2336         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2337
2338 2013-09-30  Sam Weinig  <sam@webkit.org>
2339
2340         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2341         https://bugs.webkit.org/show_bug.cgi?id=116474
2342
2343         Reviewed by Ryosuke Niwa.
2344
2345         * Scripts/webkitpy/style/checkers/cpp.py:
2346         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2347
2348 2013-09-30  Sam Weinig  <sam@webkit.org>
2349
2350         Remove support for DOMFileSystem
2351         https://bugs.webkit.org/show_bug.cgi?id=122137
2352
2353         Reviewed by Anders Carlsson.
2354
2355         * Scripts/webkitperl/FeatureList.pm:
2356         * Scripts/webkitpy/style/checkers/cpp.py:
2357         (check_spacing):
2358         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2359         (CppStyleTest.test_spacing_for_binary_ops):
2360         * qmake/mkspecs/features/features.pri:
2361
2362 2013-09-30  Mark Rowe  <mrowe@apple.com>
2363
2364         More build fixage for builds with SDKs.
2365
2366         * WebKitTestRunner/Configurations/Base.xcconfig:
2367         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2368
2369 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2370
2371         Add initial version of a new Buildbot dashboard view.
2372
2373         https://bugs.webkit.org/show_bug.cgi?id=122131
2374
2375         Reviewed by Alexey Proskuryakov.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2409
2410 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2411
2412         Remove the code guarded by STYLE_SCOPED
2413         https://bugs.webkit.org/show_bug.cgi?id=122123
2414
2415         Reviewed by Anders Carlsson.
2416
2417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2418         (resetDefaultsToConsistentValues):
2419         * Scripts/webkitperl/FeatureList.pm:
2420         * qmake/mkspecs/features/features.pri:
2421
2422 2013-09-30  Mark Rowe  <mrowe@apple.com>
2423
2424         Fix the build when building against an SDK.
2425
2426         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2427         the compiler command lines. It can't know to do this for the system framework search paths
2428         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2429
2430         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2431         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2432
2433 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2434
2435         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2436
2437         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2438         it to be double-freed.
2439
2440         * WinLauncher/WinLauncher.cpp:
2441         (EditProc): Be explicit about type passed to loadURL.
2442         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2443         that reallocating the BSTR is done with the knowledge of the smart pointer.
2444
2445 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2446
2447         [Qt] Fix force_static_libs_as_shared in WebKit2
2448         https://bugs.webkit.org/show_bug.cgi?id=121961
2449
2450         Reviewed by Csaba Osztrogonác.
2451
2452         Get rid of the unused WebKit2QML library
2453
2454         * qmake/mkspecs/features/webkit_modules.prf:
2455         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2456
2457 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2458
2459         [EFL] Fix incorrect click counting in EventSenderProxy
2460         https://bugs.webkit.org/show_bug.cgi?id=122098
2461
2462         Reviewed by Gyuyoung Kim.
2463
2464         Previously used two types of recording time, which conflicted with each other.
2465
2466         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2467         (WTR::EventSenderProxy::mouseUp):
2468
2469 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2470
2471         [webkitpy] Make the Xvfb screen depth overridable
2472         https://bugs.webkit.org/show_bug.cgi?id=122089
2473
2474         Reviewed by Gyuyoung Kim.
2475
2476         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2477         was set. The default value that's used if the variable wasn't set is 24.
2478
2479         * Scripts/webkitpy/port/xvfbdriver.py:
2480         (XvfbDriver._xvfb_screen_depth):
2481         (XvfbDriver._start):
2482         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2483         (XvfbDriverTest.make_driver):
2484         (XvfbDriverTest.test_start_no_pixel_tests):
2485         (XvfbDriverTest.test_start_pixel_tests):
2486         (XvfbDriverTest.test_start_arbitrary_worker_number):
2487         (XvfbDriverTest.test_next_free_display):
2488         (XvfbDriverTest.test_start_next_worker):
2489
2490 2013-09-29  Mark Rowe  <mrowe@apple.com>
2491
2492         Fix the Lion build.
2493
2494         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2495
2496         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2497         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2498
2499 2013-09-28  Mark Rowe  <mrowe@apple.com>
2500
2501         Fix some failures with newer versions of clang.
2502
2503         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2504         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2505         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2506         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2507         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2508
2509         Reviewed by Dan Bernstein.
2510
2511         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2512         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2513         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2514         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2515         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2516         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2517         * WebKitTestRunner/Configurations/Base.xcconfig:
2518         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2519         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2520         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2521         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2522
2523 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2524
2525         Unreviewed, rolling out r156569.
2526         http://trac.webkit.org/changeset/156569
2527         https://bugs.webkit.org/show_bug.cgi?id=122035
2528
2529         broke a lot of mismatch tests (Requested by thorton on
2530         #webkit).
2531
2532         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2533         (WTR::PlatformWebView::PlatformWebView):
2534
2535 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2536
2537         Don't retry failures on Apple MountainLion Release WK1 tester
2538         https://bugs.webkit.org/show_bug.cgi?id=122026
2539
2540         Reviewed by Mark Rowe.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2543         on this bot.
2544
2545 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2546
2547         Don't hardcode builder specific configuration in buildbot master.cfg
2548         https://bugs.webkit.org/show_bug.cgi?id=122023
2549
2550         Reviewed by Mark Rowe.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2553         property to Qt Mountain Lion Release, making it run pixel tests.
2554
2555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2556         (RunWebKitTests.start): Use additionalArguments.
2557         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2558
2559 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2560
2561         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2562         https://bugs.webkit.org/show_bug.cgi?id=122006
2563         <rdar://problem/15095197>
2564
2565         Reviewed by Dean Jackson.
2566
2567         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2568         (WTR::PlatformWebView::PlatformWebView):
2569         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2570         where the window server snapshot API returns blank snapshots.
2571
2572 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2573
2574         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2575         https://bugs.webkit.org/show_bug.cgi?id=106924
2576
2577         Reviewed by Chris Fleizach.
2578
2579         Consider headings levels as values to be returned in intValue()
2580         both in DRT and WKTR, so we can share more tests with other ports.
2581
2582         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2583         (AccessibilityUIElement::intValue): Consider headings too.
2584         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2585         (WTR::AccessibilityUIElement::intValue): Ditto.
2586
2587 2013-09-26  Darin Adler  <darin@apple.com>
2588
2589         rename KURL to URL
2590         https://bugs.webkit.org/show_bug.cgi?id=16214
2591
2592         Reviewed by Andreas Kling.
2593
2594         * many files: Renamed, using script.
2595
2596 2013-09-27  Darin Adler  <darin@apple.com>
2597
2598         Fix Python scripts test failures.
2599
2600         * Scripts/webkitpy/style/checkers/cpp.py:
2601         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2602         now, not by the checker itself.
2603
2604 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2605
2606         [GTK][WK2] Logging of accessibility events is not disabled between tests
2607         https://bugs.webkit.org/show_bug.cgi?id=121957
2608
2609         Reviewed by Mario Sanchez Prada.
2610
2611         Fixed an issue in AccessibilityNotificationHandler where the destructor
2612         was not disconnecting accessibility event callbacks if logging was on.
2613         The decision of disconnecting events can solely rely on the existence of
2614         notification handlers because logging uses the global notification
2615         handler.
2616
2617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2618         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2619         disconnection when logging is on.
2620
2621 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2622
2623         Add general CMakeLists.txt for DRT
2624         https://bugs.webkit.org/show_bug.cgi?id=119268
2625
2626         Reviewed by Gyuyoung Kim.
2627
2628         The new file allows better sharing between ports.
2629
2630         * CMakeLists.txt:
2631         * DumpRenderTree/CMakeLists.txt: Added.
2632         * DumpRenderTree/PlatformEfl.cmake: Added.
2633         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2634
2635 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2636
2637         [Qt] Fix force_static_libs_as_shared in WebKit2
2638         https://bugs.webkit.org/show_bug.cgi?id=121961
2639
2640         Reviewed by Csaba Osztrogonác.
2641
2642         Reenable force_static_libs_as_shared when building WebKit2.
2643
2644         * qmake/mkspecs/features/default_post.prf:
2645
2646 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2647
2648         [Qt] Mock implementations of positioning and orientation not used
2649         https://bugs.webkit.org/show_bug.cgi?id=121956
2650
2651         Reviewed by Csaba Osztrogonác.
2652
2653         Move production_build checks to sanitizeFeatures where its value is actually known.
2654
2655         * qmake/mkspecs/features/features.prf:
2656         * qmake/mkspecs/features/features.pri:
2657
2658 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2659
2660         [ATK] Normalize checks in entry points for DRT and WKTR
2661         https://bugs.webkit.org/show_bug.cgi?id=121959
2662
2663         Reviewed by Chris Fleizach.
2664
2665         Always check if we have a proper instance of AtkObject,
2666         implementing the interfaces that we might need for each case, at
2667         the entry point of every method of AccessibilityUIElement for ATK,
2668         and do those checks in an uniform way across DRT and WKTR, to
2669         avoid confusion and issues when modifying these files in the future.
2670
2671         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2672         (AccessibilityUIElement::getChildren): Use normalized checks.
2673         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2674         (AccessibilityUIElement::rowCount): Ditto.
2675         (AccessibilityUIElement::columnCount): Ditto.
2676         (AccessibilityUIElement::childrenCount): Ditto.
2677         (AccessibilityUIElement::elementAtPoint): Ditto.
2678         (AccessibilityUIElement::getChildAtIndex): Ditto.
2679         (AccessibilityUIElement::allAttributes): Ditto.
2680         (AccessibilityUIElement::titleUIElement): Ditto.
2681         (AccessibilityUIElement::parentElement): Ditto.
2682         (AccessibilityUIElement::attributesOfChildren): Ditto.
2683         (AccessibilityUIElement::role): Ditto.
2684         (AccessibilityUIElement::title): Ditto.
2685         (AccessibilityUIElement::description): Ditto.
2686         (AccessibilityUIElement::stringValue): Ditto.
2687         (AccessibilityUIElement::language): Ditto.
2688         (AccessibilityUIElement::x): Ditto.
2689         (AccessibilityUIElement::y): Ditto.
2690         (AccessibilityUIElement::width): Ditto.
2691         (AccessibilityUIElement::height): Ditto.
2692         (AccessibilityUIElement::orientation): Ditto.
2693         (AccessibilityUIElement::intValue): Ditto.
2694         (AccessibilityUIElement::minValue): Ditto.
2695         (AccessibilityUIElement::maxValue): Ditto.
2696         (indexRangeInTable): Ditto.
2697         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2698         (AccessibilityUIElement::stringAttributeValue): Ditto.
2699         (alterCurrentValue): Ditto.
2700         (AccessibilityUIElement::press): Ditto.
2701         (AccessibilityUIElement::documentEncoding): Ditto.
2702         (AccessibilityUIElement::documentURI): Ditto.
2703         (AccessibilityUIElement::hasPopup): Ditto.
2704
2705         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2706         (WTR::indexRangeInTable): Use normalized checks.
2707         (WTR::alterCurrentValue): Ditto.
2708         (WTR::AccessibilityUIElement::getChildren): Ditto.
2709         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2710         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2711         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2712         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2713         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2714         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2715         (WTR::AccessibilityUIElement::parentElement): Ditto.
2716         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2717         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2718         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2719         (WTR::AccessibilityUIElement::role): Ditto.
2720         (WTR::AccessibilityUIElement::title): Ditto.
2721         (WTR::AccessibilityUIElement::description): Ditto.
2722         (WTR::AccessibilityUIElement::orientation): Ditto.
2723         (WTR::AccessibilityUIElement::stringValue): Ditto.
2724         (WTR::AccessibilityUIElement::language): Ditto.
2725         (WTR::AccessibilityUIElement::x): Ditto.
2726         (WTR::AccessibilityUIElement::y): Ditto.
2727         (WTR::AccessibilityUIElement::width): Ditto.
2728         (WTR::AccessibilityUIElement::height): Ditto.
2729         (WTR::AccessibilityUIElement::intValue): Ditto.
2730         (WTR::AccessibilityUIElement::minValue): Ditto.
2731         (WTR::AccessibilityUIElement::maxValue): Ditto.
2732         (WTR::AccessibilityUIElement::rowCount): Ditto.
2733         (WTR::AccessibilityUIElement::columnCount): Ditto.
2734         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2735         (WTR::AccessibilityUIElement::press): Ditto.
2736         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2737         (WTR::AccessibilityUIElement::documentURI): Ditto.
2738         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2739
2740 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2741
2742         [ATK] accessibility/aria-sort.html is failing after r156409
2743         https://bugs.webkit.org/show_bug.cgi?id=121947
2744
2745         Reviewed by Chris Fleizach.
2746
2747         Implement AccessibilityUIElement::isSupported for the ATK
2748         platforms, just by checking whether we have an associated object
2749         attribute exposed for the wrapper object matching the required
2750         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2751
2752         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2753         (AccessibilityUIElement::isAttributeSupported): Implemented.
2754         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2755         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2756
2757 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2758
2759         [MediaStream] make MediaStream testable
2760         https://bugs.webkit.org/show_bug.cgi?id=121967
2761
2762         Reviewed by Dean Jackson.
2763
2764         * DumpRenderTree/mac/UIDelegate.mm:
2765         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2766             user media request policy delegate.
2767
2768 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2769
2770         build-webkit --inspector-frontend should copy WebInspectorUI files
2771         https://bugs.webkit.org/show_bug.cgi?id=117851
2772
2773         Reviewed by Joseph Pecoraro.
2774
2775         Change the --inspector-frontend build option to additionally build/copy 
2776         WebInspectorUI by setting it as the only project that needs to be built.
2777
2778         * Scripts/build-webkit:
2779
2780 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2781
2782         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2783         https://bugs.webkit.org/show_bug.cgi?id=121951
2784
2785         Reviewed by Carlos Garcia Campos.
2786
2787         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2788         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2789         500 layout tests that trigger accelerated compositing to be used.
2790
2791         * Scripts/webkitpy/port/xvfbdriver.py:
2792         (XvfbDriver._start):
2793         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2794         (XvfbDriverTest.test_start_no_pixel_tests):
2795         (XvfbDriverTest.test_start_pixel_tests):
2796         (XvfbDriverTest.test_start_arbitrary_worker_number):
2797         (XvfbDriverTest.test_next_free_display):
2798         (XvfbDriverTest.test_start_next_worker):
2799
2800 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2801
2802         Tiled drawing should not imply threaded scrolling
2803         https://bugs.webkit.org/show_bug.cgi?id=121874
2804         <rdar://problem/15071494>
2805
2806         Reviewed by Sam Weinig.
2807
2808         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2809         (WTR::PlatformWebView::PlatformWebView):
2810         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2811
2812 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2813
2814         Unreviewed, rolling out r156457.
2815         http://trac.webkit.org/changeset/156457
2816         https://bugs.webkit.org/show_bug.cgi?id=121960
2817
2818         Broke webkitpy tests. (Requested by kling on #webkit).
2819
2820         * Scripts/webkitpy/port/xvfbdriver.py:
2821         (XvfbDriver._start):
2822
2823 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2824
2825         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2826         https://bugs.webkit.org/show_bug.cgi?id=121951
2827
2828         Reviewed by Carlos Garcia Campos.
2829
2830         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2831         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2832         500 layout tests that trigger accelerated compositing to be used.
2833
2834         * Scripts/webkitpy/port/xvfbdriver.py:
2835         (XvfbDriver._start):
2836
2837 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2838
2839         Removed check for Apple Application Support directory in WinCairo port.
2840         https://bugs.webkit.org/show_bug.cgi?id=121869
2841
2842         Reviewed by Brent Fulgham.
2843
2844         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2845         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2846         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2847         Use DLLLauncherWinCairo.props for WinCairo ports.
2848         * win/DLLLauncher/DLLLauncherMain.cpp:
2849         (wWinMain):
2850         Don't call modifyPath to check for AAS in the WinCairo port.
2851         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2852
2853 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2854
2855         Enabled AssembleBuildLogs on WinCairo port.
2856         https://bugs.webkit.org/show_bug.cgi?id=121923
2857
2858         Reviewed by Brent Fulgham.
2859
2860         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2861         Fixed reference to README, added WinCairo configurations.
2862         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2863         Fixed reference to README.
2864         * win/AssembleBuildLogs/AssembleLogs.cmd:
2865         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2866         * win/AssembleBuildLogs/README: Fixed spelling.
2867
2868 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2869
2870         [WIN] Fix MSVC C4146 compiler warning
2871         https://bugs.webkit.org/show_bug.cgi?id=121838
2872
2873         Reviewed by Brent Fulgham.
2874
2875         Fix some variables from unsinged to int to fix the compiler warning
2876         "unary minus operator applied to unsigned type, result still unsigned".
2877
2878         * DumpRenderTree/WorkQueueItem.h:
2879         (BackItem::BackItem):
2880         (ForwardItem::ForwardItem):
2881         * DumpRenderTree/win/DumpRenderTree.cpp:
2882         (createWebViewAndOffscreenWindow):
2883
2884 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2885
2886         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2887         https://bugs.webkit.org/show_bug.cgi?id=121256
2888
2889         Reviewed by Martin Robinson.
2890
2891         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2892         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2893
2894         * BuildSlaveSupport/build.webkit.org-config/config.json:
2895
2896 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2897
2898         Add style checker for CMake lists
2899         https://bugs.webkit.org/show_bug.cgi?id=121764
2900
2901         Reviewed by Ryosuke Niwa.
2902
2903         Add an additional check to make sure that list of files are sorted.
2904         Exclude lists of include directories for now, since the order
2905         can be importent for compilation of some files.
2906
2907         * Scripts/webkitpy/style/checkers/cmake.py:
2908         (CMakeChecker.check):
2909         (CMakeChecker._check_indent):
2910         (CMakeChecker):
2911         (CMakeChecker._check_list_order):
2912         (CMakeChecker._list_item_path):
2913         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2914         (CMakeCheckerTest.test_check):
2915
2916 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2917
2918         CMakeChecker takes unusually long time to run
2919         https://bugs.webkit.org/show_bug.cgi?id=105662
2920
2921         Reviewed by Ryosuke Niwa.
2922
2923         Move the caching mechanism for regular expression of the C++ checker into
2924         a common file and use it for the CMake and ChangeLog checkers too.
2925
2926         * Scripts/webkitpy/style/checkers/changelog.py:
2927         (ChangeLogChecker.check_entry):
2928         * Scripts/webkitpy/style/checkers/cmake.py:
2929         (CMakeChecker._process_line):
2930         (CMakeChecker._check_no_space_cmds):
2931         (CMakeChecker._check_one_space_cmds):
2932         (CMakeChecker._check_non_lowercase_cmd):
2933         * Scripts/webkitpy/style/checkers/common.py:
2934         (match):
2935         (search):
2936         (searchIgnorecase):
2937         (sub):
2938         (subn):
2939         * Scripts/webkitpy/style/checkers/cpp.py:
2940
2941 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2942
2943         [Qt] Fix build with Qt 5.2 QtPosition module
2944         https://bugs.webkit.org/show_bug.cgi?id=121089
2945
2946         Reviewed by Simon Hausmann.
2947
2948         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2949         that might depend on them.
2950
2951         * qmake/mkspecs/features/default_pre.prf:
2952         * qmake/mkspecs/features/features.prf:
2953
2954 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2955
2956         [ATK] Fix style issues in AccessibilityUIElementAtk
2957         https://bugs.webkit.org/show_bug.cgi?id=121898
2958
2959         Reviewed by Chris Fleizach.
2960
2961         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2962         instead of { 0, { { 0 } } } to initialize a GValue.
2963
2964         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2965         (AccessibilityUIElement::clickPointX): Remove suffix.
2966         (AccessibilityUIElement::clickPointY): Ditto.
2967         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2968         (AccessibilityUIElement::minValue): Ditto.
2969         (AccessibilityUIElement::maxValue): Ditto.
2970         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2972         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2973         (WTR::AccessibilityUIElement::x): Ditto.
2974         (WTR::AccessibilityUIElement::y): Ditto.
2975         (WTR::AccessibilityUIElement::width): Ditto.
2976         (WTR::AccessibilityUIElement::height): Ditto.
2977         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2978         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2979         (WTR::AccessibilityUIElement::intValue): Ditto.
2980         (WTR::AccessibilityUIElement::minValue): Ditto.
2981         (WTR::AccessibilityUIElement::maxValue): Ditto.
2982
2983 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2984
2985         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2986         https://bugs.webkit.org/show_bug.cgi?id=112003
2987
2988         Reviewed by Mario Sanchez Prada.
2989
2990         Enabled addNotificationListener and removeNotificationListener for EFL port.
2991
2992         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2993         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2994         (WTR::AccessibilityController::removeNotificationListener):
2995
2996 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2997
2998         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2999         https://bugs.webkit.org/show_bug.cgi?id=121844
3000
3001         Reviewed by Mark Hahnenberg.
3002
3003         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
3004
3005 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
3006
3007         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
3008         https://bugs.webkit.org/show_bug.cgi?id=121854
3009
3010         Reviewed by Anders Carlsson.
3011
3012         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3013         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
3014         settings in underlying frameworks.
3015
3016 2013-09-24  Mark Rowe  <mrowe@apple.com>
3017
3018         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
3019
3020         Reviewed by Dan Bernstein.
3021
3022         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3023         * MiniBrowser/Configurations/Base.xcconfig:
3024         * TestWebKitAPI/Configurations/Base.xcconfig:
3025         * WebKitLauncher/Configurations/Base.xcconfig:
3026         * WebKitTestRunner/Configurations/Base.xcconfig:
3027
3028 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
3029
3030         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
3031         https://bugs.webkit.org/show_bug.cgi?id=121674
3032
3033         Reviewed by Mario Sanchez Prada.
3034
3035         Implemented the global notification listener for
3036         AccessibilityController. The signal is generated by
3037         AXObjectCache::postPlatformNotification() and received by
3038         axObjectEventListener(). axObjectEventListener will then invoke
3039         JSObjectCallAsFunction() with the respective callback function.
3040
3041         There is no additional test for this patch since its implementation will
3042         be tested by an accessibility layout test that is currently failing
3043         (accessibility/loading-iframe-sends-notification.html).
3044
3045         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
3046         stub implementations of addNotificationListener and
3047         removeNotificationListener for the GTK port.
3048         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3049         (WTR::AccessibilityController::addNotificationListener): Creates the
3050         notification handler and sets the notification function callback.
3051         (WTR::AccessibilityController::removeNotificationListener): Removes the
3052         global handler.
3053
3054 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
3055
3056         [GTK] fast/images/exif-orientation-composited.html is failing
3057         https://bugs.webkit.org/show_bug.cgi?id=119731
3058
3059         Reviewed by Carlos Garcia Campos.
3060
3061         Add handling respect image orientation property in DRT.
3062
3063         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3064         (TestRunner::overridePreference):
3065
3066 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3067
3068         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3069         https://bugs.webkit.org/show_bug.cgi?id=121787
3070
3071         Reviewed by Gustavo Noronha Silva.
3072
3073         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3074         with the Wayland target enabled to version 3.10.0.
3075
3076 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3077
3078         use NOMINMAX instead of #define min min
3079         https://bugs.webkit.org/show_bug.cgi?id=73563
3080
3081         Reviewed by Brent Fulgham.
3082
3083         Use NOMINMAX instead of #define min/max as a cleaner
3084         way of ensuring that Windows system header files don't
3085         define min/max as macro in the first place.
3086
3087         * DumpRenderTree/DumpRenderTreePrefix.h:
3088         * DumpRenderTree/cg/ImageDiffCG.cpp:
3089         * DumpRenderTree/config.h:
3090         * DumpRenderTree/win/ImageDiffCairo.cpp:
3091         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3092         * WebKitTestRunner/config.h:
3093
3094 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3095
3096         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3097         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3098
3099         Reviewed by Alexey Proskuryakov.
3100
3101         Previously, initalizing a WebPreference would change the cache model
3102         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3103         preference file on disk.
3104
3105         This patch fixes the tests by resetting the default, and using the proper
3106         default values after initializing WebPreference.
3107
3108         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3109         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3110         to the previous runs.
3111
3112         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3113         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3114         cache model to the one required.
3115
3116         * TestWebKitAPI/ios/mainIOS.mm:
3117         (main): Reset the preferences before testing.
3118         * TestWebKitAPI/mac/mainMac.mm:
3119         (main): Ditto.
3120
3121 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3122
3123         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3124         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3125
3126         Reviewed by Alexey Proskuryakov.
3127
3128         Previously, initalizing a WebPreference would change the cache model
3129         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3130         preference file on disk.
3131
3132         This patch fixes the tests by resetting the default, and using the proper
3133         default values after initializing WebPreference.
3134
3135         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3136         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3137         to the previous runs.
3138
3139         * TestWebKitAPI/ios/mainIOS.mm:
3140         (main): Reset the preferences before testing.
3141         * TestWebKitAPI/mac/mainMac.mm:
3142         (main): Ditto.
3143
3144 2013-09-23  Anders Carlsson  <andersca@apple.com>
3145
3146         ListHashSet should work with move-only types
3147         https://bugs.webkit.org/show_bug.cgi?id=121802
3148
3149         Reviewed by Andreas Kling.
3150
3151         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3152         (TestWebKitAPI::TEST):
3153         Add a test for move-only types.
3154
3155 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3156
3157         Added --64-bit option for Windows build.
3158         https://bugs.webkit.org/show_bug.cgi?id=121799
3159
3160         Reviewed by Brent Fulgham.
3161
3162         * Scripts/webkitdirs.pm:
3163         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3164         (isWin64): Added.
3165         (determineIsWin64): Added.
3166
3167 2013-09-23  Anders Carlsson  <andersca@apple.com>
3168
3169         ListHashSet should use std::reverse_iterator for reverse iterators
3170         https://bugs.webkit.org/show_bug.cgi?id=121795
3171
3172         Reviewed by Antti Koivisto.
3173
3174         Add test for reverse iterators.
3175
3176         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3177         (TestWebKitAPI::TEST):
3178
3179 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3180
3181         [EFL] accessibility/aria-invalid is failing
3182         https://bugs.webkit.org/show_bug.cgi?id=111986
3183
3184         Reviewed by Mario Sanchez Prada.
3185
3186         Adds possibility to retrieve JS context.
3187         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3188         from 119883 and 120421.
3189
3190         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3191         (axObjectEventListener):
3192         (addAccessibilityNotificationHandler):
3193         (removeAccessibilityNotificationHandler):
3194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3195         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3196         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3197
3198 2013-09-20  Mark Rowe  <mrowe@apple.com>
3199
3200         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3201
3202         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3203
3204         Reviewed by David Kilzer.
3205
3206         * Scripts/webkitdirs.pm:
3207         (checkRequiredSystemConfig):
3208
3209 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3210
3211         [ATK] Do not expose aria-help in ATK based platforms
3212         https://bugs.webkit.org/show_bug.cgi?id=121675
3213
3214         Reviewed by Chris Fleizach.
3215
3216         Remove the implementations for AccessibilityUIElement::helpText()
3217         from DRT and WKTR for GTK and EFL, since they are based on the
3218         AccessibilityObject::helpText() method and the 'aria-help'
3219         attributes, which is wrong since they should not depend on that
3220         but in ATK specific API (see also http://webkit.org/b/121684).
3221
3222         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3223         (AccessibilityUIElement::helpText): Added a new and empty
3224         implementation, now that we are no longer using this in ATK.
3225         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3226         as the only function provided here was helpText().
3227         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3228         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3229         removed from the list of sources to compile.
3230         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3231         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3232         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3233         based in DumpRenderTreeSupportGtk with an empty one.
3234
3235 2013-09-20  Dan Bernstein  <mitz@apple.com>
3236
3237         Make extract-localizable-strings available to WebCore clients
3238         https://bugs.webkit.org/show_bug.cgi?id=121699
3239
3240         Reviewed by Darin Adler.
3241
3242         * Scripts/extract-localizable-strings: Copied to
3243         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3244         executes the script from its new location. This is a temporary measure until certain code
3245         that is external to WebKit is adapted to the new location.
3246         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3247         from its new location.
3248
3249 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3250
3251         Nuke remaining VS2005 tools from the tree.
3252         https://bugs.webkit.org/show_bug.cgi?id=121691
3253
3254         Reviewed by Brent Fulgham.
3255
3256         * CLWrapper/CLWrapper.cpp: Removed.
3257         * CLWrapper/CLWrapper.sln: Removed.
3258         * CLWrapper/CLWrapper.vcproj: Removed.
3259         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3260         * MIDLWrapper/MIDLWrapper.sln: Removed.
3261         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3262         * Scripts/parallelcl: Removed.
3263         * vcbin/cl.exe: Removed.
3264         * vcbin/midl.exe: Removed.
3265
3266 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3267
3268         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3269         https://bugs.webkit.org/show_bug.cgi?id=121294
3270
3271         Reviewed by Martin Robinson.
3272
3273         Provide a new patch to deal with the issue in the GTK+ module from
3274         the internal jhbuild environment. This issue has been reported
3275         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3276
3277         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3278         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3279
3280 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3281
3282         [ATK][WTR] accessibility/aria-invalid.html times out
3283         https://bugs.webkit.org/show_bug.cgi?id=121668
3284
3285         Reviewed by Mario Sanchez Prada.
3286
3287         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3288         false in case of aria-invalid event with empty value.
3289
3290         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3291         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3292         case of aria-invalid event with empty value.
3293
3294 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3295
3296         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3297         https://bugs.webkit.org/show_bug.cgi?id=120421
3298
3299         Reviewed by Mario Sanchez Prada.
3300
3301         Implemented the notification listener for AccessibilityUIElement for
3302         WebKitTestRunner. The signal is generated by
3303         AXObjectCache::postPlatformNotification() and received by
3304         axObjectEventListener(). axObjectEventListener() will then invoke
3305         JSObjectCallAsFunction() with the respective callback function. The
3306         notification handlers are stored in HashMap in
3307         AccessibilityNotificationHandlerAtk.cpp.
3308
3309         Moved ATK signal handling (printAccessibilityEvent and
3310         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3311
3312         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3313         include path.
3314         * WebKitTestRunner/GNUmakefile.am:
3315         Added AccessibilityNotificationHandlerAtk.cpp/h.
3316         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3317         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3318         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3319         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3321         notification handler for GTK+ and EFL.
3322         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3323         Moved printAccessibilityEvent and axObjectEventListener to
3324         AccessibilityNotificationHandlerAtk.cpp.
3325         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3326         IDs to AccessibilityNotificationHandlerAtk.cpp.
3327         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3328         IDs to AccessibilityNotificationHandlerAtk.cpp.
3329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3330         (WTR::printAccessibilityEvent): Prints accessibility events. This
3331         function was moved from AccessibilityControllerAtk.cpp.
3332         (WTR::axObjectEventListener): Callback for signals. This function was
3333         moved from AccessibilityControllerAtk.cpp.
3334         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3335         Initialize element and function callback.
3336         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3337         Removes handler from HashMap and disconnects callbacks if necessary.
3338         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3339         logging mode and connects callbacks.
3340         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3341         Sets the notification callback and connects callback to signals.
3342         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3343         Removes the notification callback from HashMap.
3344         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3345         Connects axObjectEventListener to ATK signals.
3346         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3347         Disconnects callback.
3348         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3349         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3350         of AccessibilityNotificationHandler.
3351         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3352         element.
3353         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3354         element.
3355         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3356         Gets the notification callback.
3357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3358         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3359         notification handler, set the platform element and the notification
3360         callback.
3361         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3362         notification handler.
3363         * WebKitTestRunner/PlatformEfl.cmake:
3364         Added AccessibilityNotificationHandlerAtk.cpp.
3365
3366 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3367
3368         Update features.pri
3369         https://bugs.webkit.org/show_bug.cgi?id=121670
3370
3371         Reviewed by Jocelyn Turcotte.
3372
3373         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3374
3375         * qmake/mkspecs/features/features.pri:
3376
3377 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3378
3379         [GTK][WK2] accessibility/selection-states.html is failing
3380         https://bugs.webkit.org/show_bug.cgi?id=116972
3381
3382         Reviewed by Mario Sanchez Prada.
3383
3384         isSelectable() was not exposed in Accessibility.
3385
3386         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3387
3388 2013-09-19  Dan Bernstein  <mitz@apple.com>
3389
3390         Attempted build fix after r156114.
3391
3392         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3393
3394 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3395
3396         REGRESSION (r129451): run-safari --no-saved-state is broken
3397         https://bugs.webkit.org/show_bug.cgi?id=121566
3398
3399         Undo a last minute change that doesn't actually work.
3400
3401         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3402         via command line, <rdar://problem/15032886>.
3403
3404 2013-09-19  Dan Bernstein  <mitz@apple.com>
3405
3406         Add a style guideline regarding spacing in range-based for loops
3407         https://bugs.webkit.org/show_bug.cgi?id=121620
3408
3409         Reviewed by Anders Carlsson.
3410
3411         * Scripts/webkitpy/style/checkers/cpp.py:
3412         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3413         loop.
3414         (CppChecker): Added whitespace/colon to the categories set.
3415         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3416         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3417
3418 2013-09-18  Sam Weinig  <sam@webkit.org>
3419
3420         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3421         https://bugs.webkit.org/show_bug.cgi?id=121588
3422
3423         Reviewed by Anders Carlsson.
3424
3425         * DumpRenderTree/TestRunner.cpp:
3426         * ImageDiff/efl/ImageDiff.cpp:
3427         * TestWebKitAPI/JavaScriptTest.cpp:
3428         * TestWebKitAPI/PlatformUtilities.cpp:
3429         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3430         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3432         * WebKitTestRunner/StringFunctions.h:
3433         * WebKitTestRunner/TestInvocation.cpp:
3434         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3435         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3436
3437 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3438
3439         W3C Test Import script reformats test HTML
3440         https://bugs.webkit.org/show_bug.cgi?id=119159
3441
3442         Reviewed by Dirk Pranke.
3443
3444         Completely rewrite the test conversion process to minimize
3445         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3446         are still places where it will end up changing the formatting, but it
3447         is much better than before. Most notably, the public interface to the
3448         test converter has changed: now one calls a method instead of creating
3449         an instance of the test converter class. This is because the test
3450         converter class now has state, so one really needs a new instance for
3451         each test.
3452
3453         Note that this also lays some simple groundwork for being able to use
3454         a MockHost in the tests.
3455
3456         * Scripts/webkitpy/w3c/test_converter.py:
3457         (convert_for_webkit):
3458         (_W3CTestConverter):
3459         (_W3CTestConverter.__init__):
3460         (_W3CTestConverter.output):
3461         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3462         (_W3CTestConverter.convert_style_data):
3463         (_W3CTestConverter.convert_attributes_if_needed):
3464         (_W3CTestConverter.handle_starttag):
3465         (_W3CTestConverter.handle_endtag):
3466         (_W3CTestConverter.handle_startendtag):
3467         (_W3CTestConverter.handle_data):
3468         (_W3CTestConverter.handle_entityref):
3469         (_W3CTestConverter.handle_charref):
3470         (_W3CTestConverter.handle_comment):
3471         (_W3CTestConverter.handle_decl):
3472         (_W3CTestConverter.handle_pi):
3473         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3474         (W3CTestConverterTest):
3475         (W3CTestConverterTest.fake_dir_path):
3476         (W3CTestConverterTest.test_read_prefixed_property_list):
3477         (verify_no_conversion_happened):
3478         * Scripts/webkitpy/w3c/test_importer.py:
3479         (TestImporter.import_tests):
3480
3481 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3482
3483         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3484         https://bugs.webkit.org/show_bug.cgi?id=121578
3485
3486         Rubber stamped by Geoffrey Garen.
3487
3488         * Scripts/run-layout-jsc:
3489
3490 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3491
3492         Unreviewed, fix for Ruby 1.8.
3493
3494         * Scripts/run-jsc-stress-tests:
3495
3496 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3497
3498         run-jsc-stress-tests should make it easier to look at error spew from tests
3499         https://bugs.webkit.org/show_bug.cgi?id=121531
3500
3501         Reviewed by Mark Hahnenberg.
3502         
3503         This makes two changes:
3504         
3505         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3506         
3507         - The same spew also goes to the console but is prefixed by the test's name.
3508         
3509         This required some tee and awk hacks, and then some sh hacks to work around the fact
3510         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3511         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3512         needed to do weird things.
3513
3514         * Scripts/run-jsc-stress-tests:
3515
3516 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3517
3518         REGRESSION (r129451): run-safari --no-saved-state is broken
3519         https://bugs.webkit.org/show_bug.cgi?id=121566
3520
3521         Reviewed by Mark Rowe.
3522
3523         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3524         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3525         While at it, removed a check for Snow Leopard.
3526
3527 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3528
3529         Improved WinLauncher's URL handling.
3530         https://bugs.webkit.org/show_bug.cgi?id=121535
3531
3532         Reviewed by Brent Fulgham.
3533
3534         * WinLauncher/WinLauncher.cpp:
3535         (EditProc):
3536         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3537         (loadURL):
3538         Prepend "http://" to URLs with no scheme.
3539
3540 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3541
3542         DFG should support Int52 for local variables
3543         https://bugs.webkit.org/show_bug.cgi?id=121064
3544
3545         Reviewed by Oliver Hunt.
3546
3547         * Scripts/run-jsc-stress-tests:
3548
3549 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3550
3551         [Win] TestWebKitAPI does not compile.
3552         https://bugs.webkit.org/show_bug.cgi?id=121485
3553
3554         Reviewed by Brent Fulgham.
3555
3556         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3557         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3558         to return null, which is the case we want to test.
3559
3560         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3561         (TestWebKitAPI::TEST):
3562
3563 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3564
3565         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3566         https://bugs.webkit.org/show_bug.cgi?id=121495
3567
3568         Reviewed by Chris Fleizach.
3569
3570         Adapted DRT and WKTR to deal with the new names for the ATK object
3571         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3572
3573         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3574         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3575         (AccessibilityUIElement::stringAttributeValue): Ditto.
3576         (AccessibilityUIElement::hasPopup): Ditto.
3577         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3578         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3579         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3580         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3581
3582 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3583
3584         Unreviewed, rolling out r156019 and r156020.
3585         http://trac.webkit.org/changeset/156019
3586         http://trac.webkit.org/changeset/156020
3587         https://bugs.webkit.org/show_bug.cgi?id=121540
3588
3589         Broke tests (Requested by ap on #webkit).
3590
3591         * Scripts/run-jsc-stress-tests:
3592
3593 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3594
3595         Unreviewed. Add myself as a committer.
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3600
3601         Unreviewed. Add myself as a committer.
3602
3603         * Scripts/webkitpy/common/config/contributors.json:
3604
3605 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3606
3607         DFG should support Int52 for local variables
3608         https://bugs.webkit.org/show_bug.cgi?id=121064
3609
3610         Reviewed by Oliver Hunt.
3611
3612         * Scripts/run-jsc-stress-tests:
3613
3614 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3615
3616         Added back and forward buttons to WinLauncher.
3617         https://bugs.webkit.org/show_bug.cgi?id=121212
3618
3619         Reviewed by Brent Fulgham.
3620
3621         * WinLauncher/WinLauncher.cpp:
3622         (resizeSubViews):
3623         Move new back and forward buttons to correct positions before URL bar.
3624         (dllLauncherEntryPoint): 
3625         Store the default button window procedure and replace with my button procedures.
3626         (EditProc): Updated style and renamed from MyEditProc.
3627         (BackButtonProc): Added.
3628         (ForwardButtonProc): Added.
3629
3630 2013-09-17  Michael Saboff  <msaboff@apple.com>
3631
3632         Unreviewed typo fix after r155999
3633
3634         Changed en_US.UTB-8 to en_US.UTF-8
3635
3636         * Scripts/run-javascriptcore-tests:
3637
3638 2013-09-17  Michael Saboff  <msaboff@apple.com>
3639
3640         run-jsc-stress-tests fails with ruby version 2
3641         https://bugs.webkit.org/show_bug.cgi?id=121521
3642
3643         Reviewed by Jessie Berlin.
3644
3645         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3646
3647         * Scripts/run-javascriptcore-tests:
3648
3649 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3650
3651         [Windows] Unreviewed build fix after r155963.
3652
3653         * DumpRenderTree/win/TestRunnerWin.cpp:
3654         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3655
3656 2013-09-17  Anders Carlsson  <andersca@apple.com>
3657
3658         Fix a typo.
3659
3660         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3661         (TestWebKitAPI::TEST):
3662
3663 2013-09-16  Anders Carlsson  <andersca@apple.com>
3664
3665         HashMap should work with move-only keys
3666         https://bugs.webkit.org/show_bug.cgi?id=121310
3667
3668         Reviewed by Darin Adler.
3669
3670         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3671         (TestWebKitAPI::TEST):
3672         Add test.
3673
3674 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3675
3676         BrowserMarshal.h build fail
3677         https://bugs.webkit.org/show_bug.cgi?id=102938
3678
3679         Reviewed by Carlos Garcia Campos.
3680
3681         Fix variable name.
3682
3683         * MiniBrowser/gtk/GNUmakefile.am:
3684
3685 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3686
3687         [Windows] Clean up WinLauncher by using smart pointers
3688         https://bugs.webkit.org/show_bug.cgi?id=121467
3689
3690         Reviewed by Anders Carlsson.
3691
3692         * WinLauncher/PrintWebUIDelegate.cpp:
3693         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3694         * WinLauncher/WinLauncher.cpp:
3695         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3696         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3697         (showLastVisitedSites): Smart pointer updates.
3698         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3699         (setToDefaultPreferences): Ditto.
3700         (dllLauncherEntryPoint): Ditto.
3701         (PrintView): Ditto.
3702         (LaunchInspector): Ditto.
3703         (NavigateToHistory): Ditto.
3704         (MyEditProc): Ditto.
3705         (loadURL): Ditto.
3706
3707 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3708
3709         [Windows] Add rudimentary history to WinLauncher.
3710         https://bugs.webkit.org/show_bug.cgi?id=121463
3711
3712         Reviewed by Anders Carlsson.
3713
3714         * WinLauncher/WinLauncher.cpp:
3715         (updateMenuItemForHistoryItem): Added
3716         (showLastVisitedSites): Added
3717         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3718         a new page has been visited.
3719         (dllLauncherEntryPoint): Deallocate history on exit.
3720         (NavigateToHistory): Added
3721         (WndProc): Add handler for history entries
3722         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3723         up to 10 history slots.
3724         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3725         Windows utility library to allow use of _bstr_t type.
3726         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3727         to hold up to 10 history slots.
3728         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3729
3730 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3731
3732         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3733         https://bugs.webkit.org/show_bug.cgi?id=120586
3734
3735         Reviewed by Martin Robinson.
3736
3737         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3738         makefiles, so they can be included unconditionally.
3739         * GtkLauncher/GNUmakefile.am: added.
3740         * Scripts/webkitdirs.pm:
3741         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3742         to configure, since we consider builds done through build-webkit to be development
3743         and test builds.
3744         * gtk/GNUmakefile.am: added.
3745         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3746         it's not necessary and it will not work now that the Scripts directory is not
3747         shipped in the tarball.
3748
3749 2013-09-16  Anders Carlsson  <andersca@apple.com>
3750
3751         WTF::Deque should work with move only types
3752         https://bugs.webkit.org/show_bug.cgi?id=121446
3753
3754         Reviewed by Andreas Kling.
3755
3756         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3757         (TestWebKitAPI::TEST):
3758         Add a test.
3759
3760 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3761
3762         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3763         https://bugs.webkit.org/show_bug.cgi?id=98410
3764
3765         Reviewed by Darin Adler.
3766
3767         Add implementation of click() method of objects returned by eventSender.contextClick().
3768
3769         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3770         (MenuItemPrivateData):
3771         (WTR::menuItemClickCallback):
3772         (WTR::getMenuItemTitleCallback):
3773         (WTR::staticMenuItemFinalize):
3774         (WTR::getMenuItemClass):
3775         (WTR::EventSendingController::contextClick):
3776
3777 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3778
3779         Make the GDB webkit.py script compatible with Python v3
3780         https://bugs.webkit.org/show_bug.cgi?id=121395
3781
3782         Reviewed by Ryosuke Niwa.
3783
3784         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3785         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3786         the print() function invocations.
3787
3788         * gdb/webkit.py:
3789         (guess_string_length):
3790         (ustring_to_string):
3791         (lstring_to_string):
3792         (WTFCStringPrinter.to_string):
3793         (PrintPathToRootCommand.invoke):
3794
3795 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3796
3797         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3798         https://bugs.webkit.org/show_bug.cgi?id=119631
3799
3800         Reviewed by Ryosuke Niwa.
3801
3802         The perf profiler is attached to the test runner after the test runner has been launched,
3803         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3804         UIProcess, meaning that WebProcess operations will not be profiled.
3805
3806         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3807         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3808         that are settable through the --wrapper option. This causes the perf profiler to correctly
3809         continue profiling the WebProcess after it was spawned.
3810
3811         When the profiler is launched, a wait process is launched with the profiler's pid as the
3812         argument. This ensures we can check that the profiler exited normally. If it did not, its
3813         output can be corrupted and can cause problems when that output is examined. The after-exit
3814         report is avoided in that case.
3815
3816         * Scripts/webkitpy/common/system/profiler.py:
3817         (Profiler.wrapper_arguments): The method returns an empty list by default.
3818         (Perf.__init__): Remove unnecessary member variables.
3819         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3820         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3821         the method returns a list of arguments that should be used as a wrapper for the test runner.
3822         The arguments specify the 'perf record' command, with the output file and the instruction to
3823         construct the call graph given as well.
3824         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3825         whitespace in the profile lines.
3826         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3827         running. If it is running even after that, or if the profiler process produced a non-zero exit
3828         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3829         the top 10 lines of the profile and how to examine the profile further.
3830         * Scripts/webkitpy/port/driver.py:
3831         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3832         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3833         or an empty list otherwise.
3834         (Driver.cmd_line):
3835         * Scripts/webkitpy/port/driver_unittest.py:
3836         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3837         for the testing-specific Port object.
3838         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3839         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3840         a parameter.
3841         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3842         when profiling on the Linux platform with the perf profiler.
3843
3844 2013-09-14  Dan Bernstein  <mitz@apple.com>
3845
3846         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3847         https://bugs.webkit.org/show_bug.cgi?id=121215
3848
3849         Reviewed by Mark Rowe.
3850
3851         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3852         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3853         public and private headers folder paths. Also tweaked the error messages’ format to make
3854         Xcode recognize them as errors.
3855
3856 2013-09-14  Alberto Garcia  <berto@igalia.com>
3857
3858         [GTK] Fails to compile if the build directory is in a different partition
3859         https://bugs.webkit.org/show_bug.cgi?id=121296
3860
3861         Reviewed by Martin Robinson.
3862
3863         Instead of using os.symlink() to install the gtk-doc templates,
3864         use os.link() first and fall back to os.symlink() if it fails.
3865
3866         * gtk/gtkdoc.py:
3867         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3868
3869 2013-09-14  Alberto Garcia  <berto@igalia.com>
3870
3871         [GTK] WebKitGTK+ is linking against libxslt in too many places
3872         https://bugs.webkit.org/show_bug.cgi?id=121356
3873
3874         Reviewed by Martin Robinson.
3875
3876         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3877         so we don't need to link against it.
3878
3879         * MiniBrowser/gtk/GNUmakefile.am:
3880         * TestWebKitAPI/GNUmakefile.am:
3881         * WebKitTestRunner/GNUmakefile.am:
3882
3883 2013-09-14  Ross Burton  <ross.burton@intel.com>
3884
3885         Uses gtk-doc tools even when --disable-gtk-doc passed
3886         https://bugs.webkit.org/show_bug.cgi?id=91239
3887
3888         Reviewed by Martin Robinson.
3889
3890         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3891
3892         * GNUmakefile.am:
3893
3894 2013-09-14  Alberto Garcia  <berto@igalia.com>
3895
3896         [GTK] Fails to compile if the build directory is in a different partition
3897         https://bugs.webkit.org/show_bug.cgi?id=121296
3898
3899         Reviewed by Carlos Garcia Campos.
3900
3901         Use symlinks instead of hard links to support building on a
3902         different file system.
3903
3904         * gtk/gtkdoc.py:
3905         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3906
3907 2013-09-13  Darin Adler  <darin@apple.com>
3908
3909         Use a better name than m_invertibleCTM
3910         https://bugs.webkit.org/show_bug.cgi?id=121341
3911
3912         Reviewed by Andreas Kling.
3913
3914         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3915
3916 2013-09-13  Anders Carlsson  <andersca@apple.com>
3917
3918         Pick the correct overload when a const reference is passed to appendSlowCase.
3919         https://bugs.webkit.org/show_bug.cgi?id=121326
3920
3921         Reviewed by Darin Adler.
3922
3923         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3924         (TestWebKitAPI::TEST):
3925
3926 2013-09-13  Darin Adler  <darin@apple.com>
3927
3928         Rename confusingly named "runtimeObject" functions
3929         https://bugs.webkit.org/show_bug.cgi?id=121339
3930
3931         Reviewed by Sam Weinig.
3932
3933         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3934
3935 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3936
3937         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3938         https://bugs.webkit.org/show_bug.cgi?id=121330
3939
3940         Reviewed by Mark Hahnenberg and Oliver Hunt.
3941
3942         We should run tests even if they don't have expected files yet.
3943         
3944         * Scripts/run-layout-jsc:
3945
3946 2013-09-13  Anders Carlsson  <andersca@apple.com>
3947
3948         Use nullptr instead of 0 in calls to HashMap::add
3949         https://bugs.webkit.org/show_bug.cgi?id=121322
3950
3951         Reviewed by Sam Weinig.
3952
3953         * DumpRenderTree/mac/TestRunnerMac.mm:
3954         (TestRunner::evaluateScriptInIsolatedWorld):
3955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3956         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3957
3958 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3959
3960         [GTK] Move to the new web inspector
3961         https://bugs.webkit.org/show_bug.cgi?id=120647
3962
3963         Reviewed by Carlos Garcia Campos.
3964
3965         * GtkLauncher/main.c:
3966         (main): no longer set WEBKIT_INSPECTOR_PATH.
3967         * MiniBrowser/gtk/main.c:
3968         (main): ditto.
3969         * Scripts/old-run-webkit-tests:
3970         (openDumpTool): ditto.
3971         * Scripts/run-gtk-tests: ditto.
3972         * Scripts/webkitpy/port/gtk.py:
3973         (GtkPort.setup_environ_for_server): ditto.
3974
3975 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3976
3977         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3978         https://bugs.webkit.org/show_bug.cgi?id=120595
3979
3980         Reviewed by Jocelyn Turcotte.
3981
3982         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3983
3984         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3985         (DumpRenderTree::initJSObjects):
3986
3987 2013-09-13  Darin Adler  <darin@apple.com>
3988
3989         Give actions in Range class NON_SHOUTING_NAMES
3990         https://bugs.webkit.org/show_bug.cgi?id=121280
3991
3992         Reviewed by Andreas Kling.
3993
3994         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3995         the tradition of checking in the last one we did, along with other
3996         rename ideas for the future.
3997
3998 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3999
4000         Create short build logs for errors and warnings.
4001         https://bugs.webkit.org/show_bug.cgi?id=120614
4002
4003         Reviewed by Ryosuke Niwa.
4004
4005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4006             -include StringIO 
4007         (CompileWebKit.createSummary):
4008             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
4009
4010 2013-09-12  Roger Fong  <roger_fong@apple.com>
4011
4012         Update cygwin downloader to search for packages in the right location.
4013
4014         * CygwinDownloader/cygwin-downloader.py:
4015         * CygwinDownloader/cygwin-downloader.zip:
4016
4017 2013-09-12  Anders Carlsson  <andersca@apple.com>
4018
4019         Add rudimentary support for move-only types as values in HashMap
4020         https://bugs.webkit.org/show_bug.cgi?id=121226
4021
4022         Reviewed by Andreas Kling.
4023
4024         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4025         (TestWebKitAPI::TEST):
4026         Add a HashMap<unsigned, MoveOnly> test.
4027
4028 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
4029
4030         Auto GDB backtrace generation for EFL/GTK/Qt bots.
4031         https://bugs.webkit.org/show_bug.cgi?id=119338
4032
4033         Reviewed by Csaba Osztrogonác.
4034
4035         * Scripts/webkitpy/port/efl.py:
4036         (EflPort.check_sys_deps):
4037         (EflPort):
4038         (EflPort._get_crash_log):
4039         * Scripts/webkitpy/port/efl_unittest.py:
4040         (EflPortTest.test_show_results_html_file):
4041         (EflPortTest):
4042         (EflPortTest.test_get_crash_log):
4043         * Scripts/webkitpy/port/gtk.py:
4044         (GtkPort._get_crash_log):
4045         * Scripts/webkitpy/port/gtk_unittest.py:
4046         (GtkPortTest.test_get_crash_log):
4047         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
4048         (GDBCrashLogGenerator):
4049         (GDBCrashLogGenerator.__init__):
4050         (GDBCrashLogGenerator._get_gdb_output):
4051         (GDBCrashLogGenerator.generate_crash_log):
4052         (GDBCrashLogGenerator.generate_crash_log.match_filename):
4053         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
4054         (GDBCrashLogGeneratorTest):
4055         (GDBCrashLogGeneratorTest.test_generate_crash_log):
4056         (_mock_gdb_output):
4057         * Scripts/webkitpy/port/qt.py:
4058         (QtPort.default_child_processes):
4059         (QtPort):
4060         (QtPort._get_crash_log):
4061         * Scripts/webkitpy/port/qt_unittest.py:
4062         (QtPortTest.test_check_sys_deps):
4063         (QtPortTest):
4064         (QtPortTest.test_get_crash_log):
4065
4066 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
4067
4068         Unreviewed. Moving myself to the commiters list.
4069
4070         * Scripts/webkitpy/common/config/contributors.json:
4071
4072 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
4073
4074         [GTK] Add jhbuild-wayland.modules
4075         https://bugs.webkit.org/show_bug.cgi?id=120455
4076
4077         Reviewed by Gustavo Noronha Silva.
4078
4079         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
4080         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
4081         WEBKIT_EXTRA_MODULESETS.
4082
4083         * gtk/jhbuild-wayland.modules: Added.
4084
4085 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
4086
4087         [GTK][WK2] a11y tests unconditionally launching a11y daemons
4088         https://bugs.webkit.org/show_bug.cgi?id=120299
4089
4090         Reviewed by Carlos Garcia Campos.
4091
4092         Use the right variable name to store a reference to the at-spi2
4093         bus launcher process, so we can be sure we are terminating it when
4094         calling _tear_down_testing_environment().
4095
4096         * Scripts/run-gtk-tests:
4097         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
4098         instead of _ally_bus_launcher.
4099
4100 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4101
4102         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
4103         https://bugs.webkit.org/show_bug.cgi?id=121218
4104
4105         Reviewed by Philippe Normand.
4106
4107         Skipping the entire suite was added to skip tests when they can't
4108         be run because of the environment, for example to skip the a11y
4109         tests when the at-spi daemons fail to start. This is no longer
4110         true for all the cases, so we can disable the tests that are
4111         impossible to run instead of skipping them.
4112
4113         * Scripts/run-gtk-tests:
4114         (TestRunner.__init__): Initialize the skipped tests list.
4115         (TestRunner._setup_testing_environment): Add
4116         TestWebKitAccessibility path to the list of disabled tests when
4117         at-spi daemon fail to start.
4118         (TestRunner._should_run_test_program): Check first if the test
4119         program is disabled and then whether it's skipped honoring the
4120         skipped command line option.
4121
4122 2013-09-12  Samuel White  <samuel_white@apple.com>
4123
4124         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
4125         https://bugs.webkit.org/show_bug.cgi?id=117651
4126
4127         Reviewed by Mario Sanchez Prada.
4128
4129         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
4130
4131         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4132         (AccessibilityUIElement::valueDescription):
4133         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4134         (WTR::AccessibilityUIElement::valueDescription):
4135
4136 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
4137
4138         REGRESSION(r154781): accessibility/notification-listeners.html is failing
4139         https://bugs.webkit.org/show_bug.cgi?id=120669
4140
4141         Reviewed by Chris Fleizach.
4142
4143         Fixed 4 problems that were causing notification-listeners.html to fail.
4144
4145         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
4146         implemented in axObjectEventListener().
4147
4148         A notification for AXFocusedUIElementChanged was incorrectly sent when
4149         the element lost focus.
4150
4151         Global notification was not dispatched if an element notification was
4152         present in the HashMap.
4153
4154         connectAccessibilityCallbacks() was connecting signals to callbacks
4155         multiple times because it was not checking if
4156         disconnectAccessibilityCallbacks() had an early return if there were
4157         active handlers.
4158
4159         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
4160         disconnectAccessibilityCallbacks() to inform if the callbacks were
4161         successfully disconnected.
4162         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4163         (axObjectEventListener): Implemented notifications for
4164         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
4165         notification, which was not dispatched if an element notification
4166         existed. Fixed the notification for AXFocusedUIElementChanged that was
4167         incorrectly sent when the element lost focus. In addition, fixed a typo
4168         where TRUE should be true.
4169         (connectAccessibilityCallbacks): Added early return if
4170         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
4171         (disconnectAccessibilityCallbacks): Added a return value to inform if
4172         callbacks were successfully disconnected.
4173
4174 2013-09-11  Anders Carlsson  <andersca@apple.com>
4175
4176         Try to fix GCC builds.
4177
4178         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
4179
4180 2013-09-11  Anders Carlsson  <andersca@apple.com>
4181
4182         Try to fix the build.
4183
4184         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
4185         file in the Tests/ directory in the first place.
4186
4187         * TestWebKitAPI/CMakeLists.txt:
4188         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
4189         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
4190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4191         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
4192
4193 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
4194
4195         [Windows] Build fix for MoveOnly
4196
4197         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
4198         Tests to include search path.
4199         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
4200         Ditto.
4201
4202 2013-09-11  Anders Carlsson  <andersca@apple.com>
4203
4204         Add HashSet::take
4205         https://bugs.webkit.org/show_bug.cgi?id=121192
4206
4207         Reviewed by Darin Adler.
4208
4209         Add a test for HashSet::take.
4210
4211         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4212         (TestWebKitAPI::TEST):
4213
4214 2013-09-11  Anders Carlsson  <andersca@apple.com>
4215
4216         HashSet should work with move only types
4217         https://bugs.webkit.org/show_bug.cgi?id=121188
4218
4219         Reviewed by Geoffrey Garen.
4220
4221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4222         * TestWebKitAPI/Tests/MoveOnly.h: Added.
4223         Move the MoveOnly class from Vector out into its own header.
4224
4225         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4226         (TestWebKitAPI::TEST):
4227         Add aHashSet<MoveOnly> test.
4228
4229         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4230         Include MoveOnly.h.
4231
4232 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
4233
4234         [Windows] Avoid converting from IntSize->SIZE->IntSize
4235         https://bugs.webkit.org/show_bug.cgi?id=121180
4236
4237         Reviewed by Anders Carlsson.
4238
4239         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
4240         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
4241
4242 2013-09-11  Dan Bernstein  <mitz@apple.com>
4243
4244         REGRESSION (r155561): extract-localizable-strings can miss strings
4245         https://bugs.webkit.org/show_bug.cgi?id=121184
4246
4247         Reviewed by Darin Adler.
4248
4249         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
4250         parenthesis or bracket.
4251
4252 2013-09-11  Dan Bernstein  <mitz@apple.com>
4253
4254         update-webkit-localizable-strings is at least 5.8x slower than it should be
4255         https://bugs.webkit.org/show_bug.cgi?id=121178
4256
4257         Reviewed by Darin Adler.
4258
4259         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
4260         Note that this does not change functionality, because the script already does not understand
4261         the line continuation sequence (backslash followed by a newline).
4262
4263 2013-09-11  Anders Carlsson  <andersca@apple.com>
4264
4265         Vector::append doesn't work if element type has overloaded operator&
4266         https://bugs.webkit.org/show_bug.cgi?id=121175
4267
4268         Reviewed by Brent Fulgham.
4269
4270         Add a test case.
4271
4272         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4273         (TestWebKitAPI::TEST):
4274
4275 2013-09-11  Anders Carlsson  <andersca@apple.com>
4276
4277         Implement Vector::append for move-only types
4278         https://bugs.webkit.org/show_bug.cgi?id=120805
4279
4280         Reviewed by Sam Weinig.
4281
4282         Add a test for Vector<MoveOnly>::append.
4283
4284         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4285         (TestWebKitAPI::TEST):
4286
4287 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
4288
4289         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
4290
4291         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4292         (RunAndUploadPerfTests):
4293         (RunAndUploadPerfTests.start):
4294         (RunAndUploadPerfTests.getText2):
4295
4296 2013-09-11  Anders Carlsson  <andersca@apple.com>
4297
4298         The style checker shouldn't complain about returning or passing OwnPtr
4299         https://bugs.webkit.org/show_bug.cgi?id=121163
4300
4301         Reviewed by Antti Koivisto.
4302
4303         * Scripts/webkitpy/style/checkers/cpp.py:
4304         (check_function_definition_and_pass_ptr):
4305         * Scripts/webkitpy/style/checkers/cpp_unittest.py: