51d187f56d53b333d9661e6dd9d2a9830e3ce78c
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Implement a new edit command to change the enclosing list type
4         https://bugs.webkit.org/show_bug.cgi?id=191487
5         <rdar://problem/45955922>
6
7         Reviewed by Ryosuke Niwa.
8
9         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
10         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
11
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
14         (-[TestWKWebView setPosition:offset:]):
15         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
16         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
17         (TestWebKitAPI::TEST):
18         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
19
20 2018-11-11  Dan Bernstein  <mitz@apple.com>
21
22         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
23         https://bugs.webkit.org/show_bug.cgi?id=191514
24
25         Reviewed by Geoffrey Garen.
26
27         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
29         (TEST):
30
31 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
32
33         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
34         https://bugs.webkit.org/show_bug.cgi?id=191492
35
36         Reviewed by Alex Christensen.
37
38         Update file name.
39
40         * DumpRenderTree/mac/DumpRenderTree.mm:
41         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
42         * WebKitTestRunner/mac/TestControllerMac.mm:
43
44 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
45
46         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
47         https://bugs.webkit.org/show_bug.cgi?id=191492
48
49         Reviewed by Alex Christensen.
50
51         * DumpRenderTree/mac/DumpRenderTree.mm:
52         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
53         * WebKitTestRunner/mac/TestControllerMac.mm:
54
55 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
56
57         Unreviewed, rolling out r238065.
58
59         Breaks internal builds.
60
61         Reverted changeset:
62
63         "Make it possible to edit images inline"
64         https://bugs.webkit.org/show_bug.cgi?id=191352
65         https://trac.webkit.org/changeset/238065
66
67 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
68
69         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
70         https://bugs.webkit.org/show_bug.cgi?id=191221
71
72         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
73         that it is disabled, but we're testing that it is enabled, because I failed to update this
74         line.
75
76         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
77         (testWebKitSettings):
78
79 2018-11-10  Tim Horton  <timothy_horton@apple.com>
80
81         Make it possible to edit images inline
82         https://bugs.webkit.org/show_bug.cgi?id=191352
83         <rdar://problem/30107985>
84
85         Reviewed by Dean Jackson.
86
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::updateTestOptionsFromTestHeader):
89         * WebKitTestRunner/TestOptions.h:
90         (WTR::TestOptions::hasSameInitializationOptions const):
91         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
92         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
93         (WTR::TestController::platformCreateWebView):
94         Add a test option to enable editable images.
95
96         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
97         (WTR::UIScriptController::drawSquareInEditableImage):
98         (WTR::UIScriptController::numberOfStrokesInEditableImage):
99         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
100         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
101         (WTR::UIScriptController::drawSquareInEditableImage):
102         (WTR::UIScriptController::numberOfStrokesInEditableImage):
103         * TestRunnerShared/UIScriptContext/UIScriptController.h:
104         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
105         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
106         (WTR::findEditableImageCanvas):
107         (WTR::UIScriptController::drawSquareInEditableImage):
108         (WTR::UIScriptController::numberOfStrokesInEditableImage):
109         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
110         and also to retrieve the number of strokes currently on the PKCanvasView.
111         Currently this just takes the first canvas; we might need to make it
112         take an identifier or something in the future if we need tests with multiple
113         canvases. The indirect testing mechanism is required because PKCanvasView
114         can currently not actually paint its strokes in the Simulator.
115
116 2018-11-09  Chris Dumez  <cdumez@apple.com>
117
118         Suspended page persists even after back/forward list item is gone
119         https://bugs.webkit.org/show_bug.cgi?id=191488
120         <rdar://problem/45953006>
121
122         Reviewed by Geoffrey Garen.
123
124         Add API test coverage.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
127
128 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
129
130         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
131         https://bugs.webkit.org/show_bug.cgi?id=191471
132         <rdar://problem/45952472>
133
134         Reviewed by Tim Horton.
135
136         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
139         (TestWebKitAPI::webViewForEditActionTesting):
140         (TestWebKitAPI::TEST):
141
142 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
143
144         [Curl][WebKit] Implement Proxy configuration API.
145         https://bugs.webkit.org/show_bug.cgi?id=189053
146
147         Reviewed by Youenn Fablet.
148
149         Added Proxy Settings dialog to call newly added API.
150
151         * MiniBrowser/win/BrowserWindow.h:
152         * MiniBrowser/win/Common.cpp:
153         (askProxySettings):
154         (askCredential):
155         (authDialogProc): Deleted.
156         * MiniBrowser/win/Common.h:
157         * MiniBrowser/win/DialogHelper.h: Added.
158         (Dialog::run):
159         (Dialog::doalogProc):
160         (Dialog::handle):
161         (Dialog::setup):
162         (Dialog::update):
163         (Dialog::validate):
164         (Dialog::updateOkButton):
165         (Dialog::command):
166         (Dialog::ok):
167         (Dialog::cancel):
168         (Dialog::close):
169         (Dialog::hDlg):
170         (Dialog::item):
171         (Dialog::setEnabled):
172         (Dialog::setText):
173         (Dialog::getText):
174         (Dialog::getTextLength):
175         (Dialog::RadioGroup::RadioGroup):
176         (Dialog::RadioGroup::set):
177         (Dialog::RadioGroup::get):
178         (Dialog::radioGroup):
179         * MiniBrowser/win/MainWindow.cpp:
180         (MainWindow::WndProc):
181         * MiniBrowser/win/MiniBrowserLib.rc:
182         * MiniBrowser/win/MiniBrowserLibResource.h:
183         * MiniBrowser/win/WebKitBrowserWindow.cpp:
184         (createWKURL):
185         (WebKitBrowserWindow::WebKitBrowserWindow):
186         (WebKitBrowserWindow::updateProxySettings):
187         (WebKitBrowserWindow::loadURL):
188         (WebKitBrowserWindow::loadHTMLString):
189         (WebKitBrowserWindow::openProxySettings):
190         * MiniBrowser/win/WebKitBrowserWindow.h:
191         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
192         (WebKitLegacyBrowserWindow::openProxySettings):
193         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
194
195 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
196
197         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
198         https://bugs.webkit.org/show_bug.cgi?id=191410
199         <rdar://problem/45898610>
200
201         Reviewed by Dean Jackson.
202
203         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
204         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
205         hooked up to their respective editing commands.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
209         (-[TestWKWebView querySelectorExists:]):
210         (-[TestWKWebView insertString:]):
211
212         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
213         invoking the WKWebView directly on macOS and calling on the content view on iOS.
214
215         (TestWebKitAPI::webViewForEditActionTesting):
216         (TestWebKitAPI::TEST):
217
218 2018-11-09  Philippe Normand  <pnormand@igalia.com>
219
220         [Flatpak] Refactoring and drive-by fixes
221         https://bugs.webkit.org/show_bug.cgi?id=191421
222
223         Reviewed by Michael Catanzaro.
224
225         * Scripts/webkitdirs.pm:
226         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
227         the sandbox, so rely on this.
228         * flatpak/flatpakutils.py:
229         (expand_manifest): Pass explicit keywords to load_manifest() and
230         remove unused local variable.
231         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
232         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
233         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
234         build_type handling a bit.
235         * flatpak/org.webkit.CommonModules.yaml: Added.
236         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
237         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
238         declaration to CommonModules, so it can be reused later when we
239         add support for building extra libraries depending on WPE.
240
241 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
242
243 onal supported image formats
244         https://bugs.webkit.org/show_bug.cgi?id=190454
245
246         Reviewed by Simon Fraser.
247
248         Test opening a TGA image in WebView which is not allowed by default. The
249         TGA format will be allowed through WKWebViewConfiguration.
250
251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
252         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
253         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
254         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
255         (runTest):
256         (TEST):
257
258 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
259
260         Unreviewed, a proper build fix for r237983
261
262         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
263
264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
265         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
266         (TestWebKitAPI::TEST):
267         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
268         (TestWebKitAPI::getTestCorruptedSignResponse):
269         (TestWebKitAPI::getTestCredentialRawIdBytes):
270         (TestWebKitAPI::convertToVector):
271         (TestWebKitAPI::TEST):
272
273 2018-11-08  Keith Rollin  <krollin@apple.com>
274
275         Create .xcfilelist files
276         https://bugs.webkit.org/show_bug.cgi?id=191324
277         <rdar://problem/45852819>
278
279         Reviewed by Alex Christensen.
280
281         As part of preparing for enabling XCBuild, create and use .xcfilelist
282         files. These files are using during Run Script build phases in an
283         Xcode project. If a Run Script build phase produces new files that are
284         used later as inputs to subsequent build phases, XCBuild needs to know
285         about these files. These files can be either specified in an "output
286         files" section of the Run Script phase editor, or in .xcfilelist files
287         that are associated with the Run Script build phase.
288
289         This patch takes the second approach. It consists of three sets of changes:
290
291         - Modify the DerivedSources.make files to have a
292           'print_all_generated_files" target that produces a list of the files
293           they create.
294
295         - Create a shell script that produces .xcfilelist files from the
296           output of the previous step, as well as for the files created in the
297           Generate Unified Sources build steps.
298
299         - Add the new .xcfilelist files to the associated projects.
300
301         Note that, with these changes, the Xcode workspace and projects can no
302         longer be fully loaded into Xcode 9. Xcode will attempt to load the
303         projects that have .xcfilelist files associated with them, but will
304         fail and display a placeholder for those projects instead. It's
305         expected that all developers are using Xcode 10 by now and that not
306         being able to load into Xcode 9 is not a practical issue. Keep in mind
307         that this is strictly an IDE issue, and that the projects can still be
308         built with `xcodebuild`.
309
310         Also note that the shell script that creates the .xcfilelist files can
311         also be used to verify that the set of files that's currently checked
312         in is up-to-date. This checking can be used as part of a check-in hook
313         or part of check-webkit-style to sooner catch cases where the
314         .xcfilelist files need to be regenerated.
315
316         * DumpRenderTree/DerivedSources.make:
317         * DumpRenderTree/DerivedSources.xcfilelist: Added.
318         * Scripts/generate-xcfilelists: Added.
319         * WebKitTestRunner/DerivedSources.make:
320         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
321
322 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
323
324         Unreviewed, a quick build fix for r237983
325
326         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
327
328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
329         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
332         (TestWebKitAPI::getTestCorruptedSignResponse):
333         (TestWebKitAPI::getTestCredentialRawIdBytes):
334         (TestWebKitAPI::convertToVector):
335         (TestWebKitAPI::TEST):
336
337 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
338
339         Fix steps_unittest.py failures related to recent Win10/Win7 changes
340         https://bugs.webkit.org/show_bug.cgi?id=191290
341
342         Reviewed by Alexey Proskuryakov.
343
344         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
345
346 2018-11-08  Dean Jackson  <dino@apple.com>
347
348         Add a String literal that returns a String
349         https://bugs.webkit.org/show_bug.cgi?id=191425
350         <rdar://problem/45914556>
351
352         Reviewed by Sam Weinig.
353
354         Test _str.
355
356         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
357         (TestWebKitAPI::TEST):
358
359 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
360
361         webkitpy: Generalize trailing SDK specifier (Part 2)
362         https://bugs.webkit.org/show_bug.cgi?id=191275
363         <rdar://problem/45703660>
364
365         Rubber-stamped by Aakash Jain.
366
367         Re-landing this change, configuration issues have been resolved.
368
369         * Scripts/webkitpy/port/ios_device.py:
370         (IOSDevicePort): Use normalized SDK.
371         * Scripts/webkitpy/port/ios_simulator.py:
372         (IOSSimulatorPort): Use normalized SDK.
373         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
374
375 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
376
377         [WebAuthN] Import CTAP device request/response converters from Chromium
378         https://bugs.webkit.org/show_bug.cgi?id=190784
379         <rdar://problem/45460333>
380
381         Reviewed by Brent Fulgham.
382
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
385         (TestWebKitAPI::TEST):
386         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
389         (TestWebKitAPI::getTestCorruptedSignResponse):
390         (TestWebKitAPI::getTestCredentialRawIdBytes):
391         (TestWebKitAPI::convertToVector):
392         (TestWebKitAPI::TEST):
393         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
394
395 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
396
397         [BigInt] Add support to BigInt into ValueAdd
398         https://bugs.webkit.org/show_bug.cgi?id=186177
399
400         Reviewed by Keith Miller.
401
402         * Scripts/run-jsc-benchmarks:
403
404 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
405
406         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
407         https://bugs.webkit.org/show_bug.cgi?id=191326
408         <rdar://problem/45769269>
409
410         Reviewed by Geoffrey Garen.
411
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
414         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
415         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
416         (TEST):
417
418 2018-11-07  Daniel Bates  <dabates@apple.com>
419
420         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
421         https://bugs.webkit.org/show_bug.cgi?id=190141
422
423         Reviewed by Darin Adler.
424
425         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
426         runs deterministic regardless of whether a hardware keyboard is attached.
427
428         * DumpRenderTree/mac/DumpRenderTree.mm:
429         (overrideIsInHardwareKeyboardMode): Added.
430         (prepareConsistentTestingEnvironment):
431         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
432         * WebKitTestRunner/ios/TestControllerIOS.mm:
433         (overrideIsInHardwareKeyboardMode): Added.
434         (WTR::TestController::platformInitialize):
435
436 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
437
438         Unreviewed, rolling out r237913.
439
440         Breaks running tests on Mac without iOS SDK installed
441
442         Reverted changeset:
443
444         "webkitpy: Generalize trailing SDK specifier (Part 2)"
445         https://bugs.webkit.org/show_bug.cgi?id=191275
446         https://trac.webkit.org/changeset/237913
447
448 2018-11-07  Zamiul Haque  <zhaque@apple.com>
449
450         Force a gregorian calendar to show for credit card expiration date inputs
451         (autocomplete='cc-exp'*) regardless of default system settings.
452         https://bugs.webkit.org/show_bug.cgi?id=191096
453         rdar://problem/42640256
454
455         Reviewed by Tim Horton.
456
457         Implemented simulateForeignDefaultCalendar and calendarType to be used
458         for changing the default calendar returned by the system (ie. [NSCalendar
459         currentCalendar]) and getting the calendar type identifier of a presented date
460         picker.
461
462         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
463         (WTR::UIScriptController::isShowingDataListSuggestions const):
464         (WTR::UIScriptController::calendarType const):
465         (WTR::UIScriptController::setDefaultCalendarType):
466         * DumpRenderTree/mac/UIScriptControllerMac.mm:
467         (WTR::UIScriptController::calendarType const):
468         (WTR::UIScriptController::setDefaultCalendarType):
469         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
470         (WTR::UIScriptController::selectionEndGrabberViewRect const):
471         (WTR::UIScriptController::calendarType const): Deleted.
472         * WebKitTestRunner/TestController.cpp:
473         * WebKitTestRunner/TestController.h:
474         * WebKitTestRunner/UIScriptControllerCocoa.mm:
475         (WTR::UIScriptController::calendarType const):
476         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
477         (WTR::swizzledCalendar):
478         (WTR::TestController::getOverriddenCalendarIdentifier const):
479         (WTR::TestController::setDefaultCalendarType):
480         (WTR::TestController::cocoaResetStateToConsistentValues):
481         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
482         (WTR::UIScriptController::selectionEndGrabberViewRect const):
483         (WTR::UIScriptController::calendarType const): Deleted.
484
485 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
486
487         webkitpy: Boot a single worker for custom devices
488         https://bugs.webkit.org/show_bug.cgi?id=191312
489         <rdar://problem/45848717>
490
491         Rubber-stamped by Aakash Jain.
492
493         * Scripts/webkitpy/layout_tests/controllers/manager.py:
494         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
495         simulators is expensive and unneeded for these tests.
496         * Scripts/webkitpy/port/ios.py:
497         (IOSPort. child_processes): No reason to memoize this call, and it prevents
498         overriding the number of child processes when booting custom devices.
499
500 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
501
502         webkitpy: Generalize trailing SDK specifier (Part 2)
503         https://bugs.webkit.org/show_bug.cgi?id=191275
504         <rdar://problem/45703660>
505
506         Reviewed by Aakash Jain.
507
508         * Scripts/webkitpy/port/ios_device.py:
509         (IOSDevicePort): Use normalized SDK.
510         * Scripts/webkitpy/port/ios_simulator.py:
511         (IOSSimulatorPort): Use normalized SDK.
512         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
513
514 2018-11-06  Justin Fan  <justin_fan@apple.com>
515
516         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
517         https://bugs.webkit.org/show_bug.cgi?id=191291
518
519         Reviewed by Myles Maxfield.
520
521         Properly disable WEBGPU on all non-Metal platforms for now.
522
523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
524
525 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
526
527         [ews-app] Add URL configuration for OpenSource EWS Django app
528         https://bugs.webkit.org/show_bug.cgi?id=191132
529
530         Rubber-stamped by Lucas Forschler.
531
532         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
533         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
534
535 2018-11-06  Youenn Fablet  <youenn@apple.com>
536
537         Make mDNS ICE Candidate an experimental flag again
538         https://bugs.webkit.org/show_bug.cgi?id=191262
539
540         Reviewed by Dean Jackson.
541
542         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
544         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
545         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
547
548 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-app] Add views for OpenSource EWS Django app
551         https://bugs.webkit.org/show_bug.cgi?id=191131
552
553         Rubber-stamped by Lucas Forschler.
554
555         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
556         * BuildSlaveSupport/ews-app/ews/views/patch.py:
557         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
558         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
559
560 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
561
562         [ews-app] Add models for OpenSource EWS Django app
563         https://bugs.webkit.org/show_bug.cgi?id=191123
564
565         Reviewed by Lucas Forschler.
566
567         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
568         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
569         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
570         * BuildSlaveSupport/ews-app/ews/models/patch.py:
571         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
572
573 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-app] Fix Invalid HTTP_HOST header
576         https://bugs.webkit.org/show_bug.cgi?id=191325
577
578         Reviewed by Lucas Forschler.
579
580         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
581
582         * BuildSlaveSupport/ews-app/ews-app/settings.py:
583
584 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-app] Rename EWS_app to ews-app - part 2
587         https://bugs.webkit.org/show_bug.cgi?id=191317
588
589         Reviewed by Lucas Forschler.
590
591         * BuildSlaveSupport/ews-app/EWS_app: Removed.
592         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
593         * BuildSlaveSupport/ews-app/ews-app/settings.py:
594         * BuildSlaveSupport/ews-app/ews-app/urls.py:
595         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
596         * BuildSlaveSupport/ews-app/manage.py:
597
598 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
599
600         [ews-app] Rename EWS_app to ews-app - part 1
601         https://bugs.webkit.org/show_bug.cgi?id=191317
602
603         Reviewed by Lucas Forschler.
604
605         * BuildSlaveSupport/EWS_app: Removed.
606         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
607
608 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
609
610         Spelling dots are drawn in the wrong place
611         https://bugs.webkit.org/show_bug.cgi?id=190764
612
613         Reviewed by Dean Jackson.
614
615         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
616         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
617         dots to be drawn.
618
619         * WebKitTestRunner/TestController.cpp:
620         (WTR::TestController::resetStateToConsistentValues):
621         (WTR::updateTestOptionsFromTestHeader):
622         (WTR::TestController::platformResetStateToConsistentValues):
623         * WebKitTestRunner/TestController.h:
624         * WebKitTestRunner/TestOptions.h:
625         (WTR::TestOptions::hasSameInitializationOptions const):
626         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
627         (WTR::TestController::cocoaResetStateToConsistentValues):
628         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
629         * WebKitTestRunner/ios/TestControllerIOS.mm:
630         (WTR::TestController::platformResetStateToConsistentValues):
631         * WebKitTestRunner/mac/TestControllerMac.mm:
632         (WTR::TestController::platformResetStateToConsistentValues):
633
634 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
635
636         Feature flags not present for Visual Studio when using build-webkit
637         https://bugs.webkit.org/show_bug.cgi?id=191288
638
639         Reviewed by Fujii Hironori.
640
641         Passes feature flags to Visual studio builds within build-webkit.
642         Removes cmakeBasedPortArguments as it is no longer in use.
643
644         * Scripts/build-jsc:
645         * Scripts/build-webkit:
646         * Scripts/webkitdirs.pm:
647         (cmakeBasedPortArguments): Deleted.
648
649 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
650
651         REGRESSION (r230523): Caps lock indicator not shown in password field
652         https://bugs.webkit.org/show_bug.cgi?id=190056
653
654         Reviewed by Ryosuke Niwa.
655
656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
658         (WTR::TestRunner::toggleCapsLock):
659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
660         * WebKitTestRunner/TestController.h:
661         * WebKitTestRunner/TestInvocation.cpp:
662         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
663         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
664         (WTR::TestController::toggleCapsLock):
665
666 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
667
668         IndexedDB: WAL file keeps growing
669         https://bugs.webkit.org/show_bug.cgi?id=191294
670         <rdar://problem/41333493>
671
672         Reviewed by Chris Dumez.
673
674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
675         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
676         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
677         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
678         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
679         (TEST):
680
681 2018-11-06  Alex Christensen  <achristensen@webkit.org>
682
683         Fix tests after r237863
684         https://bugs.webkit.org/show_bug.cgi?id=191315
685
686         Reviewed by Chris Dumez.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
690         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
691         to verify that main2.html eventually loads, making this test less timing dependent.
692
693 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
694
695         Unreviewed, rolling out r237834.
696
697         Tests for this change crash on iOS Simulator
698
699         Reverted changeset:
700
701         "Spelling dots are drawn in the wrong place"
702         https://bugs.webkit.org/show_bug.cgi?id=190764
703         https://trac.webkit.org/changeset/237834
704
705 2018-11-05  Alex Christensen  <achristensen@webkit.org>
706
707         [Mac] Implement safe browsing in WebKit
708         https://bugs.webkit.org/show_bug.cgi?id=188871
709
710         Reviewed by Tim Horton.
711
712         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
713         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
714         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
715         (-[TestLookupContext lookUpURL:completionHandler:]):
716         (simpleURL):
717         (safeBrowsingView):
718         (TEST):
719         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
720         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
721         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
722         * TestWebKitAPI/Utilities.h:
723
724 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
725
726         webkitpy: Generalize trailing SDK specifier (Part 1)
727         https://bugs.webkit.org/show_bug.cgi?id=191275
728         <rdar://problem/45703660>
729
730         Reviewed by Lucas Forschler.
731
732         * Scripts/webkitpy/common/system/platforminfo.py:
733         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
734         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
735         (TestPlatformInfo):
736         (TestPlatformInfo.test_available_sdks):
737
738 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
739
740         Spelling dots are drawn in the wrong place
741         https://bugs.webkit.org/show_bug.cgi?id=190764
742
743         Reviewed by Dean Jackson.
744
745         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
746         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
747         dots to be drawn.
748
749         * WebKitTestRunner/TestController.cpp:
750         (WTR::TestController::resetStateToConsistentValues):
751         (WTR::updateTestOptionsFromTestHeader):
752         (WTR::TestController::platformResetStateToConsistentValues):
753         * WebKitTestRunner/TestController.h:
754         * WebKitTestRunner/TestOptions.h:
755         (WTR::TestOptions::hasSameInitializationOptions const):
756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
757         (WTR::TestController::cocoaResetStateToConsistentValues):
758         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
759         * WebKitTestRunner/ios/TestControllerIOS.mm:
760         (WTR::TestController::platformResetStateToConsistentValues):
761         * WebKitTestRunner/mac/TestControllerMac.mm:
762         (WTR::TestController::platformResetStateToConsistentValues):
763
764 2018-11-05  Chris Dumez  <cdumez@apple.com>
765
766         Use same limit for page cache and suspended pages
767         https://bugs.webkit.org/show_bug.cgi?id=191266
768
769         Reviewed by Geoffrey Garen.
770
771         Update API tests accordingly.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
774
775 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
776
777         [style] Exclude style check for auto generated files.
778         https://bugs.webkit.org/show_bug.cgi?id=191118
779
780         Reviewed by Eric Carlson.
781
782         Some files checked in to the repository are generated by other tools. In this patch,
783         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
784         VisualStudio.
785
786         There's no need to check these files because it's not practical to fix the style errors
787         or it's hard to maintain those fixes.
788
789         * Scripts/webkitpy/style/checkers/cpp.py:
790         (is_generated_file):
791         (CppChecker.check):
792
793 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
794
795         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
796         https://bugs.webkit.org/show_bug.cgi?id=190680
797
798         Reviewed by Philippe Normand.
799
800         * flatpak/org.webkit.WebKit.yaml:
801
802 2018-11-05  Daniel Bates  <dabates@apple.com>
803
804         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
805         https://bugs.webkit.org/show_bug.cgi?id=191094
806
807         Reviewed by Andy Estes.
808
809         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
810         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
811         Document summary and add closing brace '}' to both Frame and Document summary strings to make
812         them look pretty.
813
814         * lldb/lldb_webkit.py:
815         (WebCoreFrame_SummaryProvider):
816         (WebCoreDocument_SummaryProvider):
817
818 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
819
820         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
821         https://bugs.webkit.org/show_bug.cgi?id=191240
822         <rdar://problem/44872806>
823
824         Reviewed by Tim Horton.
825
826         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
827         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
828         overriding `-[WKWebView inputAssistantItem]`.
829
830         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
831         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
832         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
833         (+[InputAssistantItemTestingWebView barButtonIcon]):
834         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
835         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
836         (-[InputAssistantItemTestingWebView inputAssistantItem]):
837         (TestWebKitAPI::TEST):
838
839 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
840
841         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
842         https://bugs.webkit.org/show_bug.cgi?id=191226
843         <rdar://problem/45781765>
844
845         Reviewed by Tim Horton.
846
847         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
848         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
849
850         * WebKitTestRunner/TestOptions.h:
851         (WTR::TestOptions::hasSameInitializationOptions const):
852
853 2018-11-05  Commit Queue  <commit-queue@webkit.org>
854
855         Unreviewed, rolling out r237784 and r237788.
856         https://bugs.webkit.org/show_bug.cgi?id=191270
857
858         Caused mediastream layout test failures (Requested by
859         ryanhaddad on #webkit).
860
861         Reverted changesets:
862
863         "[MediaStream] User should not be prompted again after denying
864         getDisplayMedia request"
865         https://bugs.webkit.org/show_bug.cgi?id=191227
866         https://trac.webkit.org/changeset/237784
867
868         "[MediaStream] User should not be prompted again after denying
869         getDisplayMedia request"
870         https://bugs.webkit.org/show_bug.cgi?id=191227
871         https://trac.webkit.org/changeset/237788
872
873 2018-11-05  Lucas Forschler  <lforschler@apple.com>
874
875         https://bugs.webkit.org/show_bug.cgi?id=191268
876         Remove unused bots.
877
878         rubber-stamped by Alexey Proskuryakov.
879
880         * BuildSlaveSupport/build.webkit.org-config/config.json:
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
882         (WebKitBuildbot):
883
884 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
885
886         [WPE][GTK] API test runner fails to respect default build type
887         https://bugs.webkit.org/show_bug.cgi?id=190247
888
889         Reviewed by Carlos Garcia Campos.
890
891         Problem is it's looking for a release build, even though I've run set-webkit-configuration
892         --debug. It should look for a debug build unless I explicitly pass --release.
893
894         * glib/api_test_runner.py:
895         (TestRunner.__init__):
896
897 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
898
899         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
900         https://bugs.webkit.org/show_bug.cgi?id=190674
901
902         Reviewed by Philippe Normand.
903
904         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
905         it can use to implement encoding for different formats exposing a trimmed down unified API.
906
907         It also adds proper handling of H264 profiles.
908
909         The added files follow GStreamer coding style as we aim at upstreaming the element
910         in the future.
911
912         Reviewed by Philippe Normand.
913
914         * Scripts/webkitpy/style/checker.py:
915
916 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
917
918         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
919         https://bugs.webkit.org/show_bug.cgi?id=191221
920
921         Reviewed by Carlos Garcia Campos.
922
923         This test ensures that MSE is disabled by default, but we now enable it by default, so
924         reverse the semantics of the test.
925
926         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
927         (testWebKitSettings):
928
929 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
930
931         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
932         https://bugs.webkit.org/show_bug.cgi?id=191225
933
934         Reviewed by Alejandro G. Castro.
935
936         Fix a memory leak causing this test to fail.
937
938         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
939         (WebViewTest::initializeWebView):
940
941 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
942
943         [webkitpy] Support WPE in the run-web-platform-tests script
944         https://bugs.webkit.org/show_bug.cgi?id=191183
945
946         Reviewed by Alex Christensen.
947
948         * Scripts/webkitpy/w3c/wpt_runner.py:
949         (parse_args): Support `--wpe` as an argument that specifies WPE as the
950         target port. Additionally, the `--display-server` flag now accepts
951         `headless` as a valid value, enabling the WPE WebDriver to run in
952         headless mode.
953
954 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
955
956         [Win] Use C++14, not C++17
957         https://bugs.webkit.org/show_bug.cgi?id=191101
958
959         Reviewed by Alex Christensen.
960
961         std::basic_string::data() returns a read-only const buffer in
962         C++14.
963
964         * MiniBrowser/win/WebKitBrowserWindow.cpp:
965         (createString): Use std::vector instead of std::wstring.
966         (createUTF8String): Use std::vector instead of std::string.
967
968 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
969
970         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
971         https://bugs.webkit.org/show_bug.cgi?id=191231
972
973         Reviewed by Simon Fraser.
974
975         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
976         it can be shared between iOS-family and macOS platforms. See below for more details.
977
978         No change in behavior.
979
980         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
981         (WTR::UIScriptController::overridePreference):
982
983         Add a method stub for DumpRenderTree.
984
985         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
986         * WebKitTestRunner/UIScriptControllerCocoa.mm:
987         (WTR::UIScriptController::doAsyncTask):
988         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
989
990         Unify these method implementations.
991
992         (WTR::UIScriptController::removeViewFromWindow):
993         (WTR::UIScriptController::addViewToWindow):
994
995         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
996         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
997         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
998         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
999
1000         (WTR::UIScriptController::overridePreference):
1001         (WTR::UIScriptController::findString):
1002         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1003
1004         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1005
1006         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1007         (WTR::UIScriptController::doAsyncTask): Deleted.
1008         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1009         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1010         (WTR::UIScriptController::findString): Deleted.
1011         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1012         (WTR::UIScriptController::addViewToWindow): Deleted.
1013         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1014         (WTR::UIScriptController::doAsyncTask): Deleted.
1015         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1016         (WTR::UIScriptController::overridePreference): Deleted.
1017         (WTR::UIScriptController::findString): Deleted.
1018         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1019         (WTR::UIScriptController::addViewToWindow): Deleted.
1020         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1021
1022 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1023
1024         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1025         https://bugs.webkit.org/show_bug.cgi?id=191227
1026         <rdar://problem/45784512>
1027
1028         Reviewed by Youenn Fablet.
1029
1030         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1031         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1032         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1033         (TestWebKitAPI::TEST_F):
1034
1035 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1036
1037         [LFC][BFC] Add support for percentage height in quirks mode.
1038         https://bugs.webkit.org/show_bug.cgi?id=191232
1039
1040         Reviewed by Antti Koivisto.
1041
1042         * LayoutReloaded/misc/LFC-passing-tests.txt:
1043
1044 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1045
1046         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1047         https://bugs.webkit.org/show_bug.cgi?id=191229
1048
1049         Reviewed by Antti Koivisto.
1050
1051         * LayoutReloaded/misc/LFC-passing-tests.txt:
1052
1053 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1054
1055         [LFC][BFC] Resolve percentage height values.
1056         https://bugs.webkit.org/show_bug.cgi?id=191224
1057
1058         Reviewed by Antti Koivisto.
1059
1060         * LayoutReloaded/misc/LFC-passing-tests.txt:
1061
1062 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1063
1064         Mac production builds should sign the network process xpc service with entitlements
1065         https://bugs.webkit.org/show_bug.cgi?id=191209
1066         <rdar://problem/45377609>
1067
1068         Reviewed by Geoff Garen.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1072         (TEST):
1073
1074 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1075
1076         Unreviewed, rolling out r237761.
1077
1078         Makes most API tests timeout and WK2 tests crash
1079
1080         Reverted changeset:
1081
1082         "Mac production builds should sign the network process xpc
1083         service with entitlements"
1084         https://bugs.webkit.org/show_bug.cgi?id=191209
1085         https://trac.webkit.org/changeset/237761
1086
1087 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1088
1089         Unreviewed API test gardening
1090
1091         * TestWebKitAPI/glib/TestExpectations.json:
1092
1093 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1094
1095         Add new global object and preliminary Worklets support for CSS painting api
1096         https://bugs.webkit.org/show_bug.cgi?id=190979
1097
1098         Reviewed by Chris Dumez.
1099
1100         * Scripts/webkitpy/bindings/main.py:
1101         (BindingsTests.generate_supplemental_dependency):
1102         (BindingsTests.main):
1103
1104 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1105
1106         Mac production builds should sign the network process xpc service with entitlements
1107         https://bugs.webkit.org/show_bug.cgi?id=191209
1108         <rdar://problem/45377609>
1109
1110         Reviewed by Geoff Garen.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1114         (TEST):
1115
1116 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1117
1118         Add Windows 10 archive bots
1119         https://bugs.webkit.org/show_bug.cgi?id=190964
1120         
1121         This Change updates the Apple Windows Buildbot configuration.
1122         - Add Windows 10 specific builders and testers for release and debug.
1123         - Refactor Windows -> Windows 7.
1124         - Remove Windows 7 Debug.
1125
1126         Reviewed by Aakash Jain.
1127
1128         * BuildSlaveSupport/build.webkit.org-config/config.json:
1129
1130 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1131
1132         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1133
1134         Rubber-stamped by Michael Catanzaro.
1135
1136         This variable is useful to get rid of shell color escapes in tests stderr files.
1137
1138         * Scripts/webkitpy/port/gtk.py:
1139         (GtkPort.setup_environ_for_server):
1140         * Scripts/webkitpy/port/wpe.py:
1141         (WPEPort.setup_environ_for_server):
1142
1143 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1144
1145         Add Basic Django web app for OpenSource EWS
1146         https://bugs.webkit.org/show_bug.cgi?id=191091
1147
1148         Reviewed by Lucas Forschler.
1149
1150         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1151         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1152         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1153         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1154         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1155         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1156         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1157         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1158         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1159         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1160         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1161         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1162         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1163         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1164
1165 2018-11-02  Daniel Bates  <dabates@apple.com>
1166
1167         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1168         https://bugs.webkit.org/show_bug.cgi?id=190487
1169
1170         Reviewed by Tim Horton.
1171
1172         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1173         match my observations when using the simulator to simulate iOS 12 and add support for testing
1174         right-hand side modifiers.
1175
1176         * DumpRenderTree/mac/EventSendingController.mm:
1177         (modifierFlags):
1178         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1179         (-[EventSendingController setTouchModifier:value:]):
1180         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1181         (hidUsageCodeForCharacter):
1182
1183 2018-11-02  Chris Dumez  <cdumez@apple.com>
1184
1185         [PSON] Reuse SuspendedPages' process when possible, for performance
1186         https://bugs.webkit.org/show_bug.cgi?id=191166
1187
1188         Reviewed by Geoffrey Garen.
1189
1190         Add API test coverage.
1191
1192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1193
1194 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1195
1196         [LFC][IFC] Add support for intrinsic width calculation
1197         https://bugs.webkit.org/show_bug.cgi?id=191144
1198
1199         Reviewed by Antti Koivisto.
1200
1201         * LayoutReloaded/misc/LFC-passing-tests.txt:
1202
1203 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1204
1205         [Apache] Self-signed SSL certificate RSA key is considered too weak
1206         https://bugs.webkit.org/show_bug.cgi?id=191156
1207
1208         Reviewed by Michael Catanzaro.
1209
1210         * Scripts/webkitpy/common/system/pemfile.py:
1211
1212 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1213
1214         Unreviewed follow-up to r237678.
1215
1216         * wpe/jhbuild.modules: The patch element apparently has to be a child
1217         of the branch in order for Jhbuild to properly detect and apply the
1218         patch file.
1219
1220 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1221
1222         build-jsc --wincairo should update WinCairo libraries
1223         https://bugs.webkit.org/show_bug.cgi?id=191170
1224
1225         Reviewed by Fujii Hironori.
1226
1227         * Scripts/build-jsc:
1228
1229 2018-11-01  John Wilander  <wilander@apple.com>
1230
1231         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1232         https://bugs.webkit.org/show_bug.cgi?id=191119
1233         <rdar://problem/44176965>
1234
1235         Reviewed by Chris Dumez.
1236
1237         This is an API test for a WebKitLegacy WebView that is first closed and then
1238         JavaScript is handed a keyboard event.
1239
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1242         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1243         (-[KeyboardEventListener handleEvent:]):
1244         (TestWebKitAPI::TEST):
1245
1246 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1247
1248         Add a storage limit for IndexedDB
1249         https://bugs.webkit.org/show_bug.cgi?id=190598
1250         <rdar://problem/44654715>
1251
1252         Reviewed by Chris Dumez.
1253
1254         Add API for testing.
1255
1256         * DumpRenderTree/TestRunner.cpp:
1257         (setIDBPerOriginQuotaCallback):
1258         (TestRunner::staticFunctions):
1259         * DumpRenderTree/TestRunner.h:
1260         * DumpRenderTree/mac/TestRunnerMac.mm:
1261         (TestRunner::setIDBPerOriginQuota):
1262         * DumpRenderTree/win/TestRunnerWin.cpp:
1263         (TestRunner::setIDBPerOriginQuota):
1264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1266         (WTR::TestRunner::setIDBPerOriginQuota):
1267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1268         * WebKitTestRunner/TestController.cpp:
1269         (WTR::TestController::setIDBPerOriginQuota):
1270         * WebKitTestRunner/TestController.h:
1271         * WebKitTestRunner/TestInvocation.cpp:
1272         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1273
1274 2018-11-01  Chris Dumez  <cdumez@apple.com>
1275
1276         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1277         https://bugs.webkit.org/show_bug.cgi?id=191076
1278
1279         Reviewed by Geoffrey Garen.
1280
1281         Add API test coverage.
1282
1283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1284         (-[PSONNavigationDelegate init]):
1285         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1286
1287 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1288
1289         Fix build with VIDEO and WEB_AUDIO disabled
1290         https://bugs.webkit.org/show_bug.cgi?id=191147
1291         <rdar://problem/45726710>
1292
1293         Unreviewed build fix.
1294
1295         This adds the missing compilation guards in the WPE MiniBrowser.
1296
1297         * MiniBrowser/wpe/main.cpp:
1298         (main): Condition GST includes and calls.
1299
1300 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1301
1302         [LFC][IFC] Add support for inline-block elements.
1303         https://bugs.webkit.org/show_bug.cgi?id=191143
1304
1305         Reviewed by Antti Koivisto.
1306
1307         * LayoutReloaded/misc/LFC-passing-tests.txt:
1308
1309 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1310
1311         [WPE] Add missing libsoup patch to jhbuild
1312         https://bugs.webkit.org/show_bug.cgi?id=191149
1313
1314         Reviewed by Žan Doberšek.
1315
1316         * wpe/jhbuild.modules:
1317         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1318
1319 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1320
1321         Fix build with VIDEO and WEB_AUDIO disabled
1322         https://bugs.webkit.org/show_bug.cgi?id=191147
1323
1324         Reviewed by Philippe Normand.
1325
1326         * MiniBrowser/gtk/main.c:
1327         (main): Condition GST includes and calls
1328
1329 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1330
1331         Add Justin Michaud to the list of WebKit Committers
1332         https://bugs.webkit.org/show_bug.cgi?id=191142
1333
1334         * Scripts/webkitpy/common/config/contributors.json:
1335
1336 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
1337
1338         Don't run JIT tests on 32-bit platforms
1339         https://bugs.webkit.org/show_bug.cgi?id=191074
1340
1341         Reviewed by Michael Catanzaro.
1342
1343         * Scripts/run-jsc-stress-tests:
1344
1345 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1346
1347         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
1348         https://bugs.webkit.org/show_bug.cgi?id=190530
1349         <rdar://problem/45232149>
1350
1351         Reviewed by Tim Horton.
1352
1353         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
1354         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
1355         is equivalent to the original file wrappers used to insert attachments in the first web view.
1356
1357         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
1358         is still backed by the same NSFileWrapper instance.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1361         (TestWebKitAPI::TEST):
1362
1363 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1364
1365         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
1366         https://bugs.webkit.org/show_bug.cgi?id=190949
1367
1368         Reviewed by Alex Christensen.
1369
1370         Visual Studio 2017 Community is the alternative.
1371
1372         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
1373         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
1374         (buildVisualStudioProject): Ditto.
1375         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
1376         (usingVisualStudioExpress): Deleted.
1377
1378 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1379
1380         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1381         https://bugs.webkit.org/show_bug.cgi?id=191093
1382         <rdar://problem/45685706>
1383
1384         Unreviewed build fix.
1385
1386         error C2065: 'renderTarget': undeclared identifier
1387
1388         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1389         (createBitmapContextFromWebView): Restored the previous implementation.
1390
1391 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
1392
1393         [PlayStation] Enable JavaScriptCore
1394         https://bugs.webkit.org/show_bug.cgi?id=191072
1395
1396         Reviewed by Brent Fulgham.
1397
1398         Add platform scripts for building the PlayStation port.
1399         perl Tools/Scripts/build-webkit --playstation
1400
1401         * Scripts/build-webkit:
1402         * Scripts/build-webkittestrunner:
1403         * Scripts/webkitdirs.pm:
1404         (argumentsForConfiguration):
1405         (determineConfigurationProductDir):
1406         (isPlayStation): Added.
1407         (getMSBuildPlatformArgument): Added.
1408         (buildVisualStudioProject):
1409         (wrapperPrefixIfNeeded):
1410         (generateBuildSystemFromCMakeProject):
1411         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
1412
1413 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
1414
1415         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1416         https://bugs.webkit.org/show_bug.cgi?id=191093
1417         <rdar://problem/45685706>
1418
1419         Reviewed by Alex Christensen.
1420
1421         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
1422         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
1423         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
1424         (pixelDumpSystemFactory): Added.
1425         (printPNG): Create stub.
1426         (computeMD5HashStringForBitmapContext): Ditto.
1427         (dumpBitmap): Ditto.
1428         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
1429         (BitmapContext::createByAdoptingBitmapAndContext):
1430         (BitmapContext::~BitmapContext):
1431         (BitmapContext::platformContext const):
1432         (BitmapContext::BitmapContext):
1433         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1434         (createBitmapContextFromWebView): Update to support Direct2D.
1435         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
1436         logo is no longer available at this location. Switch to the new logo.
1437
1438 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
1439
1440         webkitpy: Support alternate simctl list outputs
1441         https://bugs.webkit.org/show_bug.cgi?id=191090
1442         <rdar://problem/45684255>
1443
1444         Rubber-stamped by Aakash Jain.
1445
1446         * Scripts/webkitpy/xcode/simulated_device.py:
1447         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
1448         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
1449         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1450         (test_available_devices): Add iOS 12 with alternative availability format.
1451
1452 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1453
1454         Clean up some obsolete MAX_ALLOWED macros
1455         https://bugs.webkit.org/show_bug.cgi?id=190916
1456
1457         Reviewed by Tim Horton.
1458
1459         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1460         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1461         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1462
1463 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
1464
1465         [GTK][WPE] Fixes to the PublicSuffix implementation
1466         https://bugs.webkit.org/show_bug.cgi?id=191031
1467
1468         Reviewed by Michael Catanzaro.
1469
1470         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1471         (TestWebKitAPI::TEST_F): Remove a test for a domain
1472         that is not registrable and shouldn't be tested there.
1473
1474 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1475
1476         Modernize WebKit nibs and lprojs for localization's sake
1477         https://bugs.webkit.org/show_bug.cgi?id=190911
1478         <rdar://problem/45349466>
1479
1480         Reviewed by Dan Bernstein.
1481
1482         * Scripts/check-inspector-strings:
1483         * Scripts/update-webkit-localizable-strings:
1484         * gtk/manifest.txt.in:
1485         * wpe/manifest.txt.in:
1486         English->en
1487
1488 2018-10-29  Daniel Bates  <dabates@apple.com>
1489
1490         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
1491         https://bugs.webkit.org/show_bug.cgi?id=191036
1492
1493         Reviewed by Andy Estes.
1494
1495         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
1496         by an enum that contains two or more enumerators with the same value. For example, suppose
1497         you have the following enum:
1498
1499         enum Flag {
1500             A = 1 << 0,
1501             AAlias = A,
1502         };
1503
1504         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
1505         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
1506         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
1507         tend to be used in bounds checks as opposed to code that adds to a set.
1508
1509         * lldb/lldbWebKitTester/main.cpp:
1510         (testSummaryProviders):
1511         * lldb/lldb_webkit.py:
1512         (WTFOptionSetProvider.update):
1513         * lldb/lldb_webkit_unittest.py:
1514         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
1515         (TestSummaryProviders):
1516         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
1517
1518 2018-10-29  Daniel Bates  <dabates@apple.com>
1519
1520         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
1521         https://bugs.webkit.org/show_bug.cgi?id=191033
1522
1523         Reviewed by Andy Estes.
1524
1525         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
1526         We display the same details in the summary for a Frame because its Document tends to be the most
1527         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
1528         and whether the origin has universal access.
1529
1530         * lldb/lldb_webkit.py:
1531         (__lldb_init_module):
1532         Register new summary providers.
1533
1534         (WebCoreSecurityOrigin_SummaryProvider):
1535         (WebCoreFrame_SummaryProvider):
1536         (WebCoreDocument_SummaryProvider):
1537         Add new summary providers.
1538
1539         (StdOptionalWrapper):
1540         (StdOptionalWrapper.__init__):
1541         (StdOptionalWrapper.has_value):
1542         (StdOptionalWrapper.value):
1543         Convenience data type that provides access to the fields of a std::optional<>.
1544         
1545         (WebCoreSecurityOriginProvider):
1546         (WebCoreSecurityOriginProvider.__init__):
1547         (WebCoreSecurityOriginProvider.is_unique):
1548         (WebCoreSecurityOriginProvider.scheme):
1549         (WebCoreSecurityOriginProvider.host):
1550         (WebCoreSecurityOriginProvider.port):
1551         (WebCoreSecurityOriginProvider.domain):
1552         (WebCoreSecurityOriginProvider.has_universal_access):
1553         (WebCoreSecurityOriginProvider.to_string):
1554         (WebCoreFrameProvider):
1555         (WebCoreFrameProvider.__init__):
1556         (WebCoreFrameProvider.is_main_frame):
1557         (WebCoreFrameProvider.document):
1558         (WebCoreDocumentProvider):
1559         (WebCoreDocumentProvider.__init__):
1560         (WebCoreDocumentProvider.url):
1561         (WebCoreDocumentProvider.origin):
1562         (WebCoreDocumentProvider.page_cache_state):
1563         (WebCoreDocumentProvider.frame):
1564
1565 2018-10-29  Chris Dumez  <cdumez@apple.com>
1566
1567         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
1568         https://bugs.webkit.org/show_bug.cgi?id=190975
1569         <rdar://problem/45059256>
1570
1571         Reviewed by Antti Koivisto.
1572
1573         Add API test coverage.
1574
1575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1576
1577 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1578
1579         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
1580         https://bugs.webkit.org/show_bug.cgi?id=191018
1581
1582         Reviewed by Antti Koivisto.
1583
1584         * LayoutReloaded/misc/LFC-passing-tests.txt:
1585
1586 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1587
1588         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
1589         https://bugs.webkit.org/show_bug.cgi?id=191011
1590
1591         Reviewed by Antti Koivisto.
1592
1593         * LayoutReloaded/misc/LFC-passing-tests.txt:
1594
1595 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1596
1597         Missing from r237549
1598
1599         Reviewed by Antti Koivisto.
1600
1601         * LayoutReloaded/misc/LFC-passing-tests.txt:
1602
1603 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1604
1605         [LFC][IFC] Add support for simple intruding floats.
1606         https://bugs.webkit.org/show_bug.cgi?id=190998
1607
1608         Reviewed by Antti Koivisto.
1609
1610         * LayoutReloaded/misc/LFC-passing-tests.txt:
1611
1612 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1613
1614         [LFC][IFC] Inline layout produces separate runs when float is present.
1615         https://bugs.webkit.org/show_bug.cgi?id=190980
1616
1617         Reviewed by Antti Koivisto.
1618
1619         * LayoutReloaded/misc/LFC-passing-tests.txt:
1620
1621 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
1622
1623         New bytecode format for JSC
1624         https://bugs.webkit.org/show_bug.cgi?id=187373
1625         <rdar://problem/44186758>
1626
1627         Reviewed by Filip Pizlo.
1628
1629         Do not force ENABLE_JIT=true when $forceCLoop is false.
1630
1631         * Scripts/build-jsc:
1632
1633 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1634
1635         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
1636
1637         Unreviewed build fix
1638
1639         The build fails because of some array-bound check related
1640         to strcmp() macro optimizations. Disabling selective Werrors
1641         when building xserver-xorg might get past this.
1642
1643         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
1644         configuration.
1645
1646 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1647
1648         [GTK] Update API test expectations after r237383
1649         https://bugs.webkit.org/show_bug.cgi?id=186913
1650
1651         Unreviewed gardening.
1652
1653         * TestWebKitAPI/glib/TestExpectations.json: Remove
1654         passing TestSSL tests.
1655
1656 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
1657
1658         [WPE] Add the WebKitVersion.h header
1659         https://bugs.webkit.org/show_bug.cgi?id=191015
1660
1661         Reviewed by Michael Catanzaro.
1662
1663         * MiniBrowser/wpe/main.cpp:
1664         (automationStartedCallback): Remove the FIXME and finally enable the
1665         webkit_application_info_set_version() call.
1666         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
1667         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
1668
1669 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1670
1671         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
1672         https://bugs.webkit.org/show_bug.cgi?id=190948
1673
1674         Reviewed by Brent Fulgham.
1675
1676         vcxproj files have been removed in Bug 154388.
1677
1678         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
1679         * Scripts/build-jsc:
1680         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
1681         which is not used because Windows ports are using CMake.
1682
1683 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
1684
1685         HashMap should support selecting a random entry
1686         https://bugs.webkit.org/show_bug.cgi?id=190814
1687
1688         Reviewed by Ryosuke Niwa.
1689
1690         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
1691         IsEvenlyDistributed to reflect the fact that we're only testing the
1692         distribution. Added a test case that covers more table densities and
1693         the remove() operation.
1694
1695 2018-10-27  Charlie Turner  <cturner@igalia.com>
1696
1697         [GTK] Add bubblewrap feature option
1698         https://bugs.webkit.org/show_bug.cgi?id=190981
1699
1700         Reviewed by Xabier Rodriguez-Calvar.
1701
1702         Without this, it was not possible to disable the bubblewrap sandbox
1703         from the webkit build scripts.
1704
1705         * Scripts/webkitperl/FeatureList.pm:
1706
1707 2018-10-26  Commit Queue  <commit-queue@webkit.org>
1708
1709         Unreviewed, rolling out r237479 and r237484.
1710         https://bugs.webkit.org/show_bug.cgi?id=190978
1711
1712         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
1713
1714         Reverted changesets:
1715
1716         "New bytecode format for JSC"
1717         https://bugs.webkit.org/show_bug.cgi?id=187373
1718         https://trac.webkit.org/changeset/237479
1719
1720         "Gardening: Build fix after r237479."
1721         https://bugs.webkit.org/show_bug.cgi?id=187373
1722         https://trac.webkit.org/changeset/237484
1723
1724 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
1725
1726         New bytecode format for JSC
1727         https://bugs.webkit.org/show_bug.cgi?id=187373
1728         <rdar://problem/44186758>
1729
1730         Reviewed by Filip Pizlo.
1731
1732         Do not force ENABLE_JIT=true when $forceCLoop is false.
1733
1734         * Scripts/build-jsc:
1735
1736 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
1737
1738         HashMap should support selecting a random entry
1739         https://bugs.webkit.org/show_bug.cgi?id=190814
1740
1741         Reviewed by Antti Koivisto.
1742
1743         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
1744         more thoroughly test for randomness.
1745
1746 2018-10-26  Antti Koivisto  <antti@apple.com>
1747
1748         hashSet.remove(hashSet.random()) doesn't build
1749         https://bugs.webkit.org/show_bug.cgi?id=190953
1750
1751         Reviewed by Chris Dumez.
1752
1753         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1754         (TestWebKitAPI::TEST):
1755
1756 2018-10-26  Zalan Bujtas  <zalan@apple.com>
1757
1758         [LFC][IFC] Layout floats as part of the inline content
1759         https://bugs.webkit.org/show_bug.cgi?id=190942
1760
1761         Reviewed by Antti Koivisto.
1762
1763         * LayoutReloaded/misc/LFC-passing-tests.txt:
1764
1765 2018-10-26  Alicia Boya García  <aboya@igalia.com>
1766
1767         [MSE][WTF][Media] Invalid MediaTime should be falsy
1768         https://bugs.webkit.org/show_bug.cgi?id=190893
1769
1770         Reviewed by Jer Noble.
1771
1772         This patch adds additional API tests for the conversions from
1773         MediaTime to boolean.
1774
1775         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1776         (TestWebKitAPI::TEST):
1777
1778 2018-10-25  Chris Dumez  <cdumez@apple.com>
1779
1780         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
1781         https://bugs.webkit.org/show_bug.cgi?id=190915
1782         <rdar://problem/45059069>
1783
1784         Reviewed by Geoffrey Garen.
1785
1786         Add API test coverage.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1789
1790 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
1791
1792         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
1793         https://bugs.webkit.org/show_bug.cgi?id=190896
1794
1795         Reviewed by Matt Baker.
1796
1797         * Scripts/webkitpy/common/config/watchlist:
1798
1799 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
1800
1801         HashMap should support selecting a random entry
1802         https://bugs.webkit.org/show_bug.cgi?id=190814
1803
1804         Reviewed by Antti Koivisto.
1805
1806         Unit testing is fun and easy!
1807
1808         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1809         (TestWebKitAPI::ZeroHash::hash):
1810         (TestWebKitAPI::TEST):
1811
1812 2018-10-24  Tim Horton  <timothy_horton@apple.com>
1813
1814         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
1815         https://bugs.webkit.org/show_bug.cgi?id=190897
1816
1817         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1818         (TestWebKitAPI::TEST):
1819         Disable the test for now.
1820
1821 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1822
1823         Clean up some obsolete macOS version guards
1824         https://bugs.webkit.org/show_bug.cgi?id=190887
1825
1826         Reviewed by Dan Bernstein.
1827
1828         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1829         (__simulated_forceClickAssociatedEventsMask):
1830         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
1831         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1832         (WTR::initializeWebViewConfiguration):
1833         * WebKitTestRunner/mac/EventSenderProxy.mm:
1834         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1835
1836 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1837
1838         Turn on Conic Gradients
1839         https://bugs.webkit.org/show_bug.cgi?id=190810
1840
1841         Reviewed by Tim Horton.
1842
1843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1844
1845 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
1846
1847         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
1848         https://bugs.webkit.org/show_bug.cgi?id=190328
1849
1850         Reviewed by Michael Catanzaro.
1851
1852         * TestWebKitAPI/CMakeLists.txt:
1853         * TestWebKitAPI/PlatformWPE.cmake:
1854
1855 2018-10-24  Chris Dumez  <cdumez@apple.com>
1856
1857         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
1858         https://bugs.webkit.org/show_bug.cgi?id=190846
1859         <rdar://problem/45058938>
1860
1861         Reviewed by Antti Koivisto.
1862
1863         Add API test coverage.
1864
1865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1866
1867 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
1868
1869         [GTK] TestSSL failing because of missing libsoup patch
1870         https://bugs.webkit.org/show_bug.cgi?id=190869
1871
1872         Reviewed by Michael Catanzaro.
1873
1874         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
1875         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1876
1877 2018-10-23  Justin Fan  <justin_fan@apple.com>
1878
1879         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
1880         https://bugs.webkit.org/show_bug.cgi?id=190817
1881
1882         Reviewed by Dean Jackson.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
1886         (TestWebKitAPI::TEST_F):
1887         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1888         (TestWebKitAPI::TEST_F):
1889         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
1890         (TestWebKitAPI::TEST_F):
1891         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1892         (TestWebKitAPI::TEST_F):
1893         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
1894         (TestWebKitAPI::TEST_F):
1895         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
1896
1897 2018-10-23  Chris Dumez  <cdumez@apple.com>
1898
1899         [PSON] Add support for cross-site client-side redirects
1900         https://bugs.webkit.org/show_bug.cgi?id=190806
1901         <rdar://problem/45047344>
1902
1903         Reviewed by Geoffrey Garen.
1904
1905         Add API test coverage.
1906
1907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1908         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
1909         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
1910
1911 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
1912
1913         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
1914         https://bugs.webkit.org/show_bug.cgi?id=190789
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         When the network process serializes certificate data to other
1919         processes through the argument coders, the certificate chain, if
1920         present, is lost. In practice this means that applications using
1921         the public API to process certificate info have no details on the
1922         certificate chain, other than the very basics included in the
1923         certificate. Serialize the entire chain if available in the
1924         certificate.
1925
1926         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1927         (testSSL): Test that the self-signed certificate has no bogus
1928         issuer certificate.
1929
1930 2018-10-22  Tim Horton  <timothy_horton@apple.com>
1931
1932         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
1933         https://bugs.webkit.org/show_bug.cgi?id=190801
1934         <rdar://problem/43674361>
1935
1936         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1937         (TEST):
1938         Use a parented WKWebView for this test, otherwise none of the assertions
1939         about gesture recognizers work anymore.
1940
1941 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
1942
1943         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
1944         https://bugs.webkit.org/show_bug.cgi?id=187972
1945
1946         Unreviewed test gardening.
1947
1948         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1949         (TestWebKitAPI::TEST): Disable the flaky test.
1950
1951 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1952
1953         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
1954         https://bugs.webkit.org/show_bug.cgi?id=190777
1955
1956         Reviewed by Tim Horton.
1957
1958         Implement isShowingDataListSuggestions on iOS. See below for more details.
1959
1960         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1961         (WTR::UIScriptController::isShowingDataListSuggestions const):
1962
1963         Add a stub implementation for DumpRenderTree.
1964
1965         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1966         (WTR::UIScriptController::isShowingDataListSuggestions const):
1967
1968         Move this stub implementation to !PLATFORM(COCOA).
1969
1970         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1971         (WTR::forEachViewInHierarchy):
1972
1973         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
1974
1975         (WTR::UIScriptController::isShowingDataListSuggestions const):
1976
1977         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
1978
1979 2018-10-19  Dan Bernstein  <mitz@apple.com>
1980
1981         [macOS] MiniBrowser has an unused injected bundle
1982         https://bugs.webkit.org/show_bug.cgi?id=190770
1983
1984         Reviewed by Tim Horton.
1985
1986         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
1987         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
1988           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
1989         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
1990         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
1991         * MiniBrowser/mac/Bundle: Removed.
1992
1993 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1994
1995         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
1996         https://bugs.webkit.org/show_bug.cgi?id=190621
1997         <rdar://problem/45310649>
1998
1999         Reviewed by Tim Horton.
2000
2001         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2002
2003         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2004         (WTR::UIScriptController::resignFirstResponder):
2005         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2006         (WTR::UIScriptController::resignFirstResponder):
2007         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2008         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2009         (WTR::UIScriptController::resignFirstResponder):
2010         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2011         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2012         (WTR::UIScriptController::resignFirstResponder):
2013         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2014         (WTR::PlatformWebView::makeWebViewFirstResponder):
2015
2016         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2017         responder on the WKWebView when running iOS layout tests.
2018
2019         * WebKitTestRunner/ios/TestControllerIOS.mm:
2020         (WTR::TestController::platformResetStateToConsistentValues):
2021
2022         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2023
2024 2018-10-19  Dean Jackson  <dino@apple.com>
2025
2026         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2027         https://bugs.webkit.org/show_bug.cgi?id=186946
2028         <rdar://problem/41724248>
2029
2030         Reviewed by Antoine Quint.
2031
2032         If the incoming test has different enableWebAnimationsCSSIntegration options,
2033         then we need to create a new WebView.
2034
2035         * DumpRenderTree/TestOptions.cpp:
2036         (TestOptions::webViewIsCompatibleWithOptions const):
2037
2038 2018-10-19  Charlie Turner  <cturner@igalia.com>
2039
2040         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2041         https://bugs.webkit.org/show_bug.cgi?id=190738
2042
2043         Reviewed by Xabier Rodriguez-Calvar.
2044
2045         Add a GStreamer patch to avoid crashing when the run-time logging
2046         level is TRACE. There was a missing null check which caused many
2047         tests to crash.
2048
2049         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2050
2051 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2052
2053         [Media] Use nanoseconds as MaximumTimeScale
2054         https://bugs.webkit.org/show_bug.cgi?id=190631
2055
2056         Rebased MediaTime tests covering timescales over the maximum.
2057
2058         Reviewed by Jer Noble.
2059
2060         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2061         (TestWebKitAPI::TEST):
2062
2063 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2064
2065         clean-webkit pulls in many unnecessary dependencies in webkitpy
2066         https://bugs.webkit.org/show_bug.cgi?id=190732
2067
2068         Reviewed by Alexey Proskuryakov.
2069
2070         * Scripts/webkitpy/common/host.py:
2071         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2072         (Host):
2073         (Host.bugs):
2074         (Host.bugzilla):
2075         (Host.web):
2076
2077 2018-10-18  Chris Dumez  <cdumez@apple.com>
2078
2079         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2080         https://bugs.webkit.org/show_bug.cgi?id=190721
2081         <rdar://problem/45059699>
2082
2083         Reviewed by Alex Christensen.
2084
2085         Add API test coverage.
2086
2087         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2088
2089 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2090
2091         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2092         https://bugs.webkit.org/show_bug.cgi?id=190729
2093
2094         Reviewed by Tim Horton.
2095
2096         * DumpRenderTree/AccessibilityController.h:
2097         * DumpRenderTree/AccessibilityTextMarker.h:
2098         * DumpRenderTree/AccessibilityUIElement.cpp:
2099         (AccessibilityUIElement::getJSClass):
2100         * DumpRenderTree/AccessibilityUIElement.h:
2101         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2102         * DumpRenderTree/TestRunner.cpp:
2103         (getSecureEventInputIsEnabledCallback):
2104         (TestRunner::staticFunctions):
2105         (TestRunner::callUIScriptCallback):
2106         * DumpRenderTree/TestRunner.h:
2107         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2108         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2109         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2110         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2111         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2112         * DumpRenderTree/ios/TextInputControllerIOS.m:
2113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2114         * DumpRenderTree/mac/AppleScriptController.m:
2115         * DumpRenderTree/mac/DumpRenderTree.mm:
2116         (createWebViewAndOffscreenWindow):
2117         (destroyWebViewAndOffscreenWindow):
2118         (resetWebPreferencesToConsistentValues):
2119         (setDefaultsToConsistentValuesForTesting):
2120         (allocateGlobalControllers):
2121         (releaseGlobalControllers):
2122         (addTestPluginsToPluginSearchPath):
2123         (prepareConsistentTestingEnvironment):
2124         (dumpRenderTree):
2125         (DumpRenderTreeMain):
2126         (dumpFrameAsPDF):
2127         (dumpBackForwardListForAllWindows):
2128         (updateDisplay):
2129         (dump):
2130         (resetWebViewToConsistentStateBeforeTesting):
2131         (runTest):
2132         (displayWebView):
2133         (displayAndTrackRepaintsWebView):
2134         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2135         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2136         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2137         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2138         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2139         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2140         (-[DumpRenderTreeWindow close]):
2141         (-[DumpRenderTreeWindow webView]):
2142         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2143         * DumpRenderTree/mac/EventSendingController.h:
2144         * DumpRenderTree/mac/EventSendingController.mm:
2145         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2146         (+[EventSendingController webScriptNameForSelector:]):
2147         (-[EventSendingController dealloc]):
2148         (-[EventSendingController currentEventTime]):
2149         (-[EventSendingController clearKillRing]):
2150         (modifierFlags):
2151         (-[EventSendingController mouseDown:withModifiers:]):
2152         (-[EventSendingController scalePageBy:atX:andY:]):
2153         (-[EventSendingController mouseUp:withModifiers:]):
2154         (-[EventSendingController mouseMoveToX:Y:]):
2155         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2156         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2157         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2158         (-[FrameLoadDelegate init]):
2159         (-[FrameLoadDelegate dealloc]):
2160         (-[FrameLoadDelegate processWork:]):
2161         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2162         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2163         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2164         * DumpRenderTree/mac/LayoutTestHelper.m:
2165         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2166         (-[MockGeolocationProvider timerFired]):
2167         * DumpRenderTree/mac/TestRunnerMac.mm:
2168         (TestRunner::setMainFrameIsFirstResponder):
2169         (TestRunner::setAutomaticLinkDetectionEnabled):
2170         (TestRunner::setUseDashboardCompatibilityMode):
2171         (TestRunner::isCommandEnabled):
2172         (TestRunner::inspectorTestStubURL):
2173         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2174         (TestRunner::abortModal):
2175         (TestRunner::setTextDirection):
2176         (TestRunner::addChromeInputField):
2177         (TestRunner::removeChromeInputField):
2178         (TestRunner::focusWebView):
2179         (TestRunner::setBackingScaleFactor):
2180         (TestRunner::imageCountInGeneralPasteboard const):
2181         * DumpRenderTree/mac/UIDelegate.h:
2182         * DumpRenderTree/mac/UIDelegate.mm:
2183         (-[UIDelegate modalWindowWillClose:]):
2184         (-[UIDelegate webViewRunModal:]):
2185         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2186         (-[UIDelegate dealloc]):
2187         * Scripts/check-for-inappropriate-objc-class-names:
2188         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2189         * TestRunnerShared/spi/UIKitTestSPI.h:
2190         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2191         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2192         (WebCore::operator<<):
2193         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2194         (TestWebKitAPI::TEST):
2195         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2196         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2197         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2198         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2199         (TestWebKitAPI::TEST):
2200         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2201         (TestWebKitAPI::TEST):
2202         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2203         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2204         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2205         (TEST):
2206         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2207         (TEST):
2208         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2209         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2210         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2211         (TEST):
2212         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2213         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2214         (createWebViewWithCustomPasteboardDataEnabled):
2215         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2216         (TEST):
2217         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2218         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2219         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2220         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2221         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2222         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2223         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2224         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2225         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2226         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2227         (defaultWebsiteCacheDirectory):
2228         (defaultApplicationCacheDirectory):
2229         (TEST):
2230         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2231         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2232         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2233         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2234         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2235         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2236         (TestWebKitAPI::TEST):
2237         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2238         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2239         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2240         (runTestWithWidth):
2241         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2242         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2243         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2244         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2245         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2246         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2247         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2248         (platformCopyRichTextWithMultipleAttachments):
2249         (platformCopyRichTextWithImage):
2250         (platformCopyPNG):
2251         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2252         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2253         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2254         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2255         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2256         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2257         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2258         (TEST):
2259         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2260         (TEST):
2261         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2262         (TEST):
2263         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2264         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2265         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2266         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2267         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2268         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2269         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2270         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2271         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2272         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2273         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2274         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2275         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2276         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2277         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2278         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2279         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2280         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2281         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2282         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2283         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2284         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2285         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2286         (-[WKWebView _test_waitForDidFinishNavigation]):
2287         * TestWebKitAPI/cocoa/TestWKWebView.h:
2288         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2289         * TestWebKitAPI/config.h:
2290         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2291         * TestWebKitAPI/ios/TestWKWebViewController.h:
2292         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2293         * TestWebKitAPI/ios/UIKitSPI.h:
2294         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2295         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2296         (WTR::InjectedBundle::beginTesting):
2297         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2298         (WTR::TestRunner::inspectorTestStubURL):
2299         * WebKitTestRunner/TestController.cpp:
2300         (WTR::TestController::webProcessName):
2301         (WTR::TestController::networkProcessName):
2302         * WebKitTestRunner/TestInvocation.cpp:
2303         (WTR::TestInvocation::invoke):
2304         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2305         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2306         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2307         (WTR::initializeWebViewConfiguration):
2308         (WTR::TestController::platformCreateWebView):
2309         (WTR::TestController::imageCountInGeneralPasteboard const):
2310         (WTR::TestController::addTestKeyToKeychain):
2311         (WTR::TestController::cleanUpKeychain):
2312         (WTR::TestController::keyExistsInKeychain):
2313         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2314         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2315         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2316
2317 2018-10-18  Chris Dumez  <cdumez@apple.com>
2318
2319         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2320         https://bugs.webkit.org/show_bug.cgi?id=190688
2321         <rdar://problem/45354095>
2322
2323         Reviewed by Antti Koivisto.
2324
2325         Extended API test coverage to confirm that:
2326         - We do not accumulate more than 3 suspended processes.
2327         - We can navigate back 3 times and use the page cache for each of these loads.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2330
2331 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2332
2333         Enable the datalist element by default on iOS and macOS
2334         https://bugs.webkit.org/show_bug.cgi?id=190594
2335         <rdar://problem/45281159>
2336
2337         Reviewed by Ryosuke Niwa and Tim Horton.
2338
2339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2340
2341 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
2342
2343         AX: Certain tags should identify their context to iOS API
2344         https://bugs.webkit.org/show_bug.cgi?id=190622
2345         <rdar://problem/45308194>
2346
2347         Reviewed by Zalan Bujtas.
2348
2349         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2350         (AccessibilityUIElement::stringAttributeValue):
2351         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2352         (WTR::AccessibilityUIElement::stringAttributeValue):
2353
2354 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
2355
2356         Add a switch for Web SQL
2357         https://bugs.webkit.org/show_bug.cgi?id=190271
2358
2359         Reviewed by Ryosuke Niwa.
2360
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::resetPreferencesToConsistentValues):
2363
2364 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2365
2366         Remove InjectedBundleBackForwardList
2367         https://bugs.webkit.org/show_bug.cgi?id=190640
2368
2369         Reviewed by Chris Dumez.
2370
2371         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2372         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
2373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2374         (WTR::InjectedBundlePage::prepare):
2375         (WTR::InjectedBundlePage::dumpHistory):
2376         (WTR::hasPrefix): Deleted.
2377         (WTR::compareByTargetName): Deleted.
2378         (WTR::dumpBackForwardListItem): Deleted.
2379         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
2380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2382         (WTR::TestRunner::clearBackForwardList):
2383
2384 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
2385
2386         Unreviewed, added myself to contributors.json.
2387
2388         * Scripts/webkitpy/common/config/contributors.json:
2389
2390 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2391
2392         Implement feature flag and bindings for CSS Painting API
2393         https://bugs.webkit.org/show_bug.cgi?id=190237
2394
2395         Reviewed by Ryosuke Niwa.
2396
2397         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2398
2399 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2400
2401         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
2402
2403         * gstreamer/jhbuild.modules:
2404
2405 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2406
2407         [GTK][JHBuild] Disable libmount support in glib
2408
2409         Rubber-stamped by Alejandro G. Castro.
2410
2411         This feature doesn't seem required for our setup.
2412
2413         * gtk/jhbuild.modules:
2414
2415 2018-10-15  Justin Fan  <justin_fan@apple.com>
2416
2417         Add WebGPU 2018 feature flag and experimental feature flag
2418         https://bugs.webkit.org/show_bug.cgi?id=190509
2419
2420         Reviewed by Dean Jackson.
2421
2422         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2423         for the 2018 WebGPU prototype.
2424
2425         * DumpRenderTree/TestOptions.cpp:
2426         (TestOptions::TestOptions):
2427         * DumpRenderTree/TestOptions.h:
2428         * DumpRenderTree/mac/DumpRenderTree.mm:
2429         (setWebPreferencesForTestOptions):
2430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2431
2432 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2433
2434         Update bot configuration for Sierra archive queues
2435         https://bugs.webkit.org/show_bug.cgi?id=190605
2436
2437         Reviewed by Aakash Jain.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/config.json:
2440
2441 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2442
2443         Add support for prefers-color-scheme media query
2444         https://bugs.webkit.org/show_bug.cgi?id=190499
2445         rdar://problem/45212025
2446
2447         Reviewed by Dean Jackson.
2448
2449         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
2450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2451
2452 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2453
2454         [JHBuild] Add xdg-dbus-proxy module
2455         https://bugs.webkit.org/show_bug.cgi?id=190589
2456
2457         Reviewed by Michael Catanzaro.
2458
2459         * gtk/jhbuild.modules:
2460
2461 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2462
2463         [GTK] Add new sandboxing dependencies to install-dependencies
2464         https://bugs.webkit.org/show_bug.cgi?id=190588
2465
2466         Reviewed by Michael Catanzaro.
2467
2468         * gtk/install-dependencies:
2469
2470 2018-10-15  Chris Dumez  <cdumez@apple.com>
2471
2472         Experiment: target=_blank on anchors should imply rel=noopener
2473         https://bugs.webkit.org/show_bug.cgi?id=190481
2474
2475         Reviewed by Alex Christensen.
2476
2477         Add API test coverage to make sure we can now swap process when target=_blank
2478         is specified on an anchor but rel=noopener is not.
2479
2480         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2481
2482 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2483
2484         [iOS] Can't select text after dismissing the keyboard when changing focus
2485         https://bugs.webkit.org/show_bug.cgi?id=190563
2486         <rdar://problem/44613559>
2487
2488         Reviewed by Tim Horton.
2489
2490         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2491         (WTR::UIScriptController::isShowingKeyboard const):
2492
2493         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
2494         details.
2495
2496         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2497         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2498         (WTR::UIScriptController::isShowingKeyboard const):
2499         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2500         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2501         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2502
2503         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
2504         `isShowingKeyboard` as the getter method.
2505
2506         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2507         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2508         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2509         (WTR::UIScriptController::isShowingKeyboard const):
2510
2511 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2512
2513         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
2514
2515         * Scripts/run-javascriptcore-tests:
2516         (runJSCStressTests): Remove wsl-tests.yaml.
2517
2518 2018-10-15  Christopher Reid  <chris.reid@sony.com>
2519
2520         [Curl][WinCairo] Add Public Suffix support to WinCairo
2521         https://bugs.webkit.org/show_bug.cgi?id=183060
2522
2523         Reviewed by Alex Christensen.
2524
2525         Share mac's PublicSuffix tests with all ports.
2526
2527         * TestWebKitAPI/PlatformWin.cmake:
2528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2529         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2530         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
2531
2532 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
2533
2534         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
2535         https://bugs.webkit.org/show_bug.cgi?id=190555
2536
2537         Unreviewed.
2538
2539         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
2540
2541         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
2542         * WebGPUShadingLanguageRI/All.js: Removed.
2543         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
2544         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
2545         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
2546         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
2547         * WebGPUShadingLanguageRI/Assignment.js: Removed.
2548         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
2549         * WebGPUShadingLanguageRI/Block.js: Removed.
2550         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
2551         * WebGPUShadingLanguageRI/Break.js: Removed.
2552         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
2553         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
2554         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
2555         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
2556         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
2557         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
2558         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
2559         * WebGPUShadingLanguageRI/Casts.js: Removed.
2560         * WebGPUShadingLanguageRI/Check.js: Removed.
2561         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
2562         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
2563         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
2564         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
2565         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
2566         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
2567         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
2568         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
2569         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
2570         * WebGPUShadingLanguageRI/Checker.js: Removed.
2571         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
2572         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
2573         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
2574         * WebGPUShadingLanguageRI/Continue.js: Removed.
2575         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
2576         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
2577         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
2578         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
2579         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
2580         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
2581         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
2582         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
2583         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
2584         * WebGPUShadingLanguageRI/EPtr.js: Removed.
2585         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
2586         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
2587         * WebGPUShadingLanguageRI/EnumType.js: Removed.
2588         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
2589         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
2590         * WebGPUShadingLanguageRI/Expression.js: Removed.
2591         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
2592         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
2593         * WebGPUShadingLanguageRI/Field.js: Removed.
2594         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
2595         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
2596         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
2597         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
2598         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
2599         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
2600         * WebGPUShadingLanguageRI/Func.js: Removed.
2601         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
2602         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
2603         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
2604         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
2605         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
2606         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
2607         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
2608         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
2609         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
2610         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
2611         * WebGPUShadingLanguageRI/Inline.js: Removed.
2612         * WebGPUShadingLanguageRI/Inliner.js: Removed.
2613         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
2614         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
2615         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
2616         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
2617         * WebGPUShadingLanguageRI/Lexer.js: Removed.
2618         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
2619         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
2620         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
2621         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
2622         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
2623         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
2624         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
2625         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
2626         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
2627         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
2628         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
2629         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
2630         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
2631         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
2632         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
2633         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
2634         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
2635         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
2636         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
2637         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
2638         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
2639         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
2640         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
2641         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
2642         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
2643         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
2644         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
2645         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
2646         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
2647         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
2648         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
2649         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
2650         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
2651         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
2652         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
2653         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
2654         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
2655         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
2656         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
2657         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
2658         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
2659         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
2660         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
2661         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
2662         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
2663         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
2664         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
2665         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
2666         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
2667         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
2668         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
2669         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
2670         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
2671         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
2672         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
2673         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
2674         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
2675         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
2676         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
2677         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
2678         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
2679         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
2680         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
2681         * WebGPUShadingLanguageRI/NameContext.js: Removed.
2682         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
2683         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
2684         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
2685         * WebGPUShadingLanguageRI/NativeType.js: Removed.
2686         * WebGPUShadingLanguageRI/Node.js: Removed.
2687         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
2688         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
2689         * WebGPUShadingLanguageRI/NullType.js: Removed.
2690         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
2691         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
2692         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
2693         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
2694         * WebGPUShadingLanguageRI/Parse.js: Removed.
2695         * WebGPUShadingLanguageRI/Prepare.js: Removed.
2696         * WebGPUShadingLanguageRI/Program.js: Removed.
2697         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
2698         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
2699         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
2700         * WebGPUShadingLanguageRI/PtrType.js: Removed.
2701         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
2702         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
2703         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
2704         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
2705         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
2706         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
2707         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
2708         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
2709         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
2710         * WebGPUShadingLanguageRI/Return.js: Removed.
2711         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
2712         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
2713         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
2714         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
2715         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
2716         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
2717         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
2718         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
2719         * WebGPUShadingLanguageRI/Sampler.js: Removed.
2720         * WebGPUShadingLanguageRI/Semantic.js: Removed.
2721         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
2722         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
2723         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
2724         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
2725         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
2726         * WebGPUShadingLanguageRI/StructType.js: Removed.
2727         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
2728         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
2729         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
2730         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
2731         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
2732         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
2733         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
2734         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
2735         * WebGPUShadingLanguageRI/Test.html: Removed.
2736         * WebGPUShadingLanguageRI/Test.js: Removed.
2737         * WebGPUShadingLanguageRI/Texture.js: Removed.
2738         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
2739         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
2740         * WebGPUShadingLanguageRI/Type.js: Removed.
2741         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
2742         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
2743         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
2744         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
2745         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
2746         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
2747         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
2748         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
2749         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
2750         * WebGPUShadingLanguageRI/Value.js: Removed.
2751         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
2752         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
2753         * WebGPUShadingLanguageRI/VectorType.js: Removed.
2754         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
2755         * WebGPUShadingLanguageRI/Visitor.js: Removed.
2756         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
2757         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
2758         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
2759         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
2760         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
2761         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
2762         * WebGPUShadingLanguageRI/index.html: Removed.
2763         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
2764         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
2765
2766 2018-10-15  Philippe Normand  <pnormand@igalia.com>
2767
2768         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
2769         https://bugs.webkit.org/show_bug.cgi?id=190581
2770
2771         Reviewed by Michael Catanzaro.
2772
2773         These bots don't use JHBuild and their host GStreamer version is
2774         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
2775
2776         * BuildSlaveSupport/build.webkit.org-config/config.json:
2777
2778 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2779
2780         Use pragma once in WTF
2781         https://bugs.webkit.org/show_bug.cgi?id=190527
2782
2783         Reviewed by Chris Dumez.
2784
2785         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
2786
2787         * DumpRenderTree/TestRunner.cpp:
2788         (TestRunner::queueLoadHTMLString):
2789         (TestRunner::queueLoadAlternateHTMLString):
2790         (TestRunner::queueBackNavigation):
2791         (TestRunner::queueForwardNavigation):
2792         (TestRunner::queueLoadingScript):
2793         (TestRunner::queueNonLoadingScript):
2794         (TestRunner::queueReload):
2795         * DumpRenderTree/WorkQueue.cpp:
2796         (WorkQueue::singleton): Deleted.
2797         (WorkQueue::WorkQueue): Deleted.
2798         (WorkQueue::queue): Deleted.
2799         (WorkQueue::dequeue): Deleted.
2800         (WorkQueue::count): Deleted.
2801         (WorkQueue::clear): Deleted.
2802         (WorkQueue::processWork): Deleted.
2803         * DumpRenderTree/WorkQueue.h:
2804         (WorkQueue::setFrozen): Deleted.
2805         * DumpRenderTree/WorkQueueItem.h:
2806         * DumpRenderTree/mac/DumpRenderTree.mm:
2807         (runTest):
2808         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2809         (-[FrameLoadDelegate processWork:]):
2810         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2811         * DumpRenderTree/mac/TestRunnerMac.mm:
2812         (TestRunner::notifyDone):
2813         (TestRunner::forceImmediateCompletion):
2814         (TestRunner::queueLoad):
2815         * DumpRenderTree/win/DumpRenderTree.cpp:
2816         (runTest):
2817         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2818         (FrameLoadDelegate::processWork):
2819         (FrameLoadDelegate::locationChangeDone):
2820         * DumpRenderTree/win/TestRunnerWin.cpp:
2821         (TestRunner::notifyDone):
2822         (TestRunner::forceImmediateCompletion):
2823         (TestRunner::queueLoad):
2824
2825 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2826
2827         [JSC] Remove Option::useAsyncIterator
2828         https://bugs.webkit.org/show_bug.cgi?id=190567
2829
2830         Reviewed by Saam Barati.
2831
2832         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2833
2834 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
2835
2836         [WPE] Silence a unused-parameter warning
2837
2838         Unreviewed.
2839         * MiniBrowser/wpe/main.cpp:
2840         (decidePermissionRequest):
2841
2842 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
2843
2844         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
2845         https://bugs.webkit.org/show_bug.cgi?id=190537
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
2850         needs to be split before adding it to the command since it is treated
2851         as a list of args.
2852
2853         * Scripts/webkitpy/common/config/ports.py:
2854         (DeprecatedPort.run_javascriptcore_tests_command):
2855
2856 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2857
2858         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
2859         https://bugs.webkit.org/show_bug.cgi?id=190504
2860         <rdar://problem/45117760>
2861
2862         Reviewed by Tim Horton.
2863
2864         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
2865         macOS and iOS.
2866
2867         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2868         (WTR::UIScriptController::setViewScale):
2869         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2870         (WTR::UIScriptController::setViewScale):
2871         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2872         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2873         (WTR::UIScriptController::setViewScale):
2874         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2875         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
2876
2877         Add a new file for UIScriptController methods on Cocoa platforms.
2878
2879         (WTR::UIScriptController::setViewScale):
2880         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2881         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2882         (WTR::TestController::cocoaResetStateToConsistentValues):
2883
2884         Ensure that _viewScale is reset to 1 after running a layout test.
2885
2886 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
2887
2888         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
2889         https://bugs.webkit.org/show_bug.cgi?id=190536
2890
2891         Reviewed by Alexey Proskuryakov.
2892
2893         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
2894
2895 2018-10-11  Youenn Fablet  <youenn@apple.com>
2896
2897         IOS 12 - Service worker cache not shared when added to homescreen
2898         https://bugs.webkit.org/show_bug.cgi?id=190269
2899         <rdar://problem/45009961>
2900
2901         Reviewed by Alex Christensen.
2902
2903         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2904         Add test to ensure that CacheStorage use the default website data store parameters.
2905
2906 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2907
2908         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
2909         https://bugs.webkit.org/show_bug.cgi?id=190476
2910         <rdar://problem/32757191>
2911
2912         Reviewed by Megan Gardner.
2913
2914         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
2915         (TEST):
2916         Add a test that we don't crash.
2917
2918 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2919
2920         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
2921
2922         * Scripts/webkitpy/tool/steps/options.py:
2923         (Options):
2924         Fix the name of the variable that the --cc-radar option writes into.
2925
2926 2018-10-10  Dean Jackson  <dino@apple.com>
2927
2928         Add --cc-radar option to webkit-patch bug creation
2929         https://bugs.webkit.org/show_bug.cgi?id=190451
2930         <rdar://problem/45176671>
2931
2932         Reviewed by Antoine Quint.
2933
2934         Add a new command line option to automatically
2935         CC radar to new or updated bugs.
2936
2937         * Scripts/webkitpy/tool/commands/commandtest.py:
2938         (CommandsTest.assert_execute_outputs):
2939         * Scripts/webkitpy/tool/commands/upload.py:
2940         (CreateBug.__init__):
2941         (CreateBug.execute):
2942         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2943         (test_prepare_with_cc):
2944         (test_prepare_with_radar):
2945         (test_prepare_with_cc_and_radar):
2946         * Scripts/webkitpy/tool/steps/createbug.py:
2947         (CreateBug.options):
2948         (CreateBug.run):
2949         * Scripts/webkitpy/tool/steps/options.py:
2950         (Options):
2951
2952 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
2953
2954         [GStreamer] Do not build gstgtk plugins
2955         https://bugs.webkit.org/show_bug.cgi?id=190463
2956
2957         Reviewed by Xabier Rodriguez-Calvar.
2958
2959         These plugins pull a GTK+ dependency that, at least in WPE,
2960         is unnecessary. The GTK+ port doesn't need it either, as far
2961         as I can tell.
2962
2963         * gstreamer/jhbuild.modules: Disable gstgtk plugins
2964
2965 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
2966
2967         [GTK][WPE] Add mediaDevices.enumerateDevices support
2968         https://bugs.webkit.org/show_bug.cgi?id=185761
2969
2970         Reviewed by Youenn Fablet.
2971
2972         Added new API test for the mediaDevices.enumerateDevices:
2973         usermedia-enumeratedevices-permission-check. And a new API test
2974         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
2975
2976         * MiniBrowser/gtk/main.c:
2977         (gotWebsiteDataCallback): Added a new section to the about:data
2978         webpage to include the information about the hash salt.
2979         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2980         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
2981         new test checking the enumerateDevices API when permission is
2982         denied and when permission is allowed for the origin.
2983         (beforeAll): Defined the new test.
2984         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2985         (serverCallback): Register a new URI for the enumerateDevices.
2986         (testWebsiteDataConfiguration): Remove the hash salts from the
2987         directories.
2988         (testWebsiteDataDeviceIdHashSalt): New test cheking the
2989         enumerateDevices API.
2990         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
2991         the init structure.
2992         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2993         (WebViewTest::initializeWebView): Make sure the media-stream is
2994         activated in the webView.
2995
2996 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2997
2998         Add WinCairo to the flakiness dashboard
2999         https://bugs.webkit.org/show_bug.cgi?id=188345
3000
3001         Reviewed by Lucas Forschler.
3002
3003         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3004         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3005
3006 2018-10-10  Dean Jackson  <dino@apple.com>
3007
3008         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3009         https://bugs.webkit.org/show_bug.cgi?id=190452
3010         <rdar://problem/45178272>
3011
3012         Reviewed by Myles Maxfield.
3013
3014         Correctly label the appropriate semantics as [[position]]
3015         and [[color(N)]].
3016
3017         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3018         and color attributes. Also use the semantic's index rather than
3019         a counter.
3020         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3021         output, and only include the actual shader code.
3022
3023 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3024
3025         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3026         https://bugs.webkit.org/show_bug.cgi?id=190430
3027
3028         Reviewed by Brian Burg.
3029
3030         * Scripts/webkitdirs.pm:
3031         (argumentsForConfiguration):
3032         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3033         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3034
3035 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3036
3037         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3038         https://bugs.webkit.org/show_bug.cgi?id=190420
3039
3040         Reviewed by Simon Fraser.
3041
3042         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3043         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3044         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3045         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3046         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3047         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3048         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3049         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3050         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3051         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3052         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3053         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3054         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3055         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3056         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3057         Change the testing mechanism for the share sheet such that we up-front
3058         set that it should immediately return with a particular state, instead
3059         of programmatically dismissing the sheet.
3060
3061         Otherwise, running the tests on macOS doesn't work, because we pop
3062         a context menu, which spins the runloop and prevents dismissal from
3063         going through.
3064
3065 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3066
3067         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3068         https://bugs.webkit.org/show_bug.cgi?id=190429
3069
3070         Reviewed by Saam Barati.
3071
3072         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3073         (TestWebKitAPI::TEST_F):
3074
3075 2018-10-10  Chris Dumez  <cdumez@apple.com>
3076
3077         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3078         https://bugs.webkit.org/show_bug.cgi?id=190418
3079         <rdar://problem/45059769>
3080
3081         Reviewed by Geoffrey Garen.
3082
3083         Add API test coverage.
3084
3085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3086
3087 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3088
3089         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3090         https://bugs.webkit.org/show_bug.cgi?id=190191
3091
3092         Reviewed by Michael Catanzaro.
3093
3094         * QueueStatusServer/config/queues.py:
3095         * Scripts/webkitpy/common/config/ews.json:
3096         * Scripts/webkitpy/common/config/ports.py:
3097         (DeprecatedPort.run_javascriptcore_tests_command):
3098         Add the possibility to pass arguments to run-javascriptcore-tests with
3099         the JSCTESTS_OPTIONS environment variable
3100         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3101         (test_ews_name):
3102
3103
3104 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3105
3106         Allow run-javascriptcore-tests to distribute tests between devices
3107         https://bugs.webkit.org/show_bug.cgi?id=190190
3108
3109         Reviewed by Michael Catanzaro.
3110
3111         * Scripts/run-jsc-stress-tests:
3112         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3113         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3114
3115 2018-10-09  Dean Jackson  <dino@apple.com>
3116
3117         Update WHLSL to Metal tester with semantics
3118         https://bugs.webkit.org/show_bug.cgi?id=190416
3119         <rdar://problem/45145139>
3120
3121         Reviewed by Myles Maxfield.
3122
3123         A few small changes to the WHLSL to Metal tools:
3124         - Make it compile by adding some missing JS files :)
3125         - Add semantics to the default shader
3126         - Add FIXMEs to the other shaders
3127         - Create an in-browser test for the WHLSLToMetal codepath
3128         - Fix typos in the semantics checker
3129
3130         * WebGPUShadingLanguageRI/Checker.js:
3131         (Checker.prototype._checkSemantics.checkSemanticTypes):
3132         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3133         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3134         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3135         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3136         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3137         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3138         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3139
3140 2018-10-09  Jer Noble  <jer.noble@apple.com>
3141
3142         Crash when closing WKWebView during enter fullscreen animation
3143         https://bugs.webkit.org/show_bug.cgi?id=190412
3144
3145         Reviewed by Brian Burg.
3146
3147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3148         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3149         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3150         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3151         (TestWebKitAPI::TEST):
3152
3153 2018-10-09  Chris Dumez  <cdumez@apple.com>
3154
3155         Anchor target should be ignored on activation when the download attribute is set
3156         https://bugs.webkit.org/show_bug.cgi?id=190408
3157
3158         Reviewed by Geoffrey Garen.
3159
3160         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3161         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3162         popup blocking.
3163
3164         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3165         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3166         (WTR::TestRunner::setCanOpenWindows):
3167         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3168         * WebKitTestRunner/TestController.cpp:
3169         (WTR::TestController::createOtherPage):
3170         * WebKitTestRunner/TestController.h:
3171         * WebKitTestRunner/TestInvocation.cpp:
3172         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3173         * WebKitTestRunner/TestInvocation.h:
3174
3175 2018-10-09  Jer Noble  <jer.noble@apple.com>
3176
3177         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3178         https://bugs.webkit.org/show_bug.cgi?id=190098
3179         <rdar://problem/42822671>
3180
3181         Reviewed by Brian Burg.
3182
3183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3184         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3185         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3186         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3187         (TestWebKitAPI::TEST):
3188
3189 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3190
3191         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3192         https://bugs.webkit.org/show_bug.cgi?id=189289
3193         <rdar://problem/44120310>
3194
3195         Reviewed by Brent Fulgham.
3196
3197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3198         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3199         (TestWebKitAPI::TEST):
3200
3201 2018-10-09  Chris Dumez  <cdumez@apple.com>
3202
3203         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3204         https://bugs.webkit.org/show_bug.cgi?id=190378
3205         <rdar://problem/45059466>
3206
3207         Reviewed by Geoffrey Garen.
3208
3209         Add API test coverage.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3212
3213 2018-10-09  Jer Noble  <jer.noble@apple.com>
3214
3215         ISOTrackEncryptionBox returns incorrect defaultKeyID
3216         https://bugs.webkit.org/show_bug.cgi?id=190368
3217
3218         Reviewed by Eric Carlson.
3219
3220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3221         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3222         (TestWebKitAPI::TEST):
3223
3224 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3225
3226         [JHBuild] Update to GStreamer 1.14.4
3227         https://bugs.webkit.org/show_bug.cgi?id=190395
3228
3229         Reviewed by Xabier Rodriguez-Calvar.
3230
3231         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3232         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3233         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3234         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3235         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3236
3237 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3238
3239         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3240         https://bugs.webkit.org/show_bug.cgi?id=190386
3241
3242         Reviewed by Ryosuke Niwa.
3243
3244         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3245         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3246         of macOS.
3247
3248         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3249         (TEST):
3250
3251 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3252
3253         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3254         https://bugs.webkit.org/show_bug.cgi?id=190342
3255         <rdar://problem/44767118>
3256
3257         Reviewed by Tim Horton.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3261
3262         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3263         moving the selection around text inside nested list elements.
3264
3265         (TestWebKitAPI::checkParagraphStyles):
3266
3267         Add a new helper to check an NSParagraphStyle against expected results.
3268
3269         (TestWebKitAPI::webViewForTestingFontAttributes):
3270
3271         Allow each test to pass in the name of the test page to load.
3272
3273         (TestWebKitAPI::TEST):
3274         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
3275
3276         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
3279
3280         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
3281
3282 2018-10-08  Justin Fan  <justin_fan@apple.com>
3283
3284         WebGPU: Rename old WebGPU prototype to WebMetal
3285         https://bugs.webkit.org/show_bug.cgi?id=190325
3286         <rdar://problem/44990443>
3287
3288         Reviewed by Dean Jackson.
3289
3290         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3291
3292         * DumpRenderTree/mac/DumpRenderTree.mm:
3293         (enableExperimentalFeatures):
3294         (resetWebPreferencesToConsistentValues):
3295         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3296         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3297         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
3298         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
3299         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3300         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3302         (WTR::InjectedBundle::beginTesting):
3303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3304         (WTR::TestRunner::setWebMetalEnabled):
3305         (WTR::TestRunner::setWebGPUEnabled): Deleted.
3306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3307
3308 2018-10-08  Commit Queue  <commit-queue@webkit.org>
3309
3310         Unreviewed, rolling out r236941.
3311         https://bugs.webkit.org/show_bug.cgi?id=190374
3312
3313         Causing API test failures in new test (Requested by jernoble
3314         on #webkit).
3315
3316         Reverted changeset:
3317
3318         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
3319         https://bugs.webkit.org/show_bug.cgi?id=190368
3320         https://trac.webkit.org/changeset/236941
3321
3322 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3323
3324         Make <input type=color> a runtime enabled (on-by-default) feature
3325         https://bugs.webkit.org/show_bug.cgi?id=189162
3326
3327         Reviewed by Wenson Hsieh and Tim Horton.
3328
3329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3330
3331 2018-10-08  Jer Noble  <jer.noble@apple.com>
3332
3333         ISOTrackEncryptionBox returns incorrect defaultKeyID
3334         https://bugs.webkit.org/show_bug.cgi?id=190368
3335
3336         Reviewed by Eric Carlson.
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3340         (TestWebKitAPI::TEST):
3341
3342 2018-10-08  Alex Christensen  <achristensen@webkit.org>
3343
3344         Remove WKBundleFileHandleRef
3345         https://bugs.webkit.org/show_bug.cgi?id=190360
3346
3347         Reviewed by Tim Horton.
3348
3349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3350         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
3351         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
3352
3353 2018-10-08  Dan Bernstein  <mitz@apple.com>
3354
3355         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
3356         https://bugs.webkit.org/show_bug.cgi?id=190250
3357
3358         Reviewed by Anders Carlsson.
3359
3360         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3361
3362         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3363           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3364           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3365
3366         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
3367
3368         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
3369           around deprecated methods or categories on deprecated classes.
3370         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
3371         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3372         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
3373         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3374
3375         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3376           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3377           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3378
3379         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3380
3381         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
3382         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
3383           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
3384
3385         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3386           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
3387           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
3388
3389         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
3390           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
3391
3392         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3393           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3394           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3395           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
3396           many C SPI headers trigger the strict prototypes warning.
3397
3398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3399
3400         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3401         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3402         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3403         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
3404         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3405         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3406         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3407         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3408         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3409         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3410         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3411         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3412         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3413         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3414         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
3415         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
3416         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3417         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
3418         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
3419         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3420         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3421         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
3422         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
3423         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
3424         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3425         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
3426
3427         In all of the above, suppressed the deprecated implementations warning where needed.
3428
3429         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
3430           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
3431           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3432           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
3433           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3434           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3435           and GCC_NO_COMMON_BLOCKS.
3436
3437         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3438
3439         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3440         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
3441           the deprecated implementations warning.
3442
3443         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3444         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
3445
3446 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
3447
3448         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
3449         https://bugs.webkit.org/show_bug.cgi?id=189238
3450
3451         Reviewed by Xabier Rodriguez-Calvar.
3452
3453         Modifications on GStreamer, tracked in GStreamer bugzilla:
3454         https://bugzilla.gnome.org/show_bug.cgi?id=797231
3455         https://bugzilla.gnome.org/show_bug.cgi?id=765275
3456
3457         * gstreamer/jhbuild.modules: Add new patches.
3458         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
3459         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
3460         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
3461         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
3462
3463 2018-10-06  Dan Bernstein  <mitz@apple.com>
3464
3465         [Xcode] Never build yasm with ASAN
3466         https://bugs.webkit.org/show_bug.cgi?id=190327
3467
3468         Reviewed by Youenn Fablet.
3469
3470         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
3471           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
3472
3473 2018-10-05  Chris Dumez  <cdumez@apple.com>
3474
3475         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
3476         https://bugs.webkit.org/show_bug.cgi?id=190320
3477         <rdar://problem/45044814>
3478
3479         Reviewed by Geoffrey Garen.
3480
3481         Add API test coverage.
3482
3483         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3484         (TestWebKitAPI::TEST):
3485         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3486         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
3487
3488 2018-10-03  Jer Noble  <jer.noble@apple.com>
3489
3490         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3491         https://bugs.webkit.org/show_bug.cgi?id=190266
3492
3493         Reviewed by Eric Carlson.
3494
3495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3496         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3497         (TestWebKitAPI::TEST):
3498
3499 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
3500
3501         Unreviewed, rolling out r236866.
3502
3503         Breaks internal builds.
3504
3505         Reverted changeset:
3506
3507         "Add support for reporting "display composited video frames"
3508         through the VideoPlaybackQuality object."
3509         https://bugs.webkit.org/show_bug.cgi?id=190266
3510         https://trac.webkit.org/changeset/236866
3511
3512 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3513
3514         [WPE][JSC] Use Unified Sources for Platform-specific sources
3515         https://bugs.webkit.org/show_bug.cgi?id=190300
3516
3517         Reviewed by Yusuke Suzuki.
3518
3519         Currently the GTK port already used Unified Sources with the same source files.
3520         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
3521         to the list of libraries to link with.
3522
3523         * TestWebKitAPI/PlatformWPE.cmake:
3524
3525 2018-10-05  Zach Li  <zachli@apple.com>
3526
3527         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
3528         https://bugs.webkit.org/show_bug.cgi?id=190302
3529         <rdar://problem/45031469>
3530
3531         Reviewed by Tim Horton.
3532
3533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3534         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
3535         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
3536         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
3537         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3538         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3539         (TEST):
3540
3541 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3542
3543         [iOS] [WK2] Expose some more editing SPI on WKWebView
3544         https://bugs.webkit.org/show_bug.cgi?id=190232
3545         <rdar://problem/44963368>
3546
3547         Reviewed by Tim Horton.
3548
3549         Adds new API tests to exercise the new SPIs.
3550
3551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3552         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
3553         (-[TestWKWebView querySelectorExists:]):
3554         (TestWebKitAPI::webViewForEditActionTesting):
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3557         (-[TestWKWebView collapseToStart]): Deleted.
3558         (-[TestWKWebView collapseToEnd]): Deleted.
3559         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
3560         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
3561         * TestWebKitAPI/cocoa/TestWKWebView.h:
3562         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3563         (-[TestWKWebView stylePropertyAtSelectionStart:]):
3564         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
3565         (-[TestWKWebView collapseToStart]):
3566         (-[TestWKWebView collapseToEnd]):
3567
3568         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
3569
3570 2018-10-04  Jer Noble  <jer.noble@apple.com>
3571
3572         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3573         https://bugs.webkit.org/show_bug.cgi?id=190266
3574
3575         Reviewed by Eric Carlson.
3576
3577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3578         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3579         (TestWebKitAPI::TEST):
3580
3581 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3582
3583         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
3584         https://bugs.webkit.org/show_bug.cgi?id=190119
3585         <rdar://problem/44767062>
3586
3587         Reviewed by Tim Horton.
3588
3589         Add a new API test that loads a document containing various rich text styles. This test moves the selection
3590         around the document and checks the last set of font attributes received via the new UI delegate hook.
3591
3592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3593         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
3594         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
3595         (-[FontAttributesListener lastFontAttributes]):
3596         (-[TestWKWebView selectElementWithIdentifier:]):
3597         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
3598         (ColorExpectation::ColorExpectation):
3599         (ShadowExpectation::ShadowExpectation):
3600         (checkColor):
3601         (checkShadow):
3602         (checkFont):
3603         (webViewForTestingFontAttributes):
3604         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
3605
3606 2018-10-04  Alan Coon  <alancoon@apple.com>
3607
3608         Unreviewed, add self as contributor.
3609
3610         * Scripts/webkitpy/common/config/contributors.json:
3611
3612 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3613
3614         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
3615         https://bugs.webkit.org/show_bug.cgi?id=190289
3616         <rdar://problem/45020806>
3617
3618         Reviewed by Ryosuke Niwa.
3619
3620         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
3621         attributes at the current selection.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
3625         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3626         (webViewForFontManagerTesting):
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
3629         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
3630
3631         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
3632         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
3633         foreground colors, and background colors.
3634
3635         (sharedFontOptionsForTesting):
3636         (+[TestFontOptions sharedInstance]):
3637         (-[TestFontOptions initWithFontOptions:]):
3638         (-[TestFontOptions selectedAttributes]):
3639         (-[TestFontOptions fontOptions]):
3640         (-[TestFontOptions shadowWidth]):
3641         (-[TestFontOptions setShadowWidth:]):
3642         (-[TestFontOptions shadowHeight]):
3643         (-[TestFontOptions setShadowHeight:]):
3644         (-[TestFontOptions setShadowBlurRadius:]):
3645         (-[TestFontOptions setHasShadow:]):
3646         (-[TestFontOptions foregroundColor]):
3647         (-[TestFontOptions setForegroundColor:]):
3648         (-[TestFontOptions backgroundColor]):
3649         (-[TestFontOptions setBackgroundColor:]):
3650         (-[TestFontOptions _dispatchFontAttributeChanges]):
3651         (-[TestFontOptions convertAttributes:]):
3652         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
3653         (-[TestFontOptions forwardInvocation:]):
3654
3655 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
3656
3657         [WebAuthN] Move time out control from WebProcess to UIProcess
3658         https://bugs.webkit.org/show_bug.cgi?id=189642
3659         <rdar://problem/44476765>
3660
3661         Reviewed by Chris Dumez.
3662
3663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3664         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3665
3666 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3667
3668         Runtime flag and IDL for MediaRecorder
3669         https://bugs.webkit.org/show_bug.cgi?id=190018
3670
3671         Reviewed by Youenn Fablet and Chris Dumez.
3672
3673         * DumpRenderTree/mac/DumpRenderTree.mm:
3674         (enableExperimentalFeatures):
3675
3676 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3677
3678         [LayoutTests][Win] Stop wpt server correctly.
3679         https://bugs.webkit.org/show_bug.cgi?id=190248
3680
3681         Reviewed by Fujii Hironori.
3682
3683         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
3684         Also refactoring the detection of Windows and cygwin environment check.
3685
3686         * Scripts/webkitpy/common/system/executive.py:
3687         (Executive.__init__): Check environment once.
3688         (Executive._should_close_fds):
3689         (Executive.kill_process):
3690         (Executive.check_running_pid):
3691         (Executive.running_pids):
3692         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
3693         (Executive.kill_all):
3694         (Executive._child_process_encoding):
3695         (Executive._should_encode_child_process_arguments):
3696         (Executive.popen):
3697         (Executive.run_in_parallel):
3698
3699 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3700
3701         Convert tests to use navigation client
3702         https://bugs.webkit.org/show_bug.cgi?id=190153
3703
3704         Reviewed by Alex Christensen.
3705
3706         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
3707
3708         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3709         (TestWebKitAPI::decidePolicyForNavigationAction):
3710         (TestWebKitAPI::setPagePolicyClient):
3711         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
3712         (TestWebKitAPI::didCommitNavigationCallback):
3713         (TestWebKitAPI::TEST):
3714         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
3715
3716 2018-10-03  Dan Bernstein  <mitz@apple.com>
3717
3718         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
3719         https://bugs.webkit.org/show_bug.cgi?id=190270
3720
3721         Reviewed by Wenson Hsieh.
3722
3723         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3724         (TestWebKitAPI::TEST):
3725
3726 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3727
3728         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3729         https://bugs.webkit.org/show_bug.cgi?id=190238
3730
3731         Reviewed by Antti Koivisto.
3732
3733         * DumpRenderTree/TestOptions.h:
3734         * DumpRenderTree/mac/DumpRenderTree.mm:
3735         (resetWebPreferencesToConsistentValues):
3736
3737 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3738
3739         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
3740         https://bugs.webkit.org/show_bug.cgi?id=179787
3741         <rdar://problem/35593389>
3742
3743         Reviewed by Tim Horton.
3744
3745         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
3746         menu items.
3747
3748         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3749         (webViewForFontManagerTesting):
3750         (menuItemCellForFontAction):
3751         (TestWebKitAPI::TEST):
3752
3753 2018-10-02  Chris Dumez  <cdumez@apple.com>
3754
3755         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
3756         https://bugs.webkit.org/show_bug.cgi?id=190176
3757         <rdar://problem/44925871>
3758
3759         Reviewed by Alex Christensen.
3760
3761         Use a URL that is truly recognized as invalid by WebCore's URL parser.
3762
3763         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
3764         (TEST):
3765
3766 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3767
3768         Remove ParsedURLString
3769         https://bugs.webkit.org/show_bug.cgi?id=190154
3770
3771         Reviewed by Chris Dumez.
3772
3773         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3774         (TestWebKitAPI::TEST_F):
3775         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3776         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3777         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3778         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3779         (TestWebKitAPI::TEST):
3780
3781 2018-10-02  Daniel Bates  <dabates@apple.com>
3782
3783         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
3784         (https://bugs.webkit.org/show_bug.cgi?id=190017)
3785
3786         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
3787             WKWebViewAutofillTests.AutofillRequiresInputSession
3788             DragAndDropTests.ExternalSourceJPEGOnly
3789             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
3790
3791         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
3792         we will look to swizzle this method for all test by default.
3793
3794         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3795         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3796         (TestWebKitAPI::TEST):
3797         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3798         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3799         (TestWebKitAPI::TEST):
3800         * TestWebKitAPI/ios/UIKitSPI.h:
3801
3802 2018-10-02  Dawei Fenton  <realdawei@apple.com>
3803
3804         Unreviewed, rolling out r236751.
3805
3806         broke the iOS Build
3807
3808         Reverted changeset:
3809
3810         "Fix iOS TestWebKitAPI failures following
3811         <https://trac.webkit.org/changeset/236619>"
3812         https://bugs.webkit.org/show_bug.cgi?id=190017
3813         https://trac.webkit.org/changeset/236751
3814
3815 2018-10-02  Daniel Bates  <dabates@apple.com>
3816
3817         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
3818         (https://bugs.webkit.org/show_bug.cgi?id=190017)
3819
3820         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
3821             WKWebViewAutofillTests.AutofillRequiresInputSession
3822             DragAndDropTests.ExternalSourceJPEGOnly
3823             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
3824
3825         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
3826         we will look to swizzle this method for all test by default.
3827
3828         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3829         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3830         (TestWebKitAPI::TEST):
3831         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3832         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3833         (TestWebKitAPI::TEST):
3834         * TestWebKitAPI/ios/UIKitSPI.h:
3835
3836 2018-10-01  Dean Jackson  <dino@apple.com>
3837
3838         Remove CSS Animation Triggers
3839         https://bugs.webkit.org/show_bug.cgi?id=190175
3840         <rdar://problem/44925626>
3841
3842         Reviewed by Simon Fraser.
3843
3844         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3845
3846 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
3847
3848         [Flatpak] Use our own check of flatpak repos
3849         https://bugs.webkit.org/show_bug.cgi?id=190194
3850
3851         Allowing us to not mess up with user installation
3852         and "--assumeyes" everywhere.
3853
3854         Reviewed by Michael Catanzaro.
3855
3856         * flatpak/flatpakutils.py:
3857         (FlatpakPackage.__init__):
3858         (FlatpakPackage.install):
3859         (FlatpakPackage.update):
3860         (WebkitFlatpak.load_from_args):
3861         (WebkitFlatpak.__init__):
3862         (WebkitFlatpak.clean_args):
3863
3864 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3865
3866         [macOS] Implement a way for the UI process to request typing attributes at the current selection
3867         https://bugs.webkit.org/show_bug.cgi?id=189983
3868         <rdar://problem/44648705>
3869
3870         Reviewed by Ryosuke Niwa.
3871
3872         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
3873
3874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3875         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
3876         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3877
3878         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
3879         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
3880         additionally check that shadowed text and strike-through are reflected in typing attributes.
3881
3882         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
3883         (-[TestWKWebView typingAttributes]):
3884
3885         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
3886
3887         (-[TestWKWebView collapseToStart]):
3888         (webViewForFontManagerTesting):
3889         (TestWebKitAPI::TEST):
3890         * TestWebKitAPI/cocoa/TestWKWebView.h:
3891         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
3892         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
3893
3894         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
3895
3896         (-[TestInspectorBarItemController initWithInspectorBar:]):
3897         (-[TestInspectorBarItemController inspectorBar]):
3898         (-[TestInspectorBarItemController updateSelectedAttributes]):
3899         (-[TestInspectorBar initWithWebView:]):
3900         (+[TestInspectorBar standardItemControllerClass]):
3901         (+[TestInspectorBar standardTextItemIdentifiers]):
3902         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
3903         (-[TestInspectorBar chooseFontSize:]):
3904         (-[TestInspectorBar chooseFontFamily:]):
3905         (-[TestInspectorBar _chooseColor:inColorWell:]):
3906         (-[TestInspectorBar chooseForegroundColor:]):
3907         (-[TestInspectorBar chooseBackgroundColor:]):
3908         (-[TestInspectorBar formatBold:]):
3909         (-[TestInspectorBar formatItalic:]):
3910         (-[TestInspectorBar formatUnderline:]):
3911
3912         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
3913         styling controls).
3914
3915         (-[TestInspectorBar itemController]):
3916         (-[TestInspectorBar setItemController:]):
3917
3918 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
3919
3920         [Flatpak] Implement icecream and ccache support
3921         https://bugs.webkit.org/show_bug.cgi?id=190146
3922
3923         Reviewed by Alejandro G. Castro.
3924
3925         * flatpak/flatpakutils.py:
3926         (WebkitFlatpak.load_from_args):
3927         (WebkitFlatpak.__init__):
3928         (WebkitFlatpak.clean_args):
3929         (WebkitFlatpak.run_in_sandbox):
3930         (WebkitFlatpak.save_config):
3931         (WebkitFlatpak):
3932         (WebkitFlatpak.setup_ccache):
3933         (WebkitFlatpak.setup_icecc):
3934         (WebkitFlatpak.setup_dev_env):
3935         * flatpak/org.webkit.WebKit.yaml:
3936
3937 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3938
3939         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
3940
3941         * WebKitTestRunner/TestController.cpp:
3942         (WTR::TestController::keyExistsInKeychain):
3943
3944 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3945
3946         [WinCairo] Enable WPT tests environment.
3947         https://bugs.webkit.org/show_bug.cgi?id=190128
3948
3949         Reviewed by Youenn Fablet.
3950
3951         Escaping backslash of the path not to confuse the JSON parser.
3952
3953         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3954         (WebPlatformTestServer._prepare_config):
3955
3956 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
3957
3958         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
3959         https://bugs.webkit.org/show_bug.cgi?id=190150
3960
3961         Reviewed by Fujii Hironori.
3962
3963         * DumpRenderTree/win/DumpRenderTree.cpp:
3964         (setWebPreferencesForTestOptions):
3965         DRT has been recognizing this field, but not propagating its value to WebPreferences.
3966
3967 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3968
3969         Unreviewed, rolling out r236551.
3970
3971         Fails URL validating too aggressively
3972
3973         Reverted changeset:
3974
3975         "URLWithUserTypedString should return nil for URLs deemed to
3976         be invalid by WebCore::URL"
3977         https://bugs.webkit.org/show_bug.cgi?id=189979
3978         https://trac.webkit.org/changeset/236551
3979
3980 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3981
3982         [iOS] Add SPI to customize the input accessory view when focusing an element
3983         https://bugs.webkit.org/show_bug.cgi?id=190152
3984         <rdar://problem/42754975>
3985
3986         Reviewed by Dan Bernstein.
3987
3988         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
3989         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
3990         `-inputAccessoryView`.
3991
3992         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3993         (webViewWithAutofocusedInput):
3994         (TestWebKitAPI::TEST):
3995         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3996         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3997         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3998         (-[TestInputDelegate willStartInputSessionHandler]):
3999         (-[TestInputDelegate _webView:willStartInputSession:]):
4000
4001 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
4002
4003         Remove StorageProcess
4004         https://bugs.webkit.org/show_bug.cgi?id=189975
4005
4006         Reviewed by Geoffrey Garen.
4007
4008         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4009         (TEST):
4010         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4011         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
4012         (TEST):
4013         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4014         (TEST):
4015         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4017         (WTR::TestRunner::terminateStorageProcess): Deleted.
4018         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4019         * WebKitTestRunner/TestController.cpp:
4020         (WTR::TestController::generatePageConfiguration):
4021         (WTR::TestController::databaseProcessName): Deleted.
4022         (WTR::TestController::databaseProcessDidCrash): Deleted.
4023         (WTR::TestController::terminateStorageProcess): Deleted.
4024         * WebKitTestRunner/TestController.h:
4025         * WebKitTestRunner/TestInvocation.cpp:
4026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4027
4028 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
4029
4030         [WebAuthN] Import a JS CBOR coder
4031         https://bugs.webkit.org/show_bug.cgi?id=189877
4032         <rdar://problem/44701124>
4033
4034         Reviewed by Chris Dumez.
4035
4036         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
4037         only if acceptAttestation is true.
4038
4039         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4040         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4041
4042 2018-10-01  Chris Dumez  <cdumez@apple.com>
4043
4044         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
4045         https://bugs.webkit.org/show_bug.cgi?id=190052
4046
4047         Reviewed by Ryosuke Niwa.
4048
4049         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
4050         to log those events. It also uses console.log() before sending those events to indicate what the test is about
4051         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
4052         so that it can log the message.
4053         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
4054         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
4055         handler to be transformed into synchronous IPC.
4056         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
4057         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
4058         messages may end up being out of order, leading to flakiness.
4059
4060         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
4061         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
4062         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
4063
4064         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4065         (WTR::InjectedBundle::outputText):
4066
4067 2018-10-01  Daniel Bates  <dabates@apple.com>
4068
4069         [iOS] Special keys are misidentified in DOM keyboard events
4070         https://bugs.webkit.org/show_bug.cgi?id=189974
4071
4072         Reviewed by Wenson Hsieh.
4073
4074         Add support for testing keys Forward Delete and Num Lock / Clear.
4075
4076         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4077         (hidUsageCodeForCharacter):
4078
4079 2018-10-01  Alex Christensen  <achristensen@webkit.org>
4080
4081         URL should not use TextEncoding internally
4082         https://bugs.webkit.org/show_bug.cgi?id=190111
4083
4084         Reviewed by Andy Estes.
4085
4086         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4087         (TestWebKitAPI::testUserPass):
4088         (TestWebKitAPI::TEST_F):
4089
4090 2018-10-01  Daniel Bates  <dabates@apple.com>
4091
4092         LLDB tests may use wrong configuration of lldbWebKitTester
4093         https://bugs.webkit.org/show_bug.cgi?id=189011
4094
4095         Reviewed by Dean Jackson.
4096
4097         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
4098         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
4099
4100         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
4101         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
4102         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
4103         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
4104         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
4105         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
4106         the Python unittest module, the Python multiprocessing module, and the general principle of unit
4107         tests - to test code in isolation). The unit tests make use of the value of this environment
4108         variable to launch lldbWebKitTester binary.
4109
4110         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
4111         out if this script is invoked for a non-Mac platform.
4112         * Scripts/webkitpy/test/main.py:
4113         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
4114         LLDB_WEBKIT_TESTER_EXECUTABLE.
4115         (_build_lldb_webkit_tester): Deleted.
4116         * lldb/dump_class_layout_unittest.py:
4117         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
4118         this is the only call site that needs the Host object now.
4119         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
4120         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
4121         * lldb/lldbWebKitTester/main.cpp:
4122         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
4123         * lldb/lldb_webkit_unittest.py:
4124         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
4125         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
4126         (TestSummaryProviders):
4127         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
4128         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
4129         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
4130         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
4131         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
4132         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
4133         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
4134
4135 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
4136
4137         [WPE] Update install-dependencies
4138         https://bugs.webkit.org/show_bug.cgi?id=190127
4139
4140         Reviewed by Michael Catanzaro.
4141
4142         * wpe/install-dependencies:
4143         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
4144         It is used by gstvaapidisplay_x11.c.
4145         Add it only for Apt, already ok for Pacman and DNF.
4146
4147         Install libevent-dev for WebRTC (like GTK)
4148
4149         Install libasound2-dev for WebRTC.
4150         Add it only for Apt, already ok for Pacam and DNF.
4151
4152         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
4153
4154 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
4155
4156         [Flatpak] Add libunwind in the sandbox
4157         https://bugs.webkit.org/show_bug.cgi?id=190123
4158
4159         Allowing us to get proper traces in GStreamer trace grabing
4160         debug functions.
4161
4162         Reviewed by Philippe Normand.
4163
4164         * flatpak/org.webkit.WebKit.yaml:
4165
4166 2018-09-29  Commit Queue  <commit-queue@webkit.org>
4167
4168         Unreviewed, rolling out r236631.
4169         https://bugs.webkit.org/show_bug.cgi?id=190112
4170
4171         Caused various eventSender tests, including fast/css/pseudo-
4172         active-style-sharing*, to fail (Requested by smfr on #webkit).
4173
4174         Reverted changeset:
4175
4176         "Regression(r236512): http/tests/navigation/keyboard-events-
4177         during-provisional-navigation.html is flaky"
4178         https://bugs.webkit.org/show_bug.cgi?id=190052
4179         https://trac.webkit.org/changeset/236631
4180
4181 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
4182
4183         [WHLSL] Fix build after r236635
4184         https://bugs.webkit.org/show_bug.cgi?id=189210
4185
4186         Unreviewed.
4187
4188         * WebGPUShadingLanguageRI/Intrinsics.js:
4189         (Intrinsics.):
4190         * WebGPUShadingLanguageRI/Test.js:
4191         (tests.atomicsNull):
4192         (tests.numThreads):
4193         (tests.textureDimensionsNull):
4194
4195 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
4196
4197         [WHLSL] Allow uniform buffers to be used in the interpreter
4198         https://bugs.webkit.org/show_bug.cgi?id=189210
4199
4200         Reviewed by Filip Pizlo.
4201
4202         Every lvalue is associated with an address space, and the propagation of these address spaces
4203         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
4204         of this, so this patch just goes the last few yards. It also updates the standard library to
4205         allow for writing into all writable address spaces for out-params.
4206
4207         * WebGPUShadingLanguageRI/Checker.js:
4208         (Checker.prototype.visitAssignment):
4209         (Checker.prototype._finishVisitingPropertyAccess):
4210         * WebGPUShadingLanguageRI/Intrinsics.js:
4211         (Intrinsics.):
4212         (Intrinsics.checkFalse):
4213         (Intrinsics):
4214         * WebGPUShadingLanguageRI/StandardLibrary.js:
4215         (let.standardLibrary):
4216         * WebGPUShadingLanguageRI/Test.js:
4217         (tests.threadArrayRefLoad):
4218         (tests.threadArrayRefLoadIntLiteral):
4219         (tests.deviceArrayRefLoad):
4220         (tests.threadArrayRefStore):
4221         (tests.deviceArrayRefStore):
4222         (tests.deviceArrayRefStoreIntLiteral):
4223         (tests.threadPointerLoad):
4224         (tests.threadPointerStore):
4225         (tests.devicePointerLoad):
4226         (tests.devicePointerStore):
4227         (tests.arrayLoad):
4228         (tests.constantAddressSpace):
4229         (tests.standardLibraryDevicePointers):
4230         (tests.threadArrayLoad): Deleted.
4231         (tests.threadArrayLoadIntLiteral): Deleted.
4232         (tests.deviceArrayLoad): Deleted.
4233         (tests.threadArrayStore): Deleted.
4234         (tests.deviceArrayStore): Deleted.
4235         (tests.deviceArrayStoreIntLiteral): Deleted.
4236
4237 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4238
4239         No DOM API to instantiate an attachment for an img element
4240         https://bugs.webkit.org/show_bug.cgi?id=189934
4241         <rdar://problem/44743222>
4242
4243         Reviewed by Ryosuke Niwa.
4244
4245         Adds 3 new API tests in WKAttachmentTests:
4246
4247         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
4248         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
4249
4250         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
4251         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
4252
4253         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
4254         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
4255         then result in an image element with the contents of the _WKAttachment's file wrapper.
4256
4257         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4258         (-[TestWKWebView imageElementSize]):
4259         (-[TestWKWebView waitForImageElementSizeToBecome:]):
4260         (TestWebKitAPI::TEST):
4261         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
4262
4263 2018-09-28  Chris Dumez  <cdumez@apple.com>
4264
4265         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
4266         https://bugs.webkit.org/show_bug.cgi?id=190052
4267
4268         Reviewed by Ryosuke Niwa.
4269
4270         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
4271         to log those events. It also uses console.log() before sending those events to indicate what the test is about
4272         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
4273         so that it can log the message.
4274         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
4275         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
4276         handler to be transformed into synchronous IPC.
4277         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
4278         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
4279         messages may end up being out of order, leading to flakiness.
4280
4281         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
4282         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
4283         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
4284
4285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4286         (WTR::InjectedBundle::outputText):
4287
4288 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
4289
4290         [WHLSL] Pointers should have automatically-generated equality checks
4291         https://bugs.webkit.org/show_bug.cgi?id=189986
4292
4293         Reviewed by Filip Pizlo.
4294