4ee2efb95cf2db48634e7c45ecefe60e31ec8e81
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-21  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r150386 and r150397.
4         http://trac.webkit.org/changeset/150386
5         http://trac.webkit.org/changeset/150397
6         https://bugs.webkit.org/show_bug.cgi?id=116572
7
8         Broke a test; Alex is going to try again later. (Requested by
9         thorton on #webkit).
10
11         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
12         (WTR::pathSuitableForTestResult):
13         (WTR::dumpRequestDescriptionSuitableForTestResult):
14         (WTR::dumpResponseDescriptionSuitableForTestResult):
15         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
16         (WTR::InjectedBundlePage::didInitiateLoadForResource):
17         (WTR::InjectedBundlePage::willSendRequestForFrame):
18         (WTR::InjectedBundlePage::didReceiveResponseForResource):
19         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
20         (InjectedBundlePage):
21
22 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
25
26         * Scripts/webkitpy/tool/commands/suggestnominations.py:
27         (AbstractCommitLogCommand._recent_commit_messages):
28
29 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
30
31         [GTK] [CMake] Add support for building WebKit2
32         https://bugs.webkit.org/show_bug.cgi?id=116372
33
34         Reviewed by Gustavo Noronha Silva.
35
36         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
37         * MiniBrowser/gtk/CMakeLists.txt: Added.
38
39 2013-05-21  Jessie Berlin  <jberlin@apple.com>
40
41         Revert r149635, it was too optimistic.
42
43         Rubber-stamped by Andreas Kling.
44
45         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
46         #ifdefs in WebCore code outside of WebCore/platform.
47
48         * Scripts/webkitpy/style/checkers/cpp.py:
49         (check_invalid_increment):
50         (process_line):
51         (CppChecker):
52         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
53         (CppStyleTest.test_plain_integral_bitfields):
54
55 2013-05-21  Jer Noble  <jer.noble@apple.com>
56
57         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
58
59         * lldb/lldb_webkit.py:
60         (WTFVectorProvider.num_children):
61         (WTFVectorProvider.get_child_index):
62         (WTFVectorProvider.get_child_at_index):
63         (WTFVectorProvider.update):
64
65 2013-05-21  Jessie Berlin  <jberlin@apple.com>
66
67         Expose a way to know when forms are added to a page or when form controls are added to a form
68         in the injected bundle
69         https://bugs.webkit.org/show_bug.cgi?id=116334
70
71         Reviewed by Alexey Proskuryakov.
72
73         Add tests for the new callbacks.
74
75         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
76         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
77
78         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
79         (TestWebKitAPI::nullJavaScriptCallback):
80         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
81         being passed in for the callback.
82         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
83         After receiving the message that didAssociateFormControls callback was invoked from adding
84         the form in the onload handler, tell the page to add a password field to the form, which
85         should also invoke didAssociateFormControls callback.
86         (TestWebKitAPI::setInjectedBundleClient):
87         Register to receive messages.
88         (TestWebKitAPI::TEST):
89         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
90         been invoked for both adding the form and for adding a password field to the form.
91
92         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
93         (TestWebKitAPI::shouldNotifyOnFormChanges):
94         Return true so the didAssociateFormControls callback is invoked.
95         (TestWebKitAPI::didAssociateFormControls):
96         Tell the UI process.
97         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
98         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
99         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
100
101         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
102         Add a form in response to the onload event. Add a button that will add the password field
103         for manual testing.
104
105 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
106
107         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
108         https://bugs.webkit.org/show_bug.cgi?id=106341
109
110         Reviewed by Martin Robinson.
111
112         Adds support for retrieving accessibility element at exact point.
113
114         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
115         (WTR::AccessibilityUIElement::elementAtPoint):
116
117 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
118
119         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
120         https://bugs.webkit.org/show_bug.cgi?id=112913
121
122         Reviewed by Martin Robinson.
123
124         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
125         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
126         so the leak appears.
127
128         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
129         (WTR):
130         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
131         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
132         (WTR::AccessibilityController::rootElement):
133         (WTR):
134         (WTR::AccessibilityController::focusedElement):
135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
136         (WTR::checkElementState):
137         (WTR::indexRangeInTable):
138         (WTR::alterCurrentValue):
139         (WTR::AccessibilityUIElement::getChildren):
140         (WTR::AccessibilityUIElement::getChildrenWithRange):
141         (WTR::AccessibilityUIElement::childrenCount):
142         (WTR::AccessibilityUIElement::indexOfChild):
143         (WTR::AccessibilityUIElement::titleUIElement):
144         (WTR::AccessibilityUIElement::parentElement):
145         (WTR::AccessibilityUIElement::allAttributes):
146         (WTR::AccessibilityUIElement::role):
147         (WTR::AccessibilityUIElement::title):
148         (WTR::AccessibilityUIElement::description):
149         (WTR::AccessibilityUIElement::orientation):
150         (WTR::AccessibilityUIElement::stringValue):
151         (WTR::AccessibilityUIElement::language):
152         (WTR::AccessibilityUIElement::x):
153         (WTR::AccessibilityUIElement::y):
154         (WTR::AccessibilityUIElement::width):
155         (WTR::AccessibilityUIElement::height):
156         (WTR::AccessibilityUIElement::intValue):
157         (WTR::AccessibilityUIElement::minValue):
158         (WTR::AccessibilityUIElement::maxValue):
159         (WTR::AccessibilityUIElement::isEnabled):
160         (WTR::AccessibilityUIElement::isFocused):
161         (WTR::AccessibilityUIElement::isSelected):
162         (WTR::AccessibilityUIElement::isExpanded):
163         (WTR::AccessibilityUIElement::isChecked):
164         (WTR::AccessibilityUIElement::rowCount):
165         (WTR::AccessibilityUIElement::columnCount):
166         (WTR::AccessibilityUIElement::rowIndexRange):
167         (WTR::AccessibilityUIElement::columnIndexRange):
168         (WTR::AccessibilityUIElement::cellForColumnAndRow):
169         (WTR::AccessibilityUIElement::increment):
170         (WTR::AccessibilityUIElement::decrement):
171         (WTR::AccessibilityUIElement::press):
172         (WTR::AccessibilityUIElement::documentEncoding):
173         (WTR::AccessibilityUIElement::documentURI):
174         (WTR::AccessibilityUIElement::isFocusable):
175         (WTR::AccessibilityUIElement::isSelectable):
176         (WTR::AccessibilityUIElement::isMultiSelectable):
177         (WTR::AccessibilityUIElement::isVisible):
178
179 2013-05-20  Lucas Forschler  <lforschler@apple.com>
180
181     Rollout 150398.
182     
183 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
184
185         [GTK] Fix concatenations of string literals that are not C++11-compliant
186         https://bugs.webkit.org/show_bug.cgi?id=116449
187
188         Reviewed by Martin Robinson.
189
190         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
191         is simply a matter of separating the string and the string literal that are being concatenated with a space.
192
193         * ImageDiff/gtk/ImageDiff.cpp:
194         (printImage):
195
196 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
197
198         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
199         https://bugs.webkit.org/show_bug.cgi?id=116450
200
201         Reviewed by Martin Robinson.
202
203         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
204         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
205         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
206         TestWebKitAPI programs when compiling them.
207
208         * TestWebKitAPI/GNUmakefile.am:
209
210 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
211
212         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
213         https://bugs.webkit.org/show_bug.cgi?id=116492
214
215         Reviewed by Dirk Pranke.
216
217         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
218
219         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
220         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
221         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
222         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
223         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
224         to memory pressure on the machine.
225
226         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
227         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
228         for a subsequent patch just to make things easier to follow.
229
230         * Scripts/webkitpy/port/driver.py:
231         (DriverProxy.__init__):
232         (DriverProxy.run_test):
233         (DriverProxy.has_crashed):
234         (DriverProxy.stop):
235
236 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
237
238         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
239         https://bugs.webkit.org/show_bug.cgi?id=116423
240
241         Reviewed by Ryosuke Niwa.
242
243         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
244
245         * BuildSlaveSupport/build.webkit.org-config/config.json:
246
247 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
248
249         Remove remaining link-prerender code
250         https://bugs.webkit.org/show_bug.cgi?id=116429
251
252         Reviewed by Darin Adler.
253
254         Link prerendering code was removed in r150356.
255
256         * Scripts/webkitperl/FeatureList.pm:
257         * qmake/mkspecs/features/features.pri:
258
259 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
260
261         commit-queue should check for oops in changelog entries
262         https://bugs.webkit.org/show_bug.cgi?id=116395
263
264         Reviewed by Martin Robinson.
265
266         Make changelog validation fail when it contains oops!.
267
268         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
269         (CommitQueueTask._validate_changelog):
270         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
271         (CommitQueueTaskTest._run_through_task):
272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
273         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
274         (ValidateChangeLogs.options):
275         (ValidateChangeLogs._check_changelog_diff):
276         (ValidateChangeLogs._changelog_contains_oops):
277         (ValidateChangeLogs.run):
278         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
279         (ValidateChangeLogsTest._assert_start_line_produces_output):
280         (ValidateChangeLogsTest.test_check_changelog_diff):
281         (ValidateChangeLogsTest):
282         (ValidateChangeLogsTest.test_changelog_contains_oops):
283
284 2013-05-20  Jessie Berlin  <jberlin@apple.com>
285
286         Expose a way to know when forms are added to a page or when form controls are added to a form
287         in the injected bundle
288         https://bugs.webkit.org/show_bug.cgi?id=116334
289
290         Reviewed by Alexey Proskuryakov.
291
292         Add tests for the new callbacks.
293
294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
295         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
296
297         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
298         (TestWebKitAPI::nullJavaScriptCallback):
299         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
300         being passed in for the callback.
301         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
302         After receiving the message that didAssociateFormControls callback was invoked from adding
303         the form in the onload handler, tell the page to add a password field to the form, which
304         should also invoke didAssociateFormControls callback.
305         (TestWebKitAPI::setInjectedBundleClient):
306         Register to receive messages.
307         (TestWebKitAPI::TEST):
308         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
309         been invoked for both adding the form and for adding a password field to the form.
310
311         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
312         (TestWebKitAPI::shouldNotifyOnFormChanges):
313         Return true so the didAssociateFormControls callback is invoked.
314         (TestWebKitAPI::didAssociateFormControls):
315         Tell the UI process.
316         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
317         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
318         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
319
320         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
321         Add a form in response to the onload event. Add a button that will add the password field
322         for manual testing.
323
324 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
325
326         [EFL][JHBUILD] Make sure eet is built before evas
327         https://bugs.webkit.org/show_bug.cgi?id=116440
328
329         Reviewed by Gyuyoung Kim.
330
331         Mark eet as a dependency of evas since evas requires eet to enable some of its
332         functionality.
333
334         * efl/jhbuild.modules:
335
336 2013-05-20  Alex Christensen  <achristensen@apple.com>
337
338         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
339         https://bugs.webkit.org/show_bug.cgi?id=116125
340
341         Reviewed by Tim Horton.
342
343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
344         (WTR::pathSuitableForTestResult):
345         Changed string operations to match _drt_descriptionSuitableForTestResult.
346         (WTR::dumpRequestDescriptionSuitableForTestResult):
347         (WTR::dumpResponseDescriptionSuitableForTestResult):
348         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
349         (WTR::InjectedBundlePage::didInitiateLoadForResource):
350         (WTR::InjectedBundlePage::willSendRequestForFrame):
351         (WTR::InjectedBundlePage::didReceiveResponseForResource):
352         Pass the main frame's URL to pathSuitableForTestResult.
353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
354         Added WKBundlePageRef to willPerformClientRedirectForFrame.
355
356 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
357
358         fix w3c test importer unit tests after r150324
359         https://bugs.webkit.org/show_bug.cgi?id=116459
360
361         Reviewed by Ryosuke Niwa.
362
363         This patch fixes the unit tests to not actually call out to
364         'hg' (by using a mock executive) and also changes the real
365         directory we crawl from Source/WebCore/css to
366         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
367         still change this to a mock filesystem, but that's a separate change.
368
369         * Scripts/webkitpy/w3c/test_importer.py:
370         (main):
371         (TestImporter.__init__):
372         (TestImporter.load_changeset):
373         * Scripts/webkitpy/w3c/test_importer_unittest.py:
374         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
375         (TestImporterTest.test_import_dir_with_no_tests):
376
377 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
378
379         Unreviewed EFL build fix.
380
381         Fix linking errors due to undefined symbols on Ubuntu 13.04.
382
383         * DumpRenderTree/efl/CMakeLists.txt:
384         * EWebLauncher/CMakeLists.txt:
385         * MiniBrowser/efl/CMakeLists.txt:
386
387 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
388
389         [EFL] Reenabled INDEXED_DATABASE after r150344
390         https://bugs.webkit.org/show_bug.cgi?id=116430
391
392         Reviewed by Gyuyoung Kim.
393
394         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
395         build was fixed in r150344.
396
397         * Scripts/webkitperl/FeatureList.pm:
398
399 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
400
401         [EFL] init/shutdown should be paired in EWebLauncher
402         https://bugs.webkit.org/show_bug.cgi?id=116427
403
404         Reviewed by Christophe Dumez.
405
406         Added ecore_file_shutdown() for cleanup of ecore_file.
407         Removed edje_init and ecore_evas_init because it was in ewk_init().
408
409         * EWebLauncher/main.c:
410         (main):
411
412 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
413
414         [EFL] Add command line option to MiniBrowser to set user agent
415         https://bugs.webkit.org/show_bug.cgi?id=116387
416
417         Reviewed by Christophe Dumez.
418
419         We need this option to compare the rendering differences according to different user agents.
420
421         * MiniBrowser/efl/main.c:
422         (window_create):
423         (elm_main):
424
425 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
426
427         Unreviewed, addressing test-webkitpy failures after r150317.
428
429         * Scripts/webkitpy/w3c/test_converter.py:
430         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
431
432 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
433
434         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
435         https://bugs.webkit.org/show_bug.cgi?id=114554
436
437         Reviewed by Gyuyoung Kim.
438
439         Using variables as target names is very uncommon in CMake.
440         The usual way to specify the name of the resulting binary
441         is to set the OUTPUT_NAME target property.
442
443         * DumpRenderTree/efl/CMakeLists.txt:
444         * EWebLauncher/CMakeLists.txt:
445         * ImageDiff/CMakeLists.txt:
446         * MiniBrowser/efl/CMakeLists.txt:
447         * TestWebKitAPI/CMakeLists.txt:
448         * WebKitTestRunner/CMakeLists.txt:
449         * WebKitTestRunner/PlatformEfl.cmake:
450         * WinCELauncher/CMakeLists.txt:
451
452 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
453
454         Unreviewed EFL build fix.
455
456         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
457         WK2 build after r150305.
458
459         * Scripts/webkitperl/FeatureList.pm:
460
461 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
462
463         [GTK] Parallel build fails if gtk-doc is enabled
464         https://bugs.webkit.org/show_bug.cgi?id=116227
465
466         Reviewed by Martin Robinson.
467
468         * GNUmakefile.am:
469         Don't use the 'all' target to generate the documentation.
470         The prerequisites of this target must be files that need to be
471         built _before_ the actual compilation of WebKit starts. Since the
472         documentation depends on WebKit being built first, this means in
473         practice that the code will be built in parallel with the
474         generation of its dependencies, potentially making the build fail.
475
476 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
477
478         Don't run hg.
479
480         * Scripts/webkitpy/w3c/test_importer_unittest.py:
481         (TestImporterTest):
482
483 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
484
485         Create a script to import W3C tests
486         https://bugs.webkit.org/show_bug.cgi?id=111513
487
488         Reviewed by Ryosuke Niwa.
489
490         This patch attempts to re-land the 'import-w3c-tests'
491         script and accompanying modules.  The tests and code have
492         been cleaned up so that we do not log anything to stdout/stderr
493         while running the tests (thanks to outputcapture) and do not
494         write into the source tree while running the tests, and much
495         but not all of the code has been converted over to using the webkitpy
496
497         * Scripts/import-w3c-tests: Added.
498         * Scripts/webkitpy/w3c/__init__.py: Added.
499         * Scripts/webkitpy/w3c/test_converter.py: Added.
500         (W3CTestConverter):
501         (W3CTestConverter.__init__):
502         (W3CTestConverter.path_from_webkit_root):
503         (W3CTestConverter.read_webkit_prefixed_css_property_list):
504         (W3CTestConverter.convert_for_webkit):
505         (W3CTestConverter.convert_css):
506         (W3CTestConverter.convert_html):
507         (W3CTestConverter.convert_testharness_paths):
508         (W3CTestConverter.convert_prefixed_properties):
509         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
510         (W3CTestConverter.replace_tag):
511         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
512         (W3CTestConverterTest):
513         (W3CTestConverterTest.fake_dir_path):
514         (W3CTestConverterTest.test_read_prefixed_property_list):
515         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
516         (test_convert_for_webkit_harness_only):
517         (test_convert_for_webkit_properties_only):
518         (test_convert_for_webkit_harness_and_properties):
519         (test_convert_test_harness_paths):
520         (test_convert_prefixed_properties):
521         (verify_conversion_happened):
522         (verify_no_conversion_happened):
523         (verify_test_harness_paths):
524         (verify_prefixed_properties):
525         (generate_test_content):
526         * Scripts/webkitpy/w3c/test_importer.py: Added.
527         (main):
528         (parse_args):
529         (validate_import_directory):
530         (TestImporter):
531         (TestImporter.__init__):
532         (TestImporter.path_from_webkit_root):
533         (TestImporter.do_import):
534         (TestImporter.load_changeset):
535         (TestImporter.find_importable_tests):
536         (TestImporter.import_tests):
537         (TestImporter.setup_destination_directory):
538         (TestImporter.update_test_status):
539         (TestImporter.remove_deleted_files):
540         (TestImporter.write_import_log):
541         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
542         (TestImporterTest):
543         (TestImporterTest.test_import_dir_with_no_tests):
544         * Scripts/webkitpy/w3c/test_parser.py: Added.
545         (TestParser):
546         (TestParser.__init__):
547         (TestParser.load_file):
548         (TestParser.analyze_test):
549         (TestParser.reference_links_of_type):
550         (TestParser.is_jstest):
551         (TestParser.support_files):
552         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
553         (TestParserTest):
554         (TestParserTest.test_analyze_test_reftest_one_match):
555         (test_analyze_test_reftest_multiple_matches):
556         (test_analyze_test_reftest_match_and_mismatch):
557         (test_analyze_test_reftest_with_ref_support_Files):
558         (test_analyze_jstest):
559         (test_analyze_pixel_test_all_true):
560         (test_analyze_pixel_test_all_false):
561         (test_analyze_non_html_file):
562
563 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
564
565         Leaks builders exit early frequently
566         https://bugs.webkit.org/show_bug.cgi?id=116355
567
568         Reviewed by Stephanie Lewis.
569
570         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
571         we tolerate from 20 to 50.
572
573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
574         (RunWebKitTests.start):
575         * Scripts/webkitpy/port/mac.py:
576         (MacPort.default_child_processes):
577
578 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
579
580         Remove chrome-channels command from the webkit-patch
581         https://bugs.webkit.org/show_bug.cgi?id=116303
582
583         Reviewed by Ryosuke Niwa.
584
585         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
586         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
587         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
588         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
589         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
590         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
591
592 2013-05-17  David Kilzer  <ddkilzer@apple.com>
593
594         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
595         Part 3 of 3: <http://webkit.org/b/116247>
596
597         Reviewed by Benjamin Poulain.
598
599         * Scripts/filter-build-webkit: Change while() loop to for() loop
600         to track $previousLine, then pass $previousLine into
601         shouldIgnoreLine().
602         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
603         line that begins with four spaces if the previous line is a
604         linker error message.
605         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
606         - Add "Ignored: " to test descriptions to document expected
607           behavior.
608         - Add comment blocks for various groups of tests.
609         - Expand "Build settings" tests since we're changing the code in
610           shouldIgnoreLine() that ignores those lines.
611         - Add tests for undefined symbols error message.
612         (description): Add.  Extract from global code.
613
614 2013-05-17  David Kilzer  <ddkilzer@apple.com>
615
616         Add tests for shouldIgnoreLine() in filter-build-webkit
617         Part 2 of 3: <http://webkit.org/b/116247>
618
619         Reviewed by Benjamin Poulain.
620
621         * Scripts/filter-build-webkit:
622         (shouldIgnoreLine): Add.  Extract code from global scope into
623         subroutine to make it testable.
624         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
625         Tests shouldIgnoreLine() using output from a real build
626         transcript.
627
628 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
629
630         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
631         https://bugs.webkit.org/show_bug.cgi?id=116341
632
633         Reviewed by Brady Eidson.
634
635         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
636
637 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
638
639         [Windows] Don't use pdevenv when building with VS2010.
640         https://bugs.webkit.org/show_bug.cgi?id=116338.
641
642         Reviewed by Adam Roben.
643
644         * Scripts/webkitdirs.pm:
645         (setupCygwinEnv): Check if we are using VS2005, and only use
646         the 'pdevenv' hack if we are. Otherwise, just build with
647         our standard project since it uses VS2010+'s native
648         parallel building features.
649
650 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
651
652         Unreviewed. Disable accelerated compositing until we figure out why it does not work
653         properly in the 64 bits release bot.
654
655         * DumpRenderTree/gtk/DumpRenderTree.cpp:
656         (resetDefaultsToConsistentValues):
657
658 2013-05-17  David Kilzer  <ddkilzer@apple.com>
659
660         Make filter-build-webkit testable using LoadAsModule
661         Part 1 of 3: <http://webkit.org/b/116247>
662
663         Reviewed by Benjamin Poulain.
664
665         * Scripts/filter-build-webkit: Change global variables that are
666         used in subroutines from 'my' to 'our' to make it possible to
667         evaluate the script in a package context in LoadAsModule.pm.
668
669 2013-05-14  Sam Weinig  <sam@webkit.org>
670
671         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
672         https://bugs.webkit.org/show_bug.cgi?id=116132
673
674         Reviewed by Anders Carlsson.
675
676         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
677         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
678
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
680         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
681         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
682         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
683
684 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
685
686         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
687         https://bugs.webkit.org/show_bug.cgi?id=114781
688
689         Reviewed by Christophe Dumez.
690
691         Add run_before_unload_confirm and
692         Print the log message with "CONFIRM NAVIGATION: " in console.
693
694         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
695         (onBeforeUnloadConfirm):
696         (drtViewAdd):
697
698 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
699
700         Fix Analyze ChangeLog's entry processing
701         https://bugs.webkit.org/show_bug.cgi?id=116219
702
703         Reviewed by Ryosuke Niwa.
704
705         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
706         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
707
708 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
709
710         [Qt] UrlLoader::loadNext is broken in MiniBrowser
711         https://bugs.webkit.org/show_bug.cgi?id=116099
712
713         Reviewed by Jocelyn Turcotte.
714
715         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
716         are not available any more. So, UrlLoader::loadNext was broken
717         because it failed to connect to those signals.
718
719         * MiniBrowser/qt/UrlLoader.cpp:
720         (UrlLoader::UrlLoader):
721         (UrlLoader::loadingChanged):
722         * MiniBrowser/qt/UrlLoader.h:
723         (UrlLoader):
724
725 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
726
727         [WebSocket] Update pywebsocket to r760
728         https://bugs.webkit.org/show_bug.cgi?id=115863
729
730         Reviewed by Alexey Proskuryakov.
731
732         Version r760 supports a newer draft of message compression.
733         We need this update to finish the permessage compression patch in
734         bug 98840. This patch also fixes failing unit tests after the update.
735
736         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
737         (StreamBase._read):
738         (StreamBase._read.of):
739         (StreamBase._write):
740         (StreamBase.receive_bytes):
741         (StreamBase._read_until):
742         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
743         (parse_frame):
744         (StreamOptions.__init__):
745         (Stream.__init__):
746         (Stream._receive_frame_as_frame_object):
747         (Stream._get_message_from_frame):
748         (Stream._process_close_message):
749         (Stream.close_connection):
750         (Stream.get_last_received_opcode):
751         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
752         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
753         (Dispatcher.do_extra_handshake):
754         (Dispatcher.transfer_data):
755         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
756         (ExtensionProcessorInterface.__init__):
757         (ExtensionProcessorInterface.request):
758         (ExtensionProcessorInterface):
759         (ExtensionProcessorInterface.name):
760         (ExtensionProcessorInterface.check_consistency_with_other_processors):
761         (ExtensionProcessorInterface.set_active):
762         (ExtensionProcessorInterface.is_active):
763         (ExtensionProcessorInterface._get_extension_response_internal):
764         (ExtensionProcessorInterface.get_extension_response):
765         (ExtensionProcessorInterface._setup_stream_options_internal):
766         (ExtensionProcessorInterface.setup_stream_options):
767         (_log_outgoing_compression_ratio):
768         (_log_incoming_compression_ratio):
769         (_parse_window_bits):
770         (_AverageRatioCalculator):
771         (_AverageRatioCalculator.__init__):
772         (_AverageRatioCalculator.add_original_bytes):
773         (_AverageRatioCalculator.add_result_bytes):
774         (_AverageRatioCalculator.get_average_ratio):
775         (DeflateFrameExtensionProcessor):
776         (DeflateFrameExtensionProcessor.__init__):
777         (DeflateFrameExtensionProcessor._get_extension_response_internal):
778         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
779         (DeflateFrameExtensionProcessor._outgoing_filter):
780         (DeflateFrameExtensionProcessor._incoming_filter):
781         (CompressionExtensionProcessorBase.for):
782         (CompressionExtensionProcessorBase.__init__):
783         (CompressionExtensionProcessorBase._get_extension_response_internal):
784         (CompressionExtensionProcessorBase._setup_stream_options_internal):
785         (PerFrameCompressExtensionProcessor):
786         (PerMessageDeflateExtensionProcessor):
787         (PerMessageDeflateExtensionProcessor.__init__):
788         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
789         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
790         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
791         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
792         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
793         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
794         (PerMessageDeflateExtensionProcessor.set_bfinal):
795         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
796         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
797         (_PerMessageDeflateFramer):
798         (_PerMessageDeflateFramer.__init__):
799         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
800         (_PerMessageDeflateFramer._process_incoming_message):
801         (_PerMessageDeflateFramer._process_outgoing_message):
802         (_PerMessageDeflateFramer.setup_stream_options):
803         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
804         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
805         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
806         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
807         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
808         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
809         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
810         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
811         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
812         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
813         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
814         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
815         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
816         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
817         (PerMessageCompressExtensionProcessor):
818         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
819         (MuxExtensionProcessor.__init__):
820         (MuxExtensionProcessor.check_consistency_with_other_processors):
821         (MuxExtensionProcessor):
822         (MuxExtensionProcessor._get_extension_response_internal):
823         (MuxExtensionProcessor._setup_stream_options_internal):
824         (MuxExtensionProcessor.set_quota):
825         (MuxExtensionProcessor.quota):
826         (MuxExtensionProcessor.set_extensions):
827         (MuxExtensionProcessor.extensions):
828         (is_compression_extension):
829         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
830         (validate_subprotocol):
831         (parse_host_header):
832         (format_header):
833         (check_request_line):
834         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
835         (Handshaker.do_handshake):
836         (Handshaker._create_handshake_response):
837         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
838         (_validate_subprotocol):
839         (_check_header_lines):
840         (_build_location):
841         (Handshaker.do_handshake):
842         (Handshaker._set_subprotocol):
843         (Handshaker._set_location):
844         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
845         (_create_dispatcher):
846         (headerparserhandler):
847         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
848         (_create_add_channel_response):
849         (_create_drop_channel):
850         (_create_flow_control):
851         (_create_new_channel_slot):
852         (_create_fallback_new_channel_slot):
853         (_MuxFramePayloadParser._read_number):
854         (_MuxFramePayloadParser._read_size_and_contents):
855         (_MuxFramePayloadParser._read_flow_control):
856         (_MuxFramePayloadParser._read_new_channel_slot):
857         (_LogicalConnection.__init__):
858         (_LogicalConnection.write):
859         (_LogicalConnection.on_write_data_done):
860         (_LogicalConnection):
861         (_LogicalConnection.on_writer_done):
862         (_InnerMessage):
863         (_InnerMessage.__init__):
864         (_InnerMessageBuilder):
865         (_InnerMessageBuilder.that):
866         (_InnerMessageBuilder.__init__):
867         (_InnerMessageBuilder._handle_first):
868         (_InnerMessageBuilder._process_first_fragmented_control):
869         (_InnerMessageBuilder._process_first_fragmented_message):
870         (_InnerMessageBuilder._handle_fragmented_control):
871         (_InnerMessageBuilder._reassemble_fragmented_control):
872         (_InnerMessageBuilder._handle_fragmented_message):
873         (_InnerMessageBuilder._reassemble_fragmented_message):
874         (_InnerMessageBuilder.build):
875         (_LogicalStream.__init__):
876         (_LogicalStream._create_inner_frame):
877         (_LogicalStream._write_inner_frame):
878         (_LogicalStream.replenish_send_quota):
879         (_LogicalStream.send_message):
880         (_LogicalStream._receive_frame):
881         (_LogicalStream._get_message_from_frame):
882         (_LogicalStream.stop_sending):
883         (_PhysicalConnectionWriter.__init__):
884         (_PhysicalConnectionWriter._write_data):
885         (_PhysicalConnectionWriter.run):
886         (_PhysicalConnectionWriter.stop):
887         (_Worker.run):
888         (_MuxHandshaker.__init__):
889         (_MuxHandshaker._create_stream):
890         (_MuxHandshaker._create_handshake_response):
891         (_HandshakeDeltaBase.create_headers):
892         (_MuxHandler.start):
893         (_MuxHandler.wait_until_done):
894         (_MuxHandler.notify_write_data_done):
895         (_MuxHandler._process_drop_channel):
896         (_MuxHandler._process_logical_frame):
897         (_MuxHandler.notify_reader_done):
898         (_MuxHandler):
899         (_MuxHandler.notify_writer_done):
900         (_MuxHandler.fail_physical_connection):
901         (_MuxHandler.fail_logical_channel):
902         (use_mux):
903         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
904         (_StandaloneRequest.get_uri):
905         (_StandaloneRequest.get_unparsed_uri):
906         (_StandaloneRequest):
907         (_StandaloneRequest.is_https):
908         (_import_ssl):
909         (_import_pyopenssl):
910         (_StandaloneSSLConnection.for):
911         (_StandaloneSSLConnection):
912         (_StandaloneSSLConnection.__getattribute__):
913         (_StandaloneSSLConnection.__setattr__):
914         (_StandaloneSSLConnection.makefile):
915         (_StandaloneSSLConnection.shutdown):
916         (_StandaloneSSLConnection.recv):
917         (WebSocketServer.__init__):
918         (WebSocketServer._create_sockets):
919         (WebSocketServer.handle_error):
920         (WebSocketServer.get_request):
921         (WebSocketServer.get_request.default_callback):
922         (WebSocketRequestHandler.parse_request):
923         (_build_option_parser):
924         (_main):
925         (_main.if):
926         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
927         (RepeatedXorMasker.__init__):
928         (RepeatedXorMasker._mask_using_swig):
929         (RepeatedXorMasker):
930         (RepeatedXorMasker._mask_using_array):
931         (_Deflater.compress_and_finish):
932         (_RFC1979Deflater.filter):
933         (DeflateSocket.send):
934
935 2013-05-16  Jonathan Liu  <net147@gmail.com>
936
937         Fix testing if program exists in PATH
938         https://bugs.webkit.org/show_bug.cgi?id=116216
939
940         Reviewed by Jocelyn Turcotte.
941
942         functions.prf incorrectly uses win_cmd_shell to test whether to
943         add .exe to the executable name when checking if it exists in
944         the PATH environment variable. This works correctly when
945         building using Windows Command Prompt but not under MSYS shell.
946
947         To resolve this, check the win32 platform scope instead of
948         win_cmd_shell so that it correctly adds .exe to the executable
949         name on Windows regardless of the shell used when testing if
950         it exists in PATH.
951
952         * qmake/mkspecs/features/functions.prf:
953
954 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
955
956         Fix the hard-coded names of EWS bots that run tests.
957
958         * Scripts/webkitpy/tool/commands/queues.py:
959         (CommitQueue.did_pass_testing_ews):
960
961 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
962
963         [GTK] Build Xvfb with jhbuild
964         https://bugs.webkit.org/show_bug.cgi?id=115907
965
966         Reviewed by Martin Robinson.
967
968         Build our own Xvfb so that we can avoid problems with the system Xvfb
969         relying on symbols not present in our jhbuilt libraries such as pixman,
970         and also to ensure we have the fix for a GLX module crasher.
971
972         * DumpRenderTree/gtk/DumpRenderTree.cpp:
973         (resetDefaultsToConsistentValues): enable accelerated compositing.
974         * gtk/install-dependencies: list packages required for building Xvfb.
975         * gtk/jhbuild.modules: add xserver as a jhbuild module.
976         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
977         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
978         initializing the GLX module for Xvfb.
979
980 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
981
982         [jhbuild] Should remove the sources directory as well when cleaning
983         https://bugs.webkit.org/show_bug.cgi?id=116229
984
985         Reviewed by Martin Robinson.
986
987         * Scripts/update-webkit-libs-jhbuild:
988         (cleanJhbuild): remove the Source directory as well when cleaning.
989
990 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
991
992         [EFL] Remove Intel Wk2 Buildbots from Master
993         https://bugs.webkit.org/show_bug.cgi?id=116149
994
995         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
996         since Gyuyoung Kim from Samsung plans to take over and maintain it.
997
998         Reviewed by Benjamin Poulain.
999
1000         * BuildSlaveSupport/build.webkit.org-config/config.json:
1001
1002 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
1003
1004         [Windows] Update various build tools to understand VS2010 environment.
1005         https://bugs.webkit.org/show_bug.cgi?id=116169.
1006
1007         Reviewed by Anders Carlsson.
1008
1009         * Scripts/build-api-tests: Identify VS2010 environment.
1010         * Scripts/build-dumprendertree: Ditto.
1011         * Scripts/build-webkit: Ditto.
1012         * Scripts/webkitdirs.pm:
1013         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1014         range of acceptable SDK's.
1015
1016 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1017
1018         Allow http tests on Arch Linux
1019         https://bugs.webkit.org/show_bug.cgi?id=116155
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         * Scripts/webkitpy/port/base.py:
1024         (Port._is_arch_based): Added check for /etc/arch-release file.
1025         (Port._apache_config_file_name_for_platform): Call the check.
1026         * Scripts/webkitpy/port/port_testcase.py:
1027         (test_linux_distro_detection): Testcase added.
1028
1029 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1030
1031         Remove a leftover v8 file from the watchlist
1032         https://bugs.webkit.org/show_bug.cgi?id=116158
1033
1034         Reviewed by Csaba Osztrogonác.
1035
1036         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1037
1038 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1039
1040         [GTK] Fails to build while generating gtkdoc
1041         https://bugs.webkit.org/show_bug.cgi?id=115612
1042
1043         Reviewed by Philippe Normand.
1044
1045         Fix typo in the prerequisites of docs-build.stamp.
1046
1047         * GNUmakefile.am:
1048
1049 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1050
1051         Unreviewed, fixing the current test-webkitpy failure.
1052
1053         * Scripts/webkitpy/port/mac_unittest.py:
1054         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1055         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1056
1057 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1058
1059         Fix build after r150090.
1060         https://bugs.webkit.org/show_bug.cgi?id=116129
1061
1062         Unreviewed build fix after r150090.
1063
1064         * WebKitTestRunner/TestInvocation.cpp:
1065         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1066
1067 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1068
1069         [Windows, others] Unreviewed build fix after r150090.
1070
1071         * DumpRenderTree/TestRunner.cpp:
1072         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1073         doesn't exist on other platforms.
1074
1075 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1076
1077         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1078         https://bugs.webkit.org/show_bug.cgi?id=115889
1079
1080         Reviewed by Benjamin Poulain.
1081
1082         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1083         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1084
1085 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1086
1087         [Windows] Identify proper run environment for scripts.
1088         https://bugs.webkit.org/show_bug.cgi?id=116114
1089
1090         Reviewed by David Kilzer.
1091
1092         Determine (based on Visual Studio version) which path to use for
1093         executables (bin versus bin32).
1094
1095         * Scripts/webkitdirs.pm:
1096         (determineVisualStudioInstallDir): Added.
1097         (determineVisualStudioVersion): Added.
1098         (determineConfigurationProductDir): Modified to choose proper bin
1099         or bin32 directory.
1100         (visualStudioVersion): Added
1101         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1102
1103 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1104
1105         [Mac] Add tests for secure event input
1106         https://bugs.webkit.org/show_bug.cgi?id=116121
1107
1108         Reviewed by Mark Rowe.
1109
1110         * DumpRenderTree/TestRunner.cpp:
1111         (getSecureEventInputIsEnabledCallback):
1112         (TestRunner::staticValues):
1113         Expose an accessor for current secure event input state.
1114
1115         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1117         (WTR::TestRunner::secureEventInputIsEnabled):
1118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1119         * WebKitTestRunner/TestInvocation.cpp:
1120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1121         Expose an accessor for current secure event input state. This has to be done in
1122         UI process, as this is where it's changed by WebKit.
1123
1124 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1125
1126         [Mac] Add a testing shim for secure event input functions
1127         https://bugs.webkit.org/show_bug.cgi?id=116122
1128
1129         Reviewed by Mark Rowe.
1130
1131         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1132         Inject WebCore testing shim library to override system framework functions.
1133
1134 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1135
1136         [Windows] Switch to embedded manifest commands for launcher executables.
1137         https://bugs.webkit.org/show_bug.cgi?id=116109
1138
1139         Reviewed by Darin Adler.
1140
1141         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1142         now-unused WinLauncher.exe.manifest file.
1143         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1144         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1145         when building with VS2010 or newer.
1146
1147 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1148
1149         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1150         https://bugs.webkit.org/show_bug.cgi?id=116079
1151
1152         Reviewed by David Kilzer.
1153
1154         * Scripts/old-run-webkit-tests:
1155         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1156
1157 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1158
1159         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1160         https://bugs.webkit.org/show_bug.cgi?id=115921
1161
1162         Reviewed by Gustavo Noronha Silva.
1163
1164         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1165         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1166
1167 2013-05-13  Alex Christensen  <achristensen@apple.com>
1168
1169         Added testRunner.setPrinting.
1170         https://bugs.webkit.org/show_bug.cgi?id=42693
1171         rdar://problem/8213845
1172
1173         Reviewed by Darin Adler.
1174
1175         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1176         Added setPrinting JavaScript function.
1177         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1178         (WTR::InjectedBundlePage::dump):
1179         Dump the external representation for printing if setPrinting has been called.
1180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1181         (WTR::TestRunner::isPrinting): Added.
1182         (WTR::TestRunner::setPrinting): Added.
1183         Added and initialized m_isPrinting member boolean.
1184
1185 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1186
1187         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1188         https://bugs.webkit.org/show_bug.cgi?id=116016
1189
1190         Reviewed by Dirk Pranke.
1191
1192         Same fix as in the upstream style checker, but without hg support.
1193         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1194
1195         * Scripts/webkitpy/style/checkers/cpp.py:
1196         (FileInfo.repository_name):
1197
1198 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1199
1200         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1201         https://bugs.webkit.org/show_bug.cgi?id=115918
1202
1203         Reviewed by Gustavo Noronha Silva.
1204
1205         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1206         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1207         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1208         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1209         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1210         problems.
1211
1212         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1213         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1214         file paths are constructed and then used to dump the member files from these archives. The member files are
1215         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1216         successfully link.
1217
1218         * TestWebKitAPI/GNUmakefile.am:
1219
1220 2013-05-13  Anders Carlsson  <andersca@apple.com>
1221
1222         Remove UnusedParam.h
1223         https://bugs.webkit.org/show_bug.cgi?id=116029
1224
1225         Reviewed by Andreas Kling.
1226
1227         Stop including UnusedParam.h.
1228
1229         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1230         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1231
1232 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1233
1234         Unreviewed, rolling out r149955.
1235         http://trac.webkit.org/changeset/149955
1236         https://bugs.webkit.org/show_bug.cgi?id=115990
1237
1238         Broke lots of tests (Requested by smfr on #webkit).
1239
1240         * Scripts/webkitpy/port/mac.py:
1241
1242 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1243
1244         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1245         https://bugs.webkit.org/show_bug.cgi?id=115914
1246
1247         Reviewed by Martin Robinson.
1248
1249         * GtkLauncher/main.c:
1250         (createToolbar):
1251         * MiniBrowser/gtk/BrowserWindow.c:
1252         (_BrowserWindow):
1253         (browserWindowSetStatusText):
1254         (fullScreenMessageTimeoutCallback):
1255         (webViewEnterFullScreen):
1256         (webViewLeaveFullScreen):
1257         (browserWindowFinalize):
1258         (browserWindowConstructed):
1259         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1260         (WTR::EventSenderProxy::mouseScrollBy):
1261         (WTR::EventSenderProxy::continuousMouseScrollBy):
1262
1263 2013-05-11  Anders Carlsson  <andersca@apple.com>
1264
1265         Crash when terminating a process that has not been fully launched
1266         https://bugs.webkit.org/show_bug.cgi?id=115962
1267         <rdar://problem/13660916>
1268
1269         Reviewed by Andreas Kling.
1270
1271         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1272         before the process has had a chance to be fully launched.
1273
1274         * TestWebKitAPI/GNUmakefile.am:
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1276         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1277         (TestWebKitAPI):
1278         (TestWebKitAPI::didFinishLoadForFrame):
1279         (TestWebKitAPI::TEST):
1280         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1281
1282 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1283
1284         Remove Mac OS X Leopard (10.5) support
1285         https://bugs.webkit.org/show_bug.cgi?id=107964
1286
1287         Reviewed by Ryosuke Niwa.
1288
1289         Removed the code for 10.5 and removed if-def for 10.6.
1290
1291         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1292         (convertMIMEType):
1293         (createXMLStringFromWebArchiveData):
1294         * DumpRenderTree/mac/TestRunnerMac.mm:
1295         (TestRunner::authenticateSession):
1296         (TestRunner::setTextDirection):
1297         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1298         (convertMIMEType):
1299         (createXMLStringFromWebArchiveData):
1300
1301 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1302
1303         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1304         https://bugs.webkit.org/show_bug.cgi?id=115935
1305
1306         Reviewed by Jer Noble.
1307
1308         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1309         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1310         to the new manifest file.
1311         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1312
1313 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1314
1315         Fix some compiler warnings (miscellaneous)
1316         https://bugs.webkit.org/show_bug.cgi?id=80790
1317
1318         Reviewed by Rob Buis.
1319
1320         Fix the following warnings for BlackBerry:
1321         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1322         used as truth value [-Wparentheses].
1323
1324         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1325         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1326
1327 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1328
1329         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1330         https://bugs.webkit.org/show_bug.cgi?id=115928
1331
1332         Reviewed by Kenneth Rohde Christiansen.
1333
1334         WKViewSetThemePath was moved to WKViewEfl.h.
1335
1336         * TestWebKitAPI/efl/PlatformWebView.cpp:
1337
1338 2013-05-10  Andreas Kling  <akling@apple.com>
1339
1340         I accidentally the Java testing.
1341
1342         * Scripts/webkitpy/port/mac.py:
1343
1344 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1345
1346         [GTK] Module Cairo fails to build under jhbuild
1347         https://bugs.webkit.org/show_bug.cgi?id=115854
1348
1349         Reviewed by Martin Robinson.
1350
1351         Make cairo depend on glib in jhbuild.modules.
1352
1353         * gtk/jhbuild.modules:
1354
1355 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1356
1357         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1358         https://bugs.webkit.org/show_bug.cgi?id=115904
1359
1360         Reviewed by Martin Robinson.
1361
1362         * ImageDiff/gtk/ImageDiff.cpp:
1363         (main):
1364
1365 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1366
1367         Add my new address to contributors.json. (Unreviewed)
1368
1369         * Scripts/webkitpy/common/config/contributors.json:
1370
1371 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1372
1373         Unreviewed. Move myself to the reviewers list.
1374
1375         * Scripts/webkitpy/common/config/contributors.json:
1376
1377 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1378
1379         Unreviewed. Add my email to a few watchlists.
1380
1381         * Scripts/webkitpy/common/config/watchlist:
1382
1383 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1384
1385         Unicode support missing from string representation of Contributors in committers.py
1386         https://bugs.webkit.org/show_bug.cgi?id=115859
1387
1388         Reviewed by Darin Adler.
1389
1390         Contributors, in committers.py, provided a string representation in __str__ which
1391         didn't support unicode characters, so printing a contributor would fail in that case.
1392         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1393         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1394
1395         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1396         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1397         representation.
1398         (Contributor.__str__):
1399         (Contributor):
1400         (Contributor.__unicode__):
1401         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1402         a contributor with unicode characters can be represented as a string.
1403         (CommittersTest):
1404         (CommittersTest.test_contributor_encoding):
1405
1406 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1407
1408         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1409         https://bugs.webkit.org/show_bug.cgi?id=92371
1410
1411         Reviewed by Brent Fulgham.
1412
1413         Use JavaScriptThreading.cpp where the same functionality is
1414         implemented too. This reduces the dependency on the pthread
1415         library. Also replace assert() with WebKit ASSERT().
1416
1417         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1418         * DumpRenderTree/win/DumpRenderTree.cpp:
1419         (dumpHistoryItem):
1420         (dumpBackForwardList):
1421         * DumpRenderTree/win/DumpRenderTree.vcproj:
1422
1423 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1424
1425         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1426         https://bugs.webkit.org/show_bug.cgi?id=92505
1427
1428         Reviewed by Brent Fulgham.
1429
1430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1431         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1432         (javaScriptThreadsMutex):
1433         (javaScriptThreads):
1434         (runJavaScriptThread):
1435         (startJavaScriptThreads):
1436         (stopJavaScriptThreads):
1437         * DumpRenderTree/pthreads: Removed.
1438         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1439
1440 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1441
1442         Unreviewed. Update Simon Pena email on his behalf.
1443
1444         * Scripts/webkitpy/common/config/contributors.json:
1445
1446 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1447
1448         Add support for [NoInterfaceObject] Web IDL extended attribute
1449         https://bugs.webkit.org/show_bug.cgi?id=115714
1450
1451         Reviewed by Kentaro Hara.
1452
1453         Update BindingsTests.generate_supplemental_dependency() to pass an
1454         additional windowConstructorsFile argument to preprocess-idls.pl.
1455
1456         * Scripts/webkitpy/bindings/main.py:
1457         (BindingsTests.generate_supplemental_dependency):
1458         (BindingsTests.main):
1459
1460 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1461
1462         [GTK][AC] Buildfix after r149694
1463         https://bugs.webkit.org/show_bug.cgi?id=115797
1464
1465         Reviewed by Gustavo Noronha Silva.
1466
1467         Add CLUTTER_LIBS for linking TestWebCore.
1468
1469         * TestWebKitAPI/GNUmakefile.am:
1470
1471 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1472
1473         [EFL] Remove unnecessary pkgs in EFL jhbuild
1474         https://bugs.webkit.org/show_bug.cgi?id=114908
1475
1476         Reviewed by Laszlo Gombos.
1477
1478         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1479         handle them using jhbuild. We can reduce build time when using --update-efl.
1480
1481         * efl/jhbuild.modules:
1482
1483 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1484
1485         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1486         https://bugs.webkit.org/show_bug.cgi?id=115834
1487
1488         Reviewed by Gyuyoung Kim.
1489
1490         * Scripts/webkitperl/FeatureList.pm:
1491
1492 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1493
1494         Add Scheduler for Mac MtnLion 32bit Release builder.
1495         
1496         Unreviewed.
1497         
1498         * BuildSlaveSupport/build.webkit.org-config/config.json:
1499
1500 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1501
1502         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1503         https://bugs.webkit.org/show_bug.cgi?id=115808
1504
1505         Reviewed by Darin Adler.
1506
1507         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1508         was left outdated after r127191, when the m_string member was changed
1509         from UString to String. This patch calls the right pretty printer for it.
1510
1511         * gdb/webkit.py:
1512         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1513         WTFImplPrettyPrinter.
1514
1515 2013-05-08  Andy Estes  <aestes@apple.com>
1516
1517         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1518         https://bugs.webkit.org/show_bug.cgi?id=115790
1519
1520         Reviewed by Alexey Proskuryakov.
1521
1522         Added two API tests:
1523
1524         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1525         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1526
1527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1528         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1529         (TestWebKitAPI):
1530         (TestWebKitAPI::TEST):
1531         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1532         (TestWebKitAPI):
1533         (TestWebKitAPI::decidePolicyForNavigationAction):
1534         (CustomProtocolInvalidSchemeTest):
1535         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1536
1537 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1538
1539         Teach buildbot how to compile 32-bit on Mac.
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1544         (CompileWebKit.start):
1545         (ExtractTestResultsAndLeaks):
1546
1547 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1548
1549         [BlackBerry] Fix usage of BlackBerry::Platform::String
1550         https://bugs.webkit.org/show_bug.cgi?id=115781
1551
1552         Reviewed by Rob Buis.
1553
1554         BlackBerry PRs 304193 and 327181
1555         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1556
1557         We currently have a problem where we're passing UTF-8 encoded data into
1558         the char* constructors of BlackBerry::Platform::String. This means the string
1559         thinks its data is not UTF-8.
1560
1561         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1562         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1563         (BlackBerry::WebKit::dumpHistoryItem):
1564         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1565         (TestRunner::setUserStyleSheetLocation):
1566         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1567         (LoadHTMLStringItem::invoke):
1568
1569 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1570
1571         Tools: add new BlackBerry include dirs.
1572         https://bugs.webkit.org/show_bug.cgi?id=115514
1573
1574         Reviewed by Rob Buis.
1575
1576         iType include dirs are missing, and HarfBuzz needs to be fixed.
1577
1578         * Scripts/webkitdirs.pm:
1579         (blackberryCMakeArguments):
1580
1581 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1582
1583         [GTK] Plumb the Automake build system for the Battery Status API feature
1584         https://bugs.webkit.org/show_bug.cgi?id=115718
1585
1586         Reviewed by Martin Robinson.
1587
1588         * Scripts/webkitdirs.pm:
1589         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1590         through the --(enable|disable)-battery-status flag passed to configure.
1591
1592 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1593
1594         new-run-webkit-websocketserver doesn't work after Chromium removal
1595         https://bugs.webkit.org/show_bug.cgi?id=115816
1596
1597         Reviewed by Joseph Pecoraro.
1598
1599         Fix the bug by instantiating the correct port object.
1600
1601         * Scripts/new-run-webkit-websocketserver:
1602         (main):
1603
1604 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1605
1606         Configure buildbot for 32bit builder.
1607         https://bugs.webkit.org/show_bug.cgi?id=115769
1608         
1609         Reviewed by Ryosuke Niwa.
1610
1611         * BuildSlaveSupport/build.webkit.org-config/config.json:
1612
1613 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1614
1615         Unreviewed. Update to show my apple.com address.
1616
1617         * Scripts/webkitpy/common/config/contributors.json: Added
1618         my apple.com e-mail address.
1619
1620 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1621
1622         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1623
1624         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1625         (concatenateAttributeAndValue): Switch to appendVector().
1626
1627 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1628
1629         [Qt][WTR] Fix the build on Mac after r149692
1630
1631         Unreviewed build fix.
1632
1633         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1634         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1635
1636 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1637
1638         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1639         to the watchlist for Accessibility.
1640
1641         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1642         * Scripts/webkitpy/common/config/watchlist: Added myself.
1643
1644 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1645
1646         [Qt] Build fails with clang
1647         https://bugs.webkit.org/show_bug.cgi?id=115741
1648
1649         Reviewed by Benjamin Poulain.
1650
1651         Since r149112 std::move is used in AtomicString for compilers that
1652         support rvalue references and this requires a standard library
1653         implementing c++11 move semantics.
1654         We only explicitely require c++11 for WebKit2, but since clang supports
1655         rvalue references the build of subtargets using AtomicString fails because
1656         of missing std::move.
1657         It is safe to add CONFIG += c++11 for the whole project when using clang
1658         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1659
1660         * qmake/mkspecs/features/unix/default_pre.prf:
1661
1662 2013-05-08  Darin Adler  <darin@apple.com>
1663
1664         Fix one more place that needed to use adoptCF/NS
1665         https://bugs.webkit.org/show_bug.cgi?id=115778
1666
1667         Reviewed by Benjamin Poulain.
1668
1669         Not sure why I missed this code last time, but found a bit more code that needs
1670         to switch to the newer style adoptCF/NS.
1671
1672         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1673         (convertWebResourceDataToString): Use adoptCF.
1674         (convertWebResourceResponseToDictionary): Ditto.
1675         (createXMLStringFromWebArchiveData): Ditto.
1676         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1677         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1678
1679 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1680
1681         Unreviewed, rolling out r149271.
1682         http://trac.webkit.org/changeset/149271
1683         https://bugs.webkit.org/show_bug.cgi?id=115780
1684
1685         The mangled symbols are now enforced through LDFLAGS
1686         (Requested by zdobersek on #webkit).
1687
1688         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1689
1690 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1691
1692         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1693         https://bugs.webkit.org/show_bug.cgi?id=115636
1694
1695         Reviewed by Ryosuke Niwa.
1696
1697         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1698         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1699         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1700         while Chromium-specific, can't be removed just yet as there's more code that uses it.
1701
1702 2013-05-06  Darin Adler  <darin@apple.com>
1703
1704         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1705         https://bugs.webkit.org/show_bug.cgi?id=115657
1706
1707         Reviewed by Sam Weinig.
1708
1709         This is similar to my last set of changes, but covers code that I missed with
1710         global replace using the Safari Xcode workspace.
1711
1712         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1713         (convertWebResourceDataToString):
1714         (convertWebResourceResponseToDictionary):
1715         (createXMLStringFromWebArchiveData):
1716         * DumpRenderTree/cg/ImageDiffCG.cpp:
1717         (createImageFromStdin):
1718         (createDifferenceImage):
1719         (main):
1720         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1721         (printPNG):
1722         (dumpBitmap):
1723         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1724         (BitmapContext::BitmapContext):
1725         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1726         (-[MockWebNotificationProvider init]):
1727         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1728         (createBitmapContext):
1729         * DumpRenderTree/mac/TestRunnerMac.mm:
1730         (TestRunner::addDisallowedURL):
1731         (TestRunner::applicationCacheDiskUsageForOrigin):
1732         (TestRunner::localStorageDiskUsageForOrigin):
1733         (TestRunner::clearApplicationCacheForOrigin):
1734         (TestRunner::deleteLocalStorageForOrigin):
1735         (TestRunner::copyDecodedHostName):
1736         (TestRunner::copyEncodedHostName):
1737         (TestRunner::queueLoad):
1738         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1739         (TestRunner::setMockGeolocationPositionUnavailableError):
1740         (TestRunner::setUserStyleSheetLocation):
1741         (TestRunner::setValueForUser):
1742         (TestRunner::overridePreference):
1743         (TestRunner::setPersistentUserStyleSheetLocation):
1744         (TestRunner::execCommand):
1745         (TestRunner::findString):
1746         (TestRunner::isCommandEnabled):
1747         (TestRunner::addOriginAccessWhitelistEntry):
1748         (TestRunner::removeOriginAccessWhitelistEntry):
1749         (TestRunner::addUserScript):
1750         (TestRunner::addUserStyleSheet):
1751         (TestRunner::evaluateInWebInspector):
1752         (TestRunner::evaluateScriptInIsolatedWorld):
1753         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1754         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1755         (TestRunner::authenticateSession):
1756         (TestRunner::grantWebNotificationPermission):
1757         (TestRunner::denyWebNotificationPermission):
1758         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1759         (createCFURLResponseFromResponseData):
1760         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1761         (LoadItem::invoke):
1762         (LoadHTMLStringItem::invoke):
1763         (ScriptItem::invoke):
1764         * DumpRenderTree/win/DumpRenderTree.cpp:
1765         (substringFromIndex):
1766         (urlSuitableForTestResult):
1767         (lastPathComponent):
1768         (sharedCFURLCache):
1769         * DumpRenderTree/win/ImageDiffCairo.cpp:
1770         (createImageFromStdin):
1771         (main):
1772         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1773         (createBitmapContextFromWebView):
1774         * DumpRenderTree/win/TestRunnerWin.cpp:
1775         (TestRunner::setUserStyleSheetLocation):
1776         (TestRunner::setPersistentUserStyleSheetLocation):
1777         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1780         (TestWebKitAPI::TEST):
1781         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1782         (TestWebKitAPI::TEST):
1783         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1786         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1787         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1788         (TestWebKitAPI::createWindow):
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1793         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1794         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1801         (TestWebKitAPI::TEST):
1802         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1805         (TestWebKitAPI::TEST):
1806         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1809         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1810         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1811         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
1812         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1813         (TestWebKitAPI::TEST):
1814         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1817         (TestWebKitAPI::TEST):
1818         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
1819         (TestWebKitAPI::TEST):
1820         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1821         (TestWebKitAPI::TEST):
1822         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1823         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1824         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1825         (TestWebKitAPI::TEST):
1826         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1827         (TestWebKitAPI::TEST):
1828         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1829         (TestWebKitAPI::TEST):
1830         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1831         (TestWebKitAPI::TEST):
1832         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1833         (TestWebKitAPI::TEST):
1834         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
1837         (TestWebKitAPI::TEST):
1838         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1839         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1840         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1841         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1842         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1843         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1844         (WTR::testPathFromURL):
1845         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1846         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1847         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1848         (WTR::createCGContextFromImage):
1849         (WTR::dumpBitmap):
1850         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1851         * WebKitTestRunner/mac/EventSenderProxy.mm:
1852         (WTR::EventSenderProxy::mouseScrollBy):
1853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1854         (WTR::PlatformWebView::windowSnapshotImage):
1855         * WebKitTestRunner/win/TestControllerWin.cpp:
1856         (WTR::TestController::initializeTestPluginDirectory):
1857         Use adoptCF and adoptNS.
1858
1859 2013-05-07  Alex Christensen  <achristensen@apple.com>
1860
1861         Fix a memory leak introduced in r149692
1862         https://bugs.webkit.org/show_bug.cgi?id=115766
1863
1864         Reviewed by Mark Rowe.
1865
1866         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
1867         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
1868
1869         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1870         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1871         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
1872
1873 2013-05-07  Darin Adler  <darin@apple.com>
1874
1875         [Win] Fix storage leak in Windows DumpRenderTree
1876         https://bugs.webkit.org/show_bug.cgi?id=115651
1877
1878         Reviewed by Sam Weinig.
1879
1880         * DumpRenderTree/win/DumpRenderTree.cpp:
1881         (lastPathComponent): Added a missing call to adoptCF.
1882
1883 2013-05-07  Alex Christensen  <achristensen@apple.com>
1884
1885         fixed a memory leak introduced by bug 42324 by using a RetainPtr
1886         https://bugs.webkit.org/show_bug.cgi?id=115760
1887
1888         Reviewed by Tim Horton.
1889
1890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1891         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1892         fixed memory leak, added UNUSED_PARAM macros
1893
1894 2013-05-07  Alex Christensen  <achristensen@apple.com>
1895
1896         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
1897         https://bugs.webkit.org/show_bug.cgi?id=42324
1898         <rdar://problem/8193633>
1899
1900         Reviewed by Tim Horton.
1901
1902         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1903         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
1904         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1905         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1906         Added dumpDOMAsWebArchive code that is called when dumping.        
1907         (WTR::InjectedBundlePage::dump):
1908         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
1909         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1910         (InjectedBundlePage):
1911         Added dumpDOMAsWebArchive declaration.
1912         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
1913         (WTR::TestRunner::dumpDOMAsWebArchive):
1914         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
1915         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1916         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
1917         * Tools/WebKitTestRunner/cf: Added.
1918         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
1919         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
1920         (convertMIMEType):
1921         (convertWebResourceDataToString):
1922         (normalizeHTTPResponseHeaderFields):
1923         (normalizeWebResourceURL):
1924         (convertWebResourceResponseToDictionary):
1925         (compareResourceURLs):
1926         (createXMLStringFromWebArchiveData):
1927         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
1928         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
1929         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
1930         Copied from Tools/DumpRenderTree/mac for used functions.
1931         (createCFURLResponseFromResponseData):
1932         (supportedNonImageMIMETypes):
1933
1934 2013-05-07  Alex Christensen  <achristensen@apple.com>
1935
1936         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
1937         https://bugs.webkit.org/show_bug.cgi?id=115745
1938
1939         Reviewed by Tim Horton.
1940
1941         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1942         (compareResourceURLs):
1943         Updated style.
1944
1945 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
1946
1947         Add an 'isReadOnly' member to IDL parse tree structure
1948         https://bugs.webkit.org/show_bug.cgi?id=115704
1949
1950         Reviewed by Kentaro Hara.
1951
1952         Use newly added isReadOnly attribute.
1953
1954         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1955         (_generateHeaderFile):
1956         (_generateImplementationFile):
1957         (_staticValuesGetterImplementation):
1958
1959 2013-05-07  Anders Carlsson  <andersca@apple.com>
1960
1961         Remove AlwaysInline.h from WTF
1962         https://bugs.webkit.org/show_bug.cgi?id=115727
1963
1964         Reviewed by Brent Fulgham.
1965
1966         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
1967         to keep AlwaysInline.h around anymore.
1968
1969         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1970         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1971
1972 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
1973
1974         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
1975         https://bugs.webkit.org/show_bug.cgi?id=114808
1976
1977         Reviewed by Jocelyn Turcotte.
1978
1979         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
1980         (https://codereview.qt-project.org/#change,54234)
1981
1982         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1983         (WTR::WrapperWindow::handleStatusChanged):
1984
1985 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1986
1987         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
1988
1989         * Scripts/webkitpy/common/config/watchlist:
1990
1991 2013-05-06  Kangil Han  <kangil.han@samsung.com>
1992
1993         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
1994         https://bugs.webkit.org/show_bug.cgi?id=115645
1995
1996         Reviewed by Gyuyoung Kim.
1997
1998         To run performance tests in wk1, we need --no-timeout option implementation.
1999         So adopt it from gtk+ port.
2000
2001         * DumpRenderTree/efl/DumpRenderTree.cpp:
2002         (shouldSetWaitToDumpWatchdog):
2003         (parseCommandLineOptions):
2004         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2005         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2006         (TestRunner::setWaitToDump):
2007
2008 2013-05-06  Commit Queue  <commit-queue@webkit.org>
2009
2010         Unreviewed, rolling out r149547.
2011         http://trac.webkit.org/changeset/149547
2012         https://bugs.webkit.org/show_bug.cgi?id=115682
2013
2014         Added unittests that fail on bots and spits out text into
2015         stdout (Requested by rniwa on #webkit).
2016
2017         * Scripts/import-w3c-tests: Removed.
2018         * Scripts/webkitpy/w3c/__init__.py: Removed.
2019         * Scripts/webkitpy/w3c/test_converter.py: Removed.
2020         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2021         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2022         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2023         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2024         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2025
2026 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2027
2028         [jhbuild] bump jhbuild version to take advantage of new improvements
2029         https://bugs.webkit.org/show_bug.cgi?id=115558
2030
2031         Reviewed by Martin Robinson.
2032
2033         One of the important improvements is jhbuild no longer fetches git
2034         repositories if they are already at the expected revision, which should
2035         make the EWS bots more robust to git servers unavailability.
2036
2037         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2038
2039 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2040
2041         [GTK] Add webkit_uri_scheme_request_finish_error
2042         https://bugs.webkit.org/show_bug.cgi?id=94316
2043
2044         Reviewed by Anders Carlsson.
2045
2046         * MiniBrowser/gtk/main.c:
2047         (miniBrowserErrorQuark): Add function to create a global quark for
2048         MiniBrowser.
2049         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2050         function webkit_uri_scheme_request_finish_error().
2051
2052 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2053
2054         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2055         https://bugs.webkit.org/show_bug.cgi?id=113808
2056
2057         Reviewed by Rob Buis.
2058
2059         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2060         to true for BlackBerry.
2061
2062         * Scripts/webkitperl/FeatureList.pm:
2063
2064 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2065
2066         check-webkit-style should complain about a layering violation if platform-specific guards are
2067         used in WebCore outside of the platform directory
2068         https://bugs.webkit.org/show_bug.cgi?id=115567
2069
2070         Reviewed by Benjamin Poulain.
2071
2072         * Scripts/webkitpy/style/checkers/cpp.py:
2073         (check_for_webcore_platform_layering_violation):
2074         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2075         (process_line):
2076         Add the check_for_webcore_platform_layering_violation.
2077         (CppChecker):
2078         List the new check.
2079
2080         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2081         (CppStyleTest.test_webcore_platform_layering_violation):
2082         Add tests.
2083
2084 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2085
2086         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2087         <http://webkit.org/b/115667>
2088
2089         Reviewed by Dirk Pranke.
2090
2091         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2092         (Bugzilla._check_create_bug_response): Update regex to work with
2093         Bugzilla 3.2.3 and 4.2.5.
2094         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2095         (test__check_create_bug_response): Add new test that covers both
2096         old and new <title> variations.
2097
2098 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2099
2100         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2101         https://bugs.webkit.org/show_bug.cgi?id=115661
2102
2103         Reviewed by Ryosuke Niwa.
2104
2105         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2106         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2107         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2108
2109         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2110         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2111
2112 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2113
2114         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2115         https://bugs.webkit.org/show_bug.cgi?id=114603
2116
2117         Reviewed by Ryosuke Niwa.
2118
2119         * TestResultServer/generate_builders_json.py:
2120         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2121         to represent these to be 'layout-test', for backwards compatibility.
2122         (main): Remove all the build.chromium.org masters.
2123         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2124         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2125         (GenerateBuildersJsonTest):
2126         (GenerateBuildersJsonTest.test_generate_json_data):
2127         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2128         test-running builders from the webkit.org master.
2129
2130 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2131
2132         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2133         https://bugs.webkit.org/show_bug.cgi?id=114988
2134
2135         Reviewed by Ryosuke Niwa.
2136
2137         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2138         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2139         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2140         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2141         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2142
2143 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2144
2145         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2146         https://bugs.webkit.org/show_bug.cgi?id=114954
2147
2148         Reviewed by Ryosuke Niwa.
2149
2150         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2151         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2152         modifier unions in the list of modifiers.
2153         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2154         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2155
2156 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2157
2158         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2159         https://bugs.webkit.org/show_bug.cgi?id=114957
2160
2161         Reviewed by Ryosuke Niwa.
2162
2163         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2164         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2165         (chromiumPlatform): Removed, unnecessary.
2166         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2167         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2168         the builder operates with debug builds, no webkit.org builders are named this way.
2169         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2170         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2171
2172 2013-05-06  Andy Estes  <aestes@apple.com>
2173
2174         Added two files I neglected to commit in r149589.
2175
2176         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2177         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2178
2179 2013-05-04  Andy Estes  <aestes@apple.com>
2180
2181         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2182         https://bugs.webkit.org/show_bug.cgi?id=115609
2183
2184         Reviewed by Oliver Hunt.
2185
2186         Added an API test.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2190         (+[TestDelegate shared]):
2191         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2192         (-[TestDelegate webView:createWebViewWithRequest:]):
2193         (TestWebKitAPI):
2194         (TestWebKitAPI::TEST):
2195         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2196
2197 2013-05-06  Antoine Quint  <graouts@apple.com>
2198
2199         Manage the presentation of the snapshotted plug-in using JavaScript
2200         https://bugs.webkit.org/show_bug.cgi?id=115548
2201
2202         Reviewed by Dean Jackson.
2203
2204         Take into account the new plugInExtraScript method added to support
2205         the injection of a JS file from the chrome client to customize the
2206         rendering of a snapshotted plug-in's shadow tree.
2207
2208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2209         (WTR::InjectedBundlePage::InjectedBundlePage):
2210
2211 2013-05-05  Anders Carlsson  <andersca@apple.com>
2212
2213         Remove the Vector::append overload that takes a Vector
2214         https://bugs.webkit.org/show_bug.cgi?id=115535
2215
2216         Reviewed by Andreas Kling.
2217
2218         Use Vector::appendVector instead.
2219
2220         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2221         (concatenateAttributeAndValue):
2222         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2223         (WTR::concatenateAttributeAndValue):
2224
2225 2013-05-04  Sam Weinig  <sam@webkit.org>
2226
2227         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2228         <rdar://problem/13702008>
2229         https://bugs.webkit.org/show_bug.cgi?id=115607
2230
2231         Reviewed by Benjamin Poulain.
2232
2233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2234         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2235         (TestWebKitAPI::didFinishLoadForFrame):
2236         (TestWebKitAPI::TEST):
2237         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2238
2239 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2240
2241         Unreviewed.
2242
2243         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2244
2245 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2246
2247         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2248
2249         * Scripts/webkitpy/common/config/contributors.json:
2250
2251 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2252
2253         [GTK] Catch select.error exceptions in parse_output_lines
2254         https://bugs.webkit.org/show_bug.cgi?id=115253
2255
2256         Reviewed by Gustavo Noronha Silva.
2257
2258         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2259         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2260         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2261         error code and the error message) and the loop is re-entered.
2262
2263         * gtk/common.py:
2264         (parse_output_lines):
2265
2266 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2267
2268         [GTK] Set up the TestWebCore in TestWebKitAPI
2269         https://bugs.webkit.org/show_bug.cgi?id=115237
2270
2271         Reviewed by Gustavo Noronha Silva.
2272
2273         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2274         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2275         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2276         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2277         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2278
2279         * TestWebKitAPI/GNUmakefile.am:
2280
2281 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2282
2283         Create a script to import W3C tests
2284         https://bugs.webkit.org/show_bug.cgi?id=111513
2285
2286         Reviewed by Dirk Pranke.
2287
2288         Script to automate the import of W3C tests into WebKit. 
2289         For the full description of how it works, see the comments
2290         at the top of test_importer.py.
2291
2292         * Scripts/import-w3c-tests: Added.
2293         * Scripts/webkitpy/w3c/__init__.py: Added.
2294         * Scripts/webkitpy/w3c/test_converter.py: Added.
2295         (TestConverter):
2296         (TestConverter.__init__):
2297         (TestConverter.load_prefixed_prop_list):
2298         (TestConverter.load_file):
2299         (TestConverter.convert_for_webkit):
2300         (TestConverter.convert_testharness_paths):
2301         (TestConverter.convert_prefixed_properties):
2302         (TestConverter.scrub_unprefixed_props):
2303         (TestConverter.replace_tag):
2304         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2305         (TestConverterTest):
2306         (TestConverterTest.testLoadPrefixedPropList):
2307         (TestConverterTest.test_convertForWebkitNothingToConvert):
2308         (test_convertForWebkitHarnessOnly):
2309         (test_convertForWebkitPropsOnly):
2310         (test_convertForWebkitHarnessAndProps):
2311         (test_convertTestHarnessPaths):
2312         (test_convertPrefixedProperties):
2313         (verifyTestHarnessPaths):
2314         (verifyPrefixedProperties):
2315         (generateTestContent):
2316         * Scripts/webkitpy/w3c/test_importer.py: Added.
2317         (main):
2318         (parse_args):
2319         (validate_import_directory):
2320         (TestImporter):
2321         (TestImporter.__init__):
2322         (TestImporter.do_import):
2323         (TestImporter.get_changeset):
2324         (TestImporter.scan_source_directory):
2325         (TestImporter.import_tests):
2326         (TestImporter.setup_destination_directory):
2327         (TestImporter.get_test_status):
2328         (TestImporter.remove_deleted_files):
2329         (TestImporter.write_import_log):
2330         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2331         (TestImporterTest):
2332         (TestImporterTest.test_ImportDirWithNoTests):
2333         * Scripts/webkitpy/w3c/test_parser.py: Added.
2334         (TestParser):
2335         (TestParser.__init__):
2336         (TestParser.load_file):
2337         (TestParser.analyze_test):
2338         (TestParser.get_reftests):
2339         (TestParser.is_jstest):
2340         (TestParser.get_support_files):
2341         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2342         (TestParserTest):
2343         (TestParserTest.test_analyzeTestReftestOneMatch):
2344         (test_analyzeTestReftestMultipleMatches):
2345         (test_analyzeTestReftestMatchAndMismatch):
2346         (test_analyzeTestReftestWithRefSupportFiles):
2347         (test_analyzeJSTest):
2348         (test_analyzePixelTestAllTrue):
2349         (test_analyzePixelTestAllFalse):
2350         (test_analyzeNonHTMLFile):
2351
2352 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2353
2354         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2355
2356         * Scripts/webkitpy/common/config/contributors.json:
2357
2358 2013-05-02  Nico Weber  <thakis@chromium.org>
2359
2360         Remove a stale script file.
2361         https://bugs.webkit.org/show_bug.cgi?id=115521
2362
2363         Reviewed by Anders Carlsson.
2364
2365         This script was added in
2366         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2367         Bakefile system that was removed in
2368         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2369         script just asserts when it's run and is useless.
2370
2371         * Scripts/update-sources-list.py: Removed.
2372
2373 2013-05-01  Glenn Adams  <glenn@skynav.com>
2374
2375         [webkitpy] Need abstract base class for commands that analyze commit logs
2376         https://bugs.webkit.org/show_bug.cgi?id=115391
2377
2378         Reviewed by Benjamin Poulain.
2379
2380         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2381         in preparation for adding two new commands that will reuse this functionality along with
2382         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2383         https://bugs.webkit.org/show_bug.cgi?id=115388.
2384
2385         No new tests as this patch does not change existing functionality or behavior.
2386
2387         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2388         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2389         (AbstractCommitLogCommand.__init__):
2390         (AbstractCommitLogCommand._init_options):
2391         (AbstractCommitLogCommand._parse_commit_message):
2392         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2393         (SuggestNominations.__init__): 
2394         (SuggestNominations._init_options):
2395
2396 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2397
2398         Web Inspector: Fix check-inspector-strings script and fix localized strings
2399         https://bugs.webkit.org/show_bug.cgi?id=115495
2400
2401         Reviewed by Joseph Pecoraro.
2402
2403         * Scripts/check-inspector-strings:
2404
2405 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2406
2407         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2408         https://bugs.webkit.org/show_bug.cgi?id=115470
2409
2410         Reviewed by Martin Robinson.
2411
2412         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2413         not building either of the IOS, Windows or GTK-WK1 platforms.
2414
2415         Up until now the header was included for everything but the IOS and Windows platforms due to
2416         an incorrectly stated condition regarding the GTK platform.
2417
2418         * TestWebKitAPI/config.h:
2419
2420 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2421
2422         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2423         https://bugs.webkit.org/show_bug.cgi?id=115469
2424
2425         Reviewed by Martin Robinson.
2426
2427         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2428         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2429         for the WebKit2 tests and the injected bundle required by them.
2430
2431         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2432         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2433         under the WebKit2 code).
2434
2435         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2436         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2437         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2438
2439         * TestWebKitAPI/GNUmakefile.am:
2440
2441 2013-04-30  Glenn Adams  <glenn@skynav.com>
2442
2443         Unreviewed. Add myself to watchlist entries.
2444
2445         * Scripts/webkitpy/common/config/watchlist:
2446
2447 2013-04-30  Glenn Adams  <glenn@skynav.com>
2448
2449         [webkitpy] suggest-nominations doesn't count all qualified patches
2450         https://bugs.webkit.org/show_bug.cgi?id=115285
2451
2452         Reviewed by Benjamin Poulain.
2453
2454         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2455         nomination. Improve commit log parsing.
2456
2457         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2458         (CommitLogError):
2459         (CommitLogError.__init__):
2460         (CommitLogMissingReviewer):
2461         (CommitLogMissingReviewer.__init__):
2462         (SuggestNominations):
2463         (SuggestNominations.__init__):
2464         (SuggestNominations._recent_commit_messages):
2465         (SuggestNominations._author_name_from_email):
2466         (SuggestNominations._contributor_from_email):
2467         (SuggestNominations._parse_commit_message):
2468         (SuggestNominations._count_commit):
2469         (SuggestNominations._count_recent_patches):
2470         (SuggestNominations._collect_nominations):
2471         (SuggestNominations._print_nominations):
2472         (SuggestNominations.execute):
2473         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2474         (_make_options):
2475         (test_recent_commit_messages):
2476         (test_basic):
2477
2478 2013-04-30  Commit Queue  <rniwa@webkit.org>
2479
2480         Unreviewed, rolling out r149309.
2481         http://trac.webkit.org/changeset/149309
2482         https://bugs.webkit.org/show_bug.cgi?id=115430
2483
2484         The patch does not build on WK1-only builds of the GTK port
2485         (Requested by zdobersek on #webkit).
2486
2487         * TestWebKitAPI/GNUmakefile.am:
2488
2489 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2490
2491         Stop using "in" keyword in IDL files
2492         https://bugs.webkit.org/show_bug.cgi?id=115418
2493
2494         Reviewed by Kentaro Hara.
2495
2496         Remove "in" keyword from IDL files as this is no longer part of the Web
2497         IDL specification.
2498
2499         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2500         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2501         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2502         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2503         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2504         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2505         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2506         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2507
2508 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2509
2510         [EFL] Enable scaled cursors
2511         https://bugs.webkit.org/show_bug.cgi?id=106242
2512
2513         Reviewed by Gyuyoung Kim.
2514
2515         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2516
2517         * Scripts/webkitperl/FeatureList.pm:
2518
2519 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2520
2521         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2522         https://bugs.webkit.org/show_bug.cgi?id=115380
2523
2524         Reviewed by Kentaro Hara.
2525
2526         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2527         keyword.
2528
2529         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2530         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2531
2532 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2533
2534         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2535         https://bugs.webkit.org/show_bug.cgi?id=114684
2536
2537         Reviewed by Simon Hausmann.
2538
2539         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2540         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2541
2542         * qmake/mkspecs/features/features.prf:
2543
2544 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2545
2546         [GTK] Disable Shadow DOM feature
2547         https://bugs.webkit.org/show_bug.cgi?id=115374
2548
2549         Reviewed by Martin Robinson.
2550
2551         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2552
2553         * Scripts/webkitperl/FeatureList.pm:
2554
2555 2013-04-29  Glenn Adams  <glenn@skynav.com>
2556
2557         [webkitpy] Add missing contributor email addresses
2558         https://bugs.webkit.org/show_bug.cgi?id=115394
2559
2560         Reviewed by Ryosuke Niwa.
2561
2562         * Scripts/webkitpy/common/config/contributors.json:
2563
2564 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2565
2566         Remove all remaining Skia code
2567         https://bugs.webkit.org/show_bug.cgi?id=115263
2568
2569         Reviewed by Benjamin Poulain.
2570
2571         Remove all remaining references to Skia.
2572
2573         * Scripts/webkitdirs.pm:
2574         (blackberryCMakeArguments):
2575         * Scripts/webkitpy/common/config/contributionareas.py:
2576         * Scripts/webkitpy/common/config/watchlist:
2577
2578 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2579
2580         Get rid of unused options in Tools/Scripts/webkit-build-directory
2581         https://bugs.webkit.org/show_bug.cgi?id=115383
2582
2583         Reviewed by Darin Adler.
2584
2585         * Scripts/webkit-build-directory:
2586
2587 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2588
2589         [WK2][Mac] Test with NetworkProcess enabled.
2590
2591         Fix the build for non-Mac.
2592
2593         * WebKitTestRunner/TestController.cpp:
2594         (WTR::TestController::initialize):
2595
2596 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2597
2598         [WK2][Mac] Test with NetworkProcess enabled.
2599
2600         Reviewed by Sam Weinig.
2601
2602         * WebKitTestRunner/TestController.cpp:
2603         (WTR::TestController::initialize):
2604
2605 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2606
2607         [GTK] Set up the TestWebCore in TestWebKitAPI
2608         https://bugs.webkit.org/show_bug.cgi?id=115237
2609
2610         Reviewed by Gustavo Noronha Silva.
2611
2612         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2613         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2614         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2615         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2616         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2617
2618         * TestWebKitAPI/GNUmakefile.am:
2619
2620 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2621
2622         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2623         https://bugs.webkit.org/show_bug.cgi?id=115236
2624
2625         Reviewed by Gustavo Noronha Silva.
2626
2627         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2628         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2629
2630         * TestWebKitAPI/GNUmakefile.am:
2631
2632 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2633
2634         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2635         https://bugs.webkit.org/show_bug.cgi?id=115323
2636
2637         Reviewed by Philippe Normand.
2638
2639         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2640         Its presence enforces linkers to output mangled symbols when reporting linking failures
2641         due to unresolved references. People trying to fix the build can then simply copy
2642         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2643         or connecting to the builders to discover the mangled version of the missing symbol.
2644
2645         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2646
2647 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2648
2649         Remove Chromium code from Tools/BuildSlaveSupport
2650         https://bugs.webkit.org/show_bug.cgi?id=115325
2651
2652         Reviewed by Benjamin Poulain.
2653
2654         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2655         covering archiving test results and built products.
2656
2657         * BuildSlaveSupport/built-product-archive:
2658         (archiveBuiltProduct):
2659         (extractBuiltProduct):
2660         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2661         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2662         * BuildSlaveSupport/test-result-archive:
2663         (archiveTestResults):
2664
2665 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2666
2667         Remove support for Chromium from webkitdirs.pm
2668         https://bugs.webkit.org/show_bug.cgi?id=115338
2669
2670         Reviewed by Darin Adler.
2671
2672         * Scripts/webkitdirs.pm:
2673         (determineBaseProductDir):
2674         (argumentsForConfiguration):
2675         (builtDylibPathForName):
2676         (determineIsQt):
2677         (isAppleWebKit):
2678
2679 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2680
2681         Rename TestRunner's setAudioData to setAudioResult
2682         https://bugs.webkit.org/show_bug.cgi?id=115326
2683
2684         Reviewed by Darin Adler.
2685
2686         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2687         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2688         affected tests are adjusted accordingly.
2689
2690         * DumpRenderTree/qt/TestRunnerQt.cpp:
2691         (TestRunnerQt::setAudioResult):
2692         * DumpRenderTree/qt/TestRunnerQt.h:
2693         (TestRunnerQt):
2694         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2696         (WTR::TestRunner::setAudioResult):
2697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2698         (TestRunner):
2699
2700 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2701
2702         [WKTR] Tests dumping audio data shouldn't dump pixels
2703         https://bugs.webkit.org/show_bug.cgi?id=115270
2704
2705         Reviewed by Benjamin Poulain.
2706
2707         Prevent dumping the pixel output when Web Audio tests are dumping output data
2708         as the testing output. Pixel output in these tests has no real meaning and is
2709         as such unnecessary.
2710
2711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2712         (WTR::TestRunner::setAudioData):
2713
2714 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2715
2716         [EFL] Unreviewed Intel bots fix after r149231.
2717
2718         * efl/jhbuild.modules: Disable the libxml Python bindings since the
2719         bots don't have Python's development files installed. libxml should
2720         detect this kind of thing better.
2721
2722 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
2723
2724         [EFL] Build break using jhbuild on ubuntu 13.04
2725         https://bugs.webkit.org/show_bug.cgi?id=115225
2726
2727         Reviewed by Gyuyoung Kim.
2728
2729         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
2730         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
2731         So this patch bumped libxml version to 2.9.1.
2732
2733         * efl/jhbuild.modules:
2734
2735 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
2736
2737         delete-stale-build-files does not clear .d files
2738         http://bugs.webkit.org/show_bug.cgi?id=115293
2739
2740         Reviewed by Ryosuke Niwa.
2741
2742         * BuildSlaveSupport/delete-stale-build-files:
2743         (main): Add .d to the file type list
2744
2745 2013-04-26  Roger Fong  <roger_fong@apple.com>
2746
2747         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
2748         Make the DebugSuffix configuration use _debug dependencies.
2749
2750         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2751         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
2752         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2753         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2754         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2755         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2756         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
2757         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2758         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2759         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2760         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2761         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2762         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2763         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2764         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2765         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2766         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2767         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2768         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2769         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
2770         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2771         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2772         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2773         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2774         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2775         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2776         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
2777         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2778         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2779         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2780         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2781         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2782         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2783         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
2784         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2785         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2786         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2788         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2789         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2790         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2791         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2792         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2793         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
2794         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2795         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2796         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2797         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2798         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2799         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2800         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2801         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2802         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2803         * win/AssembleBuildLogs/AssembleLogs.cmd:
2804         * win/record-memory/record-memory.vcxproj:
2805         * win/record-memory/record-memoryDebug.props:
2806         * win/record-memory/record-memoryDebugWinCairo.props:
2807         * win/record-memory/record-memoryProduction.props:
2808         * win/record-memory/record-memoryRelease.props:
2809         * win/record-memory/record-memoryReleaseWinCairo.props:
2810
2811 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2812
2813         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
2814         https://bugs.webkit.org/show_bug.cgi?id=115233
2815
2816         Reviewed by Martin Robinson.
2817
2818         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
2819         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
2820         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
2821         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
2822         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
2823
2824         * TestWebKitAPI/GNUmakefile.am:
2825
2826 2013-04-25  Andy Estes  <aestes@apple.com>
2827
2828         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
2829         https://bugs.webkit.org/show_bug.cgi?id=115223
2830
2831         Reviewed by Darin Adler.
2832
2833         Added an API test.
2834
2835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2836         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
2837         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
2838         when it loads a request with a custom protocol.
2839         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
2840         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
2841         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
2842         miscellaneous cleanup.
2843         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
2844         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
2845         (+[TestProtocol canInitWithRequest:]):
2846         (+[TestProtocol canonicalRequestForRequest:]):
2847         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
2848         (+[TestProtocol scheme]):
2849         (-[TestProtocol startLoading]):
2850         (-[TestProtocol stopLoading]):
2851
2852 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2853
2854         Remove the remaining Skia #ifdefs
2855         https://bugs.webkit.org/show_bug.cgi?id=114886
2856
2857         Reviewed by Benjamin Poulain.
2858
2859         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2860         (createBitmapContextFromWebView): Remove Skia #ifdef references.
2861
2862 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2863
2864         [BlackBerry] Clean up load interface in WebPage
2865         https://bugs.webkit.org/show_bug.cgi?id=113267
2866
2867         Reviewed by Rob Buis.
2868
2869         Update DumpRenderTree with change of load() interface in WebPage.
2870         RIM Bug# 315535, internally reviewed by Joe Mason.
2871
2872         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2873         (BlackBerry::WebKit::DumpRenderTree::runTest):
2874
2875 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2876
2877         Remove the HeapGraphSerializer unit test
2878         https://bugs.webkit.org/show_bug.cgi?id=115231
2879
2880         Reviewed by Andreas Kling.
2881
2882         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
2883         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
2884
2885         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2886
2887 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2888
2889         Remove support for Chromium from build/update scripts
2890         https://bugs.webkit.org/show_bug.cgi?id=115218
2891
2892         Reviewed by Darin Adler.
2893
2894         * Scripts/build-webkit:
2895         (writeCongrats):
2896         * Scripts/update-webkit:
2897
2898 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2899
2900         Remove support for Chromium from api-test
2901         https://bugs.webkit.org/show_bug.cgi?id=115211
2902
2903         Reviewed by Dirk Pranke.
2904
2905         * Scripts/build-api-tests:
2906         * Scripts/run-api-tests:
2907         (isSupportedPlatform):
2908
2909 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2910
2911         Get rid of Chromium in build-dumprendertree
2912         https://bugs.webkit.org/show_bug.cgi?id=115212
2913
2914         Reviewed by Dirk Pranke.
2915
2916         * Scripts/build-dumprendertree:
2917
2918 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
2919
2920         Pass relatedPage when creating a page in WebKitTestRunner
2921         https://bugs.webkit.org/show_bug.cgi?id=115206
2922
2923         Reviewed by Geoffrey Garen.
2924
2925         To make sure that window.open() opens in the same process even when using multiple processes.
2926
2927         * WebKitTestRunner/PlatformWebView.h:
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::TestController::createOtherPage):
2930         (WTR::TestController::createWebViewWithOptions):
2931         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2932         (WTR::PlatformWebView::PlatformWebView):
2933         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2934         (WTR::PlatformWebView::PlatformWebView):
2935         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2936         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2937         (WTR::PlatformWebView::PlatformWebView):
2938         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2939         (WTR::PlatformWebView::PlatformWebView):
2940         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2941         (WTR::PlatformWebView::PlatformWebView):
2942
2943 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2944
2945         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
2946
2947         * Scripts/webkitpy/common/config/contributors.json:
2948
2949 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2950
2951         Build fix. Forgot to merge args.
2952
2953         * Scripts/webkitpy/tool/bot/irc_command.py:
2954         (Hi.execute):
2955
2956 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2957
2958         webkitbot should recognize its own nickname in greetings.
2959         https://bugs.webkit.org/show_bug.cgi?id=115196
2960
2961         Reviewed by Andreas Kling.
2962
2963         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
2964
2965         * Scripts/webkitpy/tool/bot/irc_command.py:
2966         (Hi.execute):
2967
2968 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
2969
2970         [GTK] Tools/gtk/install-dependencies added ragel dependency
2971         https://bugs.webkit.org/show_bug.cgi?id=115163
2972
2973         Reviewed by Xan Lopez.
2974
2975         The install-dependencies script was missing a dependency on ragel
2976         which is expected when building HarfBuzz.
2977
2978         * gtk/install-dependencies: Added a dependency on ragel for both
2979         apt and yum.
2980
2981 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
2982
2983         [GTK] Remove pango from optional jhbuild dependencies
2984         https://bugs.webkit.org/show_bug.cgi?id=115162
2985
2986         Reviewed by Martin Robinson.
2987
2988         Pango is not needed since revision r148293 that lowers the pango
2989         dependency to 1.30, which is available in most distributions.
2990
2991         * gtk/jhbuild-optional.modules: Removes description of pango module.
2992
2993 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2994
2995         Remove Chromium-specific cases from FeatureList.pm
2996         https://bugs.webkit.org/show_bug.cgi?id=115169
2997
2998         Reviewed by Andreas Kling.
2999
3000         * Scripts/webkitperl/FeatureList.pm:
3001
3002 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3003
3004         Remove checking chromium from run-webkit-tests
3005         https://bugs.webkit.org/show_bug.cgi?id=115139
3006
3007         Reviewed by Benjamin Poulain.
3008
3009         * Scripts/run-webkit-tests:
3010         (useNewRunWebKitTests):
3011
3012 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
3013
3014         Pixel tests in SVG are all broken in WK2
3015         https://bugs.webkit.org/show_bug.cgi?id=114218
3016
3017         Reviewed by Darin Adler.
3018         
3019         Window snapshots in WebKitTestRunner on Mac are window-sized
3020         (800x600), which is wrong for the W3C SVG tests that require a
3021         480x360 snapshot.
3022         
3023         Fix by resizing the window, as well as the web view in
3024         PlatformWebView::resizeTo() so that window snapshots are correctly
3025         sized.
3026         
3027         Also do some drive-by cleanup of the window size constants in both
3028         DRT and WTR to remove magic numbers, and make the code more similar.
3029         
3030         * DumpRenderTree/TestRunner.cpp:
3031         (TestRunner::setShouldPaintBrokenImage):
3032         * DumpRenderTree/TestRunner.h:
3033         * DumpRenderTree/efl/DumpRenderTree.cpp:
3034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3035         (webInspectorShowWindow):
3036         * DumpRenderTree/mac/DumpRenderTree.mm:
3037         (createWebViewAndOffscreenWindow):
3038         (sizeWebViewForCurrentTest):
3039         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3040         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3041         (createPagedBitmapContext):
3042         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3043         (DumpRenderTree::DumpRenderTree):
3044         (DumpRenderTree::open):
3045         * DumpRenderTree/qt/TestRunnerQt.cpp:
3046         * DumpRenderTree/qt/TestRunnerQt.h:
3047         * DumpRenderTree/win/DumpRenderTree.cpp:
3048         (sizeWebViewForCurrentTest):
3049         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3050         * WebKitTestRunner/TestController.cpp:
3051         (WTR::TestController::resetStateToConsistentValues):
3052         * WebKitTestRunner/TestController.h:
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR::sizeWebViewForCurrentTest):
3055         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3056         (WTR::PlatformWebView::PlatformWebView):
3057         (WTR::PlatformWebView::resizeTo):
3058
3059 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3060
3061         [EFL] Fix build error after r148963.
3062         https://bugs.webkit.org/show_bug.cgi?id=115126
3063
3064         Reviewed by Laszlo Gombos.
3065
3066         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3067
3068         * TestWebKitAPI/PlatformEfl.cmake:
3069
3070 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3071
3072         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3073         https://bugs.webkit.org/show_bug.cgi?id=115118
3074
3075         Reviewed by Martin Robinson.
3076
3077         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3078         forwarding generator rules and don't call it for soup since there
3079         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3080
3081         * TestWebKitAPI/GNUmakefile.am:
3082         * WebKitTestRunner/GNUmakefile.am:
3083
3084 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3085
3086         [GTK] Update build dependencies
3087         https://bugs.webkit.org/show_bug.cgi?id=115111
3088
3089         Reviewed by Martin Robinson.
3090
3091         The install-dependencies script was missing a dependency on EGL,
3092         which is expected when building Cairo.
3093
3094         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3095         for both apt and yum.
3096
3097 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3098
3099         Remove the Chromium-specific helper from run_webkit_tests.py
3100         https://bugs.webkit.org/show_bug.cgi?id=114996
3101
3102         Reviewed by Dirk Pranke.
3103
3104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3105         (parse_args):
3106
3107 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3108
3109         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3110         https://bugs.webkit.org/show_bug.cgi?id=114850
3111
3112         Reviewed by Andreas Kling.
3113
3114         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3115         termination semantics when requested by the user so that a client is not
3116         notified of a crash anymore, since there was no crash anyway.
3117
3118         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3119         relied on being notified of a crash after calling WKPageTerminate(). As
3120         a result of not being notified of such non-existent crash, the test would
3121         timeout right after making the terminate call.
3122
3123         This patch adds an InjectedBundle to be used for simulating a crash, by
3124         calling abort() upon receiving a "Crash" message, and thus we are able to
3125         keep testing the crash callback.
3126
3127         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3128         had been disabled in revisions r148858 and r148855, since it was failing.
3129
3130         * TestWebKitAPI/PlatformEfl.cmake:
3131         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3132         (TestWebKitAPI::TEST):
3133         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3134         (TestWebKitAPI):
3135         (WKViewClientWebProcessCallbacksTest):
3136         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3137         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3138
3139 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3140
3141         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3142         https://bugs.webkit.org/show_bug.cgi?id=115095
3143
3144         Reviewed by Antonio Gomes.
3145
3146         Use different subfolders under DumpRenderTree Temp folder for every
3147         functionality (icon database, cache, localstorage, ...). This makes
3148         sure there is no conflict between the functionalities.
3149
3150         In EFL's case, libsoup cache was causing problems for the icon
3151         database if sharing the same folder.
3152
3153         * WebKitTestRunner/TestController.cpp:
3154         (WTR::TestController::initialize):
3155
3156 == Rolled over to ChangeLog-2013-04-24 ==