List libtasn1 packages in GTK+ and WPE install-dependencies scripts
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
2
3         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
4         as one of the dependencies required to build the product.
5
6         Rubber-stamped by Carlos Garcia Campos.
7
8         * gtk/install-dependencies:
9         * wpe/install-dependencies:
10
11 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
12
13         Disable font variations on macOS Sierra and iOS 10
14         https://bugs.webkit.org/show_bug.cgi?id=173618
15         <rdar://problem/32879164>
16
17         Reviewed by Jon Lee.
18
19         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
20
21 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
22
23         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
24         https://bugs.webkit.org/show_bug.cgi?id=173578
25         <rdar://problem/32825028>
26
27         Reviewed by Tim Horton.
28
29         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
30         a custom popover does not cause dragging to fail when the popover is presented.
31
32         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
33         (-[DataInteractionSimulator _advanceProgress]):
34
35 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
36
37         [WPE] Add initial implementation of glib API
38         https://bugs.webkit.org/show_bug.cgi?id=173546
39
40         Reviewed by Žan Doberšek.
41
42         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
43         include WPE glib API files.
44
45         * Scripts/webkitperl/FeatureList.pm:
46         * Scripts/webkitpy/style/checker.py:
47         * Scripts/webkitpy/style/checkers/cpp.py:
48         (check_identifier_name_in_declaration):
49
50 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
51
52         [GTK] Upgrade to ICU to version 57.1
53         https://bugs.webkit.org/show_bug.cgi?id=173538
54
55         Reviewed by Žan Doberšek.
56
57         * gtk/jhbuild.modules:
58
59 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         [GTK] Remove unneeded modules from the jhbuild
62         https://bugs.webkit.org/show_bug.cgi?id=170540
63
64         Reviewed by Michael Catanzaro.
65
66         We are building libxslt and libffi that we don't really need to build from sources.
67
68         * gtk/jhbuild.modules:
69
70 2017-06-19  Frederic Wang  <fwang@igalia.com>
71
72         [Mac] Add an experimental feature setting for async frame scrolling
73         https://bugs.webkit.org/show_bug.cgi?id=173359
74
75         Reviewed by Simon Fraser.
76
77         * DumpRenderTree/mac/DumpRenderTree.mm:
78         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
79         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
80         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
81         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
82
83 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
84
85         Unreviewed, adding myself to contributors.json
86
87         * Scripts/webkitpy/common/config/contributors.json:
88
89 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
90
91         test262: Completion values for control flow do not match the spec
92         https://bugs.webkit.org/show_bug.cgi?id=171265
93
94         Reviewed by Saam Barati.
95
96         * Scripts/run-jsc-stress-tests:
97         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
98
99 2017-06-19  Zalan Bujtas  <zalan@apple.com>
100
101         Opening certain mails brings up a mail that grows indefinitely.
102         https://bugs.webkit.org/show_bug.cgi?id=173562
103         <rdar://problem/32766579>
104
105         Reviewed by Tim Horton.
106
107         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
108         (TEST):
109
110 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
111
112         [iOS DnD] Support .zip archives for file uploads via drag and drop
113         https://bugs.webkit.org/show_bug.cgi?id=173511
114         <rdar://problem/32521025>
115
116         Reviewed by Tim Horton.
117
118         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
119         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
120
121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
122         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
123         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
124         (testZIPArchive):
125         (TestWebKitAPI::TEST):
126
127 2017-06-18  Darin Adler  <darin@apple.com>
128
129         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
130         https://bugs.webkit.org/show_bug.cgi?id=173526
131
132         Reviewed by Sam Weinig.
133
134         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
136
137         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
138         tests for assignment before destruction ones.
139
140         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
141         as a function, so it can be used in WTF::Function tests.
142
143         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
144         Added tests for swap and for assignment before deref.
145
146         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
147         to inline everything. Also removed the unnecessary clearing of the log every time
148         the DerivedRefLogger constructor is called.
149         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
150
151         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
152         Added tests for assignment before deref and similar for releaseNonNull.
153
154 2017-06-19  Sam Weinig  <sam@webkit.org>
155
156         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
157         https://bugs.webkit.org/show_bug.cgi?id=173513
158
159         Reviewed by Alex Christensen.
160
161         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
162         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
163         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
164
165 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
166
167         [Win] fast/dom/assign-to-window-status.html is flaky.
168         https://bugs.webkit.org/show_bug.cgi?id=173512
169
170         Reviewed by Alex Christensen.
171
172         We should not dump status callbacks when test is done.
173
174         * DumpRenderTree/win/UIDelegate.cpp:
175         (UIDelegate::setStatusText):
176
177 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
178
179         [WPE][JHBuild] Update WPEBackend-mesa
180         https://bugs.webkit.org/show_bug.cgi?id=173433
181
182         Unreviewed.
183
184         Update WPEBackend-mesa back (like it was done originally in r218344)
185         after fixing the issue with the DISPLAY environment variables that
186         caused the crashes.
187
188         * wpe/jhbuild.modules:
189
190 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
191
192         Rename unit test file after r218482
193         https://bugs.webkit.org/show_bug.cgi?id=173483
194
195         Unreviewed.
196
197         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
198
199 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
200
201         Unreviewed. Fix wrong style checker condition added in r218487.
202
203         * Scripts/webkitpy/style/checkers/cpp.py:
204         (check_identifier_name_in_declaration):
205
206 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
207
208         Missing <functional> includes make builds fail with GCC 7.x
209         https://bugs.webkit.org/show_bug.cgi?id=173544
210
211         Unreviewed gardening.
212
213         Fix compilation with GCC 7.
214
215         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
216         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
217
218 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
219
220         [GTK] Move GTK+ API files that could be shared to glib dirs
221         https://bugs.webkit.org/show_bug.cgi?id=173545
222
223         Reviewed by Žan Doberšek.
224
225         Update paths of GTK+ API in watchlist and style checker.
226
227         * Scripts/webkitpy/common/config/watchlist:
228         * Scripts/webkitpy/style/checker.py:
229         * Scripts/webkitpy/style/checkers/cpp.py:
230         (check_identifier_name_in_declaration):
231
232 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
233
234         Port setup_environ_for_server should not set environment variables related with the driver.
235         https://bugs.webkit.org/show_bug.cgi?id=173483
236
237         Reviewed by Carlos Garcia Campos.
238
239         The port setup_environ_for_server() should not set environment variables
240         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
241         This varibles should be only set on the driver setup_environ_for_test().
242
243         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
244         into the test environment even when running the tests with a driver
245         that is not the Xorg or Xvfb one.
246
247         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
248         (Port.to.setup_environ_for_server):
249         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
250         (Driver._setup_environ_for_driver):
251         * Scripts/webkitpy/port/driver_unittest.py:
252         (DriverTest.test_setup_environ_for_test):
253         (DriverTest):
254         (DriverTest.test_setup_environ_base_vars):
255         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
256         (GtkPort.setup_environ_for_server):
257         * Scripts/webkitpy/port/wayland_unittest.py: Added.
258         (WaylandDriverTest):
259         (WaylandDriverTest.make_driver):
260         (WaylandDriverTest.make_environment):
261         (WaylandDriverTest.test_checkdriver):
262         (WaylandDriverTest.test_environment_needed_variables):
263         (WaylandDriverTest.test_environment_forbidden_variables):
264         (WaylandDriverTest.test_environment_optional_variables):
265         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
266         (WaylandDriver.check_driver):
267         (WaylandDriver._setup_environ_for_test):
268         * Scripts/webkitpy/port/xorgdriver.py:
269         (XorgDriver.check_driver):
270         (XorgDriver._setup_environ_for_test):
271         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
272         (XorgDriverTest):
273         (XorgDriverTest.make_driver):
274         (XorgDriverTest.make_environment):
275         (XorgDriverTest.test_checkdriver):
276         (XorgDriverTest.test_environment_needed_variables):
277         (XorgDriverTest.test_environment_forbidden_variables):
278         (XorgDriverTest.test_environment_optional_variables):
279         * Scripts/webkitpy/port/xvfbdriver.py:
280         (XvfbDriver._setup_environ_for_test):
281         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
282         (XvfbDriverTest.assertDriverStartSuccessful):
283
284
285 2017-05-14 Frederic Wang  <fwang@igalia.com>
286
287         Add heuristic to avoid flattening "fullscreen" iframes
288         https://bugs.webkit.org/show_bug.cgi?id=171914
289
290         Reviewed by Simon Fraser.
291
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
294
295 2017-06-18  Chris Dumez  <cdumez@apple.com>
296
297         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
298         https://bugs.webkit.org/show_bug.cgi?id=173522
299         <rdar://problem/31185739>
300
301         Reviewed by Darin Adler.
302
303         Add API test for re-entering Function's assignment operators.
304
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
307         (TestWebKitAPI::TestObject::TestObject):
308         (TestWebKitAPI::TestObject::~TestObject):
309         (TestWebKitAPI::TestObject::operator()):
310         (TestWebKitAPI::TEST):
311
312 2017-06-16  Dan Bernstein  <mitz@apple.com>
313
314         [Cocoa] Some declarations have missing or incorrect availability attributes
315         https://bugs.webkit.org/show_bug.cgi?id=173508
316
317         Reviewed by Tim Horton.
318
319         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
320         (TestWebKitAPI::TEST): Updated for renames.
321
322 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
323
324         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
325         https://bugs.webkit.org/show_bug.cgi?id=173366
326         <rdar://problem/32767014>
327
328         Reviewed by Tim Horton.
329
330         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
331         change in behavior.
332
333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
336         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
337         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
338         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
339         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
340         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
341         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
342         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
343         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
344         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
345         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
346         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
347         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
348         (-[MockDragDropSession initWithItems:location:window:]):
349         (-[MockDragDropSession allowsMoveOperation]):
350         (-[MockDragDropSession isRestrictedToDraggingApplication]):
351         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
352         (-[MockDragDropSession canLoadObjectsOfClass:]):
353         (-[MockDragDropSession canLoadObjectsOfClasses:]):
354         (-[MockDragDropSession items]):
355         (-[MockDragDropSession setItems:]):
356         (-[MockDragDropSession locationInView:]):
357         (-[MockDataOperationSession initWithProviders:location:window:]):
358         (-[MockDataOperationSession session]):
359         (-[MockDataOperationSession isLocal]):
360         (-[MockDataOperationSession progress]):
361         (-[MockDataOperationSession setProgressIndicatorStyle:]):
362         (-[MockDataOperationSession progressIndicatorStyle]):
363         (-[MockDataOperationSession operationMask]):
364         (-[MockDataOperationSession localDragSession]):
365         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
366         (-[MockDataOperationSession canCreateItemsOfClass:]):
367         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
368         (-[MockDataInteractionSession initWithWindow:]):
369         (-[MockDataInteractionSession localOperationMask]):
370         (-[MockDataInteractionSession externalOperationMask]):
371         (-[MockDataInteractionSession session]):
372         (-[DataInteractionSimulator _advanceProgress]):
373
374 2017-06-16  Alex Christensen  <achristensen@webkit.org>
375
376         Show punycode to user if a URL has dotless i or j followed by diacritic dot
377         https://bugs.webkit.org/show_bug.cgi?id=173431
378
379         Reviewed by Darin Adler.
380
381         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
382         (TestWebKitAPI::TEST):
383
384 2017-06-16  Chris Dumez  <cdumez@apple.com>
385
386         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
387         https://bugs.webkit.org/show_bug.cgi?id=173472
388         <rdar://problem/28858817>
389
390         Reviewed by Brady Eidson.
391
392         Add API test coverage.
393
394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
395         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
396         (TEST):
397
398 2017-06-16  Brady Eidson  <beidson@apple.com>
399
400         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
401         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
402
403         Reviewed by Daniel Bates.
404
405         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
406
407 2017-06-16  Chris Dumez  <cdumez@apple.com>
408
409         DRT fails to reset page visibility between tests
410         https://bugs.webkit.org/show_bug.cgi?id=173485
411
412         Reviewed by Alexey Proskuryakov.
413
414         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
415         Fix this to address flakiness.
416
417         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
418         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
419         The test became flaky without the DRT change and was no longer flaky with the DRT
420         change.
421
422         WebKitTestRunner already does this.
423
424         * DumpRenderTree/mac/DumpRenderTree.mm:
425         (resetWebViewToConsistentStateBeforeTesting):
426
427 2017-06-16  Alex Christensen  <achristensen@webkit.org>
428
429         Implement basic authentication in MiniBrowser
430         https://bugs.webkit.org/show_bug.cgi?id=173443
431
432         Reviewed by Tim Horton.
433
434         * MiniBrowser/mac/WK2BrowserWindowController.m:
435         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
436
437 2017-06-16  Jer Noble  <jer.noble@apple.com>
438
439         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
440         https://bugs.webkit.org/show_bug.cgi?id=173398
441         <rdar://problem/32592961>
442
443         Reviewed by Eric Carlson.
444
445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
446         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
447         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
448         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
449         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
450         (TestWebKitAPI::TEST):
451         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
452
453 2017-06-16  Matt Lewis  <jlewis3@apple.com>
454
455         Unreviewed, rolling out r218375.
456
457         The API test MediaStreamTrackDetached is still timing out
458         after the patch
459
460         Reverted changeset:
461
462         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
463         reports no recording to WebKit clients"
464         https://bugs.webkit.org/show_bug.cgi?id=173398
465         http://trac.webkit.org/changeset/218375
466
467 2017-06-15  Jer Noble  <jer.noble@apple.com>
468
469         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
470         https://bugs.webkit.org/show_bug.cgi?id=173398
471         <rdar://problem/32592961>
472
473         Reviewed by Eric Carlson.
474
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
476         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
477         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
478         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
479         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
480         (TestWebKitAPI::TEST):
481         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
482
483 2017-06-15  Matt Lewis  <jlewis3@apple.com>
484
485         Unreviewed, rolling out r218365.
486
487         The revision caused API timeouts on all builds.
488
489         Reverted changeset:
490
491         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
492         reports no recording to WebKit clients"
493         https://bugs.webkit.org/show_bug.cgi?id=173398
494         http://trac.webkit.org/changeset/218365
495
496 2017-06-15  Jer Noble  <jer.noble@apple.com>
497
498         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
499         https://bugs.webkit.org/show_bug.cgi?id=173398
500         <rdar://problem/32592961>
501
502         Reviewed by Eric Carlson.
503
504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
505         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
506         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
507         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
508         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
511
512 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
513
514         REGRESSION(r218344): [WPE] Thousands of layout test crashes
515         https://bugs.webkit.org/show_bug.cgi?id=173433
516
517         Unreviewed.
518
519         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
520
521 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
522
523         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
524         https://bugs.webkit.org/show_bug.cgi?id=173061
525
526         Reviewed by Žan Doberšek.
527
528         Launch dyz <https://github.com/Igalia/dyz> with the script
529         run-minibrowser for the wpe port. It is now built as part of the
530         WPE dependencies with JHBuild.
531
532         * Scripts/run-minibrowser:
533         * Scripts/webkitdirs.pm:
534         (launcherPath):
535         (launcherName):
536         * wpe/install-dependencies: Luajit is needed for building dyz.
537         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
538
539 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
540
541         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
542         https://bugs.webkit.org/show_bug.cgi?id=173338
543         <rdar://problem/32777720>
544
545         Reviewed by Tim Horton.
546
547         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
548         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
549         these remaining items on drop.
550
551         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
552         (TestWebKitAPI::TEST):
553         * TestWebKitAPI/ios/DataInteractionSimulator.h:
554         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
555
556         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
557
558         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
559
560 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
561
562         [Win] Crash in accessibility layout test.
563         https://bugs.webkit.org/show_bug.cgi?id=173401
564
565         Reviewed by Brent Fulgham.
566
567         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
568         member will be automatically released when the _variant_t object goes out of scope if the vt member
569         does not equal VT_UNKNOWN | VT_BYREF.
570         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
571
572         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
573         (AccessibilityUIElement::titleUIElement):
574
575 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
576
577         [GTK] Add API to allow overriding popup menus
578         https://bugs.webkit.org/show_bug.cgi?id=172905
579
580         Reviewed by Michael Catanzaro.
581
582         Add a unit test to check the new API.
583
584         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
585         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
586         (OptionMenuTest::OptionMenuTest):
587         (OptionMenuTest::~OptionMenuTest):
588         (OptionMenuTest::destroyMenu):
589         (OptionMenuTest::showOptionMenuCallback):
590         (OptionMenuTest::menuCloseCallback):
591         (OptionMenuTest::showOptionMenu):
592         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
593         (OptionMenuTest::close):
594         (OptionMenuTest::activateItem):
595         (OptionMenuTest::selectItem):
596         (testOptionMenuSimple):
597         (testOptionMenuGroups):
598         (testOptionMenuActivate):
599         (testOptionMenuSelect):
600         (beforeAll):
601         (afterAll):
602
603 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
604
605         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
606         https://bugs.webkit.org/show_bug.cgi?id=173399
607
608         Reviewed by Per Arne Vollan.
609
610         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
611         Curl port needs to do nothing because libcurl doesn't have disk cache.
612
613         * DumpRenderTree/win/DumpRenderTree.cpp:
614         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
615         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
616
617 2017-06-14  Tomas Popela  <tpopela@redhat.com>
618
619         [GTK] integer expression expected if running Tools/gtk/install-dependencies
620         https://bugs.webkit.org/show_bug.cgi?id=173356
621
622         Reviewed by Michael Catanzaro.
623
624         Use the correct operator to compare the strings.
625
626         * gtk/install-dependencies:
627
628 2017-06-14  Commit Queue  <commit-queue@webkit.org>
629
630         Unreviewed, rolling out r218285.
631         https://bugs.webkit.org/show_bug.cgi?id=173391
632
633         API test fails on iOS (Requested by alexchristensen on
634         #webkit).
635
636         Reverted changeset:
637
638         "Add SPI for immediate injection of user scripts"
639         https://bugs.webkit.org/show_bug.cgi?id=173342
640         http://trac.webkit.org/changeset/218285
641
642 2017-06-14  Chris Dumez  <cdumez@apple.com>
643
644         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
645         https://bugs.webkit.org/show_bug.cgi?id=173384
646         <rdar://problem/32723779>
647
648         Reviewed by Dan Bernstein.
649
650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
651         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
652         Add API test coverage.
653
654         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
655         (TestWebKitAPI::Util::sleep):
656         Update implementation of Util::sleep() so that we actually run the run loop.
657         Otherwise, we don't process events while sleeping.
658
659 2017-06-14  Alex Christensen  <achristensen@webkit.org>
660
661         Add SPI for immediate injection of user scripts
662         https://bugs.webkit.org/show_bug.cgi?id=173342
663         <rdar://problem/29202285>
664
665         Reviewed by Brady Eidson.
666
667         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
668         (waitForMessage):
669         (TEST):
670
671 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
672
673         Add WPE to the flakiness dashboard
674         https://bugs.webkit.org/show_bug.cgi?id=173365
675
676         Reviewed by Carlos Alberto Lopez Perez.
677
678         * TestResultServer/static-dashboards/builders.jsonp:
679         * TestResultServer/static-dashboards/flakiness_dashboard.js:
680         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
681         (resetGlobals):
682         * TestResultServer/static-dashboards/loader_unittests.js:
683
684 2017-06-14  Brady Eidson  <beidson@apple.com>
685
686         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
687         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
688
689         Reviewed by Alex Christensen.
690
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
693         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
694         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
695         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
696         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
697         (TEST):
698
699 2017-06-14  Tim Horton  <timothy_horton@apple.com>
700
701         WKContentViewEditingActions API test always fails
702         https://bugs.webkit.org/show_bug.cgi?id=173374
703
704         Reviewed by Wenson Hsieh.
705
706         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
707         (TEST):
708         selectAll isn't working, because canPerformAction for selectAll returns NO
709         if selectionIsNone (which is true in the non-contenteditable case).
710         Instead, make use of r218180's test page, which knows how to select itself.
711         Also, reset the pasteboard at the beginning of the test to reduce confusion
712         (I landed the test broken because my simulator had the correct text
713         stuck in its pasteboard).
714
715 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
716
717         Configure screen scale for running layout tests on plus devices
718         https://bugs.webkit.org/show_bug.cgi?id=173319
719
720         Reviewed by Tim Horton.
721
722         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
723         * DumpRenderTree/mac/DumpRenderTree.mm:
724         (dumpRenderTree): Set screen scale to 2.0.
725         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
726         add _setScale for UIScreen.
727         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
728         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
729         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
730         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
731         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
732         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
733         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
734         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
735         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
736         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
737
738 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
739
740         Add iOS 11 support to the bot watcher's dashboard
741         https://bugs.webkit.org/show_bug.cgi?id=173369
742
743         Reviewed by Lucas Forschler.
744
745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
751
752 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
753
754         [GTK][WPE] Raise the timeout values for layout tests
755         https://bugs.webkit.org/show_bug.cgi?id=173368
756
757         Reviewed by Carlos Garcia Campos.
758
759         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
760         When running under valgrind a 10x multiplier is applied.
761
762         * Scripts/webkitpy/port/gtk.py:
763         (GtkPort.default_timeout_ms):
764         * Scripts/webkitpy/port/gtk_unittest.py:
765         (GtkPortTest.test_default_timeout_ms):
766         * Scripts/webkitpy/port/wpe.py:
767         (WPEPort.default_timeout_ms):
768         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
769         (WPEPortTest):
770         (WPEPortTest.make_port):
771         (WPEPortTest.test_default_timeout_ms):
772         (WPEPortTest.test_get_crash_log):
773
774 2017-06-14  Alex Christensen  <achristensen@webkit.org>
775
776         Test persistent WKHTTPCookieStorages on iOS.
777         https://bugs.webkit.org/show_bug.cgi?id=173284
778
779         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
780         (TEST):
781         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
782
783 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
784
785         [Win] DRT should not use disk cache.
786         https://bugs.webkit.org/show_bug.cgi?id=173361
787
788         Reviewed by Darin Adler.
789
790         Like on macOS/iOS, DRT on Windows should only use memory cache.
791
792         * DumpRenderTree/win/DumpRenderTree.cpp:
793         (setDefaultsToConsistentValuesForTesting):
794         (prepareConsistentTestingEnvironment):
795
796 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
797
798         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
799         https://bugs.webkit.org/show_bug.cgi?id=171668
800
801         Reviewed by Jer Noble.
802
803         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
804         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
805         Infinity when the double value passed as argument is greater than 2^64.
806
807         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
808         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
809         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
810         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
811         method. No behavior change for rational MediaTime.
812
813         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
814         (TestWebKitAPI::TEST):
815
816 2017-06-13  Alex Christensen  <achristensen@webkit.org>
817
818         Test persistent WKHTTPCookieStorages on iOS
819         https://bugs.webkit.org/show_bug.cgi?id=173284
820         <rdar://problem/32260156>
821
822         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
823         (TEST):
824
825 2017-06-13  Matt Rajca  <mrajca@apple.com>
826
827         WebsitePolicies: let clients select specific autoplay quirks
828         https://bugs.webkit.org/show_bug.cgi?id=173343
829
830         Reviewed by Alex Christensen.
831
832         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
833         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
834         (TEST): Updated tests.
835
836 2017-06-13  Daniel Bates  <dabates@apple.com>
837
838         Implement W3C Secure Contexts Draft Specification
839         https://bugs.webkit.org/show_bug.cgi?id=158121
840         <rdar://problem/26012994>
841
842         Reviewed by Brent Fulgham.
843
844         Part 4
845
846         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
847         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
848         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
849
850         * DumpRenderTree/TestOptions.h:
851         * DumpRenderTree/TestOptions.mm:
852         (TestOptions::TestOptions):
853         * DumpRenderTree/mac/DumpRenderTree.mm:
854         (setWebPreferencesForTestOptions):
855         * DumpRenderTree/win/DumpRenderTree.cpp:
856         (enableExperimentalFeatures):
857         * WebKitTestRunner/TestController.cpp:
858         (WTR::TestController::resetPreferencesToConsistentValues):
859         (WTR::updateTestOptionsFromTestHeader):
860         * WebKitTestRunner/TestOptions.h:
861         (WTR::TestOptions::hasSameInitializationOptions):
862
863 2017-06-13  Alex Christensen  <achristensen@webkit.org>
864
865         Test persistent WKHTTPCookieStorages on iOS
866         https://bugs.webkit.org/show_bug.cgi?id=173284
867         <rdar://problem/32260156>
868
869         Reviewed by Alexey Proskuryakov.
870
871         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
872         (TEST):
873
874 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
875
876         [GTK] Blob download doesn't work
877         https://bugs.webkit.org/show_bug.cgi?id=172442
878
879         Reviewed by Carlos Alberto Lopez Perez.
880
881         Add a unit test to check blob downloads.
882
883         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
884         (testBlobDownload):
885         (beforeAll):
886
887 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
888
889         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
890         https://bugs.webkit.org/show_bug.cgi?id=173316
891
892         Reviewed by Alex Christensen.
893
894         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
895
896         * gtk/manifest.txt.in:
897
898 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
899
900         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
901         https://bugs.webkit.org/show_bug.cgi?id=173315
902
903         Reviewed by Darin Adler.
904
905         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
906         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
907         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
908         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
909         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
910         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
911         WKGeolocationManagerRef is not destroyed.
912
913         * WebKitTestRunner/GeolocationProviderMock.cpp:
914         (WTR::GeolocationProviderMock::GeolocationProviderMock):
915         * WebKitTestRunner/GeolocationProviderMock.h:
916
917 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
918
919         Unable to paste text that was copied from a page into the universal search field
920         https://bugs.webkit.org/show_bug.cgi?id=173293
921         <rdar://problem/32440918>
922
923         Reviewed by Ryosuke Niwa.
924
925         Adds 2 new unit tests for copying plain and rich selected web content.
926         See WebCore and WebKit ChangeLogs for more detail.
927
928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
929         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
930         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
931         (TestWebKitAPI::dataForPasteboardType):
932         (TestWebKitAPI::setUpWebViewForPasteboardTests):
933         (TestWebKitAPI::TEST):
934
935 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
936
937         AX: [ATK] Implement missing AtkRelation types
938         https://bugs.webkit.org/show_bug.cgi?id=155494
939
940         Reviewed by Darin Adler.
941
942         Add additional methods to test ARIA properties which are exposed via
943         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
944
945         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
946         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
947         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
948         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
949         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
950         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
951         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
952         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
953         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
954         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
955         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
956         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
957         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
958         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
959         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
960         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
961         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
962         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
963
964 2017-06-12  Daniel Bates  <dabates@apple.com>
965
966         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
967         https://bugs.webkit.org/show_bug.cgi?id=173286
968         <rdar://problem/32726102>
969
970         Reviewed by Brent Fulgham.
971
972         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
973         (TestWebKitAPI::TEST_F):
974
975 2017-06-12  Lucas Forschler  <lforschler@apple.com>
976
977         <rdar://problem/32683422>
978         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
979
980         Reviewed by Conrad Schultz.
981
982         * Scripts/copy-webkitlibraries-to-product-directory:
983
984 2017-06-12  Tim Horton  <timothy_horton@apple.com>
985
986         [iOS] Cmd-C doesn't copy text from WKWebView
987         https://bugs.webkit.org/show_bug.cgi?id=173277
988         <rdar://problem/32396742>
989
990         Reviewed by Dan Bernstein.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
994         Add a test ensuring that -copy on WKContentView will cause text to be copied.
995
996 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
997
998         [WebCrypto] Remove experimental feature flag of SubtleCrypto
999         https://bugs.webkit.org/show_bug.cgi?id=173197
1000         <rdar://problem/32688148>
1001
1002         Reviewed by Brent Fulgham.
1003
1004         * DumpRenderTree/mac/DumpRenderTree.mm:
1005         (enableExperimentalFeatures):
1006         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1007         (WTR::InjectedBundle::beginTesting):
1008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1009         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1010         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1011
1012 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1013
1014         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1015         https://bugs.webkit.org/show_bug.cgi?id=173238
1016         <rdar://problem/31943370>
1017
1018         Reviewed by Ryosuke Niwa and Tim Horton.
1019
1020         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1021         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1022         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1023
1024         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1025         (TestWebKitAPI::TEST):
1026         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1027         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1028         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1029         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1030
1031 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1032
1033         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1034         https://bugs.webkit.org/show_bug.cgi?id=173225
1035         <rdar://problem/32713144>
1036
1037         Reviewed by Tim Horton.
1038
1039         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1040         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1041
1042         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1043         (TestWebKitAPI::TEST):
1044
1045 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1046
1047         Return correct process names for iOS on-device testing
1048         https://bugs.webkit.org/show_bug.cgi?id=173263
1049
1050         Reviewed by Alex Christensen.
1051
1052         When running tests on iOS devices, process names do not end with '.Development'
1053         as they do on Mac and iOS simulator.
1054
1055         * WebKitTestRunner/TestController.cpp:
1056         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1057         for iOS on-device testing.
1058         (WTR::TestController::networkProcessName): Ditto.
1059         (WTR::TestController::databaseProcessName): Ditto.
1060
1061 2017-06-12  Chris Dumez  <cdumez@apple.com>
1062
1063         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1064         https://bugs.webkit.org/show_bug.cgi?id=173267
1065         <rdar://problem/32701257>
1066
1067         Reviewed by Simon Fraser.
1068
1069         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1070         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1071         though as this covers the crash that r217867 was fixing.
1072
1073         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1074         (TestWebKitAPI::createSessionStateData):
1075         (TestWebKitAPI::TEST):
1076         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1077
1078 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1079
1080         [GTK] Stop dismissing menus attached to the web view for every injected event
1081         https://bugs.webkit.org/show_bug.cgi?id=172708
1082
1083         Reviewed by Alex Christensen.
1084
1085         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1086         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1087         events while the menu is open.
1088
1089         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1090         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1091         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1092         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1093
1094 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1095
1096         [GTK][WPE] Enable GStreamer GL on development builds
1097         https://bugs.webkit.org/show_bug.cgi?id=173248
1098
1099         Enable GStreamer GL for GTK and WPE.
1100
1101         Reviewed by Carlos Garcia Campos.
1102
1103         * Scripts/webkitperl/FeatureList.pm:
1104
1105 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1106
1107         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1108
1109         Notifications are no longer cleared on page navigation.
1110
1111         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1112         (testWebViewNotification):
1113
1114 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1115
1116         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1117
1118         DBus interface and object path names were updated in r217831.
1119
1120         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1121
1122 2017-06-10  Dan Bernstein  <mitz@apple.com>
1123
1124         Reverted r218056 because it made the IDE reindex constantly.
1125
1126         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1127         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1128         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1129         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1130         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1131         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1132         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1133         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1134
1135 2017-06-10  Dan Bernstein  <mitz@apple.com>
1136
1137         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1138         https://bugs.webkit.org/show_bug.cgi?id=173223
1139
1140         Reviewed by Sam Weinig.
1141
1142         The rebuilds were happening due to a difference in the compiler options that the IDE and
1143         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1144         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1145         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1146
1147         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1148         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1149         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1150         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1151         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1152         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1153         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1154         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1155
1156 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1157
1158         webkitpy: Reduce polling in ServerProcess
1159         https://bugs.webkit.org/show_bug.cgi?id=173116
1160
1161         Reviewed by Ryosuke Niwa.
1162
1163         We should be smarter about polling. We do not need to poll every time a line is read from
1164         stdout and stderr since lines are usually read from cached data. We should only poll
1165         when extracting that cached data from stdout and stderr.
1166
1167         * Scripts/webkitpy/port/driver.py:
1168         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1169         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1170         * Scripts/webkitpy/port/driver_unittest.py:
1171         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1172         ServerProcess.
1173         * Scripts/webkitpy/port/server_process.py:
1174         (ServerProcess._read): Allow for data to be read from _output even if the process has
1175         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1176         * Scripts/webkitpy/port/server_process_mock.py:
1177         (MockServerProcess): Add number_of_times_polled.
1178         (MockServerProcess.poll): Increment number_of_times_polled.
1179         (MockServerProcess.has_crashed): Poll before returning crash state.
1180         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1181         just like a ServerProcess would.
1182         (MockServerProcess.read_stdout): Ditto.
1183         * Scripts/webkitpy/port/server_process_unittest.py:
1184         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1185         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1186         (TestServerProcess):
1187         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1188         the processes is polled.
1189         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1190         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1191
1192 2017-06-10  Andy Estes  <aestes@apple.com>
1193
1194         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1195         https://bugs.webkit.org/show_bug.cgi?id=173190
1196         <rdar://problem/31360659>
1197
1198         Reviewed by Brady Eidson.
1199         
1200         Added a release assert that tries to create a proper test failure if the web process crashes.
1201
1202         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1203         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1204
1205 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1206
1207         [iOS DnD] Add a hook to perform two-step drops in editable content
1208         https://bugs.webkit.org/show_bug.cgi?id=172992
1209         <rdar://problem/32590174>
1210
1211         Reviewed by Tim Horton.
1212
1213         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
1214         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
1215                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
1216
1217         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1218         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1219         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
1220
1221         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
1222         be overridden. Currently, this is overridden to just return true.
1223
1224         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1225         (TestWebKitAPI::TEST):
1226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1227         (WTR::InjectedBundlePage::InjectedBundlePage):
1228
1229 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1230
1231         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
1232         https://bugs.webkit.org/show_bug.cgi?id=173103
1233
1234         Reviewed by Xabier Rodriguez-Calvar.
1235
1236         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
1237         when building the WPE port through build-webkit.
1238
1239 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1240
1241         [WPE] Enable MEDIA_SOURCE for build-webkit builds
1242         https://bugs.webkit.org/show_bug.cgi?id=173136
1243
1244         Reviewed by Xabier Rodriguez-Calvar.
1245
1246         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
1247
1248 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1249
1250         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
1251         https://bugs.webkit.org/show_bug.cgi?id=173098
1252
1253         Reviewed by Žan Doberšek.
1254
1255         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
1256         assuming that all tests containing forms define ids for the form elements like
1257         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
1258
1259         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1260         (formControlsAssociatedCallback):
1261
1262 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
1263
1264         webkitpy: Run sample/spindump on iOS devices
1265         https://bugs.webkit.org/show_bug.cgi?id=171881
1266         <rdar://problem/32084602>
1267
1268         Reviewed by Daniel Bates.
1269
1270         * Scripts/webkitpy/port/darwin.py:
1271         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
1272         requires sudo to run spindump.
1273         * Scripts/webkitpy/port/ios_device.py:
1274         (IOSDevicePort.look_for_new_samples): Deleted.
1275         (IOSDevicePort.sample_process): Deleted.
1276         * Scripts/webkitpy/port/ios_device_unittest.py:
1277         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
1278         (IOSDeviceTest.test_spindump):
1279         (IOSDeviceTest.test_sample_process):
1280         (IOSDeviceTest.test_sample_process_exception):
1281         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1282         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
1283
1284 2017-06-08  Keith Miller  <keith_miller@apple.com>
1285
1286         WebAssembly: We should only create wrappers for functions that can be exported
1287         https://bugs.webkit.org/show_bug.cgi?id=173088
1288
1289         Reviewed by Saam Barati.
1290
1291         Add quick mode for wasm tests.
1292
1293         * Scripts/run-jsc-stress-tests:
1294
1295 2017-06-08  Darin Adler  <darin@apple.com>
1296
1297         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
1298         https://bugs.webkit.org/show_bug.cgi?id=173106
1299
1300         Reviewed by Sam Weinig.
1301
1302         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
1303         destroyed last.
1304         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
1305         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1306
1307 2017-06-07  Dan Bernstein  <mitz@apple.com>
1308
1309         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
1310         https://bugs.webkit.org/show_bug.cgi?id=173086
1311
1312         Reviewed by Andy Estes.
1313
1314         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1315         (TEST):
1316
1317 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
1318
1319         Add High Sierra support to WebKit tools
1320         https://bugs.webkit.org/show_bug.cgi?id=173080
1321
1322         Rubber-stamped by Daniel Bates.
1323
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1328         Added dashboard support.
1329
1330         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1331         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1332         Trigger the right build queues on check-in.
1333
1334         * Scripts/webkitpy/common/system/platforminfo.py:
1335         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1336         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1337         * Scripts/webkitpy/port/mac.py:
1338         * Scripts/webkitpy/port/mac_unittest.py:
1339         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1340         Added cases for Sierra, and updated tests for new baseline search paths.
1341
1342 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
1343
1344         Unreviewed, rolling out r217902.
1345
1346         This change appears to have caused imported/w3c/web-platform-
1347         tests/fetch/api/cors tests to fail on El Capitan.
1348
1349         Reverted changeset:
1350
1351         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
1352         https://bugs.webkit.org/show_bug.cgi?id=172930
1353         http://trac.webkit.org/changeset/217902
1354
1355 2017-06-07  Daniel Bates  <dabates@apple.com>
1356
1357         Teach run-webkit-tests how to run HTTPS Web Platform Tests
1358         https://bugs.webkit.org/show_bug.cgi?id=172930
1359         <rdar://problem/32570201>
1360
1361         Reviewed by Youenn Fablet.
1362
1363         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
1364         that is conditioned on the page being delivered over a secure protocol. One example of such
1365         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
1366
1367         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
1368         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
1369         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
1370
1371         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1372         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
1373         to the Web Platform Tests HTTPS server.
1374         * Scripts/webkitpy/port/base.py:
1375         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
1376         * Scripts/webkitpy/port/driver.py:
1377         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
1378         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
1379         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
1380         indicate that they should be considered private instance variables.
1381         (Driver.is_web_platform_test): Update code for renamed instance variables.
1382         (Driver):
1383         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
1384         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
1385         determine the base URL to use to access the test.
1386         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
1387         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
1388
1389 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
1390
1391         Support removal of authentication data through the Website data store API.
1392         https://bugs.webkit.org/show_bug.cgi?id=171217
1393
1394         Reviewed by Brady Eidson.
1395
1396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1397         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1398         (WTR::InjectedBundle::didReceiveMessageToPage):
1399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1400         (WTR::TestRunner::removeAllSessionCredentials):
1401         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
1402         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1403         * WebKitTestRunner/TestController.h:
1404         * WebKitTestRunner/TestInvocation.cpp:
1405         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1406         (WTR::TestInvocation::didRemoveAllSessionCredentials):
1407         * WebKitTestRunner/TestInvocation.h:
1408         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1409         (WTR::TestController::removeAllSessionCredentials):
1410
1411 2017-06-07  Charlie Turner  <cturner@igalia.com>
1412
1413         Add Charlie Turner as contributor
1414         https://bugs.webkit.org/show_bug.cgi?id=173055
1415
1416         Reviewed by Carlos Alberto Lopez Perez.
1417
1418         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
1419         of webkit-patch upload, which reordered some fields and removed a newline.
1420
1421         * Scripts/webkitpy/common/config/contributors.json:
1422
1423 2017-06-06  Chris Dumez  <cdumez@apple.com>
1424
1425         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
1426         https://bugs.webkit.org/show_bug.cgi?id=173033
1427         <rdar://problem/32591099>
1428
1429         Reviewed by Simon Fraser.
1430
1431         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
1432         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
1433
1434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1435         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
1436         (TestWebKitAPI::didFinishLoadForFrame):
1437         (TestWebKitAPI::setPageLoaderClient):
1438         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
1439         (TestWebKitAPI::TEST):
1440
1441 2017-06-06  Andy Estes  <aestes@apple.com>
1442
1443         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
1444         https://bugs.webkit.org/show_bug.cgi?id=172849
1445         <rdar://problem/32567454>
1446
1447         Reviewed by Darin Adler.
1448
1449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1450         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
1451         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1452         (TestWebKitAPI::TEST):
1453
1454 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
1455
1456         [preload] Conditional support for media preloading and align media `as` values.
1457         https://bugs.webkit.org/show_bug.cgi?id=172501
1458
1459         Reviewed by Dean Jackson.
1460
1461         Turn on media preloading preference for tests.
1462
1463         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
1464         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
1465         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
1466
1467 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1468
1469         webkitpy: Return correct process names from SimulatorProcess
1470         https://bugs.webkit.org/show_bug.cgi?id=172940
1471
1472         Reviewed by Aakash Jain.
1473
1474         * Scripts/webkitpy/port/darwin.py:
1475         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
1476         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
1477         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
1478         * Scripts/webkitpy/port/driver.py:
1479         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
1480         _server_process.name() will not return the correct process name for iOS.
1481         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
1482         (Driver._read_block): Ditto.
1483         * Scripts/webkitpy/port/driver_unittest.py:
1484         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
1485         process_name() instead of name().
1486         * Scripts/webkitpy/port/server_process.py:
1487         (ServerProcess._start): Use process_name() instead of name().
1488         (ServerProcess.stop): Ditto.
1489         (ServerProcess.name): Deleted.
1490         * Scripts/webkitpy/port/simulator_process.py:
1491         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1492
1493 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
1494
1495         test-webkitpy: stop forking unsafely from within a spawned process
1496         https://bugs.webkit.org/show_bug.cgi?id=172774
1497
1498         Reviewed by Darin Adler.
1499
1500         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1501         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
1502         it's going to be used.
1503         (Builder.force_build):
1504
1505 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1506
1507         webkitpy: Process crash-logs for iOS devices
1508         https://bugs.webkit.org/show_bug.cgi?id=171976
1509         <rdar://problem/32134551>
1510
1511         Reviewed by David Kilzer.
1512
1513         When running layout tests on an iOS device, crash logs should be processed.
1514         Implement crash log searching and parsing for iOS devices.
1515
1516         * Scripts/webkitpy/common/system/crashlogs.py:
1517         (CrashLogs): Moved process regular expression for Darwin to class variable.
1518         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
1519         (CrashLogs.find_newest_log): Add iOS as a potential platform.
1520         (CrashLogs.find_all_logs): Ditto.
1521         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
1522         Do not assume that a Darwin crash log starts with the process.
1523         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
1524         shared code for parsing Darwin crash logs.
1525         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
1526         object so that crash logs already on the system before testing are not parsed.
1527         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
1528         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
1529         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
1530         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1531         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
1532         * Scripts/webkitpy/common/system/systemhost.py:
1533         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1534         systems is just the crashlog, use this behavior by default.
1535         * Scripts/webkitpy/common/system/systemhost_mock.py:
1536         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1537         systems is just the crashlog, use this behavior by default.
1538         * Scripts/webkitpy/port/apple.py:
1539         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
1540         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
1541         the system before testing begins
1542         * Scripts/webkitpy/port/base.py:
1543         (Port._get_crash_log): Pass optional target host when getting crash logs.
1544         * Scripts/webkitpy/port/darwin.py:
1545         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
1546         CrashLogs object.
1547         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1548         logs to be skipped to CrashLogs object.
1549         * Scripts/webkitpy/port/darwin_testcase.py:
1550         (DarwinTest.test_get_crash_log): Removed unused local function.
1551         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
1552         * Scripts/webkitpy/port/device.py:
1553         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
1554         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
1555         * Scripts/webkitpy/port/driver.py:
1556         (Driver._get_crash_log): Pass optional target host when getting crash logs.
1557         * Scripts/webkitpy/port/gtk.py:
1558         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
1559         * Scripts/webkitpy/port/ios.py: Ditto.
1560         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
1561         to be skipped for each host.
1562         * Scripts/webkitpy/port/ios_device.py:
1563         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
1564         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
1565         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
1566         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
1567         host is specified. Else, search all connected devices for the specified crash-log.
1568         (IOSDevicePort.look_for_new_crash_logs): Deleted.
1569         * Scripts/webkitpy/port/ios_device_unittest.py:
1570         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
1571         (IOSDeviceTest.test_get_crash_log): Ditto.
1572         * Scripts/webkitpy/port/simulator_process.py:
1573         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1574         * Scripts/webkitpy/port/win.py:
1575         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1576         logs to be skipped to CrashLogs object.
1577         * Scripts/webkitpy/port/wpe.py:
1578         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
1579
1580 2017-06-06  David Kilzer  <ddkilzer@apple.com>
1581
1582         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
1583         <https://webkit.org/b/172804>
1584
1585         Reviewed by Darin Adler.
1586
1587         WTF_ATTRIBUTE_PRINTF() only works outside the current
1588         compilation unit if it's on the declaration, not the
1589         implementation, of a function or class method.
1590
1591         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1592         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1593         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1594         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1595         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
1596         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1597         - Remove redundant CRASH() macro definition.  Use the one from
1598           <wtf/Assertions.h> instead.
1599
1600 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1601
1602         Move Resource Timing / User Timing from experimental features into main preferences
1603         https://bugs.webkit.org/show_bug.cgi?id=172950
1604
1605         Reviewed by Darin Adler.
1606
1607         * DumpRenderTree/mac/DumpRenderTree.mm:
1608         (enableExperimentalFeatures):
1609         (resetWebPreferencesToConsistentValues):
1610         * DumpRenderTree/win/DumpRenderTree.cpp:
1611         (enableExperimentalFeatures):
1612         (resetWebPreferencesToConsistentValues):
1613         * WebKitTestRunner/TestController.cpp:
1614         (WTR::TestController::resetPreferencesToConsistentValues):
1615         Move out no longer experimental features to the main list.
1616
1617 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1618
1619         [WPE] Add an install-dependencies script
1620         https://bugs.webkit.org/show_bug.cgi?id=172948
1621
1622         Reviewed by Žan Doberšek.
1623
1624         It is based on the gtk/install-dependencies script.
1625         Includes support for Debian based distrubutions, Fedora and Arch.
1626         It has been tested on a minimal Debian 9 chroot.
1627
1628         * wpe/install-dependencies: Added.
1629
1630 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1631
1632         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
1633         https://bugs.webkit.org/show_bug.cgi?id=172891
1634         <rdar://problem/32204540>
1635
1636         Reviewed by Darin Adler.
1637
1638         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
1639         contenteditable. See WebCore ChangeLog for more details.
1640
1641         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1642         (TestWebKitAPI::TEST):
1643
1644 2017-06-05  Daniel Bates  <dabates@apple.com>
1645
1646         webkitpy: Abstract Executive class
1647         https://bugs.webkit.org/show_bug.cgi?id=172928
1648         <rdar://problem/32569531>
1649
1650         Reviewed by Ryosuke Niwa.
1651
1652         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
1653         This will make it straightforward to create additional derived classes that
1654         adhere to the same interface, say for iOS on-device testing.
1655
1656         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
1657         (AbstractExecutive):
1658         (AbstractExecutive.run_and_throw_if_fail):
1659         (AbstractExecutive.cpu_count):
1660         (AbstractExecutive.interpreter_for_script):
1661         (AbstractExecutive.shell_command_for_script):
1662         (AbstractExecutive.kill_process):
1663         (AbstractExecutive.check_running_pid):
1664         (AbstractExecutive.running_pids):
1665         (AbstractExecutive.wait_newest):
1666         (AbstractExecutive.wait_limited):
1667         (AbstractExecutive.interrupt):
1668         (AbstractExecutive.default_error_handler):
1669         (AbstractExecutive.ignore_error):
1670         (AbstractExecutive._stringify_args):
1671         (AbstractExecutive.command_for_printing):
1672         (AbstractExecutive.run_command):
1673         (AbstractExecutive.popen):
1674         (AbstractExecutive.run_in_parallel):
1675         * Scripts/webkitpy/common/system/executive.py:
1676         (Executive):
1677         (Executive.cpu_count):
1678         (Executive.running_pids):
1679         (Executive.kill_all):
1680         (Executive._compute_stdin):
1681         (Executive.interpreter_for_script): Deleted.
1682         (Executive.shell_command_for_script): Deleted.
1683         (Executive.wait_newest): Deleted.
1684         (Executive.wait_limited): Deleted.
1685         (Executive.default_error_handler): Deleted.
1686         (Executive.ignore_error): Deleted.
1687         (Executive.command_for_printing): Deleted.
1688
1689 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
1690
1691         webkitpy: Add iOS to platform
1692         https://bugs.webkit.org/show_bug.cgi?id=172931
1693
1694         Reviewed by Daniel Bates.
1695
1696         * Scripts/webkitpy/common/system/platforminfo.py:
1697         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
1698         (PlatformInfo.is_ios): Added.
1699         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
1700         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1701         (MockPlatformInfo.is_ios): Added.
1702
1703 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1704
1705         [WPE][JHBuild] Switch github repository from git:// to https://
1706         https://bugs.webkit.org/show_bug.cgi?id=172921
1707
1708         Reviewed by Alex Christensen.
1709
1710         * wpe/jhbuild.modules:
1711
1712 2017-06-05  Tim Horton  <timothy_horton@apple.com>
1713
1714         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
1715         https://bugs.webkit.org/show_bug.cgi?id=172887
1716         <rdar://problem/32546061>
1717
1718         Reviewed by Sam Weinig.
1719
1720         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1721         (WTR::UIScriptController::applyAutocorrection):
1722         applyAutocorrection can call its completion handler synchronously,
1723         which makes UIScriptController unhappy (see bug 172884).
1724
1725 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
1726
1727         webkitpy: Add contextmanager to disable logging for a block
1728         https://bugs.webkit.org/show_bug.cgi?id=172876
1729
1730         Reviewed by Daniel Bates.
1731
1732         Add a context manager which will use an OutputCapture object to capture logging
1733         in a block and hold it in a variable.
1734
1735         * Scripts/webkitpy/common/system/outputcapture.py:
1736         (OutputCaptureScope):
1737         (OutputCaptureScope.__init__): Construct with OutputCapture object.
1738         (OutputCaptureScope.__enter__): Begin capturing output. 
1739         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
1740         output and retain the resulting log.
1741         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1742         (OutputCaptureTest.test_output_capture_scope): Added.
1743
1744 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1745
1746         Cleanup FrameView::autoSizeIfEnabled.
1747         https://bugs.webkit.org/show_bug.cgi?id=172889
1748         <rdar://problem/32550783>
1749
1750         Reviewed by Tim Horton.
1751
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1753         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
1754         (TEST):
1755
1756 2017-06-02  Chris Dumez  <cdumez@apple.com>
1757
1758         ResourceLoadStatistics are not using unique paths during test runs
1759         https://bugs.webkit.org/show_bug.cgi?id=172861
1760         <rdar://problem/32442251>
1761
1762         Reviewed by Darin Adler.
1763
1764         Make sure WebKitTestRunner sets a temporary path for saving resource
1765         load statistics.
1766
1767         * WebKitTestRunner/TestController.cpp:
1768         (WTR::TestController::generateContextConfiguration):
1769
1770 2017-06-02  Brady Eidson  <beidson@apple.com>
1771
1772         Prevent scheme handlers from handling all built-in URL schemes.
1773         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
1774
1775         Reviewed by Andy Estes.
1776
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1778
1779 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
1780
1781         [JSCOnly] Build static jsc.exe on Windows
1782         https://bugs.webkit.org/show_bug.cgi?id=172833
1783
1784         Reviewed by Konstantin Tokarev.
1785
1786         * CMakeLists.txt:
1787         * Scripts/build-jsc:
1788
1789 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1790
1791         Disable ViewportSizeForViewportUnits tests on iOS.
1792         https://bugs.webkit.org/show_bug.cgi?id=172872
1793
1794         Reviewed by Tim Horton.
1795
1796         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
1797
1798 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1799
1800         Allow clients to override viewport size for CSS viewport units.
1801         https://bugs.webkit.org/show_bug.cgi?id=172838
1802         <rdar://problem/32523441>
1803
1804         Reviewed by Tim Horton.
1805
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
1808         (TEST):
1809
1810 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
1811
1812         Get <chrono> out of StdLibExtras.h
1813         https://bugs.webkit.org/show_bug.cgi?id=172744
1814
1815         Reviewed by Zalan Bujtas.
1816
1817         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1818
1819 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
1820
1821         [WPE] Enable SUBTLE_CRYPTO
1822         https://bugs.webkit.org/show_bug.cgi?id=172756
1823
1824         Reviewed by Michael Catanzaro.
1825
1826         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
1827         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
1828         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
1829         exhausting entropy when running the crypto layout tests.
1830
1831 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1832
1833         [GTK] Bump GTK+ and its dependencies in jhbuild
1834         https://bugs.webkit.org/show_bug.cgi?id=171918
1835
1836         Reviewed by Carlos Alberto Lopez Perez.
1837
1838         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1839         (WTR::initializeGtkSettings):
1840         * gtk/jhbuild.modules:
1841         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1842         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1843
1844 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1845
1846         [GTK] Bump wayland and weston in jhbuild
1847         https://bugs.webkit.org/show_bug.cgi?id=171921
1848
1849         Reviewed by Carlos Alberto Lopez Perez.
1850
1851         * gtk/jhbuild.modules:
1852         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
1853
1854 2017-06-01  Andy Estes  <aestes@apple.com>
1855
1856         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1857         https://bugs.webkit.org/show_bug.cgi?id=172828
1858
1859         Reviewed by Beth Dakin.
1860
1861         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1862
1863 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1864
1865         webkitpy: Remove unneeded simulator teardown
1866         https://bugs.webkit.org/show_bug.cgi?id=171891
1867
1868         Reviewed by Aakash Jain.
1869
1870         * Scripts/webkitpy/port/ios_simulator.py:
1871         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
1872         for communication between Python and WebKitTestRunner/DumpRenderTree.
1873
1874 2017-06-01  Keith Miller  <keith_miller@apple.com>
1875
1876         Undo rollout in r217638 with bug fix
1877         https://bugs.webkit.org/show_bug.cgi?id=172824
1878
1879         Unreviewed, reland patch with unused set_state code removed.
1880
1881         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1882         (runThreadMessageTest):
1883         (TEST):
1884
1885 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1886
1887         webkitpy: Do not send 0 or -1 as a pid to kill_process
1888         https://bugs.webkit.org/show_bug.cgi?id=172818
1889
1890         Reviewed by Darin Adler.
1891
1892         Sending a signal to process 0 will result in all processes in the group receiving 
1893         the signal. Sending a signal to process -1 will result in all non-system processes
1894         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
1895         should consider these cases
1896
1897         * Scripts/webkitpy/common/system/executive.py:
1898         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
1899         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
1900         never be running, although os.kill may succeed.
1901         * Scripts/webkitpy/port/simulator_process.py:
1902         (SimulatorProcess.stop): Do not kill process if it is undefined.
1903
1904 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
1905
1906         JSC EWS bot does not run on WTF only patches
1907         https://bugs.webkit.org/show_bug.cgi?id=172777
1908         rdar://problem/32495975
1909
1910         Reviewed by Aakash Jain.
1911
1912         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1913         (CheckPatchRelevance): Add a missing comma.
1914
1915 2017-05-31  Commit Queue  <commit-queue@webkit.org>
1916
1917         Unreviewed, rolling out r217611 and r217631.
1918         https://bugs.webkit.org/show_bug.cgi?id=172785
1919
1920         "caused wasm-hashset-many.html to become flaky." (Requested by
1921         keith_miller on #webkit).
1922
1923         Reverted changesets:
1924
1925         "Reland r216808, underlying lldb bug has been fixed."
1926         https://bugs.webkit.org/show_bug.cgi?id=172759
1927         http://trac.webkit.org/changeset/217611
1928
1929         "Use dispatch queues for mach exceptions"
1930         https://bugs.webkit.org/show_bug.cgi?id=172775
1931         http://trac.webkit.org/changeset/217631
1932
1933 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1934
1935         EWS bots should reboot themselves more frequently
1936         https://bugs.webkit.org/show_bug.cgi?id=172402
1937
1938         Reviewed by Alexey Proskuryakov.
1939
1940         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
1941
1942         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
1943
1944 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1945
1946         Reallocate hardware for iOS bots.
1947         https://bugs.webkit.org/show_bug.cgi?id=172657
1948
1949         Reviewed by Alexey Proskuryakov.
1950
1951         * BuildSlaveSupport/build.webkit.org-config/config.json:
1952
1953 2017-05-31  Andy Estes  <aestes@apple.com>
1954
1955         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1956         https://bugs.webkit.org/show_bug.cgi?id=172366
1957
1958         Reviewed by Daniel Bates.
1959
1960         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1961
1962 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
1963
1964         Unreviewed, add Jiewen Tan as a reviewer
1965
1966         * Scripts/webkitpy/common/config/contributors.json:
1967
1968 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
1969
1970         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
1971         https://bugs.webkit.org/show_bug.cgi?id=172770
1972
1973         Reviewed by Michael Catanzaro.
1974
1975         * MiniBrowser/gtk/BrowserWindow.c:
1976         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
1977         which caused the body of the if-clause to be accidentally empty.
1978
1979 2017-05-31  Keith Miller  <keith_miller@apple.com>
1980
1981         Reland r216808, underlying lldb bug has been fixed.
1982         https://bugs.webkit.org/show_bug.cgi?id=172759
1983
1984         Unreviewed, relanding old patch. See: rdar://problem/31183352
1985
1986         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1987         (runThreadMessageTest):
1988         (TEST):
1989
1990 2017-05-31  Matt Lewis  <jlewis3@apple.com>
1991
1992         Unreviewed, rolling out r217603.
1993
1994         This patch broke the internal builds.
1995
1996         Reverted changeset:
1997
1998         "Get <chrono> out of StdLibExtras.h"
1999         https://bugs.webkit.org/show_bug.cgi?id=172744
2000         http://trac.webkit.org/changeset/217603
2001
2002 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2003
2004         Make ResourceLoadStatistics testing more reliable
2005         https://bugs.webkit.org/show_bug.cgi?id=172730
2006         <rdar://problem/32028373>
2007
2008         Reviewed by Andy Estes.
2009
2010         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2011         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2012
2013         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2014         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2015
2016 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2017
2018         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2019         https://bugs.webkit.org/show_bug.cgi?id=172757
2020
2021         Reviewed by Xabier Rodriguez-Calvar.
2022
2023         When needed, add the jhbuild wrapper at the beginning of the array
2024         that will be invoked to execute the run-jsc-stress-test or testapi
2025         commands.
2026
2027         * Scripts/run-javascriptcore-tests:
2028         (runJSCStressTests):
2029         * Scripts/webkitdirs.pm:
2030         (shouldUseJhbuild):
2031
2032 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2033
2034         Get <chrono> out of StdLibExtras.h
2035         https://bugs.webkit.org/show_bug.cgi?id=172744
2036
2037         Reviewed by Saam Barati.
2038
2039         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2040
2041 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2042
2043         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2044         https://bugs.webkit.org/show_bug.cgi?id=172735
2045         <rdar://problem/32015977>
2046
2047         Reviewed by Enrica Casucci.
2048
2049         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2050         (WTR::UIScriptController::applyAutocorrection):
2051         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2052         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2053         (WTR::UIScriptController::applyAutocorrection):
2054         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2055         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2056         (WTR::UIScriptController::applyAutocorrection):
2057         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2058         because I don't know how to tap the button in the autocorrection bar from a test.
2059
2060 2017-05-30  Daniel Bates  <dabates@apple.com>
2061
2062         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2063         https://bugs.webkit.org/show_bug.cgi?id=172671
2064
2065         Reviewed by Alex Christensen.
2066
2067         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2068         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2069
2070         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2071         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2072         to trigger a navigation to test it.
2073         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2074         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2075
2076 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2077
2078         webkitpy: Start servers before setting-up for testing
2079         https://bugs.webkit.org/show_bug.cgi?id=172176
2080         <rdar://problem/32225538>
2081
2082         Reviewed by Alexey Proskuryakov.
2083
2084         On-device testing requires that servers are started before ports set-up their
2085         test environments.
2086
2087         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2088         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2089         Servers are unconditionally stopped on exit.
2090         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2091         Manager now stops servers.
2092         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2093         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2094         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2095         (Manager.__init__): Delay construction of the test runner until we can determine
2096         if servers need to be started.
2097         (Manager.run): Determine if servers need to be started and construct the test runner.
2098         Shut servers down when the test run is finished.
2099         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2100         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2101         (is_wpt_server_running): Server is not running if no config is found.
2102         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2103         (PyWebSocket.is_running): Check if this WebSocket server is running.
2104         * Scripts/webkitpy/port/base.py:
2105         (Port.__init__): Define secure WebSocket server.
2106         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2107
2108 2017-05-30  Daniel Bates  <dabates@apple.com>
2109
2110         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2111         https://bugs.webkit.org/show_bug.cgi?id=172603
2112         <rdar://problem/32471306>
2113
2114         Reviewed by Brady Eidson.
2115
2116         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2117         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2118         unloading is initiated for a page that registered a onbeforeunload handler.
2119
2120         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2121         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2122         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2123
2124         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2125         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2126         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2127         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2128
2129         * MiniBrowser/mac/WK2BrowserWindowController.m:
2130         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2131         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2132         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2133         (sawDialog):
2134         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2135         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2136         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2137
2138 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2139
2140         Update libwebrtc configuration
2141         https://bugs.webkit.org/show_bug.cgi?id=172727
2142
2143         Reviewed by Geoffrey Garen.
2144
2145         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2146
2147 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2148
2149         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2150         https://bugs.webkit.org/show_bug.cgi?id=172702
2151
2152         Reviewed by Alex Christensen.
2153
2154         EGL PlatformDisplay needs to be shut down before existing a
2155         program on Windows.
2156
2157         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2158         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2159         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2160         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2161
2162 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2163
2164         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2165         https://bugs.webkit.org/show_bug.cgi?id=172709
2166
2167         Reviewed by Brent Fulgham.
2168
2169         Exit fullscreen mode after a fullscreen test.
2170
2171         * DumpRenderTree/win/DumpRenderTree.cpp:
2172         (resetWebViewToConsistentStateBeforeTesting):
2173
2174 2017-05-30  Antti Koivisto  <antti@apple.com>
2175
2176         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2177         https://bugs.webkit.org/show_bug.cgi?id=172713
2178
2179         Reviewed by Zalan Bujtas.
2180
2181         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2182         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2183
2184             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2185             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2186             because on Mac WK1 it may get invoked from middle of a layout.
2187
2188             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2189
2190 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2191
2192         Add a WPE EWS queue
2193         https://bugs.webkit.org/show_bug.cgi?id=172693
2194
2195         Reviewed by Carlos Garcia Campos.
2196
2197         * QueueStatusServer/config/queues.py:
2198         * QueueStatusServer/model/queues.py: Capitalize the name of the
2199         port on the tooltip of the bubbles. Do the same for the GTK port.
2200         (Queue.display_name):
2201         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2202         for the GTK+ EWS also. Set for both ports as watcher the alias
2203         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2204         * Scripts/webkitpy/common/config/ports.py:
2205         (DeprecatedPort.port):
2206         (WpePort):
2207         (WpePort.build_webkit_command):
2208         (WpePort.run_webkit_tests_command):
2209         * Scripts/webkitpy/common/config/ports_unittest.py:
2210         (DeprecatedPortTest):
2211         (DeprecatedPortTest.test_wpe_port):
2212         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2213         (test_ews_name):
2214
2215 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
2216
2217         Unreviewed. Bumping the WPEBackend-mesa dependency version.
2218
2219         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
2220         priorities for IPC communication.
2221
2222 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
2223
2224         [JSC] Map and Set constructors should have fast path for cloning
2225         https://bugs.webkit.org/show_bug.cgi?id=172413
2226
2227         Reviewed by Saam Barati.
2228
2229         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2230         (TestWebKitAPI::TEST):
2231
2232 2017-05-27  Zalan Bujtas  <zalan@apple.com>
2233
2234         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
2235         https://bugs.webkit.org/show_bug.cgi?id=172676
2236
2237         Reviewed by Simon Fraser.
2238
2239         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2240         (TestWebKitAPI::TEST):
2241
2242 2017-05-26  Zalan Bujtas  <zalan@apple.com>
2243
2244         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
2245         https://bugs.webkit.org/show_bug.cgi?id=172674
2246
2247         Reviewed by Simon Fraser.
2248
2249         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2250         (TestWebKitAPI::TEST):
2251
2252 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2253
2254         Add test resources back into TestWebKitAPI Copy Resources phase
2255
2256         Rubber-stamped by Beth Dakin.
2257
2258         Add two files back into the Copy Resources phase after they were unintentionally
2259         removed in r217447 and r217496.
2260
2261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2262
2263 2017-05-26  Beth Dakin  <bdakin@apple.com>
2264
2265         Media documents inside iframes should not get controls in the TouchBar unless the 
2266         video is playing
2267         https://bugs.webkit.org/show_bug.cgi?id=172620
2268         -and corresponding-
2269         rdar://problem/32165477
2270
2271         Reviewed by Jon Lee.
2272
2273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2274         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2275         (TestWebKitAPI::TEST):
2276         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
2277
2278 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
2279
2280         _WKUserStyleSheet and WKUserScript leak string data
2281         https://bugs.webkit.org/show_bug.cgi?id=172583
2282         <rdar://problem/32395209>
2283
2284         Reviewed by Sam Weinig.
2285
2286         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2287         We should not have been adopting an autoreleased object.
2288
2289 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
2290
2291         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
2292         https://bugs.webkit.org/show_bug.cgi?id=172554
2293         <rdar://problem/31247133>
2294
2295         Reviewed by Simon Fraser.
2296
2297         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
2298         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
2299         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
2300         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
2301         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
2302         codepath.
2303
2304         * DumpRenderTree/TestOptions.h:
2305         * DumpRenderTree/TestOptions.mm:
2306         (TestOptions::TestOptions):
2307         (TestOptions::webViewIsCompatibleWithOptions):
2308         * DumpRenderTree/mac/DumpRenderTree.mm:
2309         (shouldIgnoreWebCoreNodeLeaks):
2310         (allowedFontFamilySet):
2311         (-[DRTMockScroller rectForPart:]):
2312         (-[DRTMockScroller drawKnob]):
2313         (-[DRTMockScroller drawRect:]):
2314         (createWebViewAndOffscreenWindow):
2315         (initializeGlobalsFromCommandLineOptions):
2316         (prepareConsistentTestingEnvironment):
2317         (dumpRenderTree):
2318         (dumpAudio):
2319         (dumpHistoryItem):
2320         (dumpBackForwardListForWebView):
2321         (resetWebViewToConsistentStateBeforeTesting):
2322         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
2323         (runTest):
2324
2325 2017-05-25  Sam Weinig  <sam@webkit.org>
2326
2327         [WebIDL] Use the term 'operation' more consistently
2328         https://bugs.webkit.org/show_bug.cgi?id=172601
2329
2330         Reviewed by Chris Dumez.
2331
2332         We were using the term 'operation', a WebIDL term for function-like
2333         constructs, inconsistently in the code generator. Now, when we use
2334         'operation' when referring to the IDL concept (usually the object the
2335         parser produces) and 'function' when referring to code being generated.
2336
2337         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2338         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2339
2340 2017-05-25  Jer Noble  <jer.noble@apple.com>
2341
2342         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
2343
2344         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2345
2346 2017-05-25  Jer Noble  <jer.noble@apple.com>
2347
2348         System sleeps while playing to wireless target, ending stream.
2349         https://bugs.webkit.org/show_bug.cgi?id=172541
2350
2351         Reviewed by Eric Carlson.
2352
2353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2354         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
2355         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
2356         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2357         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2358         (TestWebKitAPI::simulateKeyDown):
2359         (TestWebKitAPI::hasAssertionType):
2360         (TestWebKitAPI::TEST):
2361
2362 2017-05-25  Commit Queue  <commit-queue@webkit.org>
2363
2364         Unreviewed, rolling out r217423 and r217424.
2365         https://bugs.webkit.org/show_bug.cgi?id=172607
2366
2367         These caused an api failure on all testers. (Requested by
2368         mlewis13 on #webkit).
2369
2370         Reverted changesets:
2371
2372         "REGRESSION (r216977): 4 leaks introduced in new
2373         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
2374         https://bugs.webkit.org/show_bug.cgi?id=172558
2375         http://trac.webkit.org/changeset/217423
2376
2377         "REGRESSION (r217423): Fix last-second typo in 'auto'"
2378         http://trac.webkit.org/changeset/217424
2379
2380 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
2381
2382         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
2383         https://bugs.webkit.org/show_bug.cgi?id=172355
2384
2385         Reviewed by Chris Fleizach.
2386
2387         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
2388         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
2389         releases which support the new platform footnote accessibility role.
2390
2391         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2392         * gtk/jhbuild.modules:
2393
2394 2017-05-25  David Kilzer  <ddkilzer@apple.com>
2395
2396         REGRESSION (r217423): Fix last-second typo in 'auto'
2397
2398         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2399         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
2400
2401 2017-05-24  David Kilzer  <ddkilzer@apple.com>
2402
2403         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
2404         <https://webkit.org/b/172558>
2405
2406         Reviewed by Sam Weinig.
2407
2408         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2409         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
2410
2411 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2412
2413         [CMake] Consolidate CMake code related to Cairo
2414         https://bugs.webkit.org/show_bug.cgi?id=172568
2415
2416         Reviewed by Alex Christensen.
2417
2418         * DumpRenderTree/config.h:
2419         * TestWebKitAPI/config.h:
2420
2421 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2422
2423         Plumb additional image metadata to item providers when beginning data interaction on an image
2424         https://bugs.webkit.org/show_bug.cgi?id=172536
2425         <rdar://problem/32371300>
2426
2427         Reviewed by Beth Dakin.
2428
2429         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
2430         source item providers.
2431
2432         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2433         (checkSuggestedNameAndEstimatedSize):
2434         (TestWebKitAPI::TEST):
2435
2436 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2437
2438         [Win] Create unique network storage session for each DRT.
2439         https://bugs.webkit.org/show_bug.cgi?id=172540
2440
2441         Reviewed by Brent Fulgham.
2442
2443         During layout testing, each DRT instance should have its own network storage session.
2444
2445         * DumpRenderTree/win/DumpRenderTree.cpp:
2446         (prepareConsistentTestingEnvironment):
2447
2448 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         Respect image UTIs when writing to item providers when beginning data interaction on an image
2451         https://bugs.webkit.org/show_bug.cgi?id=172436
2452         <rdar://problem/31786569>
2453
2454         Reviewed by Beth Dakin.
2455
2456         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
2457         details.
2458
2459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2460         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
2461         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
2462
2463         Create a new test page containing a GIF and a file input.
2464
2465         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2466         (checkTypeIdentifierIsRegisteredAtIndex):
2467         (TestWebKitAPI::TEST):
2468
2469 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
2470
2471         [Win] Increase test timeout for slow tests.
2472         https://bugs.webkit.org/show_bug.cgi?id=172449
2473
2474         Reviewed by Alexey Proskuryakov.
2475
2476         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
2477         timeout member in the TestRunner class.
2478
2479         * DumpRenderTree/win/TestRunnerWin.cpp:
2480         (TestRunner::setWaitToDump):
2481
2482 2017-05-15  Matt Rajca  <mrajca@apple.com>
2483
2484         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
2485         https://bugs.webkit.org/show_bug.cgi?id=172138
2486
2487         Reviewed by Alex Christensen.
2488
2489         Added API tests.
2490
2491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2492         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
2493         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2494         (TEST):
2495         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
2496
2497 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2498
2499         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2500         https://bugs.webkit.org/show_bug.cgi?id=172522
2501         rdar://problem/31071812
2502
2503         Reviewed by Sam Weinig.
2504
2505         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
2506         We set this in the .xib file now.
2507
2508         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2509
2510 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2511
2512         Snapshotting via -renderInContext: should do synchronous image decodes
2513         https://bugs.webkit.org/show_bug.cgi?id=172485
2514         rdar://problem/32276146
2515
2516         Reviewed by Tim Horton.
2517
2518         New API test.
2519
2520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2521         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
2522         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2523         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2524         (TestWebKitAPI::getPixelIndex):
2525         (TestWebKitAPI::TEST):
2526
2527 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2528
2529         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2530         https://bugs.webkit.org/show_bug.cgi?id=172517
2531
2532         Rubber-stamped by Simon Fraser.
2533
2534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2535
2536 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2537
2538         Multiple links should be inserted separately when performing data interaction
2539         https://bugs.webkit.org/show_bug.cgi?id=172489
2540         <rdar://problem/31510832>
2541
2542         Reviewed by Dan Bernstein.
2543
2544         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
2545
2546         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2547         (TestWebKitAPI::TEST):
2548
2549 2017-05-23  Tim Horton  <timothy_horton@apple.com>
2550
2551         REGRESSION: API test WebKit2.WKObject is failing
2552         https://bugs.webkit.org/show_bug.cgi?id=172497
2553         <rdar://problem/31694641>
2554
2555         Reviewed by Geoff Garen.
2556
2557         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2558         (TestWebKitAPI::TEST):
2559         Add a test that ensures that we pretend to at least be *some* kind of
2560         NSString, which my first fix would not have passed.
2561
2562 2017-05-23  youenn fablet  <youenn@apple.com>
2563
2564         There should be an easy way to run HTTP/WPT served tests on a browser
2565         https://bugs.webkit.org/show_bug.cgi?id=172068
2566
2567         Reviewed by Sam Weinig.
2568
2569         Adding a new script open-layout-test to open a layout-test in a
2570         browser and making sure it is served as done through run-webkit-tests.
2571         In case tests should be run using a server, detecting whether the
2572         server are running. If not, calling run-webkit-httpd to run the
2573         servers and open the URL in a browser.
2574         Otherwise, open directly the URL.
2575
2576         Adding an option in run-webkit-httpd to open an URL after having
2577         started the servers.
2578
2579         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
2580         This allows running run-webkit-httpd once and not having to restart
2581         servers everytime a test should be served.
2582
2583         Moving most of run-webkit-httpd logic in its own python file to reuse
2584         it in open-layout-test script.
2585
2586         Adding routines to check whether HTTP and WPT servers are running.
2587
2588         * Scripts/open-layout-test: Added.
2589         (parse_args):
2590         (main):
2591         * Scripts/run-webkit-httpd:
2592         (main):
2593         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2594         (LayoutTestFinder.find_tests):
2595         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2596         (LayoutTestRunner.run_tests):
2597         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2598         (parse_args):
2599         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2600         (HttpServerBase._is_server_running_on_all_ports):
2601         (HttpServerBase):
2602         (HttpServerBase._is_running_on_port):
2603         (HttpServerBase._check_that_all_ports_are_available):
2604         (is_http_server_running):
2605         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
2606         (parse_args):
2607         (main):
2608         (run_server):
2609         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2610         (is_wpt_server_running):
2611         * Scripts/webkitpy/port/base.py:
2612         (Port.to.is_http_server_running):
2613         (Port.to):
2614         (Port.to.is_wpt_server_running):
2615         (Port.to.start_web_platform_test_server):
2616         * Scripts/webkitpy/port/driver.py:
2617         (DriverProxy.is_web_platform_test):
2618         (DriverProxy):
2619         (DriverProxy.is_webkit_specific_web_platform_test):
2620
2621 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2622
2623         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2624         https://bugs.webkit.org/show_bug.cgi?id=171984
2625
2626         Reviewed by Antti Koivisto.
2627
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (enableExperimentalFeatures):
2630         * WebKitTestRunner/TestController.cpp:
2631         (WTR::TestController::resetPreferencesToConsistentValues):
2632
2633 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2634
2635         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
2636         https://bugs.webkit.org/show_bug.cgi?id=172406
2637         <rdar://32109532>
2638
2639         Reviewed by Brady Eidson.
2640
2641         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2642         (TestWebKitAPI::checkBuffer):
2643         (TestWebKitAPI::TEST_F):
2644
2645 2017-05-22  Jason Marcell  <jmarcell@apple.com>
2646
2647         Do not enter Subversion-specific logic when parsing Git-based Trac data.
2648         https://bugs.webkit.org/show_bug.cgi?id=172433
2649         <rdar://problem/32234188>
2650
2651         Reviewed by Alexey Proskuryakov.
2652
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2654         (Trac.prototype._convertCommitInfoElementToObject):
2655
2656 2017-05-22  Tim Horton  <timothy_horton@apple.com>
2657
2658         ExplicitSnapshotsChangeUponNavigation API test often fails
2659         https://bugs.webkit.org/show_bug.cgi?id=172475
2660         <rdar://problem/31688322>
2661
2662         Reviewed by Simon Fraser.
2663
2664         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2665         (-[TestWKWebView _setUpTestWindow:]):
2666         Make TestWKWebView's window layer-backed. This is now the default,
2667         and it's also easy to accidentally write a test that depends on it
2668         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
2669         which becomes layer backed, just like the WKWebView, but with no
2670         common layer-backed ancestor).
2671
2672 2017-05-22  youenn fablet  <youenn@apple.com>
2673
2674         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
2675         https://bugs.webkit.org/show_bug.cgi?id=172426
2676
2677         Reviewed by Chris Dumez.
2678
2679         * Scripts/webkitpy/w3c/test_importer.py:
2680         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
2681
2682 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
2683
2684         Unreviewed, change my status to reviewer and fill "expertise" field
2685
2686         * Scripts/webkitpy/common/config/contributors.json:
2687
2688 2017-05-22  Tomas Popela  <tpopela@redhat.com>
2689
2690         Remove some of the EFL port leftovers
2691         https://bugs.webkit.org/show_bug.cgi?id=172440
2692
2693         Reviewed by Carlos Garcia Campos.
2694
2695         * BuildSlaveSupport/built-product-archive:
2696         (archiveBuiltProduct):
2697         (extractBuiltProduct):
2698         * BuildSlaveSupport/test-result-archive:
2699         (archiveTestResults):
2700         * ImageDiff/PlatformEfl.cmake: Removed.
2701         * Scripts/run-efl-tests: Removed.
2702         * Scripts/webkit-build-directory:
2703         * Scripts/webkitpy/common/config/contributionareas.py:
2704         * Scripts/webkitpy/common/config/watchlist:
2705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2706         (parse_args):
2707         (_set_up_derived_options):
2708         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2709         (PerfTestsRunner.__init__):
2710         * Scripts/webkitpy/style/checker.py:
2711         * Scripts/webkitpy/style/checker_unittest.py:
2712         (GlobalVariablesTest.test_path_rules_specifier):
2713         * gtk/manifest.txt.in:
2714         * jhbuild/jhbuild-wrapper:
2715
2716 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         Unreviewed. Do not include WPE files in GTK+ tarballs.
2719
2720         * gtk/manifest.txt.in:
2721
2722 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2723
2724         [GTK] Add webkit_context_menu_item_new_from_gaction
2725         https://bugs.webkit.org/show_bug.cgi?id=159631
2726
2727         Reviewed by Michael Catanzaro.
2728
2729         Update context menu tests to check the new GAction API.
2730
2731         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2732         (testContextMenuPopulateMenu):
2733
2734 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2735
2736         [GTK] Remove Firefox user agent quirk for Google domains
2737         https://bugs.webkit.org/show_bug.cgi?id=171941
2738
2739         Reviewed by Carlos Garcia Campos.
2740
2741         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2742         (TestWebKitAPI::TEST):
2743         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
2744
2745 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
2746
2747         [GTK] gtkdoc-fixxref needs --module argument to work
2748         https://bugs.webkit.org/show_bug.cgi?id=172415
2749
2750         Reviewed by Michael Catanzaro.
2751
2752         * gtk/gtkdoc.py:
2753         (GTKDoc._run_gtkdoc_fixxref):
2754
2755 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
2756
2757         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
2758         https://bugs.webkit.org/show_bug.cgi?id=172416
2759
2760         Reviewed by Daniel Bates.
2761
2762         * Scripts/make-new-script-test:
2763
2764 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2765
2766         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
2767         https://bugs.webkit.org/show_bug.cgi?id=172267
2768
2769         Reviewed by Per Arne Vollan.
2770
2771         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
2772         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
2773         should link only with WebKit.
2774
2775         Unfortunately, there is a layer violation at the moment.
2776         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
2777         in WebKit. This change contains a stub of loadResourceIntoBuffer
2778         in TestWebCoreLib for the workaround.
2779
2780         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
2781         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
2782         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
2783         (loadResourceIntoBuffer): Added a stub.
2784
2785 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
2786
2787         Fix dump-class-layout to handle different file architectures
2788         https://bugs.webkit.org/show_bug.cgi?id=172392
2789
2790         Reviewed by Zalan Bujtas.
2791
2792         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
2793         and use the first architecture reported. Also add a "--architecture" argument
2794         to allow the user to specify an architecture.
2795
2796         * Scripts/dump-class-layout:
2797         (import_lldb):
2798         (verify_type_recursive):
2799         (get_first_file_architecture):
2800         (dump_class):
2801         (main):
2802         (find_build_directory): Deleted.
2803
2804 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2805
2806         Unreviewed infrastructure fix.
2807
2808         * Scripts/webkitpy/port/ios_simulator.py:
2809         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
2810
2811 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2812
2813         webkitpy: Use simctl boot to run multiple simulators at once
2814         https://bugs.webkit.org/show_bug.cgi?id=172374
2815
2816         Reviewed by Alexey Proskuryakov.
2817
2818         * Scripts/webkitpy/common/system/platforminfo.py:
2819         (PlatformInfo.xcode_version): Return the current version of Xcode.
2820         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2821         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
2822         * Scripts/webkitpy/port/ios_simulator.py:
2823         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
2824         run multiple Simulator.app instances.
2825         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
2826         versions of Xcode.
2827         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
2828         an older version of Xcode.
2829
2830 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2831
2832         Unreviewed, fix the build on the latest internal SDK.
2833
2834         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2835         (TestWebKitAPI::TEST):
2836
2837 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
2838
2839         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
2840         https://bugs.webkit.org/show_bug.cgi?id=172369
2841
2842         Reviewed by Mark Lam.
2843         
2844         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
2845         would be a good idea to write this down.
2846
2847         * Scripts/run-jsc-stress-tests:
2848
2849 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2850
2851         webkitpy: Layout tests which have no output will succeed
2852         https://bugs.webkit.org/show_bug.cgi?id=172322
2853         <rdar://problem/32258350>
2854
2855         Reviewed by David Kilzer.
2856
2857         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2858         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
2859         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2860         (determine_result_type): FailureNotTested means that the test could not be loaded. This
2861         is classified as a MISSING failure.
2862         (FailureNotTested): Added.
2863         (FailureNotTested.message):
2864
2865 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2866
2867         Add SixSpeed benchmark to PerformanceTests
2868         https://bugs.webkit.org/show_bug.cgi?id=172326
2869
2870         Reviewed by Sam Weinig.
2871
2872         * Scripts/run-jsc-benchmarks:
2873
2874 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2875
2876         [WK1] MiniBrowser should navigate when handling a dropped URL
2877         https://bugs.webkit.org/show_bug.cgi?id=172350
2878
2879         Reviewed by Tim Horton.
2880
2881         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
2882
2883         * MiniBrowser/mac/WK1BrowserWindowController.m:
2884         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2885
2886 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
2887
2888         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
2889         https://bugs.webkit.org/show_bug.cgi?id=172077
2890
2891         Reviewed by Chris Dumez.
2892
2893         Fixed perftest.py by updating the lines to ignore in Speedometer.
2894
2895         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
2896
2897         * Scripts/webkitpy/performance_tests/perftest.py:
2898         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
2899         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2900         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
2901         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
2902         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2903         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
2904
2905 2017-05-18  Andy Estes  <aestes@apple.com>
2906
2907         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
2908         https://bugs.webkit.org/show_bug.cgi?id=172305
2909
2910         Reviewed by Anders Carlsson.
2911
2912         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2913
2914 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2915
2916         Selection around attachment elements should not persist when beginning a drag
2917         https://bugs.webkit.org/show_bug.cgi?id=172319
2918         <rdar://problem/32283008>
2919
2920         Reviewed by Tim Horton.
2921
2922         Tests that temporary selection around an attachment does not persist longer than it needs to.
2923
2924         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2925         (TestWebKitAPI::TEST):
2926
2927 2017-05-18  John Wilander  <wilander@apple.com>
2928
2929         Resource Load Statistics: Grandfather domains for existing data records
2930         https://bugs.webkit.org/show_bug.cgi?id=172155
2931         <rdar://problem/24913532>
2932
2933         Reviewed by Alex Christensen.
2934
2935         Adds test infrastructure needed for the added functionality.
2936
2937         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2938         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2939         (WTR::InjectedBundle::didReceiveMessageToPage):
2940         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2941         (WTR::TestRunner::setStatisticsGrandfathered):
2942         (WTR::TestRunner::isStatisticsGrandfathered):
2943         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2944         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2945         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2946         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::setStatisticsGrandfathered):
2949         (WTR::TestController::isStatisticsGrandfathered):
2950         (WTR::TestController::setStatisticsGrandfatheringTime):
2951         * WebKitTestRunner/TestController.h:
2952         * WebKitTestRunner/TestInvocation.cpp:
2953         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2954
2955 2017-05-18  Saam Barati  <sbarati@apple.com>
2956
2957         WebAssembly: perform stack checks
2958         https://bugs.webkit.org/show_bug.cgi?id=165546
2959         <rdar://problem/29760307>
2960
2961         Reviewed by Filip Pizlo.
2962
2963         Add some new testing modes for using and not using fast TLS wasm contexts.
2964
2965         * Scripts/run-jsc-stress-tests:
2966
2967 2017-05-18  Daniel Bates  <dabates@apple.com>
2968
2969         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
2970         window CSP when object-src 'none' is set
2971         https://bugs.webkit.org/show_bug.cgi?id=172038
2972         <rdar://problem/32258262>
2973
2974         Reviewed by Andy Estes.
2975
2976         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
2977         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
2978
2979         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2980         (NPP_New):
2981
2982 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
2983
2984         [Win] Many layout tests are failing.
2985         https://bugs.webkit.org/show_bug.cgi?id=172286
2986
2987         Reviewed by Brent Fulgham.
2988
2989         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
2990  
2991         * DumpRenderTree/win/TestRunnerWin.cpp:
2992         (TestRunner::grantWebNotificationPermission):
2993         (TestRunner::denyWebNotificationPermission):
2994         (TestRunner::removeAllWebNotificationPermissions):
2995         (TestRunner::simulateWebNotificationClick):
2996
2997 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
2998
2999         [Win] Remove usage of _snprintf
3000         https://bugs.webkit.org/show_bug.cgi?id=172251
3001
3002         Reviewed by Per Arne Vollan.
3003
3004         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3005         * MiniBrowser/win/PageLoadTestClient.cpp:
3006         (PageLoadTestClient::dumpRunStatistics):
3007
3008 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3009
3010         Unreviewed, rolling out r217014.
3011
3012         This change caused mac-wk2 LayoutTests to exit early due to
3013         crashes.
3014
3015         Reverted changeset:
3016
3017         "Resource Load Statistics: Grandfather domains for existing
3018         data records"
3019         https://bugs.webkit.org/show_bug.cgi?id=172155
3020         http://trac.webkit.org/changeset/217014
3021
3022 2017-05-17  John Wilander  <wilander@apple.com>
3023
3024         Resource Load Statistics: Grandfather domains for existing data records
3025         https://bugs.webkit.org/show_bug.cgi?id=172155
3026         <rdar://problem/24913532>
3027
3028         Reviewed by Alex Christensen.
3029
3030         Adds test infrastructure needed for the added functionality.
3031
3032         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3033         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3034         (WTR::InjectedBundle::didReceiveMessageToPage):
3035         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3036         (WTR::TestRunner::setStatisticsGrandfathered):
3037         (WTR::TestRunner::isStatisticsGrandfathered):
3038         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3039         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3040         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3041         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3042         * WebKitTestRunner/TestController.cpp:
3043         (WTR::TestController::setStatisticsGrandfathered):
3044         (WTR::TestController::isStatisticsGrandfathered):
3045         (WTR::TestController::setStatisticsGrandfatheringTime):
3046         * WebKitTestRunner/TestController.h:
3047         * WebKitTestRunner/TestInvocation.cpp:
3048         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3049
3050 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3051
3052         Fix ios-simulator API test after r216977
3053         https://bugs.webkit.org/show_bug.cgi?id=171987
3054
3055         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3056         (TEST):
3057         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
3058         not as urgent as having the rest of this working. Notably the ephemeral part of the
3059         test works, so something is just wrong with the persistent part.
3060
3061 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3062
3063         Unreviewed, rolling out r216955.
3064
3065         This change caused strange behavior with web-platform-tests
3066         locally and on EWS.
3067
3068         Reverted changeset:
3069
3070         "webkitpy: Start servers before setting-up for testing"
3071         https://bugs.webkit.org/show_bug.cgi?id=172176
3072         http://trac.webkit.org/changeset/216955
3073
3074 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3075
3076         A URL type is vended for a non-URL plain text string when starting data interaction
3077         https://bugs.webkit.org/show_bug.cgi?id=172228
3078         <rdar://problem/32166729>
3079
3080         Reviewed by Andy Estes.
3081
3082         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
3083         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
3084         still vended when beginning data interaction on something that resembles a link.
3085
3086         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3087
3088 2017-05-17  David Kilzer  <ddkilzer@apple.com>
3089
3090         BlobDataFileReference::generateReplacementFile() should use mkstemp()
3091         <https://webkit.org/b/172192>
3092
3093         Reviewed by Brent Fulgham.
3094
3095         * Scripts/webkitpy/style/checkers/cpp.py:
3096         (check_language): Add check for mktemp.
3097         (CppChecker): Add 'security/temp_file' category.
3098         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3099         (CppStyleTest.test_insecure_temp_file): Add test.
3100
3101 2017-05-17  Devin Rousso  <drousso@apple.com>
3102
3103         Unreviewed, change my email.
3104
3105         * Scripts/webkitpy/common/config/contributors.json:
3106
3107 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3108
3109         Unreviewed, rolling out r216974.
3110
3111         Revision caused consistent timeouts on all platforms.
3112
3113         Reverted changeset:
3114
3115         "Add a RuntimeEnabledFeature for display: contents, defaulted
3116         to false."
3117         https://bugs.webkit.org/show_bug.cgi?id=171984
3118         http://trac.webkit.org/changeset/216974
3119
3120 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3121
3122         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
3123         https://bugs.webkit.org/show_bug.cgi?id=171987
3124
3125         Reviewed by Brady Eidson.
3126
3127         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3128         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3129         (TEST):
3130
3131 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3132
3133         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3134         https://bugs.webkit.org/show_bug.cgi?id=171984
3135
3136         Reviewed by Antti Koivisto.
3137
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (enableExperimentalFeatures):
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::TestController::resetPreferencesToConsistentValues):
3142
3143 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
3144
3145         Fix the build
3146
3147         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3148         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3149
3150 2017-05-16  Tim Horton  <timothy_horton@apple.com>
3151
3152         PageVisibilityStateWithWindowChanges tests sometimes time out
3153         https://bugs.webkit.org/show_bug.cgi?id=172202
3154         <rdar://problem/29653266>
3155
3156         Reviewed by Dean Jackson.
3157
3158         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3159         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3160         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
3161
3162 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
3163
3164         webkitpy: Start servers before setting-up for testing
3165         https://bugs.webkit.org/show_bug.cgi?id=172176
3166         <rdar://problem/32225538>
3167
3168         Reviewed by Alexey Proskuryakov.
3169
3170         On-device testing requires that servers are started before ports set-up their
3171         test environments.
3172
3173         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3174         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3175         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
3176         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3177         (Manager.__init__): Delay construction of the test runner until we can determine
3178         if servers need to be started.
3179         (Manager.run): Determine if servers need to be started and construct the test runner.
3180         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3181
3182 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
3183
3184         Unreviewed, adding myself to contributors.json
3185
3186         * Scripts/webkitpy/common/config/contributors.json:
3187
3188 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
3189
3190         [GTK] Tests that always pass when run alone, but fail in the bots
3191         https://bugs.webkit.org/show_bug.cgi?id=168572
3192
3193         Reviewed by Michael Catanzaro.
3194
3195         PlatformWebView::viewSupportsOptions() is basically a comparison
3196         that checks that the passed options are the ones supported by the
3197         web view. There is no reason for them to be implemented for each
3198         platform differently. In fact doing so causes issues each time a
3199         new option is added, if the corresponding platform implementation
3200         is not updated accordingly.
3201
3202         A consequence of not updating the viewSupportOptions()
3203         implementations when new options are added is that tests that need
3204         these options might fail if they are executed after a test that
3205         didn't need the option, as the webview will be reused even if the
3206         option is not supported. This cannot be spotted when running the
3207         tests individually. See bug #165133 for other example of the same
3208         problem.
3209
3210         Remove the platform implementations and make the comparison a
3211         method of the TestOptions structure, so that the check is in one
3212         place. For the time being, only include in the comparison the
3213         options that were checked in the mac platform, which seem to be
3214         the only ones relevant this far (unless newer ones have also been
3215         forgotten).
3216
3217         * WebKitTestRunner/PlatformWebView.h:
3218         (WTR::PlatformWebView::viewSupportsOptions): Use the method
3219         defined below.
3220         * WebKitTestRunner/TestOptions.h:
3221         (WTR::TestOptions::hasSameInitializationOptions): Added.
3222         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3223         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3224         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3225         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3226         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3227         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3228         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3229         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3230
3231 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
3232
3233         [JSC] Build testapi in non Apple ports
3234         https://bugs.webkit.org/show_bug.cgi?id=172103
3235
3236         Reviewed by Filip Pizlo.
3237
3238         Now testapi is drived in JSCOnly, GTK and WPE ports too.
3239
3240         * Scripts/build-jsc:
3241         * Scripts/run-javascriptcore-tests:
3242
3243 2017-05-15  Youenn Fablet  <youenn@apple.com>
3244
3245         WPT test importer should not account for slow manual tests
3246         https://bugs.webkit.org/show_bug.cgi?id=172127
3247
3248         Reviewed by Ryosuke Niwa.
3249
3250         Making sure manual tests are not triggering updating tests-options.json file.
3251
3252         * Scripts/webkitpy/w3c/test_importer.py:
3253         (TestImporter.find_importable_tests):
3254         (TestImporter._already_identified_as_resource_file):
3255         (TestImporter.update_tests_options):
3256         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3257         (test_manual_slow_test):
3258
3259 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
3260
3261         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
3262         https://bugs.webkit.org/show_bug.cgi?id=172142
3263
3264         Reviewed by Tim Horton.
3265
3266         * Scripts/webkitpy/xcode/simulator.py:
3267         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
3268         around runtime identifiers.
3269         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
3270
3271 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3272
3273         Update ARES-6 plan file to use the latest version
3274         https://bugs.webkit.org/show_bug.cgi?id=172139
3275
3276         Reviewed by Keith Miller.
3277
3278         Include r216538.
3279
3280         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3281
3282 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
3283
3284         Disable Picture In Picture API tests on unsupported platforms.
3285         https://bugs.webkit.org/show_bug.cgi?id=172125
3286         rdar://problem/32199477
3287
3288         Reviewed by Simon Fraser.
3289
3290         The callbacks and allowing picture-in-picture require new SPI.
3291
3292         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3293
3294 2017-05-15  Brady Eidson  <beidson@apple.com>
3295
3296         [ios-simulator] API test WKWebView.ClearAppCache is failing.
3297         https://bugs.webkit.org/show_bug.cgi?id=172120
3298
3299         Unreviewed test gardening.
3300
3301         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3302         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
3303           Restoring that code fixes this.
3304
3305 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
3306
3307         Null deref under WebContentReader::readURL when interacting with a file URL
3308         https://bugs.webkit.org/show_bug.cgi?id=172045
3309         <rdar://problem/25880647>
3310
3311         Reviewed by Wenson Hsieh.
3312
3313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3314         (TestWebKitAPI::TEST):
3315         The text of the file URL is pasted because a textual version of it gets
3316         onto the pasteboard. However, this test would have crashed before. Also
3317         tests that we don't make an <a>.
3318
3319 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3320
3321         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3322         https://bugs.webkit.org/show_bug.cgi?id=172071
3323
3324         Reviewed by Alexey Proskuryakov.
3325
3326         * DumpRenderTree/win/DumpRenderTree.cpp:
3327         (resetWebPreferencesToConsistentValues):
3328
3329 2017-05-14  Chris Dumez  <cdumez@apple.com>
3330
3331         Drop PassRefPtr class from WTF
3332         https://bugs.webkit.org/show_bug.cgi?id=172091
3333
3334         Reviewed by Alex Christensen.
3335
3336         Drop API test coverage.
3337
3338         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3339         (TestWebKitAPI::TEST):
3340         (TestWebKitAPI::passWithPassRefPtr): Deleted.
3341
3342 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
3343
3344         [MediaStream] deviceId constraint doesn't work with getUserMedia
3345         https://bugs.webkit.org/show_bug.cgi?id=171877
3346         <rdar://problem/31899730>
3347
3348         Reviewed by Jer Noble.
3349
3350         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
3351         implement the "checkUserMediaPermission" callback.
3352         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3353         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3354         (TestWebKitAPI::checkUserMediaPermissionCallback):
3355         (TestWebKitAPI::TEST):
3356
3357         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
3358         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3359
3360 2017-05-13  Chris Dumez  <cdumez@apple.com>
3361
3362         Stop using RefPtr::release()
3363         https://bugs.webkit.org/show_bug.cgi?id=172074
3364
3365         Reviewed by Geoffrey Garen.
3366
3367         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3368         (TestWebKitAPI::TEST):
3369
3370 2017-05-13  Commit Queue  <commit-queue@webkit.org>
3371
3372         Unreviewed, rolling out r216808.
3373         https://bugs.webkit.org/show_bug.cgi?id=172075
3374
3375         caused lldb to hang when debugging (Requested by smfr on
3376         #webkit).
3377
3378         Reverted changeset:
3379
3380         "Use Mach exceptions instead of signals where possible"
3381         https://bugs.webkit.org/show_bug.cgi?id=171865
3382         http://trac.webkit.org/changeset/216808
3383
3384 2017-05-12  Alex Christensen  <achristensen@webkit.org>
3385
3386         Rename WKContentExtension to WKContentRuleList
3387         https://bugs.webkit.org/show_bug.cgi?id=172053
3388         <rdar://problem/32141005>
3389
3390         Reviewed by Geoffrey Garen.
3391
3392         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
3393         (WKContentRuleListStoreTest::SetUp):
3394         (TEST_F):
3395         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3396         (WKContentExtensionStoreTest::SetUp): Deleted.
3397         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3398
3399 2017-05-12  Keith Miller  <keith_miller@apple.com>
3400
3401         Use Mach exceptions instead of signals where possible
3402         https://bugs.webkit.org/show_bug.cgi?id=171865
3403
3404         Reviewed by Mark Lam.
3405
3406         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3407         (runThreadMessageTest):
3408         (TEST):
3409
3410 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3411
3412         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
3413         https://bugs.webkit.org/show_bug.cgi?id=172048
3414         rdar://problem/32163054
3415
3416         Reviewed by Simon Fraser.
3417
3418         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
3419
3420         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
3421         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3422         (hasVideoInPictureInPictureDidChange):
3423         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
3424         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
3425         (TestWebKitAPI::TEST):
3426
3427 2017-05-12  Brady Eidson  <beidson@apple.com>
3428
3429         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3430         https://bugs.webkit.org/show_bug.cgi?id=172030
3431
3432         Unreviewed - Test gardening
3433
3434         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
3435         before the test starts.
3436
3437         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3438         (defaultWebsiteCacheDirectory):
3439         (defaultApplicationCacheDirectory):
3440         (TEST):
3441         (defaultWebsiteDataDirectory): Deleted.
3442
3443 2017-05-12  David Quesada  <david_quesada@apple.com>
3444
3445         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
3446         https://bugs.webkit.org/show_bug.cgi?id=172000
3447         rdar://problem/32144756
3448
3449         Reviewed by Simon Fraser.
3450
3451         Added API tests to verify that WKWebView provides the expected value for
3452         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
3453         inside a scrollview but not clipped, clipped by an ancestor scrollview,
3454         clipped by the webview's _enclosingViewForExposedRectComputation)
3455
3456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3457         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
3458         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
3459         (TestWebKitAPI::TEST):
3460
3461 2017-05-12  Brady Eidson  <beidson@apple.com>
3462
3463         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3464         https://bugs.webkit.org/show_bug.cgi?id=172030
3465
3466         Unreviewed - Test gardening, in effect...
3467
3468         More exploration as to why this continues to fail on the bots.
3469         
3470         This change should give us a smoking gun.
3471         
3472         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3473         (TEST):
3474
3475 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3476
3477         [GTK] Fix compile warnings in PlatformImageCairo.cpp
3478         https://bugs.webkit.org/show_bug.cgi?id=171850
3479
3480         Reviewed by Michael Catanzaro.
3481
3482         * ImageDiff/cairo/PlatformImageCairo.cpp:
3483         (ImageDiff::PlatformImage::createFromStdin):
3484         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3485
3486 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3487
3488         Add UIClient callback for when picture-in-picture is activated.
3489         https://bugs.webkit.org/show_bug.cgi?id=172023
3490
3491         Reviewed by Simon Fraser.
3492
3493         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
3494
3495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3496         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
3497         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
3498         (onLoadedCompletedCallback):
3499         (waitUntilOnLoadIsCompleted):
3500         (didFinishLoadForFrame):
3501         (setHasVideoInPictureInPicture):
3502         (TestWebKitAPI::TEST):
3503
3504 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3505
3506         Unreviewed follow-up to r216776.
3507
3508         * Scripts/webkitpy/port/base.py:
3509         (Port.path_to_crash_logs): Raise not implemented.
3510         * Scripts/webkitpy/port/test.py:
3511         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
3512         * Scripts/webkitpy/port/win.py:
3513         (WinPort.path_to_crash_logs): Ditto.
3514
3515 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
3516
3517         Bot watcher's dashboard shows results links twice sometimes
3518         https://bugs.webkit.org/show_bug.cgi?id=172043
3519
3520         Reviewed by Tim Horton.
3521
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3523         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3524
3525 2017-05-12  Brady Eidson  <beidson@apple.com>
3526
3527         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3528         https://bugs.webkit.org/show_bug.cgi?id=172030
3529
3530         Unreviewed - Test gardening, in effect...
3531
3532         This failure is only being seen by the bots.
3533         
3534         I believe this test is utterly broken in the first place; when it checks the .wal file's
3535         size that is not actually an indicator that the records were deleted.
3536         
3537         But that isn't what's coming up as failure on the bots.
3538         
3539         This patch is an attempt to:
3540         1 - More forcefully clear the Website data directory of leftovers before the test starts.
3541         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
3542
3543         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3544         (defaultWebsiteDataDirectory):
3545         (defaultApplicationCacheDirectory):
3546         (TEST):
3547
3548 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3549
3550         webkitpy: Pass directory with crash logs into CrashLogs
3551         https://bugs.webkit.org/show_bug.cgi?id=172033
3552         <rdar://problem/32157616>
3553
3554         Reviewed by Daniel Bates.
3555
3556         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
3557         the location of crash logs.
3558
3559         * Scripts/webkitpy/common/system/crashlogs.py:
3560         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
3561         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
3562         generating one.
3563         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
3564         self._results_directory.
3565         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
3566         generating one.
3567         (CrashLogs._log_directory_darwin): Moved to port.
3568         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
3569         to the crash log is no longer owned by CrashLogs.
3570         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
3571         directory for uploading crash logs. Note that crash logs are only supported on Mac
3572         and Windows.
3573         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
3574         * Scripts/webkitpy/port/base.py:
3575         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
3576         to be in the results directory.
3577         * Scripts/webkitpy/port/darwin.py:
3578         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
3579         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
3580         (DarwinPort._get_crash_log): Ditto.
3581         * Scripts/webkitpy/port/darwin_testcase.py:
3582         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
3583         the path to crash logs.
3584         * Scripts/webkitpy/port/ios_device.py:
3585         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
3586         * Scripts/webkitpy/port/ios_device_unittest.py:
3587         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
3588         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
3589         * Scripts/webkitpy/port/mac.py: Ditto.
3590         * Scripts/webkitpy/port/test.py:
3591         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
3592         * Scripts/webkitpy/port/win.py:
3593         (WinPort._get_crash_log): Ditto.
3594         * Scripts/webkitpy/tool/commands/queries.py:
3595         (execute): Construct a port object since this is the object which owns the path to crash logs.
3596
3597 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3598
3599         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
3600
3601         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
3602         URL parameter using the default value "about:blank" when not provided.
3603
3604         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3605         (testWebViewCreateNavigationData):
3606
3607 2017-05-11  Youenn Fablet  <youenn@apple.com>
3608
3609         Allow WPT server to serve specific WebKit test
3610         https://bugs.webkit.org/show_bug.cgi?id=171479
3611
3612         Reviewed by Ryosuke Niwa.
3613
3614         Adding a new mount point to WPT server.
3615         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
3616
3617         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
3618
3619         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3620         (Manager.__init__):
3621         (Manager._is_http_test):
3622         (Manager._needs_web_platform_test):
3623         (Manager._run_tests):
3624         (Manager._is_web_platform_test): Deleted.
3625         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3626         (build_routes):
3627         (main):
3628         * Scripts/webkitpy/port/driver.py:
3629         (Driver):
3630         (Driver.is_webkit_specific_web_platform_test):
3631         (Driver.test_to_uri):
3632         (Driver._command_from_driver_input):
3633
3634 2017-05-11  Brady Eidson  <beidson@apple.com>
3635
3636         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
3637         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
3638
3639         Reviewed by Andy Estes.
3640         Informal review by Maureen Daum.
3641
3642         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3643         (TEST):
3644