4caf49a5d1dff691deb785be81004316527d03f1
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         [Qt] Remove Maemo specific code paths
4         https://bugs.webkit.org/show_bug.cgi?id=71476
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         * QtTestBrowser/launcherwindow.cpp:
9         (LauncherWindow::~LauncherWindow):
10         (LauncherWindow::init):
11         (LauncherWindow::showLinkHover):
12         (LauncherWindow::selectElements):
13         (LauncherWindow::showFPS):
14         (LauncherWindow::updateFPS):
15         * QtTestBrowser/launcherwindow.h:
16         (WindowOptions::WindowOptions):
17         * QtTestBrowser/locationedit.cpp:
18         * QtTestBrowser/locationedit.h:
19
20 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
21
22         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
23         https://bugs.webkit.org/show_bug.cgi?id=71461
24
25         Reviewed by Martin Robinson.
26
27         * MiniBrowser/gtk/BrowserWindow.c:
28         (resetEntryProgress): Reset the entry progress after a while when
29         load has been completed.
30         (webViewLoadProgressChanged): Update location entry progress.
31         (browserWindowConstructed): Connect to WebView
32         notify::estimated-load-progress signal.
33
34 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
35
36         [GTK] Remove WebKit2 C API from MiniBrowser
37         https://bugs.webkit.org/show_bug.cgi?id=71459
38
39         Reviewed by Martin Robinson.
40
41         Use the GTK+ API instead to add minimum functionality. The other
42         features will be ported to GTK+ API in following patches.
43
44         * MiniBrowser/gtk/BrowserWindow.c:
45         (activateUriEntryCallback): Use webkit_web_view_load_uri().
46         (goBackCallback): Use webkit_web_view_go_back().
47         (goForwardCallback): Use webkit_web_view_go_forward().
48         (webViewURIChanged): Update location entry with current uri using
49         webkit_web_view_get_uri().
50         (browserWindowFinalize):
51         (browserWindowGetProperty):
52         (browserWindowSetProperty):
53         (browser_window_init):
54         (browserWindowConstructed): Connect to notify::uri signal of
55         WebView to be notified when the URI changes.
56         (browser_window_class_init):
57         (browser_window_new): Use WebKitWebView.
58         (browser_window_get_view): Use WebKitWebView
59         * MiniBrowser/gtk/BrowserWindow.h:
60         * MiniBrowser/gtk/GNUmakefile.am:
61         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
62         * MiniBrowser/gtk/main.c:
63         (loadURI): Use webkit_web_view_new().
64         (main):
65
66 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
67
68         [Qt] Unable to start MiniBrowser after run-webkit-tests
69         https://bugs.webkit.org/show_bug.cgi?id=71469
70
71         Reviewed by Csaba Osztrogonác.
72
73         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
74         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
75         line arguments.
76
77 2011-11-03  Philippe Normand  <pnormand@igalia.com>
78
79         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
80         https://bugs.webkit.org/show_bug.cgi?id=71445
81
82         Reviewed by Martin Robinson.
83
84         * DumpRenderTree/gtk/DumpRenderTree.cpp:
85         (initializeFonts): set directoriesDescription only when needed.
86         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
87         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
88         refactored the font files loading code to avoid copy/pastes, ease
89         maintenance and future font directories additions.
90
91 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
92
93         [GTK] Remove GtkLauncher2
94         https://bugs.webkit.org/show_bug.cgi?id=71449
95
96         Reviewed by Martin Robinson.
97
98         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
99         made sense when we wanted to implement the exactly same wk1 API
100         for wk2. Now the code would require an ifdef for most the api, so
101         it's better to remove GtkLauncher2 and port MiniBrowser to the new
102         GTK+ API.
103
104         * GNUmakefile.am:
105         * GtkLauncher/main.c:
106         (notifyProgressCb):
107         (closeWebViewCb):
108         (createBrowser):
109         (addWebSettingsGroupToContext):
110         (main):
111
112 2011-11-02  Philippe Normand  <pnormand@igalia.com>
113
114         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
115         https://bugs.webkit.org/show_bug.cgi?id=71359
116
117         Reviewed by Martin Robinson.
118
119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
120         (initializeFonts): Add the new font path for Debian fonts and
121         refactored the font files loading code to avoid copy/pastes, ease
122         maintenance and future font directories additions.
123
124 2011-11-02  Eric Seidel  <eric@webkit.org>
125
126         Move Mocks into _mock files near their implementations
127         https://bugs.webkit.org/show_bug.cgi?id=71425
128
129         Reviewed by Adam Barth.
130
131         This entire change is splitting mocktool.py into separate _mock.py files
132         and placing them next to their real implementations.
133
134         I also deleted MockPortFactory (since it was wrong) and was just hiding
135         the fact that the "skipped-ports" command was broken (and has been for a long time).
136         So I made MockHost use a real PortFactory (passed a MockHost) and changed
137         the skipped-ports implementation to use modern PortFactory methods.
138
139         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
140         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
141         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
142         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
143         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
144         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
145         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
146         * Scripts/webkitpy/common/host.py:
147         * Scripts/webkitpy/common/host_mock.py: Added.
148         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
149         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
150         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
151         * Scripts/webkitpy/common/net/credentials_unittest.py:
152         * Scripts/webkitpy/common/net/failuremap_unittest.py:
153         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
154         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
155         * Scripts/webkitpy/common/net/statusserver_unittest.py:
156         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
157         * Scripts/webkitpy/common/system/executive.py:
158         * Scripts/webkitpy/common/system/executive_mock.py:
159         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
160         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
161         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
162         * Scripts/webkitpy/common/system/workspace_unittest.py:
163         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
164         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
165         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
166         * Scripts/webkitpy/layout_tests/port/__init__.py:
167         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
168         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
169         * Scripts/webkitpy/layout_tests/port/factory.py:
170         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
171         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
172         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
173         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
174         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
175         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
176         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
177         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
178         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
179         * Scripts/webkitpy/test/main.py:
180         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
181         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
182         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
183         * Scripts/webkitpy/tool/commands/queries_unittest.py:
184         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
185         * Scripts/webkitpy/tool/mocktool.py:
186         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
187
188 2011-11-02  Dan Bernstein  <mitz@apple.com>
189
190         Fixed the build and removed another copy to ColorBits.ttf.
191
192         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
193         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
194         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
195
196 2011-11-02  Dan Bernstein  <mitz@apple.com>
197
198         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
199         https://bugs.webkit.org/show_bug.cgi?id=71424
200
201         Reviewed by Sam Weinig.
202
203         Removed the ColorBits font and the code to register it in the process
204         running the tests. The font was only used by the aforementioned test,
205         which is now being removed.
206
207         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
208         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
209         * DumpRenderTree/mac/DumpRenderTree.mm:
210         (allowedFontFamilySet):
211         (activateTestingFonts):
212         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
213         (WTR::inititializeFontConfigSetting):
214         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
215         (WTR::allowedFontFamilySet):
216         (WTR::activateFonts):
217
218 2011-11-02  Dan Bernstein  <mitz@apple.com>
219
220         Fix an intermittent hang in RenderedImageFromDOMRange.
221
222         Reviewed by Anders Carlsson.
223
224         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
225         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
226         immediately if there are no sources by passing a date in the distant past.
227
228 2011-11-02  Adam Roben  <aroben@apple.com>
229
230         Add git-add-reviewer
231
232         I've been using this script for a while to add reviewers to git commits in my local
233         repository before pushing them to the Subversion repository. Basic usage is:
234
235         git-add-reviewer HEAD^ "Joe Schmoe"
236         or
237         git-add-reviewer -i trunk
238
239         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
240         git commits
241
242         Reviewed by Sam Weinig.
243
244         * Scripts/git-add-reviewer: Added.
245         (top level): Parse options, check that the working tree is clean, then run in either
246         interactive or non-interactive mode as appropriate.
247         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
248         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
249         editor exits, we check out the commit just before the earliest one we're modifying. Then
250         for each commit, we check it out, update the reviewer, and amend the commit to contain the
251         new reviewer. Finally, we update the branch that was originally checked out to point to the
252         last amended commit.
253         (nonInteractive): Check out the commit to modify, write the current commit message to the
254         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
255         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
256         a usage message and exit.
257         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
258         and index are clean.
259         (fail): Print out the specified error message, if any, and return false. This function is
260         used as a return value in various error cases throughout the script.
261         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
262         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
263         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
264         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
265
266         (addReviewerToChangeLog):
267         (addReviewerToCommitMessage):
268         These just call through to addReviewerToFile.
269
270         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
271         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
272         temp file, then move the temp file over the original file and stage it for the next commit.
273         (head): Returns the name of the currently-checked-out branch.
274         (isAncestor): Returns true if the first commit is an ancestor of the second.
275         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
276         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
277         (resetToCommit): Checks out the given commit, throwing away any local changes.
278         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
279         the specified file.
280         (rebaseOntoHead): Rebases the specified branch onto HEAD.
281         (checkout): Checks out the given commit.
282         (getConfigValue): Reads the specified config variable from git-config.
283
284 2011-11-02  Dean Jackson  <dino@apple.com>
285
286         Add ENABLE_CSS_SHADERS flag
287         https://bugs.webkit.org/show_bug.cgi?id=71394
288
289         Reviewed by Sam Weinig.
290
291         * Scripts/build-webkit:
292
293 2011-10-31  Eric Seidel  <eric@webkit.org>
294
295         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
296         https://bugs.webkit.org/show_bug.cgi?id=71237
297
298         Reviewed by Adam Barth.
299
300         Calling the static version of factory.get() with proper mocking
301         requires passsing an explict filesystem, executive, etc.
302         So instead, we use a PortFactory instance and pass it a Host pointer.
303         I had to add a MockHost since we'd not needed a non-host tool before now.
304
305         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
306         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
307         * Scripts/webkitpy/tool/commands/rebaseline.py:
308         * Scripts/webkitpy/tool/mocktool.py:
309
310 2011-11-02  Anders Carlsson  <andersca@apple.com>
311
312         Update for the WebKit2 API fixage.
313
314         * MiniBrowser/mac/BrowserWindowController.m:
315         (-[BrowserWindowController awakeFromNib]):
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::initialize):
318
319 2011-11-02  Anders Carlsson  <andersca@apple.com>
320
321         Fix build.
322
323         Add new functions to the page loader client.
324
325         * MiniBrowser/mac/BrowserWindowController.m:
326         (-[BrowserWindowController awakeFromNib]):
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::initialize):
329
330 2011-11-02  Dan Bernstein  <mitz@apple.com>
331
332         <rdar://problem/10336700> Add API to get rendered text image without having to select it
333         https://bugs.webkit.org/show_bug.cgi?id=71407
334
335         Reviewed by Simon Fraser.
336
337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
338         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
339         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
340         (TestWebKitAPI::TEST):
341
342 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
343
344         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
345         https://bugs.webkit.org/show_bug.cgi?id=71351
346
347         Reviewed by Darin Adler.
348
349         Add the delimiter "/" at the end of the path instead of adding +1 when using
350         the path.
351
352         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
353         (-[NSURL _drt_descriptionSuitableForTestResult]):
354
355 2011-11-02  Tom Sepez  <tsepez@chromium.org>
356
357         XSSAuditor is silent
358         https://bugs.webkit.org/show_bug.cgi?id=70973
359
360         Reviewed by Adam Barth.
361
362         * DumpRenderTree/chromium/WebViewHost.cpp:
363         (WebViewHost::didDetectXSS):
364         * DumpRenderTree/chromium/WebViewHost.h:
365         * DumpRenderTree/mac/FrameLoadDelegate.mm:
366         (-[FrameLoadDelegate webView:didDetectXSS:]):
367         * MiniBrowser/mac/BrowserWindowController.m:
368         (didDetectXSSForFrame):
369         (-[BrowserWindowController awakeFromNib]):
370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
371         (WTR::InjectedBundlePage::InjectedBundlePage):
372         (WTR::InjectedBundlePage::didDetectXSSForFrame):
373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
374
375 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
376
377         [Qt] REGRESSION: 5 editing tests fail
378         https://bugs.webkit.org/show_bug.cgi?id=71117
379
380         Reviewed by Andreas Kling.
381
382         Make sure that the view is properly focused, in order to get the
383         didBeginEditing DRT calls.
384
385         This requires activating the window (the call will result in a FocusIn
386         event to the window as well as setting QGuiApplication::focusWindow())
387         as well as enabling the focus on the view item. The signature of
388         setFocus has changed to take a boolean.
389
390         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
391         (WTR::WrapperWindow::handleStatusChanged):
392
393 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
394
395         [chromium] Add per-script font preferences support in overridePreference
396         https://bugs.webkit.org/show_bug.cgi?id=71110
397
398         This allows a layout test to do something like:
399
400         // Set standard font for Arabic to Ahem.
401         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
402
403         This should make writing a layout test for per-script fonts easier.
404
405         This change only affects the Chromium DumpRenderTree, but the other
406         platforms should probably also have a similar change eventually.
407
408         Reviewed by Tony Chang.
409
410         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
411         font preferences to overridePreference
412         (LayoutTestController::cppVariantToWebStringArray):
413         (setFontMap):
414         (LayoutTestController::overridePreference):
415         * DumpRenderTree/chromium/LayoutTestController.h:
416         * DumpRenderTree/chromium/WebPreferences.cpp:
417         (setStandardFontFamilyWrapper):
418         (setFixedFontFamilyWrapper):
419         (setSerifFontFamilyWrapper):
420         (setSansSerifFontFamilyWrapper):
421         (setCursiveFontFamilyWrapper):
422         (setFantasyFontFamilyWrapper):
423         (applyFontMap):
424         (WebPreferences::applyTo):
425         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
426         preference members
427         (WebPreferences::UScriptCodeHashTraits::emptyValue):
428         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
429         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
430
431 2011-11-02  Elliot Poger  <epoger@google.com>
432
433         until use_skia=1 by default on mac, default port should be chromium-cg-mac
434         https://bugs.webkit.org/show_bug.cgi?id=71312
435
436         Reviewed by Adam Barth.
437
438         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
439         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
440         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
441
442 2011-11-02  Stephen Chenney  <schenney@chromium.org>
443
444         printing layout test failures after r98634
445         https://bugs.webkit.org/show_bug.cgi?id=71080
446
447         Reviewed by Kent Tamura
448
449         * DumpRenderTree/chromium/WebViewHost.cpp:
450         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
451         matches that for Skia.
452
453 2011-11-01  Sam Weinig  <sam@webkit.org>
454
455         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
456         https://bugs.webkit.org/show_bug.cgi?id=71346
457
458         Reviewed by Dan Bernstein.
459
460         * Scripts/webkit-tools-completion.sh:
461         Add "-o default" which allows for completing files in addition to the word list.
462
463 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
464
465         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
466         https://bugs.webkit.org/show_bug.cgi?id=71310
467
468         Reviewed by Kenneth Rohde Christiansen.
469
470         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
471         define works in EventSendingController.idl
472         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
473         handlers.
474         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
475         required by tests.
476         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
477         ui process.
478         (WTR::EventSendingController::addTouchPoint):
479         (WTR::EventSendingController::updateTouchPoint):
480         (WTR::EventSendingController::setTouchModifier):
481         (WTR::EventSendingController::touchStart):
482         (WTR::EventSendingController::touchMove):
483         (WTR::EventSendingController::touchEnd):
484         (WTR::EventSendingController::clearTouchPoints):
485         (WTR::EventSendingController::releaseTouchPoint):
486         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
487         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
488         defines.
489         * WebKitTestRunner/TestController.cpp:
490         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
491         touch messages to the EventSenderProxy.
492         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
493         (WTR::EventSenderProxy::EventSenderProxy):
494         (WTR::EventSenderProxy::addTouchPoint):
495         (WTR::EventSenderProxy::updateTouchPoint):
496         (WTR::EventSenderProxy::setTouchModifier):
497         (WTR::EventSenderProxy::touchStart):
498         (WTR::EventSenderProxy::touchMove):
499         (WTR::EventSenderProxy::touchEnd):
500         (WTR::EventSenderProxy::clearTouchPoints):
501         (WTR::EventSenderProxy::releaseTouchPoint):
502         (WTR::EventSenderProxy::sendTouchEvent):
503         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
504
505 2011-11-01  Sam Weinig  <sam@webkit.org>
506
507         resolve-ChangeLogs --help should be faster.
508
509         Reviewed by Adam Roben.
510
511         * Scripts/resolve-ChangeLogs:
512         (usageAndExit):
513         Add a call to usageAndExit() before doing work to find unmerged changelogs
514         if --help or something illegal is provided on the command line.
515
516 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
517
518         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
519         https://bugs.webkit.org/show_bug.cgi?id=71342
520
521         Reviewed by Darin Adler.
522
523         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
524         [NSString substringFromIndex:] with an index out of the string range.
525
526         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
527         from the root of the disk.
528         The problem was hidden because the exception are catched when calling the delegate.
529
530         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
531         in a subdirectory of the main frame.
532
533         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
534         (-[NSURL _drt_descriptionSuitableForTestResult]):
535
536 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
537
538         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
539         https://bugs.webkit.org/show_bug.cgi?id=71318
540
541         Reviewed by James Robinson.
542         
543         Fixed a typo for --enable-hardware-gpu flag.
544
545         * Scripts/webkitpy/layout_tests/port/chromium.py:
546
547 2011-11-01  Elliot Poger  <epoger@google.com>
548
549         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
550         https://bugs.webkit.org/show_bug.cgi?id=71286
551
552         Reviewed by Stephen White.
553
554         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
555
556 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
557
558         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
559         https://bugs.webkit.org/show_bug.cgi?id=71299
560
561         Reviewed by Andreas Kling.
562
563         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
564         build to enable WebCoreTestSupport::injectInternalsObject.
565         (WTR::InjectedBundlePage::didClearWindowForFrame):
566         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
567
568 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
569
570         [Qt] Merge common desktop and touch view APIs under a base class.
571         https://bugs.webkit.org/show_bug.cgi?id=71280
572
573         Reviewed by Andreas Kling.
574
575         Remove unneded forwarding logic for TouchWebView since those properties are
576         now in the view just as the desktop web view.
577
578         * MiniBrowser/qt/qml/TouchView.qml:
579
580 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
581
582         check-webkit-style: Allow names starting with "_q_".
583         https://bugs.webkit.org/show_bug.cgi?id=70625
584
585         Reviewed by Tor Arne Vestbø.
586
587         Used by the Qt port as the standard prefix for private slots.
588
589         * Scripts/webkitpy/style/checkers/cpp.py:
590         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
591
592 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
593
594         [Qt][WK2] Fix valgrind error about uninitialized variable
595         https://bugs.webkit.org/show_bug.cgi?id=71273
596
597         Reviewed by Kenneth Christiansen.
598
599         * MiniBrowser/qt/MiniBrowserApplication.cpp:
600         (MiniBrowserApplication::notify): Initialize isPrimary.
601
602 2011-10-31  Adam Roben  <aroben@apple.com>
603
604         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
605
606         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
607         leaky builds
608
609         Reviewed by Anders Carlsson.
610
611         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
612         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
613         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
614         total of N bytes!").
615
616 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
617
618         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
619         https://bugs.webkit.org/show_bug.cgi?id=71228
620
621         Reviewed by Antonio Gomes.
622
623         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
624         (DumpRenderTreeChrome::createNewWindow):
625         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
626
627 2011-10-31  Eric Seidel  <eric@webkit.org>
628
629         webkitpy tests depend too much on the user's environment
630         https://bugs.webkit.org/show_bug.cgi?id=71234
631
632         Reviewed by Dirk Pranke.
633
634         This change just makes a bunch of our older tests use
635         more modern mocking to avoid trying to launch processes
636         or read from the user's filesystem during unittesting.
637
638         I found many of these by adding an assert in Executive.run_command
639         that we were not unittesting.  I can't add that assert always
640         as there are some valid uses of Executive during unittesting.
641         Once I fix more of these, I may find a way to add such an assert conditionally.
642
643         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
644         * Scripts/webkitpy/common/net/credentials_unittest.py:
645         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
646         * Scripts/webkitpy/layout_tests/port/base.py:
647         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
648
649 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
650
651         [Qt] MiniBrowser doesn't resize as the size is always overridden
652         https://bugs.webkit.org/show_bug.cgi?id=71212
653
654         Reviewed by Simon Hausmann.
655
656         Remove call overriden the size.
657
658         * MiniBrowser/qt/main.cpp:
659         (main):
660
661 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
662
663         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
664         http://trac.webkit.org/changeset/98819
665         http://trac.webkit.org/changeset/98823
666         http://trac.webkit.org/changeset/98825
667         http://trac.webkit.org/changeset/98830
668         https://bugs.webkit.org/show_bug.cgi?id=71199
669
670         Broke Chromium Windows bot (Requested by rniwa on #webkit).
671
672         * Scripts/webkitpy/layout_tests/port/base.py:
673         * Scripts/webkitpy/layout_tests/port/chromium.py:
674         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
675         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
676         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
677         * Scripts/webkitpy/layout_tests/port/efl.py:
678         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
679         * Scripts/webkitpy/layout_tests/port/mac.py:
680         * Scripts/webkitpy/layout_tests/port/qt.py:
681         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
682         * Scripts/webkitpy/layout_tests/port/webkit.py:
683         * Scripts/webkitpy/layout_tests/port/win.py:
684
685 2011-10-30  Eric Seidel  <eric@webkit.org>
686
687         new-run-webkit-tests is locale dependent
688         https://bugs.webkit.org/show_bug.cgi?id=68691
689
690         Unreviewed.
691
692         This is a temporary hack until someone from the cr-win port
693         can take a look and determine which environment variable
694         lighttpd is missing.
695
696         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
697
698 2011-10-30  Eric Seidel  <eric@webkit.org>
699
700         new-run-webkit-tests is locale dependent
701         https://bugs.webkit.org/show_bug.cgi?id=68691
702
703         Unreviewed.  I would have preferred to have this reviewed,
704         but relevant reviewers are asleep and bots are broken.
705
706         This was a regression from moving to a clean environment.
707         ChromiumWin (and possibly other ports), need the "PATH"
708         environment copied over.  This wasn't caught in my testing
709         because although we had unittests to cover this, they
710         weren't being run on anything but windows.  The vast majority
711         of this change is just fixing the unittests to use our
712         modern MockFileSystem/MockUser/MockExecutive so they can
713         be run on any system (and removing the platform checks from
714         the unittests so they are run everywhere).
715
716         The actual fix is the single line "PATH" string added to base.py.
717         The rest of this change is just fixing the Chromium port unittests
718         to run on all systems (including changing the Chromium port to
719         use FileSystem.path_to_module instead of __file__).
720
721         * Scripts/webkitpy/layout_tests/port/base.py:
722         * Scripts/webkitpy/layout_tests/port/chromium.py:
723         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
724         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
725         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
726         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
727
728 2011-10-29  Eric Seidel  <eric@webkit.org>
729
730         new-run-webkit-tests is locale dependent
731         https://bugs.webkit.org/show_bug.cgi?id=68691
732
733         Unreviewed.
734
735         Fix the Qt port and unittest the function so we don't break it again.
736
737         * Scripts/webkitpy/layout_tests/port/qt.py:
738         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
739
740 2011-10-29  Eric Seidel  <eric@webkit.org>
741
742         new-run-webkit-tests is locale dependent
743         https://bugs.webkit.org/show_bug.cgi?id=68691
744
745         Reviewed by Adam Barth.
746
747         Make NRWT use a clean environment just like ORWT did.
748         I've manually validated that NRWT now copies over
749         the same environment variables that ORWT did.
750         This new code is exercised by existing setup_environ_for_server tests.
751
752         * Scripts/webkitpy/layout_tests/port/base.py:
753         * Scripts/webkitpy/layout_tests/port/efl.py:
754         * Scripts/webkitpy/layout_tests/port/mac.py:
755         * Scripts/webkitpy/layout_tests/port/qt.py:
756         * Scripts/webkitpy/layout_tests/port/webkit.py:
757         * Scripts/webkitpy/layout_tests/port/win.py:
758
759 2011-10-29  Eric Seidel  <eric@webkit.org>
760
761         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
762         https://bugs.webkit.org/show_bug.cgi?id=34984
763
764         Reviewed by Adam Barth.
765
766         Move run-webkit-tests from using a white-list of supported NRWT ports
767         to a blacklist of ports requiring ORWT.
768
769         I've also added the ability to opt-in to parallel testing on a per-port basis.
770
771         With these changes I'm going to officially declare this bug dead and
772         work on remaining polish issues and individual developer complaints.
773
774         * Scripts/run-webkit-tests:
775         (useNewRunWebKitTests):
776         (platformIsReadyForParallelTesting):
777
778 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
779
780         Unreviewed, rolling out r98780.
781         http://trac.webkit.org/changeset/98780
782         https://bugs.webkit.org/show_bug.cgi?id=71173
783
784         Broke Qt bots (Requested by rniwa on #webkit).
785
786         * Scripts/run-webkit-tests:
787         (useNewRunWebKitTests):
788
789 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
790
791         webkit.py gdb visualizer is broken after change to StringImpl
792         https://bugs.webkit.org/show_bug.cgi?id=71154
793
794         Reviewed by Tony Chang.
795
796         r98624 changed StringImpl m_data to m_data32. This changes updates
797         webkit.py to match.
798
799         * gdb/webkit.py:
800
801 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
802
803         Fix typo in check-for-inappropriate-objc-class-names
804         https://bugs.webkit.org/show_bug.cgi?id=71144
805
806         Reviewed by Dan Bernstein.
807
808         * Scripts/check-for-inappropriate-objc-class-names:
809
810 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
811
812         Add support for sending scroll-update events from EventSender.
813         https://bugs.webkit.org/show_bug.cgi?id=66272
814
815         Reviewed by Adam Barth.
816
817         * DumpRenderTree/chromium/EventSender.cpp:
818         (EventSender::EventSender):
819         (EventSender::reset):
820         (EventSender::gestureScrollUpdate):
821         (EventSender::gestureEvent):
822         * DumpRenderTree/chromium/EventSender.h:
823
824 2011-10-28  Eric Seidel  <eric@webkit.org>
825
826         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
827         https://bugs.webkit.org/show_bug.cgi?id=34984
828
829         Reviewed by Adam Barth.
830
831         Move run-webkit-tests from using a white-list of supported NRWT ports
832         to a blacklist of ports requiring ORWT.
833
834         I've also added the ability to opt-in to parallel testing on a per-port basis.
835
836         With these changes I'm going to officially declare this bug dead and
837         work on remaining polish issues and individual developer complaints.
838
839         * Scripts/run-webkit-tests:
840         (useNewRunWebKitTests):
841         (platformIsReadyForParallelTesting):
842
843 2011-10-28  Eric Seidel  <eric@webkit.org>
844
845         NRWT crashes when parsing leaks output due to UTF-8 decoding error
846         https://bugs.webkit.org/show_bug.cgi?id=71112
847
848         Reviewed by Adam Barth.
849
850         Use read_binary_file instead of read_text_file and add a test
851         case with some non-utf8 data to make sure we don't break this in the future.
852
853         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
854         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
855
856 2011-10-28  David Levin  <levin@chromium.org>
857
858         watchlist should not CC the bug reporter
859         https://bugs.webkit.org/show_bug.cgi?id=71079
860
861         Reviewed by Adam Barth.
862
863         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
864         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
865
866         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
867         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
868         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
869
870 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
871
872         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
873         https://bugs.webkit.org/show_bug.cgi?id=71116
874
875         Reviewed by David Levin.
876
877         * Scripts/webkitpy/common/config/watchlist:
878
879 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
880
881         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
882         https://bugs.webkit.org/show_bug.cgi?id=70494
883
884         Reviewed by Kenneth Christiansen.
885
886         Use QQuick* instead of QSG* as well as QStandardPaths
887         instead of QDesktopLocation.
888
889         * MiniBrowser/qt/BrowserWindow.cpp:
890         (BrowserWindow::BrowserWindow):
891         * MiniBrowser/qt/BrowserWindow.h:
892         * QtTestBrowser/cookiejar.cpp:
893         (TestBrowserCookieJar::TestBrowserCookieJar):
894         * QtTestBrowser/launcherwindow.cpp:
895         (LauncherWindow::setDiskCache):
896         * WebKitTestRunner/PlatformWebView.h:
897         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
898         (WTR::WrapperWindow::WrapperWindow):
899         (WTR::WrapperWindow::handleStatusChanged):
900
901 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
902
903         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
904         https://bugs.webkit.org/show_bug.cgi?id=71106
905
906         Reviewed by Simon Hausmann.
907
908         Holding Ctrl allows multiple touch points to be held on the screen using
909         mouse buttons. It would previously only prevent TouchReleased to be sent
910         and would require another MouseButtonRelease to be sent without holding Ctrl.
911
912         This patch makes sure that all held touch points are released when Ctrl
913         is released if MouseButtonRelease was received.
914         It also removes the touch QEvent::Type logic since it's currently handled
915         by QtGui by observing the modified touch points.
916
917         * MiniBrowser/qt/MiniBrowserApplication.cpp:
918         (MiniBrowserApplication::notify):
919         (MiniBrowserApplication::sendTouchEvent):
920         * MiniBrowser/qt/MiniBrowserApplication.h:
921
922 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
923
924         [Qt] MiniBrowser needs a -window-size option
925         https://bugs.webkit.org/show_bug.cgi?id=70999
926
927         Reviewed by Simon Hausmann.
928
929         Add an -window-size option useful for testing the viewport handling.
930         Also clean up the option handling.
931
932         * MiniBrowser/qt/BrowserWindow.cpp:
933         (BrowserWindow::BrowserWindow):
934         * MiniBrowser/qt/MiniBrowserApplication.cpp:
935         (MiniBrowserApplication::handleUserOptions):
936         * MiniBrowser/qt/MiniBrowserApplication.h:
937         (WindowOptions::WindowOptions):
938         (WindowOptions::setRequestedWindowSize):
939         (WindowOptions::requestedWindowSize):
940         * MiniBrowser/qt/utils.cpp:
941         (takeOptionValue):
942         * MiniBrowser/qt/utils.h:
943
944 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
945
946         Add allowScriptFromSource callback to FrameLoaderClient
947         https://bugs.webkit.org/show_bug.cgi?id=71013
948
949         Reviewed by Darin Fisher.
950
951         * DumpRenderTree/chromium/LayoutTestController.cpp:
952         (LayoutTestController::LayoutTestController):
953         (LayoutTestController::setScriptsAllowed):
954         * DumpRenderTree/chromium/LayoutTestController.h:
955         * DumpRenderTree/chromium/WebPermissions.cpp:
956         (WebPermissions::allowScriptFromSource):
957         (WebPermissions::setScriptsAllowed):
958         (WebPermissions::reset):
959         * DumpRenderTree/chromium/WebPermissions.h:
960
961 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
962
963         Added myself as a committer.
964
965         * Scripts/webkitpy/common/config/committers.py:
966
967 2011-10-27  Adam Barth  <abarth@webkit.org>
968
969         Remove WinCairo from the set of core builders.  WinCairo rarely builds
970         and is never green.
971
972         Rubber-stamped by Eric Seidel.
973
974         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
975         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
976
977 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
978
979         WebSocket: Connecting to localhost:8880 takes one second on Windows
980         https://bugs.webkit.org/show_bug.cgi?id=64788
981
982         Reviewed by Dirk Pranke.
983
984         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
985         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
986         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
987         from timing out on Windows, because this test tries to open a lot of
988         connections to localhost and each attempt takes one second to fall back from
989         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
990
991 2011-10-27  Adam Barth  <abarth@webkit.org>
992
993         Dis-integrate run-bindings-tests with webkitpy
994         https://bugs.webkit.org/show_bug.cgi?id=71092
995
996         Reviewed by Ryosuke Niwa.
997
998         These tests aren't really adding any value.
999
1000         * Scripts/webkitpy/common/config/ports.py:
1001         * Scripts/webkitpy/tool/commands/download_unittest.py:
1002         * Scripts/webkitpy/tool/mocktool.py:
1003         * Scripts/webkitpy/tool/steps/runtests.py:
1004         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1005         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1006
1007 2011-10-27  Eric Seidel  <eric@webkit.org>
1008
1009         REGRESSION (r98639): NRWT crashes when parsing leaks output
1010         https://bugs.webkit.org/show_bug.cgi?id=71087
1011
1012         Unreviewed.  Sadly we have no good way to test logging.
1013
1014         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1015
1016 2011-10-27  David Levin  <levin@chromium.org>
1017
1018         Test expectation errors should include the file name and platform in both the log and exception info.
1019         https://bugs.webkit.org/show_bug.cgi?id=71067
1020
1021         Reviewed by Ojan Vafai.
1022
1023         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1024         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1025
1026 2011-10-27  Eric Seidel  <eric@webkit.org>
1027
1028         new-run-webkit-tests doesn't understand --qt or --gtk
1029         https://bugs.webkit.org/show_bug.cgi?id=63970
1030
1031         Reviewed by Ojan Vafai.
1032
1033         Add support for --qt and --gtk to NRWT.
1034         I also removed some incorrect comments in the option parsing
1035         code (options which we already implement, but said we didn't)
1036         as well as moved --platform parsing out of the "results_options"
1037         section into the top configuration section.
1038
1039         Now run-webkit-tests no longer needs NRWT-specific code for passing
1040         --platform=qt, etc.
1041
1042         * Scripts/run-webkit-tests:
1043         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1044
1045 2011-10-27  Eric Seidel  <eric@webkit.org>
1046
1047         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
1048         https://bugs.webkit.org/show_bug.cgi?id=66227
1049
1050         Reviewed by Adam Roben.
1051
1052         I believe this should fix the bug.
1053
1054         * Scripts/run-webkit-tests: make NRWT default for --leaks
1055         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1056         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
1057         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
1058         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
1059         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1060         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
1061         * Scripts/webkitpy/layout_tests/port/mac.py:
1062         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
1063
1064 2011-10-27  Stephen Chenney  <schenney@chromium.org>
1065
1066         [Chromium] Need setPrinting
1067         https://bugs.webkit.org/show_bug.cgi?id=46152
1068
1069         Reviewed by Hajime Morita.
1070
1071         * DumpRenderTree/chromium/LayoutTestController.cpp:
1072         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
1073         (LayoutTestController::reset): Clearing flags for setPrinting.
1074         (LayoutTestController::setPrinting): Set flags for setPrinting.
1075         * DumpRenderTree/chromium/LayoutTestController.h:
1076         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
1077         (LayoutTestController::isPrinting): Method to return the setPrinting status.
1078         * DumpRenderTree/chromium/TestShell.cpp:
1079         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
1080         (TestShell::dump): Modified to dump setPrinting-specific output.
1081         * DumpRenderTree/chromium/WebViewHost.cpp:
1082         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
1083         active.
1084         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
1085
1086 2011-10-27  Sam Weinig  <sam@webkit.org>
1087
1088         Add allowsPlugIns property to WKBrowsingContextGroup
1089         https://bugs.webkit.org/show_bug.cgi?id=70987
1090
1091         Reviewed by Anders Carlsson.
1092
1093         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1094         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
1095
1096 2011-10-27  Adam Roben  <aroben@apple.com>
1097
1098         Test WKBundlePageGetBackingScaleFactor
1099
1100         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
1101         can't reliably determine the scale factor of snapshots returned via
1102         WKBundlePageCreateSnapshot* API
1103
1104         Reviewed by Sam Weinig.
1105
1106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1107
1108         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
1109         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
1110         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
1111         (TestWebKitAPI::createWindow): Conjure up a window.
1112         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
1113         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
1114         factors and when using a custom scale factor, and check that we get those same scale factors
1115         back.
1116
1117         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
1118         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
1119         members.
1120         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
1121         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
1122         from the page using the new API and send it back.
1123
1124 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
1125
1126         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
1127
1128         Rubber-stamped by Simon Hausmann.
1129
1130         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1131         (MiniBrowserApplication::handleUserOptions):
1132         Fix typo error.
1133
1134 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
1135
1136         [WebSocket] update pywebsocket to 0.7.
1137         https://bugs.webkit.org/show_bug.cgi?id=70992
1138
1139         Reviewed by Kent Tamura.
1140
1141         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
1142
1143         * Scripts/webkitpy/thirdparty/__init__.py:
1144
1145 2011-10-27  Elliot Poger  <epoger@google.com>
1146
1147         make lion observe MAC lines in test_expectations.txt
1148         https://bugs.webkit.org/show_bug.cgi?id=70941
1149
1150         Reviewed by Ojan Vafai.
1151
1152         * Scripts/webkitpy/layout_tests/port/chromium.py:
1153         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1154
1155 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
1156
1157         [Chromium] Allow DRT to be built without notifications enabled.
1158         https://bugs.webkit.org/show_bug.cgi?id=70919
1159
1160         Reviewed by Tony Gentilcore.
1161
1162         * DumpRenderTree/chromium/LayoutTestController.cpp:
1163         (LayoutTestController::grantDesktopNotificationPermission):
1164         (LayoutTestController::simulateDesktopNotificationClick):
1165         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1166         * DumpRenderTree/chromium/TestShell.cpp:
1167         (TestShell::TestShell):
1168         (TestShell::resetTestController):
1169
1170 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1171
1172         [Qt] Improve command line arguments handling for MiniBrowser.
1173         https://bugs.webkit.org/show_bug.cgi?id=70616
1174
1175         Reviewed by Kenneth Rohde Christiansen.
1176
1177         - Use two dashes for word arguments.
1178         - Return with an error when an unsupported argument is given.
1179         - Allow the URL to be placed before option arguments.
1180
1181         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1182         (printHelp):
1183         (MiniBrowserApplication::handleUserOptions):
1184         * MiniBrowser/qt/utils.cpp:
1185         (takeOptionFlag):
1186         (takeOptionValue):
1187         * MiniBrowser/qt/utils.h:
1188
1189 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
1190
1191         [Qt] NRWT doesn't work on qt-mac platform
1192         https://bugs.webkit.org/show_bug.cgi?id=64445
1193
1194         Reviewed by Adam Barth.
1195
1196         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
1197         (useNewRunWebKitTests):
1198         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
1199
1200 2011-10-26  Sam Weinig  <sam@webkit.org>
1201
1202         Add initial setting to WKBrowsingContextGroup
1203         https://bugs.webkit.org/show_bug.cgi?id=70942
1204
1205         Reviewed by Anders Carlsson.
1206
1207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1208         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
1209         Add basic test that setting the javaScriptEnabled setting takes. It is not
1210         possible to test its effect quite yet.
1211
1212 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
1213
1214         [GTK] [WK2] Add WebKit2 distcheck support
1215         https://bugs.webkit.org/show_bug.cgi?id=70933
1216
1217         Reviewed by Martin Robinson.
1218
1219         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
1220         sources and EXTRA_DIST.
1221
1222 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
1223
1224         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
1225
1226         Reviewed by Tor Arne Vestbø.
1227
1228         We're using QScroller since r98460, which requires QWidget/QApplication. So
1229         use QApplication and QtWidgets for the time being.
1230
1231         * MiniBrowser/qt/MiniBrowser.pro:
1232         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1233         (MiniBrowserApplication::MiniBrowserApplication):
1234         (MiniBrowserApplication::notify):
1235         * MiniBrowser/qt/MiniBrowserApplication.h:
1236
1237 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1238
1239         [Qt][WK2] Rewrite MiniBrowser in QML
1240         https://bugs.webkit.org/show_bug.cgi?id=70315
1241
1242         Add the first QML based implementation of MiniBrowser.
1243
1244         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1245                  Zeno Albisser <zeno.albisser@nokia.com>
1246
1247         Reviewed by Tor Arne Vestbø.
1248
1249         * MiniBrowser/qt/BrowserWindow.cpp:
1250         (BrowserWindow::BrowserWindow):
1251         (BrowserWindow::webView):
1252         (BrowserWindow::load):
1253         (BrowserWindow::keyPressEvent):
1254         (BrowserWindow::~BrowserWindow):
1255         * MiniBrowser/qt/BrowserWindow.h:
1256         * MiniBrowser/qt/MiniBrowser.pro:
1257         * MiniBrowser/qt/MiniBrowser.qrc:
1258         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1259         (MiniBrowserApplication::MiniBrowserApplication):
1260         (MiniBrowserApplication::handleUserOptions):
1261         * MiniBrowser/qt/MiniBrowserApplication.h:
1262         (WindowOptions::WindowOptions):
1263         * MiniBrowser/qt/UrlLoader.cpp:
1264         (UrlLoader::UrlLoader):
1265         * MiniBrowser/qt/icons/next.png: Added.
1266         * MiniBrowser/qt/icons/previous.png: Added.
1267         * MiniBrowser/qt/icons/refresh.png: Added.
1268         * MiniBrowser/qt/icons/stop.png: Added.
1269         * MiniBrowser/qt/main.cpp:
1270         (main):
1271         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
1272
1273 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
1274
1275         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
1276         https://bugs.webkit.org/show_bug.cgi?id=70529
1277
1278         Remove obsolete code for a new QML based implementation
1279         of MiniBrowser.
1280         Change BrowserWindow to derive from QSGView instead of
1281         QMainWindow. QSGView is used as a top level window that
1282         provides the container for placing QML content.
1283         Make MiniBrowserApplication derive from QGuiApplication
1284         instead of QApplication.
1285
1286         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1287                  Zeno Albisser <zeno.albisser@nokia.com>
1288
1289         Reviewed by Simon Hausmann.
1290
1291         * MiniBrowser/qt/BrowserView.cpp: Removed.
1292         * MiniBrowser/qt/BrowserView.h: Removed.
1293         * MiniBrowser/qt/BrowserWindow.cpp:
1294         (BrowserWindow::BrowserWindow):
1295         (BrowserWindow::load):
1296         (BrowserWindow::screenshot):
1297         (BrowserWindow::loadURLListFromFile):
1298         (BrowserWindow::updateUserAgentList):
1299         (BrowserWindow::~BrowserWindow):
1300         * MiniBrowser/qt/BrowserWindow.h:
1301         * MiniBrowser/qt/MiniBrowser.pro:
1302         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1303         (MiniBrowserApplication::MiniBrowserApplication):
1304         (MiniBrowserApplication::notify):
1305         * MiniBrowser/qt/MiniBrowserApplication.h:
1306         * MiniBrowser/qt/UrlLoader.cpp:
1307         (UrlLoader::UrlLoader):
1308         * MiniBrowser/qt/main.cpp:
1309
1310 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1311
1312         [Qt][WK2] Remove QAction from MiniBrowser
1313         https://bugs.webkit.org/show_bug.cgi?id=70525
1314
1315         In order to rewrite MiniBrowser in QML we need a suitable
1316         mechanism for triggering navigation actions.
1317         Due to the QtWidgets dependency of QAction the current
1318         solution is not suitable anymore. Therefore we introduce
1319         invokable methods and export properties in QWebNavigationController.
1320
1321         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1322                  Zeno Albisser <zeno.albisser@nokia.com>
1323
1324         Reviewed by Simon Hausmann.
1325
1326         * MiniBrowser/qt/BrowserView.cpp:
1327         * MiniBrowser/qt/BrowserView.h:
1328         * MiniBrowser/qt/BrowserWindow.cpp:
1329         (BrowserWindow::BrowserWindow):
1330
1331 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1332
1333         [EFL] Unregister viewport,changed signal in EWebLauncher.
1334         https://bugs.webkit.org/show_bug.cgi?id=70478
1335
1336         Reviewed by Eric Seidel.
1337
1338         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
1339         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
1340         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
1341         This signal is for mobile device.
1342
1343         * EWebLauncher/main.c:
1344         (browserCreate):
1345
1346 2011-10-25  Anders Carlsson  <andersca@apple.com>
1347
1348         Plug-ins have no way to find out when the device scale factor changes
1349         https://bugs.webkit.org/show_bug.cgi?id=67226
1350         <rdar://problem/10048276>
1351
1352         Reviewed by Sam Weinig.
1353
1354         Keep a cached copy of the contents scale and update it when it changes.
1355
1356         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
1357         (ContentsScaleFactor::ContentsScaleFactor):
1358         (ContentsScaleFactor::cachedContentsScaleFactor):
1359         (ContentsScaleFactor::ScriptableObject::hasProperty):
1360         (ContentsScaleFactor::ScriptableObject::getProperty):
1361         (ContentsScaleFactor::NPP_New):
1362         (ContentsScaleFactor::NPP_SetValue):
1363
1364 2011-10-25  Sam Weinig  <sam@webkit.org>
1365
1366         Add WKBrowsingContextLoadDelegateTest test for a failed load
1367         https://bugs.webkit.org/show_bug.cgi?id=70859
1368
1369         Reviewed by Anders Carlsson.
1370
1371         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1372         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
1373  
1374         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
1375         Test that we are getting the correct NSError code and domain.
1376
1377 2011-10-25  Erik Arvidsson  <arv@chromium.org>
1378
1379         JS Test Harness: Make successfullyParsed optional
1380         https://bugs.webkit.org/show_bug.cgi?id=70784
1381
1382         Reviewed by Ojan Vafai.
1383
1384         * Scripts/make-new-script-test:
1385         (writeTestFile): Update the template for script tests.
1386
1387 2011-10-25  Anders Carlsson  <andersca@apple.com>
1388
1389         Plug-ins have to use JavaScript to find out the current device scale factor
1390         https://bugs.webkit.org/show_bug.cgi?id=67225
1391         <rdar://problem/10048258>
1392
1393         Reviewed by Darin Adler.
1394
1395         Add a plug-in test for getting the contents scale factor.
1396
1397         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1398         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
1399         (ContentsScaleFactor::ContentsScaleFactor):
1400         (ContentsScaleFactor::contentsScaleFactor):
1401         (ContentsScaleFactor::ScriptableObject::hasProperty):
1402         (ContentsScaleFactor::ScriptableObject::getProperty):
1403         (ContentsScaleFactor::ScriptableObject::pluginTest):
1404         (ContentsScaleFactor::NPP_GetValue):
1405
1406 2011-10-25  Sam Weinig  <sam@webkit.org>
1407
1408         Flesh out WKBrowsingContextLoadDelegate a bit
1409         https://bugs.webkit.org/show_bug.cgi?id=70846
1410
1411         Reviewed by Anders Carlsson.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
1415         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
1416         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
1417         (WKBrowsingContextLoadDelegateTest::SetUp):
1418         (WKBrowsingContextLoadDelegateTest::TearDown):
1419         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
1420         (TEST_F):
1421         Add basic testing for WKBrowsingContextLoadDelegate.
1422
1423 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
1424
1425         make-script-test-wrappers should not look outside fast/js
1426         https://bugs.webkit.org/show_bug.cgi?id=66357
1427
1428         Reviewed by Maciej Stachowiak.
1429
1430         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
1431         fast/js.
1432
1433 2011-10-25  Adam Barth  <abarth@webkit.org>
1434
1435         Add a --make option to update-webkit to engage the Makefile-based build system
1436         https://bugs.webkit.org/show_bug.cgi?id=70847
1437
1438         Reviewed by Dimitri Glazkov.
1439
1440         I can never remember what crazy environment variables I'm supposed to
1441         set to tell GYP what to do.
1442
1443         * Scripts/update-webkit:
1444
1445 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
1446
1447         [EFL] DRT: Force layout when sending events.
1448         https://bugs.webkit.org/show_bug.cgi?id=70357
1449
1450         Reviewed by Antonio Gomes.
1451
1452         Some tests such as editing/input/page-up-down-scrolls.html rely on the
1453         scrollbars being properly set up during the onload events.
1454         Document::implicitClose(), however, dispatches the onload events before
1455         calling FrameView::layout(), so these tests usually fail.
1456
1457         We now do the same as the GTK+ and Chromium ports and manually force the
1458         layout when dispatching events.
1459
1460         * DumpRenderTree/efl/EventSender.cpp:
1461         (sendMouseEvent):
1462         (keyDownCallback):
1463
1464 2011-10-25  Daniel Bates  <dbates@rim.com>
1465
1466         build-webkit --clean should only clean build directory for CMake-based ports
1467         https://bugs.webkit.org/show_bug.cgi?id=70834
1468
1469         Reviewed by Antonio Gomes.
1470
1471         Currently build-webkit --clean both cleans the build directory and builds WebKit for
1472         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
1473         as per its description in the usage message of build-webkit.
1474
1475         * Scripts/webkitdirs.pm:
1476         (buildCMakeProjectOrExit):
1477
1478 2011-10-25  Anna Cavender  <annacc@chromium.org>
1479
1480         Enable running of track layout tests for Chromium
1481         https://bugs.webkit.org/show_bug.cgi?id=70803
1482
1483         Reviewed by Adam Barth.
1484         
1485         Make DumpRenderTree/TestShell always run with track enabled
1486         (equivalent of --enable-video-track).
1487
1488         * DumpRenderTree/chromium/TestShell.cpp:
1489         (TestShell::TestShell):
1490
1491 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
1492
1493         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
1494         https://bugs.webkit.org/show_bug.cgi?id=70603
1495
1496         Reviewed by Gustavo Noronha Silva.
1497
1498         * MiniBrowser/gtk/BrowserWindow.c:
1499         (focus):
1500         (unFocus):
1501         (browserWindowUIClientInit):
1502
1503 2011-10-25  Dan Bernstein  <mitz@apple.com>
1504
1505         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
1506
1507         Reviewed by Adam Roben.
1508
1509         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1510         (TestWebKitAPI::TEST):
1511
1512 2011-10-25  Eric Seidel  <eric@webkit.org>
1513
1514         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
1515         https://bugs.webkit.org/show_bug.cgi?id=64471
1516
1517         Reviewed by Adam Roben.
1518
1519         Speculative fix.
1520
1521         * Scripts/webkitpy/layout_tests/port/win.py:
1522         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1523
1524 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
1525
1526         Fix bug summary when rolling Chromium DEPS to LKGR.
1527         https://bugs.webkit.org/show_bug.cgi?id=69917
1528
1529         Reviewed by Adam Barth.
1530
1531         * Scripts/webkitpy/tool/bot/irc_command.py:
1532         * Scripts/webkitpy/tool/bot/sheriff.py:
1533         * Scripts/webkitpy/tool/commands/roll.py:
1534         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1535
1536 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
1537
1538         [EFL] Build fix. Add include path to find npapi.h
1539         https://bugs.webkit.org/show_bug.cgi?id=70730
1540
1541         Unreviewed build fix.
1542
1543         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
1544
1545 2011-10-24  Eric Seidel  <eric@webkit.org>
1546
1547         Plugin tests are failing after switching WK2 to NRWT
1548         https://bugs.webkit.org/show_bug.cgi?id=70760
1549
1550         Reviewed by Simon Fraser.
1551
1552         Perpetuate this horrible hack.
1553
1554         * Scripts/webkitpy/layout_tests/port/webkit.py:
1555
1556 2011-10-24  Eric Seidel  <eric@webkit.org>
1557
1558         NRWT doesn't support ORWT's --root option, but should
1559         https://bugs.webkit.org/show_bug.cgi?id=70416
1560
1561         Reviewed by Dirk Pranke.
1562
1563         Add support for ORWT's --root option which is used for
1564         running tests with a nightly build of WebKit.
1565
1566         * Scripts/old-run-webkit-tests:
1567         * Scripts/webkitpy/layout_tests/port/base.py:
1568          - webkit_build_path was never called by any code, removed.
1569         * Scripts/webkitpy/layout_tests/port/webkit.py:
1570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1571
1572 2011-10-24  David Levin  <levin@chromium.org>
1573
1574         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
1575         https://bugs.webkit.org/show_bug.cgi?id=70747
1576
1577         Reviewed by Tony Chang.
1578
1579         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
1580         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
1581
1582 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
1583
1584         [Qt][WK2] Crash when running pixel tests
1585         https://bugs.webkit.org/show_bug.cgi?id=70725
1586
1587         Reviewed by Chang Shu.
1588
1589         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1590         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1591
1592 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         [GTK] Remove g_thread_init() calls
1595         https://bugs.webkit.org/show_bug.cgi?id=70717
1596
1597         Reviewed by Xan Lopez.
1598
1599         With newer glib it's not needed anymore and with previous versions
1600         it was already called by g_type_init().
1601
1602         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1603         (main):
1604         * GtkLauncher/main.c:
1605         (main):
1606         * MiniBrowser/gtk/main.c:
1607         (main):
1608
1609 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
1610
1611         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
1612         https://bugs.webkit.org/show_bug.cgi?id=69403
1613
1614         We did not added autotoolsconfig.h to the config.h file and we
1615         were adding Platform.h without the config.h in the
1616         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
1617         the Prefix file.
1618
1619         Reviewed by Martin Robinson.
1620
1621         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1622
1623 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
1624
1625         [EFL] Remove unused code from EWebLauncher
1626         https://bugs.webkit.org/show_bug.cgi?id=70590
1627
1628         Reviewed by Andreas Kling.
1629
1630         Removed unused function on_closeWindow from EWebLauncher
1631
1632         * EWebLauncher/main.c:
1633
1634 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
1635
1636         Add watchlist for WebCore/css and put myself on it.
1637         https://bugs.webkit.org/show_bug.cgi?id=70701
1638
1639         Reviewed by Adam Barth.
1640
1641         * Scripts/webkitpy/common/config/watchlist:
1642         Add watchlist for WebCore/css and put myself on it.
1643
1644 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1645
1646         [GTK] Implement KeyDown function for WebKit2 EventSender.
1647         https://bugs.webkit.org/show_bug.cgi?id=69410
1648
1649         Reviewed by Martin Robinson.
1650
1651         Implement the KeyDown function on Gtk platform.
1652
1653         * WebKitTestRunner/GNUmakefile.am:
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::TestController):
1656         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1657         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
1658         (WTR::EventSenderProxy::EventSenderProxy):
1659         (WTR::dispatchEvent):
1660         (WTR::getModifiers):
1661         (WTR::getGDKKeySymForKeyRef):
1662         (WTR::EventSenderProxy::keyDown):
1663
1664 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1665
1666         [WK2][GTK] run-launcher script fails after testing WK2 tests
1667         https://bugs.webkit.org/show_bug.cgi?id=70676
1668
1669         Reviewed by Andreas Kling.
1670
1671         Pass the '-2' flag instead of '--webkit-test-runner' when executing
1672         run-launcher script after testing with WebKitTestRunner.
1673
1674         * Scripts/webkitpy/layout_tests/port/gtk.py:
1675
1676 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1677
1678         [WK2][GTK] Missing env variables cause WKTR to crash
1679         https://bugs.webkit.org/show_bug.cgi?id=70674
1680
1681         Reviewed by Martin Robinson.
1682
1683         Set two environment variables that the Gtk's port of WebKitTestRunner
1684         depends on and crashes if they're not explicitly set by the user.
1685         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
1686         properly uses the _build_path method.
1687
1688         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
1689         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
1690         environment variables.
1691
1692 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
1693
1694         Bencher script doesn't measure GC times accurately
1695         https://bugs.webkit.org/show_bug.cgi?id=70588
1696
1697         Reviewed by Geoff Garen.
1698         
1699         Added two new options which allow different ways of measuring GC times:
1700         
1701         --measure-gc, which omits calls to gc() between benchmark invocations.
1702         This option takes an optional argument, which is the name of the
1703         VM in which to enable this feature. This allows comparing a single VM
1704         against itself, with and without GC.
1705         
1706         --rerun <N>, which causes each sample measurement to include N invocations
1707         which do not have gc() calls between them. The default is N = 1, which
1708         results in the same behavior as before.
1709         
1710         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
1711         N >= 3) to get more of a contribution from GC to the measured times.
1712         --rerun results in tighter confidence intervals than --measure-gc, since
1713         it amortizes GC effects in each sample, while with --measure-gc some
1714         samples will see GC and some won't leading to a higher standard devation
1715         and thus requiring more samples to reduce confidence intervals to
1716         managable levels.
1717
1718         * Scripts/bencher:
1719
1720 2011-10-21  Sam Weinig  <sam@webkit.org>
1721
1722         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
1723         https://bugs.webkit.org/show_bug.cgi?id=70653
1724
1725         Reviewed by Simon Fraser.
1726
1727         * MiniBrowser/mac/AppDelegate.h:
1728         * MiniBrowser/mac/AppDelegate.m:
1729         (-[BrowserAppDelegate init]):
1730         (-[BrowserAppDelegate newWindow:]):
1731         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1732         * MiniBrowser/mac/BrowserWindowController.h:
1733         * MiniBrowser/mac/BrowserWindowController.m:
1734         (-[BrowserWindowController initWithContext:pageGroup:]):
1735         (-[BrowserWindowController windowWillClose:]):
1736         (createNewPage):
1737         (-[BrowserWindowController awakeFromNib]):
1738         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1739         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1740         Update testing code to pass a PageGroup as necessary.
1741
1742 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
1743
1744         webkitpy: Teach NRWT about the EFL port
1745         https://bugs.webkit.org/show_bug.cgi?id=70637
1746
1747         Allows using ``efl'' as a platform when executing NRWT.
1748
1749         Reviewed by Eric Seidel.
1750
1751         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
1752         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
1753         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
1754         when using PortFactory.get(port_name='efl').
1755
1756 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
1757
1758         [Gtk] mousemove event always has metaKey == true
1759         https://bugs.webkit.org/show_bug.cgi?id=35299
1760
1761         Reviewed by Martin Robinson.
1762
1763         * DumpRenderTree/gtk/EventSender.cpp:
1764         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
1765         keyboard events. So making it in sync with WebCore files.
1766         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
1767
1768 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         watchlist: Add a new entry for WebKit2 GTK+ public API
1771         https://bugs.webkit.org/show_bug.cgi?id=70601
1772
1773         Reviewed by Philippe Normand.
1774
1775         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
1776         for patches that might include new API that points to the WebKit2
1777         GTK+ API guidelines.
1778
1779         * Scripts/webkitpy/common/config/watchlist:
1780
1781 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
1782
1783         Remove QtScript source code from WebKit.
1784         https://bugs.webkit.org/show_bug.cgi?id=64088
1785
1786         Reviewed by Tor Arne Vestbø.
1787
1788         Removed dead code that isn't developed anymore.
1789
1790         * Scripts/webkitpy/style/checker_unittest.py:
1791
1792 2011-10-20  Eric Seidel  <eric@webkit.org>
1793
1794         Switch webkit2 bot to NRWT
1795         https://bugs.webkit.org/show_bug.cgi?id=56729
1796
1797         Reviewed by Adam Barth.
1798
1799         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
1800         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
1801
1802         * Scripts/run-webkit-tests:
1803         (runningOnBuildBot):
1804         (useNewRunWebKitTests):
1805
1806 2011-10-20  Eric Seidel  <eric@webkit.org>
1807
1808         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
1809         https://bugs.webkit.org/show_bug.cgi?id=70585
1810
1811         Reviewed by Adam Barth.
1812
1813         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
1814         However since DRT was functioning fine before in Qt, we'll make this an error log for now
1815         and once we find the root cause flip this back to an assert.
1816
1817         * Scripts/webkitpy/layout_tests/port/webkit.py:
1818
1819 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1820
1821         Unreviewed, rolling out r98064.
1822         http://trac.webkit.org/changeset/98064
1823         https://bugs.webkit.org/show_bug.cgi?id=64788
1824
1825         Broke Mac bots.
1826
1827         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1828
1829 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1830
1831         WebSocket: Connecting to localhost:8880 takes one second on Windows
1832         https://bugs.webkit.org/show_bug.cgi?id=64788
1833
1834         Reviewed by Dirk Pranke.
1835
1836         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1837         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1838         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1839         from timing out on Windows, because this test tries to open a lot of
1840         connections to localhost and each attempt takes one second to fall back from
1841         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1842
1843 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
1844
1845         nrwt: newly generated results are put in cross-platform directory
1846         https://bugs.webkit.org/show_bug.cgi?id=68931
1847
1848         Reviewed by Dirk Pranke.
1849
1850         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
1851         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
1852         (because png images are typically different on each platform), and passing True when .txt file is missing
1853         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
1854
1855         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1856         * Scripts/webkitpy/layout_tests/port/test.py:
1857         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
1858         and added a test case.
1859
1860 2011-10-20  Kent Tamura  <tkent@chromium.org>
1861
1862         Unreviewed. Adding myself to watchlist.
1863
1864         * Scripts/webkitpy/common/config/watchlist:
1865         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
1866
1867 2011-10-20  Nico Weber  <thakis@chromium.org>
1868
1869         [chromium/mac] Add support for building with make
1870         https://bugs.webkit.org/show_bug.cgi?id=70455
1871
1872         Reviewed by Adam Barth.
1873
1874         Depends on http://codereview.chromium.org/8352029/
1875         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
1876         create a toplevel Makefile.chromium.
1877
1878         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
1879         `Tools/Scripts/build-webkit --chromium` will build with make instead of
1880         xcodebuild.
1881
1882         Also let nrwt use a binary from out/ if it exists.
1883
1884         * Scripts/webkitdirs.pm:
1885         (determineBaseProductDir):
1886         (isChromiumMacMake):
1887         (determineIsChromiumMacMake):
1888         (buildChromium):
1889
1890 2011-10-20  Eric Seidel  <eric@webkit.org>
1891
1892         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
1893         https://bugs.webkit.org/show_bug.cgi?id=70524
1894
1895         Reviewed by Adam Barth.
1896
1897         This is a speculative fix, since I do not use a platform
1898         which outputs crashlogs over stderr.
1899
1900         * Scripts/webkitpy/layout_tests/port/server_process.py:
1901         * Scripts/webkitpy/layout_tests/port/webkit.py:
1902
1903 2011-10-20  Eric Seidel  <eric@webkit.org>
1904
1905         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
1906         https://bugs.webkit.org/show_bug.cgi?id=70492
1907
1908         Reviewed by Adam Barth.
1909
1910         The bug turned out to be that I was assuming the block.content
1911         would be empty before the binary content following Content-Length
1912         was read inside _read_block.  Turns out its not, due to extra newlines
1913         and "ExpectedHash" header.
1914
1915         In the process of trying to figure out what was going wrong I ended up
1916         cleaning up our newline usage in DumpRenderTree a little.  Moved
1917         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
1918
1919         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
1920         per Adam's request in the original bug.
1921
1922         * DumpRenderTree/PixelDumpSupport.cpp:
1923         (dumpWebViewAsPixelsAndCompareWithExpected):
1924         * DumpRenderTree/cg/ImageDiffCG.cpp:
1925         (main):
1926         * DumpRenderTree/mac/DumpRenderTree.mm:
1927         (dump):
1928         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1929         (restoreMainDisplayColorProfile):
1930         (setupMainDisplayColorProfile):
1931         * Scripts/webkitpy/layout_tests/port/server_process.py:
1932         * Scripts/webkitpy/layout_tests/port/webkit.py:
1933         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1934
1935 2011-10-20  Tony Chang  <tony@chromium.org>
1936
1937         [chromium] Remove <stdint.h> from ImageDiff and use
1938         unsigned int instead of uint32_t.
1939
1940         Unreviewed, fixing the chromium win build.
1941
1942         * DumpRenderTree/chromium/ImageDiff.cpp:
1943         (Image::pixelAt):
1944         (Image::setPixelAt):
1945         (maxOf3):
1946         (getRedComponent):
1947         (getGreenComponent):
1948         (getBlueComponent):
1949         (weightedPercentageDifferent):
1950         (createImageDiff):
1951
1952 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
1953
1954         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
1955         https://bugs.webkit.org/show_bug.cgi?id=69997
1956
1957         Reviewed by Tony Chang.
1958
1959         This change is required to make ImageDiff for Android, and can benefit
1960         other platforms, too. On Android, most targets are built as
1961         toolsets:target. while ImageDiff needs to be built as toolsets:host.
1962         Currently, building the standalone target of ImageDiff depends on about
1963         85 other targets (try  make ImageDiff'), which is inefficient. After the
1964         change, ImageDiff only depends on webkit_support_gfx, which in turn
1965         depends on libpng and zlib.
1966
1967         * DumpRenderTree/chromium/ImageDiff.cpp:
1968         (main):
1969
1970 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1971
1972         [EFL] Unreviewed DumpRenderTree build fix.
1973
1974         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1975         (LayoutTestController::addChromeInputField): Add stub.
1976         (LayoutTestController::removeChromeInputField): Ditto.
1977         (LayoutTestController::focusWebView): Ditto.
1978         (LayoutTestController::setBackingScaleFactor): Ditto.
1979
1980 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1981
1982         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
1983         https://bugs.webkit.org/show_bug.cgi?id=70142
1984
1985         Reviewed by Gustavo Noronha Silva.
1986
1987         * CMakeListsEfl.txt: Include DRT CMakeLists.
1988         * DumpRenderTree/efl/CMakeLists.txt: Added.
1989
1990 2011-10-20  Philippe Normand  <pnormand@igalia.com>
1991
1992         [style] Allow usage of NULL in gst_*
1993         https://bugs.webkit.org/show_bug.cgi?id=70498
1994
1995         Reviewed by David Levin.
1996
1997         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
1998         of gst_ calls. Now just ignore NULL in all of them.
1999         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
2000
2001 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2002
2003         [EFL] Unreviewed. Build fix after r97043.
2004
2005         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2006         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
2007         * DumpRenderTree/efl/EventSender.cpp:
2008         (scalePageByCallback): Ditto.
2009
2010 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2011
2012         Unreviewed. Adding myself to watchlists.
2013         * Scripts/webkitpy/common/config/watchlist:
2014
2015 2011-10-19  Eric Seidel  <eric@webkit.org>
2016
2017         Reviewed by Adam Barth.
2018
2019         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
2020         https://bugs.webkit.org/show_bug.cgi?id=63683
2021
2022         * Scripts/webkitpy/common/net/layouttestresults.py:
2023         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2024         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2025         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2026         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2027         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2028         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2029         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2030         * Scripts/webkitpy/layout_tests/port/base.py:
2031         * Scripts/webkitpy/layout_tests/port/server_process.py:
2032         * Scripts/webkitpy/layout_tests/port/webkit.py:
2033         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2034
2035 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
2036
2037         Chromium doesn't support git branch builds, so don't add the branch to the product dir
2038         https://bugs.webkit.org/show_bug.cgi?id=70449
2039
2040         Reviewed by Eric Seidel.
2041
2042         * Scripts/webkitdirs.pm:
2043         (determineBaseProductDir):
2044
2045 2011-10-19  Ojan Vafai  <ojan@chromium.org>
2046
2047         Unreviewed. Adding myself to watchlists.
2048         * Scripts/webkitpy/common/config/watchlist:
2049
2050 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
2051
2052         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
2053         https://bugs.webkit.org/show_bug.cgi?id=62166
2054
2055         Reviewed by Eric Seidel.
2056
2057         Included options to control committer/reviewer patch count requirements,
2058         an age-limit on patches, and verbose output for more in-depth analysis.
2059
2060         * Scripts/webkitpy/common/checkout/changelog.py:
2061         * Scripts/webkitpy/tool/commands/__init__.py:
2062         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
2063         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
2064
2065 2011-10-19  Eric Seidel  <eric@webkit.org>
2066
2067         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
2068         Make NRWT normalize directory names in Skipped files during parsing.
2069
2070         Unreviewed.  Very simple (tested) change.
2071
2072         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2073         * Scripts/webkitpy/layout_tests/port/webkit.py:
2074
2075 2011-10-19  David Levin  <levin@chromium.org>
2076
2077         watchlist: Should be more robust to bad regex.
2078         https://bugs.webkit.org/show_bug.cgi?id=69486
2079
2080         Reviewed by Adam Barth.
2081
2082         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
2083           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
2084           patterns since they are no longer anchored on the right hand side.
2085         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
2086         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
2087         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
2088         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
2089         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
2090         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
2091         filenames are no longer anchored on the right hand side.
2092         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
2093         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
2094         don't kill everything.
2095
2096 2011-10-19  David Levin  <levin@chromium.org>
2097
2098         watchlist: Add a stylecheck to do validity checks for the watchlist config.
2099         https://bugs.webkit.org/show_bug.cgi?id=69487
2100
2101         Reviewed by Adam Barth.
2102
2103         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
2104         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
2105         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
2106
2107 2011-10-19  Eric Seidel  <eric@webkit.org>
2108
2109         NRWT ServerProcess can't read lines from stderr and stdio separately
2110         https://bugs.webkit.org/show_bug.cgi?id=70435
2111
2112         Reviewed by Adam Barth.
2113
2114         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
2115         DRT expects RWT to read one line at a time from stderr and stdout independently.
2116         This allows DRT to communicate errors over stderr and have them responded to immediately
2117         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
2118         class only exposed a read_line function which would read a line from stdout
2119         and batch all output from stderr into an error buffer.  Callers would only be able
2120         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
2121
2122         * Scripts/webkitpy/layout_tests/port/server_process.py:
2123         * Scripts/webkitpy/layout_tests/port/webkit.py:
2124
2125 2011-10-19  Chang Shu  <cshu@webkit.org>
2126
2127         [Qt] Support WK1-only Skipped list
2128         https://bugs.webkit.org/show_bug.cgi?id=70254
2129
2130         Reviewed by Csaba Osztrogonác.
2131
2132         Added a new search path qt-wk1 for skipping WK1-only tests.
2133
2134         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
2135         * Scripts/old-run-webkit-tests: ORWT
2136
2137 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
2138
2139         [GTK] Enable to use built-product-archive on GTK platform
2140         https://bugs.webkit.org/show_bug.cgi?id=70319
2141
2142         Reviewed by Csaba Osztrogonác.
2143
2144         * BuildSlaveSupport/built-product-archive:
2145
2146 2011-10-18  David Levin  <levin@chromium.org>
2147
2148         watchlist: Should try to run if it can and not throw on mistakes.
2149         https://bugs.webkit.org/show_bug.cgi?id=70358
2150
2151         Reviewed by Adam Barth.
2152
2153         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
2154         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
2155         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
2156         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
2157         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
2158         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
2159
2160 2011-10-18  Sam Weinig  <sam@webkit.org>
2161
2162         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
2163         https://bugs.webkit.org/show_bug.cgi?id=70387
2164
2165         Reviewed by Dan Bernstein.
2166
2167         * MiniBrowser/mac/BrowserWindowController.m:
2168         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2169         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2170         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2171         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2172         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2173         Update to include WKViewPrivate.h where necessary.
2174
2175 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
2176
2177         Web Inspector: Some localizedStrings.js Updates
2178         https://bugs.webkit.org/show_bug.cgi?id=70365
2179
2180         Reviewed by Darin Adler.
2181
2182         * Scripts/check-inspector-strings:
2183         Updated to the new webkitpy way to determine checkout root.
2184
2185         * Scripts/webkitdirs.pm:
2186         (copyInspectorFrontendFiles):
2187         Made it so build-webkit --inspector-frontend copies over
2188         the localizedStrings.js file as well as the frontend files.
2189
2190 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
2191
2192         [EFL] DRT: Clear list of visited pages before each test.
2193         https://bugs.webkit.org/show_bug.cgi?id=70355
2194
2195         Reviewed by Antonio Gomes.
2196
2197         r97596 uncovered a bug in the implementation: the list of visited
2198         links was not cleared between tests, which caused tests such as
2199         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
2200         changed depending on whether fast/repaint/border-repaint-glitch.html
2201         was visited before or not).
2202
2203         Call ewk_history_clear to make sure the visited links list does not
2204         persist between tests.
2205
2206         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2207         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2208
2209 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2210
2211         Split TestExpectationsEditor into its own file.
2212         https://bugs.webkit.org/show_bug.cgi?id=70348
2213
2214         Reviewed by Adam Barth.
2215
2216         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
2217         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
2218         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
2219         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2220         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
2221
2222 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2223
2224         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
2225         https://bugs.webkit.org/show_bug.cgi?id=70313
2226
2227         Reviewed by Adam Barth.
2228
2229         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
2230         this parameter because build-webkit and other scripts don't accept it.
2231
2232         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2233
2234 2011-10-18  Adam Barth  <abarth@webkit.org>
2235
2236         Subscribe myself to WebIDL changes
2237         https://bugs.webkit.org/show_bug.cgi?id=70341
2238
2239         Reviewed by David Levin.
2240
2241         I've also added some documentation and refactored my previous
2242         subscriptions to make it eaiser for others to subscribe as well.
2243
2244         * Scripts/webkitpy/common/config/watchlist:
2245
2246 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2247
2248         Add myself to the newfangled watchlist plumbing.
2249         https://bugs.webkit.org/show_bug.cgi?id=70338
2250
2251         Reviewed by David Levin.
2252
2253         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
2254
2255 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2256
2257         Fix a unit test in TestFailures.
2258         https://bugs.webkit.org/show_bug.cgi?id=70337
2259
2260         Reviewed by Adam Barth.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
2263             the value of a method property should always be lowercase.
2264
2265 2011-10-18  Adam Barth  <abarth@webkit.org>
2266
2267         Always enable ENABLE(XPATH)
2268         https://bugs.webkit.org/show_bug.cgi?id=70217
2269
2270         Reviewed by Eric Seidel.
2271
2272         * Scripts/build-webkit:
2273
2274 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2275
2276         garden-o-matic should not report flaking in expected failures as failures.
2277         https://bugs.webkit.org/show_bug.cgi?id=70279
2278
2279         Reviewed by Adam Barth.
2280
2281         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
2282         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
2283         same for garden-o-matic.
2284
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
2286             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
2288
2289 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
2290
2291         [Gtk] Support for client-based geolocation
2292         https://bugs.webkit.org/show_bug.cgi?id=64970
2293
2294         Reviewed by Martin Robinson.
2295
2296         Add support for testing client-based geolocation tests in DumpRenderTree.
2297
2298         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2299         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
2300         (createWebView): Create web view after declaring DumpRenderTree mode.
2301         That way a mock client for geolocation is used instead of a GeoClue
2302         client if a web view is created when testing.
2303         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
2304         geolocation layout tests.
2305         (LayoutTestController::setMockGeolocationPosition):
2306         (LayoutTestController::setMockGeolocationError):
2307         (LayoutTestController::setGeolocationPermission):
2308         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2309         * Scripts/build-webkit: Note that the Gtk port is using client-based
2310         geolocation, even though changing this flag has no effect on compilation.
2311
2312 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
2313
2314         [Chromium] suppress console output from DevTools window
2315         https://bugs.webkit.org/show_bug.cgi?id=69632
2316
2317         Reviewed by Pavel Feldman.
2318
2319         * DumpRenderTree/chromium/TestShell.cpp:
2320         (TestShell::showDevTools):
2321         * DumpRenderTree/chromium/WebViewHost.cpp:
2322         (WebViewHost::didAddMessageToConsole):
2323         (WebViewHost::reset):
2324         (WebViewHost::setLogConsoleOutput):
2325         * DumpRenderTree/chromium/WebViewHost.h:
2326
2327 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2328
2329         Unreviewed, rolling out r97735.
2330         http://trac.webkit.org/changeset/97735
2331         https://bugs.webkit.org/show_bug.cgi?id=70317
2332
2333         some people apparently use build-jsc with the qt port without
2334         building webkit first (Requested by torarne on #webkit).
2335
2336         * Scripts/build-webkit:
2337         * Scripts/webkitdirs.pm:
2338         (buildQMakeProject):
2339         (buildQMakeQtProject):
2340
2341 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2342
2343         [Qt] Remove dead code in build-webkit
2344
2345         build-webkit will iterate over a list of subdirectories to build,
2346         but this feature is only used by the Apple ports. For QtWebKit we
2347         always pass an empty directory to buildQMakeProject, which makes
2348         the logic for dealing with sub-projects in buildQMakeProject just
2349         added noise.
2350
2351         If we do want this feature at some point, we should redo it in
2352         the context of the upcoming build system changes for Qt.
2353
2354         Reviewed by Simon Hausmann.
2355
2356         * Scripts/build-webkit:
2357         * Scripts/webkitdirs.pm:
2358         (buildQt):
2359
2360 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2361
2362         Remove traces of Symbian support from the build scripts
2363
2364         Reviewed by Simon Hausmann.
2365
2366         * Scripts/build-webkit:
2367         * Scripts/webkitdirs.pm:
2368         (determineBaseProductDir):
2369         (argumentsForConfiguration):
2370         (usesPerConfigurationBuildDirectory):
2371         (buildQMakeProject):
2372
2373 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Build fix after r97672.
2376
2377         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2378
2379 2011-10-17  Kent Tamura  <tkent@chromium.org>
2380
2381         A follow-up of r97716.
2382         https://bugs.webkit.org/show_bug.cgi?id=68803
2383
2384         * DumpRenderTree/chromium/LayoutTestController.cpp:
2385         (LayoutTestController::reset): Initialize m_dumpCreateView.
2386
2387 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
2388
2389         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
2390         https://bugs.webkit.org/show_bug.cgi?id=68803
2391
2392         Reviewed by Nate Chapin.
2393
2394         * DumpRenderTree/chromium/LayoutTestController.cpp:
2395         (LayoutTestController::LayoutTestController):
2396         (LayoutTestController::dumpCreateView):
2397         * DumpRenderTree/chromium/LayoutTestController.h:
2398         (LayoutTestController::shouldDumpCreateView):
2399         * DumpRenderTree/chromium/WebViewHost.cpp:
2400         (WebViewHost::createView):
2401
2402 2011-10-17  Nate Chapin  <japhet@chromium.org>
2403
2404         Add myself to watchlists, and add a watch
2405         for Source/WebCore/loader/.
2406         https://bugs.webkit.org/show_bug.cgi?id=70263
2407
2408         Reviewed by David Levin.
2409
2410         * Scripts/webkitpy/common/config/watchlist:
2411
2412 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2413
2414         [EFL] DRT: Make non-recognized keys work in events as well.
2415         https://bugs.webkit.org/show_bug.cgi?id=69860
2416
2417         Reviewed by Antonio Gomes.
2418
2419         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
2420         here: it has a select box with a few non-latin options, and one of them
2421         is selected via the keyboard.
2422
2423         In this specific case, we need to make EventHandler::keyEvent send a
2424         keyPressEvent to SelectElement, so that
2425         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
2426         only when PlatformKeyEvent::text() is not empty, which was not the case
2427         so far.
2428
2429         * DumpRenderTree/efl/EventSender.cpp:
2430         (keyDownCallback):
2431
2432 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
2433
2434         Add layout tests for WebPlugin compositor path
2435         https://bugs.webkit.org/show_bug.cgi?id=69027
2436
2437         Reviewed by James Robinson.
2438
2439         * DumpRenderTree/DumpRenderTree.gypi:
2440         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
2441         (premultiplyAlpha):
2442         (TestWebPlugin::TestWebPlugin):
2443         (TestWebPlugin::~TestWebPlugin):
2444         (TestWebPlugin::mimeType):
2445         (TestWebPlugin::initialize):
2446         (TestWebPlugin::destroy):
2447         (TestWebPlugin::updateGeometry):
2448         (TestWebPlugin::parsePrimitive):
2449         (TestWebPlugin::parseColor):
2450         (TestWebPlugin::parseOpacity):
2451         (TestWebPlugin::initScene):
2452         (TestWebPlugin::drawScene):
2453         (TestWebPlugin::destroyScene):
2454         (TestWebPlugin::initProgram):
2455         (TestWebPlugin::initPrimitive):
2456         (TestWebPlugin::drawPrimitive):
2457         (TestWebPlugin::loadShader):
2458         (TestWebPlugin::loadProgram):
2459         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
2460         (TestWebPlugin::scriptableObject):
2461         (TestWebPlugin::paint):
2462         (TestWebPlugin::updateFocus):
2463         (TestWebPlugin::updateVisibility):
2464         (TestWebPlugin::acceptsInputEvents):
2465         (TestWebPlugin::handleInputEvent):
2466         (TestWebPlugin::didReceiveResponse):
2467         (TestWebPlugin::didReceiveData):
2468         (TestWebPlugin::didFinishLoading):
2469         (TestWebPlugin::didFailLoading):
2470         (TestWebPlugin::didFinishLoadingFrameRequest):
2471         (TestWebPlugin::didFailLoadingFrameRequest):
2472         (TestWebPlugin::Scene::Scene):
2473         * DumpRenderTree/chromium/WebViewHost.cpp:
2474         (WebViewHost::createPlugin):
2475
2476 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
2477
2478         [nrwt] Add new category for MISSING
2479         https://bugs.webkit.org/show_bug.cgi?id=69990
2480
2481         Reviewed by Dirk Pranke.
2482
2483         Treat missing results as a new category in summerize_results.
2484
2485         Because Chromium port wants to turn bots red when there are tests with missing results,
2486         extracted the logic to compute the exit code as exit_code_from_summarized_results in
2487         base and chromium ports.
2488
2489         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2490         * Scripts/webkitpy/layout_tests/port/base.py:
2491         * Scripts/webkitpy/layout_tests/port/chromium.py:
2492         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2493
2494 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
2495
2496         garden-o-matic operations fail because of CSP.
2497         https://bugs.webkit.org/show_bug.cgi?id=70249
2498
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
2500
2501 2011-10-17  Ada Chan  <adachan@apple.com>
2502
2503         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
2504         https://bugs.webkit.org/show_bug.cgi?id=70168
2505
2506         Reviewed by Alexey Proskuryakov.
2507
2508         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
2509         (TestWebKitAPI::didFinishLoadForFrame):
2510         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
2511
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2514         Add the new file.
2515
2516 2011-10-17  Darin Adler  <darin@apple.com>
2517
2518         Add some more *.pyc ignores in directories with Python scripts.
2519
2520         * QueueStatusServer: Added property svn:ignore.
2521         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
2522         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
2523         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
2524
2525 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
2526
2527         [Qt][WK2][meta] Fix failing API tests
2528         https://bugs.webkit.org/show_bug.cgi?id=70236
2529
2530         Reviewed by Csaba Osztrogonác.
2531
2532         In order to run WebKit2 API tests we need the WebProcess to be in
2533         the path so let's add the bin directory when running the API tests of Qt.
2534
2535         * Scripts/run-qtwebkit-tests:
2536
2537 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2538
2539         [Qt][WK2] Build dependency problems
2540         https://bugs.webkit.org/show_bug.cgi?id=68456
2541
2542         Reviewed by Csaba Osztrogonác.
2543
2544         * Scripts/webkitdirs.pm:
2545         (buildQMakeProject):
2546
2547 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2548
2549         [build] Introduce Qt/SH4 buildbot
2550         https://bugs.webkit.org/show_bug.cgi?id=70227
2551
2552         Reviewed by Adam Roben.
2553
2554         Add buildslave for Linux/Qt/SH4.
2555
2556         * BuildSlaveSupport/build.webkit.org-config/config.json:
2557
2558 2011-10-16  Adam Barth  <abarth@webkit.org>
2559
2560         Always enable ENABLE(DOM_STORAGE)
2561         https://bugs.webkit.org/show_bug.cgi?id=70189
2562
2563         Reviewed by Eric Seidel.
2564
2565         * Scripts/build-webkit:
2566         * waf/build/settings.py:
2567
2568 2011-10-15  Adam Barth  <abarth@webkit.org>
2569
2570         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
2571         https://bugs.webkit.org/show_bug.cgi?id=70194
2572
2573         Reviewed by Daniel Bates.
2574
2575         * Scripts/build-webkit:
2576
2577 2011-10-15  Ojan Vafai  <ojan@chromium.org>
2578
2579         run-webkit-tests should accept --child-processes
2580         https://bugs.webkit.org/show_bug.cgi?id=69713
2581
2582         Reviewed by Adam Barth.
2583
2584         Only set --child-processes=1 if --child-processes it not
2585         passed on the commandline.
2586
2587         * Scripts/run-webkit-tests:
2588
2589 2011-10-15  Daniel Bates  <dbates@webkit.org>
2590
2591         Extract common gdb code into its own function; Remove script gdb-safari
2592         https://bugs.webkit.org/show_bug.cgi?id=68499
2593
2594         Reviewed by David Kilzer.
2595
2596         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
2597         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
2598         We should extract the common parts into a function that can be shared by all callers
2599         so as to remove duplicate code.
2600
2601         As a side effect of removing duplicate code we can remove the script gdb-safari since
2602         its code has been incorporated into webkitdirs::debugSafari() which is called by the
2603         script debug-safari.
2604
2605         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
2606         * Scripts/gdb-safari: Removed.
2607         * Scripts/webkitdirs.pm:
2608         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
2609         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
2610         script gdb-safari to here.
2611         (debugSafari): Added.
2612         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
2613         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
2614         runSafari() always returns 1 on Windows and the script run-safari exits using this
2615         value as its exit status. Hence, the script run-safari always exits with a nonzero
2616         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
2617         exit status of the WebKit launcher application.
2618         (debugMiniBrowser): Modified to call debugMacWebKitApp().
2619         (debugWebKitTestRunner): Ditto.
2620
2621 2011-10-15  Robert Hogan  <robert@webkit.org>
2622
2623         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
2624         https://bugs.webkit.org/show_bug.cgi?id=70056
2625
2626         Reviewed by Adam Barth.
2627
2628         The preferred file-order for patches is LayoutTests at the end and
2629         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
2630         it when creating patches for review and landing.
2631
2632         * Scripts/webkitpy/common/checkout/scm/git.py:
2633         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2634         * Scripts/webkitpy/common/config/orderfile: Added.
2635
2636 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2637
2638         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
2639         https://bugs.webkit.org/show_bug.cgi?id=69920
2640
2641         Reviewed by Kenneth Rohde Christiansen.
2642
2643         * DumpRenderTree/qt/DumpRenderTree.pro:
2644         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2645         (WebCore::DumpRenderTree::open):
2646         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2647         * QtTestBrowser/QtTestBrowser.pro:
2648         * QtTestBrowser/launcherwindow.cpp:
2649         (LauncherWindow::screenshot):
2650         (LauncherWindow::showFPS):
2651         (LauncherWindow::updateFPS):
2652         * QtTestBrowser/launcherwindow.h:
2653         (WindowOptions::WindowOptions):
2654         * QtTestBrowser/mainwindow.cpp:
2655         (MainWindow::buildUI):
2656         * Scripts/webkitpy/style/checker.py: Remove rules for the
2657         WebKit/qt/symbian/platformplugin directory.
2658         * Scripts/webkitpy/style/checker_unittest.py:
2659         * Tools.pro:
2660         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2661         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2662         (WTR::LayoutTestController::platformInitialize):
2663         * WebKitTestRunner/qt/TestControllerQt.cpp:
2664         (WTR::isExistingLibrary):
2665         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2666
2667 2011-10-15  Adam Barth  <abarth@webkit.org>
2668
2669         Fix typo in webkitpy help
2670         https://bugs.webkit.org/show_bug.cgi?id=70169
2671
2672         Reviewed by Eric Seidel.
2673
2674         * Scripts/webkitpy/tool/commands/upload.py:
2675
2676 2011-10-15  Tony Chang  <tony@chromium.org>
2677
2678         fix another typo in treemap.html
2679         https://bugs.webkit.org/show_bug.cgi?id=70149
2680
2681         Reviewed by Ojan Vafai.
2682
2683         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
2684
2685         * TestResultServer/static-dashboards/treemap.html:
2686
2687 2011-10-14  Adam Barth  <abarth@webkit.org>
2688
2689         Hide status bubbles from queues which are very far behind
2690         https://bugs.webkit.org/show_bug.cgi?id=70133
2691
2692         Reviewed by Eric Seidel.
2693
2694         The mac-ews is so far behind that we shouldn't show its status bubble.
2695         The status bubble just makes contributors sad.
2696
2697         * QueueStatusServer/handlers/statusbubble.py:
2698
2699 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2700
2701         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
2702         https://bugs.webkit.org/show_bug.cgi?id=70143
2703
2704         Reviewed by Adam Barth.
2705
2706         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
2707         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
2708
2709 2011-10-14  David Levin  <levin@chromium.org>
2710
2711         watchlist: Add a validation check for the email names in the list.
2712         https://bugs.webkit.org/show_bug.cgi?id=70154
2713
2714         Reviewed by Adam Barth.
2715
2716         If an email is listed which doesn't have a bugzilla log in, then any emails
2717         added to the bug along with that email will fail to happen, so try to prevent this
2718         from happening by validating that emails added to the watchlist are known to be
2719         contributors.
2720
2721         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
2722         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
2723         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
2724
2725 2011-10-14  David Levin  <levin@chromium.org>
2726
2727         watchlist: If the style check fails, then the watchlist will not be run.
2728         https://bugs.webkit.org/show_bug.cgi?id=69484
2729
2730         Reviewed by Adam Barth.
2731
2732         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
2733         if the style part fails and don't allow watch list failures turn the
2734         bot run red.
2735         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
2736         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
2737
2738 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2739
2740         Plumb style-checker filter up to command options and make land-cowboy use it.
2741         https://bugs.webkit.org/show_bug.cgi?id=70119
2742
2743         Reviewed by Adam Barth.
2744
2745         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
2746         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
2747         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
2748         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
2749         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2750         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
2751         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
2752
2753 2011-10-14  Sam Weinig  <sam@webkit.org>
2754
2755         Remove the Leopard slaves.
2756
2757         Reviewed by Adam Roben.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/config.json:
2760
2761 2011-10-14  Peter Beverloo  <peter@chromium.org>
2762
2763         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
2764         https://bugs.webkit.org/show_bug.cgi?id=70028
2765
2766         Reviewed by Adam Barth.
2767
2768         * Scripts/update-webkit-chromium:
2769         * Scripts/webkitdirs.pm:
2770         (buildChromiumMakefile):
2771         (buildChromium):
2772
2773 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
2774
2775         Unreviewed; add missing #includes.
2776
2777         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2778         * DumpRenderTree/efl/EventSender.cpp:
2779
2780 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2781
2782         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
2783         https://bugs.webkit.org/show_bug.cgi?id=69770
2784
2785         Reviewed by Antonio Gomes.
2786
2787         We were just appending the given URL to the absolute URI of the main
2788         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
2789         instead of "file:///foo/bar/theother/url.html".
2790
2791         This should make fast/dom/navigation-type-navigate.html behave
2792         better (it still fails, but later).
2793
2794         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2795         (LayoutTestController::queueLoad):
2796
2797 2011-10-13  Arko Saha  <arko@motorola.com>
2798
2799         Microdata: Basic implementation of document.getItems() method.
2800         https://bugs.webkit.org/show_bug.cgi?id=68610
2801
2802         Reviewed by Ryosuke Niwa.
2803
2804         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
2805         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
2806
2807         * Scripts/build-webkit:
2808
2809 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2810
2811         new-run-webkit-tests does not support qt-4.8 results
2812         https://bugs.webkit.org/show_bug.cgi?id=64071
2813
2814         Roll-back second part of r97252. :)
2815
2816         * Scripts/webkitpy/layout_tests/port/qt.py:
2817
2818 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2819
2820         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
2821         https://bugs.webkit.org/show_bug.cgi?id=70106
2822
2823         Reviewed by Antonio Gomes.
2824
2825         OwnFastMallocPtr was being used as a smart pointer that automatically called
2826         free() on the strings returned by the EFL or by ewk.
2827
2828         However, when WTF is built in release mode, it uses its own memory management
2829         code instead of using the system malloc(), free() and friends. This means bad
2830         things will happen when one uses WTF's free() on memory allocated with system
2831         malloc() by the EFL or ewk.
2832
2833         The easiest way to solve this is to call free() ourselves.
2834
2835         * DumpRenderTree/efl/DumpRenderTree.cpp:
2836         (dumpFramesAsText):
2837         (getFinalTestURL):
2838
2839 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2840
2841         [EFL] Add DumpRenderTreeSupportEfl
2842         https://bugs.webkit.org/show_bug.cgi?id=68458
2843
2844         Reviewed by Kenneth Rohde Christiansen.
2845
2846         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
2847
2848         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2849         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
2850         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2851         (DumpRenderTreeChrome::onWindowObjectCleared):
2852         (DumpRenderTreeChrome::onDocumentLoadFinished):
2853         * DumpRenderTree/efl/GCControllerEfl.cpp:
2854         (GCController::collect):
2855         (GCController::collectOnAlternateThread):
2856         (GCController::getJSObjectCount):
2857         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2858         (LayoutTestController::counterValueForElementById):
2859         (LayoutTestController::pageNumberForElementById):
2860         (LayoutTestController::numberOfPages):
2861         (LayoutTestController::workerThreadCount):
2862         (LayoutTestController::findString):
2863         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2864         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2865         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2866         (LayoutTestController::numberOfActiveAnimations):
2867         (LayoutTestController::suspendAnimations):
2868         (LayoutTestController::resumeAnimations):
2869         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2870         (createBitmapContextFromWebView):
2871
2872 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2873
2874         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
2875
2876         Unreviewed.
2877
2878         * Scripts/run-webkit-tests:
2879         (useNewRunWebKitTests):
2880
2881 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2882
2883         new-run-webkit-tests does not support qt-4.8 results
2884         https://bugs.webkit.org/show_bug.cgi?id=64071
2885
2886         Roll-back r97252 with unit test fix.
2887
2888         Reviewed by Csaba Osztrogonác.
2889
2890         * Scripts/webkitpy/layout_tests/port/qt.py:
2891         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2892
2893 2011-10-13  Ojan Vafai  <ojan@chromium.org>
2894
2895         Make filter-build-webkit exit 1 if the build fails.
2896         https://bugs.webkit.org/show_bug.cgi?id=70080
2897
2898         Reviewed by Eric Seidel.
2899
2900         This only works if you redirect stderr to stdout, but it at least makes it possible.
2901         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
2902         only if the build succeeds.
2903
2904         * Scripts/filter-build-webkit:
2905
2906 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
2907
2908         land-cowboy should at least check style.
2909         https://bugs.webkit.org/show_bug.cgi?id=70073
2910
2911         Reviewed by Adam Barth.
2912
2913         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
2914
2915 2011-10-13  Tony Chang  <tony@chromium.org>
2916
2917         fix regex in layout test times dashboard
2918         https://bugs.webkit.org/show_bug.cgi?id=70059
2919
2920         This fixes the treemapfocus query param.
2921
2922         Reviewed by Ojan Vafai.
2923
2924         * TestResultServer/static-dashboards/treemap.html:
2925
2926 2011-10-13  Beth Dakin  <bdakin@apple.com>
2927
2928         https://bugs.webkit.org/show_bug.cgi?id=70050
2929         DRT and WRT should have HiDPI testing capabilities
2930
2931         Reviewed by Darin Adler.
2932
2933         New layoutTestController function setBackingScaleFactor takes a double for a scale 
2934         factor and a callback function to call once the backing scale factor has 
2935         successfully been set for the view.
2936         * DumpRenderTree/LayoutTestController.cpp:
2937         (setBackingScaleFactorCallback):
2938         (LayoutTestController::staticFunctions):
2939
2940         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
2941         platforms do nothing.
2942         * DumpRenderTree/LayoutTestController.h:
2943         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2944         (LayoutTestController::setBackingScaleFactor):
2945         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2946         (LayoutTestController::setBackingScaleFactor):
2947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2948         (LayoutTestController::setBackingScaleFactor):
2949
2950         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
2951         value of 0, which resets to the system default.
2952         * DumpRenderTree/mac/DumpRenderTree.mm:
2953         (resetWebViewToConsistentStateBeforeTesting):
2954
2955         When generating the pixel dump, create a Bitmap of the appropriate size based on 
2956         the backing scale factor. If it is a HiDPI view, paint into the context using 
2957         displayRectIgnoringOpacity.
2958         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2959         (createBitmapContextFromWebView):
2960
2961         And now the same stuff for WK2. Again, new layoutTestController function 
2962         setBackingScaleFactor takes a double for a scale factor and a callback function. 
2963         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2964         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2965         (WTR::LayoutTestController::setBackingScaleFactor):
2966         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
2967         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2968
2969         The InjectedBundle sends a message to the UI process to set the backing scale 
2970         factor. It also processes a message the UI process will send back once it 
2971         completes this task, and at that time, the InjectedBundle calls the callback.
2972         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2973         (WTR::InjectedBundle::didReceiveMessage):
2974         (WTR::InjectedBundle::postSetBackingScaleFactor):
2975         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2976
2977         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
2978         with a value of 0, which resets to the system default.
2979         * WebKitTestRunner/TestController.cpp:
2980         (WTR::TestController::resetStateToConsistentValues):
2981
2982         Upon receiving the SetBackingScaleFactor message, call 
2983         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
2984         back to InjectedBundle to say it has been done.
2985         * WebKitTestRunner/TestInvocation.cpp:
2986         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2987         
2988         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
2989         window's scale factor so we have to avoid that.
2990         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2991         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2992
2993 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
2994
2995         [Chromium] Allow building without speech input enabled.
2996         https://bugs.webkit.org/show_bug.cgi?id=69867
2997
2998         Reviewed by Darin Fisher.
2999
3000         * DumpRenderTree/chromium/LayoutTestController.cpp:
3001         (LayoutTestController::addMockSpeechInputResult):
3002
3003 2011-10-13  Kent Tamura  <tkent@chromium.org>
3004
3005         [Chromium] A DRT fix for r97348.
3006
3007         * DumpRenderTree/chromium/LayoutTestController.cpp:
3008         (LayoutTestController::overridePreference):
3009         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
3010         print an error message.
3011
3012 2011-10-12  Lucas Forschler  <lforschler@apple.com>
3013
3014         Update kill-old-processes logic.
3015         https://bugs.webkit.org/show_bug.cgi?id=63651
3016
3017         Reviewed by Ryosuke Niwa.
3018
3019         Remove unused mac platform specific folder.
3020         Update master.config to use new kill-old-processes.
3021
3022         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3023         * BuildSlaveSupport/kill-old-processes:
3024         * BuildSlaveSupport/mac: Removed.
3025
3026 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3027
3028         [NRWT] New tests without expected files are reported as flakey tests
3029         https://bugs.webkit.org/show_bug.cgi?id=67268
3030
3031         Reviewed by Dirk Pranke.
3032
3033         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
3034         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
3035         for missing results in retry_summary.
3036
3037         Fixed the bug by treating missing results separately.
3038
3039         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3040         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3041
3042 2011-10-12  Adam Barth  <abarth@webkit.org>
3043
3044         Remove ENABLE(XHTMLMP) and associated code
3045         https://bugs.webkit.org/show_bug.cgi?id=69729
3046
3047         Reviewed by David Levin.
3048
3049         * Scripts/build-webkit:
3050         * Scripts/old-run-webkit-tests:
3051         * Scripts/webkitperl/features.pm:
3052         * Scripts/webkitpy/layout_tests/port/webkit.py:
3053         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3054
3055 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3056
3057         Kill old run-webkit-tests processes in kill-process on Mac
3058         https://bugs.webkit.org/show_bug.cgi?id=69976
3059
3060         Reviewed by Dirk Pranke.
3061
3062         Add a system call to remove all python processes running run-webkit-tests.
3063
3064         * BuildSlaveSupport/kill-old-processes:
3065         * BuildSlaveSupport/mac: Removed.
3066
3067 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3068
3069         Many WK2 snapshots are blank
3070         https://bugs.webkit.org/show_bug.cgi?id=69953
3071
3072         Reviewed by Beth Dakin.
3073         
3074         Two fixes:
3075         1. negating a size_t in CGContextTranslateCTM() fails, because
3076         size_t is unsigned. Fix by casing to CGFloat before negation.
3077         
3078         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
3079         Autodisplay is necessary to kick off Core Animation rendering.
3080
3081         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3082         (WTR::createCGContextFromImage):
3083         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3084         (WTR::PlatformWebView::PlatformWebView):
3085
3086 2011-10-12  Adam Barth  <abarth@webkit.org>
3087
3088         commit-queue doesn't have a friendly error message when the reviewer line is messed up
3089         https://bugs.webkit.org/show_bug.cgi?id=69979
3090
3091         Reviewed by Eric Seidel.
3092
3093         Rather than combining the ChangeLog validation with a more complicated
3094         command, this patch has the commit-queue run it as a separate command,
3095         which will give us more control over the error message.
3096
3097         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3098         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3099         * Scripts/webkitpy/tool/commands/download.py:
3100         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3101         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3102         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3103
3104 2011-10-12  Eric Seidel  <eric@webkit.org>
3105
3106         Layout tests asserting in LayoutTestController::pathToLocalResource()
3107         https://bugs.webkit.org/show_bug.cgi?id=69898
3108
3109         Reviewed by Simon Fraser.
3110
3111         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
3112
3113         * Scripts/old-run-webkit-tests:
3114         (openDumpTool):
3115
3116 2011-10-12  Adam Barth  <abarth@webkit.org>
3117
3118         The commit-queue doesn't tell me which tests my patch broke
3119         https://bugs.webkit.org/show_bug.cgi?id=69975
3120
3121         Reviewed by Eric Seidel.
3122
3123         We now print the list of newly failing tests, like we do for the EWS.
3124
3125         * Scripts/webkitpy/tool/commands/queues.py:
3126         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3127
3128 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
3129
3130         Added myself as a committer.
3131
3132         * Scripts/webkitpy/common/config/committers.py:
3133
3134 2011-10-12  Adam Barth  <abarth@webkit.org>
3135
3136         _run_tests is a confusing variable name in webkitpy
3137         https://bugs.webkit.org/show_bug.cgi?id=69971
3138
3139         Reviewed by Eric Seidel.
3140
3141         Eric and I thought this was a function.
3142
3143         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3144
3145 2011-10-12  Tony Chang  <tony@chromium.org>
3146
3147         Fix test-webkitpy after r97307 and r97293.
3148
3149         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
3150           is None during tests so add back the check.
3151         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
3152           output directory is now build/Debug.
3153
3154 2011-10-12  Tony Chang  <tony@chromium.org>
3155
3156         [chromium] remove old build dirs on chromium-win
3157         https://bugs.webkit.org/show_bug.cgi?id=69961
3158
3159         Reviewed by Adam Barth.
3160
3161         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
3162           always in build and never in chrome or webkit.
3163
3164 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3165
3166         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
3167         https://bugs.webkit.org/show_bug.cgi?id=69954
3168
3169         Also renamed the action and associated event name to address an FIXME.
3170
3171         Reviewed by Adam Barth.
3172
3173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
3176
3177 2011-10-12  Tony Chang  <tony@chromium.org>
3178
3179         stop spamming 'stopping test driver timed out, killing it' when running rwt
3180         https://bugs.webkit.org/show_bug.cgi?id=69938
3181
3182         Reviewed by Adam Barth.
3183
3184         In http://trac.webkit.org/changeset/95875 , we made the timeout for
3185         stopping the driver based on time_out_ms, but we based it on the wrong
3186         default times.
3187
3188         * Scripts/webkitpy/layout_tests/port/chromium.py:
3189
3190 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3191
3192         3D transforms are flattened in WebKit2 snapshots
3193         https://bugs.webkit.org/show_bug.cgi?id=68276
3194
3195         Reviewed by Adam Roben.
3196         
3197         Fix WKImage leak noticed by Adam.
3198
3199         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3200         (WTR::PlatformWebView::windowSnapshotImage):
3201
3202 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3203
3204         garden-o-matic should color-code test failure types.
3205         https://bugs.webkit.org/show_bug.cgi?id=69945
3206
3207         Reviewed by Adam Barth.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
3213
3214 2011-10-12  Adam Barth  <abarth@webkit.org>
3215
3216         webkitpy tests are failing on Mac bots
3217         https://bugs.webkit.org/show_bug.cgi?id=69929
3218
3219         Reviewed by Simon Fraser.
3220
3221         Admit that Lion exists.
3222
3223         * Scripts/webkitpy/layout_tests/port/chromium.py:
3224         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3225
3226 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3227
3228         Improve output of run-api-tests to make time-outs more obvious
3229         https://bugs.webkit.org/show_bug.cgi?id=69788
3230
3231         Reviewed by Adam Roben.
3232         
3233         List the tests that failed and timed out at the bottom of the output,
3234         if run with --verbose.
3235
3236         * Scripts/run-api-tests:
3237         (runAllTests):
3238         (runTest):
3239
3240 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3241
3242         Unreviewed, rolling out r97252.
3243         http://trac.webkit.org/changeset/97252
3244         https://bugs.webkit.org/show_bug.cgi?id=69944
3245
3246         Broke test-webkpy (Requested by abarth on #webkit).
3247
3248         * Scripts/webkitpy/layout_tests/port/qt.py:
3249         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3250
3251 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3252
3253         new-run-webkit-tests does not support qt-4.8 results
3254         https://bugs.webkit.org/show_bug.cgi?id=64071
3255
3256         Reviewed by Csaba Osztrogonác.
3257
3258         * Scripts/webkitpy/layout_tests/port/qt.py:
3259         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3260
3261 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
3262
3263         [GTK] [WebKit2] Make adding another unit test easier
3264         https://bugs.webkit.org/show_bug.cgi?id=69409
3265
3266         Reviewed by Gustavo Noronha Silva.
3267
3268         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
3269         new WebKit2 tests.
3270
3271 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
3272
3273         [WebSocket] update pywebsocket to 0.6b6.
3274         https://bugs.webkit.org/show_bug.cgi?id=69824
3275
3276         Reviewed by Kent Tamura.
3277
3278         WebKit supports WebSocket with version 8 based protocol for now.
3279         We should update its protocol to version 13 based one like hybi-17.
3280         pywebsocket 0.6b6 supports both of version 8 and 13.
3281
3282         * Scripts/webkitpy/thirdparty/__init__.py:
3283
3284 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
3285
3286         WebKitTestRunner needs to link with WebKit for NSURL category methods
3287         https://bugs.webkit.org/show_bug.cgi?id=69892
3288
3289         Reviewed by Sam Weinig.
3290         
3291         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
3292         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
3293         WebKit.framework to fix this.
3294
3295         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3296
3297 2011-10-11  Adam Barth  <abarth@webkit.org>
3298
3299         sheriffbot takes too long to acknowledge rollout commands
3300         https://bugs.webkit.org/show_bug.cgi?id=69871
3301
3302         Reviewed by Eric Seidel.
3303
3304         We used to update the working copy before acknowledging the command
3305         because we wanted to ping all the relevant IRC nicks.  That's caused a
3306         bunch of frustration because folks don't know whether the bot has heard
3307         their commands.
3308
3309         This patch makes the bot reply immediately before updating the working
3310         copy.  All the relevenat folks are still pinged when the bot finishes
3311         preparing the rollout.
3312
3313         * Scripts/webkitpy/tool/bot/irc_command.py:
3314         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3315
3316 2011-10-11  Adam Barth  <abarth@webkit.org>
3317
3318         test-webkitpy fails on Lion
3319         https://bugs.webkit.org/show_bug.cgi?id=69873
3320
3321         Reviewed by Eric Seidel.
3322
3323         This patch fixes one of the two failures.  I'll need to track down the
3324         other failure another time.
3325
3326         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3327
3328 2011-10-11  Adam Barth  <abarth@webkit.org>
3329
3330         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
3331         https://bugs.webkit.org/show_bug.cgi?id=65230
3332
3333         Reviewed by Dimitri Glazkov.
3334
3335         This patch causes us to treat crashed or hung run-webkit-tests runs
3336         similarly to how we treat compile failures.  In some sense, they're
3337         similar because they prevent us from getting test coverage.
3338
3339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3341
3342 2011-10-11  Adam Barth  <abarth@webkit.org>
3343
3344         Failing builder display in garden-o-matic should have the same visual style as the failure grid
3345         https://bugs.webkit.org/show_bug.cgi?id=69876
3346
3347         Reviewed by Dimitri Glazkov.
3348
3349         This patch generalizes the view we use for failing builders in the
3350         FailureGrid so that we can use it for the list of builders that aren't
3351         compiling.
3352
3353         One downside of this patch is that it makes it harder to tell when
3354         debug builders are failing (as opposed to release builders) because
3355         that information isn't presented in this view.  A future patch will
3356         improve this aspect.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3364
3365 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
3366
3367         Some API tests are timing out in Release
3368         https://bugs.webkit.org/show_bug.cgi?id=69787
3369
3370         Reviewed by Mark Rowe.
3371         
3372         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
3373         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
3374
3375         * TestWebKitAPI/Configurations/Base.xcconfig:
3376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3377         * TestWebKitAPI/config.h:
3378
3379 2011-10-11  Adam Barth  <abarth@webkit.org>
3380
3381         garden-o-matic links to flakiness dashboard should open in a new tab
3382         https://bugs.webkit.org/show_bug.cgi?id=69864
3383
3384         Reviewed by Dimitri Glazkov.
3385
3386         This bug was obvious in the first five minutes of using this new
3387         feature.  :)
3388
3389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3391
3392 2011-10-11  Adam Barth  <abarth@webkit.org>
3393
3394         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
3395         that * doesn't really mean "all".  I've emailed the W3C working group
3396         about changing the spec.
3397
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3399
3400 2011-10-11  Adam Barth  <abarth@webkit.org>
3401
3402         garden-o-matic should link to the flakiness dashboard
3403         https://bugs.webkit.org/show_bug.cgi?id=69862
3404
3405         Reviewed by Dimitri Glazkov.
3406
3407         The flakiness dashboard has lots of great information about the failure
3408         history of each test.  This patch adds a link from garden-o-matic to
3409         the flakiness dashboard so the gardener can look at this information.
3410
3411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3414
3415 2011-10-11  David Levin  <levin@chromium.org>
3416
3417         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
3418         https://bugs.webkit.org/show_bug.cgi?id=69789
3419
3420         Reviewed by Eric Seidel.
3421
3422         Made the signature of _assertRaisesRegexp match that of Python 2.7.
3423
3424         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
3425         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
3426         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
3427         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
3428
3429 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3430
3431         [EFL] DRT: Do not abort() when an unknown key is pressed.
3432         https://bugs.webkit.org/show_bug.cgi?id=69856
3433
3434         Reviewed by Antonio Gomes.
3435
3436         A lot of tests crash due to the previous behaviour. Just using the
3437         received name of the pressed key works most of the time, and when it
3438         does not the failing tests should tell us.
3439
3440         * DumpRenderTree/efl/EventSender.cpp:
3441         (keyPadNameFromJSValue):
3442         (keyNameFromJSValue):
3443         (keyDownCallback):
3444
3445 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3446
3447         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
3448         https://bugs.webkit.org/show_bug.cgi?id=68016
3449
3450         Reviewed by Chang Shu.
3451
3452         * Scripts/webkitpy/layout_tests/port/qt.py:
3453
3454 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3455
3456         [EFL] DRT: Return the right window count in LayoutTestController.
3457         https://bugs.webkit.org/show_bug.cgi?id=69764
3458
3459         Reviewed by Antonio Gomes.
3460
3461         Follow-up to r96943: now that we have DumpRenderTreeChrome and
3462         DumpRenderTreeView in the tree, we can correctly count the number of
3463         open windows in DRT.
3464
3465         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3466         (LayoutTestController::windowCount):
3467
3468 2011-10-11  Jer Noble  <jer.noble@apple.com>
3469
3470         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
3471         https://bugs.webkit.org/show_bug.cgi?id=69800
3472
3473         Reviewed by Csaba Osztrogonác.
3474
3475         Enable WEB_AUDIO at runtime.
3476
3477         * DumpRenderTree/mac/DumpRenderTree.mm:
3478         (resetDefaultsToConsistentValues):
3479
3480 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3481
3482         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
3483         https://bugs.webkit.org/show_bug.cgi?id=69769
3484
3485         Reviewed by Antonio Gomes.
3486
3487         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3488         (LayoutTestController::setIconDatabaseEnabled):
3489
3490 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3491
3492         [Qt] Remove all references to QTDIR_build and standalone_package
3493
3494         Qt is now modularized, which means we no longer import WebKit into
3495         the Qt source tree. Instead we use git submodules, and building
3496         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
3497
3498         To decrease the number of buildsystem configurations we also remove
3499         the standalone_package code-path used when we were providing tarballs
3500         with the derived sources pre-generated.
3501
3502         Reviewed by Simon Hausmann.
3503
3504         * MiniBrowser/qt/MiniBrowser.pro:
3505         * QtTestBrowser/QtTestBrowser.pro:
3506         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3507
3508 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
3509
3510         Update Chromium accessibility support in DRT.
3511         https://bugs.webkit.org/show_bug.cgi?id=69676
3512
3513         Reviewed by Chris Fleizach.
3514
3515         Adds several missing properties and methods to enable more
3516         tests to pass, and in particular adds support for notification
3517         callbacks.
3518
3519         * DumpRenderTree/chromium/AccessibilityController.cpp:
3520         (AccessibilityController::AccessibilityController):
3521         (AccessibilityController::reset):
3522         (AccessibilityController::getFocusedElement):
3523         (AccessibilityController::shouldLogAccessibilityEvents):
3524         (AccessibilityController::notificationReceived):
3525         (AccessibilityController::logAccessibilityEventsCallback):
3526         * DumpRenderTree/chromium/AccessibilityController.h:
3527         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3528         (getHelpText):
3529         (getStringValue):
3530         (getOrientation):
3531         (AccessibilityUIElement::AccessibilityUIElement):
3532         (AccessibilityUIElement::getChildAtIndex):
3533         (AccessibilityUIElement::isEqual):
3534         (AccessibilityUIElement::notificationReceived):
3535         (AccessibilityUIElement::roleGetterCallback):
3536         (AccessibilityUIElement::titleGetterCallback):
3537         (AccessibilityUIElement::descriptionGetterCallback):
3538         (AccessibilityUIElement::helpTextGetterCallback):
3539         (AccessibilityUIElement::stringValueGetterCallback):
3540         (AccessibilityUIElement::xGetterCallback):
3541         (AccessibilityUIElement::yGetterCallback):
3542         (AccessibilityUIElement::widthGetterCallback):
3543         (AccessibilityUIElement::heightGetterCallback):
3544         (AccessibilityUIElement::intValueGetterCallback):
3545         (AccessibilityUIElement::minValueGetterCallback):
3546         (AccessibilityUIElement::maxValueGetterCallback):
3547         (AccessibilityUIElement::childrenCountGetterCallback):
3548         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3549         (AccessibilityUIElement::selectedTextRangeGetterCallback):
3550         (AccessibilityUIElement::isEnabledGetterCallback):
3551         (AccessibilityUIElement::isRequiredGetterCallback):
3552         (AccessibilityUIElement::isFocusedGetterCallback):
3553         (AccessibilityUIElement::isFocusableGetterCallback):
3554         (AccessibilityUIElement::isSelectedGetterCallback):
3555         (AccessibilityUIElement::isSelectableGetterCallback):
3556         (AccessibilityUIElement::isMultiSelectableGetterCallback):
3557         (AccessibilityUIElement::isExpandedGetterCallback):
3558         (AccessibilityUIElement::isCheckedGetterCallback):
3559         (AccessibilityUIElement::isVisibleGetterCallback):
3560         (AccessibilityUIElement::isOffScreenGetterCallback):
3561         (AccessibilityUIElement::isCollapsedGetterCallback):
3562         (AccessibilityUIElement::hasPopupGetterCallback):
3563         (AccessibilityUIElement::isValidGetterCallback):
3564         (AccessibilityUIElement::orientationGetterCallback):
3565         (AccessibilityUIElement::showMenuCallback):
3566         (AccessibilityUIElement::pressCallback):
3567         (AccessibilityUIElement::isEqualCallback):
3568         (AccessibilityUIElement::addNotificationListenerCallback):
3569         (AccessibilityUIElement::removeNotificationListenerCallback):
3570         (AccessibilityUIElement::takeFocusCallback):
3571         (AccessibilityUIElement::fallbackCallback):
3572         (RootAccessibilityUIElement::getChildAtIndex):
3573         (AccessibilityUIElementList::getOrCreate):
3574         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3575         * DumpRenderTree/chromium/CppVariant.cpp:
3576         (CppVariant::invokeDefault):
3577         * DumpRenderTree/chromium/CppVariant.h:
3578         * DumpRenderTree/chromium/LayoutTestController.cpp:
3579         (LayoutTestController::LayoutTestController):
3580         (LayoutTestController::reset):
3581         * DumpRenderTree/chromium/LayoutTestController.h:
3582         * DumpRenderTree/chromium/WebViewHost.cpp:
3583         (WebViewHost::postAccessibilityNotification):
3584
3585 2011-10-10  Adam Klein  <adamk@chromium.org>
3586
3587         Support Distributed-CompileC as an action name in filter-build-webkit
3588         https://bugs.webkit.org/show_bug.cgi?id=69783
3589
3590         Reviewed by Ojan Vafai.
3591
3592         * Scripts/filter-build-webkit:
3593
3594 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3595
3596         3D transforms are flattened in WebKit2 snapshots
3597         https://bugs.webkit.org/show_bug.cgi?id=68276
3598
3599         Reviewed by Anders Carlsson.
3600         
3601         Use a snapshot of the window, rather than an image from the web process
3602         for pixel testing in WebKitTestRunner. This correctly captures compositing
3603         layers, so works for 3D transform tests.
3604
3605         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
3606         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3607         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
3608         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
3609         use that instead of the image we get from the web process.
3610         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3611         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
3612         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3613         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3614         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3615         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3616         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3617         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3618
3619 2011-10-10  David Levin  <levin@chromium.org>
3620
3621         Quick fix for watchlist unit test failures when using Python 2.7+
3622         Reviewed by Adam Barth.
3623
3624         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
3625         better fix.
3626
3627         * Scripts/webkitpy/common/webkitunittest.py: Always use our
3628         version of assertRaisesRegexp.
3629
3630 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3631
3632         Unreviewed, rolling out r97082.
3633         http://trac.webkit.org/changeset/97082
3634         https://bugs.webkit.org/show_bug.cgi?id=69784
3635
3636         broke Windows build (Requested by smfr on #webkit).
3637
3638         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3639         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
3640         (WTR::createCGContextFromImage):
3641         (WTR::computeMD5HashStringForContext):
3642         (WTR::dumpBitmap):
3643         (WTR::paintRepaintRectOverlay):
3644         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3645         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3646         (WTR::PlatformWebView::PlatformWebView):
3647
3648 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3649
3650         3D transforms are flattened in WebKit2 snapshots
3651         https://bugs.webkit.org/show_bug.cgi?id=68276
3652
3653         Reviewed by Anders Carlsson.
3654         
3655         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
3656         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
3657         the window when doing pixel tests.
3658         
3659         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
3660
3661         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
3662         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
3663         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
3664         (WTR::computeMD5HashStringForContext):
3665         (WTR::dumpBitmap):
3666         (WTR::paintRepaintRectOverlay):
3667         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
3668         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
3669         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3670         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
3671         We need the window to autodisplay for Core Animation to render layers and start animations.
3672
3673 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3674
3675         WebKitTestRunner needs layoutTestController.setWindowIsKey
3676         https://bugs.webkit.org/show_bug.cgi?id=42688
3677
3678         Reviewed by Anders Carlsson.
3679
3680         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
3681         This sets a flag that the platform layer uses to indicate that
3682         the window is the key window, which fixes focus ring drawing
3683         in pixel results.
3684         
3685         Also focus the web view when we get a 'didCommitLoad' for the main
3686         frame, as DumpRenderTree does.
3687
3688         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3690         (WTR::InjectedBundle::postSetWindowIsKey):
3691         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3692         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3693         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
3694         (WTR::LayoutTestController::addChromeInputField):
3695         (WTR::LayoutTestController::removeChromeInputField):
3696         (WTR::LayoutTestController::focusWebView):
3697         (WTR::LayoutTestController::setWindowIsKey):
3698         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
3699         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
3700         (WTR::LayoutTestController::callFocusWebViewCallback):
3701         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3702         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
3703         so that we can override -isKeyWindow. Use a boolean member variable
3704         to track window key status.
3705         (WTR::PlatformWebView::setWindowIsKey):
3706         (WTR::PlatformWebView::windowIsKey):
3707         * WebKitTestRunner/TestController.cpp:
3708         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
3709         (WTR::closeOtherPage): Use the same cast as other functions.
3710         (WTR::focus): Implement to call setWindowIsKey(true)
3711         (WTR::unfocus): Implement to call setWindowIsKey(false)
3712         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
3713         (WTR::TestController::initialize):
3714         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
3715         * WebKitTestRunner/TestController.h:
3716         * WebKitTestRunner/TestInvocation.cpp:
3717         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3718         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3719         (WTR::PlatformWebView::PlatformWebView):
3720         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3721         (-[WebKitTestRunnerWindow isKeyWindow]):
3722         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
3723         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
3724         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
3725         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3726         (WTR::PlatformWebView::PlatformWebView):
3727         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3728         (WTR::PlatformWebView::PlatformWebView):
3729
3730 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
3731
3732         check-webkit-style: Add readability exception for Ewk_* data types.
3733         https://bugs.webkit.org/show_bug.cgi?id=69763
3734
3735         Reviewed by David Levin.
3736
3737         Many EFL-related files (such as EditorClientEfl.h or
3738         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
3739         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
3740         check-webkit-style.
3741
3742         Add an exception for them, just like there are exceptions for
3743         Evas_*, Ecore_* and others.
3744
3745         * Scripts/webkitpy/style/checkers/cpp.py:
3746         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3747
3748 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
3749
3750         [Chromium] Get rid of WebAccessibilityCache.
3751         https://bugs.webkit.org/show_bug.cgi?id=68224
3752
3753         Reviewed by Dimitri Glazkov.
3754
3755         * DumpRenderTree/chromium/AccessibilityController.cpp:
3756         (AccessibilityController::bindToJavascript):
3757
3758 2011-10-09  Adam Barth  <abarth@webkit.org>
3759
3760         Remove "near miss" XSS vulnerabilities in garden-o-matic
3761         https://bugs.webkit.org/show_bug.cgi?id=69708
3762
3763         Reviewed by David Levin.
3764
3765         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
3766         any actual vulnerabilities yet, but he did identify a couple "near
3767         misses" where a slight change in garden-o-matic could lead to a
3768         vulnerability.  This patch removes those potential issues.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
3771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3772
3773 2011-10-07  Adam Barth  <abarth@webkit.org>
3774
3775         Add a Content-Security-Policy to garden-o-matic
3776         https://bugs.webkit.org/show_bug.cgi?id=69668
3777
3778         Reviewed by David Levin.
3779
3780         This will help mitigate cross-site script and will also help us dogfood CSP.
3781
3782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3783
3784 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
3785
3786         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
3787         https://bugs.webkit.org/show_bug.cgi?id=66380
3788
3789         Reviewed by Antonio Gomes.
3790
3791         This encapsulates EWebKit into an object that manages multiple windows
3792         and provides a cleaner interface to EFL's DumpRenderTree.
3793
3794         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
3795         (DumpRenderTreeChrome::create):
3796         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3797         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
3798         (DumpRenderTreeChrome::createNewWindow):
3799         (DumpRenderTreeChrome::createView):
3800         (DumpRenderTreeChrome::removeWindow):
3801         (DumpRenderTreeChrome::initialize):
3802         (DumpRenderTreeChrome::extraViews):
3803         (DumpRenderTreeChrome::mainFrame):
3804         (DumpRenderTreeChrome::mainView):
3805         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3806         (DumpRenderTreeChrome::onWindowObjectCleared):
3807         (DumpRenderTreeChrome::onLoadStarted):
3808         (DumpRenderTreeChrome::processWork):
3809         (DumpRenderTreeChrome::onLoadFinished):
3810         (DumpRenderTreeChrome::onStatusbarTextSet):
3811         (DumpRenderTreeChrome::onTitleChanged):
3812         (DumpRenderTreeChrome::onDocumentLoadFinished):
3813         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
3814         * DumpRenderTree/efl/EventSender.cpp:
3815         (sendClick): Use browser->mainFrame() instead of mainFrame.
3816         (mouseDownCallback): Ditto.
3817         (mouseUpCallback): Ditto.
3818         (mouseMoveToCallback): Ditto.
3819         (mouseScrollByCallback): Ditto.
3820         (keyDownCallback): Ditto.
3821         (scalePageByCallback): Ditto.
3822         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3823         (LayoutTestController::counterValueForElementById): Use
3824         browser->mainFrame() instead of mainFrame.
3825         (LayoutTestController::pageNumberForElementById): Ditto.
3826         (LayoutTestController::numberOfPages): Ditto.
3827         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
3828         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
3829         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
3830         (LayoutTestController::numberOfActiveAnimations): Ditto.
3831         (LayoutTestController::suspendAnimations): Ditto.
3832         (LayoutTestController::resumeAnimations): Ditto.
3833         (LayoutTestController::setWebViewEditable): Ditto.
3834         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
3835         instead of browser.
3836         (LayoutTestController::queueLoad): Ditto.
3837         (LayoutTestController::setAcceptsEditing): Ditto.
3838         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
3839         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
3840         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
3841         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
3842         (LayoutTestController::setPluginsEnabled): Ditto.
3843         (LayoutTestController::findString): Ditto.
3844         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
3845         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3846         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
3847         mainFrame.
3848         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3849         (LoadItem::invoke): Ditto.
3850         (LoadHTMLStringItem::invoke): Ditto.
3851         (ScriptItem::invoke): Ditto.
3852         (ReloadItem::invoke): Use browser->mainView() instead of browser.
3853
3854 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
3855
3856         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
3857         https://bugs.webkit.org/show_bug.cgi?id=69617
3858
3859         Reviewed by Andreas Kling.
3860
3861         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
3862         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
3863         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
3864         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
3865         logic.
3866
3867         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3868         (MiniBrowserApplication::MiniBrowserApplication):
3869         (MiniBrowserApplication::notify):
3870         * MiniBrowser/qt/MiniBrowserApplication.h:
3871
3872 2011-10-06  Adam Barth  <abarth@webkit.org>
3873
3874         Port PixelZoomer to work in garden-o-matic
3875         https://bugs.webkit.org/show_bug.cgi?id=69577
3876
3877         Reviewed by David Levin.
3878
3879         This implementation of PixelZoomer is basically a fork of the
3880         implementation used by results.html.  These two apps have different
3881         requirements on where this code lives.  results.html wants to be
3882         self-contained whereas garden-o-matic wants to live in the public_html
3883         folder of the buildbot.  We could do something fancy here to share the
3884         code, but that's not likely to be of much benefit.
3885
3886         I had to change a few things about pixelzoomer to accounter for the
3887         differences in DOM between results.html and garden-o-matic, but
3888         surprisingly little.  I also moved all the code into an anonymous
3889         function, which is the style we're suing for module separation in
3890         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
3891         want to drag along too many extra functions from results.html.
3892
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
3898         (.pixel-zoom-container):
3899         (.pixel-zoom-container > *):
3900         (.pixel-zoom-container .scaled-image-container):
3901         (.scaled-image-container > img):
3902
3903 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3904
3905         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
3906         https://bugs.webkit.org/show_bug.cgi?id=69505
3907
3908         Reviewed by Andreas Kling.
3909
3910         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
3911         (on_viewport_changed):
3912
3913 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3914
3915         [WinCairo] Unreviewed test correction.
3916
3917         * Scripts/webkitdirs.pm:
3918         (argumentsForConfiguration): Add 'wincairo' option to the set of
3919         configuration flags used by run-javascript-core tests, so that it
3920         does not attempt to run Apple's release version.
3921
3922 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3923
3924         [WinCairo] Unreviewed test correction.
3925
3926         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
3927          of known build slave types so that test-result-archive won't fail
3928          when running tests.
3929
3930 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
3931
3932         The GTK+ WebKit2 headers produce a lot of style warnings
3933         https://bugs.webkit.org/show_bug.cgi?id=69481
3934
3935         Reviewed by David Levin.
3936
3937         Prevent emitting so many style warnings for GTK+ API. We skip header
3938         files in the WebKit2 GTK+ API directory and also avoid warnings about
3939         identifier names that begin with "webkit_" in files that contain the
3940         string "gtk".
3941
3942         * Scripts/webkitpy/style/checker.py: Do not check header files in
3943         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
3944         adding the ability to specify a regular expression in the skip list. Remove
3945         a few files from the skipped list that no longer exist.
3946         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
3947         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
3948         about identifiers that begin with "webkit_".
3949         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
3950
3951 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3952
3953         [WinCairo] Correct config.json for WinCairo Test builds.
3954         https://bugs.webkit.org/show_bug.cgi?id=69272
3955
3956         Reviewed by Ryosuke Niwa.
3957
3958         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
3959          old 'WinCairo Debug (Build)' label and replace with correct
3960          'WinCairo Release' label.
3961
3962 2011-10-06  David Levin  <levin@chromium.org>
3963
3964         Add a style checker watchlist definition and add myself to it.
3965         https://bugs.webkit.org/show_bug.cgi?id=69564
3966
3967         Reviewed by Daniel Bates.
3968
3969         * Scripts/webkitpy/common/config/watchlist:
3970
3971 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3972
3973         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
3974         https://bugs.webkit.org/show_bug.cgi?id=69450
3975
3976         Reviewed by Ryosuke Niwa.
3977
3978         This should avoid stderr messages when running
3979         webarchive/test-link-rel-icon.html.
3980
3981         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3982         (LayoutTestController::setIconDatabaseEnabled):
3983
3984 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
3985
3986         [WK2] [GTK] Add Skipped file for Webkit2 test runner
3987         https://bugs.webkit.org/show_bug.cgi?id=69517
3988
3989         Use the shared WK2 skipped file also in GTK port.
3990
3991         Reviewed by Martin Robinson.
3992
3993         * Scripts/old-run-webkit-tests:
3994         (readSkippedFiles):
3995
3996 2011-10-06  Elliot Poger  <epoger@google.com>
3997
3998         allow new-run-webkit-tests to run on Lion
3999         https://bugs.webkit.org/show_bug.cgi?id=69429
4000
4001         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
4002         directory to fallback lists (even though that directory doesn't exist yet)
4003
4004         Reviewed by Adam Barth.
4005
4006         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4007         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4008
4009 2011-10-03  Hans Wennborg  <hans@chromium.org>
4010
4011         IndexedDB: Remove SQLite-LevelDB migration code
4012         https://bugs.webkit.org/show_bug.cgi?id=69264
4013
4014         Reviewed by Tony Chang.
4015
4016         Remove setOverrideIndexedDBBackingStore. It was used in the layout
4017         test for migration.
4018
4019         * DumpRenderTree/chromium/LayoutTestController.cpp:
4020         (LayoutTestController::LayoutTestController):
4021         * DumpRenderTree/chromium/LayoutTestController.h:
4022
4023 2011-10-05  James Robinson  <jamesr@chromium.org>
4024
4025         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
4026         https://bugs.webkit.org/show_bug.cgi?id=69498
4027
4028         Reviewed by Adam Barth.
4029
4030         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4031         (main):
4032         * DumpRenderTree/chromium/TestShell.cpp:
4033         (TestShell::TestShell):
4034         (TestShell::resetWebSettings):
4035         * DumpRenderTree/chromium/TestShell.h:
4036         (TestShell::setThreadedCompositingEnabled):
4037         * DumpRenderTree/chromium/WebPreferences.cpp:
4038         (WebPreferences::reset):
4039         (WebPreferences::applyTo):
4040         * DumpRenderTree/chromium/WebPreferences.h:
4041         * Scripts/webkitpy/layout_tests/port/chromium.py:
4042         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4043
4044 2011-10-05  Erik Arvidsson  <arv@chromium.org>
4045
4046         [QT] Fix DRT after r96779
4047
4048         unreviewed.
4049
4050         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4051         (WebCore::dumpHistoryItem):
4052
4053 2011-10-05  Erik Arvidsson  <arv@chromium.org>
4054
4055         window.location.href and others needlessly decodes URI-encoded characters
4056         https://bugs.webkit.org/show_bug.cgi?id=30225
4057
4058         Reviewed by Darin Adler.
4059
4060         * DumpRenderTree/chromium/TestShell.cpp:
4061         (normalizeLayoutTestURLInternal): Remove extra encode.
4062
4063 2011-10-05  Darin Adler  <darin@apple.com>
4064
4065         Fix build.
4066
4067         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
4068         (TestWebKitAPI::TEST): Remove underscore prefix from call to
4069         WKContextRegisterURLSchemeAsEmptyDocument.
4070
4071 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
4072
4073         [WinCairo] Switch to building Release target, and activate tests.
4074         https://bugs.webkit.org/show_bug.cgi?id=69272
4075
4076         Reviewed by Adam Barth.
4077
4078         * BuildSlaveSupport/build.webkit.org-config/config.json:
4079         Change from debug to release target. Switch from "Build" to
4080         "BuildAndTest"
4081
4082 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
4083
4084         In WebKitTestRunner, text has font smoothing in pixel snapshots
4085         https://bugs.webkit.org/show_bug.cgi?id=69396
4086
4087         Reviewed by Darin Adler.
4088         
4089         Call the new WKContext method that disables font smoothing in
4090         WebKitTestRunner, so that pixel snapshots don't have font smoothing
4091         enabled. Remove leading underscore from a WKContext function call.
4092
4093         * WebKitTestRunner/TestController.cpp:
4094         (WTR::TestController::resetStateToConsistentValues):
4095
4096 2011-10-05  David Levin  <levin@chromium.org>
4097
4098         Improve the watchlist for threading entries.
4099         https://bugs.webkit.org/show_bug.cgi?id=69463
4100
4101         Reviewed by Adam Barth.
4102
4103         * Scripts/webkitpy/common/config/watchlist:
4104
4105 2011-10-05  Adam Roben  <aroben@apple.com>
4106
4107         Add tests for using RetainPtrs inside HashMap and HashSet
4108
4109         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
4110         in HashMap/HashSet fails to compile
4111
4112         Reviewed by John Sullivan.
4113
4114         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
4115         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
4116         and value type of HashMap.
4117
4118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4119         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4120         Added new file.
4121
4122 2011-10-05  Adam Barth  <abarth@webkit.org>
4123
4124         Mark as Expected in garden-o-matic is confusing
4125         https://bugs.webkit.org/show_bug.cgi?id=69452
4126
4127         Reviewed by David Levin.
4128
4129         krit didn't understand the difference between this button and the
4130         Rebaseline button because both of them seem to indicate that the new
4131         behavior is expected.  This patch renames "Mark as Expected" to "Expect
4132         Failure" to make it clear that we're just expecting the test to fail
4133         rather than accepting the new results as passing.  We might need to
4134         iterate on these names a bit more if folks continue to find them
4135         confusing.
4136
4137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
4138
4139 2011-10-05  Adam Barth  <abarth@webkit.org>
4140
4141         Add watchlist entries for abarth
4142         https://bugs.webkit.org/show_bug.cgi?id=69461
4143
4144         Reviewed by David Levin.
4145
4146         I might have gone a bit overboard.  We'll see if this is too much spam
4147         for me.
4148
4149         * Scripts/webkitpy/common/config/watchlist:
4150
4151 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
4152
4153         [WinCairo] Teach old-run-webkit-tests about wincairo.
4154         https://bugs.webkit.org/show_bug.cgi?id=69280
4155
4156         Reviewed by Adam Roben.
4157
4158         * Scripts/old-run-webkit-tests: Handle wincairo case.
4159         (buildPlatformResultHierarchy):
4160         (readSkippedFiles): Ditto
4161         * Scripts/webkitdirs.pm: Deal with wincairo build case.
4162         (determineConfiguration):
4163
4164 2011-10-05  Chang Shu  <cshu@webkit.org>
4165
4166         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
4167         https://bugs.webkit.org/show_bug.cgi?id=68924
4168
4169         Added TextInputController files and JS interfaces for the above functions.
4170
4171         Reviewed by Darin Adler.
4172
4173         * WebKitTestRunner/DerivedSources.make:
4174         * WebKitTestRunner/DerivedSources.pro:
4175         * WebKitTestRunner/GNUmakefile.am:
4176         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
4177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4178         (WTR::InjectedBundle::beginTesting):
4179         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4180         (WTR::InjectedBundle::textInputController):
4181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4182         (WTR::InjectedBundlePage::didClearWindowForFrame):
4183         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
4184         (WTR::TextInputController::create):
4185         (WTR::TextInputController::TextInputController):
4186         (WTR::TextInputController::~TextInputController):
4187         (WTR::TextInputController::wrapperClass):
4188         (WTR::TextInputController::makeWindowObject):
4189         (WTR::TextInputController::setMarkedText):
4190         (WTR::TextInputController::hasMarkedText):
4191         (WTR::TextInputController::unmarkText):
4192         (WTR::TextInputController::insertText):
4193         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
4194         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4195         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4196         * WebKitTestRunner/win/InjectedBundle.vcproj:
4197
4198 2011-10-04  Oliver Hunt  <oliver@apple.com>
4199
4200         Add rudimentary filtering to write barriers
4201         https://bugs.webkit.org/show_bug.cgi?id=69392
4202
4203         Reviewed by Filip Pizlo.
4204
4205         When we're recording gc phase times Heap.o picks up
4206         some exit time destructors, so we'll just ignore Heap.o
4207         in this check.
4208
4209         * Scripts/check-for-exit-time-destructors:
4210
4211 2011-10-05  Chang Shu  <cshu@webkit.org>
4212
4213         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
4214         https://bugs.webkit.org/show_bug.cgi?id=69365
4215
4216         Reviewed by Darin Adler.
4217
4218         Added js API in WTR LayoutTestController.
4219
4220         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4221         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4222         (WTR::LayoutTestController::dumpConfigurationForViewport):
4223         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4224
4225 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
4226
4227         [EFL] ImageDiff: Do not clear the image before it is processed and compared
4228         https://bugs.webkit.org/show_bug.cgi?id=69378
4229
4230         Reviewed by Antonio Gomes.
4231
4232         Commit 61836 to Evas added a few cleanup calls to some
4233         evas_object_image functions which effectively made ImageDiff consider
4234         all images to be equal.
4235
4236         It turns out that now evas_object_image_colorspace_set clears any
4237         data set, so the call to evas_object_image_data_set was not having any
4238         effect.
4239
4240         * DumpRenderTree/efl/ImageDiff.cpp:
4241         (readImageFromStdin): Call evas_object_image_data_set after
4242         evas_object_image_colorspace_set.
4243
4244 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
4245
4246         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
4247         https://bugs.webkit.org/show_bug.cgi?id=68449
4248
4249         Reviewed by Antonio Gomes.
4250
4251         evas_render() must be called to close up temporary files and unmap unused
4252         resources. evas_object_image_data_set() must be called after an
4253         evas_object_image_data_get() to balance an internal reference count.
4254
4255         * DumpRenderTree/efl/ImageDiff.cpp:
4256         (differenceImageFromDifferenceBuffer):
4257         (calculateDifference):
4258         (printImage):
4259         (printImageDifferences):
4260
4261 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
4262
4263         [Qt][WK2] Unreviewed build fix.
4264
4265         Don't use WebCore directly in WTR.
4266
4267         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4268         (WTR::PlatformWebView::addChromeInputField):
4269         (WTR::PlatformWebView::removeChromeInputField):
4270         (WTR::PlatformWebView::makeWebViewFirstResponder):
4271
4272 2011-10-05  David Levin  <levin@chromium.org>
4273
4274         watchlist: Add more rules for chromium public api and sort the file.
4275         https://bugs.webkit.org/show_bug.cgi?id=69323
4276
4277         Reviewed by Adam Barth.
4278
4279         * Scripts/webkitpy/common/config/watchlist:
4280
4281 2011-10-05  David Levin  <levin@chromium.org>
4282
4283         watchlist: Don't add the same message to a bug more than once.
4284         https://bugs.webkit.org/show_bug.cgi?id=69303
4285
4286         Reviewed by Adam Barth.
4287
4288         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
4289         if a message is in the comments already.
4290         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
4291         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
4292         Pick a bug supplied by the mock. Change the test due to different output
4293         from the mock watch list tool.
4294         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
4295         another email so it will be filtered out, fix bugs to have the cc and comment fields,
4296         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
4297         to debug).
4298         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
4299         and/or cc's that are already in the bug.
4300         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
4301         and remove a comment that is filtered out.
4302
4303 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
4304
4305         [Qt][WK2] Unreviewed build fix after r96643.
4306
4307         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4308         (WTR::PlatformWebView::addChromeInputField):
4309         (WTR::PlatformWebView::removeChromeInputField):
4310         (WTR::Platfor