[Win] Revise DRT logic to match Mac.
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Revise DRT logic to match Mac.
4
5         Rubberstamped by Anders Carlsson.
6
7         Update the Windows logic to perform initialization of preferences and WebKit
8         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
9         the same circumstances as the Mac version.
10
11         * DumpRenderTree/win/DumpRenderTree.cpp:
12         (dump):
13         (resetWebPreferencesToConsistentValues):
14         (setDefaultsToConsistentValuesForTesting):
15         (resetWebViewToConsistentStateBeforeTesting):
16         (sizeWebViewForCurrentTest):
17         (runTest):
18         (createWebViewAndOffscreenWindow):
19         (allocateGlobalControllers):
20         (prepareConsistentTestingEnvironment):
21         (main):
22         (resetDefaultsToConsistentValues): Deleted.
23
24 2014-12-19  Roger Fong  <roger_fong@apple.com>
25
26         Unreviewed. Rollout r177605.
27
28         * EWSTools/start-queue-win.sh:
29
30 2014-12-19  Roger Fong  <roger_fong@apple.com>
31
32         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
33
34         * EWSTools/start-queue-win.sh:
35
36 2014-12-19  Daniel Bates  <dabates@apple.com>
37
38         [iOS] Add WebKitSystemInterface for iOS 8.1
39         https://bugs.webkit.org/show_bug.cgi?id=139831
40
41         Reviewed by Alexey Proskuryakov.
42
43         Implement support in copy-webkitlibraries-to-product-directory to copy
44         WebKitSystemInterface for iOS to the product directory and have build-webkit
45         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
46
47         * Scripts/build-webkit:
48         * Scripts/copy-webkitlibraries-to-product-directory:
49
50 2014-12-19  Daniel Bates  <dabates@apple.com>
51
52         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
53         https://bugs.webkit.org/show_bug.cgi?id=139829
54
55         Reviewed by Alexey Proskuryakov.
56
57         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
58         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
59         expects the Xcode SDK to be specified using the --sdk-name command line argument.
60
61         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
62         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
63         logic to both avoid duplicating effort and make the command line options for
64         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
65         with the approach used in other WebKit tools.
66
67         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
68         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
69         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
70
71         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
72         improve the readability of the code.
73         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
74         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
75         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
76         be included in a library.
77         (unpackIfNecessary): Modified to call executeRanlib().
78
79 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
80
81         REGRESSION (177368): Some tests started to immediately time out
82         https://bugs.webkit.org/show_bug.cgi?id=139826
83
84         Reviewed by Daniel Bates.
85
86         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
87         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
88         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
89         ends in a load failure, we don't dump, so we used to leak the timer.
90         
91         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
92         Added a comment.
93
94 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
95
96         [Win] Add accessor for serializing HTTP loads
97         https://bugs.webkit.org/show_bug.cgi?id=139817
98
99         Reviewed by Mark Lam.
100
101         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
102         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
103         remove some redundant code from the destructor.
104
105 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
106
107         Clean up a fix for performance test bot failing to build
108         https://bugs.webkit.org/show_bug.cgi?id=139818
109
110         Reviewed by Csaba Osztrogonác.
111
112         The "_1" in step name was annoying.
113
114         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
115         (CleanBuildIfScheduled.start):
116         (RunAndUploadPerfTests):
117         (DownloadAndPerfTestFactory.__init__):
118         (DownloadAndPerfTestWebKit2Factory.__init__):
119         (CleanBuildUnconditionally): Deleted.
120         (CleanBuildUnconditionally.start): Deleted.
121
122 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
123
124         REGRESSION(r177535): It broke the GTK performance bot
125         https://bugs.webkit.org/show_bug.cgi?id=139811
126
127         Reviewed by Carlos Garcia Campos.
128
129         Trigger clean build only on mac platform.
130
131         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
132         (DownloadAndPerfTestFactory.__init__):
133         (DownloadAndPerfTestWebKit2Factory.__init__):
134
135 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
136
137         Unreviewed, moved myself to the list of committers.
138
139         * Scripts/webkitpy/common/config/contributors.json:
140
141 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
142
143         [Win] Update DumpRenderTree to more closely match Mac version
144         https://bugs.webkit.org/show_bug.cgi?id=139799
145
146         Reviewed by Tim Horton.
147
148         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
149         (AccessibilityController::accessibleElementById): Correct
150         use of BSTR to avoid leak.
151         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
152         update to match Mac version more closely.
153         (dumpFramesAsText):
154         (dump):
155         (resetDefaultsToConsistentValues):
156         (resetWebViewToConsistentStateBeforeTesting):
157         (sizeWebViewForCurrentTest):
158         (runTest):
159         (openWindows):
160         (windowToWebViewMap):
161         (createWebViewAndOffscreenWindow):
162         (sharedCFURLCache):
163         (initializeGlobalsFromCommandLineOptions):
164         (main):
165         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
166         (TestRunner::addDisallowedURL):
167         (TestRunner::applicationCacheDiskUsageForOrigin):
168         (TestRunner::syncLocalStorage):
169         (TestRunner::localStorageDiskUsageForOrigin):
170         (TestRunner::observeStorageTrackerNotifications):
171         (TestRunner::clearApplicationCacheForOrigin):
172         (TestRunner::originsWithApplicationCache):
173         (TestRunner::deleteAllLocalStorage):
174         (TestRunner::setStorageDatabaseIdleInterval):
175         (TestRunner::closeIdleLocalStorageDatabases):
176         (TestRunner::originsWithLocalStorage):
177         (TestRunner::deleteLocalStorageForOrigin):
178         (TestRunner::copyDecodedHostName):
179         (TestRunner::copyEncodedHostName):
180         (TestRunner::keepWebHistory):
181         (TestRunner::numberOfPendingGeolocationPermissionRequests):
182         (TestRunner::setAppCacheMaximumSize):
183         (TestRunner::setCustomPolicyDelegate):
184         (TestRunner::goBack):
185         (TestRunner::setDefersLoading):
186         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
187         (TestRunner::setMockDeviceOrientation):
188         (TestRunner::setMockGeolocationPosition):
189         (TestRunner::setMockGeolocationPositionUnavailableError):
190         (TestRunner::setIconDatabaseEnabled):
191         (TestRunner::setMainFrameIsFirstResponder):
192         (TestRunner::setSpatialNavigationEnabled):
193         (TestRunner::setPluginsEnabled):
194         (TestRunner::setAutomaticLinkDetectionEnabled):
195         (TestRunner::setUseDashboardCompatibilityMode):
196         (TestRunner::dispatchPendingLoadRequests):
197         (TestRunner::findString):
198         (TestRunner::setCacheModel):
199         (TestRunner::apiTestNewWindowDataLoadBaseURL):
200         (TestRunner::setWebViewEditable):
201         (TestRunner::authenticateSession):
202         (TestRunner::abortModal):
203         (TestRunner::setSerializeHTTPLoads):
204         (TestRunner::addChromeInputField):
205         (TestRunner::removeChromeInputField):
206         (TestRunner::focusWebView):
207         (TestRunner::setBackingScaleFactor):
208         (TestRunner::grantWebNotificationPermission):
209         (TestRunner::denyWebNotificationPermission):
210         (TestRunner::removeAllWebNotificationPermissions):
211         (TestRunner::simulateWebNotificationClick):
212
213 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
214
215         Add strong typing to RefCounter interface, return value as a bool.
216         https://bugs.webkit.org/show_bug.cgi?id=139776
217
218         Reviewed by Geoff Garen.
219
220         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
221         This means there is no compile time type checking to prevent mistakes. Update the count()
222         method to token<>(), templated on type used to identify the token being returned.
223         Calls to token<T>() will return a result of type RefCounter::Token<T>.
224
225         There are a few problems with the fact the counter will return you an exact count of the
226         number of outstanding tokens:
227           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
228             to do so if the value is only readable as a boolean.
229           - It is desirable to provide the value as an argument to the callback, however to make
230             this useful for integer values it is also necessary to indicate the direction of change
231             (0->1 is often interesting where 2->1 is not).
232           - There is a mismatch between the precision of returning a count, and the inherent
233             imprecision of a token based mechanism, where it may be difficult to guarantee
234             absolutely no unnecessary refcount churn, and thus unintentional counter values.
235
236         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
237         (TestWebKitAPI::TEST):
238             - update API test.
239
240 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
241
242         Disable retries on Mac Release WK2 testers
243         https://bugs.webkit.org/show_bug.cgi?id=139798
244
245         Reviewed by Simon Fraser.
246
247         * BuildSlaveSupport/build.webkit.org-config/config.json:
248
249 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
250
251         Perf tests frequently fail saying "build not up to date"
252         https://bugs.webkit.org/show_bug.cgi?id=139786
253
254         Illegitimately yet authoritatively reviewed by Lucas Forschler.
255
256         Undo the rest of the first fix, and implement the behavior differently.
257
258         is_clean isn't automatically forwarded from config.json to properties.
259
260         * BuildSlaveSupport/build.webkit.org-config/config.json:
261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
262         (CleanBuildUnconditionally):
263         (CleanBuildUnconditionally.start):
264         (DownloadAndPerfTestFactory.__init__):
265         (DownloadAndPerfTestWebKit2Factory.__init__):
266
267 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
268
269         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
270         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
271         found nothing.
272
273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
274         (BuildAndPerfTestFactory):
275         (BuildAndPerfTestWebKit2Factory):
276
277 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
278
279         Perf tests frequently fail saying "build not up to date"
280         https://bugs.webkit.org/show_bug.cgi?id=139786
281
282         Reviewed by Ryosuke Niwa.
283
284         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
285         directory to get rid of stale precompiled headers, and let it rebuild
286         DumpRenderTree each time, that's fast.
287
288         Also, removed unused "build and perf test" code.
289
290         * BuildSlaveSupport/build.webkit.org-config/config.json:
291
292 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
293
294         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
295
296         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
297         it easier to see what steps are missing when running under Windows.
298
299         * DumpRenderTree/win/TestRunnerWin.cpp:
300         (TestRunner::callShouldCloseOnWebView):
301         (TestRunner::clearAllApplicationCaches):
302         (TestRunner::applicationCacheDiskUsageForOrigin):
303         (TestRunner::syncLocalStorage):
304         (TestRunner::localStorageDiskUsageForOrigin):
305         (TestRunner::observeStorageTrackerNotifications):
306         (TestRunner::clearApplicationCacheForOrigin):
307         (TestRunner::originsWithApplicationCache):
308         (TestRunner::clearAllDatabases):
309         (TestRunner::deleteAllLocalStorage):
310         (TestRunner::setStorageDatabaseIdleInterval):
311         (TestRunner::closeIdleLocalStorageDatabases):
312         (TestRunner::originsWithLocalStorage):
313         (TestRunner::deleteLocalStorageForOrigin):
314         (TestRunner::numberOfPendingGeolocationPermissionRequests):
315         (jsStringRefToWString):
316         (TestRunner::setAppCacheMaximumSize):
317         (TestRunner::setDatabaseQuota):
318         (TestRunner::goBack):
319         (TestRunner::setDefersLoading):
320         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
321         (TestRunner::setAutomaticLinkDetectionEnabled):
322         (TestRunner::dispatchPendingLoadRequests):
323         (TestRunner::overridePreference):
324         (TestRunner::removeAllVisitedLinks):
325         (TestRunner::waitForPolicyDelegate):
326         (TestRunner::resetPageVisibility):
327         (TestRunner::setPageVisibility):
328         (TestRunner::grantWebNotificationPermission):
329         (TestRunner::denyWebNotificationPermission):
330         (TestRunner::removeAllWebNotificationPermissions):
331         (TestRunner::simulateWebNotificationClick):
332         (TestRunner::simulateLegacyWebNotificationClick):
333
334 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
335
336         [Win] Correct Windows tests after Bug 139149 (edit)
337         https://bugs.webkit.org/show_bug.cgi?id=139781
338
339         Reviewed by Anders Carlsson.
340
341         * DumpRenderTree/win/TestRunnerWin.cpp:
342         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
343         interface.
344
345 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
346
347         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
348         https://bugs.webkit.org/show_bug.cgi?id=139748
349
350         Reviewed by Daniel Bates.
351         
352         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
353         have all been updated.
354
355         * Scripts/webkitpy/port/factory.py:
356         (platform_options):
357
358 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
359
360         Build more of TestWebKitAPI for iOS
361         https://bugs.webkit.org/show_bug.cgi?id=139747
362
363         Reviewed by Daniel Bates.
364         
365         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
366         which excluded some tests that should be run for iOS.
367         
368         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
369         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
370         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
371         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
372         
373         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
374         to share code between Mac and iOS.
375
376         * TestWebKitAPI/Configurations/Base.xcconfig:
377         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
378         * TestWebKitAPI/InjectedBundleController.cpp:
379         * TestWebKitAPI/InjectedBundleMain.cpp:
380         * TestWebKitAPI/JavaScriptTest.cpp:
381         * TestWebKitAPI/PlatformUtilities.cpp:
382         * TestWebKitAPI/PlatformUtilities.h:
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
385         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
386         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
387         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
388         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
389         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
390         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
391         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
392         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
393         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
394         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
395         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
396         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
397         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
398         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
399         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
400         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
401         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
402         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
403         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
404         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
405         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
406         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
407         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
408         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
409         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
410         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
411         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
412         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
413         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
414         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
415         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
416         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
417         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
418         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
419         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
420         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
421         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
422         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
423         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
424         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
425         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
426         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
427         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
428         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
429         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
430         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
431         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
432         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
433         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
434         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
435         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
436         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
437         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
438         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
439         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
440         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
441         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
442         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
443         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
444         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
445         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
446         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
447         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
448         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
449         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
450         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
451         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
452         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
453         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
454         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
455         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
456         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
457         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
458         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
459         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
460         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
461         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
462         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
465         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
466         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
467         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
468         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
469         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
470         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
471         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
472         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
473         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
474         (TEST):
475         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
476         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
477         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
478         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
479         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
480         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
481         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
482         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
483         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
484         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
485         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
486         (TestWebKitAPI::Util::run):
487         (TestWebKitAPI::Util::sleep):
488         (TestWebKitAPI::Util::toSTD):
489         * TestWebKitAPI/config.h:
490         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
491         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
492         (TestWebKitAPI::Util::run): Deleted.
493         (TestWebKitAPI::Util::sleep): Deleted.
494         (TestWebKitAPI::Util::toSTD): Deleted.
495
496 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
497
498         [GTK] Add support for FTL JIT on ARM64
499         https://bugs.webkit.org/show_bug.cgi?id=139677
500
501         Reviewed by Csaba Osztrogonác.
502
503         * gtk/jhbuild-optional.modules:
504         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
505         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
506
507 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
508
509         [GTK] Implement webkit_web_view_is_playing_audio()
510         https://bugs.webkit.org/show_bug.cgi?id=138918
511
512         Reviewed by Carlos Garcia Campos.
513
514         Add test case case for webkit_web_view_is_playing_audio() and the
515         WebKitWebView::is-playing-audio property.
516
517         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
518         (urlForResource): Utility function to get URLs pointing to resources
519         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
520         (testWebViewIsPlayingAudio): Added.
521         (beforeAll):
522         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
523         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
524         API tests resources directory, or the WebKit2 C API tests resources
525         directory. The default value of the flag is to use the WebKit2 GTK
526         one, to avoid having to change existing tests.
527         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
528         (isPlayingAudioChanged): Added.
529         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
530         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
531
532 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
533
534         [GTK] [EFL] Enable per_test_timeout
535         https://bugs.webkit.org/show_bug.cgi?id=139771
536
537         Reviewed by Csaba Osztrogonác.
538
539         This is needed to make WKTR use either the default port timeout, or the
540         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
541         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
542
543         * Scripts/webkitpy/port/efl.py:
544         (EflPort.supports_per_test_timeout): Enabled.
545         * Scripts/webkitpy/port/gtk.py:
546         (GtkPort.supports_per_test_timeout): Enabled.
547
548 2014-12-17  Lucas Forschler  <lforschler@apple.com>
549
550         Move Apple buildbot slaves to their new home.
551         
552         Reviewed by Roger Fong.
553
554         * BuildSlaveSupport/build.webkit.org-config/config.json:
555
556 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
557
558         REGRESSION (r177363): Gtk and Efl testing is broken
559         https://bugs.webkit.org/show_bug.cgi?id=139734
560
561         Reviewed by Simon Fraser.
562
563         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
564         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
565         affected both script and tool timeout. This is still the right place for this logic,
566         but it would be a larger refactoring than I can do right now.
567
568         * Scripts/webkitpy/port/base.py:
569         (Port.supports_per_test_timeout): Added a FIXME.
570         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
571         to avoid making tests take more time.
572
573         * Scripts/webkitpy/port/driver.py:
574         (Driver.run_test): Adjust script timeout here.
575         (Driver._check_for_driver_timeout): Fix the timeout detection.
576         (Driver._read_block): Actually use the timeout detection code.
577
578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
579         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
580
581         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
582         Update results for the new default.
583
584         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
585         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
586         actually a good one.
587
588 2014-12-17  Commit Queue  <commit-queue@webkit.org>
589
590         Unreviewed, rolling out r177456.
591         https://bugs.webkit.org/show_bug.cgi?id=139749
592
593         Broke webkitpy and Mac tests (Requested by ap on #webkit).
594
595         Reverted changeset:
596
597         "REGRESSION (r177363): Gtk and Efl testing is broken"
598         https://bugs.webkit.org/show_bug.cgi?id=139734
599         http://trac.webkit.org/changeset/177456
600
601 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
602
603         REGRESSION (r177363): Gtk and Efl testing is broken
604         https://bugs.webkit.org/show_bug.cgi?id=139734
605
606         Reviewed by Simon Fraser.
607
608         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
609         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
610         affected both script and tool timeout. This is still the right place for this logic,
611         but it would be a larger refactoring than I can do right now.
612
613         * Scripts/webkitpy/port/base.py:
614         (Port.supports_per_test_timeout): Added a FIXME.
615         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
616         to avoid making tests take more time.
617
618         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
619
620         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
621         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
622
623 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
626         https://bugs.webkit.org/show_bug.cgi?id=139725
627
628         Reviewed by Martin Robinson.
629
630         The timeout is already in milliseconds, so we don't need to do any conversion.
631
632         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
633         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
634
635 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
636
637         [EFL]Fix build warning in MiniBrowser
638         https://bugs.webkit.org/show_bug.cgi?id=139723
639
640         Reviewed by Darin Adler.
641
642         The warning is caused by the compiler wanting the first argument to be a
643         string literal, not a dynamically created string.
644
645         * MiniBrowser/efl/main.c:
646         (quit):
647
648 2014-12-16  Sam Weinig  <sam@webkit.org>
649
650         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
651         https://bugs.webkit.org/show_bug.cgi?id=139718
652
653         Reviewed by Mark Rowe.
654
655         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
656         files into a static lib which the command line utility can link link against.
657         This will allow us to create a TestWebKitAPI.app that can run on iOS.
658
659         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
660         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662
663 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
664
665         Sort out timeout implementations in DRT and WKTR
666         https://bugs.webkit.org/show_bug.cgi?id=139671
667
668         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
669         with the tool.
670
671         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
672         (RunTest.test_hung_thread):
673
674 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
675
676         Sort out timeout implementations in DRT and WKTR
677         https://bugs.webkit.org/show_bug.cgi?id=139671
678
679         Reviewed by Simon Fraser.
680
681         Test timeout implementation had many deficiencies, please see the bug for details.
682         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
683         [ Slow ] modifiers should work a lot better.
684
685         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
686         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
687         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
688         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
689         DumpRenderTree already read the --timeout option from command line, and webkitpy
690         was already configured to pass it on Mac and iOS. Let's actually use it.
691         TestCommand already had the same 30 second default, so this doesn't change behavior
692         when DRT is ran manually without the option.
693         Windows DumpRenderTree will need to be fixed separately (that's easy).
694
695         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
696         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
697         slightly better to use stderr in both, as this is an out of band message, but
698         that's a larger refactoring, and the difference is minimal in practice.
699
700         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
701         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
702         different. We want the tool to reliably detect timeouts that can be detected, and
703         not race with the script for that.
704
705         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
706         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
707         is honored inmore cases, that could make tests run slower.
708         * Scripts/webkitpy/port/driver.py:
709         (Driver.__init__):
710         (Driver.run_test):
711         (Driver.cmd_line):
712         (Driver._check_for_driver_timeout):
713         Detect tests that have the timeout output, and make these have the proper Timeout result.
714
715         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
716         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
717
718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
719         (WTR::TestRunner::setCustomTimeout): Deleted.
720         * WebKitTestRunner/InjectedBundle/TestRunner.h:
721         (WTR::TestRunner::setCustomTimeout):
722         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
723         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
724         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
725         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
726         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
727         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
728         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
729         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
730         Updated to use a timeout passed from UI process, which used to be ignored.
731
732         * WebKitTestRunner/TestController.cpp:
733         (WTR::TestController::TestController):
734         (WTR::TestController::runUntil):
735         (WTR::TestController::getCustomTimeout): Deleted.
736         * WebKitTestRunner/TestController.h:
737         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
738         Changed default message timeouts to match new run-webkit-tests timeout. These don't
739         affect ports where timeout is passed per test (shouldn't they all be like that?).
740
741         * WebKitTestRunner/TestInvocation.cpp:
742         (WTR::TestInvocation::invoke):
743         (WTR::TestInvocation::setCustomTimeout): Deleted.
744         * WebKitTestRunner/TestInvocation.h:
745         (WTR::TestInvocation::setCustomTimeout):
746         (WTR::TestInvocation::customTimeout):
747         Ditto.
748
749 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
750
751         [EFL] Add logging domain for MiniBrowser
752         https://bugs.webkit.org/show_bug.cgi?id=139642
753
754         Reviewed by Gyuyoung Kim.
755
756         Similarly to EWebKit2, provide logging facility for MiniBrowser
757         based on Eina Log module to have a convenient way to display
758         all/subset/none messages for EFL based libraries and MiniBrowser.
759
760         Usage:
761         1. Disable all messages:
762            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
763
764         2. Enable all messages:
765            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
766
767         3. Enable MiniBrowser and EWebkit2 messages only:
768            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
769
770         More information and examples you can find here:
771         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
772
773         * MiniBrowser/efl/main.c:
774         (on_mouse_wheel):
775         (on_window_resize):
776         (save_page_contents_callback):
777         (script_execute_callback):
778         (on_key_down):
779         (on_download_request):
780         (on_download_finished):
781         (on_download_failed):
782         (quit):
783         (on_refresh_button_clicked):
784         (on_stop_button_clicked):
785         (navigation_button_longpress_process):
786         (on_popup_menu_item_clicked):
787         (popup_menu_populate):
788         (on_popup_menu_show):
789         (on_window_create):
790         (context_menu_item_selected_cb):
791         (context_menu_populate):
792         (on_context_menu_show):
793         (on_context_menu_hide):
794         (on_navigation_policy_decision):
795         (window_create):
796         (parse_cookies_policy):
797         (elm_main):
798         (has_scheme):
799         (list_item_label_get):
800         (on_popup_menu_hide):
801         (on_window_close):
802         (on_home_button_clicked):
803         Replace locally info() macro with newly introduced
804         one which uses Eina Log module. There is no logic change.
805
806 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
807
808         [EFL] FTL JIT not working on ARM64
809         https://bugs.webkit.org/show_bug.cgi?id=139295
810
811         Reviewed by Michael Saboff.
812
813         Added patches for llvm to add ARM64 support for FTL JIT
814
815         * efl/jhbuild.modules:
816         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
817         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
818
819 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
820
821         Move Said to the committers section.
822
823         * Scripts/webkitpy/common/config/contributors.json:
824
825 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
826
827         Implement Data Detectors immediate actions for WebKit2
828         https://bugs.webkit.org/show_bug.cgi?id=139617
829         <rdar://problem/19198539>
830
831         Reviewed by Beth Dakin.
832
833         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
834         (TestWebKitAPI::TEST):
835         Temporarily disable the action menu tests while the
836         underlying code is in flux.
837
838 2014-12-14  Andreas Kling  <akling@apple.com>
839
840         Replace PassRef with Ref/Ref&& across the board.
841         <https://webkit.org/b/139587>
842
843         Reviewed by Darin Adler.
844
845         * TestWebKitAPI/Tests/WTF/Ref.cpp:
846         (TestWebKitAPI::passWithRef):
847         (TestWebKitAPI::TEST):
848         (TestWebKitAPI::passWithPassRef): Deleted.
849         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
850         (TestWebKitAPI::TEST):
851         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
852         (TestWebKitAPI::TEST):
853         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
854         (TestWebKitAPI::createTestValue):
855
856 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
857
858         [EFL] MiniBrowser's window_create may return NULL
859         https://bugs.webkit.org/show_bug.cgi?id=139585
860
861         Reviewed by Gyuyoung Kim.
862
863         Move NULL checking before using object which window_create
864         returns.
865
866         * MiniBrowser/efl/main.c:
867         (elm_main):
868
869 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
870
871         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
872         https://bugs.webkit.org/show_bug.cgi?id=73030
873
874         Reviewed by Anders Carlsson.
875
876         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
877         database to empty to avoid having it fetch default favicons at random times.
878         DumpRenderTree also disables it, and also it has a way for tests to temporarily
879         enable it.
880
881 2014-12-12  Lucas Forschler  <lforschler@apple.com>
882
883         Update Apple owned build slaves after infrastructure update.
884         
885         Reviewed by Ryosuke Niwa.
886
887         * BuildSlaveSupport/build.webkit.org-config/config.json:
888
889 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
890
891         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
892         https://bugs.webkit.org/show_bug.cgi?id=139537
893
894         Reviewed by Carlos Garcia Campos.
895
896         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
897         of get_dependencies_path().
898         * jhbuild/jhbuildutils.py:
899         (get_dependencies_path): Fix the function to return the new
900         dependencies path: DependenciesPORT.
901         (enter_jhbuild_environment_if_available): Pass the port name
902         when invoking get_dependencies_path().
903
904 2014-12-10  Lucas Forschler  <lforschler@apple.com>
905
906         Update Apple owned build slaves.
907         
908         Rubber-stamped by Dana Burkart.
909         
910         * BuildSlaveSupport/build.webkit.org-config/config.json:
911
912 2014-12-10  Daniel Bates  <dabates@apple.com>
913
914         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
915         timeout instead of test failure
916         https://bugs.webkit.org/show_bug.cgi?id=139525
917
918         Reviewed by Zalan Bujtas.
919
920         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
921         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
922         output.
923
924         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
925         for the WebThread to spin its run loop before dumping its output. A test that
926         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
927         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
928         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
929         because run-webkit-tests may terminate a DumpRenderTree.app process when it
930         exceeds its process time limit (defaults to 35ms) regardless of whether such
931         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
932
933         * Scripts/webkitpy/port/ios.py:
934         (IOSSimulatorPort.default_timeout_ms):
935
936 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
937
938         [GTK][WK2] Add HTML5 Notifications support
939         https://bugs.webkit.org/show_bug.cgi?id=61140
940
941         Reviewed by Carlos Garcia Campos.
942
943         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
944         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
945         (testWebViewNotification):
946         (beforeAll):
947         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
948         (permissionRequestDialogCallback):
949         (webViewDecidePermissionRequest):
950         (geolocationRequestDialogCallback): Deleted.
951
952 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
953
954         Fix webkitpy test expectation
955
956         Not sure what I messed up, but TOTAL_SKIPS was not right.
957
958         * Scripts/webkitpy/port/test.py:
959
960 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
961
962         Remove virtual test support from webkitpy
963         https://bugs.webkit.org/show_bug.cgi?id=139427
964
965         Reviewed by Alexey Proskuryakov.
966
967         It seems that the only concrete client of virtual tests is the unit tests :D
968
969         This patch tries to clean as much useless code as possible.
970
971         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
972         (RunTest.test_tolerance):
973         (RunTest.test_virtual): Deleted.
974         * Scripts/webkitpy/layout_tests/views/printing.py:
975         (Printer._print_test_trace):
976         * Scripts/webkitpy/port/base.py:
977         (Port.expected_filename):
978         (Port.tests):
979         (Port.test_isfile):
980         (Port.test_isdir):
981         (Port.sample_process):
982         (Port.find_system_pid):
983         (Port.test_expectations_file_position):
984         (Port.virtual_test_suites): Deleted.
985         (Port): Deleted.
986         (Port.populated_virtual_test_suites): Deleted.
987         (Port._virtual_tests): Deleted.
988         (Port.lookup_virtual_test_base): Deleted.
989         (Port.lookup_virtual_test_args): Deleted.
990         (VirtualTestSuite): Deleted.
991         (VirtualTestSuite.__init__): Deleted.
992         (VirtualTestSuite.__repr__): Deleted.
993         * Scripts/webkitpy/port/base_unittest.py:
994         (PortTest.test_test_exists):
995         (PortTest.test_test_isfile):
996         (PortTest.test_test_isdir):
997         (PortTest.test_tests):
998         * Scripts/webkitpy/port/driver.py:
999         (DriverProxy.run_test): Deleted.
1000         * Scripts/webkitpy/port/test.py:
1001         (TestPort._skipped_tests_for_unsupported_features):
1002         (TestPort.all_baseline_variants):
1003         (TestPort.virtual_test_suites): Deleted.
1004         * Scripts/webkitpy/tool/commands/queries.py:
1005         (PrintBaselines.__init__):
1006         (PrintBaselines.execute):
1007         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1008         (PrintBaselinesTest.test_basic):
1009         (PrintBaselinesTest.test_multiple):
1010         (PrintBaselinesTest.test_csv):
1011
1012 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1013
1014         Blink Merge: Remove 'http_lock' code from webkitpy
1015         https://bugs.webkit.org/show_bug.cgi?id=136722
1016
1017         Reviewed by Alexey Proskuryakov.
1018
1019         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
1020         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
1021
1022         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1023         (LayoutTestRunner.__init__):
1024         (LayoutTestRunner.run_tests):
1025         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
1026         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
1027         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1028         (FakePrinter.flush):
1029         (LayoutTestRunnerTests._runner):
1030         (LayoutTestRunnerTests._run_tests):
1031         (LayoutTestRunnerTests.test_servers_started):
1032         (LockCheckingRunner): Deleted.
1033         (LockCheckingRunner.__init__): Deleted.
1034         (LockCheckingRunner.handle_finished_list): Deleted.
1035         (LayoutTestRunnerTests.test_http_locking): Deleted.
1036         * Scripts/webkitpy/port/base.py:
1037         (Port.__init__):
1038         (Port.to.http_server_supports_ipv6):
1039         (Port.to.stop_websocket_server):
1040         (Port.to.acquire_http_lock): Deleted.
1041         (Port.to.release_http_lock): Deleted.
1042         * Scripts/webkitpy/port/http_lock.py: Removed.
1043         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
1044         * Scripts/webkitpy/port/ios.py:
1045         (IOSSimulatorPort.show_results_html_file):
1046         (IOSSimulatorPort.acquire_http_lock): Deleted.
1047         (IOSSimulatorPort): Deleted.
1048         (IOSSimulatorPort.release_http_lock): Deleted.
1049         * Scripts/webkitpy/port/mac.py:
1050         (MacPort.show_results_html_file):
1051         (MacPort): Deleted.
1052         (MacPort.acquire_http_lock): Deleted.
1053         (MacPort.release_http_lock): Deleted.
1054         * Scripts/webkitpy/port/mock_drt.py:
1055         (MockDRTPort.start_websocket_server):
1056         (MockDRTPort.stop_websocket_server):
1057         (MockDRTPort.acquire_http_lock): Deleted.
1058         (MockDRTPort.release_http_lock): Deleted.
1059         * Scripts/webkitpy/port/mock_drt_unittest.py:
1060         (MockDRTPortTest.test_uses_apache):
1061         (MockDRTPortTest.integration_test_http_lock): Deleted.
1062         * Scripts/webkitpy/port/port_testcase.py:
1063         (PortTestCase.assert_servers_are_up):
1064         (PortTestCase.integration_test_http_lock): Deleted.
1065         * Scripts/webkitpy/port/test.py:
1066         (TestPort.start_websocket_server):
1067         (TestPort.stop_websocket_server):
1068         (TestPort.acquire_http_lock): Deleted.
1069         (TestPort.release_http_lock): Deleted.
1070
1071 2014-12-09  Alberto Garcia  <berto@igalia.com>
1072
1073         convertToUTF8String converts null string to empty string
1074         https://bugs.webkit.org/show_bug.cgi?id=133904
1075
1076         Reviewed by Carlos Garcia Campos.
1077
1078         Test that trying to get the value of a non-existent attribute
1079         returns 0 instead of an empty string.
1080
1081         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1082         (WebKitDOMNodeTest::testInsertion):
1083
1084 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1085
1086         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
1087         https://bugs.webkit.org/show_bug.cgi?id=139070
1088
1089         Reviewed by Carlos Garcia Campos.
1090
1091         * gtk/jhbuild.modules:
1092
1093 2014-12-08  Tim Horton  <timothy_horton@apple.com>
1094
1095         Add action menu tests
1096         https://bugs.webkit.org/show_bug.cgi?id=139156
1097
1098         Reviewed by Dean Jackson.
1099
1100         * TestWebKitAPI/PlatformWebView.h:
1101         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1102         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1103         Add a mechanism allowing tests to provide their own WKView subclass.
1104
1105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1106         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
1107         Add a file with lots of menu targets.
1108
1109         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
1110         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1111         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
1112         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1113         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
1114
1115         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
1116
1117         (TestWebKitAPI::didFinishLoadForFrameCallback):
1118         (TestWebKitAPI::didFinishDownloadCallback):
1119         (TestWebKitAPI::didCreateDownloadDestinationCallback):
1120         Watch downloads and ensure that they match the content we expect.
1121
1122         (TestWebKitAPI::watchPasteboardForString):
1123         (TestWebKitAPI::watchPasteboardForImage):
1124         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
1125         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
1126         (TestWebKitAPI::javaScriptStringCallback):
1127         (TestWebKitAPI::javaScriptBoolCallback):
1128         (TestWebKitAPI::callJavaScriptReturningString):
1129         (TestWebKitAPI::callJavaScriptReturningBool):
1130         (TestWebKitAPI::watchEditableAreaForString):
1131         (TestWebKitAPI::waitForVideoReady):
1132         (TestWebKitAPI::retrieveSelection):
1133         (TestWebKitAPI::retrieveSelectionInElement):
1134         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
1135         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
1136         Add many helpers for testing, especially to make asynchronous things synchronous.
1137
1138         (TestWebKitAPI::windowPointForTarget):
1139         (TestWebKitAPI::inset8):
1140         Hard-code points in action-menu-targets.html for hit testing.
1141
1142         (TestWebKitAPI::TEST):
1143         Add a suite of tests for WebKit2 action menus.
1144
1145         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
1146         (TestWebKitAPI::createActionContextForPhoneNumber):
1147         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
1148         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
1149         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1150         (TestWebKitAPI::ActionMenuTest::drawRect):
1151         (TestWebKitAPI::ActionMenuTest::didCreatePage):
1152         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
1153         so that we can test that infrastructure.
1154
1155 2014-12-08  Philippe Normand  <pnormand@igalia.com>
1156
1157         [GTK] UserMedia Permission Request API
1158         https://bugs.webkit.org/show_bug.cgi?id=136449
1159
1160         Reviewed by Carlos Garcia Campos.
1161
1162         The GTK version of the MiniBrowser has gained UserMedia permission
1163         request support.
1164
1165         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
1166         requires user permission to access audio/video devices.
1167         (permissionRequestDialogCallback):
1168         (webViewDecidePermissionRequest):
1169         (geolocationRequestDialogCallback): Deleted.
1170
1171 2014-12-08  Anders Carlsson  <andersca@apple.com>
1172
1173         Add a stubbed out method for clearing out the website data store
1174         https://bugs.webkit.org/show_bug.cgi?id=139404
1175
1176         Reviewed by Antti Koivisto.
1177
1178         Add a debug menu item for testing clearing of website data.
1179
1180         * MiniBrowser/mac/MainMenu.xib:
1181         * MiniBrowser/mac/WK2BrowserWindowController.m:
1182         (-[WK2BrowserWindowController clearWebsiteData:]):
1183
1184 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
1185
1186         Update style checker to deal with "const override"
1187         https://bugs.webkit.org/show_bug.cgi?id=139371
1188
1189         Reviewed by Csaba Osztrogonác.
1190
1191         check-webkit-style shouldn't complain about an open brace to start a
1192         line after a function definition with const override.
1193
1194         * Scripts/webkitpy/style/checkers/cpp.py:
1195         (check_braces):
1196         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1197         (CppStyleTest.test_brace_at_begin_of_line):
1198
1199 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201         [GTK] Fix GObject DOM bindings API break tests after r176920
1202         https://bugs.webkit.org/show_bug.cgi?id=139368
1203
1204         Reviewed by Gustavo Noronha Silva.
1205
1206         Remove the @version from the symbol name before comparing.
1207
1208         * gtk/check-for-webkitdom-api-breaks:
1209         (read_expected_api):
1210
1211 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1212
1213         Remove the option to automatically update the GObject DOM bindings symbols file
1214         https://bugs.webkit.org/show_bug.cgi?id=139366
1215
1216         Reviewed by Martin Robinson.
1217
1218         It's currently broken, because symbols now need to be in a
1219         specific order. Now that the symbols file only contains stable
1220         API, it's not a problem to manually update it every time new API
1221         is added.
1222
1223         * gtk/check-for-webkitdom-api-breaks:
1224         (read_expected_api):
1225         (check_api):
1226         (write_expected_api): Deleted.
1227
1228 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1229
1230         [GTK] Use GMainLoopSource in WebKitTestRunner
1231         https://bugs.webkit.org/show_bug.cgi?id=138831
1232
1233         Reviewed by Sergio Villar Senin.
1234
1235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1236         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1237         (WTR::TestRunner::platformInitialize):
1238         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1239         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1240         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1241         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1242         (WTR::TestController::notifyDone):
1243         (WTR::TestController::platformRunUntil):
1244         (WTR::cancelTimeout): Deleted.
1245
1246 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         [GTK] Missing API detected in GObject DOM bindings after r176630
1249         https://bugs.webkit.org/show_bug.cgi?id=139201
1250
1251         Reviewed by Gustavo Noronha Silva.
1252
1253         Handle deprecated symbols again when generating the GObject DOM
1254         bindings documentation.
1255
1256         * gtk/webkitdom.py:
1257         (WebKitDOMDocGenerator):
1258         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
1259         (WebKitDOMDocGenerator.generate):
1260         (WebKitDOMDocGeneratorSections.__init__):
1261         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
1262         (WebKitDOMDocGeneratorSections.write_section):
1263
1264 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1265
1266         [EFL][jhbuild] Fix libsoup build with clang
1267         https://bugs.webkit.org/show_bug.cgi?id=139088
1268
1269         Reviewed by Gyuyoung Kim.
1270
1271         * efl/jhbuild.modules:
1272         * efl/patches/soup-clang-warning-fix1.patch: Added.
1273         * efl/patches/soup-clang-warning-fix2.patch: Added.
1274
1275 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
1276
1277         [Mac] DumpRenderTree sets storage directory incorrectly
1278         https://bugs.webkit.org/show_bug.cgi?id=139347
1279
1280         Reviewed by Dan Bernstein.
1281
1282         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1283         Don't use user defaults to pass per-instance paths, as user defaults are shared
1284         across all instances.
1285
1286 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
1287
1288         AX: I cannot activate links on the mobile version of news.google.com
1289         https://bugs.webkit.org/show_bug.cgi?id=139330
1290
1291         Reviewed by Simon Fraser.
1292
1293         Implement press for iOS.
1294
1295         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1296         (AccessibilityUIElement::press):
1297
1298 2014-12-05  Daniel Bates  <dabates@apple.com>
1299
1300         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
1301         https://bugs.webkit.org/show_bug.cgi?id=139326
1302
1303         Reviewed by Anders Carlsson.
1304
1305         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
1306         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
1307         using the same scale factor as used in WebKit.
1308
1309         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1310         (createBitmapContextFromWebView):
1311
1312 2014-12-05  Anders Carlsson  <andersca@apple.com>
1313
1314         REGRESSION (r176677): All tests crash on Windows
1315         https://bugs.webkit.org/show_bug.cgi?id=139321
1316
1317         Reviewed by Alexey Proskuryakov.
1318
1319         * DumpRenderTree/win/DumpRenderTree.cpp:
1320         (runTest):
1321         Don't call CFRelease on the url while we have an outstanding pointer to its string,
1322         and use the right number of bytes when allocating the testURL buffer.
1323
1324 2014-12-05  Daniel Bates  <dabates@apple.com>
1325
1326         [iOS] DumpRenderTree produces many reference test mismatches
1327         https://bugs.webkit.org/show_bug.cgi?id=139314
1328
1329         Reviewed by Simon Fraser.
1330
1331         Fixes an issue where the scale factor used to render the snapshot taken by
1332         DumpRenderTree may differ from the device scale factor. In particular, the
1333         scale factor used to render a snapshot of a test may differ from the scale
1334         factor used to render the snapshot of its expected result.
1335
1336         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
1337         snapshot the UIWebBrowserView. This SPI always render using a scale factor
1338         of one when the backing store for the LegacyTileLayer objects were out-of-
1339         date regardless of the device scale factor. Instead we should use UIImage
1340         and CALayer API to perform the snapshot with respect to the device scale
1341         factor.
1342
1343         Additionally write iOS pixel dump support logic in terms of existing
1344         DumpRenderTree abstractions so as to support generating and comparing
1345         pixel dump checksums as well as make the iOS code more consistent with
1346         the logic used by other ports.
1347
1348         * DumpRenderTree/PixelDumpSupport.cpp:
1349         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
1350         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1351         (BitmapContext::createFromUIImage): Added.
1352         (BitmapContext::pixelData): Added.
1353         (BitmapContext::BitmapContext): Added.
1354         (computeMD5HashStringForBitmapContext): Added.
1355         (dumpBitmap): Added.
1356         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
1357         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
1358
1359 2014-12-05  Anders Carlsson  <andersca@apple.com>
1360
1361         Give all web pages a website data store
1362         https://bugs.webkit.org/show_bug.cgi?id=139317
1363
1364         Reviewed by Tim Horton.
1365
1366         * MiniBrowser/mac/AppDelegate.m:
1367         (-[BrowserAppDelegate newPrivateWindow:]):
1368         Don't release the controller - it's implicitly retained by the window.
1369
1370 2014-12-05  Daniel Bates  <dabates@apple.com>
1371
1372         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
1373         https://bugs.webkit.org/show_bug.cgi?id=137581
1374         <rdar://problem/18642906>
1375
1376         Reviewed by Simon Fraser.
1377
1378         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
1379         of the test that proceeded the currently running test.
1380
1381         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1382         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
1383         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
1384         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
1385
1386 2014-12-05  Jer Noble  <jer.noble@apple.com>
1387
1388         [WTF] MediaTime should support round-tripping from and to doubles.
1389         https://bugs.webkit.org/show_bug.cgi?id=139248
1390
1391         Reviewed by Eric Carlson.
1392
1393         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
1394         the MediaTimes after this change.
1395
1396         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1397         (WTF::operator<<):
1398         (TestWebKitAPI::TEST):
1399         * lldb/lldb_webkit.py:
1400         (WTFMediaTime_SummaryProvider):
1401         (WTFMediaTimeProvider.timeValueAsDouble):
1402         (WTFMediaTimeProvider.isIndefinite):
1403         (WTFMediaTimeProvider):
1404         (WTFMediaTimeProvider.hasDoubleValue):
1405
1406 2014-12-05  Anders Carlsson  <andersca@apple.com>
1407
1408         Add a private browsing mode to MiniBrowser
1409         https://bugs.webkit.org/show_bug.cgi?id=139308
1410
1411         Reviewed by Sam Weinig.
1412
1413         * MiniBrowser/mac/AppDelegate.m:
1414         (defaultConfiguration):
1415         (-[BrowserAppDelegate newWindow:]):
1416         (-[BrowserAppDelegate newPrivateWindow:]):
1417         * MiniBrowser/mac/MainMenu.xib:
1418         * MiniBrowser/mac/WK2BrowserWindowController.h:
1419         * MiniBrowser/mac/WK2BrowserWindowController.m:
1420         (-[WK2BrowserWindowController awakeFromNib]):
1421         (-[WK2BrowserWindowController initWithConfiguration:]):
1422         (-[WK2BrowserWindowController dealloc]):
1423         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1424
1425 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1426
1427         Run http tests parallel
1428         https://bugs.webkit.org/show_bug.cgi?id=138958
1429
1430         Reviewed by Daniel Bates.
1431
1432         Remove the concept of "locked shard". Now http tests are just like any other tests.
1433         We start HTTP and WebSocket servers at the start if we need them, and terminate them
1434         when done with all the tests (not when the last http test runs, which is unnecessarily
1435         unpredictable).
1436
1437         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
1438         patch, they used to take over 15 minutes.
1439
1440         As part of the fix, we no longer pass the number of servers to Apache. I don't
1441         think that these parameters did what we wanted them to do; Apache handles the load
1442         just fine without them.
1443
1444         The change applies to all platforms. I fixed everything I could find on Mac, and
1445         Ossy told me that he's been running http tests in parallel for a long time. If
1446         there is increased instability for some ports, it will need to be fixed - there is
1447         generally nothing special about http tests at this point, and most code is
1448         cross-platform in WebKit2.
1449
1450         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1451         (LayoutTestRunner.__init__):
1452         (LayoutTestRunner.run_tests):
1453         (LayoutTestRunner.start_servers_with_lock):
1454         (LayoutTestRunner._handle_started_test):
1455         (Worker.handle):
1456         (Sharder.__init__):
1457         (Sharder.shard_tests):
1458         (Sharder._shard_every_file):
1459         (Sharder._shard_by_directory):
1460         (LayoutTestRunner._handle_finished_test_list): Deleted.
1461         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
1462         (Sharder._shard_in_two): Deleted.
1463         (Sharder): Deleted.
1464         (Sharder._resize_shards): Deleted.
1465         (Sharder._resize_shards.divide_and_round_up): Deleted.
1466         (Sharder._resize_shards.extract_and_flatten): Deleted.
1467         (Sharder._resize_shards.split_at): Deleted.
1468         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1469         (FakePrinter.print_workers_and_shards):
1470         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1471         (LayoutTestRunnerTests.test_servers_started):
1472         (SharderTests.get_shards):
1473         (SharderTests.test_shard_by_dir):
1474         (SharderTests.test_shard_every_file):
1475         (SharderTests): Deleted.
1476         (SharderTests.test_shard_in_two): Deleted.
1477         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
1478         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
1479         (SharderTests.test_multiple_locked_shards): Deleted.
1480         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1481         (ManagerTest.test_needs_servers.get_manager):
1482         (ManagerTest.integration_test_needs_servers.get_manager):
1483         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1484         (ManagerTest):
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1486         (_set_up_derived_options):
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1488         (RunTest.test_batch_size):
1489         (RunTest.test_max_locked_shards): Deleted.
1490         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1491         (LayoutTestApacheHttpd.__init__):
1492         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1493         (TestLayoutTestApacheHttpd.test_start_cmd):
1494         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1495         (Lighttpd.__init__):
1496         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1497         (HttpServerBase.__init__):
1498         * Scripts/webkitpy/layout_tests/views/printing.py:
1499         (Printer.print_workers_and_shards):
1500         * Scripts/webkitpy/port/base.py:
1501         (Port.default_child_processes):
1502         (Port.to.start_http_server):
1503         (Port.default_max_locked_shards): Deleted.
1504         * Scripts/webkitpy/port/port_testcase.py:
1505         (PortTestCase.make_port):
1506         (PortTestCase.test_default_max_locked_shards): Deleted.
1507         * Scripts/webkitpy/port/test.py:
1508         (TestPort.start_http_server):
1509
1510 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1511
1512         Don't lock perf tests in run-webkit-tests
1513         https://bugs.webkit.org/show_bug.cgi?id=139264
1514
1515         Reviewed by Daniel Bates.
1516
1517         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1518         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1519         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1520         * Scripts/webkitpy/layout_tests/models/test_input.py:
1521         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1522
1523 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
1524
1525         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
1526         https://bugs.webkit.org/show_bug.cgi?id=139243
1527
1528         Reviewed by Anders Carlsson.
1529
1530         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
1531         chance to allow untrusted certificates.
1532
1533         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
1534         Set up more client objects for secondary windows. We may be able to share some of the
1535         code with main view creation function, but it's not exactly the same (notably, we
1536         do not focus a secondary window when it's done loading).
1537
1538 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
1539
1540         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
1541         https://bugs.webkit.org/show_bug.cgi?id=139071
1542
1543         Reviewed by Chris Fleizach.
1544
1545         Add string value for ATK_ROLE_STATIC in roleToString.
1546
1547         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1548
1549 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
1550
1551         check-webkit-style is confused by ternary expression inside first member initializer
1552         https://bugs.webkit.org/show_bug.cgi?id=136442
1553
1554         Reviewed by Csaba Osztrogonác.
1555
1556         * Scripts/webkitpy/style/checkers/cpp.py:
1557         (check_member_initialization_list):
1558
1559 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1560
1561         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
1562         https://bugs.webkit.org/show_bug.cgi?id=139220
1563
1564         Reviewed by Philippe Normand.
1565
1566         * gtk/jhbuild.modules:
1567         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1568
1569 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1570
1571         Remove unused JSC runtime options
1572         https://bugs.webkit.org/show_bug.cgi?id=133070
1573
1574         Reviewed by Csaba Osztrogonác.
1575
1576         * Scripts/run-jsc-stress-tests:
1577
1578 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1579
1580         [EFL] Add subtle crypto to the build system
1581         https://bugs.webkit.org/show_bug.cgi?id=138612
1582
1583         Reviewed by Csaba Osztrogonác.
1584
1585         * Scripts/webkitperl/FeatureList.pm:
1586
1587 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
1588
1589         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
1590         https://bugs.webkit.org/show_bug.cgi?id=139005
1591
1592         Reviewed by Chris Fleizach.
1593
1594         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1595         Add mapping for ATK_ROLE_CAPTION to roleToString
1596
1597 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1598
1599         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1600         https://bugs.webkit.org/show_bug.cgi?id=139149
1601
1602         Reviewed by Anders Carlsson.
1603
1604         WebKit2 already cleared application caches between runs (although it wasn't entirely
1605         effective without WebCore changes in this patch).
1606
1607         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
1608
1609         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
1610         function is not implemented on Windows, see below).
1611
1612         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
1613         Ameded a FIXME.
1614
1615 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
1616
1617         Generalize PageActivityAssertionToken
1618         https://bugs.webkit.org/show_bug.cgi?id=139106
1619
1620         Reviewed by Sam Weinig.
1621
1622         Add an API test for WTF::RefCounter.
1623
1624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1625         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
1626         (TestWebKitAPI::TEST):
1627             - added RefCounter test.
1628
1629 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1630
1631         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
1632         https://bugs.webkit.org/show_bug.cgi?id=139174
1633
1634         Reviewed by Simon Fraser.
1635
1636         * DumpRenderTree/TestRunner.cpp:
1637         * DumpRenderTree/TestRunner.h:
1638         Renamed testPathOrURL to testURL, because this variable always contains a URL.
1639
1640         * DumpRenderTree/mac/DumpRenderTree.mm:
1641         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
1642         (testPathFromURL): Moved from FrameLoadDelegate.mm.
1643         (runTest): Set crash reporter information here, as we know the exact test URL.
1644
1645         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1646         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
1647         reporter information here.
1648
1649         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1650         * DumpRenderTree/mac/TestRunnerMac.mm:
1651         Updated for testPathOrURL renaming.
1652
1653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1654         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
1655         test URL until load starts, so save it into TestRunner now. A new TestRunner object
1656         is created for each test.
1657
1658         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1659         (WTR::TestRunner::testURL):
1660         (WTR::TestRunner::setTestURL):
1661         Make TestRunner know the test name. For now, it's good enough to have it once load
1662         starts, but if we ever need it earlier, we can send it with BeginTest message.
1663
1664         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1665         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1666         Use test URL, not currently loading URL for CrashReporter.
1667
1668         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1669         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
1670         (WebKit1 already had it right).
1671
1672         * DumpRenderTree/win/DumpRenderTree.cpp:
1673         (sizeWebViewForCurrentTest):
1674         (runTest):
1675         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1676         (ResourceLoadDelegate::willSendRequest):
1677         Changed Windows DumpRenderTree to also use URL in TestRunner.
1678
1679 2014-12-02  Daniel Bates  <dabates@apple.com>
1680
1681         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
1682         https://bugs.webkit.org/show_bug.cgi?id=139143
1683
1684         Reviewed by David Kilzer.
1685
1686         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
1687         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
1688         crashes. Run-webkit-tests will record as crashing the test associated with the
1689         DumpRenderTree instance that wrote that string.
1690
1691         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
1692         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
1693         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
1694         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
1695         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
1696         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
1697         about a crash.
1698
1699         Additionally, update the crash message format written to standard error when LayoutTestRelay
1700         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
1701         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
1702         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
1703         when they crash in their test machinery logic/UI process code.
1704
1705         * DumpRenderTree/mac/DumpRenderTree.mm:
1706         (writeCrashedMessageOnFatalError): Added.
1707         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
1708         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
1709         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1710         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
1711         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
1712         the crash logs for WebKitTestRunner/DumpRenderTree.app.
1713         * Scripts/webkitpy/port/driver.py:
1714         (Driver.__init__): Update comment.
1715         (Driver._check_for_driver_crash): Ditto.
1716         * Scripts/webkitpy/port/ios.py:
1717         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
1718         regular expression. This constant is used as an optimization to avoid compiling the same
1719         regular expression across invocations of _get_crash_log().
1720         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
1721         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
1722         closer to where they are used.
1723
1724 2014-12-01  Anders Carlsson  <andersca@apple.com>
1725
1726         Remove WKBundleRemoveAllVisitedLinks
1727         https://bugs.webkit.org/show_bug.cgi?id=139163
1728
1729         Reviewed by Sam Weinig.
1730
1731         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
1732
1733         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1734         (WTR::InjectedBundle::beginTesting):
1735         * WebKitTestRunner/TestInvocation.cpp:
1736         (WTR::TestInvocation::invoke):
1737
1738 2014-12-02  Anders Carlsson  <andersca@apple.com>
1739
1740         Fix Windows build.
1741
1742         * DumpRenderTree/win/DumpRenderTree.cpp:
1743         (setAlwaysAcceptCookies):
1744
1745 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1746
1747         [EFL] Remove edbus dependency from jhbuild
1748         https://bugs.webkit.org/show_bug.cgi?id=139130
1749
1750         Reviewed by Gyuyoung Kim.
1751
1752         After http://trac.webkit.org/changeset/176555 we
1753         don't need it anymore.
1754
1755         * efl/jhbuild.modules:
1756
1757 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1758
1759         [jhbuild] wrong Dependencies path
1760         https://bugs.webkit.org/show_bug.cgi?id=139176
1761
1762         Reviewed by Martin Robinson.
1763
1764         * Scripts/webkitpy/port/base.py:
1765         (Port._should_use_jhbuild):
1766
1767 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1768
1769         [GStreamer] Bump internal jhbuild versions to 1.4.4
1770         https://bugs.webkit.org/show_bug.cgi?id=138866
1771
1772         Reviewed by Carlos Garcia Campos.
1773
1774         * gtk/jhbuild.modules:
1775         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1776         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1777         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1778
1779 2014-12-01  Commit Queue  <commit-queue@webkit.org>
1780
1781         Unreviewed, rolling out r176566.
1782         https://bugs.webkit.org/show_bug.cgi?id=139124
1783
1784         It broke the GTK performance tests. (Requested by clopez on
1785         #webkit).
1786
1787         Reverted changeset:
1788
1789         "[GTK] Use GMainLoopSource in WebKitTestRunner"
1790         https://bugs.webkit.org/show_bug.cgi?id=138831
1791         http://trac.webkit.org/changeset/176566
1792
1793 2014-11-29  Anders Carlsson  <andersca@apple.com>
1794
1795         Crash when calling WKPageClose on the originated page from within createNewPage callback
1796         https://bugs.webkit.org/show_bug.cgi?id=139099
1797         <rdar://problem/19052564>
1798
1799         Reviewed by Sam Weinig.
1800
1801         Add a test.
1802
1803         * TestWebKitAPI/PlatformWebView.h:
1804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1805         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
1806         (TestWebKitAPI::runJavaScriptAlert):
1807         (TestWebKitAPI::createNewPage):
1808         (TestWebKitAPI::TEST):
1809         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
1810         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1811         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1812
1813 2014-11-28  Commit Queue  <commit-queue@webkit.org>
1814
1815         Unreviewed, rolling out r176564.
1816         https://bugs.webkit.org/show_bug.cgi?id=139093
1817
1818         massive failures on release test bot (Requested by philn on
1819         #webkit).
1820
1821         Reverted changeset:
1822
1823         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
1824         https://bugs.webkit.org/show_bug.cgi?id=138866
1825         http://trac.webkit.org/changeset/176564
1826
1827 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] Use GMainLoopSource in WebKitTestRunner
1830         https://bugs.webkit.org/show_bug.cgi?id=138831
1831
1832         Reviewed by Sergio Villar Senin.
1833
1834         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1835         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1836         (WTR::TestRunner::platformInitialize):
1837         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1838         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1839         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1840         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1841         (WTR::TestController::notifyDone):
1842         (WTR::TestController::platformRunUntil):
1843         (WTR::cancelTimeout): Deleted.
1844
1845 2014-11-24  Philippe Normand  <pnormand@igalia.com>
1846
1847         [GStreamer] Bump internal jhbuild versions to 1.4.4
1848         https://bugs.webkit.org/show_bug.cgi?id=138866
1849
1850         Reviewed by Carlos Garcia Campos.
1851
1852         * gtk/jhbuild.modules:
1853         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1854         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1855         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1856
1857 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1858
1859         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
1860         https://bugs.webkit.org/show_bug.cgi?id=138834
1861
1862         Reviewed by Sergio Villar Senin.
1863
1864         It makes everyting simpler and the tests run faster too, since we
1865         don't need to spawn the private bus and wait until the DBus name
1866         is registered. The web extension registers a new JavaSCript class
1867         with a status method to run the tests, similar to the DBus
1868         method. In the UI process side, tests use webkit_web_view_run_java_script()
1869         instead of sending a DBus message.
1870
1871         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1872         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1873         (WebKitDOMNodeFilterTest::create):
1874         (WebKitDOMNodeFilterTest::testTreeWalker):
1875         (WebKitDOMNodeFilterTest::testNodeIterator):
1876         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
1877         (WebKitDOMNodeFilterTest::runTest): Deleted.
1878         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1879         (WebKitDOMNodeTest::create):
1880         (WebKitDOMNodeTest::testHierarchyNavigation):
1881         (WebKitDOMNodeTest::testInsertion):
1882         (WebKitDOMNodeTest::testTagNames):
1883         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
1884         (WebKitDOMNodeTest::runTest): Deleted.
1885         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1886         (WebKitDOMXPathNSResolverTest::create):
1887         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1888         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1889         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
1890         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
1891         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1892         (WebKitFrameTest::create):
1893         (WebKitFrameTest::testMainFrame):
1894         (WebKitFrameTest::testURI):
1895         (WebKitFrameTest::testJavaScriptContext):
1896         (WebKitFrameTest::webPageFromArgs): Deleted.
1897         (WebKitFrameTest::runTest): Deleted.
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1899         (testWebKitDOMNodeHierarchyNavigation):
1900         (testWebKitDOMNodeInsertion):
1901         (testWebKitDOMNodeTagNames):
1902         (beforeAll):
1903         (afterAll):
1904         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1905         (runTest):
1906         (beforeAll):
1907         (afterAll):
1908         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1909         (testWebKitDOMXPathNSResolverNative):
1910         (testWebKitDOMXPathNSResolverCustom):
1911         (beforeAll):
1912         (afterAll):
1913         (runTest): Deleted.
1914         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1915         (webkitFrameTestRun):
1916         (beforeAll):
1917         (afterAll):
1918         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1919         (testsMap):
1920         (WebProcessTest::add):
1921         (WebProcessTest::create):
1922         (runTest):
1923         (windowObjectClearedCallback):
1924         (webkit_web_extension_initialize):
1925         (methodCallCallback): Deleted.
1926         (webkit_web_extension_initialize_with_user_data): Deleted.
1927         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1928         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
1929         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
1930         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1931         (WebViewTest::runWebProcessTest):
1932         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1933
1934 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
1935
1936         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
1937         https://bugs.webkit.org/show_bug.cgi?id=139086
1938
1939         Reviewed by Gyuyoung Kim.
1940
1941         * efl/jhbuild.modules:
1942         * efl/patches/libseccomp-pick-up-CC.patch: Added.
1943
1944 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
1945
1946         [EFL] Add warning if CMake version is too old for building with ninja.
1947         https://bugs.webkit.org/show_bug.cgi?id=139055
1948
1949         Reviewed by Gyuyoung Kim.
1950
1951         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
1952         that version in their repositories.
1953
1954         * efl/install-dependencies:
1955
1956 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
1957
1958         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
1959         https://bugs.webkit.org/show_bug.cgi?id=139044
1960
1961         Reviewed by Chris Fleizach.
1962
1963         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
1964         The proposed solution will enable the use of this method for the object table.
1965         Existing test shows the result.
1966
1967         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1968         (WTR::AccessibilityUIElement::columnHeaders):
1969
1970 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
1971
1972         [EFL] Remove E_Dbus dependency
1973         https://bugs.webkit.org/show_bug.cgi?id=136355
1974
1975         Reviewed by Gyuyoung Kim.
1976
1977         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
1978
1979 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1980
1981         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
1982         https://bugs.webkit.org/show_bug.cgi?id=139047
1983
1984         Reviewed by Carlos Garcia Campos.
1985
1986         * efl/jhbuild.modules:
1987         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
1988         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
1989         * gtk/jhbuild-optional.modules:
1990         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
1991         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
1992
1993 2014-11-25  Tanay C  <tanay.c@samsung.com>
1994
1995         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
1996         https://bugs.webkit.org/show_bug.cgi?id=138090
1997
1998         Reviewed by Carlos Garcia Campos.
1999
2000         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
2001         (browserWindowZoomIn): Added.
2002         (browserWindowZoomOut): Added.
2003         (scrollEventCallback): Added.
2004         (zoomInCallback): Modified.
2005         (zoomOutCallback): Modified.
2006         (browserWindowConstructed): Modified.
2007
2008 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2009
2010         [EFL] REGRESSION(r176514): It made performance tests fail
2011         https://bugs.webkit.org/show_bug.cgi?id=139037
2012
2013         Reviewed by Gyuyoung Kim.
2014
2015         * Scripts/webkitpy/port/efl.py:
2016         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
2017         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
2018         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
2019
2020 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2021
2022         [GTK] update-webkitgtk-libs fails to build fontconfig
2023         https://bugs.webkit.org/show_bug.cgi?id=139032
2024
2025         Reviewed by Martin Robinson.
2026
2027         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
2028         fontconfig will try to generate documentation and fail.
2029
2030         * gtk/install-dependencies:
2031
2032 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2033
2034         Unreviewed. Fix GTK+ make distcheck.
2035
2036         * gtk/manifest.txt: Remove deleted files.
2037
2038 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
2039
2040         [EFL] Utilize Eail library to support accessibility in EFL
2041         https://bugs.webkit.org/show_bug.cgi?id=137742
2042
2043         Reviewed by Gyuyoung Kim.
2044
2045         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
2046
2047         * efl/jhbuild-optional.modules: Added.
2048         * efl/jhbuild.modules:
2049
2050 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2051
2052         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
2053         https://bugs.webkit.org/show_bug.cgi?id=139023
2054
2055         Reviewed by Sergio Villar Senin.
2056
2057         Rename WebKitWebView/default-context as WebKitWebView/web-context
2058         and check we are always using the right context for new web views.
2059
2060         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2061         (testWebViewWebContext):
2062         (beforeAll):
2063         (testWebViewDefaultContext): Deleted.
2064
2065 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2066
2067         [GTK] Add API to override the default local storage directory
2068         https://bugs.webkit.org/show_bug.cgi?id=138828
2069
2070         Reviewed by Gustavo Noronha Silva.
2071
2072         Add test to check that the local storage directory is created at
2073         the path given on construction.
2074
2075         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2076         (testWebContextConfiguration):
2077         (beforeAll):
2078         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2079         (Test::Test):
2080         (Test::~Test): Deleted.
2081
2082 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2083
2084         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2085         https://bugs.webkit.org/show_bug.cgi?id=138981
2086
2087         Reviewed by Simon Fraser.
2088
2089         * MiniBrowser/mac/SettingsController.h:
2090         * MiniBrowser/mac/SettingsController.m:
2091         (-[SettingsController _populateMenu]):
2092         (-[SettingsController validateMenuItem:]):
2093         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
2094         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
2095         * MiniBrowser/mac/WK1BrowserWindowController.m:
2096         (-[WK1BrowserWindowController didChangeSettings]):
2097         * MiniBrowser/mac/WK2BrowserWindowController.m:
2098         (-[WK2BrowserWindowController didChangeSettings]):
2099
2100 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
2101
2102         Remove http lock code from webkitperl
2103         https://bugs.webkit.org/show_bug.cgi?id=138959
2104
2105         Reviewed by Alexey Proskuryakov.
2106
2107         * Scripts/webkitperl/httpd.pm:
2108         (cleanUp):
2109         (extractLockNumber): Deleted.
2110         (getLockFiles): Deleted.
2111         (getNextAvailableLockNumber): Deleted.
2112         (getLockNumberForCurrentRunning): Deleted.
2113         (waitForHTTPDLock): Deleted.
2114         (scheduleHttpTesting): Deleted.
2115         (getWaitTime): Deleted.
2116
2117 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
2118
2119         [EFL] The option value of fixed layout is false in MiniBrowser
2120         https://bugs.webkit.org/show_bug.cgi?id=138830
2121
2122         Reviewed by Gyuyoung Kim.
2123
2124         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
2125
2126         * MiniBrowser/efl/main.c:
2127
2128 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
2129
2130         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
2131         https://bugs.webkit.org/show_bug.cgi?id=138871
2132
2133         Reviewed by Carlos Garcia Campos.
2134
2135         Add a test case for the convenience API for posting user messages
2136         added to the DOM bindings.
2137
2138         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2139         (testUserContentManagerMessageFromConvenienceDOMBindings):
2140         (beforeAll):
2141         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2142         (documentLoadedCallback):
2143
2144 2014-11-19  Dana Burkart  <dburkart@apple.com>
2145
2146         Work around the fact that different masters may have different names for their codebases.
2147         https://bugs.webkit.org/show_bug.cgi?id=138878
2148
2149         Reviewed by Mark Rowe.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2152         (parseRevisionProperty): Changed.
2153         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
2154         opensource / internal codebase naming convention.
2155
2156 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2157
2158         AX: Screen braille input doesn't work on forms.
2159         https://bugs.webkit.org/show_bug.cgi?id=138804
2160
2161         Unreviewed build fix.
2162
2163         * DumpRenderTree/AccessibilityUIElement.cpp:
2164         (AccessibilityUIElement::setValue):
2165
2166 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2167
2168         AX: Screen braille input doesn't work on forms.
2169         https://bugs.webkit.org/show_bug.cgi?id=138804
2170
2171         Reviewed by Mario Sanchez Prada.
2172
2173         Add a method to setValue through the AX API in DRT.
2174
2175         * DumpRenderTree/AccessibilityUIElement.cpp:
2176         (setValueCallback):
2177         (AccessibilityUIElement::getJSClass):
2178         * DumpRenderTree/AccessibilityUIElement.h:
2179         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2180         (AccessibilityUIElement::setValue):
2181         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2182         (AccessibilityUIElement::setValue):
2183
2184 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
2185
2186         Remove the WinCairo buildbot
2187         https://bugs.webkit.org/show_bug.cgi?id=138805
2188
2189         Reviewed by Alex Christensen.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/config.json:
2192         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2193         (appendCustomBuildFlags):
2194         * BuildSlaveSupport/test-result-archive:
2195         (archiveTestResults):
2196
2197 2014-11-18  Daniel Bates  <dabates@apple.com>
2198
2199         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2200         SPI are not available in public SDK
2201         https://bugs.webkit.org/show_bug.cgi?id=138802
2202
2203         Reviewed by David Kilzer.
2204
2205         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2206
2207         * DumpRenderTree/mac/CheckedMalloc.cpp:
2208
2209 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
2212
2213         Forgot to fix this test before landing.
2214
2215         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2216         (testWebViewDefaultContext):
2217
2218 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2219
2220         [GTK] Add API to create a WebKitWebContext
2221         https://bugs.webkit.org/show_bug.cgi?id=138826
2222
2223         Reviewed by Gustavo Noronha Silva.
2224
2225         Use a different WebKitWebContext for every test to ensure test
2226         cases are independent to each other. Tests using DBus to
2227         communicate with the injected bundle extension now use a unique
2228         name for the well known DBus name.
2229
2230         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2231         (beforeAll): Remove comment about the order of the tests and
2232         move the success test before the failed one now that tests don't
2233         depend on each others.
2234         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2235         (beforeAll): Remove call to set the web extensions directory,
2236         since this is now done for all test in the Test constructor.
2237         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2238         (beforeAll): Do not create a temporary directory, a temporary data
2239         directory is now created for all tests.
2240         (afterAll):
2241         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2242         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
2243         to the web process test runner.
2244         (testWebKitDOMNodeInsertion): Ditto.
2245         (testWebKitDOMNodeTagNames): Ditto.
2246         (beforeAll): Remove call to set the web extensions directory.
2247         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
2248         (runTest): Pass the web extension ID to the web process test runner.
2249         (beforeAll): Remove call to set the web extensions directory.
2250         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2251         (runTest): Pass the web extension ID to the web process test runner.
2252         (beforeAll): Remove call to set the web extensions directory.
2253         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2254         (createFileAtDestination): Use Test::dataDirectory() as base dir
2255         for temporary files.
2256         (beforeAll): Do not create a temporary directory.
2257         (afterAll):
2258         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
2259         (webkitFrameTestRun): Pass the web extension ID to the web process
2260         test runner.
2261         (beforeAll): Remove call to set the web extensions directory.
2262         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2263         (beforeAll): Remove call to set the web extensions directory.
2264         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2265         (testProcessPerWebView): Use local member instead of global variable.
2266         (testMultiprocessWebViewCreateReadyClose): Ditto.
2267         (beforeAll): Do not connect to initialize-web-extensions, Test now
2268         connects to the signal for all tests and calls a virtual method
2269         that test can override.
2270         (afterAll):
2271         (initializeWebExtensions): Deleted.
2272         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2273         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
2274         for temporary files.
2275         (beforeAll): Do not create a temporary directory.
2276         (afterAll):
2277         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2278         (beforeAll): Remove call to set the web extensions directory.
2279         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2280         (beforeAll): Remove comment about the tests order.
2281         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2282         (testWebExtensionGetTitle): Build the DBus service name using the
2283         web extension ID.
2284         (testDocumentLoadedSignal): Ditto.
2285         (testWebKitWebViewProcessCrashed): Ditto.
2286         (testWebExtensionIsolatedWorld): Ditto.
2287         (beforeAll): Remove initialization-user-data test, since now all
2288         tests are passing user data to the web extension.
2289         (testWebExtensionInitializationUserData): Deleted.
2290         (initializeWebExtensions): Deleted.
2291         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2292         (testSetDirectory): Use the web context member inherited from Test.
2293         (testClearDatabase): Ditto.
2294         (testGetFaviconURI): Ditto.
2295         (beforeAll): Do not create a temporary directory.
2296         (afterAll):
2297         (webkitFaviconDatabaseFinalizedCallback): Deleted.
2298         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2299         (UserContentManagerTest::UserContentManagerTest):
2300         (beforeAll): Remove call to set the web extensions directory.
2301         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2302         (testWebContextDefault): Check also that a newly create web
2303         context is not the default web context.
2304         (testWebContextSpellChecker): Use the web context member inherited
2305         from Test.
2306         (testWebContextLanguages): Ditto.
2307         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2308         (methodCallCallback): Remove GetInitializationUserData method.
2309         (webkit_web_extension_initialize_with_user_data): Always create
2310         the DBus name using the user data provided.
2311         (makeBusName): Deleted.
2312         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2313         (webkit_web_extension_initialize_with_user_data): Create the DBus
2314         name using the user data provided.
2315         (webkit_web_extension_initialize): Deleted.
2316         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2317         (Test::dataDirectory): Return the temporary data directory.
2318         (removeNonEmptyDirectory): Also remove directories recursively.
2319         (main): Remove the disk cache directory initialization, since this
2320         is now done in the Test constructor.
2321         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2322         (Test::initializeWebExtensionsCallback): Call the virtual method
2323         initializeWebExtensions()
2324         (Test::Test): Create a new WebKitWebContext and initialize it.
2325         (Test::~Test): Disconnect initialize-web-extensions signal.
2326         (Test::initializeWebExtensions): Set the web extensions directory
2327         and user data.
2328         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
2329         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
2330         (WebProcessTestRunner::runTest): Build the DBus proxy using a
2331         unique name created with the Test web extension ID.
2332         (WebProcessTestRunner::proxy): Deleted.
2333         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
2334         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2335         (WebViewTest::WebViewTest): Create the web view with the Test web
2336         context.
2337         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
2338         content manager parameter to the constructor.
2339
2340 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
2341
2342         [GTK] Mesa build fails over llvm-3.5
2343         https://bugs.webkit.org/show_bug.cgi?id=138825
2344
2345         Reviewed by Gustavo Noronha Silva.
2346
2347         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
2348
2349         * gtk/jhbuild.modules:
2350         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
2351
2352 2014-11-17  Daniel Bates  <dabates@apple.com>
2353
2354         Unreviewed, rolling out r176232.
2355
2356         Broke the Mac build. Will investigate offline.
2357
2358         Reverted changeset:
2359
2360         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2361         MobileGestalt"
2362         https://bugs.webkit.org/show_bug.cgi?id=138802
2363         http://trac.webkit.org/changeset/176232
2364
2365 2014-11-17  Daniel Bates  <dabates@apple.com>
2366
2367         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2368         SPI are not available in public SDK
2369         https://bugs.webkit.org/show_bug.cgi?id=138802
2370
2371         Reviewed by David Kilzer.
2372
2373         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2374
2375         * DumpRenderTree/mac/CheckedMalloc.cpp:
2376
2377 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
2378
2379         Having 30+ flaky failures breaks EWS
2380         https://bugs.webkit.org/show_bug.cgi?id=138743
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         Adds tests to ensure that the problem has been solved.
2385         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2386         (test_first_failure_limit):
2387         (test_first_failure_limit_with_some_tree_redness):
2388         (test_second_failure_limit):
2389         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
2390         (test_first_and_second_failure_limit):
2391         (test_first_and_clean_failure_limit):
2392         (test_first_second_and_clean_failure_limit):
2393         (test_very_red_tree_retry): Deleted.
2394         Really this was renamed to test_first_second_and_clean_failure_limit.
2395         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2396         Makes the appropriate changes to PatchAnalysisTask to make sure that
2397         even when the first test run hits the failure limit, it will still try
2398         a second run.
2399         (PatchAnalysisTask._results_failed_different_tests):
2400         (PatchAnalysisTask._test_patch):
2401         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
2402
2403 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
2404
2405         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
2406         https://bugs.webkit.org/show_bug.cgi?id=136018
2407
2408         Reviewed by Carlos Garcia Campos.
2409
2410         It is possible that the order of -L arguments in the output of
2411         pkg-config is wrong, which causes the linker to find the wrong
2412         version (usually older version) of libraries when running
2413         gtkdoc-scangobj.
2414
2415         * gtk/gtkdoc.py:
2416         (GTKDoc._run_gtkdoc_scangobj):
2417
2418 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2419
2420         Bump EFL version to 1.12.0
2421         https://bugs.webkit.org/show_bug.cgi?id=138733
2422
2423         Reviewed by Gyuyoung Kim.
2424
2425         * efl/jhbuild.modules:
2426
2427 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
2428
2429         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
2430         https://bugs.webkit.org/show_bug.cgi?id=138771
2431
2432         Reviewed by Chris Fleizach.
2433
2434         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
2435
2436         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2437
2438 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
2439
2440         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
2441         https://bugs.webkit.org/show_bug.cgi?id=138767
2442
2443         Reviewed by Chris Fleizach.
2444
2445         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
2446
2447         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2448
2449 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
2450
2451         Add shortcut macros to Mac TestExpectations
2452         https://bugs.webkit.org/show_bug.cgi?id=138729
2453
2454         Reviewed by Simon Fraser.
2455
2456         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
2457         Add version macros for current OS versions.
2458
2459 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
2460
2461         https://bugs.webkit.org/show_bug.cgi?id=138628
2462         A patch that doesn't apply is stuck in commit queue
2463
2464         Rubber-stamped by David Kilzer.
2465
2466         This also hopefully fixes other issues:
2467         - a patch that has cq+ flag set by a non-committer kills commit queue;
2468         - EWS never reports failing tests, and keeps spinning instead.
2469
2470         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2471         (Bugzilla.set_flag_on_attachment):
2472         (Bugzilla.obsolete_attachment):
2473         Apply the fix from r174797 to more places.
2474
2475 2014-11-13  Dan Bernstein  <mitz@apple.com>
2476
2477         Policy client not called for navigations through the page cache
2478         https://bugs.webkit.org/show_bug.cgi?id=138703
2479
2480         Reviewed by Alexey Proskuryakov.
2481
2482         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2483         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
2484         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2485
2486 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
2487
2488         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
2489         https://bugs.webkit.org/show_bug.cgi?id=137867
2490
2491         Reviewed by Chris Fleizach.
2492
2493         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
2494         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
2495         able to test for the presence of ATK_ROLE_INVALID.
2496
2497         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2498         (WTR::AccessibilityUIElement::role):
2499
2500 2014-11-13  Juergen Ributzka  <juergen@apple.com>
2501
2502         Update the "combineModules" script to handel more LLVM metadata.
2503         https://bugs.webkit.org/show_bug.cgi?id=138514
2504
2505         Reviewed by Filip Pizlo.
2506
2507         * ReducedFTL/combineModules.rb:
2508
2509 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2510
2511         Allow constructing a base PassRef with a derived Ref
2512         https://bugs.webkit.org/show_bug.cgi?id=138701
2513
2514         Reviewed by Andreas Kling
2515
2516         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2517         (TestWebKitAPI::passWithPassRef):
2518         (TestWebKitAPI::passWithPassRefPtr):
2519         (TestWebKitAPI::TEST):
2520
2521 2014-11-05  Ada Chan  <adachan@apple.com>
2522
2523         Implement new plug-in API for muting plug-ins
2524         https://bugs.webkit.org/show_bug.cgi?id=138105
2525
2526         Reviewed by Anders Carlsson.
2527
2528         Add a new plug-in test for the mute API.
2529
2530         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2531         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
2532         (SetMuted::SetMuted):
2533         (SetMuted::isMuted):
2534         (SetMuted::cachedIsMuted):
2535         (SetMuted::ScriptableObject::hasProperty):
2536         (SetMuted::ScriptableObject::getProperty):
2537         (SetMuted::ScriptableObject::pluginTest):
2538         (SetMuted::NPP_New):
2539         (SetMuted::NPP_GetValue):
2540         (SetMuted::NPP_SetValue):
2541
2542 2014-11-12  Philippe Normand  <pnormand@igalia.com>
2543
2544         Unreviewed, GTK gardening.
2545
2546         * Scripts/run-gtk-tests:
2547         (TestRunner): Skip the UserMediaBasic test because it depends on
2548         constraints validation which is going to be fixed in bug #136449.
2549
2550 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2551
2552         [GTK] Expose user script messages to GObject DOM bindings
2553         https://bugs.webkit.org/show_bug.cgi?id=138411
2554
2555         Reviewed by Philippe Normand.
2556
2557         Add a test case to check that user script messages sent using the
2558         DOM bindings API are also received in the UI process.
2559
2560         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2561         (UserScriptMessageTest::waitUntilMessageReceived):
2562         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2563         (testUserContentManagerScriptMessageFromDOMBindings):
2564         (beforeAll):
2565         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2566         (documentLoadedCallback):
2567
2568 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2569
2570         Unreviewed. Fix GTK+ clean build after r175930.
2571
2572         Partial rollout of r175930 to not build the new unit test that
2573         broke clean builds in GTK+ port.
2574
2575         * TestWebKitAPI/PlatformGTK.cmake:
2576
2577 2014-09-01  Philippe Normand  <pnormand@igalia.com>
2578
2579         [WK2] UserMediaClient support
2580         https://bugs.webkit.org/show_bug.cgi?id=123158
2581
2582         Reviewed by Benjamin Poulain.
2583
2584         Simple API test for the UserMedia permission request API. The
2585         required test infrastructure is also added, inspired by the
2586         Geolocation infrastructure.
2587
2588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
2589         Permission request.
2590         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
2591         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
2594         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
2595         helper method to set the permission request result without user interaction.
2596         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
2597         (WTR::InjectedBundle::setUserMediaPermission):
2598         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2600         (WTR::TestRunner::setUserMediaPermission):
2601         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2602         * WebKitTestRunner/TestController.cpp:
2603         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
2604         request handler.
2605         (WTR::TestController::createOtherPage): Enable the new UserMedia
2606         permission request handler.
2607         (WTR::TestController::createWebViewWithOptions): Ditto.
2608         (WTR::TestController::resetPreferencesToConsistentValues): Enable
2609         MediaStream support, this is needed for getUserMedia.
2610         (WTR::TestController::resetStateToConsistentValues): clear
2611         UserMedia permissions list and flags.
2612         (WTR::TestController::setUserMediaPermission): Set permission
2613         request result and distpatch it.
2614         (WTR::TestController::handleUserMediaPermissionRequest): Save
2615         request and dispatch it.
2616         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2617         Dispatch cached permission requests.
2618         * WebKitTestRunner/TestController.h:
2619         * WebKitTestRunner/TestInvocation.cpp:
2620         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2621
2622 2014-11-11  David Kilzer  <ddkilzer@apple.com>
2623
2624         webkit-patch --suggest-reviewers is broken with newer versions of git
2625         <http://webkit.org/b/138627>
2626
2627         Reviewed by Michael Saboff with feedback from Daniel Bates.
2628
2629         * Scripts/webkitpy/common/checkout/scm/git.py:
2630         (Git._changes_files_for_commit): Strip blank lines instead of
2631         assuming there is always a blank line at the beginning of the
2632         list.
2633
2634 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
2635
2636         DRT and WKTR touch disk cache
2637         https://bugs.webkit.org/show_bug.cgi?id=138622
2638
2639         Reviewed by Geoffrey Garen.
2640
2641         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2642         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
2643         because this function uses the shared cache.
2644
2645         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
2646         Create an empty shared cache to prevent a default one from being created on disk.
2647
2648 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
2649
2650         [CSS Grid Layout] Limit the size of explicit/implicit grid
2651         https://bugs.webkit.org/show_bug.cgi?id=136217
2652
2653         Reviewed by Andreas Kling.
2654
2655         Added a new unit test for the CSS parser. Right now it only checks
2656         that we properly clamp the maximum number of tracks on a grid to a
2657         maximum of 1 million.
2658
2659         * TestWebKitAPI/CMakeLists.txt:
2660         * TestWebKitAPI/PlatformEfl.cmake:
2661         * TestWebKitAPI/PlatformGTK.cmake:
2662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2663         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
2664         (TestWebKitAPI::computeNumberOfTracks): Helper function.
2665         (TestWebKitAPI::TEST): Added a
2666         CSSPropertyParserTest.GridTrackLimits test case.
2667
2668 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2669
2670         webkitpy test fix after r175867
2671         https://bugs.webkit.org/show_bug.cgi?id=138607
2672
2673         Reviewed by Philippe Normand.
2674
2675         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2676         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2677
2678 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2679
2680         webkitpy: demangle C++ symbols from crash log stderr
2681         https://bugs.webkit.org/show_bug.cgi?id=138565
2682
2683         Reviewed by Alexey Proskuryakov.
2684
2685         * Scripts/webkitpy/port/linux_get_crash_log.py:
2686         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
2687         with c++filt.
2688
2689 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2690
2691         [GTK] fix up the GDB backtrace report tool
2692         https://bugs.webkit.org/show_bug.cgi?id=138564
2693
2694         Reviewed by Carlos Garcia Campos.
2695
2696         * Scripts/webkitpy/port/gtk.py:
2697         (GtkPort._get_crash_log): Match the process name reported by the
2698         driver with the GTK port WebProcess executable filename.
2699         * Scripts/webkitpy/port/linux_get_crash_log.py:
2700         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
2701         program.
2702         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
2703         pattern to workaround the 16 characters size limit of %e.
2704
2705 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
2706
2707         Unreviewed, moved myself to the list of committers.
2708
2709         * Scripts/webkitpy/common/config/contributors.json:
2710
2711 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2712
2713         [EFL] Fix the test font path after r175555.
2714
2715         Reviewed by Csaba Osztrogonác.
2716
2717         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
2718
2719 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
2720
2721         Fix the exception fuzz helper to generate targets in the correct range
2722         https://bugs.webkit.org/show_bug.cgi?id=138544
2723
2724         Reviewed by Filip Pizlo.
2725
2726         Currently, the script generates exception fuzz targets in the range of
2727         0..($checkCount-1). However, target 0 is never hit, while target 1 is
2728         always outside of the outermost try block of the tests, which therefore
2729         prints unexpected output and results in false failures when fired at.
2730         Additionally, target $checkCount is never generated.
2731
2732         This patch fixes the script to generate targets in the range of
2733         2..$checkCount.
2734
2735         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2736
2737 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2738
2739         make-passwords-json.py should generarate everything needed for testing
2740         https://bugs.webkit.org/show_bug.cgi?id=138503
2741
2742         Reviewed by Ryosuke Niwa.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
2745         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
2746         Additionally generate auth.json, credentials.cfg and committers.cfg too.
2747         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
2748         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2749         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
2750         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
2751
2752 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2753
2754         [GTK] generate-gtkdoc should ignore invalid files
2755         https://bugs.webkit.org/show_bug.cgi?id=138542
2756
2757         Reviewed by Darin Adler.
2758
2759         * gtk/generate-gtkdoc:
2760         (files_to_ignore.file_should_be_ignored): Return True to ignore
2761         invalid files.
2762
2763 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2764
2765         Delete cookies between tests
2766         https://bugs.webkit.org/show_bug.cgi?id=138528
2767
2768         Reviewed by Sam Weinig.
2769
2770         * DumpRenderTree/mac/DumpRenderTree.mm:
2771         (resetWebPreferencesToConsistentValues):
2772         * WebKitTestRunner/TestController.cpp:
2773         (WTR::TestController::resetPreferencesToConsistentValues):
2774         Do it.
2775
2776         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2777         (WTR::InjectedBundle::beginTesting):
2778         Added a FIXME.
2779
2780 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2781
2782         [GTK] Run layout tests using the network process
2783         https://bugs.webkit.org/show_bug.cgi?id=138428
2784
2785         Reviewed by Martin Robinson.
2786
2787         Shared secondary process is the default in the GTK+ port, but we
2788         should run the tests using the network process to ensure
2789         everything works with the network process. In the future, the
2790         shared secondary process model might be a special case of multiple
2791         processes with 1 as maximum number of processes, but always using
2792         the network process.
2793
2794         * WebKitTestRunner/TestController.cpp:
2795         (WTR::TestController::initialize):
2796
2797 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2798
2799         [GTK] Allow to create a view with a related page in WTR
2800         https://bugs.webkit.org/show_bug.cgi?id=138501
2801
2802         Reviewed by Martin Robinson.
2803
2804         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2805         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
2806         related page to WKViewCreate.
2807         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2808         (WTR::PlatformWebView::PlatformWebView): Pass the given related
2809         page to WKViewCreate.
2810
2811 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2812
2813         WTR crashes after running a test when NetworkProcess enabled
2814         https://bugs.webkit.org/show_bug.cgi?id=138500
2815
2816         Reviewed by Alexey Proskuryakov.
2817
2818         WebNotificationProvider destructor is calling
2819         WKNotificationManagerSetProvider, but m_notificationManager is
2820         null because removeNotificationManager was already called.
2821
2822         * WebKitTestRunner/WebNotificationProvider.cpp:
2823         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
2824         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
2825
2826 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
2827
2828         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
2829         regarding incorrect call to PatchAnalysisTask.report_failure
2830         https://bugs.webkit.org/show_bug.cgi?id=138229
2831
2832         Reviewed by Daniel Bates.
2833
2834         * Scripts/webkitpy/common/net/layouttestresults.py:
2835         Makes sure test_results returns a list.
2836         (LayoutTestResults.test_results):
2837         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2838         Makes unit tests also check to make sure
2839         task.results_from_patch_test_run() and
2840         task.results_from_test_run_without_patch return instances of
2841         LayoutTestResults.
2842         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2843         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2844         Condenses duplicate code into _should_defer_patch_or_throw, and
2845         removes the now-unused _clean_tree_results member.
2846         (PatchAnalysisTask.__init__):
2847         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2848         (PatchAnalysisTask._should_defer_patch_or_throw):
2849         (PatchAnalysisTask._test_patch):
2850         (PatchAnalysisTask.results_from_patch_test_run):
2851         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
2852         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2853         Removes needless call to results_from_test_run_without_patch
2854         (AbstractEarlyWarningSystem._failing_tests_message):
2855         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2856         Changes order of test failure messages to be in the order that they
2857         appear.
2858         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2859         * Scripts/webkitpy/tool/commands/queues.py:
2860         Removes needless call to results_from_test_run_without_patch.
2861         (CommitQueue._failing_tests_message):
2862         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2863         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
2864
2865 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
2866
2867         Unreviewed. Reorder my e-mail addresses in contributors.json
2868
2869         * Scripts/webkitpy/common/config/contributors.json:
2870
2871 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
2872
2873         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
2874         https://bugs.webkit.org/show_bug.cgi?id=138475
2875
2876         Reviewed by Ryosuke Niwa.
2877
2878         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
2879         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
2880         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
2881         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
2882
2883         * Scripts/webkitpy/common/checkout/scm/git.py:
2884         (Git._run_git_svn_find_rev):
2885         Add comment mentioning that svn_revisions need to begin with 'r'.
2886         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
2887         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
2888         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
2889
2890 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2891
2892         [GTK] Add context menu API to Web Process Extensions
2893         https://bugs.webkit.org/show_bug.cgi?id=138311
2894
2895         Reviewed by Gustavo Noronha Silva.
2896
2897         Add tests cases for WebKitWebPage::context-menu signal.
2898
2899         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2900         (testContextMenuWebExtensionMenu):
2901         (testContextMenuWebExtensionNode):
2902         (beforeAll):
2903         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2904         (serializeContextMenu):
2905         (serializeNode):
2906         (contextMenuCallback):
2907         (pageCreatedCallback):
2908
2909 2014-11-06  Commit Queue  <commit-queue@webkit.org>
2910
2911         Unreviewed, rolling out r175690.
2912         https://bugs.webkit.org/show_bug.cgi?id=138460
2913
2914         We are not ready to run layout tests using the network process
2915         yet (Requested by KaL on #webkit).
2916
2917         Reverted changeset:
2918
2919         "[GTK] Run layout tests using the network process"
2920         https://bugs.webkit.org/show_bug.cgi?id=138428
2921         http://trac.webkit.org/changeset/175690
2922
2923 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2924
2925         [GTK] Run layout tests using the network process
2926         https://bugs.webkit.org/show_bug.cgi?id=138428
2927
2928         Reviewed by Martin Robinson.
2929
2930         Shared secondary process is the default in the GTK+ port, but we
2931         should run the tests using the network process to ensure
2932         everything works with the network process. In the future, the
2933         shared secondary process model might be a special case of multiple
2934         processes with 1 as maximum number of processes, but always using
2935         the network process.
2936
2937         * WebKitTestRunner/TestController.cpp:
2938         (WTR::TestController::initialize):
2939
2940 2014-11-05  Dan Bernstein  <mitz@apple.com>
2941
2942         Remove the unused deletion UI feature
2943         https://bugs.webkit.org/show_bug.cgi?id=138442
2944
2945         Rubber-stamped by Alexey Proskuryakov.
2946
2947         * DumpRenderTree/mac/EditingDelegate.mm:
2948         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
2949         delegate method that’s been removed.
2950
2951 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
2952
2953         fast/dom/remove-body-during-body-replacement2.html fails on WK2
2954         https://bugs.webkit.org/show_bug.cgi?id=138334
2955
2956         Reviewed by Anders Carlsson.
2957
2958         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
2959         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
2960         -makeFirstResponder calls, which may or may not be needed for other reasons, but
2961         it also needs to reset internal focus explicitly.
2962
2963         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
2964         WebKit behavior appears wrong, but it matches Firefox.
2965
2966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2967         (WTR::InjectedBundlePage::resetAfterTest):
2968
2969 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
2972         https://bugs.webkit.org/show_bug.cgi?id=137862
2973
2974         Reviewed by Gustavo Noronha Silva.
2975
2976         Add a test case to check that WebKitWebResource::failed-with-tls-errors
2977         is emitted when a subresource load fails due to TLS errors.
2978
2979         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2980         (TLSSubresourceTest::resourceLoadStartedCallback):
2981         (TLSSubresourceTest::TLSSubresourceTest):
2982         (TLSSubresourceTest::subresourceFailedCallback):
2983         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
2984         (TLSSubresourceTest::subresourceLoadStarted):
2985         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
2986         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
2987         (testSubresourceLoadFailedWithTLSErrors):
2988         (httpsServerCallback):
2989         (httpServerCallback):
2990         (beforeAll):
2991
2992 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
2993
2994         Build fix for some compiler versions.
2995
2996         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
2997         unhappy because this is a getter, and these shouldn't have side effects.
2998
2999 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3000
3001         Add a method for performing cherrypick-merges.
3002         https://bugs.webkit.org/show_bug.cgi?id=138375
3003
3004         Reviewed by Ryosuke Niwa.
3005
3006         Adds support for cherrypick-merges.
3007
3008         * Scripts/webkitpy/common/checkout/scm/git.py:
3009         (Git.cherrypick_merge): Added.
3010
3011 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3012
3013         Add a way to ascertain the SVN URL associated with a Git branch.
3014         https://bugs.webkit.org/show_bug.cgi?id=138374
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         The svn_url method returns the SVN URL associated with the current Git branch.
3019
3020         * Scripts/webkitpy/common/checkout/scm/git.py:
3021         (Git.svn_url): Added.
3022
3023 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3024
3025         Add the ability to search for modifications that are staged for commit.
3026         https://bugs.webkit.org/show_bug.cgi?id=138373
3027
3028         Reviewed by Ryosuke Niwa and Daniel Bates.
3029
3030         This makes is easy to do identify files that require merge post-processing,
3031         in addition to stand-alone utility.
3032
3033         * Scripts/webkitpy/common/checkout/scm/git.py:
3034         (Git.modifications_staged_for_commit): Added.
3035
3036 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3037
3038         Add a branch keyword argument to _run_git_svn_find_rev.
3039         https://bugs.webkit.org/show_bug.cgi?id=138372
3040
3041         Reviewed by Ryosuke Niwa.
3042
3043         The addition of this keyword argument allows clients to determine the Git hash
3044         of commits made on an SVN branch, provided that branch has been fetched locally.
3045
3046         * Scripts/webkitpy/common/checkout/scm/git.py:
3047         (Git._run_git_svn_find_rev):
3048         Add a branch keyword argument that is added to the end of the command, if present.
3049
3050 2014-11-04  Chris Dumez  <cdumez@apple.com>
3051
3052         Add ptr() method to Ref class
3053         https://bugs.webkit.org/show_bug.cgi?id=138361
3054
3055         Reviewed by Darin Adler.
3056
3057         Use the new Ref::ptr() method.
3058
3059         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3060         (TestWebKitAPI::TEST):
3061
3062 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3063
3064         [jhbuild] Make it possible to build GTK/EFL in same repository
3065         https://bugs.webkit.org/show_bug.cgi?id=137448
3066
3067         Reviewed by Martin Robinson.
3068
3069         * Scripts/webkitdirs.pm:
3070         (getJhbuildPath):
3071         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
3072         (getPlatformFontsPath):
3073         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3074         (WTR::getFontsPath):
3075         * jhbuild/jhbuild-wrapper:
3076         (determine_platform):
3077         (install_jhbuild):
3078         * jhbuild/jhbuildrc_common.py:
3079         (init):
3080
3081 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3082
3083         [EFL] Bump LLVM to version 3.5.0
3084         https://bugs.webkit.org/show_bug.cgi?id=138312
3085
3086         Reviewed by Csaba Osztrogonác.
3087
3088         * efl/jhbuild.modules:
3089         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
3090         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
3091
3092 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
3093
3094         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
3095         https://bugs.webkit.org/show_bug.cgi?id=138257
3096
3097         Reviewed by Tim Horton.
3098         
3099         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
3100         the user to toggle region page overlays on and off. Two overlays are available,
3101         for the non-fast scrollable region, and the region of element with wheel
3102         event handlers.
3103
3104         * MiniBrowser/mac/SettingsController.h:
3105         * MiniBrowser/mac/SettingsController.m:
3106         (-[SettingsController _populateMenu]):
3107         (-[SettingsController validateMenuItem:]):
3108         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
3109         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
3110         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
3111         (-[SettingsController toggleDebugOverlay:]):
3112         (-[SettingsController debugOverlayVisible:]):
3113         * MiniBrowser/mac/WK2BrowserWindowController.m:
3114         (-[WK2BrowserWindowController didChangeSettings]):
3115
3116 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
3117
3118         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
3119         https://bugs.webkit.org/show_bug.cgi?id=138323
3120
3121         Reviewed by Zalan Bujtas.
3122
3123         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
3124
3125 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3126
3127         [ninja] Don't remove response files for verbose builds
3128         https://bugs.webkit.org/show_bug.cgi?id=137816
3129
3130         Reviewed by Csaba Osztrogonác.
3131
3132         * Scripts/webkitdirs.pm:
3133         (determineNinjaVersion):
3134         (buildCMakeGeneratedProject):
3135
3136 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
3137
3138         [GTK] Fix the build of FTL JIT
3139         https://bugs.webkit.org/show_bug.cgi?id=138298
3140
3141         Reviewed by Carlos Garcia Campos.
3142
3143         * gtk/jhbuild-optional.modules:
3144         Bump up LLVM version to 3.5.0 release and apply patches.
3145         * gtk/patches/llvm-elf-add-stackmaps.patch:
3146         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
3147         trunk.
3148         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
3149         Added. Ensures that PC-relative relocations in EH frames are not
3150         truncated to 32 bits on x86_64.
3151
3152 2014-10-31  Michael Saboff  <msaboff@apple.com>
3153
3154         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
3155         https://bugs.webkit.org/show_bug.cgi?id=138268
3156
3157         Reviewed by Andreas Kling.
3158
3159         Added a --arch and --os option to set or override the values that are
3160         normally computed based on examining the JavaScriptCore we want to test.
3161
3162         * Scripts/run-jsc-stress-tests:
3163
3164 2014-10-31  Dan Bernstein  <mitz@apple.com>
3165
3166         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
3167         https://bugs.webkit.org/show_bug.cgi?id=138259
3168
3169         Reviewed by Geoff Garen.
3170
3171         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
3172         going to be empty to silence the warning.
3173
3174 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
3175
3176         [GTK] Support script message handlers WebKitUserContentManager
3177         https://bugs.webkit.org/show_bug.cgi?id=133730
3178
3179         Reviewed by Carlos Garcia Campos.
3180
3181         Support user script message handlers in WebKitUserContentManager.
3182         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
3183         an option is added to the CMake build files. The option is disabled
3184         globally by default, and the WebKitGTK port enables it. On the API
3185         level, two new methods to register and unregister names are provided
3186         in the "window.webkit" namespace, and on message reception the
3187         "WebKitUserContentManager::script-message-received" signal is
3188         emitted, using the registered names as signal detail.
3189
3190         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3191         Add test case for user script message handlers.
3192         (scriptMessageReceived):
3193         (testUserContentManagerScriptMessageReceived):
3194         (beforeAll):
3195
3196 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3197
3198         bisect-builds should support WebKit clients other than Safari
3199         https://bugs.webkit.org/show_bug.cgi?id=138225
3200
3201         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
3202
3203         The -a / --application optional argument allows the user to specify which application (or application bundle)
3204         should be run against the WebKit nightly builds.
3205
3206         Reviewed by David Kilzer.
3207
3208         * Scripts/bisect-builds:
3209         Swap out $safariPath for the more general $applicationPath
3210         Leave --safari-path as a commandline option for backwards compatibility
3211         (mountAndRunNightly):
3212         Use File::Spec->cat correctly (one directory per argument)
3213         Use open --wait-apps instead of running the target application directly
3214
3215 2014-10-30  Dana Burkart  <dburkart@apple.com>
3216
3217         <rdar://problem/18821260> Perpare for the mysterious future
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3222         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3223         * LayoutTestRelay/Configurations/Base.xcconfig:
3224         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3225         * MiniBrowser/Configurations/Base.xcconfig:
3226         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3227         * TestWebKitAPI/Configurations/Base.xcconfig:
3228         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3229         * WebKitLauncher/Configurations/Base.xcconfig:
3230         * WebKitTestRunner/Configurations/Base.xcconfig:
3231         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3232
3233 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3234
3235         Update safariVersion to safariVersionString
3236         https://bugs.webkit.org/show_bug.cgi?id=138193
3237
3238         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
3239         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
3240
3241         Rubber-stamped by David Kilzer.
3242
3243         * Scripts/bisect-builds:
3244         (makeNightlyList):
3245         Compare safariVersionString to a string literal, instead of safariVersion.
3246
3247 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
3248
3249         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
3250         https://bugs.webkit.org/show_bug.cgi?id=137775
3251
3252         Reviewed by Carlos Garcia Campos.
3253
3254         * MiniBrowser/gtk/BrowserWindow.c:
3255         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
3256         (browser_window_init):
3257
3258 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
3259
3260         CommitQueue and EWS should reject any patches that result in consistent test
3261         failures that aren't present on the tree.
3262         https://bugs.webkit.org/show_bug.cgi?id=138184
3263
3264         Reviewed by Alexey Proskuryakov.
3265
3266         * Scripts/webkitpy/layout_tests/models/test_results.py:
3267         Adds a simple hashing function to allow for set operations to handle
3268         TestResult objects properly.
3269         (TestResult.__hash__):
3270         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3271         Adds one unit test, and modifies others to agree with the notion that
3272         patches that introduce new test failures (but also have flakyness)
3273         should be rejected rather than spin.
3274         (MockCommitQueue.report_flaky_tests):
3275         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3276         (test_double_flaky_test_failure):
3277         (test_two_flaky_tests):
3278         (test_very_flaky_patch):
3279         (test_very_flaky_patch_with_some_tree_redness):
3280         (test_different_test_failures):
3281         (test_different_test_failures_with_some_tree_redness):
3282         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
3283         (test_mildly_flaky_patch):
3284         (test_mildly_flaky_patch_with_some_tree_redness):
3285         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3286         Makes PatchAnalysisTask reject said patches.
3287         (PatchAnalysisTask._test_patch):
3288
3289 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3290
3291         WinCairoRequirements.zip cannot be downloaded from dropbox
3292         https://bugs.webkit.org/show_bug.cgi?id=138113
3293
3294         Reviewed by Alexey Proskuryakov.
3295
3296         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
3297
3298 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
3299
3300         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
3301         https://bugs.webkit.org/show_bug.cgi?id=138193
3302
3303         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
3304         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
3305
3306         It also does a bit of refactoring, including distinguishing between versions and version strings and
3307         saving versions to local variables instead of using eval in each conditional.
3308
3309         Reviewed by David Kilzer.
3310
3311         * Scripts/bisect-builds:
3312         (makeNightlyList):
3313         Restrict the set of nightlies to r174650 and above when running Yosemite.
3314         Restrict the set of nightlies to r157846 and above when running Mavericks.
3315         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
3316
3317 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
3318
3319         [EFL] build-webkit should try harder to avoid re-running cmake
3320         https://bugs.webkit.org/show_bug.cgi?id=137949
3321
3322         Reviewed by Martin Robinson.
3323
3324         * Scripts/webkitdirs.pm:
3325         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
3326         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
3327
3328 2014-10-28  Daniel Bates  <dabates@apple.com>
3329
3330         Unify logic in RunTests.run() to run the Python unit tests
3331         https://bugs.webkit.org/show_bug.cgi?id=138160
3332
3333         Reviewed by Martin Robinson.
3334
3335         Unify the interactive and non-interactive code path for running the Python unit tests
3336         in step RunTests so as to remove duplicate code to compute the the path to the script
3337         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
3338
3339         No new tests since no functionality was changed.
3340
3341         * Scripts/webkitpy/port/base.py:
3342         (Port.python_unittest_results_directory):
3343         * Scripts/webkitpy/tool/steps/runtests.py:
3344         (RunTests.run):
3345
3346 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
3347
3348         Make runtest.py call test-webkitpy with the --json flag when in
3349         non-interactive mode.
3350         https://bugs.webkit.org/show_bug.cgi?id=137667
3351
3352         Reviewed by Daniel Bates.
3353
3354         * Scripts/webkitpy/port/base.py:
3355         Adds the python_unittest_results_directory method.
3356         (Port.python_unittest_results_directory):
3357         * Scripts/webkitpy/tool/steps/runtests.py:
3358         Changes RunTests to call test-webkitpy with the --json flag if the
3359         --non-interactive flag is set.
3360         (RunTests):
3361         (RunTests.run):
3362
3363 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
3364
3365         import-w3c-tests should use re.escape() wherever it's handling file paths
3366         https://bugs.webkit.org/show_bug.cgi?id=137934
3367
3368         This patch adds re.escape() to a few places where we're doing string
3369         conversions. This prevents errors when attribute values coincidentally
3370         have character sequences that can be interpreted as regular expressions.
3371
3372         Reviewed by Bem Jones-Bey.
3373
3374         * Scripts/webkitpy/w3c/test_converter.py:
3375         (_W3CTestConverter.convert_attributes_if_needed):
3376
3377 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3378
3379         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
3380         https://bugs.webkit.org/show_bug.cgi?id=138130
3381
3382         Reviewed by Csaba Osztrogonác.
3383
3384         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3385
3386 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
3387
3388         Fix link to Arch Linux Wiki
3389         https://bugs.webkit.org/show_bug.cgi?id=138010
3390
3391         Reviewed by Benjamin Poulain.
3392
3393         * gtk/install-dependencies:
3394
3395 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
3396
3397         Test regressions are not detected when image result is missing
3398         https://bugs.webkit.org/show_bug.cgi?id=138070
3399
3400         Reviewed by Simon Fraser.
3401
3402         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3403         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3404         Count these as regressions, not as flaky tests.
3405
3406         * Scripts/webkitpy/port/test.py:
3407         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3408         Test it.
3409
3410 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
3411
3412         Add Conrad Shultz to the contributors list.
3413
3414         * Scripts/webkitpy/common/config/contributors.json:
3415
3416 2014-10-24  Dan Bernstein  <mitz@apple.com>
3417
3418         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
3419         https://bugs.webkit.org/show_bug.cgi?id=138046
3420
3421         Reviewed by Alexey Proskuryakov.
3422
3423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3424         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
3425         401. Otherwise, we’ll retry normally in 45 seconds.
3426
3427 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3428
3429         [GTK] Implement is_selected method on WebKitHitTestResult
3430         https://bugs.webkit.org/show_bug.cgi?id=137110
3431
3432         Reviewed by Tim Horton.
3433
3434         Add tests for new context SELECTION on WebKitHitTestResult.
3435
3436         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3437         (testContextMenuDefaultMenu):
3438         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3439         (testWebViewMouseTarget):
3440
3441 2014-10-23  Roger Fong  <roger_fong@apple.com>
3442
3443         [Win] Skip failing JSC tests following r175078
3444         https://bugs.webkit.org/show_bug.cgi?id=130967.
3445
3446         * Scripts/run-javascriptcore-tests:
3447
3448 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3449
3450         commitqueuetask_unittest.py should be made more concise.
3451         https://bugs.webkit.org/show_bug.cgi?id=137985
3452
3453         Reviewed by Alexey Proskuryakov.
3454
3455         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3456         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
3457         (MockCommitQueue.__init__):
3458         (MockCommitQueue.report_flaky_tests):
3459         (MockCommitQueue):
3460         (MockCommitQueue.get_reported_flaky_tests):
3461         (MockSimpleTestPlanCommitQueue.__init__):
3462         (MockSimpleTestPlanCommitQueue.run_command):
3463         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
3464         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3465         (test_land_failure):
3466         (test_failed_archive):
3467         (test_double_flaky_test_failure):
3468         (test_test_failure):
3469         (test_red_test_failure):
3470         (test_very_red_tree_retry):
3471         (test_red_tree_patch_rejection):
3472         (test_one_flaky_test):
3473         (test_tree_more_red_than_patch):
3474         (MockCommitQueue.test_results): Deleted.
3475         (test_simple_flaky_test_failure): Deleted.
3476         (_expect_validate): Deleted.
3477         (_expect_validate.MockDelegate): Deleted.
3478         (_expect_validate.MockDelegate.refetch_patch): Deleted.
3479         (_expect_validate.MockDelegate.expected_failures): Deleted.
3480         (_mock_patch): Deleted.
3481         (test_validate): Deleted.
3482         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3483         Fixes a bug that slipped through the cracks prior to this change.
3484         (PatchAnalysisTask._test_patch):
3485
3486 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
3487
3488         Flakiness dashboard should support OS X Yosemite
3489         https://bugs.webkit.org/show_bug.cgi?id=137986
3490
3491         Reviewed by Ryosuke Niwa.
3492
3493         * TestResultServer/app.yaml:
3494         * TestResultServer/static-dashboards/builders.jsonp:
3495         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3496
3497 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3498
3499         commitqueuetask should include more tests to ensure that the behavior
3500         of PatchAnalysisTask._test_patch() is well defined
3501         https://bugs.webkit.org/show_bug.cgi?id=137977
3502
3503         Reviewed by Alexey Proskuryakov.
3504
3505         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3506         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
3507         and more readable to define tests that are meant to test the behaviour
3508         of PatchAnalysisTask._test_patch(), and adds several unit tests.
3509         (FailingTestCommitQueue.test_results):
3510         (PatchAnalysisResult):
3511         (MockSimpleTestPlanCommitQueue):
3512         (MockSimpleTestPlanCommitQueue.__init__):
3513         (MockSimpleTestPlanCommitQueue.run_command):
3514         (MockSimpleTestPlanCommitQueue._mock_test_result):
3515         (MockSimpleTestPlanCommitQueue.test_results):
3516         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3517         (test_flaky_test_failure):
3518         (test_failed_archive):
3519         (test_two_flaky_tests):
3520         (test_one_flaky_test):
3521         (test_very_flaky_patch):
3522         (test_very_flaky_patch_with_some_tree_redness):
3523         (test_different_test_failures):
3524         (test_different_test_failures_with_some_tree_redness):
3525         (test_mildly_flaky_patch):
3526         (test_mildly_flaky_patch_with_some_tree_redness):
3527         (test_tree_more_red_than_patch):
3528
3529 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3530
3531         PatchAnalysisTask._test_patch() needs refactoring
3532         https://bugs.webkit.org/show_bug.cgi?id=137904
3533
3534         Reviewed by Alexey Proskuryakov.
3535
3536         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3537         Fixes several small bugs, and makes minor changes to accomodate the
3538         changes in PatchAnalysisTask.
3539         (MockCommitQueue.refetch_patch):
3540         (MockCommitQueue.test_results):
3541         (test_flaky_test_failure):
3542         (test_failed_archive):
3543         (test_very_red_tree_retry):
3544         (_expect_validate.MockDelegate.refetch_patch):
3545         (MockCommitQueue.expected_failures): Deleted.
3546         (_expect_validate.MockDelegate.expected_failures): Deleted.
3547         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
3548         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
3549         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3550         Removes the unexpected_failures member, adds the _clean_tree_results
3551         member, adds a helper function for _test_patch, and refactors
3552         _test_patch to be more readable.
3553         (PatchAnalysisTask.__init__):
3554         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
3555         (PatchAnalysisTask._test_patch):
3556         (PatchAnalysisTask.results_from_test_run_without_patch):
3557         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3558         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
3559         (AbstractEarlyWarningSystem.begin_work_queue):
3560         (AbstractEarlyWarningSystem._failing_tests_message):
3561         (AbstractEarlyWarningSystem.command_failed):
3562         (AbstractEarlyWarningSystem.expected_failures): Deleted.
3563         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3564         Makes changes to accomodate the changes made to PatchAnalysisTask.
3565         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3566         * Scripts/webkitpy/tool/commands/perfalizer.py:
3567         Removes Perfalizer's dependancy on ExpectedFailures. 
3568         (PerfalizerTask.refetch_patch):
3569         (PerfalizerTask.expected_failures): Deleted.
3570         * Scripts/webkitpy/tool/commands/queues.py:
3571         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
3572         initializer to allow for mock injection.
3573         (CommitQueue.__init__):
3574         (CommitQueue.begin_work_queue):
3575         (CommitQueue.process_work_item):
3576         (CommitQueue._failing_tests_message):
3577         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3578         Removes dependancy on ExpectedFailures, and instead uses mock
3579         injection.
3580         (MockCommitQueueTask):
3581         (MockCommitQueueTask.results_from_patch_test_run):
3582         (MockCommitQueueTask.results_from_test_run_without_patch):
3583         (mock_run_webkit_patch):
3584
3585 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
3586
3587         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
3588         https://bugs.webkit.org/show_bug.cgi?id=136736
3589
3590         Reviewed by Gyuyoung Kim.
3591
3592         * MiniBrowser/efl/main.c:
3593         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
3594         (window_create):
3595
3596 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3597
3598         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
3599         https://bugs.webkit.org/show_bug.cgi?id=137884
3600
3601         Reviewed by Gustavo Noronha Silva.
3602
3603         Move InputMethodFilter test from WebCore tests to WebKit2 tests
3604         and adapt it to use the new InputMethodFilter WebKit class. Instead
3605         of having virtual methods just for testing, it has a testing mode
3606         that logs the events.
3607
3608         * TestWebKitAPI/PlatformGTK.cmake:
3609         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
3610         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3611         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
3612         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
3613         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):