4c3679cb8e1129b04be28b59e10c6d597227a290
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-19  David Farler  <dfarler@apple.com>
2
3         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
4         https://bugs.webkit.org/show_bug.cgi?id=133086
5
6         Reviewed by Daniel Bates.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
9
10 2014-05-19  David Kilzer  <ddkilzer@apple.com>
11
12         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
13         <http://webkit.org/b/132954>
14
15         * Scripts/webkitdirs.pm:
16         (sharedCommandLineOptionsUsage): Remove the prototype for the
17         subroutine.  Older perls don't like the "+@" syntax.
18
19 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
20
21         run-javascriptcore-tests should sort the list of failing stress tests
22         https://bugs.webkit.org/show_bug.cgi?id=132989
23
24         Reviewed by Csaba Osztrogonác.
25
26         * Scripts/run-javascriptcore-tests:
27
28 2014-05-19  David Kilzer  <ddkilzer@apple.com>
29
30         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
31         <http://webkit.org/b/132954>
32
33         Reviewed by Darin Adler.
34
35         Extract code into setupMacWebKitEnvironment() for setting up
36         common environment variables so it may be shared.  Sets
37         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
38         using guardmalloc to some scripts.
39
40         Also adds support for parsing shared (common) command-line
41         switches, initially just -g|--guard-malloc.
42
43         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
44         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
45         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
46         local copy of %ENV when launching Safari so we don't have to
47         restore variables.
48
49         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
50         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
51         Check result of GetOptions() to catch invalid command-line
52         switches.
53         (runTest): Use a local copy of %ENV when running tests so we
54         don't have to restore variables.
55         (prepareEnvironmentForRunningTestTool): Call
56         setupMacWebKitEnvironment().
57
58         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
59         using sharedCommandLineOptions() and
60         sharedCommandLineOptionsUsage().  Call
61         setupMacWebKitEnvironment().
62
63         * Scripts/webkitdirs.pm:
64         (sharedCommandLineOptions): Return array of common switches to
65         pass to Getopt::Long::GetOptions().
66         (sharedCommandLineOptionsUsage): Return formatted string of
67         common switches for printing usage help text.
68         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
69         guardmalloc.
70         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
71         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
72         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
73         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
74         local copy of %ENV when launching Safari so we don't have to
75         restore variables.
76         (execMacWebKitAppForDebugging): Call
77         setupMacWebKitEnvironment().
78
79 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
80
81         support for navigator.hardwareConcurrency
82         https://bugs.webkit.org/show_bug.cgi?id=132588
83
84         Reviewed by Filip Pizlo.
85
86         * Scripts/webkitperl/FeatureList.pm:
87
88 2014-05-18  Anders Carlsson  <andersca@apple.com>
89
90         Implement Navigations for all methods declared returning one
91         https://bugs.webkit.org/show_bug.cgi?id=133048
92         <rdar://problem/16830064>
93
94         Reviewed by Sam Weinig.
95
96         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
97         Import WebKit.h.
98         
99         * MiniBrowser/mac/WK2BrowserWindowController.m:
100         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
101         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
102         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
103         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
104         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
105         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
106         Print out the navigations.
107
108 2014-05-17  Zalan Bujtas  <zalan@apple.com>
109
110         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
111         https://bugs.webkit.org/show_bug.cgi?id=133029
112
113         Reviewed by Simon Fraser.
114
115         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
116         toggling it on a WK2 window needs restart.
117         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
118         the WebPreferences just to support this temporary toggle.
119
120         * MiniBrowser/mac/BrowserWindowController.h:
121         * MiniBrowser/mac/MainMenu.xib:
122         * MiniBrowser/mac/WK1BrowserWindowController.m:
123         (-[WK1BrowserWindowController validateMenuItem:]):
124         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
125         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
126         * MiniBrowser/mac/WK2BrowserWindowController.m:
127         (-[WK2BrowserWindowController validateMenuItem:]):
128         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
129         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
130
131 2014-05-17  Anders Carlsson  <andersca@apple.com>
132
133         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
134         https://bugs.webkit.org/show_bug.cgi?id=133033
135         <rdar://problem/16830143>
136
137         Reviewed by Sam Weinig.
138
139         Set up the WebSQL and IndexedDB directories.
140
141         * WebKitTestRunner/TestController.cpp:
142         (WTR::TestController::initialize):
143
144 2014-05-16  Martin Hock  <mhock@apple.com>
145
146         MemoryCache::addImageToCache should return the result of add().
147         https://bugs.webkit.org/show_bug.cgi?id=132928
148         <rdar://problem/16651547>
149
150         Reviewed by Alexey Proskuryakov.
151
152         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
154         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
155         (TestWebKitAPI::TEST):
156
157 2014-05-15  David Farler  <dfarler@apple.com>
158
159         old-run-webkit-tests: allow specifying a simulator app path
160         https://bugs.webkit.org/show_bug.cgi?id=132975
161
162         Reviewed by Anders Carlsson.
163
164         * Scripts/old-run-webkit-tests:
165         (openIPhoneSimulator):
166         Add new --simulator-app command line parameter for specifying the
167         absolute path to the simulator app to launch before starting a
168         session.
169
170 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
171
172         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
173         https://bugs.webkit.org/show_bug.cgi?id=131363
174
175         Reviewed by Csaba Osztrogonác.
176
177         * Scripts/webkitpy/common/checkout/checkout_mock.py:
178         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
179         (MockBugzilla):
180         * Scripts/webkitpy/tool/commands/download_unittest.py:
181         (test_create_rollout_multiple_revision_with_one_resolved):
182         (test_create_rollout_multiple_resolved):
183         (test_rollout_two_revisions):
184         (test_rollout_multiple_revisions):
185         (test_rollout_multiple_revisions_with_a_missing_bug_id):
186         * Scripts/webkitpy/tool/steps/createbug.py:
187         (CreateBug.run):
188         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
189         (ReopenBugAfterRollout.run):
190
191 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
192
193         [WK2] Change the remaining framework includes from WebKit2 to WebKit
194         https://bugs.webkit.org/show_bug.cgi?id=132956
195
196         Reviewed by Sam Weinig.
197
198         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
199         * MiniBrowser/mac/AppDelegate.m:
200         * MiniBrowser/mac/WK2BrowserWindowController.m:
201         * TestWebKitAPI/InjectedBundleController.h:
202         * TestWebKitAPI/InjectedBundleMain.cpp:
203         * TestWebKitAPI/JavaScriptTest.cpp:
204         * TestWebKitAPI/PlatformUtilities.h:
205         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
206         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
207         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
208         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
209         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
212         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
213         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
214         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
215         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
216         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
217         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
218         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
219         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
220         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
221         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
222         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
223         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
224         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
225         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
226         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
227         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
228         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
229         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
230         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
231         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
232         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
233         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
234         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
235         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
236         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
237         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
238         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
239         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
240         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
241         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
242         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
243         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
244         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
245         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
246         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
247         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
248         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
249         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
250         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
251         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
252         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
253         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
254         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
255         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
256         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
257         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
258         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
259         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
260         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
261         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
262         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
263         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
264         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
265         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
266         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
267         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
268         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
269         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
270         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
271         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
272         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
273         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
274         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
275         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
276         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
277         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
278         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
279         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
280         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
281         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
282         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
283         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
284         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
285         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
286         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
287         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
288         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
289         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
290         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
291         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
292         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
293         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
294         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
295         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
296         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
297         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
298         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
299         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
300         * TestWebKitAPI/config.h:
301         * TestWebKitAPI/efl/PlatformWebView.cpp:
302         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
303         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
304         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
305         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
306         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
307         * WebKitTestRunner/EventSenderProxy.h:
308         * WebKitTestRunner/GeolocationProviderMock.cpp:
309         * WebKitTestRunner/GeolocationProviderMock.h:
310         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
311         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
312         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
313         * WebKitTestRunner/InjectedBundle/GCController.cpp:
314         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
315         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
316         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
320         * WebKitTestRunner/InjectedBundle/TestRunner.h:
321         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
322         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
324         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
325         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
326         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
327         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
328         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
329         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
330         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
331         * WebKitTestRunner/PlatformWebView.h:
332         * WebKitTestRunner/StringFunctions.h:
333         * WebKitTestRunner/TestController.cpp:
334         * WebKitTestRunner/TestController.h:
335         * WebKitTestRunner/TestInvocation.cpp:
336         * WebKitTestRunner/TestInvocation.h:
337         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
338         * WebKitTestRunner/WebNotificationProvider.cpp:
339         * WebKitTestRunner/WebNotificationProvider.h:
340         * WebKitTestRunner/WorkQueueManager.cpp:
341         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
342         * WebKitTestRunner/cg/TestInvocationCG.cpp:
343         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
344         * WebKitTestRunner/config.h:
345         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
346         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
347         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
348         * WebKitTestRunner/ios/TestControllerIOS.mm:
349         * WebKitTestRunner/mac/EventSenderProxy.mm:
350         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
351         * WebKitTestRunner/mac/TestControllerMac.mm:
352
353 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
354
355         [EFL][WK2] Skip failing unit tests
356         https://bugs.webkit.org/show_bug.cgi?id=132979
357
358         Reviewed by Daniel Bates.
359
360         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
361
362 2014-05-15  David Kilzer  <ddkilzer@apple.com>
363
364         [iOS] Support TestWebKitAPI in the iOS Simulator
365         <http://webkit.org/b/129535>
366         <rdar://problem/16203529>
367
368         Reviewed by Daniel Bates.
369
370         * Scripts/run-api-tests:
371         (runTest):
372         (listAllTests):
373         - Extract common arguments into local variable.
374         - Use xcrun to find the sim tool in order to invoke
375         TestWebKitAPI properly in the iOS Simulator. 
376
377         * Scripts/webkitdirs.pm:
378         (argumentsForConfiguration): Set --device or --sim as
379         appropriate to fix buildTestTool() in run-api-tests.
380
381 2014-05-15  Tim Horton  <timothy_horton@apple.com>
382
383         Fix a logging typo in copy-webkitlibraries-to-product-directory
384
385         Reviewed by Dean Jackson.
386
387         * Scripts/copy-webkitlibraries-to-product-directory:
388
389 2014-05-15  David Kilzer  <ddkilzer@apple.com>
390
391         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
392         <http://webkit.org/b/132959>
393
394         Reviewed by Dan Bernstein.
395
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
397         Cocoa directory to project and move URLExtras.mm into it.
398         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
399
400 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
401
402         [GTK] Compile all installed resources as GResources
403         https://bugs.webkit.org/show_bug.cgi?id=131099
404
405         Reviewed by Philippe Normand.
406
407         * Scripts/webkitpy/port/gtk.py:
408         (GtkPort.setup_environ_for_server): Removed now unneeded
409         AUDIO_RESOURCES_PATH env var.
410
411 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
412
413         Remove CSS_STICKY_POSITION guards
414         https://bugs.webkit.org/show_bug.cgi?id=132676
415
416         Reviewed by Simon Fraser.
417
418         * Scripts/webkitperl/FeatureList.pm:
419
420 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
421
422         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
423         https://bugs.webkit.org/show_bug.cgi?id=132686
424
425         Reviewed by Philippe Normand.
426
427         Bring back InputMethodFilter test to the build and compile it into
428         a single binary TestWebCore with the other WebCore tests. Also
429         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
430
431         * Scripts/run-gtk-tests:
432         (TestRunner): Remove WebCoreGtk from the list of test directories.
433         * TestWebKitAPI/PlatformGTK.cmake:
434         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
435
436 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
437
438         [EFL] Make XVFBDriver optional
439         https://bugs.webkit.org/show_bug.cgi?id=131036
440
441         Reviewed by Gyuyoung Kim.
442
443         * Scripts/webkitpy/port/efl.py:
444         (EflPort._driver_class):
445
446 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
447
448         Flakiness dashboard contains outdated list of bots on builders.jsonp
449         https://bugs.webkit.org/show_bug.cgi?id=132874
450
451         Reviewed by Darin Adler.
452
453         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
454         file by changing to the directory Tools/TestResultServer and executing
455         the script generate_builders_json.py
456
457 2014-05-11  Anders Carlsson  <andersca@apple.com>
458
459         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
460         https://bugs.webkit.org/show_bug.cgi?id=132809
461
462         Reviewed by Dan Bernstein.
463
464         * WebKitTestRunner/TestController.cpp:
465         (WTR::TestController::initialize):
466         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
467
468 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
469
470         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
471         https://bugs.webkit.org/show_bug.cgi?id=132739
472
473         Reviewed Anders Carlsson.
474
475         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
476         the JSC unit tests.
477         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
478
479 2014-05-11  Anders Carlsson  <andersca@apple.com>
480
481         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
482         https://bugs.webkit.org/show_bug.cgi?id=132806
483
484         Reviewed by Beth Dakin.
485
486         Migrate to WKContextConfiguration.
487
488         * WebKitTestRunner/TestController.cpp:
489         (WTR::TestController::initialize):
490
491 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
492
493         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
494         https://bugs.webkit.org/show_bug.cgi?id=132685
495
496         Reviewed by Martin Robinson.
497
498         Use a single TestWebKit2 binary for all WebKit2 C API tests.
499
500         * TestWebKitAPI/PlatformGTK.cmake:
501
502 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
503
504         [iOS] Switch geolocation to an explicit authorization query model
505         https://bugs.webkit.org/show_bug.cgi?id=132717
506
507         Reviewed by Sam Weinig.
508
509         * DumpRenderTree/mac/MockGeolocationProvider.mm:
510         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
511         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
512
513 2014-05-09  David Farler  <dfarler@apple.com>
514
515         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
516         https://bugs.webkit.org/show_bug.cgi?id=132718
517
518         Reviewed by David Kilzer.
519
520         The simulator may not be able to look up runtimes by SDK paths
521         and instead will map SDK versions to runtimes instead. In
522         com.apple.iphonesimulator.startSession notifications,
523         'runtimeIdentifier' (SDK version string) is preferred over
524         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
525         when creating a new DRT or WKTR simulator session.
526
527         IPhoneSimulatorNotification.pm filters out keys for this
528         notification's userInfo with a hard-coded list. There's no harm
529         in including extra key-value pairs in an NSNotification userInfo
530         dictionary anyway and the simulator may again change its
531         userInfo schema for this notification.
532
533         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
534         (postStartSessionNotification):
535         * Scripts/old-run-webkit-tests:
536         (installAndLaunchDumpToolAppUsingNotification):
537
538 2014-05-09  Anders Carlsson  <andersca@apple.com>
539
540         Another build fix.
541
542         * Scripts/build-webkit:
543         WebKit2 should always be built for OS X and iOS.
544
545 2014-05-09  Anders Carlsson  <andersca@apple.com>
546
547         Follow-up build fix.
548
549         * Scripts/build-webkit:
550         WebKit2 should no longer be built before WebKit.
551
552 2014-05-09  Anders Carlsson  <andersca@apple.com>
553
554         Rename WebKit2.framework to WebKit.framework
555         https://bugs.webkit.org/show_bug.cgi?id=132743
556         <rdar://problem/15920046>
557
558         Reviewed by Dan Bernstein.
559
560         * Scripts/check-for-inappropriate-files-in-framework:
561         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
562         Change WebKit2 to WebKit.
563
564         * Scripts/check-for-webkit-framework-include-consistency:
565         Change WebKit to WebKitLegacy.
566
567 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
568
569         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
570         https://bugs.webkit.org/show_bug.cgi?id=132732
571
572         Reviewed by Alexey Proskuryakov.
573
574         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
575
576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
577         (EWS): Remove GTK+ WK1 EWS.
578
579 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
580
581         Add new u-szeged contributors.
582
583         Reviewed by Csaba Osztrogonác.
584
585         * Scripts/webkitpy/common/config/contributors.json:
586
587 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
588
589         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
590         https://bugs.webkit.org/show_bug.cgi?id=132736
591
592         Reviewed by Philippe Normand.
593
594         There are two problems, the path returned by common.library_build_path() is wrong when
595         common.binary_build_path() has previously been called, and the test is still looking for
596         the .la instead of .so
597
598         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
599         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
600         of .la as extension of the injected bundle library.
601         * gtk/common.py:
602         (binary_build_path): Remove unused global variable and add a new
603         one for binary_build_dir instead of sharing the same global
604         variable for library_build_path and binary_build_path.
605
606 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
607
608         [EFL] Enable MEDIA_STREAM for EFL port
609         https://bugs.webkit.org/show_bug.cgi?id=132648
610
611         Reviewed by Gyuyoung Kim.
612
613         Script modified to enable MEDIA_STREAM for EFL build.
614
615         * Scripts/webkitperl/FeatureList.pm: 
616
617 2014-05-08  David Farler  <dfarler@apple.com>
618
619         old-run-webkit-tests: update strings for simulator devices and app name
620         https://bugs.webkit.org/show_bug.cgi?id=132687
621
622         Reviewed by Darin Adler.
623
624         iPhone Retina (4-inch) -> iPhone 5
625         iPhone Retina (4-inch 64-bit) -> iPhone 5s
626
627         * Scripts/old-run-webkit-tests:
628         (installAndLaunchDumpToolAppUsingNotification):
629         (openIPhoneSimulator):
630         (quitIPhoneSimulator):
631         quit iOS Simulator, not iPhone Simulator.
632
633 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
634
635         REGRESSION(r168471): Update the builder names on the scheduler list.
636         https://bugs.webkit.org/show_bug.cgi?id=132699
637
638         Reviewed by Martin Robinson.
639
640         On r168471 I missed to update the builder names for the GTK build
641         bots on the AnyBranchScheduler type scheduler list of bots.
642
643         * BuildSlaveSupport/build.webkit.org-config/config.json:
644
645 2014-05-08  Brady Eidson  <beidson@apple.com>
646
647         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
648         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
649
650         Reviewed by Tim Horton.
651
652         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
653         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
654
655 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
656
657         REGRESSION(r168471): Duplicate builddirs broke the build master.
658         https://bugs.webkit.org/show_bug.cgi?id=132688
659
660         Reviewed by Carlos Garcia Campos.
661
662         Rename the builddirs of the new GTK bots introduced on r168471 to
663         be unique. Otherwise the master will break.
664
665         * BuildSlaveSupport/build.webkit.org-config/config.json:
666
667 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
668
669         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
670         https://bugs.webkit.org/show_bug.cgi?id=132674
671
672         Reviewed by Philippe Normand.
673
674         Only ignore mkdir failure when exception is raised because the
675         file already exists and it's a directory.
676
677         * gtk/webkitdom.py:
678         (write_doc_files):
679
680 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
681
682         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
683         https://bugs.webkit.org/show_bug.cgi?id=131358
684
685         Reviewed by Carlos Garcia Campos.
686
687         Current 64-bit GTK build bots (Release and Debug) not only test
688         the build, but run all tests. Split each one of the bots in
689         BuildOnly and TestWebKit2.
690
691         This will allow us to have a better overview of the status of
692         the GTK port.
693
694         Original patch from Sergio Villar Senin <svillar@igalia.com>
695
696         * BuildSlaveSupport/build.webkit.org-config/config.json:
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
699         (WebKitBuildbot):
700         * Scripts/webkitpy/port/builders.py:
701         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
702         (TestRebaselineTest.test_baseline_directory):
703         * TestResultServer/static-dashboards/builders.jsonp:
704         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
705         (resetGlobals):
706         * TestResultServer/static-dashboards/loader_unittests.js:
707
708 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
709
710         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
711         https://bugs.webkit.org/show_bug.cgi?id=126022
712
713         Reviewed by Benjamin Poulain.
714
715         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
716
717         Added an unit test case to check if scroll position and scale are restored properly.
718
719         * TestWebKitAPI/PlatformEfl.cmake:
720         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
721         (TestWebKitAPI::didFinishLoadForFrame):
722         (TestWebKitAPI::didChangeContentsPosition):
723         (TestWebKitAPI::TEST):
724         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
725         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
726
727 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
728
729         WebKit1 is flashy when compositing layers come and go
730         https://bugs.webkit.org/show_bug.cgi?id=132655
731         <rdar://problem/16830981&16788846>
732
733         Reviewed by Sam Weinig.
734         
735         Revert the change from r166117.
736
737         * DumpRenderTree/mac/DumpRenderTree.mm:
738         (updateDisplay):
739
740 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
741
742         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
743         https://bugs.webkit.org/show_bug.cgi?id=132622
744
745         Reviewed by Mario Sanchez Prada.
746
747         * DumpRenderTree/AccessibilityUIElement.cpp:
748         (selectTextWithCriteriaCallback):
749         (isEqualCallback):
750         * DumpRenderTree/AccessibilityUIElement.h:
751         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
752         (AccessibilityUIElement::selectTextWithCriteria):
753         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
754         (AccessibilityUIElement::selectTextWithCriteria):
755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
756         (selectTextParameterizedAttributeForCriteria):
757         (AccessibilityUIElement::selectTextWithCriteria):
758         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
759         (AccessibilityUIElement::selectTextWithCriteria):
760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
761         (WTR::AccessibilityUIElement::selectTextWithCriteria):
762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
764         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
765         (WTR::AccessibilityUIElement::selectTextWithCriteria):
766         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
767         (WTR::AccessibilityUIElement::selectTextWithCriteria):
768         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
769         (WTR::selectTextParameterizedAttributeForCriteria):
770         (WTR::AccessibilityUIElement::selectTextWithCriteria):
771
772 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
773
774         [SOUP] TLSErrors do not cause page load to fail when not ignored
775         https://bugs.webkit.org/show_bug.cgi?id=121548
776
777         Reviewed by Sergio Villar Senin.
778
779         Add unit tests to check that the load fails with TLS errors in
780         case of a redirection.
781
782         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
783         (testTLSErrorsRedirect):
784         (httpsServerCallback):
785         (beforeAll):
786
787 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
788
789         [CSS Grid Layout] Remove runtime feature
790         https://bugs.webkit.org/show_bug.cgi?id=132382
791
792         Reviewed by Benjamin Poulain.
793
794         Remove cssGridLayoutEnabled setting usage.
795
796         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
797         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
798         * DumpRenderTree/efl/TestRunnerEfl.cpp:
799         (TestRunner::overridePreference):
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (resetWebPreferencesToConsistentValues):
802
803 2014-05-06  David Kilzer  <ddkilzer@apple.com>
804
805         Add Makefile targets for copying static libraries (LLVM and WKSI)
806         <http://webkit.org/b/132619>
807
808         Reviewed by Mark Rowe.
809
810         * Scripts/copy-webkitlibraries-to-product-directory: Set a
811         sensible default for product directory if not specified on
812         either the command-line or in the environment (by Xcode) by
813         calling productDir() in webkitdirs.pm.
814
815 2014-05-06  Brady Eidson  <beidson@apple.com>
816
817         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
818         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
819
820         Reviewed by Sam Weinig.
821
822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
823
824         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
825         (TestWebKitAPI::itemURLLastComponentIsString):
826         (TestWebKitAPI::didFinishLoadForFrame):
827         (TestWebKitAPI::willGoToBackForwardListItem):
828         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
829         (TestWebKitAPI::setPageLoaderClient):
830         (TestWebKitAPI::TEST):
831         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
832         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
833
834         * WebKitTestRunner/TestController.cpp:
835         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
836
837 2014-05-06  Darin Adler  <darin@apple.com>
838
839         Try to fix iOS build.
840
841         * DumpRenderTree/mac/TestRunnerMac.mm:
842         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
843         Updated since I changed testRunner into a pointer instead of a reference.
844         Updated argument names to avoid conflict with field names.
845         (-[APITestDelegateIPhone run]): Ditto.
846         (-[APITestDelegateIPhone _cleanUp]): Ditto.
847
848 2014-05-06  Commit Queue  <commit-queue@webkit.org>
849
850         Unreviewed, rolling out r168304.
851         https://bugs.webkit.org/show_bug.cgi?id=132607
852
853         Broke the build (Requested by KaL on #webkit).
854
855         Reverted changeset:
856
857         "[GTK][CMake] Unable to do make install"
858         https://bugs.webkit.org/show_bug.cgi?id=130188
859         http://trac.webkit.org/changeset/168304
860
861 2014-05-04  Darin Adler  <darin@apple.com>
862
863         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
864         https://bugs.webkit.org/show_bug.cgi?id=80222
865
866         Reviewed by Alexey Proskuryakov.
867
868         * DumpRenderTree/mac/TestRunnerMac.mm:
869         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
870         do more work here so we don't use RetainPtr local variables.
871         (-[APITestDelegateIPhone dealloc]): Added.
872         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
873         created. Updated for changes to member names and types.
874         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
875         updated for changes to member names and types. Changed to two word spelling.
876         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
877         name of _cleanUp method.
878         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
879         Ditto.
880         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
881
882 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
883
884         Clean up Image Document and tweak the layout and viewport
885         https://bugs.webkit.org/show_bug.cgi?id=132552
886
887         Reviewed by Anders Carlsson.
888
889         * DumpRenderTree/mac/DumpRenderTree.mm:
890         (resetWebPreferencesToConsistentValues):
891         Update the default settings to have something consistent with WebKit2.
892
893 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
894
895         [GTK][CMake] Unable to do make install
896         https://bugs.webkit.org/show_bug.cgi?id=130188
897
898         Reviewed by Carlos Garcia Campos.
899
900         * Scripts/webkitdirs.pm:
901         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
902         will give an early signal that a change has broken the documentation.
903
904 2014-05-05  Pratik Solanki  <psolanki@apple.com>
905
906         Update framework locations in package-root
907         https://bugs.webkit.org/show_bug.cgi?id=132571
908
909         Reviewed by Simon Fraser.
910
911         * Scripts/package-root:
912
913 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
914
915         [EFL][WK2] Refactor favicon database APIs
916         https://bugs.webkit.org/show_bug.cgi?id=132519
917
918         Reviewed by Gyuyoung Kim.
919
920         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
921         (update_view_favicon):
922         (on_icon_changed_cb):
923         (window_free):
924         (on_url_changed):
925         (window_create):
926         (on_view_favicon_changed): Deleted.
927
928 2014-05-02  Mark Rowe  <mrowe@apple.com>
929
930         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
931
932         Reviewed by Dan Bernstein.
933
934         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
935         when determining which LLVM archive to extract.
936
937 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
938
939         Add Jeremy as a committer.
940         https://bugs.webkit.org/show_bug.cgi?id=132492
941
942         Reviewed by Jer Noble.
943
944         Add myself as a committer.
945
946         * Scripts/webkitpy/common/config/contributors.json:
947
948 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
949
950         Add Jeremy as a committer.
951         https://bugs.webkit.org/show_bug.cgi?id=132492
952
953         Reviewed by Jer Noble.
954
955         Add Jeremy Jones to the committers file.
956
957         * Scripts/webkitpy/common/config/contributors.json:
958
959 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
960
961         Hard to figure out how to run a single test with run-api-tests
962         https://bugs.webkit.org/show_bug.cgi?id=116332
963
964         Reviewed by Alexey Proskuryakov.
965
966         * Scripts/run-api-tests: add two examples to the help message.
967
968 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
969
970         Fix several memory leaks found by code inspection
971         https://bugs.webkit.org/show_bug.cgi?id=132472
972
973         Reviewed by Geoffrey Garen.
974         
975         Fix memory leaks.
976
977         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
978         (TestWebKitAPI::TEST):
979         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
980         (WTR::InjectedBundlePage::willSendRequestForFrame):
981         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
982         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
983
984 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
985
986         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
987         https://bugs.webkit.org/show_bug.cgi?id=132446
988
989         Reviewed by Mark Hahnenberg.
990         
991         Test the FTL by default now that it's enabled by default.
992
993         * Scripts/run-javascriptcore-tests:
994
995 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
996
997         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
998         https://bugs.webkit.org/show_bug.cgi?id=132240
999
1000         Reviewed by Anders Carlsson.
1001
1002         Removed ewk_view_setting_tiled_backingstore related code.
1003
1004         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1005         (DumpRenderTreeChrome::createView):
1006         (shouldUseTiledBackingStore): Deleted.
1007         * EWebLauncher/main.c:
1008         (windowCreate):
1009         (parseUserArguments):
1010
1011 2014-05-01  Anders Carlsson  <andersca@apple.com>
1012
1013         window.testRunner.keepWebHistory() should update the UI process state
1014         https://bugs.webkit.org/show_bug.cgi?id=132440
1015
1016         Reviewed by Dan Bernstein.
1017
1018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1019         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1020         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1021         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1022         (WTR::TestRunner::keepWebHistory):
1023         * WebKitTestRunner/TestInvocation.cpp:
1024         (WTR::TestInvocation::invoke):
1025         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1026
1027 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1028
1029         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1030         <http://webkit.org/b/132432>
1031
1032         Reviewed by Tim Horton.
1033
1034         * Scripts/webkitperl/FeatureList.pm: Remove support for
1035         --plugin-proxy-for-video switch.
1036
1037 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1038
1039         Kernel sysctl interface hw.activecpu don't exists on Linux.
1040         https://bugs.webkit.org/show_bug.cgi?id=132286
1041
1042         Reviewed by Filip Pizlo.
1043
1044         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1045         calling sysctl over hw.activecpu
1046
1047 2014-04-30  Anders Carlsson  <andersca@apple.com>
1048
1049         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1050         https://bugs.webkit.org/show_bug.cgi?id=132399
1051         <rdar://problem/15920046>
1052
1053         Reviewed by Dan Bernstein.
1054
1055         * Scripts/check-for-webkit-framework-include-consistency:
1056         Allos WAK headers in WebKitLegacy as well as WebKit.
1057
1058         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1059         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1060         Update header imports.
1061
1062 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1063
1064         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1065         https://bugs.webkit.org/show_bug.cgi?id=131954
1066
1067         Reviewed by Darin Adler.
1068         
1069         WebKitTestRunner was adding application-specific information to crash reports
1070         to log the test path, but only in the web process. Fix it to also do this
1071         for the UI process, for both iOS and OS X.
1072         
1073         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1074         both iOS and OS X.
1075         
1076         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1077         a new TestController::platformWillRunTest() function on Mac and iOS.
1078         
1079         Also remove Xcode-added unit test junk from the project.
1080
1081         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1082         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1083         * WebKitTestRunner/TestController.cpp:
1084         (WTR::TestController::runTest):
1085         * WebKitTestRunner/TestController.h:
1086         * WebKitTestRunner/TestInvocation.cpp:
1087         (WTR::TestInvocation::url):
1088         * WebKitTestRunner/TestInvocation.h:
1089         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1090         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1091         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1092         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1093         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1094         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1095         (WTR::testPathFromURL):
1096         (WTR::setCrashReportApplicationSpecificInformationToURL):
1097         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1098         (WTR::TestController::platformWillRunTest):
1099         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1100         (WTR::TestController::platformWillRunTest):
1101         * WebKitTestRunner/ios/TestControllerIOS.mm:
1102         (WTR::TestController::platformWillRunTest):
1103         (WTR::TestController::setHidden):
1104         * WebKitTestRunner/mac/TestControllerMac.mm:
1105         (WTR::TestController::platformWillRunTest):
1106
1107 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1108
1109         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1110
1111         Reviewed by Tim Horton.
1112
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (resetWebPreferencesToConsistentValues):
1115         (prepareConsistentTestingEnvironment):
1116
1117 2014-04-30  Anders Carlsson  <andersca@apple.com>
1118
1119         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1120         https://bugs.webkit.org/show_bug.cgi?id=132397
1121
1122         Reviewed by Dan Bernstein.
1123
1124         * Scripts/check-for-inappropriate-macros-in-external-headers:
1125
1126 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1127
1128         [GTK] Make it easier to run CMake for downstreams
1129         https://bugs.webkit.org/show_bug.cgi?id=132370
1130
1131         Reviewed by Carlos Garcia Campos.
1132
1133         * Scripts/webkitdirs.pm:
1134         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1135         the GTK+ port.
1136
1137 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1138
1139         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1140         
1141         Rubber stamped by Jessie Berlin.
1142
1143         JSON.pm was removed from our tools setup.
1144
1145         * Scripts/generate-coverage-data:
1146
1147 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1148
1149         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1150         https://bugs.webkit.org/show_bug.cgi?id=112840
1151
1152         Rubber stamped by Geoffrey Garen.
1153
1154         * Scripts/build-jsc: Enable it on Mac.
1155         * Scripts/build-webkit: Enable it on Mac.
1156         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1157
1158 2014-04-28  Sam Weinig  <sam@webkit.org>
1159
1160         REGRESSION (r167751): svn-create-patch is very slow
1161         https://bugs.webkit.org/show_bug.cgi?id=132300
1162
1163         Reviewed by Alexey Proskuryakov.
1164
1165         * Scripts/svn-create-patch:
1166         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1167         by calling `svn-create-patch --style`.
1168
1169 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1170
1171         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1172         https://bugs.webkit.org/show_bug.cgi?id=132190
1173
1174         Reviewed by Gustavo Noronha Silva.
1175
1176         * Scripts/webkitdirs.pm:
1177         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1178             if ninja is in the path.
1179         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1180             to the previous ninja generator if not.
1181
1182 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1183
1184         check-webkit-style should understand --git-index
1185         https://bugs.webkit.org/show_bug.cgi?id=125364
1186
1187         Reviewed by Csaba Osztrogonác.
1188
1189         * Scripts/webkitpy/common/checkout/scm/git.py:
1190         (Git.create_patch): The command now supports the --cached option.
1191         * Scripts/webkitpy/style/main.py:
1192         (CheckWebKitStyle.main): Passing the --git-index option.
1193         * Scripts/webkitpy/style/optparser.py:
1194         (CommandOptionValues.__init__): The git-index option is switched off by default.
1195         (CommandOptionValues.__eq__): Equality check for the new option.
1196         (ArgumentParser._create_option_parser):Adding the --git-index option
1197         (ArgumentParser.parse):
1198         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1199         (CommandOptionValuesTest.test_init): 
1200         (CommandOptionValuesTest.test_eq):
1201
1202 2014-04-28  Michael Saboff  <msaboff@apple.com>
1203
1204         Crash in platform/mac/accessibility/table-visible-rows.html
1205         https://bugs.webkit.org/show_bug.cgi?id=132146
1206
1207         Reviewed by Filip Pizlo.
1208
1209         Instead of creating a local JSValueRef array on the stack and passing that to
1210         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1211         values using the JSObjectSetPropertyAtIndex() API.
1212
1213         * DumpRenderTree/AccessibilityUIElement.cpp:
1214         (elementsForRangeCallback):
1215         (convertElementsToObjectArray):
1216         * DumpRenderTree/mac/TestRunnerMac.mm:
1217         (originsArrayToJS):
1218         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1219         (WTR::EventSendingController::contextClick):
1220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1221         (WTR::stringArrayToJS):
1222         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1223         (WTR::convertElementsToObjectArray):
1224
1225 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1226
1227         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1228         "no-cjit" runs force the old-school threshold.
1229
1230         Rubber stamped by Mark Hahnenberg.
1231
1232         * Scripts/run-jsc-stress-tests:
1233
1234 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1235
1236         [GTK] install-dependencies should also install ruby-json and ruby-highline
1237         https://bugs.webkit.org/show_bug.cgi?id=132292
1238
1239         Reviewed by Philippe Normand.
1240
1241         * gtk/install-dependencies: Install ruby json and highline packages.
1242
1243 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1244
1245         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1246         https://bugs.webkit.org/show_bug.cgi?id=132176
1247
1248         Reviewed by Gyuyoung Kim.
1249
1250         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1251         and turn off indexedDB feature until the sqlite implementation is introduced.
1252
1253         * Scripts/webkitperl/FeatureList.pm:
1254
1255 2014-04-25  James Craig  <jcraig@apple.com>
1256
1257         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1258         https://bugs.webkit.org/show_bug.cgi?id=132209
1259
1260         Reviewed by Daniel Bates.
1261
1262         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1263         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1264
1265         * Scripts/prepare-ChangeLog:
1266         (main): 
1267
1268 2014-04-25  Michael Saboff  <msaboff@apple.com>
1269
1270         Crash in platform/mac/accessibility/table-visible-rows.html
1271         https://bugs.webkit.org/show_bug.cgi?id=132146
1272
1273         Reviewed by Mark Lam.
1274
1275         Changed to use a local JSValueRef array temporary instead of a
1276         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1277         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1278         the temporary values could be collected.
1279
1280         * DumpRenderTree/AccessibilityUIElement.cpp:
1281         (convertElementsToObjectArray):
1282         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1283         (WTR::EventSendingController::contextClick):
1284         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1285         (WTR::convertElementsToObjectArray):
1286
1287 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1288
1289         Unreviewed GTK gardening
1290
1291         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1292         (TestRunner):
1293
1294 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1295
1296         prepare-ChangeLog reports as deleted methods that has not been removed.
1297         https://bugs.webkit.org/show_bug.cgi?id=131733
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         * Scripts/prepare-ChangeLog:
1302         (originalFile): Set merge base to origin/master by default.
1303
1304 2014-04-23  James Craig  <jcraig@apple.com>
1305
1306         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1307         https://bugs.webkit.org/show_bug.cgi?id=131115
1308
1309         Reviewed by Daniel Bates.
1310
1311         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1312
1313         * Scripts/commit-log-editor: Added --no-style.
1314         * Scripts/prepare-ChangeLog: Primary patch.
1315         (main): Primary patch.
1316         (createPatchCommand): Added --no-style.
1317         * Scripts/svn-create-patch: Primary patch.
1318         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1319         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1320         (SVN.create_patch): Added --no-style.
1321
1322 2014-04-23  Anders Carlsson  <andersca@apple.com>
1323
1324         Try to fix iOS build.
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327
1328 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
1329
1330         Eliminate internals.setMockScrollbarsEnabled()
1331         https://bugs.webkit.org/show_bug.cgi?id=132085
1332
1333         Reviewed by Tim Horton.
1334
1335         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
1336         No need to reset the preference, there is no way it can change.
1337
1338 2014-04-23  James Craig  <jcraig@apple.com>
1339
1340         Unreviewed. Moving myself from Contributors to Committers list.
1341
1342         * Scripts/webkitpy/common/config/contributors.json:
1343
1344 2014-04-23  Tim Horton  <timothy_horton@apple.com>
1345
1346         Mock scrollbars don't always work in DumpRenderTree
1347         https://bugs.webkit.org/show_bug.cgi?id=132082
1348
1349         Reviewed by Alexey Proskuryakov.
1350
1351         * DumpRenderTree/mac/DumpRenderTree.mm:
1352         (prepareConsistentTestingEnvironment):
1353         Set the mock scrollbar setting before creating the WebView, as this setting
1354         cannot be dynamically changed, so any scrollbars that are created during
1355         WebView initialization and are not replaced before snapshotting will end
1356         up being platform scrollbars instead of mock ones.
1357         WebKitTestRunner already sets this preference before creating WKViews,
1358         so we're just matching its behavior.
1359
1360 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1361
1362         [GTK] ShadowRoot API was removed in r164131
1363         https://bugs.webkit.org/show_bug.cgi?id=132059
1364
1365         Reviewed by Gustavo Noronha Silva.
1366
1367         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1368         the API docs.
1369
1370         * gtk/webkitdom.py:
1371         (WebKitDOMDocGenerator):
1372
1373 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1374
1375         [GTK] run-webkit-tests script is failing to invoke run-launcher
1376         https://bugs.webkit.org/show_bug.cgi?id=132051
1377
1378         Reviewed by Philippe Normand.
1379
1380         After the WK1 support was dropped, if run-webkit-tests is executed
1381         without --no-show-results parameter, the launcher is being called
1382         using a -2 parameter that is it causing the run-launcher to break.
1383
1384         * Scripts/webkitpy/port/gtk.py:
1385         (GtkPort.show_results_html_file):
1386
1387 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1388
1389         DumpRenderTree generates black snapshots on some platforms
1390         https://bugs.webkit.org/show_bug.cgi?id=132029
1391         <rdar://problem/16679363>
1392
1393         Reviewed by Simon Fraser.
1394
1395         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1396         (createBitmapContextFromWebView):
1397         DRT checks with the WebView to determine whether it can use the window's
1398         backing store directly or (because of compositing) needs to take a WindowServer
1399         snapshot. However, on some platforms and in some situations, the window can
1400         be layer backed without the WebView necessarily currently being composited.
1401         We should check with the window in addition to the WebView before going
1402         ahead and using its backing store.
1403
1404 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1405
1406         DumpRenderTree generates white snapshots on some platforms
1407         https://bugs.webkit.org/show_bug.cgi?id=132026
1408         <rdar://problem/16679363>
1409
1410         Reviewed by Simon Fraser.
1411
1412         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1413         Link DRT against QuartzCore.
1414
1415         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1416         (createBitmapContextFromWebView):
1417         Force CoreAnimation to synchronously update layers in a more explicit
1418         way that doesn't depend on AppKit behavior. This is very similar to what
1419         WebKitTestRunner does (indirectly) during its force repaint.
1420
1421 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1422
1423         [Win] Support Python 2.7 in Cygwin
1424         https://bugs.webkit.org/show_bug.cgi?id=132023
1425
1426         Reviewed by Michael Saboff.
1427
1428         * Scripts/webkitdirs.pm:
1429         (checkInstalledTools): Remove check for Python 2.7, since
1430         it now works properly.
1431
1432 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1433
1434         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1435         https://bugs.webkit.org/show_bug.cgi?id=130867
1436         <rdar://problem/16432456> 
1437
1438         Reviewed by Mark Hahnenberg.
1439
1440         * Scripts/build-webkit:
1441         * Scripts/copy-webkitlibraries-to-product-directory:
1442
1443 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1444
1445         [GTK] Fails to build documentation when output is redirected
1446         https://bugs.webkit.org/show_bug.cgi?id=131178
1447
1448         Reviewed by Martin Robinson.
1449
1450         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1451         explicitly to avoid encoding issues when they are redirected.
1452
1453 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1454
1455         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1456         https://bugs.webkit.org/show_bug.cgi?id=131911
1457
1458         Reviewed by Martin Robinson.
1459
1460         common.get_build_path returns release path even though Debug configuration
1461         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1462
1463         * gtk/ycm_extra_conf.py:
1464         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1465         (FlagsForFile):
1466
1467 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1468
1469         Unreviewed build fix.
1470
1471         * DumpRenderTree/mac/EventSendingController.mm:
1472         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1473         Correct a typo that prevented tests from working properly.
1474
1475 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1476
1477         [GTK] Should have the ability to output composited contents during layout testing
1478         https://bugs.webkit.org/show_bug.cgi?id=131864
1479
1480         Reviewed by Philippe Normand.
1481
1482         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1483         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1484         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1485         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1486         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1487
1488 2014-04-21  Sam Weinig  <sam@webkit.org>
1489
1490         Attempt to fix the tests.
1491
1492         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1493         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1494         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1495
1496 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1497
1498         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1499         being the same as a "quick run", which is meant for genuinely slow tests).
1500
1501         * Scripts/run-jsc-stress-tests:
1502
1503 2014-04-21  Darin Adler  <darin@apple.com>
1504
1505         Add HashSet::takeAny
1506         https://bugs.webkit.org/show_bug.cgi?id=131928
1507
1508         Reviewed by Benjamin Poulain.
1509
1510         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1511
1512 2014-04-20  Dan Bernstein  <mitz@apple.com>
1513
1514         Fixed a test timing out after r167572.
1515
1516         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1517         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1518         -webView:didFinishLoadingNavigation:.
1519
1520 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1521
1522         Unreviewed, rolling out r167510.
1523         https://bugs.webkit.org/show_bug.cgi?id=131915
1524
1525         broke GTK Debug bot (Requested by philn on #webkit).
1526
1527         Reverted changeset:
1528
1529         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1530         it when running layout tests"
1531         https://bugs.webkit.org/show_bug.cgi?id=131472
1532         http://trac.webkit.org/changeset/167510
1533
1534 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1535
1536         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1537         https://bugs.webkit.org/show_bug.cgi?id=131472
1538
1539         Reviewed by Philippe Normand.
1540
1541         * Scripts/webkitpy/port/gtk.py:
1542         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1543         when running WebKitTestRunner with run-webkit-tests.
1544         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1545         installed.
1546         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1547         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1548         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1549         deal.
1550
1551 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1552
1553         DownloadDecideDestinationCrash API test uses an incorrect value for path
1554         https://bugs.webkit.org/show_bug.cgi?id=131845
1555         <rdar://problem/15925560>
1556
1557         Reviewed by Enrica Casucci.
1558
1559         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1560         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1561
1562 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1563
1564         [Mac] AttributedStringTest API tests fail with async text input
1565         https://bugs.webkit.org/show_bug.cgi?id=131833
1566
1567         Reviewed by Enrica Casucci.
1568
1569         Don't run sync NSTextInputClient tests where we don't implement these calls.
1570
1571         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1572         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1573         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1574         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1575         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1576         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1577         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1578
1579 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1580
1581         Remove NETWORK_INFO support
1582         https://bugs.webkit.org/show_bug.cgi?id=131841
1583
1584         Reviewed by Gyuyoung Kim.
1585
1586         * Scripts/webkitperl/FeatureList.pm:
1587
1588 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1589
1590         [GTK] YouCompleteMe doesn't work for cmake build system.
1591         https://bugs.webkit.org/show_bug.cgi?id=131591
1592
1593         Reviewed by Martin Robinson.
1594
1595         Add cmake build system support for YouCompleteMe. It should work regardless of
1596         using make or ninja. In addition, autotools related code is removed since it's
1597         not used anymore in WebKit.
1598
1599         * Scripts/webkitdirs.pm:
1600         (generateBuildSystemFromCMakeProject):
1601         * gtk/ycm_extra_conf.py:
1602         (transform_relative_paths_to_absolute_paths):
1603         (FlagsForFile):
1604
1605 2014-04-17  Anders Carlsson  <andersca@apple.com>
1606
1607         Fix build.
1608
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1610         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1611         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1612
1613 2014-04-17  Anders Carlsson  <andersca@apple.com>
1614
1615         Remove unused API enums
1616         https://bugs.webkit.org/show_bug.cgi?id=131836
1617
1618         Reviewed by Tim Horton.
1619
1620         * MiniBrowser/mac/WK2BrowserWindowController.m:
1621         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1622
1623 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1624
1625         [Win] A few final cleanups to the DataObject classes.
1626         https://bugs.webkit.org/show_bug.cgi?id=131784
1627
1628         Reviewed by Anders Carlsson.
1629
1630         * DumpRenderTree/win/DRTDataObject.cpp:
1631         (DRTDataObject::clearData): Use 'last()' method.
1632         * DumpRenderTree/win/UIDelegate.cpp:
1633         (DRTUndoStack::pop): Use 'takeLast()' method.
1634
1635 2014-04-17  Andres Gomez  <agomez@igalia.com>
1636
1637         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1638         https://bugs.webkit.org/show_bug.cgi?id=131365
1639
1640         Reviewed by Brent Fulgham.
1641
1642         The cygwin installer is now downloading the wanted versions for
1643         the local installation given to the setup wizard.
1644
1645         * CygwinDownloader/cygwin-downloader.py:
1646         * CygwinDownloader/cygwin-downloader.zip:
1647
1648 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1649
1650         [GTK] Make run-webkit-tests always use WKTR
1651         https://bugs.webkit.org/show_bug.cgi?id=131737
1652
1653         Reviewed by Darin Adler.
1654
1655         Now that the GTK+ port only has support for WebKit2, instruct
1656         run-webkit-tests to always use WKTR. This avoids needing to pass
1657         flag "-2" every time.
1658
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1660         (_set_up_derived_options): Always set webkit_test_runner when
1661         the platform is GTK+.
1662
1663 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1664
1665         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1666         https://bugs.webkit.org/show_bug.cgi?id=131760
1667
1668         Reviewed by Philippe Normand.
1669
1670         * gtk/install-dependencies: Install ninja-build when it's available.
1671
1672 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1673
1674         [Win] run-javascriptcore-tests fails to run.
1675         https://bugs.webkit.org/show_bug.cgi?id=131761
1676
1677         Reviewed by Brent Fulgham.
1678
1679         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1680
1681 2014-04-16  Andres Gomez  <agomez@igalia.com>
1682
1683         [Win] Pass default parameters to cygwin setup wizard
1684         https://bugs.webkit.org/show_bug.cgi?id=131361
1685
1686         Reviewed by Brent Fulgham.
1687
1688         Added some parameters to the cygwin setup wizard so the user
1689         doesn't really have to do any interaction.
1690
1691         * CygwinDownloader/cygwin-downloader.py:
1692         * CygwinDownloader/cygwin-downloader.zip:
1693
1694 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1695
1696         [Win] Eliminate use of deleteAllValues in Windows Files
1697         https://bugs.webkit.org/show_bug.cgi?id=131631
1698
1699         Reviewed by Darin Adler.
1700
1701         Switch to std::unique_ptr for memory lifetime. Get rid of
1702         deleteAllValues now that it is no longer needed. Use ranged
1703         for loops where possible.
1704
1705         * DumpRenderTree/win/DRTDataObject.cpp:
1706         (WCEnumFormatEtc::WCEnumFormatEtc):
1707         (DRTDataObject::~DRTDataObject):
1708         (DRTDataObject::GetData):
1709         (DRTDataObject::QueryGetData):
1710         (DRTDataObject::SetData):
1711         (DRTDataObject::clearData):
1712         * DumpRenderTree/win/DRTDataObject.h:
1713         * DumpRenderTree/win/UIDelegate.cpp:
1714         (DRTUndoObject::DRTUndoObject):
1715         (DRTUndoObject::~DRTUndoObject):
1716         (DRTUndoStack::~DRTUndoStack):
1717         (DRTUndoStack::clear):
1718         (DRTUndoStack::pop):
1719         (DRTUndoManager::DRTUndoManager):
1720         (DRTUndoManager::redo):
1721         (DRTUndoManager::undo):
1722         (UIDelegate::UIDelegate):
1723         (UIDelegate::resetUndoManager):
1724         * DumpRenderTree/win/UIDelegate.h:
1725
1726 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1727
1728         [GTK] Unreviewed GTK gardening.
1729
1730         Update list of skipped unit tests:
1731
1732           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1733
1734           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1735           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1736
1737         * Scripts/run-gtk-tests:
1738         (TestRunner):
1739
1740 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1741
1742         check-webkit-style doesn't check code style in .mm or .m files
1743         https://bugs.webkit.org/show_bug.cgi?id=131708
1744
1745         Reviewed by Darin Adler.
1746
1747         * Scripts/webkitpy/style/checker.py:
1748         * Scripts/webkitpy/style/checker_unittest.py:
1749         (CheckerDispatcherDispatchTest.test_cpp_paths):
1750         (CheckerDispatcherDispatchTest.test_text_paths):
1751         Check .mm and .m files as C++.
1752
1753         * Scripts/webkitpy/style/checkers/cpp.py:
1754         (check_spacing):
1755         Add an override for our ordinary "missing spaces around =" for @synthesize,
1756         which should look like "@synthesize propertyName=_varName;"
1757
1758         Add an override for "missing space before {" for blocks' "^{".
1759
1760         Don't follow the "extra space before [" rule for Objective-C, because
1761         it breaks this rule in a multitude of ways because of method calls.
1762
1763         (check_braces):
1764         Don't complain about { not being on the end of the previous line if
1765         the previous line starts with "- (" or "+ (", which would indicate a
1766         Objective-C method definition.
1767
1768 2014-04-16  Darin Adler  <darin@apple.com>
1769
1770         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1771         https://bugs.webkit.org/show_bug.cgi?id=131735
1772
1773         Reviewed by Alexey Proskuryakov.
1774
1775         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1776         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1777         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1778         way, but gtest works better this way.
1779
1780 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1781
1782         [EFL] Fix problems with the pixel dump.
1783         https://bugs.webkit.org/show_bug.cgi?id=131265
1784
1785         Reviewed by Gyuyoung Kim.
1786
1787         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1788         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1789         which causes that nothing is drawn.
1790
1791         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1792         One of new functions is AcceleratedCompositingContext::extractImageData(),
1793         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1794         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1795
1796         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1797         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1798
1799 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1800
1801         Update LLVM export scrpt to handle the build directory being different from the
1802         source directory.
1803
1804         Rubber stamped by Geoffrey Garen.
1805
1806         * Scripts/export-llvm-build:
1807
1808 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1809
1810         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1811         https://bugs.webkit.org/show_bug.cgi?id=131695
1812
1813         Reviewed by Antti Koivisto.
1814
1815         Updated.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1818
1819 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1820
1821         [GTK] Reduce the binary size by compressing the text based web inspector resources
1822         https://bugs.webkit.org/show_bug.cgi?id=121545
1823
1824         Reviewed by Gustavo Noronha Silva.
1825
1826         Compress text based files when compiling inspector resources. It
1827         reduces the binary size in 3MB.
1828
1829         * gtk/generate-inspector-gresource-manifest.py:
1830         (find_all_files_in_directory):
1831         (is_compressible):
1832
1833 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1834
1835         Remove Gtk WebKit1 tester.
1836
1837         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1838         results over and over as fast as it could.
1839
1840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1841         (WebKitBuildbot):
1842
1843 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1844
1845         Wrong link for webkitpy tests results in dashboard popover
1846         https://bugs.webkit.org/show_bug.cgi?id=131664
1847
1848         Reviewed by Timothy Hatcher.
1849
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1851         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1852         Use a correct link.
1853
1854 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1855
1856         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1857
1858         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1859
1860         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1861         (CommitMessageForThisCommitTest):
1862
1863 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1864
1865         Fix commit-log-editor bug revealed by r165447
1866         https://bugs.webkit.org/show_bug.cgi?id=130676
1867
1868         Reviewed by Csaba Osztrogonác.
1869
1870         * Scripts/commit-log-editor:
1871         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1872         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1873         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1874         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1875
1876 2014-04-13  Darin Adler  <darin@apple.com>
1877
1878         userVisibleString should not try to "encode" host names
1879         https://bugs.webkit.org/show_bug.cgi?id=131587
1880         rdar://problem/14686849
1881
1882         Reviewed by Alexey Proskuryakov.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1885
1886         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1887         Coverage is tiny at this point; we could add a lot more cases!
1888
1889 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1890
1891         Use #include instead of #import
1892         https://bugs.webkit.org/show_bug.cgi?id=131604
1893
1894         Reviewed by Darin Adler.
1895
1896         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1897
1898         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1899
1900 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1901
1902         Make slow-stress tests run faster by running fewer VM variants.
1903
1904         Rubber stamped by Geoffrey Garen.
1905
1906         * Scripts/run-javascriptcore-tests:
1907         * Scripts/run-jsc-stress-tests:
1908
1909 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1910
1911         [CMake] Add missing WTF unit tests
1912         https://bugs.webkit.org/show_bug.cgi?id=131459
1913
1914         Reviewed by Martin Robinson.
1915
1916         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1917         that should be compiled into the TestWTF binary.
1918
1919 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1920
1921         [Gtk] run-launcher doesn't work by default
1922         https://bugs.webkit.org/show_bug.cgi?id=131494
1923
1924         Reviewed by Philippe Normand.
1925
1926         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1927         * Scripts/webkitdirs.pm:
1928         (launcherName): Same.
1929         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1930         * gtk/common.py:
1931         (get_build_path.is_valid_build_directory): Same.
1932         * gtk/manifest.txt: Same.
1933
1934 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1935
1936         Unreviewed, rolling out r167046.
1937         https://bugs.webkit.org/show_bug.cgi?id=131479
1938
1939         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1940         on #webkit).
1941
1942         Reverted changeset:
1943
1944         "Remove "System Font" from whitelisted DRT fonts and char
1945         width calculations"
1946         https://bugs.webkit.org/show_bug.cgi?id=131411
1947         http://trac.webkit.org/changeset/167046
1948
1949 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1950
1951         Remove "System Font" from whitelisted DRT fonts and char width calculations
1952         https://bugs.webkit.org/show_bug.cgi?id=131411
1953
1954         Reviewed by Tim Horton.
1955
1956         Covered by existing tests.
1957
1958         * DumpRenderTree/mac/DumpRenderTree.mm:
1959         (allowedFontFamilySet):
1960
1961 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1962
1963         systemHiddenFontFamilySet in DRT is unnecessary
1964         https://bugs.webkit.org/show_bug.cgi?id=131414
1965
1966         Reviewed by Tim Horton.
1967
1968         It doesn't seem to affect test results on my machine.
1969
1970         * DumpRenderTree/mac/DumpRenderTree.mm:
1971         (drt_NSFontManager_availableFonts):
1972         (systemHiddenFontFamilySet): Deleted.
1973
1974 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1975
1976         [Win] Unreviewed test fix: Don't double-release BSTR.
1977
1978         * DumpRenderTree/win/DumpRenderTree.cpp:
1979         (dump): Remove unneeded call to SysFreeString now that we are
1980         using _bstr_t for this variable.
1981
1982 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1983
1984         [Win] Various DumpRenderTree Fixes.
1985         https://bugs.webkit.org/show_bug.cgi?id=131446.
1986
1987         Reviewed by Tim Horton.
1988
1989         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1990         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1991         (AccessibilityUIElement::description): Ditto.
1992         (AccessibilityUIElement::helpText): Ditto.
1993         (AccessibilityUIElement::intValue): Ditto.
1994         (AccessibilityUIElement::isPressActionSupported): Ditto.
1995         (AccessibilityUIElement::accessibilityValue): Ditto.
1996         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1997         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1998         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1999         (DRTDesktopNotificationPresenter::Release): Ditto.
2000         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2001         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2002         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2003         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2004         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2005         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2006         * DumpRenderTree/win/DumpRenderTree.cpp:
2007         (dumpFrameScrollPosition): Ditto.
2008         (dumpFramesAsText): Ditto.
2009         (compareHistoryItems): Ditto.
2010         (dumpHistoryItem): Ditto.
2011         (dump): Ditto.
2012         (resetDefaultsToConsistentValues): Ditto.
2013         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2014         (runTest): Ditto.
2015         (createWebViewAndOffscreenWindow): Ditto.
2016         * DumpRenderTree/win/EditingDelegate.cpp:
2017         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2018         (EditingDelegate::AddRef): Ditto.
2019         (EditingDelegate::Release): Ditto.
2020         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2021         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2022         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2023         (EditingDelegate::shouldInsertNode): Ditto.
2024         (EditingDelegate::shouldInsertText): Ditto.
2025         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2026         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2027         (EditingDelegate::shouldApplyStyle): Ditto.
2028         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2029         (EditingDelegate::doPlatformCommand): Ditto.
2030         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2031         (EditingDelegate::webViewDidChange): Ditto.
2032         (EditingDelegate::webViewDidEndEditing): Ditto.
2033         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2034         (EditingDelegate::webViewDidChangeSelection): Ditto.
2035         (EditingDelegate::checkSpellingOfString): Ditto.
2036         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2037         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2038         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2039         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2040         (FrameLoadDelegate::AddRef): Ditto.
2041         (FrameLoadDelegate::Release): Ditto.
2042         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2043         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2044         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2045         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2046         (FrameLoadDelegate::didReceiveTitle): Ditto.
2047         (FrameLoadDelegate::didChangeIcons): Ditto.
2048         (delegatesWithDelayedWork): Ditto.
2049         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2050         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2051         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2052         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2053         (FrameLoadDelegate::willCloseFrame): Ditto.
2054         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2055         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2056         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2057         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2058         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2059         * DumpRenderTree/win/FrameLoadDelegate.h:
2060         * DumpRenderTree/win/HistoryDelegate.cpp:
2061         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2062         (HistoryDelegate::updateHistoryTitle): Ditto.
2063         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2064         * DumpRenderTree/win/PolicyDelegate.cpp:
2065         (dumpPath):
2066         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2067         (PolicyDelegate::AddRef): Ditto.
2068         (PolicyDelegate::Release): Ditto.
2069         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2070         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2071         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2072         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2073         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2074         (ResourceLoadDelegate::AddRef): Ditto.
2075         (ResourceLoadDelegate::Release): Ditto.
2076         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2077         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2078         (ResourceLoadDelegate::willSendRequest): Ditto.
2079         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2080         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2081         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2082         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2083         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2084         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2085         (TestRunner::setUserStyleSheetLocation): Ditto.
2086         (TestRunner::execCommand): Ditto.
2087         (TestRunner::overridePreference): Ditto.
2088         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2089         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2090         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2091         (TextInputController::insertText): Ditto.
2092         * DumpRenderTree/win/UIDelegate.cpp:
2093         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2094         (UIDelegate::AddRef): Ditto.
2095         (UIDelegate::Release): Ditto.
2096         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2097         (UIDelegate::trackCustomPopupMenu): Ditto.
2098         (UIDelegate::registerUndoWithTarget): Ditto.
2099         (UIDelegate::removeAllActionsWithTarget): Ditto.
2100         (UIDelegate::setActionTitle): Ditto.
2101         (UIDelegate::undo): Ditto.
2102         (UIDelegate::redo): Ditto.
2103         (UIDelegate::canUndo): Ditto.
2104         (UIDelegate::canRedo): Ditto.
2105         (UIDelegate::printFrame): Ditto.
2106         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2107         (UIDelegate::webViewHeaderHeight): Ditto.
2108         (UIDelegate::webViewFooterHeight): Ditto.
2109         (UIDelegate::drawHeaderInRect): Ditto.
2110         (UIDelegate::drawFooterInRect): Ditto.
2111         (UIDelegate::webViewPrintingMarginRect): Ditto.
2112         (UIDelegate::canRunModal): Ditto.
2113         (UIDelegate::createModalDialog): Ditto.
2114         (UIDelegate::runModal): Ditto.
2115         (UIDelegate::isMenuBarVisible): Ditto.
2116         (UIDelegate::setMenuBarVisible): Ditto.
2117         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2118         (UIDelegate::paintCustomScrollbar): Ditto.
2119         (UIDelegate::paintCustomScrollCorner): Ditto.
2120         (UIDelegate::setFrame): Ditto.
2121         (UIDelegate::webViewFrame): Ditto.
2122         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2123         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2124         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2125         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2126         (UIDelegate::webViewAddMessageToConsole): Ditto.
2127         (UIDelegate::doDragDrop): Ditto.
2128         (UIDelegate::webViewGetDlgCode): Ditto.
2129         (UIDelegate::createWebViewWithRequest): Ditto.
2130         (UIDelegate::webViewClose): Ditto.
2131         (UIDelegate::webViewFocus): Ditto.
2132         (UIDelegate::webViewUnfocus): Ditto.
2133         (UIDelegate::webViewPainted): Ditto.
2134         (UIDelegate::exceededDatabaseQuota): Ditto.
2135         (UIDelegate::embeddedViewWithArguments): Ditto.
2136         (UIDelegate::webViewClosing): Ditto.
2137         (UIDelegate::webViewSetCursor): Ditto.
2138         (UIDelegate::webViewDidInvalidate): Ditto.
2139         (UIDelegate::setStatusText): Ditto.
2140         (UIDelegate::desktopNotificationsDelegate): Ditto.
2141         (UIDelegate::drawBackground): Ditto.
2142         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2143         (UIDelegate::didPressMissingPluginButton): Ditto.
2144         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2145         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2146         (LoadHTMLStringItem::invoke): Ditto.
2147         (ScriptItem::invoke): Ditto.
2148
2149 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2150
2151         Stylechecker: False positive on inline asm code.
2152         https://bugs.webkit.org/show_bug.cgi?id=130570
2153
2154         Reviewed by Csaba Osztrogonác.
2155
2156         Disable stylechecking in asm blocks.
2157
2158         * Scripts/webkitpy/style/checkers/cpp.py:
2159         (process_line):
2160         (_InlineASMState):
2161         (_InlineASMState.__init__):
2162         (_InlineASMState.process_line):
2163         (_InlineASMState.isInside):
2164         (_process_lines):
2165         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2166         (WebKitStyleTest.test_member_initialization_list):
2167
2168 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2169
2170         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2171         https://bugs.webkit.org/show_bug.cgi?id=131029
2172
2173         Reviewed by Philippe Normand.
2174
2175         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2176         tests and remove the getWebKit1TestResoucesDir() method.
2177
2178         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2179         (testDownloadLocalFile): Use Test::getResourcesDir().
2180         (testDownloadLocalFileError): Ditto.
2181         (serverCallback): Ditto.
2182         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2183         (serverCallback): Ditto.
2184         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2185         (httpServerCallback): Ditto.
2186         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2187         (serverCallback): Ditto.
2188         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2189         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2190         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2191         (Test::getWebKit1TestResoucesDir): Deleted.
2192
2193 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2194
2195         [WK2] HTTP authentication regression tests fail
2196         https://bugs.webkit.org/show_bug.cgi?id=81627
2197         <rdar://problem/11079296>
2198
2199         Reviewed by Anders Carlsson.
2200
2201         * WebKitTestRunner/TestController.h:
2202         * WebKitTestRunner/TestController.cpp:
2203         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2204         to pageLoaderClient structure.
2205         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2206         for password based authentication (we do get server trust challenges on some tests,
2207         which WKTR can't handle).
2208         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2209         calls won't be made, at least on CFNetwork based platforms.
2210         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2211         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2212         make sense to associate auth requests with individual resources - there can be
2213         multiple resources loading at once from the same protection space, so WebKit1 API
2214         that had a resource identifier was inherently racy.
2215
2216 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2217
2218         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2219         https://bugs.webkit.org/show_bug.cgi?id=131427
2220
2221         Reviewed by Gyuyoung Kim.
2222
2223         Since r166973, font path was changed.
2224
2225         * DumpRenderTree/PlatformEfl.cmake:
2226         * WebKitTestRunner/PlatformEfl.cmake:
2227
2228 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2229
2230         Fix the build-jsc build
2231         https://bugs.webkit.org/show_bug.cgi?id=131410
2232
2233         Reviewed by Michael Saboff.
2234
2235         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2236         WTF depends on it.
2237
2238 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2239
2240         [GTK] Remove WebKit1 unit tests
2241         https://bugs.webkit.org/show_bug.cgi?id=131359
2242
2243         Reviewed by Anders Carlsson.
2244
2245         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2246         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2247         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2248
2249         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2250         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2251         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2252         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2253         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2254         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2255         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2256         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2257         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2258         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2259         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2260         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2261         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2262         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2263         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2264         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2265         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2266         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2267         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2268         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2269         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2270         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2271         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2272         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2273         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2274         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2275         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2276         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2277         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2278         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2279         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2280         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2281         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2282         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2283         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2284         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2285         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2286         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2287
2288 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2289
2290         Unreviewed gardening (Take 2): Prevent users from attempting
2291         to build with known invalid cURL. 
2292
2293         * Scripts/webkitdirs.pm:
2294         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2295         7.33.0 (the known good version).
2296
2297 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2298
2299         [GTK] Remove DumpRenderTree and GtkLauncher
2300         https://bugs.webkit.org/show_bug.cgi?id=131373
2301
2302         Reviewed by Andreas Kling.
2303
2304         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2305         no longer necessary now that WebKit1 GTK+ will be removed.
2306
2307         * CMakeLists.txt:
2308         * DumpRenderTree/PlatformGTK.cmake: Removed.
2309         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2310         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2311         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2312         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2313         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2314         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2315         * DumpRenderTree/gtk/EventSender.h: Removed.
2316         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2317         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2318         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2319         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2320         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2321         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2322         * DumpRenderTree/gtk/TextInputController.h: Removed.
2323         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2324         * GtkLauncher/CMakeLists.txt: Removed.
2325         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2326         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2327         * GtkLauncher/main.c: Removed.
2328         * GtkLauncher/simple.svg: Removed.
2329         * GtkLauncher/text.html: Removed.
2330         * WebKitTestRunner/PlatformGTK.cmake:
2331         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
2332         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
2333         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
2334
2335 2014-04-08  Mark Rowe  <mrowe@apple.com>
2336
2337         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
2338         <https://webkit.org/b/131388> / <rdar://problem/16291687>
2339
2340         Reviewed by Alexey Proskuryakov.
2341
2342         * Scripts/webkitdirs.pm:
2343         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
2344         (execMacWebKitAppForDebugging): Ditto.
2345
2346 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2347
2348         Build bmalloc on iOS too
2349         https://bugs.webkit.org/show_bug.cgi?id=131381
2350
2351         Reviewed by Andreas Kling.
2352
2353         * Scripts/build-webkit:
2354
2355 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2356
2357         Unreviewed gardening: Prevent users from attempting
2358         to build with known invalid cURL.
2359
2360         * Scripts/webkitdirs.pm:
2361         (checkInstalledTools): Block build attempts with bad
2362         Cygwin tool set.
2363
2364 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2365
2366         Build bmalloc on Mac
2367         https://bugs.webkit.org/show_bug.cgi?id=131333
2368
2369         Reviewed by Mark Rowe.
2370
2371         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2372         (Note: Just testing Mac is not good enough because in this
2373         script 'Mac' means 'Mac or iOS'.)
2374
2375 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2376
2377         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2378         https://bugs.webkit.org/show_bug.cgi?id=130951
2379
2380         Reviewed by Geoffrey Garen.
2381
2382         * Scripts/run-javascriptcore-tests:
2383
2384 2014-04-06  Darin Adler  <darin@apple.com>
2385
2386         Rework CSS calc logic, fixing some reference count mistakes in Length
2387         https://bugs.webkit.org/show_bug.cgi?id=131280
2388
2389         Reviewed by Andreas Kling.
2390
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2392         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2393
2394 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2395
2396         Enable WEB_REPLAY for PLATFORM(MAC)
2397         https://bugs.webkit.org/show_bug.cgi?id=130700
2398
2399         Reviewed by Timothy Hatcher.
2400
2401         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2402
2403 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2404
2405         [CMake] Include X11's include dirs in TestNetscapePlugin
2406         https://bugs.webkit.org/show_bug.cgi?id=131270
2407
2408         Reviewed by Martin Robinson.
2409
2410         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2411         TestNetscapePlugin includes WebCore code that includes X headers.
2412
2413 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2414
2415         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2416         <http://webkit.org/b/130986>
2417
2418         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2419         prefix to TileCache class names in exception list.
2420
2421 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2422
2423         [GTK] kill-old-processes should kill dbus-daemon processes
2424         https://bugs.webkit.org/show_bug.cgi?id=127352
2425
2426         Reviewed by Martin Robinson.
2427
2428         * BuildSlaveSupport/kill-old-processes:
2429         (main):
2430
2431 2014-04-04  Andres Gomez  <agomez@igalia.com>
2432
2433         [Win] Update obsolete packages in cygwin
2434         https://bugs.webkit.org/show_bug.cgi?id=126264
2435
2436         Reviewed by Brent Fulgham.
2437
2438         Removed "apache" and "minires" as the first has been replaced by
2439         "lighttpd" and the second is now integrated into
2440         "cygwin". Replaced the transitional and now obsolete "gcc" package
2441         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2442         since the newer version available is "2.7.3" which breaks the
2443         build due to some funniness with environment variable handling.
2444
2445         * CygwinDownloader/cygwin-downloader.py:
2446         * CygwinDownloader/cygwin-downloader.zip:
2447
2448 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2449
2450         check-webkit-style: Improve warnings on Objective-C @property syntax
2451         https://bugs.webkit.org/show_bug.cgi?id=131200
2452
2453         Reviewed by Dan Bernstein.
2454
2455         * Scripts/webkitpy/style/checkers/cpp.py:
2456         (check_spacing):
2457         (CppChecker):
2458         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2459         (CppStyleTest.test_spacing_in_objective_c_properties):
2460
2461 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2462
2463         Unreviewed. Moving my name to commiter section
2464
2465         * Scripts/webkitpy/common/config/contributors.json:
2466
2467 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2468
2469         Unreviewed. Add myself as a committer.
2470
2471         * Scripts/webkitpy/common/config/contributors.json:
2472
2473 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2474
2475         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2476         https://bugs.webkit.org/show_bug.cgi?id=130391
2477
2478         Reviewed by Gyuyoung Kim.
2479
2480         Change the implementation of the zoom functionality from ewk_view_scale_set
2481         to ewk_view_page_zoom_set.
2482
2483         * MiniBrowser/efl/main.c:
2484
2485 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2486
2487         [webkitpy] perf profiler does not understand --call-graph argument
2488         https://bugs.webkit.org/show_bug.cgi?id=131132
2489
2490         Reviewed by Ryosuke Niwa.
2491
2492         New versions of perf profiler have changed the argument from --call-graph to -g.
2493
2494         * Scripts/webkitpy/common/system/profiler.py:
2495         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2496         * Scripts/webkitpy/port/driver_unittest.py:
2497         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2498
2499 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2500
2501         Add EFL WK2 performance bot to build.webkit.org
2502         https://bugs.webkit.org/show_bug.cgi?id=131034
2503
2504         Fix after r166707, use "Perf" instead of "perf" for consistency.
2505
2506         Reviewed by Csaba Osztrogonác.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/config.json:
2509
2510 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2511
2512         Add EFL WK2 performance bot to build.webkit.org
2513         https://bugs.webkit.org/show_bug.cgi?id=131034
2514
2515         Reviewed by Csaba Osztrogonác.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/config.json:
2518
2519 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2520
2521         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2522         https://bugs.webkit.org/show_bug.cgi?id=131151
2523
2524         Reviewed by Gyuyoung Kim.
2525
2526         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2527         (TouchEventInfo::TouchEventInfo):
2528         (sendTouchEvent):
2529         (addTouchPointCallback):
2530         (updateTouchPointCallback):
2531         (cancelTouchPointCallback):
2532         (releaseTouchPointCallback):
2533
2534 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2535
2536         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2537         <http://webkit.org/b/131045>
2538
2539         Reviewed by Daniel Bates.
2540
2541         * Scripts/filter-build-webkit:
2542         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2543         of clang, plus debug data for all DVTAssertions.
2544
2545 2014-04-01  Dean Jackson  <dino@apple.com>
2546
2547         Load Media Controls js/css from bundle
2548         https://bugs.webkit.org/show_bug.cgi?id=131086
2549
2550         Reviewed by Eric Carlson.
2551
2552         We're now putting CSS files into the bundle, so remove the test for them.
2553
2554         * Scripts/check-for-inappropriate-files-in-framework:
2555
2556 2014-04-02  Martin Hock  <mhock@apple.com>
2557
2558         Unify private browsing with sessions.
2559         https://bugs.webkit.org/show_bug.cgi?id=130099
2560
2561         Reviewed by Alexey Proskuryakov.
2562
2563         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2565         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2566         (TestWebKitAPI::didNavigateWithNavigationData):
2567         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2568         (TestWebKitAPI::TEST):
2569
2570         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2571         (TestWebKitAPI::didNavigateWithoutNavigationData):
2572         (TestWebKitAPI::didNavigateWithNavigationData):
2573         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2574         (TestWebKitAPI::TEST):
2575
2576 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2577
2578         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2579         https://bugs.webkit.org/show_bug.cgi?id=130343
2580
2581         Reviewed by Gustavo Noronha Silva.
2582
2583         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2584         of directories on the command line and look for all appropriate files in those directories for the
2585         GResource archive. Also make archive paths relative to those directories.
2586         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2587         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2588
2589 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2590
2591         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2592         https://bugs.webkit.org/show_bug.cgi?id=131106
2593
2594         Reviewed by Csaba Osztrogonác.
2595
2596         * Scripts/webkitpy/tool/commands/download.py:
2597         (AbstractRolloutPrepCommand._prepare_state):
2598         * Scripts/webkitpy/tool/commands/download_unittest.py:
2599         (test_prepare_rollout):
2600         (test_create_rollout):
2601         (test_create_rollout_resolved):
2602         (test_rollout):
2603
2604 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2605
2606         [EFL] Add option to use separate web process for new window in MiniBrowser
2607         https://bugs.webkit.org/show_bug.cgi?id=130190
2608
2609         Reviewed by Gyuyoung Kim.
2610
2611         New created window (CTRL + n) will be open in separated web process.
2612         This option is enabled by adding a flag (S/separate-process) with launching
2613         MiniBrowser.
2614
2615         * MiniBrowser/efl/main.c:
2616         (elm_main):
2617
2618 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2619
2620         [GTK] Move NEWS file to a new location
2621         https://bugs.webkit.org/show_bug.cgi?id=130901
2622
2623         Reviewed by Brent Fulgham.
2624
2625         * gtk/manifest.txt: Update the NEWS file path.
2626
2627 2014-04-01  Anders Carlsson  <andersca@apple.com>
2628
2629         Fix build.
2630
2631         * MiniBrowser/mac/WK2BrowserWindowController.m:
2632         (-[WK2BrowserWindowController awakeFromNib]):
2633         (-[WK2BrowserWindowController dealloc]):
2634         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2635
2636 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2637
2638         Unreviewed test gardening.
2639
2640         * Scripts/webkitpy/port/base_unittest.py:
2641         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2642
2643 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2644
2645         [CSS Exclusions] Remove exclusions parsing support
2646         https://bugs.webkit.org/show_bug.cgi?id=131046
2647
2648         Reviewed by David Hyatt.
2649
2650         * Scripts/webkitperl/FeatureList.pm:
2651
2652 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2653
2654         [GTK] Remove last reference to GTK+ WK1 EWS
2655         https://bugs.webkit.org/show_bug.cgi?id=131058
2656
2657         Reviewed by Martin Robinson.
2658
2659         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2660
2661         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2662
2663 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2664
2665         Add a 32bit JSC builder/tester.
2666         https://bugs.webkit.org/show_bug.cgi?id=131054
2667         
2668         Reviewed by Michael Saboff.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/config.json:
2671         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2672         (Compile32bitJSC):
2673         (Run32bitJSCTests):
2674         (Run32bitJSCTests.countFailures):
2675         (BuildAndTest32bitJSCFactory):
2676         (BuildAndTest32bitJSCFactory.__init__):
2677
2678 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2679
2680         [GTK] No longer build WebKit1 gtkdoc
2681         https://bugs.webkit.org/show_bug.cgi?id=130970
2682
2683         Reviewed by Anders Carlsson.
2684
2685         * gtk/common.py:
2686         (gtk_version_of_pkg_config_file): Deleted.
2687         * gtk/generate-gtkdoc:
2688         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2689         was only applicable for WebKit1.
2690         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2691
2692 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2693
2694         [GTK] Running minibrowser with url crashes in debug build
2695         https://bugs.webkit.org/show_bug.cgi?id=130492
2696
2697         Reviewed by Martin Robinson.
2698
2699         Update "uri-scheme" test not to use invalid URIs in it, so we
2700         don't get a mistmatch when comparing the original URI stored in
2701         the test class with the one returned by the WebKitWebView.
2702
2703         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2704         (testWebContextURIScheme): Update the test.
2705
2706 2014-04-01  Mihai Tica  <mitica@adobe.com>
2707
2708         Unreviewed: Add myself as a commiter to the contributors list.
2709
2710         * Scripts/webkitpy/common/config/contributors.json:
2711
2712 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2713
2714         [EFL][WK2] Extract the control of page background out of color_set
2715         https://bugs.webkit.org/show_bug.cgi?id=127539
2716
2717         Reviewed by Gyuyoung Kim.
2718
2719         Added an option(C) to change background color.
2720
2721         * MiniBrowser/efl/main.c:
2722         (window_create):
2723         (elm_main):
2724
2725 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2726
2727         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2728
2729         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2730
2731 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2732
2733         Unreviewed test correction after r166530.
2734
2735         * DumpRenderTree/mac/DumpRenderTree.mm:
2736         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2737         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2738
2739 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2740
2741         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2742         https://bugs.webkit.org/show_bug.cgi?id=130987
2743
2744         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2745         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2746
2747         Reviewed by Martin Robinson.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/config.json:
2750
2751 2014-03-31  Dean Jackson  <dino@apple.com>
2752
2753         Remove WEB_ANIMATIONS
2754         https://bugs.webkit.org/show_bug.cgi?id=130989
2755
2756         Reviewed by Simon Fraser.
2757
2758         Remove this feature flag until we plan to implement.
2759
2760         * Scripts/webkitperl/FeatureList.pm:
2761
2762 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2763
2764         Reduced Latched Scroll Test Flakiness
2765         https://bugs.webkit.org/show_bug.cgi?id=130983
2766
2767         Reviewed by Darin Adler.
2768
2769         * DumpRenderTree/mac/DumpRenderTree.mm:
2770         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2771         * DumpRenderTree/mac/EventSendingController.mm:
2772         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2773         with high resolution flags turned on.
2774         * WebKitTestRunner/mac/EventSenderProxy.mm:
2775         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2776
2777 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2778
2779         run-webkit-tests should have a --no-timeout option
2780         https://bugs.webkit.org/show_bug.cgi?id=128286
2781
2782         Reviewed by Joseph Pecoraro.
2783
2784         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2785         (Worker._run_test): Renaming _run_test_with_timeout()
2786         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2787         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2788         (Worker._run_test_in_this_thread):
2789         (Worker._run_test_with_timeout): Deleted.
2790         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2791         (parse_args): Added the --no-timeout option
2792
2793 2014-03-31  Samuel White  <samuel_white@apple.com>
2794
2795         AX: Need ability to get line range for text marker.
2796         https://bugs.webkit.org/show_bug.cgi?id=130906
2797
2798         Reviewed by Chris Fleizach.
2799
2800         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2801
2802         * DumpRenderTree/AccessibilityUIElement.cpp:
2803         (lineTextMarkerRangeForTextMarkerCallback):
2804         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2805         (AccessibilityUIElement::getJSClass):
2806         * DumpRenderTree/AccessibilityUIElement.h:
2807         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2808         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2809         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2810         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2811         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2812         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2813         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2814         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2815         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2816         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2817         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2818         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2819
2820 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2821
2822         More validation for FTL inline caches
2823         https://bugs.webkit.org/show_bug.cgi?id=130948
2824
2825         Reviewed by Geoffrey Garen.
2826
2827         * Scripts/run-jsc-stress-tests:
2828
2829 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2830
2831         [GTK] Do not run WebKit1 unit tests by default
2832         https://bugs.webkit.org/show_bug.cgi?id=130968
2833
2834         Reviewed by Martin Robinson.
2835
2836         * Scripts/run-gtk-tests:
2837         (TestRunner):
2838
2839 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2840
2841         [GTK] Remove scripts code only applicable to autotools
2842         https://bugs.webkit.org/show_bug.cgi?id=130841
2843
2844         Reviewed by Anders Carlsson.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2847         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2848         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2849         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2850         * gtk/find-make-dist-errors: Removed.
2851         * gtk/generate-feature-defines-files: Removed.
2852         * gtk/manifest.txt: No longer need to consider autotools files.
2853
2854 2014-03-30  Andy Estes  <aestes@apple.com>
2855
2856         Fix two failing layout tests on Mountain Lion after r166466.
2857
2858         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2859         (-[DownloadDelegate _downloadDidStart:]):
2860
2861 2014-03-30  Andy Estes  <aestes@apple.com>
2862
2863         [Cocoa] Add an originatingWebView property to _WKDownload
2864         https://bugs.webkit.org/show_bug.cgi?id=130945
2865
2866         Reviewed by Anders Carlsson.
2867
2868         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2869         (-[DownloadDelegate _downloadDidStart:]):
2870         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2871         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2872         (TEST):
2873
2874 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2875
2876         Land the stackmap register liveness glue with the uses of the liveness disabled
2877         https://bugs.webkit.org/show_bug.cgi?id=130924
2878
2879         Reviewed by Oliver Hunt.
2880
2881         * Scripts/run-jsc-stress-tests:
2882
2883 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2884
2885         Update WebKit1.StringTruncator for Mountain Lion.
2886
2887         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2888         due to different font metrics on 10.8.
2889
2890 2014-03-28  Darin Adler  <darin@apple.com>
2891
2892         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2893         https://bugs.webkit.org/show_bug.cgi?id=130889
2894
2895         Reviewed by Alexey Proskuryakov.
2896
2897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2898         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2899         WebStringTruncator methods; should be good for a start. These are dependent on the
2900         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2901
2902 2014-03-28  Martin Hock  <mhock@apple.com>
2903
2904         Unreviewed. Add myself as a committer.
2905
2906         * Scripts/webkitpy/common/config/contributors.json:
2907
2908 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2909
2910         Remove WebKit1 GTK+ bots
2911         https://bugs.webkit.org/show_bug.cgi?id=130904
2912
2913         Reviewed by Anders Carlsson.
2914
2915         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2916         all bots are testing WebKit2 only.
2917         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2918         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2919         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2920         * Scripts/webkitpy/port/builders.py: Ditto.
2921         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2922         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2923
2924 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2925
2926         Remove Brian Burg's apple.com email address.
2927
2928         * Scripts/webkitpy/common/config/contributors.json:
2929
2930 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2931
2932         bisect-builds should print Trac 'changeset' URL if only one build is detected
2933         <http://webkit.org/b/130903>
2934
2935         Reviewed by Dan Bernstein.
2936
2937         * Scripts/bisect-builds:
2938         (printTracLink): Print a direct link to the Trac 'changeset'
2939         URL if there is only one revision in the range.
2940
2941 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2942
2943         [EFL] Bump glib version from 2.36 to 2.38 
2944         https://bugs.webkit.org/show_bug.cgi?id=130886
2945
2946         Reviewed by Csaba Osztrogonác.
2947
2948         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2949         we need to bump glib version up to 2.38 as gtk port.
2950
2951         * efl/jhbuild.modules:
2952
2953 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2954
2955         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2956
2957         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2958         the globalhistory directory.
2959
2960         Reviewed by Sam Weinig.
2961
2962         * WebKitTestRunner/TestController.cpp:
2963         (WTR::TestController::TestController):
2964         (WTR::TestController::initialize): Set the history client.
2965         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2966         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2967         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2968         and we don't yet have API to access the data in question.
2969         (WTR::TestController::didPerformClientRedirect):
2970         (WTR::TestController::didPerformServerRedirect):
2971         (WTR::TestController::didUpdateHistoryTitle):
2972         * WebKitTestRunner/TestController.h:
2973         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2974         * WebKitTestRunner/TestInvocation.cpp:
2975         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2976         (WTR::TestInvocation::invoke):
2977
2978 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2979
2980         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2981
2982         * Scripts/build-webkit:
2983         * Scripts/copy-webkitlibraries-to-product-directory:
2984
2985 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2986
2987         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2988         https://bugs.webkit.org/show_bug.cgi?id=130867
2989         <rdar://problem/16432456> 
2990
2991         Reviewed by Mark Hahnenberg.
2992
2993         * Scripts/build-webkit:
2994         * Scripts/copy-webkitlibraries-to-product-directory:
2995
2996 2014-03-26  Andy Estes  <aestes@apple.com>
2997
2998         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2999         https://bugs.webkit.org/show_bug.cgi?id=130805
3000
3001         Reviewed by Dan Bernstein.
3002
3003         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3004         (-[DownloadDelegate _download:didReceiveResponse:]):
3005         (-[DownloadDelegate _downloadDidFinish:]):
3006         (runTest):
3007         (TEST):
3008         (-[FailingDownloadDelegate _downloadDidFinish:]):
3009         (-[FailingDownloadDelegate _download:didFailWithError:]):
3010         (-[FailingDownloadDelegate _downloadDidCancel:]):
3011         (-[CancelledDownloadDelegate _downloadDidStart:]):
3012         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3013         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3014         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3015         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3016         (-[DownloadDelegate sourceURL]): Deleted.
3017         (runTestWithNavigationDelegate): Deleted.
3018
3019 2014-03-26  Anders Carlsson  <andersca@apple.com>
3020
3021         Change MiniBrowser to hold on to window controllers instead of windows
3022         https://bugs.webkit.org/show_bug.cgi?id=130797
3023
3024         Reviewed by Oliver Hunt.
3025
3026         * MiniBrowser/mac/AppDelegate.h:
3027         * MiniBrowser/mac/AppDelegate.m:
3028         (-[BrowserAppDelegate init]):
3029         (-[BrowserAppDelegate newWindow:]):
3030         (-[BrowserAppDelegate browserWindowWillClose:]):
3031         (-[BrowserAppDelegate applicationWillTerminate:]):
3032         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3033
3034 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3035
3036         Unreviewed, rolling out r166264.
3037         https://bugs.webkit.org/show_bug.cgi?id=130785
3038
3039         Broke some window.opener tests for WK2 Mavericks (Requested by
3040         brrian__ on #webkit).
3041
3042         Reverted changeset:
3043
3044         "Web Replay: resource unique identifiers should be unique-per-
3045         frame, not globally"
3046         https://bugs.webkit.org/show_bug.cgi?id=130632
3047         http://trac.webkit.org/changeset/166264
3048
3049 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3050
3051         [CSS Shapes] Remove shape-inside support
3052         https://bugs.webkit.org/show_bug.cgi?id=130698
3053
3054         Reviewed by David Hyatt.
3055
3056         * Scripts/webkitperl/FeatureList.pm:
3057
3058 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3059
3060         Unreviewed. Add myself as a committer.
3061
3062         * Scripts/webkitpy/common/config/contributors.json:
3063
3064 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3065
3066         run-launcher is Perl script so use elsif and not elif
3067         https://bugs.webkit.org/show_bug.cgi?id=130771
3068
3069         Reviewed by Carlos Garcia Campos.
3070
3071         * Scripts/run-launcher:
3072
3073 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3074
3075         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3076         https://bugs.webkit.org/show_bug.cgi?id=130575
3077
3078         Reviewed by Mario Sanchez Prada.
3079
3080         Change ATK version to 2.11.92. Adjust current implementation.
3081
3082         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3083         (AccessibilityUIElement::intValue):
3084         (AccessibilityUIElement::minValue):
3085         (AccessibilityUIElement::maxValue):
3086         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3087         (WTR::AccessibilityUIElement::intValue):
3088         (WTR::AccessibilityUIElement::minValue):
3089         (WTR::AccessibilityUIElement::maxValue):
3090         * efl/jhbuild.modules:
3091         * gtk/jhbuild.modules:
3092
3093 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3094
3095         [GTK] The gnumake package is no longer needed in jhbuild
3096         https://bugs.webkit.org/show_bug.cgi?id=130121
3097
3098         Reviewed by Martin Robinson.
3099
3100         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3101         for a debug build cmake/system-gnumake worked just fine for me.
3102
3103         * gtk/jhbuild.modules: Removed gnumake.
3104         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3105         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3106
3107 2014-03-25  Andy Estes  <aestes@apple.com>
3108
3109         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3110
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3112         (-[DownloadDelegate _download:didReceiveData:]):
3113         (-[DownloadDelegate _downloadDidFinish:]):
3114
3115 2014-03-25  Brian Burg  <bburg@apple.com>
3116
3117         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3118         https://bugs.webkit.org/show_bug.cgi?id=130623
3119
3120         Reviewed by Timothy Hatcher.
3121
3122         The resource loader callback dumping routines assumed that resource identifiers
3123         were globally unique. Its map of resource identifiers to URLs must also track the
3124         frame associated with the resource.
3125
3126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3127         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3128         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3129         stable as long as the frame is valid.
3130         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3131         (WTR::InjectedBundlePage::willSendRequestForFrame):
3132         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3133         (WTR::InjectedBundlePage::didFinishLoadForResource):
3134         (WTR::InjectedBundlePage::didFailLoadForResource):
3135
3136 2014-03-25  Andy Estes  <aestes@apple.com>
3137
3138         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3139
3140         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3141         (-[DownloadDelegate _download:didReceiveResponse:]):
3142         (-[DownloadDelegate _download:didReceiveData:]):
3143
3144 2014-03-25  Andy Estes  <aestes@apple.com>
3145
3146         Add some debug logging to an API test that's failing on Mountain Lion.
3147
3148         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3149         (-[DownloadDelegate _download:didReceiveResponse:]):
3150         (-[DownloadDelegate _downloadDidFinish:]):
3151
3152 2014-03-25  Anders Carlsson  <andersca@apple.com>
3153
3154         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3155         https://bugs.webkit.org/show_bug.cgi?id=130732
3156
3157         Reviewed by Tim Horton.
3158
3159         * MiniBrowser/mac/WK2BrowserWindowController.m:
3160         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3161
3162 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3163
3164         [GTK] Remove the autotools build
3165         https://bugs.webkit.org/show_bug.cgi?id=130717
3166
3167         Reviewed by Anders Carlsson.
3168
3169         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3170         * GNUmakefile.am: Removed.
3171         * GtkLauncher/GNUmakefile.am: Removed.
3172         * GtkLauncher/main.c: Remove references to the autotools configure file.
3173         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3174         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3175         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3176         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3177         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3178         * Scripts/build-webkit: No longer handle autotools.
3179         * Scripts/run-gtk-tests: Ditto.
3180         (TestRunner._setup_testing_environment):
3181         * Scripts/run-launcher: Ditto.
3182         * Scripts/webkitdirs.pm: Ditto.
3183         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3184         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3185         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3186         * Scripts/webkitpy/style/checker.py:
3187         * TestWebKitAPI/GNUmakefile.am: Removed.
3188         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3189         * WebKitTestRunner/GNUmakefile.am: Removed.
3190         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3191         * gtk/GNUmakefile.am: Removed.
3192         * gtk/common.py: Remove checks for the autotools build.
3193         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3194
3195 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3196
3197         prepare-ChangeLog throws false positive warnings for modified files.
3198         https://bugs.webkit.org/show_bug.cgi?id=130687
3199
3200         Reviewed by Darin Adler.
3201
3202         * Scripts/prepare-ChangeLog:
3203         (originalFile): Ignore git commit paremeter.
3204         We don't need this to get the unmodified file.
3205         (extractLineRangeBeforeChange):
3206         Simplify the if statement. Follow-up after r166189.
3207
3208 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3209
3210         [EFL] Add ARM64 build support
3211         https://bugs.webkit.org/show_bug.cgi?id=130506
3212
3213         Rubber stamped by Gyuyoung Kim.
3214
3215         * Scripts/webkitdirs.pm:
3216         (isARM): Detect aarch64 as ARM.
3217
3218 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3219
3220         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3221         https://bugs.webkit.org/show_bug.cgi?id=130137
3222
3223         Reviewed by Csaba Osztrogonác.
3224
3225         * Scripts/webkitpy/common/checkout/changelog.py:
3226         (ChangeLogEntry._parse_bug_description):
3227         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3228         (test_parse_log_entries_from_changelog):
3229         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3230         (CheckoutTest.test_commit_info_for_revision):
3231
3232 2014-03-24  Andy Estes  <aestes@apple.com>
3233
3234         Fix the iOS build of TestWebKitAPI.
3235
3236         * TestWebKitAPI/Configurations/Base.xcconfig:
3237         * TestWebKitAPI/PlatformUtilities.h:
3238
3239 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3240
3241         Fix prepare-ChangeLog after r166156.
3242         https://bugs.webkit.org/show_bug.cgi?id=130674
3243
3244         Reviewed by Darin Adler.
3245
3246         * Scripts/prepare-ChangeLog:
3247         (generateFunctionLists):
3248         (extractLineRangeBeforeChange):
3249
3250 2014-03-24  Andy Estes  <aestes@apple.com>
3251
3252         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3253         https://bugs.webkit.org/show_bug.cgi?id=129322
3254
3255         Reviewed by Anders Carlsson.
3256
3257         Add an API test suite for _WKDownload.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3261         (-[DownloadDelegate initWithSourceURL:]):
3262         (-[DownloadDelegate sourceURL]):
3263         (-[DownloadDelegate _downloadDidStart:]):
3264         (-[DownloadDelegate _download:didReceiveResponse:]):
3265         (-[DownloadDelegate _download:didReceiveData:]):
3266         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3267         (-[DownloadDelegate _downloadDidFinish:]):
3268         (TEST):
3269         (runTestWithNavigationDelegate):
3270         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3271         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3272
3273 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3274
3275         filter-build-webkit: reduce unfiltered output
3276         https://bugs.webkit.org/show_bug.cgi?id=130485
3277
3278         Reviewed by Brent Fulgham.
3279
3280         * Scripts/filter-build-webkit:
3281         (shouldIgnoreLine):
3282
3283 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3284
3285         prepare-ChangeLog should list functions that have been removed too.
3286         https://bugs.webkit.org/show_bug.cgi?id=130508
3287
3288         Reviewed by Darin Adler.
3289
3290         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3291         We have to read the functions and the line ranges of them from the source
3292         before the change, then search for overlaps between them and the changed
3293         line ranges from diff.
3294
3295         * Scripts/prepare-ChangeLog:
3296         (originalFile): Get original source command.
3297         (generateFunctionLists): Collect deleted functions too.
3298         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3299         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3300         deleted functions ranges too.
3301         (extractLineRange): Renamed to extractLineRangeAfterChange.
3302
3303 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3304
3305         Move all EFL typedefs into EflTypedefs.h.
3306         https://bugs.webkit.org/show_bug.cgi?id=130511
3307
3308         Reviewed by Gyuyoung Kim.
3309
3310         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3311         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3312         * WebKitTestRunner/PlatformWebView.h: Ditto.
3313
3314 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3315
3316         Don't flush compositing layers within FrameView::willPaintContents()
3317         https://bugs.webkit.org/show_bug.cgi?id=130627
3318         <rdar://problem/16368869>
3319
3320         Reviewed by Sam Weinig.
3321         
3322         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3323         does not flush.
3324         
3325         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3326         into an explicit function called before dumping. 
3327         
3328         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
3329         are flushed to CA. They will be pushed to the window by snapshotting.
3330
3331         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3332         Fix weird path to IOKit.framework.
3333         * DumpRenderTree/mac/DumpRenderTree.mm:
3334         (updateDisplay):
3335         (dump):
3336         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3337         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
3338         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
3339
3340 2014-03-21  David Kilzer  <ddkilzer@apple.com>
3341
3342         fix-blink-patch: tool to fix up renamed directory paths in Blink
3343         <http://webkit.org/b/130609>
3344
3345         Reviewed by Ryosuke Niwa.
3346
3347         Usage: cat blink.patch | fix-blink-patch | svn-apply
3348
3349         * Scripts/fix-blink-patch: Added.
3350
3351 2014-03-21  Darin Adler  <darin@apple.com>
3352
3353         Remove use of deprecatedCharacters in WebKit API tests
3354         https://bugs.webkit.org/show_bug.cgi?id=130602
3355
3356         Reviewed by Antti Koivisto.
3357
3358         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3359         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3360         (TestWebKitAPI::expectEmpty): Use characters8.
3361         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3362
3363         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3364         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3365         the deprecatedCharacters function itself, which we are about to delete.
3366
3367 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3368
3369         [webkitpy] Fix has_valid_reviewer()
3370         https://bugs.webkit.org/show_bug.cgi?id=130589
3371
3372         Reviewed by Csaba Osztrogonác.
3373
3374         * Scripts/webkitpy/common/checkout/changelog.py:
3375         (ChangeLogEntry.has_valid_reviewer):
3376         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3377         (test_has_valid_reviewer):
3378         * Scripts/webkitpy/common/config/committers.py:
3379         (CommitterList._reviewer_only):
3380         (CommitterList.committer_by_name):
3381         (CommitterList.reviewer_by_email):
3382         (CommitterList):
3383         (CommitterList.reviewer_by_name):
3384
3385 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3386
3387         Add cache support for jhbuild
3388         https://bugs.webkit.org/show_bug.cgi?id=130588
3389
3390         Reviewed by Csaba Osztrogonác.
3391
3392         * jhbuild/jhbuildrc_common.py:
3393         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3394
3395 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3396
3397         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3398         https://bugs.webkit.org/show_bug.cgi?id=130504
3399
3400         Reviewed by Martin Robinson.
3401
3402         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3403         CMake if not specified.
3404         * Scripts/webkitdirs.pm:
3405         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3406         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3407
3408 2014-03-21  Andreas Kling  <akling@apple.com>
3409
3410         RetainPtr API test should use CFArray instead of CFString for testing.
3411         <rdar://problem/16384899>
3412
3413         Unreviewed bot fix.
3414
3415         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3416         (TestWebKitAPI::TEST):
3417         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3418         (TestWebKitAPI::TEST):
3419
3420 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3421
3422         Move to using std::unique_ptr for EFL objects.
3423         https://bugs.webkit.org/show_bug.cgi?id=129853
3424
3425         Reviewed by Gyuyoung Kim.
3426
3427         EflUniquePtr is a template alias of std::unique_ptr
3428         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3429         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3430
3431         * DumpRenderTree/efl/DumpRenderTree.cpp:
3432         (main):
3433         * ImageDiff/efl/ImageDiff.cpp:
3434         (initEfl):
3435         (main):
3436
3437 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3438
3439         Unreviewed buildfix after r165983 for non Cocoa platforms
3440
3441         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3442
3443         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3444         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3445         * WebKitTestRunner/TestController.cpp:
3446
3447 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3448
3449         [GTK][CMake] Add support for building with Clang
3450         https://bugs.webkit.org/show_bug.cgi?id=130260
3451
3452         Reviewed by Martin Robinson.
3453
3454         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3455         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3456         included GTest framework headers.
3457         * gtk/generate-gtkdoc:
3458         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3459         in case of using Clang since that is now set by the CMake rule.
3460
3461 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3462
3463         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3464         https://bugs.webkit.org/show_bug.cgi?id=130476
3465
3466         Reviewed by Anders Carlsson.
3467         
3468         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3469
3470         * MiniBrowser/mac/WK1BrowserWindowController.m:
3471         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3472         Remove log.
3473         * MiniBrowser/mac/WK2BrowserWindowController.m:
3474         (-[WK2BrowserWindowController awakeFromNib]):
3475         (-[WK2BrowserWindowController validateMenuItem:]):
3476         (-[WK2BrowserWindowController reload:]):
3477         Hook up reload.
3478         (-[WK2BrowserWindowController toggleZoomMode:]):
3479         (-[WK2BrowserWindowController resetZoom:]):
3480         (-[WK2BrowserWindowController canResetZoom]):
3481         (-[WK2BrowserWindowController currentZoomFactor]):
3482         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3483         (-[WK2BrowserWindowController canZoomIn]):
3484         (-[WK2BrowserWindowController canZoomOut]):
3485
3486 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3487
3488         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3489         https://bugs.webkit.org/show_bug.cgi?id=130463
3490
3491         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3492
3493 2014-03-18  Samuel White  <samuel_white@apple.com>
3494
3495         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3496         https://bugs.webkit.org/show_bug.cgi?id=130250
3497
3498         Reviewed by Chris Fleizach.
3499
3500         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3501
3502         * DumpRenderTree/AccessibilityController.cpp:
3503         (enableEnhancedAccessibilityCallback):
3504         (getEnhancedAccessibilityEnabledCallback):
3505         (AccessibilityController::getJSClass):
3506         * DumpRenderTree/AccessibilityController.h:
3507         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3508         (AccessibilityController::enableEnhancedAccessibility):
3509         (AccessibilityController::enhancedAccessibilityEnabled):
3510         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3511         (AccessibilityController::enableEnhancedAccessibility):
3512         (AccessibilityController::enhancedAccessibilityEnabled):
3513         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3514         (AccessibilityController::enableEnhancedAccessibility):
3515         (AccessibilityController::enhancedAccessibilityEnabled):
3516         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3517         (AccessibilityController::enableEnhancedAccessibility):
3518         (AccessibilityController::enhancedAccessibilityEnabled):
3519         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3520         (WTR::AccessibilityController::enableEnhancedAccessibility):
3521         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3522         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3523         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3524
3525 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3526
3527         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3528         yet).
3529
3530         * Scripts/webkitpy/common/config/contributors.json:
3531
3532 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3533
3534         Web Inspector: Remove stale ReportMemoryUsagePlugin
3535         https://bugs.webkit.org/show_bug.cgi?id=130405
3536
3537         Reviewed by Andreas Kling.
3538
3539         This clang plugin looks like it was used for the old Inspector memory
3540         instrumentation that was removed. So the tool can be removed.
3541
3542         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3543         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3544         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3545         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3546
3547 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3548
3549         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3550         https://bugs.webkit.org/show_bug.cgi?id=130220
3551
3552         Reviewed by Csaba Osztrogonác.
3553
3554         * Scripts/webkitpy/common/checkout/changelog.py:
3555         (ChangeLog.set_reviewer):
3556         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3557         (test_set_reviewer):
3558
3559 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3560
3561         More FTL enabling.
3562
3563         Rubber stamped by Dan Bernstein.
3564
3565         * Tools/Scripts/build-webkit:
3566
3567 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3568
3569         Renable pagination mode in WK2 MiniBrowser
3570         https://bugs.webkit.org/show_bug.cgi?id=130374
3571
3572         Reviewed by Anders Carlsson.
3573         
3574         Put the implementation of togglePaginationMode: back, and correctly
3575         enable the menu item.
3576
3577         * MiniBrowser/mac/WK2BrowserWindowController.m:
3578         (-[WK2BrowserWindowController validateMenuItem:]):
3579         (-[WK2BrowserWindowController isPaginated]):
3580         (-[WK2BrowserWindowController togglePaginationMode:]):
3581
3582 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3583
3584         Add --reset option to Tools/Scripts/set-webkit-configuration script
3585         https://bugs.webkit.org/show_bug.cgi?id=130401
3586
3587         Reviewed by Csaba Osztrogonác.
3588
3589         * Scripts/set-webkit-configuration:
3590
3591 2014-03-18  Alberto Garcia  <berto@igalia.com>
3592
3593         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3594         https://bugs.webkit.org/show_bug.cgi?id=130388
3595
3596         Reviewed by Sergio Villar Senin.
3597
3598         * Scripts/webkitdirs.pm:
3599         (shouldRemoveCMakeCache): make sure that the build directory
3600         exists before attempting to create a file in it.
3601
3602 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3603
3604         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3605         https://bugs.webkit.org/show_bug.cgi?id=130336
3606
3607         Reviewed by Gyuyoung Kim.
3608
3609         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3610         requires a space between literal and string macro [-Wliteral-suffix]'
3611         warning treated as error.
3612
3613         This patch applies a solution from r162448 to the EFL port.
3614
3615         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3616         * efl/jhbuild.modules: Added appropriate patch section.
3617
3618 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3619
3620         webkitpy test rebaseline.
3621
3622         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3623         (MainTest.test_default_args):
3624
3625 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3626
3627         --profile should imply --test-runner-count=1 in run-perf-tests
3628         https://bugs.webkit.org/show_bug.cgi?id=130375
3629
3630         Reviewed by Benjamin Poulain.
3631
3632         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3633
3634         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3635         (PerfTestsRunner._parse_args): Use -1 as the default value.
3636         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3637         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3638         should be 1.
3639
3640 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3641
3642         Address some style nits.
3643
3644         * MiniBrowser/mac/WK2BrowserWindowController.m:
3645
3646 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3647
3648         Add transparent window support back into MiniBrowser
3649         https://bugs.webkit.org/show_bug.cgi?id=130363
3650
3651         Reviewed by Anders Carlsson.
3652         
3653         Re-enable transparent window support for WK2.
3654
3655         * MiniBrowser/mac/WK2BrowserWindowController.m:
3656         (-[WK2BrowserWindowController validateMenuItem:]):
3657         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3658
3659 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3660
3661         Fix the 32-bit build; make the open panel make a WK1 window.
3662
3663         * MiniBrowser/mac/AppDelegate.m:
3664         (-[BrowserAppDelegate openDocument:]):
3665
3666 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3667
3668         Convert MiniBrowser to use WKWebView API
3669         https://bugs.webkit.org/show_bug.cgi?id=130061
3670
3671         Reviewed by Anders Carlsson.
3672         
3673         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3674         as possible.
3675         
3676         Some functionality was removed temporarily:
3677             - text zoom, page zoom
3678             - reload
3679             - pagination mode
3680             - transparent window
3681             - dumping source
3682             - window.open support
3683             - beforeUnload panel
3684             - find in page
3685
3686         * MiniBrowser/mac/AppDelegate.h:
3687         * MiniBrowser/mac/AppDelegate.m:
3688         (-[BrowserAppDelegate init]):
3689         (-[BrowserAppDelegate newWindow:]):
3690         (-[BrowserAppDelegate applicationWillTerminate:]):
3691         (-[BrowserAppDelegate openDocument:]):
3692         * MiniBrowser/mac/WK2BrowserWindowController.h:
3693         * MiniBrowser/mac/WK2BrowserWindowController.m:
3694         (-[WK2BrowserWindowController awakeFromNib]):
3695         (-[WK2BrowserWindowController dealloc]):
3696         (-[WK2BrowserWindowController fetch:]):
3697         (-[WK2BrowserWindowController validateMenuItem:]):
3698         (-[WK2BrowserWindowController reload:]):
3699         (-[WK2BrowserWindowController goBack:]):
3700         (-[WK2BrowserWindowController goForward:]):
3701         (-[WK2BrowserWindowController toggleZoomMode:]):
3702         (-[WK2BrowserWindowController resetZoom:]):
3703         (-[WK2BrowserWindowController canResetZoom]):
3704         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3705         (-[WK2BrowserWindowController togglePaginationMode:]):
3706         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3707         (-[WK2BrowserWindowController windowShouldClose:]):
3708         (-[WK2BrowserWindowController applicationTerminating]):
3709         (-[WK2BrowserWindowController currentZoomFactor]):
3710         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3711         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3712         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3713         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3714         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3715         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3716         (-[WK2BrowserWindowController find:]):
3717         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3718         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3719         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3720         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3721         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3722         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3723         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3724         * WebKitTestRunner/PlatformWebView.h:
3725         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3726         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3727
3728 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3729
3730         Use RunLoop objects through references instead of pointers
3731         https://bugs.webkit.org/show_bug.cgi?id=130313
3732
3733         Reviewed by Andreas Kling.
3734
3735         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3736         return RunLoop reference instead of a pointer.
3737
3738         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3739         (loadedCallback):
3740         (clickedCallback):
3741
3742 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3743
3744         sort-export-file --help doesn't work (missing 'use')
3745         https://bugs.webkit.org/show_bug.cgi?id=130338
3746
3747         Reviewed by Anders Carlsson.
3748
3749         * Scripts/sort-export-file:
3750         Add a missing 'use', and fix a typo in an error message.
3751
3752 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3753
3754         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3755         https://bugs.webkit.org/show_bug.cgi?id=130155
3756
3757         Reviewed by Philippe Normand.
3758
3759         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3760
3761 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3762
3763         [GTK] MiniBrowser fails to load injected bundle lib
3764         https://bugs.webkit.org/show_bug.cgi?id=130332
3765
3766         Reviewed by Anders Carlsson.
3767
3768         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3769
3770         * MiniBrowser/gtk/main.c:
3771         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3772         process is spawn.
3773
3774 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3775
3776         [EFL] Enable TOUCH_SLIDER macro
3777         https://bugs.webkit.org/show_bug.cgi?id=130185
3778
3779         Reviewed by Gyuyoung Kim.
3780
3781         * Scripts/webkitperl/FeatureList.pm:
3782
3783 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3784
3785         [GTK][CMake] Build with -fno-rtti
3786         https://bugs.webkit.org/show_bug.cgi?id=130261
3787
3788         Reviewed by Martin Robinson.
3789
3790         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3791         defined to 0 to prevent typeid use in included GTest headers.
3792
3793 2014-03-16  Brian Burg  <bburg@apple.com>
3794
3795         Web Inspector: vended backend commands file should be generated as part of the build
3796         https://bugs.webkit.org/show_bug.cgi?id=130110
3797
3798         Reviewed by Timothy Hatcher.
3799
3800         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3801
3802 2014-03-16  Diego Pino García  <dpino@igalia.com>
3803
3804         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3805         https://bugs.webkit.org/show_bug.cgi?id=128999
3806
3807         Reviewed by Philippe Normand.
3808
3809         * MiniBrowser/gtk/BrowserWindow.c:
3810         (reloadPage):
3811         (reloadPageIgnoringCache):
3812         (browser_window_init):
3813
3814 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3815
3816         [GTK] Improve ninja detection in webkitdirs.pm
3817         https://bugs.webkit.org/show_bug.cgi?id=129902
3818
3819         Reviewed by Daniel Bates.
3820
3821         * Scripts/webkitdirs.pm:
3822         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3823         us to look for ninja-build as well.
3824
3825 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3826
3827         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3828         https://bugs.webkit.org/show_bug.cgi?id=130276
3829         <rdar://problem/16266927>
3830         
3831         Reviewed by Simon Fraser.
3832
3833         * BuildSlaveSupport/build-launcher-app:
3834         * BuildSlaveSupport/build-launcher-dmg:
3835         * DumpRenderTree/DumpRenderTree.h:
3836         * DumpRenderTree/DumpRenderTreePrefix.h:
3837         * DumpRenderTree/GCController.cpp:
3838         * DumpRenderTree/GCController.h:
3839         * DumpRenderTree/JavaScriptThreading.cpp:
3840         * DumpRenderTree/JavaScriptThreading.h:
3841         * DumpRenderTree/PixelDumpSupport.cpp:
3842         * DumpRenderTree/PixelDumpSupport.h:
3843         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3844         * DumpRenderTree/TestRunner.cpp:
3845         * DumpRenderTree/TestRunner.h:
3846         * DumpRenderTree/WorkQueue.cpp:
3847         * DumpRenderTree/WorkQueue.h:
3848         * DumpRenderTree/WorkQueueItem.h:
3849         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3850         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3851         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3852         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3853         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3854         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3855         * DumpRenderTree/efl/EditingCallbacks.cpp:
3856         * DumpRenderTree/efl/EditingCallbacks.h:
3857         * DumpRenderTree/efl/EventSender.cpp:
3858         * DumpRenderTree/efl/EventSender.h:
3859         * DumpRenderTree/efl/GCControllerEfl.cpp:
3860         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3861         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3862         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3863         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3864         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3865         * DumpRenderTree/gtk/EditingCallbacks.h:
3866         * DumpRenderTree/gtk/EventSender.cpp:
3867         * DumpRenderTree/gtk/EventSender.h:
3868         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3869         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3870         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3871         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3872         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3873         * DumpRenderTree/gtk/TextInputController.cpp:
3874         * DumpRenderTree/gtk/TextInputController.h:
3875         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3876         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3877         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3878         * DumpRenderTree/mac/AppleScriptController.h:
3879         * DumpRenderTree/mac/AppleScriptController.m:
3880         * DumpRenderTree/mac/CheckedMalloc.cpp:
3881         * DumpRenderTree/mac/CheckedMalloc.h:
3882         * DumpRenderTree/mac/DumpRenderTree.mm:
3883         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3884         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3885         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3886         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3887         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3888         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3889         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3890         * DumpRenderTree/mac/EditingDelegate.h:
3891         * DumpRenderTree/mac/EditingDelegate.mm:
3892         * DumpRenderTree/mac/EventSendingController.h:
3893         * DumpRenderTree/mac/EventSendingController.mm:
3894         * DumpRenderTree/mac/FrameLoadDelegate.h:
3895         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3896         * DumpRenderTree/mac/GCControllerMac.mm:
3897         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3898         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3899         * DumpRenderTree/mac/NavigationController.h:
3900         * DumpRenderTree/mac/NavigationController.m:
3901         * DumpRenderTree/mac/ObjCController.h:
3902         * DumpRenderTree/mac/ObjCController.m:
3903         * DumpRenderTree/mac/ObjCPlugin.h:
3904         * DumpRenderTree/mac/ObjCPlugin.m:
3905         * DumpRenderTree/mac/ObjCPluginFunction.h:
3906         * DumpRenderTree/mac/ObjCPluginFunction.m:
3907         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3908         * DumpRenderTree/mac/PolicyDelegate.h:
3909         * DumpRenderTree/mac/PolicyDelegate.mm:
3910         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3911         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3912         * DumpRenderTree/mac/TestRunnerMac.mm:
3913         * DumpRenderTree/mac/TextInputController.h:
3914         * DumpRenderTree/mac/TextInputController.m:
3915         * DumpRenderTree/mac/UIDelegate.h:
3916         * DumpRenderTree/mac/UIDelegate.mm:
3917         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3918         * DumpRenderTree/win/DRTDataObject.cpp:
3919         * DumpRenderTree/win/DRTDataObject.h:
3920         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3921         * DumpRenderTree/win/DRTDropSource.cpp:
3922         * DumpRenderTree/win/DRTDropSource.h:
3923         * DumpRenderTree/win/DraggingInfo.h:
3924         * DumpRenderTree/win/DumpRenderTree.cpp:
3925         * DumpRenderTree/win/DumpRenderTreeWin.h:
3926         * DumpRenderTree/win/EditingDelegate.cpp:
3927         * DumpRenderTree/win/EditingDelegate.h:
3928         * DumpRenderTree/win/EventSender.cpp:
3929         * DumpRenderTree/win/EventSender.h:
3930         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3931         * DumpRenderTree/win/FrameLoadDelegate.h:
3932         * DumpRenderTree/win/GCControllerWin.cpp:
3933         * DumpRenderTree/win/HistoryDelegate.cpp:
3934         * DumpRenderTree/win/HistoryDelegate.h:
3935         * DumpRenderTree/win/MD5.cpp:
3936         * DumpRenderTree/win/MD5.h:
3937         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3938         * DumpRenderTree/win/PolicyDelegate.cpp:
3939         * DumpRenderTree/win/PolicyDelegate.h:
3940         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3941         * DumpRenderTree/win/ResourceLoadDelegate.h:
3942         * DumpRenderTree/win/TestRunnerWin.cpp:
3943         * DumpRenderTree/win/TextInputController.cpp:
3944         * DumpRenderTree/win/TextInputController.h:
3945         * DumpRenderTree/win/TextInputControllerWin.cpp:
3946         * DumpRenderTree/win/UIDelegate.cpp:
3947         * DumpRenderTree/win/UIDelegate.h:
3948         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3949         * EWebLauncher/main.c:
3950         * GtkLauncher/main.c:
3951         * ImageDiff/efl/ImageDiff.cpp:
3952         * ImageDiff/gtk/ImageDiff.cpp:
3953         * MiniBrowser/gtk/main.c:
3954         * Scripts/SpacingHeuristics.pm:
3955         * Scripts/VCSUtils.pm:
3956         * Scripts/bisect-builds:
3957         * Scripts/build-dumprendertree:
3958         * Scripts/build-jsc:
3959         * Scripts/build-webkit:
3960         * Scripts/check-dom-results:
3961         * Scripts/check-for-exit-time-destructors:
3962         * Scripts/check-for-global-initializers:
3963         * Scripts/commit-log-editor:
3964         * Scripts/compare-timing-files:
3965         * Scripts/debug-minibrowser:
3966         * Scripts/debug-safari:
3967         * Scripts/do-file-rename:
3968         * Scripts/find-extra-includes:
3969         * Scripts/generate-coverage-data:
3970         * Scripts/make-script-test-wrappers:
3971         * Scripts/malloc-tree:
3972         * Scripts/old-run-webkit-tests:
3973         * Scripts/parse-malloc-history:
3974         * Scripts/report-include-statistics:
3975         * Scripts/resolve-ChangeLogs:
3976         * Scripts/run-bindings-tests:
3977         * Scripts/run-iexploder-tests:
3978         * Scripts/run-javascriptcore-tests:
3979         * Scripts/run-jsc:
3980         * Scripts/run-launcher:
3981         * Scripts/run-leaks:
3982         * Scripts/run-mangleme-tests:
3983         * Scripts/run-minibrowser:
3984         * Scripts/run-pageloadtest:
3985         * Scripts/run-regexp-tests:
3986         * Scripts/run-safari:
3987         * Scripts/run-sunspider:
3988         * Scripts/run-webkit-app:
3989         * Scripts/sampstat:
3990         * Scripts/set-webkit-configuration:
3991         * Scripts/sort-Xcode-project-file:
3992         * Scripts/sort-export-file:
3993         * Scripts/split-file-by-class:
3994         * Scripts/sunspider-compare-results:
3995         * Scripts/svn-apply:
3996         * Scripts/svn-create-patch:
3997         * Scripts/svn-unapply:
3998         * Scripts/test-webkit-scripts:
3999         * Scripts/update-javascriptcore-test-results:
4000         * Scripts/update-webkit:
4001         * Scripts/update-webkit-auxiliary-libs:
4002         * Scripts/update-webkit-dependency:
4003         * Scripts/update-webkit-localizable-strings:
4004         * Scripts/update-webkit-support-libs:
4005         * Scripts/update-webkit-wincairo-libs:
4006         * Scripts/webkit-build-directory:
4007         * Scripts/webkitdirs.pm:
4008         (installedSafariPath):
4009         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
4010         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
4011         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
4012         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
4013         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
4014         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
4015         * Scripts/webkitperl/features.pm:
4016         * Scripts/webkitperl/httpd.pm:
4017         * Scripts/webkitpy/bindings/main.py:
4018         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4019         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
4020         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4021         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4022         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4023         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4024         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
4025         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4026         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4027         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
4028         * WebKitTestRunner/PixelDumpSupport.cpp:
4029         * WebKitTestRunner/PixelDumpSupport.h:
4030         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4031         * WinLauncher/WinLauncher.cpp:
4032         * WinLauncher/WinLauncher.h:
4033         * WinLauncher/stdafx.cpp:
4034         * WinLauncher/stdafx.h:
4035
4036 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
4037
4038         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
4039         https://bugs.webkit.org/show_bug.cgi?id=130265
4040
4041         Reviewed by Michael Saboff.
4042
4043         * Scripts/build-webkit:
4044         * Scripts/copy-webkitlibraries-to-product-directory:
4045
4046 2014-03-14  Landry Breuil  <landry@openbsd.org>
4047
4048         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
4049         Also allow to set MAKE in the environment.
4050         https://bugs.webkit.org/show_bug.cgi?id=129991
4051
4052         Reviewed by Andreas Kling.
4053
4054         * Scripts/webkitdirs.pm:
4055         (determineArchitecture):
4056         (determineNumberOfCPUs):
4057         (isBSD):
4058         (buildAutotoolsProject):
4059         * Scripts/webkitpy/common/system/platforminfo.py:
4060         (PlatformInfo.__init__):
4061         (PlatformInfo.is_openbsd):
4062         (PlatformInfo):
4063         (PlatformInfo.is_netbsd):
4064         (PlatformInfo._determine_os_name):
4065
4066 2014-03-14  Dean Jackson  <dino@apple.com>
4067
4068         Remove libWebKitSystemInterfaceLion.a
4069         https://bugs.webkit.org/show_bug.cgi?id=130254
4070
4071         Reviewed by Geoffrey Garen and Andreas Kling.
4072
4073         No need to copy the Lion libraries into the build.
4074
4075         * Scripts/copy-webkitlibraries-to-product-directory:
4076
4077 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4078
4079         [EFL][MiniBrowser] Revise help messages of command line parameters
4080         https://bugs.webkit.org/show_bug.cgi?id=130222
4081
4082         Reviewed by Csaba Osztrogonác.
4083
4084         Correct the default value description and make help messages to be consistent.
4085
4086         * MiniBrowser/efl/main.c:
4087
4088 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
4089
4090         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
4091         https://bugs.webkit.org/show_bug.cgi?id=129612
4092
4093         Reviewed by Darin Adler.
4094
4095         For new code use static NeverDestroyed<T> instead.
4096
4097         * DumpRenderTree/JavaScriptThreading.cpp:
4098         (javaScriptThreadsMutex):
4099         (javaScriptThreads):
4100         * DumpRenderTree/efl/EventSender.cpp:
4101         (touchPointList):
4102         (delayedEventQueue):
4103         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4104         (delegatesWithDelayedWork):
4105         * Scripts/check-for-exit-time-destructors:
4106         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
4107         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
4108         (testsMap):
4109
4110 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
4111
4112         [EFL][WK2] Fix compilation warning in Minibrowser
4113         https://bugs.webkit.org/show_bug.cgi?id=130132
4114
4115         Reviewed by Csaba Osztrogonác.
4116
4117         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
4118
4119         * MiniBrowser/efl/main.c:
4120         (on_download_request):
4121
4122 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
4123
4124         FTL should support IsBlah
4125         https://bugs.webkit.org/show_bug.cgi?id=130202
4126
4127         Reviewed by Geoffrey Garen.
4128         
4129         Running existing JSRegress tests with noInline gives us coverage for these
4130         changes. Chances are, this will also give coverage for other interesting things
4131         as well.
4132
4133         * Scripts/run-jsc-stress-tests:
4134
4135 2014-03-12  Brian Burg  <bburg@apple.com>
4136
4137         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
4138         https://bugs.webkit.org/show_bug.cgi?id=129744
4139
4140         Reviewed by Timothy Hatcher.
4141
4142         * DumpRenderTree/TestRunner.cpp:
4143         (evaluateInWebInspectorCallback):
4144         * DumpRenderTree/TestRunner.h:
4145         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4146         (TestRunner::evaluateInWebInspector):
4147         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4148         (TestRunner::evaluateInWebInspector):
4149         * DumpRenderTree/mac/TestRunnerMac.mm:
4150         (TestRunner::evaluateInWebInspector):
4151         * DumpRenderTree/win/TestRunnerWin.cpp:
4152         (TestRunner::evaluateInWebInspector):
4153         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4155         (WTR::TestRunner::evaluateInWebInspector):
4156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4157
4158 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4159
4160         [GTK] build-webkit shouldn't show error message when ninja isn't installed
4161         https://bugs.webkit.org/show_bug.cgi?id=130129
4162
4163         Reviewed by Csaba Osztrogonác.
4164
4165         * Scripts/webkitdirs.pm:
4166         (canUseNinja): Redirecting stderr to /dev/null
4167
4168 2014-03-13  Andres Gomez  <agomez@igalia.com>
4169
4170         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
4171         https://bugs.webkit.org/show_bug.cgi?id=130092
4172
4173         Reviewed by Csaba Osztrogonác.
4174
4175         Added "python-dev" as dependency for deb based distros. It is
4176         already present for rpm based distros. This dependency will allow
4177         libxml2 to generate its python bindings, needed by gtk-doc.
4178
4179         * gtk/install-dependencies:
4180
4181 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4182
4183         Unreviewed. Fix GTK+ cmake build after r165488.
4184
4185         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
4186
4187 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4188
4189         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
4190         https://bugs.webkit.org/show_bug.cgi?id=130014
4191
4192         Reviewed by Martin Robinson.
4193
4194         Include cmake or autotools config header.
4195
4196         * MiniBrowser/gtk/BrowserDownloadsBar.c:
4197         * MiniBrowser/gtk/BrowserSearchBar.c:
4198         * MiniBrowser/gtk/BrowserWindow.c:
4199         * MiniBrowser/gtk/main.c:
4200
4201 2014-03-12  Commit Queue  <commit-queue@webkit.org>
4202
4203         Unreviewed, rolling out r165471.
4204         https://bugs.webkit.org/show_bug.cgi?id=130139
4205
4206         Didn't really fix the issue and broke another bot (Requested
4207         by mrobinson on #webkit).
4208
4209         Reverted changeset:
4210
4211         "[CMake] Newer versions of CMake cannot find older versions of
4212         Freetype"
4213         https://bugs.webkit.org/show_bug.cgi?id=130107
4214         http://trac.webkit.org/changeset/165471
4215
4216 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
4217
4218         It should be possible to build WebKit with FTL on iOS
4219         https://bugs.webkit.org/show_bug.cgi?id=130116
4220
4221         Reviewed by Dan Bernstein.
4222
4223         * Scripts/build-webkit:
4224         * Scripts/copy-webkitlibraries-to-product-directory:
4225
4226 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
4227
4228         [Win] Remove use of QTSDK
4229         https://bugs.webkit.org/show_bug.cgi?id=130049
4230
4231         Reviewed by Darin Adler.
4232
4233         * DumpRenderTree/win/DumpRenderTree.cpp:
4234         (initialize): Remove QuickTime code.
4235         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
4236         building QTMovieWin.
4237
4238 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
4239
4240         [GTK][CMAKE] Too verbose build output
4241         https://bugs.webkit.org/show_bug.cgi?id=130076
4242
4243         Reviewed by Carlos Garcia Campos.
4244
4245         Instead of building with cmake --build which isn't smart about pretty printing and
4246         colors, we build with a script which calls the proper build command.
4247
4248         * Scripts/webkitdirs.pm:
4249         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
4250         the CMake configuration pass.
4251
4252 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
4253
4254         [CMake] Newer versions of CMake cannot find older versions of Freetype
4255         https://bugs.webkit.org/show_bug.cgi?id=130107
4256
4257         Reviewed by Gustavo Noronha Silva.
4258
4259         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
4260         to CMake during jhbuild initialization.
4261
4262 2014-03-12  Zalan Bujtas  <zalan@apple.com>
4263
4264         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
4265         https://bugs.webkit.org/show_bug.cgi?id=129961
4266
4267         Reviewed by Simon Fraser.
4268
4269         Now scaled content can go through the window capturing mechanism too for compositing content.
4270         AppleMagnifiedMode is redundant.
4271
4272         * DumpRenderTree/mac/DumpRenderTree.mm:
4273         (setDefaultsToConsistentValuesForTesting):
4274         (runTest):
4275         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4276         (createBitmapContextFromWebView):
4277         * WebKitTestRunner/PlatformWebView.h:
4278         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4279         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4280         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4281         (WTR::PlatformWebView::didInitializeClients):
4282         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4283         (WTR::PlatformWebView::forceWindowFramesChanged):
4284         * WebKitTestRunner/mac/main.mm:
4285         (setDefaultsToConsistentValuesForTesting):
4286
4287 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
4288
4289         Unreviewed. Add myself as a committer.
4290
4291         * Scripts/webkitpy/common/config/contributors.json:
4292
4293 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
4294
4295         Unreviewed build fix on the EFL port when used lower version of ATK
4296
4297         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4298         (WTR::AccessibilityUIElement::y): Fixed typo.
4299
4300 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
4301
4302         Some images are blank in the rebaseline server UI
4303         https://bugs.webkit.org/show_bug.cgi?id=130104
4304
4305         Reviewed by Tim Horton.
4306
4307         Let the server check for images in the 'retries' directory
4308         if it can't find an image otherwise.
4309
4310         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4311         (RebaselineHTTPRequestHandler.test_result):
4312
4313 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4314
4315         [GTK][CMake] --update-gtk has no effect
4316         https://bugs.webkit.org/show_bug.cgi?id=130088
4317
4318         Reviewed by Philippe Normand.
4319
4320         * Scripts/webkitdirs.pm:
4321         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
4322         as an argument.
4323
4324 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
4325
4326         Add "System Font" to the list of whitelisted DRT fonts
4327         https://bugs.webkit.org/show_bug.cgi?id=130046
4328
4329         Reviewed by Darin Adler.
4330
4331         * DumpRenderTree/mac/DumpRenderTree.mm:
4332         (allowedFontFamilySet):
4333         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4334
4335 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
4336
4337         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH