4c107b448e9f6e2367e3270e88b11f5fb5a97005
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         [Qt] No need to save and restore TEMPLATE in a function
4
5         This was a leftover from when the logic was not in its own function scope.
6
7         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
8         will surprisingly affect the global scope as well, so we have to save and restore it.
9
10         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
11
12         Reviewed by Tor Arne Vestbø.
13
14         * qmake/mkspecs/features/functions.prf:
15
16 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
17
18         [Qt] Fix lookup location for sqlite sources
19
20         Don't look in the install dir - we are unlikely to find anything there
21         unless we are doing a developer build.
22
23         Reviewed by Tor Arne Vestbø.
24
25         * qmake/mkspecs/features/features.prf:
26
27 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
28
29         [Gtk] Add support for the Gamepad API
30         https://bugs.webkit.org/show_bug.cgi?id=87503
31
32         Reviewed by Carlos Garcia Campos.
33
34         Enable the gamepad support for the GTK port.
35
36         * Scripts/webkitperl/FeatureList.pm:
37
38 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
39
40         Fix gcc build after r121302
41         https://bugs.webkit.org/show_bug.cgi?id=90055
42
43         Reviewed by Mark Rowe.
44
45         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
46
47         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
48
49         * TestWebKitAPI/Configurations/Base.xcconfig:
50         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
51         (TestWebKitAPI::AcceptsFirstMouse::runTest):
52
53 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
54
55         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
56         https://bugs.webkit.org/show_bug.cgi?id=89564
57
58         Reviewed by Tony Chang.
59
60         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
61         (BuildStepsConstructorTest):
62         (BuildStepsConstructorTest.generateTests):
63         (BuildStepsConstructorTest.createTest):
64         (BuildStepsConstructorTest.createTest.doTest):
65
66 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
67
68         Add support for preciseTime() to WebKitTestRunner
69         https://bugs.webkit.org/show_bug.cgi?id=90027
70
71         Reviewed by Darin Adler.
72
73         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
74
75         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
76         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
77         (WTR::LayoutTestController::preciseTime): 
78         (WTR):
79         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
80         (LayoutTestController):
81
82 2012-06-26  Lucas Forschler  <lforschler@apple.com>
83
84       Teach the Apple port how to build the test tools in build-webkit
85       https://bugs.webkit.org/show_bug.cgi?id=89540
86
87       Reviewed by Jon Lee & Simon Fraser.
88
89       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
90       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
91       (RunUnitTests.start): ditto
92       * Scripts/build-webkit: add tools to the projects build list
93
94 2012-06-26  Ojan Vafai  <ojan@chromium.org>
95
96         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
97         https://bugs.webkit.org/show_bug.cgi?id=90025
98
99         Reviewed by Simon Fraser.
100
101         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
102         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
107
108 2012-06-26  Ojan Vafai  <ojan@chromium.org>
109
110         Fix failing garden-o-matic unittests
111         https://bugs.webkit.org/show_bug.cgi?id=90021
112
113         Reviewed by Adam Barth.
114
115         These had all just fallen out of date.
116
117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
120
121 2012-06-26  Ojan Vafai  <ojan@chromium.org>
122
123         Fix platform picker change handler in garden-o-matic
124         https://bugs.webkit.org/show_bug.cgi?id=90010
125
126         Reviewed by Simon Fraser.
127
128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
129         The old code never worked. This is hard to test because change handlers require
130         a user-initiated action and the code is changing the window's location, which would
131         navigate the test page.
132
133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
134         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
135         due to the large margin-bottom.
136
137 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
138
139         webkitpy: Make webkit-patch patches-to-review useful
140         https://bugs.webkit.org/show_bug.cgi?id=89470
141
142         Reviewed by Eric Seidel.
143
144         webkit-patch patches-to-review will now output the list of
145         bugs with patches pending for review that has the user on CC,
146         excluding patches with cq-, sorted by the age of the patch.
147
148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
149         (BugzillaQueries.fetch_bugs_from_review_queue):
150         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
151         (MockBugzillaQueries.fetch_bugs_from_review_queue):
152         (MockBugzilla.__init__):
153         (MockBugzilla.authenticate):
154         * Scripts/webkitpy/tool/commands/queries.py:
155         (PatchesToReview):
156         (PatchesToReview.__init__):
157         (PatchesToReview._print_report):
158         (PatchesToReview._generate_report):
159         (PatchesToReview.execute):
160         * Scripts/webkitpy/tool/commands/queries_unittest.py:
161         (QueryCommandsTest.test_patches_to_review):
162
163 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
164
165         nrwt: broken for chromium on vista
166         https://bugs.webkit.org/show_bug.cgi?id=89988
167
168         Reviewed by Tony Chang.
169
170         r121194 removed support for 'chromium-win-vista' as a separate
171         port, but this actually prevented the code from running on vista
172         at all, which is unduly harsh and broke the websocket tests on
173         the (non-webkit) chromium bots that are still running on vista.
174
175         It's probably good enough to pretend that vista is win7 instead;
176         some layout tests will still fail but at least things'll run.
177
178         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
179         (ChromiumWinPort.determine_full_port_name):
180         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
181         (ChromiumWinTest.test_versions):
182
183 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
184
185         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
186         https://bugs.webkit.org/show_bug.cgi?id=89215
187
188         We need it because it is deprecated and will be dropped in buildbot 0.8.7
189
190         Reviewed by Tony Chang.
191
192         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
193         (CheckOutSource.__init__):
194         (Factory.__init__):
195
196 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
197
198         [Qt][Win] Symbols are not exported in QtWebKit5.dll
199         https://bugs.webkit.org/show_bug.cgi?id=88873
200
201         Reviewed by Tor Arne Vestbø.
202
203         When linking the target dll make sure to re-export the symbols from
204         the static libraries marked as export, with the help of a little python
205         script and a qmake extra compiler.
206
207         * Scripts/generate-win32-export-forwards: Added.
208         * qmake/mkspecs/features/win32/default_post.prf:
209
210 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
211
212         Add a note about hostname completion not working well with --cc completion
213
214         Reviewed by Simon Hausmann.
215
216         Hostname completion tries to resolve anything after an @ sign which is present
217         in the completed list of contributor emails to CC.
218
219         * Scripts/webkit-tools-completion.sh:
220
221 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
222
223         Unreviewed, rolling out r121244.
224         http://trac.webkit.org/changeset/121244
225         https://bugs.webkit.org/show_bug.cgi?id=89966
226
227         skip list path is incorrect now. (Requested by Ossy on
228         #webkit).
229
230         * Scripts/webkitpy/layout_tests/port/qt.py:
231         (QtPort.baseline_search_path):
232         (QtPort._skipped_file_search_paths):
233         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
234         (QtPortTest.test_baseline_search_path):
235
236 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
237
238         [Qt][NRWT] Fix baseline and skipped file search path.
239         https://bugs.webkit.org/show_bug.cgi?id=89882
240
241         Reviewed by Csaba Osztrogonác.
242
243         * Scripts/webkitpy/layout_tests/port/qt.py:
244         (QtPort.baseline_search_path):
245         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
246         (QtPortTest.test_baseline_search_path):
247
248 2012-06-26  Tony Chang  <tony@chromium.org>
249
250         [Qt] Enable grid layout LayoutTests
251         https://bugs.webkit.org/show_bug.cgi?id=89909
252
253         Reviewed by Csaba Osztrogonác.
254
255         These tests pass, we just need to hook up the overridePreference.
256
257         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
258         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
259         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
260         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
261
262 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
263
264         Unreviewed, rolling out r121236.
265         http://trac.webkit.org/changeset/121236
266         https://bugs.webkit.org/show_bug.cgi?id=89956
267
268         It's broke the nrwt on qt and gtk platform (Requested by
269         kkristof on #webkit).
270
271         * Scripts/webkitpy/layout_tests/port/qt.py:
272         (QtPort._build_driver):
273         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
274         (XvfbDriver._start):
275         (XvfbDriver._start.x_filter):
276         (XvfbDriver.stop):
277
278 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
279
280         [NRWT] XvfbDriver should choose the next free display
281         https://bugs.webkit.org/show_bug.cgi?id=88414
282
283         Reviewed by Dirk Pranke.
284
285         * Scripts/webkitpy/layout_tests/port/qt.py:
286         (QtPort._driver_class):
287         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
288         (XvfbDriver.__init__):
289         (XvfbDriver._start):
290         (XvfbDriver._start.next_free_id):
291         (XvfbDriver.stop):
292
293 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
294
295         [Qt] Make it possible to build WebKit without QtWidgets
296         https://bugs.webkit.org/show_bug.cgi?id=78109
297
298         Reviewed by Tor Arne Vestbø.
299
300         * Tools.pro: Disable various tools that depend on WK1.
301         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
302         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
303         * qmake/mkspecs/modules/webkit1.prf: Added.
304
305 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
306
307         put vista back for chromium (non-webkit) bots ...
308         https://bugs.webkit.org/show_bug.cgi?id=89929
309
310         Unreviewed, build fix.
311
312         Turns out we've only gotten rid of vista on the webkit tests so
313         far. Put vista back for the other chromium bots ...
314
315         * TestResultServer/static-dashboards/flakiness_dashboard.js:
316         (chromiumPlatform):
317         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
318         (test):
319
320 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
321
322         update flakiness dashboard after removing chromium-vista bots
323         https://bugs.webkit.org/show_bug.cgi?id=89925
324
325         Unreviewed, build fix.
326
327         More changes missed in r121194 :(.
328
329         * TestResultServer/static-dashboards/flakiness_dashboard.js:
330         (chromiumPlatform):
331         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
332         (test):
333
334 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
335
336         remove support for chromium vista from tools
337         https://bugs.webkit.org/show_bug.cgi?id=89915
338
339         Reviewed by Tony Chang.
340
341         This change is all deleting code and updating tests to handle
342         the configuration being gone. All tests now pass except for a
343         few unittests for the flakiness dashboard which were failing
344         before this patch.
345
346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
350         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
351         (BaselineOptimizerTest.test_complex_shadowing):
352         * Scripts/webkitpy/layout_tests/port/builders.py:
353         * Scripts/webkitpy/layout_tests/port/chromium.py:
354         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
355         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
356         (ChromiumWinPort):
357         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
358         (ChromiumWinTest.test_versions):
359         (ChromiumWinTest.test_baseline_path):
360         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
361         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
362         (BuildCoverageExtrapolatorTest.test_extrapolate):
363
364 2012-06-25  Scott Graham  <scottmg@chromium.org>
365
366         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
367         https://bugs.webkit.org/show_bug.cgi?id=89907
368
369         Not reviewed. Fix build in Chromium.
370
371         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
372         (WebThemeEngineDRTWin::getSize):
373         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
374         (WebThemeEngineDRTWin):
375
376 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
377
378         [EFL] Implement Network Information API
379         https://bugs.webkit.org/show_bug.cgi?id=87067
380
381         Reviewed by Kenneth Rohde Christiansen.
382
383         * efl/jhbuild.modules: Add eeze library dependency.
384
385 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
386
387         [Qt] Fix Win32 debug build
388
389         Reviewed by Tor Arne Vestbø.
390
391         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
392
393         * qmake/mkspecs/features/unix/default_pre.prf:
394         * qmake/mkspecs/features/win32/default_pre.prf: Added.
395
396 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
397
398         [Qt] Enable <input type="color"> support by default
399         https://bugs.webkit.org/show_bug.cgi?id=89653
400
401         Reviewed by Kenneth Rohde Christiansen.
402
403         This feature is complete for Qt WebKit2. Enabling by default
404         will help to mature the implementation.
405
406         * Scripts/webkitperl/FeatureList.pm:
407         * qmake/mkspecs/features/features.pri:
408
409 2012-06-24  Dan Bernstein  <mitz@apple.com>
410
411         Made debug-{minibrowser,safari,test-runner} work with LLDB.
412
413         Reviewed by Sam Weinig.
414
415         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
416         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
417         * Scripts/debug-safari: Ditto.
418         * Scripts/debug-test-runner: Ditto.
419         * Scripts/webkitdirs.pm:
420         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
421         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
422         and to "gdb" otherwise.
423         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
424         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
425         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
426
427 2012-06-24  Adam Barth  <abarth@webkit.org>
428
429         [Chromium] Release media resources after each LayoutTest on Android
430         https://bugs.webkit.org/show_bug.cgi?id=89720
431
432         Reviewed by Eric Carlson.
433
434         The LayoutTests can hang when run on Android because we sometimes run
435         out of media resources. This patch causes us to release our media
436         resources after each test in order to avoid running out of this
437         resource. In production, there are other mechanisms that manage this
438         resource.
439
440         * DumpRenderTree/chromium/TestShell.cpp:
441         (TestShell::resetTestController):
442
443 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
444
445         [Gtk] REGRESSION(r120918): Causes flaky DND tests
446         https://bugs.webkit.org/show_bug.cgi?id=89770
447
448         Reviewed by Martin Robinson.
449
450         Connect to the run-file-chooser signal of the WebKitWebView and
451         return TRUE so no file chooser dialog is run. This prevents certain
452         test failures.
453
454         * DumpRenderTree/gtk/DumpRenderTree.cpp:
455         (webViewRunFileChooser):
456         (createWebView):
457
458 2012-06-23  Dan Bernstein  <mitz@apple.com>
459
460         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
461
462         Reviewed by Sam Weinig.
463
464         * Scripts/webkitdirs.pm:
465         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
466
467 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
468
469         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
470
471         It fails always when running it in Xvfb.
472
473         * gtk/run-api-tests:
474         (TestRunner):
475
476 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
477
478         [GTK][WK2]Mis-spelt defaultWindowTitle
479         https://bugs.webkit.org/show_bug.cgi?id=89808
480
481         Reviewed by Carlos Garcia Campos.
482
483         * MiniBrowser/gtk/BrowserWindow.c:
484
485 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
486
487         [GTK] Add a new webkit2 tests slave bot
488         https://bugs.webkit.org/show_bug.cgi?id=89336
489
490         Reviewed by Csaba Osztrogonác.
491
492         Slave configuration for a new GTK 64 bit release bot that will run
493         WebKit2 tests.
494
495         Also BuildAndTest now accepts the "triggers" parametter,
496         this means that apart from building and testing it can trigger
497         some other build/test sequences in other slaves.
498
499         * BuildSlaveSupport/build.webkit.org-config/config.json:
500         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
501         (BuildAndTestFactory.__init__):
502
503 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
504
505         Unreviewed. Update my email.
506
507         * Scripts/webkitpy/common/config/committers.py:
508
509 2012-06-22  Adam Barth  <abarth@webkit.org>
510
511         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
512         https://bugs.webkit.org/show_bug.cgi?id=89721
513
514         Reviewed by Nate Chapin.
515
516         This patch teaches DumpRenderTree to configure Skia to use the fallback
517         fonts that the LayoutTests assume. This patch reduces the number result
518         differences between chromium-android and chromium-linux.
519
520         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
521         * DumpRenderTree/chromium/TestShellAndroid.cpp:
522         (platformInit):
523         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
524         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
525         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
526
527 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
528
529         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
530         https://bugs.webkit.org/show_bug.cgi?id=89781
531
532         Reviewed by Dean Jackson.
533
534         Added CSS Shaders as enabled by default on Safari for Mac.
535
536         * Scripts/webkitperl/FeatureList.pm:
537
538 2012-06-22  Adam Barth  <abarth@webkit.org>
539
540         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
541         https://bugs.webkit.org/show_bug.cgi?id=89791
542
543         Reviewed by Dirk Pranke.
544
545         Downstream, the chromium-android port maintains a test expectations
546         file to keep track of which tests pass or fail. That causes them to
547         keep a patch in chromium_android.py in their branch.
548
549         This patch teaches chromium_android.py to use test_expectations_android.txt.
550         We don't intend to use this file upstream, but having this code patch
551         upstream lets us unfork webkitpy.
552
553         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
554         (ChromiumAndroidPort.expectations_files):
555
556 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
557
558         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
559         https://bugs.webkit.org/show_bug.cgi?id=89734
560
561         Reviewed by Ryosuke Niwa.
562
563         Fix a crash in ServerProcess if you called .pid() after it
564         crashed during a write(). We had a test for this case but the
565         test wasn't calling pid(), just has_crashed(). Fixed the problem
566         and the test.
567
568         * Scripts/webkitpy/layout_tests/port/server_process.py:
569         (ServerProcess.__init__):
570         (ServerProcess.pid):
571         (ServerProcess._start):
572         (ServerProcess.stop):
573         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
574         (FakeServerProcess._start):
575         (TestServerProcess.test_broken_pipe):
576
577 2012-06-22  Peter Beverloo  <peter@chromium.org>
578
579         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
580         https://bugs.webkit.org/show_bug.cgi?id=88853
581
582         Reviewed by Steve Block.
583
584         The Android exclusions were necessary to fix a gyp generation error, as
585         the gcc_version variable wasn't being defined for Android. Remove these
586         exceptions when Chromium is able to define the gcc_version variable.
587
588         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
589
590 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
591
592         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
593
594         * gtk/run-api-tests:
595         (TestRunner): Unskip WTF.HashMap.
596
597 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
598
599         [Qt] Allow DumpRenderTree to dump about:blank
600         https://bugs.webkit.org/show_bug.cgi?id=89685
601
602         Reviewed by Ryosuke Niwa.
603
604         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
605         additionaly this behavior is required for running WTR performance tests.
606
607         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
608         (WebCore::DumpRenderTree::processLine):
609
610 2012-06-21  Adam Barth  <abarth@webkit.org>
611
612         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
613         https://bugs.webkit.org/show_bug.cgi?id=89718
614
615         Reviewed by Kent Tamura.
616
617         We should reset this WebSetting to its default value so that it behaves
618         consistently across tests.
619
620         * DumpRenderTree/chromium/WebPreferences.cpp:
621         (WebPreferences::reset):
622         (WebPreferences::applyTo):
623         * DumpRenderTree/chromium/WebPreferences.h:
624         (WebPreferences):
625
626 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
627
628         DRT/WTR python interface handles about:blank incorrectly
629         https://bugs.webkit.org/show_bug.cgi?id=89563
630
631         Reviewed by Dirk Pranke.
632
633         Currently DRT/WTR python interface's _command_from_driver_input function
634         puts the test directory path before about:blank. Remove this incorrect behavior.
635
636         * Scripts/webkitpy/layout_tests/port/webkit.py:
637         (WebKitDriver._command_from_driver_input):
638
639 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
640
641         reenable perf tests on win
642         https://bugs.webkit.org/show_bug.cgi?id=89690
643
644         Reviewed by Ryosuke Niwa.
645
646         Only the replay tests don't work, and those are disabled by
647         default. This change also fixes the undefined _log reference
648         that was causing a crash.
649
650         * Scripts/run-perf-tests:
651
652 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
653
654         Unreviewed, rolling out r120937.
655         http://trac.webkit.org/changeset/120937
656         https://bugs.webkit.org/show_bug.cgi?id=89679
657
658         This patch brought buildbot master down (Requested by svillar
659         on #webkit).
660
661         * BuildSlaveSupport/build.webkit.org-config/config.json:
662
663 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
664
665         [GTK] Combine WebKit API tests into fewer binaries
666         https://bugs.webkit.org/show_bug.cgi?id=88458
667
668         Reviewed by Carlos Garcia Campos.
669
670         Instead of creating one binary per-test file, create binaries for each
671         category of tests. Right now this includes WTF and the WebKit2 C API,
672         but later tests can be added for the GTK+ platform layer and the WebKit1
673         and WebKit2 API layers.
674
675         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
676           C API and one for WTF. Refresh the source list to ensure that new test are active.
677         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
678         concept of skipping a test and skipping a suite (program) of tests. Test cases are
679         skipped because of legitimate failures, but entire programs are skipped because of
680         problems in the harness. As of right now a test program is only skipped if the
681         accessibility bus cannot be started.
682         (SkippedTest.__init__): Make the test case a required argument and have one skipped
683         test case per SkippedTest instance.
684         (SkippedTest.__str__): Ditto.
685         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
686         in one directory. Reformat the test list to make it slightly easier to read.
687         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
688         test programs that are skipped.
689         (TestRunner._setup_testing_environment): Use the new member.
690         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
691         the first SkippedTest that matches.
692         (TestRunner._should_run_test_program): Take a look at the new member to make this
693         decision.
694         (TestRunner._run_test_command): Use the name test_program instead of test
695         to disambiguate between test cases and test suites.
696         (TestRunner._run_test_glib): ditto.
697         (TestRunner._run_test_google): Ditto.
698         (TestRunner._run_test): Ditto.
699         (TestRunner.run_tests): Ditto.
700
701 2012-06-21  Yong Li  <yoli@rim.com>
702
703         Unreviewed. Moving myself from committer to reviewer.
704
705         * Scripts/webkitpy/common/config/committers.py:
706
707 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
708
709         [GTK] Add a new webkit2 tests slave bot
710         https://bugs.webkit.org/show_bug.cgi?id=89336
711
712         Reviewed by Philippe Normand.
713
714         Slave configuration for a new GTK bot that will run WebKit2 tests.
715
716         * BuildSlaveSupport/build.webkit.org-config/config.json:
717
718 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
719
720         [Qt] Add a custom Color Chooser widget to MiniBrowser
721         https://bugs.webkit.org/show_bug.cgi?id=87988
722
723         Reviewed by Alexis Menard.
724
725         Added custom color chooser example for the MiniBrowser.
726
727         * MiniBrowser/qt/MiniBrowser.qrc:
728         * MiniBrowser/qt/qml/BrowserWindow.qml:
729         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
730
731 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
732
733         Remove the warning "File not found" in MiniBrowser post-build event
734         https://bugs.webkit.org/show_bug.cgi?id=89601
735
736         Reviewed by Adam Roben.
737
738         * MiniBrowser/MiniBrowserPostBuild.cmd:
739
740 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
741
742         [Qt] DRT in standalone mode hangs after the first test
743         https://bugs.webkit.org/show_bug.cgi?id=89613
744
745         Reviewed by Csaba Osztrogonác.
746
747         Break an inline signal slot chain that ends up in setting
748         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
749         we emit done() which starts the chain that finishes in DumpRenderTree::open().
750         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
751         these two lines but it seems to be wrong in general to start the next load
752         from this call chain. The server mode (when DRT is runned by the test harness)
753         also uses a queued connection to read the next test from stdin.
754
755         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
756         (WebCore::DumpRenderTree::processArgsLine):
757
758 2012-06-20  Hans Wennborg  <hans@chromium.org>
759
760         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
761         https://bugs.webkit.org/show_bug.cgi?id=89217
762
763         Reviewed by Adam Barth.
764
765         Add a method for checking whether the mock speech
766         recognition was aborted.
767
768         Also redo the way the mock posts tasks. Instead of posting them all at once,
769         maintain an internal queue of task objects, and call postTask() for them
770         once at the time. This means that for example when the page is navigated
771         away and abort() is called, that call doesn't end up after a bunch
772         of previously posted events on the event loop.
773
774         * DumpRenderTree/chromium/LayoutTestController.cpp:
775         (LayoutTestController::LayoutTestController):
776         (LayoutTestController::wasMockSpeechRecognitionAborted):
777         * DumpRenderTree/chromium/LayoutTestController.h:
778         (LayoutTestController):
779         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
780         (WebKit::ClientCallTask::ClientCallTask):
781         (WebKit::ResultTask::ResultTask):
782         (WebKit::NoMatchTask::NoMatchTask):
783         (WebKit::ErrorTask::ErrorTask):
784         (MockWebSpeechRecognizer::start):
785         (MockWebSpeechRecognizer::abort):
786         (MockWebSpeechRecognizer::setError):
787         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
788         (MockWebSpeechRecognizer::startTaskQueue):
789         (MockWebSpeechRecognizer::StepTask::runIfValid):
790         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
791         (MockWebSpeechRecognizer::hasBeenAborted):
792         (MockWebSpeechRecognizer):
793         (MockWebSpeechRecognizer::taskList):
794         (Task):
795         (MockWebSpeechRecognizer::Task::Task):
796         (MockWebSpeechRecognizer::Task::~Task):
797         (StepTask):
798         (MockWebSpeechRecognizer::StepTask::StepTask):
799
800 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
801
802         [GTK] Add support for window.showModalDialog in WebKit2GTK+
803         https://bugs.webkit.org/show_bug.cgi?id=79500
804
805         Reviewed by Carlos Garcia Campos.
806
807         Add support for modal dialogs in GTK's MiniBrowser.
808
809         * MiniBrowser/gtk/BrowserWindow.c:
810         (webViewRunAsModal):
811         (webViewCreate):
812         (webViewDecidePolicy):
813         (browser_window_new):
814         * MiniBrowser/gtk/BrowserWindow.h:
815         * MiniBrowser/gtk/main.c:
816         (createBrowserWindow):
817
818 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
819
820         [WinCairo] Unreviewed build fix.
821         The wrapper script that launched new- and old-run-webkit-tests
822         was discarding the --wincairo argument needed to get the proper
823         test infrastructure to build under WinCairo.
824
825         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
826         behavior to chain the --wincairo flag through to the new build
827         and test scripts.
828
829 2012-06-20  Mark Rowe  <mrowe@apple.com>
830
831         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
832
833         Reviewed by Dan Bernstein.
834
835         * Scripts/webkitdirs.pm:
836         (executableHasEntitlements):
837         (safariPathFromSafariBundle):
838
839 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
840
841         Unreviewed, rolling out r120821.
842         http://trac.webkit.org/changeset/120821
843         https://bugs.webkit.org/show_bug.cgi?id=89605
844
845         It made duplicated reviewer entries (Requested by Ossy on
846         #webkit).
847
848         * Scripts/webkitpy/common/checkout/changelog.py:
849         (ChangeLog.set_reviewer):
850         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
851         (test_set_reviewer):
852         (test_set_short_description_and_bug_url):
853
854 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
855
856         nrwt outputs empty files for wdiff output if wdiff is not installed
857         https://bugs.webkit.org/show_bug.cgi?id=88709
858
859         Reviewed by Tony Chang.
860
861         Reviewed by Tony Chang.
862
863         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
864         aren't available, and clean up the handling for them in the port
865         code.
866
867         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
868         (MainTest.test_output_diffs):
869         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
870         (TestResultWriter.create_text_diff_and_write_result):
871         * Scripts/webkitpy/layout_tests/port/base.py:
872         (Port.check_pretty_patch):
873         (Port.check_wdiff):
874         (Port._wdiff_missing_message):
875         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
876         (ChromiumLinuxPort.check_build):
877         (ChromiumLinuxPort._wdiff_missing_message):
878         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
879         (ChromiumMacPort.check_build):
880         (ChromiumMacPort):
881         (ChromiumMacPort._wdiff_missing_message):
882         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
883         (ChromiumMacPortTest):
884
885 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
886
887         nrwt: fix unit tests for ensuring svn revision is correct
888         https://bugs.webkit.org/show_bug.cgi?id=89498
889
890         Reviewed by Eric Seidel.
891
892         Reviewed by Eric Seidel.
893
894         Fix the unit tests for testing that we are embedding the SVN
895         revision in the results json for NRWT properly; this was broken
896         in r120646 but because the MockHost worked differently than the
897         real one (by always initializing the MockSCM object) we didn't
898         notice. Unfortunately, just changing the default breaks all
899         sorts of unit tests ...
900
901         * Scripts/webkitpy/common/host_mock.py:
902         (MockHost.__init__):
903         (MockHost._initialize_scm):
904         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
905         (ResultSummaryTest.test_no_svn_revision):
906         (ResultSummaryTest.test_svn_revision):
907
908 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
909
910         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
911         https://bugs.webkit.org/show_bug.cgi?id=69360
912
913         Reviewed by Eric Seidel.
914
915         Reviewed by Eric Seidel.
916
917         Propagate the 'port_implementation' part of the platform (i.e.,
918         gtk,qt,chromium) to webkit-build-directory so that we can pick
919         up the gtk-specific handling of WEBKITOUTPUTDIR ...
920
921         I didn't write any additional tests for this; testing it
922         properly is an integration test between the python code and the
923         perl code, which I verified by hand.
924
925         * Scripts/webkitpy/layout_tests/port/base.py:
926         (Port.__init__):
927         * Scripts/webkitpy/layout_tests/port/config.py:
928         (Config.__init__):
929         (Config.build_directory):
930         * Scripts/webkitpy/layout_tests/port/config_mock.py:
931         (MockConfig.__init__):
932         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
933         (ConfigTest.test_build_directory_passes_port_implementation):
934
935 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
936
937         Fix import sorting missed in r120846
938
939         Reviewed by Tony Chang.
940
941         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
942
943 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
944
945         Fix chromium win http servers after breakage introduced in r120846.
946
947         Unreviewed, build fix.
948
949         * Scripts/webkitpy/layout_tests/port/base.py:
950         (Port.to.start_http_server):
951         * Scripts/webkitpy/layout_tests/servers/http_server.py:
952         (Lighttpd.__init__):
953
954 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
955
956         tweak output of webkit-patch print-{baselines,expectations}
957         https://bugs.webkit.org/show_bug.cgi?id=89588
958
959         Reviewed by Tony Chang.
960
961         Minor tweaks to the output to make it more readable, including
962         turning off csv by default for print-baselines with multiple ports.
963
964         * Scripts/webkitpy/layout_tests/port/test.py:
965         (TestPort):
966         * Scripts/webkitpy/tool/commands/queries.py:
967         (PrintExpectations.execute):
968         (PrintBaselines.execute):
969         * Scripts/webkitpy/tool/commands/queries_unittest.py:
970         (PrintExpectationsTest.run_test):
971         (PrintExpectationsTest.test_multiple):
972         (PrintBaselinesTest.setUp):
973         (PrintBaselinesTest.test_multiple):
974
975 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
976
977         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
978         https://bugs.webkit.org/show_bug.cgi?id=88134
979
980         Reviewed by Tony Chang.
981
982         Change NRWT to spin up 2*min(child_processes, locked_shards)
983         http servers by default so that we are less likely to get a
984         bunch of http timeouts at the beginning of a test run.
985
986         Note that I had to tweak executive_mock to support mocked stderr
987         because the apache_http_server code reads stderr when starting a
988         process to ensure it started okay.
989
990         * Scripts/webkitpy/common/system/executive_mock.py:
991         (MockProcess.__init__):
992         * Scripts/webkitpy/common/system/outputcapture.py:
993         * Scripts/webkitpy/layout_tests/controllers/manager.py:
994         (Manager._run_tests):
995         (Manager.start_servers_with_lock):
996         * Scripts/webkitpy/layout_tests/port/base.py:
997         (Port.to.start_http_server):
998         * Scripts/webkitpy/layout_tests/port/test.py:
999         (TestPort.start_http_server):
1000         (TestPort._path_to_apache):
1001         (TestPort):
1002         (TestPort._path_to_apache_config_file):
1003         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1004         (LayoutTestApacheHttpd.__init__):
1005         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
1006         (LayoutTestApacheHttpd.__init__):
1007         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1008         (Lighttpd.__init__):
1009         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1010         (HttpServerBase.__init__):
1011
1012 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
1013
1014         Unreviewed: Back out accidentally checked in debug print which broke a test
1015
1016         * Scripts/webkitpy/performance_tests/perftest.py:
1017         (PerfTest.parse_output):
1018
1019 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
1020
1021         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
1022         https://bugs.webkit.org/show_bug.cgi?id=78789
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         Updated parser to include fps as a valid unit.
1027
1028         * Scripts/webkitpy/performance_tests/perftest.py:
1029         (PerfTest):
1030         (PerfTest.parse_output):
1031
1032 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
1033
1034         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
1035         https://bugs.webkit.org/show_bug.cgi?id=67935
1036
1037         Reviewed by Ryosuke Niwa.
1038
1039         * Scripts/webkitpy/common/checkout/changelog.py:
1040         (ChangeLog.set_reviewer):
1041         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1042         (test_set_reviewer):
1043         (test_set_short_description_and_bug_url):
1044
1045 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
1046
1047         Unreviewed trivial permissions fix.
1048
1049         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
1050
1051 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
1052
1053         [EFL][Regression] Build break after r120786
1054         https://bugs.webkit.org/show_bug.cgi?id=89549
1055
1056         Unreviewed build fix for Efl port.
1057
1058         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
1059
1060 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1061
1062         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
1063         https://bugs.webkit.org/show_bug.cgi?id=64489
1064
1065         Reviewed by Tony Chang.
1066
1067         This change changes NRWT so that we don't start the websocket
1068         server if we aren't running websocket tests and don't start the
1069         HTTP server if we aren't running http tests.
1070         
1071         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1072         (Manager._websocket_tests):
1073         (Manager.start_servers_with_lock):
1074         (Manager.stop_servers_with_lock):
1075         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1076         (ManagerTest.test_servers_started):
1077
1078 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1079
1080         test-webkitpy: add a -p flag to pass through captured output to enable debugging
1081         https://bugs.webkit.org/show_bug.cgi?id=89158
1082
1083         Reviewed by Eric Seidel.
1084
1085         Normally when outputcapture runs it intercepts stdout/stderr,
1086         which makes running under the debugger difficult and mostly
1087         pointless (since you can't see any output). This change adds a
1088         flag to test-webkitpy (-p) that will cause outputcapture to pass
1089         through the output as well as capture it.
1090
1091         * Scripts/webkitpy/common/system/outputcapture.py:
1092         (OutputCapture.stream_wrapper):
1093         (OutputCapture._capture_output_with_name):
1094         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1095         (OutputCaptureTest.setUp):
1096         * Scripts/webkitpy/test/main.py:
1097         (Tester._parse_args):
1098         (Tester._run_tests):
1099         (Tester._log_exception):
1100         (_CaptureAndPassThroughStream):
1101         (_CaptureAndPassThroughStream.__init__):
1102         (_CaptureAndPassThroughStream.write):
1103         (_CaptureAndPassThroughStream._message_is_from_pdb):
1104         (_CaptureAndPassThroughStream.flush):
1105         (_CaptureAndPassThroughStream.getvalue):
1106
1107 2012-06-19  Adam Barth  <abarth@webkit.org>
1108
1109         garden-o-matic fails to rebaseline tests with MISSING results
1110         https://bugs.webkit.org/show_bug.cgi?id=89521
1111
1112         Reviewed by Kenneth Russell.
1113
1114         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1117
1118 2012-06-19  Adam Barth  <abarth@webkit.org>
1119
1120         svn.delete_list fails to delete empty parent directories
1121         https://bugs.webkit.org/show_bug.cgi?id=89520
1122
1123         Reviewed by Dirk Pranke.
1124
1125         These functions were calling scm.delete and scm.add, which already
1126         delete the parent directory. We'd get an exception when we tried to
1127         delete the parent directory again.
1128
1129         * Scripts/webkitpy/common/checkout/scm/svn.py:
1130         (SVN._add_parent_directories):
1131         (SVN._delete_parent_directories):
1132
1133 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1134
1135         webkitpy: Simplify fetch_bugs_matching_search()
1136         https://bugs.webkit.org/show_bug.cgi?id=89497
1137
1138         Reviewed by Adam Barth.
1139
1140         Removed parameter with default value. It's not being used
1141         and the handling of the parameter was wrong. Saves a check.
1142
1143         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1144         (BugzillaQueries.fetch_bugs_matching_search):
1145         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1146         (MockBugzillaQueries.fetch_bugs_matching_search):
1147
1148 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1149
1150         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
1151         https://bugs.webkit.org/show_bug.cgi?id=89522
1152
1153         Reviewed by Eric Seidel.
1154
1155         They were no longer being used. No tests necessary.
1156
1157         * Scripts/webkitpy/layout_tests/port/chromium.py:
1158
1159 2012-06-19  Adam Barth  <abarth@webkit.org>
1160
1161         Missing results aren't shown in garden-o-matic
1162
1163         Reviewed by Kenneth Russell.
1164
1165         Previously we didn't know to look for text and image results when the
1166         bot told us that results were missing.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1169
1170 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1171
1172         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
1173
1174         Unreviewed, build fix.
1175
1176         It turns out that we store the svn revision two different ways
1177         in the JSON, and I only caught one of them :(. This should fix
1178         the other.
1179
1180         Also, this part of the code is poorly tested. I will investigate
1181         adding at least a basic test for this in a separate fix.
1182
1183         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1184         (summarize_results):
1185
1186 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1187
1188         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
1189         https://bugs.webkit.org/show_bug.cgi?id=78127
1190
1191         Reviewed by Ryosuke Niwa.
1192
1193         Add the --add-platform-exceptions flag from ORWT, and ensure
1194         that --new-baseline is equivalent to --reset-results
1195         --add-platform-exceptions. Also fix the default logic for where to
1196         put PNGs and render tree dumps if --new-test-results is true:
1197         if --add-platform-exceptions is False, baselines should go in
1198         the least-specific platform directory (e.g., platform/mac)
1199         rather than the most-specific (platform/mac-snowleopard).
1200
1201         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1202         (SingleTestRunner):
1203         (SingleTestRunner.run):
1204         (SingleTestRunner._run_rebaseline):
1205         (SingleTestRunner._add_missing_baselines):
1206         (SingleTestRunner._location_for_new_baseline):
1207         (SingleTestRunner._overwrite_baselines):
1208         (SingleTestRunner._save_baseline_data):
1209         * Scripts/webkitpy/layout_tests/port/base.py:
1210         (Port.baseline_path):
1211         (Port):
1212         (Port.baseline_platform_dir):
1213         (Port.baseline_version_dir):
1214         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1215         (_set_up_derived_options):
1216         (parse_args):
1217         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1218         (RebaselineTest.assertBaselines):
1219         (RebaselineTest.test_reset_results):
1220         (RebaselineTest.test_missing_results):
1221         (RebaselineTest.test_new_baseline):
1222
1223 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1224
1225         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
1226         https://bugs.webkit.org/show_bug.cgi?id=81379
1227
1228         Reviewed by Eric Seidel.
1229
1230         The 'free memory' calculation we were running on the mac seemed
1231         to underestimate how many children we can run in parallel, and
1232         it was complex. This patch replaces that calculation with a
1233         simpler one that reserves 2GB for overhead and assumes 256MB per
1234         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
1235
1236         Also, there was a bug where we were truncating the memory
1237         installed on the machine to 4GB by casting to an int instead of
1238         a long; this was probably the source of some of the earlier
1239         problems when using total memory.
1240
1241         This patch also removes the no-longer-needed restrictions on the
1242         number of workers on beefy Lion boxes for both Apple Mac and Chromium
1243         Mac; we should now use all of the cores by default.
1244
1245         The memory calculations have only been implemented on the mac;
1246         having the calculation in base.default_child_processes() was IMO
1247         misleading, and so this patch also moves the computation into
1248         the MacPort. I have not heard of the # of workers being an issue
1249         on any other ports, so this should be fine.
1250
1251         * Scripts/webkitpy/common/system/platforminfo.py:
1252         (PlatformInfo.total_bytes_memory):
1253         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1254         (PlatformInfo.total_bytes_memory):
1255         (PlatformInfo.total_bytes_memory):
1256         (PlatformInfo._win_version_tuple_from_cmd):
1257         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1258         (TestPlatformInfo.test_total_bytes_memory):
1259         * Scripts/webkitpy/layout_tests/port/base.py:
1260         (Port.default_child_processes):
1261         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1262         (PortTest.test_default_child_processes):
1263         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1264         (ChromiumMacPort.operating_system):
1265         * Scripts/webkitpy/layout_tests/port/mac.py:
1266         (MacPort.default_child_processes):
1267         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1268         (TestMacPort.test_default_child_processes):
1269
1270 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1271
1272         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
1273         https://bugs.webkit.org/show_bug.cgi?id=85446
1274
1275         Reviewed by Simon Fraser.
1276
1277         Embed whether pixel testing was enabled into the results.json.
1278
1279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1280         (summarize_results):
1281
1282 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
1283
1284         [Qt] Modify HTTPS port to 8443 for performance tests
1285         https://bugs.webkit.org/show_bug.cgi?id=89442
1286
1287         Reviewed by Ryosuke Niwa.
1288
1289         We should be consistent with the default HTTPS port and with the changelog of r119188.
1290
1291         * Scripts/webkitpy/performance_tests/perftest.py:
1292         (ReplayServer.__init__):
1293
1294 2012-06-19  Mike West  <mkwst@chromium.org>
1295
1296         Introduce ENABLE_CSP_NEXT configuration flag.
1297         https://bugs.webkit.org/show_bug.cgi?id=89300
1298
1299         Reviewed by Adam Barth.
1300
1301         The 1.0 draft of the Content Security Policy spec is just about to
1302         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
1303         this ENABLE flag, disabled by default.
1304
1305         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
1306
1307         * Scripts/webkitperl/FeatureList.pm:
1308         * qmake/mkspecs/features/features.pri:
1309
1310 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
1311
1312         [EFL] EFL's LayoutTestController does not support setTextDirection
1313         https://bugs.webkit.org/show_bug.cgi?id=87481
1314
1315         Reviewed by Hajime Morita.
1316
1317         Implement setTextDirection in EFL's LayoutTestController and
1318         properly reset its value between test cases to avoid flakiness.
1319
1320         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1321         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1322         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1323         (LayoutTestController::setTextDirection):
1324
1325 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1326
1327         [Qt] Temporarily disable xvfb driver in nrwt
1328         https://bugs.webkit.org/show_bug.cgi?id=88414
1329
1330         Reviewed by Csaba Osztrogonác.
1331
1332         * Scripts/webkitpy/layout_tests/port/qt.py:
1333         (QtPort._build_driver):
1334
1335 2012-06-18  Joone Hur  <joone.hur@intel.com>
1336
1337         [EFL] Fontconfig can't be linked properly
1338         https://bugs.webkit.org/show_bug.cgi?id=89418
1339
1340         Unreviewed build fix.
1341
1342         Make Fontconfig be linked correctly.
1343
1344         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
1345
1346 2012-06-18  Joone Hur  <joone.hur@intel.com>
1347
1348         Unreviewed. Updating email for committers.py script.
1349
1350         * Scripts/webkitpy/common/config/committers.py:
1351
1352 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1353
1354         Fix a typo that caused TestFailures to have a syntax error.
1355         
1356         Sadly TestFailures is broken for another reason now too:
1357         https://bugs.webkit.org/show_bug.cgi?id=89419
1358
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1360         (ViewController.prototype._domForBuildName):
1361
1362 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1363
1364         Provide bug links for suspicious commits
1365         https://bugs.webkit.org/show_bug.cgi?id=89408
1366         
1367         Reviewed by Adam Barth.
1368
1369         Add links to bugs for the suspicious commits if we have bug data.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1374         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
1375         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
1376
1377 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
1378
1379         [Chromium] DeviceOrientation Cleanup
1380         https://bugs.webkit.org/show_bug.cgi?id=89354
1381
1382         Reviewed by Kent Tamura.
1383
1384         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
1385         (WebViewHost):
1386
1387 2012-06-18  James Robinson  <jamesr@chromium.org>
1388
1389         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
1390         https://bugs.webkit.org/show_bug.cgi?id=89254
1391
1392         Reviewed by Adrienne Walker.
1393
1394         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
1395         upstream.
1396
1397         * DumpRenderTree/chromium/WebViewHost.cpp:
1398         (WebViewHost::createGraphicsContext3D):
1399
1400 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1401
1402         Minor fix suggested by Adam Barth.
1403
1404         Use $(this._what).empty(); rather than removing children one at a time.
1405         For some reason removeAllChildren() is undefined on this node.
1406         
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1408
1409 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1410
1411         Show TOT revision in garden-o-matic, and make the revisions into links
1412         https://bugs.webkit.org/show_bug.cgi?id=89396
1413
1414         Reviewed by Adam Barth.
1415
1416         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
1417         where the revisions are links to trac.
1418         
1419         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
1420         the knock-on effect of flipping the target and href attributes for anchors in some test output.
1421
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1423         (ViewController.prototype._displayTesters.updateList.list):
1424         (ViewController.prototype._displayTesters.updateList):
1425         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
1426         (ViewController.prototype._domForRegressionRange):
1427         (ViewController.prototype._domForAuxiliaryUIElements):
1428         (ViewController.prototype._domForBuildName):
1429         (ViewController.prototype):
1430         (ViewController.prototype.):
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1436
1437 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
1438
1439         REGRESSION(r100558): NRWT should work without SVN or GIT
1440         https://bugs.webkit.org/show_bug.cgi?id=76630
1441
1442         Reviewed by Dirk Pranke.
1443
1444         NRWT is not supposed to have a requirement that we have an
1445         actual SVN or Git checkout, and we were unnecessarily
1446         initializing the checkout. This patch removes that line :).
1447
1448         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1449         (main):
1450
1451 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1452
1453         [garden-o-matic] Add support for the GTK builders
1454         https://bugs.webkit.org/show_bug.cgi?id=89360
1455
1456         Reviewed by Adam Barth.
1457
1458         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
1459         both get their data from build.webkit.org.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1462         (.):
1463
1464 2012-06-18  Nico Weber  <thakis@chromium.org>
1465
1466         [chromium/mac] Unbreak smooth scrolling.
1467         https://bugs.webkit.org/show_bug.cgi?id=89327
1468
1469         Reviewed by Dimitri Glazkov.
1470
1471         Broken by Sam in r115589 / r115591.
1472
1473         * DumpRenderTree/mac/DumpRenderTree.mm:
1474         (resetDefaultsToConsistentValues):
1475         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1476         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1477         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1478         (WTR::InjectedBundle::platformInitialize):
1479
1480 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1481
1482         Unreviewed, rolling out r120541, r120547, and r120548.
1483         http://trac.webkit.org/changeset/120541
1484         http://trac.webkit.org/changeset/120547
1485         http://trac.webkit.org/changeset/120548
1486         https://bugs.webkit.org/show_bug.cgi?id=89383
1487
1488         This approach doesn't work for WebKit2 (Requested by abarth on
1489         #webkit).
1490
1491         * DumpRenderTree/LayoutTestController.cpp:
1492         (setBackingScaleFactorCallback):
1493         (LayoutTestController::staticFunctions):
1494         * DumpRenderTree/LayoutTestController.h:
1495         (LayoutTestController):
1496         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1497         (LayoutTestController::setBackingScaleFactor):
1498         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1499         (LayoutTestController::setBackingScaleFactor):
1500         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1501         (LayoutTestController::setBackingScaleFactor):
1502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1503         (LayoutTestController::setBackingScaleFactor):
1504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1505         (LayoutTestController::setBackingScaleFactor):
1506         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1507         (LayoutTestController::setBackingScaleFactor):
1508         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1510         (WTR::InjectedBundle::didReceiveMessage):
1511         (WTR::InjectedBundle::postSetBackingScaleFactor):
1512         (WTR):
1513         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1514         (InjectedBundle):
1515         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1516         (WTR::LayoutTestController::setBackingScaleFactor):
1517         (WTR):
1518         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1519         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1520         (LayoutTestController):
1521         * WebKitTestRunner/TestInvocation.cpp:
1522         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1523
1524 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1525
1526         REGRESSION(r120546): It made 3 webkitpy tests fail
1527         https://bugs.webkit.org/show_bug.cgi?id=89332
1528
1529         Reviewed by Adam Barth.
1530
1531         Update the BaselineOptimizer unittest after r120546.
1532
1533         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1534         (BaselineOptimizerTest.test_no_add_mac_future):
1535         (BaselineOptimizerTest.test_mac_future):
1536         (BaselineOptimizerTest.test_complex_shadowing):
1537
1538 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1539
1540         new-run-webkit-tests output gets confused when logging
1541         https://bugs.webkit.org/show_bug.cgi?id=63793
1542
1543         Reviewed by Adam Barth.
1544
1545         Ship all of the log messages generated in the worker back
1546         to the manager; this allows the messages to be properly
1547         serialized to stderr and for the meter to flush its output correctly.
1548
1549         Note however that this will likely result in messages to be
1550         logged out of order between workers; I'm not sure that there's
1551         an easy way to fix this short of buffering a potentially
1552         unbounded amount of data. It might be better to just log through
1553         stderr unless we're in 'metering' mode, but it's also worth
1554         noting that we already get messages out of order through stderr
1555         on Windows.
1556
1557         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1558         (Manager.handle_done):
1559         (Manager.handle_finished_test):
1560         (Manager._log_messages):
1561         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1562         (Worker.__init__):
1563         (Worker._set_up_logging):
1564         (Worker.run):
1565         (Worker._run_test):
1566         (Worker.cleanup):
1567         (Worker.run_single_test):
1568         (_WorkerLogHandler):
1569         (_WorkerLogHandler.__init__):
1570         (_WorkerLogHandler.emit):
1571         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1572         (MeteredStream.write):
1573         (MeteredStream.writeln):
1574         * Scripts/webkitpy/layout_tests/views/printing.py:
1575         (Printer.writeln):
1576
1577 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1578
1579         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
1580         https://bugs.webkit.org/show_bug.cgi?id=89362
1581
1582         Reviewed by Simon Fraser.
1583
1584         Replace white spaces, braces and dots in the builder name with underscores. This
1585         way the JQuery tabs will be properly matched with the according container.
1586
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1588
1589 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1590
1591         nrwt: metered output doesn't handle ^C cleanly
1592         https://bugs.webkit.org/show_bug.cgi?id=89249
1593
1594         Reviewed by Tony Chang.
1595
1596         If you ctrl-c a running nrwt (w/o --verbose), then all but
1597         two characters of the last update are erased, and then we print
1598         "interrupted, exiting" as an update, which itself then gets
1599         erased. Fix this so that we flush the meter (making the last
1600         update persistent, so that we print the ^C for a visual clue),
1601         print the interrupt message, and move on ...
1602
1603         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1604         (Manager._run_tests):
1605         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1606         (MeteredStream.flush):
1607         * Scripts/webkitpy/layout_tests/views/printing.py:
1608         (Printer._write):
1609         (Printer):
1610         (Printer.flush):
1611
1612 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
1613
1614         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
1615         https://bugs.webkit.org/show_bug.cgi?id=89228
1616
1617         Reviewed by Tony Chang.
1618
1619         * DumpRenderTree/chromium/LayoutTestController.cpp:
1620         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1621
1622 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
1623
1624         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
1625         https://bugs.webkit.org/show_bug.cgi?id=89226
1626
1627         Reviewed by Martin Robinson.
1628
1629         Implement increment() and decrement() functions in term of the AtkValue interface,
1630         instead of using DumpRenderTreeSupportGtk helper class.
1631
1632         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1633         (AccessibilityUIElement::intValue):
1634         (AccessibilityUIElement::minValue):
1635         (AccessibilityUIElement::maxValue):
1636         (alterCurrentValue):
1637         (AccessibilityUIElement::increment):
1638         (AccessibilityUIElement::decrement):
1639
1640 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
1641
1642         garden-o-matic 'Results' panel is broken for the Apple platform
1643         https://bugs.webkit.org/show_bug.cgi?id=89310
1644
1645         Reviewed by Adam Barth.
1646         
1647         For platforms that don't use accumulated build directories on the server,
1648         carry along buildLocation data with buildInfo, so that we know where to
1649         look for the test results files for a given test.
1650         
1651         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
1652         it now returns an array of objects with buildNumber, revision and url info.
1653         
1654         Fixed results.fetchResultsURLs() to use this data to find results.
1655         
1656         Fixed the results display to not scroll when you click on a test to see the results.
1657         Made the h3s look less ugly
1658         
1659         Don't try to show the flakiness dashboard for the Apple platform.
1660
1661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1667         (.results-view .top-panel):
1668         (.results-view h3):
1669
1670 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1671
1672         Make garden-o-matic work for the Apple Mac port
1673         https://bugs.webkit.org/show_bug.cgi?id=84642
1674
1675         Reviewed by Adam Barth.
1676         
1677         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1678         educating the scripts in various ways:
1679         * Wrap up platform-related differences in config.kPlatforms[]
1680         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1681         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1682           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1683           recent build with valid results.
1684         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1685           try to test a build that has already been deleted). Make walkHistory() more robust here.
1686         * webkit.org uses differently named test result directories, that include the SVN revision as
1687           well as the build number. That forces us to fetch more build info before we can get the
1688           result directory URL.
1689         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1690           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1691           dirs.
1692         * Various URLs differ between webkit.org and chromium.org
1693         * Better UI for the failures info, so that some info is visible even when not hovered.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1697         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1711         (ol.notifications>li table.failures):
1712         (ol.notifications>li:hover table.failures):
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1714         (#onebar #platform-picker):
1715         * Scripts/webkitpy/layout_tests/port/builders.py:
1716
1717 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1718
1719         Unreviewed, rolling out r120536.
1720         http://trac.webkit.org/changeset/120536
1721         https://bugs.webkit.org/show_bug.cgi?id=89296
1722
1723         Does not compile on chromium-linux (Requested by abarth on
1724         #webkit).
1725
1726         * DumpRenderTree/chromium/LayoutTestController.cpp:
1727         (LayoutTestController::reset):
1728         (LayoutTestController::setTextSubpixelPositioning):
1729         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1730
1731 2012-06-16  Adam Barth  <abarth@webkit.org>
1732
1733         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1734         https://bugs.webkit.org/show_bug.cgi?id=89274
1735
1736         Reviewed by Levi Weintraub.
1737
1738         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1739         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1740         tested by API-level tests.
1741
1742         * DumpRenderTree/LayoutTestController.cpp:
1743         (LayoutTestController::staticFunctions):
1744         * DumpRenderTree/LayoutTestController.h:
1745         (LayoutTestController):
1746         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1747         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1748         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1749         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1750         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1751         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1752         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1753         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1754         (WTR::InjectedBundle::didReceiveMessage):
1755         (WTR):
1756         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1757         (InjectedBundle):
1758         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1759         (WTR):
1760         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1761         (LayoutTestController):
1762         * WebKitTestRunner/TestInvocation.cpp:
1763         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1764
1765 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1766
1767         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1768         https://bugs.webkit.org/show_bug.cgi?id=89228
1769
1770         Reviewed by Tony Chang.
1771
1772         * DumpRenderTree/chromium/LayoutTestController.cpp:
1773         (LayoutTestController::reset):
1774         (LayoutTestController::setTextSubpixelPositioning):
1775         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1776
1777 2012-06-15  Adam Barth  <abarth@webkit.org>
1778
1779         garden-o-matic's results.js should use RequestTracker
1780         https://bugs.webkit.org/show_bug.cgi?id=89257
1781
1782         Reviewed by Dimitri Glazkov.
1783
1784         We wrote results.js before we recognized the RequestTracker pattern.
1785         This patch replaces the manual implementations of RequestTracker with
1786         the real deal.
1787
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1789
1790 2012-06-15  Darin Adler  <darin@apple.com>
1791
1792         * Scripts/webkitpy/bindings: Added property svn:ignore.
1793
1794 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1795
1796         Unreviewed, rolling out r120511.
1797         http://trac.webkit.org/changeset/120511
1798         https://bugs.webkit.org/show_bug.cgi?id=89255
1799
1800         Breaks at least Android builder (Requested by wangxianzhu on
1801         #webkit).
1802
1803         * DumpRenderTree/chromium/LayoutTestController.cpp:
1804         (LayoutTestController::reset):
1805         (LayoutTestController::setTextSubpixelPositioning):
1806
1807 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1808
1809         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1810         https://bugs.webkit.org/show_bug.cgi?id=89228
1811
1812         Reviewed by Tony Chang.
1813
1814         * DumpRenderTree/chromium/LayoutTestController.cpp:
1815         (LayoutTestController::reset):
1816         (LayoutTestController::setTextSubpixelPositioning):
1817
1818 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1819
1820         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1821         https://bugs.webkit.org/show_bug.cgi?id=89135
1822
1823         Re-land change in r120370 with fix in
1824         PortFactory.get_from_builder_name() that changes BuilderOptions
1825         to an actual optparse.Values object.
1826
1827         * Scripts/webkitpy/layout_tests/port/base.py:
1828         (Port.__init__):
1829         (Port.get_option):
1830         (Port.set_option_default):
1831         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1832         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1833         * Scripts/webkitpy/layout_tests/port/factory.py:
1834         (_builder_options):
1835         (PortFactory.get_from_builder_name):
1836         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1837         (FactoryTest.test_get_from_builder_name):
1838         * Scripts/webkitpy/style/checkers/test_expectations.py:
1839         (TestExpectationsChecker._determine_port_from_expectations_path):
1840         * Scripts/webkitpy/tool/mocktool.py:
1841         (MockOptions.ensure_value):
1842
1843 2012-06-15  Bill Budge  <bbudge@chromium.org>
1844
1845         Add bbudge@chromium.org to committers.py
1846
1847         Unreviewed.
1848
1849         * Scripts/webkitpy/common/config/committers.py:
1850
1851 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1852
1853         Unreviewed style fix after r120351.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1856         (body.interface):
1857
1858 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1859
1860         master.cfg cleanup, remove unnecessary workaround
1861         https://bugs.webkit.org/show_bug.cgi?id=88994
1862
1863         Reviewed by Lucas Forschler.
1864
1865         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1866         (loadBuilderConfig):
1867
1868 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1869
1870         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1871         https://bugs.webkit.org/show_bug.cgi?id=88581
1872
1873         Reviewed by Adam Barth.
1874
1875         Make sure we only optimize the suffixes we rebaselined during
1876         rebaseline-expectations, and not all suffixes for a test.
1877         While optimizing is somewhere between harmless and good, it's also confusing :)
1878
1879         * Scripts/webkitpy/tool/commands/rebaseline.py:
1880         (RebaselineExpectations._rebaseline_port):
1881         (RebaselineExpectations.execute):
1882         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1883
1884 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1885
1886         Update builder.html template for newer buildmaster
1887         https://bugs.webkit.org/show_bug.cgi?id=89207
1888
1889         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1890
1891         Reviewed by Zoltan Herczeg.
1892
1893         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1894
1895 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1896
1897         Add ForceScheduler to build.webkit.org
1898         https://bugs.webkit.org/show_bug.cgi?id=88982
1899
1900         Reviewed by Ryosuke Niwa.
1901
1902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1903         (loadBuilderConfig):
1904
1905 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1906
1907         [EFL][WK2] Add title support to Ewk_View
1908         https://bugs.webkit.org/show_bug.cgi?id=89095
1909
1910         Reviewed by Kenneth Rohde Christiansen.
1911
1912         Update the MiniBrowser so it listens for the "title,change"
1913         signal on the view and keeps the browser window title
1914         up-to-date.
1915
1916         * MiniBrowser/efl/main.c:
1917         (on_title_changed):
1918         (browserCreate):
1919
1920 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1921
1922         [WK2][EFL] Implement navigation back/forward in Ewk_View
1923         https://bugs.webkit.org/show_bug.cgi?id=89173
1924
1925         Reviewed by Kenneth Rohde Christiansen.
1926
1927         Implement navigation back / forward in MiniBrowser. Use
1928         'F1' to navigate back and 'F2' to navigate forward.
1929
1930         * MiniBrowser/efl/main.c:
1931         (on_key_down):
1932
1933 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1934
1935         [EFL] EFL's LayoutTestController does not support titleTextDirection
1936         https://bugs.webkit.org/show_bug.cgi?id=86475
1937
1938         Reviewed by Hajime Morita.
1939
1940         Add titleTextDirection getter and setter to LayoutTestController and
1941         expose its value to JavaScript.
1942         Update the titleTextDirection value from EFL's "title,changed"
1943         callback in DumpRenderTree.
1944
1945         * DumpRenderTree/LayoutTestController.cpp:
1946         (LayoutTestController::LayoutTestController):
1947         (getTitleTextDirectionCallback):
1948         (LayoutTestController::staticValues):
1949         * DumpRenderTree/LayoutTestController.h:
1950         (LayoutTestController::titleTextDirection):
1951         (LayoutTestController::setTitleTextDirection):
1952         (LayoutTestController):
1953         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1954         (DumpRenderTreeChrome::onFrameTitleChanged):
1955
1956 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1957
1958         [EFL][WK2] Implement reload / stop in Ewk_View
1959         https://bugs.webkit.org/show_bug.cgi?id=89168
1960
1961         Reviewed by Kenneth Rohde Christiansen.
1962
1963         Implement view reload / stop loading in MiniBrowser.
1964         Use 'F5' for reload and 'F6' for stopping the load.
1965
1966         * MiniBrowser/efl/main.c:
1967         (on_key_down):
1968         (browserCreate):
1969
1970 2012-06-15  Hironori Bono  <hbono@chromium.org>
1971
1972         Allow platforms to choose whether to remove markers on editing
1973         https://bugs.webkit.org/show_bug.cgi?id=88838
1974
1975         Reviewed by Hajime Morita.
1976
1977         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1978         run grammar tests.
1979
1980         * DumpRenderTree/chromium/WebViewHost.cpp:
1981         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1982         * DumpRenderTree/chromium/WebViewHost.h:
1983         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1984
1985 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1986
1987         Unreviewed, rolling out r120370.
1988         http://trac.webkit.org/changeset/120370
1989         https://bugs.webkit.org/show_bug.cgi?id=89183
1990
1991         Broke webkit-patch rebaseline (Requested by zdobersek on
1992         #webkit).
1993
1994         * Scripts/webkitpy/layout_tests/port/base.py:
1995         (DummyOptions):
1996         (DummyOptions.__init__):
1997         (DummyOptions.__init__.this):
1998         (Port.__init__):
1999         (Port.get_option):
2000         (Port.set_option_default):
2001         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2002         (ChromiumWinTest.RegisterCygwinOption):
2003         (ChromiumWinTest.RegisterCygwinOption.__init__):
2004         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2005         * Scripts/webkitpy/style/checkers/test_expectations.py:
2006         (TestExpectationsChecker._determine_port_from_expectations_path):
2007         * Scripts/webkitpy/tool/mocktool.py:
2008         (MockOptions.update):
2009
2010 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
2011
2012         [Chromium-Android] Initialize font rendering in DumpRenderTree
2013         https://bugs.webkit.org/show_bug.cgi?id=89133
2014
2015         Reviewed by Adam Barth.
2016
2017         * DumpRenderTree/chromium/LayoutTestController.cpp:
2018         (LayoutTestController::reset):
2019         (LayoutTestController::setTextSubpixelPositioning):
2020         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2021         (platformInit):
2022
2023 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
2024
2025         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
2026         https://bugs.webkit.org/show_bug.cgi?id=88622
2027
2028         Reviewed by Philippe Normand.
2029
2030         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
2031         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2032
2033 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
2034
2035         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
2036         https://bugs.webkit.org/show_bug.cgi?id=89124
2037
2038         Reviewed by Dirk Pranke.
2039
2040         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2041         (ChromiumAndroidDriver._start):
2042         (ChromiumAndroidDriver):
2043         (ChromiumAndroidDriver._start_once):
2044
2045 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
2046
2047         Update webpagereplay to 1.1.2
2048         https://bugs.webkit.org/show_bug.cgi?id=89118
2049
2050         This includes the following patch which avoids pkg_resources import errors:
2051         http://code.google.com/p/web-page-replay/source/detail?r=476
2052
2053         Reviewed by Dirk Pranke.
2054
2055         * Scripts/webkitpy/thirdparty/__init__.py:
2056         (AutoinstallImportHook._install_webpagereplay):
2057
2058 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
2059
2060         Get rid of FAIL test expectation
2061         https://bugs.webkit.org/show_bug.cgi?id=89137
2062
2063         Reviewed by Dirk Pranke.
2064
2065         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2066         (ResultSummaryTest.test_summarized_results_wontfix):
2067         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2068         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2069         (JSONLayoutResultsGenerator):
2070         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2071         (result_was_expected):
2072         (suffixes_for_expectations):
2073         (TestExpectationsModel._add_test):
2074         (TestExpectations):
2075         (TestExpectations.get_rebaselining_failures):
2076         (TestExpectations.remove_configuration_from_test):
2077         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2078         (FunctionsTest.test_result_was_expected):
2079         (FunctionsTest.test_suffixes_for_expectations):
2080         (TestExpectationSerializerTests.test_parsed_expectations_string):
2081         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2082         (test_test_expectations):
2083         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2084         (TestExpectationsTestCase.test_valid_expectations):
2085
2086 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2087
2088         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
2089         https://bugs.webkit.org/show_bug.cgi?id=89135
2090
2091         Reviewed by Ryosuke Niwa.
2092
2093         This patch is just some minor cleanup and simplification. There
2094         should be no functional changes here.
2095
2096         * Scripts/webkitpy/layout_tests/port/base.py:
2097         (Port.__init__):
2098         (Port.get_option):
2099         (Port.set_option_default):
2100         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2101         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2102         * Scripts/webkitpy/style/checkers/test_expectations.py:
2103         (TestExpectationsChecker._determine_port_from_expectations_path):
2104         * Scripts/webkitpy/tool/mocktool.py:
2105         (MockOptions.ensure_value):
2106
2107 2012-06-14  Ian Vollick  <vollick@chromium.org>
2108
2109         [chromium] Certain settings in CCSettings could be global
2110         https://bugs.webkit.org/show_bug.cgi?id=88384
2111
2112         Reviewed by James Robinson.
2113
2114         * DumpRenderTree/chromium/TestShell.cpp:
2115         (TestShell::TestShell):
2116         (TestShell::resetWebSettings):
2117         (TestShell::setPerTilePaintingEnabled):
2118         * DumpRenderTree/chromium/TestShell.h:
2119         (TestShell):
2120         * DumpRenderTree/chromium/WebPreferences.cpp:
2121         (WebPreferences::reset):
2122         (WebPreferences::applyTo):
2123         * DumpRenderTree/chromium/WebPreferences.h:
2124         (WebPreferences):
2125
2126 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2127
2128         Unreviewed, rolling out r120352.
2129         http://trac.webkit.org/changeset/120352
2130         https://bugs.webkit.org/show_bug.cgi?id=89120
2131
2132         It seems something is still wrong with it :/ (Requested by
2133         Ossy on #webkit).
2134
2135         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2136         (Factory.__init__):
2137         (BuildFactory.__init__):
2138         (TestFactory.__init__):
2139         (BuildAndTestFactory.__init__):
2140         (BuildAndPerfTestFactory.__init__):
2141         (BuildAndPerfTestWebKit2Factory.__init__):
2142         (DownloadAndPerfTestFactory.__init__):
2143         (DownloadAndPerfTestWebKit2Factory.__init__):
2144
2145 2012-06-14  Jia Pu  <jpu@apple.com>
2146
2147         Mark text with text alternative with blue underline.
2148         https://bugs.webkit.org/show_bug.cgi?id=83047
2149
2150         Reviewed by NOBODY Enrica Casucci.
2151
2152         * DumpRenderTree/mac/TextInputController.m:
2153         (+[TextInputController isSelectorExcludedFromWebScript:]):
2154         (+[TextInputController webScriptNameForSelector:]):
2155         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
2156
2157 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2158
2159         Unreviewed, rolling out r120353.
2160         http://trac.webkit.org/changeset/120353
2161         https://bugs.webkit.org/show_bug.cgi?id=89119
2162
2163         It seems we still need this workaround (Requested by Ossy on
2164         #webkit).
2165
2166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2167         (loadBuilderConfig):
2168
2169 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2170
2171         master.cfg cleanup, remove unnecessary workaround
2172         https://bugs.webkit.org/show_bug.cgi?id=88994
2173
2174         Reviewed by Lucas Forschler.
2175
2176         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2177         (loadBuilderConfig):
2178
2179 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2180
2181         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
2182         https://bugs.webkit.org/show_bug.cgi?id=89001
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2187         (Factory.__init__):
2188         (BuildFactory.__init__):
2189         (TestFactory.__init__):
2190         (BuildAndTestFactory.__init__):
2191         (BuildAndPerfTestFactory.__init__):
2192         (BuildAndPerfTestWebKit2Factory.__init__):
2193         (DownloadAndPerfTestFactory.__init__):
2194         (DownloadAndPerfTestWebKit2Factory.__init__):
2195
2196 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2197
2198         Unhide login form on the build.webkit.org
2199         https://bugs.webkit.org/show_bug.cgi?id=88981
2200
2201         Reviewed by Lucas Forschler.
2202
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2204
2205 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
2206
2207         [Gtk] Add support in DumpRenderTree for tracking repaints
2208         https://bugs.webkit.org/show_bug.cgi?id=87658
2209
2210         Reviewed by Martin Robinson.
2211
2212         Reimplement the displayWebView method in DumpRenderTree - force a
2213         repaint before starting tracking repaints and resetting them.
2214
2215         When gathering pixel output from a web view, if tracking repaints,
2216         paint an overlay over the output with the overlay being clear in the
2217         areas where the repaints occurred.
2218
2219         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2220         (displayWebView):
2221         (resetDefaultsToConsistentValues):
2222         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2223         (paintOverlay):
2224         (fillRepaintOverlayIntoContext):
2225         (createBitmapContextFromWebView):
2226
2227 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2228
2229         new-run-webkit-tests doesn't find similar platform tests for a keyword
2230         https://bugs.webkit.org/show_bug.cgi?id=37956
2231
2232         Reviewed by Ryosuke Niwa.
2233
2234         This patches adds support for NRWT so that if you type
2235         "new-run-webkit-tests foo" it will run all the tests in foo as
2236         well as platform/foo for all of the platforms that are normally
2237         searched (this only applies to directories, not to individual tests).
2238
2239         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2240         (Manager.collect_tests):
2241         * Scripts/webkitpy/layout_tests/port/base.py:
2242         (Port.tests):
2243         (Port):
2244         (Port._expanded_paths):
2245         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2246         (MainTest.test_no_http_tests):
2247         (MainTest):
2248         (MainTest.test_platform_tests_are_found):
2249
2250 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2251
2252         NRWT should honor --skipped=[default|ignore|only], like ORWT does
2253         https://bugs.webkit.org/show_bug.cgi?id=66308
2254
2255         Reviewed by Ryosuke Niwa.
2256
2257         This patch adds support for ORWT's --skipped=(default|ignore|only)
2258         flag and cleans up the interaction between that and --ignore.
2259
2260         Individual tests (but not directories) explicitly listed on the
2261         command line will always be run regardless of what is passed
2262         for --skipped and --ignore.
2263
2264         This patch also changes the "found" and "running" log messages
2265         since it wasn't clear how the skipped tests were included in those numbers.
2266
2267         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2268         (Manager.__init__):
2269         (Manager.collect_tests):
2270         (Manager.prepare_lists_and_print_output):
2271         * Scripts/webkitpy/layout_tests/port/test.py:
2272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2273         (_set_up_derived_options):
2274         (parse_args):
2275         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2276         (MainTest.test_ignore_flag):
2277         (MainTest):
2278         (MainTest.test_skipped_flag):
2279
2280 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2281
2282         new-run-webkit-websocketserver must handle TLS related arguments
2283         https://bugs.webkit.org/show_bug.cgi?id=89079
2284
2285         Reviewed by Dirk Pranke.
2286
2287         PyWebSocket class must accept private_key, certificate, and
2288         ca_certificate arguments and pass them to launching pywebsocket.
2289         Also add ca_certificate handling to new-run-webkit-websocketserver.
2290
2291         * Scripts/new-run-webkit-websocketserver:
2292         (main):
2293         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2294         (PyWebSocket.__init__):
2295         (PyWebSocket._prepare_config):
2296
2297 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2298
2299         Unreviewed. Update my email.
2300
2301         * Scripts/webkitpy/common/config/committers.py:
2302
2303 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2304
2305         Update pywebsocket to 0.7.6 from 0.7.4
2306         https://bugs.webkit.org/show_bug.cgi?id=88975
2307
2308         Reviewed by Kent Tamura.
2309
2310         This new version of pywebsocket introduce following features.
2311          - Allow handlers to send a close frame with empty body in response of
2312              a client initiated closing handshake
2313          - Implement perframe compression extension
2314          - Support client certificate authentication
2315
2316         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
2317         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2318         (_create_control_frame):
2319         (Stream._receive_frame):
2320         (Stream.send_message):
2321         (Stream.receive_message):
2322         (Stream._send_closing_handshake):
2323         (Stream.close_connection):
2324         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2325         (ExtensionParsingException):
2326         (ExtensionParsingException.__init__):
2327         (_parse_extension_param):
2328         (_parse_extension):
2329         (parse_extensions):
2330         (format_extension):
2331         (format_extensions):
2332         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2333         (_parse_compression_method):
2334         (_create_accepted_method_desc):
2335         (PerFrameCompressionExtensionProcessor):
2336         (PerFrameCompressionExtensionProcessor.__init__):
2337         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
2338         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
2339         (PerFrameCompressionExtensionProcessor.get_extension_response):
2340         (PerFrameCompressionExtensionProcessor.setup_stream_options):
2341         (PerFrameCompressionExtensionProcessor.get_compression_processor):
2342         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2343         (parse_token_list):
2344         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2345         (Handshaker._parse_extensions):
2346         (Handshaker._send_handshake):
2347         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2348         (WebSocketServer._create_sockets):
2349         (_get_logger_from_class):
2350         (_configure_logging):
2351         (_build_option_parser):
2352         (_main.if):
2353         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2354         (RepeatedXorMasker.mask):
2355
2356 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
2357
2358         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
2359
2360         Reviewed by Noam Rosenthal.
2361
2362         * qmake/mkspecs/features/features.prf:
2363
2364 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
2365
2366         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
2367         https://bugs.webkit.org/show_bug.cgi?id=88399
2368
2369         Reviewed by Kenneth Rohde Christiansen.
2370
2371         Update initialization of WKPageLoaderClient.
2372
2373         * MiniBrowser/mac/BrowserWindowController.m:
2374         (-[BrowserWindowController awakeFromNib]):
2375         * WebKitTestRunner/TestController.cpp:
2376         (WTR::TestController::initialize):
2377
2378 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2379
2380         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
2381         https://bugs.webkit.org/show_bug.cgi?id=84577
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
2386         LayoutTestController.
2387
2388         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2389         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2390
2391 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2392
2393         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2394         https://bugs.webkit.org/show_bug.cgi?id=88340
2395
2396         Reviewed by Kenneth Rohde Christiansen.
2397
2398         Update initialization of WKPageLoaderClient.
2399
2400         * MiniBrowser/mac/BrowserWindowController.m:
2401         (-[BrowserWindowController awakeFromNib]):
2402         * WebKitTestRunner/TestController.cpp:
2403         (WTR::TestController::initialize):
2404
2405 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2406
2407         Unreviewed, rolling out r120268.
2408         http://trac.webkit.org/changeset/120268
2409         https://bugs.webkit.org/show_bug.cgi?id=89060
2410
2411         WebCompositor::setPerTilePaintingEnabled hits an assertion in
2412         DEBUG (Requested by dominicc|work on #webkit).
2413
2414         * DumpRenderTree/chromium/WebPreferences.cpp:
2415         (WebPreferences::applyTo):
2416
2417 2012-06-13  Tim Horton  <timothy_horton@apple.com>
2418
2419         REGRESSION (r120252): run-webkit-tests on Mac fails
2420         https://bugs.webkit.org/show_bug.cgi?id=89057
2421
2422         Reviewed by Dan Bernstein.
2423
2424         get_option will happily return None (the default only kicks in if
2425         the option is actually *not set*). We should instead check get_option's
2426         return value and default to "x86_64" architecture ourselves.
2427
2428         * Scripts/webkitpy/layout_tests/port/mac.py:
2429         (MacPort.__init__):
2430
2431 2012-06-13  Ian Vollick  <vollick@chromium.org>
2432
2433         [chromium] Certain settings in CCSettings could be global
2434         https://bugs.webkit.org/show_bug.cgi?id=88384
2435
2436         Reviewed by James Robinson.
2437
2438         * DumpRenderTree/chromium/WebPreferences.cpp:
2439         (WebPreferences::applyTo):
2440
2441 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2442
2443         new-run-webkit-tests does not support --32-bit like ORWT did
2444         https://bugs.webkit.org/show_bug.cgi?id=71634
2445
2446         Reviewed by Ojan Vafai.
2447
2448         This patch adds support for 32-bit apple mac builds, adding the
2449         --32-bit flag for compatibility with ORWT and fixing the port
2450         architecture() definition to actually return the correct values.
2451
2452         * Scripts/webkitpy/layout_tests/port/apple.py:
2453         (ApplePort._generate_all_test_configurations):
2454         * Scripts/webkitpy/layout_tests/port/factory.py:
2455         (port_options):
2456         * Scripts/webkitpy/layout_tests/port/mac.py:
2457         (MacPort):
2458         (MacPort.__init__):
2459         (MacPort._build_driver_flags):
2460         (MacPort.setup_environ_for_server):
2461         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2462         (test_sample_process_throws_exception):
2463         (test_32bit):
2464         (test_32bit.run_script):
2465         (test_64bit):
2466         (test_64bit.run_script):
2467         * Scripts/webkitpy/layout_tests/port/webkit.py:
2468         (WebKitPort._build_driver):
2469         (WebKitPort._build_driver_flags):
2470         * Scripts/webkitpy/layout_tests/port/win.py:
2471         (WinPort):
2472
2473 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2474
2475         Remove webkitpy code to support legacy test_expectations.txt files
2476         https://bugs.webkit.org/show_bug.cgi?id=89038
2477
2478         Reviewed by Dirk Pranke.
2479
2480         * Scripts/webkitpy/layout_tests/port/base.py:
2481         (Port.path_to_test_expectations_file):
2482         (Port.expectations_dict):
2483         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2484         (PortTest.test_uses_test_expectations_file):
2485         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2486         (WebKitPortTest.test_path_to_test_expectations_file):
2487         (test_test_expectations):
2488         * Scripts/webkitpy/style/checker.py:
2489         (CheckerDispatcher.should_skip_without_warning):
2490         (CheckerDispatcher._create_checker):
2491         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2492         (TestExpectationsTestCase._expect_port_for_expectations_path):
2493         * Scripts/webkitpy/tool/steps/commit.py:
2494         (Commit._check_test_expectations):
2495         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2496         (CommitTest.test_check_test_expectations):
2497
2498 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2499
2500         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
2501         https://bugs.webkit.org/show_bug.cgi?id=88948
2502
2503         Reviewed by Ojan Vafai.
2504
2505         In the final patch of this run, we remove the
2506         test_expectations() and test_expectation_overrides() methods
2507         from the Port class - callers must now use just
2508         expectations_dict().
2509
2510         Note that support for the cascade in new-run-webkit-tests is
2511         complete but only Chromium uses it; webkit-patch
2512         rebaseline-expectations still does not support updating entries
2513         in any file other than the first expectations file, however.
2514
2515         * Scripts/webkitpy/layout_tests/port/base.py:
2516         (Port.path_to_test_expectations_file):
2517         (Port.uses_test_expectations_file):
2518         (Port.expectations_files):
2519         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2520         (PortTest.test_additional_expectations):
2521         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2522         (ChromiumPortTest.test_expectations_files):
2523         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2524         (TestGoogleChromePort.test_get_google_chrome_port):
2525         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2526         (test_test_expectations):
2527         (test_legacy_test_expectations):
2528
2529 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2530
2531         nrwt: implement the actual cascade of TestExpectations
2532         https://bugs.webkit.org/show_bug.cgi?id=88947
2533
2534         Reviewed by Ojan Vafai.
2535
2536         This change implements the actual cascade by removing the
2537         concept of 'overrides' from the TestExpectations object and
2538         parsing each file separately.
2539
2540         There is an actual semantic change in this patch, in that
2541         setting an expectation on a directory in one file will override
2542         the expectations on any individual tests set in prior files. The
2543         test_overrides__directory() unit test verifies this.
2544
2545         Otherwise, this patch mostly consists of deleting code :).
2546
2547         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2548         (TestExpectationsModel.__init__):
2549         (TestExpectationsModel.add_expectation_line):
2550         (TestExpectationsModel._add_test):
2551         (TestExpectationsModel._already_seen_better_match):
2552         (TestExpectations.__init__):
2553         (TestExpectations._add_expectations):
2554         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2555         (test_overrides__directory):
2556
2557 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2558
2559         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
2560         https://bugs.webkit.org/show_bug.cgi?id=88946
2561
2562         Reviewed by Ojan Vafai.
2563
2564         In preparation for fully supporting cascading expectations files
2565         and removing the 'overrides' concept.
2566
2567         There should be no functional changes in this patch.
2568
2569         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2570         (ManagerTest.test_update_summary_with_result):
2571         (ResultSummaryTest.get_result_summary):
2572         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2573         (TestExpectations.__init__):
2574         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2575         (parse_exp):
2576         (SkippedTests.check):
2577         (RemoveConfigurationsTest.test_remove):
2578         (test_remove_line):
2579         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2580         (LintTest.test_all_configurations.FakePort.__init__):
2581         (LintTest.test_all_configurations.FakePort.expectations_dict):
2582         (LintTest.test_lint_test_files__errors):
2583         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2584         (test_overrides_are_included_correctly):
2585
2586 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2587
2588         webkitpy: rework the TestExpectations style checker in preparation for the cascade
2589         https://bugs.webkit.org/show_bug.cgi?id=88945
2590
2591         Reviewed by Ojan Vafai.
2592
2593         This patch changes the style checker to call the
2594         TestExpectations parser directly and be oblivious as to what the
2595         port's actual expectations are.
2596
2597         * Scripts/webkitpy/style/checkers/test_expectations.py:
2598         (TestExpectationsChecker.__init__):
2599         (TestExpectationsChecker.check_test_expectations):
2600
2601 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2602
2603         nrwt: restructure the port classes to handle multiple expectations files
2604         https://bugs.webkit.org/show_bug.cgi?id=88944
2605
2606         Reviewed by Ojan Vafai.
2607
2608         This patch restructures the Port classes so that each port
2609         returns a list of TestExpectations files to be used (in a new, public,
2610         expectations_files() method), and the base implementation rolls them
2611         up into the ordered expectations_dict(), which becomes a public
2612         method.
2613
2614         port.path_to_test_expectations_file(), port.test_expectations(),
2615         and port.test_expectations_overrides() are then reimplemented as
2616         wrappers around port.expectations_dict().
2617         port.test_expectations() and port.test_expectations_overrides()
2618         will eventually be removed when the cascade is fully completed,
2619         and port.path_to_test_expectations_file() will be removed when
2620         the rebaselining tool supports the cascade
2621         (expectations_files() may also become private at that point).
2622
2623         There should be no functional changes in this patch, but a bunch
2624         of custom logic gets deleted!
2625
2626         * Scripts/webkitpy/layout_tests/port/base.py:
2627         (Port.expectations_dict):
2628         (Port):
2629         (Port.expectations_files):
2630         (Port.test_expectations):
2631         (Port.test_expectations_overrides):
2632         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2633         (PortTest.test_additional_expectations):
2634         (PortTest.test_uses_test_expectations_file):
2635         * Scripts/webkitpy/layout_tests/port/chromium.py:
2636         (ChromiumPort.all_baseline_variants):
2637         (ChromiumPort.expectations_files):
2638         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2639         (ChromiumPortTest.test_overrides_and_builder_names):
2640         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2641         (_expectations_files):
2642         (GoogleChromeLinux32Port.expectations_files):
2643         (GoogleChromeLinux64Port.expectations_files):
2644         (GoogleChromeMacPort.expectations_files):
2645         (GoogleChromeWinPort.expectations_files):
2646         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2647         (TestGoogleChromePort._verify_expectations_overrides):
2648         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2649         (PortTestCase.test_expectations_ordering):
2650         * Scripts/webkitpy/layout_tests/port/webkit.py:
2651         (WebKitPort._skipped_file_search_paths):
2652         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2653         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2654         (test_rebaseline_updates_expectations_file):
2655         (test_rebaseline_does_not_include_overrides):
2656         (test_rebaseline_expectations):
2657         (test_overrides_are_included_correctly):
2658
2659 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
2660
2661         [WinCairo] Update URL of WinCairoRequirements.zip download.
2662         https://bugs.webkit.org/show_bug.cgi?id=89009
2663
2664         Reviewed by Martin Robinson.
2665
2666         * Tools/Scripts/update-webkit-dependency: Put fallback code
2667         to download a "last update" time from servers that don't properly
2668         report Last-Modified in their HTTP header.
2669         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2670         for the WinCairo build requirements bundle.
2671
2672 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2673
2674         nrwt: preliminary cleanup before supporting cascading expectations files
2675         https://bugs.webkit.org/show_bug.cgi?id=88942
2676
2677         Reviewed by Ojan Vafai.
2678
2679         This change just prepares the TestExpectations parser to get filenames
2680         along with the expectations, and improves the warning messages so that
2681         they contain the filenames along with the line numbers.
2682
2683         There should be no functional changes in this patch.
2684
2685         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2686         (TestExpectationEditorTests.make_parsed_expectation_lines):
2687         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2688         (TestExpectationParser.parse):
2689         (TestExpectationParser.expectation_for_skipped_test):
2690         (TestExpectationParser._tokenize):
2691         (TestExpectationParser._tokenize_list):
2692         (TestExpectationLine):
2693         (TestExpectationsModel.__init__):
2694         (TestExpectationsModel._already_seen_better_match):
2695         (TestExpectations.__init__):
2696         (TestExpectations._shorten_filename):
2697         (TestExpectations._report_warnings):
2698         (TestExpectations._add_skipped_tests):
2699         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2700         (TestExpectationParserTests._tokenize):
2701         (TestExpectationParserTests.test_tokenize_blank):
2702         (TestExpectationParserTests.test_tokenize_missing_colon):
2703         (TestExpectationParserTests.test_tokenize_extra_colon):
2704         (TestExpectationParserTests.test_tokenize_empty_comment):
2705         (TestExpectationParserTests.test_tokenize_comment):
2706         (TestExpectationParserTests.test_tokenize_missing_equal):
2707         (TestExpectationParserTests.test_tokenize_extra_equal):
2708         (TestExpectationParserTests.test_tokenize_valid):
2709         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2710         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2711         (TestExpectationParserTests.test_parse_empty_string):
2712         (TestExpectationSerializerTests._tokenize):
2713         (TestExpectationSerializerTests.assert_round_trip):
2714         (TestExpectationSerializerTests.assert_list_round_trip):
2715         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2716         (GardeningExpectationsUpdater.update_expectations):
2717
2718 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2719
2720         [Gtk] Enable link prefetch support in the developer builds
2721         https://bugs.webkit.org/show_bug.cgi?id=89011
2722
2723         Reviewed by Martin Robinson.
2724
2725         Enable the link prefetch support for Gtk by default in developer
2726         builds.
2727
2728         * Scripts/webkitperl/FeatureList.pm:
2729
2730 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2731
2732         Update buildbot master in autoinstaller to match build.webkit.org
2733         https://bugs.webkit.org/show_bug.cgi?id=88992
2734
2735         Reviewed by Adam Barth.
2736
2737         * Scripts/webkitpy/thirdparty/__init__.py:
2738         (AutoinstallImportHook._install_buildbot):
2739
2740 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2741
2742         Unreviewed, rolling out r120209.
2743         http://trac.webkit.org/changeset/120209
2744         https://bugs.webkit.org/show_bug.cgi?id=89007
2745
2746         Broke the WebKit2 mac build. (Requested by andersca on
2747         #webkit).
2748
2749         * MiniBrowser/mac/BrowserWindowController.m:
2750         (-[BrowserWindowController awakeFromNib]):
2751         * WebKitTestRunner/TestController.cpp:
2752         (WTR::TestController::initialize):
2753
2754 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2755
2756         check-webkit-style needs to respect Qt API coding style
2757         https://bugs.webkit.org/show_bug.cgi?id=88995
2758
2759         Reviewed by Csaba Osztrogonác.
2760
2761         Add -whitespace/declaration exception to Qt API files.
2762
2763         * Scripts/webkitpy/style/checker.py:
2764
2765 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2766
2767         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2768         https://bugs.webkit.org/show_bug.cgi?id=88340
2769
2770         Reviewed by Kenneth Rohde Christiansen.
2771
2772         Update initialization of WKPageLoaderClient.
2773
2774         * MiniBrowser/mac/BrowserWindowController.m:
2775         (-[BrowserWindowController awakeFromNib]):
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::TestController::initialize):
2778
2779 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2780
2781         [Qt] Handle multiple held buttons in touch mocking.
2782         https://bugs.webkit.org/show_bug.cgi?id=88865
2783
2784         Reviewed by Kenneth Rohde Christiansen.
2785
2786         Add handling for multiple held mouse-buttons in the appropiate places.
2787         To do this last-pos and start-pos are now also read from the last recorded
2788         touch-point instead from object-global variables.
2789
2790         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2791         (MiniBrowserApplication::notify):
2792         (MiniBrowserApplication::updateTouchPoint):
2793         * MiniBrowser/qt/MiniBrowserApplication.h:
2794         (MiniBrowserApplication):
2795
2796 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2797
2798         [Qt] Make it possible to disable -Werror in production builds
2799
2800         Reviewed by Tor Arne Vestbø.
2801
2802         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2803         something qt5.git's qtwebkit.pri will soon do.
2804
2805         * qmake/mkspecs/features/unix/default_post.prf:
2806
2807 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2808
2809         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2810         https://bugs.webkit.org/show_bug.cgi?id=85790
2811
2812         Reviewed by Gustavo Noronha Silva.
2813
2814         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2815         code in webkitdirs.pm.
2816
2817         * Scripts/webkitdirs.pm:
2818         (jhbuildConfigurationChanged):
2819         (saveJhbuildMd5):
2820         (cleanJhbuild):
2821         (buildAutotoolsProject):
2822         (generateBuildSystemFromCMakeProject):
2823
2824 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2825
2826         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2827         https://bugs.webkit.org/show_bug.cgi?id=88763
2828
2829         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2830         extension.
2831
2832         Reviewed by Simon Hausmann.
2833
2834         * qmake/config.tests/libzlib: Added.
2835         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2836         (main):
2837         * qmake/config.tests/libzlib/libzlib.pro: Added.
2838         * qmake/mkspecs/features/features.prf:
2839         * qmake/sync.profile:
2840
2841 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2842
2843         [BlackBerry] Enable MEDIA_STREAM by default
2844         https://bugs.webkit.org/show_bug.cgi?id=88849
2845
2846         Reviewed by Antonio Gomes.
2847
2848         * Scripts/webkitperl/FeatureList.pm:
2849
2850 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2851
2852         Prevent stderr output from messing up detection of build path
2853
2854         https://bugs.webkit.org/show_bug.cgi?id=88075
2855
2856         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2857         end up as the build path when calling out to webkit-build-directory.
2858
2859         Reviewed by Ojan Vafai.
2860
2861         * Scripts/webkitpy/layout_tests/port/config.py:
2862         (Config.build_directory):
2863
2864 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2865
2866         Update the builder name for Apple Lion builders.
2867
2868         * Scripts/webkitpy/layout_tests/port/builders.py:
2869
2870 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2871
2872         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2873         https://bugs.webkit.org/show_bug.cgi?id=88874
2874
2875         Reviewed by Simon Hausmann.
2876
2877         Rename main.cpp in QtTestBrowser because on Windows
2878         it conflicts with main.cpp from DumpRenderTree.
2879
2880         * QtTestBrowser/QtTestBrowser.pro:
2881         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2882         (launcherMain):
2883         (LauncherApplication):
2884         (LauncherApplication::urls):
2885         (LauncherApplication::isRobotized):
2886         (LauncherApplication::robotTimeout):
2887         (LauncherApplication::robotExtraTime):
2888         (LauncherApplication::applyDefaultSettings):
2889         (LauncherApplication::LauncherApplication):
2890         (requiresGraphicsView):
2891         (LauncherApplication::handleUserOptions):
2892         (main):
2893
2894 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2895
2896         Wrap bot types inside ().
2897         https://bugs.webkit.org/show_bug.cgi?id=88893
2898         
2899         Reviewed by Stephanie Lewis.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/config.json:
2902
2903 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2904
2905         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2906         https://bugs.webkit.org/show_bug.cgi?id=88760
2907
2908         Reviewed by Gustavo Noronha Silva.
2909
2910         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2911         to v2.33.2 for both GTK and EFL ports.
2912
2913         * efl/jhbuild.modules:
2914         * gtk/jhbuild.modules:
2915
2916 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2917
2918         [EFL] Enable SHADOW_DOM flag
2919         https://bugs.webkit.org/show_bug.cgi?id=87732
2920
2921         Reviewed by Kentaro Hara.
2922
2923         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2924         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2925         SHADOW_DOM by default in DRT.
2926         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2927         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2928         Chromium and Mac ports.
2929         (drtViewAdd):
2930         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2931         at compile time for EFL port.
2932
2933 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2934
2935         WinLauncher should show loading errors
2936         https://bugs.webkit.org/show_bug.cgi?id=80760
2937
2938         Reviewed by Brent Fulgham.
2939
2940         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2941         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2942         * WinLauncher/WinLauncher.h:
2943         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2944         (WinLauncherWebHost):
2945
2946 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2947
2948         [EFL][WK2] Add MiniBrowserEfl.
2949         https://bugs.webkit.org/show_bug.cgi?id=61850
2950
2951         Reviewed by Chang Shu.
2952
2953         Implement MiniBrowser for EFL.
2954
2955         * CMakeLists.txt:
2956         * MiniBrowser/efl/CMakeLists.txt: Added.
2957         * MiniBrowser/efl/main.c: Added.
2958         (_MiniBrowser):
2959         (main_signal_exit):
2960         (on_ecore_evas_resize):
2961         (browserCreate):
2962         (main):
2963
2964 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2965
2966         Unreviewed. Update my email address in committers.py.
2967
2968         * Scripts/webkitpy/common/config/committers.py:
2969
2970 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2971
2972         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2973         https://bugs.webkit.org/show_bug.cgi?id=84707
2974
2975         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2976         use_lib64 variable is preconfigured to True by jhbuild.
2977
2978         Reviewed by Dirk Pranke.
2979
2980         * efl/jhbuildrc:
2981
2982 2012-06-12  Dana Jansens  <danakj@chromium.org>
2983
2984         Add zlieber@chromium.org to contributors list
2985         https://bugs.webkit.org/show_bug.cgi?id=88904
2986
2987         Unreviewed.
2988
2989         * Scripts/webkitpy/common/config/committers.py:
2990
2991 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2992
2993         Rename Apple bots to a standard convention.
2994         https://bugs.webkit.org/show_bug.cgi?id=88893
2995         
2996         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2997
2998         Reviewed by Simon Fraser.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/config.json:
3001
3002 2012-06-12  Mike West  <mkwst@chromium.org>
3003
3004         Make document.documentURI readonly from JavaScript
3005         https://bugs.webkit.org/show_bug.cgi?id=65187
3006
3007         Reviewed by Alexey Proskuryakov.
3008
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
3011         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
3012         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
3013         (TestWebKitAPI):
3014         (TestWebKitAPI::TEST):
3015
3016 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
3017
3018         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
3019         https://bugs.webkit.org/show_bug.cgi?id=88715
3020
3021         Reviewed by Noam Rosenthal.
3022
3023         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
3024
3025         * Scripts/webkitperl/FeatureList.pm:
3026
3027 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3028
3029         [Qt] Fix -Werror for the buildbots
3030         https://bugs.webkit.org/show_bug.cgi?id=88223
3031
3032         Rubber-stamped by Tor Arne Vestbø.
3033
3034         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
3035
3036         * qmake/mkspecs/features/unix/default_post.prf:
3037
3038 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
3039
3040         [REGRESSION][WTR] Build fail with werror after r120054
3041         https://bugs.webkit.org/show_bug.cgi?id=88862
3042
3043         Reviewed by Csaba Osztrogonác.
3044
3045         Some static helpers become unused after counterValueForElementById
3046         has moved to Internals. Let's remove them.
3047
3048         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3049         (WTR):
3050
3051 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3052
3053         [Qt] Slave losts cause build break on bots
3054         https://bugs.webkit.org/show_bug.cgi?id=38980
3055
3056         Minor fix after r59261.
3057
3058         Reviewed by Tor Arne Vestbø.
3059
3060         * Scripts/build-webkit:
3061         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
3062
3063 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3064
3065         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
3066         https://bugs.webkit.org/show_bug.cgi?id=84406
3067
3068         Reviewed by Hajime Morita.
3069
3070         Move the counterValueForElementById from LayoutTestCotroller to Internals and
3071         remove the old platform specific implementations as it exclusively tests WebCore functionality.
3072
3073         * DumpRenderTree/LayoutTestController.cpp:
3074         (LayoutTestController::staticFunctions):
3075         * DumpRenderTree/LayoutTestController.h:
3076         (LayoutTestController):
3077         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3078         * DumpRenderTree/chromium/LayoutTestController.cpp:
3079         (LayoutTestController::LayoutTestController):
3080         (LayoutTestController::setPOSIXLocale):
3081         * DumpRenderTree/chromium/LayoutTestController.h:
3082         (LayoutTestController):
3083         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3084         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3085         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3087         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3088         (LayoutTestController):
3089         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3090         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3091         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3092         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3093         (WTR):
3094         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3095         (LayoutTestController):
3096
3097 2012-06-11  Hans Wennborg  <hans@chromium.org>
3098
3099         Speech JavaScript API: Make SpeechRecognitionError an Event
3100         https://bugs.webkit.org/show_bug.cgi?id=88784
3101
3102         Reviewed by Adam Barth.
3103
3104         Make it possible to have MockWebSpeechRecognizer fire error events.
3105
3106         * DumpRenderTree/chromium/LayoutTestController.cpp:
3107         (LayoutTestController::LayoutTestController):
3108         (LayoutTestController::setMockSpeechRecognitionError):
3109         * DumpRenderTree/chromium/LayoutTestController.h:
3110         (LayoutTestController):
3111         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
3112         (WebKit):
3113         (ErrorTask):
3114         (WebKit::ErrorTask::ErrorTask):
3115         (MockWebSpeechRecognizer::addMockResult):
3116         (MockWebSpeechRecognizer::setError):
3117         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3118         (MockWebSpeechRecognizer):
3119
3120 2012-06-11  Ojan Vafai  <ojan@chromium.org>
3121
3122         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
3123         https://bugs.webkit.org/show_bug.cgi?id=88836
3124
3125         Reviewed by Dirk Pranke.
3126
3127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3129
3130 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
3131
3132         [EFL] Remove CMakeCache.txt before building
3133         https://bugs.webkit.org/show_bug.cgi?id=88717
3134
3135         Reviewed by Antonio Gomes.
3136
3137         Remove CMake cache file before every build to avoid using outdated
3138         build flags when new features get enabled. This will avoid unexpected
3139         failures on the bots due to outdated build flags.
3140
3141         * Scripts/webkitdirs.pm:
3142         (generateBuildSystemFromCMakeProject):
3143
3144 2012-06-11  Vincent Scheib  <scheib@chromium.org>
3145
3146         Add new Pointer Lock spec attribute webkitPointerLockElement.
3147         https://bugs.webkit.org/show_bug.cgi?id=88799
3148
3149         Reviewed by Dimitri Glazkov.
3150
3151         Part of a series of refactoring changes to update pointer lock API to
3152         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
3153
3154         New attribute webkitPointerLockElement added. Follow up patches
3155         will remove the previous isLocked attribute. Tests updated to use
3156         the new attribute.
3157
3158         WebViewHost logic required modification to correctly repond to
3159         a lock, unlock, pointerLockElement call series. Specifically,
3160         unlocking must be queued after a lock command is issued always
3161         as the lock state may not be set yet with a lock request in flight.
3162
3163         * DumpRenderTree/chromium/WebViewHost.cpp:
3164         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
3165         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
3166
3167 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
3168
3169         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
3170         https://bugs.webkit.org/show_bug.cgi?id=88804
3171
3172         Reviewed by Tony Chang.
3173
3174         Protect box-decoration-break behind a feature flag enabled by default.
3175
3176         * Scripts/webkitperl/FeatureList.pm:
3177         * qmake/mkspecs/features/features.pri:
3178
3179 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3180
3181         [CMAKE][EFL] Remove duplicated executable output path
3182         https://bugs.webkit.org/show_bug.cgi?id=88765
3183
3184         Reviewed by Daniel Bates.
3185
3186         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
3187         need to define again because it is already defined in top-level CMake file.
3188
3189         * DumpRenderTree/efl/CMakeLists.txt:
3190         * EWebLauncher/CMakeLists.txt:
3191
3192 2012-06-11  Ojan Vafai  <ojan@chromium.org>
3193
3194         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
3195         https://bugs.webkit.org/show_bug.cgi?id=88816
3196
3197         Reviewed by Dirk Pranke.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3200         Expose a way to clear AsynchronousCaches.
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3203         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
3204
3205 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
3206
3207         nrwt exits early too frequently
3208         https://bugs.webkit.org/show_bug.cgi?id=73843
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         Change the defaults for new-run-webkit-tests for both
3213         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
3214         to zero (i.e., we will never exit early by default).
3215
3216         If people want their buildbots to exit early it is their
3217         responsibility to update their buildbot configs appropriately.
3218
3219         Note that we have tests that ensure that these flags work for
3220         non-zero numbers, but we don't have tests that either test the
3221         default or ensure that zero means "run all of the tests". I
3222         think that's okay but can add tests if others disagree.
3223
3224         Also note that it looks like no changes on the build.webkit.org
3225         master.cfg are necessary; all of the bots seem to be using the
3226         RunWebKitTests wrapper which is already setting the flags. There
3227         is a NewRunWebKitTests wrapper, but that looks to be unused; I
3228         will delete that in a separate patch.
3229
3230         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3231         (parse_args):
3232
3233 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3234
3235         [EFL] [DRT] Reset CacheModel before running each test
3236         https://bugs.webkit.org/show_bug.cgi?id=87534
3237
3238         Reviewed by Gustavo Noronha Silva.
3239
3240         Reset cache model to default before running each test to fix some
3241         flaky tests on EFL build bots. Also fix case value in setCacheModel.
3242
3243         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3244         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3245         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3246         (LayoutTestController::setCacheModel):
3247
3248 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3249
3250         [GTK] Memory leaks in DRT EventSender.cpp
3251         https://bugs.webkit.org/show_bug.cgi?id=88774
3252
3253         Reviewed by Martin Robinson.
3254
3255         Fix a few possible memory leaks in EventSender code.
3256
3257         * DumpRenderTree/gtk/EventSender.cpp:
3258         (contextClickCallback): Free the event returned by gdk_event_new().
3259         (mouseDownCallback): Ditto.
3260         (mouseUpCallback): Ditto.
3261
3262 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3263
3264         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
3265         https://bugs.webkit.org/show_bug.cgi?id=88661
3266
3267         Reviewed by Dirk Pranke.
3268
3269         Pass string length explicitly when creating String object from
3270         non-null-terminated UChar* returned by characters().
3271
3272         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3273         (LayoutTestController::pathToLocalResource):
3274
3275 2012-06-11  David Dorwin  <ddorwin@chromium.org>
3276
3277         [chromium] Provide access to the WebPlugin created by the helper plugin widget
3278         https://bugs.webkit.org/show_bug.cgi?id=88028
3279
3280         Reviewed by Adam Barth.
3281
3282         Added isPlaceholder() to WebPlugin.
3283
3284         * DumpRenderTree/chromium/TestWebPlugin.h:
3285         (TestWebPlugin::isPlaceholder):
3286
3287 2012-06-11  Tony Chang  <tony@chromium.org>
3288
3289         rebaseline from garden-o-matic leaves N processes each time it is run
3290         https://bugs.webkit.org/show_bug.cgi?id=88586
3291
3292         Reviewed by Dirk Pranke.
3293
3294         This appears to only be a problem on python 2.7. Maybe a bug causing
3295         pools to not be garbage collected?
3296
3297         * Scripts/webkitpy/common/system/executive.py:
3298         (Executive.run_in_parallel): close() and join() the process pool.
3299         * Scripts/webkitpy/common/system/executive_unittest.py:
3300         (ExecutiveTest.test_run_in_parallel):
3301
3302 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
3303
3304         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
3305         https://bugs.webkit.org/show_bug.cgi?id=87841
3306
3307         Reviewed by Simon Hausmann.
3308
3309         * qmake/config.tests/libwebp/libwebp.cpp: Added.
3310         (main):
3311         * qmake/config.tests/libwebp/libwebp.pro: Added.
3312         * qmake/sync.profile:
3313
3314 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
3315
3316         Expose layoutTestController as testRunner
3317         https://bugs.webkit.org/show_bug.cgi?id=88210
3318
3319         Reviewed by Darin Adler.
3320
3321         * DumpRenderTree/LayoutTestController.cpp:
3322         (LayoutTestController::makeWindowObject):
3323         * DumpRenderTree/chromium/TestShell.cpp:
3324         (TestShell::bindJSObjectsToWindow):
3325         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3326         (WebCore::DumpRenderTree::initJSObjects):
3327         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3328         (WTR::LayoutTestController::makeWindowObject):
3329
3330 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
3331
3332         [Chromium] Remove JavaScriptCore dependencies from gyp
3333         https://bugs.webkit.org/show_bug.cgi?id=88510
3334
3335         Reviewed by Adam Barth.
3336
3337         Chromium doesn't support JSC any more and there doesn't seem to be
3338         a strong interest in using GYP as the common build system in other
3339         ports.
3340
3341         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3342         * Scripts/generate-project-files: Removed.
3343
3344 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
3345
3346         Add UNDO_MANAGER flag
3347         https://bugs.webkit.org/show_bug.cgi?id=87908
3348
3349         Reviewed by Tony Chang.
3350
3351         * Scripts/webkitperl/FeatureList.pm:
3352         * qmake/mkspecs/features/features.pri:
3353
3354 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3355
3356         webkit-patch land-safely should set cq? if the patch author is not in committers.py
3357         https://bugs.webkit.org/show_bug.cgi?id=88689
3358
3359         Reviewed by Dirk Pranke.
3360
3361         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
3362         in committers.py or the contributor cannot commit. If anything, the contributor can still
3363         set cq+ on thier patches manually so I don't think this will be an issue for people who
3364         don't list their Bugzille email on committers.py.
3365
3366         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3367         (Bugzilla._commit_queue_flag):
3368         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3369         (test_commit_queue_flag):
3370         (test_commit_queue_flag.assert_commit_queue_flag):
3371
3372 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
3373
3374         remove obsolete NewRunWebKitTests buildbot master factory classes
3375         https://bugs.webkit.org/show_bug.cgi?id=88693
3376
3377         Reviewed by Ryosuke Niwa.
3378
3379         I believe these aren't used any more ...
3380
3381         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3382         (RunWebKitTests.getText2):
3383         (BuildAndTestLeaksFactory):
3384
3385 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3386
3387         [Chromium-Android] Build DumpRenderTree with Android SDK
3388         https://bugs.webkit.org/show_bug.cgi?id=88598
3389
3390         Change WebKit side of DRT related code according to some recent changes at chromium side.
3391
3392         Reviewed by Adam Barth.
3393
3394         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3395         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3396         (ChromiumAndroidPort.__init__):
3397         (ChromiumAndroidPort._path_to_driver):
3398
3399 2012-06-08  Wei James  <james.wei@intel.com>
3400
3401         Add app_abi option for DumpRenderTree_apk
3402         https://bugs.webkit.org/show_bug.cgi?id=88626
3403
3404         Reviewed by Adam Barth.
3405
3406         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3407
3408 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3409
3410         [GTK] Add API to get the library version to WebKit2 GTK+
3411         https://bugs.webkit.org/show_bug.cgi?id=88426
3412
3413         Reviewed by Martin Robinson.
3414
3415         * gtk/generate-gtkdoc:
3416         (get_webkit2_options): Add built sources to the list of files, but
3417         ignore enum types and marshallers.
3418
3419 2012-06-07  Vincent Scheib  <scheib@chromium.org>
3420
3421         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
3422         https://bugs.webkit.org/show_bug.cgi?id=88604
3423
3424         Reviewed by Kent Tamura.
3425
3426         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
3427         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
3428
3429         * DumpRenderTree/chromium/WebViewHost.cpp:
3430         (WebViewHost::requestPointerUnlock):
3431
3432 2012-06-08  Hans Wennborg  <hans@chromium.org>
3433
3434         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
3435         https://bugs.webkit.org/show_bug.cgi?id=87976
3436
3437         Reviewed by Kent Tamura.
3438
3439         Provide a mock implementation of WebSpeechRecognizer for
3440         DumpRenderTree. This will allow better testing of the API via layout
3441         tests.
3442
3443         * DumpRenderTree/DumpRenderTree.gypi:
3444         * DumpRenderTree/chromium/LayoutTestController.cpp:
3445         (LayoutTestController::LayoutTestController):
3446         (LayoutTestController::addMockSpeechRecognitionResult):
3447         * DumpRenderTree/chromium/LayoutTestController.h:
3448         (LayoutTestController):
3449         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
3450         (MockWebSpeechRecognizer::create):
3451         (MockWebSpeechRecognizer::start):
3452         (MockWebSpeechRecognizer::stop):
3453         (MockWebSpeechRecognizer::abort):
3454         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3455         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3456         (MockWebSpeechRecognizer::ResultTask::runIfValid):
3457         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
3458         (WebKit):
3459         (MockWebSpeechRecognizer):
3460         (MockWebSpeechRecognizer::addMockResult):
3461         (MockWebSpeechRecognizer::taskList):
3462         (ClientCallTask):
3463         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
3464         (ResultTask):
3465         (MockWebSpeechRecognizer::ResultTask::ResultTask):
3466         (NoMatchTask):
3467         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
3468         * DumpRenderTree/chromium/WebViewHost.cpp:
3469         (WebViewHost::speechRecognizer):
3470         * DumpRenderTree/chromium/WebViewHost.h:
3471         (WebViewHost):
3472         (WebViewHost::mockSpeechRecognizer):
3473
3474 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
3475
3476         check-webkit-style needs to be taught about <public/Foo.h>
3477         https://bugs.webkit.org/show_bug.cgi?id=88524
3478
3479         Reviewed by David Levin.
3480
3481         * Scripts/webkitpy/style/checkers/cpp.py:
3482         (_classify_include):
3483         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3484         (OrderOfIncludesTest.test_public_primary_header):
3485         (OrderOfIncludesTest.test_classify_include):
3486
3487 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
3488
3489         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3490         https://bugs.webkit.org/show_bug.cgi?id=67255
3491
3492         Reviewed by Dirk Pranke.
3493
3494         Implement pathToLocalResource to redirect file:///tmp URL's to
3495         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
3496         LayoutTests sub-directory of the WebKit source tree.
3497
3498         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3499         (LayoutTestController::pathToLocalResource):
3500
3501 2012-06-07  Tony Payne  <tpayne@chromium.org>
3502
3503         [chromium] Allow LayoutTests under new git workflow
3504         https://bugs.webkit.org/show_bug.cgi?id=88575
3505
3506         On Windows, chromium indirects through git.bat. Adds the same hack that
3507         is currently used for discovering svn.bat to support the new git
3508         workflow.
3509
3510         Reviewed by Dirk Pranke.
3511
3512         * Scripts/webkitpy/common/checkout/scm/git.py:
3513         (Git): Replaces all hard-coded references to 'git' with the class
3514         variable executable_name.
3515         (Git._check_git_architecture):
3516         (Git.in_working_directory):
3517         (Git.find_checkout_root):
3518         (Git.read_git_config):
3519         (Git.discard_local_commits):
3520         (Git.local_commits):
3521         (Git.working_directory_is_clean):
3522         (Git.clean_working_directory):
3523         (Git.status_command):
3524         (Git.add_list):
3525         (Git.delete_list):
3526         (Git.exists):
3527         (Git._current_branch):
3528         (Git.changed_files):
3529         (Git._changes_files_for_commit):
3530         (Git.revisions_changing_file):
3531         (Git.conflicted_files):
3532         (Git.svn_revision):
3533         (Git.create_patch):
3534         (Git._run_git_svn_find_rev):
3535         (Git.contents_at_revision):
3536         (Git.diff_for_file):
3537         (Git.show_head):
3538         (Git.committer_email_for_revision):
3539         (Git.apply_reverse_diff):
3540         (Git.revert_files):
3541         (Git.commit_with_message):
3542         (Git._commit_on_branch):
3543         (Git.svn_commit_log):
3544         (Git.last_svn_commit_log):
3545         (Git.svn_blame):
3546         (Git._branch_ref_exists):
3547         (Git.delete_branch):
3548         (Git.remote_merge_base):
3549         (Git.commit_locally_with_message):
3550         (Git.push_local_commits_to_server):
3551         (Git.commit_ids_from_commitish_arguments):
3552         (Git.commit_message_for_local_commit):
3553         (Git.files_changed_summary_for_commit):
3554         * Scripts/webkitpy/common/host.py:
3555         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
3556         that duplicates the logic in the existing 'svn.bat' hack.
3557
3558 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3559
3560         Style build architectures like build versions for non-layout test failures
3561         https://bugs.webkit.org/show_bug.cgi?id=88590
3562
3563         Reviewed by Tony Chang.
3564
3565         Since we show the list of failing tests after the architecture, we want the
3566         buildtype and architecture to be grouped together visually.
3567
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3569         (.effects a.failing-builder>span.architecture):
3570
3571 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3572
3573         [Chromium] Remove header dependency of ImageDiff to WTF
3574         https://bugs.webkit.org/show_bug.cgi?id=88422
3575
3576         Reviewed by Ryosuke Niwa.
3577
3578         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3579         * DumpRenderTree/chromium/ImageDiff.cpp:
3580         (untestedCompareImages):
3581
3582 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
3583
3584         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
3585         https://bugs.webkit.org/show_bug.cgi?id=88491
3586
3587         Reviewed by Dirk Pranke.
3588
3589         DRT should enable WebAudio when WebAudio feature is enabled,
3590         so that the WebAudio feature could be tested by the Layouttest.
3591
3592         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
3593         (LayoutTestController::overridePreference):
3594
3595 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3596
3597         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
3598         https://bugs.webkit.org/show_bug.cgi?id=88581
3599
3600         Reviewed by Ojan Vafai.
3601
3602         webkit-paptch rebaseline-expectations was ignoring what the
3603         expected results for a test were and pulling down all the result
3604         files from a bot. This could lead to us pulling down old,
3605         incorrect .txt or .png files. With this patch we will now only
3606         pull down expectations of the appropriate file types (so an
3607         IMAGE failure will only pull the png and not the txt file).
3608
3609         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3610         (has_pixel_failures):
3611         (suffixes_for_expectations):
3612         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3613         (FunctionsTest.test_suffixes_for_expectations):
3614         * Scripts/webkitpy/tool/commands/rebaseline.py:
3615         (AbstractRebaseliningCommand.__init__):
3616         (RebaselineExpectations._is_supported_port):
3617         (RebaselineExpectations._update_expectations_file):
3618         (RebaselineExpectations._tests_to_rebaseline):
3619         (RebaselineExpectations._rebaseline_port):
3620         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3621         (test_overrides_are_included_correctly):
3622
3623 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3624
3625         Fix recent null pointer error regression in the flakiness dashboard
3626         https://bugs.webkit.org/show_bug.cgi?id=88573
3627
3628         Reviewed by Dirk Pranke.
3629
3630         * TestResultServer/static-dashboards/builders.js:
3631         (requestBuilderList):
3632         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3633
3634 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
3635
3636         Add Konrad Piascik to committers.py
3637         https://bugs.webkit.org/show_bug.cgi?id=88560
3638
3639         Unreviewed.
3640
3641         * Scripts/webkitpy/common/config/committers.py:
3642
3643 2012-06-07  Tony Chang  <tony@chromium.org>
3644
3645         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
3646         https://bugs.webkit.org/show_bug.cgi?id=77368
3647
3648         Reviewed by Ojan Vafai.
3649
3650         It doesn't look like we ever get a rect with width or height of 0.
3651         I ran css1, css2.1, fast/forms, and tables without any crashes.
3652
3653         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3654         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
3655
3656 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3657
3658         run-webkit-tests --lint-test-files gives an error when run on linux
3659         https://bugs.webkit.org/show_bug.cgi?id=88551
3660
3661         Reviewed by Ojan Vafai.
3662
3663         We weren't mapping the expectations properly for the
3664         google-chrome ports.
3665
3666         * Scripts/webkitpy/layout_tests/port/base.py:
3667         (Port.path_to_test_expectations_file):
3668         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3669         (TestGoogleChromePort.test_path_to_expectations):
3670
3671 2012-06-07  Daniel Erat  <derat@chromium.org>
3672
3673         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
3674         https://bugs.webkit.org/show_bug.cgi?id=88263
3675
3676         Reviewed by Tony Chang.
3677
3678         * DumpRenderTree/chromium/LayoutTestController.cpp:
3679         (LayoutTestController::LayoutTestController):
3680         (LayoutTestController::reset):
3681         (LayoutTestController::setTextSubpixelPositioning):
3682         * DumpRenderTree/chromium/LayoutTestController.h:
3683         (LayoutTestController):
3684         * DumpRenderTree/chromium/fonts.conf:
3685
3686 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
3687
3688         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
3689         https://bugs.webkit.org/show_bug.cgi?id=88060
3690
3691         Reviewed by Martin Robinson.
3692
3693         Spin the main loop before acquiring the pixel content. This ensures things
3694         like late size allocations are finished before calling gtk_widget_draw,
3695         avoiding assertions and subsequent empty pixel results.
3696
3697         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3698         (createBitmapContextFromWebView):
3699
3700 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3701
3702         [Qt] Improve the visual of the viewport info box
3703         https://bugs.webkit.org/show_bug.cgi?id=88410
3704
3705         Reviewed by Tor Arne Vestbø.
3706
3707         Improve the visual and make it possible to see the content more easy.
3708
3709         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3710
3711 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3712
3713         [EFL][WK2] Compile webkit1 and webkit2 by default.
3714         https://bugs.webkit.org/show_bug.cgi?id=85041
3715
3716         Reviewed by Chang Shu.
3717
3718         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3719         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3720
3721         * Scripts/build-webkit:
3722
3723 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3724
3725         Unreviewed, rolling out r119662.
3726         http://trac.webkit.org/changeset/119662
3727         https://bugs.webkit.org/show_bug.cgi?id=88487
3728
3729         Broke builds (Requested by rniwa on #webkit).
3730
3731         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3732         * DumpRenderTree/chromium/ImageDiff.cpp:
3733         (untestedCompareImages):
3734
3735 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3736
3737         [Chromium] Remove header dependency of ImageDiff to WTF
3738         https://bugs.webkit.org/show_bug.cgi?id=88422
3739
3740         Reviewed by Adam Barth.
3741
3742         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3743         * DumpRenderTree/chromium/ImageDiff.cpp:
3744         (untestedCompareImages):
3745
3746 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3747
3748         [WebKit] DeviceOrientation cleanup
3749         https://bugs.webkit.org/show_bug.cgi?id=88406
3750
3751         Reviewed by Kent Tamura.
3752
3753         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3754
3755         * DumpRenderTree/chromium/LayoutTestController.cpp:
3756         (LayoutTestController::setMockDeviceOrientation):
3757
3758 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3759
3760         webkitpy: add support for an ordered dict of test expectations
3761         https://bugs.webkit.org/show_bug.cgi?id=87802
3762
3763         Reviewed by Ojan Vafai.
3764
3765         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3766         support a cascaded list of test expectations files. An easy way
3767         to think of this is as an ordered dictionary of name -> contents
3768         for files, where the name is usually a path on disk (I say
3769         usually because we want to support other kinds of expectations
3770         like the compile-time skips for unsupported features in
3771         webkit.py, and we want to continue to support "in-memory" test
3772         expectations that don't require a filesystem).
3773
3774         Conveniently there is an OrderedDict implementation in Python
3775         2.7+ and it is available as a backport, so the first step in
3776         adding this support is to use that implementation. Subsequent
3777         patches will update the test_expectations.py module (and other
3778         callers) to access the dict directly.
3779
3780         This patch just changes the base internal implementation and
3781         provides wrappers for compatibility. The derived ports
3782         (WebKitPort, TestPort, etc.) still need to be updated.
3783
3784         * Scripts/webkitpy/layout_tests/port/base.py:
3785         (Port._expectations_dict):
3786         (Port.test_expectations):
3787         (Port):
3788         (Port._expectations_overrides_dict):
3789         (Port.test_expectations_overrides):
3790         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3791         (PortTestCase.test_expectations_ordering):
3792         (PortTestCase):
3793         (PortTestCase.test_expectations_overrides_ordering):
3794         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3795         (OrderedDict):
3796         (OrderedDict.__init__):
3797         (OrderedDict.clear):
3798         (OrderedDict.__setitem__):
3799         (OrderedDict.__delitem__):
3800         (OrderedDict.__iter__):
3801         (OrderedDict.__reversed__):
3802         (OrderedDict.popitem):
3803         (OrderedDict.__reduce__):
3804         (OrderedDict.__repr__):
3805         (OrderedDict.copy):
3806         (OrderedDict.fromkeys):
3807
3808 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3809
3810         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3811
3812         * gtk/run-api-tests:
3813         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3814
3815 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3816
3817         nrwt should look in 'out' for binaries on chromium win to support ninja
3818         https://bugs.webkit.org/show_bug.cgi?id=88273
3819
3820         Reviewed by Tony Chang.
3821
3822         This patch standardizes the search algorithm the chromium ports
3823         use to figure out which driver to run. We will look in a
3824         chromium location before a webkit location (e.g., in
3825         Source/WebKit/chromium/out before out/) and we will look in the
3826         "legacy" directory (xcodebuild) before the directory ninja uses
3827         (out).
3828
3829         Unfortunately due to the way the test code is set up testing the
3830         properly requires some duplication of test code. I will fix that
3831         in a followup patch.
3832
3833         * Scripts/webkitpy/layout_tests/port/chromium.py:
3834         (ChromiumPort):
3835         (ChromiumPort._static_build_path):
3836         (ChromiumPort._build_path):
3837         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3838         (ChromiumLinuxPort):
3839         (ChromiumLinuxPort._determine_driver_path_statically):
3840         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3841         (ChromiumLinuxPortTest.test_build_path):
3842         (ChromiumLinuxPortTest):
3843         (ChromiumLinuxPortTest.test_driver_name_option):
3844         (ChromiumLinuxPortTest.path_to_image_diff):
3845         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3846         (ChromiumMacPort):
3847         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3848         (ChromiumMacPortTest.test_build_path):
3849         (ChromiumMacPortTest):
3850         (ChromiumMacPortTest.test_driver_name_option):
3851         (ChromiumMacPortTest.path_to_image_diff):
3852         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3853         (ChromiumPortTest.test_overrides_and_builder_names):
3854         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3855         (ChromiumWinPort):
3856         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3857         (ChromiumWinTest.test_build_path):
3858         (ChromiumWinTest.test_operating_system):
3859         (ChromiumWinTest):
3860         (ChromiumWinTest.test_driver_name_option):
3861         (ChromiumWinPortTest.path_to_image_diff):
3862         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3863         (PortTestCase.assert_build_path):
3864
3865 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3866
3867         Remove very red Windows WebKit2 testers
3868         https://bugs.webkit.org/show_bug.cgi?id=88452
3869
3870         Reviewed by Steve Falkenburg.
3871
3872         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3873         need to focus on getting the WK1 testers green.
3874
3875         * BuildSlaveSupport/build.webkit.org-config/config.json:
3876
3877 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3878
3879         get rebaselining tools to kinda work with the skia overrides file
3880         https://bugs.webkit.org/show_bug.cgi?id=88456
3881
3882         Reviewed by Ryosuke Niwa.
3883
3884         Update rebaseline-expectations so that we read in the overrides
3885         when looking for tests to rebaseline, but don't read in the
3886         overrides when we are writing the expectations file back out.
3887         This prevents the overrides from getting written into the main
3888         file. This is kind of a hack but will have to do until we
3889         support multiple expectations files properly.
3890
3891         * Scripts/webkitpy/tool/commands/rebaseline.py:
3892         (RebaselineExpectations._expectations):
3893         (RebaselineExpectations._update_expectations_file):
3894         (RebaselineExpectations._tests_to_rebaseline):
3895         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3896         (test_overrides_are_included_correctly):
3897
3898 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3899
3900         webkitpy: two manager_worker_broker_unittest tests are broken
3901         https://bugs.webkit.org/show_bug.cgi?id=88445
3902
3903         Reviewed by Ojan Vafai.
3904
3905         These tests were never updated when we removed the
3906         --worker-model argument, and we were passing 'inline' instead of
3907         1 (for the number of workers) :(. As a result we were creating
3908         multiprocessing queues unnecessarily and that was failing on cygwin.
3909
3910         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3911         (InterfaceTest.test_managerconnection_is_abstract):
3912         (InterfaceTest.test_workerconnection_is_abstract):
3913
3914 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3915
3916         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3917         https://bugs.webkit.org/show_bug.cgi?id=87406
3918
3919         Reviewed by Dirk Pranke.
3920
3921         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3922         (TestExpectations.__init__):
3923         * Scripts/webkitpy/tool/commands/rebaseline.py:
3924         (RebaselineTest._update_expectations_file):
3925         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3926         (test_rebaseline_does_not_include_overrides):
3927
3928 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3929
3930         webkitpy: perf tests unit tests fail on chromium win
3931         https://bugs.webkit.org/show_bug.cgi?id=88279
3932
3933         Reviewed by Ryosuke Niwa.
3934
3935         I'm seeing weird failures running the unit tests in my win32
3936         checkout, and we don't really expect webpagereplay to work on
3937         win32 anyway, so I'm skipping the import of that module for now
3938         and adding a warning.
3939
3940         * Scripts/run-perf-tests:
3941         * Scripts/webkitpy/performance_tests/perftest.py:
3942
3943 2012-06-06  Yong Li <yoli@rim.com>
3944
3945         Unreviewed. Update my email address in committers.py.
3946
3947         * Scripts/webkitpy/common/config/committers.py:
3948
3949 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3950
3951         Add Robert Kroeger  to commiters.py
3952         https://bugs.webkit.org/show_bug.cgi?id=88415
3953
3954         Unreviewed.
3955
3956         * Scripts/webkitpy/common/config/committers.py:
3957
3958 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3959
3960         [EFL][DRT] http/tests/globalhistory testcases do not pass
3961         https://bugs.webkit.org/show_bug.cgi?id=82579
3962
3963         Reviewed by Csaba Osztrogonác.
3964
3965         DRT has provided callbacks for ewk_view "global history delegate" signals.
3966
3967         * DumpRenderTree/efl/DumpRenderTree.cpp:
3968         (isGlobalHistoryTest): Aux function to ident global history testcase.
3969         (createLayoutTestController):
3970         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3971         (DumpRenderTreeChrome::createView):
3972         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3973         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3974         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3975         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
3976         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
3977         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3978         (DumpRenderTreeChrome):
3979
3980 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
3981
3982         [Qt] run-qtwebkit-tests hangs with -j1
3983         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
3984         This could happen due to an uncancelled timer after results were returned. This timer was
3985         started only if --timeout was set.
3986         https://bugs.webkit.org/show_bug.cgi?id=85475
3987
3988         Reviewed by Csaba Osztrogonác.
3989
3990         * Scripts/run-qtwebkit-tests:
3991         (run_test):
3992
3993 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
3994
3995         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
3996         https://bugs.webkit.org/show_bug.cgi?id=88327
3997
3998         Reviewed by Kenneth Rohde Christiansen.
3999
4000         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
4001         * MiniBrowser/qt/icons/contents_width.png: Added.
4002         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
4003         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
4004
4005 2012-06-05  Jon Lee  <jonlee@apple.com>
4006
4007         Buildbot fix.
4008
4009         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
4010         in the function. Store in a local variable.
4011         (loadBuilderConfig):
4012
4013 2012-06-05  Jon Lee  <jonlee@apple.com>
4014
4015         Buildbot fix.
4016
4017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4018         (loadBuilderConfig):
4019
4020 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
4021
4022         webkitpy: clean up win-specific path handling and tests
4023         https://bugs.webkit.org/show_bug.cgi?id=88281
4024
4025         Reviewed by Adam Barth.
4026
4027         There was a bunch of inconsistent logic for handling path
4028         conversions for win32 and cygwin paths due to us sometimes
4029         looking at sys.platform and sometimes using mock hosts. This
4030         patch cleans everything up so that we are required to pass
4031         PlatformInfo objects to the path module and stop trying to do
4032         different things when running on cygwin or win32 hosts (except
4033         in the path_unittest module itself).
4034
4035         This may slightly reduce test coverage for the win32 code paths
4036         but will be a lot easier to follow and maintain.
4037
4038         * Scripts/webkitpy/common/system/path.py:
4039         (abspath_to_uri):
4040         (_convert_path):
4041         * Scripts/webkitpy/common/system/path_unittest.py:
4042         (AbspathTest.platforminfo):
4043         (AbspathTest.test_abspath_to_uri_cygwin):
4044         (AbspathTest.test_abspath_to_uri_unixy):
4045         (AbspathTest.test_abspath_to_uri_win):
4046         (AbspathTest.test_abspath_to_uri_escaping_unixy):
4047         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
4048         (AbspathTest.test_stop_cygpath_subprocess):
4049         * Scripts/webkitpy/common/system/platforminfo.py:
4050         (PlatformInfo.__init__):
4051         (PlatformInfo.is_cygwin):
4052         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4053         (MockPlatformInfo.is_cygwin):
4054         * Scripts/webkitpy/layout_tests/port/base.py:
4055         (Port.to.show_results_html_file):
4056         * Scripts/webkitpy/layout_tests/port/driver.py:
4057         (Driver.test_to_uri):
4058         (Driver.uri_to_test):
4059         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4060         (DriverTest.test_test_to_uri):
4061         (DriverTest.test_uri_to_test):
4062         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4063         (MockDRTPortTest.make_port):
4064         (MockDRTTest.input_line):
4065         (MockChromiumDRTTest.test_pixeltest__fails):
4066         * Scripts/webkitpy/layout_tests/port/test.py:
4067         * Scripts/webkitpy/layout_tests/port/win.py:
4068         (WinPort.show_results_html_file):
4069         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4070         (MainTest.test_unexpected_failures):
4071         (MainTest.test_results_directory_absolute):
4072         (MainTest.test_results_directory_default):
4073         (MainTest.test_results_directory_relative):
4074
4075 2012-06-05  Jon Lee  <jonlee@apple.com>
4076
4077         Workaround buildbot bug when merging build requests.
4078         https://bugs.webkit.org/show_bug.cgi?id=88158
4079
4080         Reviewed by Mark Rowe.
4081
4082         For expediency, we still want testers to pick the latest build to test, but to ensure
4083         that the builders are reporting the correct revision number, we should let the building bots
4084         run as they normally would. That is, the builder picks the oldest revision, and merges
4085         subsequent requests. Because merged requests get appended to the list of changes for a given
4086         build, the last change in that list is also the latest change. When we used pickLatestBuild
4087         for the builders, this was not the case (it would always report the penultimate change).
4088
4089         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
4092         for all Apple builders.
4093         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
4094         the latest build to run.
4095         (loadBuilderConfig):
4096
4097 2012-06-05  Jessie Berlin  <jberlin@apple.com>
4098
4099         [Win] DumpRenderTree should call resetInternalsObject
4100         https://bugs.webkit.org/show_bug.cgi?id=88346
4101
4102         Reviewed by Simon Fraser.
4103
4104         Invoke it on Windows in the same place it is invoked on Mac.
4105
4106         * DumpRenderTree/win/DumpRenderTree.cpp:
4107         (resetWebViewToConsistentStateBeforeTesting):
4108
4109 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4110
4111         [GTK] Fix two more memory leaks in DRT
4112         https://bugs.webkit.org/show_bug.cgi?id=88255
4113
4114         Reviewed by Martin Robinson.
4115
4116         Fixed memory leaks in GTK's DRT code.
4117
4118         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4119         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
4120         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
4121         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
4122         (createBitmapContextFromWebView): Free the cairo surface.
4123
4124 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
4125
4126         [Qt] Building when a top directory is named Source
4127         https://bugs.webkit.org/show_bug.cgi?id=77727
4128
4129         Reviewed by Tor Arne Vestbø.
4130
4131         Change regex to only replace the last instance of OUT_PWD.
4132
4133         * qmake/mkspecs/features/default_pre.prf:
4134
4135 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
4136
4137         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
4138         https://bugs.webkit.org/show_bug.cgi?id=73176
4139
4140         Reviewed by Adam Barth.
4141
4142         Two more APIs are added in Custom Scheme Handler specification.
4143         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
4144         One is 'isProtocolHandlerRegistered' to query whether the specific URL
4145         is registered or not.
4146         The other is 'unregisterProtocolHandler' to remove the registered URL.
4147
4148         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
4149
4150 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
4151
4152         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
4153         https://bugs.webkit.org/show_bug.cgi?id=83879
4154
4155         Reviewed by Carlos Garcia Campos.
4156
4157         Make minibrowser connect to the new 'permission requests' signal
4158         to allow users handle the Geolocation permission requests.
4159
4160         * MiniBrowser/gtk/BrowserWindow.c:
4161         (geolocationRequestDialogCallback): Callback for the dialog asking
4162         the user for allowing or not geolocation permission requests.
4163         (webViewDecidePermissionRequest): Launch a dialog to ask the user
4164         whether to allow or deny geolocation permission requests.
4165         (browserWindowConstructed): Connect to 'permission-request' signal.
4166
4167 2012-06-04  Chase Phillips  <cmp@google.com>
4168
4169         Make a builder group support+expect multiple loads.
4170         https://bugs.webkit.org/show_bug.cgi?id=88260
4171
4172         Change BuilderGroup to allow expecting multiple
4173         loads.  This allows merging results for a given set
4174         of builders into one group.
4175
4176         Add a test that verifies that the group count
4177         increments correctly based on successful and failed
4178         list loads.
4179
4180         Reviewed by Ojan Vafai.
4181
4182         * TestResultServer/static-dashboards/builders.js:
4183         (BuilderGroup):
4184         (BuilderGroup.prototype.setbuilder):
4185         (BuilderGroup.prototype.append):
4186         (BuilderGroup.prototype.loaded):
4187         (requestBuilderList.xhr.onload):
4188         (requestBuilderList.xhr.onerror):
4189         (onErrorLoadingBuilderList):
4190         (loadBuildersList):
4191         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4192         (test):
4193         * TestResultServer/static-dashboards/run-unittests.html:
4194
4195 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
4196
4197         Python test fix attempt for Chromium Windows.
4198
4199         * Scripts/webkitpy/layout_tests/port/driver.py:
4200         (Driver.uri_to_test):
4201
4202 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
4203
4204         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
4205         https://bugs.webkit.org/show_bug.cgi?id=88243
4206
4207         Reviewed by Adam Barth.
4208
4209         * qmake/mkspecs/features/features.prf:
4210
4211 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
4212
4213         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
4214         https://bugs.webkit.org/show_bug.cgi?id=88280
4215
4216         Unreviewed, build fix.
4217
4218         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
4219         (TestServerProcess.test_basic):
4220
4221 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
4222
4223         test-webkitpy is hanging under cygwin
4224         https://bugs.webkit.org/show_bug.cgi?id=88269
4225
4226         Reviewed by Ryosuke Niwa.
4227
4228         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
4229         so we need to skip any tests that use it.
4230
4231         * Scripts/webkitpy/common/system/executive.py:
4232         (Executive.run_in_parallel):
4233         * Scripts/webkitpy/common/system/executive_unittest.py:
4234         (ExecutiveTest.test_run_in_parallel):
4235
4236 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
4237
4238         test-webkitpy is failing on win32 after r115054
4239         https://bugs.webkit.org/show_bug.cgi?id=88264
4240
4241         Reviewed by Ryosuke Niwa.
4242
4243         The failing http_server test was improperly suppressed (the
4244         tuple was missing a comma, and so wasn't a tuple at all, just a
4245         string) and so we were skipping *all* tests on win32. The right
4246         way to skip a single test is to disable it inside the test
4247         itself.
4248
4249         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4250         (TestHttpServer.test_start_cmd):
4251         * Scripts/webkitpy/test/test_finder.py:
4252         (TestFinder._default_names):
4253         * Scripts/webkitpy/test/main.py:
4254         (Tester.run): Add error message if we don't find any tests to run.
4255         * Scripts/webkitpy/test/main_unittest.py:
4256             
4257
4258 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4259
4260         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
4261         https://bugs.webkit.org/show_bug.cgi?id=88215
4262
4263         Reviewed by Martin Robinson.
4264
4265         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
4266         for newly allocated strings.
4267
4268         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4269         (attributeSetToString):
4270         (AccessibilityUIElement::allAttributes):
4271
4272 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4273
4274         [GTK] Memory leaks in DumpRenderTree.cpp
4275         https://bugs.webkit.org/show_bug.cgi?id=88213
4276
4277         Reviewed by Martin Robinson.
4278
4279         Fixed memory leaks in DumpRenderTree.
4280
4281         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4282         (appendString): Accepts const gchar* as the second argument.
4283         (dumpFramesAsText): Free the string returned by g_strdup_printf().
4284         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
4285
4286 2012-06-04  David Dorwin  <ddorwin@chromium.org>
4287
4288         Enable Chromium media player to instantiate a plugin
4289         https://bugs.webkit.org/show_bug.cgi?id=87399
4290
4291         Reviewed by Kent Tamura.
4292
4293         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
4294
4295         * DumpRenderTree/chromium/WebViewHost.cpp:
4296         (WebViewHost::createPopupMenu):
4297
4298 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
4299
4300         [GTK][WK2] Implement geolocation provider for the GTK port
4301         https://bugs.webkit.org/show_bug.cgi?id=83877
4302
4303         Reviewed by Carlos Garcia Campos.
4304
4305         * gtk/generate-gtkdoc:
4306         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
4307
4308 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4309
4310         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
4311         https://bugs.webkit.org/show_bug.cgi?id=87668
4312
4313         Reviewed by Ryosuke Niwa.
4314
4315         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
4316         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
4317         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
4318
4319         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4320         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4321
4322 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
4323
4324         [EFL] Refactor ewk_view_context_paint code.
4325         https://bugs.webkit.org/show_bug.cgi?id=85588
4326
4327         Reviewed by Hajime Morita.
4328
4329         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
4330
4331 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
4332
4333         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
4334         https://bugs.webkit.org/show_bug.cgi?id=87869
4335
4336         Reviewed by Andreas Kling.
4337
4338         Replace %lld by PRId64 macro to print an int64_t value and silent a
4339         compilation warning on 64-Bit.
4340
4341         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
4342         (onExceededApplicationCacheQuota):
4343
4344 2012-06-03  Varun Jain  <varunjain@google.com>
4345
4346         [chromium] Add new gesture type (two finger tap) that triggers context menu.
4347         https://bugs.webkit.org/show_bug.cgi?id=88173
4348
4349         Reviewed by Adam Barth.
4350
4351         * DumpRenderTree/chromium/EventSender.cpp:
4352         (EventSender::EventSender):
4353         (EventSender::gestureTwoFingerTap):
4354         (EventSender::gestureEvent):
4355         * DumpRenderTree/chromium/EventSender.h:
4356         (EventSender):
4357
4358 2012-06-02  Zeno Albisser  <zeno@webkit.org>
4359
4360         Fix and enable WebGL for WebKit2 on Qt.
4361         https://bugs.webkit.org/show_bug.cgi?id=86214
4362