2011-04-11 George Guo <George.Guo@nokia.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-11  George Guo  <George.Guo@nokia.com>
2
3         Reviewed by Eric Seidel.
4
5         prepare-ChangeLog support email input but -h did not show the option
6         https://bugs.webkit.org/show_bug.cgi?id=58164
7
8         Add email option to -h to improve the usability
9
10         * Scripts/prepare-ChangeLog:
11
12 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
13
14         Reviewed by Eric Carlson.
15
16         Rename MediaControls to MediaControlRootElement.
17         https://bugs.webkit.org/show_bug.cgi?id=58250
18
19         * Scripts/do-webcore-rename: Documented the renaming.
20
21 2011-04-11  Sam Weinig  <sam@webkit.org>
22
23         Fix Windows build.
24
25         * MiniBrowser/win/BrowserView.cpp:
26         (BrowserView::create):
27
28 2011-04-11  Sam Weinig  <sam@webkit.org>
29
30         Reviewed by Anders Carlsson.
31
32         Move focus management out of WebKit via  the UIClient
33         <rdar://problem/8784068>
34         https://bugs.webkit.org/show_bug.cgi?id=58278
35
36         * MiniBrowser/mac/BrowserWindowController.m:
37         (-[BrowserWindowController awakeFromNib]):
38         * WebKitTestRunner/TestController.cpp:
39         (WTR::TestController::createOtherPage):
40         (WTR::TestController::initialize):
41         Add stubs for new UIClient functions.
42
43 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
44
45         Reviewed by Eric Seidel.
46
47         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
48         https://bugs.webkit.org/show_bug.cgi?id=53605
49
50         Add an implementation of the PlainTextController for the GTK+ DRT.
51
52         * DumpRenderTree/gtk/DumpRenderTree.cpp:
53         (addControllerToWindow): Added this helper method.
54         (webViewWindowObjectCleared): Use the new helper to add EventSender
55         and the PlainTextController to the window object.
56         * GNUmakefile.am: Added PlainTextController source files.
57         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
58         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
59         until that functionality exists somewhere in the WebKitGTK+ stack.
60         * DumpRenderTree/gtk/PlainTextController.h: Added.
61
62 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
63
64         Unreviewed.
65
66         Adding my IRC nick.
67
68         * Scripts/webkitpy/common/config/committers.py:
69
70 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
71
72         Reviewed by Adam Roben.
73
74         new-run-webkit-tests: fix crash when running under windows cmd.exe
75         https://bugs.webkit.org/show_bug.cgi?id=58197
76
77         We would intermittently crash when running NRWT directly under
78         cmd.exe on windows because we were sharing the stdin file
79         descriptor between the python process and the http server.
80         cmd.exe really didn't like that, and there was no reason to
81         share the descriptor, so we now use a PIPE instead.
82
83         * Scripts/webkitpy/layout_tests/port/http_server.py:
84
85 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
86
87         Reviewed by Ojan Vafai.
88
89         new-run-webkit-tests: add unit tests for Port.diff_image()
90         https://bugs.webkit.org/show_bug.cgi?id=58196
91
92         Add the unit tests for the fix in bug 58195.
93
94         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
95         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
96         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
97
98 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
99
100         Reviewed by Tony Chang.
101
102         new-run-webkit-tests: implement support for audio, take two
103         https://bugs.webkit.org/show_bug.cgi?id=58195
104
105         Attempt to re-land the fix for bug 58101 (which was initially
106         landed in r83330, but rolled out). This is the same patch but
107         fixes crashes in Port.diff_image() caused by the change for
108         empty image files being None instead of ''.
109
110         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
111         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
112         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
113         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
114         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
115         * Scripts/webkitpy/layout_tests/port/base.py:
116         * Scripts/webkitpy/layout_tests/port/chromium.py:
117         * Scripts/webkitpy/layout_tests/port/dryrun.py:
118         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
119         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
120         * Scripts/webkitpy/layout_tests/port/test.py:
121         * Scripts/webkitpy/layout_tests/port/webkit.py:
122
123 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
124
125         Reviewed by Xan Lopez.
126
127         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
128         https://bugs.webkit.org/show_bug.cgi?id=57854
129
130         Implement missing features in GTK's DRT.
131
132         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
133         (indexRangeInTable): New helper function to get the range string
134         for the current cell inside the parent table, either from the
135         point of view of rows or columns.
136         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
137         the new helper function indexRangeInTable().
138         (AccessibilityUIElement::columnIndexRange): Ditto.
139
140 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
141
142         Reviewed by Chris Fleizach.
143
144         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
145         https://bugs.webkit.org/show_bug.cgi?id=57826
146
147         Implement missing feature in GTK's DRT.
148
149         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
150         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
151         relying on the analogous function from the AtkTable interface.
152
153 2011-04-05  Timothy Hatcher  <timothy@apple.com>
154
155         Fix the extract-localizable-strings script errors that started after
156         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
157
158         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
159
160 2011-04-11  Tony Chang  <tony@chromium.org>
161
162         Reviewed by Eric Seidel.
163
164         fix crc computation on 64 bit machines
165         https://bugs.webkit.org/show_bug.cgi?id=58243
166
167         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
168
169         * DumpRenderTree/CyclicRedundancyCheck.cpp:
170         (makeCrcTable):
171         (computeCrc):
172         * DumpRenderTree/CyclicRedundancyCheck.h:
173         * DumpRenderTree/PixelDumpSupport.cpp:
174         (appendIntToVector):
175         (convertChecksumToPNGComment):
176
177 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
178
179         Reviewed by Eric Seidel.
180
181         Require no undefined symbols during compilation.
182
183         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
184         https://bugs.webkit.org/show_bug.cgi?id=54896
185
186         Add -Wl,--no-undefined to catch missing symbols early.
187
188         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
189         * WebKitTestRunner/qt/WebKitTestRunner.pro:
190
191 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
192
193         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
194
195         * wx/build/settings.py:
196
197 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
198
199         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
200
201         * wx/build/settings.py:
202
203 2011-04-10  David Levin  <levin@chromium.org>
204
205         Reviewed by Dimitri Glazkov.
206
207         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
208         https://bugs.webkit.org/show_bug.cgi?id=58201
209
210         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
211         and filed bug 58202.
212
213 2011-04-09  David Levin  <levin@chromium.org>
214
215         Unreviewed, rolling out r83394.
216         http://trac.webkit.org/changeset/83394
217         https://bugs.webkit.org/show_bug.cgi?id=53625
218
219         Patch was incorrect as noted in the bug.
220
221         * Scripts/svn-apply:
222
223 2011-04-09  David Levin  <levin@chromium.org>
224
225         Reviewed by Adam Barth.
226
227         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
228         https://bugs.webkit.org/show_bug.cgi?id=53625
229
230         * Scripts/svn-apply: Ensure that the portions of patches
231         which are for vcproj/vsprops files has DOS line endings.
232
233 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
234
235         Reviewed by Tony Chang.
236
237         It looks like NRWT has not been stopping DRT/TestShell
238         instances properly on windows, probably for a long time.
239         This would go a long way to explaining why we often have
240         processes lying around :)
241
242         https://bugs.webkit.org/show_bug.cgi?id=57807
243
244         * Scripts/webkitpy/layout_tests/port/chromium.py:
245         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
246
247 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
248
249         Reviewed by Laszlo Gombos.
250
251         [Qt] Don't link against fontconfig or X11 if embedded
252         https://bugs.webkit.org/show_bug.cgi?id=58104
253
254         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
255         * QtTestBrowser/QtTestBrowser.pro: ditto
256         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
257         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
258
259 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
260
261         http/tests/loading/preload-append-scan.php is failing on Windows
262         https://bugs.webkit.org/show_bug.cgi?id=58178
263
264         Reviewed by Brian Weinstein.
265
266         * DumpRenderTree/win/DumpRenderTree.cpp:
267         (lastPathComponent):
268         Use CFURL API to find the last path component, rather than
269         PathFindFileName(), because the latter will include the query string.
270
271 2011-04-08  Jian Li  <jianli@chromium.org>
272
273         Unreviewed, rolling out r83327, r83330 since these patches are very
274         likely to break chromium webkit mac10.6 builders.
275
276         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
277         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
278         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
279         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
280         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
281         * Scripts/webkitpy/layout_tests/port/base.py:
282         * Scripts/webkitpy/layout_tests/port/chromium.py:
283         * Scripts/webkitpy/layout_tests/port/dryrun.py:
284         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
285         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
286         * Scripts/webkitpy/layout_tests/port/test.py:
287         * Scripts/webkitpy/layout_tests/port/webkit.py:
288
289 2011-04-08  Vincent Scheib  <scheib@chromium.org>
290
291         Reviewed by Eric Seidel.
292
293         add chromium-gpu-linux-x86_64 to the recognized list of ports
294         https://bugs.webkit.org/show_bug.cgi?id=58099
295
296         Add chromium-gpu-linux-x86_64 to fix assert.
297
298         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
299
300 2011-04-08  Alpha Lam  <hclam@chromium.org>
301
302         Unreviewed, rolling out r83335.
303         http://trac.webkit.org/changeset/83335
304         https://bugs.webkit.org/show_bug.cgi?id=53556
305
306         GTK and QT bots are broken
307
308         * Scripts/build-webkit:
309
310 2011-04-07  Anna Cavender  <annacc@chromium.org>
311
312         Reviewed by Eric Carlson.
313
314         Setup ENABLE(TRACK) feature define
315         https://bugs.webkit.org/show_bug.cgi?id=53556
316
317         * Scripts/build-webkit:
318
319 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
320
321         Reviewed by Adam Roben.
322
323         new-run-webkit-tests: configure a NRWT test bot for Mac SL
324         https://bugs.webkit.org/show_bug.cgi?id=58114
325
326         This change removes the old new-run-webkit-tests entry and
327         updates it for a new test-only bot.
328
329         * BuildSlaveSupport/build.webkit.org-config/config.json:
330
331 2011-04-08  Dominic Cooney  <dominicc@google.com>
332
333         Reviewed by Adam Roben.
334
335         Make layoutTestController.shadowRoot return null, not undefined,
336         when its argument is invalid.
337         https://bugs.webkit.org/show_bug.cgi?id=58121
338
339         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
340         (LayoutTestController::shadowRoot):
341         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
342         (WTR::LayoutTestController::shadowRoot):
343
344 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
345
346         Reviewed by Adam Roben.
347
348         Locate NSTD.EXE in 64-bit Windows
349         https://bugs.webkit.org/show_bug.cgi?id=57847
350
351         * Scripts/old-run-webkit-tests:
352
353 2011-04-08  Adam Roben  <aroben@apple.com>
354
355         Qt build fix
356
357         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
358
359 2011-04-07  Adam Roben  <aroben@apple.com>
360
361         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
362
363         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
364         plugin
365
366         Reviewed by Anders Carlsson.
367
368         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
369         (pluginLogWithArguments): Moved code to format and log the message here...
370         (pluginLog): ...from here.
371
372         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
373
374         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
375         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
376
377         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
378
379         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
380         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
381         to begin.
382         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
383         constructor.
384         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
385         can be used to invoke our setWillBeDestroyed function.
386         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
387         anything unexpected happens).
388         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
389         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
390         NPP_SetWindow was *not* called during destruction.
391         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
392         method, setWillBeDestroyed.
393         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
394         object.
395
396         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
397         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
398         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
399         * GNUmakefile.am:
400         Added new test.
401
402         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
403         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
404
405 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
406
407         Reviewed by Martin Robinson.
408
409         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
410         https://bugs.webkit.org/show_bug.cgi?id=58039
411
412         Implement missing functions in GTK's DRT.
413
414         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
415         (AccessibilityUIElement::increment): Implemented.
416         (AccessibilityUIElement::decrement): Implemented.
417
418 2011-04-08  Dominic Cooney  <dominicc@google.com>
419
420         Reviewed by Kent Tamura.
421
422         Make WK2 layoutTestController.shadowRoot return undefined, not
423         null, when its argument is not an element.
424         https://bugs.webkit.org/show_bug.cgi?id=58121
425
426         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
427         (WTR::LayoutTestController::shadowRoot):
428
429 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
430
431         Reviewed by Mihai Parparita.
432
433         Change reference port for Mac GPU baselines from
434         Leopard to SnowLeopard, XP to Win7, and Linux-x86
435         to Linux x86-64.
436
437         https://bugs.webkit.org/show_bug.cgi?id=58099
438
439         * Scripts/webkitpy/layout_tests/port/chromium.py:
440
441 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
442
443         Revert ENABLE_TRACK patch due to compile failures.
444
445         * Scripts/build-webkit:
446
447 2011-04-07  Tony Chang  <tony@chromium.org>
448
449         Reviewed by Eric Seidel.
450
451         update DRT to embed checksums in png files
452         https://bugs.webkit.org/show_bug.cgi?id=57871
453
454         We insert the bytes for the comment in printPNG rather than at encode
455         time because each platform does its own PNG encoding (either using CG
456         or cairo).  Putting this in pringPNG avoids having to duplicate this
457         code, although it's not as clean as doing it at encoding time.
458
459         We insert the comment right after the IHDR chunk of the PNG.
460
461         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
462         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
463         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
464         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
465         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
466         * DumpRenderTree/PixelDumpSupport.cpp:
467         (dumpWebViewAsPixelsAndCompareWithExpected):
468         (convertChecksumToPNGComment): Generate the bytes to insert.
469         (printPNG): Insert the png comment before the first IDAT section.
470         * DumpRenderTree/PixelDumpSupport.h:
471         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
472         (printPNG):
473         (dumpBitmap):
474         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
475         (printPNG):
476         (dumpBitmap):
477         * DumpRenderTree/win/DumpRenderTree.vcproj:
478         * GNUmakefile.am:
479
480 2011-04-07  Jeff Miller  <jeffm@apple.com>
481
482         Reviewed by Adam Roben.
483
484         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
485         https://bugs.webkit.org/show_bug.cgi?id=58058
486
487         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
488         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
489
490 2011-04-07  Chang Shu  <cshu@webkit.org>
491
492         Reviewed by Darin Adler.
493
494         WebKitTestRunner needs layoutTestController.isPageBoxVisible
495         https://bugs.webkit.org/show_bug.cgi?id=42695
496
497         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
498         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
499         (WTR::LayoutTestController::isPageBoxVisible):
500         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
501
502 2011-04-07  Adam Roben  <aroben@apple.com>
503
504         Build fix
505
506         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
507
508 2011-04-07  Adam Roben  <aroben@apple.com>
509
510         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
511
512         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
513         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
514         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
515         be overridden by subclasses to provide extra URLs before we call up to the base class (after
516         which adding more URLs is no longer possible).
517
518         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
519         bot results page
520
521         Reviewed by John Sullivan.
522
523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
524         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
525         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
526         method is never called for MasterShellCommands.
527         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
528         with this method (which is).
529
530 2011-04-07  Adam Roben  <aroben@apple.com>
531
532         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
533
534         This matches how most of our other build steps work, so is good just for improving
535         consistency between build steps. It should also make it possible for
536         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
537         trying to do this in finished() after we had called up to the base class, but that was
538         apparently too late to add more URLs.)
539
540         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
541         results page
542
543         Reviewed by John Sullivan.
544
545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
546         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
547         call setText to get the right text to show up for this step. This matches how most of our
548         other build steps work.
549         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
550         This is how most of our other build steps work.
551         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
552         function, to match the base class.
553
554 2011-04-07  Adam Barth  <abarth@webkit.org>
555
556         Reviewed by Maciej Stachowiak.
557
558         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
559         https://bugs.webkit.org/show_bug.cgi?id=58022
560
561         Previously, we were ignoring the args variable!  This patch fixes the
562         regression introduced in http://trac.webkit.org/changeset/82771.
563
564         * Scripts/webkitpy/tool/commands/download_unittest.py:
565         * Scripts/webkitpy/tool/mocktool.py:
566         * Scripts/webkitpy/tool/steps/checkstyle.py:
567
568 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
569
570         Reviewed by Adam Barth.
571
572         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
573         https://bugs.webkit.org/show_bug.cgi?id=58017
574
575         * Scripts/webkitpy/common/checkout/scm.py:
576         * Scripts/webkitpy/common/checkout/scm_unittest.py:
577
578 2011-04-06  Chang Shu  <cshu@webkit.org>
579
580         Reviewed by Darin Adler.
581
582         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
583         https://bugs.webkit.org/show_bug.cgi?id=57984
584
585         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
586         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
587         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
588         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
589
590 2011-04-06  Chris Rogers  <crogers@google.com>
591
592         Reviewed by Tony Chang.
593
594         Add web audio support to DumpRenderTree (mac port)
595         https://bugs.webkit.org/show_bug.cgi?id=57969
596
597         * DumpRenderTree/LayoutTestController.cpp:
598         (LayoutTestController::LayoutTestController):
599         (setEncodedAudioDataCallback):
600         (LayoutTestController::staticFunctions):
601         * DumpRenderTree/LayoutTestController.h:
602         (LayoutTestController::dumpAsAudio):
603         (LayoutTestController::setDumpAsAudio):
604         (LayoutTestController::encodedAudioData):
605         (LayoutTestController::setEncodedAudioData):
606         * DumpRenderTree/mac/DumpRenderTree.mm:
607         (dumpAudio):
608         (dump):
609
610 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
611
612         Reviewed by Kenneth Rohde Christiansen.
613
614         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
615         https://bugs.webkit.org/show_bug.cgi?id=56086
616
617         Add the missing method.
618
619         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
620         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
621         * DumpRenderTree/qt/DumpRenderTreeQt.h:
622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
623         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
624
625 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
626
627         Reviewed by David Levin.
628
629         Add QUOTA build flag for unified quota API
630         https://bugs.webkit.org/show_bug.cgi?id=57918
631
632         * Scripts/build-webkit: Added QUOTA build flag
633
634 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
635
636         Reviewed by Tony Chang.
637
638         Adjust the apple webkit port's default timeout to match
639         old-run-webkit-tests at 35 seconds.
640
641         https://bugs.webkit.org/show_bug.cgi?id=37738
642
643         * Scripts/webkitpy/layout_tests/port/mac.py:
644
645 2011-04-06  Scott Cameron  <sccameron@rim.com>
646
647         Reviewed by Eric Seidel.
648
649         Remove global variable $httpdPath and replace with the return value of
650         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
651         https://bugs.webkit.org/show_bug.cgi?id=53499
652
653         * Scripts/run-iexploder-tests:
654         * Scripts/webkitperl/httpd.pm:
655
656 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
657
658         Reviewed by Darin Adler.
659
660         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
661         
662         https://bugs.webkit.org/show_bug.cgi?id=27551
663         
664         * DumpRenderTree/config.h:
665         * WebKitAPITest/config.h:
666         * WebKitTestRunner/config.h:
667
668 2011-04-06  Tony Chang  <tony@chromium.org>
669
670         Reviewed by Darin Adler.
671
672         teach run-webkit-tests to read checksums from png files
673         https://bugs.webkit.org/show_bug.cgi?id=57993
674
675         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
676           no .checksum and look for the checksum in there.
677
678 2011-04-06  David Dorwin  <ddorwin@chromium.org>
679
680         Reviewed by David Levin.
681
682         Enable fullscreen layout tests for Chromium
683         https://bugs.webkit.org/show_bug.cgi?id=55726
684
685         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
686
687         * DumpRenderTree/chromium/WebPreferences.cpp:
688         (WebPreferences::applyTo):
689
690 2011-04-06  Adam Roben  <aroben@apple.com>
691
692         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
693
694         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
695
696         Reviewed by David Kilzer.
697
698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
699         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
700         build's results directory here...
701         (ExtractTestResults.finished): ...from here.
702         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
703         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
704         leaks" link to point to Leaks Viewer for this build.
705         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
706         but it seemed good to add for consistency with BuildAndTestFactory.
707         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
708         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
709         that we'll get a "view leaks" link.
710
711 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
712
713         Reviewed by Eric Seidel.
714
715         [Gtk] plugins/set-status.html fails
716         https://bugs.webkit.org/show_bug.cgi?id=57844
717
718         Allow an empty status text to be dumped.
719
720         * DumpRenderTree/gtk/DumpRenderTree.cpp:
721         (webViewStatusBarTextChanged):
722
723 2011-04-06  Chang Shu  <cshu@webkit.org>
724
725         Reviewed by Darin Adler.
726
727         WebKitTestRunner needs layoutTestController.pageNumberForElementById
728         https://bugs.webkit.org/show_bug.cgi?id=42329
729
730         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
731         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
732         (WTR::LayoutTestController::pageNumberForElementById):
733         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
734
735 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
736
737         Reviewed by Martin Robinson.
738
739         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
740         https://bugs.webkit.org/show_bug.cgi?id=57932
741
742         Some Layout tests have invalid URIs that do not generate valid
743         SoupURI instances. Do not try to free those NULL SoupURIs.
744
745         * DumpRenderTree/gtk/DumpRenderTree.cpp:
746         (willSendRequestCallback):
747
748 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
749
750         Reviewed by Andreas Kling.
751
752         ORWT shouldn't generate diff files for tests without expected files
753         https://bugs.webkit.org/show_bug.cgi?id=57846
754
755         * Scripts/old-run-webkit-tests:
756
757 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
758
759         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
760         to deps.
761
762         * wx/install-unix-extras:
763
764 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
765
766         Unreviewed, rolling out r82978, r82999, and r83001.
767         http://trac.webkit.org/changeset/82978
768         http://trac.webkit.org/changeset/82999
769         http://trac.webkit.org/changeset/83001
770         https://bugs.webkit.org/show_bug.cgi?id=57913
771
772         Does not work in Python 2.5 (Requested by abarth on #webkit).
773
774         * Scripts/webkitpy/common/system/executive.py:
775         * Scripts/webkitpy/common/system/executive_unittest.py:
776
777 2011-04-05  Chang Shu  <cshu@webkit.org>
778
779         Reviewed by Darin Adler.
780
781         WebKitTestRunner needs layoutTestController.numberOfPages
782         https://bugs.webkit.org/show_bug.cgi?id=42694
783
784         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
785         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
786         (WTR::LayoutTestController::numberOfPages):
787         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
788
789 2011-04-05  Tony Chang  <tony@chromium.org>
790
791         Reviewed by Mihai Parparita.
792
793         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
794         https://bugs.webkit.org/show_bug.cgi?id=57889
795
796         * Scripts/webkitpy/layout_tests/port/chromium.py:
797         * Scripts/webkitpy/layout_tests/port/test.py:
798         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
799
800 2011-04-05  Adam Barth  <abarth@webkit.org>
801
802         Silly with statement, from the future!
803
804         * Scripts/webkitpy/common/system/executive.py:
805
806 2011-04-05  Adam Barth  <abarth@webkit.org>
807
808         Reviewed by Tony Chang.
809
810         Don't use Exception.message because it's deprecated
811         https://bugs.webkit.org/show_bug.cgi?id=57892
812
813         Suppress the warning for now.  When we move to Python 3, we might need
814         to something more dramatic.
815
816         * Scripts/webkitpy/common/system/executive.py:
817
818 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
819
820         Reviewed by Ojan Vafai.
821
822         Add builders.js to dashboard file list
823         https://bugs.webkit.org/show_bug.cgi?id=57899
824
825         Add file added by http://crrev.com/80538 to dashboard file list.
826
827         * TestResultServer/handlers/dashboardhandler.py:
828
829 2011-04-05  MORITA Hajime  <morrita@google.com>
830
831         Reviewed by Adam Barth.
832
833         webkit-patch should print git's stderr when git svn dcommit fail
834         http://webkit.org/b/57861
835
836         * Scripts/webkitpy/common/checkout/scm.py:
837
838 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
839
840         Reviewed by Tony Chang.
841
842         Add --baseline-search-path to NRWT
843         https://bugs.webkit.org/show_bug.cgi?id=56233
844         
845         Add NRWT option to specify additional directories to look for baselines
846         (will be used by hardware GPU bots which will have local per-bot
847         expectations for some tests)
848
849         * Scripts/webkitpy/common/system/filesystem_mock.py:
850         * Scripts/webkitpy/layout_tests/port/base.py:
851         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
853
854 2011-04-05  Adam Roben  <aroben@apple.com>
855
856         Strip off /results.html from results URLs before trying to load leaks files from them
857
858         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
859         files, rather than pointing to the directory that contains them. This is more convenient for
860         people browsing build.webkit.org, but confused Leaks Viewer.
861
862         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
863         list don't work
864
865         Reviewed by Joseph Pecoraro.
866
867         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
868         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
869
870 2011-04-05  Carol Szabo  <carol@webkit.org>
871
872         Unreviewed.
873
874         Updated my info in committers.py
875
876         Scripts\webkitpy\common\config\committers.py 
877
878 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
879
880         Reviewed by Laszlo Gombos.
881
882         [Qt] Make WebKitLibraries optional for building QtWebKit
883         https://bugs.webkit.org/show_bug.cgi?id=57542
884
885         * Scripts/build-webkit:
886
887 2011-04-05  Chang Shu  <cshu@webkit.org>
888
889         Reviewed by Laszlo Gombos.
890
891         [Qt] MiniBrowser defaultUrl does not work
892         https://bugs.webkit.org/show_bug.cgi?id=57021
893
894         Match the behavior and coding of MiniBrowser to QtTestBrowser.
895         * MiniBrowser/qt/main.cpp:
896         (main):
897
898 2011-04-05  Jade Han  <jade.han@nokia.com>
899
900         Reviewed by Laszlo Gombos.
901
902         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
903         https://bugs.webkit.org/show_bug.cgi?id=54977
904
905         This change is a preparation to enable building webkit2 for Symbian.
906         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
907
908         * Tools.pro:
909
910 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
911
912         Reviewed by Andreas Kling.
913
914         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
915         https://bugs.webkit.org/show_bug.cgi?id=57832
916
917         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
918
919         * MiniBrowser/qt/UrlLoader.cpp:
920         (UrlLoader::UrlLoader):
921
922 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
923
924         [Qt] Linux Release minimal build fix after r82919.
925
926         * MiniBrowser/qt/BrowserWindow.cpp:
927         (BrowserWindow::loadURLListFromFile):
928         * QtTestBrowser/launcherwindow.cpp:
929         (LauncherWindow::loadURLListFromFile):
930
931 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
932
933         Reviewed by Andreas Kling.
934
935         [Qt] Make URL loader accessible from testbrowser's menus
936         https://bugs.webkit.org/show_bug.cgi?id=57823
937
938         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
939
940         * MiniBrowser/qt/BrowserWindow.cpp:
941         (BrowserWindow::BrowserWindow):
942         (BrowserWindow::loadURLListFromFile):
943         (BrowserWindow::~BrowserWindow):
944         * MiniBrowser/qt/BrowserWindow.h:
945         * QtTestBrowser/launcherwindow.cpp:
946         (LauncherWindow::LauncherWindow):
947         (LauncherWindow::~LauncherWindow):
948         (LauncherWindow::createChrome):
949         (LauncherWindow::loadURLListFromFile):
950         * QtTestBrowser/launcherwindow.h:
951
952 2011-04-04  Sam Weinig  <sam@webkit.org>
953
954         Reviewed by Brian Weinstein.
955
956         Remove duplicate API from WKContext
957         <rdar://problem/8727879>
958         https://bugs.webkit.org/show_bug.cgi?id=57815
959
960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
961         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
962         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
963         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
964
965 2011-04-04  Tony Chang  <tony@chromium.org>
966
967         Reviewed by Ojan Vafai.
968
969         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
970         https://bugs.webkit.org/show_bug.cgi?id=57783
971
972         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
973         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
974
975 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
976
977         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
978         from WebKitBuild.
979
980         * Scripts/webkitdirs.pm:
981
982 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
983
984         Reviewed by Gustavo Noronha Silva.
985
986         [GTK] WebGL support
987         https://bugs.webkit.org/show_bug.cgi?id=31517
988
989         Add support to the DRT for turning on WebGL when a layout tests requests it.
990
991         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
992         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
993
994 2011-04-04  Chang Shu  <cshu@webkit.org>
995
996         Reviewed by Darin Adler.
997
998         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
999         https://bugs.webkit.org/show_bug.cgi?id=57572
1000
1001         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1002         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1003         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1004         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1005
1006 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1007
1008         Reviewed by Csaba Osztrogonác.
1009
1010         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1011         https://bugs.webkit.org/show_bug.cgi?id=57602
1012
1013         * DumpRenderTree/qt/main.cpp:
1014         (get_backtrace):
1015
1016 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1017
1018         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1019
1020         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1021         (LayoutTestController::shadowRoot):
1022
1023 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1024
1025         Unreviewed, fix exception in rebaseline tool.
1026
1027         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1028
1029 2011-04-02  Beth Dakin  <bdakin@apple.com>
1030
1031         Rubber-stamped by Geoff Garen.
1032
1033         For Dan!
1034         * DumpRenderTree/mac/DumpRenderTree.mm:
1035         (resetWebViewToConsistentStateBeforeTesting):
1036
1037 2011-04-02  Beth Dakin  <bdakin@apple.com>
1038
1039         Rubber-stamped by Geoff Garen.
1040
1041         Need to reset the scale, much like zoom.
1042         * DumpRenderTree/mac/DumpRenderTree.mm:
1043         (resetWebViewToConsistentStateBeforeTesting):
1044
1045 2011-04-02  Sam Weinig  <sam@webkit.org>
1046
1047         Reviewed by Beth Dakin.
1048
1049         https://bugs.webkit.org/show_bug.cgi?id=57605
1050         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1051         getClientRects()
1052         -and corresponding-
1053         <rdar://problem/9194541>
1054
1055         Add DRT support for the scaleWebView SPI.
1056         * DumpRenderTree/mac/EventSendingController.mm:
1057         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1058         (+[EventSendingController webScriptNameForSelector:]):
1059         (-[EventSendingController scalePageBy:atX:andY:]):
1060         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1061         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1062         (WTR::EventSendingController::scalePageBy):
1063         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1064         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1065         (WTR::InjectedBundlePage::reset):
1066
1067 2011-04-02  Dominic Cooney  <dominicc@google.com>
1068
1069         Reviewed by Martin Robinson.
1070
1071         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1072         https://bugs.webkit.org/show_bug.cgi?id=57551
1073
1074         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1075         (LayoutTestController::shadowRoot):
1076
1077 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1078
1079         Reviewed by Eric Seidel.
1080
1081         Remove AbstractStep._run_script and move script names to ports.py
1082         https://bugs.webkit.org/show_bug.cgi?id=57704
1083
1084         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1085
1086         * Scripts/webkitpy/common/config/ports.py:
1087         * Scripts/webkitpy/tool/commands/download_unittest.py:
1088         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1089         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1090         * Scripts/webkitpy/tool/steps/abstractstep.py:
1091         * Scripts/webkitpy/tool/steps/checkstyle.py:
1092         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1093         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1094         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1095
1096 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1097
1098         Reviewed by Eric Seidel.
1099
1100         Emulate shebang on Win32
1101         https://bugs.webkit.org/show_bug.cgi?id=55927
1102
1103         Scripts on Windows work only if they are called with the explicit interpreter.
1104         Read the first line of scripts to detect the correct executable.
1105
1106         * Scripts/webkitpy/common/config/ports.py:
1107         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1108         * Scripts/webkitpy/common/system/executive_unittest.py:
1109
1110 2011-04-01  Adam Barth  <abarth@webkit.org>
1111
1112         Reviewed by Eric Seidel.
1113
1114         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1115         https://bugs.webkit.org/show_bug.cgi?id=57692
1116
1117         Previously, we were using BeautifulSoup to process XML from
1118         bugs.webkit.org, but that's incorrect.  We should be using
1119         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1120         entity wrong because &apos; is an XML entity but not an HTML entity.
1121
1122         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1123         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1124
1125 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1126
1127         Unreviewed, rolling out r82721.
1128         http://trac.webkit.org/changeset/82721
1129         https://bugs.webkit.org/show_bug.cgi?id=57687
1130
1131         This patch introduced assertion failures on the GTK+ bots.
1132         (Requested by mrobinson on #webkit).
1133
1134         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1135         (LayoutTestController::shadowRoot):
1136
1137 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1138
1139         Unreviewed buildfix.
1140
1141         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1142         https://bugs.webkit.org/show_bug.cgi?id=55074
1143
1144         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1145         (The isWK2() function removes it from @ARGV, but not from @options.)
1146
1147 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1148
1149         Reviewed by Csaba Osztrogonác.
1150
1151         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1152         https://bugs.webkit.org/show_bug.cgi?id=57666
1153
1154         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1155
1156 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1161
1162         We apparently never implemented the code to skip tests based on
1163         what was compiled into DRT. Also, change the logic used to skip
1164         platform directories to match what old-run-webkit-tests does: 
1165         skip every test not in a directory in the baseline search path.
1166
1167         https://bugs.webkit.org/show_bug.cgi?id=57662
1168
1169         * Scripts/webkitpy/layout_tests/port/mac.py:
1170         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1171         * Scripts/webkitpy/layout_tests/port/webkit.py:
1172
1173 2011-03-29  Mark Rowe  <mrowe@apple.com>
1174
1175         Reviewed by Jon Honeycutt.
1176
1177         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1178
1179         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1180
1181         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1182         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1183         * Scripts/webkitpy/layout_tests/port/mac.py:
1184         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1185
1186 2011-04-01  Chang Shu  <cshu@webkit.org>
1187
1188         Reviewed by Csaba Osztrogonác.
1189
1190         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1191         https://bugs.webkit.org/show_bug.cgi?id=55074
1192
1193         * Scripts/build-webkit:
1194
1195 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1196
1197         Reviewed by Tony Chang.
1198
1199         new-run-webkit-tests: remove spurious port version override in webkit.py
1200         base.py provides a default implementation so this is just
1201         breaking things.
1202
1203         https://bugs.webkit.org/show_bug.cgi?id=57667
1204
1205         * Scripts/webkitpy/layout_tests/port/webkit.py:
1206         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1207
1208 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1209
1210         Reviewed by Adam Roben.
1211
1212         Make view results on waterfall direct link to results.html
1213         https://bugs.webkit.org/show_bug.cgi?id=57671
1214
1215         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1216         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1217
1218 2011-04-01  Sam Weinig  <sam@webkit.org>
1219
1220         Fix windows build.
1221
1222         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1223         (TestWebKitAPI::TEST):
1224         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1225         (TestWebKitAPI::flushMessages):
1226
1227 2011-04-01  Sam Weinig  <sam@webkit.org>
1228
1229         Reviewed by Adam Roben.
1230
1231         Add adoptWK to WKRetainPtr.h
1232         https://bugs.webkit.org/show_bug.cgi?id=57670
1233
1234         * TestWebKitAPI/PlatformUtilities.h:
1235         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1236         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1237         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1238         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1239         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1240         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1241         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1242         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1243         (TestWebKitAPI::createSessionStateContainingFormData):
1244         * WebKitTestRunner/StringFunctions.h:
1245         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1246
1247 2011-04-01  Sam Weinig  <sam@webkit.org>
1248
1249         Reviewed by Adam Roben.
1250
1251         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1252
1253         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1254         (WTR::LayoutTestController::shadowRoot):
1255         Make judicious use of adoptWK().
1256
1257 2011-04-01  Sam Weinig  <sam@webkit.org>
1258
1259         Reviewed by Timothy Hatcher.
1260
1261         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1262
1263         * Scripts/extract-localizable-strings:
1264
1265 2011-04-01  Anders Carlsson  <andersca@apple.com>
1266
1267         Reviewed by Sam Weinig.
1268
1269         Shockwave plug-in doesn't accept mouse events
1270         https://bugs.webkit.org/show_bug.cgi?id=57653
1271         <rdar://problem/8483273>
1272
1273         Add a plug-in test.
1274
1275         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1276         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1277         (PluginTest::indicateTestFailure):
1278         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1279
1280         (PluginTest::NPN_ConvertPoint):
1281         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1282         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1283         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1284         Call indicateTestFailure.
1285
1286         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1287         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1288         (ConvertPoint::ConvertPoint):
1289         (ConvertPoint::testConvert):
1290         (ConvertPoint::NPP_New):
1291
1292 2011-04-01  Dominic Cooney  <dominicc@google.com>
1293
1294         Reviewed by Martin Robinson.
1295
1296         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1297         https://bugs.webkit.org/show_bug.cgi?id=57551
1298
1299         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1300         (LayoutTestController::shadowRoot):
1301
1302 2011-04-01  Sam Weinig  <sam@webkit.org>
1303
1304         Reviewed by Anders Carlsson.
1305
1306         WebKitTestRunner needs layoutTestController.shadowRoot
1307         https://bugs.webkit.org/show_bug.cgi?id=57661
1308
1309         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1311         (WTR::LayoutTestController::shadowRoot):
1312         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1313         Implement layoutTestController.shadowRoot for WebKit2.
1314
1315 2011-04-01  Chang Shu  <cshu@webkit.org>
1316
1317         Reviewed by Darin Adler.
1318
1319         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1320         https://bugs.webkit.org/show_bug.cgi?id=57568
1321
1322         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1323         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1324         (WTR::LayoutTestController::setDatabaseQuota):
1325         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1326
1327 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1328
1329         Reviewed by Tony Chang.
1330
1331         This patch completes the cleanup of
1332         rebaseline-chromium-webkit-tests to work with all of the
1333         variants of a platform (we can now rebaseline gpu- and non-gpu
1334         files at the same time).
1335
1336         When the rebaselining is complete, any lines declared as
1337         REBASELINE in the expectations file that matches a test that was
1338         actually rebaselined will be deleted, even if only one of the
1339         variants was actually rebaselined. This may cause odd problems,
1340         but is better than where we're at today.
1341
1342         This change removes the -g flag and deprecates -w. The -g flag is gone
1343         because GPU baselines are handled just like any other variant.
1344         The -w flag is deprecated because this tool now only works
1345         against the canaries, since that's the only place we have a full
1346         set of bots. It will be trivial to change this to
1347         build.webkit.org if we decide that's where we want them to be.
1348
1349         Also, this patch deletes a lot of cruft that is no longer needed
1350         in the test_expectations code and the port-specific code.
1351
1352         https://bugs.webkit.org/show_bug.cgi?id=55191
1353
1354         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1355         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1356         * Scripts/webkitpy/layout_tests/port/base.py:
1357         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1358         * Scripts/webkitpy/layout_tests/port/chromium.py:
1359         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1360         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1361         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1362         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1363         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1364         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1365         * Scripts/webkitpy/layout_tests/port/mac.py:
1366         * Scripts/webkitpy/layout_tests/port/test.py:
1367         * Scripts/webkitpy/layout_tests/port/webkit.py:
1368         * Scripts/webkitpy/layout_tests/port/win.py:
1369         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1370         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1371
1372 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1373
1374         Reviewed by Adam Barth.
1375
1376         rebaseline-chromium-webkit-tests does not work correctly with
1377         version-specific baselines. This patch updates the tool to use
1378         all of the version-specific bots on the canaries, and will now
1379         attempt to rebaseline all of the versions by default, although
1380         it will not update both GPU and CPU versions.
1381         
1382         Also, it will no longer modify the test_expectations.txt file
1383         *at all*. You will have to manually delete the REBASELINE lines
1384         after running the tool and determining that it did what you
1385         wanted it to do. This should be fixed in a separate bug - see
1386         webkit bug #55191.
1387
1388         https://bugs.webkit.org/show_bug.cgi?id=55608
1389
1390         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1391         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1392         * Scripts/webkitpy/layout_tests/port/chromium.py:
1393         * Scripts/webkitpy/layout_tests/port/test.py:
1394         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1395         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1396
1397 2011-03-31  Tony Chang  <tony@chromium.org>
1398
1399         Reviewed by Ojan Vafai.
1400
1401         [chromium] update the rebaseline tool to know about pngs with checksums
1402         https://bugs.webkit.org/show_bug.cgi?id=57481
1403
1404         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1405         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1406
1407 2011-04-01  Adam Roben  <aroben@apple.com>
1408
1409         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1410
1411         Previously, we were getting the revision of the first revision that triggered a build.
1412         Choosing the last revision would have been more accurate. But got_revision is what is used
1413         everywhere else on build.webkit.org, and should work even when there were no changes that
1414         triggered a build (e.g., if someone clicked the Force Build button).
1415
1416         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1417         recent builds list
1418
1419         Reviewed by Anders Carlsson.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1422         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1423         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1424
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1426         (Array.prototype.first): Added this helper function to return the first element in an array
1427         that matches the given predicate, or null if no such element exists.
1428
1429 2011-03-31  Adam Roben  <aroben@apple.com>
1430
1431         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1432
1433         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1434
1435         Reviewed by Darin Adler.
1436
1437         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1438         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1439         URL on its own line.
1440
1441         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1442         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1443         progression, and added a new test that uses a short bug URL while I was at it.
1444
1445 2011-04-01  Adam Roben  <aroben@apple.com>
1446
1447         Mark .vcproj/.vsprops/.sln files as being Windows-only
1448
1449         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1450
1451         Reviewed by Anders Carlsson.
1452
1453         * Scripts/webkitpy/common/config/build.py:
1454         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1455         directories as Windows-only.
1456
1457         * Scripts/webkitpy/common/config/build_unittest.py:
1458         (ShoulBuildTest): Added test cases for the above.
1459
1460 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1461
1462         Reviewed by Laszlo Gombos.
1463
1464         [Qt] Build MiniBrowser for Symbian
1465         https://bugs.webkit.org/show_bug.cgi?id=56319
1466
1467         Have MiniBrowser reference it's own copy of useragentlist.txt instead
1468         of copying QtTestBrowser's.
1469         Remove Tools/MiniBrowser/DerivedSources.pro
1470         This reduces complexity in the Tools scripts due to Symbian limitations.
1471
1472         * DerivedSources.pro:
1473         * MiniBrowser/DerivedSources.pro: Removed.
1474         * MiniBrowser/MiniBrowser.qrc:
1475         * MiniBrowser/qt/MiniBrowser.pro:
1476         * Scripts/webkitdirs.pm:
1477
1478 2011-03-31  Chang Shu  <cshu@webkit.org>
1479
1480         Reviewed by Darin Adler.
1481
1482         WebKitTestRunner needs layoutTestController.clearAllDatabases
1483         https://bugs.webkit.org/show_bug.cgi?id=42540
1484
1485         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1486         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1487         (WTR::InjectedBundle::beginTesting):
1488         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1489         (WTR::LayoutTestController::clearAllDatabases):
1490         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1491
1492 2011-03-31  Chang Shu  <cshu@webkit.org>
1493
1494         Reviewed by Darin Adler.
1495
1496         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1497         https://bugs.webkit.org/show_bug.cgi?id=42692
1498
1499         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1500
1501 2011-03-31  Darin Adler  <darin@apple.com>
1502
1503         Reviewed by Sam Weinig.
1504
1505         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1506         https://bugs.webkit.org/show_bug.cgi?id=57573
1507
1508         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1509         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1510         Removed fake definitions of keyDown and contextClick.
1511
1512         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1513         (WTR::operator==): Added. So we can compare two WKPoint structs.
1514         (WTR::parseModifier): Added.
1515         (WTR::parseModifierArray): Added.
1516         (WTR::EventSendingController::EventSendingController): Initialize the
1517         new data members.
1518         (WTR::EventSendingController::mouseDown): Added. Calls
1519         WKBundlePageSimulateMouseDown.
1520         (WTR::EventSendingController::mouseUp): Added. Calls
1521         WKBundlePageSimulateMouseUp.
1522         (WTR::EventSendingController::mouseMoveTo): Added. Calls
1523         WKBundlePageSimulateMouseMotion.
1524         (WTR::EventSendingController::leapForward): Added.
1525         (WTR::EventSendingController::updateClickCount): Added. Used by the
1526         mouseDown/Up functions to create a click count.
1527
1528         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1529         for the changes above.
1530
1531 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
1532
1533         Reviewed by Martin Robinson.
1534
1535         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1536         https://bugs.webkit.org/show_bug.cgi?id=57362
1537
1538         Do not generate DRT output if willSendRequestReturnsNull is set.
1539
1540         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1541         (willSendRequestCallback):
1542
1543 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
1544
1545         Reviewed by Martin Robinson.
1546
1547         Implement MiniBrowser for Gtk port.
1548         https://bugs.webkit.org/show_bug.cgi?id=48512
1549
1550         Initial implementation of the Gtk MiniBrowser.
1551
1552         * MiniBrowser/gtk/GNUmakefile.am: Added.
1553         * MiniBrowser/gtk/main.c: Added.
1554         (activateUriEntryCallback):
1555         (destroyCallback):
1556         (goBackCallback):
1557         (goForwardCallback):
1558         (createToolbar):
1559         (createWebView):
1560         (createWindow):
1561         (argumentToURL):
1562         (main):
1563
1564 2011-03-30  Dominic Cooney  <dominicc@google.com>
1565
1566         Reviewed by Dimitri Glazkov.
1567
1568         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1569         https://bugs.webkit.org/show_bug.cgi?id=57415
1570
1571         * DumpRenderTree/LayoutTestController.cpp:
1572         (shadowRootCallback):
1573         (LayoutTestController::staticFunctions):
1574         * DumpRenderTree/LayoutTestController.h:
1575         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1576         (LayoutTestController::shadowRoot):
1577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1578         (LayoutTestController::shadowRoot):
1579
1580 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1581
1582         Reviewed by Chris Marrin.
1583
1584         Update fast/canvas tests to avoid dumping the render tree when possible
1585         https://bugs.webkit.org/show_bug.cgi?id=57493
1586
1587         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1588           accelerated drawing and accelerated drawing for canvas
1589
1590 2011-03-30  Adam Roben  <aroben@apple.com>
1591
1592         Stop ignoring leaks in CGGradientCreateWithColorStops
1593
1594         Fixes <rdar://problem/7888547>.
1595
1596         Rubber-stamped by John Sullivan.
1597
1598         * Scripts/old-run-webkit-tests:
1599         (countAndPrintLeaks): Removed some code to ignore those leaks.
1600
1601 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1602
1603         Reviewed by Alexey Proskuryakov.
1604
1605         Add some dynamic annotations to JavaScriptCore/wtf
1606         https://bugs.webkit.org/show_bug.cgi?id=53747
1607
1608         By using these annotations we can improve the precision of finding
1609         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1610         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1611
1612         These files don't add new functionality, so don't need extra tests.
1613
1614         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1615
1616 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1617
1618         Reviewed by Adam Roben.
1619
1620         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1621         https://bugs.webkit.org/show_bug.cgi?id=57508
1622
1623         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1626         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1627         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1628         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1629         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1630         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1631         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1632         * FindSafari/FindSafariProduction.vsprops:
1633         * FindSafari/FindSafariRelease.vsprops:
1634         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1635         * FindSafari/FindSafariReleasePGO.vsprops:
1636         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1637         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1638         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1639         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1640         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1641         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1642         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1643         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1644         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1645         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1646         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1647         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1648         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1649         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1650         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1651         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1652         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1653         * WinLauncher/WinLauncherProduction.vsprops:
1654         * WinLauncher/WinLauncherRelease.vsprops:
1655         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1656         * record-memory-win/record-memory-winProduction.vsprops:
1657         * record-memory-win/record-memory-winRelease.vsprops:
1658         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1659
1660 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1661
1662         Reviewed by Adam Roben.
1663
1664         Update Windows production build logic for new production configurations
1665         https://bugs.webkit.org/show_bug.cgi?id=57494
1666
1667         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1668         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1669         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1670         * FindSafari/FindSafariProduction.vsprops:
1671         * FindSafari/FindSafariReleasePGO.vsprops:
1672         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1673         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1674         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1675         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1676         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1677         * WinLauncher/WinLauncherProduction.vsprops:
1678         * record-memory-win/record-memory-winProduction.vsprops:
1679
1680 2011-03-30  Robert Hogan  <robert@webkit.org>
1681
1682         Reviewed by Antonio Gomes.
1683
1684         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1685         Unskip http/tests/navigation/go-back-to-error-page.html
1686
1687         Also add the location of DumpRenderTreeSupportQt.h
1688         to DRT's include paths.
1689
1690         https://bugs.webkit.org/show_bug.cgi?id=52614
1691
1692         * DumpRenderTree/qt/DumpRenderTree.pro:
1693         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1694         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1695         * DumpRenderTree/qt/GCControllerQt.cpp:
1696         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1697         (LayoutTestController::queueLoadHTMLString):
1698         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1699         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1700         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1701         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1702         (LoadAlternateHTMLStringItem::invoke):
1703         * DumpRenderTree/qt/WorkQueueItemQt.h:
1704         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1705         * QtTestBrowser/QtTestBrowser.pro:
1706         * QtTestBrowser/launcherwindow.h:
1707
1708 2011-03-30  Adam Barth  <abarth@webkit.org>
1709
1710         Reviewed by Adam Roben.
1711
1712         SheriffBot rollouts take too long
1713         https://bugs.webkit.org/show_bug.cgi?id=57498
1714
1715         We used to build before landing rollouts via the commit-queue to
1716         prevent further breakage, but now that our individual commit-queue
1717         machines are slower, building takes too long.  I can't remember the
1718         last time a rollout broke compile.  It seems like just landing the
1719         patch is the better trade-off.
1720
1721         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1722         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1723
1724 2011-03-30  Adam Barth  <abarth@webkit.org>
1725
1726         Remove platform/chromium-mac-snowleopard
1727         https://bugs.webkit.org/show_bug.cgi?id=57486
1728
1729         This directory no longer exists, so we can remove it from the fallback
1730         chain.
1731
1732         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1733
1734 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1735
1736         Reviewed by Adam Roben.
1737
1738         Rename Windows configuration Release_LTCG to Production for clarity
1739         https://bugs.webkit.org/show_bug.cgi?id=57465
1740
1741         * DumpRenderTree/DumpRenderTree.sln:
1742         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1743         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
1744         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
1745         * DumpRenderTree/win/DumpRenderTree.vcproj:
1746         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
1747         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
1748         * DumpRenderTree/win/ImageDiff.vcproj:
1749         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
1750         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
1751         * FindSafari/FindSafari.vcproj:
1752         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
1753         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
1754         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
1755         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
1756         * MiniBrowser/MiniBrowser.vcproj:
1757         * Scripts/webkitdirs.pm:
1758         * TestWebKitAPI/win/TestWebKitAPI.sln:
1759         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1760         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1761         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1762         * WebKitAPITest/WebKitAPITest.vcproj:
1763         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
1764         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
1765         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1766         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
1767         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
1768         * WebKitTestRunner/WebKitTestRunner.sln:
1769         * WebKitTestRunner/win/InjectedBundle.vcproj:
1770         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1771         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
1772         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
1773         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1774         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
1775         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
1776         * WinLauncher/WinLauncher.vcproj:
1777         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
1778         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
1779         * record-memory-win/record-memory-win.vcproj:
1780         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
1781         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
1782
1783 2011-03-30  MORITA Hajime  <morrita@google.com>
1784
1785         Reviewed by Dimitri Glazkov.
1786
1787         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
1788         https://bugs.webkit.org/show_bug.cgi?id=56573
1789
1790         Added LayoutTestController.shadowRoot() to Chromium DRT.
1791
1792         * DumpRenderTree/chromium/LayoutTestController.cpp:
1793         (LayoutTestController::LayoutTestController):
1794         (LayoutTestController::shadowRoot):
1795         * DumpRenderTree/chromium/LayoutTestController.h:
1796
1797 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
1798
1799         Reviewed by Kent Tamura.
1800
1801         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
1802         https://bugs.webkit.org/show_bug.cgi?id=57430
1803
1804         * DumpRenderTree/chromium/LayoutTestController.cpp:
1805         (LayoutTestController::LayoutTestController):
1806         (LayoutTestController::setPluginsEnabled):
1807         * DumpRenderTree/chromium/LayoutTestController.h:
1808
1809 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1810
1811         Reviewed by Adam Barth.
1812
1813         make webkit-patch upload respect -d
1814         https://bugs.webkit.org/show_bug.cgi?id=57425
1815
1816         * Scripts/webkitpy/common/checkout/scm.py:
1817         * Scripts/webkitpy/tool/steps/commit.py:
1818
1819 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1820
1821         Reviewed by Adam Barth.
1822
1823         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
1824         https://bugs.webkit.org/show_bug.cgi?id=57429
1825
1826         * Scripts/webkitpy/common/checkout/scm.py:
1827
1828 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1829
1830         Unreviewed, rolling out r82383.
1831         http://trac.webkit.org/changeset/82383
1832         https://bugs.webkit.org/show_bug.cgi?id=57417
1833
1834         "nrwt isn't shutting down cleanly" (Requested by dpranke on
1835         #webkit).
1836
1837         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1838         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1839         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1840
1841 2011-03-29  Kent Tamura  <tkent@chromium.org>
1842
1843         Reviewed by Dimitri Glazkov.
1844
1845         Make validation message bubble testable
1846         https://bugs.webkit.org/show_bug.cgi?id=57290
1847
1848         * DumpRenderTree/mac/DumpRenderTree.mm:
1849         (createWebViewAndOffscreenWindow): Change a setting so that validation
1850           bubbles isn't hidden automatically.
1851
1852 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
1853
1854         Reviewed by Ojan Vafai.
1855
1856         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
1857
1858         It's a bit unclear whether multiple threads or multiple
1859         processes will be a better model on windows. This change will
1860         test threads for now while we're still working out the bugs in
1861         multiple-processes.
1862
1863         https://bugs.webkit.org/show_bug.cgi?id=57410
1864
1865         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1866         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1867         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1868
1869 2011-03-29  David Levin  <levin@chromium.org>
1870
1871         Reviewed by Shinichiro Hamaji.
1872
1873         check-webkit-style confused by two ChangeLog entries in a row from same user
1874         https://bugs.webkit.org/show_bug.cgi?id=57250
1875
1876         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
1877         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
1878         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
1879           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
1880           checking more than that would be very messey.
1881         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
1882         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
1883
1884 2011-03-29  Kent Tamura  <tkent@chromium.org>
1885
1886         Reviewed by Dimitri Glazkov.
1887
1888         [Mac] Enable interactive-validation tests on Mac DRT
1889         https://bugs.webkit.org/show_bug.cgi?id=57308
1890
1891         * DumpRenderTree/mac/DumpRenderTree.mm:
1892         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
1893
1894 2011-03-29  Chang Shu  <cshu@webkit.org>
1895
1896         Reviewed by Kenneth Rohde Christiansen.
1897
1898         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1899         https://bugs.webkit.org/show_bug.cgi?id=42692
1900
1901         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1902         (WTR::InjectedBundle::beginTesting):
1903         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1904         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
1905         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1906
1907 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
1908
1909         Reviewed by Xan Lopez.
1910
1911         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
1912         https://bugs.webkit.org/show_bug.cgi?id=57067
1913
1914         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
1915         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
1916         update DRT and pixel results as hundreds of results will need to be updated.
1917
1918         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1919         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
1920         by overriding the theme RC/CSS files.
1921
1922 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
1923
1924         Reviewed by Adam Roben.
1925
1926         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1927         https://bugs.webkit.org/show_bug.cgi?id=57394
1928
1929         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1930         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1931         the IDE. To avoid this, add a separate vsprops file for each project configuration that
1932         contains the required inherited property sheets.
1933
1934         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1935         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
1936         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
1937         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
1938         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
1939         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
1940         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
1941         * DumpRenderTree/win/DumpRenderTree.vcproj:
1942         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
1943         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
1944         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
1945         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
1946         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
1947         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
1948         * DumpRenderTree/win/ImageDiff.vcproj:
1949         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
1950         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1951         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1952         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1953         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1954         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1955         * FindSafari/FindSafari.vcproj:
1956         * FindSafari/FindSafariDebug.vsprops: Added.
1957         * FindSafari/FindSafariDebugAll.vsprops: Added.
1958         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1959         * FindSafari/FindSafariRelease.vsprops: Added.
1960         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1961         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1962         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1963         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1964         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1965         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1966         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1967         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1968         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1969         * MiniBrowser/MiniBrowser.vcproj:
1970         * WebKitAPITest/WebKitAPITest.vcproj:
1971         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1972         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1973         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1974         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1975         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1976         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1977         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1978         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1979         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1980         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1981         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1982         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1983         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1984         * WebKitTestRunner/win/InjectedBundle.vcproj:
1985         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1986         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1987         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1988         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1989         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1990         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1991         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1992         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1993         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1994         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1995         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1996         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1997         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1998         * WinLauncher/WinLauncher.vcproj:
1999         * WinLauncher/WinLauncherDebug.vsprops: Added.
2000         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2001         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2002         * WinLauncher/WinLauncherRelease.vsprops: Added.
2003         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2004         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2005         * record-memory-win/record-memory-win.vcproj:
2006         * record-memory-win/record-memory-winDebug.vsprops: Added.
2007         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2008         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2009         * record-memory-win/record-memory-winRelease.vsprops: Added.
2010         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2011         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2012
2013 2011-03-29  Adam Barth  <abarth@webkit.org>
2014
2015         Reviewed by Darin Adler.
2016
2017         test_runner2.py can crash due to undefined variable
2018         https://bugs.webkit.org/show_bug.cgi?id=57356
2019
2020         Replace reference to undefined variable with a variable that's actually
2021         defined.  AFAICT, there's no way to test this code.
2022
2023         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2024
2025 2011-03-29  Tony Chang  <tony@chromium.org>
2026
2027         Reviewed by Eric Seidel.
2028
2029         cleanup rebaseline-chromium-webkit-tests
2030         https://bugs.webkit.org/show_bug.cgi?id=57375
2031
2032         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2033             - Split _extract_and_add_new_baselines into 3 functions
2034             - Reduce the amount of line wrapping (the file already has lines
2035               over 80 col, so may as well try to make the file consistent)
2036             - Remove unnecessary ()s
2037
2038 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2039
2040         Reviewed by Adam Roben.
2041
2042         Make WinCairo a core builder.
2043         https://bugs.webkit.org/show_bug.cgi?id=57373
2044
2045         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2046         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2047
2048 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2049
2050         Update update-webkit-localizable-strings to understand that WebKit and
2051         WebKit2 strings go in WebCore.
2052
2053         Also make extract-localizable-strings optionally use an exclude file. No individual
2054         warnings are produced about unlocalized strings when there is no exclude file. This
2055         is needed for WebCore, since there are too many bare strings.
2056
2057         https://webkit.org/b/57354
2058
2059         Reviewed by Sam Weinig.
2060
2061         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2062         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2063
2064 2011-03-29  Darin Adler  <darin@apple.com>
2065
2066         Reviewed by Adam Roben.
2067
2068         WebKit2 bundle page needs to offer generated file hooks
2069         https://bugs.webkit.org/show_bug.cgi?id=57279
2070
2071         (Land missing part of the original patch after r82289.)
2072
2073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2074         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2075
2076 2011-03-29  Tony Chang  <tony@chromium.org>
2077
2078         Reviewed by Ojan Vafai.
2079
2080         [chromium] NRWT should be able to read checksums from png comments
2081         https://bugs.webkit.org/show_bug.cgi?id=57280
2082
2083         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2084             from a file.
2085         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2086         * Scripts/webkitpy/common/system/filesystem_mock.py:
2087         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2088             if the -checksum.txt file doesn't exist, try looking in the png.
2089         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2090         * Scripts/webkitpy/layout_tests/port/test.py:
2091         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2092             2k for a png comment with the checksum
2093         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2094
2095 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2096
2097         Rubber-stamped by Gustavo Noronha Silva.
2098
2099         [GTK] http/tests/uri/username-with-no-hostname.html fails
2100         https://bugs.webkit.org/show_bug.cgi?id=57325
2101
2102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2103         (willSendRequestCallback): URI host value check done case-insensitively.
2104
2105 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2106
2107         Reviewed by Martin Robinson.
2108
2109         [GTK] http/tests/uri/username-with-no-hostname.html fails
2110         https://bugs.webkit.org/show_bug.cgi?id=57325
2111
2112         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2113         (willSendRequestCallback): Check URI before submitting the request
2114         to WebCore.
2115
2116 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2117
2118         Reviewed by Ojan Vafai.
2119
2120         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2121         https://bugs.webkit.org/show_bug.cgi?id=57303
2122
2123         * DumpRenderTree/chromium/EventSender.cpp:
2124         (EventSender::doDragDrop):
2125         (EventSender::beginDragWithFiles):
2126
2127 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2128
2129         Reviewed by Andreas Kling.
2130
2131         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2132         https://bugs.webkit.org/show_bug.cgi?id=57314
2133
2134         Provide possibility to print loaded urls to the standard output.
2135
2136         * MiniBrowser/qt/BrowserWindow.cpp:
2137         (BrowserWindow::BrowserWindow):
2138         (BrowserWindow::printURL):
2139         * MiniBrowser/qt/BrowserWindow.h:
2140         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2141         (MiniBrowserApplication::handleUserOptions):
2142         * MiniBrowser/qt/MiniBrowserApplication.h:
2143         (WindowOptions::WindowOptions):
2144         * QtTestBrowser/launcherwindow.cpp:
2145         (LauncherWindow::initializeView):
2146         (LauncherWindow::printURL):
2147         (LauncherWindow::cloneWindow):
2148         * QtTestBrowser/launcherwindow.h:
2149         (WindowOptions::WindowOptions):
2150         * QtTestBrowser/main.cpp:
2151         (LauncherApplication::handleUserOptions):
2152
2153 2011-03-29  Gabor Loki  <loki@webkit.org>
2154
2155         Rubber-stamped by Csaba Osztrogonác.
2156
2157         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2158         https://bugs.webkit.org/show_bug.cgi?id=56918
2159
2160         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2161
2162 2011-03-28  Gabor Loki  <loki@webkit.org>
2163
2164         Reviewed by Csaba Osztrogonác.
2165
2166         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2167         https://bugs.webkit.org/show_bug.cgi?id=56918
2168
2169         * Scripts/build-jsc:
2170         * Scripts/webkitdirs.pm:
2171
2172 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2173
2174         Reviewed by Ojan Vafai.
2175
2176         webkit-patch should be more intelligent about whether a bug applies to a patch
2177         Create a new function, parse_bug_id_from_changelog() which determines
2178         that a bug is related to a patch by parsing the output generated from
2179         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2180         the description of a patch.
2181         https://bugs.webkit.org/show_bug.cgi?id=56989
2182
2183         * Scripts/webkitpy/common/checkout/api.py:
2184         * Scripts/webkitpy/common/checkout/changelog.py:
2185         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2186         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2187         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2188         * Scripts/webkitpy/style/checkers/changelog.py:
2189         * Scripts/webkitpy/tool/commands/upload.py:
2190
2191 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2192
2193         Revert accidentally commited change.
2194
2195         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2196         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2197
2198 2011-03-28  Tony Chang  <tony@chromium.org>
2199
2200         Reviewed by Adam Barth.
2201
2202         [chromium] have DRT write the png checksum into a png comment
2203         https://bugs.webkit.org/show_bug.cgi?id=57255
2204
2205         * DumpRenderTree/chromium/TestShell.cpp:
2206         (TestShell::dumpImage):
2207
2208 2011-03-28  Adele Peterson  <adele@apple.com>
2209
2210         Removing Qt stub, since it doesn't use the same header as the others.
2211
2212         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2213
2214 2011-03-28  Adele Peterson  <adele@apple.com>
2215
2216         Added a few more stubs.
2217
2218         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2219         (LayoutTestController::hasGrammarMarker):
2220         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2221         (LayoutTestController::hasGrammarMarker):
2222         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2223         (LayoutTestController::hasGrammarMarker):
2224
2225 2011-03-28  Adele Peterson  <adele@apple.com>
2226
2227         Build fix.
2228
2229         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2230         (LayoutTestController::hasGrammarMarker):
2231
2232 2011-03-28  Adele Peterson  <adele@apple.com>
2233
2234         Reviewed by Eric Seidel.
2235
2236         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2237         https://bugs.webkit.org/show_bug.cgi?id=57173
2238
2239         * DumpRenderTree/LayoutTestController.cpp:
2240         (hasGrammarMarkerCallback): Added.
2241         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2242         * DumpRenderTree/LayoutTestController.h:
2243         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2244         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2245
2246 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2247
2248         Reviewed by Benjamin Poulain.
2249
2250         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2251         https://bugs.webkit.org/show_bug.cgi?id=57087
2252
2253         Trivial typo fix after r82082.
2254
2255         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2256         (WTR::activateFonts):
2257
2258 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2259
2260         Reviewed by Andreas Kling.
2261
2262         Add myself to the committers list.
2263
2264         * Scripts/webkitpy/common/config/committers.py:
2265
2266 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2267
2268         Reviewed by Sam Weinig.
2269
2270         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2271         to link against WebKit.framework for now.
2272
2273         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2274
2275 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2276
2277         Reviewed by Andreas Kling.
2278
2279         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2280         https://bugs.webkit.org/show_bug.cgi?id=57087
2281
2282         Disable QT_ASCII_CAST_WARNINGS for applications.
2283
2284         * DumpRenderTree/qt/DumpRenderTree.pro:
2285         * DumpRenderTree/qt/ImageDiff.pro:
2286         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2287         * MiniBrowser/qt/MiniBrowser.pro:
2288         * QtTestBrowser/QtTestBrowser.pro:
2289         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2290
2291 2011-03-28  Andreas Kling  <kling@webkit.org>
2292
2293         Reviewed by Kenneth Rohde Christiansen.
2294
2295         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2296         https://bugs.webkit.org/show_bug.cgi?id=57224
2297
2298         * QtTestBrowser/mainwindow.cpp:
2299         (MainWindow::buildUI):
2300         (MainWindow::onTitleChanged):
2301         * QtTestBrowser/mainwindow.h:
2302
2303 2011-03-27  Jer Noble  <jer.noble@apple.com>
2304
2305         Reviewed by Maciej Stachowiak.
2306
2307         Full Screen: disable keyboard access by default
2308         https://bugs.webkit.org/show_bug.cgi?id=56684
2309
2310         Accept the withKeyboard parameter to supportsFullScreenForElement.
2311
2312         * DumpRenderTree/mac/UIDelegate.mm:
2313         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2314
2315 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2316
2317         Reviewed by David Levin.
2318
2319         check-webkit-style should check ChangeLog for a valid bug number
2320         https://bugs.webkit.org/show_bug.cgi?id=57184
2321
2322         * Scripts/webkitpy/style/checker.py:
2323         * Scripts/webkitpy/style/checker_unittest.py:
2324         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2325         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2326
2327 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2328
2329         Reviewed by Andreas Kling.
2330
2331         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2332         https://bugs.webkit.org/show_bug.cgi?id=57087
2333
2334         Use explicit conversion for string to avoid depending on the default codec
2335         installed by the user code.
2336
2337         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2338         (WTR::activateFonts):
2339
2340 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2341
2342         Revert inadvertantly committed changes.
2343
2344         * Scripts/old-run-webkit-tests:
2345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2346
2347 2011-03-26  Andreas Kling  <kling@webkit.org>
2348
2349         Reviewed by Kenneth Rohde Christiansen.
2350
2351         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2352         https://bugs.webkit.org/show_bug.cgi?id=57162
2353
2354         * QtTestBrowser/QtTestBrowser.qrc:
2355         * QtTestBrowser/favicon.png: Added.
2356         * QtTestBrowser/locationedit.cpp:
2357         (defaultPageIcon):
2358         (LocationEdit::LocationEdit):
2359         (LocationEdit::setPageIcon):
2360         (LocationEdit::resizeEvent):
2361         (LocationEdit::updateInternalGeometry):
2362         * QtTestBrowser/locationedit.h:
2363         * QtTestBrowser/mainwindow.cpp:
2364         (MainWindow::buildUI):
2365         (MainWindow::onIconChanged):
2366         (MainWindow::onLoadStarted):
2367         * QtTestBrowser/mainwindow.h:
2368
2369 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
2370
2371         Reviewed by Xan Lopez.
2372
2373         [GTK] Force DumpRenderTree to use 96 DPI
2374         https://bugs.webkit.org/show_bug.cgi?id=56866
2375
2376         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2377         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2378
2379         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2380         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2381         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2382         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2383
2384 2011-03-25  Andy Estes  <aestes@apple.com>
2385
2386         Reviewed by Adele Peterson.
2387
2388         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2389         https://bugs.webkit.org/show_bug.cgi?id=49016
2390
2391         TestNetscapePlugIn needs to register support for an image MIME type so
2392         we can test that the embed tag prefers plug-ins to render image MIME
2393         types.
2394
2395         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2396         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2397         (NP_GetMIMEDescription): Ditto.
2398         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2399
2400 2011-03-25  Jessie Berlin  <jberlin@apple.com>
2401
2402         Reviewed by Sam Weinig.
2403
2404         WebKit2: Need to be able to set and get the Cookie Storage Policy.
2405         https://bugs.webkit.org/show_bug.cgi?id=50780
2406
2407         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2408
2409         The test is named "CookieManager" so that we can eventually exercise more of the
2410         CookieManager functionality in the test.
2411
2412         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2413         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2414         Assert that the policy returned is equal to the policy set in
2415         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2416         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2417         Set the policy to something different than the user's policy and get the policy again.
2418         (TestWebKitAPI::didFinishLoadForFrame):
2419         Get the user's policy so that it can be restored at the end of the test.
2420         (TestWebKitAPI::TEST):
2421         Load about:blank so that the Web Process gets instatiated (needed to get the
2422         CookieManager).
2423
2424         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2425         Add CookieManager.cpp.
2426
2427 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2428
2429         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2430
2431         * wx/build/settings.py:
2432
2433 2011-03-24  Ilya Sherman  <isherman@chromium.org>
2434
2435         Reviewed by Adam Roben.
2436
2437         Implement layoutTestController.setAutoFilled in DRT on Windows
2438         https://bugs.webkit.org/show_bug.cgi?id=56828
2439
2440         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2441         (LayoutTestController::setAutofilled): Implemented.
2442
2443 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2444
2445         Unreviewed build correction.
2446
2447         Correct vsprops file for Debug variant of the CFLite build.
2448         Disable a CFNETWORK-specific test when building for CFLite.
2449
2450         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2451         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2452
2453 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2454
2455         Reviewed by Adam Barth.
2456
2457         fix regressions introduced in 81908 - there were a couple of
2458         code paths that only fired under python 2.5 that I missed.
2459
2460         Also change a couple of 'python' references to sys.executable
2461         in order to handle runing test-webkitpy with a binary other than
2462         something called 'python'.
2463
2464         https://bugs.webkit.org/show_bug.cgi?id=57063
2465
2466         * Scripts/webkitpy/layout_tests/port/mac.py:
2467         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2468         * Scripts/webkitpy/test/cat.py:
2469         * Scripts/webkitpy/test/echo.py:
2470
2471 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2472
2473         Unreviewed build correction.
2474
2475         Add a stub implementation of the TestInvocation dumping logic.
2476         Update project files to reflect new file.
2477
2478         * WebKitTestRunner/cairo: Added.
2479         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2480         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2481         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2482
2483 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2484
2485         Reviewed by Tony Chang.
2486
2487         new-run-webkit-tests: clean up worker model defaults. This
2488         changes the default behavior to 'threads' instead of
2489         'old-threads', and clarifies that chromium-win-* and
2490         chromium-mac-leopard are exceptions.
2491
2492         https://bugs.webkit.org/show_bug.cgi?id=56971
2493
2494         * Scripts/webkitpy/layout_tests/port/base.py:
2495         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2496         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2497         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2498         * Scripts/webkitpy/layout_tests/port/test.py:
2499         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2500
2501 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
2502
2503         Reviewed by Darin Adler.
2504
2505         Media Stream API: fix the order of the options in build-webkit.
2506         https://bugs.webkit.org/show_bug.cgi?id=56949
2507
2508         Fix the order of the options in build-webkit.
2509
2510         * Scripts/build-webkit:
2511
2512 2011-03-23  Adam Klein  <adamk@chromium.org>
2513
2514         Reviewed by Mihai Parparita.
2515
2516         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2517         https://bugs.webkit.org/show_bug.cgi?id=56884
2518
2519         This option will be utilized by Chromium's ui_tests to allow
2520         referencing js-test-resources from a layout test over HTTP.
2521
2522         * Scripts/new-run-webkit-httpd:
2523         Added --layout_tests_dir option.
2524         * Scripts/webkitpy/layout_tests/port/http_server.py:
2525         Plumbed through as layout_tests_dir param.
2526
2527 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
2528
2529         Reviewed by Mihai Parparita.
2530
2531         new-run-webkit-tests: run tests in ascending alphabetical order per
2532         dir. This is a second attempt at the fix; the first attempt, in 
2533         r81597, broke the behavior on the old-inline and old-threads
2534         worker models.
2535
2536         https://bugs.webkit.org/show_bug.cgi?id=56760
2537
2538         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2539         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2540         * Scripts/webkitpy/layout_tests/port/test.py:
2541         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2542
2543 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
2544
2545         Reviewed by Martin Robinson.
2546
2547         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2548         https://bugs.webkit.org/show_bug.cgi?id=56953
2549
2550         Print the string for the detail of 'property-change' signal.
2551
2552         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2553         (axObjectEventListener): Print the detail string.
2554
2555 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
2556
2557         Reviewed by Pavel Feldman.
2558
2559         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2560         https://bugs.webkit.org/show_bug.cgi?id=56843
2561
2562         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2563         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2564
2565 2011-03-22  Eric Seidel  <eric@webkit.org>
2566
2567         Reviewed by Adam Barth.
2568
2569         Teach update-webkit about gyp
2570         https://bugs.webkit.org/show_bug.cgi?id=56881
2571
2572         This makes it possible for someone who builds from Xcode
2573         to just run update-webkit --gyp and have the project files
2574         generated after update automatically.
2575
2576         I also added a stand-alone "generate-project-files" script
2577         wrapping Source/gyp/configure.  This makes running gyp simpler
2578         since most people will not have gyp or Source/gyp in their path.
2579
2580         * Scripts/build-webkit:
2581         * Scripts/generate-project-files: Added.
2582         * Scripts/update-webkit:
2583
2584 2011-03-22  Anton D'Auria  <adauria@apple.com>
2585
2586         Reviewed by Alexey Proskuryakov.
2587
2588         Add +[WebApplicationCache getOriginsWithCache]
2589         https://bugs.webkit.org/show_bug.cgi?id=56722
2590
2591         * DumpRenderTree/LayoutTestController.cpp:
2592         (originsWithApplicationCacheCallback):
2593         (LayoutTestController::staticFunctions):
2594         * DumpRenderTree/LayoutTestController.h:
2595         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2596         (LayoutTestController::originsWithApplicationCache):
2597         * DumpRenderTree/chromium/LayoutTestController.h:
2598         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2599         (LayoutTestController::originsWithApplicationCache):
2600         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2601         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2602         (LayoutTestController::originsWithApplicationCache):
2603         (LayoutTestController::originsWithLocalStorage):
2604         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2605         (LayoutTestController::originsWithApplicationCache):
2606         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2607         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2608         (LayoutTestController::originsWithApplicationCache):
2609         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2610         (LayoutTestController::originsWithApplicationCache):
2611
2612 2011-03-22  Eric Seidel  <eric@webkit.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         Add support to build-webkit for building with gyp-generated project files
2617         https://bugs.webkit.org/show_bug.cgi?id=56877
2618
2619         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2620         Eventually we'll want to support gyp-generated projects in a more general manner.
2621
2622         * Scripts/build-webkit:
2623
2624 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2625
2626         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2627
2628         Reviewed by Joseph Pecoraro.
2629
2630         * Scripts/build-webkit: Updated usage statement to include
2631         --dsym.
2632         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2633         (generateDsym): Added. Call determineGenerateDsym() and
2634         return $generateDsym.
2635         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2636         $generateDsym.
2637         (argumentsForXcode): Added.  Returns additional arguments for
2638         xcodebuild based on command-line switches.
2639         (XcodeOptions): Updated to include argumentsForXcode() in the
2640         array returned.
2641
2642 2011-03-22  Adam Roben  <aroben@apple.com>
2643
2644         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2645
2646         These bots are consistently green again.
2647
2648         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2649         core builders
2650
2651         Rubber-stamped by Antti Koivisto.
2652
2653         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2654         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2655
2656         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2657         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2658
2659 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2660
2661         Unreviewed, rolling out r81597.
2662         http://trac.webkit.org/changeset/81597
2663         https://bugs.webkit.org/show_bug.cgi?id=56801
2664
2665         Change results in lots of unexpected flaky on the dashboard.
2666         (Requested by pfeldman on #webkit).
2667
2668         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2669         * Scripts/webkitpy/layout_tests/port/test.py:
2670         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2671
2672 2011-03-21  Sam Weinig  <sam@webkit.org>
2673
2674         Fix failing tests on the WebKit2 bots.
2675
2676         * WebKitTestRunner/TestController.cpp:
2677         (WTR::TestController::resetStateToConsistentValues):
2678
2679 2011-03-21  Daniel Sievers  <sievers@google.com>
2680
2681         Reviewed by Simon Fraser.
2682
2683         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2684         https://bugs.webkit.org/show_bug.cgi?id=56139
2685
2686         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2687         (main):
2688         * DumpRenderTree/chromium/LayoutTestController.cpp:
2689         (LayoutTestController::LayoutTestController):
2690         (LayoutTestController::layerTreeAsText):
2691         * DumpRenderTree/chromium/LayoutTestController.h:
2692         (LayoutTestController::setShowDebugLayerTree):
2693         * DumpRenderTree/chromium/TestShell.cpp:
2694         (TestShell::runFileTest):
2695         (TestShell::dump):
2696         * DumpRenderTree/chromium/TestShell.h:
2697         (TestParams::TestParams):
2698
2699 2011-03-21  Adam Roben  <aroben@apple.com>
2700
2701         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2702
2703         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2704         output as plain text
2705
2706         Reviewed by David Kilzer.
2707
2708         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2709         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
2710         to the master.
2711         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
2712         since we're running on the build master, not the slave. Instead, turn the raw source of
2713         actual.html which the build slave uploaded into an HTML log.
2714
2715 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
2716
2717         Reviewed by Mihai Parparita.
2718
2719         new-run-webkit-tests: run tests in ascending alphabetical order per dir
2720         https://bugs.webkit.org/show_bug.cgi?id=56760
2721
2722         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2723         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2724         * Scripts/webkitpy/layout_tests/port/test.py:
2725
2726 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
2727
2728         Reviewed by Steve Block.
2729
2730         Media Stream API patch 0: adding compilation guards.
2731         https://bugs.webkit.org/show_bug.cgi?id=56458
2732
2733         Adding options to enable the media stream API feature in Chromium.
2734
2735         * Scripts/build-webkit:
2736
2737 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
2738
2739         Reviewed by Laszlo Gombos.
2740
2741         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
2742         https://bugs.webkit.org/show_bug.cgi?id=56323
2743
2744         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
2745         "--stdout" or "--stderr" option.
2746
2747         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2748         (WebCore::DumpRenderTree::~DumpRenderTree):
2749         (WebCore::DumpRenderTree::processArgsLine):
2750         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2751         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2752         (WebCore::DumpRenderTree::setRedirectOutputFileName):
2753         (WebCore::DumpRenderTree::setRedirectErrorFileName):
2754         * DumpRenderTree/qt/main.cpp:
2755         (isOption):
2756         (takeOptionValue):
2757         (printUsage):
2758         (main):
2759
2760 2011-03-21  Adam Roben  <aroben@apple.com>
2761
2762         Fix exceptions on the buildbot due to my last change
2763
2764         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2765         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
2766
2767 2011-03-21  Adam Roben  <aroben@apple.com>
2768
2769         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
2770
2771         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2772         output as plain text
2773
2774         Reviewed by Darin Adler.
2775
2776         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2777         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
2778         logs.
2779         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
2780         the build master. This will correctly treat it as HTML.
2781
2782 2011-03-20  Bill Budge  <bbudge@chromium.org>
2783
2784         Reviewed by Adam Barth.
2785
2786         Rename ThreadSafeShared to ThreadSafeRefCounted
2787         https://bugs.webkit.org/show_bug.cgi?id=56714
2788
2789         No new tests. Exposes no new functionality.
2790
2791         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
2792         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
2793         * Scripts/do-webcore-rename:
2794
2795 2011-03-19  Anton D'Auria  <adauria@apple.com>
2796
2797         Reviewed by Dan Bernstein.
2798
2799         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
2800         https://bugs.webkit.org/show_bug.cgi?id=56719
2801
2802         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
2803         (LayoutTestController::clearApplicationCacheForOrigin):
2804
2805 2011-03-19  Anton D'Auria  <adauria@apple.com>
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2810         https://bugs.webkit.org/show_bug.cgi?id=56415
2811
2812         * DumpRenderTree/LayoutTestController.cpp:
2813         (clearApplicationCacheForOriginCallback):
2814         (LayoutTestController::staticFunctions):
2815         * DumpRenderTree/LayoutTestController.h:
2816         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
2817         (LayoutTestController::LayoutTestController):
2818         (LayoutTestController::clearAllApplicationCaches):
2819         (LayoutTestController::clearApplicationCacheForOrigin): 
2820         * DumpRenderTree/chromium/LayoutTestController.h:
2821         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
2822         (LayoutTestController::clearApplicationCacheForOrigin):
2823         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
2824         (LayoutTestController::clearApplicationCacheForOrigin):
2825         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2826         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
2827         (LayoutTestController::clearApplicationCacheForOrigin):
2828         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
2829         (LayoutTestController::clearApplicationCacheForOrigin):
2830
2831 2011-03-18  Dan Bernstein  <mitz@apple.com>
2832
2833         Revised build fix for r81135.
2834
2835         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2836         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2837
2838 2011-03-18  Adam Roben  <aroben@apple.com>
2839
2840         Windows build fix
2841
2842         * WebKitTestRunner/config.h: Add a missing #endif.
2843
2844 2011-03-18  Andreas Kling  <kling@webkit.org>
2845
2846         Unbreak Qt build after r81494.
2847
2848         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2849         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2850
2851 2011-03-18  Sam Weinig  <sam@webkit.org>
2852
2853         Fix windows build. This was really Adam Roben's fault. I swear!
2854
2855         * WebKitTestRunner/config.h:
2856
2857 2011-03-18  Sam Weinig  <sam@webkit.org>
2858
2859         Reviewed by Adam Roben.
2860
2861         Pixel tests don't work in WebKitTestRunner on Windows
2862         https://bugs.webkit.org/show_bug.cgi?id=56630
2863
2864         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
2865         built-in snapshotting instead of using the window server on the Mac.
2866
2867         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2868         (WTR::InjectedBundle::InjectedBundle):
2869         (WTR::InjectedBundle::didReceiveMessage):
2870         (WTR::InjectedBundle::beginTesting):
2871         (WTR::InjectedBundle::done):
2872         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2873         (WTR::InjectedBundle::setPixelResult):
2874         (WTR::InjectedBundle::shouldDumpPixels):
2875         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2876         (WTR::InjectedBundlePage::dump):
2877         Take the snapshot in the bundle and send it to the UIProcess for dumping.
2878
2879         * WebKitTestRunner/TestInvocation.cpp:
2880         (WTR::TestInvocation::invoke):
2881         (WTR::TestInvocation::dump):
2882         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2883         * WebKitTestRunner/TestInvocation.h:
2884         * WebKitTestRunner/cg: Added.
2885         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
2886         (WTR::createCGContextFromImage):
2887         (WTR::computeMD5HashStringForContext):
2888         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2889         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2890         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
2891
2892         * WebKitTestRunner/win/TestInvocationWin.cpp:
2893         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2894         Keep stub for Cairo build.
2895
2896         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
2897         Add CG configuration.
2898
2899         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2900         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2901         Add new files.
2902
2903 2011-03-18  Adam Roben  <aroben@apple.com>
2904
2905         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
2906
2907         Rubber-stamped by Simon Fraser.
2908
2909         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2910         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
2911         overflow-y:overlay so that the scrollbar doesn't overlay the content.
2912
2913 2011-03-18  Adam Roben  <aroben@apple.com>
2914
2915         Don't ellipsize long or indented function names in Leaks Viewer
2916
2917         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
2918         scrollbar
2919
2920         Reviewed by Simon Fraser.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2923         (.data-grid .data-container):
2924         (.data-grid td > div, .data-grid th > div):
2925         Allow the contents to extend to the right.
2926
2927 2011-03-18  Adam Roben  <aroben@apple.com>
2928
2929         Fix some leaks in DRT seen on the leaks bot
2930
2931         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
2932         setWillSendRequestClearHeaderCallback in DRT are leaky
2933
2934         Reviewed by Alexey Proskuryakov.
2935
2936         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
2937
2938         * DumpRenderTree/LayoutTestController.cpp:
2939         (addURLToRedirectCallback):
2940         (setWillSendRequestClearHeaderCallback):
2941         Use OwnArrayPtr to cause the strings to be deleted.
2942
2943 2011-03-18  Adam Roben  <aroben@apple.com>
2944
2945         Fix a NSURLCredential leak seen on the leaks bot
2946
2947         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
2948         connection:didReceiveAuthenticationChallenge:] is leaky
2949
2950         Reviewed by John Sullivan.
2951
2952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2953         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2954         cause the NSURLCredential to be released.
2955
2956 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2957
2958         Unreviewed.
2959
2960         Remove unnecessary brackets around my email address.
2961
2962         * Scripts/webkitpy/common/config/committers.py:
2963
2964 2011-03-18  Adam Roben  <aroben@apple.com>
2965         
2966         Remove some files I accidentally added in r81454
2967
2968         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2969         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2970
2971 2011-03-18  Adam Roben  <aroben@apple.com>
2972
2973         Ignore an NSNumberFormatter leak on SnowLeopard
2974
2975         * Scripts/old-run-webkit-tests:
2976         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2977         getObjectValue:forString:errorDescription:].
2978
2979 2011-03-18  Adam Roben  <aroben@apple.com>
2980
2981         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2982
2983         Rubber-stamped by Mark Rowe.
2984
2985         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2986         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2987         released.
2988
2989 2011-03-17  Adam Roben  <aroben@apple.com>
2990
2991         Address a review comment I missed in r81445
2992
2993         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2994         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2995         leaked bytes to speed up searching on long lines.
2996
2997 2011-03-17  Adam Roben  <aroben@apple.com>
2998
2999         Mark leaky builds orange, even if all regression tests passed
3000
3001         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3002         build.webkit.org when all tests pass even though there are still leaks
3003
3004         Reviewed by Dan Bernstein.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3007         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3008         be marked orange if this build step generates warnings.
3009
3010 2011-03-17  Adam Roben  <aroben@apple.com>
3011
3012         Allow values in Leaks Viewer to be shown as percentages
3013
3014         Double-clicking on a column will toggle between showing percentages and showing real values.
3015
3016         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3017         number of leaked bytes in Leaks Viewer
3018
3019         Reviewed by Joe Pecoraro.
3020
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3022         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3023         node's totalTime, which is used in calculating percentages.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3026         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
3027         showing them as percentages.
3028
3029 2011-03-17  Adam Roben  <aroben@apple.com>
3030
3031         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
3032
3033         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
3034         the number of leaked allocations. And the new Average column shows the average number of
3035         leaked bytes per call.
3036
3037         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
3038         just how many allocations
3039
3040         Reviewed by Joe Pecoraro.
3041
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3043         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3044         line and store it with the leak stack.
3045         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3046         properties.
3047         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3048         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3049         .numberOfCalls now holds the number of leaked allocations.
3050
3051         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3052         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3053         appear.
3054         (monkeyPatchInspectorObjects): Format the values as bytes.
3055
3056 2011-03-17  Adam Roben  <aroben@apple.com>
3057
3058         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3059
3060         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3061         regression tests
3062
3063         Reviewed by James Robinson.
3064
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3066         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3067         is always populated, even when all regression tests pass.
3068
3069 2011-03-10  Hayato Ito  <hayato@chromium.org>
3070
3071         Reviewed by Tony Chang.
3072
3073         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3074
3075         https://bugs.webkit.org/show_bug.cgi?id=56076
3076
3077         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3078
3079 2011-03-17  Adam Roben  <aroben@apple.com>
3080
3081         Skip a compositing-sensitive test when accelerated compositing is disabled
3082
3083         Reviewed by Sam Weinig.
3084
3085         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3086         accelerated compositing is disabled.
3087
3088 2011-03-17  Adam Roben  <aroben@apple.com>
3089
3090         Start using PlatformSpecificScheduler for the Mac builders
3091
3092         The current set of file/directory patterns should work for Mac builders. We may discover
3093         that there are more files and directories we can exclude from the Mac builds, but they can
3094         be added later.
3095
3096         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3097
3098         Reviewed by Mark Rowe.
3099
3100         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3101         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3102
3103         * Scripts/webkitpy/common/config/build.py:
3104         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3105         cleaned up patterns a little bit.
3106
3107         * Scripts/webkitpy/common/config/build_unittest.py:
3108         (ShouldBuildTest): Fixed some expected results.
3109         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3110         platforms.
3111
3112 2011-03-17  Jeff Miller  <jeffm@apple.com>
3113
3114         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3115         
3116         *.mode*
3117         *.pbxuser
3118         *.perspective*
3119         project.xcworkspace
3120         xcuserdata
3121
3122         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3123         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3124         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3125         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3126         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3127
3128 2011-03-17  Adam Roben  <aroben@apple.com>
3129
3130         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3131
3132         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3133         mac-wk2
3134
3135         Reviewed by Anders Carlsson.
3136
3137         * Scripts/old-run-webkit-tests:
3138         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3139         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3140         we're running in WebKit2 mode.
3141
3142 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3143
3144         Reviewed by Yury Semikhatsky.
3145
3146         Web Inspector: Clean up Inspector strings.
3147         https://bugs.webkit.org/show_bug.cgi?id=56557
3148
3149         Modify the script to deal correctly with "\xNN" escapes, and to
3150         check strings in Chromium's DevTools.js.
3151
3152         * Scripts/check-inspector-strings:
3153
3154 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3155
3156         Reviewed by Benjamin Poulain.
3157
3158         Update autoinstall to install mechanize 0.2.4
3159         https://bugs.webkit.org/show_bug.cgi?id=56499
3160
3161         Newer versions of mechanize support HTTPS proxies, which is necessary
3162         for people using webkit-patch behind firewalls.
3163
3164         * Scripts/webkitpy/common/system/autoinstall.py:
3165         * Scripts/webkitpy/thirdparty/__init__.py:
3166
3167 2011-03-16  Sam Weinig  <sam@webkit.org>
3168
3169         Reviewed by Adam Roben.
3170
3171         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3172         https://bugs.webkit.org/show_bug.cgi?id=56541
3173
3174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3175         (WTR::InjectedBundlePage::willSendRequestForFrame):
3176         Check for an empty host in addition to a null host.  This bug was introduced
3177         when porting off of the KURL code and onto the WKURLRef version.
3178
3179 2011-03-16  Sam Weinig  <sam@webkit.org>
3180
3181         Reviewed by Adam Roben.
3182
3183         Add Lucas Forschler to the list of WebKit committers.
3184
3185         * Scripts/webkitpy/common/config/committers.py:
3186
3187 2011-03-16  Sam Weinig  <sam@webkit.org>
3188
3189         Reviewed upon and dictated through Adam Roben.
3190
3191         Escape crashing function names in results.html. This fixes an issue
3192         when a crash involves a type with templates.
3193
3194         * Scripts/old-run-webkit-tests:
3195
3196 2011-03-16  Daniel Sievers  <sievers@google.com>
3197
3198         Reviewed by James Robinson.
3199
3200         Add setting to always force compositing mode
3201         https://bugs.webkit.org/show_bug.cgi?id=56156
3202
3203         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3204         (main):
3205         * DumpRenderTree/chromium/TestShell.cpp:
3206         (TestShell::TestShell):
3207         (TestShell::resetWebSettings):
3208         * DumpRenderTree/chromium/TestShell.h:
3209         (TestShell::setForceCompositingMode):
3210         * DumpRenderTree/chromium/WebPreferences.cpp:
3211         (WebPreferences::reset):
3212         (WebPreferences::applyTo):
3213         * DumpRenderTree/chromium/WebPreferences.h:
3214
3215 2011-03-15  Hayato Ito  <hayato@chromium.org>
3216
3217         Reviewed by Ojan Vafai.
3218
3219         Ignore files that will be used by reftests in old-run-webkit-tests.
3220
3221         https://bugs.webkit.org/show_bug.cgi?id=55936
3222
3223         * Scripts/old-run-webkit-tests:
3224
3225 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3226
3227         Reviewed by Adam Roben.
3228
3229         Function relativeScriptsDir doesn't return the correct relative
3230         Scripts directory.
3231
3232         * Scripts/webkitdirs.pm:
3233         (relativeScriptsDir): Ensure we use the directory that contains
3234         webkitdirs.pm, not the one that contains the original script that
3235         was invoked.
3236
3237 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3238
3239         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3240         fix to link against the Security framework after recent WebKitSystemInterface changes.
3241
3242         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3243         (LayoutTestController::originsWithLocalStorage):
3244         * wx/build/settings.py:
3245         * wx/build/waf_extensions.py:
3246
3247 2011-03-15  Sam Weinig  <sam@webkit.org>
3248
3249         Reviewed by Darin Adler.
3250
3251         Add script to convert a patch to a prettypatch and show in the default browser
3252         https://bugs.webkit.org/show_bug.cgi?id=56416
3253
3254         This can be used either like
3255             $ svn-create-patch | show-pretty-diff
3256         or
3257             $ show-pretty-diff patch.diff
3258
3259         * Scripts/show-pretty-diff: Added.
3260
3261 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3262
3263         Rubber-stamped by Adam Roben.
3264
3265         Adding myself as a reviewer.
3266
3267         * Scripts/webkitpy/common/config/committers.py:
3268
3269 2011-03-15  Anders Carlsson  <andersca@apple.com>
3270
3271         Try to fix the Windows build.
3272
3273         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3274         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3275
3276 2011-03-15  Anders Carlsson  <andersca@apple.com>
3277
3278         Reviewed by Sam Weinig.
3279
3280         Make sure that NP_Shutdown is always the last NPP function called
3281         https://bugs.webkit.org/show_bug.cgi?id=56391
3282
3283         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3284
3285         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3286         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3287         (PluginTest::PluginTest):
3288         (PluginTest::NP_Shutdown):
3289         (PluginTest::registerNPShutdownFunction):
3290         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3291         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3292         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3293         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3294         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3295         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3296         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3297         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3298         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3299         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3300         (NP_Shutdown):
3301         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3302         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3303         * GNUmakefile.am:
3304
3305 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3306
3307         Reviewed by Tony Chang.
3308
3309         Autofilled form elements are assigned fixed background color but not text color
3310         https://bugs.webkit.org/show_bug.cgi?id=48382
3311
3312         * DumpRenderTree/LayoutTestController.cpp:
3313         (setAutofilledCallback): Added.
3314         (LayoutTestController::staticFunctions):
3315         * DumpRenderTree/LayoutTestController.h:
3316         * DumpRenderTree/chromium/LayoutTestController.cpp:
3317         (LayoutTestController::LayoutTestController):
3318         (LayoutTestController::setAutofilled): Added.
3319         * DumpRenderTree/chromium/LayoutTestController.h:
3320         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3321         (LayoutTestController::setAutofilled): Added.
3322         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3323         (LayoutTestController::setAutofilled): Added.
3324         (LayoutTestController::setValueForUser): Style tweak.
3325         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3326         (LayoutTestController::setAutofilled): Added (stub).
3327         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3328         (LayoutTestController::setAutofilled): Added (stub).
3329
3330 2011-03-15  Dan Bernstein  <mitz@apple.com>
3331
3332         Build fix after r81135.
3333
3334         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3335
3336 2011-03-15  Dan Bernstein  <mitz@apple.com>
3337
3338         Build fix after r81135.
3339
3340         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3341         * WebKitTestRunner/mac/TestControllerMac.mm:
3342         * WebKitTestRunner/mac/TestInvocationMac.mm:
3343         * WebKitTestRunner/mac/main.mm:
3344
3345 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3346
3347         Reviewed by Adam Barth.
3348
3349         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3350         https://bugs.webkit.org/show_bug.cgi?id=56349
3351
3352         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3353         on platforms where we use it. Copied from DumpRenderTree.pro.
3354
3355 2011-03-15  Dan Bernstein  <mitz@apple.com>
3356
3357         Build fix after r81135.
3358
3359         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3360         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3361
3362 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3363
3364         Reviewed by Darin Adler.
3365
3366         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3367         info into the headers rather than in export symbol definition files, but disable it on 
3368         all platforms initially so we can deal with port build issues one port at a time.
3369         
3370         https://bugs.webkit.org/show_bug.cgi?id=27551
3371
3372         * DumpRenderTree/cg/ImageDiffCG.cpp:
3373         * DumpRenderTree/chromium/config.h:
3374         * DumpRenderTree/config.h:
3375         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3376         * TestWebKitAPI/TestWebKitAPIPrefix.h:
3377         * WebKitAPITest/HostWindow.cpp:
3378         * WebKitAPITest/TestsController.cpp:
3379         * WebKitAPITest/config.h: Added.
3380         * WebKitAPITest/main.cpp:
3381         * WebKitAPITest/tests/WebViewDestruction.cpp:
3382         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
3383         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3384         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3385         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3386         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3387         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3388         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3389         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3390         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3391         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3392         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3393         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3394         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3395         * WebKitTestRunner/TestController.cpp:
3396         * WebKitTestRunner/TestInvocation.cpp:
3397         * WebKitTestRunner/config.h: Added.
3398         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3399         * WebKitTestRunner/qt/TestControllerQt.cpp:
3400         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3401         * WebKitTestRunner/qt/main.cpp:
3402         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3403         * WebKitTestRunner/win/TestControllerWin.cpp:
3404         * WebKitTestRunner/win/TestInvocationWin.cpp:
3405         * WebKitTestRunner/win/main.cpp:
3406         * wx/build/settings.py:
3407
3408 2011-03-15  Hayato Ito  <hayato@chromium.org>
3409
3410         Reviewed by Shinichiro Hamaji.
3411
3412         [NRWT] Add support for reftests to new-run-webkit-tests.
3413
3414         https://bugs.webkit.org/show_bug.cgi?id=55457
3415
3416         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3417         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3418         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3419         * Scripts/webkitpy/layout_tests/port/base.py:
3420         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3421         * Scripts/webkitpy/layout_tests/port/test.py:
3422         * Scripts/webkitpy/layout_tests/port/test_files.py:
3423         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3424
3425 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
3426
3427         Reviewed by Martin Robinson.
3428
3429         [GTK] Fix compilation warning after r80892
3430         https://bugs.webkit.org/show_bug.cgi?id=56302
3431
3432         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3433         (LayoutTestController::originsWithLocalStorage):
3434
3435 2011-03-15  Robert Hogan  <robert@webkit.org>
3436
3437         Reviewed by Adam Barth.
3438
3439         Document the qmakearg argument, and hint how to build webkit2 on Qt
3440         https://bugs.webkit.org/show_bug.cgi?id=56326
3441
3442         * Scripts/build-webkit: add --qmakearg to build-webkit --help
3443
3444 2011-03-15  Adam Roben  <aroben@apple.com>
3445
3446         Make Windows 7 Release (Tests) a core builder
3447
3448         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3449         give it a few more days of greenness first.
3450
3451         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3452
3453         Reviewed by Sam Weinig.
3454
3455         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3456         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3457
3458         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3459         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3460         Updated the core regexps to match the buildbot module. Updated the expected results to match
3461         the current set of core builders.
3462
3463 2011-03-14  Adam Roben  <aroben@apple.com>
3464
3465         Add forgotten file from r81116
3466
3467         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
3468
3469 2011-03-14  Sam Weinig  <sam@webkit.org>
3470
3471         Reviewed by Adam Roben.
3472
3473         about:blank fake responses don't get serialized when sent the UIProcess
3474         <rdar://problem/9108119>
3475         https://bugs.webkit.org/show_bug.cgi?id=56357
3476
3477         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
3478         (TestWebKitAPI::decidePolicyForResponse):
3479         (TestWebKitAPI::TEST):
3480         Add test that loads of about:blank have a response with a MIMEType of text/html.
3481
3482         * TestWebKitAPI/PlatformUtilities.h:
3483         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3484         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3485         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3486         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3487         Add helper to get the MIMEType from a WKURLResponse.
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3490         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3491         Add new files.
3492
3493 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3494
3495         Reviewed by Kenneth Rohde Christiansen.
3496
3497         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
3498         https://bugs.webkit.org/show_bug.cgi?id=56006
3499
3500         * QtTestBrowser/launcherwindow.cpp:
3501         (LauncherWindow::initializeView):
3502         * QtTestBrowser/main.cpp:
3503         (LauncherApplication::handleUserOptions):
3504
3505 2011-03-14  James Kozianski  <koz@chromium.org>
3506
3507         Reviewed by Ojan Vafai.
3508
3509         Add method to make BuildBot return test outputs
3510         https://bugs.webkit.org/show_bug.cgi?id=54374
3511
3512         The Builder.latest_cached_build will be used by the new rebaseline
3513         script to determine the build to use baselines from.
3514
3515         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3516         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3517
3518 2011-03-14  Adam Roben  <aroben@apple.com>
3519
3520         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
3521
3522         Reviewed by Sam Weinig.
3523
3524         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
3525         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
3526         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
3527         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
3528         ensure the web process is initialized, then ask the bundle to run the test and assert that
3529         it succeeded.
3530
3531         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
3532         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
3533         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
3534         handle a given URL.
3535         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
3536         URL type cannot be handled).
3537         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
3538         result.
3539
3540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3541         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3542         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3543         Added new files to the project.
3544
3545 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3546
3547         Unreviewed, rolling out r81094.
3548         http://trac.webkit.org/changeset/81094
3549         https://bugs.webkit.org/show_bug.cgi?id=56355
3550
3551         Broke the chromium DRT related build. (Requested by dave_levin
3552         on #webkit).
3553
3554         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3555         (main):
3556         * DumpRenderTree/chromium/LayoutTestController.cpp:
3557         (LayoutTestController::LayoutTestController):
3558         (LayoutTestController::layerTreeAsText):
3559         * DumpRenderTree/chromium/LayoutTestController.h:
3560         * DumpRenderTree/chromium/TestShell.cpp:
3561         (TestShell::runFileTest):
3562         (TestShell::dump):
3563         * DumpRenderTree/chromium/TestShell.h:
3564         (TestParams::TestParams):
3565
3566 2011-03-14  Daniel Sievers  <sievers@google.com>
3567
3568         Reviewed by Simon Fraser.
3569
3570         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3571         https://bugs.webkit.org/show_bug.cgi?id=56139
3572
3573         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3574         (main):
3575         * DumpRenderTree/chromium/LayoutTestController.cpp:
3576         (LayoutTestController::LayoutTestController):
3577         (LayoutTestController::layerTreeAsText):
3578         * DumpRenderTree/chromium/LayoutTestController.h:
3579         (LayoutTestController::setShowDebugLayerTree):
3580         * DumpRenderTree/chromium/TestShell.cpp:
3581         (TestShell::runFileTest):
3582         (TestShell::dump):
3583         * DumpRenderTree/chromium/TestShell.h:
3584         (TestParams::TestParams):
3585
3586 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3587
3588         Reviewed by Adam Roben.
3589
3590         [Qt][WK2]Unbreak InjectedBundle on Qt
3591         https://bugs.webkit.org/show_bug.cgi?id=54109
3592
3593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3594         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3595         API's instead of KURL to analyze the URL.
3596         * WebKitTestRunner/StringFunctions.h:
3597         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3598         in the WebKitTestRunner project.
3599         (WTR::toWK): Use adoptWK.
3600         (WTR::operator<<): Added helper for printing a WKURL.
3601         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3602         against WebCore.
3603
3604 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3605
3606         Reviewed by Kenneth Rohde Christiansen.
3607
3608         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3609         https://bugs.webkit.org/show_bug.cgi?id=56321
3610
3611         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3612         to the list of exceptions for WebKit2 C API headers.
3613
3614 2011-03-14  Adam Roben  <aroben@apple.com>
3615
3616         Show the list of recent leaky builds in reverse chronological order
3617
3618         Previously they were being shown in a deterministic but surprising order based on
3619         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3620
3621         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3622
3623         Reviewed by Darin Adler.
3624
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3626         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3627         callback.
3628
3629 2011-03-14  Adam Roben  <aroben@apple.com>
3630
3631         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3632
3633         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3634         analyze
3635
3636         Reviewed by David Kilzer and Joe Pecoraro.
3637
3638         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3639         (#url-prompt): Made this a bit taller to make room for the list of builds.
3640
3641         (#recent-builds-loading-indicator):
3642         (#recent-builds-list):
3643         Added styles for the build list and loading indicator.
3644
3645         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3646         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3647         it. This will unescape it.
3648         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3649         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3650         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3651         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3652         prompt UI.
3653         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3654         now also used when a recent build is clicked.
3655
3656         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3657         (RecentBuildsLoader): Store the callback.
3658         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3659         builder. Find the revision number, leak count, and results URL for each one. Pass the
3660         resulting info to our callback.
3661
3662         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3663         (range): Added this helper function to return an array containing the integers [0, n).
3664
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3666         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3667
3668 2011-03-14  Mark Rowe  <mrowe@apple.com>
3669
3670         Reviewed by Adam Roben.
3671
3672         Fix two memory leaks within LayoutTestController's storage support.
3673
3674         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3675         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3676         by JSStringCreateWithCFString.