4bb92681b4fe529a3ce6e8b9c1869c57769aa560
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
4         https://bugs.webkit.org/show_bug.cgi?id=71466
5
6         Reviewed by Martin Robinson.
7
8         * MiniBrowser/gtk/BrowserWindow.c:
9         (browserWindowHistoryItemActivated): Go to selected back formard
10         list item using webkit_web_view_go_to_back_forward_list_item()
11         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
12         given GList of WebKitBackForwardListItems.
13         (browserWindowUpdateNavigationActions): Enable/disable back and
14         forward buttons depending on whether it's possible to go
15         back/forward. Create a menu for back and forward toolbar buttons.
16         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
17         (browserWindowConstructed): Connect to WebKitBackForwardList
18         changed signal.
19
20 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
21
22         [Qt] Remove Maemo specific code paths
23         https://bugs.webkit.org/show_bug.cgi?id=71476
24
25         Reviewed by Kenneth Rohde Christiansen.
26
27         * QtTestBrowser/launcherwindow.cpp:
28         (LauncherWindow::~LauncherWindow):
29         (LauncherWindow::init):
30         (LauncherWindow::showLinkHover):
31         (LauncherWindow::selectElements):
32         (LauncherWindow::showFPS):
33         (LauncherWindow::updateFPS):
34         * QtTestBrowser/launcherwindow.h:
35         (WindowOptions::WindowOptions):
36         * QtTestBrowser/locationedit.cpp:
37         * QtTestBrowser/locationedit.h:
38
39 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
42         https://bugs.webkit.org/show_bug.cgi?id=71461
43
44         Reviewed by Martin Robinson.
45
46         * MiniBrowser/gtk/BrowserWindow.c:
47         (resetEntryProgress): Reset the entry progress after a while when
48         load has been completed.
49         (webViewLoadProgressChanged): Update location entry progress.
50         (browserWindowConstructed): Connect to WebView
51         notify::estimated-load-progress signal.
52
53 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
54
55         [GTK] Remove WebKit2 C API from MiniBrowser
56         https://bugs.webkit.org/show_bug.cgi?id=71459
57
58         Reviewed by Martin Robinson.
59
60         Use the GTK+ API instead to add minimum functionality. The other
61         features will be ported to GTK+ API in following patches.
62
63         * MiniBrowser/gtk/BrowserWindow.c:
64         (activateUriEntryCallback): Use webkit_web_view_load_uri().
65         (goBackCallback): Use webkit_web_view_go_back().
66         (goForwardCallback): Use webkit_web_view_go_forward().
67         (webViewURIChanged): Update location entry with current uri using
68         webkit_web_view_get_uri().
69         (browserWindowFinalize):
70         (browserWindowGetProperty):
71         (browserWindowSetProperty):
72         (browser_window_init):
73         (browserWindowConstructed): Connect to notify::uri signal of
74         WebView to be notified when the URI changes.
75         (browser_window_class_init):
76         (browser_window_new): Use WebKitWebView.
77         (browser_window_get_view): Use WebKitWebView
78         * MiniBrowser/gtk/BrowserWindow.h:
79         * MiniBrowser/gtk/GNUmakefile.am:
80         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
81         * MiniBrowser/gtk/main.c:
82         (loadURI): Use webkit_web_view_new().
83         (main):
84
85 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
86
87         [Qt] Unable to start MiniBrowser after run-webkit-tests
88         https://bugs.webkit.org/show_bug.cgi?id=71469
89
90         Reviewed by Csaba Osztrogonác.
91
92         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
93         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
94         line arguments.
95
96 2011-11-03  Philippe Normand  <pnormand@igalia.com>
97
98         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
99         https://bugs.webkit.org/show_bug.cgi?id=71445
100
101         Reviewed by Martin Robinson.
102
103         * DumpRenderTree/gtk/DumpRenderTree.cpp:
104         (initializeFonts): set directoriesDescription only when needed.
105         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
106         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
107         refactored the font files loading code to avoid copy/pastes, ease
108         maintenance and future font directories additions.
109
110 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
111
112         [GTK] Remove GtkLauncher2
113         https://bugs.webkit.org/show_bug.cgi?id=71449
114
115         Reviewed by Martin Robinson.
116
117         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
118         made sense when we wanted to implement the exactly same wk1 API
119         for wk2. Now the code would require an ifdef for most the api, so
120         it's better to remove GtkLauncher2 and port MiniBrowser to the new
121         GTK+ API.
122
123         * GNUmakefile.am:
124         * GtkLauncher/main.c:
125         (notifyProgressCb):
126         (closeWebViewCb):
127         (createBrowser):
128         (addWebSettingsGroupToContext):
129         (main):
130
131 2011-11-02  Philippe Normand  <pnormand@igalia.com>
132
133         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
134         https://bugs.webkit.org/show_bug.cgi?id=71359
135
136         Reviewed by Martin Robinson.
137
138         * DumpRenderTree/gtk/DumpRenderTree.cpp:
139         (initializeFonts): Add the new font path for Debian fonts and
140         refactored the font files loading code to avoid copy/pastes, ease
141         maintenance and future font directories additions.
142
143 2011-11-02  Eric Seidel  <eric@webkit.org>
144
145         Move Mocks into _mock files near their implementations
146         https://bugs.webkit.org/show_bug.cgi?id=71425
147
148         Reviewed by Adam Barth.
149
150         This entire change is splitting mocktool.py into separate _mock.py files
151         and placing them next to their real implementations.
152
153         I also deleted MockPortFactory (since it was wrong) and was just hiding
154         the fact that the "skipped-ports" command was broken (and has been for a long time).
155         So I made MockHost use a real PortFactory (passed a MockHost) and changed
156         the skipped-ports implementation to use modern PortFactory methods.
157
158         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
159         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
160         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
161         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
162         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
163         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
164         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
165         * Scripts/webkitpy/common/host.py:
166         * Scripts/webkitpy/common/host_mock.py: Added.
167         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
168         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
169         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
170         * Scripts/webkitpy/common/net/credentials_unittest.py:
171         * Scripts/webkitpy/common/net/failuremap_unittest.py:
172         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
173         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
174         * Scripts/webkitpy/common/net/statusserver_unittest.py:
175         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
176         * Scripts/webkitpy/common/system/executive.py:
177         * Scripts/webkitpy/common/system/executive_mock.py:
178         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
179         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
180         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
181         * Scripts/webkitpy/common/system/workspace_unittest.py:
182         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
183         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
184         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
185         * Scripts/webkitpy/layout_tests/port/__init__.py:
186         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
187         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
188         * Scripts/webkitpy/layout_tests/port/factory.py:
189         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
190         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
191         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
192         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
193         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
194         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
195         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
196         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
197         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
198         * Scripts/webkitpy/test/main.py:
199         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
200         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
201         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
202         * Scripts/webkitpy/tool/commands/queries_unittest.py:
203         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
204         * Scripts/webkitpy/tool/mocktool.py:
205         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
206
207 2011-11-02  Dan Bernstein  <mitz@apple.com>
208
209         Fixed the build and removed another copy to ColorBits.ttf.
210
211         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
212         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
213         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
214
215 2011-11-02  Dan Bernstein  <mitz@apple.com>
216
217         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
218         https://bugs.webkit.org/show_bug.cgi?id=71424
219
220         Reviewed by Sam Weinig.
221
222         Removed the ColorBits font and the code to register it in the process
223         running the tests. The font was only used by the aforementioned test,
224         which is now being removed.
225
226         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
227         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
228         * DumpRenderTree/mac/DumpRenderTree.mm:
229         (allowedFontFamilySet):
230         (activateTestingFonts):
231         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
232         (WTR::inititializeFontConfigSetting):
233         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
234         (WTR::allowedFontFamilySet):
235         (WTR::activateFonts):
236
237 2011-11-02  Dan Bernstein  <mitz@apple.com>
238
239         Fix an intermittent hang in RenderedImageFromDOMRange.
240
241         Reviewed by Anders Carlsson.
242
243         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
244         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
245         immediately if there are no sources by passing a date in the distant past.
246
247 2011-11-02  Adam Roben  <aroben@apple.com>
248
249         Add git-add-reviewer
250
251         I've been using this script for a while to add reviewers to git commits in my local
252         repository before pushing them to the Subversion repository. Basic usage is:
253
254         git-add-reviewer HEAD^ "Joe Schmoe"
255         or
256         git-add-reviewer -i trunk
257
258         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
259         git commits
260
261         Reviewed by Sam Weinig.
262
263         * Scripts/git-add-reviewer: Added.
264         (top level): Parse options, check that the working tree is clean, then run in either
265         interactive or non-interactive mode as appropriate.
266         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
267         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
268         editor exits, we check out the commit just before the earliest one we're modifying. Then
269         for each commit, we check it out, update the reviewer, and amend the commit to contain the
270         new reviewer. Finally, we update the branch that was originally checked out to point to the
271         last amended commit.
272         (nonInteractive): Check out the commit to modify, write the current commit message to the
273         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
274         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
275         a usage message and exit.
276         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
277         and index are clean.
278         (fail): Print out the specified error message, if any, and return false. This function is
279         used as a return value in various error cases throughout the script.
280         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
281         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
282         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
283         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
284
285         (addReviewerToChangeLog):
286         (addReviewerToCommitMessage):
287         These just call through to addReviewerToFile.
288
289         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
290         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
291         temp file, then move the temp file over the original file and stage it for the next commit.
292         (head): Returns the name of the currently-checked-out branch.
293         (isAncestor): Returns true if the first commit is an ancestor of the second.
294         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
295         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
296         (resetToCommit): Checks out the given commit, throwing away any local changes.
297         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
298         the specified file.
299         (rebaseOntoHead): Rebases the specified branch onto HEAD.
300         (checkout): Checks out the given commit.
301         (getConfigValue): Reads the specified config variable from git-config.
302
303 2011-11-02  Dean Jackson  <dino@apple.com>
304
305         Add ENABLE_CSS_SHADERS flag
306         https://bugs.webkit.org/show_bug.cgi?id=71394
307
308         Reviewed by Sam Weinig.
309
310         * Scripts/build-webkit:
311
312 2011-10-31  Eric Seidel  <eric@webkit.org>
313
314         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
315         https://bugs.webkit.org/show_bug.cgi?id=71237
316
317         Reviewed by Adam Barth.
318
319         Calling the static version of factory.get() with proper mocking
320         requires passsing an explict filesystem, executive, etc.
321         So instead, we use a PortFactory instance and pass it a Host pointer.
322         I had to add a MockHost since we'd not needed a non-host tool before now.
323
324         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
325         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
326         * Scripts/webkitpy/tool/commands/rebaseline.py:
327         * Scripts/webkitpy/tool/mocktool.py:
328
329 2011-11-02  Anders Carlsson  <andersca@apple.com>
330
331         Update for the WebKit2 API fixage.
332
333         * MiniBrowser/mac/BrowserWindowController.m:
334         (-[BrowserWindowController awakeFromNib]):
335         * WebKitTestRunner/TestController.cpp:
336         (WTR::TestController::initialize):
337
338 2011-11-02  Anders Carlsson  <andersca@apple.com>
339
340         Fix build.
341
342         Add new functions to the page loader client.
343
344         * MiniBrowser/mac/BrowserWindowController.m:
345         (-[BrowserWindowController awakeFromNib]):
346         * WebKitTestRunner/TestController.cpp:
347         (WTR::TestController::initialize):
348
349 2011-11-02  Dan Bernstein  <mitz@apple.com>
350
351         <rdar://problem/10336700> Add API to get rendered text image without having to select it
352         https://bugs.webkit.org/show_bug.cgi?id=71407
353
354         Reviewed by Simon Fraser.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
358         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
359         (TestWebKitAPI::TEST):
360
361 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
362
363         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
364         https://bugs.webkit.org/show_bug.cgi?id=71351
365
366         Reviewed by Darin Adler.
367
368         Add the delimiter "/" at the end of the path instead of adding +1 when using
369         the path.
370
371         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
372         (-[NSURL _drt_descriptionSuitableForTestResult]):
373
374 2011-11-02  Tom Sepez  <tsepez@chromium.org>
375
376         XSSAuditor is silent
377         https://bugs.webkit.org/show_bug.cgi?id=70973
378
379         Reviewed by Adam Barth.
380
381         * DumpRenderTree/chromium/WebViewHost.cpp:
382         (WebViewHost::didDetectXSS):
383         * DumpRenderTree/chromium/WebViewHost.h:
384         * DumpRenderTree/mac/FrameLoadDelegate.mm:
385         (-[FrameLoadDelegate webView:didDetectXSS:]):
386         * MiniBrowser/mac/BrowserWindowController.m:
387         (didDetectXSSForFrame):
388         (-[BrowserWindowController awakeFromNib]):
389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
390         (WTR::InjectedBundlePage::InjectedBundlePage):
391         (WTR::InjectedBundlePage::didDetectXSSForFrame):
392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
393
394 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
395
396         [Qt] REGRESSION: 5 editing tests fail
397         https://bugs.webkit.org/show_bug.cgi?id=71117
398
399         Reviewed by Andreas Kling.
400
401         Make sure that the view is properly focused, in order to get the
402         didBeginEditing DRT calls.
403
404         This requires activating the window (the call will result in a FocusIn
405         event to the window as well as setting QGuiApplication::focusWindow())
406         as well as enabling the focus on the view item. The signature of
407         setFocus has changed to take a boolean.
408
409         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
410         (WTR::WrapperWindow::handleStatusChanged):
411
412 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
413
414         [chromium] Add per-script font preferences support in overridePreference
415         https://bugs.webkit.org/show_bug.cgi?id=71110
416
417         This allows a layout test to do something like:
418
419         // Set standard font for Arabic to Ahem.
420         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
421
422         This should make writing a layout test for per-script fonts easier.
423
424         This change only affects the Chromium DumpRenderTree, but the other
425         platforms should probably also have a similar change eventually.
426
427         Reviewed by Tony Chang.
428
429         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
430         font preferences to overridePreference
431         (LayoutTestController::cppVariantToWebStringArray):
432         (setFontMap):
433         (LayoutTestController::overridePreference):
434         * DumpRenderTree/chromium/LayoutTestController.h:
435         * DumpRenderTree/chromium/WebPreferences.cpp:
436         (setStandardFontFamilyWrapper):
437         (setFixedFontFamilyWrapper):
438         (setSerifFontFamilyWrapper):
439         (setSansSerifFontFamilyWrapper):
440         (setCursiveFontFamilyWrapper):
441         (setFantasyFontFamilyWrapper):
442         (applyFontMap):
443         (WebPreferences::applyTo):
444         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
445         preference members
446         (WebPreferences::UScriptCodeHashTraits::emptyValue):
447         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
448         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
449
450 2011-11-02  Elliot Poger  <epoger@google.com>
451
452         until use_skia=1 by default on mac, default port should be chromium-cg-mac
453         https://bugs.webkit.org/show_bug.cgi?id=71312
454
455         Reviewed by Adam Barth.
456
457         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
458         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
459         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
460
461 2011-11-02  Stephen Chenney  <schenney@chromium.org>
462
463         printing layout test failures after r98634
464         https://bugs.webkit.org/show_bug.cgi?id=71080
465
466         Reviewed by Kent Tamura
467
468         * DumpRenderTree/chromium/WebViewHost.cpp:
469         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
470         matches that for Skia.
471
472 2011-11-01  Sam Weinig  <sam@webkit.org>
473
474         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
475         https://bugs.webkit.org/show_bug.cgi?id=71346
476
477         Reviewed by Dan Bernstein.
478
479         * Scripts/webkit-tools-completion.sh:
480         Add "-o default" which allows for completing files in addition to the word list.
481
482 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
483
484         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
485         https://bugs.webkit.org/show_bug.cgi?id=71310
486
487         Reviewed by Kenneth Rohde Christiansen.
488
489         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
490         define works in EventSendingController.idl
491         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
492         handlers.
493         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
494         required by tests.
495         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
496         ui process.
497         (WTR::EventSendingController::addTouchPoint):
498         (WTR::EventSendingController::updateTouchPoint):
499         (WTR::EventSendingController::setTouchModifier):
500         (WTR::EventSendingController::touchStart):
501         (WTR::EventSendingController::touchMove):
502         (WTR::EventSendingController::touchEnd):
503         (WTR::EventSendingController::clearTouchPoints):
504         (WTR::EventSendingController::releaseTouchPoint):
505         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
506         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
507         defines.
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
510         touch messages to the EventSenderProxy.
511         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
512         (WTR::EventSenderProxy::EventSenderProxy):
513         (WTR::EventSenderProxy::addTouchPoint):
514         (WTR::EventSenderProxy::updateTouchPoint):
515         (WTR::EventSenderProxy::setTouchModifier):
516         (WTR::EventSenderProxy::touchStart):
517         (WTR::EventSenderProxy::touchMove):
518         (WTR::EventSenderProxy::touchEnd):
519         (WTR::EventSenderProxy::clearTouchPoints):
520         (WTR::EventSenderProxy::releaseTouchPoint):
521         (WTR::EventSenderProxy::sendTouchEvent):
522         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
523
524 2011-11-01  Sam Weinig  <sam@webkit.org>
525
526         resolve-ChangeLogs --help should be faster.
527
528         Reviewed by Adam Roben.
529
530         * Scripts/resolve-ChangeLogs:
531         (usageAndExit):
532         Add a call to usageAndExit() before doing work to find unmerged changelogs
533         if --help or something illegal is provided on the command line.
534
535 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
536
537         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
538         https://bugs.webkit.org/show_bug.cgi?id=71342
539
540         Reviewed by Darin Adler.
541
542         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
543         [NSString substringFromIndex:] with an index out of the string range.
544
545         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
546         from the root of the disk.
547         The problem was hidden because the exception are catched when calling the delegate.
548
549         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
550         in a subdirectory of the main frame.
551
552         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
553         (-[NSURL _drt_descriptionSuitableForTestResult]):
554
555 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
556
557         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
558         https://bugs.webkit.org/show_bug.cgi?id=71318
559
560         Reviewed by James Robinson.
561         
562         Fixed a typo for --enable-hardware-gpu flag.
563
564         * Scripts/webkitpy/layout_tests/port/chromium.py:
565
566 2011-11-01  Elliot Poger  <epoger@google.com>
567
568         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
569         https://bugs.webkit.org/show_bug.cgi?id=71286
570
571         Reviewed by Stephen White.
572
573         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
574
575 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
576
577         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
578         https://bugs.webkit.org/show_bug.cgi?id=71299
579
580         Reviewed by Andreas Kling.
581
582         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
583         build to enable WebCoreTestSupport::injectInternalsObject.
584         (WTR::InjectedBundlePage::didClearWindowForFrame):
585         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
586
587 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
588
589         [Qt] Merge common desktop and touch view APIs under a base class.
590         https://bugs.webkit.org/show_bug.cgi?id=71280
591
592         Reviewed by Andreas Kling.
593
594         Remove unneded forwarding logic for TouchWebView since those properties are
595         now in the view just as the desktop web view.
596
597         * MiniBrowser/qt/qml/TouchView.qml:
598
599 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
600
601         check-webkit-style: Allow names starting with "_q_".
602         https://bugs.webkit.org/show_bug.cgi?id=70625
603
604         Reviewed by Tor Arne Vestbø.
605
606         Used by the Qt port as the standard prefix for private slots.
607
608         * Scripts/webkitpy/style/checkers/cpp.py:
609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
610
611 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
612
613         [Qt][WK2] Fix valgrind error about uninitialized variable
614         https://bugs.webkit.org/show_bug.cgi?id=71273
615
616         Reviewed by Kenneth Christiansen.
617
618         * MiniBrowser/qt/MiniBrowserApplication.cpp:
619         (MiniBrowserApplication::notify): Initialize isPrimary.
620
621 2011-10-31  Adam Roben  <aroben@apple.com>
622
623         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
624
625         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
626         leaky builds
627
628         Reviewed by Anders Carlsson.
629
630         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
631         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
632         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
633         total of N bytes!").
634
635 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
636
637         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
638         https://bugs.webkit.org/show_bug.cgi?id=71228
639
640         Reviewed by Antonio Gomes.
641
642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
643         (DumpRenderTreeChrome::createNewWindow):
644         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
645
646 2011-10-31  Eric Seidel  <eric@webkit.org>
647
648         webkitpy tests depend too much on the user's environment
649         https://bugs.webkit.org/show_bug.cgi?id=71234
650
651         Reviewed by Dirk Pranke.
652
653         This change just makes a bunch of our older tests use
654         more modern mocking to avoid trying to launch processes
655         or read from the user's filesystem during unittesting.
656
657         I found many of these by adding an assert in Executive.run_command
658         that we were not unittesting.  I can't add that assert always
659         as there are some valid uses of Executive during unittesting.
660         Once I fix more of these, I may find a way to add such an assert conditionally.
661
662         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
663         * Scripts/webkitpy/common/net/credentials_unittest.py:
664         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
665         * Scripts/webkitpy/layout_tests/port/base.py:
666         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
667
668 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
669
670         [Qt] MiniBrowser doesn't resize as the size is always overridden
671         https://bugs.webkit.org/show_bug.cgi?id=71212
672
673         Reviewed by Simon Hausmann.
674
675         Remove call overriden the size.
676
677         * MiniBrowser/qt/main.cpp:
678         (main):
679
680 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
681
682         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
683         http://trac.webkit.org/changeset/98819
684         http://trac.webkit.org/changeset/98823
685         http://trac.webkit.org/changeset/98825
686         http://trac.webkit.org/changeset/98830
687         https://bugs.webkit.org/show_bug.cgi?id=71199
688
689         Broke Chromium Windows bot (Requested by rniwa on #webkit).
690
691         * Scripts/webkitpy/layout_tests/port/base.py:
692         * Scripts/webkitpy/layout_tests/port/chromium.py:
693         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
694         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
695         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
696         * Scripts/webkitpy/layout_tests/port/efl.py:
697         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
698         * Scripts/webkitpy/layout_tests/port/mac.py:
699         * Scripts/webkitpy/layout_tests/port/qt.py:
700         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
701         * Scripts/webkitpy/layout_tests/port/webkit.py:
702         * Scripts/webkitpy/layout_tests/port/win.py:
703
704 2011-10-30  Eric Seidel  <eric@webkit.org>
705
706         new-run-webkit-tests is locale dependent
707         https://bugs.webkit.org/show_bug.cgi?id=68691
708
709         Unreviewed.
710
711         This is a temporary hack until someone from the cr-win port
712         can take a look and determine which environment variable
713         lighttpd is missing.
714
715         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
716
717 2011-10-30  Eric Seidel  <eric@webkit.org>
718
719         new-run-webkit-tests is locale dependent
720         https://bugs.webkit.org/show_bug.cgi?id=68691
721
722         Unreviewed.  I would have preferred to have this reviewed,
723         but relevant reviewers are asleep and bots are broken.
724
725         This was a regression from moving to a clean environment.
726         ChromiumWin (and possibly other ports), need the "PATH"
727         environment copied over.  This wasn't caught in my testing
728         because although we had unittests to cover this, they
729         weren't being run on anything but windows.  The vast majority
730         of this change is just fixing the unittests to use our
731         modern MockFileSystem/MockUser/MockExecutive so they can
732         be run on any system (and removing the platform checks from
733         the unittests so they are run everywhere).
734
735         The actual fix is the single line "PATH" string added to base.py.
736         The rest of this change is just fixing the Chromium port unittests
737         to run on all systems (including changing the Chromium port to
738         use FileSystem.path_to_module instead of __file__).
739
740         * Scripts/webkitpy/layout_tests/port/base.py:
741         * Scripts/webkitpy/layout_tests/port/chromium.py:
742         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
743         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
744         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
745         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
746
747 2011-10-29  Eric Seidel  <eric@webkit.org>
748
749         new-run-webkit-tests is locale dependent
750         https://bugs.webkit.org/show_bug.cgi?id=68691
751
752         Unreviewed.
753
754         Fix the Qt port and unittest the function so we don't break it again.
755
756         * Scripts/webkitpy/layout_tests/port/qt.py:
757         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
758
759 2011-10-29  Eric Seidel  <eric@webkit.org>
760
761         new-run-webkit-tests is locale dependent
762         https://bugs.webkit.org/show_bug.cgi?id=68691
763
764         Reviewed by Adam Barth.
765
766         Make NRWT use a clean environment just like ORWT did.
767         I've manually validated that NRWT now copies over
768         the same environment variables that ORWT did.
769         This new code is exercised by existing setup_environ_for_server tests.
770
771         * Scripts/webkitpy/layout_tests/port/base.py:
772         * Scripts/webkitpy/layout_tests/port/efl.py:
773         * Scripts/webkitpy/layout_tests/port/mac.py:
774         * Scripts/webkitpy/layout_tests/port/qt.py:
775         * Scripts/webkitpy/layout_tests/port/webkit.py:
776         * Scripts/webkitpy/layout_tests/port/win.py:
777
778 2011-10-29  Eric Seidel  <eric@webkit.org>
779
780         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
781         https://bugs.webkit.org/show_bug.cgi?id=34984
782
783         Reviewed by Adam Barth.
784
785         Move run-webkit-tests from using a white-list of supported NRWT ports
786         to a blacklist of ports requiring ORWT.
787
788         I've also added the ability to opt-in to parallel testing on a per-port basis.
789
790         With these changes I'm going to officially declare this bug dead and
791         work on remaining polish issues and individual developer complaints.
792
793         * Scripts/run-webkit-tests:
794         (useNewRunWebKitTests):
795         (platformIsReadyForParallelTesting):
796
797 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
798
799         Unreviewed, rolling out r98780.
800         http://trac.webkit.org/changeset/98780
801         https://bugs.webkit.org/show_bug.cgi?id=71173
802
803         Broke Qt bots (Requested by rniwa on #webkit).
804
805         * Scripts/run-webkit-tests:
806         (useNewRunWebKitTests):
807
808 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
809
810         webkit.py gdb visualizer is broken after change to StringImpl
811         https://bugs.webkit.org/show_bug.cgi?id=71154
812
813         Reviewed by Tony Chang.
814
815         r98624 changed StringImpl m_data to m_data32. This changes updates
816         webkit.py to match.
817
818         * gdb/webkit.py:
819
820 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
821
822         Fix typo in check-for-inappropriate-objc-class-names
823         https://bugs.webkit.org/show_bug.cgi?id=71144
824
825         Reviewed by Dan Bernstein.
826
827         * Scripts/check-for-inappropriate-objc-class-names:
828
829 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
830
831         Add support for sending scroll-update events from EventSender.
832         https://bugs.webkit.org/show_bug.cgi?id=66272
833
834         Reviewed by Adam Barth.
835
836         * DumpRenderTree/chromium/EventSender.cpp:
837         (EventSender::EventSender):
838         (EventSender::reset):
839         (EventSender::gestureScrollUpdate):
840         (EventSender::gestureEvent):
841         * DumpRenderTree/chromium/EventSender.h:
842
843 2011-10-28  Eric Seidel  <eric@webkit.org>
844
845         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
846         https://bugs.webkit.org/show_bug.cgi?id=34984
847
848         Reviewed by Adam Barth.
849
850         Move run-webkit-tests from using a white-list of supported NRWT ports
851         to a blacklist of ports requiring ORWT.
852
853         I've also added the ability to opt-in to parallel testing on a per-port basis.
854
855         With these changes I'm going to officially declare this bug dead and
856         work on remaining polish issues and individual developer complaints.
857
858         * Scripts/run-webkit-tests:
859         (useNewRunWebKitTests):
860         (platformIsReadyForParallelTesting):
861
862 2011-10-28  Eric Seidel  <eric@webkit.org>
863
864         NRWT crashes when parsing leaks output due to UTF-8 decoding error
865         https://bugs.webkit.org/show_bug.cgi?id=71112
866
867         Reviewed by Adam Barth.
868
869         Use read_binary_file instead of read_text_file and add a test
870         case with some non-utf8 data to make sure we don't break this in the future.
871
872         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
873         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
874
875 2011-10-28  David Levin  <levin@chromium.org>
876
877         watchlist should not CC the bug reporter
878         https://bugs.webkit.org/show_bug.cgi?id=71079
879
880         Reviewed by Adam Barth.
881
882         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
883         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
884
885         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
886         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
887         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
888
889 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
890
891         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
892         https://bugs.webkit.org/show_bug.cgi?id=71116
893
894         Reviewed by David Levin.
895
896         * Scripts/webkitpy/common/config/watchlist:
897
898 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
899
900         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
901         https://bugs.webkit.org/show_bug.cgi?id=70494
902
903         Reviewed by Kenneth Christiansen.
904
905         Use QQuick* instead of QSG* as well as QStandardPaths
906         instead of QDesktopLocation.
907
908         * MiniBrowser/qt/BrowserWindow.cpp:
909         (BrowserWindow::BrowserWindow):
910         * MiniBrowser/qt/BrowserWindow.h:
911         * QtTestBrowser/cookiejar.cpp:
912         (TestBrowserCookieJar::TestBrowserCookieJar):
913         * QtTestBrowser/launcherwindow.cpp:
914         (LauncherWindow::setDiskCache):
915         * WebKitTestRunner/PlatformWebView.h:
916         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
917         (WTR::WrapperWindow::WrapperWindow):
918         (WTR::WrapperWindow::handleStatusChanged):
919
920 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
921
922         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
923         https://bugs.webkit.org/show_bug.cgi?id=71106
924
925         Reviewed by Simon Hausmann.
926
927         Holding Ctrl allows multiple touch points to be held on the screen using
928         mouse buttons. It would previously only prevent TouchReleased to be sent
929         and would require another MouseButtonRelease to be sent without holding Ctrl.
930
931         This patch makes sure that all held touch points are released when Ctrl
932         is released if MouseButtonRelease was received.
933         It also removes the touch QEvent::Type logic since it's currently handled
934         by QtGui by observing the modified touch points.
935
936         * MiniBrowser/qt/MiniBrowserApplication.cpp:
937         (MiniBrowserApplication::notify):
938         (MiniBrowserApplication::sendTouchEvent):
939         * MiniBrowser/qt/MiniBrowserApplication.h:
940
941 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
942
943         [Qt] MiniBrowser needs a -window-size option
944         https://bugs.webkit.org/show_bug.cgi?id=70999
945
946         Reviewed by Simon Hausmann.
947
948         Add an -window-size option useful for testing the viewport handling.
949         Also clean up the option handling.
950
951         * MiniBrowser/qt/BrowserWindow.cpp:
952         (BrowserWindow::BrowserWindow):
953         * MiniBrowser/qt/MiniBrowserApplication.cpp:
954         (MiniBrowserApplication::handleUserOptions):
955         * MiniBrowser/qt/MiniBrowserApplication.h:
956         (WindowOptions::WindowOptions):
957         (WindowOptions::setRequestedWindowSize):
958         (WindowOptions::requestedWindowSize):
959         * MiniBrowser/qt/utils.cpp:
960         (takeOptionValue):
961         * MiniBrowser/qt/utils.h:
962
963 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
964
965         Add allowScriptFromSource callback to FrameLoaderClient
966         https://bugs.webkit.org/show_bug.cgi?id=71013
967
968         Reviewed by Darin Fisher.
969
970         * DumpRenderTree/chromium/LayoutTestController.cpp:
971         (LayoutTestController::LayoutTestController):
972         (LayoutTestController::setScriptsAllowed):
973         * DumpRenderTree/chromium/LayoutTestController.h:
974         * DumpRenderTree/chromium/WebPermissions.cpp:
975         (WebPermissions::allowScriptFromSource):
976         (WebPermissions::setScriptsAllowed):
977         (WebPermissions::reset):
978         * DumpRenderTree/chromium/WebPermissions.h:
979
980 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
981
982         Added myself as a committer.
983
984         * Scripts/webkitpy/common/config/committers.py:
985
986 2011-10-27  Adam Barth  <abarth@webkit.org>
987
988         Remove WinCairo from the set of core builders.  WinCairo rarely builds
989         and is never green.
990
991         Rubber-stamped by Eric Seidel.
992
993         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
994         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
995
996 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
997
998         WebSocket: Connecting to localhost:8880 takes one second on Windows
999         https://bugs.webkit.org/show_bug.cgi?id=64788
1000
1001         Reviewed by Dirk Pranke.
1002
1003         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1004         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1005         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1006         from timing out on Windows, because this test tries to open a lot of
1007         connections to localhost and each attempt takes one second to fall back from
1008         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1009
1010 2011-10-27  Adam Barth  <abarth@webkit.org>
1011
1012         Dis-integrate run-bindings-tests with webkitpy
1013         https://bugs.webkit.org/show_bug.cgi?id=71092
1014
1015         Reviewed by Ryosuke Niwa.
1016
1017         These tests aren't really adding any value.
1018
1019         * Scripts/webkitpy/common/config/ports.py:
1020         * Scripts/webkitpy/tool/commands/download_unittest.py:
1021         * Scripts/webkitpy/tool/mocktool.py:
1022         * Scripts/webkitpy/tool/steps/runtests.py:
1023         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1024         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1025
1026 2011-10-27  Eric Seidel  <eric@webkit.org>
1027
1028         REGRESSION (r98639): NRWT crashes when parsing leaks output
1029         https://bugs.webkit.org/show_bug.cgi?id=71087
1030
1031         Unreviewed.  Sadly we have no good way to test logging.
1032
1033         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1034
1035 2011-10-27  David Levin  <levin@chromium.org>
1036
1037         Test expectation errors should include the file name and platform in both the log and exception info.
1038         https://bugs.webkit.org/show_bug.cgi?id=71067
1039
1040         Reviewed by Ojan Vafai.
1041
1042         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1043         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1044
1045 2011-10-27  Eric Seidel  <eric@webkit.org>
1046
1047         new-run-webkit-tests doesn't understand --qt or --gtk
1048         https://bugs.webkit.org/show_bug.cgi?id=63970
1049
1050         Reviewed by Ojan Vafai.
1051
1052         Add support for --qt and --gtk to NRWT.
1053         I also removed some incorrect comments in the option parsing
1054         code (options which we already implement, but said we didn't)
1055         as well as moved --platform parsing out of the "results_options"
1056         section into the top configuration section.
1057
1058         Now run-webkit-tests no longer needs NRWT-specific code for passing
1059         --platform=qt, etc.
1060
1061         * Scripts/run-webkit-tests:
1062         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1063
1064 2011-10-27  Eric Seidel  <eric@webkit.org>
1065
1066         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
1067         https://bugs.webkit.org/show_bug.cgi?id=66227
1068
1069         Reviewed by Adam Roben.
1070
1071         I believe this should fix the bug.
1072
1073         * Scripts/run-webkit-tests: make NRWT default for --leaks
1074         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1075         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
1076         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
1077         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
1078         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1079         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
1080         * Scripts/webkitpy/layout_tests/port/mac.py:
1081         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
1082
1083 2011-10-27  Stephen Chenney  <schenney@chromium.org>
1084
1085         [Chromium] Need setPrinting
1086         https://bugs.webkit.org/show_bug.cgi?id=46152
1087
1088         Reviewed by Hajime Morita.
1089
1090         * DumpRenderTree/chromium/LayoutTestController.cpp:
1091         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
1092         (LayoutTestController::reset): Clearing flags for setPrinting.
1093         (LayoutTestController::setPrinting): Set flags for setPrinting.
1094         * DumpRenderTree/chromium/LayoutTestController.h:
1095         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
1096         (LayoutTestController::isPrinting): Method to return the setPrinting status.
1097         * DumpRenderTree/chromium/TestShell.cpp:
1098         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
1099         (TestShell::dump): Modified to dump setPrinting-specific output.
1100         * DumpRenderTree/chromium/WebViewHost.cpp:
1101         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
1102         active.
1103         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
1104
1105 2011-10-27  Sam Weinig  <sam@webkit.org>
1106
1107         Add allowsPlugIns property to WKBrowsingContextGroup
1108         https://bugs.webkit.org/show_bug.cgi?id=70987
1109
1110         Reviewed by Anders Carlsson.
1111
1112         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1113         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
1114
1115 2011-10-27  Adam Roben  <aroben@apple.com>
1116
1117         Test WKBundlePageGetBackingScaleFactor
1118
1119         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
1120         can't reliably determine the scale factor of snapshots returned via
1121         WKBundlePageCreateSnapshot* API
1122
1123         Reviewed by Sam Weinig.
1124
1125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1126
1127         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
1128         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
1129         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
1130         (TestWebKitAPI::createWindow): Conjure up a window.
1131         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
1132         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
1133         factors and when using a custom scale factor, and check that we get those same scale factors
1134         back.
1135
1136         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
1137         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
1138         members.
1139         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
1140         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
1141         from the page using the new API and send it back.
1142
1143 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
1144
1145         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
1146
1147         Rubber-stamped by Simon Hausmann.
1148
1149         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1150         (MiniBrowserApplication::handleUserOptions):
1151         Fix typo error.
1152
1153 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
1154
1155         [WebSocket] update pywebsocket to 0.7.
1156         https://bugs.webkit.org/show_bug.cgi?id=70992
1157
1158         Reviewed by Kent Tamura.
1159
1160         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
1161
1162         * Scripts/webkitpy/thirdparty/__init__.py:
1163
1164 2011-10-27  Elliot Poger  <epoger@google.com>
1165
1166         make lion observe MAC lines in test_expectations.txt
1167         https://bugs.webkit.org/show_bug.cgi?id=70941
1168
1169         Reviewed by Ojan Vafai.
1170
1171         * Scripts/webkitpy/layout_tests/port/chromium.py:
1172         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1173
1174 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
1175
1176         [Chromium] Allow DRT to be built without notifications enabled.
1177         https://bugs.webkit.org/show_bug.cgi?id=70919
1178
1179         Reviewed by Tony Gentilcore.
1180
1181         * DumpRenderTree/chromium/LayoutTestController.cpp:
1182         (LayoutTestController::grantDesktopNotificationPermission):
1183         (LayoutTestController::simulateDesktopNotificationClick):
1184         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1185         * DumpRenderTree/chromium/TestShell.cpp:
1186         (TestShell::TestShell):
1187         (TestShell::resetTestController):
1188
1189 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1190
1191         [Qt] Improve command line arguments handling for MiniBrowser.
1192         https://bugs.webkit.org/show_bug.cgi?id=70616
1193
1194         Reviewed by Kenneth Rohde Christiansen.
1195
1196         - Use two dashes for word arguments.
1197         - Return with an error when an unsupported argument is given.
1198         - Allow the URL to be placed before option arguments.
1199
1200         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1201         (printHelp):
1202         (MiniBrowserApplication::handleUserOptions):
1203         * MiniBrowser/qt/utils.cpp:
1204         (takeOptionFlag):
1205         (takeOptionValue):
1206         * MiniBrowser/qt/utils.h:
1207
1208 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
1209
1210         [Qt] NRWT doesn't work on qt-mac platform
1211         https://bugs.webkit.org/show_bug.cgi?id=64445
1212
1213         Reviewed by Adam Barth.
1214
1215         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
1216         (useNewRunWebKitTests):
1217         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
1218
1219 2011-10-26  Sam Weinig  <sam@webkit.org>
1220
1221         Add initial setting to WKBrowsingContextGroup
1222         https://bugs.webkit.org/show_bug.cgi?id=70942
1223
1224         Reviewed by Anders Carlsson.
1225
1226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1227         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
1228         Add basic test that setting the javaScriptEnabled setting takes. It is not
1229         possible to test its effect quite yet.
1230
1231 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
1232
1233         [GTK] [WK2] Add WebKit2 distcheck support
1234         https://bugs.webkit.org/show_bug.cgi?id=70933
1235
1236         Reviewed by Martin Robinson.
1237
1238         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
1239         sources and EXTRA_DIST.
1240
1241 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
1242
1243         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
1244
1245         Reviewed by Tor Arne Vestbø.
1246
1247         We're using QScroller since r98460, which requires QWidget/QApplication. So
1248         use QApplication and QtWidgets for the time being.
1249
1250         * MiniBrowser/qt/MiniBrowser.pro:
1251         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1252         (MiniBrowserApplication::MiniBrowserApplication):
1253         (MiniBrowserApplication::notify):
1254         * MiniBrowser/qt/MiniBrowserApplication.h:
1255
1256 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1257
1258         [Qt][WK2] Rewrite MiniBrowser in QML
1259         https://bugs.webkit.org/show_bug.cgi?id=70315
1260
1261         Add the first QML based implementation of MiniBrowser.
1262
1263         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1264                  Zeno Albisser <zeno.albisser@nokia.com>
1265
1266         Reviewed by Tor Arne Vestbø.
1267
1268         * MiniBrowser/qt/BrowserWindow.cpp:
1269         (BrowserWindow::BrowserWindow):
1270         (BrowserWindow::webView):
1271         (BrowserWindow::load):
1272         (BrowserWindow::keyPressEvent):
1273         (BrowserWindow::~BrowserWindow):
1274         * MiniBrowser/qt/BrowserWindow.h:
1275         * MiniBrowser/qt/MiniBrowser.pro:
1276         * MiniBrowser/qt/MiniBrowser.qrc:
1277         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1278         (MiniBrowserApplication::MiniBrowserApplication):
1279         (MiniBrowserApplication::handleUserOptions):
1280         * MiniBrowser/qt/MiniBrowserApplication.h:
1281         (WindowOptions::WindowOptions):
1282         * MiniBrowser/qt/UrlLoader.cpp:
1283         (UrlLoader::UrlLoader):
1284         * MiniBrowser/qt/icons/next.png: Added.
1285         * MiniBrowser/qt/icons/previous.png: Added.
1286         * MiniBrowser/qt/icons/refresh.png: Added.
1287         * MiniBrowser/qt/icons/stop.png: Added.
1288         * MiniBrowser/qt/main.cpp:
1289         (main):
1290         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
1291
1292 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
1293
1294         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
1295         https://bugs.webkit.org/show_bug.cgi?id=70529
1296
1297         Remove obsolete code for a new QML based implementation
1298         of MiniBrowser.
1299         Change BrowserWindow to derive from QSGView instead of
1300         QMainWindow. QSGView is used as a top level window that
1301         provides the container for placing QML content.
1302         Make MiniBrowserApplication derive from QGuiApplication
1303         instead of QApplication.
1304
1305         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1306                  Zeno Albisser <zeno.albisser@nokia.com>
1307
1308         Reviewed by Simon Hausmann.
1309
1310         * MiniBrowser/qt/BrowserView.cpp: Removed.
1311         * MiniBrowser/qt/BrowserView.h: Removed.
1312         * MiniBrowser/qt/BrowserWindow.cpp:
1313         (BrowserWindow::BrowserWindow):
1314         (BrowserWindow::load):
1315         (BrowserWindow::screenshot):
1316         (BrowserWindow::loadURLListFromFile):
1317         (BrowserWindow::updateUserAgentList):
1318         (BrowserWindow::~BrowserWindow):
1319         * MiniBrowser/qt/BrowserWindow.h:
1320         * MiniBrowser/qt/MiniBrowser.pro:
1321         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1322         (MiniBrowserApplication::MiniBrowserApplication):
1323         (MiniBrowserApplication::notify):
1324         * MiniBrowser/qt/MiniBrowserApplication.h:
1325         * MiniBrowser/qt/UrlLoader.cpp:
1326         (UrlLoader::UrlLoader):
1327         * MiniBrowser/qt/main.cpp:
1328
1329 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1330
1331         [Qt][WK2] Remove QAction from MiniBrowser
1332         https://bugs.webkit.org/show_bug.cgi?id=70525
1333
1334         In order to rewrite MiniBrowser in QML we need a suitable
1335         mechanism for triggering navigation actions.
1336         Due to the QtWidgets dependency of QAction the current
1337         solution is not suitable anymore. Therefore we introduce
1338         invokable methods and export properties in QWebNavigationController.
1339
1340         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1341                  Zeno Albisser <zeno.albisser@nokia.com>
1342
1343         Reviewed by Simon Hausmann.
1344
1345         * MiniBrowser/qt/BrowserView.cpp:
1346         * MiniBrowser/qt/BrowserView.h:
1347         * MiniBrowser/qt/BrowserWindow.cpp:
1348         (BrowserWindow::BrowserWindow):
1349
1350 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1351
1352         [EFL] Unregister viewport,changed signal in EWebLauncher.
1353         https://bugs.webkit.org/show_bug.cgi?id=70478
1354
1355         Reviewed by Eric Seidel.
1356
1357         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
1358         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
1359         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
1360         This signal is for mobile device.
1361
1362         * EWebLauncher/main.c:
1363         (browserCreate):
1364
1365 2011-10-25  Anders Carlsson  <andersca@apple.com>
1366
1367         Plug-ins have no way to find out when the device scale factor changes
1368         https://bugs.webkit.org/show_bug.cgi?id=67226
1369         <rdar://problem/10048276>
1370
1371         Reviewed by Sam Weinig.
1372
1373         Keep a cached copy of the contents scale and update it when it changes.
1374
1375         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
1376         (ContentsScaleFactor::ContentsScaleFactor):
1377         (ContentsScaleFactor::cachedContentsScaleFactor):
1378         (ContentsScaleFactor::ScriptableObject::hasProperty):
1379         (ContentsScaleFactor::ScriptableObject::getProperty):
1380         (ContentsScaleFactor::NPP_New):
1381         (ContentsScaleFactor::NPP_SetValue):
1382
1383 2011-10-25  Sam Weinig  <sam@webkit.org>
1384
1385         Add WKBrowsingContextLoadDelegateTest test for a failed load
1386         https://bugs.webkit.org/show_bug.cgi?id=70859
1387
1388         Reviewed by Anders Carlsson.
1389
1390         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1391         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
1392  
1393         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
1394         Test that we are getting the correct NSError code and domain.
1395
1396 2011-10-25  Erik Arvidsson  <arv@chromium.org>
1397
1398         JS Test Harness: Make successfullyParsed optional
1399         https://bugs.webkit.org/show_bug.cgi?id=70784
1400
1401         Reviewed by Ojan Vafai.
1402
1403         * Scripts/make-new-script-test:
1404         (writeTestFile): Update the template for script tests.
1405
1406 2011-10-25  Anders Carlsson  <andersca@apple.com>
1407
1408         Plug-ins have to use JavaScript to find out the current device scale factor
1409         https://bugs.webkit.org/show_bug.cgi?id=67225
1410         <rdar://problem/10048258>
1411
1412         Reviewed by Darin Adler.
1413
1414         Add a plug-in test for getting the contents scale factor.
1415
1416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1417         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
1418         (ContentsScaleFactor::ContentsScaleFactor):
1419         (ContentsScaleFactor::contentsScaleFactor):
1420         (ContentsScaleFactor::ScriptableObject::hasProperty):
1421         (ContentsScaleFactor::ScriptableObject::getProperty):
1422         (ContentsScaleFactor::ScriptableObject::pluginTest):
1423         (ContentsScaleFactor::NPP_GetValue):
1424
1425 2011-10-25  Sam Weinig  <sam@webkit.org>
1426
1427         Flesh out WKBrowsingContextLoadDelegate a bit
1428         https://bugs.webkit.org/show_bug.cgi?id=70846
1429
1430         Reviewed by Anders Carlsson.
1431
1432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1433         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
1434         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
1435         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
1436         (WKBrowsingContextLoadDelegateTest::SetUp):
1437         (WKBrowsingContextLoadDelegateTest::TearDown):
1438         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
1439         (TEST_F):
1440         Add basic testing for WKBrowsingContextLoadDelegate.
1441
1442 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
1443
1444         make-script-test-wrappers should not look outside fast/js
1445         https://bugs.webkit.org/show_bug.cgi?id=66357
1446
1447         Reviewed by Maciej Stachowiak.
1448
1449         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
1450         fast/js.
1451
1452 2011-10-25  Adam Barth  <abarth@webkit.org>
1453
1454         Add a --make option to update-webkit to engage the Makefile-based build system
1455         https://bugs.webkit.org/show_bug.cgi?id=70847
1456
1457         Reviewed by Dimitri Glazkov.
1458
1459         I can never remember what crazy environment variables I'm supposed to
1460         set to tell GYP what to do.
1461
1462         * Scripts/update-webkit:
1463
1464 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
1465
1466         [EFL] DRT: Force layout when sending events.
1467         https://bugs.webkit.org/show_bug.cgi?id=70357
1468
1469         Reviewed by Antonio Gomes.
1470
1471         Some tests such as editing/input/page-up-down-scrolls.html rely on the
1472         scrollbars being properly set up during the onload events.
1473         Document::implicitClose(), however, dispatches the onload events before
1474         calling FrameView::layout(), so these tests usually fail.
1475
1476         We now do the same as the GTK+ and Chromium ports and manually force the
1477         layout when dispatching events.
1478
1479         * DumpRenderTree/efl/EventSender.cpp:
1480         (sendMouseEvent):
1481         (keyDownCallback):
1482
1483 2011-10-25  Daniel Bates  <dbates@rim.com>
1484
1485         build-webkit --clean should only clean build directory for CMake-based ports
1486         https://bugs.webkit.org/show_bug.cgi?id=70834
1487
1488         Reviewed by Antonio Gomes.
1489
1490         Currently build-webkit --clean both cleans the build directory and builds WebKit for
1491         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
1492         as per its description in the usage message of build-webkit.
1493
1494         * Scripts/webkitdirs.pm:
1495         (buildCMakeProjectOrExit):
1496
1497 2011-10-25  Anna Cavender  <annacc@chromium.org>
1498
1499         Enable running of track layout tests for Chromium
1500         https://bugs.webkit.org/show_bug.cgi?id=70803
1501
1502         Reviewed by Adam Barth.
1503         
1504         Make DumpRenderTree/TestShell always run with track enabled
1505         (equivalent of --enable-video-track).
1506
1507         * DumpRenderTree/chromium/TestShell.cpp:
1508         (TestShell::TestShell):
1509
1510 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
1511
1512         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
1513         https://bugs.webkit.org/show_bug.cgi?id=70603
1514
1515         Reviewed by Gustavo Noronha Silva.
1516
1517         * MiniBrowser/gtk/BrowserWindow.c:
1518         (focus):
1519         (unFocus):
1520         (browserWindowUIClientInit):
1521
1522 2011-10-25  Dan Bernstein  <mitz@apple.com>
1523
1524         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
1525
1526         Reviewed by Adam Roben.
1527
1528         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1529         (TestWebKitAPI::TEST):
1530
1531 2011-10-25  Eric Seidel  <eric@webkit.org>
1532
1533         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
1534         https://bugs.webkit.org/show_bug.cgi?id=64471
1535
1536         Reviewed by Adam Roben.
1537
1538         Speculative fix.
1539
1540         * Scripts/webkitpy/layout_tests/port/win.py:
1541         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1542
1543 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
1544
1545         Fix bug summary when rolling Chromium DEPS to LKGR.
1546         https://bugs.webkit.org/show_bug.cgi?id=69917
1547
1548         Reviewed by Adam Barth.
1549
1550         * Scripts/webkitpy/tool/bot/irc_command.py:
1551         * Scripts/webkitpy/tool/bot/sheriff.py:
1552         * Scripts/webkitpy/tool/commands/roll.py:
1553         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1554
1555 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
1556
1557         [EFL] Build fix. Add include path to find npapi.h
1558         https://bugs.webkit.org/show_bug.cgi?id=70730
1559
1560         Unreviewed build fix.
1561
1562         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
1563
1564 2011-10-24  Eric Seidel  <eric@webkit.org>
1565
1566         Plugin tests are failing after switching WK2 to NRWT
1567         https://bugs.webkit.org/show_bug.cgi?id=70760
1568
1569         Reviewed by Simon Fraser.
1570
1571         Perpetuate this horrible hack.
1572
1573         * Scripts/webkitpy/layout_tests/port/webkit.py:
1574
1575 2011-10-24  Eric Seidel  <eric@webkit.org>
1576
1577         NRWT doesn't support ORWT's --root option, but should
1578         https://bugs.webkit.org/show_bug.cgi?id=70416
1579
1580         Reviewed by Dirk Pranke.
1581
1582         Add support for ORWT's --root option which is used for
1583         running tests with a nightly build of WebKit.
1584
1585         * Scripts/old-run-webkit-tests:
1586         * Scripts/webkitpy/layout_tests/port/base.py:
1587          - webkit_build_path was never called by any code, removed.
1588         * Scripts/webkitpy/layout_tests/port/webkit.py:
1589         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1590
1591 2011-10-24  David Levin  <levin@chromium.org>
1592
1593         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
1594         https://bugs.webkit.org/show_bug.cgi?id=70747
1595
1596         Reviewed by Tony Chang.
1597
1598         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
1599         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
1600
1601 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
1602
1603         [Qt][WK2] Crash when running pixel tests
1604         https://bugs.webkit.org/show_bug.cgi?id=70725
1605
1606         Reviewed by Chang Shu.
1607
1608         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1609         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1610
1611 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1612
1613         [GTK] Remove g_thread_init() calls
1614         https://bugs.webkit.org/show_bug.cgi?id=70717
1615
1616         Reviewed by Xan Lopez.
1617
1618         With newer glib it's not needed anymore and with previous versions
1619         it was already called by g_type_init().
1620
1621         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1622         (main):
1623         * GtkLauncher/main.c:
1624         (main):
1625         * MiniBrowser/gtk/main.c:
1626         (main):
1627
1628 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
1629
1630         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
1631         https://bugs.webkit.org/show_bug.cgi?id=69403
1632
1633         We did not added autotoolsconfig.h to the config.h file and we
1634         were adding Platform.h without the config.h in the
1635         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
1636         the Prefix file.
1637
1638         Reviewed by Martin Robinson.
1639
1640         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1641
1642 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
1643
1644         [EFL] Remove unused code from EWebLauncher
1645         https://bugs.webkit.org/show_bug.cgi?id=70590
1646
1647         Reviewed by Andreas Kling.
1648
1649         Removed unused function on_closeWindow from EWebLauncher
1650
1651         * EWebLauncher/main.c:
1652
1653 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
1654
1655         Add watchlist for WebCore/css and put myself on it.
1656         https://bugs.webkit.org/show_bug.cgi?id=70701
1657
1658         Reviewed by Adam Barth.
1659
1660         * Scripts/webkitpy/common/config/watchlist:
1661         Add watchlist for WebCore/css and put myself on it.
1662
1663 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1664
1665         [GTK] Implement KeyDown function for WebKit2 EventSender.
1666         https://bugs.webkit.org/show_bug.cgi?id=69410
1667
1668         Reviewed by Martin Robinson.
1669
1670         Implement the KeyDown function on Gtk platform.
1671
1672         * WebKitTestRunner/GNUmakefile.am:
1673         * WebKitTestRunner/TestController.cpp:
1674         (WTR::TestController::TestController):
1675         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1676         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
1677         (WTR::EventSenderProxy::EventSenderProxy):
1678         (WTR::dispatchEvent):
1679         (WTR::getModifiers):
1680         (WTR::getGDKKeySymForKeyRef):
1681         (WTR::EventSenderProxy::keyDown):
1682
1683 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1684
1685         [WK2][GTK] run-launcher script fails after testing WK2 tests
1686         https://bugs.webkit.org/show_bug.cgi?id=70676
1687
1688         Reviewed by Andreas Kling.
1689
1690         Pass the '-2' flag instead of '--webkit-test-runner' when executing
1691         run-launcher script after testing with WebKitTestRunner.
1692
1693         * Scripts/webkitpy/layout_tests/port/gtk.py:
1694
1695 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
1696
1697         [WK2][GTK] Missing env variables cause WKTR to crash
1698         https://bugs.webkit.org/show_bug.cgi?id=70674
1699
1700         Reviewed by Martin Robinson.
1701
1702         Set two environment variables that the Gtk's port of WebKitTestRunner
1703         depends on and crashes if they're not explicitly set by the user.
1704         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
1705         properly uses the _build_path method.
1706
1707         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
1708         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
1709         environment variables.
1710
1711 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
1712
1713         Bencher script doesn't measure GC times accurately
1714         https://bugs.webkit.org/show_bug.cgi?id=70588
1715
1716         Reviewed by Geoff Garen.
1717         
1718         Added two new options which allow different ways of measuring GC times:
1719         
1720         --measure-gc, which omits calls to gc() between benchmark invocations.
1721         This option takes an optional argument, which is the name of the
1722         VM in which to enable this feature. This allows comparing a single VM
1723         against itself, with and without GC.
1724         
1725         --rerun <N>, which causes each sample measurement to include N invocations
1726         which do not have gc() calls between them. The default is N = 1, which
1727         results in the same behavior as before.
1728         
1729         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
1730         N >= 3) to get more of a contribution from GC to the measured times.
1731         --rerun results in tighter confidence intervals than --measure-gc, since
1732         it amortizes GC effects in each sample, while with --measure-gc some
1733         samples will see GC and some won't leading to a higher standard devation
1734         and thus requiring more samples to reduce confidence intervals to
1735         managable levels.
1736
1737         * Scripts/bencher:
1738
1739 2011-10-21  Sam Weinig  <sam@webkit.org>
1740
1741         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
1742         https://bugs.webkit.org/show_bug.cgi?id=70653
1743
1744         Reviewed by Simon Fraser.
1745
1746         * MiniBrowser/mac/AppDelegate.h:
1747         * MiniBrowser/mac/AppDelegate.m:
1748         (-[BrowserAppDelegate init]):
1749         (-[BrowserAppDelegate newWindow:]):
1750         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1751         * MiniBrowser/mac/BrowserWindowController.h:
1752         * MiniBrowser/mac/BrowserWindowController.m:
1753         (-[BrowserWindowController initWithContext:pageGroup:]):
1754         (-[BrowserWindowController windowWillClose:]):
1755         (createNewPage):
1756         (-[BrowserWindowController awakeFromNib]):
1757         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1758         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1759         Update testing code to pass a PageGroup as necessary.
1760
1761 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
1762
1763         webkitpy: Teach NRWT about the EFL port
1764         https://bugs.webkit.org/show_bug.cgi?id=70637
1765
1766         Allows using ``efl'' as a platform when executing NRWT.
1767
1768         Reviewed by Eric Seidel.
1769
1770         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
1771         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
1772         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
1773         when using PortFactory.get(port_name='efl').
1774
1775 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
1776
1777         [Gtk] mousemove event always has metaKey == true
1778         https://bugs.webkit.org/show_bug.cgi?id=35299
1779
1780         Reviewed by Martin Robinson.
1781
1782         * DumpRenderTree/gtk/EventSender.cpp:
1783         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
1784         keyboard events. So making it in sync with WebCore files.
1785         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
1786
1787 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         watchlist: Add a new entry for WebKit2 GTK+ public API
1790         https://bugs.webkit.org/show_bug.cgi?id=70601
1791
1792         Reviewed by Philippe Normand.
1793
1794         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
1795         for patches that might include new API that points to the WebKit2
1796         GTK+ API guidelines.
1797
1798         * Scripts/webkitpy/common/config/watchlist:
1799
1800 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
1801
1802         Remove QtScript source code from WebKit.
1803         https://bugs.webkit.org/show_bug.cgi?id=64088
1804
1805         Reviewed by Tor Arne Vestbø.
1806
1807         Removed dead code that isn't developed anymore.
1808
1809         * Scripts/webkitpy/style/checker_unittest.py:
1810
1811 2011-10-20  Eric Seidel  <eric@webkit.org>
1812
1813         Switch webkit2 bot to NRWT
1814         https://bugs.webkit.org/show_bug.cgi?id=56729
1815
1816         Reviewed by Adam Barth.
1817
1818         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
1819         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
1820
1821         * Scripts/run-webkit-tests:
1822         (runningOnBuildBot):
1823         (useNewRunWebKitTests):
1824
1825 2011-10-20  Eric Seidel  <eric@webkit.org>
1826
1827         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
1828         https://bugs.webkit.org/show_bug.cgi?id=70585
1829
1830         Reviewed by Adam Barth.
1831
1832         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
1833         However since DRT was functioning fine before in Qt, we'll make this an error log for now
1834         and once we find the root cause flip this back to an assert.
1835
1836         * Scripts/webkitpy/layout_tests/port/webkit.py:
1837
1838 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1839
1840         Unreviewed, rolling out r98064.
1841         http://trac.webkit.org/changeset/98064
1842         https://bugs.webkit.org/show_bug.cgi?id=64788
1843
1844         Broke Mac bots.
1845
1846         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1847
1848 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
1849
1850         WebSocket: Connecting to localhost:8880 takes one second on Windows
1851         https://bugs.webkit.org/show_bug.cgi?id=64788
1852
1853         Reviewed by Dirk Pranke.
1854
1855         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1856         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1857         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1858         from timing out on Windows, because this test tries to open a lot of
1859         connections to localhost and each attempt takes one second to fall back from
1860         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1861
1862 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
1863
1864         nrwt: newly generated results are put in cross-platform directory
1865         https://bugs.webkit.org/show_bug.cgi?id=68931
1866
1867         Reviewed by Dirk Pranke.
1868
1869         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
1870         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
1871         (because png images are typically different on each platform), and passing True when .txt file is missing
1872         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
1873
1874         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1875         * Scripts/webkitpy/layout_tests/port/test.py:
1876         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
1877         and added a test case.
1878
1879 2011-10-20  Kent Tamura  <tkent@chromium.org>
1880
1881         Unreviewed. Adding myself to watchlist.
1882
1883         * Scripts/webkitpy/common/config/watchlist:
1884         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
1885
1886 2011-10-20  Nico Weber  <thakis@chromium.org>
1887
1888         [chromium/mac] Add support for building with make
1889         https://bugs.webkit.org/show_bug.cgi?id=70455
1890
1891         Reviewed by Adam Barth.
1892
1893         Depends on http://codereview.chromium.org/8352029/
1894         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
1895         create a toplevel Makefile.chromium.
1896
1897         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
1898         `Tools/Scripts/build-webkit --chromium` will build with make instead of
1899         xcodebuild.
1900
1901         Also let nrwt use a binary from out/ if it exists.
1902
1903         * Scripts/webkitdirs.pm:
1904         (determineBaseProductDir):
1905         (isChromiumMacMake):
1906         (determineIsChromiumMacMake):
1907         (buildChromium):
1908
1909 2011-10-20  Eric Seidel  <eric@webkit.org>
1910
1911         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
1912         https://bugs.webkit.org/show_bug.cgi?id=70524
1913
1914         Reviewed by Adam Barth.
1915
1916         This is a speculative fix, since I do not use a platform
1917         which outputs crashlogs over stderr.
1918
1919         * Scripts/webkitpy/layout_tests/port/server_process.py:
1920         * Scripts/webkitpy/layout_tests/port/webkit.py:
1921
1922 2011-10-20  Eric Seidel  <eric@webkit.org>
1923
1924         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
1925         https://bugs.webkit.org/show_bug.cgi?id=70492
1926
1927         Reviewed by Adam Barth.
1928
1929         The bug turned out to be that I was assuming the block.content
1930         would be empty before the binary content following Content-Length
1931         was read inside _read_block.  Turns out its not, due to extra newlines
1932         and "ExpectedHash" header.
1933
1934         In the process of trying to figure out what was going wrong I ended up
1935         cleaning up our newline usage in DumpRenderTree a little.  Moved
1936         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
1937
1938         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
1939         per Adam's request in the original bug.
1940
1941         * DumpRenderTree/PixelDumpSupport.cpp:
1942         (dumpWebViewAsPixelsAndCompareWithExpected):
1943         * DumpRenderTree/cg/ImageDiffCG.cpp:
1944         (main):
1945         * DumpRenderTree/mac/DumpRenderTree.mm:
1946         (dump):
1947         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1948         (restoreMainDisplayColorProfile):
1949         (setupMainDisplayColorProfile):
1950         * Scripts/webkitpy/layout_tests/port/server_process.py:
1951         * Scripts/webkitpy/layout_tests/port/webkit.py:
1952         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1953
1954 2011-10-20  Tony Chang  <tony@chromium.org>
1955
1956         [chromium] Remove <stdint.h> from ImageDiff and use
1957         unsigned int instead of uint32_t.
1958
1959         Unreviewed, fixing the chromium win build.
1960
1961         * DumpRenderTree/chromium/ImageDiff.cpp:
1962         (Image::pixelAt):
1963         (Image::setPixelAt):
1964         (maxOf3):
1965         (getRedComponent):
1966         (getGreenComponent):
1967         (getBlueComponent):
1968         (weightedPercentageDifferent):
1969         (createImageDiff):
1970
1971 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
1972
1973         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
1974         https://bugs.webkit.org/show_bug.cgi?id=69997
1975
1976         Reviewed by Tony Chang.
1977
1978         This change is required to make ImageDiff for Android, and can benefit
1979         other platforms, too. On Android, most targets are built as
1980         toolsets:target. while ImageDiff needs to be built as toolsets:host.
1981         Currently, building the standalone target of ImageDiff depends on about
1982         85 other targets (try  make ImageDiff'), which is inefficient. After the
1983         change, ImageDiff only depends on webkit_support_gfx, which in turn
1984         depends on libpng and zlib.
1985
1986         * DumpRenderTree/chromium/ImageDiff.cpp:
1987         (main):
1988
1989 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1990
1991         [EFL] Unreviewed DumpRenderTree build fix.
1992
1993         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1994         (LayoutTestController::addChromeInputField): Add stub.
1995         (LayoutTestController::removeChromeInputField): Ditto.
1996         (LayoutTestController::focusWebView): Ditto.
1997         (LayoutTestController::setBackingScaleFactor): Ditto.
1998
1999 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2000
2001         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
2002         https://bugs.webkit.org/show_bug.cgi?id=70142
2003
2004         Reviewed by Gustavo Noronha Silva.
2005
2006         * CMakeListsEfl.txt: Include DRT CMakeLists.
2007         * DumpRenderTree/efl/CMakeLists.txt: Added.
2008
2009 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2010
2011         [style] Allow usage of NULL in gst_*
2012         https://bugs.webkit.org/show_bug.cgi?id=70498
2013
2014         Reviewed by David Levin.
2015
2016         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
2017         of gst_ calls. Now just ignore NULL in all of them.
2018         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
2019
2020 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2021
2022         [EFL] Unreviewed. Build fix after r97043.
2023
2024         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2025         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
2026         * DumpRenderTree/efl/EventSender.cpp:
2027         (scalePageByCallback): Ditto.
2028
2029 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2030
2031         Unreviewed. Adding myself to watchlists.
2032         * Scripts/webkitpy/common/config/watchlist:
2033
2034 2011-10-19  Eric Seidel  <eric@webkit.org>
2035
2036         Reviewed by Adam Barth.
2037
2038         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
2039         https://bugs.webkit.org/show_bug.cgi?id=63683
2040
2041         * Scripts/webkitpy/common/net/layouttestresults.py:
2042         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2043         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2044         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2045         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2046         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2047         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2048         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2049         * Scripts/webkitpy/layout_tests/port/base.py:
2050         * Scripts/webkitpy/layout_tests/port/server_process.py:
2051         * Scripts/webkitpy/layout_tests/port/webkit.py:
2052         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2053
2054 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
2055
2056         Chromium doesn't support git branch builds, so don't add the branch to the product dir
2057         https://bugs.webkit.org/show_bug.cgi?id=70449
2058
2059         Reviewed by Eric Seidel.
2060
2061         * Scripts/webkitdirs.pm:
2062         (determineBaseProductDir):
2063
2064 2011-10-19  Ojan Vafai  <ojan@chromium.org>
2065
2066         Unreviewed. Adding myself to watchlists.
2067         * Scripts/webkitpy/common/config/watchlist:
2068
2069 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
2070
2071         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
2072         https://bugs.webkit.org/show_bug.cgi?id=62166
2073
2074         Reviewed by Eric Seidel.
2075
2076         Included options to control committer/reviewer patch count requirements,
2077         an age-limit on patches, and verbose output for more in-depth analysis.
2078
2079         * Scripts/webkitpy/common/checkout/changelog.py:
2080         * Scripts/webkitpy/tool/commands/__init__.py:
2081         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
2082         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
2083
2084 2011-10-19  Eric Seidel  <eric@webkit.org>
2085
2086         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
2087         Make NRWT normalize directory names in Skipped files during parsing.
2088
2089         Unreviewed.  Very simple (tested) change.
2090
2091         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2092         * Scripts/webkitpy/layout_tests/port/webkit.py:
2093
2094 2011-10-19  David Levin  <levin@chromium.org>
2095
2096         watchlist: Should be more robust to bad regex.
2097         https://bugs.webkit.org/show_bug.cgi?id=69486
2098
2099         Reviewed by Adam Barth.
2100
2101         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
2102           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
2103           patterns since they are no longer anchored on the right hand side.
2104         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
2105         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
2106         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
2107         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
2108         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
2109         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
2110         filenames are no longer anchored on the right hand side.
2111         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
2112         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
2113         don't kill everything.
2114
2115 2011-10-19  David Levin  <levin@chromium.org>
2116
2117         watchlist: Add a stylecheck to do validity checks for the watchlist config.
2118         https://bugs.webkit.org/show_bug.cgi?id=69487
2119
2120         Reviewed by Adam Barth.
2121
2122         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
2123         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
2124         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
2125
2126 2011-10-19  Eric Seidel  <eric@webkit.org>
2127
2128         NRWT ServerProcess can't read lines from stderr and stdio separately
2129         https://bugs.webkit.org/show_bug.cgi?id=70435
2130
2131         Reviewed by Adam Barth.
2132
2133         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
2134         DRT expects RWT to read one line at a time from stderr and stdout independently.
2135         This allows DRT to communicate errors over stderr and have them responded to immediately
2136         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
2137         class only exposed a read_line function which would read a line from stdout
2138         and batch all output from stderr into an error buffer.  Callers would only be able
2139         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
2140
2141         * Scripts/webkitpy/layout_tests/port/server_process.py:
2142         * Scripts/webkitpy/layout_tests/port/webkit.py:
2143
2144 2011-10-19  Chang Shu  <cshu@webkit.org>
2145
2146         [Qt] Support WK1-only Skipped list
2147         https://bugs.webkit.org/show_bug.cgi?id=70254
2148
2149         Reviewed by Csaba Osztrogonác.
2150
2151         Added a new search path qt-wk1 for skipping WK1-only tests.
2152
2153         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
2154         * Scripts/old-run-webkit-tests: ORWT
2155
2156 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
2157
2158         [GTK] Enable to use built-product-archive on GTK platform
2159         https://bugs.webkit.org/show_bug.cgi?id=70319
2160
2161         Reviewed by Csaba Osztrogonác.
2162
2163         * BuildSlaveSupport/built-product-archive:
2164
2165 2011-10-18  David Levin  <levin@chromium.org>
2166
2167         watchlist: Should try to run if it can and not throw on mistakes.
2168         https://bugs.webkit.org/show_bug.cgi?id=70358
2169
2170         Reviewed by Adam Barth.
2171
2172         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
2173         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
2174         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
2175         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
2176         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
2177         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
2178
2179 2011-10-18  Sam Weinig  <sam@webkit.org>
2180
2181         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
2182         https://bugs.webkit.org/show_bug.cgi?id=70387
2183
2184         Reviewed by Dan Bernstein.
2185
2186         * MiniBrowser/mac/BrowserWindowController.m:
2187         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2188         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2189         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2190         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2191         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2192         Update to include WKViewPrivate.h where necessary.
2193
2194 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
2195
2196         Web Inspector: Some localizedStrings.js Updates
2197         https://bugs.webkit.org/show_bug.cgi?id=70365
2198
2199         Reviewed by Darin Adler.
2200
2201         * Scripts/check-inspector-strings:
2202         Updated to the new webkitpy way to determine checkout root.
2203
2204         * Scripts/webkitdirs.pm:
2205         (copyInspectorFrontendFiles):
2206         Made it so build-webkit --inspector-frontend copies over
2207         the localizedStrings.js file as well as the frontend files.
2208
2209 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
2210
2211         [EFL] DRT: Clear list of visited pages before each test.
2212         https://bugs.webkit.org/show_bug.cgi?id=70355
2213
2214         Reviewed by Antonio Gomes.
2215
2216         r97596 uncovered a bug in the implementation: the list of visited
2217         links was not cleared between tests, which caused tests such as
2218         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
2219         changed depending on whether fast/repaint/border-repaint-glitch.html
2220         was visited before or not).
2221
2222         Call ewk_history_clear to make sure the visited links list does not
2223         persist between tests.
2224
2225         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2226         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2227
2228 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2229
2230         Split TestExpectationsEditor into its own file.
2231         https://bugs.webkit.org/show_bug.cgi?id=70348
2232
2233         Reviewed by Adam Barth.
2234
2235         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
2236         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
2237         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
2238         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2239         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
2240
2241 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2242
2243         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
2244         https://bugs.webkit.org/show_bug.cgi?id=70313
2245
2246         Reviewed by Adam Barth.
2247
2248         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
2249         this parameter because build-webkit and other scripts don't accept it.
2250
2251         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2252
2253 2011-10-18  Adam Barth  <abarth@webkit.org>
2254
2255         Subscribe myself to WebIDL changes
2256         https://bugs.webkit.org/show_bug.cgi?id=70341
2257
2258         Reviewed by David Levin.
2259
2260         I've also added some documentation and refactored my previous
2261         subscriptions to make it eaiser for others to subscribe as well.
2262
2263         * Scripts/webkitpy/common/config/watchlist:
2264
2265 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2266
2267         Add myself to the newfangled watchlist plumbing.
2268         https://bugs.webkit.org/show_bug.cgi?id=70338
2269
2270         Reviewed by David Levin.
2271
2272         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
2273
2274 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2275
2276         Fix a unit test in TestFailures.
2277         https://bugs.webkit.org/show_bug.cgi?id=70337
2278
2279         Reviewed by Adam Barth.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
2282             the value of a method property should always be lowercase.
2283
2284 2011-10-18  Adam Barth  <abarth@webkit.org>
2285
2286         Always enable ENABLE(XPATH)
2287         https://bugs.webkit.org/show_bug.cgi?id=70217
2288
2289         Reviewed by Eric Seidel.
2290
2291         * Scripts/build-webkit:
2292
2293 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2294
2295         garden-o-matic should not report flaking in expected failures as failures.
2296         https://bugs.webkit.org/show_bug.cgi?id=70279
2297
2298         Reviewed by Adam Barth.
2299
2300         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
2301         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
2302         same for garden-o-matic.
2303
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
2305             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
2307
2308 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
2309
2310         [Gtk] Support for client-based geolocation
2311         https://bugs.webkit.org/show_bug.cgi?id=64970
2312
2313         Reviewed by Martin Robinson.
2314
2315         Add support for testing client-based geolocation tests in DumpRenderTree.
2316
2317         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2318         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
2319         (createWebView): Create web view after declaring DumpRenderTree mode.
2320         That way a mock client for geolocation is used instead of a GeoClue
2321         client if a web view is created when testing.
2322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
2323         geolocation layout tests.
2324         (LayoutTestController::setMockGeolocationPosition):
2325         (LayoutTestController::setMockGeolocationError):
2326         (LayoutTestController::setGeolocationPermission):
2327         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2328         * Scripts/build-webkit: Note that the Gtk port is using client-based
2329         geolocation, even though changing this flag has no effect on compilation.
2330
2331 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
2332
2333         [Chromium] suppress console output from DevTools window
2334         https://bugs.webkit.org/show_bug.cgi?id=69632
2335
2336         Reviewed by Pavel Feldman.
2337
2338         * DumpRenderTree/chromium/TestShell.cpp:
2339         (TestShell::showDevTools):
2340         * DumpRenderTree/chromium/WebViewHost.cpp:
2341         (WebViewHost::didAddMessageToConsole):
2342         (WebViewHost::reset):
2343         (WebViewHost::setLogConsoleOutput):
2344         * DumpRenderTree/chromium/WebViewHost.h:
2345
2346 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2347
2348         Unreviewed, rolling out r97735.
2349         http://trac.webkit.org/changeset/97735
2350         https://bugs.webkit.org/show_bug.cgi?id=70317
2351
2352         some people apparently use build-jsc with the qt port without
2353         building webkit first (Requested by torarne on #webkit).
2354
2355         * Scripts/build-webkit:
2356         * Scripts/webkitdirs.pm:
2357         (buildQMakeProject):
2358         (buildQMakeQtProject):
2359
2360 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2361
2362         [Qt] Remove dead code in build-webkit
2363
2364         build-webkit will iterate over a list of subdirectories to build,
2365         but this feature is only used by the Apple ports. For QtWebKit we
2366         always pass an empty directory to buildQMakeProject, which makes
2367         the logic for dealing with sub-projects in buildQMakeProject just
2368         added noise.
2369
2370         If we do want this feature at some point, we should redo it in
2371         the context of the upcoming build system changes for Qt.
2372
2373         Reviewed by Simon Hausmann.
2374
2375         * Scripts/build-webkit:
2376         * Scripts/webkitdirs.pm:
2377         (buildQt):
2378
2379 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2380
2381         Remove traces of Symbian support from the build scripts
2382
2383         Reviewed by Simon Hausmann.
2384
2385         * Scripts/build-webkit:
2386         * Scripts/webkitdirs.pm:
2387         (determineBaseProductDir):
2388         (argumentsForConfiguration):
2389         (usesPerConfigurationBuildDirectory):
2390         (buildQMakeProject):
2391
2392 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2393
2394         Build fix after r97672.
2395
2396         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2397
2398 2011-10-17  Kent Tamura  <tkent@chromium.org>
2399
2400         A follow-up of r97716.
2401         https://bugs.webkit.org/show_bug.cgi?id=68803
2402
2403         * DumpRenderTree/chromium/LayoutTestController.cpp:
2404         (LayoutTestController::reset): Initialize m_dumpCreateView.
2405
2406 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
2407
2408         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
2409         https://bugs.webkit.org/show_bug.cgi?id=68803
2410
2411         Reviewed by Nate Chapin.
2412
2413         * DumpRenderTree/chromium/LayoutTestController.cpp:
2414         (LayoutTestController::LayoutTestController):
2415         (LayoutTestController::dumpCreateView):
2416         * DumpRenderTree/chromium/LayoutTestController.h:
2417         (LayoutTestController::shouldDumpCreateView):
2418         * DumpRenderTree/chromium/WebViewHost.cpp:
2419         (WebViewHost::createView):
2420
2421 2011-10-17  Nate Chapin  <japhet@chromium.org>
2422
2423         Add myself to watchlists, and add a watch
2424         for Source/WebCore/loader/.
2425         https://bugs.webkit.org/show_bug.cgi?id=70263
2426
2427         Reviewed by David Levin.
2428
2429         * Scripts/webkitpy/common/config/watchlist:
2430
2431 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2432
2433         [EFL] DRT: Make non-recognized keys work in events as well.
2434         https://bugs.webkit.org/show_bug.cgi?id=69860
2435
2436         Reviewed by Antonio Gomes.
2437
2438         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
2439         here: it has a select box with a few non-latin options, and one of them
2440         is selected via the keyboard.
2441
2442         In this specific case, we need to make EventHandler::keyEvent send a
2443         keyPressEvent to SelectElement, so that
2444         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
2445         only when PlatformKeyEvent::text() is not empty, which was not the case
2446         so far.
2447
2448         * DumpRenderTree/efl/EventSender.cpp:
2449         (keyDownCallback):
2450
2451 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
2452
2453         Add layout tests for WebPlugin compositor path
2454         https://bugs.webkit.org/show_bug.cgi?id=69027
2455
2456         Reviewed by James Robinson.
2457
2458         * DumpRenderTree/DumpRenderTree.gypi:
2459         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
2460         (premultiplyAlpha):
2461         (TestWebPlugin::TestWebPlugin):
2462         (TestWebPlugin::~TestWebPlugin):
2463         (TestWebPlugin::mimeType):
2464         (TestWebPlugin::initialize):
2465         (TestWebPlugin::destroy):
2466         (TestWebPlugin::updateGeometry):
2467         (TestWebPlugin::parsePrimitive):
2468         (TestWebPlugin::parseColor):
2469         (TestWebPlugin::parseOpacity):
2470         (TestWebPlugin::initScene):
2471         (TestWebPlugin::drawScene):
2472         (TestWebPlugin::destroyScene):
2473         (TestWebPlugin::initProgram):
2474         (TestWebPlugin::initPrimitive):
2475         (TestWebPlugin::drawPrimitive):
2476         (TestWebPlugin::loadShader):
2477         (TestWebPlugin::loadProgram):
2478         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
2479         (TestWebPlugin::scriptableObject):
2480         (TestWebPlugin::paint):
2481         (TestWebPlugin::updateFocus):
2482         (TestWebPlugin::updateVisibility):
2483         (TestWebPlugin::acceptsInputEvents):
2484         (TestWebPlugin::handleInputEvent):
2485         (TestWebPlugin::didReceiveResponse):
2486         (TestWebPlugin::didReceiveData):
2487         (TestWebPlugin::didFinishLoading):
2488         (TestWebPlugin::didFailLoading):
2489         (TestWebPlugin::didFinishLoadingFrameRequest):
2490         (TestWebPlugin::didFailLoadingFrameRequest):
2491         (TestWebPlugin::Scene::Scene):
2492         * DumpRenderTree/chromium/WebViewHost.cpp:
2493         (WebViewHost::createPlugin):
2494
2495 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
2496
2497         [nrwt] Add new category for MISSING
2498         https://bugs.webkit.org/show_bug.cgi?id=69990
2499
2500         Reviewed by Dirk Pranke.
2501
2502         Treat missing results as a new category in summerize_results.
2503
2504         Because Chromium port wants to turn bots red when there are tests with missing results,
2505         extracted the logic to compute the exit code as exit_code_from_summarized_results in
2506         base and chromium ports.
2507
2508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2509         * Scripts/webkitpy/layout_tests/port/base.py:
2510         * Scripts/webkitpy/layout_tests/port/chromium.py:
2511         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2512
2513 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
2514
2515         garden-o-matic operations fail because of CSP.
2516         https://bugs.webkit.org/show_bug.cgi?id=70249
2517
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
2519
2520 2011-10-17  Ada Chan  <adachan@apple.com>
2521
2522         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
2523         https://bugs.webkit.org/show_bug.cgi?id=70168
2524
2525         Reviewed by Alexey Proskuryakov.
2526
2527         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
2528         (TestWebKitAPI::didFinishLoadForFrame):
2529         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
2530
2531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2532         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2533         Add the new file.
2534
2535 2011-10-17  Darin Adler  <darin@apple.com>
2536
2537         Add some more *.pyc ignores in directories with Python scripts.
2538
2539         * QueueStatusServer: Added property svn:ignore.
2540         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
2541         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
2542         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
2543
2544 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
2545
2546         [Qt][WK2][meta] Fix failing API tests
2547         https://bugs.webkit.org/show_bug.cgi?id=70236
2548
2549         Reviewed by Csaba Osztrogonác.
2550
2551         In order to run WebKit2 API tests we need the WebProcess to be in
2552         the path so let's add the bin directory when running the API tests of Qt.
2553
2554         * Scripts/run-qtwebkit-tests:
2555
2556 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2557
2558         [Qt][WK2] Build dependency problems
2559         https://bugs.webkit.org/show_bug.cgi?id=68456
2560
2561         Reviewed by Csaba Osztrogonác.
2562
2563         * Scripts/webkitdirs.pm:
2564         (buildQMakeProject):
2565
2566 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2567
2568         [build] Introduce Qt/SH4 buildbot
2569         https://bugs.webkit.org/show_bug.cgi?id=70227
2570
2571         Reviewed by Adam Roben.
2572
2573         Add buildslave for Linux/Qt/SH4.
2574
2575         * BuildSlaveSupport/build.webkit.org-config/config.json:
2576
2577 2011-10-16  Adam Barth  <abarth@webkit.org>
2578
2579         Always enable ENABLE(DOM_STORAGE)
2580         https://bugs.webkit.org/show_bug.cgi?id=70189
2581
2582         Reviewed by Eric Seidel.
2583
2584         * Scripts/build-webkit:
2585         * waf/build/settings.py:
2586
2587 2011-10-15  Adam Barth  <abarth@webkit.org>
2588
2589         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
2590         https://bugs.webkit.org/show_bug.cgi?id=70194
2591
2592         Reviewed by Daniel Bates.
2593
2594         * Scripts/build-webkit:
2595
2596 2011-10-15  Ojan Vafai  <ojan@chromium.org>
2597
2598         run-webkit-tests should accept --child-processes
2599         https://bugs.webkit.org/show_bug.cgi?id=69713
2600
2601         Reviewed by Adam Barth.
2602
2603         Only set --child-processes=1 if --child-processes it not
2604         passed on the commandline.
2605
2606         * Scripts/run-webkit-tests:
2607
2608 2011-10-15  Daniel Bates  <dbates@webkit.org>
2609
2610         Extract common gdb code into its own function; Remove script gdb-safari
2611         https://bugs.webkit.org/show_bug.cgi?id=68499
2612
2613         Reviewed by David Kilzer.
2614
2615         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
2616         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
2617         We should extract the common parts into a function that can be shared by all callers
2618         so as to remove duplicate code.
2619
2620         As a side effect of removing duplicate code we can remove the script gdb-safari since
2621         its code has been incorporated into webkitdirs::debugSafari() which is called by the
2622         script debug-safari.
2623
2624         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
2625         * Scripts/gdb-safari: Removed.
2626         * Scripts/webkitdirs.pm:
2627         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
2628         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
2629         script gdb-safari to here.
2630         (debugSafari): Added.
2631         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
2632         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
2633         runSafari() always returns 1 on Windows and the script run-safari exits using this
2634         value as its exit status. Hence, the script run-safari always exits with a nonzero
2635         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
2636         exit status of the WebKit launcher application.
2637         (debugMiniBrowser): Modified to call debugMacWebKitApp().
2638         (debugWebKitTestRunner): Ditto.
2639
2640 2011-10-15  Robert Hogan  <robert@webkit.org>
2641
2642         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
2643         https://bugs.webkit.org/show_bug.cgi?id=70056
2644
2645         Reviewed by Adam Barth.
2646
2647         The preferred file-order for patches is LayoutTests at the end and
2648         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
2649         it when creating patches for review and landing.
2650
2651         * Scripts/webkitpy/common/checkout/scm/git.py:
2652         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2653         * Scripts/webkitpy/common/config/orderfile: Added.
2654
2655 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2656
2657         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
2658         https://bugs.webkit.org/show_bug.cgi?id=69920
2659
2660         Reviewed by Kenneth Rohde Christiansen.
2661
2662         * DumpRenderTree/qt/DumpRenderTree.pro:
2663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2664         (WebCore::DumpRenderTree::open):
2665         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2666         * QtTestBrowser/QtTestBrowser.pro:
2667         * QtTestBrowser/launcherwindow.cpp:
2668         (LauncherWindow::screenshot):
2669         (LauncherWindow::showFPS):
2670         (LauncherWindow::updateFPS):
2671         * QtTestBrowser/launcherwindow.h:
2672         (WindowOptions::WindowOptions):
2673         * QtTestBrowser/mainwindow.cpp:
2674         (MainWindow::buildUI):
2675         * Scripts/webkitpy/style/checker.py: Remove rules for the
2676         WebKit/qt/symbian/platformplugin directory.
2677         * Scripts/webkitpy/style/checker_unittest.py:
2678         * Tools.pro:
2679         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2680         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2681         (WTR::LayoutTestController::platformInitialize):
2682         * WebKitTestRunner/qt/TestControllerQt.cpp:
2683         (WTR::isExistingLibrary):
2684         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2685
2686 2011-10-15  Adam Barth  <abarth@webkit.org>
2687
2688         Fix typo in webkitpy help
2689         https://bugs.webkit.org/show_bug.cgi?id=70169
2690
2691         Reviewed by Eric Seidel.
2692
2693         * Scripts/webkitpy/tool/commands/upload.py:
2694
2695 2011-10-15  Tony Chang  <tony@chromium.org>
2696
2697         fix another typo in treemap.html
2698         https://bugs.webkit.org/show_bug.cgi?id=70149
2699
2700         Reviewed by Ojan Vafai.
2701
2702         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
2703
2704         * TestResultServer/static-dashboards/treemap.html:
2705
2706 2011-10-14  Adam Barth  <abarth@webkit.org>
2707
2708         Hide status bubbles from queues which are very far behind
2709         https://bugs.webkit.org/show_bug.cgi?id=70133
2710
2711         Reviewed by Eric Seidel.
2712
2713         The mac-ews is so far behind that we shouldn't show its status bubble.
2714         The status bubble just makes contributors sad.
2715
2716         * QueueStatusServer/handlers/statusbubble.py:
2717
2718 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2719
2720         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
2721         https://bugs.webkit.org/show_bug.cgi?id=70143
2722
2723         Reviewed by Adam Barth.
2724
2725         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
2726         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
2727
2728 2011-10-14  David Levin  <levin@chromium.org>
2729
2730         watchlist: Add a validation check for the email names in the list.
2731         https://bugs.webkit.org/show_bug.cgi?id=70154
2732
2733         Reviewed by Adam Barth.
2734
2735         If an email is listed which doesn't have a bugzilla log in, then any emails
2736         added to the bug along with that email will fail to happen, so try to prevent this
2737         from happening by validating that emails added to the watchlist are known to be
2738         contributors.
2739
2740         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
2741         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
2742         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
2743
2744 2011-10-14  David Levin  <levin@chromium.org>
2745
2746         watchlist: If the style check fails, then the watchlist will not be run.
2747         https://bugs.webkit.org/show_bug.cgi?id=69484
2748
2749         Reviewed by Adam Barth.
2750
2751         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
2752         if the style part fails and don't allow watch list failures turn the
2753         bot run red.
2754         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
2755         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
2756
2757 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
2758
2759         Plumb style-checker filter up to command options and make land-cowboy use it.
2760         https://bugs.webkit.org/show_bug.cgi?id=70119
2761
2762         Reviewed by Adam Barth.
2763
2764         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
2765         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
2766         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
2767         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
2768         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2769         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
2770         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
2771
2772 2011-10-14  Sam Weinig  <sam@webkit.org>
2773
2774         Remove the Leopard slaves.
2775
2776         Reviewed by Adam Roben.
2777
2778         * BuildSlaveSupport/build.webkit.org-config/config.json:
2779
2780 2011-10-14  Peter Beverloo  <peter@chromium.org>
2781
2782         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
2783         https://bugs.webkit.org/show_bug.cgi?id=70028
2784
2785         Reviewed by Adam Barth.
2786
2787         * Scripts/update-webkit-chromium:
2788         * Scripts/webkitdirs.pm:
2789         (buildChromiumMakefile):
2790         (buildChromium):
2791
2792 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
2793
2794         Unreviewed; add missing #includes.
2795
2796         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2797         * DumpRenderTree/efl/EventSender.cpp:
2798
2799 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2800
2801         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
2802         https://bugs.webkit.org/show_bug.cgi?id=69770
2803
2804         Reviewed by Antonio Gomes.
2805
2806         We were just appending the given URL to the absolute URI of the main
2807         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
2808         instead of "file:///foo/bar/theother/url.html".
2809
2810         This should make fast/dom/navigation-type-navigate.html behave
2811         better (it still fails, but later).
2812
2813         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2814         (LayoutTestController::queueLoad):
2815
2816 2011-10-13  Arko Saha  <arko@motorola.com>
2817
2818         Microdata: Basic implementation of document.getItems() method.
2819         https://bugs.webkit.org/show_bug.cgi?id=68610
2820
2821         Reviewed by Ryosuke Niwa.
2822
2823         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
2824         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
2825
2826         * Scripts/build-webkit:
2827
2828 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2829
2830         new-run-webkit-tests does not support qt-4.8 results
2831         https://bugs.webkit.org/show_bug.cgi?id=64071
2832
2833         Roll-back second part of r97252. :)
2834
2835         * Scripts/webkitpy/layout_tests/port/qt.py:
2836
2837 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2838
2839         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
2840         https://bugs.webkit.org/show_bug.cgi?id=70106
2841
2842         Reviewed by Antonio Gomes.
2843
2844         OwnFastMallocPtr was being used as a smart pointer that automatically called
2845         free() on the strings returned by the EFL or by ewk.
2846
2847         However, when WTF is built in release mode, it uses its own memory management
2848         code instead of using the system malloc(), free() and friends. This means bad
2849         things will happen when one uses WTF's free() on memory allocated with system
2850         malloc() by the EFL or ewk.
2851
2852         The easiest way to solve this is to call free() ourselves.
2853
2854         * DumpRenderTree/efl/DumpRenderTree.cpp:
2855         (dumpFramesAsText):
2856         (getFinalTestURL):
2857
2858 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2859
2860         [EFL] Add DumpRenderTreeSupportEfl
2861         https://bugs.webkit.org/show_bug.cgi?id=68458
2862
2863         Reviewed by Kenneth Rohde Christiansen.
2864
2865         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
2866
2867         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2868         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
2869         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2870         (DumpRenderTreeChrome::onWindowObjectCleared):
2871         (DumpRenderTreeChrome::onDocumentLoadFinished):
2872         * DumpRenderTree/efl/GCControllerEfl.cpp:
2873         (GCController::collect):
2874         (GCController::collectOnAlternateThread):
2875         (GCController::getJSObjectCount):
2876         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2877         (LayoutTestController::counterValueForElementById):
2878         (LayoutTestController::pageNumberForElementById):
2879         (LayoutTestController::numberOfPages):
2880         (LayoutTestController::workerThreadCount):
2881         (LayoutTestController::findString):
2882         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2883         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2884         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2885         (LayoutTestController::numberOfActiveAnimations):
2886         (LayoutTestController::suspendAnimations):
2887         (LayoutTestController::resumeAnimations):
2888         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2889         (createBitmapContextFromWebView):
2890
2891 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2892
2893         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
2894
2895         Unreviewed.
2896
2897         * Scripts/run-webkit-tests:
2898         (useNewRunWebKitTests):
2899
2900 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2901
2902         new-run-webkit-tests does not support qt-4.8 results
2903         https://bugs.webkit.org/show_bug.cgi?id=64071
2904
2905         Roll-back r97252 with unit test fix.
2906
2907         Reviewed by Csaba Osztrogonác.
2908
2909         * Scripts/webkitpy/layout_tests/port/qt.py:
2910         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2911
2912 2011-10-13  Ojan Vafai  <ojan@chromium.org>
2913
2914         Make filter-build-webkit exit 1 if the build fails.
2915         https://bugs.webkit.org/show_bug.cgi?id=70080
2916
2917         Reviewed by Eric Seidel.
2918
2919         This only works if you redirect stderr to stdout, but it at least makes it possible.
2920         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
2921         only if the build succeeds.
2922
2923         * Scripts/filter-build-webkit:
2924
2925 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
2926
2927         land-cowboy should at least check style.
2928         https://bugs.webkit.org/show_bug.cgi?id=70073
2929
2930         Reviewed by Adam Barth.
2931
2932         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
2933
2934 2011-10-13  Tony Chang  <tony@chromium.org>
2935
2936         fix regex in layout test times dashboard
2937         https://bugs.webkit.org/show_bug.cgi?id=70059
2938
2939         This fixes the treemapfocus query param.
2940
2941         Reviewed by Ojan Vafai.
2942
2943         * TestResultServer/static-dashboards/treemap.html:
2944
2945 2011-10-13  Beth Dakin  <bdakin@apple.com>
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=70050
2948         DRT and WRT should have HiDPI testing capabilities
2949
2950         Reviewed by Darin Adler.
2951
2952         New layoutTestController function setBackingScaleFactor takes a double for a scale 
2953         factor and a callback function to call once the backing scale factor has 
2954         successfully been set for the view.
2955         * DumpRenderTree/LayoutTestController.cpp:
2956         (setBackingScaleFactorCallback):
2957         (LayoutTestController::staticFunctions):
2958
2959         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
2960         platforms do nothing.
2961         * DumpRenderTree/LayoutTestController.h:
2962         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2963         (LayoutTestController::setBackingScaleFactor):
2964         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2965         (LayoutTestController::setBackingScaleFactor):
2966         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2967         (LayoutTestController::setBackingScaleFactor):
2968
2969         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
2970         value of 0, which resets to the system default.
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (resetWebViewToConsistentStateBeforeTesting):
2973
2974         When generating the pixel dump, create a Bitmap of the appropriate size based on 
2975         the backing scale factor. If it is a HiDPI view, paint into the context using 
2976         displayRectIgnoringOpacity.
2977         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2978         (createBitmapContextFromWebView):
2979
2980         And now the same stuff for WK2. Again, new layoutTestController function 
2981         setBackingScaleFactor takes a double for a scale factor and a callback function. 
2982         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2983         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2984         (WTR::LayoutTestController::setBackingScaleFactor):
2985         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
2986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2987
2988         The InjectedBundle sends a message to the UI process to set the backing scale 
2989         factor. It also processes a message the UI process will send back once it 
2990         completes this task, and at that time, the InjectedBundle calls the callback.
2991         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2992         (WTR::InjectedBundle::didReceiveMessage):
2993         (WTR::InjectedBundle::postSetBackingScaleFactor):
2994         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2995
2996         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
2997         with a value of 0, which resets to the system default.
2998         * WebKitTestRunner/TestController.cpp:
2999         (WTR::TestController::resetStateToConsistentValues):
3000
3001         Upon receiving the SetBackingScaleFactor message, call 
3002         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
3003         back to InjectedBundle to say it has been done.
3004         * WebKitTestRunner/TestInvocation.cpp:
3005         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3006         
3007         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
3008         window's scale factor so we have to avoid that.
3009         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3010         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3011
3012 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
3013
3014         [Chromium] Allow building without speech input enabled.
3015         https://bugs.webkit.org/show_bug.cgi?id=69867
3016
3017         Reviewed by Darin Fisher.
3018
3019         * DumpRenderTree/chromium/LayoutTestController.cpp:
3020         (LayoutTestController::addMockSpeechInputResult):
3021
3022 2011-10-13  Kent Tamura  <tkent@chromium.org>
3023
3024         [Chromium] A DRT fix for r97348.
3025
3026         * DumpRenderTree/chromium/LayoutTestController.cpp:
3027         (LayoutTestController::overridePreference):
3028         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
3029         print an error message.
3030
3031 2011-10-12  Lucas Forschler  <lforschler@apple.com>
3032
3033         Update kill-old-processes logic.
3034         https://bugs.webkit.org/show_bug.cgi?id=63651
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         Remove unused mac platform specific folder.
3039         Update master.config to use new kill-old-processes.
3040
3041         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3042         * BuildSlaveSupport/kill-old-processes:
3043         * BuildSlaveSupport/mac: Removed.
3044
3045 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3046
3047         [NRWT] New tests without expected files are reported as flakey tests
3048         https://bugs.webkit.org/show_bug.cgi?id=67268
3049
3050         Reviewed by Dirk Pranke.
3051
3052         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
3053         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
3054         for missing results in retry_summary.
3055
3056         Fixed the bug by treating missing results separately.
3057
3058         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3059         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3060
3061 2011-10-12  Adam Barth  <abarth@webkit.org>
3062
3063         Remove ENABLE(XHTMLMP) and associated code
3064         https://bugs.webkit.org/show_bug.cgi?id=69729
3065
3066         Reviewed by David Levin.
3067
3068         * Scripts/build-webkit:
3069         * Scripts/old-run-webkit-tests:
3070         * Scripts/webkitperl/features.pm:
3071         * Scripts/webkitpy/layout_tests/port/webkit.py:
3072         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3073
3074 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3075
3076         Kill old run-webkit-tests processes in kill-process on Mac
3077         https://bugs.webkit.org/show_bug.cgi?id=69976
3078
3079         Reviewed by Dirk Pranke.
3080
3081         Add a system call to remove all python processes running run-webkit-tests.
3082
3083         * BuildSlaveSupport/kill-old-processes:
3084         * BuildSlaveSupport/mac: Removed.
3085
3086 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3087
3088         Many WK2 snapshots are blank
3089         https://bugs.webkit.org/show_bug.cgi?id=69953
3090
3091         Reviewed by Beth Dakin.
3092         
3093         Two fixes:
3094         1. negating a size_t in CGContextTranslateCTM() fails, because
3095         size_t is unsigned. Fix by casing to CGFloat before negation.
3096         
3097         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
3098         Autodisplay is necessary to kick off Core Animation rendering.
3099
3100         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3101         (WTR::createCGContextFromImage):
3102         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3103         (WTR::PlatformWebView::PlatformWebView):
3104
3105 2011-10-12  Adam Barth  <abarth@webkit.org>
3106
3107         commit-queue doesn't have a friendly error message when the reviewer line is messed up
3108         https://bugs.webkit.org/show_bug.cgi?id=69979
3109
3110         Reviewed by Eric Seidel.
3111
3112         Rather than combining the ChangeLog validation with a more complicated
3113         command, this patch has the commit-queue run it as a separate command,
3114         which will give us more control over the error message.
3115
3116         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3117         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3118         * Scripts/webkitpy/tool/commands/download.py:
3119         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3120         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3121         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3122
3123 2011-10-12  Eric Seidel  <eric@webkit.org>
3124
3125         Layout tests asserting in LayoutTestController::pathToLocalResource()
3126         https://bugs.webkit.org/show_bug.cgi?id=69898
3127
3128         Reviewed by Simon Fraser.
3129
3130         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
3131
3132         * Scripts/old-run-webkit-tests:
3133         (openDumpTool):
3134
3135 2011-10-12  Adam Barth  <abarth@webkit.org>
3136
3137         The commit-queue doesn't tell me which tests my patch broke
3138         https://bugs.webkit.org/show_bug.cgi?id=69975
3139
3140         Reviewed by Eric Seidel.
3141
3142         We now print the list of newly failing tests, like we do for the EWS.
3143
3144         * Scripts/webkitpy/tool/commands/queues.py:
3145         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3146
3147 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
3148
3149         Added myself as a committer.
3150
3151         * Scripts/webkitpy/common/config/committers.py:
3152
3153 2011-10-12  Adam Barth  <abarth@webkit.org>
3154
3155         _run_tests is a confusing variable name in webkitpy
3156         https://bugs.webkit.org/show_bug.cgi?id=69971
3157
3158         Reviewed by Eric Seidel.
3159
3160         Eric and I thought this was a function.
3161
3162         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3163
3164 2011-10-12  Tony Chang  <tony@chromium.org>
3165
3166         Fix test-webkitpy after r97307 and r97293.
3167
3168         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
3169           is None during tests so add back the check.
3170         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
3171           output directory is now build/Debug.
3172
3173 2011-10-12  Tony Chang  <tony@chromium.org>
3174
3175         [chromium] remove old build dirs on chromium-win
3176         https://bugs.webkit.org/show_bug.cgi?id=69961
3177
3178         Reviewed by Adam Barth.
3179
3180         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
3181           always in build and never in chrome or webkit.
3182
3183 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3184
3185         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
3186         https://bugs.webkit.org/show_bug.cgi?id=69954
3187
3188         Also renamed the action and associated event name to address an FIXME.
3189
3190         Reviewed by Adam Barth.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
3195
3196 2011-10-12  Tony Chang  <tony@chromium.org>
3197
3198         stop spamming 'stopping test driver timed out, killing it' when running rwt
3199         https://bugs.webkit.org/show_bug.cgi?id=69938
3200
3201         Reviewed by Adam Barth.
3202
3203         In http://trac.webkit.org/changeset/95875 , we made the timeout for
3204         stopping the driver based on time_out_ms, but we based it on the wrong
3205         default times.
3206
3207         * Scripts/webkitpy/layout_tests/port/chromium.py:
3208
3209 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3210
3211         3D transforms are flattened in WebKit2 snapshots
3212         https://bugs.webkit.org/show_bug.cgi?id=68276
3213
3214         Reviewed by Adam Roben.
3215         
3216         Fix WKImage leak noticed by Adam.
3217
3218         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3219         (WTR::PlatformWebView::windowSnapshotImage):
3220
3221 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3222
3223         garden-o-matic should color-code test failure types.
3224         https://bugs.webkit.org/show_bug.cgi?id=69945
3225
3226         Reviewed by Adam Barth.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
3232
3233 2011-10-12  Adam Barth  <abarth@webkit.org>
3234
3235         webkitpy tests are failing on Mac bots
3236         https://bugs.webkit.org/show_bug.cgi?id=69929
3237
3238         Reviewed by Simon Fraser.
3239
3240         Admit that Lion exists.
3241
3242         * Scripts/webkitpy/layout_tests/port/chromium.py:
3243         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3244
3245 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3246
3247         Improve output of run-api-tests to make time-outs more obvious
3248         https://bugs.webkit.org/show_bug.cgi?id=69788
3249
3250         Reviewed by Adam Roben.
3251         
3252         List the tests that failed and timed out at the bottom of the output,
3253         if run with --verbose.
3254
3255         * Scripts/run-api-tests:
3256         (runAllTests):
3257         (runTest):
3258
3259 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3260
3261         Unreviewed, rolling out r97252.
3262         http://trac.webkit.org/changeset/97252
3263         https://bugs.webkit.org/show_bug.cgi?id=69944
3264
3265         Broke test-webkpy (Requested by abarth on #webkit).
3266
3267         * Scripts/webkitpy/layout_tests/port/qt.py:
3268         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3269
3270 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3271
3272         new-run-webkit-tests does not support qt-4.8 results
3273         https://bugs.webkit.org/show_bug.cgi?id=64071
3274
3275         Reviewed by Csaba Osztrogonác.
3276
3277         * Scripts/webkitpy/layout_tests/port/qt.py:
3278         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3279
3280 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
3281
3282         [GTK] [WebKit2] Make adding another unit test easier
3283         https://bugs.webkit.org/show_bug.cgi?id=69409
3284
3285         Reviewed by Gustavo Noronha Silva.
3286
3287         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
3288         new WebKit2 tests.
3289
3290 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
3291
3292         [WebSocket] update pywebsocket to 0.6b6.
3293         https://bugs.webkit.org/show_bug.cgi?id=69824
3294
3295         Reviewed by Kent Tamura.
3296
3297         WebKit supports WebSocket with version 8 based protocol for now.
3298         We should update its protocol to version 13 based one like hybi-17.
3299         pywebsocket 0.6b6 supports both of version 8 and 13.
3300
3301         * Scripts/webkitpy/thirdparty/__init__.py:
3302
3303 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
3304
3305         WebKitTestRunner needs to link with WebKit for NSURL category methods
3306         https://bugs.webkit.org/show_bug.cgi?id=69892
3307
3308         Reviewed by Sam Weinig.
3309         
3310         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
3311         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
3312         WebKit.framework to fix this.
3313
3314         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3315
3316 2011-10-11  Adam Barth  <abarth@webkit.org>
3317
3318         sheriffbot takes too long to acknowledge rollout commands
3319         https://bugs.webkit.org/show_bug.cgi?id=69871
3320
3321         Reviewed by Eric Seidel.
3322
3323         We used to update the working copy before acknowledging the command
3324         because we wanted to ping all the relevant IRC nicks.  That's caused a
3325         bunch of frustration because folks don't know whether the bot has heard
3326         their commands.
3327
3328         This patch makes the bot reply immediately before updating the working
3329         copy.  All the relevenat folks are still pinged when the bot finishes
3330         preparing the rollout.
3331
3332         * Scripts/webkitpy/tool/bot/irc_command.py:
3333         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3334
3335 2011-10-11  Adam Barth  <abarth@webkit.org>
3336
3337         test-webkitpy fails on Lion
3338         https://bugs.webkit.org/show_bug.cgi?id=69873
3339
3340         Reviewed by Eric Seidel.
3341
3342         This patch fixes one of the two failures.  I'll need to track down the
3343         other failure another time.
3344
3345         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3346
3347 2011-10-11  Adam Barth  <abarth@webkit.org>
3348
3349         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
3350         https://bugs.webkit.org/show_bug.cgi?id=65230
3351
3352         Reviewed by Dimitri Glazkov.
3353
3354         This patch causes us to treat crashed or hung run-webkit-tests runs
3355         similarly to how we treat compile failures.  In some sense, they're
3356         similar because they prevent us from getting test coverage.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3360
3361 2011-10-11  Adam Barth  <abarth@webkit.org>
3362
3363         Failing builder display in garden-o-matic should have the same visual style as the failure grid
3364         https://bugs.webkit.org/show_bug.cgi?id=69876
3365
3366         Reviewed by Dimitri Glazkov.
3367
3368         This patch generalizes the view we use for failing builders in the
3369         FailureGrid so that we can use it for the list of builders that aren't
3370         compiling.
3371
3372         One downside of this patch is that it makes it harder to tell when
3373         debug builders are failing (as opposed to release builders) because
3374         that information isn't presented in this view.  A future patch will
3375         improve this aspect.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3383
3384 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
3385
3386         Some API tests are timing out in Release
3387         https://bugs.webkit.org/show_bug.cgi?id=69787
3388
3389         Reviewed by Mark Rowe.
3390         
3391         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
3392         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
3393
3394         * TestWebKitAPI/Configurations/Base.xcconfig:
3395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3396         * TestWebKitAPI/config.h:
3397
3398 2011-10-11  Adam Barth  <abarth@webkit.org>
3399
3400         garden-o-matic links to flakiness dashboard should open in a new tab
3401         https://bugs.webkit.org/show_bug.cgi?id=69864
3402
3403         Reviewed by Dimitri Glazkov.
3404
3405         This bug was obvious in the first five minutes of using this new
3406         feature.  :)
3407
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3410
3411 2011-10-11  Adam Barth  <abarth@webkit.org>
3412
3413         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
3414         that * doesn't really mean "all".  I've emailed the W3C working group
3415         about changing the spec.
3416
3417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3418
3419 2011-10-11  Adam Barth  <abarth@webkit.org>
3420
3421         garden-o-matic should link to the flakiness dashboard
3422         https://bugs.webkit.org/show_bug.cgi?id=69862
3423
3424         Reviewed by Dimitri Glazkov.
3425
3426         The flakiness dashboard has lots of great information about the failure
3427         history of each test.  This patch adds a link from garden-o-matic to
3428         the flakiness dashboard so the gardener can look at this information.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3433
3434 2011-10-11  David Levin  <levin@chromium.org>
3435
3436         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
3437         https://bugs.webkit.org/show_bug.cgi?id=69789
3438
3439         Reviewed by Eric Seidel.
3440
3441         Made the signature of _assertRaisesRegexp match that of Python 2.7.
3442
3443         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
3444         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
3445         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
3446         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
3447
3448 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3449
3450         [EFL] DRT: Do not abort() when an unknown key is pressed.
3451         https://bugs.webkit.org/show_bug.cgi?id=69856
3452
3453         Reviewed by Antonio Gomes.
3454
3455         A lot of tests crash due to the previous behaviour. Just using the
3456         received name of the pressed key works most of the time, and when it
3457         does not the failing tests should tell us.
3458
3459         * DumpRenderTree/efl/EventSender.cpp:
3460         (keyPadNameFromJSValue):
3461         (keyNameFromJSValue):
3462         (keyDownCallback):
3463
3464 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3465
3466         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
3467         https://bugs.webkit.org/show_bug.cgi?id=68016
3468
3469         Reviewed by Chang Shu.
3470
3471         * Scripts/webkitpy/layout_tests/port/qt.py:
3472
3473 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3474
3475         [EFL] DRT: Return the right window count in LayoutTestController.
3476         https://bugs.webkit.org/show_bug.cgi?id=69764
3477
3478         Reviewed by Antonio Gomes.
3479
3480         Follow-up to r96943: now that we have DumpRenderTreeChrome and
3481         DumpRenderTreeView in the tree, we can correctly count the number of
3482         open windows in DRT.
3483
3484         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3485         (LayoutTestController::windowCount):
3486
3487 2011-10-11  Jer Noble  <jer.noble@apple.com>
3488
3489         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
3490         https://bugs.webkit.org/show_bug.cgi?id=69800
3491
3492         Reviewed by Csaba Osztrogonác.
3493
3494         Enable WEB_AUDIO at runtime.
3495
3496         * DumpRenderTree/mac/DumpRenderTree.mm:
3497         (resetDefaultsToConsistentValues):
3498
3499 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3500
3501         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
3502         https://bugs.webkit.org/show_bug.cgi?id=69769
3503
3504         Reviewed by Antonio Gomes.
3505
3506         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3507         (LayoutTestController::setIconDatabaseEnabled):
3508
3509 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3510
3511         [Qt] Remove all references to QTDIR_build and standalone_package
3512
3513         Qt is now modularized, which means we no longer import WebKit into
3514         the Qt source tree. Instead we use git submodules, and building
3515         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
3516
3517         To decrease the number of buildsystem configurations we also remove
3518         the standalone_package code-path used when we were providing tarballs
3519         with the derived sources pre-generated.
3520
3521         Reviewed by Simon Hausmann.
3522
3523         * MiniBrowser/qt/MiniBrowser.pro:
3524         * QtTestBrowser/QtTestBrowser.pro:
3525         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3526
3527 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
3528
3529         Update Chromium accessibility support in DRT.
3530         https://bugs.webkit.org/show_bug.cgi?id=69676
3531
3532         Reviewed by Chris Fleizach.
3533
3534         Adds several missing properties and methods to enable more
3535         tests to pass, and in particular adds support for notification
3536         callbacks.
3537
3538         * DumpRenderTree/chromium/AccessibilityController.cpp:
3539         (AccessibilityController::AccessibilityController):
3540         (AccessibilityController::reset):
3541         (AccessibilityController::getFocusedElement):
3542         (AccessibilityController::shouldLogAccessibilityEvents):
3543         (AccessibilityController::notificationReceived):
3544         (AccessibilityController::logAccessibilityEventsCallback):
3545         * DumpRenderTree/chromium/AccessibilityController.h:
3546         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3547         (getHelpText):
3548         (getStringValue):
3549         (getOrientation):
3550         (AccessibilityUIElement::AccessibilityUIElement):
3551         (AccessibilityUIElement::getChildAtIndex):
3552         (AccessibilityUIElement::isEqual):
3553         (AccessibilityUIElement::notificationReceived):
3554         (AccessibilityUIElement::roleGetterCallback):
3555         (AccessibilityUIElement::titleGetterCallback):
3556         (AccessibilityUIElement::descriptionGetterCallback):
3557         (AccessibilityUIElement::helpTextGetterCallback):
3558         (AccessibilityUIElement::stringValueGetterCallback):
3559         (AccessibilityUIElement::xGetterCallback):
3560         (AccessibilityUIElement::yGetterCallback):
3561         (AccessibilityUIElement::widthGetterCallback):
3562         (AccessibilityUIElement::heightGetterCallback):
3563         (AccessibilityUIElement::intValueGetterCallback):
3564         (AccessibilityUIElement::minValueGetterCallback):
3565         (AccessibilityUIElement::maxValueGetterCallback):
3566         (AccessibilityUIElement::childrenCountGetterCallback):
3567         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3568         (AccessibilityUIElement::selectedTextRangeGetterCallback):
3569         (AccessibilityUIElement::isEnabledGetterCallback):
3570         (AccessibilityUIElement::isRequiredGetterCallback):
3571         (AccessibilityUIElement::isFocusedGetterCallback):
3572         (AccessibilityUIElement::isFocusableGetterCallback):
3573         (AccessibilityUIElement::isSelectedGetterCallback):
3574         (AccessibilityUIElement::isSelectableGetterCallback):
3575         (AccessibilityUIElement::isMultiSelectableGetterCallback):
3576         (AccessibilityUIElement::isExpandedGetterCallback):
3577         (AccessibilityUIElement::isCheckedGetterCallback):
3578         (AccessibilityUIElement::isVisibleGetterCallback):
3579         (AccessibilityUIElement::isOffScreenGetterCallback):
3580         (AccessibilityUIElement::isCollapsedGetterCallback):
3581         (AccessibilityUIElement::hasPopupGetterCallback):
3582         (AccessibilityUIElement::isValidGetterCallback):
3583         (AccessibilityUIElement::orientationGetterCallback):
3584         (AccessibilityUIElement::showMenuCallback):
3585         (AccessibilityUIElement::pressCallback):
3586         (AccessibilityUIElement::isEqualCallback):
3587         (AccessibilityUIElement::addNotificationListenerCallback):
3588         (AccessibilityUIElement::removeNotificationListenerCallback):
3589         (AccessibilityUIElement::takeFocusCallback):
3590         (AccessibilityUIElement::fallbackCallback):
3591         (RootAccessibilityUIElement::getChildAtIndex):
3592         (AccessibilityUIElementList::getOrCreate):
3593         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3594         * DumpRenderTree/chromium/CppVariant.cpp:
3595         (CppVariant::invokeDefault):
3596         * DumpRenderTree/chromium/CppVariant.h:
3597         * DumpRenderTree/chromium/LayoutTestController.cpp:
3598         (LayoutTestController::LayoutTestController):
3599         (LayoutTestController::reset):
3600         * DumpRenderTree/chromium/LayoutTestController.h:
3601         * DumpRenderTree/chromium/WebViewHost.cpp:
3602         (WebViewHost::postAccessibilityNotification):
3603
3604 2011-10-10  Adam Klein  <adamk@chromium.org>
3605
3606         Support Distributed-CompileC as an action name in filter-build-webkit
3607         https://bugs.webkit.org/show_bug.cgi?id=69783
3608
3609         Reviewed by Ojan Vafai.
3610
3611         * Scripts/filter-build-webkit:
3612
3613 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3614
3615         3D transforms are flattened in WebKit2 snapshots
3616         https://bugs.webkit.org/show_bug.cgi?id=68276
3617
3618         Reviewed by Anders Carlsson.
3619         
3620         Use a snapshot of the window, rather than an image from the web process
3621         for pixel testing in WebKitTestRunner. This correctly captures compositing
3622         layers, so works for 3D transform tests.
3623
3624         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
3625         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3626         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
3627         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
3628         use that instead of the image we get from the web process.
3629         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3630         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
3631         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3632         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3633         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3634         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3635         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3636         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3637
3638 2011-10-10  David Levin  <levin@chromium.org>
3639
3640         Quick fix for watchlist unit test failures when using Python 2.7+
3641         Reviewed by Adam Barth.
3642
3643         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
3644         better fix.
3645
3646         * Scripts/webkitpy/common/webkitunittest.py: Always use our
3647         version of assertRaisesRegexp.
3648
3649 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3650
3651         Unreviewed, rolling out r97082.
3652         http://trac.webkit.org/changeset/97082
3653         https://bugs.webkit.org/show_bug.cgi?id=69784
3654
3655         broke Windows build (Requested by smfr on #webkit).
3656
3657         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3658         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
3659         (WTR::createCGContextFromImage):
3660         (WTR::computeMD5HashStringForContext):
3661         (WTR::dumpBitmap):
3662         (WTR::paintRepaintRectOverlay):
3663         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3664         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3665         (WTR::PlatformWebView::PlatformWebView):
3666
3667 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3668
3669         3D transforms are flattened in WebKit2 snapshots
3670         https://bugs.webkit.org/show_bug.cgi?id=68276
3671
3672         Reviewed by Anders Carlsson.
3673         
3674         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
3675         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
3676         the window when doing pixel tests.
3677         
3678         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
3679
3680         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
3681         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
3682         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
3683         (WTR::computeMD5HashStringForContext):
3684         (WTR::dumpBitmap):
3685         (WTR::paintRepaintRectOverlay):
3686         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
3687         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
3688         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3689         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
3690         We need the window to autodisplay for Core Animation to render layers and start animations.
3691
3692 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
3693
3694         WebKitTestRunner needs layoutTestController.setWindowIsKey
3695         https://bugs.webkit.org/show_bug.cgi?id=42688
3696
3697         Reviewed by Anders Carlsson.
3698
3699         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
3700         This sets a flag that the platform layer uses to indicate that
3701         the window is the key window, which fixes focus ring drawing
3702         in pixel results.
3703         
3704         Also focus the web view when we get a 'didCommitLoad' for the main
3705         frame, as DumpRenderTree does.
3706
3707         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3709         (WTR::InjectedBundle::postSetWindowIsKey):
3710         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3711         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3712         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
3713         (WTR::LayoutTestController::addChromeInputField):
3714         (WTR::LayoutTestController::removeChromeInputField):
3715         (WTR::LayoutTestController::focusWebView):
3716         (WTR::LayoutTestController::setWindowIsKey):
3717         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
3718         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
3719         (WTR::LayoutTestController::callFocusWebViewCallback):
3720         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3721         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
3722         so that we can override -isKeyWindow. Use a boolean member variable
3723         to track window key status.
3724         (WTR::PlatformWebView::setWindowIsKey):
3725         (WTR::PlatformWebView::windowIsKey):
3726         * WebKitTestRunner/TestController.cpp:
3727         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
3728         (WTR::closeOtherPage): Use the same cast as other functions.
3729         (WTR::focus): Implement to call setWindowIsKey(true)
3730         (WTR::unfocus): Implement to call setWindowIsKey(false)
3731         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
3732         (WTR::TestController::initialize):
3733         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
3734         * WebKitTestRunner/TestController.h:
3735         * WebKitTestRunner/TestInvocation.cpp:
3736         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3737         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3738         (WTR::PlatformWebView::PlatformWebView):
3739         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3740         (-[WebKitTestRunnerWindow isKeyWindow]):
3741         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
3742         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
3743         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
3744         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3745         (WTR::PlatformWebView::PlatformWebView):
3746         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3747         (WTR::PlatformWebView::PlatformWebView):
3748
3749 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
3750
3751         check-webkit-style: Add readability exception for Ewk_* data types.
3752         https://bugs.webkit.org/show_bug.cgi?id=69763
3753
3754         Reviewed by David Levin.
3755
3756         Many EFL-related files (such as EditorClientEfl.h or
3757         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
3758         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
3759         check-webkit-style.
3760
3761         Add an exception for them, just like there are exceptions for
3762         Evas_*, Ecore_* and others.
3763
3764         * Scripts/webkitpy/style/checkers/cpp.py:
3765         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3766
3767 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
3768
3769         [Chromium] Get rid of WebAccessibilityCache.
3770         https://bugs.webkit.org/show_bug.cgi?id=68224
3771
3772         Reviewed by Dimitri Glazkov.
3773
3774         * DumpRenderTree/chromium/AccessibilityController.cpp:
3775         (AccessibilityController::bindToJavascript):
3776
3777 2011-10-09  Adam Barth  <abarth@webkit.org>
3778
3779         Remove "near miss" XSS vulnerabilities in garden-o-matic
3780         https://bugs.webkit.org/show_bug.cgi?id=69708
3781
3782         Reviewed by David Levin.
3783
3784         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
3785         any actual vulnerabilities yet, but he did identify a couple "near
3786         misses" where a slight change in garden-o-matic could lead to a
3787         vulnerability.  This patch removes those potential issues.
3788
3789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
3790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3791
3792 2011-10-07  Adam Barth  <abarth@webkit.org>
3793
3794         Add a Content-Security-Policy to garden-o-matic
3795         https://bugs.webkit.org/show_bug.cgi?id=69668
3796
3797         Reviewed by David Levin.
3798
3799         This will help mitigate cross-site script and will also help us dogfood CSP.
3800
3801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3802
3803 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
3804
3805         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
3806         https://bugs.webkit.org/show_bug.cgi?id=66380
3807
3808         Reviewed by Antonio Gomes.
3809
3810         This encapsulates EWebKit into an object that manages multiple windows
3811         and provides a cleaner interface to EFL's DumpRenderTree.
3812
3813         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
3814         (DumpRenderTreeChrome::create):
3815         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3816         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
3817         (DumpRenderTreeChrome::createNewWindow):
3818         (DumpRenderTreeChrome::createView):
3819         (DumpRenderTreeChrome::removeWindow):
3820         (DumpRenderTreeChrome::initialize):
3821         (DumpRenderTreeChrome::extraViews):
3822         (DumpRenderTreeChrome::mainFrame):
3823         (DumpRenderTreeChrome::mainView):
3824         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3825         (DumpRenderTreeChrome::onWindowObjectCleared):
3826         (DumpRenderTreeChrome::onLoadStarted):
3827         (DumpRenderTreeChrome::processWork):
3828         (DumpRenderTreeChrome::onLoadFinished):
3829         (DumpRenderTreeChrome::onStatusbarTextSet):
3830         (DumpRenderTreeChrome::onTitleChanged):
3831         (DumpRenderTreeChrome::onDocumentLoadFinished):
3832         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
3833         * DumpRenderTree/efl/EventSender.cpp:
3834         (sendClick): Use browser->mainFrame() instead of mainFrame.
3835         (mouseDownCallback): Ditto.
3836         (mouseUpCallback): Ditto.
3837         (mouseMoveToCallback): Ditto.
3838         (mouseScrollByCallback): Ditto.
3839         (keyDownCallback): Ditto.
3840         (scalePageByCallback): Ditto.
3841         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3842         (LayoutTestController::counterValueForElementById): Use
3843         browser->mainFrame() instead of mainFrame.
3844         (LayoutTestController::pageNumberForElementById): Ditto.
3845         (LayoutTestController::numberOfPages): Ditto.
3846         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
3847         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
3848         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
3849         (LayoutTestController::numberOfActiveAnimations): Ditto.
3850         (LayoutTestController::suspendAnimations): Ditto.
3851         (LayoutTestController::resumeAnimations): Ditto.
3852         (LayoutTestController::setWebViewEditable): Ditto.
3853         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
3854         instead of browser.
3855         (LayoutTestController::queueLoad): Ditto.
3856         (LayoutTestController::setAcceptsEditing): Ditto.
3857         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
3858         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
3859         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
3860         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
3861         (LayoutTestController::setPluginsEnabled): Ditto.
3862         (LayoutTestController::findString): Ditto.
3863         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
3864         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3865         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
3866         mainFrame.
3867         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3868         (LoadItem::invoke): Ditto.
3869         (LoadHTMLStringItem::invoke): Ditto.
3870         (ScriptItem::invoke): Ditto.
3871         (ReloadItem::invoke): Use browser->mainView() instead of browser.
3872
3873 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
3874
3875         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
3876         https://bugs.webkit.org/show_bug.cgi?id=69617
3877
3878         Reviewed by Andreas Kling.
3879
3880         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
3881         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
3882         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
3883         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
3884         logic.
3885
3886         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3887         (MiniBrowserApplication::MiniBrowserApplication):
3888         (MiniBrowserApplication::notify):
3889         * MiniBrowser/qt/MiniBrowserApplication.h:
3890
3891 2011-10-06  Adam Barth  <abarth@webkit.org>
3892
3893         Port PixelZoomer to work in garden-o-matic
3894         https://bugs.webkit.org/show_bug.cgi?id=69577
3895
3896         Reviewed by David Levin.
3897
3898         This implementation of PixelZoomer is basically a fork of the
3899         implementation used by results.html.  These two apps have different
3900         requirements on where this code lives.  results.html wants to be
3901         self-contained whereas garden-o-matic wants to live in the public_html
3902         folder of the buildbot.  We could do something fancy here to share the
3903         code, but that's not likely to be of much benefit.
3904
3905         I had to change a few things about pixelzoomer to accounter for the
3906         differences in DOM between results.html and garden-o-matic, but
3907         surprisingly little.  I also moved all the code into an anonymous
3908         function, which is the style we're suing for module separation in
3909         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
3910         want to drag along too many extra functions from results.html.
3911
3912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
3915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
3917         (.pixel-zoom-container):
3918         (.pixel-zoom-container > *):
3919         (.pixel-zoom-container .scaled-image-container):
3920         (.scaled-image-container > img):
3921
3922 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3923
3924         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
3925         https://bugs.webkit.org/show_bug.cgi?id=69505
3926
3927         Reviewed by Andreas Kling.
3928
3929         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
3930         (on_viewport_changed):
3931
3932 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3933
3934         [WinCairo] Unreviewed test correction.
3935
3936         * Scripts/webkitdirs.pm:
3937         (argumentsForConfiguration): Add 'wincairo' option to the set of
3938         configuration flags used by run-javascript-core tests, so that it
3939         does not attempt to run Apple's release version.
3940
3941 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3942
3943         [WinCairo] Unreviewed test correction.
3944
3945         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
3946          of known build slave types so that test-result-archive won't fail
3947          when running tests.
3948
3949 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
3950
3951         The GTK+ WebKit2 headers produce a lot of style warnings
3952         https://bugs.webkit.org/show_bug.cgi?id=69481
3953
3954         Reviewed by David Levin.
3955
3956         Prevent emitting so many style warnings for GTK+ API. We skip header
3957         files in the WebKit2 GTK+ API directory and also avoid warnings about
3958         identifier names that begin with "webkit_" in files that contain the
3959         string "gtk".
3960
3961         * Scripts/webkitpy/style/checker.py: Do not check header files in
3962         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
3963         adding the ability to specify a regular expression in the skip list. Remove
3964         a few files from the skipped list that no longer exist.
3965         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
3966         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
3967         about identifiers that begin with "webkit_".
3968         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
3969
3970 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
3971
3972         [WinCairo] Correct config.json for WinCairo Test builds.
3973         https://bugs.webkit.org/show_bug.cgi?id=69272
3974
3975         Reviewed by Ryosuke Niwa.
3976
3977         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
3978          old 'WinCairo Debug (Build)' label and replace with correct
3979          'WinCairo Release' label.
3980
3981 2011-10-06  David Levin  <levin@chromium.org>
3982
3983         Add a style checker watchlist definition and add myself to it.
3984         https://bugs.webkit.org/show_bug.cgi?id=69564
3985
3986         Reviewed by Daniel Bates.
3987
3988         * Scripts/webkitpy/common/config/watchlist:
3989
3990 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3991
3992         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
3993         https://bugs.webkit.org/show_bug.cgi?id=69450
3994
3995         Reviewed by Ryosuke Niwa.
3996
3997         This should avoid stderr messages when running
3998         webarchive/test-link-rel-icon.html.
3999
4000         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4001         (LayoutTestController::setIconDatabaseEnabled):
4002
4003 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
4004
4005         [WK2] [GTK] Add Skipped file for Webkit2 test runner
4006         https://bugs.webkit.org/show_bug.cgi?id=69517
4007
4008         Use the shared WK2 skipped file also in GTK port.
4009
4010         Reviewed by Martin Robinson.
4011
4012         * Scripts/old-run-webkit-tests:
4013         (readSkippedFiles):
4014
4015 2011-10-06  Elliot Poger  <epoger@google.com>
4016
4017         allow new-run-webkit-tests to run on Lion
4018         https://bugs.webkit.org/show_bug.cgi?id=69429
4019
4020         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
4021         directory to fallback lists (even though that directory doesn't exist yet)
4022
4023         Reviewed by Adam Barth.
4024
4025         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4026         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4027
4028 2011-10-03  Hans Wennborg  <hans@chromium.org>
4029
4030         IndexedDB: Remove SQLite-LevelDB migration code
4031         https://bugs.webkit.org/show_bug.cgi?id=69264
4032
4033         Reviewed by Tony Chang.
4034
4035         Remove setOverrideIndexedDBBackingStore. It was used in the layout
4036         test for migration.
4037
4038         * DumpRenderTree/chromium/LayoutTestController.cpp:
4039         (LayoutTestController::LayoutTestController):
4040         * DumpRenderTree/chromium/LayoutTestController.h:
4041
4042 2011-10-05  James Robinson  <jamesr@chromium.org>
4043
4044         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
4045         https://bugs.webkit.org/show_bug.cgi?id=69498
4046
4047         Reviewed by Adam Barth.
4048
4049         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4050         (main):
4051         * DumpRenderTree/chromium/TestShell.cpp:
4052         (TestShell::TestShell):
4053         (TestShell::resetWebSettings):
4054         * DumpRenderTree/chromium/TestShell.h:
4055         (TestShell::setThreadedCompositingEnabled):
4056         * DumpRenderTree/chromium/WebPreferences.cpp:
4057         (WebPreferences::reset):
4058         (WebPreferences::applyTo):
4059         * DumpRenderTree/chromium/WebPreferences.h:
4060         * Scripts/webkitpy/layout_tests/port/chromium.py:
4061         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4062
4063 2011-10-05  Erik Arvidsson  <arv@chromium.org>
4064
4065         [QT] Fix DRT after r96779
4066
4067         unreviewed.
4068
4069         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4070         (WebCore::dumpHistoryItem):
4071
4072 2011-10-05  Erik Arvidsson  <arv@chromium.org>
4073
4074         window.location.href and others needlessly decodes URI-encoded characters
4075         https://bugs.webkit.org/show_bug.cgi?id=30225
4076
4077         Reviewed by Darin Adler.
4078
4079         * DumpRenderTree/chromium/TestShell.cpp:
4080         (normalizeLayoutTestURLInternal): Remove extra encode.
4081
4082 2011-10-05  Darin Adler  <darin@apple.com>
4083
4084         Fix build.
4085
4086         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
4087         (TestWebKitAPI::TEST): Remove underscore prefix from call to
4088         WKContextRegisterURLSchemeAsEmptyDocument.
4089
4090 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
4091
4092         [WinCairo] Switch to building Release target, and activate tests.
4093         https://bugs.webkit.org/show_bug.cgi?id=69272
4094
4095         Reviewed by Adam Barth.
4096
4097         * BuildSlaveSupport/build.webkit.org-config/config.json:
4098         Change from debug to release target. Switch from "Build" to
4099         "BuildAndTest"
4100
4101 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
4102
4103         In WebKitTestRunner, text has font smoothing in pixel snapshots
4104         https://bugs.webkit.org/show_bug.cgi?id=69396
4105
4106         Reviewed by Darin Adler.
4107         
4108         Call the new WKContext method that disables font smoothing in
4109         WebKitTestRunner, so that pixel snapshots don't have font smoothing
4110         enabled. Remove leading underscore from a WKContext function call.
4111
4112         * WebKitTestRunner/TestController.cpp:
4113         (WTR::TestController::resetStateToConsistentValues):
4114
4115 2011-10-05  David Levin  <levin@chromium.org>
4116
4117         Improve the watchlist for threading entries.
4118         https://bugs.webkit.org/show_bug.cgi?id=69463
4119
4120         Reviewed by Adam Barth.
4121
4122         * Scripts/webkitpy/common/config/watchlist:
4123
4124 2011-10-05  Adam Roben  <aroben@apple.com>
4125
4126         Add tests for using RetainPtrs inside HashMap and HashSet
4127
4128         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
4129         in HashMap/HashSet fails to compile
4130
4131         Reviewed by John Sullivan.
4132
4133         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
4134         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
4135         and value type of HashMap.
4136
4137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4138         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4139         Added new file.
4140
4141 2011-10-05  Adam Barth  <abarth@webkit.org>
4142
4143         Mark as Expected in garden-o-matic is confusing
4144         https://bugs.webkit.org/show_bug.cgi?id=69452
4145
4146         Reviewed by David Levin.
4147
4148         krit didn't understand the difference between this button and the
4149         Rebaseline button because both of them seem to indicate that the new
4150         behavior is expected.  This patch renames "Mark as Expected" to "Expect
4151         Failure" to make it clear that we're just expecting the test to fail
4152         rather than accepting the new results as passing.  We might need to
4153         iterate on these names a bit more if folks continue to find them
4154         confusing.
4155
4156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
4157
4158 2011-10-05  Adam Barth  <abarth@webkit.org>
4159
4160         Add watchlist entries for abarth
4161         https://bugs.webkit.org/show_bug.cgi?id=69461
4162
4163         Reviewed by David Levin.
4164
4165         I might have gone a bit overboard.  We'll see if this is too much spam
4166         for me.
4167
4168         * Scripts/webkitpy/common/config/watchlist:
4169
4170 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
4171
4172         [WinCairo] Teach old-run-webkit-tests about wincairo.
4173         https://bugs.webkit.org/show_bug.cgi?id=69280
4174
4175         Reviewed by Adam Roben.
4176
4177         * Scripts/old-run-webkit-tests: Handle wincairo case.
4178         (buildPlatformResultHierarchy):
4179         (readSkippedFiles): Ditto
4180         * Scripts/webkitdirs.pm: Deal with wincairo build case.
4181         (determineConfiguration):
4182
4183 2011-10-05  Chang Shu  <cshu@webkit.org>
4184
4185         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
4186         https://bugs.webkit.org/show_bug.cgi?id=68924
4187
4188         Added TextInputController files and JS interfaces for the above functions.
4189
4190         Reviewed by Darin Adler.
4191
4192         * WebKitTestRunner/DerivedSources.make:
4193         * WebKitTestRunner/DerivedSources.pro:
4194         * WebKitTestRunner/GNUmakefile.am:
4195         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
4196         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4197         (WTR::InjectedBundle::beginTesting):
4198         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4199         (WTR::InjectedBundle::textInputController):
4200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4201         (WTR::InjectedBundlePage::didClearWindowForFrame):
4202         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
4203         (WTR::TextInputController::create):
4204         (WTR::TextInputController::TextInputController):
4205         (WTR::TextInputController::~TextInputController):
4206         (WTR::TextInputController::wrapperClass):
4207         (WTR::TextInputController::makeWindowObject):
4208         (WTR::TextInputController::setMarkedText):
4209         (WTR::TextInputController::hasMarkedText):
4210         (WTR::TextInputController::unmarkText):
4211         (WTR::TextInputController::insertText):
4212         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
4213         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4214         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4215         * WebKitTestRunner/win/InjectedBundle.vcproj:
4216
4217 2011-10-04  Oliver Hunt  <oliver@apple.com>
4218
4219         Add rudimentary filtering to write barriers
4220         https://bugs.webkit.org/show_bug.cgi?id=69392
4221
4222         Reviewed by Filip Pizlo.
4223
4224         When we're recording gc phase times Heap.o picks up
4225         some exit time destructors, so we'll just ignore Heap.o
4226         in this check.
4227
4228         * Scripts/check-for-exit-time-destructors:
4229
4230 2011-10-05  Chang Shu  <cshu@webkit.org>
4231
4232         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
4233         https://bugs.webkit.org/show_bug.cgi?id=69365
4234
4235         Reviewed by Darin Adler.
4236
4237         Added js API in WTR LayoutTestController.
4238
4239         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4240         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4241         (WTR::LayoutTestController::dumpConfigurationForViewport):
4242         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4243
4244 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
4245
4246         [EFL] ImageDiff: Do not clear the image before it is processed and compared
4247         https://bugs.webkit.org/show_bug.cgi?id=69378
4248
4249         Reviewed by Antonio Gomes.
4250
4251         Commit 61836 to Evas added a few cleanup calls to some
4252         evas_object_image functions which effectively made ImageDiff consider
4253         all images to be equal.
4254
4255         It turns out that now evas_object_image_colorspace_set clears any
4256         data set, so the call to evas_object_image_data_set was not having any
4257         effect.
4258
4259         * DumpRenderTree/efl/ImageDiff.cpp:
4260         (readImageFromStdin): Call evas_object_image_data_set after
4261         evas_object_image_colorspace_set.
4262
4263 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
4264
4265         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
4266         https://bugs.webkit.org/show_bug.cgi?id=68449
4267
4268         Reviewed by Antonio Gomes.
4269
4270         evas_render() must be called to close up temporary files and unmap unused
4271         resources. evas_object_image_data_set() must be called after an
4272         evas_object_image_data_get() to balance an internal reference count.
4273
4274         * DumpRenderTree/efl/ImageDiff.cpp:
4275         (differenceImageFromDifferenceBuffer):
4276         (calculateDifference):
4277         (printImage):
4278         (printImageDifferences):
4279
4280 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
4281
4282         [Qt][WK2] Unreviewed build fix.
4283
4284         Don't use WebCore directly in WTR.
4285
4286         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4287         (WTR::PlatformWebView::addChromeInputField):
4288         (WTR::PlatformWebView::removeChromeInputField):
4289         (WTR::PlatformWebView::makeWebViewFirstResponder):
4290
4291 2011-10-05  David Levin  <levin@chromium.org>
4292
4293         watchlist: Add more rules for chromium public api and sort the file.
4294         https://bugs.webkit.org/show_bug.cgi?id=69323
4295
4296         Reviewed by Adam Barth.
4297
4298         * Scripts/webkitpy/common/config/watchlist:
4299
4300 2011-10-05  David Levin  <levin@chromium.org>
4301
4302         watchlist: Don't add the same message to a bug more than once.
4303         https://bugs.webkit.org/show_bug.cgi?id=69303
4304
4305         Reviewed by Adam Barth.
4306
4307         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
4308         if a message is in the comments already.
4309         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
4310         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
4311         Pick a bug supplied by the mock. Change&nb