REGRESSION (r169042): Fix run-api-tests on Mountain Lion
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2
3         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
4         <http://webkit.org/b/132954>
5
6         * Scripts/webkitdirs.pm:
7         (sharedCommandLineOptionsUsage): Remove the prototype for the
8         subroutine.  Older perls don't like the "+@" syntax.
9
10 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
11
12         run-javascriptcore-tests should sort the list of failing stress tests
13         https://bugs.webkit.org/show_bug.cgi?id=132989
14
15         Reviewed by Csaba Osztrogonác.
16
17         * Scripts/run-javascriptcore-tests:
18
19 2014-05-19  David Kilzer  <ddkilzer@apple.com>
20
21         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
22         <http://webkit.org/b/132954>
23
24         Reviewed by Darin Adler.
25
26         Extract code into setupMacWebKitEnvironment() for setting up
27         common environment variables so it may be shared.  Sets
28         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
29         using guardmalloc to some scripts.
30
31         Also adds support for parsing shared (common) command-line
32         switches, initially just -g|--guard-malloc.
33
34         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
35         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
36         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
37         local copy of %ENV when launching Safari so we don't have to
38         restore variables.
39
40         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
41         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
42         Check result of GetOptions() to catch invalid command-line
43         switches.
44         (runTest): Use a local copy of %ENV when running tests so we
45         don't have to restore variables.
46         (prepareEnvironmentForRunningTestTool): Call
47         setupMacWebKitEnvironment().
48
49         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
50         using sharedCommandLineOptions() and
51         sharedCommandLineOptionsUsage().  Call
52         setupMacWebKitEnvironment().
53
54         * Scripts/webkitdirs.pm:
55         (sharedCommandLineOptions): Return array of common switches to
56         pass to Getopt::Long::GetOptions().
57         (sharedCommandLineOptionsUsage): Return formatted string of
58         common switches for printing usage help text.
59         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
60         guardmalloc.
61         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
62         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
63         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
64         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
65         local copy of %ENV when launching Safari so we don't have to
66         restore variables.
67         (execMacWebKitAppForDebugging): Call
68         setupMacWebKitEnvironment().
69
70 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
71
72         support for navigator.hardwareConcurrency
73         https://bugs.webkit.org/show_bug.cgi?id=132588
74
75         Reviewed by Filip Pizlo.
76
77         * Scripts/webkitperl/FeatureList.pm:
78
79 2014-05-18  Anders Carlsson  <andersca@apple.com>
80
81         Implement Navigations for all methods declared returning one
82         https://bugs.webkit.org/show_bug.cgi?id=133048
83         <rdar://problem/16830064>
84
85         Reviewed by Sam Weinig.
86
87         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
88         Import WebKit.h.
89         
90         * MiniBrowser/mac/WK2BrowserWindowController.m:
91         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
92         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
93         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
94         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
95         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
96         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
97         Print out the navigations.
98
99 2014-05-17  Zalan Bujtas  <zalan@apple.com>
100
101         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
102         https://bugs.webkit.org/show_bug.cgi?id=133029
103
104         Reviewed by Simon Fraser.
105
106         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
107         toggling it on a WK2 window needs restart.
108         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
109         the WebPreferences just to support this temporary toggle.
110
111         * MiniBrowser/mac/BrowserWindowController.h:
112         * MiniBrowser/mac/MainMenu.xib:
113         * MiniBrowser/mac/WK1BrowserWindowController.m:
114         (-[WK1BrowserWindowController validateMenuItem:]):
115         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
116         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
117         * MiniBrowser/mac/WK2BrowserWindowController.m:
118         (-[WK2BrowserWindowController validateMenuItem:]):
119         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
120         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
121
122 2014-05-17  Anders Carlsson  <andersca@apple.com>
123
124         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
125         https://bugs.webkit.org/show_bug.cgi?id=133033
126         <rdar://problem/16830143>
127
128         Reviewed by Sam Weinig.
129
130         Set up the WebSQL and IndexedDB directories.
131
132         * WebKitTestRunner/TestController.cpp:
133         (WTR::TestController::initialize):
134
135 2014-05-16  Martin Hock  <mhock@apple.com>
136
137         MemoryCache::addImageToCache should return the result of add().
138         https://bugs.webkit.org/show_bug.cgi?id=132928
139         <rdar://problem/16651547>
140
141         Reviewed by Alexey Proskuryakov.
142
143         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
145         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
146         (TestWebKitAPI::TEST):
147
148 2014-05-15  David Farler  <dfarler@apple.com>
149
150         old-run-webkit-tests: allow specifying a simulator app path
151         https://bugs.webkit.org/show_bug.cgi?id=132975
152
153         Reviewed by Anders Carlsson.
154
155         * Scripts/old-run-webkit-tests:
156         (openIPhoneSimulator):
157         Add new --simulator-app command line parameter for specifying the
158         absolute path to the simulator app to launch before starting a
159         session.
160
161 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
162
163         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
164         https://bugs.webkit.org/show_bug.cgi?id=131363
165
166         Reviewed by Csaba Osztrogonác.
167
168         * Scripts/webkitpy/common/checkout/checkout_mock.py:
169         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
170         (MockBugzilla):
171         * Scripts/webkitpy/tool/commands/download_unittest.py:
172         (test_create_rollout_multiple_revision_with_one_resolved):
173         (test_create_rollout_multiple_resolved):
174         (test_rollout_two_revisions):
175         (test_rollout_multiple_revisions):
176         (test_rollout_multiple_revisions_with_a_missing_bug_id):
177         * Scripts/webkitpy/tool/steps/createbug.py:
178         (CreateBug.run):
179         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
180         (ReopenBugAfterRollout.run):
181
182 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
183
184         [WK2] Change the remaining framework includes from WebKit2 to WebKit
185         https://bugs.webkit.org/show_bug.cgi?id=132956
186
187         Reviewed by Sam Weinig.
188
189         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
190         * MiniBrowser/mac/AppDelegate.m:
191         * MiniBrowser/mac/WK2BrowserWindowController.m:
192         * TestWebKitAPI/InjectedBundleController.h:
193         * TestWebKitAPI/InjectedBundleMain.cpp:
194         * TestWebKitAPI/JavaScriptTest.cpp:
195         * TestWebKitAPI/PlatformUtilities.h:
196         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
197         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
198         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
199         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
200         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
203         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
204         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
205         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
206         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
207         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
208         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
209         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
210         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
211         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
212         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
213         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
214         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
215         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
216         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
217         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
218         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
219         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
220         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
221         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
222         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
223         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
224         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
225         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
226         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
227         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
228         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
229         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
230         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
231         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
232         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
233         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
234         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
235         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
236         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
237         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
238         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
239         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
240         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
241         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
242         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
243         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
244         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
245         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
246         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
247         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
248         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
249         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
250         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
251         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
252         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
253         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
254         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
255         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
256         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
257         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
258         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
259         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
260         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
261         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
262         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
263         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
264         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
265         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
266         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
267         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
268         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
269         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
270         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
271         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
272         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
273         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
274         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
275         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
276         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
277         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
278         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
279         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
280         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
281         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
282         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
283         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
284         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
285         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
286         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
287         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
288         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
289         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
290         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
291         * TestWebKitAPI/config.h:
292         * TestWebKitAPI/efl/PlatformWebView.cpp:
293         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
294         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
295         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
296         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
297         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
298         * WebKitTestRunner/EventSenderProxy.h:
299         * WebKitTestRunner/GeolocationProviderMock.cpp:
300         * WebKitTestRunner/GeolocationProviderMock.h:
301         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
302         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
303         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
304         * WebKitTestRunner/InjectedBundle/GCController.cpp:
305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
306         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
307         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
308         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
310         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
312         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
313         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
314         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
316         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
317         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
318         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
320         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
321         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
322         * WebKitTestRunner/PlatformWebView.h:
323         * WebKitTestRunner/StringFunctions.h:
324         * WebKitTestRunner/TestController.cpp:
325         * WebKitTestRunner/TestController.h:
326         * WebKitTestRunner/TestInvocation.cpp:
327         * WebKitTestRunner/TestInvocation.h:
328         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
329         * WebKitTestRunner/WebNotificationProvider.cpp:
330         * WebKitTestRunner/WebNotificationProvider.h:
331         * WebKitTestRunner/WorkQueueManager.cpp:
332         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
333         * WebKitTestRunner/cg/TestInvocationCG.cpp:
334         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
335         * WebKitTestRunner/config.h:
336         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
337         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
338         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
339         * WebKitTestRunner/ios/TestControllerIOS.mm:
340         * WebKitTestRunner/mac/EventSenderProxy.mm:
341         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
342         * WebKitTestRunner/mac/TestControllerMac.mm:
343
344 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
345
346         [EFL][WK2] Skip failing unit tests
347         https://bugs.webkit.org/show_bug.cgi?id=132979
348
349         Reviewed by Daniel Bates.
350
351         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
352
353 2014-05-15  David Kilzer  <ddkilzer@apple.com>
354
355         [iOS] Support TestWebKitAPI in the iOS Simulator
356         <http://webkit.org/b/129535>
357         <rdar://problem/16203529>
358
359         Reviewed by Daniel Bates.
360
361         * Scripts/run-api-tests:
362         (runTest):
363         (listAllTests):
364         - Extract common arguments into local variable.
365         - Use xcrun to find the sim tool in order to invoke
366         TestWebKitAPI properly in the iOS Simulator. 
367
368         * Scripts/webkitdirs.pm:
369         (argumentsForConfiguration): Set --device or --sim as
370         appropriate to fix buildTestTool() in run-api-tests.
371
372 2014-05-15  Tim Horton  <timothy_horton@apple.com>
373
374         Fix a logging typo in copy-webkitlibraries-to-product-directory
375
376         Reviewed by Dean Jackson.
377
378         * Scripts/copy-webkitlibraries-to-product-directory:
379
380 2014-05-15  David Kilzer  <ddkilzer@apple.com>
381
382         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
383         <http://webkit.org/b/132959>
384
385         Reviewed by Dan Bernstein.
386
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
388         Cocoa directory to project and move URLExtras.mm into it.
389         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
390
391 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
392
393         [GTK] Compile all installed resources as GResources
394         https://bugs.webkit.org/show_bug.cgi?id=131099
395
396         Reviewed by Philippe Normand.
397
398         * Scripts/webkitpy/port/gtk.py:
399         (GtkPort.setup_environ_for_server): Removed now unneeded
400         AUDIO_RESOURCES_PATH env var.
401
402 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
403
404         Remove CSS_STICKY_POSITION guards
405         https://bugs.webkit.org/show_bug.cgi?id=132676
406
407         Reviewed by Simon Fraser.
408
409         * Scripts/webkitperl/FeatureList.pm:
410
411 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
414         https://bugs.webkit.org/show_bug.cgi?id=132686
415
416         Reviewed by Philippe Normand.
417
418         Bring back InputMethodFilter test to the build and compile it into
419         a single binary TestWebCore with the other WebCore tests. Also
420         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
421
422         * Scripts/run-gtk-tests:
423         (TestRunner): Remove WebCoreGtk from the list of test directories.
424         * TestWebKitAPI/PlatformGTK.cmake:
425         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
426
427 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
428
429         [EFL] Make XVFBDriver optional
430         https://bugs.webkit.org/show_bug.cgi?id=131036
431
432         Reviewed by Gyuyoung Kim.
433
434         * Scripts/webkitpy/port/efl.py:
435         (EflPort._driver_class):
436
437 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
438
439         Flakiness dashboard contains outdated list of bots on builders.jsonp
440         https://bugs.webkit.org/show_bug.cgi?id=132874
441
442         Reviewed by Darin Adler.
443
444         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
445         file by changing to the directory Tools/TestResultServer and executing
446         the script generate_builders_json.py
447
448 2014-05-11  Anders Carlsson  <andersca@apple.com>
449
450         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
451         https://bugs.webkit.org/show_bug.cgi?id=132809
452
453         Reviewed by Dan Bernstein.
454
455         * WebKitTestRunner/TestController.cpp:
456         (WTR::TestController::initialize):
457         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
458
459 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
460
461         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
462         https://bugs.webkit.org/show_bug.cgi?id=132739
463
464         Reviewed Anders Carlsson.
465
466         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
467         the JSC unit tests.
468         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
469
470 2014-05-11  Anders Carlsson  <andersca@apple.com>
471
472         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
473         https://bugs.webkit.org/show_bug.cgi?id=132806
474
475         Reviewed by Beth Dakin.
476
477         Migrate to WKContextConfiguration.
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::initialize):
481
482 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
483
484         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
485         https://bugs.webkit.org/show_bug.cgi?id=132685
486
487         Reviewed by Martin Robinson.
488
489         Use a single TestWebKit2 binary for all WebKit2 C API tests.
490
491         * TestWebKitAPI/PlatformGTK.cmake:
492
493 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
494
495         [iOS] Switch geolocation to an explicit authorization query model
496         https://bugs.webkit.org/show_bug.cgi?id=132717
497
498         Reviewed by Sam Weinig.
499
500         * DumpRenderTree/mac/MockGeolocationProvider.mm:
501         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
502         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
503
504 2014-05-09  David Farler  <dfarler@apple.com>
505
506         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
507         https://bugs.webkit.org/show_bug.cgi?id=132718
508
509         Reviewed by David Kilzer.
510
511         The simulator may not be able to look up runtimes by SDK paths
512         and instead will map SDK versions to runtimes instead. In
513         com.apple.iphonesimulator.startSession notifications,
514         'runtimeIdentifier' (SDK version string) is preferred over
515         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
516         when creating a new DRT or WKTR simulator session.
517
518         IPhoneSimulatorNotification.pm filters out keys for this
519         notification's userInfo with a hard-coded list. There's no harm
520         in including extra key-value pairs in an NSNotification userInfo
521         dictionary anyway and the simulator may again change its
522         userInfo schema for this notification.
523
524         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
525         (postStartSessionNotification):
526         * Scripts/old-run-webkit-tests:
527         (installAndLaunchDumpToolAppUsingNotification):
528
529 2014-05-09  Anders Carlsson  <andersca@apple.com>
530
531         Another build fix.
532
533         * Scripts/build-webkit:
534         WebKit2 should always be built for OS X and iOS.
535
536 2014-05-09  Anders Carlsson  <andersca@apple.com>
537
538         Follow-up build fix.
539
540         * Scripts/build-webkit:
541         WebKit2 should no longer be built before WebKit.
542
543 2014-05-09  Anders Carlsson  <andersca@apple.com>
544
545         Rename WebKit2.framework to WebKit.framework
546         https://bugs.webkit.org/show_bug.cgi?id=132743
547         <rdar://problem/15920046>
548
549         Reviewed by Dan Bernstein.
550
551         * Scripts/check-for-inappropriate-files-in-framework:
552         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
553         Change WebKit2 to WebKit.
554
555         * Scripts/check-for-webkit-framework-include-consistency:
556         Change WebKit to WebKitLegacy.
557
558 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
559
560         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
561         https://bugs.webkit.org/show_bug.cgi?id=132732
562
563         Reviewed by Alexey Proskuryakov.
564
565         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
566
567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
568         (EWS): Remove GTK+ WK1 EWS.
569
570 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
571
572         Add new u-szeged contributors.
573
574         Reviewed by Csaba Osztrogonác.
575
576         * Scripts/webkitpy/common/config/contributors.json:
577
578 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
579
580         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
581         https://bugs.webkit.org/show_bug.cgi?id=132736
582
583         Reviewed by Philippe Normand.
584
585         There are two problems, the path returned by common.library_build_path() is wrong when
586         common.binary_build_path() has previously been called, and the test is still looking for
587         the .la instead of .so
588
589         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
590         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
591         of .la as extension of the injected bundle library.
592         * gtk/common.py:
593         (binary_build_path): Remove unused global variable and add a new
594         one for binary_build_dir instead of sharing the same global
595         variable for library_build_path and binary_build_path.
596
597 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
598
599         [EFL] Enable MEDIA_STREAM for EFL port
600         https://bugs.webkit.org/show_bug.cgi?id=132648
601
602         Reviewed by Gyuyoung Kim.
603
604         Script modified to enable MEDIA_STREAM for EFL build.
605
606         * Scripts/webkitperl/FeatureList.pm: 
607
608 2014-05-08  David Farler  <dfarler@apple.com>
609
610         old-run-webkit-tests: update strings for simulator devices and app name
611         https://bugs.webkit.org/show_bug.cgi?id=132687
612
613         Reviewed by Darin Adler.
614
615         iPhone Retina (4-inch) -> iPhone 5
616         iPhone Retina (4-inch 64-bit) -> iPhone 5s
617
618         * Scripts/old-run-webkit-tests:
619         (installAndLaunchDumpToolAppUsingNotification):
620         (openIPhoneSimulator):
621         (quitIPhoneSimulator):
622         quit iOS Simulator, not iPhone Simulator.
623
624 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
625
626         REGRESSION(r168471): Update the builder names on the scheduler list.
627         https://bugs.webkit.org/show_bug.cgi?id=132699
628
629         Reviewed by Martin Robinson.
630
631         On r168471 I missed to update the builder names for the GTK build
632         bots on the AnyBranchScheduler type scheduler list of bots.
633
634         * BuildSlaveSupport/build.webkit.org-config/config.json:
635
636 2014-05-08  Brady Eidson  <beidson@apple.com>
637
638         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
639         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
640
641         Reviewed by Tim Horton.
642
643         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
644         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
645
646 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
647
648         REGRESSION(r168471): Duplicate builddirs broke the build master.
649         https://bugs.webkit.org/show_bug.cgi?id=132688
650
651         Reviewed by Carlos Garcia Campos.
652
653         Rename the builddirs of the new GTK bots introduced on r168471 to
654         be unique. Otherwise the master will break.
655
656         * BuildSlaveSupport/build.webkit.org-config/config.json:
657
658 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
659
660         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
661         https://bugs.webkit.org/show_bug.cgi?id=132674
662
663         Reviewed by Philippe Normand.
664
665         Only ignore mkdir failure when exception is raised because the
666         file already exists and it's a directory.
667
668         * gtk/webkitdom.py:
669         (write_doc_files):
670
671 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
672
673         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
674         https://bugs.webkit.org/show_bug.cgi?id=131358
675
676         Reviewed by Carlos Garcia Campos.
677
678         Current 64-bit GTK build bots (Release and Debug) not only test
679         the build, but run all tests. Split each one of the bots in
680         BuildOnly and TestWebKit2.
681
682         This will allow us to have a better overview of the status of
683         the GTK port.
684
685         Original patch from Sergio Villar Senin <svillar@igalia.com>
686
687         * BuildSlaveSupport/build.webkit.org-config/config.json:
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
689         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
690         (WebKitBuildbot):
691         * Scripts/webkitpy/port/builders.py:
692         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
693         (TestRebaselineTest.test_baseline_directory):
694         * TestResultServer/static-dashboards/builders.jsonp:
695         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
696         (resetGlobals):
697         * TestResultServer/static-dashboards/loader_unittests.js:
698
699 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
700
701         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
702         https://bugs.webkit.org/show_bug.cgi?id=126022
703
704         Reviewed by Benjamin Poulain.
705
706         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
707
708         Added an unit test case to check if scroll position and scale are restored properly.
709
710         * TestWebKitAPI/PlatformEfl.cmake:
711         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
712         (TestWebKitAPI::didFinishLoadForFrame):
713         (TestWebKitAPI::didChangeContentsPosition):
714         (TestWebKitAPI::TEST):
715         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
716         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
717
718 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
719
720         WebKit1 is flashy when compositing layers come and go
721         https://bugs.webkit.org/show_bug.cgi?id=132655
722         <rdar://problem/16830981&16788846>
723
724         Reviewed by Sam Weinig.
725         
726         Revert the change from r166117.
727
728         * DumpRenderTree/mac/DumpRenderTree.mm:
729         (updateDisplay):
730
731 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
732
733         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
734         https://bugs.webkit.org/show_bug.cgi?id=132622
735
736         Reviewed by Mario Sanchez Prada.
737
738         * DumpRenderTree/AccessibilityUIElement.cpp:
739         (selectTextWithCriteriaCallback):
740         (isEqualCallback):
741         * DumpRenderTree/AccessibilityUIElement.h:
742         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
743         (AccessibilityUIElement::selectTextWithCriteria):
744         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
745         (AccessibilityUIElement::selectTextWithCriteria):
746         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
747         (selectTextParameterizedAttributeForCriteria):
748         (AccessibilityUIElement::selectTextWithCriteria):
749         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
750         (AccessibilityUIElement::selectTextWithCriteria):
751         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
752         (WTR::AccessibilityUIElement::selectTextWithCriteria):
753         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
754         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
755         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
756         (WTR::AccessibilityUIElement::selectTextWithCriteria):
757         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
758         (WTR::AccessibilityUIElement::selectTextWithCriteria):
759         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
760         (WTR::selectTextParameterizedAttributeForCriteria):
761         (WTR::AccessibilityUIElement::selectTextWithCriteria):
762
763 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
764
765         [SOUP] TLSErrors do not cause page load to fail when not ignored
766         https://bugs.webkit.org/show_bug.cgi?id=121548
767
768         Reviewed by Sergio Villar Senin.
769
770         Add unit tests to check that the load fails with TLS errors in
771         case of a redirection.
772
773         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
774         (testTLSErrorsRedirect):
775         (httpsServerCallback):
776         (beforeAll):
777
778 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
779
780         [CSS Grid Layout] Remove runtime feature
781         https://bugs.webkit.org/show_bug.cgi?id=132382
782
783         Reviewed by Benjamin Poulain.
784
785         Remove cssGridLayoutEnabled setting usage.
786
787         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
788         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
789         * DumpRenderTree/efl/TestRunnerEfl.cpp:
790         (TestRunner::overridePreference):
791         * DumpRenderTree/mac/DumpRenderTree.mm:
792         (resetWebPreferencesToConsistentValues):
793
794 2014-05-06  David Kilzer  <ddkilzer@apple.com>
795
796         Add Makefile targets for copying static libraries (LLVM and WKSI)
797         <http://webkit.org/b/132619>
798
799         Reviewed by Mark Rowe.
800
801         * Scripts/copy-webkitlibraries-to-product-directory: Set a
802         sensible default for product directory if not specified on
803         either the command-line or in the environment (by Xcode) by
804         calling productDir() in webkitdirs.pm.
805
806 2014-05-06  Brady Eidson  <beidson@apple.com>
807
808         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
809         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
810
811         Reviewed by Sam Weinig.
812
813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
814
815         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
816         (TestWebKitAPI::itemURLLastComponentIsString):
817         (TestWebKitAPI::didFinishLoadForFrame):
818         (TestWebKitAPI::willGoToBackForwardListItem):
819         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
820         (TestWebKitAPI::setPageLoaderClient):
821         (TestWebKitAPI::TEST):
822         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
823         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
824
825         * WebKitTestRunner/TestController.cpp:
826         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
827
828 2014-05-06  Darin Adler  <darin@apple.com>
829
830         Try to fix iOS build.
831
832         * DumpRenderTree/mac/TestRunnerMac.mm:
833         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
834         Updated since I changed testRunner into a pointer instead of a reference.
835         Updated argument names to avoid conflict with field names.
836         (-[APITestDelegateIPhone run]): Ditto.
837         (-[APITestDelegateIPhone _cleanUp]): Ditto.
838
839 2014-05-06  Commit Queue  <commit-queue@webkit.org>
840
841         Unreviewed, rolling out r168304.
842         https://bugs.webkit.org/show_bug.cgi?id=132607
843
844         Broke the build (Requested by KaL on #webkit).
845
846         Reverted changeset:
847
848         "[GTK][CMake] Unable to do make install"
849         https://bugs.webkit.org/show_bug.cgi?id=130188
850         http://trac.webkit.org/changeset/168304
851
852 2014-05-04  Darin Adler  <darin@apple.com>
853
854         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
855         https://bugs.webkit.org/show_bug.cgi?id=80222
856
857         Reviewed by Alexey Proskuryakov.
858
859         * DumpRenderTree/mac/TestRunnerMac.mm:
860         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
861         do more work here so we don't use RetainPtr local variables.
862         (-[APITestDelegateIPhone dealloc]): Added.
863         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
864         created. Updated for changes to member names and types.
865         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
866         updated for changes to member names and types. Changed to two word spelling.
867         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
868         name of _cleanUp method.
869         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
870         Ditto.
871         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
872
873 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
874
875         Clean up Image Document and tweak the layout and viewport
876         https://bugs.webkit.org/show_bug.cgi?id=132552
877
878         Reviewed by Anders Carlsson.
879
880         * DumpRenderTree/mac/DumpRenderTree.mm:
881         (resetWebPreferencesToConsistentValues):
882         Update the default settings to have something consistent with WebKit2.
883
884 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
885
886         [GTK][CMake] Unable to do make install
887         https://bugs.webkit.org/show_bug.cgi?id=130188
888
889         Reviewed by Carlos Garcia Campos.
890
891         * Scripts/webkitdirs.pm:
892         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
893         will give an early signal that a change has broken the documentation.
894
895 2014-05-05  Pratik Solanki  <psolanki@apple.com>
896
897         Update framework locations in package-root
898         https://bugs.webkit.org/show_bug.cgi?id=132571
899
900         Reviewed by Simon Fraser.
901
902         * Scripts/package-root:
903
904 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
905
906         [EFL][WK2] Refactor favicon database APIs
907         https://bugs.webkit.org/show_bug.cgi?id=132519
908
909         Reviewed by Gyuyoung Kim.
910
911         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
912         (update_view_favicon):
913         (on_icon_changed_cb):
914         (window_free):
915         (on_url_changed):
916         (window_create):
917         (on_view_favicon_changed): Deleted.
918
919 2014-05-02  Mark Rowe  <mrowe@apple.com>
920
921         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
922
923         Reviewed by Dan Bernstein.
924
925         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
926         when determining which LLVM archive to extract.
927
928 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
929
930         Add Jeremy as a committer.
931         https://bugs.webkit.org/show_bug.cgi?id=132492
932
933         Reviewed by Jer Noble.
934
935         Add myself as a committer.
936
937         * Scripts/webkitpy/common/config/contributors.json:
938
939 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
940
941         Add Jeremy as a committer.
942         https://bugs.webkit.org/show_bug.cgi?id=132492
943
944         Reviewed by Jer Noble.
945
946         Add Jeremy Jones to the committers file.
947
948         * Scripts/webkitpy/common/config/contributors.json:
949
950 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
951
952         Hard to figure out how to run a single test with run-api-tests
953         https://bugs.webkit.org/show_bug.cgi?id=116332
954
955         Reviewed by Alexey Proskuryakov.
956
957         * Scripts/run-api-tests: add two examples to the help message.
958
959 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
960
961         Fix several memory leaks found by code inspection
962         https://bugs.webkit.org/show_bug.cgi?id=132472
963
964         Reviewed by Geoffrey Garen.
965         
966         Fix memory leaks.
967
968         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
969         (TestWebKitAPI::TEST):
970         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
971         (WTR::InjectedBundlePage::willSendRequestForFrame):
972         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
973         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
974
975 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
976
977         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
978         https://bugs.webkit.org/show_bug.cgi?id=132446
979
980         Reviewed by Mark Hahnenberg.
981         
982         Test the FTL by default now that it's enabled by default.
983
984         * Scripts/run-javascriptcore-tests:
985
986 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
987
988         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
989         https://bugs.webkit.org/show_bug.cgi?id=132240
990
991         Reviewed by Anders Carlsson.
992
993         Removed ewk_view_setting_tiled_backingstore related code.
994
995         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
996         (DumpRenderTreeChrome::createView):
997         (shouldUseTiledBackingStore): Deleted.
998         * EWebLauncher/main.c:
999         (windowCreate):
1000         (parseUserArguments):
1001
1002 2014-05-01  Anders Carlsson  <andersca@apple.com>
1003
1004         window.testRunner.keepWebHistory() should update the UI process state
1005         https://bugs.webkit.org/show_bug.cgi?id=132440
1006
1007         Reviewed by Dan Bernstein.
1008
1009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1010         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1011         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1012         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1013         (WTR::TestRunner::keepWebHistory):
1014         * WebKitTestRunner/TestInvocation.cpp:
1015         (WTR::TestInvocation::invoke):
1016         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1017
1018 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1019
1020         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1021         <http://webkit.org/b/132432>
1022
1023         Reviewed by Tim Horton.
1024
1025         * Scripts/webkitperl/FeatureList.pm: Remove support for
1026         --plugin-proxy-for-video switch.
1027
1028 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1029
1030         Kernel sysctl interface hw.activecpu don't exists on Linux.
1031         https://bugs.webkit.org/show_bug.cgi?id=132286
1032
1033         Reviewed by Filip Pizlo.
1034
1035         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1036         calling sysctl over hw.activecpu
1037
1038 2014-04-30  Anders Carlsson  <andersca@apple.com>
1039
1040         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1041         https://bugs.webkit.org/show_bug.cgi?id=132399
1042         <rdar://problem/15920046>
1043
1044         Reviewed by Dan Bernstein.
1045
1046         * Scripts/check-for-webkit-framework-include-consistency:
1047         Allos WAK headers in WebKitLegacy as well as WebKit.
1048
1049         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1050         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1051         Update header imports.
1052
1053 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1054
1055         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1056         https://bugs.webkit.org/show_bug.cgi?id=131954
1057
1058         Reviewed by Darin Adler.
1059         
1060         WebKitTestRunner was adding application-specific information to crash reports
1061         to log the test path, but only in the web process. Fix it to also do this
1062         for the UI process, for both iOS and OS X.
1063         
1064         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1065         both iOS and OS X.
1066         
1067         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1068         a new TestController::platformWillRunTest() function on Mac and iOS.
1069         
1070         Also remove Xcode-added unit test junk from the project.
1071
1072         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1073         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1074         * WebKitTestRunner/TestController.cpp:
1075         (WTR::TestController::runTest):
1076         * WebKitTestRunner/TestController.h:
1077         * WebKitTestRunner/TestInvocation.cpp:
1078         (WTR::TestInvocation::url):
1079         * WebKitTestRunner/TestInvocation.h:
1080         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1081         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1082         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1083         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1084         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1085         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1086         (WTR::testPathFromURL):
1087         (WTR::setCrashReportApplicationSpecificInformationToURL):
1088         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1089         (WTR::TestController::platformWillRunTest):
1090         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1091         (WTR::TestController::platformWillRunTest):
1092         * WebKitTestRunner/ios/TestControllerIOS.mm:
1093         (WTR::TestController::platformWillRunTest):
1094         (WTR::TestController::setHidden):
1095         * WebKitTestRunner/mac/TestControllerMac.mm:
1096         (WTR::TestController::platformWillRunTest):
1097
1098 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1099
1100         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1101
1102         Reviewed by Tim Horton.
1103
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         (resetWebPreferencesToConsistentValues):
1106         (prepareConsistentTestingEnvironment):
1107
1108 2014-04-30  Anders Carlsson  <andersca@apple.com>
1109
1110         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1111         https://bugs.webkit.org/show_bug.cgi?id=132397
1112
1113         Reviewed by Dan Bernstein.
1114
1115         * Scripts/check-for-inappropriate-macros-in-external-headers:
1116
1117 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1118
1119         [GTK] Make it easier to run CMake for downstreams
1120         https://bugs.webkit.org/show_bug.cgi?id=132370
1121
1122         Reviewed by Carlos Garcia Campos.
1123
1124         * Scripts/webkitdirs.pm:
1125         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1126         the GTK+ port.
1127
1128 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1129
1130         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1131         
1132         Rubber stamped by Jessie Berlin.
1133
1134         JSON.pm was removed from our tools setup.
1135
1136         * Scripts/generate-coverage-data:
1137
1138 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1139
1140         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1141         https://bugs.webkit.org/show_bug.cgi?id=112840
1142
1143         Rubber stamped by Geoffrey Garen.
1144
1145         * Scripts/build-jsc: Enable it on Mac.
1146         * Scripts/build-webkit: Enable it on Mac.
1147         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1148
1149 2014-04-28  Sam Weinig  <sam@webkit.org>
1150
1151         REGRESSION (r167751): svn-create-patch is very slow
1152         https://bugs.webkit.org/show_bug.cgi?id=132300
1153
1154         Reviewed by Alexey Proskuryakov.
1155
1156         * Scripts/svn-create-patch:
1157         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1158         by calling `svn-create-patch --style`.
1159
1160 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1161
1162         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1163         https://bugs.webkit.org/show_bug.cgi?id=132190
1164
1165         Reviewed by Gustavo Noronha Silva.
1166
1167         * Scripts/webkitdirs.pm:
1168         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1169             if ninja is in the path.
1170         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1171             to the previous ninja generator if not.
1172
1173 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1174
1175         check-webkit-style should understand --git-index
1176         https://bugs.webkit.org/show_bug.cgi?id=125364
1177
1178         Reviewed by Csaba Osztrogonác.
1179
1180         * Scripts/webkitpy/common/checkout/scm/git.py:
1181         (Git.create_patch): The command now supports the --cached option.
1182         * Scripts/webkitpy/style/main.py:
1183         (CheckWebKitStyle.main): Passing the --git-index option.
1184         * Scripts/webkitpy/style/optparser.py:
1185         (CommandOptionValues.__init__): The git-index option is switched off by default.
1186         (CommandOptionValues.__eq__): Equality check for the new option.
1187         (ArgumentParser._create_option_parser):Adding the --git-index option
1188         (ArgumentParser.parse):
1189         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1190         (CommandOptionValuesTest.test_init): 
1191         (CommandOptionValuesTest.test_eq):
1192
1193 2014-04-28  Michael Saboff  <msaboff@apple.com>
1194
1195         Crash in platform/mac/accessibility/table-visible-rows.html
1196         https://bugs.webkit.org/show_bug.cgi?id=132146
1197
1198         Reviewed by Filip Pizlo.
1199
1200         Instead of creating a local JSValueRef array on the stack and passing that to
1201         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1202         values using the JSObjectSetPropertyAtIndex() API.
1203
1204         * DumpRenderTree/AccessibilityUIElement.cpp:
1205         (elementsForRangeCallback):
1206         (convertElementsToObjectArray):
1207         * DumpRenderTree/mac/TestRunnerMac.mm:
1208         (originsArrayToJS):
1209         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1210         (WTR::EventSendingController::contextClick):
1211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1212         (WTR::stringArrayToJS):
1213         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1214         (WTR::convertElementsToObjectArray):
1215
1216 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1217
1218         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1219         "no-cjit" runs force the old-school threshold.
1220
1221         Rubber stamped by Mark Hahnenberg.
1222
1223         * Scripts/run-jsc-stress-tests:
1224
1225 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1226
1227         [GTK] install-dependencies should also install ruby-json and ruby-highline
1228         https://bugs.webkit.org/show_bug.cgi?id=132292
1229
1230         Reviewed by Philippe Normand.
1231
1232         * gtk/install-dependencies: Install ruby json and highline packages.
1233
1234 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1235
1236         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1237         https://bugs.webkit.org/show_bug.cgi?id=132176
1238
1239         Reviewed by Gyuyoung Kim.
1240
1241         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1242         and turn off indexedDB feature until the sqlite implementation is introduced.
1243
1244         * Scripts/webkitperl/FeatureList.pm:
1245
1246 2014-04-25  James Craig  <jcraig@apple.com>
1247
1248         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1249         https://bugs.webkit.org/show_bug.cgi?id=132209
1250
1251         Reviewed by Daniel Bates.
1252
1253         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1254         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1255
1256         * Scripts/prepare-ChangeLog:
1257         (main): 
1258
1259 2014-04-25  Michael Saboff  <msaboff@apple.com>
1260
1261         Crash in platform/mac/accessibility/table-visible-rows.html
1262         https://bugs.webkit.org/show_bug.cgi?id=132146
1263
1264         Reviewed by Mark Lam.
1265
1266         Changed to use a local JSValueRef array temporary instead of a
1267         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1268         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1269         the temporary values could be collected.
1270
1271         * DumpRenderTree/AccessibilityUIElement.cpp:
1272         (convertElementsToObjectArray):
1273         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1274         (WTR::EventSendingController::contextClick):
1275         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1276         (WTR::convertElementsToObjectArray):
1277
1278 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1279
1280         Unreviewed GTK gardening
1281
1282         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1283         (TestRunner):
1284
1285 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1286
1287         prepare-ChangeLog reports as deleted methods that has not been removed.
1288         https://bugs.webkit.org/show_bug.cgi?id=131733
1289
1290         Reviewed by Ryosuke Niwa.
1291
1292         * Scripts/prepare-ChangeLog:
1293         (originalFile): Set merge base to origin/master by default.
1294
1295 2014-04-23  James Craig  <jcraig@apple.com>
1296
1297         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1298         https://bugs.webkit.org/show_bug.cgi?id=131115
1299
1300         Reviewed by Daniel Bates.
1301
1302         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1303
1304         * Scripts/commit-log-editor: Added --no-style.
1305         * Scripts/prepare-ChangeLog: Primary patch.
1306         (main): Primary patch.
1307         (createPatchCommand): Added --no-style.
1308         * Scripts/svn-create-patch: Primary patch.
1309         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1310         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1311         (SVN.create_patch): Added --no-style.
1312
1313 2014-04-23  Anders Carlsson  <andersca@apple.com>
1314
1315         Try to fix iOS build.
1316
1317         * DumpRenderTree/mac/DumpRenderTree.mm:
1318
1319 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
1320
1321         Eliminate internals.setMockScrollbarsEnabled()
1322         https://bugs.webkit.org/show_bug.cgi?id=132085
1323
1324         Reviewed by Tim Horton.
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
1327         No need to reset the preference, there is no way it can change.
1328
1329 2014-04-23  James Craig  <jcraig@apple.com>
1330
1331         Unreviewed. Moving myself from Contributors to Committers list.
1332
1333         * Scripts/webkitpy/common/config/contributors.json:
1334
1335 2014-04-23  Tim Horton  <timothy_horton@apple.com>
1336
1337         Mock scrollbars don't always work in DumpRenderTree
1338         https://bugs.webkit.org/show_bug.cgi?id=132082
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * DumpRenderTree/mac/DumpRenderTree.mm:
1343         (prepareConsistentTestingEnvironment):
1344         Set the mock scrollbar setting before creating the WebView, as this setting
1345         cannot be dynamically changed, so any scrollbars that are created during
1346         WebView initialization and are not replaced before snapshotting will end
1347         up being platform scrollbars instead of mock ones.
1348         WebKitTestRunner already sets this preference before creating WKViews,
1349         so we're just matching its behavior.
1350
1351 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1352
1353         [GTK] ShadowRoot API was removed in r164131
1354         https://bugs.webkit.org/show_bug.cgi?id=132059
1355
1356         Reviewed by Gustavo Noronha Silva.
1357
1358         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1359         the API docs.
1360
1361         * gtk/webkitdom.py:
1362         (WebKitDOMDocGenerator):
1363
1364 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1365
1366         [GTK] run-webkit-tests script is failing to invoke run-launcher
1367         https://bugs.webkit.org/show_bug.cgi?id=132051
1368
1369         Reviewed by Philippe Normand.
1370
1371         After the WK1 support was dropped, if run-webkit-tests is executed
1372         without --no-show-results parameter, the launcher is being called
1373         using a -2 parameter that is it causing the run-launcher to break.
1374
1375         * Scripts/webkitpy/port/gtk.py:
1376         (GtkPort.show_results_html_file):
1377
1378 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1379
1380         DumpRenderTree generates black snapshots on some platforms
1381         https://bugs.webkit.org/show_bug.cgi?id=132029
1382         <rdar://problem/16679363>
1383
1384         Reviewed by Simon Fraser.
1385
1386         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1387         (createBitmapContextFromWebView):
1388         DRT checks with the WebView to determine whether it can use the window's
1389         backing store directly or (because of compositing) needs to take a WindowServer
1390         snapshot. However, on some platforms and in some situations, the window can
1391         be layer backed without the WebView necessarily currently being composited.
1392         We should check with the window in addition to the WebView before going
1393         ahead and using its backing store.
1394
1395 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1396
1397         DumpRenderTree generates white snapshots on some platforms
1398         https://bugs.webkit.org/show_bug.cgi?id=132026
1399         <rdar://problem/16679363>
1400
1401         Reviewed by Simon Fraser.
1402
1403         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1404         Link DRT against QuartzCore.
1405
1406         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1407         (createBitmapContextFromWebView):
1408         Force CoreAnimation to synchronously update layers in a more explicit
1409         way that doesn't depend on AppKit behavior. This is very similar to what
1410         WebKitTestRunner does (indirectly) during its force repaint.
1411
1412 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1413
1414         [Win] Support Python 2.7 in Cygwin
1415         https://bugs.webkit.org/show_bug.cgi?id=132023
1416
1417         Reviewed by Michael Saboff.
1418
1419         * Scripts/webkitdirs.pm:
1420         (checkInstalledTools): Remove check for Python 2.7, since
1421         it now works properly.
1422
1423 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1424
1425         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1426         https://bugs.webkit.org/show_bug.cgi?id=130867
1427         <rdar://problem/16432456> 
1428
1429         Reviewed by Mark Hahnenberg.
1430
1431         * Scripts/build-webkit:
1432         * Scripts/copy-webkitlibraries-to-product-directory:
1433
1434 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1435
1436         [GTK] Fails to build documentation when output is redirected
1437         https://bugs.webkit.org/show_bug.cgi?id=131178
1438
1439         Reviewed by Martin Robinson.
1440
1441         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1442         explicitly to avoid encoding issues when they are redirected.
1443
1444 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1445
1446         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1447         https://bugs.webkit.org/show_bug.cgi?id=131911
1448
1449         Reviewed by Martin Robinson.
1450
1451         common.get_build_path returns release path even though Debug configuration
1452         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1453
1454         * gtk/ycm_extra_conf.py:
1455         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1456         (FlagsForFile):
1457
1458 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1459
1460         Unreviewed build fix.
1461
1462         * DumpRenderTree/mac/EventSendingController.mm:
1463         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1464         Correct a typo that prevented tests from working properly.
1465
1466 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1467
1468         [GTK] Should have the ability to output composited contents during layout testing
1469         https://bugs.webkit.org/show_bug.cgi?id=131864
1470
1471         Reviewed by Philippe Normand.
1472
1473         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1474         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1475         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1476         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1477         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1478
1479 2014-04-21  Sam Weinig  <sam@webkit.org>
1480
1481         Attempt to fix the tests.
1482
1483         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1484         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1485         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1486
1487 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1488
1489         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1490         being the same as a "quick run", which is meant for genuinely slow tests).
1491
1492         * Scripts/run-jsc-stress-tests:
1493
1494 2014-04-21  Darin Adler  <darin@apple.com>
1495
1496         Add HashSet::takeAny
1497         https://bugs.webkit.org/show_bug.cgi?id=131928
1498
1499         Reviewed by Benjamin Poulain.
1500
1501         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1502
1503 2014-04-20  Dan Bernstein  <mitz@apple.com>
1504
1505         Fixed a test timing out after r167572.
1506
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1508         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1509         -webView:didFinishLoadingNavigation:.
1510
1511 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1512
1513         Unreviewed, rolling out r167510.
1514         https://bugs.webkit.org/show_bug.cgi?id=131915
1515
1516         broke GTK Debug bot (Requested by philn on #webkit).
1517
1518         Reverted changeset:
1519
1520         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1521         it when running layout tests"
1522         https://bugs.webkit.org/show_bug.cgi?id=131472
1523         http://trac.webkit.org/changeset/167510
1524
1525 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1526
1527         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1528         https://bugs.webkit.org/show_bug.cgi?id=131472
1529
1530         Reviewed by Philippe Normand.
1531
1532         * Scripts/webkitpy/port/gtk.py:
1533         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1534         when running WebKitTestRunner with run-webkit-tests.
1535         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1536         installed.
1537         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1538         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1539         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1540         deal.
1541
1542 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1543
1544         DownloadDecideDestinationCrash API test uses an incorrect value for path
1545         https://bugs.webkit.org/show_bug.cgi?id=131845
1546         <rdar://problem/15925560>
1547
1548         Reviewed by Enrica Casucci.
1549
1550         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1551         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1552
1553 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1554
1555         [Mac] AttributedStringTest API tests fail with async text input
1556         https://bugs.webkit.org/show_bug.cgi?id=131833
1557
1558         Reviewed by Enrica Casucci.
1559
1560         Don't run sync NSTextInputClient tests where we don't implement these calls.
1561
1562         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1563         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1564         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1565         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1566         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1567         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1568         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1569
1570 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1571
1572         Remove NETWORK_INFO support
1573         https://bugs.webkit.org/show_bug.cgi?id=131841
1574
1575         Reviewed by Gyuyoung Kim.
1576
1577         * Scripts/webkitperl/FeatureList.pm:
1578
1579 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1580
1581         [GTK] YouCompleteMe doesn't work for cmake build system.
1582         https://bugs.webkit.org/show_bug.cgi?id=131591
1583
1584         Reviewed by Martin Robinson.
1585
1586         Add cmake build system support for YouCompleteMe. It should work regardless of
1587         using make or ninja. In addition, autotools related code is removed since it's
1588         not used anymore in WebKit.
1589
1590         * Scripts/webkitdirs.pm:
1591         (generateBuildSystemFromCMakeProject):
1592         * gtk/ycm_extra_conf.py:
1593         (transform_relative_paths_to_absolute_paths):
1594         (FlagsForFile):
1595
1596 2014-04-17  Anders Carlsson  <andersca@apple.com>
1597
1598         Fix build.
1599
1600         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1601         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1602         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1603
1604 2014-04-17  Anders Carlsson  <andersca@apple.com>
1605
1606         Remove unused API enums
1607         https://bugs.webkit.org/show_bug.cgi?id=131836
1608
1609         Reviewed by Tim Horton.
1610
1611         * MiniBrowser/mac/WK2BrowserWindowController.m:
1612         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1613
1614 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1615
1616         [Win] A few final cleanups to the DataObject classes.
1617         https://bugs.webkit.org/show_bug.cgi?id=131784
1618
1619         Reviewed by Anders Carlsson.
1620
1621         * DumpRenderTree/win/DRTDataObject.cpp:
1622         (DRTDataObject::clearData): Use 'last()' method.
1623         * DumpRenderTree/win/UIDelegate.cpp:
1624         (DRTUndoStack::pop): Use 'takeLast()' method.
1625
1626 2014-04-17  Andres Gomez  <agomez@igalia.com>
1627
1628         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1629         https://bugs.webkit.org/show_bug.cgi?id=131365
1630
1631         Reviewed by Brent Fulgham.
1632
1633         The cygwin installer is now downloading the wanted versions for
1634         the local installation given to the setup wizard.
1635
1636         * CygwinDownloader/cygwin-downloader.py:
1637         * CygwinDownloader/cygwin-downloader.zip:
1638
1639 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1640
1641         [GTK] Make run-webkit-tests always use WKTR
1642         https://bugs.webkit.org/show_bug.cgi?id=131737
1643
1644         Reviewed by Darin Adler.
1645
1646         Now that the GTK+ port only has support for WebKit2, instruct
1647         run-webkit-tests to always use WKTR. This avoids needing to pass
1648         flag "-2" every time.
1649
1650         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1651         (_set_up_derived_options): Always set webkit_test_runner when
1652         the platform is GTK+.
1653
1654 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1655
1656         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1657         https://bugs.webkit.org/show_bug.cgi?id=131760
1658
1659         Reviewed by Philippe Normand.
1660
1661         * gtk/install-dependencies: Install ninja-build when it's available.
1662
1663 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1664
1665         [Win] run-javascriptcore-tests fails to run.
1666         https://bugs.webkit.org/show_bug.cgi?id=131761
1667
1668         Reviewed by Brent Fulgham.
1669
1670         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1671
1672 2014-04-16  Andres Gomez  <agomez@igalia.com>
1673
1674         [Win] Pass default parameters to cygwin setup wizard
1675         https://bugs.webkit.org/show_bug.cgi?id=131361
1676
1677         Reviewed by Brent Fulgham.
1678
1679         Added some parameters to the cygwin setup wizard so the user
1680         doesn't really have to do any interaction.
1681
1682         * CygwinDownloader/cygwin-downloader.py:
1683         * CygwinDownloader/cygwin-downloader.zip:
1684
1685 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1686
1687         [Win] Eliminate use of deleteAllValues in Windows Files
1688         https://bugs.webkit.org/show_bug.cgi?id=131631
1689
1690         Reviewed by Darin Adler.
1691
1692         Switch to std::unique_ptr for memory lifetime. Get rid of
1693         deleteAllValues now that it is no longer needed. Use ranged
1694         for loops where possible.
1695
1696         * DumpRenderTree/win/DRTDataObject.cpp:
1697         (WCEnumFormatEtc::WCEnumFormatEtc):
1698         (DRTDataObject::~DRTDataObject):
1699         (DRTDataObject::GetData):
1700         (DRTDataObject::QueryGetData):
1701         (DRTDataObject::SetData):
1702         (DRTDataObject::clearData):
1703         * DumpRenderTree/win/DRTDataObject.h:
1704         * DumpRenderTree/win/UIDelegate.cpp:
1705         (DRTUndoObject::DRTUndoObject):
1706         (DRTUndoObject::~DRTUndoObject):
1707         (DRTUndoStack::~DRTUndoStack):
1708         (DRTUndoStack::clear):
1709         (DRTUndoStack::pop):
1710         (DRTUndoManager::DRTUndoManager):
1711         (DRTUndoManager::redo):
1712         (DRTUndoManager::undo):
1713         (UIDelegate::UIDelegate):
1714         (UIDelegate::resetUndoManager):
1715         * DumpRenderTree/win/UIDelegate.h:
1716
1717 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1718
1719         [GTK] Unreviewed GTK gardening.
1720
1721         Update list of skipped unit tests:
1722
1723           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1724
1725           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1726           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1727
1728         * Scripts/run-gtk-tests:
1729         (TestRunner):
1730
1731 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1732
1733         check-webkit-style doesn't check code style in .mm or .m files
1734         https://bugs.webkit.org/show_bug.cgi?id=131708
1735
1736         Reviewed by Darin Adler.
1737
1738         * Scripts/webkitpy/style/checker.py:
1739         * Scripts/webkitpy/style/checker_unittest.py:
1740         (CheckerDispatcherDispatchTest.test_cpp_paths):
1741         (CheckerDispatcherDispatchTest.test_text_paths):
1742         Check .mm and .m files as C++.
1743
1744         * Scripts/webkitpy/style/checkers/cpp.py:
1745         (check_spacing):
1746         Add an override for our ordinary "missing spaces around =" for @synthesize,
1747         which should look like "@synthesize propertyName=_varName;"
1748
1749         Add an override for "missing space before {" for blocks' "^{".
1750
1751         Don't follow the "extra space before [" rule for Objective-C, because
1752         it breaks this rule in a multitude of ways because of method calls.
1753
1754         (check_braces):
1755         Don't complain about { not being on the end of the previous line if
1756         the previous line starts with "- (" or "+ (", which would indicate a
1757         Objective-C method definition.
1758
1759 2014-04-16  Darin Adler  <darin@apple.com>
1760
1761         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1762         https://bugs.webkit.org/show_bug.cgi?id=131735
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1767         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1768         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1769         way, but gtest works better this way.
1770
1771 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1772
1773         [EFL] Fix problems with the pixel dump.
1774         https://bugs.webkit.org/show_bug.cgi?id=131265
1775
1776         Reviewed by Gyuyoung Kim.
1777
1778         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1779         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1780         which causes that nothing is drawn.
1781
1782         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1783         One of new functions is AcceleratedCompositingContext::extractImageData(),
1784         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1785         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1786
1787         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1788         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1789
1790 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1791
1792         Update LLVM export scrpt to handle the build directory being different from the
1793         source directory.
1794
1795         Rubber stamped by Geoffrey Garen.
1796
1797         * Scripts/export-llvm-build:
1798
1799 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1800
1801         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1802         https://bugs.webkit.org/show_bug.cgi?id=131695
1803
1804         Reviewed by Antti Koivisto.
1805
1806         Updated.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1809
1810 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1811
1812         [GTK] Reduce the binary size by compressing the text based web inspector resources
1813         https://bugs.webkit.org/show_bug.cgi?id=121545
1814
1815         Reviewed by Gustavo Noronha Silva.
1816
1817         Compress text based files when compiling inspector resources. It
1818         reduces the binary size in 3MB.
1819
1820         * gtk/generate-inspector-gresource-manifest.py:
1821         (find_all_files_in_directory):
1822         (is_compressible):
1823
1824 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1825
1826         Remove Gtk WebKit1 tester.
1827
1828         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1829         results over and over as fast as it could.
1830
1831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1832         (WebKitBuildbot):
1833
1834 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1835
1836         Wrong link for webkitpy tests results in dashboard popover
1837         https://bugs.webkit.org/show_bug.cgi?id=131664
1838
1839         Reviewed by Timothy Hatcher.
1840
1841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1842         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1843         Use a correct link.
1844
1845 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1846
1847         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1848
1849         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1850
1851         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1852         (CommitMessageForThisCommitTest):
1853
1854 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1855
1856         Fix commit-log-editor bug revealed by r165447
1857         https://bugs.webkit.org/show_bug.cgi?id=130676
1858
1859         Reviewed by Csaba Osztrogonác.
1860
1861         * Scripts/commit-log-editor:
1862         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1863         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1864         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1865         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1866
1867 2014-04-13  Darin Adler  <darin@apple.com>
1868
1869         userVisibleString should not try to "encode" host names
1870         https://bugs.webkit.org/show_bug.cgi?id=131587
1871         rdar://problem/14686849
1872
1873         Reviewed by Alexey Proskuryakov.
1874
1875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1876
1877         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1878         Coverage is tiny at this point; we could add a lot more cases!
1879
1880 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1881
1882         Use #include instead of #import
1883         https://bugs.webkit.org/show_bug.cgi?id=131604
1884
1885         Reviewed by Darin Adler.
1886
1887         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1888
1889         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1890
1891 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1892
1893         Make slow-stress tests run faster by running fewer VM variants.
1894
1895         Rubber stamped by Geoffrey Garen.
1896
1897         * Scripts/run-javascriptcore-tests:
1898         * Scripts/run-jsc-stress-tests:
1899
1900 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1901
1902         [CMake] Add missing WTF unit tests
1903         https://bugs.webkit.org/show_bug.cgi?id=131459
1904
1905         Reviewed by Martin Robinson.
1906
1907         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1908         that should be compiled into the TestWTF binary.
1909
1910 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1911
1912         [Gtk] run-launcher doesn't work by default
1913         https://bugs.webkit.org/show_bug.cgi?id=131494
1914
1915         Reviewed by Philippe Normand.
1916
1917         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1918         * Scripts/webkitdirs.pm:
1919         (launcherName): Same.
1920         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1921         * gtk/common.py:
1922         (get_build_path.is_valid_build_directory): Same.
1923         * gtk/manifest.txt: Same.
1924
1925 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1926
1927         Unreviewed, rolling out r167046.
1928         https://bugs.webkit.org/show_bug.cgi?id=131479
1929
1930         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1931         on #webkit).
1932
1933         Reverted changeset:
1934
1935         "Remove "System Font" from whitelisted DRT fonts and char
1936         width calculations"
1937         https://bugs.webkit.org/show_bug.cgi?id=131411
1938         http://trac.webkit.org/changeset/167046
1939
1940 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1941
1942         Remove "System Font" from whitelisted DRT fonts and char width calculations
1943         https://bugs.webkit.org/show_bug.cgi?id=131411
1944
1945         Reviewed by Tim Horton.
1946
1947         Covered by existing tests.
1948
1949         * DumpRenderTree/mac/DumpRenderTree.mm:
1950         (allowedFontFamilySet):
1951
1952 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1953
1954         systemHiddenFontFamilySet in DRT is unnecessary
1955         https://bugs.webkit.org/show_bug.cgi?id=131414
1956
1957         Reviewed by Tim Horton.
1958
1959         It doesn't seem to affect test results on my machine.
1960
1961         * DumpRenderTree/mac/DumpRenderTree.mm:
1962         (drt_NSFontManager_availableFonts):
1963         (systemHiddenFontFamilySet): Deleted.
1964
1965 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1966
1967         [Win] Unreviewed test fix: Don't double-release BSTR.
1968
1969         * DumpRenderTree/win/DumpRenderTree.cpp:
1970         (dump): Remove unneeded call to SysFreeString now that we are
1971         using _bstr_t for this variable.
1972
1973 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1974
1975         [Win] Various DumpRenderTree Fixes.
1976         https://bugs.webkit.org/show_bug.cgi?id=131446.
1977
1978         Reviewed by Tim Horton.
1979
1980         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1981         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1982         (AccessibilityUIElement::description): Ditto.
1983         (AccessibilityUIElement::helpText): Ditto.
1984         (AccessibilityUIElement::intValue): Ditto.
1985         (AccessibilityUIElement::isPressActionSupported): Ditto.
1986         (AccessibilityUIElement::accessibilityValue): Ditto.
1987         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1988         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1989         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1990         (DRTDesktopNotificationPresenter::Release): Ditto.
1991         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1992         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1993         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1994         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1995         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1996         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1997         * DumpRenderTree/win/DumpRenderTree.cpp:
1998         (dumpFrameScrollPosition): Ditto.
1999         (dumpFramesAsText): Ditto.
2000         (compareHistoryItems): Ditto.
2001         (dumpHistoryItem): Ditto.
2002         (dump): Ditto.
2003         (resetDefaultsToConsistentValues): Ditto.
2004         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2005         (runTest): Ditto.
2006         (createWebViewAndOffscreenWindow): Ditto.
2007         * DumpRenderTree/win/EditingDelegate.cpp:
2008         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2009         (EditingDelegate::AddRef): Ditto.
2010         (EditingDelegate::Release): Ditto.
2011         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2012         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2013         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2014         (EditingDelegate::shouldInsertNode): Ditto.
2015         (EditingDelegate::shouldInsertText): Ditto.
2016         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2017         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2018         (EditingDelegate::shouldApplyStyle): Ditto.
2019         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2020         (EditingDelegate::doPlatformCommand): Ditto.
2021         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2022         (EditingDelegate::webViewDidChange): Ditto.
2023         (EditingDelegate::webViewDidEndEditing): Ditto.
2024         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2025         (EditingDelegate::webViewDidChangeSelection): Ditto.
2026         (EditingDelegate::checkSpellingOfString): Ditto.
2027         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2028         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2029         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2030         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2031         (FrameLoadDelegate::AddRef): Ditto.
2032         (FrameLoadDelegate::Release): Ditto.
2033         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2034         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2035         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2036         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2037         (FrameLoadDelegate::didReceiveTitle): Ditto.
2038         (FrameLoadDelegate::didChangeIcons): Ditto.
2039         (delegatesWithDelayedWork): Ditto.
2040         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2041         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2042         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2043         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2044         (FrameLoadDelegate::willCloseFrame): Ditto.
2045         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2046         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2047         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2048         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2049         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2050         * DumpRenderTree/win/FrameLoadDelegate.h:
2051         * DumpRenderTree/win/HistoryDelegate.cpp:
2052         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2053         (HistoryDelegate::updateHistoryTitle): Ditto.
2054         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2055         * DumpRenderTree/win/PolicyDelegate.cpp:
2056         (dumpPath):
2057         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2058         (PolicyDelegate::AddRef): Ditto.
2059         (PolicyDelegate::Release): Ditto.
2060         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2061         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2062         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2063         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2064         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2065         (ResourceLoadDelegate::AddRef): Ditto.
2066         (ResourceLoadDelegate::Release): Ditto.
2067         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2068         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2069         (ResourceLoadDelegate::willSendRequest): Ditto.
2070         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2071         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2072         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2073         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2074         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2075         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2076         (TestRunner::setUserStyleSheetLocation): Ditto.
2077         (TestRunner::execCommand): Ditto.
2078         (TestRunner::overridePreference): Ditto.
2079         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2080         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2081         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2082         (TextInputController::insertText): Ditto.
2083         * DumpRenderTree/win/UIDelegate.cpp:
2084         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2085         (UIDelegate::AddRef): Ditto.
2086         (UIDelegate::Release): Ditto.
2087         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2088         (UIDelegate::trackCustomPopupMenu): Ditto.
2089         (UIDelegate::registerUndoWithTarget): Ditto.
2090         (UIDelegate::removeAllActionsWithTarget): Ditto.
2091         (UIDelegate::setActionTitle): Ditto.
2092         (UIDelegate::undo): Ditto.
2093         (UIDelegate::redo): Ditto.
2094         (UIDelegate::canUndo): Ditto.
2095         (UIDelegate::canRedo): Ditto.
2096         (UIDelegate::printFrame): Ditto.
2097         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2098         (UIDelegate::webViewHeaderHeight): Ditto.
2099         (UIDelegate::webViewFooterHeight): Ditto.
2100         (UIDelegate::drawHeaderInRect): Ditto.
2101         (UIDelegate::drawFooterInRect): Ditto.
2102         (UIDelegate::webViewPrintingMarginRect): Ditto.
2103         (UIDelegate::canRunModal): Ditto.
2104         (UIDelegate::createModalDialog): Ditto.
2105         (UIDelegate::runModal): Ditto.
2106         (UIDelegate::isMenuBarVisible): Ditto.
2107         (UIDelegate::setMenuBarVisible): Ditto.
2108         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2109         (UIDelegate::paintCustomScrollbar): Ditto.
2110         (UIDelegate::paintCustomScrollCorner): Ditto.
2111         (UIDelegate::setFrame): Ditto.
2112         (UIDelegate::webViewFrame): Ditto.
2113         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2114         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2115         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2116         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2117         (UIDelegate::webViewAddMessageToConsole): Ditto.
2118         (UIDelegate::doDragDrop): Ditto.
2119         (UIDelegate::webViewGetDlgCode): Ditto.
2120         (UIDelegate::createWebViewWithRequest): Ditto.
2121         (UIDelegate::webViewClose): Ditto.
2122         (UIDelegate::webViewFocus): Ditto.
2123         (UIDelegate::webViewUnfocus): Ditto.
2124         (UIDelegate::webViewPainted): Ditto.
2125         (UIDelegate::exceededDatabaseQuota): Ditto.
2126         (UIDelegate::embeddedViewWithArguments): Ditto.
2127         (UIDelegate::webViewClosing): Ditto.
2128         (UIDelegate::webViewSetCursor): Ditto.
2129         (UIDelegate::webViewDidInvalidate): Ditto.
2130         (UIDelegate::setStatusText): Ditto.
2131         (UIDelegate::desktopNotificationsDelegate): Ditto.
2132         (UIDelegate::drawBackground): Ditto.
2133         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2134         (UIDelegate::didPressMissingPluginButton): Ditto.
2135         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2136         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2137         (LoadHTMLStringItem::invoke): Ditto.
2138         (ScriptItem::invoke): Ditto.
2139
2140 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2141
2142         Stylechecker: False positive on inline asm code.
2143         https://bugs.webkit.org/show_bug.cgi?id=130570
2144
2145         Reviewed by Csaba Osztrogonác.
2146
2147         Disable stylechecking in asm blocks.
2148
2149         * Scripts/webkitpy/style/checkers/cpp.py:
2150         (process_line):
2151         (_InlineASMState):
2152         (_InlineASMState.__init__):
2153         (_InlineASMState.process_line):
2154         (_InlineASMState.isInside):
2155         (_process_lines):
2156         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2157         (WebKitStyleTest.test_member_initialization_list):
2158
2159 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2160
2161         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2162         https://bugs.webkit.org/show_bug.cgi?id=131029
2163
2164         Reviewed by Philippe Normand.
2165
2166         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2167         tests and remove the getWebKit1TestResoucesDir() method.
2168
2169         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2170         (testDownloadLocalFile): Use Test::getResourcesDir().
2171         (testDownloadLocalFileError): Ditto.
2172         (serverCallback): Ditto.
2173         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2174         (serverCallback): Ditto.
2175         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2176         (httpServerCallback): Ditto.
2177         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2178         (serverCallback): Ditto.
2179         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2180         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2181         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2182         (Test::getWebKit1TestResoucesDir): Deleted.
2183
2184 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2185
2186         [WK2] HTTP authentication regression tests fail
2187         https://bugs.webkit.org/show_bug.cgi?id=81627
2188         <rdar://problem/11079296>
2189
2190         Reviewed by Anders Carlsson.
2191
2192         * WebKitTestRunner/TestController.h:
2193         * WebKitTestRunner/TestController.cpp:
2194         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2195         to pageLoaderClient structure.
2196         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2197         for password based authentication (we do get server trust challenges on some tests,
2198         which WKTR can't handle).
2199         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2200         calls won't be made, at least on CFNetwork based platforms.
2201         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2202         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2203         make sense to associate auth requests with individual resources - there can be
2204         multiple resources loading at once from the same protection space, so WebKit1 API
2205         that had a resource identifier was inherently racy.
2206
2207 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2208
2209         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2210         https://bugs.webkit.org/show_bug.cgi?id=131427
2211
2212         Reviewed by Gyuyoung Kim.
2213
2214         Since r166973, font path was changed.
2215
2216         * DumpRenderTree/PlatformEfl.cmake:
2217         * WebKitTestRunner/PlatformEfl.cmake:
2218
2219 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2220
2221         Fix the build-jsc build
2222         https://bugs.webkit.org/show_bug.cgi?id=131410
2223
2224         Reviewed by Michael Saboff.
2225
2226         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2227         WTF depends on it.
2228
2229 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2230
2231         [GTK] Remove WebKit1 unit tests
2232         https://bugs.webkit.org/show_bug.cgi?id=131359
2233
2234         Reviewed by Anders Carlsson.
2235
2236         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2237         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2238         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2239
2240         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2241         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2242         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2243         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2244         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2245         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2246         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2247         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2248         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2249         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2250         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2251         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2252         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2253         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2254         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2255         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2256         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2257         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2258         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2259         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2260         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2261         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2262         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2263         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2264         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2265         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2266         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2267         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2268         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2269         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2270         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2271         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2272         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2273         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2274         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2275         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2276         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2277         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2278
2279 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2280
2281         Unreviewed gardening (Take 2): Prevent users from attempting
2282         to build with known invalid cURL. 
2283
2284         * Scripts/webkitdirs.pm:
2285         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2286         7.33.0 (the known good version).
2287
2288 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2289
2290         [GTK] Remove DumpRenderTree and GtkLauncher
2291         https://bugs.webkit.org/show_bug.cgi?id=131373
2292
2293         Reviewed by Andreas Kling.
2294
2295         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2296         no longer necessary now that WebKit1 GTK+ will be removed.
2297
2298         * CMakeLists.txt:
2299         * DumpRenderTree/PlatformGTK.cmake: Removed.
2300         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2301         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2302         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2303         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2304         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2305         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2306         * DumpRenderTree/gtk/EventSender.h: Removed.
2307         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2308         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2309         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2310         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2311         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2312         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2313         * DumpRenderTree/gtk/TextInputController.h: Removed.
2314         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2315         * GtkLauncher/CMakeLists.txt: Removed.
2316         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2317         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2318         * GtkLauncher/main.c: Removed.
2319         * GtkLauncher/simple.svg: Removed.
2320         * GtkLauncher/text.html: Removed.
2321         * WebKitTestRunner/PlatformGTK.cmake:
2322         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
2323         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
2324         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
2325
2326 2014-04-08  Mark Rowe  <mrowe@apple.com>
2327
2328         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
2329         <https://webkit.org/b/131388> / <rdar://problem/16291687>
2330
2331         Reviewed by Alexey Proskuryakov.
2332
2333         * Scripts/webkitdirs.pm:
2334         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
2335         (execMacWebKitAppForDebugging): Ditto.
2336
2337 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2338
2339         Build bmalloc on iOS too
2340         https://bugs.webkit.org/show_bug.cgi?id=131381
2341
2342         Reviewed by Andreas Kling.
2343
2344         * Scripts/build-webkit:
2345
2346 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2347
2348         Unreviewed gardening: Prevent users from attempting
2349         to build with known invalid cURL.
2350
2351         * Scripts/webkitdirs.pm:
2352         (checkInstalledTools): Block build attempts with bad
2353         Cygwin tool set.
2354
2355 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2356
2357         Build bmalloc on Mac
2358         https://bugs.webkit.org/show_bug.cgi?id=131333
2359
2360         Reviewed by Mark Rowe.
2361
2362         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2363         (Note: Just testing Mac is not good enough because in this
2364         script 'Mac' means 'Mac or iOS'.)
2365
2366 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2367
2368         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2369         https://bugs.webkit.org/show_bug.cgi?id=130951
2370
2371         Reviewed by Geoffrey Garen.
2372
2373         * Scripts/run-javascriptcore-tests:
2374
2375 2014-04-06  Darin Adler  <darin@apple.com>
2376
2377         Rework CSS calc logic, fixing some reference count mistakes in Length
2378         https://bugs.webkit.org/show_bug.cgi?id=131280
2379
2380         Reviewed by Andreas Kling.
2381
2382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2383         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2384
2385 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2386
2387         Enable WEB_REPLAY for PLATFORM(MAC)
2388         https://bugs.webkit.org/show_bug.cgi?id=130700
2389
2390         Reviewed by Timothy Hatcher.
2391
2392         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2393
2394 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2395
2396         [CMake] Include X11's include dirs in TestNetscapePlugin
2397         https://bugs.webkit.org/show_bug.cgi?id=131270
2398
2399         Reviewed by Martin Robinson.
2400
2401         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2402         TestNetscapePlugin includes WebCore code that includes X headers.
2403
2404 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2405
2406         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2407         <http://webkit.org/b/130986>
2408
2409         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2410         prefix to TileCache class names in exception list.
2411
2412 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2413
2414         [GTK] kill-old-processes should kill dbus-daemon processes
2415         https://bugs.webkit.org/show_bug.cgi?id=127352
2416
2417         Reviewed by Martin Robinson.
2418
2419         * BuildSlaveSupport/kill-old-processes:
2420         (main):
2421
2422 2014-04-04  Andres Gomez  <agomez@igalia.com>
2423
2424         [Win] Update obsolete packages in cygwin
2425         https://bugs.webkit.org/show_bug.cgi?id=126264
2426
2427         Reviewed by Brent Fulgham.
2428
2429         Removed "apache" and "minires" as the first has been replaced by
2430         "lighttpd" and the second is now integrated into
2431         "cygwin". Replaced the transitional and now obsolete "gcc" package
2432         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2433         since the newer version available is "2.7.3" which breaks the
2434         build due to some funniness with environment variable handling.
2435
2436         * CygwinDownloader/cygwin-downloader.py:
2437         * CygwinDownloader/cygwin-downloader.zip:
2438
2439 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2440
2441         check-webkit-style: Improve warnings on Objective-C @property syntax
2442         https://bugs.webkit.org/show_bug.cgi?id=131200
2443
2444         Reviewed by Dan Bernstein.
2445
2446         * Scripts/webkitpy/style/checkers/cpp.py:
2447         (check_spacing):
2448         (CppChecker):
2449         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2450         (CppStyleTest.test_spacing_in_objective_c_properties):
2451
2452 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2453
2454         Unreviewed. Moving my name to commiter section
2455
2456         * Scripts/webkitpy/common/config/contributors.json:
2457
2458 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2459
2460         Unreviewed. Add myself as a committer.
2461
2462         * Scripts/webkitpy/common/config/contributors.json:
2463
2464 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2465
2466         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2467         https://bugs.webkit.org/show_bug.cgi?id=130391
2468
2469         Reviewed by Gyuyoung Kim.
2470
2471         Change the implementation of the zoom functionality from ewk_view_scale_set
2472         to ewk_view_page_zoom_set.
2473
2474         * MiniBrowser/efl/main.c:
2475
2476 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2477
2478         [webkitpy] perf profiler does not understand --call-graph argument
2479         https://bugs.webkit.org/show_bug.cgi?id=131132
2480
2481         Reviewed by Ryosuke Niwa.
2482
2483         New versions of perf profiler have changed the argument from --call-graph to -g.
2484
2485         * Scripts/webkitpy/common/system/profiler.py:
2486         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2487         * Scripts/webkitpy/port/driver_unittest.py:
2488         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2489
2490 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2491
2492         Add EFL WK2 performance bot to build.webkit.org
2493         https://bugs.webkit.org/show_bug.cgi?id=131034
2494
2495         Fix after r166707, use "Perf" instead of "perf" for consistency.
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/config.json:
2500
2501 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2502
2503         Add EFL WK2 performance bot to build.webkit.org
2504         https://bugs.webkit.org/show_bug.cgi?id=131034
2505
2506         Reviewed by Csaba Osztrogonác.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/config.json:
2509
2510 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2511
2512         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2513         https://bugs.webkit.org/show_bug.cgi?id=131151
2514
2515         Reviewed by Gyuyoung Kim.
2516
2517         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2518         (TouchEventInfo::TouchEventInfo):
2519         (sendTouchEvent):
2520         (addTouchPointCallback):
2521         (updateTouchPointCallback):
2522         (cancelTouchPointCallback):
2523         (releaseTouchPointCallback):
2524
2525 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2526
2527         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2528         <http://webkit.org/b/131045>
2529
2530         Reviewed by Daniel Bates.
2531
2532         * Scripts/filter-build-webkit:
2533         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2534         of clang, plus debug data for all DVTAssertions.
2535
2536 2014-04-01  Dean Jackson  <dino@apple.com>
2537
2538         Load Media Controls js/css from bundle
2539         https://bugs.webkit.org/show_bug.cgi?id=131086
2540
2541         Reviewed by Eric Carlson.
2542
2543         We're now putting CSS files into the bundle, so remove the test for them.
2544
2545         * Scripts/check-for-inappropriate-files-in-framework:
2546
2547 2014-04-02  Martin Hock  <mhock@apple.com>
2548
2549         Unify private browsing with sessions.
2550         https://bugs.webkit.org/show_bug.cgi?id=130099
2551
2552         Reviewed by Alexey Proskuryakov.
2553
2554         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2557         (TestWebKitAPI::didNavigateWithNavigationData):
2558         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2559         (TestWebKitAPI::TEST):
2560
2561         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2562         (TestWebKitAPI::didNavigateWithoutNavigationData):
2563         (TestWebKitAPI::didNavigateWithNavigationData):
2564         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2565         (TestWebKitAPI::TEST):
2566
2567 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2568
2569         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2570         https://bugs.webkit.org/show_bug.cgi?id=130343
2571
2572         Reviewed by Gustavo Noronha Silva.
2573
2574         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2575         of directories on the command line and look for all appropriate files in those directories for the
2576         GResource archive. Also make archive paths relative to those directories.
2577         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2578         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2579
2580 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2581
2582         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2583         https://bugs.webkit.org/show_bug.cgi?id=131106
2584
2585         Reviewed by Csaba Osztrogonác.
2586
2587         * Scripts/webkitpy/tool/commands/download.py:
2588         (AbstractRolloutPrepCommand._prepare_state):
2589         * Scripts/webkitpy/tool/commands/download_unittest.py:
2590         (test_prepare_rollout):
2591         (test_create_rollout):
2592         (test_create_rollout_resolved):
2593         (test_rollout):
2594
2595 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2596
2597         [EFL] Add option to use separate web process for new window in MiniBrowser
2598         https://bugs.webkit.org/show_bug.cgi?id=130190
2599
2600         Reviewed by Gyuyoung Kim.
2601
2602         New created window (CTRL + n) will be open in separated web process.
2603         This option is enabled by adding a flag (S/separate-process) with launching
2604         MiniBrowser.
2605
2606         * MiniBrowser/efl/main.c:
2607         (elm_main):
2608
2609 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2610
2611         [GTK] Move NEWS file to a new location
2612         https://bugs.webkit.org/show_bug.cgi?id=130901
2613
2614         Reviewed by Brent Fulgham.
2615
2616         * gtk/manifest.txt: Update the NEWS file path.
2617
2618 2014-04-01  Anders Carlsson  <andersca@apple.com>
2619
2620         Fix build.
2621
2622         * MiniBrowser/mac/WK2BrowserWindowController.m:
2623         (-[WK2BrowserWindowController awakeFromNib]):
2624         (-[WK2BrowserWindowController dealloc]):
2625         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2626
2627 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2628
2629         Unreviewed test gardening.
2630
2631         * Scripts/webkitpy/port/base_unittest.py:
2632         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2633
2634 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2635
2636         [CSS Exclusions] Remove exclusions parsing support
2637         https://bugs.webkit.org/show_bug.cgi?id=131046
2638
2639         Reviewed by David Hyatt.
2640
2641         * Scripts/webkitperl/FeatureList.pm:
2642
2643 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2644
2645         [GTK] Remove last reference to GTK+ WK1 EWS
2646         https://bugs.webkit.org/show_bug.cgi?id=131058
2647
2648         Reviewed by Martin Robinson.
2649
2650         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2651
2652         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2653
2654 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2655
2656         Add a 32bit JSC builder/tester.
2657         https://bugs.webkit.org/show_bug.cgi?id=131054
2658         
2659         Reviewed by Michael Saboff.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/config.json:
2662         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2663         (Compile32bitJSC):
2664         (Run32bitJSCTests):
2665         (Run32bitJSCTests.countFailures):
2666         (BuildAndTest32bitJSCFactory):
2667         (BuildAndTest32bitJSCFactory.__init__):
2668
2669 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2670
2671         [GTK] No longer build WebKit1 gtkdoc
2672         https://bugs.webkit.org/show_bug.cgi?id=130970
2673
2674         Reviewed by Anders Carlsson.
2675
2676         * gtk/common.py:
2677         (gtk_version_of_pkg_config_file): Deleted.
2678         * gtk/generate-gtkdoc:
2679         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2680         was only applicable for WebKit1.
2681         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2682
2683 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2684
2685         [GTK] Running minibrowser with url crashes in debug build
2686         https://bugs.webkit.org/show_bug.cgi?id=130492
2687
2688         Reviewed by Martin Robinson.
2689
2690         Update "uri-scheme" test not to use invalid URIs in it, so we
2691         don't get a mistmatch when comparing the original URI stored in
2692         the test class with the one returned by the WebKitWebView.
2693
2694         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2695         (testWebContextURIScheme): Update the test.
2696
2697 2014-04-01  Mihai Tica  <mitica@adobe.com>
2698
2699         Unreviewed: Add myself as a commiter to the contributors list.
2700
2701         * Scripts/webkitpy/common/config/contributors.json:
2702
2703 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2704
2705         [EFL][WK2] Extract the control of page background out of color_set
2706         https://bugs.webkit.org/show_bug.cgi?id=127539
2707
2708         Reviewed by Gyuyoung Kim.
2709
2710         Added an option(C) to change background color.
2711
2712         * MiniBrowser/efl/main.c:
2713         (window_create):
2714         (elm_main):
2715
2716 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2717
2718         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2719
2720         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2721
2722 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2723
2724         Unreviewed test correction after r166530.
2725
2726         * DumpRenderTree/mac/DumpRenderTree.mm:
2727         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2728         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2729
2730 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2731
2732         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2733         https://bugs.webkit.org/show_bug.cgi?id=130987
2734
2735         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2736         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2737
2738         Reviewed by Martin Robinson.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/config.json:
2741
2742 2014-03-31  Dean Jackson  <dino@apple.com>
2743
2744         Remove WEB_ANIMATIONS
2745         https://bugs.webkit.org/show_bug.cgi?id=130989
2746
2747         Reviewed by Simon Fraser.
2748
2749         Remove this feature flag until we plan to implement.
2750
2751         * Scripts/webkitperl/FeatureList.pm:
2752
2753 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2754
2755         Reduced Latched Scroll Test Flakiness
2756         https://bugs.webkit.org/show_bug.cgi?id=130983
2757
2758         Reviewed by Darin Adler.
2759
2760         * DumpRenderTree/mac/DumpRenderTree.mm:
2761         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2762         * DumpRenderTree/mac/EventSendingController.mm:
2763         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2764         with high resolution flags turned on.
2765         * WebKitTestRunner/mac/EventSenderProxy.mm:
2766         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2767
2768 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2769
2770         run-webkit-tests should have a --no-timeout option
2771         https://bugs.webkit.org/show_bug.cgi?id=128286
2772
2773         Reviewed by Joseph Pecoraro.
2774
2775         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2776         (Worker._run_test): Renaming _run_test_with_timeout()
2777         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2778         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2779         (Worker._run_test_in_this_thread):
2780         (Worker._run_test_with_timeout): Deleted.
2781         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2782         (parse_args): Added the --no-timeout option
2783
2784 2014-03-31  Samuel White  <samuel_white@apple.com>
2785
2786         AX: Need ability to get line range for text marker.
2787         https://bugs.webkit.org/show_bug.cgi?id=130906
2788
2789         Reviewed by Chris Fleizach.
2790
2791         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2792
2793         * DumpRenderTree/AccessibilityUIElement.cpp:
2794         (lineTextMarkerRangeForTextMarkerCallback):
2795         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2796         (AccessibilityUIElement::getJSClass):
2797         * DumpRenderTree/AccessibilityUIElement.h:
2798         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2799         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2800         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2801         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2802         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2803         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2804         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2805         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2806         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2807         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2808         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2809         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2810
2811 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2812
2813         More validation for FTL inline caches
2814         https://bugs.webkit.org/show_bug.cgi?id=130948
2815
2816         Reviewed by Geoffrey Garen.
2817
2818         * Scripts/run-jsc-stress-tests:
2819
2820 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2821
2822         [GTK] Do not run WebKit1 unit tests by default
2823         https://bugs.webkit.org/show_bug.cgi?id=130968
2824
2825         Reviewed by Martin Robinson.
2826
2827         * Scripts/run-gtk-tests:
2828         (TestRunner):
2829
2830 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2831
2832         [GTK] Remove scripts code only applicable to autotools
2833         https://bugs.webkit.org/show_bug.cgi?id=130841
2834
2835         Reviewed by Anders Carlsson.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2838         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2839         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2840         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2841         * gtk/find-make-dist-errors: Removed.
2842         * gtk/generate-feature-defines-files: Removed.
2843         * gtk/manifest.txt: No longer need to consider autotools files.
2844
2845 2014-03-30  Andy Estes  <aestes@apple.com>
2846
2847         Fix two failing layout tests on Mountain Lion after r166466.
2848
2849         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2850         (-[DownloadDelegate _downloadDidStart:]):
2851
2852 2014-03-30  Andy Estes  <aestes@apple.com>
2853
2854         [Cocoa] Add an originatingWebView property to _WKDownload
2855         https://bugs.webkit.org/show_bug.cgi?id=130945
2856
2857         Reviewed by Anders Carlsson.
2858
2859         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2860         (-[DownloadDelegate _downloadDidStart:]):
2861         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2862         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2863         (TEST):
2864
2865 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2866
2867         Land the stackmap register liveness glue with the uses of the liveness disabled
2868         https://bugs.webkit.org/show_bug.cgi?id=130924
2869
2870         Reviewed by Oliver Hunt.
2871
2872         * Scripts/run-jsc-stress-tests:
2873
2874 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2875
2876         Update WebKit1.StringTruncator for Mountain Lion.
2877
2878         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2879         due to different font metrics on 10.8.
2880
2881 2014-03-28  Darin Adler  <darin@apple.com>
2882
2883         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2884         https://bugs.webkit.org/show_bug.cgi?id=130889
2885
2886         Reviewed by Alexey Proskuryakov.
2887
2888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2889         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2890         WebStringTruncator methods; should be good for a start. These are dependent on the
2891         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2892
2893 2014-03-28  Martin Hock  <mhock@apple.com>
2894
2895         Unreviewed. Add myself as a committer.
2896
2897         * Scripts/webkitpy/common/config/contributors.json:
2898
2899 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2900
2901         Remove WebKit1 GTK+ bots
2902         https://bugs.webkit.org/show_bug.cgi?id=130904
2903
2904         Reviewed by Anders Carlsson.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2907         all bots are testing WebKit2 only.
2908         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2909         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2910         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2911         * Scripts/webkitpy/port/builders.py: Ditto.
2912         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2913         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2914
2915 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2916
2917         Remove Brian Burg's apple.com email address.
2918
2919         * Scripts/webkitpy/common/config/contributors.json:
2920
2921 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2922
2923         bisect-builds should print Trac 'changeset' URL if only one build is detected
2924         <http://webkit.org/b/130903>
2925
2926         Reviewed by Dan Bernstein.
2927
2928         * Scripts/bisect-builds:
2929         (printTracLink): Print a direct link to the Trac 'changeset'
2930         URL if there is only one revision in the range.
2931
2932 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2933
2934         [EFL] Bump glib version from 2.36 to 2.38 
2935         https://bugs.webkit.org/show_bug.cgi?id=130886
2936
2937         Reviewed by Csaba Osztrogonác.
2938
2939         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2940         we need to bump glib version up to 2.38 as gtk port.
2941
2942         * efl/jhbuild.modules:
2943
2944 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2945
2946         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2947
2948         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2949         the globalhistory directory.
2950
2951         Reviewed by Sam Weinig.
2952
2953         * WebKitTestRunner/TestController.cpp:
2954         (WTR::TestController::TestController):
2955         (WTR::TestController::initialize): Set the history client.
2956         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2957         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2958         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2959         and we don't yet have API to access the data in question.
2960         (WTR::TestController::didPerformClientRedirect):
2961         (WTR::TestController::didPerformServerRedirect):
2962         (WTR::TestController::didUpdateHistoryTitle):
2963         * WebKitTestRunner/TestController.h:
2964         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2965         * WebKitTestRunner/TestInvocation.cpp:
2966         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2967         (WTR::TestInvocation::invoke):
2968
2969 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2970
2971         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2972
2973         * Scripts/build-webkit:
2974         * Scripts/copy-webkitlibraries-to-product-directory:
2975
2976 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2977
2978         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2979         https://bugs.webkit.org/show_bug.cgi?id=130867
2980         <rdar://problem/16432456> 
2981
2982         Reviewed by Mark Hahnenberg.
2983
2984         * Scripts/build-webkit:
2985         * Scripts/copy-webkitlibraries-to-product-directory:
2986
2987 2014-03-26  Andy Estes  <aestes@apple.com>
2988
2989         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2990         https://bugs.webkit.org/show_bug.cgi?id=130805
2991
2992         Reviewed by Dan Bernstein.
2993
2994         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2995         (-[DownloadDelegate _download:didReceiveResponse:]):
2996         (-[DownloadDelegate _downloadDidFinish:]):
2997         (runTest):
2998         (TEST):
2999         (-[FailingDownloadDelegate _downloadDidFinish:]):
3000         (-[FailingDownloadDelegate _download:didFailWithError:]):
3001         (-[FailingDownloadDelegate _downloadDidCancel:]):
3002         (-[CancelledDownloadDelegate _downloadDidStart:]):
3003         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3004         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3005         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3006         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3007         (-[DownloadDelegate sourceURL]): Deleted.
3008         (runTestWithNavigationDelegate): Deleted.
3009
3010 2014-03-26  Anders Carlsson  <andersca@apple.com>
3011
3012         Change MiniBrowser to hold on to window controllers instead of windows
3013         https://bugs.webkit.org/show_bug.cgi?id=130797
3014
3015         Reviewed by Oliver Hunt.
3016
3017         * MiniBrowser/mac/AppDelegate.h:
3018         * MiniBrowser/mac/AppDelegate.m:
3019         (-[BrowserAppDelegate init]):
3020         (-[BrowserAppDelegate newWindow:]):
3021         (-[BrowserAppDelegate browserWindowWillClose:]):
3022         (-[BrowserAppDelegate applicationWillTerminate:]):
3023         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3024
3025 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3026
3027         Unreviewed, rolling out r166264.
3028         https://bugs.webkit.org/show_bug.cgi?id=130785
3029
3030         Broke some window.opener tests for WK2 Mavericks (Requested by
3031         brrian__ on #webkit).
3032
3033         Reverted changeset:
3034
3035         "Web Replay: resource unique identifiers should be unique-per-
3036         frame, not globally"
3037         https://bugs.webkit.org/show_bug.cgi?id=130632
3038         http://trac.webkit.org/changeset/166264
3039
3040 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3041
3042         [CSS Shapes] Remove shape-inside support
3043         https://bugs.webkit.org/show_bug.cgi?id=130698
3044
3045         Reviewed by David Hyatt.
3046
3047         * Scripts/webkitperl/FeatureList.pm:
3048
3049 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3050
3051         Unreviewed. Add myself as a committer.
3052
3053         * Scripts/webkitpy/common/config/contributors.json:
3054
3055 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3056
3057         run-launcher is Perl script so use elsif and not elif
3058         https://bugs.webkit.org/show_bug.cgi?id=130771
3059
3060         Reviewed by Carlos Garcia Campos.
3061
3062         * Scripts/run-launcher:
3063
3064 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3065
3066         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3067         https://bugs.webkit.org/show_bug.cgi?id=130575
3068
3069         Reviewed by Mario Sanchez Prada.
3070
3071         Change ATK version to 2.11.92. Adjust current implementation.
3072
3073         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3074         (AccessibilityUIElement::intValue):
3075         (AccessibilityUIElement::minValue):
3076         (AccessibilityUIElement::maxValue):
3077         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3078         (WTR::AccessibilityUIElement::intValue):
3079         (WTR::AccessibilityUIElement::minValue):
3080         (WTR::AccessibilityUIElement::maxValue):
3081         * efl/jhbuild.modules:
3082         * gtk/jhbuild.modules:
3083
3084 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3085
3086         [GTK] The gnumake package is no longer needed in jhbuild
3087         https://bugs.webkit.org/show_bug.cgi?id=130121
3088
3089         Reviewed by Martin Robinson.
3090
3091         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3092         for a debug build cmake/system-gnumake worked just fine for me.
3093
3094         * gtk/jhbuild.modules: Removed gnumake.
3095         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3096         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3097
3098 2014-03-25  Andy Estes  <aestes@apple.com>
3099
3100         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3101
3102         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3103         (-[DownloadDelegate _download:didReceiveData:]):
3104         (-[DownloadDelegate _downloadDidFinish:]):
3105
3106 2014-03-25  Brian Burg  <bburg@apple.com>
3107
3108         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3109         https://bugs.webkit.org/show_bug.cgi?id=130623
3110
3111         Reviewed by Timothy Hatcher.
3112
3113         The resource loader callback dumping routines assumed that resource identifiers
3114         were globally unique. Its map of resource identifiers to URLs must also track the
3115         frame associated with the resource.
3116
3117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3118         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3119         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3120         stable as long as the frame is valid.
3121         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3122         (WTR::InjectedBundlePage::willSendRequestForFrame):
3123         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3124         (WTR::InjectedBundlePage::didFinishLoadForResource):
3125         (WTR::InjectedBundlePage::didFailLoadForResource):
3126
3127 2014-03-25  Andy Estes  <aestes@apple.com>
3128
3129         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3130
3131         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3132         (-[DownloadDelegate _download:didReceiveResponse:]):
3133         (-[DownloadDelegate _download:didReceiveData:]):
3134
3135 2014-03-25  Andy Estes  <aestes@apple.com>
3136
3137         Add some debug logging to an API test that's failing on Mountain Lion.
3138
3139         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3140         (-[DownloadDelegate _download:didReceiveResponse:]):
3141         (-[DownloadDelegate _downloadDidFinish:]):
3142
3143 2014-03-25  Anders Carlsson  <andersca@apple.com>
3144
3145         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3146         https://bugs.webkit.org/show_bug.cgi?id=130732
3147
3148         Reviewed by Tim Horton.
3149
3150         * MiniBrowser/mac/WK2BrowserWindowController.m:
3151         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3152
3153 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3154
3155         [GTK] Remove the autotools build
3156         https://bugs.webkit.org/show_bug.cgi?id=130717
3157
3158         Reviewed by Anders Carlsson.
3159
3160         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3161         * GNUmakefile.am: Removed.
3162         * GtkLauncher/GNUmakefile.am: Removed.
3163         * GtkLauncher/main.c: Remove references to the autotools configure file.
3164         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3165         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3166         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3167         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3168         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3169         * Scripts/build-webkit: No longer handle autotools.
3170         * Scripts/run-gtk-tests: Ditto.
3171         (TestRunner._setup_testing_environment):
3172         * Scripts/run-launcher: Ditto.
3173         * Scripts/webkitdirs.pm: Ditto.
3174         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3175         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3176         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3177         * Scripts/webkitpy/style/checker.py:
3178         * TestWebKitAPI/GNUmakefile.am: Removed.
3179         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3180         * WebKitTestRunner/GNUmakefile.am: Removed.
3181         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3182         * gtk/GNUmakefile.am: Removed.
3183         * gtk/common.py: Remove checks for the autotools build.
3184         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3185
3186 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3187
3188         prepare-ChangeLog throws false positive warnings for modified files.
3189         https://bugs.webkit.org/show_bug.cgi?id=130687
3190
3191         Reviewed by Darin Adler.
3192
3193         * Scripts/prepare-ChangeLog:
3194         (originalFile): Ignore git commit paremeter.
3195         We don't need this to get the unmodified file.
3196         (extractLineRangeBeforeChange):
3197         Simplify the if statement. Follow-up after r166189.
3198
3199 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3200
3201         [EFL] Add ARM64 build support
3202         https://bugs.webkit.org/show_bug.cgi?id=130506
3203
3204         Rubber stamped by Gyuyoung Kim.
3205
3206         * Scripts/webkitdirs.pm:
3207         (isARM): Detect aarch64 as ARM.
3208
3209 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3210
3211         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3212         https://bugs.webkit.org/show_bug.cgi?id=130137
3213
3214         Reviewed by Csaba Osztrogonác.
3215
3216         * Scripts/webkitpy/common/checkout/changelog.py:
3217         (ChangeLogEntry._parse_bug_description):
3218         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3219         (test_parse_log_entries_from_changelog):
3220         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3221         (CheckoutTest.test_commit_info_for_revision):
3222
3223 2014-03-24  Andy Estes  <aestes@apple.com>
3224
3225         Fix the iOS build of TestWebKitAPI.
3226
3227         * TestWebKitAPI/Configurations/Base.xcconfig:
3228         * TestWebKitAPI/PlatformUtilities.h:
3229
3230 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3231
3232         Fix prepare-ChangeLog after r166156.
3233         https://bugs.webkit.org/show_bug.cgi?id=130674
3234
3235         Reviewed by Darin Adler.
3236
3237         * Scripts/prepare-ChangeLog:
3238         (generateFunctionLists):
3239         (extractLineRangeBeforeChange):
3240
3241 2014-03-24  Andy Estes  <aestes@apple.com>
3242
3243         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3244         https://bugs.webkit.org/show_bug.cgi?id=129322
3245
3246         Reviewed by Anders Carlsson.
3247
3248         Add an API test suite for _WKDownload.
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3252         (-[DownloadDelegate initWithSourceURL:]):
3253         (-[DownloadDelegate sourceURL]):
3254         (-[DownloadDelegate _downloadDidStart:]):
3255         (-[DownloadDelegate _download:didReceiveResponse:]):
3256         (-[DownloadDelegate _download:didReceiveData:]):
3257         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3258         (-[DownloadDelegate _downloadDidFinish:]):
3259         (TEST):
3260         (runTestWithNavigationDelegate):
3261         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3262         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3263
3264 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3265
3266         filter-build-webkit: reduce unfiltered output
3267         https://bugs.webkit.org/show_bug.cgi?id=130485
3268
3269         Reviewed by Brent Fulgham.
3270
3271         * Scripts/filter-build-webkit:
3272         (shouldIgnoreLine):
3273
3274 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3275
3276         prepare-ChangeLog should list functions that have been removed too.
3277         https://bugs.webkit.org/show_bug.cgi?id=130508
3278
3279         Reviewed by Darin Adler.
3280
3281         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3282         We have to read the functions and the line ranges of them from the source
3283         before the change, then search for overlaps between them and the changed
3284         line ranges from diff.
3285
3286         * Scripts/prepare-ChangeLog:
3287         (originalFile): Get original source command.
3288         (generateFunctionLists): Collect deleted functions too.
3289         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3290         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3291         deleted functions ranges too.
3292         (extractLineRange): Renamed to extractLineRangeAfterChange.
3293
3294 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3295
3296         Move all EFL typedefs into EflTypedefs.h.
3297         https://bugs.webkit.org/show_bug.cgi?id=130511
3298
3299         Reviewed by Gyuyoung Kim.
3300
3301         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3302         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3303         * WebKitTestRunner/PlatformWebView.h: Ditto.
3304
3305 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3306
3307         Don't flush compositing layers within FrameView::willPaintContents()
3308         https://bugs.webkit.org/show_bug.cgi?id=130627
3309         <rdar://problem/16368869>
3310
3311         Reviewed by Sam Weinig.
3312         
3313         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3314         does not flush.
3315         
3316         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3317         into an explicit function called before dumping. 
3318         
3319         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
3320         are flushed to CA. They will be pushed to the window by snapshotting.
3321
3322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3323         Fix weird path to IOKit.framework.
3324         * DumpRenderTree/mac/DumpRenderTree.mm:
3325         (updateDisplay):
3326         (dump):
3327         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3328         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
3329         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
3330
3331 2014-03-21  David Kilzer  <ddkilzer@apple.com>
3332
3333         fix-blink-patch: tool to fix up renamed directory paths in Blink
3334         <http://webkit.org/b/130609>
3335
3336         Reviewed by Ryosuke Niwa.
3337
3338         Usage: cat blink.patch | fix-blink-patch | svn-apply
3339
3340         * Scripts/fix-blink-patch: Added.
3341
3342 2014-03-21  Darin Adler  <darin@apple.com>
3343
3344         Remove use of deprecatedCharacters in WebKit API tests
3345         https://bugs.webkit.org/show_bug.cgi?id=130602
3346
3347         Reviewed by Antti Koivisto.
3348
3349         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3350         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3351         (TestWebKitAPI::expectEmpty): Use characters8.
3352         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3353
3354         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3355         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3356         the deprecatedCharacters function itself, which we are about to delete.
3357
3358 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3359
3360         [webkitpy] Fix has_valid_reviewer()
3361         https://bugs.webkit.org/show_bug.cgi?id=130589
3362
3363         Reviewed by Csaba Osztrogonác.
3364
3365         * Scripts/webkitpy/common/checkout/changelog.py:
3366         (ChangeLogEntry.has_valid_reviewer):
3367         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3368         (test_has_valid_reviewer):
3369         * Scripts/webkitpy/common/config/committers.py:
3370         (CommitterList._reviewer_only):
3371         (CommitterList.committer_by_name):
3372         (CommitterList.reviewer_by_email):
3373         (CommitterList):
3374         (CommitterList.reviewer_by_name):
3375
3376 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3377
3378         Add cache support for jhbuild
3379         https://bugs.webkit.org/show_bug.cgi?id=130588
3380
3381         Reviewed by Csaba Osztrogonác.
3382
3383         * jhbuild/jhbuildrc_common.py:
3384         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3385
3386 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3387
3388         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3389         https://bugs.webkit.org/show_bug.cgi?id=130504
3390
3391         Reviewed by Martin Robinson.
3392
3393         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3394         CMake if not specified.
3395         * Scripts/webkitdirs.pm:
3396         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3397         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3398
3399 2014-03-21  Andreas Kling  <akling@apple.com>
3400
3401         RetainPtr API test should use CFArray instead of CFString for testing.
3402         <rdar://problem/16384899>
3403
3404         Unreviewed bot fix.
3405
3406         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3407         (TestWebKitAPI::TEST):
3408         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3409         (TestWebKitAPI::TEST):
3410
3411 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3412
3413         Move to using std::unique_ptr for EFL objects.
3414         https://bugs.webkit.org/show_bug.cgi?id=129853
3415
3416         Reviewed by Gyuyoung Kim.
3417
3418         EflUniquePtr is a template alias of std::unique_ptr
3419         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3420         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3421
3422         * DumpRenderTree/efl/DumpRenderTree.cpp:
3423         (main):
3424         * ImageDiff/efl/ImageDiff.cpp:
3425         (initEfl):
3426         (main):
3427
3428 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3429
3430         Unreviewed buildfix after r165983 for non Cocoa platforms
3431
3432         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3433
3434         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3435         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3436         * WebKitTestRunner/TestController.cpp:
3437
3438 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3439
3440         [GTK][CMake] Add support for building with Clang
3441         https://bugs.webkit.org/show_bug.cgi?id=130260
3442
3443         Reviewed by Martin Robinson.
3444
3445         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3446         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3447         included GTest framework headers.
3448         * gtk/generate-gtkdoc:
3449         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3450         in case of using Clang since that is now set by the CMake rule.
3451
3452 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3453
3454         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3455         https://bugs.webkit.org/show_bug.cgi?id=130476
3456
3457         Reviewed by Anders Carlsson.
3458         
3459         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3460
3461         * MiniBrowser/mac/WK1BrowserWindowController.m:
3462         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3463         Remove log.
3464         * MiniBrowser/mac/WK2BrowserWindowController.m:
3465         (-[WK2BrowserWindowController awakeFromNib]):
3466         (-[WK2BrowserWindowController validateMenuItem:]):
3467         (-[WK2BrowserWindowController reload:]):
3468         Hook up reload.
3469         (-[WK2BrowserWindowController toggleZoomMode:]):
3470         (-[WK2BrowserWindowController resetZoom:]):
3471         (-[WK2BrowserWindowController canResetZoom]):
3472         (-[WK2BrowserWindowController currentZoomFactor]):
3473         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3474         (-[WK2BrowserWindowController canZoomIn]):
3475         (-[WK2BrowserWindowController canZoomOut]):
3476
3477 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3478
3479         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3480         https://bugs.webkit.org/show_bug.cgi?id=130463
3481
3482         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3483
3484 2014-03-18  Samuel White  <samuel_white@apple.com>
3485
3486         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3487         https://bugs.webkit.org/show_bug.cgi?id=130250
3488
3489         Reviewed by Chris Fleizach.
3490
3491         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3492
3493         * DumpRenderTree/AccessibilityController.cpp:
3494         (enableEnhancedAccessibilityCallback):
3495         (getEnhancedAccessibilityEnabledCallback):
3496         (AccessibilityController::getJSClass):
3497         * DumpRenderTree/AccessibilityController.h:
3498         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3499         (AccessibilityController::enableEnhancedAccessibility):
3500         (AccessibilityController::enhancedAccessibilityEnabled):
3501         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3502         (AccessibilityController::enableEnhancedAccessibility):
3503         (AccessibilityController::enhancedAccessibilityEnabled):
3504         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3505         (AccessibilityController::enableEnhancedAccessibility):
3506         (AccessibilityController::enhancedAccessibilityEnabled):
3507         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3508         (AccessibilityController::enableEnhancedAccessibility):
3509         (AccessibilityController::enhancedAccessibilityEnabled):
3510         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3511         (WTR::AccessibilityController::enableEnhancedAccessibility):
3512         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3513         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3514         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3515
3516 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3517
3518         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3519         yet).
3520
3521         * Scripts/webkitpy/common/config/contributors.json:
3522
3523 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3524
3525         Web Inspector: Remove stale ReportMemoryUsagePlugin
3526         https://bugs.webkit.org/show_bug.cgi?id=130405
3527
3528         Reviewed by Andreas Kling.
3529
3530         This clang plugin looks like it was used for the old Inspector memory
3531         instrumentation that was removed. So the tool can be removed.
3532
3533         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3534         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3535         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3536         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3537
3538 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3539
3540         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3541         https://bugs.webkit.org/show_bug.cgi?id=130220
3542
3543         Reviewed by Csaba Osztrogonác.
3544
3545         * Scripts/webkitpy/common/checkout/changelog.py:
3546         (ChangeLog.set_reviewer):
3547         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3548         (test_set_reviewer):
3549
3550 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3551
3552         More FTL enabling.
3553
3554         Rubber stamped by Dan Bernstein.
3555
3556         * Tools/Scripts/build-webkit:
3557
3558 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3559
3560         Renable pagination mode in WK2 MiniBrowser
3561         https://bugs.webkit.org/show_bug.cgi?id=130374
3562
3563         Reviewed by Anders Carlsson.
3564         
3565         Put the implementation of togglePaginationMode: back, and correctly
3566         enable the menu item.
3567
3568         * MiniBrowser/mac/WK2BrowserWindowController.m:
3569         (-[WK2BrowserWindowController validateMenuItem:]):
3570         (-[WK2BrowserWindowController isPaginated]):
3571         (-[WK2BrowserWindowController togglePaginationMode:]):
3572
3573 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3574
3575         Add --reset option to Tools/Scripts/set-webkit-configuration script
3576         https://bugs.webkit.org/show_bug.cgi?id=130401
3577
3578         Reviewed by Csaba Osztrogonác.
3579
3580         * Scripts/set-webkit-configuration:
3581
3582 2014-03-18  Alberto Garcia  <berto@igalia.com>
3583
3584         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3585         https://bugs.webkit.org/show_bug.cgi?id=130388
3586
3587         Reviewed by Sergio Villar Senin.
3588
3589         * Scripts/webkitdirs.pm:
3590         (shouldRemoveCMakeCache): make sure that the build directory
3591         exists before attempting to create a file in it.
3592
3593 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3594
3595         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3596         https://bugs.webkit.org/show_bug.cgi?id=130336
3597
3598         Reviewed by Gyuyoung Kim.
3599
3600         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3601         requires a space between literal and string macro [-Wliteral-suffix]'
3602         warning treated as error.
3603
3604         This patch applies a solution from r162448 to the EFL port.
3605
3606         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3607         * efl/jhbuild.modules: Added appropriate patch section.
3608
3609 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3610
3611         webkitpy test rebaseline.
3612
3613         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3614         (MainTest.test_default_args):
3615
3616 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3617
3618         --profile should imply --test-runner-count=1 in run-perf-tests
3619         https://bugs.webkit.org/show_bug.cgi?id=130375
3620
3621         Reviewed by Benjamin Poulain.
3622
3623         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3624
3625         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3626         (PerfTestsRunner._parse_args): Use -1 as the default value.
3627         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3628         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3629         should be 1.
3630
3631 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3632
3633         Address some style nits.
3634
3635         * MiniBrowser/mac/WK2BrowserWindowController.m:
3636
3637 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3638
3639         Add transparent window support back into MiniBrowser
3640         https://bugs.webkit.org/show_bug.cgi?id=130363
3641
3642         Reviewed by Anders Carlsson.
3643         
3644         Re-enable transparent window support for WK2.
3645
3646         * MiniBrowser/mac/WK2BrowserWindowController.m:
3647         (-[WK2BrowserWindowController validateMenuItem:]):
3648         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3649
3650 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3651
3652         Fix the 32-bit build; make the open panel make a WK1 window.
3653
3654         * MiniBrowser/mac/AppDelegate.m:
3655         (-[BrowserAppDelegate openDocument:]):
3656
3657 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3658
3659         Convert MiniBrowser to use WKWebView API
3660         https://bugs.webkit.org/show_bug.cgi?id=130061
3661
3662         Reviewed by Anders Carlsson.
3663         
3664         Convert the MiniBrowser WK2 window to use WebKit2 API as much