[XCode] webkit-patch should run sort-Xcode-project-file
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
2
3         [XCode] webkit-patch should run sort-Xcode-project-file
4         https://bugs.webkit.org/show_bug.cgi?id=174036
5
6         Reviewed by Simon Fraser.
7
8         * Scripts/webkitpy/common/config/ports.py:
9         * Scripts/webkitpy/tool/commands/download.py:
10         * Scripts/webkitpy/tool/commands/upload.py:
11         * Scripts/webkitpy/tool/steps/__init__.py:
12         * Scripts/webkitpy/tool/steps/options.py:
13         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
14
15 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
16
17         REGRESSION(r219857): run-benchmark --allplans broken
18         https://bugs.webkit.org/show_bug.cgi?id=175186
19
20         Reviewed by Saam Barati.
21
22         r219857 forgot to update also the calls to BenchmarkRunner() that
23         is done when the script is run with --allplans.
24
25         To fix this (and avoid future issues like this), let's factorize
26         the calls to the benchhmark runner in a run_benchmark_plan()
27         function.
28
29         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
30         (run_benchmark_plan):
31         (start):
32
33 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
34
35         Dashboard bubbles sometimes show failure count instead of crash count
36         https://bugs.webkit.org/show_bug.cgi?id=175157
37         <rdar://problem/33709009>
38
39         Reviewed by Alexey Proskuryakov.
40
41         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
42         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
43
44 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
45
46         Add tests for NeverDestroyed
47         https://bugs.webkit.org/show_bug.cgi?id=175146
48
49         Reviewed by Darin Adler.
50
51         * CMakeLists.txt:
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         New files and sort.
54
55         * TestWebKitAPI/Tests/WTF/Logger.h:
56         * TestWebKitAPI/Tests/WTF/Logger.cpp:
57         (TestWebKitAPI::log):
58         (TestWebKitAPI::takeLogStr):
59         * TestWebKitAPI/Tests/WTF/RefLogger.h:
60         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
61         (TestWebKitAPI::log): Deleted.
62         (TestWebKitAPI::takeLogStr): Deleted.
63         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
64
65         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
66         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
67         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
68         (TestWebKitAPI::LifecycleLogger::operator=):
69         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
70         (TestWebKitAPI::LifecycleLogger::setName):
71         (TestWebKitAPI::TEST):
72         Add a class that logs construction / assignment / modifications.
73
74         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
75         (TestWebKitAPI::TEST):
76         (TestWebKitAPI::list):
77         Test construction behavior is as expected both directly and using makeNeverDestroyed.
78
79 2017-08-04  Lucas Forschler  <lforschler@apple.com>
80
81         minification logic is not implemented for ios builds
82         <rdar://problem/33726561>
83
84         Reviewed by Dean Johnson
85
86         * BuildSlaveSupport/built-product-archive:
87         (minifyDirectory): refactor minifySource -> minifyDirectory
88         (archiveBuiltProduct): add ios minification logic
89         (minifySource): Deleted.
90
91 2017-08-04  Matt Lewis  <jlewis3@apple.com>
92
93         Unreviewed, rolling out r220271.
94
95         Rolling out due to Layout Test failing on iOS Simulator.
96
97         Reverted changeset:
98
99         "Remove STREAMS_API compilation guard"
100         https://bugs.webkit.org/show_bug.cgi?id=175165
101         http://trac.webkit.org/changeset/220271
102
103 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
104
105         Unreviewed, rolling out r220268.
106
107         This change caused assertion failures on macOS and iOS Debug
108         WK2.
109
110         Reverted changeset:
111
112         "Resource Load Statistics: Report user interaction
113         immediately, but only when needed"
114         https://bugs.webkit.org/show_bug.cgi?id=175090
115         http://trac.webkit.org/changeset/220268
116
117 2017-08-04  Youenn Fablet  <youenn@apple.com>
118
119         Remove STREAMS_API compilation guard
120         https://bugs.webkit.org/show_bug.cgi?id=175165
121
122         Reviewed by Darin Adler.
123
124         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
125
126 2017-08-04  John Wilander  <wilander@apple.com>
127
128         Resource Load Statistics: Report user interaction immediately, but only when needed
129         https://bugs.webkit.org/show_bug.cgi?id=175090
130         <rdar://problem/33685546>
131
132         Reviewed by Chris Dumez.
133
134         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
135         (WTR::InjectedBundle::beginTesting):
136             Now calls WebCore::ResourceLoadObserver::clearState().
137
138 2017-08-03  Brian Burg  <bburg@apple.com>
139
140         Remove ENABLE(WEB_SOCKET) guards
141         https://bugs.webkit.org/show_bug.cgi?id=167044
142
143         Reviewed by Joseph Pecoraro.
144
145         * Scripts/webkitperl/FeatureList.pm:
146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
147
148 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
149
150         REGRESSION(r219850): run-benchmark script broken on Linux
151         https://bugs.webkit.org/show_bug.cgi?id=175126
152
153         Reviewed by Stephanie Lewis.
154
155         The run-benchmark script dynamically generates the list of supported
156         browsers and platforms (currently Linux and OSX) by loading all
157         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
158         and getting the browser_name and platform variables from the
159         classes defined there.
160
161         This means that this classes should not raise an exception when
162         loaded on other platforms or otherwise they will broke the whole
163         script. Its fine if they raise an exception when executing any of
164         the methods they implement, but not when just loading/importing
165         the class.
166
167         Move the argument variable definitions that call on the platform
168         specific OSXBrowserDriver._screen_size() function from beeing
169         variables that are evaluated when loading the file, to be functions
170         that are only evaluated when the actual functionality needs to be
171         executed.
172
173         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
174         (OSXChromeDriver.launch_url):
175         (OSXChromeCanaryDriver.launch_url):
176         (create_args):
177         (create_chrome_options):
178         (create_window_size_arg):
179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
180         (OSXFirefoxDriver.launch_url):
181         (OSXFirefoxNightlyDriver.launch_url):
182         (OSXFirefoxNightlyDriver.launch_driver):
183         (create_args):
184
185 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
186
187         [PAL] Move spi/cf directory into PAL
188         https://bugs.webkit.org/show_bug.cgi?id=175057
189
190         Reviewed by Antti Koivisto.
191
192         * Scripts/webkitpy/style/checker.py:
193         * Scripts/webkitpy/style/checker_unittest.py:
194         (GlobalVariablesTest.test_path_rules_specifier):
195
196         Ignore "readability/naming/underscores" style errors for sources
197         under the WebCore/PAL/pal/spi directory.
198
199         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
200
201 2017-08-03  Youenn Fablet  <youenn@apple.com>
202
203         Remove FETCH_API compilation guard
204         https://bugs.webkit.org/show_bug.cgi?id=175154
205
206         Reviewed by Chris Dumez.
207
208         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
209
210 2017-08-03  Lucas Forschler  <lforschler@apple.com>
211
212         Enable archive minification on iOS builds
213         https://bugs.webkit.org/show_bug.cgi?id=174718
214         
215         Reviewed by Aakash Jain.
216
217         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
218         (BuildFactory.__init__):
219
220 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
221
222         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
223         https://bugs.webkit.org/show_bug.cgi?id=175140
224
225         Reviewed by Alexey Proskuryakov.
226
227         We are having lately issues with JSC tests causing problems on
228         the GTK+ and WPE bots due to the high amount of memory some tests
229         need to run.
230
231         The best thing we can do now is to workaround this by disabling
232         all the tests marked as memoryLimited on the GTK and WPE bots.
233         We may revise this on the future.
234
235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
236         (RunJavaScriptCoreTests.start):
237
238 2017-08-03  Brady Eidson  <beidson@apple.com>
239
240         Add SW IDLs and stub out basic functionality.
241         https://bugs.webkit.org/show_bug.cgi?id=175115
242
243         Reviewed by Chris Dumez.
244
245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
246
247         * Scripts/webkitpy/bindings/main.py:
248
249 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
250
251         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
252         https://bugs.webkit.org/show_bug.cgi?id=159510
253
254         Reviewed by Daniel Bates.
255
256         Allow any https certificate when running tests.
257
258         * DumpRenderTree/win/DumpRenderTree.cpp:
259         (runTest):
260
261 2017-08-02  Youenn Fablet  <youenn@apple.com>
262
263         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
264         https://bugs.webkit.org/show_bug.cgi?id=175089
265
266         Reviewed by Chris Dumez.
267
268         * DumpRenderTree/TestOptions.mm:
269         (TestOptions::TestOptions): Using absolutePath if available.
270         * DumpRenderTree/mac/DumpRenderTree.mm:
271         (computeTestURL): Removing http/tests/ specific URL computation.
272         * Scripts/webkitpy/port/driver.py:
273         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
274
275 2017-08-02  Lucas Forschler  <lforschler@apple.com>
276
277         download-built-product should allow for a proxy option
278         https://bugs.webkit.org/show_bug.cgi?id=174875
279
280         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
281
282         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
283         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
284         
285
286 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
287
288         check-webkit-style: deleting lines in a file runs the linter on the whole file
289         https://bugs.webkit.org/show_bug.cgi?id=175078
290
291         Reviewed by David Kilzer.
292
293         Deleting lines in a file should not cause linter errors to be blamed on the patch.
294         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
295
296         * Scripts/webkitpy/style/checkers/test_expectations.py:
297         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
298         * Scripts/webkitpy/style/main_unittest.py:
299         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
300         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
301         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
302
303 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
304
305         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
306         https://bugs.webkit.org/show_bug.cgi?id=175075
307
308         Reviewed by David Kilzer.
309
310         We have no way of handling text files with illegal unicode characters. Allow the callers of
311         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
312         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
313
314         * Scripts/webkitpy/common/system/filesystem.py:
315         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
316         (FileSystem.write_text_file): Ditto.
317         * Scripts/webkitpy/common/system/filesystem_mock.py:
318         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
319         (MockFileSystem.write_text_file): Ditto.
320         * Scripts/webkitpy/common/system/filesystem_unittest.py:
321         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
322         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
323
324 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
325
326         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
327         https://bugs.webkit.org/show_bug.cgi?id=175072
328
329         Reviewed by Alexey Proskuryakov.
330
331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
332         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
333
334 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
335
336         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
337         https://bugs.webkit.org/show_bug.cgi?id=175019
338
339         Reviewed by Darin Adler.
340
341         * TestWebKitAPI/CMakeLists.txt:
342
343 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
344
345         Enabling uploading archives to S3
346         https://bugs.webkit.org/show_bug.cgi?id=174198
347
348         Unreviewed unit test fix after r219235.
349
350         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
351
352 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
353
354         Fix JSCOnly ARM buildbots after r220047
355         https://bugs.webkit.org/show_bug.cgi?id=174993
356
357         Unreviewed fix after r220087.
358
359         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
360         (BuildAndRemoteJSCTestsFactory.__init__):
361
362 2017-08-01  Chris Dumez  <cdumez@apple.com>
363
364         Add initial support for navigator.sendBeacon
365         https://bugs.webkit.org/show_bug.cgi?id=175007
366         <rdar://problem/33547728>
367
368         Reviewed by Sam Weinig.
369
370         Enable the Beacon API at runtime in the context of layout tests since the
371         feature is currently disabled by default.
372
373         * DumpRenderTree/mac/DumpRenderTree.mm:
374         (enableExperimentalFeatures):
375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
376         (WTR::InjectedBundle::beginTesting):
377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
378         (WTR::TestRunner::setModernMediaControlsEnabled):
379         (WTR::TestRunner::setBeaconAPIEnabled):
380         * WebKitTestRunner/InjectedBundle/TestRunner.h:
381
382 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
383
384         Update Bot Watcher's Dashboard for Buildbot 0.9
385         https://bugs.webkit.org/show_bug.cgi?id=174777
386
387         Reviewed by Daniel Bates.
388
389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
390         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
391         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
392         in a dictionary.
393         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
394         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
396         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
397         (parseRevisionProperty): Ditto.
398         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
399         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
400         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
401         have changed in Buildbot 0.9.
402         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
403         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
404         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
405         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
406         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
407         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
408         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
409         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
410         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
411         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
413         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
414         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
415         (BuildbotQueue.prototype.get overviewURL): Ditto.
416         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
417         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
418         Buildbot 0.8 or 0.9.
419         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
420         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
421         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
422         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
423         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
424         Therefore we are fetching information for fixed number of build. 
425         Also iterating the loop incrementally since the build data is already reverse sorted.
426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
427         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
428         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
430         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
431
432 2017-08-01  Devin Rousso  <drousso@apple.com>
433
434         Web Inspector: simplify WebInspector with WI
435         https://bugs.webkit.org/show_bug.cgi?id=175058
436
437         Reviewed by Joseph Pecoraro.
438
439         * Scripts/check-inspector-strings:
440         (extract_ui_strings):
441         * Scripts/extract-localizable-js-strings:
442
443 2017-08-01  Youenn Fablet  <youenn@apple.com>
444
445         Layout tests with 'https' suffix should be run over HTTPS
446         https://bugs.webkit.org/show_bug.cgi?id=174992
447
448         Reviewed by Chris Dumez.
449
450         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
451         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
452         Covered by corresponding unit tests.
453
454         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
455         (run_server):
456         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
457         (base_http_url):
458         (base_https_url):
459         (base_url): Deleted.
460         * Scripts/webkitpy/port/base.py:
461         (Port.to.web_platform_test_server_base_http_url):
462         (Port.to):
463         (Port.to.web_platform_test_server_base_https_url):
464         (Port.to.web_platform_test_server_base_url): Deleted.
465         * Scripts/webkitpy/port/driver.py:
466         (Driver.__init__):
467         (Driver.wpt_test_path_to_uri):
468         (Driver):
469         (Driver.http_test_path_to_uri):
470         (Driver.test_to_uri):
471         (Driver.uri_to_test):
472         * Scripts/webkitpy/port/driver_unittest.py:
473         (DriverTest.test_test_to_uri):
474         (DriverTest.test_uri_to_test):
475
476 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
477
478         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
479         https://bugs.webkit.org/show_bug.cgi?id=173998
480
481         Reviewed by Darin Adler.
482
483         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
484         detect mistakes in backward compatibility in the future when we change it.
485
486         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
487         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
488         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
489         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
490         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
491         internal key data slot.
492
493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
494         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
495         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
496         (getNextMessage):
497         (TEST):
498         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
499         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
500         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
501         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
502         These are the pre-baked databases.
503         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
504         This is the actual test that do all the reads and comparisons.
505         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
506         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
507         IndexedDB new stuffs. Then it can be used to bake the database again.
508
509 2017-08-01  Brady Eidson  <beidson@apple.com>
510
511         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
512         https://bugs.webkit.org/show_bug.cgi?id=175030
513
514         Reviewed by Andy Estes.
515
516         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
517         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
518
519 2017-08-01  Brady Eidson  <beidson@apple.com>
520
521         Part 2 of: Rename DatabaseProcess to StorageProcess.
522         https://bugs.webkit.org/show_bug.cgi?id=174880
523
524         Reviewed by Andy Estes.
525
526         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
527         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
528         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
529         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
530         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
531         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
532         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
533         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
534
535 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
536
537         Fix JSCOnly ARM buildbots after r220047
538         https://bugs.webkit.org/show_bug.cgi?id=174993
539
540         Reviewed by Saam Barati.
541
542         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
543         (BuildAndRemoteJSCTestsFactory.__init__):
544
545 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
546
547         [WTF] Introduce Private Symbols
548         https://bugs.webkit.org/show_bug.cgi?id=174935
549
550         Reviewed by Darin Adler.
551
552         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
553         (TestWebKitAPI::TEST):
554
555 2017-07-30  Darin Adler  <darin@apple.com>
556
557         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
558         https://bugs.webkit.org/show_bug.cgi?id=130653
559
560         Reviewed by Antti Koivisto.
561
562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
563         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
564         when calling frameDidChangeLocation.
565         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
566         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
567         thus causing mysterious failures of a couple of tests. There are two remaining issues:
568         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
569         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
570         same logic flaw that causes "top loading frame" to get set to one of the subframes in
571         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
572         loading, subframe starts loading. It would be good to clean that up some day, but for now
573         this patch makes the two work identically rather than changing both.
574         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
575
576 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
577
578         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
579         https://bugs.webkit.org/show_bug.cgi?id=174963
580
581         Reviewed by Darin Adler.
582
583         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
584         RetainPtr<>. This patch changes them to all use auto.
585
586         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
587         (TestWebKitAPI::TEST):
588
589 2017-07-30  Brady Eidson  <beidson@apple.com>
590
591         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
592         https://bugs.webkit.org/show_bug.cgi?id=174958
593
594         Reviewed by Darin Adler.
595
596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
597         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
598         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
599         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
600         (runUntilTasksInFlight):
601         (TEST):
602
603 2017-07-28  Commit Queue  <commit-queue@webkit.org>
604
605         Unreviewed, rolling out r219990.
606         https://bugs.webkit.org/show_bug.cgi?id=174961
607
608         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
609         estes on #webkit).
610
611         Reverted changeset:
612
613         "Part 2 of: Rename DatabaseProcess to StorageProcess."
614         https://bugs.webkit.org/show_bug.cgi?id=174880
615         http://trac.webkit.org/changeset/219990
616
617 2017-07-28  Brady Eidson  <beidson@apple.com>
618
619         API tests that use URLSchemeHandler are failing.
620         https://bugs.webkit.org/show_bug.cgi?id=174950
621
622         Reviewed by Alex Christensen.
623
624         Fix the NoMIMEType test to be correct.
625
626         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
627         (-[SchemeHandler initWithData:mimeType:]):
628         (-[SchemeHandler webView:startURLSchemeTask:]):
629         (TEST):
630
631 2017-07-28  Daniel Bates  <dabates@apple.com>
632
633         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
634         https://bugs.webkit.org/show_bug.cgi?id=174876
635
636         Reviewed by Alex Christensen.
637
638         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
639         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
640         they provide a more direct way to test the platform abstraction.
641
642         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
643
644         * Scripts/prepare-ChangeLog:
645         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
646         of the current working directory.
647
648 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
649
650         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
651         https://bugs.webkit.org/show_bug.cgi?id=174930
652
653         Unreviewed test fix.
654
655         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
656
657         * Scripts/prepare-ChangeLog:
658         (get_function_line_ranges_for_cpp):
659
660 2017-07-28  JF Bastien  <jfbastien@apple.com>
661
662         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
663         https://bugs.webkit.org/show_bug.cgi?id=174930
664
665         Reviewed by Daniel Bates.
666
667         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
668         here also teach it about const and volatile overloads. I didn't do
669         reference and rvalue reference overloads because we don't really
670         use them, and the current parser throws away those characters and
671         it doesn't seem worth making it more complex.
672
673         * Scripts/prepare-ChangeLog:
674         (get_function_line_ranges_for_cpp):
675         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
676         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
677         (Foo::Arrow::arrow):
678         (Foo::Arrow::otherArrow):
679         (Foo::Arrow::otherArrow const):
680         (Foo::Arrow::otherArrow volatile):
681         (Foo::Arrow::otherArrow const volatile):
682
683 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
684
685         [GTK] Building with ENABLE_VIDEO=OFF fails
686         https://bugs.webkit.org/show_bug.cgi?id=174940
687
688         Reviewed by Alex Christensen.
689
690         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
691         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
692
693         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
694         (methodCallCallback): Add missing USE(GSTREAMER) guard.
695
696 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
697
698         [WPE] Implement EventSenderProxy in WTR
699         https://bugs.webkit.org/show_bug.cgi?id=173419
700
701         Reviewed by Žan Doberšek.
702
703         Add the implementation of EventSenderProxy to the WTR. This
704         allows us to extend the coverage of the test suite in WKWPE.
705
706         * WebKitTestRunner/EventSenderProxy.h:
707         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
708         libxkbcommon needed to deal with key events.
709         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
710         (WTR::EventSenderProxy::EventSenderProxy):
711         (WTR::senderButtonToWPEButton):
712         (WTR::EventSenderProxy::mouseDown):
713         (WTR::EventSenderProxy::mouseUp):
714         (WTR::EventSenderProxy::mouseMoveTo):
715         (WTR::EventSenderProxy::mouseScrollBy):
716         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
717         (WTR::EventSenderProxy::leapForward):
718         (WTR::wkEventModifiersToWPE):
719         (WTR::getXKBKeySymForKeyRef):
720         (WTR::EventSenderProxy::keyDown):
721         (WTR::EventSenderProxy::addTouchPoint):
722         (WTR::EventSenderProxy::updateTouchPoint):
723         (WTR::EventSenderProxy::setTouchModifier):
724         (WTR::EventSenderProxy::setTouchPointRadius):
725         (WTR::EventSenderProxy::getUpdatedTouchEvents):
726         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
727         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
728         (WTR::EventSenderProxy::touchStart):
729         (WTR::EventSenderProxy::touchMove):
730         (WTR::EventSenderProxy::touchEnd):
731         (WTR::EventSenderProxy::touchCancel):
732         (WTR::EventSenderProxy::clearTouchPoints):
733         (WTR::EventSenderProxy::releaseTouchPoint):
734         (WTR::EventSenderProxy::cancelTouchPoint):
735
736 2017-07-27  Brady Eidson  <beidson@apple.com>
737
738         Part 2 of: Rename DatabaseProcess to StorageProcess.
739         https://bugs.webkit.org/show_bug.cgi?id=174880
740
741         Reviewed by Andy Estes.
742
743         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
744         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
745         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
746         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
747         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
748         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
749         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
750         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
751
752 2017-07-26  Mark Lam  <mark.lam@apple.com>
753
754         Add ability to only run specific tests in run-javascriptcore-tests.
755         https://bugs.webkit.org/show_bug.cgi?id=174884
756
757         Reviewed by Saam Barati.
758
759         For example, if we only want to run testapi, we can do so as follows:
760             $ run-javascriptcore-tests --testapi
761
762         Previously, specifying --testapi effectively does nothing because we run all tests
763         by default.  Only --no-testapi had the effect of disabling the test set.  This
764         old behavior for --testapi is not very useful or meaningful.  We're now changing
765         it to mean that we will only run that test.
766
767         With this change, we can also run more than one set of tests.  For example, if we
768         only want to run testmasm and testair, we can do so as follows:
769             $ run-javascriptcore-tests --testmasm --testair
770
771         By default, if no specific test option is specified, run-javascriptcore-tests will
772         run all tests.
773
774         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
775         the mozilla tests (--mozilla-tests) even though both are run via the lower level
776         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
777         the other set will not run.  For example, the following only runs the mozilla tests:
778             $ run-javascriptcore-tests --mozilla-tests
779
780         Note also that --jit-stress-tests is not for choosing a different set of tests.
781         Instead, it is used for determining whether we run JIT'ed test configurations
782         on the jsc stress tests and mozilla tests.  As a result, specifying
783         --jit-stress-tests will not omit other tests.  For example, the following still
784         runs all tests:
785             $ run-javascriptcore-tests --jit-stress-tests
786
787         * Scripts/run-javascriptcore-tests:
788         (defaultStringForTestState):
789         (enableTestOrNot):
790         (runJSCStressTests):
791
792 2017-07-26  Mark Lam  <mark.lam@apple.com>
793
794         Make run-javascriptcore-test run testair, testb3, and testmasm.
795         https://bugs.webkit.org/show_bug.cgi?id=174837
796         <rdar://problem/33522927>
797
798         Reviewed by Saam Barati and Filip Pizlo.
799
800         1. Refactors code for running testapi so that we can use it to run other tests.
801         2. Added running of testmasm, testair, testb3.
802
803         Note: the existing testapi invocation code does not support remote invocation of
804         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
805         and testb3 also do not support remote invocation.  If we wish to add remote
806         invocation support, we should do that in a separate patch.
807
808         * Scripts/run-javascriptcore-tests:
809         (testPath):
810         (runTest):
811         (testapiPath): Deleted.
812
813 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
814
815         Remove duplicate code from Buildbot.js in dashboard
816         https://bugs.webkit.org/show_bug.cgi?id=174870
817
818         Reviewed by Daniel Bates.
819
820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
821         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
822         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
824         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
825
826 2017-07-26  Brady Eidson  <beidson@apple.com>
827
828         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
829         https://bugs.webkit.org/show_bug.cgi?id=174851
830
831         Reviewed by Chris Dumez.
832
833         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
834         (TEST):
835
836 2017-07-26  Brian Burg  <bburg@apple.com>
837
838         Remove WEB_TIMING feature flag
839         https://bugs.webkit.org/show_bug.cgi?id=174795
840
841         Reviewed by Alex Christensen.
842
843         * Scripts/webkitperl/FeatureList.pm:
844         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
845
846 2017-07-26  Chris Dumez  <cdumez@apple.com>
847
848         Pressing the Escape key should not be a valid user gesture to enter fullscreen
849         https://bugs.webkit.org/show_bug.cgi?id=174864
850         <rdar://problem/33009088>
851
852         Reviewed by Geoffrey Garen.
853
854         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
855         WKTR.
856
857         * DumpRenderTree/mac/EventSendingController.mm:
858         (-[EventSendingController keyDown:withModifiers:withLocation:]):
859
860 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
861
862         Unreviewed, added Romain Bellessort to contributors.json.
863
864         * Scripts/webkitpy/common/config/contributors.json:
865
866 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
867
868         [WPE] WebGL2 support
869         https://bugs.webkit.org/show_bug.cgi?id=174249
870
871         Reviewed by Alex Christensen.
872
873         * Scripts/webkitperl/FeatureList.pm:
874         Enable WebGL2 for WPE when building through build-webkit.
875
876 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
877
878         Unreviewed. Fix GTK distcheck.
879
880         * gtk/make-dist.py:
881         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
882
883 2017-07-25  Brady Eidson  <beidson@apple.com>
884
885         ResourceLoadStatistics grandfathering happens much too often.
886         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
887
888         Reviewed by Chris Dumez.
889
890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
891         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
892         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
893         (TEST):
894
895 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
896
897         Fix autoinstaller failing on autoinstall_everything
898         https://bugs.webkit.org/show_bug.cgi?id=174830
899
900         Reviewed by Joseph Pecoraro.
901
902         * Scripts/webkitpy/thirdparty/__init__.py:
903         (AutoinstallImportHook.find_module):
904         (AutoinstallImportHook.install_chromedriver):
905         (AutoinstallImportHook.install_geckodriver):
906         (AutoinstallImportHook._install_chromedriver): Deleted.
907         (AutoinstallImportHook._install_geckodriver): Deleted.
908
909 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
910
911         Replace --runtime with something for both ios-simulator and ios-device
912         https://bugs.webkit.org/show_bug.cgi?id=173775
913         <rdar://problem/32952164>
914
915         Reviewed by Aakash Jain.
916
917         Add --version flag for both iOS simulator and iOS device.
918
919         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
920         (parse_args): Add --version flag and move --no-install.
921         * Scripts/webkitpy/port/factory.py:
922         (platform_options): Move --no-intall to run_webkit_tests.py.
923         * Scripts/webkitpy/port/ios.py:
924         (IOSPort):
925         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
926         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
927         * Scripts/webkitpy/port/ios_device.py:
928         (IOSDevicePort.ios_version): Consult --version flag before checking connected
929         devices for iOS version.
930         * Scripts/webkitpy/port/ios_device_unittest.py:
931         (IOSDeviceTest.make_port): Set --version option so that we can generate test
932         expectation paths without devices connected.
933         (IOSDeviceTest.test_additional_platform_directory): Deleted.
934         (IOSDeviceTest.test_baseline_searchpath): Deleted.
935         (IOSDeviceTest.test_expectations_ordering): Deleted.
936         * Scripts/webkitpy/port/ios_simulator.py:
937         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
938         flag to specify a runtime.
939         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
940         flag and then use the default runtime.
941
942 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
945         https://bugs.webkit.org/show_bug.cgi?id=174815
946
947         Reviewed by Carlos Alberto Lopez Perez.
948
949         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
950         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
951         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
952         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
953         think), probably because of a newer CMake version.
954
955         * CMakeLists.txt:
956         * TestWebKitAPI/CMakeLists.txt:
957         * TestWebKitAPI/PlatformGTK.cmake:
958
959 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
960
961         Fix BenchmarkRunner to only import selenium when needed
962         https://bugs.webkit.org/show_bug.cgi?id=174808
963
964         Reviewed by Stephanie Lewis.
965
966         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
967         (LinuxChromeDriver.launch_driver):
968         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
969         (LinuxFirefoxDriver.launch_driver):
970         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
971         (OSXChromeDriver.launch_driver):
972         (OSXChromeCanaryDriver.launch_driver):
973         (create_chrome_options):
974         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
975         (OSXFirefoxDriver.launch_driver):
976         (OSXFirefoxNightlyDriver.launch_driver):
977         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
978         (OSXSafariDriver.launch_driver):
979         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
980         (WebDriverBenchmarkRunner._run_one_test):
981
982 2017-07-23  Darin Adler  <darin@apple.com>
983
984         More NeverDestroyed and related cleanup
985         https://bugs.webkit.org/show_bug.cgi?id=174745
986
987         Reviewed by Alex Christensen.
988
989         * DumpRenderTree/JavaScriptThreading.cpp:
990         (javaScriptThreadsMutex): Use NeverDestroyed instead of
991         DEPRECATED_DEFINE_STATIC_LOCAL.
992         (javaScriptThreads): Ditto.
993
994 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
995
996         Subclass Benchmark Runner script for WebDriver support
997         https://bugs.webkit.org/show_bug.cgi?id=174390
998
999         Reviewed by Dewei Zhu, Stephanie Lewis.
1000
1001         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1002
1003         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1004         (BenchmarkBuilder.__init__):
1005         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1006         (BenchmarkRunner.__init__):
1007         (BenchmarkRunner._find_plan_file):
1008         (BenchmarkRunner._run_one_test.and):
1009         (BenchmarkRunner.execute):
1010         (BenchmarkRunner._get_result): Deleted.
1011         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1012         (parse_args):
1013         (start):
1014         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1015         (WebDriverBenchmarkRunner):
1016         (WebDriverBenchmarkRunner._get_result):
1017         (WebDriverBenchmarkRunner._run_one_test):
1018         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1019         (WebServerBenchmarkRunner):
1020         (WebServerBenchmarkRunner.__init__):
1021         (WebServerBenchmarkRunner._get_result):
1022         (WebServerBenchmarkRunner._run_one_test):
1023
1024 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1025
1026         Add BenchmarkRunner patches with WebDriver support for each testing plan
1027         https://bugs.webkit.org/show_bug.cgi?id=174443
1028
1029         Reviewed by Dewei Zhu, Stephanie Lewis.
1030
1031         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1032         (BenchmarkBuilder.__enter__):
1033         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1034         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1035         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1036         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1037         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1038         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1039         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1040         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1041         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1042         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1043         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1044         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1045         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1046         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1047         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1048         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1049         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1050         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1051         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1052         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1053         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1054         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1055         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1056         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1057         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1058         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1059         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1060         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1061         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1062         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1063         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1064         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1065         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1066
1067 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1068
1069         Add functions to autoinstaller needed for Benchmark Runner script
1070         https://bugs.webkit.org/show_bug.cgi?id=174331
1071
1072         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1073
1074         Adds autoinstaller functions to install selenium and webdriver binaries
1075         which will be used by the browser driver part of Benchmark Runner.
1076
1077         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1078         (BrowserDriver.restore_env):
1079         (BrowserDriver):
1080         (BrowserDriver.get_webdriver_binary_path):
1081         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1082         (LinuxChromeDriver.launch_driver):
1083         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1084         (LinuxFirefoxDriver.launch_driver):
1085         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1086         (OSXChromeDriver.launch_driver):
1087         (OSXChromeCanaryDriver.launch_driver):
1088         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1089         (OSXFirefoxDriver.launch_driver):
1090         (OSXFirefoxNightlyDriver.launch_driver):
1091         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1092         * Scripts/webkitpy/benchmark_runner/utils.py:
1093         (get_driver_binary_path):
1094         * Scripts/webkitpy/common/system/autoinstall.py:
1095         (AutoInstaller._unzip):
1096         * Scripts/webkitpy/thirdparty/__init__.py:
1097         (AutoinstallImportHook.find_module):
1098         (AutoinstallImportHook._install_selenium):
1099         (AutoinstallImportHook):
1100         (AutoinstallImportHook._install_chromedriver):
1101         (AutoinstallImportHook._install_geckodriver):
1102         (AutoinstallImportHook.get_latest_pypi_url):
1103         (AutoinstallImportHook.install_binary):
1104         (autoinstall_everything):
1105         (get_driver_filename):
1106         (get_os_info):
1107
1108 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1109
1110         Add WebDriver support in browser driver part of BenchmarkRunner
1111         https://bugs.webkit.org/show_bug.cgi?id=174445
1112
1113         Reviewed by Stephanie Lewis.
1114
1115         Adds a launch_driver function to each BrowserDriver subclass. This
1116         function sets up the arguments for the webdriver and launches the
1117         webdriver specific to that browser.
1118
1119         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1120         (BrowserDriver.launch_webdriver):
1121         (BrowserDriver):
1122         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1123         (LinuxBrowserDriver.launch_webdriver):
1124         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1125         (LinuxChromeDriver.launch_url):
1126         (LinuxChromeDriver):
1127         (LinuxChromeDriver.launch_driver):
1128         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1129         (EpiphanyBrowserDriver.launch_url):
1130         (EpiphanyBrowserDriver):
1131         (EpiphanyBrowserDriver.launch_driver):
1132         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1133         (LinuxFirefoxDriver):
1134         (LinuxFirefoxDriver.launch_url):
1135         (LinuxFirefoxDriver.launch_driver):
1136         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1137         (GTKMiniBrowserDriver.launch_url):
1138         (GTKMiniBrowserDriver):
1139         (GTKMiniBrowserDriver.launch_driver):
1140         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1141         (OSXBrowserDriver._launch_webdriver):
1142         (OSXBrowserDriver):
1143         (OSXBrowserDriver._screen_size):
1144         (OSXBrowserDriver._insert_url):
1145         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1146         (OSXChromeDriver):
1147         (OSXChromeDriver.launch_url):
1148         (OSXChromeDriver.launch_driver):
1149         (OSXChromeCanaryDriver):
1150         (OSXChromeCanaryDriver.launch_url):
1151         (OSXChromeCanaryDriver.launch_driver):
1152         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1153         (OSXFirefoxDriver):
1154         (OSXFirefoxDriver.launch_url):
1155         (OSXFirefoxDriver.launch_driver):
1156         (OSXFirefoxNightlyDriver):
1157         (OSXFirefoxNightlyDriver.launch_url):
1158         (OSXFirefoxNightlyDriver.launch_driver):
1159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1160         (OSXSafariDriver.launch_driver):
1161
1162 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1163
1164         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1165         https://bugs.webkit.org/show_bug.cgi?id=174793
1166
1167         Reviewed by Tim Horton.
1168
1169         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1170         down. Without r219765, this test will dereference null and crash.
1171
1172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1173         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1174         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1175         (TEST):
1176
1177 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1178
1179         [Win] Implement Authentication dialog in MiniBrowser
1180         https://bugs.webkit.org/show_bug.cgi?id=174662
1181
1182         Reviewed by Alex Christensen.
1183
1184         * MiniBrowser/win/Common.cpp:
1185         (CustomUserAgent):
1186         (DisplayAuthDialog):
1187         (AuthDialogProc):
1188         * MiniBrowser/win/MiniBrowserLib.rc:
1189         * MiniBrowser/win/MiniBrowserLibResource.h:
1190         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1191         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1192
1193 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1194
1195         Handle case where line_numbers is None instead of an array of line numbers
1196         https://bugs.webkit.org/show_bug.cgi?id=174775
1197
1198         Reviewed by Aakash Jain.
1199
1200         Added files set line_numbers to None in process_file.
1201
1202         * Scripts/webkitpy/style/filereader.py:
1203         (TextFileReader.process_file): Handle case where line_number is set to None.
1204         * Scripts/webkitpy/style/main_unittest.py:
1205         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1206
1207 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1208
1209         [WPE] Add libepoxy to the Jhbuild moduleset
1210         https://bugs.webkit.org/show_bug.cgi?id=174711
1211
1212         Reviewed by Carlos Alberto Lopez Perez.
1213
1214         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1215
1216 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1217
1218         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1219         https://bugs.webkit.org/show_bug.cgi?id=174780
1220
1221         Reviewed by Carlos Garcia Campos.
1222
1223         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1224         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1225         in case the eglplatform.h header doesn't provide that macro. This replicates
1226         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1227
1228 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1229
1230         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1231         https://bugs.webkit.org/show_bug.cgi?id=174758
1232
1233         Reviewed by Dan Bernstein.
1234
1235         Migrate position-information-related unit tests from the PositionInformationTests suite to
1236         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1237
1238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1240         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1241         (TestWebKitAPI::TEST):
1242         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1243         * TestWebKitAPI/cocoa/TestWKWebView.h:
1244         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1245         (-[TestWKWebView activatedElementAtPosition:]):
1246
1247 2017-07-22  Chris Dumez  <cdumez@apple.com>
1248
1249         REGRESSION(r204565): WKObject is broken
1250         https://bugs.webkit.org/show_bug.cgi?id=174736
1251         <rdar://problem/33246169>
1252
1253         Reviewed by Dan Bernstein.
1254
1255         Add API test that used to crash.
1256
1257         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1258         (TestWebKitAPI::TEST):
1259
1260 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1261
1262         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1263         https://bugs.webkit.org/show_bug.cgi?id=174705
1264
1265         Reviewed by Mark Lam.
1266
1267         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1268         (TestWebKitAPI::testThreadGroup):
1269         (TestWebKitAPI::TEST):
1270
1271 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1272
1273         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1274         https://bugs.webkit.org/show_bug.cgi?id=174724
1275
1276         Reviewed by Aakash Jain.
1277
1278         * Scripts/webkitpy/port/ios_simulator.py:
1279         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1280         simulator. Errors here should be treated the same as no simulators found.
1281
1282 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1283
1284         [CMake] Add an option to stop build after generating project files
1285         https://bugs.webkit.org/show_bug.cgi?id=174664
1286
1287         Reviewed by Konstantin Tokarev.
1288
1289         Add "--generate-project-only" to stop build after generating project files.
1290
1291         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1292         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1293         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1294         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1295         (isGenerateProjectOnly): ditto
1296
1297 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1298
1299         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1300         https://bugs.webkit.org/show_bug.cgi?id=174501
1301
1302         Reviewed by Darin Adler.
1303
1304         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1305         (TestWebKitAPI::TEST):
1306
1307 2017-07-20  David Quesada  <david_quesada@apple.com>
1308
1309         Add SPI to notify WKNavigationDelegate about client redirects
1310         https://bugs.webkit.org/show_bug.cgi?id=174680
1311         rdar://problem/33184886
1312
1313         Reviewed by Brady Eidson.
1314
1315         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1316         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1317         (TEST):
1318         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1319
1320 2017-07-20  Brady Eidson  <beidson@apple.com>
1321
1322         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1323         https://bugs.webkit.org/show_bug.cgi?id=174685
1324
1325         Reviewed by Andy Estes.
1326
1327         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1328         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1329
1330 2017-07-20  Brady Eidson  <beidson@apple.com>
1331
1332         Deprecate WebIconDatabase in WebKitLegacy/mac.
1333         https://bugs.webkit.org/show_bug.cgi?id=174607
1334
1335         Reviewed by Alex Christensen.
1336
1337         * DumpRenderTree/mac/TestRunnerMac.mm:
1338
1339 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1340
1341         lint-test-expectations should be run during style checking
1342         https://bugs.webkit.org/show_bug.cgi?id=173559
1343         <rdar://problem/32854941>
1344
1345         Reviewed by Aakash Jain.
1346
1347         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1348         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1349         prevents identifying errors on specific lines in a file.
1350         * Scripts/webkitpy/style/main_unittest.py:
1351         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1352         case where a linter error is in the file modified, but the line modified is not related to
1353         the linter error.
1354
1355 2017-07-20  Brady Eidson  <beidson@apple.com>
1356
1357         Remove WebIconDatabase from WebKitLegacy/win.
1358         https://bugs.webkit.org/show_bug.cgi?id=174608
1359
1360         Reviewed by Alex Christensen.
1361
1362         * DumpRenderTree/win/DumpRenderTree.cpp:
1363         (main):
1364         * DumpRenderTree/win/TestRunnerWin.cpp:
1365         (TestRunner::setIconDatabaseEnabled):
1366
1367 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1368
1369         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1370         https://bugs.webkit.org/show_bug.cgi?id=174671
1371
1372         Reviewed by Carlos Garcia Campos.
1373
1374         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1375         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1376         priority for this source in order to have it dispatched on the same
1377         priority as the other WebKit-controlled GSource objects.
1378
1379 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1380
1381         lint-test-expectations should be run during style checking
1382         https://bugs.webkit.org/show_bug.cgi?id=173559
1383         <rdar://problem/32854941>
1384
1385         Reviewed by Daniel Bates.
1386
1387         Follow up fix addressing style and a few minor bugs.
1388
1389         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1390         (TestExpectationParser.__init__): Use lambda x: x instead of str
1391         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1392         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1393         reduce the calls of _shorten_filename, fix minor bug in appending the current
1394         expectation's line number instead of the previous ones, clarify treatment of None
1395         in file-to-line-number mapping.
1396         (TestExpectations._report_warnings): Collapse call.
1397         * Scripts/webkitpy/style/checkers/test_expectations.py:
1398         (TestExpectationsChecker.lint_test_expectations):
1399         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1400         (TextFileReader.process_file): Add comment explaining treatment of None in
1401         file-to-line-number mapping.
1402         (TextFileReader.delete_file): Collapse call.
1403
1404 2017-07-19  Chris Dumez  <cdumez@apple.com>
1405
1406         Unreviewed attempt to fix API test failure after r219663.
1407
1408         The test was hard-coding an exception string and the string has changed slightly
1409         in r219663.
1410
1411         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1412         (TEST):
1413
1414 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1415
1416         Don't write file URLs to iOS Pasteboard
1417         https://bugs.webkit.org/show_bug.cgi?id=174647
1418         <rdar://problem/33199730>
1419
1420         Reviewed by Wenson Hsieh.
1421
1422         Updating tests to reflect the lack of file URLs for images.
1423
1424         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1425         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1426         (checkEstimatedSize):
1427         (TestWebKitAPI::TEST):
1428
1429 2017-07-19  Brady Eidson  <beidson@apple.com>
1430
1431         iBooks sometimes crashes when closing a book.
1432         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1433
1434         Reviewed by Oliver Hunt.
1435
1436         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1437         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1438         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1439         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1440         (TestWebKitAPI::TEST):
1441
1442         Add a "spin the runloop X number of times" utility:
1443         * TestWebKitAPI/Utilities.h:
1444         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1445         (TestWebKitAPI::Util::spinRunLoop):
1446
1447 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1448
1449         lint-test-expectations should be run during style checking
1450         https://bugs.webkit.org/show_bug.cgi?id=173559
1451         <rdar://problem/32854941>
1452
1453         Reviewed by David Kilzer.
1454
1455         Running the test expectation linter requires reading both files and lines not in the
1456         patch because, for example, deletion of a test can cause a lint failure even though
1457         no test expectations where modified. This means that the linter will occasionally warn
1458         about lines which were not changed in a given patch but whose error is related to a
1459         change made in that patch.
1460
1461         * Scripts/webkitpy/common/system/filesystem_mock.py:
1462         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1463         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1464         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1465         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1466         content, description of the error and the name of the associated test.
1467         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1468         (TestExpectationParser.__init__): Pass shorten_filename function to
1469         TestExpectationsParser to add a deleted file to the related_files dictionary.
1470         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1471         missing path to the related_files dictionary.
1472         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1473         files and line numbers related to this test expectation line. This will allow
1474         tracking linter errors in the style checker occurring across multiple files.
1475         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1476         lines to related_files dictionary.
1477         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1478         (TestExpectations._report_warnings): Construct warning object instead of string
1479         when adding to warnings list.
1480         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1481         clean-up log.
1482         * Scripts/webkitpy/style/checker.py:
1483         (ProcessorBase.do_association_check): Add required function for processor classes.
1484         (StyleProcessor):
1485         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1486         checking for errors between associated files.
1487         * Scripts/webkitpy/style/checkers/test_expectations.py:
1488         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1489         (TestExpectationsChecker):
1490         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1491         of modified files, the current working directory and the host, determine if the linter
1492         warning is associated with the changes.
1493         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1494         style checker.
1495         * Scripts/webkitpy/style/filereader.py:
1496         (TextFileReader):
1497         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1498         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1499         (TextFileReader.process_file): Track both the number of files changed and which lines
1500         in those files were changed.
1501         (TextFileReader.do_association_check): Run the processor's association check on all
1502         modified or deleted files processed by TextFileReader.
1503         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1504         (TextFileReader.count_delete_only_file): Deleted.
1505         * Scripts/webkitpy/style/filereader_unittest.py:
1506         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1507         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1508         * Scripts/webkitpy/style/main.py:
1509         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1510         explicitly run the association check on the file reader.
1511         * Scripts/webkitpy/style/main_unittest.py:
1512         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1513         embedded in the style checker.
1514         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1515         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1516         construct the TextFileReader object with a StyleProcessor used to run style checks on
1517         specific files.
1518         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1519         testing the test expectation linter inside the style checker. This host must contain a
1520         mock file system with the basic structure of test expectations.
1521         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1522         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1523         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1524         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1525         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1526         * Scripts/webkitpy/style/patchreader.py:
1527         (PatchReader.check): Specify which file was deleted, run the association check.
1528         * Scripts/webkitpy/style/patchreader_unittest.py:
1529         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1530         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1531         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1532
1533 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1534
1535         [WTF] Implement WTF::ThreadGroup
1536         https://bugs.webkit.org/show_bug.cgi?id=174081
1537
1538         Reviewed by Mark Lam.
1539
1540         Add WTF::ThreadGroup tests.
1541
1542         * TestWebKitAPI/CMakeLists.txt:
1543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1544         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1545         (TestWebKitAPI::testThreadGroup):
1546         (TestWebKitAPI::TEST):
1547
1548 2017-07-18  Andy Estes  <aestes@apple.com>
1549
1550         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1551         https://bugs.webkit.org/show_bug.cgi?id=174631
1552
1553         Reviewed by Tim Horton.
1554
1555         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1556         * MiniBrowser/Configurations/Base.xcconfig:
1557         * MobileMiniBrowser/Configurations/Base.xcconfig:
1558         * TestWebKitAPI/Configurations/Base.xcconfig:
1559         * WebKitTestRunner/Configurations/Base.xcconfig:
1560
1561 2017-07-18  Andy Estes  <aestes@apple.com>
1562
1563         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1564         https://bugs.webkit.org/show_bug.cgi?id=174631
1565
1566         Reviewed by Sam Weinig.
1567
1568         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1569         * MiniBrowser/Configurations/Base.xcconfig:
1570         * MobileMiniBrowser/Configurations/Base.xcconfig:
1571         * TestWebKitAPI/Configurations/Base.xcconfig:
1572         * WebKitTestRunner/Configurations/Base.xcconfig:
1573
1574 2017-07-18  Daniel Bates  <dabates@apple.com>
1575
1576         lldb: Add type summary for StringView
1577         https://bugs.webkit.org/show_bug.cgi?id=174637
1578
1579         Reviewed by Sam Weinig.
1580
1581         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1582         StringView object will print output that has the form:
1583
1584             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1585               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1586               m_length = 2
1587               m_is8Bit = true
1588               m_underlyingString = 0x0000614000000a90
1589             }
1590
1591         * lldb/lldb_webkit.py:
1592         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1593         (WTFStringView_SummaryProvider):
1594         (WTFStringViewProvider):
1595         (WTFStringViewProvider.__init__):
1596         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1597         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1598         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1599         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1600
1601 2017-07-18  Andy Estes  <aestes@apple.com>
1602
1603         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1604         https://bugs.webkit.org/show_bug.cgi?id=174631
1605
1606         Reviewed by Dan Bernstein.
1607
1608         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1609         * MiniBrowser/Configurations/Base.xcconfig:
1610         * MobileMiniBrowser/Configurations/Base.xcconfig:
1611         * TestWebKitAPI/Configurations/Base.xcconfig:
1612         * WebKitTestRunner/Configurations/Base.xcconfig:
1613
1614 2017-07-18  Devin Rousso  <drousso@apple.com>
1615
1616         Web Inspector: Add memoryCost to Inspector Protocol objects
1617         https://bugs.webkit.org/show_bug.cgi?id=174478
1618
1619         Reviewed by Joseph Pecoraro.
1620
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1623         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1624         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1625         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1626         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1627         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1628         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1629         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1630         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1631         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1632         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1633         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1634         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1635         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1636         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1637         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1638
1639 2017-07-18  Andy Estes  <aestes@apple.com>
1640
1641         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1642         https://bugs.webkit.org/show_bug.cgi?id=174631
1643
1644         Reviewed by Darin Adler.
1645
1646         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1647         * MiniBrowser/Configurations/Base.xcconfig:
1648         * MobileMiniBrowser/Configurations/Base.xcconfig:
1649         * TestWebKitAPI/Configurations/Base.xcconfig:
1650         * WebKitTestRunner/Configurations/Base.xcconfig:
1651
1652 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1653
1654         Unreviewed, fix the iOS build.
1655
1656         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1657
1658         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1659         (TestWebKitAPI::TEST):
1660
1661 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1662
1663         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1664         https://bugs.webkit.org/show_bug.cgi?id=174585
1665         <rdar://problem/33302541>
1666
1667         Reviewed by Tim Horton.
1668
1669         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1670         being dragged when initiating a drag.
1671
1672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1673         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1674         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1675         (TestWebKitAPI::TEST):
1676         * TestWebKitAPI/cocoa/TestWKWebView.h:
1677
1678         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1679
1680         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1681         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1682
1683 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1684
1685         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1686         https://bugs.webkit.org/show_bug.cgi?id=174547
1687
1688         Reviewed by Alex Christensen.
1689
1690         * DumpRenderTree/PlatformWin.cmake:
1691         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1692
1693 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1694
1695         Update style checker to deal with "final"
1696         https://bugs.webkit.org/show_bug.cgi?id=174528
1697
1698         Reviewed by Alex Christensen.
1699         
1700         check-webkit-style shouldn't complain about an open brace to start a
1701         line after a function definition with "final" or "const final".
1702
1703         * Scripts/webkitpy/style/checkers/cpp.py:
1704         (check_braces):
1705         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1706         (CppStyleTest.test_brace_at_begin_of_line):
1707
1708 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1709
1710         Modernize content extension code
1711         https://bugs.webkit.org/show_bug.cgi?id=174588
1712
1713         Reviewed by Sam Weinig.
1714
1715         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1716         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1717         (TestWebKitAPI::testRequest):
1718         (TestWebKitAPI::makeBackend):
1719         (TestWebKitAPI::TEST_F):
1720
1721 2017-07-17  Brady Eidson  <beidson@apple.com>
1722
1723         WKHTTPCookieStore observing only works on the default cookie store.
1724         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1725
1726         Reviewed by Sam Weinig.
1727
1728         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1729         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1730           called for the default store, a non-persistent store, and a custom store.
1731         (TEST):
1732
1733 2017-07-16  Sam Weinig  <sam@webkit.org>
1734
1735         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1736         https://bugs.webkit.org/show_bug.cgi?id=174575
1737
1738         Reviewed by Brady Eidson.
1739
1740         * Scripts/svn-create-patch:
1741         (findModificationType):
1742         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1743         default value of "unknown".
1744
1745         (generateFileList):
1746         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1747         for untracked, which matches our old behavior.
1748
1749 2017-07-17  Charlie Turner  <cturner@igalia.com>
1750
1751         Add some missing build dependencies on Fedora
1752         https://bugs.webkit.org/show_bug.cgi?id=174578
1753
1754         Unreviewed dependency update.
1755
1756         * gtk/install-dependencies:
1757
1758 2017-07-16  Brady Eidson  <beidson@apple.com>
1759
1760         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1761         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1762
1763         Reviewed by Tim Horton.
1764
1765         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1766         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1767         (TEST):
1768
1769 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1770
1771         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1772         https://bugs.webkit.org/show_bug.cgi?id=174540
1773
1774         Reviewed by Michael Catanzaro.
1775
1776         * gtk/generate-inspector-gresource-manifest.py:
1777         (get_filenames): sort list of input files
1778
1779 2017-07-15  Brady Eidson  <beidson@apple.com>
1780
1781         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1782         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1783
1784         Reviewed by Tim Horton.
1785
1786         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1787         (TEST): Make this test more reliable by clearing everything beforehand.
1788
1789 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1790
1791         Make it possible to extend check-webkit-style with Apple-internal checkers
1792         <https://webkit.org/b/174464>
1793         <rdar://problem/25564402>
1794
1795         Reviewed by Darin Adler.
1796
1797         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1798         (_all_categories): Add categories from apple_additions() if it
1799         exists.
1800         (CheckerDispatcher._create_checker): Create python checker
1801         from apple_additions() if it exists.
1802
1803 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1804
1805         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1806         https://bugs.webkit.org/show_bug.cgi?id=174539
1807         <rdar://problem/33307395>
1808
1809         Reviewed by Darin Adler.
1810
1811         Adds a new unit test suite to cover action sheet popover presentation.
1812
1813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1814         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1815         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1816         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1817
1818         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1819
1820         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1821         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1822
1823         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1824
1825         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1826         (TestWebKitAPI::TEST):
1827
1828 2017-07-15  Sam Weinig  <sam@webkit.org>
1829
1830         [Scripts] Make svn-create-patch work better when called in sub directories
1831         https://bugs.webkit.org/show_bug.cgi?id=174551
1832
1833         Reviewed by Darin Adler.
1834
1835         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1836           by ensuring that the prefix is applied as is done in generateDiff.
1837         - Silence output of explanatory lines from svn stat (" > move to ...")
1838           that show up in STDERR when running svn-create-patch.
1839         - Add verbose logging that I found useful while debugging this issue.
1840
1841         * Scripts/svn-create-patch:
1842         (findBaseUrl):
1843         (findMimeType):
1844         (findSourceFileAndRevision):
1845         (generateDiff):
1846         (generateFileList):
1847         (manufacturePatchForAdditionWithHistory):
1848
1849 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1850
1851         Unreviewed build fix after r219537.
1852
1853         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1854
1855 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1856
1857         Add iOS 11 SPI
1858         https://bugs.webkit.org/show_bug.cgi?id=174430
1859         <rdar://problem/33269288>
1860
1861         Reviewed by Tim Horton.
1862
1863         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1864         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1865         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1866
1867 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1868
1869         Failing to install on iPad simulators
1870         https://bugs.webkit.org/show_bug.cgi?id=174532
1871         <rdar://problem/33328347>
1872
1873         Reviewed by Stephanie Lewis.
1874
1875         * Scripts/webkitpy/xcode/simulated_device.py:
1876         (SimulatedDevice.install_app): Place install command in retry try-except block.
1877
1878 2017-07-14  Jeff Miller  <jeffm@apple.com>
1879
1880         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1881         https://bugs.webkit.org/show_bug.cgi?id=174524
1882
1883         Reviewed by Sam Weinig.
1884
1885         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1886         (TEST):
1887         Renamed TestParameter to TestParameter1.
1888         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1889
1890         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1891         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1892         Observe changes for two bundle parameters.
1893
1894         (-[BundleParametersPlugIn dealloc]):
1895         Remove observers for two bundle parameters.
1896
1897 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1898
1899         Unreviewed, rolling out r219510.
1900         https://bugs.webkit.org/show_bug.cgi?id=174525
1901
1902         Need to revert length() == 0 check for null string (Requested
1903         by yusukesuzuki on #webkit).
1904
1905         Reverted changeset:
1906
1907         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1908         static string if StringImpl is static"
1909         https://bugs.webkit.org/show_bug.cgi?id=174501
1910         http://trac.webkit.org/changeset/219510
1911
1912 2017-07-14  Jer Noble  <jer.noble@apple.com>
1913
1914         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1915         https://bugs.webkit.org/show_bug.cgi?id=174514
1916
1917         Reviewed by Sam Weinig.
1918
1919         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1920         (TestWebKitAPI::TEST_F):
1921
1922 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1923
1924         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1925         https://bugs.webkit.org/show_bug.cgi?id=174501
1926
1927         Reviewed by Darin Adler.
1928
1929         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1930         (TestWebKitAPI::TEST):
1931
1932 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1933
1934         Bring mac expectations in-line with other platforms
1935         https://bugs.webkit.org/show_bug.cgi?id=174472
1936         <rdar://problem/33297388>
1937
1938         Reviewed by David Kilzer.
1939
1940         The override order for Mac test expectations does not conform to the pattern used by iOS,
1941         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1942
1943             platform/mac-wk2
1944             platform/wk2
1945             platform/mac-elcapitan
1946             platform/mac-sierra
1947             generic
1948
1949         After this change, El Capitan's baseline search path looks like this:
1950
1951             platform/mac-sierra-wk2
1952             platform/mac-sierra
1953             platform/mac-wk2
1954             platform/wk2
1955             generic
1956
1957         * Scripts/webkitpy/port/mac.py:
1958         (MacPort.__init__): If a specific version is specified in the port name, use that
1959         as the os version.
1960         (MacPort.default_baseline_search_path): Expectation search paths should work the
1961         same way they do on other ports. Port + version overrides port, port overrides generic
1962         and wk1/wk2 should override expectations for the two combined.
1963         * Scripts/webkitpy/port/mac_unittest.py:
1964         (MacTest.test_tests_for_other_platforms): Deleted.
1965         (MacTest._assert_search_path): Deleted.
1966         (MacTest.test_baseline_search_path): Deleted.
1967         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1968         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1969         (test_rebaseline_test_and_print_scm_changes): Ditto.
1970         (test_rebaseline_and_copy_test): Ditto.
1971         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1972         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1973         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1974
1975 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1976
1977         Fix style checker unit test
1978
1979         Unreviewed WebKit2 => WebKit fixup.
1980
1981         * Scripts/webkitpy/style/checker_unittest.py:
1982         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1983
1984 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1985
1986         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1987
1988         Unreviewed build fix.
1989
1990         r219492 missed one hunk from its partial revert of r219489.
1991         This patch reverts that hunk.
1992
1993         * TestWebKitAPI/CMakeLists.txt:
1994
1995 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1996
1997         Use the old WebKit/WebKit2 targets for CMake builds.
1998
1999         Unreviewed build fix.
2000
2001         We can update the target names to match the Framework names in a future patch.
2002         This is a partial revert of r219489.
2003
2004         * TestWebKitAPI/CMakeLists.txt:
2005         WebKitLegacy => WebKit
2006         WebKit => WebKit2
2007
2008 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2009
2010         Fix TestWebKit API.
2011         https://bugs.webkit.org/show_bug.cgi?id=174164
2012         rdar://problem/33137595
2013
2014         Reviewed by Dan Bernstein.
2015
2016         * TestWebKitAPI/CMakeLists.txt:
2017         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2018         * TestWebKitAPI/PlatformGTK.cmake:
2019
2020 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2021
2022         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2023         https://bugs.webkit.org/show_bug.cgi?id=174164
2024         rdar://problem/33137595
2025
2026         Reviewed by Dan Bernstein.
2027
2028         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2029         (ShouldBuildTest):
2030         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2031         * Scripts/build-webkit:
2032         * Scripts/do-file-rename:
2033         * Scripts/do-webcore-rename:
2034         * Scripts/update-webkit-localizable-strings:
2035         * Scripts/webkitpy/common/config/watchlist:
2036         * Scripts/webkitpy/style/checker.py:
2037         * Scripts/webkitpy/style/checkers/featuredefines.py:
2038         * gtk/make-dist.py:
2039         (ensure_version_if_possible):
2040         * gtk/manifest.txt.in:
2041
2042 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2043
2044         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2045         https://bugs.webkit.org/show_bug.cgi?id=174162
2046         rdar://problem/33137594
2047
2048         Reviewed by Dan Bernstein.
2049
2050         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2051
2052         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2053         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2054         * EWSTools/configure-clang-linux.sh:
2055         * Scripts/build-webkit:
2056         * Scripts/do-file-rename:
2057         * Scripts/do-webcore-rename:
2058         * Scripts/update-webkit-localizable-strings:
2059         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2060         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2061         * Scripts/webkitpy/style/checkers/featuredefines.py:
2062         * gtk/manifest.txt.in:
2063
2064 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2065
2066         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2067         https://bugs.webkit.org/show_bug.cgi?id=174438
2068         <rdar://problem/33277112>
2069
2070         Reviewed by Aakash Jain.
2071
2072         Given a patch, this will convert the changes from the path to the new directory structure.
2073
2074         * Scripts/rebase-patch-after-webkit-move: Added.
2075         (append_source): Append 'Source' to the provided path.
2076         (is_editable_line): Return true if a line the script expects to modify.
2077         (needs_rebase): Return if a line needs to be rebased based on it's content.
2078         (rebase_line): Rebase the provided line.
2079         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2080         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2081         were provided.
2082
2083 2017-07-12  Nan Wang  <n_wang@apple.com>
2084
2085         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2086         https://bugs.webkit.org/show_bug.cgi?id=174393
2087         <rdar://problem/33248006>
2088
2089         Reviewed by Chris Fleizach.
2090
2091         * DumpRenderTree/AccessibilityUIElement.cpp:
2092         (textMarkerRangeMatchesTextNearMarkersCallback):
2093         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2094         (AccessibilityUIElement::getJSClass):
2095         * DumpRenderTree/AccessibilityUIElement.h:
2096         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2097         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2098         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2099         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2100         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2101         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2102         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2103         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2104
2105 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2106
2107         Unreviewed, rolling out r219409.
2108
2109         The revision caused the Windows builds to fail.
2110
2111         Reverted changeset:
2112
2113         "AX: [iOS] Implement a way to retrieve a text marker range
2114         with desired text that is closest to a position"
2115         https://bugs.webkit.org/show_bug.cgi?id=174393
2116         http://trac.webkit.org/changeset/219409
2117
2118 2017-07-12  Nan Wang  <n_wang@apple.com>
2119
2120         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2121         https://bugs.webkit.org/show_bug.cgi?id=174393
2122         <rdar://problem/33248006>
2123
2124         Reviewed by Chris Fleizach.
2125
2126         * DumpRenderTree/AccessibilityUIElement.cpp:
2127         (textMarkerRangeMatchesTextNearMarkersCallback):
2128         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2129         (AccessibilityUIElement::getJSClass):
2130         * DumpRenderTree/AccessibilityUIElement.h:
2131         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2132         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2133         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2134         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2135         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2136         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2137         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2138         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2139
2140 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2141
2142         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2143         https://bugs.webkit.org/show_bug.cgi?id=174197
2144
2145         Reviewed by Darin Adler.
2146
2147         This bit me the first time I tried to submit a patch to WebKit, and still I have
2148         to manually edit the ChangeLog every time I use the script.
2149
2150         This generates a more convenient and standard ChangeLog entry.
2151
2152         * Scripts/prepare-ChangeLog:
2153         (generateNewChangeLogs):
2154
2155 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2156
2157         Unreviewed, rolling out r219401.
2158
2159         This revision rolled out the previous patch, but after talking
2160         with reviewer, a rebaseline is what was needed.Rolling back in
2161         before rebaseline.
2162
2163         Reverted changeset:
2164
2165         "Unreviewed, rolling out r219379."
2166         https://bugs.webkit.org/show_bug.cgi?id=174400
2167         http://trac.webkit.org/changeset/219401
2168
2169 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2170
2171         Unreviewed, rolling out r219379.
2172
2173         This revision caused a consistent failure in the test
2174         fast/dom/Window/property-access-on-cached-window-after-frame-
2175         removed.html.
2176
2177         Reverted changeset:
2178
2179         "Remove NAVIGATOR_HWCONCURRENCY"
2180         https://bugs.webkit.org/show_bug.cgi?id=174400
2181         http://trac.webkit.org/changeset/219379
2182
2183 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2184
2185         [WPE] Use libepoxy
2186         https://bugs.webkit.org/show_bug.cgi?id=172104
2187
2188         Reviewed by Michael Catanzaro.
2189
2190         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2191         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2192
2193 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2194
2195         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2196         https://bugs.webkit.org/show_bug.cgi?id=174363
2197
2198         Reviewed by Michael Catanzaro.
2199
2200         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2201         between the GTK+ and WPE port. There's no reason for the two ports to apply
2202         different patches over same versions of GStreamer releases.
2203
2204         This aligns the two ports on this specific issue. Next we'll look into
2205         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2206         to keep these patches in a single place, avoiding duplicate files.
2207
2208         * gtk/jhbuild.modules:
2209         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2210         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2211         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2212         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2213
2214 2017-07-11  Dean Jackson  <dino@apple.com>
2215
2216         Remove NAVIGATOR_HWCONCURRENCY
2217         https://bugs.webkit.org/show_bug.cgi?id=174400
2218
2219         Reviewed by Sam Weinig.
2220
2221         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2222
2223 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2224
2225         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2226         https://bugs.webkit.org/show_bug.cgi?id=174239
2227
2228         Reviewed by Brady Eidson.
2229
2230         Create windows with specific features set and make sure those are properly reflected in the
2231         WKWindowFeatures object.
2232
2233         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2234         (resetToConsistentState):
2235         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2236         (TEST):
2237
2238 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2239
2240         Do not duplicate files when deleting directories with svn 1.9
2241         https://bugs.webkit.org/show_bug.cgi?id=174339
2242         <rdar://problem/33226781>
2243
2244         Reviewed by David Kilzer.
2245
2246         * Scripts/svn-create-patch:
2247         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2248         (generateFileList): Determine which files are deleted because they are part of a
2249         directory being deleted.
2250
2251 2017-07-11  Dean Jackson  <dino@apple.com>
2252
2253         Rolling out r219372.
2254
2255         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2256
2257 2017-07-11  Dean Jackson  <dino@apple.com>
2258
2259         Remove NAVIGATOR_HWCONCURRENCY
2260         https://bugs.webkit.org/show_bug.cgi?id=174400
2261
2262         Reviewed by Sam Weinig.
2263
2264         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2265
2266 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2267
2268         Teach build workers to fetch archives from S3.
2269         https://bugs.webkit.org/show_bug.cgi?id=174384
2270
2271         Reviewed by Aakash Jain.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2274         (DownloadBuiltProduct):
2275
2276 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2277
2278         Configure buildbot to transfer all archives to S3.
2279         Previously this was Mac only, but it's time to expand!
2280         https://bugs.webkit.org/show_bug.cgi?id=174378
2281         
2282         Reviewed by Aakash Jain.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2285         (BuildFactory.__init__):
2286
2287 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2288
2289         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2290         https://bugs.webkit.org/show_bug.cgi?id=174350
2291
2292         Reviewed by Xabier Rodriguez-Calvar.
2293
2294         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2295         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2296         patches are removed. The patches for gst-plugins-good are updated, removing
2297         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2298         rtpbin elements that will help with the EMEv3 development.
2299
2300         * wpe/jhbuild.modules:
2301         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2302         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2303         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2304         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2305         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2306         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2307         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2308         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2309         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2310
2311 2017-07-10  John Wilander  <wilander@apple.com>
2312
2313         Resource Load Statistics: Prune statistics in orders of importance
2314         https://bugs.webkit.org/show_bug.cgi?id=174215
2315         <rdar://problem/33164403>
2316
2317         Reviewed by Chris Dumez.
2318
2319         Nest infrastructure. Adds these functions:
2320         1. testRunner.setStatisticsLastSeen()
2321         2. setStatisticsMaxStatisticsEntries()
2322         3. setStatisticsPruneEntriesDownTo()
2323
2324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2326         (WTR::TestRunner::setStatisticsLastSeen):
2327         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2328         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2329         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2330         * WebKitTestRunner/TestController.cpp:
2331         (WTR::TestController::setStatisticsLastSeen):
2332         (WTR::TestController::setMaxStatisticsEntries):
2333         (WTR::TestController::setPruneEntriesDownTo):
2334         * WebKitTestRunner/TestController.h:
2335         * WebKitTestRunner/TestInvocation.cpp:
2336         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2337         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2338         (WTR::TestController::setStatisticsLastSeen):
2339         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2340         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2341
2342 2017-07-03  Brian Burg  <bburg@apple.com>
2343
2344         Web Replay: remove some unused code
2345         https://bugs.webkit.org/show_bug.cgi?id=173903
2346
2347         Rubber-stamped by Joseph Pecoraro.
2348
2349         * Scripts/run-input-generator-tests: Removed.
2350         * Scripts/webkitpy/replay/__init__.py: Removed.
2351         * Scripts/webkitpy/replay/main.py: Removed.
2352
2353 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2354
2355         [WPE] Fix layout test baseline and TestExpectations hierarchy
2356         https://bugs.webkit.org/show_bug.cgi?id=174092
2357
2358         Reviewed by Michael Catanzaro.
2359
2360         Like for the GTK+ port, override the default_baseline_search_path() and
2361         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2362         Both methods operate on a short list of search paths that defaults to 'wpe' and
2363         'wk2', along with any other user-specified platform directory.
2364
2365         The test_expectations_file_position() method is overridden for testing purposes,
2366         and relevant unit tests are added.
2367
2368         * Scripts/webkitpy/port/wpe.py:
2369         (WPEPort._search_paths):
2370         (WPEPort):
2371         (WPEPort.default_baseline_search_path):
2372         (WPEPort._port_specific_expectations_files):
2373         (WPEPort.test_expectations_file_position):
2374         * Scripts/webkitpy/port/wpe_unittest.py:
2375         (WPEPortTest.test_default_baseline_search_path):
2376         (WPEPortTest):
2377         (WPEPortTest.test_port_specific_expectations_files):
2378
2379 2017-07-10  Chris Dumez  <cdumez@apple.com>
2380
2381         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2382         https://bugs.webkit.org/show_bug.cgi?id=174301
2383
2384         Reviewed by Brent Fulgham.
2385
2386         Rename some of the testRunner API for clarity and to better match what it calls
2387         internally.
2388
2389         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2390         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2391         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2392         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::TestController::statisticsUpdateCookiePartitioning):
2396         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2397         * WebKitTestRunner/TestController.h:
2398         * WebKitTestRunner/TestInvocation.cpp:
2399         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2400         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2401         (WTR::TestController::statisticsUpdateCookiePartitioning):
2402         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2403
2404 2017-07-10  Charlie Turner  <cturner@igalia.com>
2405
2406         [GStreamer] Live twitch.tv videos do not play
2407         https://bugs.webkit.org/show_bug.cgi?id=174222
2408
2409         Reviewed by Michael Catanzaro.
2410
2411         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2412         fixes videos not playing on twitch.tv.
2413
2414         * gtk/jhbuild.modules:
2415
2416 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2417
2418         Add WebGL2 configuration option to build-webkit
2419         https://bugs.webkit.org/show_bug.cgi?id=174251
2420
2421         Reviewed by Michael Catanzaro.
2422
2423         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2424         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2425         is marked as enabled for the Apple Cocoa ports.
2426
2427 2017-07-08  Chris Dumez  <cdumez@apple.com>
2428
2429         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2430         https://bugs.webkit.org/show_bug.cgi?id=174290
2431
2432         Reviewed by Brent Fulgham.
2433
2434         Rename testRunner API to match the new internal API names.
2435
2436         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2438         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2439         (WTR::TestRunner::statisticsSubmitTelemetry):
2440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2441         * WebKitTestRunner/TestController.cpp:
2442         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2443         (WTR::TestController::statisticsSubmitTelemetry):
2444         * WebKitTestRunner/TestController.h:
2445         * WebKitTestRunner/TestInvocation.cpp:
2446         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2447         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2448         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2449         (WTR::TestController::statisticsSubmitTelemetry):
2450
2451 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2452
2453         Drop NOSNIFF compile flag
2454         https://bugs.webkit.org/show_bug.cgi?id=174289
2455
2456         Reviewed by Michael Catanzaro.
2457
2458         * Scripts/webkitperl/FeatureList.pm:
2459         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2460
2461 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2462
2463         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2464         https://bugs.webkit.org/show_bug.cgi?id=174219
2465         <rdar://problem/32083177>
2466
2467         Reviewed by Ryosuke Niwa.
2468
2469         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2470         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2471         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2472         place.
2473
2474         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2475         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2476         no action is taken when dropping.
2477
2478         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2479         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2480         (TestWebKitAPI::TEST):
2481         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2482         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2483         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2484         (-[MockDragDropSession allowsMoveOperation]):
2485         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2486         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2487         (-[DataInteractionSimulator initWithWebView:]):
2488         (-[DataInteractionSimulator runFrom:to:]):
2489         (-[DataInteractionSimulator _advanceProgress]):
2490         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2491         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2492         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2493
2494 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2495
2496         Unreviewed, rolling out r219238, r219239, and r219241.
2497         https://bugs.webkit.org/show_bug.cgi?id=174265
2498
2499         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2500         (Requested by yusukesuzuki on #webkit).
2501
2502         Reverted changesets:
2503
2504         "[WTF] Implement WTF::ThreadGroup"
2505         https://bugs.webkit.org/show_bug.cgi?id=174081
2506         http://trac.webkit.org/changeset/219238
2507
2508         "Unreviewed, build fix after r219238"
2509         https://bugs.webkit.org/show_bug.cgi?id=174081
2510         http://trac.webkit.org/changeset/219239
2511
2512         "Unreviewed, CLoop build fix after r219238"
2513         https://bugs.webkit.org/show_bug.cgi?id=174081
2514         http://trac.webkit.org/changeset/219241
2515
2516 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2517
2518         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2519         https://bugs.webkit.org/show_bug.cgi?id=174250
2520
2521         Reviewed by Carlos Alberto Lopez Perez.
2522
2523         * Scripts/webkitperl/FeatureList.pm:
2524
2525 2017-07-07  Charlie Turner  <cturner@igalia.com>
2526         [GStreamer] vid.me videos do not play
2527         https://bugs.webkit.org/show_bug.cgi?id=172240
2528
2529         Reviewed by Xabier Rodriguez-Calvar.
2530
2531         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2532         have the existing libsoup build against GNOME to avoid header drift
2533         against GStreamer's linked Soup library.
2534
2535         * gtk/jhbuild.modules:
2536
2537 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2538
2539         Write a support script to enable buildbot to upload to S3
2540         https://bugs.webkit.org/show_bug.cgi?id=174196
2541         
2542         Reviewed by Stephanie Lewis.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2545         (uploadToS3):
2546         (archiveExists):
2547
2548 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2549
2550         Enabling uploading archives to S3.
2551         https://bugs.webkit.org/show_bug.cgi?id=174198
2552         
2553         Reviewed by Stephanie Lewis.
2554
2555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2556         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2557         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2558         (TransferToS3): Transfer full and minified archives to S3
2559
2560 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2561
2562         [WTF] Implement WTF::ThreadGroup
2563         https://bugs.webkit.org/show_bug.cgi?id=174081
2564
2565         Reviewed by Mark Lam.
2566
2567         Add WTF::ThreadGroup tests.
2568
2569         * TestWebKitAPI/CMakeLists.txt:
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2572         (TestWebKitAPI::TEST):
2573
2574 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2575
2576         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2577         https://bugs.webkit.org/show_bug.cgi?id=174150
2578
2579         Reviewed by Mark Lam.
2580
2581         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2582         (TestWebKitAPI::TEST):
2583         * TestWebKitAPI/TestsController.cpp:
2584         (TestWebKitAPI::TestsController::TestsController):
2585
2586 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2587
2588         Enabling uploading archives to S3.
2589         https://bugs.webkit.org/show_bug.cgi?id=174198
2590         
2591         Reviewed by Lucas Forschler.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2594         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2595         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2596         (TransferToS3): Transfer full and minified archives to S3
2597
2598 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2599
2600         [GTK][WPE] kill-old-process should kill more webkit related process
2601         https://bugs.webkit.org/show_bug.cgi?id=174220
2602
2603         Reviewed by Michael Catanzaro.
2604
2605         Generate list of possible webkit-related process names and add
2606         them to the list of process to kill.
2607         Also update the possible system related process for GTK+/WPE.
2608
2609         * BuildSlaveSupport/kill-old-processes:
2610         (listAllWebKitPrograms):
2611         (main):
2612
2613 2017-07-06  Chris Dumez  <cdumez@apple.com>
2614
2615         FileMonitor should not be ref counted
2616         https://bugs.webkit.org/show_bug.cgi?id=174166
2617
2618         Reviewed by Brent Fulgham.
2619
2620         Update the API tests to reflect the API change.
2621
2622         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2623         (TestWebKitAPI::TEST_F):
2624
2625 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2626
2627         Unreviewed, rolling out r219194.
2628         https://bugs.webkit.org/show_bug.cgi?id=174207
2629
2630         it broke some layout tests (Requested by clopez on #webkit).
2631
2632         Reverted changeset:
2633
2634         "[GStreamer] vid.me videos do not play"
2635         https://bugs.webkit.org/show_bug.cgi?id=172240
2636         http://trac.webkit.org/changeset/219194
2637
2638 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2639
2640         Unreviewed, rolling out r219178.
2641
2642         This caused a consistent failure with the API test
2643         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2644
2645         Reverted changeset:
2646
2647         "[WTF] Clean up StringStatics.cpp by using
2648         LazyNeverDestroyed<> for Atoms"
2649         https://bugs.webkit.org/show_bug.cgi?id=174150
2650         http://trac.webkit.org/changeset/219178
2651
2652 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2653
2654         Add CWD to Perl library path (no longer the default since 5.26.0)
2655         https://bugs.webkit.org/show_bug.cgi?id=174200
2656
2657         Reviewed by Michael Catanzaro.
2658
2659         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2660         (SetupGitClone._get_username_and_email):
2661
2662 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2663
2664         Unreviewed, update my email address.
2665
2666         * Scripts/webkitpy/common/config/contributors.json:
2667
2668 2017-07-06  Charlie Turner  <cturner@igalia.com>
2669         [GStreamer] vid.me videos do not play
2670         https://bugs.webkit.org/show_bug.cgi?id=172240
2671
2672         Reviewed by Xabier Rodriguez-Calvar.
2673
2674         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2675         have the existing libsoup build against GNOME to avoid header drift
2676         against GStreamer's linked Soup library.
2677
2678         * gtk/jhbuild.modules:
2679
2680 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2681
2682         [WTF] Move SoftLinking.h into WTF
2683         https://bugs.webkit.org/show_bug.cgi?id=174000
2684
2685         Reviewed by Alex Christensen.
2686
2687         * DumpRenderTree/mac/TestRunnerMac.mm:
2688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2689         (test_primary_header):
2690         (ErrorCollector.__init__): Deleted.
2691         (ErrorCollector.__call__): Deleted.
2692         (ErrorCollector.results): Deleted.
2693         (ErrorCollector.result_list): Deleted.
2694         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2695         (MockIo.open): Deleted.
2696         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2697         (CppFunctionsTest.test_create_acronym): Deleted.
2698         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2699         (CppFunctionsTest.test_parameter): Deleted.
2700         (CppFunctionsTest.test_single_line_view): Deleted.
2701         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2702         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2703         (CppFunctionsTest.test_parameter_list): Deleted.
2704         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2705         (CppStyleTestBase.process_file_data): Deleted.
2706         (CppStyleTestBase.perform_lint): Deleted.
2707         (CppStyleTestBase.perform_single_line_lint): Deleted.
2708         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2709         (CppStyleTestBase.perform_language_rules_check): Deleted.
2710         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2711         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2712         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2713         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2714         (CppStyleTestBase.perform_header_guard_check): Deleted.
2715         (CppStyleTestBase.assert_lint): Deleted.
2716         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2717         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2718         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2719         (CppStyleTestBase.assert_language_rules_check): Deleted.
2720         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2721         (CppStyleTestBase.assert_header_guard): Deleted.
2722         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2723         (CppStyleTestBase.assert_positions_equal): Deleted.
2724         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2725         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2726         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2727         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2728         (FunctionDetectionTest.test_ignore_macros): Deleted.
2729         (FunctionDetectionTest.test_non_functions): Deleted.
2730         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2731         (FunctionDetectionTest.test_parameter_list): Deleted.
2732         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2733         (CppStyleTest.test_asm_lines_ignored): Deleted.
2734         (CppStyleTest.test_get_line_width): Deleted.
2735         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2736         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2737         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2738         (CppStyleTest.test_position): Deleted.
2739         (CppStyleTest.test_rfind_in_lines): Deleted.
2740         (CppStyleTest.test_close_expression): Deleted.
2741         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2742         (CppStyleTest.test_cstyle_cast): Deleted.
2743         (CppStyleTest.test_runtime_casting): Deleted.
2744         (CppStyleTest.test_runtime_selfinit): Deleted.
2745         (CppStyleTest.test_runtime_rtti): Deleted.
2746         (CppStyleTest.test_static_cast_readability): Deleted.
2747         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2748         (CppStyleTest.void): Deleted.
2749         (CppStyleTest.test_deprecated_cast): Deleted.
2750         (CppStyleTest.test_mock_method): Deleted.
2751         (CppStyleTest.test_sizeof_type): Deleted.
2752         (CppStyleTest.cases): Deleted.
2753         (CppStyleTest.for): Deleted.
2754         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2755         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2756         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2757         (CppStyleTest.test_include_what_you_use): Deleted.
2758         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2759         (CppStyleTest.test_cleanse_line): Deleted.
2760         (CppStyleTest.test_multi_line_comments): Deleted.
2761         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2762         (CppStyleTest.test_multiline_strings): Deleted.
2763         (CppStyleTest.test_platformh_comments): Deleted.
2764         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2765         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2766         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2767         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2768         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2769         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2770         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2771         (CppStyleTest.test_check_posix_threading): Deleted.
2772         (CppStyleTest.test_insecure_string_operations): Deleted.
2773         (CppStyleTest.test_format_strings): Deleted.
2774         (CppStyleTest.test_insecure_temp_file): Deleted.
2775         (CppStyleTest.test_variable_length_array_detection): Deleted.
2776         (CppStyleTest.test_braces): Deleted.
2777         (CppStyleTest.test_check_check): Deleted.
2778         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2779         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2780         (CppStyleTest.test_spacing_for_fncall): Deleted.
2781         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2782         (CppStyleTest.test_spacing_before_braces): Deleted.
2783         (CppStyleTest.test_spacing_between_braces): Deleted.
2784         (CppStyleTest.test_spacing_before_brackets): Deleted.
2785         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2786         (CppStyleTest.test_objective_c_block): Deleted.
2787         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2788         (CppStyleTest.test_spacing_around_else): Deleted.
2789         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2790         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2791         (CppStyleTest.test_operator_methods): Deleted.
2792         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2793         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2794         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2795         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2796         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2797         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2798         (CppStyleTest.test_space_after_comment_marker): Deleted.
2799         (CppStyleTest.test_newline_at_eof): Deleted.
2800         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2801         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2802         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2803         (CppStyleTest.test_invalid_utf8): Deleted.
2804         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2805         (CppStyleTest.test_is_blank_line): Deleted.
2806         (CppStyleTest.test_blank_lines_check): Deleted.
2807         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2808         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2809         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2810         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2811         (CppStyleTest.test_comma): Deleted.
2812         (CppStyleTest.test_declaration): Deleted.
2813         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2814         (CppStyleTest.test_indent): Deleted.
2815         (CppStyleTest.test_indent.Foo): Deleted.
2816         (CppStyleTest.test_not_alabel): Deleted.
2817         (CppStyleTest.test_tab): Deleted.
2818         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2819         (CppStyleTest.test_build_class): Deleted.
2820         (CppStyleTest.test_build_class.definitions): Deleted.
2821         (CppStyleTest.test_build_class.Foo): Deleted.
2822         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2823         (CppStyleTest.test_build_end_comment): Deleted.
2824         (CppStyleTest.test_build_forward_decl): Deleted.
2825         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2826         (CppStyleTest.test_build_header_guard): Deleted.
2827         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2828         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2829         (CppStyleTest.test_build_printf_format): Deleted.
2830         (CppStyleTest.test_runtime_printf_format): Deleted.
2831         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2832         (CppStyleTest.test_build_storage_class): Deleted.
2833         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2834         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2835         (CppStyleTest.test_build_storage_class.after): Deleted.
2836         (CppStyleTest.test_build_storage_class.is): Deleted.
2837         (CppStyleTest.test_legal_copyright): Deleted.
2838         (CppStyleTest.test_invalid_increment): Deleted.
2839         (CppStyleTest.test_enum_bitfields): Deleted.
2840         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2841         (CleansedLinesTest.test_init_empty): Deleted.
2842         (CleansedLinesTest.test_collapse_strings): Deleted.
2843         (OrderOfIncludesTest.tearDown): Deleted.
2844         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2845         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2846         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2847         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2848         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2849         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2850         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2851         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2852         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2853         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2854         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2855         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2856         (OrderOfIncludesTest.test_primary_header): Deleted.
2857         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2858         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2859         (OrderOfIncludesTest.test_classify_include): Deleted.
2860         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2861         (CheckForFunctionLengthsTest.tearDown): Deleted.
2862         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2863         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2864         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2865         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2866         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2867         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2868         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2869         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2870         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2871         (CheckForFunctionLengthsTest.function_body): Deleted.
2872         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2873         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2874         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2875         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2876         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2877         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2878         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2879         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2880         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2881         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2882         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2883         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2884         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2885         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2886         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2887         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2888         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2889         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2890         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2891         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2892         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2893         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2894         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2895         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2896         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2897         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2898         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2899         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2900         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2901         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2902         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2903         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2904         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2905         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2906         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2907         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2908         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2909         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2910         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2911         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2912         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2913         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2914         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2915         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2916         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2917         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2918         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2919         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2920         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2921         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2922         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2923         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2924         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2925         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2926         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2927         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2928         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2929         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2930         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2931         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2932         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2933         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2934         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2935         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2936         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2937         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2938         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2939         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2940         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2941         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2942         (LeakyPatternTest.test_get_dc): Deleted.
2943         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2944         (LeakyPatternTest.test_own_get_dc): Deleted.
2945         (LeakyPatternTest.test_create_dc): Deleted.
2946         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2947         (WebKitStyleTest.test_indentation): Deleted.
2948         (WebKitStyleTest.test_indentation.Foo): Deleted.
2949         (WebKitStyleTest.test_indentation.Document): Deleted.
2950         (WebKitStyleTest.test_spacing): Deleted.
2951         (WebKitStyleTest.test_line_breaking): Deleted.
2952         (WebKitStyleTest.test_braces): Deleted.
2953         (WebKitStyleTest.test_braces.MyClass): Deleted.
2954         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2955         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2956         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2957         (WebKitStyleTest.test_null_false_zero): Deleted.
2958         (WebKitStyleTest.test_directive_indentation): Deleted.
2959         (WebKitStyleTest.test_using_std): Deleted.
2960         (WebKitStyleTest.test_using_namespace): Deleted.
2961         (WebKitStyleTest.test_max_macro): Deleted.
2962         (WebKitStyleTest.test_min_macro): Deleted.
2963         (WebKitStyleTest.test_wtf_move): Deleted.
2964         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2965         (WebKitStyleTest.test_names): Deleted.
2966         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2967         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2968         (WebKitStyleTest.test_names.declarations): Deleted.
2969         (WebKitStyleTest.test_names.struct): Deleted.
2970         (WebKitStyleTest.test_names.VectorType): Deleted.
2971         (WebKitStyleTest.test_parameter_names): Deleted.
2972         (WebKitStyleTest.test_comments): Deleted.
2973         (WebKitStyleTest.test_webkit_export_check): Deleted.
2974         (WebKitStyleTest.test_member_initialization_list): Deleted.
2975         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2976         (WebKitStyleTest.test_other): Deleted.
2977         (CppCheckerTest.mock_handle_style_error): Deleted.
2978         (CppCheckerTest._checker): Deleted.
2979         (CppCheckerTest.test_init): Deleted.
2980         (CppCheckerTest.test_eq): Deleted.
2981         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2982         (CppCheckerTest.test_ne): Deleted.
2983         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2984         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2985         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2986         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2987         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2988         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2989
2990 2017-07-05  Saam Barati  <sbarati@apple.com>
2991
2992         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2993         https://bugs.webkit.org/show_bug.cgi?id=174188
2994         <rdar://problem/30581423>
2995
2996         Reviewed by Mark Lam.
2997
2998         * Scripts/run-jsc-stress-tests:
2999
3000 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3001
3002         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3003         https://bugs.webkit.org/show_bug.cgi?id=174150
3004
3005         Reviewed by Mark Lam.
3006
3007         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3008         (TestWebKitAPI::TEST):
3009
3010 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3011
3012         Remove copy of ICU headers from WebKit
3013         https://bugs.webkit.org/show_bug.cgi?id=116407
3014
3015         Reviewed by Alex Christensen.
3016
3017         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3018         * TestWebKitAPI/Configurations/Base.xcconfig:
3019         * WebKitTestRunner/Configurations/Base.xcconfig:
3020
3021 2017-07-05  Chris Dumez  <cdumez@apple.com>
3022
3023         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3024         https://bugs.webkit.org/show_bug.cgi?id=174163
3025         <rdar://problem/33067518>
3026
3027         Reviewed by Alex Christensen.
3028
3029         Add API test coverage.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3033         (TEST):
3034
3035 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3036
3037         When dragging a selection, clearing the selection in dragstart should not crash the web process
3038         https://bugs.webkit.org/show_bug.cgi?id=174142
3039         <rdar://problem/33067501>
3040
3041         Reviewed by Tim Horton.
3042
3043         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3044         drag is starting up.
3045
3046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3047         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3048         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3049         (TestWebKitAPI::TEST):
3050
3051 2017-07-05  Daniel Bates  <dabates@apple.com>
3052
3053         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3054         API navigation
3055         https://bugs.webkit.org/show_bug.cgi?id=174170
3056         <rdar://problem/33140328>
3057
3058         Reviewed by Brady Eidson.
3059
3060         Update tests as needed for the behavior change.
3061
3062         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3063         (TEST):
3064
3065 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3066
3067         Add WebKitPrivateFrameworkStubs for iOS 11
3068         https://bugs.webkit.org/show_bug.cgi?id=173988
3069
3070         Reviewed by David Kilzer.
3071
3072         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3073         should use the same directory for private framework stubs.
3074         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3075
3076 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3077
3078         [MediaStream] Protect request and web view during gUM client callback
3079         https://bugs.webkit.org/show_bug.cgi?id=174096
3080         <rdar://problem/32833102>
3081
3082         Reviewed by Youenn Fablet.
3083
3084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3085         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3086
3087 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3088
3089         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3090
3091         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3092
3093 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3094
3095         Unreviewed, rolling out r219128.
3096
3097         Spoke with engineer who originally submitted, Patch for APi
3098         test to follow.
3099
3100         Reverted changeset:
3101
3102         "Unreviewed, rolling out r219070."
3103         https://bugs.webkit.org/show_bug.cgi?id=174082
3104         http://trac.webkit.org/changeset/219128
3105
3106 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3107
3108         Unreviewed, rolling out r219070.
3109
3110         This revision caused consistent failures of the API test
3111         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3112
3113         Reverted changeset:
3114
3115         "Pasting single words copied to UIPasteboard inserts URLs in
3116         editable areas"
3117         https://bugs.webkit.org/show_bug.cgi?id=174082
3118         http://trac.webkit.org/changeset/219070
3119
3120 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3121
3122         Remove unused EFL logo from bot watcher dashboard
3123         https://bugs.webkit.org/show_bug.cgi?id=174136
3124
3125         Reviewed by Alexey Proskuryakov.
3126
3127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3129
3130 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3131
3132         [GTK] Add more GTK bots to dashboard
3133         https://bugs.webkit.org/show_bug.cgi?id=174129
3134
3135         Reviewed by Carlos Alberto Lopez Perez.
3136
3137         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3138         them.
3139
3140         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3141         less-essential GTK bots.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3145         (WebKitBuildbot):
3146
3147 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3148
3149         [WPE] Add WPE to bot watcher dashboard
3150         https://bugs.webkit.org/show_bug.cgi?id=174119
3151
3152         Reviewed by Alexey Proskuryakov.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3159         (WebKitBuildbot):
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3161         (table.queue-grid tr.platform.linux-wpe img.logo):
3162
3163 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3164
3165         https://bugs.webkit.org/show_bug.cgi?id=174105
3166         
3167         Reviewed by Stephanie Lewis.
3168
3169         * BuildSlaveSupport/built-product-archive:
3170         (main): Add a -minify parser option
3171         (createZip): Pass along the optional Minify argument if requested
3172         (minifySource): This will trim down archives, logic limited to Mac platform.
3173
3174 2017-07-03  Matt Rajca  <mrajca@apple.com>
3175
3176         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3177         https://bugs.webkit.org/show_bug.cgi?id=174103
3178
3179         Reviewed by Alex Christensen.
3180
3181         Added an API test.
3182
3183         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3184         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3185         (TEST): Added test.
3186         * TestWebKitAPI/cocoa/TestWKWebView.h:
3187         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3188         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3189
3190 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3191
3192         Unreviewed, rolling out r219103.
3193
3194         Caused multiple build failures.
3195
3196         Reverted changeset:
3197
3198         "Remove copy of ICU headers from WebKit"
3199         https://bugs.webkit.org/show_bug.cgi?id=116407
3200         http://trac.webkit.org/changeset/219103
3201
3202 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3203
3204         Remove copy of ICU headers from WebKit
3205         https://bugs.webkit.org/show_bug.cgi?id=116407
3206
3207         Reviewed by Alex Christensen.
3208
3209         Use WTF's copy of ICU headers.
3210
3211         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3212         * TestWebKitAPI/Configurations/Base.xcconfig:
3213         * WebKitTestRunner/Configurations/Base.xcconfig:
3214
3215 2017-07-03  Brady Eidson  <beidson@apple.com>
3216
3217         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3218         https://bugs.webkit.org/show_bug.cgi?id=174073
3219
3220         Reviewed by Andy Estes.
3221
3222         * DumpRenderTree/mac/TestRunnerMac.mm:
3223         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3224
3225         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3226         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3227
3228 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3229
3230         Unreviewed, rolling out r219083.
3231
3232         The revision caused an API failure on all testing platforms.
3233
3234         Reverted changeset:
3235
3236         "[MediaStream] Protect request and web view during gUM client
3237         callback"
3238         https://bugs.webkit.org/show_bug.cgi?id=174096
3239         http://trac.webkit.org/changeset/219083
3240
3241 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3242
3243         webkitpy: Properly number duplicated crashlogs
3244         https://bugs.webkit.org/show_bug.cgi?id=172002
3245
3246         Reviewed by Aakash Jain.
3247
3248         * Scripts/webkitpy/common/system/crashlogs.py:
3249         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3250         an increasing integer.
3251         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3252         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3253         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3254         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3255
3256 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3257
3258         WebContent processes crash when the network process crashes with pending connection requests
3259         https://bugs.webkit.org/show_bug.cgi?id=174065
3260         <rdar://problem/30359835>
3261
3262         Reviewed by Tim Horton.
3263
3264         Add a API to ensure UI process tries to relaunch a new network process when the network process
3265         crashes with pending network connection requests.
3266
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3269         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3270         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3271         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3272
3273 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3274
3275         [MediaStream] Protect request and web view during gUM client callback
3276         https://bugs.webkit.org/show_bug.cgi?id=174096
3277         <rdar://problem/32833102>
3278
3279         Reviewed by Youenn Fablet.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3283
3284 2017-07-03  Andy Estes  <aestes@apple.com>
3285
3286         [Xcode] Add an experimental setting to build with ccache
3287         https://bugs.webkit.org/show_bug.cgi?id=173875
3288
3289         Reviewed by Tim Horton.
3290
3291         On systems that already have ccache(1) installed, this patch adds experimental support for
3292         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3293
3294         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3295         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3296         find the toolchain from which to run clang, and then invokes ccache with the required
3297         arguments.
3298
3299         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3300         precompiled headers to work properly [1].
3301
3302         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3303         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3304         during linking.
3305         
3306         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3307
3308         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3309         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3310         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3311         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3312         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3313         * ccache/README.md: Added.
3314         * ccache/ccache-clang: Added.
3315         * ccache/ccache-clang++: Added.
3316         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3317
3318 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3319
3320         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3321         https://bugs.webkit.org/show_bug.cgi?id=174051
3322
3323         Reviewed by Tim Horton.
3324
3325         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3326         (TestWebKitAPI::TEST_F):
3327
3328 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3329
3330         Unreviewed, rolling out r219024.
3331
3332         This patch cause 3 didferent test to fail.
3333
3334         Reverted changeset:
3335
3336         "REGRESSION(r215096) Queries of URLs with non-special schemes
3337         should not percent-encode single quotes"
3338         https://bugs.webkit.org/show_bug.cgi?id=174051
3339         http://trac.webkit.org/changeset/219024
3340
3341 2017-07-03  Chris Dumez  <cdumez@apple.com>
3342
3343         Drop ResourceLoadStatisticsStore's statisticsLock
3344         https://bugs.webkit.org/show_bug.cgi?id=174080
3345
3346         Reviewed by Brent Fulgham.
3347
3348         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3349
3350         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3351         (WTR::TestController::isStatisticsPrevalentResource):
3352         (WTR::TestController::isStatisticsHasHadUserInteraction):
3353         (WTR::TestController::isStatisticsGrandfathered):
3354
3355 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3356
3357         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3358         https://bugs.webkit.org/show_bug.cgi?id=174082
3359         <rdar://problem/33046992>
3360
3361         Reviewed by Tim Horton.
3362
3363         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3364
3365         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3366         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3367         (TestWebKitAPI::TEST):
3368
3369 2017-07-02  Brady Eidson  <beidson@apple.com>
3370
3371         Add API test for all parts of WebKit1 API related to favicons.
3372         https://bugs.webkit.org/show_bug.cgi?id=174069
3373
3374         Reviewed by Andy Estes.
3375
3376         These two API tests cover all WebKit1 API related to icons.
3377         
3378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3379         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3380         (mainResourceData):
3381         (defaultFaviconData):
3382         (customFaviconData):
3383         (imageFromData):
3384         (+[IconLoadingProtocol canInitWithRequest:]):
3385         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3386         (-[IconLoadingProtocol startLoading]):
3387         (-[IconLoadingProtocol stopLoading]):
3388         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3389         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3390         (TestWebKitAPI::TEST):
3391
3392 2017-07-01  Dan Bernstein  <mitz@apple.com>
3393
3394         [iOS] Remove code only needed when building for iOS 9.x
3395         https://bugs.webkit.org/show_bug.cgi?id=174068
3396
3397         Reviewed by Tim Horton.
3398
3399         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3400         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3401         (WTR::initializeWebViewConfiguration):
3402         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3403         (-[HIDEventGenerator _createIOHIDEventType:]):
3404
3405 2017-07-01  Brady Eidson  <beidson@apple.com>
3406
3407         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3408         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3409
3410         Reviewed by Alex Christensen.
3411
3412         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3413
3414 2017-07-01  Dan Bernstein  <mitz@apple.com>
3415
3416         [macOS] Remove code only needed when building for OS X Yosemite
3417         https://bugs.webkit.org/show_bug.cgi?id=174067
3418
3419         Reviewed by Tim Horton.
3420
3421         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3422         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3423         * DumpRenderTree/mac/DumpRenderTree.mm:
3424         (setDefaultsToConsistentValuesForTesting):
3425         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3426         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3427         * MiniBrowser/Configurations/Base.xcconfig:
3428         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3429         * TestWebKitAPI/Configurations/Base.xcconfig:
3430         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3431         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3432         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3433         (TestWebKitAPI::TEST_F):
3434         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3435         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3436         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3437         (TestWebKitAPI::TEST_F):
3438         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3439         (TestWebKitAPI::TEST):
3440         * WebKitTestRunner/Configurations/Base.xcconfig:
3441         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3442         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3443         (WTR::InjectedBundle::platformInitialize):
3444         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3445         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3446
3447 2017-07-01  Chris Dumez  <cdumez@apple.com>
3448
3449         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3450         https://bugs.webkit.org/show_bug.cgi?id=174060
3451
3452         Reviewed by Brent Fulgham.
3453
3454         Port WebKitTestRunner over to the new Cocoa SPI.
3455
3456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3457         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3458         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3459         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3460         no-ops since this code runs in the WebContent process, not the
3461         UIProcess.
3462
3463         * WebKitTestRunner/TestController.cpp:
3464         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3465
3466 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3467
3468         Unreviewed mac build fix.
3469
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3471         (TestWebKitAPI::TEST):
3472
3473 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3474
3475         Add API to get WKActivatedElementInfo
3476         https://bugs.webkit.org/show_bug.cgi?id=174001
3477         <rdar://problem/29165518>
3478         
3479         Tests for now SPI to get activatedElementInfo.
3480
3481         Reviewed by Tim Horton.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3485         (TestWebKitAPI::TEST):
3486
3487 2017-06-30  Chris Dumez  <cdumez@apple.com>
3488
3489         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3490         https://bugs.webkit.org/show_bug.cgi?id=174038
3491
3492         Reviewed by Brent Fulgham.
3493
3494         Fix typo in API name.
3495
3496         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3497         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3498         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3499         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3500         * WebKitTestRunner/TestController.cpp:
3501         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3502         * WebKitTestRunner/TestController.h:
3503         * WebKitTestRunner/TestInvocation.cpp:
3504         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3505
3506 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3507
3508         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3509         https://bugs.webkit.org/show_bug.cgi?id=174051
3510         <rdar://problem/33002846>
3511
3512         Reviewed by Tim Horton.
3513
3514         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3515         (TestWebKitAPI::TEST_F):
3516
3517 2017-06-30  Daniel Bates  <dabates@apple.com>
3518
3519         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3520         https://bugs.webkit.org/show_bug.cgi?id=165160
3521         <rdar://problem/29451999>
3522
3523         Reviewed by Brady Eidson.
3524
3525         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3526         for navigations and window creation.
3527
3528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3529         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3530         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3531         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3532         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3533         (TEST):
3534
3535 2017-06-29  Jer Noble  <jer.noble@apple.com>
3536
3537         Make Legacy EME API controlled by RuntimeEnabled setting.
3538         https://bugs.webkit.org/show_bug.cgi?id=173994
3539
3540         Reviewed by Sam Weinig.
3541
3542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3543
3544 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3545
3546         Follow-up fix for r218996
3547
3548         Unreviewed infrastructure fix.
3549
3550         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3551
3552         * Scripts/webkitpy/port/ios_simulator.py:
3553         (IOSSimulatorPort): Memoize ios_version().
3554
3555 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3556
3557         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3558         https://bugs.webkit.org/show_bug.cgi?id=174017
3559         <rdar://problem/32959782>
3560
3561         Reviewed by Simon Fraser.
3562
3563         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3564         changes, the caret would appear outside of the iframe.
3565
3566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3567         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3568         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3569         (checkDragCaretRectIsContainedInRect):
3570         (TestWebKitAPI::TEST):
3571         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3572         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3573         (-[DataInteractionSimulator _resetSimulatedState]):
3574         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3575         (-[DataInteractionSimulator _advanceProgress]):
3576         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3577
3578 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3579
3580         Add support for different versions of iOS when loading test expectations
3581         https://bugs.webkit.org/show_bug.cgi?id=173774
3582         <rdar://problem/32951132>
3583
3584         Rubber-stamped by Aakash Jain.
3585
3586         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3587
3588         * Scripts/webkitpy/port/ios.py:
3589         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3590         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3591         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3592         * Scripts/webkitpy/port/ios_device.py:
3593         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3594         * Scripts/webkitpy/port/ios_device_unittest.py:
3595      &