49f25a0c5f179f70553bc22f4f277cbd05364d81
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-17  Andreas Kling  <akling@apple.com>
2
3         Disable CSS regions at compile time
4         https://bugs.webkit.org/show_bug.cgi?id=175630
5
6         Reviewed by Antti Koivisto.
7
8         * Scripts/webkitperl/FeatureList.pm:
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
12
13         Unreviewed, try to fix the internal iOS 10 build after r220865.
14
15         * TestWebKitAPI/ios/UIKitSPI.h:
16
17         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
18         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
19         this compiler guard.
20
21 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
22
23         [iOS] Respect type fidelities when copying image elements to the pasteboard
24         https://bugs.webkit.org/show_bug.cgi?id=175638
25         <rdar://problem/26556043>
26
27         Reviewed by Ryosuke Niwa.
28
29         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
30         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
31         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
32
33         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
34         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
35         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
36         (TestWebKitAPI::TEST):
37         (TestWebKitAPI::presentActionSheetAndChooseAction):
38         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
39         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
40         (checkEstimatedSize):
41         (checkSuggestedNameAndEstimatedSize):
42
43         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
44
45         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
46         (TestWebKitAPI::TEST):
47         * TestWebKitAPI/ios/DataInteractionSimulator.h:
48         * TestWebKitAPI/ios/UIKitSPI.h: Added.
49
50 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
51
52         Recursively create resource load statistics folder for testing
53         https://bugs.webkit.org/show_bug.cgi?id=175676
54
55         Reviewed by Brady Eidson.
56
57         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
58         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
59
60 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
61
62         [GTK][WPE] Add NTLM authentication enabled API
63         https://bugs.webkit.org/show_bug.cgi?id=122952
64
65         Reviewed by Michael Catanzaro.
66
67         Add a test case to check we can enable/disable NTLM.
68
69         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
70         (testWebViewAuthenticationNTLM):
71         (beforeAll):
72
73 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
74
75         [PAL] Move spi/ios and spi/win directories into PAL
76         https://bugs.webkit.org/show_bug.cgi?id=175171
77
78         Reviewed by Antti Koivisto.
79
80         * DumpRenderTree/mac/EventSendingController.mm:
81
82 2017-08-16  Andy Estes  <aestes@apple.com>
83
84         [Payment Request] Add an ENABLE flag and an experimental feature preference
85         https://bugs.webkit.org/show_bug.cgi?id=175622
86
87         Reviewed by Tim Horton.
88
89         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
90         * WebKitTestRunner/TestController.cpp:
91         (WTR::TestController::resetPreferencesToConsistentValues):
92
93 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
94
95         undefined URL in PopoverTracker for failed step
96         https://bugs.webkit.org/show_bug.cgi?id=175593
97         <rdar://problem/33898769>
98
99         Reviewed by Daniel Bates.
100
101         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
102         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
105         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
106         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
108         (BuildbotTestResults): Accept URL in constructor.
109
110 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
111
112         Remove Proximity Events and related code
113         https://bugs.webkit.org/show_bug.cgi?id=175545
114
115         Reviewed by Daniel Bates.
116
117         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
118         and other related code.
119
120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
121
122 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
123
124         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
125         https://bugs.webkit.org/show_bug.cgi?id=175504
126
127         Reviewed by Sam Weinig.
128
129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
130
131 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
132
133         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
134         https://bugs.webkit.org/show_bug.cgi?id=175557
135
136         Reviewed by Jon Lee.
137         
138         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
139
140         * DumpRenderTree/TestRunner.cpp:
141         (TestRunner::staticFunctions):
142         (setViewModeMediaFeatureCallback): Deleted.
143         * DumpRenderTree/TestRunner.h:
144         * DumpRenderTree/mac/TestRunnerMac.mm:
145         (TestRunner::setViewModeMediaFeature): Deleted.
146         * DumpRenderTree/win/TestRunnerWin.cpp:
147         (TestRunner::setViewModeMediaFeature): Deleted.
148         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
149
150 2017-08-14  Andy Estes  <aestes@apple.com>
151
152         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
153         https://bugs.webkit.org/show_bug.cgi?id=175548
154         <rdar://problem/33866206>
155
156         Reviewed by Brady Eidson.
157
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
160         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
161
162 2017-08-14  Youenn Fablet  <youenn@apple.com>
163
164         WPT server should be able to do logging even if its output folder is not created at launch time
165         https://bugs.webkit.org/show_bug.cgi?id=175543
166
167         Reviewed by Alexey Proskuryakov.
168
169         Removing no longer used stdout/stderr member variables.
170         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
171
172         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
173         (WebPlatformTestServer.__init__):
174         (WebPlatformTestServer._prepare_config):
175         (WebPlatformTestServer._spawn_process):
176         (WebPlatformTestServer._stop_running_server):
177
178 2017-08-14  Daniel Bates  <dabates@apple.com>
179
180         webkit-patch: Passing --no-review should submit patch to EWS by default
181         https://bugs.webkit.org/show_bug.cgi?id=148899
182
183         Reviewed by David Kilzer.
184
185         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
186         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
187         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
188
189         Frequently I want to post a draft of a patch without review to have the EWS bots process
190         it to catch build and test breakage before I clean it up and post it for formal review.
191         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
192         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
193         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
194
195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
196         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
197         parse the attachment id from the response page after adding an attachment to the bug.
198         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
199         HTTP response after uploading the patch.
200         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
201         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
202         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
203         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
204         * Scripts/webkitpy/tool/commands/upload.py:
205         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
206         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
207         this command.
208         (PostCommits.execute): Submit the patch to EWS, if applicable.
209         * Scripts/webkitpy/tool/commands/upload_unittest.py:
210         (test_upload): Set options.ews to False as the upload command expects this option
211         to be specified.
212         (test_upload_with_no_review_and_ews): Added.
213         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
214         * Scripts/webkitpy/tool/steps/options.py:
215         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
216         * Scripts/webkitpy/tool/steps/postdiff.py:
217         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
218         this command.
219         (PostDiff.run): Submit the patch to EWS, if applicable.
220         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
221         (SubmitToEWS):
222         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
223         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
224
225 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
226
227         Disable two flaky VideoControlsManager API tests.
228
229         Unreviewed test gardening.
230
231         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
232         (TestWebKitAPI::TEST):
233
234 2017-08-14  Tim Horton  <timothy_horton@apple.com>
235
236         Only create directory and sandbox extension handle for storage directories if they are set
237         https://bugs.webkit.org/show_bug.cgi?id=175522
238
239         Reviewed by Brady Eidson.
240
241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
242         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
243         (TEST):
244         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
245         doesn't log anything to stderr.
246
247 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
248
249         sub-categorize Sandbox violation logs
250         https://bugs.webkit.org/show_bug.cgi?id=175536
251         <rdar://problem/33834416>
252
253         Reviewed by David Kilzer.
254
255         * Scripts/webkitpy/common/system/crashlogs.py:
256         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
257         a Sandbox violation.
258         (CrashLogs._find_all_logs_darwin): Update comment.
259         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
260         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
261         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
262         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
263         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
264         * Scripts/webkitpy/port/darwin.py:
265         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
266
267 2017-08-14  Daniel Bates  <dabates@apple.com>
268
269         Add Automator service to copy permalink to Clipboard
270         https://bugs.webkit.org/show_bug.cgi?id=170978
271
272         Reviewed by Joseph Pecoraro.
273
274         It is helpful to reference using a hyperlink a particular line of code when having
275         a discussion on IRC or in a bug. You can get such a link by navigating to the file
276         in the Trac Browse Source viewer and selecting the line your are interested in.
277         I found myself doing this often enough that I wrote an Automator service to do it
278         for me.
279
280         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
281
282         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
283         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
284         * CopyPermalink/README: Added.
285
286 2017-08-14  Chris Dumez  <cdumez@apple.com>
287
288         Address flakiness related to download tests
289         https://bugs.webkit.org/show_bug.cgi?id=175338
290         <rdar://problem/33865119>
291
292         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
293         between tests.
294
295         * WebKitTestRunner/TestController.cpp:
296         (WTR::TestController::resetStateToConsistentValues):
297
298 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
299
300         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
301         https://bugs.webkit.org/show_bug.cgi?id=175474
302         <rdar://problem/33844628>
303
304         Reviewed by Wenson Hsieh.
305
306         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
307
308         * DumpRenderTree/mac/DumpRenderTree.mm:
309         (resetWebPreferencesToConsistentValues):
310         * WebKitTestRunner/TestController.cpp:
311         (WTR::TestController::resetPreferencesToConsistentValues):
312
313 2017-08-12  Chris Dumez  <cdumez@apple.com>
314
315         Address flakiness related to download tests
316         https://bugs.webkit.org/show_bug.cgi?id=175338
317
318         Reviewed by Ryosuke Niwa.
319
320         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
321           is actually queried when a download completes. Previously, this would be
322           identical to a call to testRunner.waitUntilDone() because any download
323           completion would call testRunner.notifyDone().
324         - Disable logging of download callbacks by default and add a
325           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
326           enable such logging.
327
328         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
329         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
330         (WTR::InjectedBundle::didReceiveMessageToPage):
331         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
332         (WTR::TestRunner::setShouldLogDownloadCallbacks):
333         * WebKitTestRunner/InjectedBundle/TestRunner.h:
334         * WebKitTestRunner/TestController.cpp:
335         (WTR::TestController::downloadDidStart):
336         (WTR::TestController::decideDestinationWithSuggestedFilename):
337         (WTR::TestController::downloadDidFinish):
338         (WTR::TestController::downloadDidFail):
339         (WTR::TestController::downloadDidCancel):
340         * WebKitTestRunner/TestController.h:
341         (WTR::TestController::setShouldLogDownloadCallbacks):
342         * WebKitTestRunner/TestInvocation.cpp:
343         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
344
345 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
346
347         Create mock ITP data in testing to prevent grandfathering
348         https://bugs.webkit.org/show_bug.cgi?id=174720
349
350         Unreviewed follow-up fix for r220604.
351
352         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
353         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
354
355 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
356
357         Create mock ITP data in testing to prevent grandfathering
358         https://bugs.webkit.org/show_bug.cgi?id=174720
359         <rdar://problem/33457779>
360
361         Reviewed by Brent Fulgham.
362
363         We don't need to be triggering grandfathering when each test runner starts. On Mac,
364         this may launch plugins which can cause layout tests to fail later if the test
365         runner does not shut-down before the plugins unload.
366
367         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
368         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
369         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
370         prevent grandfathering from being triggered.
371         * WebKitTestRunner/ios/TestControllerIOS.mm:
372         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
373         * WebKitTestRunner/mac/TestControllerMac.mm:
374         (WTR::TestController::platformInitialize): Ditto.
375
376 2017-08-11  Sam Weinig  <sam@webkit.org>
377
378         WTF::Function does not allow for reference / non-default constructible return types
379         https://bugs.webkit.org/show_bug.cgi?id=175244
380         <rdar://problem/33801582>
381
382         Reviewed by Chris Dumez.
383
384         * TestWebKitAPI/Tests/WTF/Function.cpp:
385         (TestWebKitAPI::TEST):
386
387 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
388
389         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
390         https://bugs.webkit.org/show_bug.cgi?id=175378
391
392         Reviewed by Sergio Villar Senin.
393
394         Add two test cases to check proxy authentication.
395
396         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
397         (Tunnel::Tunnel):
398         (Tunnel::~Tunnel):
399         (Tunnel::connect):
400         (Tunnel::connected):
401         (serverCallback):
402         (ProxyAuthenticationTest::ProxyAuthenticationTest):
403         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
404         (ProxyAuthenticationTest::proxyServerPortAsString):
405         (testWebViewAuthenticationProxy):
406         (testWebViewAuthenticationProxyHTTPS):
407         (beforeAll):
408
409 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
410
411         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
412         https://bugs.webkit.org/show_bug.cgi?id=175428
413
414         Both ports share the GStreamer code as multimedia backend and till
415         not so long they were using different versions. Now they do use
416         the same versions and it does not make any sense anymore (and
417         neither had sense before) to have differences in the modulesets.
418
419         In this patch I created a GStreamer moduleset and referenced it
420         from both GTK+'s and WPE's. GStreamer patches were also moved there.
421
422         Reviewed by Žan Doberšek.
423
424         * gstreamer/jhbuild.modules: Added.
425         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
426         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
427         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
428         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
429         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
430         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
431         * gtk/jhbuild.modules:
432         * wpe/jhbuild.modules:
433         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
434         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
435         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
436         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
437         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
438
439 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
440
441         Unreviewed, adding Ross Kirsling to contributors.json
442
443         * Scripts/webkitpy/common/config/contributors.json:
444
445 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
446
447         Unreviewed, attempt to fix build failure with VC2017
448
449         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
450         (TEST):
451
452 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
453
454         Unreviewed, suppress warnings on GCC
455
456         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
457         (TestWebKitAPI::CheckedArithmeticTester::run):
458
459 2017-08-10  Dan Bernstein  <mitz@apple.com>
460
461         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
462         https://bugs.webkit.org/show_bug.cgi?id=173223
463
464         Reviewed by Tim Horton.
465
466         The rebuilds were happening due to a difference in the compiler options that the IDE and
467         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
468         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
469         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
470         Advanced when a Custom Absolute path is selected.
471
472         * Scripts/webkitdirs.pm:
473         (determineBaseProductDir):
474
475 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
476
477         Run more WTF tests
478         https://bugs.webkit.org/show_bug.cgi?id=174970
479
480         Reviewed by Michael Catanzaro.
481
482         Some of WTF tests are not executed in non Apple ports while they are generic ones.
483         This patch adds these tests to non-Apple port TestWebKitAPI.
484         Currently, we do not add Signals.cpp since it depends on signal functionality.
485
486         * TestWebKitAPI/CMakeLists.txt:
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
489         (isHigherPriority):
490         (TEST):
491         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
492         (TEST):
493         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
494         (TEST):
495
496 2017-08-10  obinna obike  <oobike@apple.com>
497
498         Remove obsolete link from webkit-queues status page
499         https://bugs.webkit.org/show_bug.cgi?id=175337
500
501         Reviewed by Aakash Jain.
502
503         * QueueStatusServer/templates/recentstatus.html:
504         Removed the link to the ews-watcher server.
505
506 2017-08-10  Brian Burg  <bburg@apple.com>
507
508         WKPreferences should conform to NSCopying
509         https://bugs.webkit.org/show_bug.cgi?id=175303
510         <rdar://problem/33764939>
511
512         Reviewed by Dan Bernstein.
513
514         Add unit test to make sure a WKPreference and its copy are
515         not aliased to each other or affect each other's properties.
516
517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
518         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
519         (TEST):
520
521 2017-08-10  Tim Horton  <timothy_horton@apple.com>
522
523         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
524         https://bugs.webkit.org/show_bug.cgi?id=175436
525         <rdar://problem/33667497>
526
527         Reviewed by Simon Fraser.
528
529         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
530         (TestWebKitAPI::TEST_F):
531
532 2017-08-10  Lucas Forschler  <lforschler@apple.com>
533
534         Fix duplicated code in r220534.
535
536         Unreviewed cleanup.
537
538         * Scripts/bisect-builds:
539
540 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
541
542         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
543         https://bugs.webkit.org/show_bug.cgi?id=175344
544         <rdar://problem/28507240>
545
546         Reviewed by Alexey Proskuryakov.
547
548         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
549         Finally enable the existing tests for iOS.
550
551         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
552         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
554         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
555
556 2017-08-10  Lucas Forschler  <lforschler@apple.com>
557
558         Write a tool to bisect WebKit builds
559         https://bugs.webkit.org/show_bug.cgi?id=174596
560
561         Reviewed by Dean Johnson and Kocsen Chung.
562
563         * Scripts/bisect-builds: Added.
564         (bisect_builds): main bisection algorithm
565         (download_archive):download an archive from S3 using existing tools
566         (extract_archive):extract an archive using existing tools
567         (find_le):Find rightmost value less than or equal to x
568         (find_ge):Find leftmost item greater than or equal to x
569         (get_api_url):generate url for the rest api/database
570         (get_indices_from_revisions):convert revisions to list indexes for bisection
571         (get_sorted_revisions):retrieve sorted revision list
572         (get_s3_location_for_revision):calculate the S3 archive storage location
573         (parse_args):parse command line arguments
574         (pick_next_build):compute the next build to bisect
575         (prompt_did_reproduce):prompt user for direction for bisection
576         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
577         (test_archive):Platform specific logic to test downloaded archive
578         (minified_platforms):return a list of minified platforms in the database
579         (unminified_platforms):return a list of full platforms in the database
580         (is_supported_platform):check if platform is supported
581         (validate_options):validate command line options
582         (main):
583
584 2017-08-10  Lucas Forschler  <lforschler@apple.com>
585
586         Remove bisect-builds script.
587         https://bugs.webkit.org/show_bug.cgi?id=175433
588         
589         Reviewed by Aakash Jain.
590
591         * Scripts/bisect-builds: Removed.
592
593 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
594
595         Remove ENABLE_GAMEPAD_DEPRECATED
596         https://bugs.webkit.org/show_bug.cgi?id=175361
597
598         Reviewed by Carlos Garcia Campos.
599
600         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
601
602 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
603
604         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
605         https://bugs.webkit.org/show_bug.cgi?id=175426
606
607         Reviewed by Carlos Garcia Campos.
608
609         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
610
611 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
612
613         Add Ms2ger as contributor.
614         https://bugs.webkit.org/show_bug.cgi?id=175325
615
616         Reviewed by Carlos Alberto Lopez Perez.
617
618         * Scripts/webkitpy/common/config/contributors.json:
619
620 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
621
622         Fix run-benchmark after r220483.
623         https://bugs.webkit.org/show_bug.cgi?id=175415
624         <rdar://problem/33803003>
625
626         Reviewed by Ryosuke Niwa.
627
628         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
629
630         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
631         (WebServerBenchmarkRunner._run_one_test):
632
633 2017-08-09  Chris Dumez  <cdumez@apple.com>
634
635         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
636         https://bugs.webkit.org/show_bug.cgi?id=175401
637
638         Reviewed by Brady Eidson.
639
640         * DumpRenderTree/mac/DumpRenderTree.mm:
641         (enableExperimentalFeatures):
642
643 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
644
645         [PAL] Move spi/cocoa and spi/cg directories into PAL
646         https://bugs.webkit.org/show_bug.cgi?id=175175
647
648         Reviewed by Myles C. Maxfield.
649
650         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
651         * DumpRenderTree/mac/DumpRenderTree.mm:
652         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
653         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
654
655         * Scripts/webkitpy/style/checker.py:
656         * Scripts/webkitpy/style/checker_unittest.py:
657         (GlobalVariablesTest.test_path_rules_specifier):
658
659         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
660
661         * Scripts/webkitpy/style/checkers/cpp.py:
662         (check_braces):
663         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
664         (WebKitStyleTest.test_braces.CF_OPTIONS):
665         (WebKitStyleTest.test_braces):
666
667         Prevent CF_OPTIONS() from being handled as funtion definition.
668
669 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
670
671         [WTF] Move TextStream into WTF
672         https://bugs.webkit.org/show_bug.cgi?id=175211
673
674         Reviewed by Myles C. Maxfield.
675
676         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
677
678 2017-08-09  Andy Estes  <aestes@apple.com>
679
680         Part 3 of: Rename DatabaseProcess to StorageProcess
681         https://bugs.webkit.org/show_bug.cgi?id=175034
682
683         Reviewed by Brady Eidson.
684
685         * WebKitTestRunner/TestController.cpp:
686         (WTR::TestController::databaseProcessName): Updated to return
687         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
688
689 2017-08-09  Commit Queue  <commit-queue@webkit.org>
690
691         Unreviewed, rolling out r220466, r220477, and r220487.
692         https://bugs.webkit.org/show_bug.cgi?id=175411
693
694         This change broke existing API tests and follow up fixes did
695         not resolve all the issues. (Requested by ryanhaddad on
696         #webkit).
697
698         Reverted changesets:
699
700         https://bugs.webkit.org/show_bug.cgi?id=175244
701         http://trac.webkit.org/changeset/220466
702
703         "WTF::Function does not allow for reference / non-default
704         constructible return types"
705         https://bugs.webkit.org/show_bug.cgi?id=175244
706         http://trac.webkit.org/changeset/220477
707
708         https://bugs.webkit.org/show_bug.cgi?id=175244
709         http://trac.webkit.org/changeset/220487
710
711 2017-08-09  Sam Weinig  <sam@webkit.org>
712
713         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
714
715         Remove one addition of null Function test.
716
717 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
718
719         Allow nested timeouts in webkitpy
720         https://bugs.webkit.org/show_bug.cgi?id=175390
721         <rdar://problem/33803003>
722
723         Reviewed by David Kilzer.
724
725         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
726         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
727         the executive to detect and recover from any issues connecting with devices.
728
729         * Scripts/webkitpy/benchmark_runner/utils.py:
730         (TimeoutError): Deleted.
731         (timeout): Deleted.
732         * Scripts/webkitpy/common/timeout_context.py: Added.
733         (Timeout): A timeout context designed to be nested.
734         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
735         (Timeout.TimeoutData.__init__):
736         (Timeout.default_handler): Timeout handler used if none is specified.
737         (Timeout.current): Access data about the most urgent timeout.
738         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
739         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
740         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
741         urgent timeout data.
742         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
743         most urgent timeout data, if such data exists.
744         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
745         (TimeoutContextTests):
746         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
747         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
748         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
749         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
750         over a less urgent outer timeout.
751         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
752         over a less urgent inner timeout.
753         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
754         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
755         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
756         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
757         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
758         * Scripts/webkitpy/port/simulator_process.py:
759         (SimulatorProcess._start): Use Timeout class.
760         * Scripts/webkitpy/xcode/simulated_device.py:
761         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
762         (SimulatedDevice.launch_app): Ditto.
763         (SimulatedDevice.launch_app._install_timeout): Deleted.
764         * Scripts/webkitpy/xcode/simulator.py:
765         (Simulator.wait_until_device_is_booted):Use Timeout class.
766         (Simulator.wait_until_device_is_in_state): Ditto.
767
768 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
769
770         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
771         https://bugs.webkit.org/show_bug.cgi?id=175392
772         <rdar://problem/33783207>
773
774         Reviewed by Tim Horton and Megan Gardner.
775
776         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
777
778         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
779
780 2017-08-09  Sam Weinig  <sam@webkit.org>
781
782         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
783
784         * TestWebKitAPI/Tests/WTF/Function.cpp:
785         Remove tests of null Functions, as they are no longer supported.
786
787 2017-08-09  Daniel Bates  <dabates@apple.com>
788
789         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
790         https://bugs.webkit.org/show_bug.cgi?id=175247
791         <rdar://problem/33679804>
792
793         Reviewed by Brady Eidson.
794
795         Add tests for redirects.
796
797         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
798         (TEST):
799         * TestWebKitAPI/cocoa/TestProtocol.mm:
800         (createRedirectURL):
801         (-[TestProtocol startLoading]):
802
803 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
804
805         Unreviewed, rolling out r220393.
806
807         This patch regresses the performance of WebPage::editorState.
808
809         Reverted changeset:
810
811         "[iOS WK2] WKWebView schedules nonstop layout after pressing
812         cmb+b,i,u inside a contenteditable div"
813         https://bugs.webkit.org/show_bug.cgi?id=175116
814         http://trac.webkit.org/changeset/220393
815
816 2017-08-08  obinna obike  <oobike@apple.com>
817
818         Created Individual EWS Pages
819         https://bugs.webkit.org/show_bug.cgi?id=174477
820
821         Reviewed by Aakash Jain.
822
823         Created individual pages for each EWS. Changed the link within each status bubble
824         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
825
826         * QueueStatusServer/handlers/patch.py:
827         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
828         * QueueStatusServer/handlers/statusbubble.py:
829         (StatusBubble._build_bubble): Updated url for specific EWS.
830         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
831         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
832         all ews queues.
833         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
834         takes you directly to the individual ews page.
835
836 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
837
838         Separate jsc stress test script writer from run-jsc-stress-tests
839         https://bugs.webkit.org/show_bug.cgi?id=175216
840
841         Reviewed by Mark Lam.
842
843         * Scripts/run-jsc-stress-tests:
844         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
845
846 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
847
848         Unreviewed, fix Ubuntu LTS build
849         https://bugs.webkit.org/show_bug.cgi?id=174490
850
851         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
852
853 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
856         https://bugs.webkit.org/show_bug.cgi?id=175302
857         <rdar://problem/33762116>
858
859         Reviewed by Tim Horton.
860
861         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
862         See WebKit ChangeLog for more details.
863
864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
865         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
866         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
867         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
868         (-[SlowTextInputContext handleEvent:completionHandler:]):
869         (-[SlowInputWebView inputContext]):
870         (-[SlowInputWebView _web_superInputContext]):
871         (TEST):
872
873 2017-08-08  John Wilander  <wilander@apple.com>
874
875         Resource Load Statistics: Clear web processes' state on history removal
876         https://bugs.webkit.org/show_bug.cgi?id=175271
877         <rdar://problem/33756560>
878
879         Reviewed by Chris Dumez.
880
881         Test infrastructure for asynchronous tests of website data
882         removal for _WKWebsiteDataTypeResourceLoadStatistics.
883
884         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
885         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
886         (WTR::InjectedBundle::didReceiveMessageToPage):
887         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
888         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
889         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
890         * WebKitTestRunner/InjectedBundle/TestRunner.h:
891         * WebKitTestRunner/TestController.cpp:
892         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
893         * WebKitTestRunner/TestController.h:
894         * WebKitTestRunner/TestInvocation.cpp:
895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
896         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
897         * WebKitTestRunner/TestInvocation.h:
898         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
899         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
900
901 2017-08-08  Alicia Boya García  <aboya@igalia.com>
902
903         Add Alicia Boya García as contributor
904         https://bugs.webkit.org/show_bug.cgi?id=175326
905
906         Reviewed by Michael Catanzaro.
907
908         * Scripts/webkitpy/common/config/contributors.json:
909
910 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
911
912         [CMake] Properly test if compiler supports compiler flags
913         https://bugs.webkit.org/show_bug.cgi?id=174490
914
915         Reviewed by Konstantin Tokarev.
916
917         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
918         * MiniBrowser/gtk/CMakeLists.txt:
919         * TestRunnerShared/Bindings/JSWrapper.cpp:
920         (WTR::JSWrapper::initialize):
921         * TestWebKitAPI/CMakeLists.txt:
922         * TestWebKitAPI/PlatformGTK.cmake:
923         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
924         (TestWebKitAPI::CheckedArithmeticTester::run):
925         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
926         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
927         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
928         (formControlsAssociatedCallback):
929         * TestWebKitAPI/glib/CMakeLists.txt:
930         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
931         (Test::getResourcesDir):
932         * WebKitTestRunner/CMakeLists.txt:
933         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
934         (WTR::menuItemClickCallback):
935         (WTR::staticConvertMenuItemToType):
936         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
937         (WTR::TestRunner::setUseDashboardCompatibilityMode):
938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
939         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
940         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
941         (WTR::AccessibilityUIElement::helpText const):
942         (WTR::AccessibilityUIElement::attributedStringForRange):
943         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
944         (WTR::EventSenderProxy::updateTouchPoint):
945         (WTR::EventSenderProxy::releaseTouchPoint):
946
947 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
948
949         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
950         https://bugs.webkit.org/show_bug.cgi?id=175116
951         <rdar://problem/28279301>
952
953         Reviewed by Darin Adler and Ryosuke Niwa.
954
955         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
956         EditorStateTests run on both iOS and Mac.
957
958         * TestWebKitAPI/EditingTestHarness.h: Added.
959         * TestWebKitAPI/EditingTestHarness.mm: Added.
960
961         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
962         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
963         the state of the latest observed EditorState.
964
965         (-[EditingTestHarness initWithWebView:]):
966         (-[EditingTestHarness dealloc]):
967         (-[EditingTestHarness webView]):
968         (-[EditingTestHarness latestEditorState]):
969         (-[EditingTestHarness editorStateHistory]):
970         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
971         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
972         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
973         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
974         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
975         (-[EditingTestHarness toggleBold]):
976         (-[EditingTestHarness toggleItalic]):
977         (-[EditingTestHarness toggleUnderline]):
978         (-[EditingTestHarness setForegroundColor:]):
979         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
980         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
981         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
982         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
983         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
984         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
985         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
986
987         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
988         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
989         keys and values.
990
991         (-[EditingTestHarness latestEditorStateContains:]):
992         (-[EditingTestHarness _webView:editorStateDidChange:]):
993         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
994         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
995         (TestWebKitAPI::setUpEditorStateTestHarness):
996         (TestWebKitAPI::TEST):
997         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
998
999 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1000
1001         Prevent domain from being set to a TLD
1002         https://bugs.webkit.org/show_bug.cgi?id=175226
1003         <rdar://problem/11079948>
1004
1005         Reviewed by Chris Dumez.
1006
1007         Extend the public suffix tests to include cases used by the
1008         Public Domain 'Public Suffix List'.
1009
1010         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1011         (TestWebKitAPI::TEST):
1012
1013 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1014
1015         [XCode] webkit-patch should run sort-Xcode-project-file
1016         https://bugs.webkit.org/show_bug.cgi?id=174036
1017         <rdar://problem/33732709>
1018
1019         Reviewed by Simon Fraser.
1020
1021         * Scripts/webkitpy/common/config/ports.py:
1022         * Scripts/webkitpy/tool/commands/download.py:
1023         * Scripts/webkitpy/tool/commands/download_unittest.py:
1024         * Scripts/webkitpy/tool/commands/upload.py:
1025         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1026         * Scripts/webkitpy/tool/steps/__init__.py:
1027         * Scripts/webkitpy/tool/steps/options.py:
1028         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1029
1030 2017-08-07  Devin Rousso  <drousso@apple.com>
1031
1032         Web Inspector: Preview Canvas path when viewing a recording
1033         https://bugs.webkit.org/show_bug.cgi?id=174967
1034
1035         Reviewed by Brian Burg.
1036
1037         * DumpRenderTree/TestOptions.h:
1038         * DumpRenderTree/TestOptions.mm:
1039         (TestOptions::TestOptions):
1040         * DumpRenderTree/mac/DumpRenderTree.mm:
1041         (setWebPreferencesForTestOptions):
1042         * WebKitTestRunner/TestController.cpp:
1043         (WTR::TestController::resetPreferencesToConsistentValues):
1044         (WTR::updateTestOptionsFromTestHeader):
1045         * WebKitTestRunner/TestOptions.h:
1046         (WTR::TestOptions::hasSameInitializationOptions const):
1047         Add plumbing for new InspectorAdditions runtime flag.
1048
1049 2017-08-07  obinna obike  <oobike@apple.com>
1050
1051         Sorted EWS Queues on Patch page
1052         https://bugs.webkit.org/show_bug.cgi?id=173667
1053
1054         Reviewed by Aakash Jain.
1055
1056         * QueueStatusServer/handlers/patch.py:
1057         (Patch.get): Sorted queue_status.
1058         * QueueStatusServer/templates/patch.html:
1059         Changed queue_status.items to queue_status because it's a list.
1060
1061 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1062
1063         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1064         https://bugs.webkit.org/show_bug.cgi?id=175286
1065
1066         Reviewed by Myles C. Maxfield.
1067
1068         * Scripts/webkitpy/style/checkers/cpp.py:
1069         (check_braces):
1070         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1071         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1072         (WebKitStyleTest.test_braces):
1073         (WebKitStyleTest.test_braces.NS_OPTIONS):
1074
1075 2017-08-07  Brian Burg  <bburg@apple.com>
1076
1077         Remove CANVAS_PATH compilation guard
1078         https://bugs.webkit.org/show_bug.cgi?id=175207
1079
1080         Reviewed by Sam Weinig.
1081
1082         * Scripts/webkitperl/FeatureList.pm:
1083         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1084
1085 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1086
1087         [Win] Use Visual Studio 2017 if installed.
1088         https://bugs.webkit.org/show_bug.cgi?id=175188
1089
1090         Reviewed by Sam Weinig.
1091
1092         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1093
1094         * Scripts/webkitdirs.pm:
1095         (visualStudioInstallDir):
1096         (msBuildInstallDir):
1097
1098 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GTK][WPE] Add API to provide browser information required by automation
1101         https://bugs.webkit.org/show_bug.cgi?id=175130
1102
1103         Reviewed by Michael Catanzaro.
1104
1105         * MiniBrowser/gtk/main.c:
1106         (automationStartedCallback): Set browser information when a new automation session is started.
1107         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1108         (testAutomationSessionApplicationInfo):
1109         (beforeAll):
1110
1111 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1112
1113         Unreviewed, rolling out r220295.
1114
1115         This change introduced 4 errors in webkitpy tests.
1116
1117         Reverted changeset:
1118
1119         "[XCode] webkit-patch should run sort-Xcode-project-file"
1120         https://bugs.webkit.org/show_bug.cgi?id=174036
1121         http://trac.webkit.org/changeset/220295
1122
1123 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1124
1125         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1126
1127         Unreviewed test gardening.
1128
1129         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1130         (TestWebKitAPI::TEST):
1131
1132 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1133
1134         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1135         https://bugs.webkit.org/show_bug.cgi?id=175083
1136
1137         Reviewed by Oliver Hunt.
1138         
1139         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1140         to wait for VM destructions to finish before running the next test. This makes it easier to 
1141         understand leaks results from workers tests, and leads to fewer reported leaks.
1142
1143         * DumpRenderTree/mac/DumpRenderTree.mm:
1144         (runTest):
1145
1146 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1147
1148         check-webkit-style: fix path-specific rules for WebKit2 rename
1149         https://bugs.webkit.org/show_bug.cgi?id=175182
1150
1151         Reviewed by David Kilzer.
1152
1153         * Scripts/webkitpy/style/checker.py:
1154
1155 2017-08-04  Youenn Fablet  <youenn@apple.com>
1156
1157         [Cache API] Add Cache and CacheStorage IDL definitions
1158         https://bugs.webkit.org/show_bug.cgi?id=175201
1159
1160         Reviewed by Brady Eidson.
1161
1162         * DumpRenderTree/mac/DumpRenderTree.mm:
1163         (enableExperimentalFeatures):
1164         (resetWebPreferencesToConsistentValues):
1165         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1166         (WTR::InjectedBundle::beginTesting):
1167         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1168         (WTR::TestRunner::setCacheAPIEnabled):
1169         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1170
1171 2017-08-04  John Wilander  <wilander@apple.com>
1172
1173         Resource Load Statistics: Report user interaction immediately, but only when needed
1174         https://bugs.webkit.org/show_bug.cgi?id=175090
1175         <rdar://problem/33685546>
1176
1177         Reviewed by Chris Dumez.
1178
1179         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1180         (WTR::InjectedBundle::beginTesting):
1181             Now calls WebCore::ResourceLoadObserver::clearState().
1182
1183 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1184
1185         Add an API test for r220286
1186         https://bugs.webkit.org/show_bug.cgi?id=175206
1187
1188         Reviewed by Simon Fraser.
1189
1190         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1191         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1192         (createAnimatedResizeWebView):
1193         (TEST):
1194         Add a test to ensure that we don't call
1195         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1196         animated resize.
1197
1198 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1199
1200         [XCode] webkit-patch should run sort-Xcode-project-file
1201         https://bugs.webkit.org/show_bug.cgi?id=174036
1202
1203         Reviewed by Simon Fraser.
1204
1205         * Scripts/webkitpy/common/config/ports.py:
1206         * Scripts/webkitpy/tool/commands/download.py:
1207         * Scripts/webkitpy/tool/commands/upload.py:
1208         * Scripts/webkitpy/tool/steps/__init__.py:
1209         * Scripts/webkitpy/tool/steps/options.py:
1210         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1211
1212 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1213
1214         REGRESSION(r219857): run-benchmark --allplans broken
1215         https://bugs.webkit.org/show_bug.cgi?id=175186
1216
1217         Reviewed by Saam Barati.
1218
1219         r219857 forgot to update also the calls to BenchmarkRunner() that
1220         is done when the script is run with --allplans.
1221
1222         To fix this (and avoid future issues like this), let's factorize
1223         the calls to the benchhmark runner in a run_benchmark_plan()
1224         function.
1225
1226         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1227         (run_benchmark_plan):
1228         (start):
1229
1230 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1231
1232         Dashboard bubbles sometimes show failure count instead of crash count
1233         https://bugs.webkit.org/show_bug.cgi?id=175157
1234         <rdar://problem/33709009>
1235
1236         Reviewed by Alexey Proskuryakov.
1237
1238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1239         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1240
1241 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1242
1243         Add tests for NeverDestroyed
1244         https://bugs.webkit.org/show_bug.cgi?id=175146
1245
1246         Reviewed by Darin Adler.
1247
1248         * CMakeLists.txt:
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         New files and sort.
1251
1252         * TestWebKitAPI/Tests/WTF/Logger.h:
1253         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1254         (TestWebKitAPI::log):
1255         (TestWebKitAPI::takeLogStr):
1256         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1257         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1258         (TestWebKitAPI::log): Deleted.
1259         (TestWebKitAPI::takeLogStr): Deleted.
1260         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1261
1262         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1263         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1264         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1265         (TestWebKitAPI::LifecycleLogger::operator=):
1266         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1267         (TestWebKitAPI::LifecycleLogger::setName):
1268         (TestWebKitAPI::TEST):
1269         Add a class that logs construction / assignment / modifications.
1270
1271         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1272         (TestWebKitAPI::TEST):
1273         (TestWebKitAPI::list):
1274         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1275
1276 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1277
1278         minification logic is not implemented for ios builds
1279         <rdar://problem/33726561>
1280
1281         Reviewed by Dean Johnson
1282
1283         * BuildSlaveSupport/built-product-archive:
1284         (minifyDirectory): refactor minifySource -> minifyDirectory
1285         (archiveBuiltProduct): add ios minification logic
1286         (minifySource): Deleted.
1287
1288 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1289
1290         Unreviewed, rolling out r220271.
1291
1292         Rolling out due to Layout Test failing on iOS Simulator.
1293
1294         Reverted changeset:
1295
1296         "Remove STREAMS_API compilation guard"
1297         https://bugs.webkit.org/show_bug.cgi?id=175165
1298         http://trac.webkit.org/changeset/220271
1299
1300 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1301
1302         Unreviewed, rolling out r220268.
1303
1304         This change caused assertion failures on macOS and iOS Debug
1305         WK2.
1306
1307         Reverted changeset:
1308
1309         "Resource Load Statistics: Report user interaction
1310         immediately, but only when needed"
1311         https://bugs.webkit.org/show_bug.cgi?id=175090
1312         http://trac.webkit.org/changeset/220268
1313
1314 2017-08-04  Youenn Fablet  <youenn@apple.com>
1315
1316         Remove STREAMS_API compilation guard
1317         https://bugs.webkit.org/show_bug.cgi?id=175165
1318
1319         Reviewed by Darin Adler.
1320
1321         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1322
1323 2017-08-04  John Wilander  <wilander@apple.com>
1324
1325         Resource Load Statistics: Report user interaction immediately, but only when needed
1326         https://bugs.webkit.org/show_bug.cgi?id=175090
1327         <rdar://problem/33685546>
1328
1329         Reviewed by Chris Dumez.
1330
1331         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1332         (WTR::InjectedBundle::beginTesting):
1333             Now calls WebCore::ResourceLoadObserver::clearState().
1334
1335 2017-08-03  Brian Burg  <bburg@apple.com>
1336
1337         Remove ENABLE(WEB_SOCKET) guards
1338         https://bugs.webkit.org/show_bug.cgi?id=167044
1339
1340         Reviewed by Joseph Pecoraro.
1341
1342         * Scripts/webkitperl/FeatureList.pm:
1343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1344
1345 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1346
1347         REGRESSION(r219850): run-benchmark script broken on Linux
1348         https://bugs.webkit.org/show_bug.cgi?id=175126
1349
1350         Reviewed by Stephanie Lewis.
1351
1352         The run-benchmark script dynamically generates the list of supported
1353         browsers and platforms (currently Linux and OSX) by loading all
1354         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1355         and getting the browser_name and platform variables from the
1356         classes defined there.
1357
1358         This means that this classes should not raise an exception when
1359         loaded on other platforms or otherwise they will broke the whole
1360         script. Its fine if they raise an exception when executing any of
1361         the methods they implement, but not when just loading/importing
1362         the class.
1363
1364         Move the argument variable definitions that call on the platform
1365         specific OSXBrowserDriver._screen_size() function from beeing
1366         variables that are evaluated when loading the file, to be functions
1367         that are only evaluated when the actual functionality needs to be
1368         executed.
1369
1370         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1371         (OSXChromeDriver.launch_url):
1372         (OSXChromeCanaryDriver.launch_url):
1373         (create_args):
1374         (create_chrome_options):
1375         (create_window_size_arg):
1376         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1377         (OSXFirefoxDriver.launch_url):
1378         (OSXFirefoxNightlyDriver.launch_url):
1379         (OSXFirefoxNightlyDriver.launch_driver):
1380         (create_args):
1381
1382 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1383
1384         [PAL] Move spi/cf directory into PAL
1385         https://bugs.webkit.org/show_bug.cgi?id=175057
1386
1387         Reviewed by Antti Koivisto.
1388
1389         * Scripts/webkitpy/style/checker.py:
1390         * Scripts/webkitpy/style/checker_unittest.py:
1391         (GlobalVariablesTest.test_path_rules_specifier):
1392
1393         Ignore "readability/naming/underscores" style errors for sources
1394         under the WebCore/PAL/pal/spi directory.
1395
1396         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1397
1398 2017-08-03  Youenn Fablet  <youenn@apple.com>
1399
1400         Remove FETCH_API compilation guard
1401         https://bugs.webkit.org/show_bug.cgi?id=175154
1402
1403         Reviewed by Chris Dumez.
1404
1405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1406
1407 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1408
1409         Enable archive minification on iOS builds
1410         https://bugs.webkit.org/show_bug.cgi?id=174718
1411         
1412         Reviewed by Aakash Jain.
1413
1414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415         (BuildFactory.__init__):
1416
1417 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1418
1419         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1420         https://bugs.webkit.org/show_bug.cgi?id=175140
1421
1422         Reviewed by Alexey Proskuryakov.
1423
1424         We are having lately issues with JSC tests causing problems on
1425         the GTK+ and WPE bots due to the high amount of memory some tests
1426         need to run.
1427
1428         The best thing we can do now is to workaround this by disabling
1429         all the tests marked as memoryLimited on the GTK and WPE bots.
1430         We may revise this on the future.
1431
1432         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1433         (RunJavaScriptCoreTests.start):
1434
1435 2017-08-03  Brady Eidson  <beidson@apple.com>
1436
1437         Add SW IDLs and stub out basic functionality.
1438         https://bugs.webkit.org/show_bug.cgi?id=175115
1439
1440         Reviewed by Chris Dumez.
1441
1442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1443
1444         * Scripts/webkitpy/bindings/main.py:
1445
1446 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1447
1448         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1449         https://bugs.webkit.org/show_bug.cgi?id=159510
1450
1451         Reviewed by Daniel Bates.
1452
1453         Allow any https certificate when running tests.
1454
1455         * DumpRenderTree/win/DumpRenderTree.cpp:
1456         (runTest):
1457
1458 2017-08-02  Youenn Fablet  <youenn@apple.com>
1459
1460         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1461         https://bugs.webkit.org/show_bug.cgi?id=175089
1462
1463         Reviewed by Chris Dumez.
1464
1465         * DumpRenderTree/TestOptions.mm:
1466         (TestOptions::TestOptions): Using absolutePath if available.
1467         * DumpRenderTree/mac/DumpRenderTree.mm:
1468         (computeTestURL): Removing http/tests/ specific URL computation.
1469         * Scripts/webkitpy/port/driver.py:
1470         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1471
1472 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1473
1474         download-built-product should allow for a proxy option
1475         https://bugs.webkit.org/show_bug.cgi?id=174875
1476
1477         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1478
1479         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1480         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1481         
1482
1483 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1484
1485         check-webkit-style: deleting lines in a file runs the linter on the whole file
1486         https://bugs.webkit.org/show_bug.cgi?id=175078
1487
1488         Reviewed by David Kilzer.
1489
1490         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1491         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1492
1493         * Scripts/webkitpy/style/checkers/test_expectations.py:
1494         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1495         * Scripts/webkitpy/style/main_unittest.py:
1496         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1497         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1498         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1499
1500 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1501
1502         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1503         https://bugs.webkit.org/show_bug.cgi?id=175075
1504
1505         Reviewed by David Kilzer.
1506
1507         We have no way of handling text files with illegal unicode characters. Allow the callers of
1508         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1509         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1510
1511         * Scripts/webkitpy/common/system/filesystem.py:
1512         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1513         (FileSystem.write_text_file): Ditto.
1514         * Scripts/webkitpy/common/system/filesystem_mock.py:
1515         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1516         (MockFileSystem.write_text_file): Ditto.
1517         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1518         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1519         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1520
1521 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1522
1523         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1524         https://bugs.webkit.org/show_bug.cgi?id=175072
1525
1526         Reviewed by Alexey Proskuryakov.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1529         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1530
1531 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1532
1533         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1534         https://bugs.webkit.org/show_bug.cgi?id=175019
1535
1536         Reviewed by Darin Adler.
1537
1538         * TestWebKitAPI/CMakeLists.txt:
1539
1540 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1541
1542         Enabling uploading archives to S3
1543         https://bugs.webkit.org/show_bug.cgi?id=174198
1544
1545         Unreviewed unit test fix after r219235.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1548
1549 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1550
1551         Fix JSCOnly ARM buildbots after r220047
1552         https://bugs.webkit.org/show_bug.cgi?id=174993
1553
1554         Unreviewed fix after r220087.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1557         (BuildAndRemoteJSCTestsFactory.__init__):
1558
1559 2017-08-01  Chris Dumez  <cdumez@apple.com>
1560
1561         Add initial support for navigator.sendBeacon
1562         https://bugs.webkit.org/show_bug.cgi?id=175007
1563         <rdar://problem/33547728>
1564
1565         Reviewed by Sam Weinig.
1566
1567         Enable the Beacon API at runtime in the context of layout tests since the
1568         feature is currently disabled by default.
1569
1570         * DumpRenderTree/mac/DumpRenderTree.mm:
1571         (enableExperimentalFeatures):
1572         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1573         (WTR::InjectedBundle::beginTesting):
1574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1575         (WTR::TestRunner::setModernMediaControlsEnabled):
1576         (WTR::TestRunner::setBeaconAPIEnabled):
1577         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1578
1579 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1580
1581         Update Bot Watcher's Dashboard for Buildbot 0.9
1582         https://bugs.webkit.org/show_bug.cgi?id=174777
1583
1584         Reviewed by Daniel Bates.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1587         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1588         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1589         in a dictionary.
1590         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1591         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1593         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1594         (parseRevisionProperty): Ditto.
1595         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1596         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1597         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1598         have changed in Buildbot 0.9.
1599         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1600         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1601         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1602         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1603         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1604         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1605         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1606         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1607         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1608         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1610         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1611         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1612         (BuildbotQueue.prototype.get overviewURL): Ditto.
1613         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1614         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1615         Buildbot 0.8 or 0.9.
1616         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1617         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1618         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1619         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1620         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1621         Therefore we are fetching information for fixed number of build. 
1622         Also iterating the loop incrementally since the build data is already reverse sorted.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1624         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1625         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1627         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1628
1629 2017-08-01  Devin Rousso  <drousso@apple.com>
1630
1631         Web Inspector: simplify WebInspector with WI
1632         https://bugs.webkit.org/show_bug.cgi?id=175058
1633
1634         Reviewed by Joseph Pecoraro.
1635
1636         * Scripts/check-inspector-strings:
1637         (extract_ui_strings):
1638         * Scripts/extract-localizable-js-strings:
1639
1640 2017-08-01  Youenn Fablet  <youenn@apple.com>
1641
1642         Layout tests with 'https' suffix should be run over HTTPS
1643         https://bugs.webkit.org/show_bug.cgi?id=174992
1644
1645         Reviewed by Chris Dumez.
1646
1647         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1648         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1649         Covered by corresponding unit tests.
1650
1651         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1652         (run_server):
1653         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1654         (base_http_url):
1655         (base_https_url):
1656         (base_url): Deleted.
1657         * Scripts/webkitpy/port/base.py:
1658         (Port.to.web_platform_test_server_base_http_url):
1659         (Port.to):
1660         (Port.to.web_platform_test_server_base_https_url):
1661         (Port.to.web_platform_test_server_base_url): Deleted.
1662         * Scripts/webkitpy/port/driver.py:
1663         (Driver.__init__):
1664         (Driver.wpt_test_path_to_uri):
1665         (Driver):
1666         (Driver.http_test_path_to_uri):
1667         (Driver.test_to_uri):
1668         (Driver.uri_to_test):
1669         * Scripts/webkitpy/port/driver_unittest.py:
1670         (DriverTest.test_test_to_uri):
1671         (DriverTest.test_uri_to_test):
1672
1673 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1674
1675         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1676         https://bugs.webkit.org/show_bug.cgi?id=173998
1677
1678         Reviewed by Darin Adler.
1679
1680         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1681         detect mistakes in backward compatibility in the future when we change it.
1682
1683         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1684         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1685         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1686         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1687         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1688         internal key data slot.
1689
1690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1691         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1692         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1693         (getNextMessage):
1694         (TEST):
1695         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1696         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1697         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1698         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1699         These are the pre-baked databases.
1700         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1701         This is the actual test that do all the reads and comparisons.
1702         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1703         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1704         IndexedDB new stuffs. Then it can be used to bake the database again.
1705
1706 2017-08-01  Brady Eidson  <beidson@apple.com>
1707
1708         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1709         https://bugs.webkit.org/show_bug.cgi?id=175030
1710
1711         Reviewed by Andy Estes.
1712
1713         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1714         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1715
1716 2017-08-01  Brady Eidson  <beidson@apple.com>
1717
1718         Part 2 of: Rename DatabaseProcess to StorageProcess.
1719         https://bugs.webkit.org/show_bug.cgi?id=174880
1720
1721         Reviewed by Andy Estes.
1722
1723         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1724         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1725         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1726         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1727         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1728         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1729         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1731
1732 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1733
1734         Fix JSCOnly ARM buildbots after r220047
1735         https://bugs.webkit.org/show_bug.cgi?id=174993
1736
1737         Reviewed by Saam Barati.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1740         (BuildAndRemoteJSCTestsFactory.__init__):
1741
1742 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1743
1744         [WTF] Introduce Private Symbols
1745         https://bugs.webkit.org/show_bug.cgi?id=174935
1746
1747         Reviewed by Darin Adler.
1748
1749         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1750         (TestWebKitAPI::TEST):
1751
1752 2017-07-30  Darin Adler  <darin@apple.com>
1753
1754         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1755         https://bugs.webkit.org/show_bug.cgi?id=130653
1756
1757         Reviewed by Antti Koivisto.
1758
1759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1760         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1761         when calling frameDidChangeLocation.
1762         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1763         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1764         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1765         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1766         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1767         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1768         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1769         loading, subframe starts loading. It would be good to clean that up some day, but for now
1770         this patch makes the two work identically rather than changing both.
1771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1772
1773 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1774
1775         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1776         https://bugs.webkit.org/show_bug.cgi?id=174963
1777
1778         Reviewed by Darin Adler.
1779
1780         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1781         RetainPtr<>. This patch changes them to all use auto.
1782
1783         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1784         (TestWebKitAPI::TEST):
1785
1786 2017-07-30  Brady Eidson  <beidson@apple.com>
1787
1788         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1789         https://bugs.webkit.org/show_bug.cgi?id=174958
1790
1791         Reviewed by Darin Adler.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1795         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1796         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1797         (runUntilTasksInFlight):
1798         (TEST):
1799
1800 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1801
1802         Unreviewed, rolling out r219990.
1803         https://bugs.webkit.org/show_bug.cgi?id=174961
1804
1805         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1806         estes on #webkit).
1807
1808         Reverted changeset:
1809
1810         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1811         https://bugs.webkit.org/show_bug.cgi?id=174880
1812         http://trac.webkit.org/changeset/219990
1813
1814 2017-07-28  Brady Eidson  <beidson@apple.com>
1815
1816         API tests that use URLSchemeHandler are failing.
1817         https://bugs.webkit.org/show_bug.cgi?id=174950
1818
1819         Reviewed by Alex Christensen.
1820
1821         Fix the NoMIMEType test to be correct.
1822
1823         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1824         (-[SchemeHandler initWithData:mimeType:]):
1825         (-[SchemeHandler webView:startURLSchemeTask:]):
1826         (TEST):
1827
1828 2017-07-28  Daniel Bates  <dabates@apple.com>
1829
1830         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1831         https://bugs.webkit.org/show_bug.cgi?id=174876
1832
1833         Reviewed by Alex Christensen.
1834
1835         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1836         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1837         they provide a more direct way to test the platform abstraction.
1838
1839         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1840
1841         * Scripts/prepare-ChangeLog:
1842         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1843         of the current working directory.
1844
1845 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1846
1847         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1848         https://bugs.webkit.org/show_bug.cgi?id=174930
1849
1850         Unreviewed test fix.
1851
1852         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1853
1854         * Scripts/prepare-ChangeLog:
1855         (get_function_line_ranges_for_cpp):
1856
1857 2017-07-28  JF Bastien  <jfbastien@apple.com>
1858
1859         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1860         https://bugs.webkit.org/show_bug.cgi?id=174930
1861
1862         Reviewed by Daniel Bates.
1863
1864         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1865         here also teach it about const and volatile overloads. I didn't do
1866         reference and rvalue reference overloads because we don't really
1867         use them, and the current parser throws away those characters and
1868         it doesn't seem worth making it more complex.
1869
1870         * Scripts/prepare-ChangeLog:
1871         (get_function_line_ranges_for_cpp):
1872         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1873         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1874         (Foo::Arrow::arrow):
1875         (Foo::Arrow::otherArrow):
1876         (Foo::Arrow::otherArrow const):
1877         (Foo::Arrow::otherArrow volatile):
1878         (Foo::Arrow::otherArrow const volatile):
1879
1880 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1881
1882         [GTK] Building with ENABLE_VIDEO=OFF fails
1883         https://bugs.webkit.org/show_bug.cgi?id=174940
1884
1885         Reviewed by Alex Christensen.
1886
1887         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1888         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1889
1890         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1891         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1892
1893 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1894
1895         [WPE] Implement EventSenderProxy in WTR
1896         https://bugs.webkit.org/show_bug.cgi?id=173419
1897
1898         Reviewed by Žan Doberšek.
1899
1900         Add the implementation of EventSenderProxy to the WTR. This
1901         allows us to extend the coverage of the test suite in WKWPE.
1902
1903         * WebKitTestRunner/EventSenderProxy.h:
1904         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1905         libxkbcommon needed to deal with key events.
1906         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1907         (WTR::EventSenderProxy::EventSenderProxy):
1908         (WTR::senderButtonToWPEButton):
1909         (WTR::EventSenderProxy::mouseDown):
1910         (WTR::EventSenderProxy::mouseUp):
1911         (WTR::EventSenderProxy::mouseMoveTo):
1912         (WTR::EventSenderProxy::mouseScrollBy):
1913         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1914         (WTR::EventSenderProxy::leapForward):
1915         (WTR::wkEventModifiersToWPE):
1916         (WTR::getXKBKeySymForKeyRef):
1917         (WTR::EventSenderProxy::keyDown):
1918         (WTR::EventSenderProxy::addTouchPoint):
1919         (WTR::EventSenderProxy::updateTouchPoint):
1920         (WTR::EventSenderProxy::setTouchModifier):
1921         (WTR::EventSenderProxy::setTouchPointRadius):
1922         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1923         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1924         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1925         (WTR::EventSenderProxy::touchStart):
1926         (WTR::EventSenderProxy::touchMove):
1927         (WTR::EventSenderProxy::touchEnd):
1928         (WTR::EventSenderProxy::touchCancel):
1929         (WTR::EventSenderProxy::clearTouchPoints):
1930         (WTR::EventSenderProxy::releaseTouchPoint):
1931         (WTR::EventSenderProxy::cancelTouchPoint):
1932
1933 2017-07-27  Brady Eidson  <beidson@apple.com>
1934
1935         Part 2 of: Rename DatabaseProcess to StorageProcess.
1936         https://bugs.webkit.org/show_bug.cgi?id=174880
1937
1938         Reviewed by Andy Estes.
1939
1940         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1942         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1943         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1944         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1945         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1946         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1947         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1948
1949 2017-07-26  Mark Lam  <mark.lam@apple.com>
1950
1951         Add ability to only run specific tests in run-javascriptcore-tests.
1952         https://bugs.webkit.org/show_bug.cgi?id=174884
1953
1954         Reviewed by Saam Barati.
1955
1956         For example, if we only want to run testapi, we can do so as follows:
1957             $ run-javascriptcore-tests --testapi
1958
1959         Previously, specifying --testapi effectively does nothing because we run all tests
1960         by default.  Only --no-testapi had the effect of disabling the test set.  This
1961         old behavior for --testapi is not very useful or meaningful.  We're now changing
1962         it to mean that we will only run that test.
1963
1964         With this change, we can also run more than one set of tests.  For example, if we
1965         only want to run testmasm and testair, we can do so as follows:
1966             $ run-javascriptcore-tests --testmasm --testair
1967
1968         By default, if no specific test option is specified, run-javascriptcore-tests will
1969         run all tests.
1970
1971         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1972         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1973         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1974         the other set will not run.  For example, the following only runs the mozilla tests:
1975             $ run-javascriptcore-tests --mozilla-tests
1976
1977         Note also that --jit-stress-tests is not for choosing a different set of tests.
1978         Instead, it is used for determining whether we run JIT'ed test configurations
1979         on the jsc stress tests and mozilla tests.  As a result, specifying
1980         --jit-stress-tests will not omit other tests.  For example, the following still
1981         runs all tests:
1982             $ run-javascriptcore-tests --jit-stress-tests
1983
1984         * Scripts/run-javascriptcore-tests:
1985         (defaultStringForTestState):
1986         (enableTestOrNot):
1987         (runJSCStressTests):
1988
1989 2017-07-26  Mark Lam  <mark.lam@apple.com>
1990
1991         Make run-javascriptcore-test run testair, testb3, and testmasm.
1992         https://bugs.webkit.org/show_bug.cgi?id=174837
1993         <rdar://problem/33522927>
1994
1995         Reviewed by Saam Barati and Filip Pizlo.
1996
1997         1. Refactors code for running testapi so that we can use it to run other tests.
1998         2. Added running of testmasm, testair, testb3.
1999
2000         Note: the existing testapi invocation code does not support remote invocation of
2001         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2002         and testb3 also do not support remote invocation.  If we wish to add remote
2003         invocation support, we should do that in a separate patch.
2004
2005         * Scripts/run-javascriptcore-tests:
2006         (testPath):
2007         (runTest):
2008         (testapiPath): Deleted.
2009
2010 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2011
2012         Remove duplicate code from Buildbot.js in dashboard
2013         https://bugs.webkit.org/show_bug.cgi?id=174870
2014
2015         Reviewed by Daniel Bates.
2016
2017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2018         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2019         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2021         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2022
2023 2017-07-26  Brady Eidson  <beidson@apple.com>
2024
2025         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2026         https://bugs.webkit.org/show_bug.cgi?id=174851
2027
2028         Reviewed by Chris Dumez.
2029
2030         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2031         (TEST):
2032
2033 2017-07-26  Brian Burg  <bburg@apple.com>
2034
2035         Remove WEB_TIMING feature flag
2036         https://bugs.webkit.org/show_bug.cgi?id=174795
2037
2038         Reviewed by Alex Christensen.
2039
2040         * Scripts/webkitperl/FeatureList.pm:
2041         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2042
2043 2017-07-26  Chris Dumez  <cdumez@apple.com>
2044
2045         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2046         https://bugs.webkit.org/show_bug.cgi?id=174864
2047         <rdar://problem/33009088>
2048
2049         Reviewed by Geoffrey Garen.
2050
2051         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2052         WKTR.
2053
2054         * DumpRenderTree/mac/EventSendingController.mm:
2055         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2056
2057 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2058
2059         Unreviewed, added Romain Bellessort to contributors.json.
2060
2061         * Scripts/webkitpy/common/config/contributors.json:
2062
2063 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2064
2065         [WPE] WebGL2 support
2066         https://bugs.webkit.org/show_bug.cgi?id=174249
2067
2068         Reviewed by Alex Christensen.
2069
2070         * Scripts/webkitperl/FeatureList.pm:
2071         Enable WebGL2 for WPE when building through build-webkit.
2072
2073 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2074
2075         Unreviewed. Fix GTK distcheck.
2076
2077         * gtk/make-dist.py:
2078         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2079
2080 2017-07-25  Brady Eidson  <beidson@apple.com>
2081
2082         ResourceLoadStatistics grandfathering happens much too often.
2083         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2084
2085         Reviewed by Chris Dumez.
2086
2087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2088         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2089         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2090         (TEST):
2091
2092 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2093
2094         Fix autoinstaller failing on autoinstall_everything
2095         https://bugs.webkit.org/show_bug.cgi?id=174830
2096
2097         Reviewed by Joseph Pecoraro.
2098
2099         * Scripts/webkitpy/thirdparty/__init__.py:
2100         (AutoinstallImportHook.find_module):
2101         (AutoinstallImportHook.install_chromedriver):
2102         (AutoinstallImportHook.install_geckodriver):
2103         (AutoinstallImportHook._install_chromedriver): Deleted.
2104         (AutoinstallImportHook._install_geckodriver): Deleted.
2105
2106 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2107
2108         Replace --runtime with something for both ios-simulator and ios-device
2109         https://bugs.webkit.org/show_bug.cgi?id=173775
2110         <rdar://problem/32952164>
2111
2112         Reviewed by Aakash Jain.
2113
2114         Add --version flag for both iOS simulator and iOS device.
2115
2116         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2117         (parse_args): Add --version flag and move --no-install.
2118         * Scripts/webkitpy/port/factory.py:
2119         (platform_options): Move --no-intall to run_webkit_tests.py.
2120         * Scripts/webkitpy/port/ios.py:
2121         (IOSPort):
2122         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2123         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2124         * Scripts/webkitpy/port/ios_device.py:
2125         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2126         devices for iOS version.
2127         * Scripts/webkitpy/port/ios_device_unittest.py:
2128         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2129         expectation paths without devices connected.
2130         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2131         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2132         (IOSDeviceTest.test_expectations_ordering): Deleted.
2133         * Scripts/webkitpy/port/ios_simulator.py:
2134         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2135         flag to specify a runtime.
2136         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2137         flag and then use the default runtime.
2138
2139 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2140
2141         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2142         https://bugs.webkit.org/show_bug.cgi?id=174815
2143
2144         Reviewed by Carlos Alberto Lopez Perez.
2145
2146         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2147         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2148         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2149         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2150         think), probably because of a newer CMake version.
2151
2152         * CMakeLists.txt:
2153         * TestWebKitAPI/CMakeLists.txt:
2154         * TestWebKitAPI/PlatformGTK.cmake:
2155
2156 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2157
2158         Fix BenchmarkRunner to only import selenium when needed
2159         https://bugs.webkit.org/show_bug.cgi?id=174808
2160
2161         Reviewed by Stephanie Lewis.
2162
2163         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2164         (LinuxChromeDriver.launch_driver):
2165         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2166         (LinuxFirefoxDriver.launch_driver):
2167         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2168         (OSXChromeDriver.launch_driver):
2169         (OSXChromeCanaryDriver.launch_driver):
2170         (create_chrome_options):
2171         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2172         (OSXFirefoxDriver.launch_driver):
2173         (OSXFirefoxNightlyDriver.launch_driver):
2174         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2175         (OSXSafariDriver.launch_driver):
2176         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2177         (WebDriverBenchmarkRunner._run_one_test):
2178
2179 2017-07-23  Darin Adler  <darin@apple.com>
2180
2181         More NeverDestroyed and related cleanup
2182         https://bugs.webkit.org/show_bug.cgi?id=174745
2183
2184         Reviewed by Alex Christensen.
2185
2186         * DumpRenderTree/JavaScriptThreading.cpp:
2187         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2188         DEPRECATED_DEFINE_STATIC_LOCAL.
2189         (javaScriptThreads): Ditto.
2190
2191 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2192
2193         Subclass Benchmark Runner script for WebDriver support
2194         https://bugs.webkit.org/show_bug.cgi?id=174390
2195
2196         Reviewed by Dewei Zhu, Stephanie Lewis.
2197
2198         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2199
2200         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2201         (BenchmarkBuilder.__init__):
2202         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2203         (BenchmarkRunner.__init__):
2204         (BenchmarkRunner._find_plan_file):
2205         (BenchmarkRunner._run_one_test.and):
2206         (BenchmarkRunner.execute):
2207         (BenchmarkRunner._get_result): Deleted.
2208         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2209         (parse_args):
2210         (start):
2211         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2212         (WebDriverBenchmarkRunner):
2213         (WebDriverBenchmarkRunner._get_result):
2214         (WebDriverBenchmarkRunner._run_one_test):
2215         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2216         (WebServerBenchmarkRunner):
2217         (WebServerBenchmarkRunner.__init__):
2218         (WebServerBenchmarkRunner._get_result):
2219         (WebServerBenchmarkRunner._run_one_test):
2220
2221 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2222
2223         Add BenchmarkRunner patches with WebDriver support for each testing plan
2224         https://bugs.webkit.org/show_bug.cgi?id=174443
2225
2226         Reviewed by Dewei Zhu, Stephanie Lewis.
2227
2228         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2229         (BenchmarkBuilder.__enter__):
2230         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2231         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2232         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2233         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2234         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2235         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2236         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2237         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2238         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2239         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2240         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2241         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2242         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2243         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2244         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2245         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2246         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2247         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2248         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2249         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2250         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2251         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2252         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2253         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2254         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2255         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2256         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2257         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2258         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2259         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2260         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2261         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2262         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2263
2264 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2265
2266         Add functions to autoinstaller needed for Benchmark Runner script
2267         https://bugs.webkit.org/show_bug.cgi?id=174331
2268
2269         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2270
2271         Adds autoinstaller functions to install selenium and webdriver binaries
2272         which will be used by the browser driver part of Benchmark Runner.
2273
2274         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2275         (BrowserDriver.restore_env):
2276         (BrowserDriver):
2277         (BrowserDriver.get_webdriver_binary_path):
2278         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2279         (LinuxChromeDriver.launch_driver):
2280         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2281         (LinuxFirefoxDriver.launch_driver):
2282         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2283         (OSXChromeDriver.launch_driver):
2284         (OSXChromeCanaryDriver.launch_driver):
2285         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2286         (OSXFirefoxDriver.launch_driver):
2287         (OSXFirefoxNightlyDriver.launch_driver):
2288         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2289         * Scripts/webkitpy/benchmark_runner/utils.py:
2290         (get_driver_binary_path):
2291         * Scripts/webkitpy/common/system/autoinstall.py:
2292         (AutoInstaller._unzip):
2293         * Scripts/webkitpy/thirdparty/__init__.py:
2294         (AutoinstallImportHook.find_module):
2295         (AutoinstallImportHook._install_selenium):
2296         (AutoinstallImportHook):
2297         (AutoinstallImportHook._install_chromedriver):
2298         (AutoinstallImportHook._install_geckodriver):
2299         (AutoinstallImportHook.get_latest_pypi_url):
2300         (AutoinstallImportHook.install_binary):
2301         (autoinstall_everything):
2302         (get_driver_filename):
2303         (get_os_info):
2304
2305 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2306
2307         Add WebDriver support in browser driver part of BenchmarkRunner
2308         https://bugs.webkit.org/show_bug.cgi?id=174445
2309
2310         Reviewed by Stephanie Lewis.
2311
2312         Adds a launch_driver function to each BrowserDriver subclass. This
2313         function sets up the arguments for the webdriver and launches the
2314         webdriver specific to that browser.
2315
2316         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2317         (BrowserDriver.launch_webdriver):
2318         (BrowserDriver):
2319         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2320         (LinuxBrowserDriver.launch_webdriver):
2321         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2322         (LinuxChromeDriver.launch_url):
2323         (LinuxChromeDriver):
2324         (LinuxChromeDriver.launch_driver):
2325         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2326         (EpiphanyBrowserDriver.launch_url):
2327         (EpiphanyBrowserDriver):
2328         (EpiphanyBrowserDriver.launch_driver):
2329         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2330         (LinuxFirefoxDriver):
2331         (LinuxFirefoxDriver.launch_url):
2332         (LinuxFirefoxDriver.launch_driver):
2333         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2334         (GTKMiniBrowserDriver.launch_url):
2335         (GTKMiniBrowserDriver):
2336         (GTKMiniBrowserDriver.launch_driver):
2337         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2338         (OSXBrowserDriver._launch_webdriver):
2339         (OSXBrowserDriver):
2340         (OSXBrowserDriver._screen_size):
2341         (OSXBrowserDriver._insert_url):
2342         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2343         (OSXChromeDriver):
2344         (OSXChromeDriver.launch_url):
2345         (OSXChromeDriver.launch_driver):
2346         (OSXChromeCanaryDriver):
2347         (OSXChromeCanaryDriver.launch_url):
2348         (OSXChromeCanaryDriver.launch_driver):
2349         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2350         (OSXFirefoxDriver):
2351         (OSXFirefoxDriver.launch_url):
2352         (OSXFirefoxDriver.launch_driver):
2353         (OSXFirefoxNightlyDriver):
2354         (OSXFirefoxNightlyDriver.launch_url):
2355         (OSXFirefoxNightlyDriver.launch_driver):
2356         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2357         (OSXSafariDriver.launch_driver):
2358
2359 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2360
2361         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2362         https://bugs.webkit.org/show_bug.cgi?id=174793
2363
2364         Reviewed by Tim Horton.
2365
2366         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2367         down. Without r219765, this test will dereference null and crash.
2368
2369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2370         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2371         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2372         (TEST):
2373
2374 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2375
2376         [Win] Implement Authentication dialog in MiniBrowser
2377         https://bugs.webkit.org/show_bug.cgi?id=174662
2378
2379         Reviewed by Alex Christensen.
2380
2381         * MiniBrowser/win/Common.cpp:
2382         (CustomUserAgent):
2383         (DisplayAuthDialog):
2384         (AuthDialogProc):
2385         * MiniBrowser/win/MiniBrowserLib.rc:
2386         * MiniBrowser/win/MiniBrowserLibResource.h:
2387         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2388         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2389
2390 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2391
2392         Handle case where line_numbers is None instead of an array of line numbers
2393         https://bugs.webkit.org/show_bug.cgi?id=174775
2394
2395         Reviewed by Aakash Jain.
2396
2397         Added files set line_numbers to None in process_file.
2398
2399         * Scripts/webkitpy/style/filereader.py:
2400         (TextFileReader.process_file): Handle case where line_number is set to None.
2401         * Scripts/webkitpy/style/main_unittest.py:
2402         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2403
2404 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2405
2406         [WPE] Add libepoxy to the Jhbuild moduleset
2407         https://bugs.webkit.org/show_bug.cgi?id=174711
2408
2409         Reviewed by Carlos Alberto Lopez Perez.
2410
2411         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2412
2413 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2414
2415         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2416         https://bugs.webkit.org/show_bug.cgi?id=174780
2417
2418         Reviewed by Carlos Garcia Campos.
2419
2420         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2421         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2422         in case the eglplatform.h header doesn't provide that macro. This replicates
2423         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2424
2425 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2426
2427         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2428         https://bugs.webkit.org/show_bug.cgi?id=174758
2429
2430         Reviewed by Dan Bernstein.
2431
2432         Migrate position-information-related unit tests from the PositionInformationTests suite to
2433         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2434
2435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2436         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2437         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2438         (TestWebKitAPI::TEST):
2439         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2440         * TestWebKitAPI/cocoa/TestWKWebView.h:
2441         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2442         (-[TestWKWebView activatedElementAtPosition:]):
2443
2444 2017-07-22  Chris Dumez  <cdumez@apple.com>
2445
2446         REGRESSION(r204565): WKObject is broken
2447         https://bugs.webkit.org/show_bug.cgi?id=174736
2448         <rdar://problem/33246169>
2449
2450         Reviewed by Dan Bernstein.
2451
2452         Add API test that used to crash.
2453
2454         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2455         (TestWebKitAPI::TEST):
2456
2457 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2458
2459         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2460         https://bugs.webkit.org/show_bug.cgi?id=174705
2461
2462         Reviewed by Mark Lam.
2463
2464         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2465         (TestWebKitAPI::testThreadGroup):
2466         (TestWebKitAPI::TEST):
2467
2468 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2469
2470         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2471         https://bugs.webkit.org/show_bug.cgi?id=174724
2472
2473         Reviewed by Aakash Jain.
2474
2475         * Scripts/webkitpy/port/ios_simulator.py:
2476         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2477         simulator. Errors here should be treated the same as no simulators found.
2478
2479 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2480
2481         [CMake] Add an option to stop build after generating project files
2482         https://bugs.webkit.org/show_bug.cgi?id=174664
2483
2484         Reviewed by Konstantin Tokarev.
2485
2486         Add "--generate-project-only" to stop build after generating project files.
2487
2488         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2489         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2490         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2491         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2492         (isGenerateProjectOnly): ditto
2493
2494 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2495
2496         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2497         https://bugs.webkit.org/show_bug.cgi?id=174501
2498
2499         Reviewed by Darin Adler.
2500
2501         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2502         (TestWebKitAPI::TEST):
2503
2504 2017-07-20  David Quesada  <david_quesada@apple.com>
2505
2506         Add SPI to notify WKNavigationDelegate about client redirects
2507         https://bugs.webkit.org/show_bug.cgi?id=174680
2508         rdar://problem/33184886
2509
2510         Reviewed by Brady Eidson.
2511
2512         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2513         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2514         (TEST):
2515         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2516
2517 2017-07-20  Brady Eidson  <beidson@apple.com>
2518
2519         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2520         https://bugs.webkit.org/show_bug.cgi?id=174685
2521
2522         Reviewed by Andy Estes.
2523
2524         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2525         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2526
2527 2017-07-20  Brady Eidson  <beidson@apple.com>
2528
2529         Deprecate WebIconDatabase in WebKitLegacy/mac.
2530         https://bugs.webkit.org/show_bug.cgi?id=174607
2531
2532         Reviewed by Alex Christensen.
2533
2534         * DumpRenderTree/mac/TestRunnerMac.mm:
2535
2536 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2537
2538         lint-test-expectations should be run during style checking
2539         https://bugs.webkit.org/show_bug.cgi?id=173559
2540         <rdar://problem/32854941>
2541
2542         Reviewed by Aakash Jain.
2543
2544         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2545         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2546         prevents identifying errors on specific lines in a file.
2547         * Scripts/webkitpy/style/main_unittest.py:
2548         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2549         case where a linter error is in the file modified, but the line modified is not related to
2550         the linter error.
2551
2552 2017-07-20  Brady Eidson  <beidson@apple.com>
2553
2554         Remove WebIconDatabase from WebKitLegacy/win.
2555         https://bugs.webkit.org/show_bug.cgi?id=174608
2556
2557         Reviewed by Alex Christensen.
2558
2559         * DumpRenderTree/win/DumpRenderTree.cpp:
2560         (main):
2561         * DumpRenderTree/win/TestRunnerWin.cpp:
2562         (TestRunner::setIconDatabaseEnabled):
2563
2564 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2565
2566         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2567         https://bugs.webkit.org/show_bug.cgi?id=174671
2568
2569         Reviewed by Carlos Garcia Campos.
2570
2571         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2572         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2573         priority for this source in order to have it dispatched on the same
2574         priority as the other WebKit-controlled GSource objects.
2575
2576 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2577
2578         lint-test-expectations should be run during style checking
2579         https://bugs.webkit.org/show_bug.cgi?id=173559
2580         <rdar://problem/32854941>
2581
2582         Reviewed by Daniel Bates.
2583
2584         Follow up fix addressing style and a few minor bugs.
2585
2586         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2587         (TestExpectationParser.__init__): Use lambda x: x instead of str
2588         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2589         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2590         reduce the calls of _shorten_filename, fix minor bug in appending the current
2591         expectation's line number instead of the previous ones, clarify treatment of None
2592         in file-to-line-number mapping.
2593         (TestExpectations._report_warnings): Collapse call.
2594         * Scripts/webkitpy/style/checkers/test_expectations.py:
2595         (TestExpectationsChecker.lint_test_expectations):
2596         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2597         (TextFileReader.process_file): Add comment explaining treatment of None in
2598         file-to-line-number mapping.
2599         (TextFileReader.delete_file): Collapse call.
2600
2601 2017-07-19  Chris Dumez  <cdumez@apple.com>
2602
2603         Unreviewed attempt to fix API test failure after r219663.
2604
2605         The test was hard-coding an exception string and the string has changed slightly
2606         in r219663.
2607
2608         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2609         (TEST):
2610
2611 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2612
2613         Don't write file URLs to iOS Pasteboard
2614         https://bugs.webkit.org/show_bug.cgi?id=174647
2615         <rdar://problem/33199730>
2616
2617         Reviewed by Wenson Hsieh.
2618
2619         Updating tests to reflect the lack of file URLs for images.
2620
2621         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2622         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2623         (checkEstimatedSize):
2624         (TestWebKitAPI::TEST):
2625
2626 2017-07-19  Brady Eidson  <beidson@apple.com>
2627
2628         iBooks sometimes crashes when closing a book.
2629         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2630
2631         Reviewed by Oliver Hunt.
2632
2633         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2634         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2635         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2636         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2637         (TestWebKitAPI::TEST):
2638
2639         Add a "spin the runloop X number of times" utility:
2640         * TestWebKitAPI/Utilities.h:
2641         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2642         (TestWebKitAPI::Util::spinRunLoop):
2643
2644 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2645
2646         lint-test-expectations should be run during style checking
2647         https://bugs.webkit.org/show_bug.cgi?id=173559
2648         <rdar://problem/32854941>
2649
2650         Reviewed by David Kilzer.
2651
2652         Running the test expectation linter requires reading both files and lines not in the
2653         patch because, for example, deletion of a test can cause a lint failure even though
2654         no test expectations where modified. This means that the linter will occasionally warn
2655         about lines which were not changed in a given patch but whose error is related to a
2656         change made in that patch.
2657
2658         * Scripts/webkitpy/common/system/filesystem_mock.py:
2659         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2660         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2661         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2662         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2663         content, description of the error and the name of the associated test.
2664         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2665         (TestExpectationParser.__init__): Pass shorten_filename function to
2666         TestExpectationsParser to add a deleted file to the related_files dictionary.
2667         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2668         missing path to the related_files dictionary.
2669         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2670         files and line numbers related to this test expectation line. This will allow
2671         tracking linter errors in the style checker occurring across multiple files.
2672         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2673         lines to related_files dictionary.
2674         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2675         (TestExpectations._report_warnings): Construct warning object instead of string
2676         when adding to warnings list.
2677         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2678         clean-up log.
2679         * Scripts/webkitpy/style/checker.py:
2680         (ProcessorBase.do_association_check): Add required function for processor classes.
2681         (StyleProcessor):
2682         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2683         checking for errors between associated files.
2684         * Scripts/webkitpy/style/checkers/test_expectations.py:
2685         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2686         (TestExpectationsChecker):
2687         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2688         of modified files, the current working directory and the host, determine if the linter
2689         warning is associated with the changes.
2690         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2691         style checker.
2692         * Scripts/webkitpy/style/filereader.py:
2693         (TextFileReader):
2694         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2695         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2696         (TextFileReader.process_file): Track both the number of files changed and which lines
2697         in those files were changed.
2698         (TextFileReader.do_association_check): Run the processor's association check on all
2699         modified or deleted files processed by TextFileReader.
2700         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2701         (TextFileReader.count_delete_only_file): Deleted.
2702         * Scripts/webkitpy/style/filereader_unittest.py:
2703         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2704         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2705         * Scripts/webkitpy/style/main.py:
2706         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2707         explicitly run the association check on the file reader.
2708         * Scripts/webkitpy/style/main_unittest.py:
2709         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2710         embedded in the style checker.
2711         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2712         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2713         construct the TextFileReader object with a StyleProcessor used to run style checks on
2714         specific files.
2715         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2716         testing the test expectation linter inside the style checker. This host must contain a
2717         mock file system with the basic structure of test expectations.
2718         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2719         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2720         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2721         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2722         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2723         * Scripts/webkitpy/style/patchreader.py:
2724         (PatchReader.check): Specify which file was deleted, run the association check.
2725         * Scripts/webkitpy/style/patchreader_unittest.py:
2726         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2727         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2728         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2729
2730 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2731
2732         [WTF] Implement WTF::ThreadGroup
2733         https://bugs.webkit.org/show_bug.cgi?id=174081
2734
2735         Reviewed by Mark Lam.
2736
2737         Add WTF::ThreadGroup tests.
2738
2739         * TestWebKitAPI/CMakeLists.txt:
2740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2741         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2742         (TestWebKitAPI::testThreadGroup):
2743         (TestWebKitAPI::TEST):
2744
2745 2017-07-18  Andy Estes  <aestes@apple.com>
2746
2747         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2748         https://bugs.webkit.org/show_bug.cgi?id=174631
2749
2750         Reviewed by Tim Horton.
2751
2752         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2753         * MiniBrowser/Configurations/Base.xcconfig:
2754         * MobileMiniBrowser/Configurations/Base.xcconfig:
2755         * TestWebKitAPI/Configurations/Base.xcconfig:
2756         * WebKitTestRunner/Configurations/Base.xcconfig:
2757
2758 2017-07-18  Andy Estes  <aestes@apple.com>
2759
2760         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2761         https://bugs.webkit.org/show_bug.cgi?id=174631
2762
2763         Reviewed by Sam Weinig.
2764
2765         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2766         * MiniBrowser/Configurations/Base.xcconfig:
2767         * MobileMiniBrowser/Configurations/Base.xcconfig:
2768         * TestWebKitAPI/Configurations/Base.xcconfig:
2769         * WebKitTestRunner/Configurations/Base.xcconfig:
2770
2771 2017-07-18  Daniel Bates  <dabates@apple.com>
2772
2773         lldb: Add type summary for StringView
2774         https://bugs.webkit.org/show_bug.cgi?id=174637
2775
2776         Reviewed by Sam Weinig.
2777
2778         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2779         StringView object will print output that has the form:
2780
2781             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2782               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2783               m_length = 2
2784               m_is8Bit = true
2785               m_underlyingString = 0x0000614000000a90
2786             }
2787
2788         * lldb/lldb_webkit.py:
2789         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2790         (WTFStringView_SummaryProvider):
2791         (WTFStringViewProvider):
2792         (WTFStringViewProvider.__init__):
2793         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2794         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2795         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2796         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2797
2798 2017-07-18  Andy Estes  <aestes@apple.com>
2799
2800         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2801         https://bugs.webkit.org/show_bug.cgi?id=174631
2802
2803         Reviewed by Dan Bernstein.
2804
2805         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2806         * MiniBrowser/Configurations/Base.xcconfig:
2807         * MobileMiniBrowser/Configurations/Base.xcconfig:
2808         * TestWebKitAPI/Configurations/Base.xcconfig:
2809         * WebKitTestRunner/Configurations/Base.xcconfig:
2810
2811 2017-07-18  Devin Rousso  <drousso@apple.com>
2812
2813         Web Inspector: Add memoryCost to Inspector Protocol objects
2814         https://bugs.webkit.org/show_bug.cgi?id=174478
2815
2816         Reviewed by Joseph Pecoraro.
2817
2818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2820         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2821         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2822         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2823         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2824         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2825         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2826         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2827         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2828         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2829         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2830         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2831         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2832         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2833         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2834         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2835
2836 2017-07-18  Andy Estes  <aestes@apple.com>
2837
2838         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2839         https://bugs.webkit.org/show_bug.cgi?id=174631
2840
2841         Reviewed by Darin Adler.
2842
2843         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2844         * MiniBrowser/Configurations/Base.xcconfig:
2845         * MobileMiniBrowser/Configurations/Base.xcconfig:
2846         * TestWebKitAPI/Configurations/Base.xcconfig:
2847         * WebKitTestRunner/Configurations/Base.xcconfig:
2848
2849 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2850
2851         Unreviewed, fix the iOS build.
2852
2853         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2854
2855         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2856         (TestWebKitAPI::TEST):
2857
2858 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2859
2860         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2861         https://bugs.webkit.org/show_bug.cgi?id=174585
2862         <rdar://problem/33302541>
2863
2864         Reviewed by Tim Horton.
2865
2866         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2867         being dragged when initiating a drag.
2868
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2870         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2871         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2872         (TestWebKitAPI::TEST):
2873         * TestWebKitAPI/cocoa/TestWKWebView.h:
2874
2875         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2876
2877         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2878         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2879
2880 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2881
2882         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2883         https://bugs.webkit.org/show_bug.cgi?id=174547
2884
2885         Reviewed by Alex Christensen.
2886
2887         * DumpRenderTree/PlatformWin.cmake:
2888         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2889
2890 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2891
2892         Update style checker to deal with "final"
2893         https://bugs.webkit.org/show_bug.cgi?id=174528
2894
2895         Reviewed by Alex Christensen.
2896         
2897         check-webkit-style shouldn't complain about an open brace to start a
2898         line after a function definition with "final" or "const final".
2899
2900         * Scripts/webkitpy/style/checkers/cpp.py:
2901         (check_braces):
2902         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2903         (CppStyleTest.test_brace_at_begin_of_line):
2904
2905 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2906
2907         Modernize content extension code
2908         https://bugs.webkit.org/show_bug.cgi?id=174588
2909
2910         Reviewed by Sam Weinig.
2911
2912         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2913         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2914         (TestWebKitAPI::testRequest):
2915         (TestWebKitAPI::makeBackend):
2916         (TestWebKitAPI::TEST_F):
2917
2918 2017-07-17  Brady Eidson  <beidson@apple.com>
2919
2920         WKHTTPCookieStore observing only works on the default cookie store.
2921         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2922
2923         Reviewed by Sam Weinig.
2924
2925         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2926         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2927           called for the default store, a non-persistent store, and a custom store.
2928         (TEST):
2929
2930 2017-07-16  Sam Weinig  <sam@webkit.org>
2931
2932         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2933         https://bugs.webkit.org/show_bug.cgi?id=174575
2934
2935         Reviewed by Brady Eidson.
2936
2937         * Scripts/svn-create-patch:
2938         (findModificationType):
2939         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2940         default value of "unknown".
2941
2942         (generateFileList):
2943         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2944         for untracked, which matches our old behavior.
2945
2946 2017-07-17  Charlie Turner  <cturner@igalia.com>
2947
2948         Add some missing build dependencies on Fedora
2949         https://bugs.webkit.org/show_bug.cgi?id=174578
2950
2951         Unreviewed dependency update.
2952
2953         * gtk/install-dependencies:
2954
2955 2017-07-16  Brady Eidson  <beidson@apple.com>
2956
2957         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2958         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2959
2960         Reviewed by Tim Horton.
2961
2962         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2963         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2964         (TEST):
2965
2966 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2967
2968         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2969         https://bugs.webkit.org/show_bug.cgi?id=174540
2970
2971         Reviewed by Michael Catanzaro.
2972
2973         * gtk/generate-inspector-gresource-manifest.py:
2974         (get_filenames): sort list of input files
2975
2976 2017-07-15  Brady Eidson  <beidson@apple.com>
2977
2978         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2979         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2980
2981         Reviewed by Tim Horton.
2982
2983         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2984         (TEST): Make this test more reliable by clearing everything beforehand.
2985
2986 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2987
2988         Make it possible to extend check-webkit-style with Apple-internal checkers
2989         <https://webkit.org/b/174464>
2990         <rdar://problem/25564402>
2991
2992         Reviewed by Darin Adler.
2993
2994         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2995         (_all_categories): Add categories from apple_additions() if it
2996         exists.
2997         (CheckerDispatcher._create_checker): Create python checker
2998         from apple_additions() if it exists.
2999
3000 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3001
3002         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3003         https://bugs.webkit.org/show_bug.cgi?id=174539
3004         <rdar://problem/33307395>
3005
3006         Reviewed by Darin Adler.
3007
3008         Adds a new unit test suite to cover action sheet popover presentation.
3009
3010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3011         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3012         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3013         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3014
3015         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3016
3017         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3018         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3019
3020         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3021
3022         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3023         (TestWebKitAPI::TEST):
3024
3025 2017-07-15  Sam Weinig  <sam@webkit.org>
3026
3027         [Scripts] Make svn-create-patch work better when called in sub directories
3028         https://bugs.webkit.org/show_bug.cgi?id=174551
3029
3030         Reviewed by Darin Adler.
3031
3032         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3033           by ensuring that the prefix is applied as is done in generateDiff.
3034         - Silence output of explanatory lines from svn stat (" > move to ...")
3035           that show up in STDERR when running svn-create-patch.
3036         - Add verbose logging that I found useful while debugging this issue.
3037
3038         * Scripts/svn-create-patch:
3039         (findBaseUrl):
3040         (findMimeType):
3041         (findSourceFileAndRevision):
3042         (generateDiff):
3043         (generateFileList):
3044         (manufacturePatchForAdditionWithHistory):
3045
3046 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3047
3048         Unreviewed build fix after r219537.
3049
3050         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3051
3052 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3053
3054         Add iOS 11 SPI
3055         https://bugs.webkit.org/show_bug.cgi?id=174430
3056         <rdar://problem/33269288>
3057
3058         Reviewed by Tim Horton.
3059
3060         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3061         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3062         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3063
3064 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3065
3066         Failing to install on iPad simulators
3067         https://bugs.webkit.org/show_bug.cgi?id=174532
3068         <rdar://problem/33328347>
3069
3070         Reviewed by Stephanie Lewis.
3071
3072         * Scripts/webkitpy/xcode/simulated_device.py:
3073         (SimulatedDevice.install_app): Place install command in retry try-except block.
3074
3075 2017-07-14  Jeff Miller  <jeffm@apple.com>
3076
3077         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3078         https://bugs.webkit.org/show_bug.cgi?id=174524
3079
3080         Reviewed by Sam Weinig.
3081
3082         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3083         (TEST):
3084         Renamed TestParameter to TestParameter1.
3085         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3086
3087         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3088         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3089         Observe changes for two bundle parameters.
3090
3091         (-[BundleParametersPlugIn dealloc]):
3092         Remove observers for two bundle parameters.
3093
3094 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3095
3096         Unreviewed, rolling out r219510.
3097         https://bugs.webkit.org/show_bug.cgi?id=174525
3098
3099         Need to revert length() == 0 check for null string (Requested
3100         by yusukesuzuki on #webkit).
3101
3102         Reverted changeset:
3103
3104         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3105         static string if StringImpl is static"
3106         https://bugs.webkit.org/show_bug.cgi?id=174501
3107         http://trac.webkit.org/changeset/219510
3108
3109 2017-07-14  Jer Noble  <jer.noble@apple.com>
3110
3111         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3112         https://bugs.webkit.org/show_bug.cgi?id=174514
3113
3114         Reviewed by Sam Weinig.
3115
3116         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3117         (TestWebKitAPI::TEST_F):
3118
3119 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3120
3121         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3122         https://bugs.webkit.org/show_bug.cgi?id=174501
3123
3124         Reviewed by Darin Adler.
3125
3126         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3127         (TestWebKitAPI::TEST):
3128
3129 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3130
3131         Bring mac expectations in-line with other platforms
3132         https://bugs.webkit.org/show_bug.cgi?id=174472
3133         <rdar://problem/33297388>
3134
3135         Reviewed by David Kilzer.
3136
3137         The override order for Mac test expectations does not conform to the pattern used by iOS,
3138         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3139
3140             platform/mac-wk2
3141             platform/wk2
3142             platform/mac-elcapitan
3143             platform/mac-sierra
3144             generic
3145
3146         After this change, El Capitan's baseline search path looks like this:
3147
3148             platform/mac-sierra-wk2
3149             platform/mac-sierra
3150             platform/mac-wk2
3151             platform/wk2
3152             generic
3153
3154         * Scripts/webkitpy/port/mac.py:
3155         (MacPort.__init__): If a specific version is specified in the port name, use that
3156         as the os version.
3157         (MacPort.default_baseline_search_path): Expectation search paths should work the
3158         same way they do on other ports. Port + version overrides port, port overrides generic
3159         and wk1/wk2 should override expectations for the two combined.
3160         * Scripts/webkitpy/port/mac_unittest.py:
3161         (MacTest.test_tests_for_other_platforms): Deleted.
3162         (MacTest._assert_search_path): Deleted.
3163         (MacTest.test_baseline_search_path): Deleted.
3164         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3165         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3166         (test_rebaseline_test_and_print_scm_changes): Ditto.
3167         (test_rebaseline_and_copy_test): Ditto.
3168         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3169         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3170         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3171
3172 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3173
3174         Fix style checker unit test
3175
3176         Unreviewed WebKit2 => WebKit fixup.
3177
3178         * Scripts/webkitpy/style/checker_unittest.py:
3179         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3180
3181 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3182
3183         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3184
3185         Unreviewed build fix.
3186
3187         r219492 missed one hunk from its partial revert of r219489.
3188         This patch reverts that hunk.
3189
3190         * TestWebKitAPI/CMakeLists.txt:
3191
3192 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3193
3194         Use the old WebKit/WebKit2 targets for CMake builds.
3195
3196         Unreviewed build fix.
3197
3198         We can update the target names to match the Framework names in a future patch.
3199         This is a partial revert of r219489.
3200
3201         * TestWebKitAPI/CMakeLists.txt:
3202         WebKitLegacy => WebKit
3203         WebKit => WebKit2
3204
3205 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3206
3207         Fix TestWebKit API.
3208         https://bugs.webkit.org/show_bug.cgi?id=174164
3209         rdar://problem/33137595
3210
3211         Reviewed by Dan Bernstein.
3212
3213         * TestWebKitAPI/CMakeLists.txt:
3214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3215         * TestWebKitAPI/PlatformGTK.cmake:
3216
3217 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3218
3219         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3220         https://bugs.webkit.org/show_bug.cgi?id=174164
3221         rdar://problem/33137595
3222
3223         Reviewed by Dan Bernstein.
3224
3225         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3226         (ShouldBuildTest):
3227         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3228         * Scripts/build-webkit:
3229         * Scripts/do-file-rename:
3230         * Scripts/do-webcore-rename:
3231         * Scripts/update-webkit-localizable-strings:
3232         * Scripts/webkitpy/common/config/watchlist:
3233         * Scripts/webkitpy/style/checker.py:
3234         * Scripts/webkitpy/style/checkers/featuredefines.py:
3235         * gtk/make-dist.py:
3236         (ensure_version_if_possible):
3237         * gtk/manifest.txt.in:
3238
3239 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3240
3241         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3242         https://bugs.webkit.org/show_bug.cgi?id=174162
3243         rdar://problem/33137594
3244
3245         Reviewed by Dan Bernstein.
3246
3247         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3250         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3251         * EWSTools/configure-clang-linux.sh:
3252         * Scripts/build-webkit:
3253         * Scripts/do-file-rename:
3254         * Scripts/do-webcore-rename:
3255         * Scripts/update-webkit-localizable-strings:
3256         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3257         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3258         * Scripts/webkitpy/style/checkers/featuredefines.py:
3259         * gtk/manifest.txt.in:
3260
3261 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3262
3263         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3264         https://bugs.webkit.org/show_bug.cgi?id=174438
3265         <rdar://problem/33277112>
3266
3267         Reviewed by Aakash Jain.
3268
3269         Given a patch, this will convert the changes from the path to the new directory structure.
3270
3271         * Scripts/rebase-patch-after-webkit-move: Added.
3272         (append_source): Append 'Source' to the provided path.
3273         (is_editable_line): Return true if a line the script expects to modify.
3274         (needs_rebase): Return if a line needs to be rebased based on it's content.
3275         (rebase_line): Rebase the provided line.
3276         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3277         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3278         were provided.
3279
3280 2017-07-12  Nan Wang  <n_wang@apple.com>
3281
3282         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3283         https://bugs.webkit.org/show_bug.cgi?id=174393
3284         <rdar://problem/33248006>
3285
3286         Reviewed by Chris Fleizach.
3287
3288         * DumpRenderTree/AccessibilityUIElement.cpp:
3289         (textMarkerRangeMatchesTextNearMarkersCallback):
3290         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3291         (AccessibilityUIElement::getJSClass):
3292         * DumpRenderTree/AccessibilityUIElement.h:
3293         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3294         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3295         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3296         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3297         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3298         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3299         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3300         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3301
3302 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3303
3304         Unreviewed, rolling out r219409.
3305
3306         The revision caused the Windows builds to fail.
3307
3308         Reverted changeset:
3309
3310         "AX: [iOS] Implement a way to retrieve a text marker range
3311         with desired text that is closest to a position"
3312         https://bugs.webkit.org/show_bug.cgi?id=174393
3313         http://trac.webkit.org/changeset/219409
3314
3315 2017-07-12  Nan Wang  <n_wang@apple.com>
3316
3317         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3318         https://bugs.webkit.org/show_bug.cgi?id=174393
3319         <rdar://problem/33248006>
3320
3321         Reviewed by Chris Fleizach.
3322
3323         * DumpRenderTree/AccessibilityUIElement.cpp:
3324         (textMarkerRangeMatchesTextNearMarkersCallback):
3325         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3326         (AccessibilityUIElement::getJSClass):
3327         * DumpRenderTree/AccessibilityUIElement.h:
3328         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3329         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3330         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3331         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3332         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3333         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3334         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3335         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3336
3337 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3338
3339         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3340         https://bugs.webkit.org/show_bug.cgi?id=174197
3341
3342         Reviewed by Darin Adler.
3343
3344         This bit me the first time I tried to submit a patch to WebKit, and still I have
3345         to manually edit the ChangeLog every time I use the script.
3346
3347         This generates a more convenient and standard ChangeLog entry.
3348
3349         * Scripts/prepare-ChangeLog:
3350         (generateNewChangeLogs):
3351
3352 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3353
3354         Unreviewed, rolling out r219401.
3355
3356         This revision rolled out the previous patch, but after talking
3357         with reviewer, a rebaseline is what was needed.Rolling back in
3358         before rebaseline.
3359
3360         Reverted changeset:
3361
3362         "Unreviewed, rolling out r219379."
3363         https://bugs.webkit.org/show_bug.cgi?id=174400
3364         http://trac.webkit.org/changeset/219401
3365
3366 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3367
3368         Unreviewed, rolling out r219379.
3369
3370         This revision caused a consistent failure in the test
3371         fast/dom/Window/property-access-on-cached-window-after-frame-
3372         removed.html.
3373
3374         Reverted changeset:
3375
3376         "Remove NAVIGATOR_HWCONCURRENCY"
3377         https://bugs.webkit.org/show_bug.cgi?id=174400
3378         http://trac.webkit.org/changeset/219379
3379
3380 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3381
3382         [WPE] Use libepoxy
3383         https://bugs.webkit.org/show_bug.cgi?id=172104
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3388         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3389
3390 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3391
3392         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3393         https://bugs.webkit.org/show_bug.cgi?id=174363
3394
3395         Reviewed by Michael Catanzaro.
3396
3397         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3398         between the GTK+ and WPE port. There's no reason for the two ports to apply
3399         different patches over same versions of GStreamer releases.
3400
3401         This aligns the two ports on this specific issue. Next we'll look into
3402         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3403         to keep these patches in a single place, avoiding duplicate files.
3404
3405         * gtk/jhbuild.modules:
3406         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3407         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3408         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3409         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3410
3411 2017-07-11  Dean Jackson  <dino@apple.com>
3412
3413         Remove NAVIGATOR_HWCONCURRENCY
3414         https://bugs.webkit.org/show_bug.cgi?id=174400
3415
3416         Reviewed by Sam Weinig.
3417
3418         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3419
3420 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3421
3422         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3423         https://bugs.webkit.org/show_bug.cgi?id=174239
3424
3425         Reviewed by Brady Eidson.
3426
3427         Create windows with specific features set and make sure those are properly reflected in the
3428         WKWindowFeatures object.
3429
3430         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3431         (resetToConsistentState):
3432         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3433         (TEST):
3434
3435 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3436
3437         Do not duplicate files when deleting directories with svn 1.9
3438         https://bugs.webkit.org/show_bug.cgi?id=174339
3439         <rdar://problem/33226781>
3440
3441         Reviewed by David Kilzer.
3442
3443         * Scripts/svn-create-patch:
3444         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3445         (generateFileList): Determine which files are deleted because they are part of a
3446         directory being deleted.
3447
3448 2017-07-11  Dean Jackson  <dino@apple.com>
3449
3450         Rolling out r219372.
3451
3452         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3453
3454 2017-07-11  Dean Jackson  <dino@apple.com>
3455
3456         Remove NAVIGATOR_HWCONCURRENCY
3457         https://bugs.webkit.org/show_bug.cgi?id=174400
3458
3459         Reviewed by Sam Weinig.
3460
3461         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3462
3463 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3464
3465         Teach build workers to fetch archives from S3.
3466         https://bugs.webkit.org/show_bug.cgi?id=174384
3467
3468         Reviewed by Aakash Jain.
3469
3470         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3471         (DownloadBuiltProduct):
3472
3473 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3474
3475         Configure buildbot to transfer all archives to S3.
3476         Previously this was Mac only, but it's time to expand!
3477         https://bugs.webkit.org/show_bug.cgi?id=174378
3478         
3479         Reviewed by Aakash Jain.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3482         (BuildFactory.__init__):
3483
3484 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3485
3486         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3487         https://bugs.webkit.org/show_bug.cgi?id=174350
3488
3489         Reviewed by Xabier Rodriguez-Calvar.
3490
3491         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3492         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3493         patches are removed. The patches for gst-plugins-good are updated, removing
3494         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3495         rtpbin elements that will help with the EMEv3 development.
3496
3497         * wpe/jhbuild.modules:
3498         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3499         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3500         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3501         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3502         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3503         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3504         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3505         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3506         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3507
3508 2017-07-10  John Wilander  <wilander@apple.com>
3509
3510         Resource Load Statistics: Prune statistics in orders of importance
3511         https://bugs.webkit.org/show_bug.cgi?id=174215
3512         <rdar://problem/33164403>
3513
3514         Reviewed by Chris Dumez.
3515
3516         Nest infrastructure. Adds these functions:
3517         1. testRunner.setStatisticsLastSeen()
3518         2. setStatisticsMaxStatisticsEntries()
3519         3. setStatisticsPruneEntriesDownTo()
3520
3521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::TestRunner::setStatisticsLastSeen):
3524         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3525         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3527         * WebKitTestRunner/TestController.cpp:
3528         (WTR::TestController::setStatisticsLastSeen):
3529         (WTR::TestController::setMaxStatisticsEntries):
3530         (WTR::TestController::setPruneEntriesDownTo):
3531         * WebKitTestRunner/TestController.h:
3532         * WebKitTestRunner/TestInvocation.cpp:
3533         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3534         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3535         (WTR::TestController::setStatisticsLastSeen):
3536         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3537         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3538
3539 2017-07-03  Brian Burg  <bburg@apple.com>
3540
3541         Web Replay: remove some unused code
3542         https://bugs.webkit.org/show_bug.cgi?id=173903
3543
3544         Rubber-stamped by Joseph Pecoraro.
3545
3546         * Scripts/run-input-generator-tests: Removed.
3547         * Scripts/webkitpy/replay/__init__.py: Removed.
3548         * Scripts/webkitpy/replay/main.py: Removed.
3549
3550 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3551
3552         [WPE] Fix layout test baseline and TestExpectations hierarchy
3553         https://bugs.webkit.org/show_bug.cgi?id=174092
3554
3555         Reviewed by Michael Catanzaro.
3556
3557         Like for the GTK+ port, override the default_baseline_search_path() and
3558         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3559         Both methods operate on a short list of search paths that defaults to 'wpe' and
3560         'wk2', along with any other user-specified platform directory.
3561
3562         The test_expectations_file_position() method is overridden for testing purposes,
3563         and relevant unit tests are added.
3564
3565         * Scripts/webkitpy/port/wpe.py:
3566         (WPEPort._search_paths):
3567         (WPEPort):
3568         (WPEPort.default_baseline_search_path):
3569         (WPEPort._port_specific_expectations_files):
3570         (WPEPort.test_expectations_file_position):
3571         * Scripts/webkitpy/port/wpe_unittest.py:
3572         (WPEPortTest.test_default_baseline_search_path):
3573         (WPEPortTest):
3574         (WPEPortTest.test_port_specific_expectations_files):
3575
3576 2017-07-10  Chris Dumez  <cdumez@apple.com>
3577
3578         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3579         https://bugs.webkit.org/show_bug.cgi?id=174301
3580
3581         Reviewed by Brent Fulgham.
3582
3583         Rename some of the testRunner API for clarity and to better match what it calls
3584         internally.
3585
3586         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3588         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3589         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3590         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3591         * WebKitTestRunner/TestController.cpp:
3592         (WTR::TestController::statisticsUpdateCookiePartitioning):
3593         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3594         * WebKitTestRunner/TestController.h:
3595         * WebKitTestRunner/TestInvocation.cpp:
3596         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3597         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3598         (WTR::TestController::statisticsUpdateCookiePartitioning):
3599         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3600
3601 2017-07-10  Charlie Turner  <cturner@igalia.com>
3602
3603         [GStreamer] Live twitch.tv videos do not play
3604         https://bugs.webkit.org/show_bug.cgi?id=174222
3605
3606         Reviewed by Michael Catanzaro.
3607
3608         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
3609         fixes videos not playing on twitch.tv.