1 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
3 Revert "Introducing the Platform Abstraction Layer (PAL)"
4 https://bugs.webkit.org/show_bug.cgi?id=144751
8 PAL should be a new target inside WebCore, rather than a top-level folder.
10 * Scripts/build-webkit: Add it to build-webkit.
12 2015-05-07 Ada Chan <adachan@apple.com>
14 Add a test for WKPageCopySessionState() with filtering.
15 https://bugs.webkit.org/show_bug.cgi?id=144666
17 Reviewed by Darin Adler.
19 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20 * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
21 (TestWebKitAPI::didFinishLoadForFrame):
22 (TestWebKitAPI::setPageLoaderClient):
23 (TestWebKitAPI::filterFirstItemCallback):
24 (TestWebKitAPI::filterAllItemsCallback):
25 (TestWebKitAPI::createSessionStates):
26 (TestWebKitAPI::TEST):
28 2015-05-06 Alexey Proskuryakov <ap@apple.com>
32 Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
34 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
36 2015-05-06 Matt Baker <mattbaker@apple.com>
38 Unreviewed, updated my list of email addresses.
40 * Scripts/webkitpy/common/config/contributors.json:
42 2015-05-06 Alexey Proskuryakov <ap@apple.com>
44 Do not link tools to WebKit2.framework
45 https://bugs.webkit.org/show_bug.cgi?id=144699
49 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
50 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
51 These linked to WebKit2 in two ways, eliminating the other one.
53 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
55 Introducing the Platform Abstraction Layer (PAL)
56 https://bugs.webkit.org/show_bug.cgi?id=143358
58 Reviewed by Simon Fraser.
60 * Scripts/build-webkit: Add it to build-webkit.
62 2015-05-06 Alex Christensen <achristensen@webkit.org>
64 Fix api tests after r183877.
66 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
67 (TestWebKitAPI::TEST_F):
68 Generate all DFAs before compiling them.
70 2015-05-06 Alexey Proskuryakov <ap@apple.com>
72 Do not link tools to WebKit2.framework
73 https://bugs.webkit.org/show_bug.cgi?id=144699
75 Reviewed by Tim Horton.
77 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
78 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
79 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
81 2015-05-06 Alex Christensen <achristensen@webkit.org>
83 [Content Extensions] Test splitting NFAs by max NFA size.
84 https://bugs.webkit.org/show_bug.cgi?id=144659
86 Reviewed by Darin Adler.
88 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
89 (TestWebKitAPI::createNFAs):
90 (TestWebKitAPI::TEST_F):
91 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
92 (TestWebKitAPI::createNFAs):
94 2015-05-05 daegyu lee <daegyu.lee@navercorp.com>
96 Remove the remaining vestiges of SVG feature define
97 https://bugs.webkit.org/show_bug.cgi?id=144655
99 Reviewed by Alexey Proskuryakov.
101 * Scripts/webkitperl/FeatureList.pm:
103 2015-05-05 Timothy Horton <timothy_horton@apple.com>
105 Add a layout mode for computing fixed layout size from a minimum size
106 https://bugs.webkit.org/show_bug.cgi?id=144610
107 <rdar://problem/19790341>
109 Reviewed by Simon Fraser.
111 * MiniBrowser/mac/BrowserWindow.xib:
112 * MiniBrowser/mac/BrowserWindowController.h:
113 * MiniBrowser/mac/WK1BrowserWindowController.m:
114 (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
115 * MiniBrowser/mac/WK2BrowserWindowController.m:
116 (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
117 Add a optional toolbar item to toggle a minimum view size of 1024x0.
119 2015-05-05 Alex Christensen <achristensen@webkit.org>
121 [Content Extensions] Release input NSString when finished copying it.
122 https://bugs.webkit.org/show_bug.cgi?id=144642
124 Reviewed by Brian Weinstein.
126 * WebKitTestRunner/mac/TestControllerMac.mm:
127 (WTR::TestController::platformConfigureViewForTest):
128 Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
130 2015-05-05 Brent Fulgham <bfulgham@apple.com>
132 Unreviewed test fix after r183798.
134 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
135 (convertToDRTLabel): Mimic behavior of Mac accessibility output
136 so we can share results.
138 2015-05-05 Alex Christensen <achristensen@webkit.org>
140 [Content Extensions] Use less memory to store the json input.
141 https://bugs.webkit.org/show_bug.cgi?id=144604
143 Reviewed by Benjamin Poulain.
145 * MiniBrowser/mac/ExtensionManagerWindowController.m:
146 (-[ExtensionManagerWindowController add:]):
147 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
148 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
149 * WebKitTestRunner/mac/TestControllerMac.mm:
150 (WTR::TestController::platformConfigureViewForTest):
152 2015-05-05 Yusuke Suzuki <utatane.tea@gmail.com>
154 Unreviewed. Make myself a WebKit reviewer.
156 * Scripts/webkitpy/common/config/contributors.json:
158 2015-05-05 Joanmarie Diggs <jdiggs@igalia.com>
160 [GTK] r183783 breaks build
161 https://bugs.webkit.org/show_bug.cgi?id=144632
163 Reviewed by Martin Robinson.
165 Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
167 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
168 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
170 2015-05-05 Alex Christensen <achristensen@webkit.org>
172 [Content Extensions] Combine NFAs properly and free memory as we compile.
173 https://bugs.webkit.org/show_bug.cgi?id=144485
175 Reviewed by Benjamin Poulain.
177 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
178 (TestWebKitAPI::TEST_F):
179 Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
180 Added tests for deep NFAs.
182 2015-05-04 Alex Christensen <achristensen@webkit.org>
184 [Content Extensions] Use less memory when writing byte code to file
185 https://bugs.webkit.org/show_bug.cgi?id=144602
187 Reviewed by Darin Adler.
189 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
191 2015-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
193 [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
194 https://bugs.webkit.org/show_bug.cgi?id=144541
196 Reviewed by Žan Doberšek.
198 Add a test case to WorkQueue unit test, to check that sources of
199 asynchronous IO operations running in the WorkQueue thread are
200 dispatched by the WorkQueue main loop.
202 * TestWebKitAPI/PlatformGTK.cmake:
203 * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
204 (TestWebKitAPI::TEST):
206 2015-05-04 Brent Fulgham <bfulgham@apple.com>
208 Correct '--show-webview' option for Tiled Drawing tests
209 https://bugs.webkit.org/show_bug.cgi?id=144621
211 Reviewed by Simon Fraser.
213 The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
214 sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
216 * WebKitTestRunner/mac/TestControllerMac.mm:
217 (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
218 WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
220 2015-05-04 Filip Pizlo <fpizlo@apple.com>
222 Large array shouldn't be slow
223 https://bugs.webkit.org/show_bug.cgi?id=144617
225 Reviewed by Geoffrey Garen.
227 Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
228 SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
229 long-running. So, hash-map sort of belongs here.
231 * Scripts/run-jsc-benchmarks:
233 2015-05-04 Doug Russell <d_russell@apple.com>
235 AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
236 https://bugs.webkit.org/show_bug.cgi?id=144489
238 Reviewed by Chris Fleizach.
240 Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
241 on the returned control.
242 Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
243 Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
244 Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
245 Add support for setSelectedVisibleTextRange() in accessibility tests.
247 * DumpRenderTree/AccessibilityUIElement.cpp:
248 (setSelectedVisibleTextRangeCallback):
249 (AccessibilityUIElement::setSelectedVisibleTextRange):
250 (AccessibilityUIElement::getJSClass):
251 (AccessibilityUIElement::textMarkerForIndex): Deleted.
252 * DumpRenderTree/AccessibilityUIElement.h:
253 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
254 (AccessibilityUIElement::setSelectedVisibleTextRange):
255 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
256 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
257 (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
258 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
259 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
260 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
261 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
262 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
263 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
264 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
265 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
267 2015-05-04 Brent Fulgham <bfulgham@apple.com>
269 [Win] Implement the "--show-webview" option for Windows
270 https://bugs.webkit.org/show_bug.cgi?id=144589
272 Reviewed by Alex Christensen.
274 Add another runtime flag (--show-webview) that causes DumpRenderTree
275 to draw its view on-screen, rather than the standard offscreen mode.
277 * DumpRenderTree/win/DumpRenderTree.cpp:
278 (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
279 (initializeGlobalsFromCommandLineOptions): Recognize the new
280 command-line argument, and set the global 'showWebView' state if
283 2015-05-04 Csaba Osztrogonác <ossy@webkit.org>
285 Remove dead code from TestInvocationCairo.cpp
286 https://bugs.webkit.org/show_bug.cgi?id=144564
288 Reviewed by Gyuyoung Kim.
290 Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
292 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
293 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
295 2015-05-04 Joonghun Park <jh718.park@samsung.com>
297 [GTK] Add libnotify in gtk install-dependencies
298 https://bugs.webkit.org/show_bug.cgi?id=144379
300 Reviewed by Csaba Osztrogonác.
302 * gtk/install-dependencies:
304 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
306 check-webkit-style fails due to system pylint
307 https://bugs.webkit.org/show_bug.cgi?id=144360
309 Reviewed by Darin Adler.
311 Make sure that the directory containing third party autoinstalled modules
312 is at the beginning of the search path, to avoid conflicts with other
313 versions of the same modules installed in the system (e.g. pylint).
315 * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
316 modules directory to sys.path, instead of appending it.
318 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
320 Unreviewed, updated my list of email addresses.
322 * Scripts/webkitpy/common/config/contributors.json: Updated.
324 2015-05-01 Martin Robinson <mrobinson@igalia.com>
326 USE(...) macro should expect unprefixed variables
327 https://bugs.webkit.org/show_bug.cgi?id=144454
329 Reviewed by Daniel Bates.
331 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
332 * DumpRenderTree/config.h: Ditto.
333 * TestWebKitAPI/config.h: Ditto.
335 2015-05-01 Basile Clement <basile_clement@apple.com>
337 Unreviewed. Add myself as a commiter in contributors.json.
339 * Scripts/webkitpy/common/config/contributors.json:
341 2015-05-01 Dewei Zhu <dewei_zhu@apple.com>
343 Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
344 https://bugs.webkit.org/show_bug.cgi?id=144487
346 Reviewed by Ryosuke Niwa.
348 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
349 (BenchmarkRunner.merge): Fix bug.
350 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
352 2015-05-01 Brady Eidson <beidson@apple.com>
354 Add API to disable meta refreshes.
355 <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
357 Reviewed by Alexey Proskuryakov.
359 * DumpRenderTree/mac/DumpRenderTree.mm:
360 (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
362 2015-05-01 Brent Fulgham <bfulgham@apple.com>
364 Provide a runtime flag to run-webkit-tests that shows the test view
365 https://bugs.webkit.org/show_bug.cgi?id=144079.
367 Unreviewed correction to r183651.
369 * WebKitTestRunner/TestController.cpp:
370 (WTR::TestController::initialize): Make sure the state of the '--show-webview'
371 flag is included in the options dictionary passed to the PlatformWebView.
373 2015-05-01 Antti Koivisto <antti@apple.com>
375 Remove network process load serialization code
376 https://bugs.webkit.org/show_bug.cgi?id=144448
378 Reviewed by Alexey Proskuryakov.
380 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
381 (WTR::InjectedBundle::beginTesting):
382 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
383 (WTR::TestRunner::setSerializeHTTPLoads):
384 (WTR::TestRunner::dispatchPendingLoadRequests):
386 2015-05-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
388 [GTK] Add libhyphen-dev to the build dependencies
389 https://bugs.webkit.org/show_bug.cgi?id=144452
391 Reviewed by Martin Robinson.
393 * gtk/install-dependencies: Added hyphen as Fedora and Arch
396 2015-04-30 Brent Fulgham <bfulgham@apple.com>
398 Provide a runtime flag to run-webkit-tests that shows the test view
399 https://bugs.webkit.org/show_bug.cgi?id=144079.
401 Reviewed by Dean Jackson.
403 Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
404 their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
407 --additional-drt-flag="--show-webview"
409 * DumpRenderTree/mac/DumpRenderTree.mm:
410 (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
411 '--show-webview' flag.
412 (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
413 * WebKitTestRunner/Options.cpp:
414 (WTR::Options::Options):
415 (WTR::handleOptionShowWebView):
416 (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
417 * WebKitTestRunner/Options.h:
418 * WebKitTestRunner/TestController.cpp:
419 (WTR::TestController::TestController):
420 (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
421 * WebKitTestRunner/TestController.h:
422 (WTR::TestController::shouldShowWebView):
423 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
424 (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
425 options dictionary. If it is true, display the web view while running the test.
427 2015-04-30 Alexey Proskuryakov <ap@apple.com>
429 r183355 didn't trigger Mac tests
430 https://bugs.webkit.org/show_bug.cgi?id=144464
432 Reviewed by Simon Fraser.
434 Update badly neglected filters and unit tests.
436 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
437 (_should_file_trigger_build):
438 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
440 (ShouldBuildTest.test_should_build):
442 2015-04-30 Xabier Rodriguez Calvar <calvaris@igalia.com>
444 [GTK] Add libhyphen-dev to the build dependencies
445 https://bugs.webkit.org/show_bug.cgi?id=144452
447 Reviewed by Martin Robinson.
449 * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
452 2015-04-30 Martin Robinson <mrobinson@igalia.com>
454 [GTK] Testing dictionaries are not installed automatically
455 https://bugs.webkit.org/show_bug.cgi?id=144460
457 Reviewed by Carlos Garcia Campos.
459 * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
461 2015-04-30 Dewei Zhu <dewei_zhu@apple.com>
463 Fix return code issue, check return code of safari process and dump results to log
464 https://bugs.webkit.org/show_bug.cgi?id=144436
466 Reviewed by Ryosuke Niwa.
468 * Scripts/run-benchmark:
469 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
470 (BenchmarkRunner.dump): Correct typo.
471 (BenchmarkRunner.wrap): Add results to console.
472 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
473 (OSXSafariDriver.prepareEnv):
474 (OSXSafariDriver.launchUrl):
475 (OSXSafariDriver.closeBrowsers):
477 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
479 Should no longer need to worry about very old versions of Xcode
480 https://bugs.webkit.org/show_bug.cgi?id=144437
482 Reviewed by Dan Bernstein.
484 * Scripts/check-for-exit-time-destructors:
485 * Scripts/check-for-global-initializers:
486 * Scripts/check-for-weak-vtables-and-externals:
488 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
490 REGRESSION(183583): [Mac] make without SDKROOT has issues
491 https://bugs.webkit.org/show_bug.cgi?id=144431
493 Reviewed by Dan Bernstein.
496 * WebKitTestRunner/Makefile:
497 Assume an empty SDKROOT means an macosx variant, so only
498 enable settings if the SDKROOT is not empty and does not
501 2015-04-29 Brent Fulgham <bfulgham@apple.com>
503 Expand test infrastructure to support scrolling tests
504 https://bugs.webkit.org/show_bug.cgi?id=143684
505 <rdar://problem/20375516>
507 Reviewed by Simon Fraser.
509 * DumpRenderTree/mac/DumpRenderTree.mm:
510 (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
511 reset before the next test run.
512 * WebKitTestRunner/TestController.cpp:
513 (WTR::TestController::resetStateToConsistentValues): Ditto."
515 2015-04-29 Alex Christensen <achristensen@webkit.org>
517 Run javascriptcore tests on Windows without cygwin
518 https://bugs.webkit.org/show_bug.cgi?id=144419
520 Reviewed by Brent Fulgham.
522 * Scripts/run-javascriptcore-tests:
524 Just call ruby, not /usr/bin/env ruby.
526 2015-04-29 Yusuke Suzuki <utatane.tea@gmail.com>
528 [GTK] Add --enable-shared option to LLVM to build mesa
529 https://bugs.webkit.org/show_bug.cgi?id=144393
531 Reviewed by Martin Robinson.
533 The updated mesa requires the shared LLVM libraries.
534 To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
535 to LLVM configure script. It will provide shared libraries in addition to static libraries.
537 * gtk/jhbuild-optional.modules:
539 2015-04-29 Martin Robinson <mrobinson@igalia.com>
541 [GTK] Add support for automatic hyphenation
542 https://bugs.webkit.org/show_bug.cgi?id=44478
544 Reviewed by Carlos Garcia Campos.
546 * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
547 all systems will use the same dictionaries for testing purposes.
549 2015-04-29 Jake Nielsen <jacob_nielsen@apple.com>
551 Failure when building WebKit for appletvsimulator.
552 https://bugs.webkit.org/show_bug.cgi?id=144356
554 Reviewed by Alexey Proskuryakov.
556 Changes Makefile logic to check for "not OS X" rather than "is iOS" to
557 make TVOS and WatchOS behave correctly.
560 * WebKitTestRunner/Makefile:
562 2015-04-29 Alexey Proskuryakov <ap@apple.com>
564 Use-after-free when invalidating WKPageForceRepaint callback
565 https://bugs.webkit.org/show_bug.cgi?id=144401
566 rdar://problem/20741111
568 Reviewed by Tim Horton.
570 * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
572 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
573 Don't do anything on error, because the context may be a stale pointer now.
575 2015-04-29 David Kilzer <ddkilzer@apple.com>
577 check-webkit-style: Don't complain about returning value from Objective-C method call in header
578 <http://webkit.org/b/144395>
580 Reviewed by Andy Estes.
582 * Scripts/webkitpy/style/checkers/cpp.py:
583 (check_spacing): Update regex so 'return' is ignored if it
584 precedes the whitespace and bracket. Change category name to
585 'whitespace/brackets'. Add period to error message.
586 (CppChecker): Add 'whitespace/brackets' as a category.
587 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
588 (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
589 'CppChecker.categories' since that's where the list lives now.
590 (CppStyleTest.test_spacing_before_brackets): Add tests for
591 'whitespace/brackets' issues and non-issues.
593 2015-04-29 Alex Christensen <achristensen@webkit.org>
597 * Scripts/webkitdirs.pm:
598 (determinePassedConfiguration):
599 WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
601 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com>
603 [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
604 https://bugs.webkit.org/show_bug.cgi?id=132159
606 Reviewed by Darin Adler.
608 Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
609 swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
611 * DumpRenderTree/mac/DumpRenderTree.mm:
614 (createWebViewAndOffscreenWindow):
615 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
616 (WTR::activateFonts):
617 * WebKitTestRunner/mac/TestControllerMac.mm:
618 (WTR::allowedFontFamilySet):
619 (WTR::systemHiddenFontFamilySet):
620 (WTR::generateWhitelist):
621 (WTR::TestController::platformInitializeContext):
623 2015-04-29 Alexey Proskuryakov <ap@apple.com>
625 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
626 https://bugs.webkit.org/show_bug.cgi?id=144155
628 Reviewed by Andreas Kling.
630 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
631 Make sure that test window is "visible" before each test. While there is no concrete
632 evidence that this is the problem indeed, the behavior is consistent with what would
633 happen for an invisible window. Also, WKTR obviously needs to do this to protect
634 against potential buggy tests that hide the window and don't show it.
636 2015-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
638 Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
640 Latest changes in the inspector UI made this test fail. We were
641 relying that the sidebar was always visible and the first 'li'
642 element of the inspector was the one containing the title. This is
643 no longer true, so better use document title that is not likely
646 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
647 (openRemoteDebuggingSession):
649 2015-04-29 Andres Gomez <agomez@igalia.com>
651 Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
653 * Scripts/webkitpy/common/config/contributors.json:
655 2015-04-29 Andres Gomez <agomez@igalia.com>
657 Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
659 * Scripts/webkitpy/common/config/watchlist:
661 2015-04-29 Hunseop Jeong <hs85.jeong@samsung.com>
663 [EFL] Allow to run the tests on the native X display
664 https://bugs.webkit.org/show_bug.cgi?id=144247
666 Reviewed by Gyuyoung Kim.
668 Added the USE_NATIVE_XDISPLAY option for the WTR.
669 We can select the Xorg driver if environment variable is set up before running the tests.
671 * Scripts/webkitpy/port/efl.py:
672 (EflPort._driver_class):
674 2015-04-29 Joonghun Park <jh718.park@samsung.com>
676 [GTK] Add libnotify-dev in gtk install-dependencies
677 https://bugs.webkit.org/show_bug.cgi?id=144379
679 Reviewed by Žan Doberšek.
681 * gtk/install-dependencies:
683 2015-04-28 Ryuan Choi <ryuan.choi@navercorp.com>
685 [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
686 https://bugs.webkit.org/show_bug.cgi?id=143001
688 Reviewed by Gyuyoung Kim.
690 * WebKitTestRunner/TestController.cpp:
691 (WTR::shouldUseFixedLayout):
693 2015-04-28 Dewei Zhu <dewei_zhu@apple.com>
695 Increase stablility of run-benchmark script
696 https://bugs.webkit.org/show_bug.cgi?id=144361
698 Reviewed by Ryosuke Niwa.
700 * Scripts/run-benchmark:
702 * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
703 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
704 (GenericBenchmarkBuilder.clean):
705 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
706 (BenchmarkRunner.__init__):
707 (BenchmarkRunner.execute):
708 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
709 (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
710 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
711 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
712 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
713 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
714 (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
715 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
716 (HTTPServerDriver.fetchResult):
718 (HTTPServerDriver.killServer): Add kill server interface.
719 (HTTPServerDriver.getReturnCode): Add get return code interface.
720 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
721 (SimpleHTTPServerDriver.serve):
722 (SimpleHTTPServerDriver.fetchResult):
723 (SimpleHTTPServerDriver):
724 (SimpleHTTPServerDriver.killServer):
725 (SimpleHTTPServerDriver.getReturnCode):
726 * Scripts/webkitpy/benchmark_runner/utils.py:
727 (forceRemove): Provide python version of 'rm -rf'.
729 2015-04-28 Sam Weinig <sam@webkit.org>
731 [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
732 https://bugs.webkit.org/show_bug.cgi?id=144363
734 Reviewed by Alex Christensen.
736 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
737 (TestWebKitAPI::createNFAs):
738 (TestWebKitAPI::TEST_F):
739 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
740 (TestWebKitAPI::countLiveNodes):
741 (TestWebKitAPI::createNFAs):
742 (TestWebKitAPI::buildDFAFromPatterns):
743 Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
745 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
747 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
748 https://bugs.webkit.org/show_bug.cgi?id=144304
750 Reviewed by Geoffrey Garen.
752 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
753 set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
754 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
756 2015-04-28 Commit Queue <commit-queue@webkit.org>
758 Unreviewed, rolling out r183514.
759 https://bugs.webkit.org/show_bug.cgi?id=144359
761 It broke cloop test bots (Requested by mcatanzaro on #webkit).
765 "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
766 https://bugs.webkit.org/show_bug.cgi?id=144304
767 http://trac.webkit.org/changeset/183514
769 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
771 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
772 https://bugs.webkit.org/show_bug.cgi?id=144304
774 Reviewed by Geoffrey Garen.
776 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
777 checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
778 of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
779 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
781 2015-04-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
783 [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
784 https://bugs.webkit.org/show_bug.cgi?id=144319
786 Reviewed by Csaba Osztrogonác.
788 * TestWebKitAPI/CMakeLists.txt:
789 * TestWebKitAPI/PlatformEfl.cmake:
791 2015-04-28 Joseph Pecoraro <pecoraro@apple.com>
793 Fix common typo "targetting" => "targeting"
794 https://bugs.webkit.org/show_bug.cgi?id=144349
796 Reviewed by Daniel Bates.
798 * Scripts/webkitdirs.pm:
799 (execMacWebKitAppForDebugging):
801 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
803 [GTK][jhbuild] Mesa build failure with llvm 3.6
804 https://bugs.webkit.org/show_bug.cgi?id=144250
806 Reviewed by Žan Doberšek.
808 Bump the version of Mesa to 10.5.4
810 * gtk/jhbuild.modules:
812 2015-04-28 Alexey Proskuryakov <ap@apple.com>
814 Disable App Nap in WebKitTestRunner UI process
815 https://bugs.webkit.org/show_bug.cgi?id=144308
817 Reviewed by Daniel Bates.
819 * WebKitTestRunner/mac/main.mm:
820 (disableAppNapInUIProcess):
823 2015-04-28 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
825 [GTK] Update JHBuild Mesa download directory
826 https://bugs.webkit.org/show_bug.cgi?id=144318
828 Update the download directory of Mesa module since the previous one
829 doesn't exist any more.
831 Reviewed by Žan Doberšek.
833 * gtk/jhbuild.modules:
835 2015-04-28 Commit Queue <commit-queue@webkit.org>
837 Unreviewed, rolling out r183477.
838 https://bugs.webkit.org/show_bug.cgi?id=144334
840 Roll back the Mesa dependency bump in fear of uncaught
841 regressions while the testing bots are no-op. (Requested by
842 zdobersek on #webkit).
846 "[GTK][jhbuild] Mesa build failure with llvm 3.6"
847 https://bugs.webkit.org/show_bug.cgi?id=144250
848 http://trac.webkit.org/changeset/183477
850 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
852 [GTK][jhbuild] Mesa build failure with llvm 3.6
853 https://bugs.webkit.org/show_bug.cgi?id=144250
855 Reviewed by Žan Doberšek.
857 Bump the version of Mesa to 10.5.4
859 * gtk/jhbuild.modules:
861 2015-04-27 Dewei Zhu <dewei_zhu@apple.com>
863 Add '__init__.py' and fix known bug in benchmark runner.
864 https://bugs.webkit.org/show_bug.cgi?id=144296
866 Reviewed by Ryosuke Niwa
868 * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
869 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
870 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
871 (BenchmarkRunner.__init__):
872 (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
873 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
874 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
876 2015-04-27 Alexey Proskuryakov <ap@apple.com>
880 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
881 (-[AccessibilityNotificationHandler _notificationReceived:]):
882 Use -objectForKey:, not array subscript.
884 2015-04-27 Alexey Proskuryakov <ap@apple.com>
886 Catch unexpected exits in DumpRenderTree
887 https://bugs.webkit.org/show_bug.cgi?id=144288
889 Reviewed by Tim Horton.
891 * DumpRenderTree/mac/DumpRenderTree.mm:
893 (DumpRenderTreeMain):
895 2015-04-27 Alexey Proskuryakov <ap@apple.com>
899 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
900 (-[AccessibilityNotificationHandler _notificationReceived:]):
901 Use -objectForKey:, not array subscript.
903 2015-04-27 Alexey Proskuryakov <ap@apple.com>
905 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
906 https://bugs.webkit.org/show_bug.cgi?id=144155
908 Reviewed by Tim Horton.
910 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
911 Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
912 and we clearly don't want App Nap while testing.
914 2015-04-22 Martin Robinson <mrobinson@igalia.com>
916 [CMake] Autogenerate cmakeconfig.h.cmake
917 https://bugs.webkit.org/show_bug.cgi?id=143997
919 Reviewed by Csaba Osztrogonác.
921 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
922 definitions since TestNetscapePlugIn does not use cmakeconfig.h.
924 2015-04-27 Brent Fulgham <bfulgham@apple.com>
926 REGRESSION(r182879): Images and video can no longer be downloaded
927 https://bugs.webkit.org/show_bug.cgi?id=144267
928 <rdar://problem/20702844>
930 Reviewed by Simon Fraser.
932 Revise tests to check for proper download menu state.
933 1. Downloading a loal image should be disabled.
934 2. Downloading a local media file should be disabled.
935 3. Downloading non-downloadable media should be disabled.
937 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
938 (TestWebKitAPI::TEST):
940 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
942 Merge run-launcher into run-minibrowser
943 https://bugs.webkit.org/show_bug.cgi?id=141928
945 Reviewed by Darin Adler.
947 * Scripts/run-iexploder-tests:
948 (runSafariWithIExploder):
949 * Scripts/run-launcher: Removed.
950 * Scripts/run-minibrowser:
951 * Scripts/webkitdirs.pm:
953 * Scripts/webkitpy/port/efl.py:
954 (EflPort.show_results_html_file):
955 * Scripts/webkitpy/port/efl_unittest.py:
956 (EflPortTest.test_show_results_html_file):
957 * Scripts/webkitpy/port/gtk.py:
958 (GtkPort.print_leaks_summary):
959 (GtkPort.show_results_html_file):
961 * Scripts/webkitpy/port/gtk_unittest.py:
962 (GtkPortTest.test_show_results_html_file):
964 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
966 [buildbot] Fix the output of perf-test buildstep on timeout
967 https://bugs.webkit.org/show_bug.cgi?id=144097
969 Reviewed by Ryosuke Niwa.
971 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
972 (RunAndUploadPerfTests.getText2):
973 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
974 (RunAndUploadPerfTestsTest.test_buildbot_timeout):
975 (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
977 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
979 [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
980 https://bugs.webkit.org/show_bug.cgi?id=143874
982 Reviewed by Gyuyoung Kim.
984 * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
986 2015-04-24 Philippe Normand <pnormand@igalia.com>
988 [JHBuild] Move to upstream OpenWebRTC
989 https://bugs.webkit.org/show_bug.cgi?id=144145
991 Reviewed by Carlos Garcia Campos.
993 * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
994 and add a new simple patch to gst-plugins-base, required for
996 * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
997 * gtk/jhbuild.modules: Ditto.
998 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1000 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
1002 [ES6] Implement ES6 template literals
1003 https://bugs.webkit.org/show_bug.cgi?id=142691
1005 Reviewed by Darin Adler.
1007 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1009 * Scripts/webkitperl/FeatureList.pm:
1011 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1013 [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
1014 https://bugs.webkit.org/show_bug.cgi?id=144217
1016 Reviewed by Darin Adler.
1018 * WebKitTestRunner/PlatformEfl.cmake:
1020 2015-04-26 Doug Russell <d_russell@apple.com>
1022 AX: richer text change notifications (142719)
1023 https://bugs.webkit.org/show_bug.cgi?id=142719
1025 Reviewed by Darin Adler.
1027 Richer accessibility value change notifications. Introduce AXTextEditType,
1028 postTextStateChangeNotification and postTextReplacementNotification to give assistive
1029 tech apps more reliable context for responding to changes in web content. Also implement
1030 a mechanism to post value changes in password form fields in coalesced ticks to thwart
1031 analyzing the cadence of changes.
1033 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1034 and an overload of postTextReplacementNotification to give assistive tech apps more
1035 reliable context for responding to changes in web content selection. Also block posting
1036 selection changes on password fields.
1038 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1039 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1040 (-[AccessibilityNotificationHandler stopObserving]):
1041 (-[AccessibilityNotificationHandler _notificationReceived:]):
1042 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1043 (AccessibilityUIElement::removeNotificationListener):
1044 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1045 (-[AccessibilityNotificationHandler _notificationReceived:]):
1046 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1047 (WTR::AccessibilityUIElement::removeNotificationListener):
1049 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com>
1051 Add myself to contributors.json
1052 https://bugs.webkit.org/show_bug.cgi?id=144204
1054 Reviewed by Darin Adler.
1056 * Scripts/webkitpy/common/config/contributors.json:
1058 2015-04-25 Martin Robinson <mrobinson@igalia.com>
1060 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1061 https://bugs.webkit.org/show_bug.cgi?id=144182
1063 Reviewed by Simon Fraser.
1065 * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1067 2015-04-25 Dewei Zhu <dewei_zhu@apple.com>
1069 https://bugs.webkit.org/show_bug.cgi?id=144038
1071 Reviewed by Ryosuke Niwa
1073 Add a script to run Speedometer and JetStream on a browser.
1075 * Scripts/run-benchmark: Wrapper script to run benchmark.
1077 * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1078 * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1079 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1080 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1081 (BenchmarkBuilderFactory):
1082 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1083 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1084 (GenericBenchmarkBuilder):
1085 (GenericBenchmarkBuilder.prepare):
1086 (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1087 (GenericBenchmarkBuilder._applyPatch):
1088 (GenericBenchmarkBuilder.clean):
1089 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1090 (JetStreamBenchmarkBuilder):
1091 (JetStreamBenchmarkBuilder.prepare):
1092 (JetStreamBenchmarkBuilder._runCreateScript):
1093 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1095 (BenchmarkRunner.__init__):
1096 (BenchmarkRunner.execute):
1097 (BenchmarkRunner.dump):
1098 (BenchmarkRunner.wrap):
1099 (BenchmarkRunner.merge):
1100 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1101 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1103 (BrowserDriver.prepareEnv):
1104 (BrowserDriver.launchUrl):
1105 (BrowserDriver.closeBrowser):
1106 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1107 (BrowserDriverFactory):
1108 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1109 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1111 (OSXChromeDriver.prepareEnv):
1112 (OSXChromeDriver.launchUrl):
1113 (OSXChromeDriver.closeBrowsers):
1114 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1116 (OSXSafariDriver.prepareEnv):
1117 (OSXSafariDriver.launchUrl):
1118 (OSXSafariDriver.closeBrowsers):
1119 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1120 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1121 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1122 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1123 * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1125 (GenericFactory.iterateGetItem):
1126 (GenericFactory.create):
1127 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1128 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1130 (ServerControl.render_GET):
1131 (ServerControl.render_POST):
1132 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1134 (HTTPServerDriver.serve):
1135 (HTTPServerDriver.fetchResult):
1136 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1137 (HTTPServerDriverFactory):
1138 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1139 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1140 (SimpleHTTPServerDriver):
1141 (SimpleHTTPServerDriver.depends):
1142 (SimpleHTTPServerDriver.__init__):
1143 (SimpleHTTPServerDriver.serve):
1144 (SimpleHTTPServerDriver.baseUrl):
1145 (SimpleHTTPServerDriver.fetchResult):
1146 * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1147 (ModuleNotFoundError):
1149 (getPathFromProjectRoot):
1154 (timeout.handle_timeout):
1155 (timeout.__enter__):
1158 2015-04-24 Commit Queue <commit-queue@webkit.org>
1160 Unreviewed, rolling out r183303.
1161 https://bugs.webkit.org/show_bug.cgi?id=144181
1163 Change was incorrect, broke builds (Requested by smfr on
1169 http://trac.webkit.org/changeset/183303
1171 2015-04-24 Simon Fraser <simon.fraser@apple.com>
1175 * MiniBrowser/mac/WK2BrowserWindowController.m:
1176 (-[WK2BrowserWindowController initWithConfiguration:]):
1178 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1180 Disable ActionMenusPDFTest due to timeout on test bot
1182 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1183 (TestWebKitAPI::TEST):
1185 2015-04-24 Commit Queue <commit-queue@webkit.org>
1187 Unreviewed, rolling out r183266.
1188 https://bugs.webkit.org/show_bug.cgi?id=144164
1190 Broke 32-bit build and a test. (Requested by ap on #webkit).
1194 "AX: richer text change notifications (142719)"
1195 https://bugs.webkit.org/show_bug.cgi?id=142719
1196 http://trac.webkit.org/changeset/183266
1198 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1200 REGRESSION: WebKit2.ActionMenusTest API test fails
1201 https://bugs.webkit.org/show_bug.cgi?id=144149
1202 <rdar://problem/20677770>
1204 Reviewed by Tim Horton.
1206 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1207 as the 'ActionMenusPDFTest'.
1208 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1209 (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1210 to match the hit test on the 'action-menu-target.pdf' test file.
1212 2015-04-24 Daniel Bates <dabates@apple.com>
1214 Cleanup: Use @memoized for property IOSSimulator.testing_device
1215 https://bugs.webkit.org/show_bug.cgi?id=141715
1217 Reviewed by Darin Adler.
1219 Simplify the caching of the result of IOSSimulator.testing_device
1220 and make the code more readable by making use of the @memoized declarator
1221 instead of explicitly managing a private instance variable,
1222 IOSSimulator._testing_device, for the cached result.
1224 * Scripts/webkitpy/port/ios.py:
1225 (IOSPort.determine_full_port_name):
1226 (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1228 (IOSSimulatorPort.testing_device): No need to cache the created device object in
1229 IOSSimulatorPort._testing_device since we are marking this function @memoized.
1230 (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1231 of caching in local variable since we only make use of this value exactly once in this function.
1232 (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1233 been used since being added in r178622. So, we can remove this constructor since
1234 it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1236 2015-04-24 Anders Carlsson <andersca@apple.com>
1238 Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1239 https://bugs.webkit.org/show_bug.cgi?id=144158
1241 Reviewed by Beth Dakin.
1243 * MiniBrowser/mac/WK2BrowserWindowController.m:
1244 (-[WK2BrowserWindowController initWithConfiguration:]):
1246 2015-04-24 Doug Russell <d_russell@apple.com>
1248 AX: richer text change notifications (142719)
1249 https://bugs.webkit.org/show_bug.cgi?id=142719
1251 Reviewed by Darin Adler.
1253 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1255 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1257 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1258 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1259 (-[AccessibilityNotificationHandler stopObserving]):
1260 (-[AccessibilityNotificationHandler _notificationReceived:]):
1261 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1262 (AccessibilityUIElement::removeNotificationListener):
1263 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1264 (-[AccessibilityNotificationHandler _notificationReceived:]):
1265 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1266 (WTR::AccessibilityUIElement::removeNotificationListener):
1268 2015-04-24 Darin Adler <darin@apple.com>
1270 Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1271 https://bugs.webkit.org/show_bug.cgi?id=128007
1273 Reviewed by Anders Carlsson.
1275 * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1276 * DumpRenderTree/win/UIDelegate.h: Ditto.
1278 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1279 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1281 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1283 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1284 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1285 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1286 (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1287 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1288 (WebKitDOMDOMWindowTest::create): Ditto.
1289 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1290 (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1291 of smart pointers to DelayedSIgnal objects.
1292 (uriChangedCallback): Ditto.
1294 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1296 [Mac] Unreviewed test fix.
1297 https://bugs.webkit.org/show_bug.cgi?id=144149
1299 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1300 (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1303 2015-04-23 Darin Adler <darin@apple.com>
1305 Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1306 https://bugs.webkit.org/show_bug.cgi?id=144090
1308 Reviewed by Anders Carlsson.
1310 * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1312 2015-04-23 Michael Saboff <msaboff@apple.com>
1314 lldb macro btjs sometimes can't get a frame description
1315 https://bugs.webkit.org/show_bug.cgi?id=144130
1317 Reviewed by Filip Pizlo.
1319 We look to execute ExecState::describeFrame(). It appears that in some contexts the
1320 debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
1321 ExecState. Therefore we can fallback to using CallFrame::describeFrame().
1323 * lldb/lldb_webkit.py:
1326 2015-04-23 Alex Christensen <achristensen@webkit.org>
1328 Use less memory when compiling content extensions.
1329 https://bugs.webkit.org/show_bug.cgi?id=144051
1331 Reviewed by Darin Adler and Benjamin Poulain.
1333 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1334 (TestWebKitAPI::TEST_F):
1335 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1336 (TestWebKitAPI::countLiveNodes):
1338 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
1340 [CMake] Clean up JSC JIT options
1341 https://bugs.webkit.org/show_bug.cgi?id=143998
1343 Reviewed by Filip Pizlo.
1345 * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1346 * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1348 2015-04-21 Brent Fulgham <bfulgham@apple.com>
1350 [Mac] Extend action menus to support PDF
1351 https://bugs.webkit.org/show_bug.cgi?id=143895
1352 <rdar://problem/19003333>
1354 Reviewed by Tim Horton.
1356 Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1357 of PDF content works.
1359 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1360 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1361 * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1362 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1363 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1364 Update to support PDF tests.
1365 (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1366 (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1368 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1370 Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1372 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1374 (testWebViewAudioOnlyUserMediaPermissionRequests):
1376 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
1378 Add myself to watchlist
1379 https://bugs.webkit.org/show_bug.cgi?id=144041
1381 Reviewed by Alex Christensen.
1383 Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1385 * Scripts/webkitpy/common/config/watchlist:
1387 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1389 [GTK] MiniBrowser should use NetworkProcess by default
1390 https://bugs.webkit.org/show_bug.cgi?id=143948
1392 Reviewed by Sergio Villar Senin.
1394 Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1395 unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1397 * MiniBrowser/gtk/main.c:
1400 2015-04-21 Matthew Hanson <matthew_hanson@apple.com>
1402 Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1404 Unreviewed build fix.
1406 * Scripts/prepare-ChangeLog:
1407 (get_function_line_ranges_for_cpp):
1408 Use grep instead of any to determine if a string is an element of an array.
1410 2015-04-21 Anders Carlsson <andersca@apple.com>
1412 Fix block signatures
1413 https://bugs.webkit.org/show_bug.cgi?id=144002
1415 Reviewed by Andreas Kling.
1417 * MiniBrowser/mac/WK2BrowserWindowController.m:
1418 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1420 2015-04-21 Philippe Normand <pnormand@igalia.com>
1422 [GTK] jhbuild should not use a branch for openwebrtc
1423 https://bugs.webkit.org/show_bug.cgi?id=143981
1425 Reviewed by Carlos Garcia Campos.
1427 * gtk/jhbuild.modules:
1429 2015-04-20 Matthew Hanson <matthew_hanson@apple.com>
1431 Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1433 Unreviewed build fix.
1435 The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1436 However, it has been exposed by List::MoreUtils since its inception. This patch uses
1437 the any function exposed by List::MoreUtils for greater compatibility.
1439 * Scripts/prepare-ChangeLog:
1440 Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1441 the any function in all of versions of Perl used by our infrastructure.
1443 2015-04-20 Alex Christensen <achristensen@webkit.org>
1445 Remove unnecessary logs when resetting tests.
1447 * WebKitTestRunner/mac/TestControllerMac.mm:
1448 (WTR::TestController::platformResetPreferencesToConsistentValues):
1449 In r183020 I added some logs when compiling or removing content extensions fails.
1450 We often try to remove a content extension that does not exist, and that is not a problem.
1452 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
1454 prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1455 https://bugs.webkit.org/show_bug.cgi?id=143897
1457 Reviewed by David Kilzer.
1459 This is a speculative fix that addresses two issues:
1461 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1462 We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1464 So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1468 Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1469 Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1471 This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1472 to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1474 The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1476 2. Creating git diffs from HEAD and not origin/master by default.
1478 Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1479 when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1481 * Scripts/prepare-ChangeLog:
1483 Use HEAD instead of origin/master in default Git case.
1485 (generateFunctionLists):
1486 Ensure that the end line is not less than the start line.
1488 (extractLineRangeAfterChange):
1489 Set the end line to the start line if the end line is less than the start line.
1491 (extractLineRangeBeforeChange):
1494 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
1496 Suppress warning in prepare-ChangeLog.
1497 https://bugs.webkit.org/show_bug.cgi?id=143882
1499 Reviewed by David Kilzer.
1501 Prune noisy prepare-ChangeLog output by using the List::Util::any function
1502 instead of the deprecated smartmatch operator.
1504 * Scripts/prepare-ChangeLog:
1505 Import the List::Util::any function.
1507 (get_function_line_ranges_for_cpp):
1508 Use the any function instead of smartmatch.
1510 2015-04-20 Anders Carlsson <andersca@apple.com>
1512 Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1513 https://bugs.webkit.org/show_bug.cgi?id=143966
1515 Reviewed by Dan Bernstein.
1517 * MiniBrowser/mac/WK2BrowserWindowController.m:
1519 (-[WK2BrowserWindowController fetchWebsiteData:]):
1520 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1521 (-[WK2BrowserWindowController clearWebsiteData:]):
1523 2015-04-20 Alex Christensen <achristensen@webkit.org>
1525 Fix content extension test flakiness.
1526 https://bugs.webkit.org/show_bug.cgi?id=143950
1528 Reviewed by Brady Eidson.
1530 * WebKitTestRunner/mac/TestControllerMac.mm:
1531 (WTR::TestController::platformResetPreferencesToConsistentValues):
1532 Remove the TestContentExtensions if it exists.
1533 (WTR::TestController::platformConfigureViewForTest):
1534 Log errors in case there are any.
1536 2015-04-20 Alex Christensen <achristensen@webkit.org>
1538 Properly report errors from _WKUserContentExtensionStore.
1539 https://bugs.webkit.org/show_bug.cgi?id=143808
1541 Reviewed by Darin Adler.
1543 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1546 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
1548 Add a rule for NetworkCache to watchlist file
1549 https://bugs.webkit.org/show_bug.cgi?id=143945
1551 Reviewed by Sergio Villar Senin.
1553 And add myself to the list of watchers.
1555 * Scripts/webkitpy/common/config/watchlist:
1557 2015-04-19 Darin Adler <darin@apple.com>
1559 Update RefPtr documentation and deprecation
1560 https://bugs.webkit.org/show_bug.cgi?id=143936
1562 Reviewed by Andreas Kling.
1564 * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1566 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com>
1568 Introduce bytecode intrinsics
1569 https://bugs.webkit.org/show_bug.cgi?id=143926
1571 Reviewed by Filip Pizlo.
1573 Change cpplint to accept emit_intrinsic_XXX.
1575 * Scripts/webkitpy/style/checkers/cpp.py:
1576 (check_identifier_name_in_declaration):
1578 2015-04-18 Simon Fraser <simon.fraser@apple.com>
1580 Fix lldb_webkit.py to show StringImpls correctly
1581 https://bugs.webkit.org/show_bug.cgi?id=143920
1583 Reviewed by Andreas Kling.
1585 Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1587 * lldb/lldb_webkit.py:
1588 (WTFStringImplProvider.is_8bit):
1590 2015-04-17 Daniel Bates <dabates@apple.com>
1592 Not able to build WebKit against iOS Simulator 8.3 SDK
1593 https://bugs.webkit.org/show_bug.cgi?id=143883
1595 Reviewed by David Kilzer.
1597 Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1598 so that Xcode uses them.
1600 * Scripts/copy-webkitlibraries-to-product-directory:
1602 2015-04-17 Beth Dakin <bdakin@apple.com>
1604 Force mouse events should go through normal mouse event handling code paths
1605 https://bugs.webkit.org/show_bug.cgi?id=143749
1607 rdar://problem/20472895
1609 Reviewed by Dean Jackson.
1611 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
1612 Since there is not a way to create an NSEventTypePressure from scratch, we
1613 subclass NSEvent and override all of the critical methods.
1615 * WebKitTestRunner/EventSenderProxy.h:
1616 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1617 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1618 (WTR::EventSendingController::mouseForceDown):
1619 (WTR::EventSendingController::mouseForceUp):
1620 (WTR::EventSendingController::mouseForceChanged):
1621 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1622 * WebKitTestRunner/TestController.cpp:
1623 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1624 * WebKitTestRunner/mac/EventSenderProxy.mm:
1625 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1626 (-[EventSenderPressureEvent timestamp]):
1627 (-[EventSenderPressureEvent type]):
1628 (-[EventSenderPressureEvent locationInWindow]):
1629 (-[EventSenderPressureEvent location]):
1630 (-[EventSenderPressureEvent stage]):
1631 (-[EventSenderPressureEvent pressure]):
1632 (-[EventSenderPressureEvent phase]):
1633 (-[EventSenderPressureEvent eventNumber]):
1634 (WTR::EventSenderProxy::mouseForceDown):
1635 (WTR::EventSenderProxy::mouseForceUp):
1636 (WTR::EventSenderProxy::mouseForceChanged):
1638 2015-04-17 Alexey Proskuryakov <ap@apple.com>
1640 build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1641 https://bugs.webkit.org/show_bug.cgi?id=143885
1643 Reviewed by Tim Horton.
1645 Fixed a case where we have two builds with the same revision(s). An in order build
1646 is one for which the revision is strictly higher.
1648 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1649 (BuildbotQueue.prototype._checkForInOrderResult):
1650 (BuildbotQueue.prototype.compareIterationsByRevisions):
1652 2015-04-17 Commit Queue <commit-queue@webkit.org>
1654 Unreviewed, rolling out r182912 and r182920.
1655 https://bugs.webkit.org/show_bug.cgi?id=143881
1657 Build breakage in some configurations (Requested by ap on
1660 Reverted changesets:
1662 "Force mouse events should go through normal mouse event
1663 handling code paths"
1664 https://bugs.webkit.org/show_bug.cgi?id=143749
1665 http://trac.webkit.org/changeset/182912
1667 http://trac.webkit.org/changeset/182920
1669 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
1671 [GTK] One more unreviewed fix after r182882.
1673 * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1675 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
1677 [GTK] Unreviewed speculative clean build fix after r182882.
1679 TestWebKitAPI's forwarding header generator depended on WeKit2's
1680 which generated SOUP related forwarding headers too.
1682 This dependency isn't necessary and was removed by r182882 to make
1683 forwarding header generators parallelizable. But in this case
1684 TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1685 should generate SOUP related forwarding headers too similar to EFL.
1687 * TestWebKitAPI/PlatformGTK.cmake:
1688 * WebKitTestRunner/PlatformGTK.cmake:
1690 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com>
1692 [SOUP] Redirect to non HTTP destination is broken
1693 https://bugs.webkit.org/show_bug.cgi?id=143866
1695 Reviewed by Sergio Villar Senin.
1697 Add a unit test to check that redirect to a data URI works.
1699 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1700 (testRedirectToDataURI):
1704 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
1706 Changes method of quitting iOS Simulator to be more correct.
1707 https://bugs.webkit.org/show_bug.cgi?id=143847
1708 <rdar://problem/20530344>
1710 Reviewed by Darin Adler.
1712 Fixes by addressing the app by ID rather than by name.
1714 * Scripts/webkitdirs.pm:
1716 * Scripts/webkitpy/port/ios.py:
1717 (IOSSimulatorPort.check_sys_deps):
1719 2015-04-16 Anders Carlsson <andersca@apple.com>
1721 Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1722 https://bugs.webkit.org/show_bug.cgi?id=143844
1724 Reviewed by Dan Bernstein.
1726 * MiniBrowser/mac/AppDelegate.m:
1727 (-[BrowserAppDelegate newPrivateWindow:]):
1728 * MiniBrowser/mac/WK2BrowserWindowController.m:
1729 (-[WK2BrowserWindowController initWithConfiguration:]):
1730 (-[WK2BrowserWindowController fetchWebsiteData:]):
1731 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1732 (-[WK2BrowserWindowController clearWebsiteData:]):
1734 2015-04-16 Alex Christensen <achristensen@webkit.org>
1738 * WebKitTestRunner/mac/TestControllerMac.mm:
1739 (WTR::TestController::platformResetPreferencesToConsistentValues):
1740 (WTR::TestController::platformConfigureViewForTest):
1741 Added WK_API_ENABLED.
1743 2015-04-16 Alex Christensen <achristensen@webkit.org>
1745 Removed unused WKUserContentFilterRef.
1746 https://bugs.webkit.org/show_bug.cgi?id=143852
1748 Reviewed by Sam Weinig.
1750 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1751 * WebKitTestRunner/mac/TestControllerMac.mm:
1752 (WTR::TestController::platformResetPreferencesToConsistentValues):
1753 (WTR::TestController::platformConfigureViewForTest):
1755 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
1757 Unreviewed. Adding myself as a commiter in contributers.json.
1759 * Scripts/webkitpy/common/config/contributors.json:
1761 2015-04-16 Alexey Proskuryakov <ap@apple.com>
1763 It is very hard to attach a debugger to WebProcess to debug tests
1764 https://bugs.webkit.org/show_bug.cgi?id=143837
1766 Reviewed by Chris Dumez.
1768 --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1769 WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1771 Now it disables all timeouts in tools, as is best for debugging tests.
1773 * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1774 that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1776 * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1777 now has the same functionality.
1779 2015-04-16 Beth Dakin <bdakin@apple.com>
1781 Force mouse events should go through normal mouse event handling code paths
1782 https://bugs.webkit.org/show_bug.cgi?id=143749
1784 rdar://problem/20472895
1786 Reviewed by Dean Jackson.
1788 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
1789 Since there is not a way to create an NSEventTypePressure from scratch, we
1790 subclass NSEvent and override all of the critical methods.
1792 * WebKitTestRunner/EventSenderProxy.h:
1793 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1794 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1795 (WTR::EventSendingController::mouseForceDown):
1796 (WTR::EventSendingController::mouseForceUp):
1797 (WTR::EventSendingController::mouseForceChanged):
1798 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1799 * WebKitTestRunner/TestController.cpp:
1800 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1801 * WebKitTestRunner/mac/EventSenderProxy.mm:
1802 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1803 (-[EventSenderPressureEvent timestamp]):
1804 (-[EventSenderPressureEvent type]):
1805 (-[EventSenderPressureEvent locationInWindow]):
1806 (-[EventSenderPressureEvent location]):
1807 (-[EventSenderPressureEvent stage]):
1808 (-[EventSenderPressureEvent pressure]):
1809 (-[EventSenderPressureEvent phase]):
1810 (-[EventSenderPressureEvent eventNumber]):
1811 (WTR::EventSenderProxy::mouseForceDown):
1812 (WTR::EventSenderProxy::mouseForceUp):
1813 (WTR::EventSenderProxy::mouseForceChanged):
1815 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1817 [EFL] Bump LLVM to version 3.6.0 on X86_64
1818 https://bugs.webkit.org/show_bug.cgi?id=143604
1820 Reviewed by Gyuyoung Kim.
1822 * efl/jhbuild.modules:
1823 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1824 * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1825 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1826 * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1828 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1830 [EFL] Remove an unnecessary workaround from jhbuildrc
1831 https://bugs.webkit.org/show_bug.cgi?id=143823
1833 Reviewed by Gyuyoung Kim.
1837 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1839 [GTK] Run forwarding headers generator unconditionally
1840 https://bugs.webkit.org/show_bug.cgi?id=143819
1842 Reviewed by Carlos Garcia Campos.
1844 * TestWebKitAPI/PlatformGTK.cmake:
1845 * WebKitTestRunner/PlatformGTK.cmake:
1847 2015-04-15 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1849 [EFL] Add gnutls to jhbuild.module
1850 https://bugs.webkit.org/show_bug.cgi?id=143777
1852 Reviewed by Csaba Osztrogonác.
1854 EFL port has required at least 3.0.0 version of gnutls since r176712.
1855 However some old linux distributions don't support 3.0.0 version. Besides
1856 other projects sometimes need to use lower version of gnutls.
1858 This patch supports to download gnutls through jhbuild, and use it.
1860 * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev.
1861 * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1863 2015-04-15 Mark Lam <mark.lam@apple.com>
1865 Remove obsolete VMInspector debugging tool.
1866 https://bugs.webkit.org/show_bug.cgi?id=143798
1868 Reviewed by Michael Saboff.
1870 * TestWebKitAPI/CMakeLists.txt:
1871 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1872 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1873 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1874 * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1876 2015-04-15 Jer Noble <jer.noble@apple.com>
1878 Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1880 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1882 2015-04-15 Jer Noble <jer.noble@apple.com>
1884 Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1886 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1887 (TestWebKitAPI::TEST_F):
1889 2015-04-15 Chris Dumez <cdumez@apple.com>
1891 [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1892 https://bugs.webkit.org/show_bug.cgi?id=143779
1894 Reviewed by Brent Fulgham.
1896 Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1897 similarly to what is done on Mac / WK1. Without this, PageCache could
1898 stay enabled after page cache tests and cause weird behaviors.
1900 * DumpRenderTree/win/DumpRenderTree.cpp:
1901 (resetWebPreferencesToConsistentValues):
1903 2015-04-14 Simon Fraser <simon.fraser@apple.com>
1905 Re-enable custom dilation for antialiased fonts
1906 https://bugs.webkit.org/show_bug.cgi?id=143738
1908 Reviewed by Tim Horton.
1910 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1911 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1912 a private WebKit pref. This pref defaults to YES, enabling the feature by default
1913 in WK1 as we do for WK2.
1915 * DumpRenderTree/mac/DumpRenderTree.mm:
1916 (resetWebPreferencesToConsistentValues):
1917 * WebKitTestRunner/TestController.cpp:
1918 (WTR::TestController::resetPreferencesToConsistentValues):
1920 2015-04-14 Brent Fulgham <bfulgham@apple.com>
1922 Correct layering violation in DumpRenderTree Build
1923 https://bugs.webkit.org/show_bug.cgi?id=143732
1925 Reviewed by Simon Fraser.
1927 Correct a layering violation in DumpRenderTree by calling functions on the
1928 WebCoreTestSupport library, rather than attempting to work with WebCore
1931 * DumpRenderTree/mac/EventSendingController.mm:
1932 (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1933 than WebCore itself.,
1934 (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1936 2015-04-14 Benjamin Poulain <benjamin@webkit.org>
1938 Add a conservative DFA minimizer for the content extension matcher
1939 https://bugs.webkit.org/show_bug.cgi?id=143501
1941 Reviewed by Alex Christensen.
1943 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1944 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1946 2015-04-14 Daniel Bates <dabates@apple.com>
1948 Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1949 https://bugs.webkit.org/show_bug.cgi?id=143693
1950 <rdar://problem/20530316>
1952 Reviewed by Tim Horton.
1954 Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1955 to use the fixed layout code on iOS at this time.
1957 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1959 2015-04-14 Dominik Röttsches <dominik.rottsches@intel.com>
1961 Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1962 https://bugs.webkit.org/show_bug.cgi?id=143705
1964 Unreviewed change to watchlist file.
1966 * Scripts/webkitpy/common/config/watchlist:
1968 2015-04-14 KwangHyuk Kim <hyuki.kim@samsung.com>
1970 [EFL] favicon wasn't updated for google.com sometimes.
1971 https://bugs.webkit.org/show_bug.cgi?id=141940
1973 Reviewed by Gyuyoung Kim.
1975 As elm_entry_utf8_to_markup can include additional characters, parameter for the
1976 on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1978 * MiniBrowser/efl/main.c:
1981 2015-04-13 Tim Horton <timothy_horton@apple.com>
1983 Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1984 https://bugs.webkit.org/show_bug.cgi?id=143560
1985 <rdar://problem/16302047>
1987 Reviewed by Darin Adler.
1989 * MiniBrowser/mac/BrowserWindowController.h:
1990 * MiniBrowser/mac/MainMenu.xib:
1991 * MiniBrowser/mac/WK1BrowserWindowController.m:
1992 (-[WK1BrowserWindowController setScale:]):
1993 * MiniBrowser/mac/WK2BrowserWindowController.m:
1994 (viewScaleForMenuItemTag):
1995 (-[WK2BrowserWindowController setScale:]):
1996 (-[WK2BrowserWindowController validateMenuItem:]):
1997 Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1998 When in use, we resize the window so that the view fits correctly, and
1999 use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2000 layout size will not change when scaling down (but will update appropriately
2001 when the view is resized).
2003 2015-04-13 Alexey Proskuryakov <ap@apple.com>
2005 build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2006 https://bugs.webkit.org/show_bug.cgi?id=138630
2008 Reviewed by Tim Horton.
2010 Make sure that we always load at least one in order productive iteration.
2012 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2013 (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2014 is done loading at least one iteration that wasn't an out of order build.
2015 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2016 when that's needed to check for out of order builds.
2017 (BuildbotQueue.prototype.update): Ditto.
2018 (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2019 result, and if it does not, load more iterations.
2020 (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2021 an in order iteration loaded too.
2022 (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2023 corrected to always sort loaded iterations before unloaded ones.
2025 2015-04-10 Brent Fulgham <bfulgham@apple.com>
2027 Expand test infrastructure to support scrolling tests
2028 https://bugs.webkit.org/show_bug.cgi?id=143286
2029 <rdar://problem/20375516>
2031 Reviewed by Simon Fraser.
2033 Extend the WK1 and WK2 test programs to support two new EventSender commands:
2034 (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2035 block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2036 (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2037 relevant rubberband, scroll, and scroll-snap animations are finished.
2039 * DumpRenderTree/mac/EventSendingController.mm:
2040 (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2041 and 'monitorWheelEvents'.
2042 (+[EventSendingController webScriptNameForSelector:]): Ditto.
2043 (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2044 debugging test failures.
2045 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2046 (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2047 function, then passes it to WebCore to be called once the test deferrals have been cleared.
2048 (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2049 'callAfterScrollingCompletes' method.
2050 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2051 and 'monitorWheelEvents'.
2052 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2053 (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2054 callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2055 (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2056 'callAfterScrollingComplates' method.
2057 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2059 2015-04-13 Alexey Proskuryakov <ap@apple.com>
2061 build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2062 https://bugs.webkit.org/show_bug.cgi?id=143656
2064 Reviewed by Darin Adler.
2066 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2067 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2069 2015-04-13 Sergio Villar Senin <svillar@igalia.com>
2071 REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2072 https://bugs.webkit.org/show_bug.cgi?id=142387
2074 Reviewed by Carlos Garcia Campos.
2076 Running mixed content is blocked by default since r181134. Updated
2077 the test case to reflect the new default settings.
2079 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2080 (testInsecureContent):
2082 2015-04-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2084 Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2085 https://bugs.webkit.org/show_bug.cgi?id=143667
2087 Reviewed by Csaba Osztrogonác.
2089 ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2090 since r169017. Added $hardwareConcurrencySupport for it.
2092 Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2094 * Scripts/webkitperl/FeatureList.pm:
2096 2015-04-13 Csaba Osztrogonác <ossy@webkit.org>
2098 [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2099 https://bugs.webkit.org/show_bug.cgi?id=143664
2101 Reviewed by Gyuyoung Kim.
2103 * Scripts/webkitperl/FeatureList.pm:
2105 2015-04-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2107 [EFL] Enable Media Source
2108 https://bugs.webkit.org/show_bug.cgi?id=143635
2110 Reviewed by Csaba Osztrogonác.
2112 * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2114 2015-04-12 Alexey Proskuryakov <ap@apple.com>
2116 build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2117 https://bugs.webkit.org/show_bug.cgi?id=143646
2119 Reviewed by David Kilzer.
2121 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2122 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2124 2015-04-11 Alexey Proskuryakov <ap@apple.com>
2126 Use en_US spell checker for tests on Mac instead of Multilingual
2127 https://bugs.webkit.org/show_bug.cgi?id=143641
2129 Reviewed by Dan Bernstein.
2131 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2132 While at it, override NSUserDictionaryReplacementItems, so that user replacements
2133 cannot affect tests.
2135 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2136 Made this more like WebKit1 version.
2138 2015-04-10 Tim Horton <timothy_horton@apple.com>
2140 Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2141 https://bugs.webkit.org/show_bug.cgi?id=143576
2143 Reviewed by Simon Fraser.
2145 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2149 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2151 Update my email address and expertise.
2152 https://bugs.webkit.org/show_bug.cgi?id=143586
2154 Unreviewed, just update my info.
2156 * Scripts/webkitpy/common/config/contributors.json:
2158 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
2160 Flakiness Dashboard not loading insecure content if loaded with https URL
2161 https://bugs.webkit.org/show_bug.cgi?id=143570
2163 Reviewed by Alexey Proskuryakov.
2165 * TestResultServer/app.yaml:
2166 * TestResultServer/static-dashboards/loader.js:
2167 Switch to https scheme.
2169 2015-04-09 Csaba Osztrogonác <ossy@webkit.org>
2171 [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2172 https://bugs.webkit.org/show_bug.cgi?id=142907
2174 Reviewed by Carlos Garcia Campos.
2176 * TestWebKitAPI/PlatformEfl.cmake:
2177 * TestWebKitAPI/PlatformGTK.cmake:
2178 * WebKitTestRunner/PlatformEfl.cmake:
2179 * WebKitTestRunner/PlatformGTK.cmake:
2181 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2183 [Mac] Unreviewed test fix after r182584
2184 https://bugs.webkit.org/show_bug.cgi?id=143452
2186 Put both of these tests back to their original state now that the underlying
2189 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2190 (TestWebKitAPI::TEST):
2191 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2192 (TestWebKitAPI::TEST):
2194 2015-04-08 Filip Pizlo <fpizlo@apple.com>
2196 run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2197 https://bugs.webkit.org/show_bug.cgi?id=143553
2199 Reviewed by Ryosuke Niwa.
2201 Remove the spurious printVMs left over from an earlier change.
2203 * Scripts/run-jsc-benchmarks:
2205 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2207 [Mac] Unreviewed test fix after r182581
2209 The behavior of control-left-click is controlled by a system preference.
2210 Our test bots have this turned off.
2212 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2213 (TestWebKitAPI::TEST):
2214 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2215 (TestWebKitAPI::TEST):
2217 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2219 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2220 https://bugs.webkit.org/show_bug.cgi?id=143452
2221 <rdar://problem/20437483>
2223 Reviewed by Tim Horton.
2225 Add a new API test to confirm that Cocoa mouse button press events are properly
2226 tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2228 The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2229 some registered event handlers that the expected button press and context menu
2230 events are received.
2232 The WK1 unit test creates an NSEvent with the desired button press state, and then
2233 uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2234 We check the resulting PlatformMouseEvent for proper state.
2236 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2237 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2238 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2239 * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2240 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2241 (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2242 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2243 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2244 (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2246 * TestWebKitAPI/mac/PlatformWebViewMac.h:
2248 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
2250 [GTK] Add pango to jhbuild-optional.modules
2251 https://bugs.webkit.org/show_bug.cgi?id=143537
2253 Reviewed by Martin Robinson.
2255 * gtk/jhbuild-optional.modules: Add pango.
2257 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
2259 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2260 https://bugs.webkit.org/show_bug.cgi?id=143530
2262 Reviewed by Žan Doberšek.
2264 Assume that the default value for display (:0) is reserved and start checking on :1
2265 Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2266 and for X server named Xorg.bin (previous bug 1376599)
2268 * Scripts/webkitpy/port/xvfbdriver.py:
2269 (XvfbDriver._next_free_display)
2270 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2271 (XvfbDriverTest.test_start_no_pixel_tests):
2272 (XvfbDriverTest.test_start_pixel_tests):
2273 (XvfbDriverTest.test_start_arbitrary_worker_number):
2274 (XvfbDriverTest.test_next_free_display):
2275 (XvfbDriverTest.test_start_next_worker):
2276 2015-04-08 Alex Christensen <achristensen@webkit.org>
2278 Block popups from content extensions.
2279 https://bugs.webkit.org/show_bug.cgi?id=143497
2281 Reviewed by Brady Eidson.
2283 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2284 (TestWebKitAPI::TEST_F):
2287 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
2289 Add CMake build system for WinCairo port.
2290 https://bugs.webkit.org/show_bug.cgi?id=115944
2292 Reviewed by Chris Dumez.
2295 * WinLauncher/CMakeLists.txt: Added.
2297 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
2299 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2300 https://bugs.webkit.org/show_bug.cgi?id=143521
2302 Reviewed by Martin Robinson.
2304 Add a way to detect unexpected web process crashes to WebViewTest,
2305 and a test case to testDOMCache to trigger the crash.
2307 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2308 (WebKitDOMNodeTest::testDOMCache):
2309 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2310 (testWebKitWebViewProcessCrashed):
2311 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2312 (WebViewTest::WebViewTest):
2313 (WebViewTest::webProcessCrashed):
2314 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2316 2015-04-07 Alexey Proskuryakov <ap@apple.com>
2318 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2319 rdar://problem/20461342
2321 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2323 2015-04-07 Commit Queue <commit-queue@webkit.org>
2325 Unreviewed, rolling out r182511.
2326 https://bugs.webkit.org/show_bug.cgi?id=143507
2328 caused debug test failures (Requested by alexchristensen on
2333 "Block popups from content extensions."
2334 https://bugs.webkit.org/show_bug.cgi?id=143497
2335 http://trac.webkit.org/changeset/182511
2337 2015-04-07 Alex Christensen <achristensen@webkit.org>
2339 Block popups from content extensions.
2340 https://bugs.webkit.org/show_bug.cgi?id=143497
2342 Reviewed by Brady Eidson.
2344 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2345 (TestWebKitAPI::TEST_F):
2348 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
2350 Get the features.json files ready for open contributions
2351 https://bugs.webkit.org/show_bug.cgi?id=143436
2353 Reviewed by Darin Adler.
2355 * Scripts/webkitpy/style/checkers/jsonchecker.py:
2356 (JSONFeaturesChecker.check):
2357 Extend the syntax checking a bit, but leave everything non-mandatory
2358 very loose until we figure what fields are important.
2360 2015-04-07 Tim Horton <timothy_horton@apple.com>
2362 Expose and test fixedLayoutSize via modern WebKit SPI
2363 https://bugs.webkit.org/show_bug.cgi?id=143500
2365 Reviewed by Simon Fraser.
2367 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2368 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2369 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2371 Add a test that verifies that fixedLayoutSize works at all, that
2372 it persists through a navigation, and that turning it back off reverts to
2373 laying out at the size of the view.
2375 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
2377 Unreviewed. Add myself as a committer.
2379 * Scripts/webkitpy/common/config/contributors.json:
2381 2015-04-07 Brent Fulgham <bfulgham@apple.com>
2383 [Win] Bots complain about missing /etc/catalog
2384 https://bugs.webkit.org/show_bug.cgi?id=143484
2386 Reviewed by Chris Dumez.
2388 The libxml2 build on Mac, iOS, and Windows does not provide the set
2389 of default catalog files. We do not actually need these for our
2390 purposes, but we get warnings and some bot flakiness because they
2393 We can avoid both problems the same way the Mac and iOS ports do,
2394 by setting the XML_CATALOG_FILES environment variable to 'empty string',
2395 which avoid the warnings and bot problems.
2397 * Scripts/webkitpy/port/win.py:
2398 (WinPort.setup_environ_for_server): Added.
2400 2015-04-06 Sam Weinig <sam@webkit.org>
2402 Use content extensions in MiniBrowser.
2403 https://bugs.webkit.org/show_bug.cgi?id=143446
2405 Reviewed by Alex Christensen.
2407 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2408 * MiniBrowser/mac/AppDelegate.h:
2409 * MiniBrowser/mac/AppDelegate.m:
2410 (-[BrowserAppDelegate init]):
2411 (-[BrowserAppDelegate showExtensionsManager:]):
2412 (-[BrowserAppDelegate userContentContoller]):
2413 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2414 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2415 (-[ExtensionManagerWindowController init]):
2416 (-[ExtensionManagerWindowController windowDidLoad]):
2417 (-[ExtensionManagerWindowController add:]):
2418 (-[ExtensionManagerWindowController remove:]):
2419 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2420 * MiniBrowser/mac/MainMenu.xib:
2422 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
2424 web-platform-tests server should retrieve the modules file relatively to its docroot path
2425 https://bugs.webkit.org/show_bug.cgi?id=142742
2427 Reviewed by Darin Adler.
2429 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2430 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2432 2015-04-06 Commit Queue <commit-queue@webkit.org>
2434 Unreviewed, rolling out r182445.
2435 https://bugs.webkit.org/show_bug.cgi?id=143459
2437 broke 32 bit build (Requested by alexchristensen on #webkit).
2441 "Use content extensions in MiniBrowser."
2442 https://bugs.webkit.org/show_bug.cgi?id=143446
2443 http://trac.webkit.org/changeset/182445
2445 2015-04-06 Sam Weinig <sam@webkit.org>
2447 Use content extensions in MiniBrowser.
2448 https://bugs.webkit.org/show_bug.cgi?id=143446
2450 Reviewed by Alex Christensen.
2452 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2453 * MiniBrowser/mac/AppDelegate.h:
2454 * MiniBrowser/mac/AppDelegate.m:
2455 (-[BrowserAppDelegate init]):
2456 (-[BrowserAppDelegate showExtensionsManager:]):
2457 (-[BrowserAppDelegate userContentContoller]):
2458 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2459 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2460 (-[ExtensionManagerWindowController init]):
2461 (-[ExtensionManagerWindowController windowDidLoad]):
2462 (-[ExtensionManagerWindowController add:]):
2463 (-[ExtensionManagerWindowController remove:]):
2464 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2465 * MiniBrowser/mac/MainMenu.xib:
2467 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
2469 [GTK] install-dependencies should prefer dnf to yum
2470 https://bugs.webkit.org/show_bug.cgi?id=143441
2472 Reviewed by Martin Robinson.
2474 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2476 * gtk/install-dependencies:
2478 2015-04-06 Andy Estes <aestes@apple.com>
2480 [iOS] 'make clean' fails in Tools/WebKitTestRunner
2481 https://bugs.webkit.org/show_bug.cgi?id=143455
2483 Reviewed by Dan Bernstein.
2485 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2486 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2488 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2490 2015-04-06 Alexey Proskuryakov <ap@apple.com>
2492 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2493 https://bugs.webkit.org/show_bug.cgi?id=143450
2495 Reviewed by Anders Carlsson.
2497 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2498 Make sure that the view is actually closed, regardless of anything else that happens beneath.
2499 Also, removed unnecessary get() calls.
2501 2015-04-03 Alexey Proskuryakov <ap@apple.com>
2503 Reduce the dependency on Flash in regression tests
2504 https://bugs.webkit.org/show_bug.cgi?id=143391
2506 Reviewed by Anders Carlsson.
2508 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2509 Only allow QuickTime and the test plug-in.
2511 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
2513 W3C test importer should generate the modules installed dynamically to run wpt tests
2514 https://bugs.webkit.org/show_bug.cgi?id=142738
2516 Reviewed by Ryosuke Niwa.
2518 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2519 The implementation is done within TestDownloader and it is activated for the WPT repository.
2520 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2522 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2523 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2524 * Scripts/webkitpy/w3c/test_downloader.py:
2525 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2527 (TestDownloader._git_submodules_description): Computes submodule description.
2528 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2529 * Scripts/webkitpy/w3c/test_importer.py:
2530 (TestImporter.do_import): Added the possibility to post process the tests.
2532 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2533 (TestImporter.should_convert_test_harness_links): Updated according new options format.
2534 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2535 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
2536 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2537 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2538 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2539 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2541 2015-04-05 Antti Koivisto <antti@apple.com>
2543 Bloom filter should support longer hashes
2544 https://bugs.webkit.org/show_bug.cgi?id=143419
2546 Reviewed by Dan Bernstein.
2548 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2549 (TestWebKitAPI::generateRandomDigests):
2550 (TestWebKitAPI::TEST):
2552 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2554 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2555 https://bugs.webkit.org/show_bug.cgi?id=143372
2557 Reviewed by Darin Adler.
2559 * Scripts/run-jsc-stress-tests:
2561 2015-04-03 Antti Koivisto <antti@apple.com>
2563 Add non-counting bloom filter class
2564 https://bugs.webkit.org/show_bug.cgi?id=143366
2566 Reviewed by Sam Weinig.
2568 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2569 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2570 (TestWebKitAPI::generateRandomHashes):
2571 (TestWebKitAPI::TEST):
2573 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2575 FTL JIT tests should fail if LLVM library isn't available
2576 https://bugs.webkit.org/show_bug.cgi?id=143374
2578 Reviewed by Mark Lam.
2580 * Scripts/run-jsc-stress-tests:
2582 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2584 [EFL] Speedup jhbuild with disable running autogen.sh
2585 https://bugs.webkit.org/show_bug.cgi?id=143369
2587 Reviewed by Gyuyoung Kim.
2589 * efl/jhbuild.modules:
2591 2015-04-01 Alexey Proskuryakov <ap@apple.com>
2593 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2594 https://bugs.webkit.org/show_bug.cgi?id=143282
2596 Reviewed by Daniel Bates.
2598 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2600 2015-04-01 Alexey Proskuryakov <ap@apple.com>
2602 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2603 https://bugs.webkit.org/show_bug.cgi?id=143240
2604 rdar://problem/19990425
2606 Reviewed by Tim Horton.
2608 * DumpRenderTree/mac/LayoutTestHelper.m:
2609 (colorProfileURLForDisplay):
2610 (saveDisplayColorProfiles):
2611 Gracefully handle it when the current profile cannot be retrieved, fixing at
2612 least one case when LayoutTestHelper couldn't start.
2614 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2615 (Manager._set_up_run):
2616 (Manager._force_pixel_tests_if_needed):
2617 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2618 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2619 Return and check an error from start_helper().
2621 2015-04-01 Brent Fulgham <bfulgham@apple.com>
2623 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2624 https://bugs.webkit.org/show_bug.cgi?id=143321
2626 Reviewed by Alexey Proskuryakov.
2628 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2630 2015-04-01 Enrica Casucci <enrica@apple.com>
2632 Injected bundle messages should be at the page level.
2633 https://bugs.webkit.org/show_bug.cgi?id=143283
2635 Reviewed by Alexey Proskuryakov.
2637 Updating WebKitTestRunner to use the new page level messaging.
2638 The author of this patch is Tim Horton, I just finished it.
2640 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2641 (WTR::EventSendingController::mouseDown):
2642 (WTR::EventSendingController::mouseUp):
2643 (WTR::EventSendingController::mouseMoveTo):
2644 (WTR::EventSendingController::leapForward):
2645 (WTR::EventSendingController::scheduleAsynchronousClick):
2646 (WTR::EventSendingController::keyDown):
2647 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2648 (WTR::EventSendingController::mouseScrollBy):
2649 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2650 (WTR::EventSendingController::continuousMouseScrollBy):
2651 (WTR::EventSendingController::addTouchPoint):
2652 (WTR::EventSendingController::updateTouchPoint):
2653 (WTR::EventSendingController::setTouchModifier):
2654 (WTR::EventSendingController::setTouchPointRadius):
2655 (WTR::EventSendingController::touchStart):
2656 (WTR::EventSendingController::touchMove):
2657 (WTR::EventSendingController::touchEnd):
2658 (WTR::EventSendingController::touchCancel):
2659 (WTR::EventSendingController::clearTouchPoints):
2660 (WTR::EventSendingController::releaseTouchPoint):
2661 (WTR::EventSendingController::cancelTouchPoint):
2662 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2663 (WTR::InjectedBundle::didReceiveMessage):
2664 (WTR::InjectedBundle::didReceiveMessageToPage):
2665 (WTR::InjectedBundle::done):
2666 (WTR::InjectedBundle::outputText):
2667 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2668 (WTR::InjectedBundle::postAddChromeInputField):
2669 (WTR::InjectedBundle::postRemoveChromeInputField):
2670 (WTR::InjectedBundle::postFocusWebView):
2671 (WTR::InjectedBundle::postSetBackingScaleFactor):
2672 (WTR::InjectedBundle::postSetWindowIsKey):
2673 (WTR::InjectedBundle::postSimulateWebNotificationClick):
2674 (WTR::InjectedBundle::postSetAddsVisitedLinks):
2675 (WTR::InjectedBundle::setGeolocationPermission):
2676 (WTR::InjectedBundle::setMockGeolocationPosition):
2677 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2678 (WTR::InjectedBundle::setUserMediaPermission):
2679 (WTR::InjectedBundle::setCustomPolicyDelegate):
2680 (WTR::InjectedBundle::setHidden):
2681 (WTR::InjectedBundle::setCacheModel):
2682 (WTR::InjectedBundle::shouldProcessWorkQueue):
2683 (WTR::InjectedBundle::processWorkQueue):
2684 (WTR::InjectedBundle::queueBackNavigation):
2685 (WTR::InjectedBundle::queueForwardNavigation):
2686 (WTR::InjectedBundle::queueLoad):
2687 (WTR::InjectedBundle::queueLoadHTMLString):
2688 (WTR::InjectedBundle::queueReload):
2689 (WTR::InjectedBundle::queueLoadingScript):
2690 (WTR::InjectedBundle::queueNonLoadingScript):
2691 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2692 (WTR::TestRunner::setHandlesAuthenticationChallenges):
2693 (WTR::TestRunner::setAuthenticationUsername):
2694 (WTR::TestRunner::setAuthenticationPassword):
2695 (WTR::TestRunner::secureEventInputIsEnabled):
2696 (WTR::TestRunner::setBlockAllPlugins):
2697 * WebKitTestRunner/TestController.cpp:
2698 (WTR::TestController::createWebViewWithOptions):
2699 (WTR::TestController::resetStateToConsistentValues):
2700 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2701 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2702 * WebKitTestRunner/TestController.h:
2703 * WebKitTestRunner/TestInvocation.cpp:
2704 (WTR::TestInvocation::invoke):
2705 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2707 2015-04-01 Commit Queue <commit-queue@webkit.org>
2709 Unreviewed, rolling out r182174 and r182177.
2710 https://bugs.webkit.org/show_bug.cgi?id=143314
2712 Try to correct EWS failures (Requested by bfulgham on
2715 Reverted changesets:
2717 "Python SCM should be able to retrieve untracked files"
2718 https://bugs.webkit.org/show_bug.cgi?id=143135
2719 http://trac.webkit.org/changeset/182174
2721 "[buildbot] clean-build script should remove untracked files
2722 and revert local changes too"
2723 https://bugs.webkit.org/show_bug.cgi?id=142400
2724 http://trac.webkit.org/changeset/182177
2726 2015-04-01 Alex Christensen <achristensen@webkit.org>
2728 [Content Extensions] Properly handle regexes that match everything.
2729 https://bugs.webkit.org/show_bug.cgi?id=143281
2731 Reviewed by Benjamin Poulain.
2733 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2734 (TestWebKitAPI::testRequest):
2735 (TestWebKitAPI::makeBackend):
2736 (TestWebKitAPI::TEST_F):
2737 Removed duplicate code and added test.
2739 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
2741 Content Extensions: split the state machines to minimize prefix states
2742 https://bugs.webkit.org/show_bug.cgi?id=143253
2744 Reviewed by Alex Christensen.
2746 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2747 (TestWebKitAPI::TEST_F):
2748 (TestWebKitAPI::testPatternStatus):
2750 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
2752 Clean up Identifier factories to clarify the meaning of StringImpl*
2753 https://bugs.webkit.org/show_bug.cgi?id=143146
2755 Reviewed by Filip Pizlo.
2757 Simple API tests for StringImpl are added.
2759 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2760 (TestWebKitAPI::TEST):
2762 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
2764 [EFL] Add AArch64 builder and tester bot to build.webkit.org
2765 https://bugs.webkit.org/show_bug.cgi?id=143092
2767 Reviewed by Gyuyoung Kim.
2769 * BuildSlaveSupport/build.webkit.org-config/config.json:
2770 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2772 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2774 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2776 [buildbot] clean-build script should remove untracked files and revert local changes too
2777 https://bugs.webkit.org/show_bug.cgi?id=142400
2779 Reviewed by Ryosuke Niwa.
2781 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2782 A helper routine SCM.discard_untracked_files is added for that purpose.
2784 * BuildSlaveSupport/clean-build:
2785 (main): Making call to Scripts/clean-webkit
2786 * Scripts/clean-webkit: Added.
2787 (main): Revert changes and delete untracked files.
2788 * Scripts/webkitpy/common/checkout/scm/scm.py:
2789 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2790 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2791 (SCMTest._shared_test_discard_untracked_files):
2792 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2794 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2796 Python SCM should be able to retrieve untracked files
2797 https://bugs.webkit.org/show_bug.cgi?id=143135
2799 Reviewed by Ryosuke Niwa.
2801 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2802 Ignored files may be included or not in this list according boolean passed to the function.
2804 * Scripts/webkitpy/common/checkout/scm/git.py:
2805 (Git.untracked_files):
2806 * Scripts/webkitpy/common/checkout/scm/scm.py:
2807 (SCM.untracked_files):
2808 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2809 (SCMTest._shared_test_untracked_files):
2810 (test_untracked_files):
2811 (GitSVNTest.test_untracked_files):
2812 * Scripts/webkitpy/common/checkout/scm/svn.py:
2813 (SVN.untracked_files):
2815 2015-03-30 Alex Christensen <achristensen@webkit.org>
2817 [Content Extensions] Correctly handle regular expressions matching everything
2818 https://bugs.webkit.org/show_bug.cgi?id=143235
2820 Reviewed by Benjamin Poulain.
2822 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2823 (TestWebKitAPI::checkCompilerError):
2824 (TestWebKitAPI::TEST_F):
2825 Test ContentExtensionErrors.
2827 2015-03-30 Alexey Proskuryakov <ap@apple.com>
2829 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2830 https://bugs.webkit.org/show_bug.cgi?id=143241
2831 rdar://problem/20351297
2833 Reviewed by Mark Lam.
2835 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2837 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2839 [CMake][EFL] Remove redundant library link and include path
2840 https://bugs.webkit.org/show_bug.cgi?id=143221
2842 Reviewed by Csaba Osztrogonác.
2844 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2846 2015-03-30 Sam Weinig <sam@webkit.org>
2848 [Content Extensions] Flesh out the UserContentExtensionStore
2849 https://bugs.webkit.org/show_bug.cgi?id=143123
2851 Reviewed by Benjamin Poulain.
2853 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2854 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2855 Add tests for _WKUserContentExtensionStore.
2857 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
2859 Update install-dependencies Fedora packages after r181624
2860 https://bugs.webkit.org/show_bug.cgi?id=143215
2862 Add json-glib, libv4l, openssl and pulseaudio development packages to
2863 the Fedora list providing we need them to build WebKit dependencies
2864 for this distribution.
2866 Reviewed by Philippe Normand.
2868 * gtk/install-dependencies:
2870 2015-03-30 Commit Queue <commit-queue@webkit.org>
2872 Unreviewed, rolling out r182119.
2873 https://bugs.webkit.org/show_bug.cgi?id=143196
2875 problem with syntax (Requested by youenn on #webkit).
2879 "[buildbot] clean-build script should remove untracked files
2880 and revert local changes too"
2881 https://bugs.webkit.org/show_bug.cgi?id=142400
2882 http://trac.webkit.org/changeset/182119
2884 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
2886 Start the features.json files
2887 https://bugs.webkit.org/show_bug.cgi?id=143207
2889 Reviewed by Darin Adler.
2891 I kept the style checking light. We'll have to figure
2892 what is the best format for each field.
2894 * Scripts/webkitpy/style/checker.py:
2895 (CheckerDispatcher._create_checker):
2896 * Scripts/webkitpy/style/checkers/jsonchecker.py:
2897 (JSONContributorsChecker.check):
2898 (JSONFeaturesChecker):
2899 (JSONFeaturesChecker.check):
2901 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
2903 [buildbot] clean-build script should remove untracked files and revert local changes too
2904 https://bugs.webkit.org/show_bug.cgi?id=142400
2906 Reviewed by Ryosuke Niwa.
2908 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2910 * BuildSlaveSupport/clean-build:
2911 (main): Adding call to Tools/Scripts/clean-webkit.
2912 * Scripts/clean-webkit: Added.
2913 (main): Removes untracked and changed files.
2914 * Scripts/webkitpy/common/checkout/scm/git.py:
2915 (Git.untracked_files): Retrieves GIT untracked files.
2916 * Scripts/webkitpy/common/checkout/scm/scm.py:
2917 (SCM.untracked_files): Retrieves SVN untracked files.
2919 (SCM.discard_untracked_files): Deletes untracked files/folders.
2920 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2921 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2922 (test_untracked_files):
2923 (GitSVNTest.test_untracked_files):
2924 * Scripts/webkitpy/common/checkout/scm/svn.py:
2925 (SVN.untracked_files):
2927 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2929 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
2930 https://bugs.webkit.org/show_bug.cgi?id=143138
2932 Reviewed by Csaba Osztrogonác.
2934 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2935 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2937 * ImageDiff/CMakeLists.txt:
2938 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2939 * WebKitTestRunner/CMakeLists.txt: ditto.
2941 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
2943 Support building WTF on Windows without Cygwin
2944 https://bugs.webkit.org/show_bug.cgi?id=143084
2946 Reviewed by Brent Fulgham.
2948 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2949 This patch also migrates to using File::Spec->catfile() for directory separators.
2951 * Scripts/update-webkit-dependency:
2953 * Scripts/update-webkit-support-libs:
2955 (downloadExpectedVersionNumber):
2957 (toUnixPath): Deleted.
2958 * Scripts/webkitdirs.pm:
2959 (determineSourceDir):
2960 (windowsSourceSourceDir):
2961 (windowsLibrariesDir):
2963 (checkInstalledTools):
2964 (buildVisualStudioProject):
2966 2015-03-27 Alex Christensen <achristensen@webkit.org>
2969 https://bugs.webkit.org/show_bug.cgi?id=143086
2971 Reviewed by Brent Fulgham.
2973 * Scripts/webkitdirs.pm:
2974 (buildVisualStudioProject):
2975 (runSvnUpdateAndResolveChangeLogs):
2976 Use ActivePerl-friendly perl.
2978 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
2980 URTBF after r182059 to fix the EFL build.
2982 * TestWebKitAPI/CMakeLists.txt:
2984 2015-03-26 Alexey Proskuryakov <ap@apple.com>
2986 Layout test results URL loads in WK1 but not WK2 minibrowser
2987 https://bugs.webkit.org/show_bug.cgi?id=143117
2989 Reviewed by Tim Horton.
2991 * MiniBrowser/mac/WK2BrowserWindowController.m:
2992 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2994 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2996 2015-03-26 Jer Noble <jer.noble@apple.com>
2998 Add --allowed-host support to run-webkit-tests
2999 https://bugs.webkit.org/show_bug.cgi?id=142938
3001 Reviewed by Brent Fulgham.
3003 Accept --allowed-host arguments from run-webkit-tests and pass them through to
3004 DumpRenderTree and WebKitTestRunner.
3006 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3007 are placed in the wrong location. The argument is compared with each tests's path, and if a
3008 relative path or a path with '..' was used, results are placed alongside the test. Take the
3009 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3011 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3013 * Scripts/webkitpy/port/base.py:
3015 (Port.allowed_hosts):
3016 * Scripts/webkitpy/port/driver.py:
3019 2015-03-26 Jer Noble <jer.noble@apple.com>
3021 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3022 https://bugs.webkit.org/show_bug.cgi?id=142931
3024 Reviewed by Brent Fulgham.
3026 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3027 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3028 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3031 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3032 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3034 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3035 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3036 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3037 the top loading frame from the page, as we do elsewhere in this class.
3039 * DumpRenderTree/TestRunner.h:
3040 (TestRunner::allowedHosts):
3041 (TestRunner::setAllowedHosts):
3042 * DumpRenderTree/mac/DumpRenderTree.mm:
3043 (initializeGlobalsFromCommandLineOptions):
3045 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3047 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3048 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3049 (WTR::InjectedBundle::didReceiveMessage):
3050 (WTR::InjectedBundle::isAllowedHost):
3051 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3052 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3053 (WTR::isAllowedHost):
3054 (WTR::InjectedBundlePage::willSendRequestForFrame):
3055 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3056 * WebKitTestRunner/Options.cpp:
3057 (WTR::handleOptionAllowedHost):
3058 (WTR::OptionsHandler::OptionsHandler):
3059 * WebKitTestRunner/Options.h:
3060 * WebKitTestRunner/TestController.cpp:
3061 (WTR::TestController::initialize):
3062 (WTR::TestController::resetStateToConsistentValues):
3063 * WebKitTestRunner/TestController.h:
3065 2015-03-26 Brady Eidson <beidson@apple.com>
3067 Apply ContentExtension actions after redirects.
3068 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3070 Reviewed by Alex Christensen.
3072 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3073 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
3074 which is specifically interesting to a new test.
3076 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
3078 [EFL] Disable building libseccomp on AArch64
3079 https://bugs.webkit.org/show_bug.cgi?id=143094
3081 Reviewed by Gyuyoung Kim.
3085 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
3087 [jhbuild] git should use only 1 thread for cloning jhbuild
3088 https://bugs.webkit.org/show_bug.cgi?id=143095
3090 Reviewed by Gyuyoung Kim.
3092 * jhbuild/jhbuild-wrapper:
3095 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
3097 Update prepare-ChangeLog to work with ES6 Class syntax
3098 https://bugs.webkit.org/show_bug.cgi?id=143069
3100 Reviewed by Timothy Hatcher.
3102 * Scripts/prepare-ChangeLog:
3103 (get_function_line_ranges_for_javascript):
3104 Better handle ES6 Class syntax.
3106 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3107 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3110 (DerivedClass.staticMethod):
3111 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3112 (DerivedClass.prototype.method):
3113 (DerivedClass.prototype.get getter):
3114 (namespace.MyClass):
3115 (namespace.MyClass.staticMethod):
3116 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3117 (namespace.MyClass.prototype.method):
3118 (namespace.MyClass.prototype.get getter):
3121 2015-03-25 Filip Pizlo <fpizlo@apple.com>
3123 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3124 https://bugs.webkit.org/show_bug.cgi?id=142993
3126 Reviewed by Mark Lam.
3128 Bunch of support for testing executable allocation failure.
3130 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3132 * Scripts/run-javascriptcore-tests:
3133 (runJSCStressTests):
3134 * Scripts/run-jsc-stress-tests:
3136 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
3138 Fix Windows build from r181977.
3142 * Scripts/update-webkit-dependency:
3144 2015-03-25 Sam Weinig <sam@webkit.org>
3146 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3148 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3149 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3151 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
3153 Migrate update-webkit for Windows to not require Cygwin
3154 https://bugs.webkit.org/show_bug.cgi?id=143040
3156 Reviewed by Brent Fulgham.
3158 * Scripts/update-webkit-dependency:
3160 (toUnixPath): Deleted.
3161 * Scripts/webkitdirs.pm:
3163 (checkInstalledTools):
3166 2015-03-25 Sam Weinig <sam@webkit.org>
3168 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3169 https://bugs.webkit.org/show_bug.cgi?id=143059
3171 Reviewed by Alex Christensen.
3173 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3174 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3175 Update for new interface of compileRuleList().
3177 2015-03-25 Alex Christensen <achristensen@webkit.org>
3179 [Content Extensions] Add multi-DFA compiling and interpreting.
3180 https://bugs.webkit.org/show_bug.cgi?id=143010
3182 Reviewed by Benjamin Poulain.
3184 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3185 (TestWebKitAPI::testRequest):
3186 (TestWebKitAPI::TEST_F):
3187 Add some tests for ignore-previous-rules and large rulesets.
3189 2015-03-25 Alexey Proskuryakov <ap@apple.com>
3191 Mavericks WK1 still runs JSC tests
3192 https://bugs.webkit.org/show_bug.cgi?id=143035
3194 Reviewed by Csaba Osztrogonác.
3196 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3199 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3202 2015-03-25 Commit Queue <commit-queue@webkit.org>
3204 Unreviewed, rolling out r181932.
3205 https://bugs.webkit.org/show_bug.cgi?id=143041
3207 The test fails most of the time on bots (Requested by ap on
3212 "[Content Extensions] Add multi-DFA compiling and
3214 https://bugs.webkit.org/show_bug.cgi?id=143010
3215 http://trac.webkit.org/changeset/181932
3217 2015-03-24 Alex Christensen <achristensen@webkit.org>
3219 [Content Extensions] Add multi-DFA compiling and interpreting.
3220 https://bugs.webkit.org/show_bug.cgi?id=143010
3222 Reviewed by Benjamin Poulain.
3224 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3225 (TestWebKitAPI::testRequest):
3226 (TestWebKitAPI::TEST_F):
3227 Add some tests for ignore-previous-rules and large rulesets.
3229 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
3231 Make URL filter patterns matching consistent and add a simple canonicalization step
3232 https://bugs.webkit.org/show_bug.cgi?id=142998
3234 Reviewed by Alex Christensen.
3236 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3238 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
3240 [EFL] Add OpenWebRTC in jhbuild
3241 https://bugs.webkit.org/show_bug.cgi?id=142778
3243 Reviewed by Gyuyoung Kim.
3245 Original patch by Philippe Normand <pnormand@igalia.com>
3247 * efl/install-dependencies: Dependencies for OpenWebRTC.
3248 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
3249 the openwebrtc gst plugins.
3251 2015-03-23 Brent Fulgham <bfulgham@apple.com>
3253 Regression(r181257): WTF_WorkQueue.Simple is flaky
3254 https://bugs.webkit.org/show_bug.cgi?id=142560
3256 Remove the check that the refCount has returned to one after the
3257 individual tasks have completed. It's too nondeterministic when
3258 the reference count will be reduced.
3260 Reviewed by Alexey Proskuryakov
3262 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3263 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
3265 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3267 [CMake][EFL] Put failure API test excutables into failure directory
3268 https://bugs.webkit.org/show_bug.cgi?id=142965
3270 Reviewed by Csaba Osztrogonác.
3272 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
3274 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
3275 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
3277 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
3279 CSS Selectors: fix attribute case-insensitive matching of Contain and List
3280 https://bugs.webkit.org/show_bug.cgi?id=142932
3282 Reviewed by Darin Adler.
3284 Add tests for the new features and fix some existing tests using the
3285 stringFromUTF8() utility recently added by Dhi.
3287 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3288 (TestWebKitAPI::stringFromUTF8):
3289 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3291 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
3293 [GTK] install-dependencies should install orc
3294 https://bugs.webkit.org/show_bug.cgi?id=142955
3296 Reviewed by Martin Robinson.
3298 Install orc, needed by openwebrtc
3300 * gtk/install-dependencies:
3302 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
3304 Detect when url filter pattern with groups match the empty string
3305 https://bugs.webkit.org/show_bug.cgi?id=142930
3307 Reviewed by Sam Weinig.
3309 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3311 2015-03-22 Anders Carlsson <andersca@apple.com>
3313 _WKWebsiteDataStore should clear WebSQL databases
3314 https://bugs.webkit.org/show_bug.cgi?id=142947
3316 Reviewed by Sam Weinig.
3318 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3320 * MiniBrowser/mac/WK2BrowserWindowController.m:
3321 (-[WK2BrowserWindowController fetchWebsiteData:]):
3322 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3323 (-[WK2BrowserWindowController clearWebsiteData:]):
3325 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
3327 GCTimer should know keep track of nested GC phases
3328 https://bugs.webkit.org/show_bug.cgi?id=142675
3330 Reviewed by Darin Adler.
3332 Adds a tool to aid in parsing the GC phase timing output into a
3333 tree-like structure based on the parent-child relationships
3334 of nested GC phases.
3336 * Scripts/parse-gc-phase-timings: Added.
3339 (Timing.__unicode__):
3343 (print_timing_node):
3344 (print_timing_tree):
3348 2015-03-20 Brent Fulgham <bfulgham@apple.com>
3350 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3352 * Scripts/webkitpy/common/config/ews.json:
3354 2015-03-20 Philippe Normand <pnormand@igalia.com>
3356 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3357 https://bugs.webkit.org/show_bug.cgi?id=142867
3359 Rubber-stamped by Csaba Osztrogon.
3361 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3362 a fixed revision for the openwebrtc-gst-plugins.
3364 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
3366 Unreviewed build fix. Don't try to report stats for all benchmarks.
3367 Just report the geometric mean of preferred means.
3369 * Scripts/run-jsc-benchmarks:
3371 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
3373 run-jsc-benchmarks should only report preferred mean
3374 https://bugs.webkit.org/show_bug.cgi?id=142874
3376 Reviewed by Geoffrey Garen.
3378 Just collect statistics for the preferred mean.
3380 * Scripts/run-jsc-benchmarks:
3382 2015-03-19 Alex Christensen <achristensen@webkit.org>
3384 [Content Extensions] Test regular expression parse failures.
3385 https://bugs.webkit.org/show_bug.cgi?id=142872
3387 Reviewed by Benjamin Poulain.
3389 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3390 (TestWebKitAPI::testPatternStatus):
3391 (TestWebKitAPI::TEST_F):
3392 Added tests for each parsing status.
3394 2015-03-19 Alex Christensen <achristensen@webkit.org>
3396 Fix API tests after r181754.
3398 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3399 (TestWebKitAPI::testRequest):
3401 2015-03-19 Brady Eidson <beidson@apple.com>
3403 Part of content extensions should apply css selectors
3404 https://bugs.webkit.org/show_bug.cgi?id=142604
3406 Reviewed by Alex Christensen.
3408 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3409 (WebCore::ContentExtensions::operator<<):
3411 2015-03-19 Brent Fulgham <bfulgham@apple.com>
3413 [Win] Activate tests on EWS
3414 https://bugs.webkit.org/show_bug.cgi?id=142850
3416 Reviewed by Alexey Proskuryakov.
3418 * Scripts/webkitpy/common/config/ews.json: Add me as
3419 the EWS bot watcher, and activate tests.
3421 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
3423 [GTK] Fix inspector userinterface related incremental build issue
3424 https://bugs.webkit.org/show_bug.cgi?id=142849
3426 Reviewed by Carlos Garcia Campos.
3428 * Scripts/webkitdirs.pm:
3429 (shouldRemoveCMakeCache):
3431 2015-03-18 Alex Christensen <achristensen@webkit.org>
3433 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3434 https://bugs.webkit.org/show_bug.cgi?id=142799
3436 Reviewed by Brady Eidson.
3438 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3439 (TestWebKitAPI::testPattern):
3440 (TestWebKitAPI::TEST_F):
3441 Start testing regex failures.
3443 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
3445 Fix StringView typos after r181525 and r181558
3446 https://bugs.webkit.org/show_bug.cgi?id=142772
3448 Reviewed by Darin Adler.
3450 Add some tests in [1] to cover the StringView::startsWith,
3451 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
3452 StringView::endsWithIgnoringASCIICase implementations.
3454 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3455 (TestWebKitAPI::TEST):
3457 2015-03-18 Dana Burkart <dburkart@apple.com>
3459 Remove extraneous import to fix the build.
3463 * Scripts/webkitpy/port/driver.py:
3465 2015-03-18 Dana Burkart <dburkart@apple.com>
3467 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
3468 https://bugs.webkit.org/show_bug.cgi?id=142547
3470 Reviewed by Alexey Proskuryakov.
3472 * Scripts/webkitpy/port/driver.py:
3473 (Driver._setup_environ_for_driver):
3475 2015-03-18 Alexey Proskuryakov <ap@apple.com>
3477 Tweak how AppleSystemFontOSSubversion default is added
3478 https://bugs.webkit.org/show_bug.cgi?id=142835
3480 Reviewed by Dan Bernstein.
3482 * DumpRenderTree/mac/DumpRenderTree.mm:
3483 (setDefaultsToConsistentValuesForTesting):
3485 2015-03-18 Dan Bernstein <mitz@apple.com>
3487 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3488 https://bugs.webkit.org/show_bug.cgi?id=142815
3490 Reviewed by Darin Adler.
3492 * Scripts/prepare-ChangeLog:
3493 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3494 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3495 keep consuming the quoted text until the matching quotation mark is reached. Emit the
3496 warning only if a line ends without a backslash before the matching quotation mark was found.
3498 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
3500 Remove unused "preprocessor" parameter to sub-CodeGenerators
3501 https://bugs.webkit.org/show_bug.cgi?id=142793
3503 Reviewed by Darin Adler.
3505 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3508 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
3510 [EFL] Bump gstreamer version to 1.4.4
3511 https://bugs.webkit.org/show_bug.cgi?id=142782
3513 Reviewed by Philippe Normand.
3515 * efl/jhbuild.modules:
3516 * efl/patches/gst-libav.patch:
3517 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3518 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3520 2015-03-17 Tim Horton <timothy_horton@apple.com>
3524 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3525 (WTR::InjectedBundle::platformInitialize):
3527 2015-03-17 Dean Jackson <dino@apple.com>
3529 check-webkit-style should allow "bool a : 1"
3530 https://bugs.webkit.org/show_bug.cgi?id=142794
3532 Reviewed by Brent Fulgham.
3534 We should allow member bitfields of the form:
3538 It seems that Visual Studio 8 was the last compiler that
3539 wasn't happy about not using unsigned here. We already have
3540 about 500 cases (in WebCore) where people were ignoring this rule.
3542 * Scripts/webkitpy/style/checkers/cpp.py:
3543 (check_language): Allow "bool".
3544 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3545 (CppStyleTest.test_enum_bitfields):
3546 (CppStyleTest.test_plain_integral_bitfields):
3548 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
3550 Compile character ranges targeting the same state as range check in the bytecode
3551 https://bugs.webkit.org/show_bug.cgi?id=142759
3553 Reviewed by Alex Christensen.
3555 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3556 (TestWebKitAPI::TEST_F):
3558 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
3560 W3C test parser and converter should use test importer host
3561 https://bugs.webkit.org/show_bug.cgi?id=142729
3563 Reviewed by Bem Jones-Bey.
3565 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3566 This enables adding more TestImporter unit testing.
3567 This patch also ensures that the git object instantiated by TestDownloader is using the
3568 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3570 * Scripts/webkitpy/common/system/filesystem_mock.py:
3571 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3572 * Scripts/webkitpy/w3c/test_downloader.py:
3573 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3574 (TestDownloader.checkout_test_repository): Making use of the new git function.
3575 * Scripts/webkitpy/w3c/test_importer.py:
3576 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3577 (TestImporter.import_tests): Adding host as parameter to the converter.
3578 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3579 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3581 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
3582 * Scripts/webkitpy/w3c/test_parser.py:
3583 (TestParser.__init__): Adding host as parameter constructor.
3585 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
3587 [GTK] WebKitDOM objects leaking
3588 https://bugs.webkit.org/show_bug.cgi?id=118788
3590 Reviewed by Darin Adler and Sergio Villar Senin.
3592 Update DOMObjectCache unit test to check that DOM objects are also
3593 released when new contents are loaded in the web view, and the old
3594 document is detached from the frame.
3596 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3597 (testWebKitDOMObjectCache):
3598 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3601 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
3603 W3C test importer default import folder should be LayoutTests/imported/w3c
3604 https://bugs.webkit.org/show_bug.cgi?id=142728
3606 Reviewed by Bem Jones-Bey.
3608 * Scripts/webkitpy/w3c/test_importer.py:
3609 (parse_args): Updating the default destination option value to 'imported/w3c'.
3611 2015-03-17 Philippe Normand <pnormand@igalia.com>
3613 [GTK] basic OpenWebRTC build support
3614 https://bugs.webkit.org/show_bug.cgi?id=142393
3616 Reviewed by Carlos Garcia Campos.
3618 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3619 is not the upstream OpenWebRTC repository. This temporary fork
3620 contains a few patches needed by WebKit for audio/video rendering.
3622 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3624 [CMake][EFL] Build test tools only for developer mode
3625 https://bugs.webkit.org/show_bug.cgi?id=142761
3627 Reviewed by Csaba Osztrogonác.
3629 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3633 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
3635 Remove never used "useLayerOnTop" bindings generator argument
3636 https://bugs.webkit.org/show_bug.cgi?id=142773
3638 Reviewed by Darin Adler.
3640 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3643 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
3645 Enable ES6 classes by default
3646 https://bugs.webkit.org/show_bug.cgi?id=142774
3648 Reviewed by Gavin Barraclough.
3650 * Scripts/webkitperl/FeatureList.pm:
3652 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3654 Fix webkitpy tests after r181585.
3656 Looks like "me" cannot be anyone's email, it's a special case.
3658 * Scripts/webkitpy/common/config/contributors.json:
3660 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3662 Add tolerance to WebAudio tests
3663 https://bugs.webkit.org/show_bug.cgi?id=142676
3665 Reviewed by Tim Horton.
3667 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3669 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3670 (TestResultWriter.create_audio_diff_and_write_result):
3671 * Scripts/webkitpy/layout_tests/models/test_failures.py:
3672 (FailureAudio.write_failure):
3673 * Scripts/webkitpy/port/base.py:
3674 (Port.do_audio_results_differ):
3675 Diff audio failures.
3677 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3678 tests to use real parseable WAV data, and got rid of base64, which there didn't
3679 seem to have been any reason for.
3681 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3683 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3684 https://bugs.webkit.org/show_bug.cgi?id=142720
3686 Reviewed by Myles C. Maxfield.
3688 Activate system copies of Microsoft fonts for the current process, thus overriding
3689 any other ones that could be preferred by the system otherwise.
3691 * DumpRenderTree/mac/DumpRenderTree.mm:
3692 (activateSystemCoreWebFonts):