WebSocket: Introduce pywebsocket-0.6b2
[WebKit-https.git] / Tools / ChangeLog
1 2011-07-14  Yuta Kitamura  <yutak@chromium.org>
2
3         WebSocket: Introduce pywebsocket-0.6b2
4         https://bugs.webkit.org/show_bug.cgi?id=64534
5
6         Reviewed by Kent Tamura.
7
8         * Scripts/webkitpy/thirdparty/__init__.py:
9
10 2011-07-14  Dimitri Glazkov  <dglazkov@chromium.org>
11
12         Introduce TestExpectationsModel, split out of TestExpectations.
13         https://bugs.webkit.org/show_bug.cgi?id=64531
14
15         This is a simple split-and-make-work refactoring, a first step among many.
16
17         Reviewed by Adam Barth.
18
19         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members
20             out of TestExpectations and into TestExpectationsModel.
21
22 2011-07-14  Eric Seidel  <eric@webkit.org>
23
24         Move webkitpy off of loose mocks
25         https://bugs.webkit.org/show_bug.cgi?id=64508
26
27         Unreviewed.  Fixing a test which fails under test-webkitpy --all (but not in a normal run).
28
29         * Scripts/webkitpy/common/checkout/scm/git.py:
30
31 2011-07-14  Adam Barth  <abarth@webkit.org>
32
33         garden-o-matic should have a "rebaseline" button
34         https://bugs.webkit.org/show_bug.cgi?id=64446
35
36         Reviewed by Ojan Vafai.
37
38         This patch adds a basic Rebaseline button that copies the baselines
39         displayed in the results pane into the appropriate directory in your
40         working copy.
41
42         There are two main limitations:
43
44         1) There is no UI for actually committing the baselines.
45
46         2) The baselines are not optimized for redundancy (meaning you can have
47            identical baselines in both chromium-mac and chromium-win).
48
49         * Scripts/webkitpy/tool/commands/rebaseline.py:
50             - Turns out we need to create the directory for the baseline if it doesn't exist yet.
51         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
52             - Add an programatic API to call the server.
53         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
54             - Add the rebaseline button itself.
55         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
56             - Change the CSS so that the Rebaseline and Close buttons can
57               appear in the normal order in the DOM.
58         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
59             - Bind the event and translate the parameters.
60             - Hide/show the rebaseline button, as appropriate.
61         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
62             - Add some helpful utility functions for manipulating failure types.
63         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
64
65 2011-07-14  Ryosuke Niwa  <rniwa@webkit.org>
66
67         REGRESSION: webkit-patch roll-chromium-deps is broken
68         https://bugs.webkit.org/show_bug.cgi?id=64568
69
70         Reviewed by Dirk Pranke
71
72         Use _filesystem.join.
73
74         * Scripts/webkitpy/common/checkout/checkout.py:
75         * Scripts/webkitpy/common/checkout/checkout_unittests.py:
76
77 2011-07-14  Noam Rosenthal  <noam.rosenthal@nokia.com>
78
79         Adding myself to the reviewers list; No review needed.
80
81         * Scripts/webkitpy/common/config/committers.py:
82
83 2011-07-14  Adam Roben  <aroben@apple.com>
84
85         Don't use Element.prototype.classList in TestFailures
86
87         Safari 5 doesn't support it.
88
89         Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5
90
91         Reviewed by Daniel Bates.
92
93         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
94         (Element.prototype.hasStyleClass):
95         (Element.prototype.addStyleClass):
96         (Element.prototype.removeStyleClass):
97         (Element.prototype.toggleStyleClass):
98         Added these helper functions which simulate classList functionality.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:
101         Added. Tests for the above.
102
103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
104         (ViewController.prototype._domForPossiblyFlakyTests): Changed to use
105         toggleStyleClass/hasStyleClass instead of classList.
106
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
108         Added Utilities_unittests.js, and reordered the tested files to be in
109         roughly dependency order (i.e., the lowest-level files are imported
110         and tested first).
111
112 2011-07-14  Eric Seidel  <eric@webkit.org>
113
114         NRWT doesn't store the svn revision in full_results.json on chromium-win
115         https://bugs.webkit.org/show_bug.cgi?id=64492
116
117         Unreviewed.  Just fixing my test-webkitpy regression.
118
119         Fix the unit tests.  Unfortunately scm does not use a filesystem
120         object so we can't control the result of detect_scm_system.
121         When detect_scm_system would fail, we would log, which would
122         cause all passing_run integration tests to fail.
123
124         * Scripts/webkitpy/common/checkout/scm/scm.py:
125         * Scripts/webkitpy/layout_tests/controllers/manager.py:
126         * Scripts/webkitpy/layout_tests/port/base.py:
127         * Scripts/webkitpy/layout_tests/port/test.py:
128         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
129
130 2011-07-14  Eric Seidel  <eric@webkit.org>
131
132         NRWT doesn't store the svn revision in full_results.json on chromium-win
133         https://bugs.webkit.org/show_bug.cgi?id=64492
134
135         Reviewed by Ojan Vafai.
136
137         This should fix the bug.  Unfortunately this code is currently
138         impossible to test since it's impossible to mock detect_scm_system at the
139         moment.  I started re-writing scm.detection.py to be mockable, but decided that
140         was best left for another day.
141
142         * Scripts/webkitpy/layout_tests/controllers/manager.py:
143         * Scripts/webkitpy/layout_tests/port/base.py:
144
145 2011-07-14  Ojan Vafai  <ojan@chromium.org>
146
147         fix coding style of dashboard_base.js
148         https://bugs.webkit.org/show_bug.cgi?id=64545
149
150         Reviewed by Adam Roben.
151
152         The code changes to the files other than dashboard_base.js
153         are just fallout from renaming globals in dashboard_base.js.
154
155         * TestResultServer/static-dashboards/aggregate_results.html:
156         * TestResultServer/static-dashboards/builders.js:
157         * TestResultServer/static-dashboards/dashboard_base.js:
158         * TestResultServer/static-dashboards/flakiness_dashboard.html:
159         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
160         * TestResultServer/static-dashboards/timeline_explorer.html:
161         * TestResultServer/static-dashboards/treemap.html:
162
163 2011-07-14  Carlos Garcia Campos  <cgarcia@igalia.com>
164
165         Unreviewed. Fix WebKit2 GTK build after r90953.
166
167         * WebKitTestRunner/GNUmakefile.am:
168
169 2011-07-14  Adam Barth  <abarth@webkit.org>
170
171         garden-o-matic results pane should be more discoverable
172         https://bugs.webkit.org/show_bug.cgi?id=64513
173
174         Reviewed by Eric Seidel.
175
176         This patch causes us to trigger the results pane on mouse clicks
177         instead of mousein.  Also, handle the case of no results details more
178         elegantly.
179
180         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
181         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
182             - Change the binding to "click".
183         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
184             - Handle the "no results URLs" case explicitly instead of never
185               calling the callback.
186         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
187         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
188             - Show a message when there are no result details to show.
189         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
190
191 2011-07-14  Adam Barth  <abarth@webkit.org>
192
193         garden-o-matic should badge TIMEOUT failures
194         https://bugs.webkit.org/show_bug.cgi?id=64435
195
196         Reviewed by Eric Seidel.
197
198         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
199         (.regression .what a[draggable].TIMEOUT::before):
200             - Add TIMEOUT.
201
202 2011-07-14  Adam Barth  <abarth@webkit.org>
203
204         Fix Python exception blocking the commit-queue.
205
206         * Scripts/webkitpy/common/checkout/scm/git.py:
207
208 2011-07-13  Eric Seidel  <eric@webkit.org>
209
210         Move webkitpy off of loose mocks
211         https://bugs.webkit.org/show_bug.cgi?id=64508
212
213         Reviewed by Adam Barth.
214
215         Using Mock has caused us more pain than help.
216         It's possible that there was a cleaner way to use it
217         (maybe Mock(class) instead of inheriting from it?).
218         But for now, I've removed all uses of Mock from mocktool.py.
219
220         I also moved run_command into the only 3 files which call it
221         instead of leaving the deprecated method in executive.py.
222
223         I changed various direct calls to os.* to use filesystem instead.
224
225         * Scripts/webkitpy/common/checkout/checkout.py:
226         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
227         * Scripts/webkitpy/common/checkout/scm/git.py:
228         * Scripts/webkitpy/common/checkout/scm/scm.py:
229         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
230         * Scripts/webkitpy/common/checkout/scm/svn.py:
231         * Scripts/webkitpy/common/system/executive.py:
232         * Scripts/webkitpy/common/system/executive_unittest.py:
233         * Scripts/webkitpy/tool/mocktool.py:
234         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
235         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
236
237 2011-07-13  Eric Seidel  <eric@webkit.org>
238
239         NRWT doesn't store the svn revision in full_results.json on chromium-win
240         https://bugs.webkit.org/show_bug.cgi?id=64492
241
242         Reviewed by Adam Barth.
243
244         Add a warning message in the revision='' case to help us diagnose
245         what's going wrong on the bot.
246
247         * Scripts/webkitpy/layout_tests/controllers/manager.py:
248
249 2011-07-13  Dirk Pranke  <dpranke@chromium.org>
250
251         new-run-webkit-tests: print baseline search path as part of config output
252         https://bugs.webkit.org/show_bug.cgi?id=64499
253
254         Reviewed by Eric Seidel.
255
256         * Scripts/webkitpy/layout_tests/controllers/manager.py:
257         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
258
259 2011-07-13  Adam Barth  <abarth@webkit.org>
260
261         gardening server should have an API for parsing changelogs
262         https://bugs.webkit.org/show_bug.cgi?id=64495
263
264         Reviewed by Eric Seidel.
265
266         This patch exposes much of the same information from CommitInfo in a
267         dictionary form, which is easier to send over-the-wire as JSON to the
268         frontend.
269
270         * Scripts/webkitpy/common/checkout/checkout.py:
271         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
272         * Scripts/webkitpy/tool/mocktool.py:
273         * Scripts/webkitpy/tool/servers/gardeningserver.py:
274         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
275         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
276
277 2011-07-13  Eric Seidel  <eric@webkit.org>
278
279         REGRESSION: GitTestWithMock.test_create_patch fails
280         https://bugs.webkit.org/show_bug.cgi?id=62945
281
282         Reviewed by Daniel Bates.
283
284         I was not able to reproduce the exact failure seen in the bug,
285         however this test was failing on my machine for other reasons.
286
287         I went through and did an audit of our run_command usage, it's
288         entirely in scm classes after this change.  (Not surprising given
289         that scm.py was the second file ever created in webkit.py.)
290
291         The real bug I'm fixing here is that we were setting executive.should_log
292         when the value had changed to executive._should_log.  Now we set the right one
293         and the test works again.
294
295         * Scripts/webkitpy/common/checkout/checkout.py:
296         * Scripts/webkitpy/common/checkout/scm/git.py:
297         * Scripts/webkitpy/common/checkout/scm/scm.py:
298         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
299         * Scripts/webkitpy/common/checkout/scm/svn.py:
300
301 2011-07-13  Ilya Sherman  <isherman@chromium.org>
302
303         Fix WTF header guard style check
304         https://bugs.webkit.org/show_bug.cgi?id=64488
305
306         Reviewed by David Levin.
307
308         * Scripts/webkitpy/style/checkers/cpp.py:
309         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
310
311 2011-07-13  Ojan Vafai  <ojan@chromium.org>
312
313         bring flakiness_dashboard.html closer to webkit style
314         https://bugs.webkit.org/show_bug.cgi?id=64477
315
316         Reviewed by Adam Barth.
317
318         * TestResultServer/static-dashboards/dashboard_base.js:
319         Fix bad variable name that would hit only when running the tests.
320         * TestResultServer/static-dashboards/flakiness_dashboard.html:
321         No code/logic changes. All moving/removing brackets, indents and moving things
322         to one line.
323
324 2011-07-13  Xan Lopez  <xlopez@igalia.com>
325
326         [GTK] Fix distcheck
327
328         Reviewed by Martin Robinson.
329
330         * WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.
331
332 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
333
334         Unreviewed fix. Add a "\n" to a printf that somehow got lost.
335
336         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
337         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
338
339 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
340
341         ApplicationCache Quota Output is Flakey
342         https://bugs.webkit.org/show_bug.cgi?id=64410
343
344         Reviewed by Alexey Proskuryakov.
345
346         Unify the delegate logging for reaching application cache
347         quotas. Truncate the space needed to the nearest 10000
348         for less flakey test output. This also better supports
349         printing NSUInteger on non-64 bit systems by casting to
350         an unsigned long.
351
352         * DumpRenderTree/mac/UIDelegate.mm:
353         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
354         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
355         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
356
357 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
358
359         Remove unused TestExpectations._overrides.
360         https://bugs.webkit.org/show_bug.cgi?id=64470
361
362         Reviewed by Adam Barth.
363
364         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
365
366 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
367
368         Introduce TestExpectationSerializer.list_to_string.
369         https://bugs.webkit.org/show_bug.cgi?id=64462
370
371         Reviewed by Adam Barth.
372
373         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
374         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
375
376 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
377
378         Consolidate expectations parsing code.
379         https://bugs.webkit.org/show_bug.cgi?id=64460
380
381         Reviewed by Adam Barth.
382
383         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
384
385 2011-07-12  Brent Fulgham  <bfulgham@webkit.org>
386
387         Standardize WinCairo conditionalized code under PLATFORM macro.
388         https://bugs.webkit.org/show_bug.cgi?id=64377
389
390         Reviewed by Maciej Stachowiak.
391
392         Update compile-time conditions that had previously used #ifdef
393         of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
394
395         * DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
396         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
397           define of WIN_CAIRO=1.
398         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
399           WinCairo.vsprops to set (to match Release build).
400
401 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
402
403         Eliminate TestExpectationsFile.
404         https://bugs.webkit.org/show_bug.cgi?id=64458
405
406         Turns out, we can just use a Python list.
407
408         Reviewed by Adam Barth.
409
410         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
411             removed TestExpectationsFile.
412         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
413             since there's no more custom iterator machinery.
414
415 2011-07-13  Philippe Normand  <pnormand@igalia.com>
416
417         Unreviewed, added my other email addresses.
418
419         * Scripts/webkitpy/common/config/committers.py:
420
421 2011-07-13  Adam Barth  <abarth@webkit.org>
422
423         Folks should only be listed once.
424
425         * Scripts/webkitpy/common/config/committers.py:
426
427 2011-07-13  Philippe Normand  <pnormand@igalia.com>
428
429         Unreviewed, adding myself as Reviewer.
430
431         * Scripts/webkitpy/common/config/committers.py:
432
433 2011-07-13  Adam Barth  <abarth@webkit.org>
434
435         Fix flickering bug introduced by my previous patch.  I forgot to change
436         the name of the class everywhere.
437
438         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
439
440 2011-07-12  Philippe Normand  <pnormand@igalia.com>
441
442         [GTK] media/media-blocked-by-willsendrequest.html fails
443         https://bugs.webkit.org/show_bug.cgi?id=63699
444
445         Reviewed by Martin Robinson.
446
447         * DumpRenderTree/gtk/DumpRenderTree.cpp:
448         (willSendRequestCallback): Abort the request if explicitely asked
449         by the LayoutTestController's willSendRequestReturnsNull() function.
450
451 2011-07-13  Adam Barth  <abarth@webkit.org>
452
453         Remove "Dismiss" button from garden-o-matic butterbar
454         https://bugs.webkit.org/show_bug.cgi?id=64443
455
456         Reviewed by Dimitri Glazkov.
457
458         We don't have any persistent butter bar messages yet, so the dismiss
459         button is premature (and fairly heavy, visually).
460
461         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
462         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
463
464 2011-07-13  Adam Barth  <abarth@webkit.org>
465
466         Refine garden-o-matic status pane
467         https://bugs.webkit.org/show_bug.cgi?id=64442
468
469         Reviewed by Dimitri Glazkov.
470
471         This patch makes two improvements to the status pane:
472
473         1) We only query the server for failure types that we're expecting.
474            This dramatically reduces the number of HTTP requests, making
475            loading the status pane faster.
476
477         2) The status pane now displays which test and which builder it is
478            showing results for.
479
480         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
481         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
482         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
483         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
484         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
485         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
486         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
487
488 2011-07-13  Adam Barth  <abarth@webkit.org>
489
490         garden-o-matic should show test results
491         https://bugs.webkit.org/show_bug.cgi?id=64440
492
493         Reviewed by Adam Roben.
494
495         This patch introduces the results detail pane, which appears at the
496         bottom of the window and contains test results from the bots.
497         Currently, you can activate the pane by mousing over one of the builder
498         names associated with a failing test.
499
500         This is just a first iteration of the UI.  There's no way to resize or
501         zoom in on elements of the details pane, and images likely aren't sized
502         correctly, but it's a place to start.
503
504         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
505             - Add constants for our data attributes so we don't typo them!
506         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
507             - Add DOM structure for the details pane.
508         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
509         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
510             - Bind events for showing and hiding the details pane.
511         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
512             - Reduce the number of result types that we query for to avoid
513               overfilling the details pane.  We'll probably need another
514               solution here in the long-term.  For example, we could use tabs
515               to pack more results into the pane.
516         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
517         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
518             - Now that we're using the config package during testing, we need
519               to include it in the testing HTML.
520         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
521         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
522             - Change the DOM structure of the results detail to make it fit
523               nicely in the details pane (rather than flowing freely in the
524               body, as it did before).
525
526 2011-07-13  Adam Roben  <aroben@apple.com>
527
528         Make TestFailures show every time a possibly-flaky test failed, but hide it by default
529
530         It's useful to be able to see every time a flaky test failed to see whether it failed the
531         same way every time. But doing so takes a lot of space, so the list of failures is now
532         collapsed by default and can be revealed using a disclosure triangle.
533
534         Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
535         flaky tests as I would like, even though the page is already so long
536
537         Reviewed by Dimitri Glazkov.
538
539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
540         (FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
541         function. Now returns all failures for the given test.
542
543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
544         Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
545         more over time.
546
547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
548         (LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
549         that we no longer return passing builds for possibly-flaky tests.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
552         (.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
553         flakiness examples small, too, since it can get quite long.
554
555         (.disclosure-triangle):
556         (.expanded > .disclosure-triangle):
557         Simple styles for the disclosure triangle.
558
559         (.flakiness-examples-list): Collapse the list by default.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
562         (ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
563         _domForPossiblyFlakyTests.
564         (ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
565         of each test name, and the number of failures to the right. When the disclosure triangle is
566         clicked for the first time, we build up the list of failures and expand the element. After
567         that we just collapse or expand the element on subsequent clicks.
568
569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
570         Pulled in new tests.
571
572 2011-07-13  Adam Roben  <aroben@apple.com>
573         
574         Teach TestFailures to understand NRWT's output when it exits early due to too many failures
575
576         Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
577         exits early
578
579         Reviewed by Dimitri Glazkov.
580
581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
582         (Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
583         it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
584         line. Tightened up the regex that's used to parse the number of failing tests to require the
585         leading number to be followed by whitespace so that we won't parse the "2011" in
586         "2011-07-13" as a number of failures.
587
588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
589         Added a test for the above.
590
591 2011-07-12  Dimitri Glazkov  <dglazkov@chromium.org>
592
593         Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
594         https://bugs.webkit.org/show_bug.cgi?id=64386
595
596         This is the first step in converting TestExpectations to a real model.
597         * TestExpectationsLine represents a line in the test_expectations.txt file, and
598         * TestExpectationsFile represents the file, which is a collection of lines.
599
600         Reviewed by Adam Barth.
601
602         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
603         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
604         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
605
606 2011-07-13  Xan Lopez  <xlopez@igalia.com>
607
608         [GTK] Do not grab focus too early in DRT.
609
610         Reviewed by Gustavo Noronha.
611
612         It causes a layout to happen and a progress signal to be emitted
613         since r90900, but at this point we don't have a
614         LayoutTestController object and we'll eventually crash. Since we
615         already grab focus at the beginning of runTest() this is
616         redundant, so get rid of it to fix the crash.
617
618         * DumpRenderTree/gtk/DumpRenderTree.cpp:
619         (main): remove call to grab_focus
620
621 2011-07-13  Sheriff Bot  <webkit.review.bot@gmail.com>
622
623         Unreviewed, rolling out r90893 and r90894.
624         http://trac.webkit.org/changeset/90893
625         http://trac.webkit.org/changeset/90894
626         https://bugs.webkit.org/show_bug.cgi?id=64441
627
628         NRWT still doesn't work on qt-mac platform (Requested by Ossy
629         on #webkit).
630
631         * Scripts/run-webkit-tests:
632         (useNewRunWebKitTests):
633
634 2011-07-13  Csaba Osztrogonác  <ossy@webkit.org>
635
636         [Qt] NRWT should pick up the right httpd config file
637         https://bugs.webkit.org/show_bug.cgi?id=64086
638
639         * Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.
640         (useNewRunWebKitTests):
641
642 2011-07-12  Mark Rowe  <mrowe@apple.com>
643
644         Fix the 32-bit build.
645
646         * DumpRenderTree/mac/UIDelegate.mm:
647         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
648         Cast the NSUInteger value to unsigned long to match the format specifier.
649
650 2011-07-12  Adam Barth  <abarth@webkit.org>
651
652         Improve garden-o-matic UI when the bots fail to report revision numbers
653         https://bugs.webkit.org/show_bug.cgi?id=64427
654
655         Reviewed by Dimitri Glazkov.
656
657         At least Win (dbg)(2) seems to fail to report the SVN revision number
658         in full_results.json.  This patch makes garden-o-matic more robust to
659         missing revision numbers.
660
661         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
662         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
663         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
664         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
665         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
666
667 2011-07-12  Adam Barth  <abarth@webkit.org>
668
669         Adjust garden-o-matic layout to use fewer lines
670         https://bugs.webkit.org/show_bug.cgi?id=64422
671
672         Reviewed by Ojan Vafai.
673
674         This patch effectively merges the test name line with the list of
675         builders on which the test fails.  Each test failure now occupies two
676         lines instead of three.
677
678         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
679         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
680         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
681
682 2011-07-12  Adam Barth  <abarth@webkit.org>
683
684         garden-o-matic should label tests failures of new tests as such
685         https://bugs.webkit.org/show_bug.cgi?id=64421
686
687         Reviewed by Ojan Vafai.
688
689         Also, we shouldn't dim failures of new tests, even if we've only seen
690         them once because they're likely to be real problems that need
691         attention.
692
693         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
694         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
695         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
696         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
697         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
698         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
699         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
700         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
701         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
702         * Scripts/webkitpy/tool/servers/gardeningserver.py:
703
704 2011-07-12  Adam Barth  <abarth@webkit.org>
705
706         garden-o-matic should display how many times we've seen a failure
707         https://bugs.webkit.org/show_bug.cgi?id=64417
708
709         Reviewed by Ojan Vafai.
710
711         This patch adds some UI to display how many times we've seen a given
712         failure, which can be helpful for determining whether that failure is a
713         real failure or a flaky test.
714
715         When a failure has only been seen once (i.e., only a single run on a
716         single bot), we set the opacity of to 50% to avoid distracting the
717         gardener.
718
719         This patch also refactors the failure walker to have a simpler API
720         internally by moving from an object-oriented paradigm to a functional
721         paradigm.
722
723         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
724         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
725         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
726         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
727         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
728         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
729
730 2011-07-12  Chris Rogers  <crogers@google.com>
731
732         Enable Web Audio for chromium DRT
733         https://bugs.webkit.org/show_bug.cgi?id=64409
734
735         Reviewed by James Robinson.
736
737         * DumpRenderTree/chromium/TestShell.cpp:
738         (TestShell::TestShell):
739
740 2011-07-12  Adam Barth  <abarth@webkit.org>
741
742         Tweak some UI in garden-o-matic now that the tree actually has a
743         failure and I can see what this all looks like.
744
745         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
746         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
747         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
748
749 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
750
751         Unreviewed. Skipping a few tests which fail due to differing output
752         in recent ApplicationCache quota tests. Reenabling the tests is
753         tracked by <http://webkit.org/b/64410>.
754
755         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
756         (WebCore::DumpRenderTree::dumpApplicationCacheQuota): This should
757         have been a space, not a newline.
758
759 2011-07-12  Adam Barth  <abarth@webkit.org>
760
761         garden-o-matic should display regression ranges
762         https://bugs.webkit.org/show_bug.cgi?id=64407
763
764         Reviewed by Dimitri Glazkov.
765
766         This patch computes a regression range for a failure by intersecting
767         the regression ranges seen by the various bots.  We make the underlying
768         assumption that a test is only failing due to one revision at any given
769         moment.  If that's not true, this code probably explodes.
770
771         The regression ranges appear asynchronously, which might be a jarring
772         UI.  We'll have to experiment to see.
773
774         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
775         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
776         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
777         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
778         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
779         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
780         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
781
782 2011-07-12  Adam Barth  <abarth@webkit.org>
783
784         cr-linux-ews should run pixel tests
785         https://bugs.webkit.org/show_bug.cgi?id=64394
786
787         Reviewed by Ojan Vafai.
788
789         This patch enabled pixel test on the cr-linux-ews.  Running a quick
790         test on the bots, it looks like we have five pixel failures, related to
791         some missing fonts.  I've also made the bots skip failing tests to
792         avoid uploading huge zip files to bugs.webkit.org (with all the exected
793         IMAGE failures).
794
795         * Scripts/webkitpy/common/config/ports.py:
796         * Scripts/webkitpy/common/config/ports_unittest.py:
797
798 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
799
800         ApplicationCache update should not immediately fail when reaching per-origin quota
801         https://bugs.webkit.org/show_bug.cgi?id=64177
802
803         Reviewed by Alexey Proskuryakov.
804
805         Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
806         to disable the default behavior of raising the default per-origin
807         quota to 5MB when reached. This allows us to test what happens
808         when the quota is reached and not increased.
809
810         * DumpRenderTree/LayoutTestController.cpp:
811         (LayoutTestController::LayoutTestController):
812         (disallowIncreaseForApplicationCacheQuotaCallback):
813         (LayoutTestController::staticFunctions):
814         * DumpRenderTree/LayoutTestController.h:
815         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
816         (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
817         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
818         (LayoutTestController::reset):
819         * DumpRenderTree/qt/LayoutTestControllerQt.h:
820         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
821         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
822         Expose a function to prevent automatically increasing the per-origin
823         quota when the quota is reached. This allows us to test what happens
824         when a user would "disallow" a quota increase.
825
826         * DumpRenderTree/mac/UIDelegate.mm:
827         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
828         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
829         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
830         Respect the new disallowIncrease flag and dump the spaceNeeded values
831         for ports that implement application cache quotas.
832
833 2011-07-12  Ojan Vafai  <ojan@chromium.org>
834
835         fix flakiness dashboard to work with new crash log filenames
836         https://bugs.webkit.org/show_bug.cgi?id=64393
837
838         Reviewed by Adam Barth.
839
840         * TestResultServer/static-dashboards/flakiness_dashboard.html:
841
842 2011-07-12  Adam Barth  <abarth@webkit.org>
843
844         Add a happy animation to garden-o-matic when there are no failures
845         https://bugs.webkit.org/show_bug.cgi?id=64382
846
847         Reviewed by Ojan Vafai.
848
849         As requested by Ojan.
850
851         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
852         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
853         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
854         * Scripts/webkitpy/tool/servers/gardeningserver.py:
855
856 2011-07-12  Adam Barth  <abarth@webkit.org>
857
858         sheriffbot can't perform rollouts
859         https://bugs.webkit.org/show_bug.cgi?id=64370
860
861         Reviewed by Eric Seidel.
862
863         Now that we're not updating the working copy before processing every
864         IRC message, the rollout command needs to update it manually.
865
866         * Scripts/webkitpy/tool/bot/irc_command.py:
867         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
868
869 2011-07-12  Adam Barth  <abarth@webkit.org>
870
871         Fix the grammar in the FIXME comment.
872
873         * Scripts/webkitpy/common/net/resultsjsonparser.py:
874
875 2011-07-12  Eric Seidel  <eric@webkit.org>
876
877         NRWT should open test results page with Safari trunk, not the system provided one on Mac
878         https://bugs.webkit.org/show_bug.cgi?id=64346
879
880         Reviewed by Adam Barth.
881
882         To fix this I implemented Port.show_results_html_file in Mac, Gtk and Qt ports with
883         implementations (mostly) matching those found in old-run-webkit-tests.
884         There are still some minor differences for Qt which Qt hackers may wish to tweak.
885
886         I had to add a WebKitPort._port_flag_for_scripts method (similar to flag() in common.config.ports.py)
887         for the Qt/Gtk ports which always require a flag passed to scripts.
888
889         While trying to test this, I found that FactoryTest.test_chromium_gpu_linux
890         was using a real filesystem (due to assert_platform) which due to
891         global variables in config.py was causing set-webkit-configuration to have
892         an affect on unit test results!  So I fixed this by making FactoryTest.assert_port
893         pass a mock file system whenever calling factory.get.
894
895         Unfortunately TestPort was depending on always being passed a None filesystem
896         and asserting filesystem._tests (only true for unit_test_filesystem()).
897         So I just removed the FactoryTest.test_test and FactoryTest.test_dryrun tests
898         deciding that they were pretty much useless anyway.  If others feel strongly
899         I'm happy to fix this in a different way.
900
901         * Scripts/webkitpy/common/system/executive.py:
902          - default arguments in python are screwy.  They use a single shared
903            instance, so it's better to use argument=None and then argument = argument or Default()
904            if you have any chance of mutating (or returning) the default argument.
905         * Scripts/webkitpy/layout_tests/port/config.py:
906          - This code is wrong.  We don't need to use a global variable here (as far as I can tell).
907            I'm not fixing it in this patch, but I've marked it with a FIXME and we can convert to
908            storing the results of the read on the Config object (which should only be created once during normal operation).
909            Unit tests shouldn't be hitting the disk anyway.  It's possible Config should move off of Port and onto Tool/Host directly.
910         * Scripts/webkitpy/layout_tests/port/factory.py:
911         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
912         * Scripts/webkitpy/layout_tests/port/gtk.py:
913         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
914         * Scripts/webkitpy/layout_tests/port/mac.py:
915         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
916         * Scripts/webkitpy/layout_tests/port/qt.py:
917         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
918         * Scripts/webkitpy/layout_tests/port/webkit.py:
919
920 2011-07-12  Adam Roben  <aroben@apple.com>
921
922         Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot
923
924         Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
925         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
926
927         Reviewed by Daniel Bates.
928
929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
930         (Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
931         exit status but we didn't find any failure counts, assume that there was some error that
932         caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).
933
934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
935         Added a new test that shows that we get a failingTestCount of -1 when run-webkit-tests dies
936         early.
937         (runGetNumberOfFailingTestsTest): Moved most code here from the only pre-existing test in this
938         file.
939
940         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
941         (LayoutTestResultsLoader.prototype.start): Bump the cache number so old cached data that was
942         tainted by the bug fixed in this patch will be evicted.
943
944 2011-07-12  Adam Barth  <abarth@webkit.org>
945
946         cr-linux-ews complains about tests that aren't actually failing
947         https://bugs.webkit.org/show_bug.cgi?id=64367
948
949         The underlying problem here is that full_results.json doesn't have
950         enough information to determine whether a given test result was
951         expected because whether an actual result is expected depends on
952         whether full_results.json was generated duing a test run that included
953         pixel tests.
954
955         The right long-term solution is to make full_results.json a complete
956         description of what happened durning a test run.  In this patch
957         however, to stop the spam, this patch makes the jsonresultsparser
958         ignore pixel failures.
959
960         (I'm landing this patch unreviewed in order to stop the bots from
961         spamming.  I'll happily address any review comments in a follow-up
962         patch.)
963
964         * Scripts/webkitpy/common/net/resultsjsonparser.py:
965         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
966
967 2011-07-12  Adam Barth  <abarth@webkit.org>
968
969         Re-work garden-o-matic UI to begin to look like the mocks
970         https://bugs.webkit.org/show_bug.cgi?id=64334
971
972         Reviewed by Dimitri Glazkov.
973
974         This patch changes how we display failures to be more like the mock the
975         dglazkov made. We now can display the same information much more
976         compactly.
977
978         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
979         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
980         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
981         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
982         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
983         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
984         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
985         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
986         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
987         * Scripts/webkitpy/tool/servers/gardeningserver.py:
988
989 2011-07-11  Adam Roben  <aroben@apple.com>
990
991         Extract TestFailures's bug-filing code into two new classes
992
993         Fixes <http://webkit.org/b/64300> TestFailures page's new-bug-filing code is a mess!
994
995         Reviewed by Darin Adler and Adam Barth.
996
997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
998         (Buildbot.prototype.resultsDirectoryURL): Changed to return a URI-encoded URL. Otherwise the
999         URL isn't valid (and it's harder to mock this function).
1000
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js:
1002         Added. Just tests the above change (for now).
1003
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1005         Added a license header, enclosed everything in a closure to avoid polluting the global
1006         namespace, changed the test name to actually describe the passing condition, and replaced
1007         uses of equals() with equal(). (The latter is the actual name of the function, and matches
1008         deepEqual, etc.)
1009
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Added.
1011         (NewBugForm): This class knows how to construct a <form> used for filing new bugs in
1012         Bugzilla based on some parameters.
1013         (NewBugForm.prototype.domElement): Creates and returns the <form> element. Code came from
1014         ViewController.prototype._domForNewAndExistingBugs.
1015
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
1017         Added. Tests the above code.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js: Added.
1020         (TestFailureBugForm): This class knows how to construct a <form> element used for filing new
1021         bugs specifically about test failures. Code came from
1022         ViewController.prototype._domForNewAndExistingBugs.
1023         (TestFailureBugForm.prototype.domElement): Slightly customizes the <form> element returned
1024         by NewBugForm.
1025         (TestFailureBugForm.prototype._computeOperatingSystem):
1026         (TestFailureBugForm.prototype._computePlatform):
1027         (TestFailureBugForm.prototype._createBugTitle):
1028         (TestFailureBugForm.prototype._failingResultsHTMLURL):
1029         (TestFailureBugForm.prototype._failingRevision):
1030         (TestFailureBugForm.prototype._passingRevision):
1031         (TestFailureBugForm.prototype._regressionRangeString):
1032         Code came from ViewController.prototype._domForNewAndExistingBugs. I broke it out into
1033         separate functions to break up the rat's nest a bit.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js:
1036         Added. Tests the above code.
1037
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1039         (ViewController.prototype._domForNewAndExistingBugs): Moved code from here to
1040         TestFailureBugForm/NewBugForm, and changed this code to use a TestFailureBugForm.
1041
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1043         NewBugForm/TestFailureBugForm.js.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1046         Added new tests and required files.
1047
1048 2011-07-12  Adam Roben  <aroben@apple.com>
1049
1050         Test that no intermediate WTF::Strings are created when concatenating with string literals
1051
1052         Test for <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
1053         operator+ is suboptimal
1054
1055         Reviewed by Darin Adler.
1056
1057         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Added.
1058         (TestWebKitAPI::TEST): Test that a bunch of different string concatenation expressions don't
1059         create any intermediate WTF::Strings while they're being evaluated.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1063         Added new file.
1064
1065 2011-07-12  Eric Seidel  <eric@webkit.org>
1066
1067         [Qt] NRWT should pick up the right httpd config file
1068         https://bugs.webkit.org/show_bug.cgi?id=64086
1069
1070         Reviewed by Adam Barth.
1071
1072         This is more fall-out from the Port class inappropriately encapsulating
1073         both platform and port knowledge.  We need to split out some of this
1074         platform knowledge into a separate class which can be better shared
1075         between ports.
1076
1077         The fix was to move all the _path_to_apache_config_file logic down
1078         into the WebKitPort baseclass so that all of the ports can find the
1079         right apache config file, regardless of what platform they may be running on.
1080
1081         I did not move this down into base.Port (even though I considered it).
1082         Chromium duplicates some of this logic, but since they have separate
1083         subclasses for each port-OS combination (e.g. ChromiumMac, ChromiumWin)
1084         they wouldn't notice the change.  Eventually we'll move this logic
1085         out of Port entirely, and then it will be shared by all ports.
1086
1087         I also cleaned up the http-config logic for ORWT while I was there,
1088         although since we're killing that code, I'm happy to revert that part
1089         of the change if changing it is viewed as needlessly risky.
1090
1091         During this cleanup, I noticed that no ports use the "default" httpd.conf
1092         which is left over from Mac OS X Tiger (and old linux distros) which used
1093         Apache 1.3.  I've removed httpd.conf (and associated support in ORWT) since
1094         we no longer support any ports which use this httpd.conf.
1095
1096         * Scripts/webkitperl/httpd.pm:
1097         (getHTTPDConfigPathForTestDirectory):
1098         * Scripts/webkitpy/layout_tests/port/base.py:
1099         * Scripts/webkitpy/layout_tests/port/gtk.py:
1100         * Scripts/webkitpy/layout_tests/port/mac.py:
1101         * Scripts/webkitpy/layout_tests/port/qt.py:
1102         * Scripts/webkitpy/layout_tests/port/webkit.py:
1103         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1104         * Scripts/webkitpy/layout_tests/port/win.py:
1105         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1106
1107 2011-07-11  Hironori Bono  <hbono@chromium.org>
1108
1109         Reviewed by Adam Roben.
1110
1111         Implement layoutTestController.setTextDirection for WebKit2 and Windows.
1112         https://bugs.webkit.org/show_bug.cgi?id=61931
1113
1114         This change implements layoutTextController.setTextDirection for WebKit2
1115         and Windows so we can run a layout test added by r87770 on them. Each
1116         implementation adds a wrapper function for Editor::setBaseWritingDirection()
1117         so LayoutTestController can call it.
1118
1119         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1120         (LayoutTestController::setTextDirection): Implemented the binding function
1121         for layoutTestController.setTextDirection (Windows).
1122         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1123         Added a binding function for layoutTestController.setTextDirection (WebKit2).
1124         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto.
1125         (WTR::LayoutTestController::setTextDirection):
1126         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto.
1127
1128 2011-07-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1129
1130         [EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time.
1131         https://bugs.webkit.org/show_bug.cgi?id=64293
1132
1133         Reviewed by Kent Tamura.
1134
1135         gEcoreEvas was being destroyed after shutdownEfl() was called, so the
1136         call to ecore_evas_free() failed.
1137
1138         We now shut it down manually before shutdownEfl() is called.
1139
1140         * DumpRenderTree/efl/ImageDiff.cpp:
1141         (main): Destroy gEcoreEvas before shutting down the EFL.
1142
1143 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
1144
1145         Make Chromium Mac and Linux tests bot core builders
1146         https://bugs.webkit.org/show_bug.cgi?id=63196
1147
1148         Reviewed by Adam Barth.
1149
1150         Added Chromium Mac and Linux Release Tests bots core builders.
1151
1152         Also rearranged the order of bots so that test bots show up right next to
1153         respective builders.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/config.json:
1156         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1157         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1158
1159 2011-07-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1160
1161         [EFL] DRT: Add code related to font management.
1162         https://bugs.webkit.org/show_bug.cgi?id=63989
1163
1164         Reviewed by Kent Tamura.
1165
1166         The added files are responsible for managing fontconfig and adding the
1167         fonts required by some layout tests to fontconfig's path.
1168
1169         * DumpRenderTree/efl/FontManagement.cpp: Added.
1170         (getFontDirectories):
1171         (getFontFiles):
1172         (addFontDirectories):
1173         (addFontFiles):
1174         (addFontsToEnvironment):
1175         * DumpRenderTree/efl/FontManagement.h: Added.
1176
1177 2011-07-08  Dirk Pranke  <dpranke@chromium.org>
1178
1179         nrwt: linting fixes
1180         https://bugs.webkit.org/show_bug.cgi?id=64225
1181
1182         Reviewed by Eric Siedel.
1183
1184         Miscellaneous linting fixes. The most notable change is that
1185         we add public attributes for user, executive, filesystem, and
1186         options on the Port object, so we don't have to refer to the
1187         "protected" versions all over the place".
1188
1189         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1190         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1191         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1192         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py:
1193         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1194         * Scripts/webkitpy/layout_tests/port/base.py:
1195         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1196
1197 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
1198
1199         webkit-patch roll-chromium-deps no longer works
1200         https://bugs.webkit.org/show_bug.cgi?id=64324
1201
1202         Reviewed by James Robinson.
1203
1204         Lower the minimum commit message length to 10.
1205
1206         * Scripts/webkitpy/tool/steps/commit.py:
1207
1208 2011-07-11  Alice Boxhall  <aboxhall@chromium.org>
1209
1210         Convert json_results_generator.py to output version 4 JSON.
1211         https://bugs.webkit.org/show_bug.cgi?id=60869
1212
1213         Reviewed by Ojan Vafai.
1214
1215         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1216         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1217         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1218
1219 2011-07-11  Martin Robinson  <mrobinson@igalia.com>
1220
1221         [GTK] [NRWT] Pixel tests do not work
1222         https://bugs.webkit.org/show_bug.cgi?id=64091
1223
1224         Reviewed by Eric Seidel.
1225
1226         Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
1227         path to the ImageDiff binary.
1228
1229         * Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
1230
1231 2011-07-11  Dirk Pranke  <dpranke@chromium.org>
1232
1233         Fix hang on win32 in a multiprocessing test that shouldn't have been running.
1234
1235         Unreviewed, build fix.
1236
1237         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1238
1239 2011-07-11  Adam Roben  <aroben@apple.com>
1240
1241         Don't count leaks as test failures on TestFailures's front page
1242
1243         As a bonus, this patch adds our first unit test.
1244
1245         Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
1246         are failing on the Leaks bot than actually are
1247
1248         Reviewed by Adam Barth.
1249
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1251         (Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
1252         failure counts.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1255         Added. Contains a simple test to show that leaks aren't counted as test failures.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1258         Added. This is the test harness.
1259
1260 2011-06-14  Mike Stegeman  <mrstegeman@gmail.com>
1261
1262         [GTK] Add API to allow setting local storage database path
1263         https://bugs.webkit.org/show_bug.cgi?id=62091
1264
1265         Reviewed by Martin Robinson and Gustavo Noronha.
1266
1267         Expose the path of the localStorage databases through a setting
1268         to allow HTML5 localStorage to be persistent. New setting is:
1269         html5-local-storage-database-path
1270
1271         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1272         (resetDefaultsToConsistentValues):
1273
1274 2011-07-11  Adam Barth  <abarth@webkit.org>
1275
1276         garden-o-matic should be able to rebaseline tests
1277         https://bugs.webkit.org/show_bug.cgi?id=64186
1278
1279         Reviewed by Eric Seidel.
1280
1281         This patch contains a simple HTTP server binding for the
1282         rebaseline-test command.  The frontend will appear in another patch.
1283
1284         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1285         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1286         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1287
1288 2011-07-11  Adam Barth  <abarth@webkit.org>
1289
1290         Add some basic UI for showing regression ranges
1291         https://bugs.webkit.org/show_bug.cgi?id=64243
1292
1293         Reviewed by Eric Seidel.
1294
1295         This UI is all temporary.  It exists mostly just to have some buttons
1296         to click to exercise the code.
1297
1298         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
1299         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1300         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
1301         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
1302         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
1303
1304 2011-07-11  Adam Barth  <abarth@webkit.org>
1305
1306         garden-o-matic should be able to determine which revisions caused a given failure
1307         https://bugs.webkit.org/show_bug.cgi?id=64189
1308
1309         Reviewed by Adam Roben.
1310
1311         Walking the failure history looking for failures turns out to be
1312         slightly tricky because the network requests are asynchronous.
1313         Currently we do all the fetches serially and our cache is unbounded.
1314         We'll probably optimize both those parameters eventually.
1315
1316         This patch also generalizes some functionality in the unit testing
1317         framework to make testing this sort of code easier.
1318
1319         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
1320         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1321         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
1322
1323 2011-07-11  Adam Barth  <abarth@webkit.org>
1324
1325         Add a webkit-patch command for rebaselining an individual test
1326         https://bugs.webkit.org/show_bug.cgi?id=64246
1327
1328         Reviewed by Eric Seidel.
1329
1330         This patch introduces a command that's able to rebaseline a single
1331         test.  Currently, the command works only with the build.chromium.org
1332         buildbots, but extending it to work with the build.webkit.org bots
1333         shouldn't be that hard.
1334
1335         A complete rebaseling tool should also include an "optimize baselines"
1336         command (which moves/deletes baselines in order to reduce the number of
1337         expected results files), but that will come in a future patch.
1338
1339         Really BuilderToPort should be merged into builders.py, but I'm going
1340         to save that for a future patch as well.  (We need to stop shaving yaks
1341         at some point.)
1342
1343         * Scripts/webkitpy/tool/commands/rebaseline.py:
1344
1345 2011-07-11  Adam Barth  <abarth@webkit.org>
1346
1347         garden-o-matic should be able to roll out patches
1348         https://bugs.webkit.org/show_bug.cgi?id=64185
1349
1350         Reviewed by Eric Seidel.
1351
1352         This gardening server API is simply a binding to the rollout machinery
1353         already present in webkit-patch.
1354
1355         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1356         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1357         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
1358
1359 2011-07-11  Csaba Osztrogonác  <ossy@webkit.org>
1360
1361         [Qt][Mac] Unreviewed fix after r90746.
1362
1363         * Scripts/run-webkit-tests:
1364         (useNewRunWebKitTests): Really disable NRWT for qt-mac platform.
1365
1366 2011-07-11  Adam Roben  <aroben@apple.com>
1367
1368         Teach TestFailures that ORWT's results.html file might be missing due to all tests passing
1369
1370         There are three reasons why we might fail to fetch ORWT's results.html:
1371           - All tests passed, so no results.html was generated
1372           - Some error during the test run caused results.html not to be generated (e.g., ORWT
1373             timed out)
1374           - Some network error occurred when fetching results.html
1375
1376         We were failing to account for the first possibility in some cases. For test runs before
1377         r89610, we first check build.webkit.org/json to determine how many tests failed and whether
1378         ORWT exited early due to too many failures; if all tests passed then we don't fetch
1379         results.html at all. r89610 changed ORWT to put information in results.html about exiting
1380         early due to too many failures, so we no longer needed to check build.webkit.org/json to get
1381         that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
1382         still needed to check build.webkit.org/json to find out if all tests passed!
1383
1384         Now, for test runs after r89610, we check results.html first, and then check
1385         build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
1386         tests passing and the error cases.
1387
1388         Fixes <http://webkit.org/b/64280> TestFailures page can't pinpoint that r90699 caused 13
1389         tests to fail on Windows 7 Release (WebKit2 Tests)
1390
1391         Reviewed by David Kilzer.
1392
1393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1394         (LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
1395         cached data will get evicted. We were marking builds where all tests passed as errors!
1396         (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
1397         parameters to the fetchAndParseResultsHTML helper function, and added a similar
1398         fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
1399         from later in the function). For test runs before r89610, we first check
1400         build.webkit.org/json then check results.html. For builds after r89610, we first check
1401         results.html and then check build.webkit.org/json if we couldn't fetch results.html.
1402
1403 2011-07-11  Csaba Osztrogonác  <ossy@webkit.org>
1404
1405         new-run-webkit-tests does not support qt-arm or qt-4.8 results
1406         https://bugs.webkit.org/show_bug.cgi?id=64071
1407
1408         [Qt] NRWT should pick up the right httpd config file
1409         https://bugs.webkit.org/show_bug.cgi?id=64086
1410
1411         Reviewed by Zoltán Herczeg.
1412
1413         * Scripts/run-webkit-tests: Disable NRWT for qt-mac, qt-arm and qt-4.8 platforms until fix.
1414         (useNewRunWebKitTests):
1415
1416 2011-07-11  Kenichi Ishibashi  <bashi@chromium.org>
1417
1418         Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files
1419         https://bugs.webkit.org/show_bug.cgi?id=64248
1420
1421         Reviewed by Kent Tamura.
1422
1423         * DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp.
1424         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto.
1425         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto.
1426         * GNUmakefile.am: Ditto.
1427
1428 2011-07-10  Kenichi Ishibashi  <bashi@chromium.org>
1429
1430         Let plugins participate in form submission
1431         https://bugs.webkit.org/show_bug.cgi?id=13061
1432
1433         Adds NPPVformValue support to the testing plugin.
1434
1435         Reviewed by Anders Carlsson.
1436
1437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added FormValue.cpp
1438         * DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp: Added.
1439         (FormValue::FormValue): Ditto.
1440         (FormValue::NPP_GetValue): Ditto.
1441
1442 2011-07-11  Roland Steiner  <rolandsteiner@chromium.org>
1443
1444         Reviewed by Tony Chang.
1445
1446         Complete functions in filesystem.py
1447         https://bugs.webkit.org/show_bug.cgi?id=63528
1448
1449         - missing text file functions added
1450         - functions sorted
1451         - removed 'append' optional parameters (were unused)
1452         - adapted filesystem_mock in the same way
1453
1454         * Scripts/webkitpy/common/system/filesystem.py:
1455         * Scripts/webkitpy/common/system/filesystem_mock.py:
1456         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1457
1458 2011-07-10  Adam Barth  <abarth@webkit.org>
1459
1460         Clean up style in fallback path calculation
1461         https://bugs.webkit.org/show_bug.cgi?id=64239
1462
1463         Reviewed by Daniel Bates.
1464
1465         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1466         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1467         * Scripts/webkitpy/layout_tests/port/mac.py:
1468         * Scripts/webkitpy/layout_tests/port/win.py:
1469
1470 2011-07-10  Balazs Kelemen  <kbalazs@webkit.org>
1471
1472         [Qt][WK2] Implement the rest of WTR::PlatformWebView
1473         https://bugs.webkit.org/show_bug.cgi?id=63630
1474
1475         Reviewed by Kenneth Rohde Christiansen.
1476
1477         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1478         (WTR::PlatformWebView::windowFrame):
1479         (WTR::PlatformWebView::setWindowFrame):
1480
1481 2011-07-10  Mark Rowe  <mrowe@apple.com>
1482
1483         Teach build-webkit how to find the latest WebKitSystemInterface binary.
1484
1485         * Scripts/build-webkit:
1486
1487 2011-07-09  Adam Roben  <aroben@apple.com>
1488
1489         Teach TestFailures to abbreviate the examples of test flakiness
1490
1491         These lists can get quite long, and it's not really helpful in most cases to have soooooo
1492         many examples of flakiness.
1493
1494         Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
1495         long they're hard to navigate
1496
1497         Reviewed by Dan Bates.
1498
1499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
1500         (FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
1501         of examples, replace the middle items with a separator.
1502
1503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1504         (.flakiness-example-separator): Added styles for the separator.
1505
1506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1507         (ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
1508         the separator.
1509
1510 2011-07-09  Dirk Pranke  <dpranke@chromium.org>
1511
1512         nrwt: stack traces from worker-side exceptions aren't very useful inside test-webkitpy
1513         https://bugs.webkit.org/show_bug.cgi?id=64218
1514
1515         Reviewed by Eric Seidel.
1516
1517         Exceptions aren't picklable and can't be sent across the
1518         manager/worker message queue without losing information. NRWT
1519         handles this by turning the stack trace into a set of strings,
1520         and logging the strings when we receive an exception from the
1521         worker. However, when you are running tests and something
1522         crashes on the worker side, test-webkitpy prints the
1523         manager-side stack trace, which is just confusing and useless.
1524
1525         This patch changes the logic so that exceptions are passed
1526         through as-is when the worker and manager are in the same
1527         process (the --worker-model=inline option). This increases the
1528         code paths slightly but makes crashes much more useful.
1529
1530         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1531         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1532         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1533         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1534         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1535
1536 2011-07-09  Darin Fisher  <darin@chromium.org>
1537
1538         Eliminate bad dependency on gfx::Point.
1539         https://bugs.webkit.org/show_bug.cgi?id=64228
1540
1541         Reviewed by Kent Tamura.
1542
1543         * DumpRenderTree/chromium/EventSender.cpp:
1544         (initMouseEvent):
1545
1546 2011-07-08  Ojan Vafai  <ojan@chromium.org>
1547
1548         pull static dashboard files into the appengine server from the chromium repository
1549         https://bugs.webkit.org/show_bug.cgi?id=64208
1550
1551         Reviewed by Dirk Pranke.
1552
1553         These files belong in the WebKit repo since they are tied primarily to the webkit tests.
1554         They have some extra bits to support chromium's gtests, but that seems fine.
1555         Mainly, this will allow other WebKit hackers to hack on the dashboards.
1556
1557         As a nice side-effect, we can now push the dashboard files when we do appengine pushes
1558         instead of the weird thing we used to do of pulling them from the Chromium repository
1559         and storing them in the appengine datastore. This allows for cleaning up a lot of code
1560         and will likely make the dashboards load a bit faster.
1561
1562         The new JS files don't fully match WebKit style, but I'd like to clean that up in a
1563         followup patch if possible to maintain my sanity with this patch.
1564
1565         * TestResultServer/app.yaml:
1566         * TestResultServer/handlers/dashboardhandler.py: Removed.
1567         * TestResultServer/handlers/menu.py:
1568         * TestResultServer/main.py:
1569         * TestResultServer/model/dashboardfile.py: Removed.
1570         * TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
1571         * TestResultServer/static-dashboards/README.dygraph.txt: Added.
1572         * TestResultServer/static-dashboards/README.webtreemap.txt: Added.
1573         * TestResultServer/static-dashboards/aggregate_results.html: Added.
1574         * TestResultServer/static-dashboards/builders.js: Added.
1575         * TestResultServer/static-dashboards/dashboard_base.js: Added.
1576         * TestResultServer/static-dashboards/dygraph-combined.js: Added.
1577         * TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
1578         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
1579         * TestResultServer/static-dashboards/timeline_explorer.html: Added.
1580         * TestResultServer/static-dashboards/treemap.html: Added.
1581         * TestResultServer/static-dashboards/webtreemap.css: Added.
1582         * TestResultServer/static-dashboards/webtreemap.js: Added.
1583         * TestResultServer/stylesheets/dashboardfile.css: Removed.
1584         * TestResultServer/stylesheets/menu.css:
1585         * TestResultServer/templates/dashboardfilelist.html: Removed.
1586         * TestResultServer/templates/menu.html:
1587
1588 2011-07-08  Adam Roben  <aroben@apple.com>
1589
1590         Make TestFailures's list of flaky tests look more like the list of non-flaky tests
1591
1592         Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
1593
1594         Reviewed by Daniel Bates.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1597         (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
1598         tests.
1599         (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
1600         from here...
1601         (#failure-history > li): ...to here.
1602
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1604         (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
1605         styling purposes.
1606
1607 2011-07-08  Jeffrey Pfau  <jpfau@apple.com>
1608
1609         Unreviewed, add myself as committer.
1610
1611         * Scripts/webkitpy/common/config/committers.py:
1612
1613 2011-07-08  Adam Barth  <abarth@webkit.org>
1614
1615         TestResultsServer should keep old test results
1616         https://bugs.webkit.org/show_bug.cgi?id=64199
1617
1618         Reviewed by Ojan Vafai.
1619
1620         Having historical data will help us do failure archeology.
1621
1622         * TestResultServer/handlers/testfilehandler.py:
1623         * TestResultServer/model/testfile.py:
1624         * TestResultServer/templates/showfilelist.jsonp: Added.
1625
1626 2011-07-08  Adam Roben  <aroben@apple.com>
1627
1628         Remove commit-log-editor's dependency on Module::Load::Conditional
1629
1630         This module isn't available in Perl 5.8.8 (the version used on Leopard).
1631
1632         Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
1633         webkitpy.common.checkout.checkout_unittest failing on Leopard
1634
1635         Reviewed by Daniel Bates.
1636
1637         * Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of
1638         Module::Load::Conditional::can_load.
1639         (loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.
1640
1641 2011-07-08  Adam Roben  <aroben@apple.com>
1642
1643         Make checkout_unittest more robust against files moving around
1644
1645         Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
1646         Scripts directory
1647
1648         Reviewed by Adam Barth.
1649
1650         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1651         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
1652         object and use it to get the path to the Scripts directory, rather than hard-coding the
1653         relative path from this file to Scripts.
1654
1655 2011-07-08  Adam Roben  <aroben@apple.com>
1656
1657         Make TestFailures remember that run-webkit-tests timed out, even across reloads
1658
1659         Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
1660         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
1661
1662         Reviewed by Daniel Bates.
1663
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1665         (LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
1666         When true, it indicates that there was an error retrieving the results for this build and
1667         that the errorCallback should be called.
1668
1669 2011-07-08  Adam Barth  <abarth@webkit.org>
1670
1671         Teach garden-o-matic how to display test results
1672         https://bugs.webkit.org/show_bug.cgi?id=64141
1673
1674         Reviewed by Ojan Vafai.
1675
1676         This patch includes basic infrastructure for probing build.chromium.org
1677         for test results.  We only handle text and image tests, not anything
1678         complicated like reftests.  Also, we're using the revision/build
1679         independent results store on the server, so we're avoiding that
1680         complication for now.
1681
1682         It's slightly hacky that we need to probe the server to see what kinds
1683         of results exist.  A better solution would be to add CORS support to
1684         the server or to use the local server to help.
1685
1686         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
1687         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1688         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
1689         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1690         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
1691         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
1692
1693 2011-07-08  Dirk Pranke  <dpranke@chromium.org>
1694
1695         REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
1696         https://bugs.webkit.org/show_bug.cgi?id=64092
1697
1698         Reviewed by Tony Chang.
1699
1700         The code was incorrectly creating empty shards in the
1701         shard_in_two case.
1702
1703         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1704         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1705
1706 2011-07-08  Adam Roben  <aroben@apple.com>
1707
1708         Teach buildbot to figure out how many webkitpy/webkitperl tests failed
1709
1710         Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
1711         tests failed when looking at build.webkit.org
1712
1713         Reviewed by Eric Seidel.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1716         (TestWithFailureCount): New class that represents a test build step which has an associated
1717         failure count. Eventually we should move more of our test classes to deriving from this.
1718         (TestWithFailureCount.countFailures): Method for subclasses to override to say how many
1719         failures occurred.
1720
1721         (TestWithFailureCount.commandComplete):
1722         (TestWithFailureCount.evaluateCommand):
1723         (TestWithFailureCount.getText):
1724         (TestWithFailureCount.getText2):
1725         These were all based on RunGtkAPITests.
1726
1727         (RunPythonTests): Changed to inherit from TestWithFailureCount.
1728         (RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
1729         failures.
1730         (RunPerlTests): Changed to inherit from TestWithFailureCount.
1731         (RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
1732         failures.
1733
1734 2011-07-08  Adam Roben  <aroben@apple.com>
1735
1736         Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
1737
1738         Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
1739         bots due to commit-log-editor errors
1740
1741         Reviewed by Adam Barth.
1742
1743         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1744         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
1745         $CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
1746         commit-log-editor can find a value for the committer's email, and that the committer and
1747         author email addresses match, which will prevent commit-log-editor from inserting a "Patch
1748         by" line in the commit message.
1749
1750 2011-07-08  Andreas Kling  <kling@webkit.org>
1751
1752         [Qt][WK2] Views should expose QActions for basic navigation.
1753         https://bugs.webkit.org/show_bug.cgi?id=64174
1754
1755         Reviewed by Benjamin Poulain.
1756
1757         Bring the toolbar in Qt's MiniBrowser back to life.
1758
1759         * MiniBrowser/qt/BrowserView.cpp:
1760         (BrowserView::navigationAction):
1761         * MiniBrowser/qt/BrowserView.h:
1762         * MiniBrowser/qt/BrowserWindow.cpp:
1763         (BrowserWindow::BrowserWindow):
1764
1765 2011-07-08  Adam Roben  <aroben@apple.com>
1766
1767         Teach TestFailures how to find test names in commit-log-editor-style commit messages
1768
1769         TestFailures was relying on Trac turning the list of modified files in our commit messages
1770         into an HTML list. But Trac only does this when the list of modified files is indented.
1771         commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
1772         list, which was confusing TestFailures.
1773
1774         TestFailures now does much simpler parsing of the commit message (i.e., just a substring
1775         search) without relying at all on its structure.
1776
1777         Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
1778         fast/dom/HTMLProgressElement/progress-element-markup.html on Windows
1779
1780         Reviewed by David Kilzer.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1783         (Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
1784         message, just return its text.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1787         (ViewController.prototype._domForRegressionRange): Instead of searching for test names in
1788         each commit's list of modified files, just search for test names anywhere in the commit's
1789         message.
1790
1791 2011-07-08  Adam Barth  <abarth@webkit.org>
1792
1793         sheriffbot is too spammy in IRC
1794         https://bugs.webkit.org/show_bug.cgi?id=64153
1795
1796         Reviewed by Eric Seidel.
1797
1798         Reporting failures in IRC worked well when the tree was greener than it
1799         is today.  Nowadays, this feature mostly just results in spam about
1800         false positives.  If we reach a greener state, we can bring this code
1801         back.
1802
1803         (Another possibility is to restrict this feature to builder bots,
1804         rather than including testers, as we did before this patch.)
1805
1806         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1807         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1808
1809 2011-07-08  Adam Roben  <aroben@apple.com>
1810
1811         Ensure commit-log-editor adds a "Patch by" line when the author and committer are different
1812
1813         Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
1814         by" line. But some patches (like rollout patches) don't contain that line. Now we always add
1815         "Patch by" to the commit log regardless of the ChangeLog's contents.
1816
1817         Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
1818         should have been abarth@webkit.org
1819
1820         Reviewed by Anders Carlsson.
1821
1822         * Scripts/commit-log-editor:
1823         (createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
1824         before. If there is no "Reviewed by" line, try to put it just above the first modified file.
1825         If all else fails, put it at the end of the commit message.
1826         (patchAuthorshipString): Added. Code came from createCommitMessage.
1827
1828 2011-07-08  Herczeg Zoltan  <zherczeg@webkit.org>
1829
1830         Reviewed by Andreas Kling.
1831
1832         Adding myself as a reviewer.
1833
1834         * Scripts/webkitpy/common/config/committers.py:
1835
1836 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1837
1838         [wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.
1839
1840         * wx/build: Removed.
1841         * wx/build/build_utils.py: Removed.
1842         * wx/build/settings.py: Removed.
1843         * wx/build/waf_extensions.py: Removed.
1844         * wx/build/wxpresets.py: Removed.
1845         * wx/packaging/build-mac-installer.py:
1846
1847 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1848
1849         [wx] Unreviewed build fix, more fixes for install name issues.
1850
1851         * wx/packaging/build-mac-installer.py:
1852
1853 2011-07-07  Dirk Pranke  <dpranke@chromium.org>
1854
1855         test-webkitpy fails on chromium win
1856         https://bugs.webkit.org/show_bug.cgi?id=64137
1857
1858         Reviewed by Eric Seidel.
1859
1860         test-webkitpy doesn't play nicely with the multiprocessing
1861         module on win32. An earlier change actually reenabled the tests
1862         on win32 by mistake.
1863
1864         This patch also fixes a few cases where path names will trip
1865         things up on win32 (e.g., by testing unix paths on windows).
1866         We do not lose any real coverage here with those fixes.
1867
1868         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1869         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1870         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1871         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1872
1873 2011-07-07  Leandro Pereira  <leandro@profusion.mobi>
1874
1875         [ImageDiff] Calculate/print difference right after reading baseline image.
1876         https://bugs.webkit.org/show_bug.cgi?id=64117
1877
1878         Reviewed by Kent Tamura.
1879
1880         Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
1881         it.  Whichever happens first.
1882
1883         * DumpRenderTree/efl/ImageDiff.cpp:
1884         (main):
1885
1886 2011-07-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
1887
1888         [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
1889         https://bugs.webkit.org/show_bug.cgi?id=64107
1890
1891         Reviewed by Kent Tamura.
1892
1893         The pointer is later managed by BitmapContext, but it was being
1894         de-refed and deleted earlier by our RefPtr, causing crashes in all
1895         pixel tests.
1896
1897         We now call leakRef() to make sure it is not removed when our
1898         createBitmapContextFromWebView goes out of context.
1899
1900         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1901         (createBitmapContextFromWebView):
1902
1903 2011-07-07  Adam Roben  <aroben@apple.com>
1904
1905         Update TestFailures's title and header immediately upon navigation
1906
1907         Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks
1908
1909         Reviewed by Daniel Bates.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1912         (ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
1913         title.
1914         (ViewController.prototype._displayBuilder): Set the page's title and clear out any old
1915         content immediately instead of waiting for the first set of results for the history
1916         analyzer. As we receive new results from the analyzer we'll just clear out the main content
1917         area and replace it with the new info.
1918         (ViewController.prototype._displayTesters): Set the page's title and clear out any old
1919         content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
1920         in a little use of our removeAllChildren helper, too.
1921         (ViewController.prototype._setTitle): Added. Set's the page's title and the header text.
1922
1923 2011-07-07  Adam Roben  <aroben@apple.com>
1924
1925         Make Checkout use SCM's Executive instead of conjuring up its own
1926
1927         This will improve integration with the rest of webkitpy, particularly when invoked via
1928         webkit-patch.
1929
1930         Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
1931         Executive inappropriately
1932
1933         Reviewed by Adam Barth.
1934
1935         * Scripts/webkitpy/common/checkout/checkout.py:
1936         (Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
1937         our own use. SCM might have some super-special Executive that it uses under the covers, and
1938         we want to use it, too!
1939
1940         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1941         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
1942         method to call through to Executive.run_command.
1943
1944 2011-07-07  Adam Roben  <aroben@apple.com>
1945
1946         Make Term/ReadKey.pm an optional dependency of commit-log-editor
1947
1948         When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
1949
1950         Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
1951         webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
1952         Term/ReadKey.pm module
1953
1954         Reviewed by Xan Lopez.
1955
1956         * Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
1957         Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
1958         that existing commit messages will be preserved. (Users can manually remove existing commit
1959         messages using git-reset.)
1960
1961 2011-07-07  Adam Roben  <aroben@apple.com>
1962
1963         Keep testing that commit messages containing Unicode are handled properly by webkitpy
1964
1965         Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
1966         correctly handle Unicode in commit messages
1967
1968         Reviewed by Eric Seidel.
1969
1970         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in
1971         places in the ChangeLog that will end up being included in the commit message.
1972
1973 2011-07-07  Andreas Kling  <kling@webkit.org>
1974
1975         [Qt][WK2] Remove Symbian code.
1976         https://bugs.webkit.org/show_bug.cgi?id=64101
1977
1978         Reviewed by Benjamin Poulain.
1979
1980         * MiniBrowser/qt/BrowserWindow.cpp:
1981         (BrowserWindow::BrowserWindow):
1982         (BrowserWindow::screenshot):
1983         * MiniBrowser/qt/MiniBrowser.pro:
1984         * MiniBrowser/qt/MiniBrowserApplication.h:
1985         (WindowOptions::WindowOptions):
1986
1987 2011-07-07  Andreas Kling  <kling@webkit.org>
1988
1989         [Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
1990         https://bugs.webkit.org/show_bug.cgi?id=64099
1991
1992         Reviewed by Benjamin Poulain.
1993
1994         * MiniBrowser/qt/BrowserWindow.cpp:
1995         (BrowserWindow::openFile):
1996         (BrowserWindow::screenshot):
1997         (BrowserWindow::loadURLListFromFile):
1998
1999 2011-07-07  Adam Roben  <aroben@apple.com>
2000
2001         Completely ignore too-many-failures builds in TestFailures in most circumstances
2002
2003         Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
2004         really use them to perform regression analysis. The only time we want to pay attention to
2005         too-many-failures builds is when we're trying to explain when the current bout of
2006         too-many-failures started.
2007
2008         Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
2009         in a build that didn't even run it (because it exited early due to too many failues)
2010
2011         Reviewed by David Kilzer.
2012
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
2014         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
2015         too-many-failures handling that would cause us to blame builds that didn't even run a given
2016         test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
2017         build was itself a too-many-failures build.
2018
2019 2011-07-07  Adam Roben  <aroben@apple.com>
2020
2021         Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
2022
2023         Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
2024         commit-log-editor's
2025
2026         Reviewed by David Kilzer.
2027
2028         * Scripts/webkitpy/common/checkout/checkout.py:
2029         (Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
2030         the modified ChangeLogs, to generate the commit message, rather than trying to generate one
2031         ourselves.
2032
2033         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
2034         to match commit-log-editor's format.
2035         (CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
2036         directories so we can see how the various entries get labeled in the commit message.
2037         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
2038         instance that knows how to find commit-log-editor and pass it to our Checkout instance.
2039         Don't bother capturing output, since there shouldn't be any.
2040
2041 2011-07-07  Adam Roben  <aroben@apple.com>
2042
2043         Add a --print-log option to commit-log-editor
2044
2045         When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
2046         generates a commit message from those ChangeLogs, prints it to stdout, and exits.
2047
2048         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
2049         readable than commit-log-editor's
2050
2051         Reviewed by David Kilzer.
2052
2053         * Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
2054         option, which calls through to createCommitMessage, prints the result, and exits.
2055         (printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
2056         explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
2057
2058 2011-07-07  Adam Roben  <aroben@apple.com>
2059
2060         Extract commit-log-editor's commit-message-generation code into a separate function
2061
2062         As a bonus, we now skip a bunch of work in the case where we are generating a commit message
2063         for staged git changes.
2064
2065         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
2066         readable than commit-log-editor's
2067
2068         Reviewed by David Kilzer.
2069
2070         * Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
2071         file so that it will be defined even if we aren't operating on an existing log message.
2072         Moved a bunch of top-level code to generate the commit message from here...
2073         (createCommitMessage): ...to here.
2074
2075 2011-07-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2076
2077         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2078         https://bugs.webkit.org/show_bug.cgi?id=63988
2079
2080         Reviewed by Martin Robinson.
2081
2082         * MiniBrowser/gtk/BrowserWindow.c:
2083         (browserWindowConstructed):
2084         (decidePolicyForNavigationAction): Ignore the action if a link is
2085         clicked with the middle buttonm and open the link in a new window.
2086         (browserWindowPolicyClientInit):
2087
2088 2011-07-07  Adam Barth  <abarth@webkit.org>
2089
2090         Remove style_references.py
2091         https://bugs.webkit.org/show_bug.cgi?id=64070
2092
2093         Reviewed by Eric Seidel.
2094
2095         We never really adopted the _references design, and this file is a bit
2096         of an orphan at this point.
2097
2098         * Scripts/check-webkit-style:
2099         * Scripts/webkitpy/style/checker.py:
2100         * Scripts/webkitpy/style/checker_unittest.py:
2101         * Scripts/webkitpy/style/checkers/python.py:
2102         * Scripts/webkitpy/style/checkers/test_expectations.py:
2103         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2104         * Scripts/webkitpy/style/main_unittest.py:
2105         * Scripts/webkitpy/style_references.py: Removed.
2106
2107 2011-07-07  Eric Seidel  <eric@webkit.org>
2108
2109         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
2110         https://bugs.webkit.org/show_bug.cgi?id=64056
2111
2112         Unreviewed.
2113
2114         I had written this unittest prior to landing my change, but
2115         had named it qt_unitest.py, so it wasn't running (nor was
2116         it added to my git repo).
2117
2118         Once I fixe the name of the unittest file, it was very easy
2119         to fix the error in webkit.py (which already had a FIXME).
2120
2121         * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
2122         * Scripts/webkitpy/layout_tests/port/webkit.py:
2123
2124 2011-07-07  Eric Seidel  <eric@webkit.org>
2125
2126         Unreviewed.  Add more debug logging about which test expectations we're using.
2127
2128         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2129         * Scripts/webkitpy/layout_tests/port/webkit.py:
2130
2131 2011-07-06  Adam Barth  <abarth@webkit.org>
2132
2133         Remove unexpected_results.json
2134         https://bugs.webkit.org/show_bug.cgi?id=64065
2135
2136         Reviewed by Eric Seidel.
2137
2138         No one should be using this file any more.  This patch removes it from
2139         the face of the earth.  This patch also removes two NRWT-specific
2140         command line options that were implemented using
2141         unexpected_results.json.
2142
2143         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2144         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2145         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2146         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2147         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2148         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2149         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2150
2151 2011-07-07  Adam Barth  <abarth@webkit.org>
2152
2153         REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
2154         https://bugs.webkit.org/show_bug.cgi?id=64067
2155
2156         Reviewed by Eric Seidel.
2157
2158         The author of r90520 forgot to change the chromium_gpu.py implemenation
2159         of this method as well.
2160
2161         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2162
2163 2011-07-06  Eric Seidel  <eric@webkit.org>
2164
2165         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
2166         https://bugs.webkit.org/show_bug.cgi?id=64056
2167
2168         Reviewed by Adam Barth.
2169
2170         This fixes the MacPort's version of baseline_search_path to include
2171         wk2 fallback like WebKitPort's does.  This also re-works the QtPort
2172         to set self._name (as other ports do) so that WebKitPort's default
2173         implementations will understand Qt operating system flavors correctly
2174         (including when running wk2 tests).
2175
2176         In trying to test this, I realized that nearly all of our port-tests
2177         use the default FileSystem(), User() and Executive() objects, which
2178         is really bad, because they expose details of your system in the unittest results!
2179
2180         Once I fixed many of the Port() calls to pass MockFileSystem(), then
2181         MacPort.test_tests_for_other_platforms started failing, and I had to
2182         teach MockFileSystem.glob how to handle directories to make it work again.
2183
2184         I removed the useless PortTestCase.test_baseline_search_path and replaced
2185         it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.
2186
2187         * Scripts/webkitpy/common/config/ports.py:
2188         * Scripts/webkitpy/common/system/filesystem_mock.py:
2189         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2190         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2191         * Scripts/webkitpy/layout_tests/port/mac.py:
2192         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2193         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2194         * Scripts/webkitpy/layout_tests/port/qt.py:
2195         * Scripts/webkitpy/layout_tests/port/test_files.py:
2196         * Scripts/webkitpy/layout_tests/port/win.py:
2197         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
2198         * Scripts/webkitpy/tool/mocktool.py:
2199
2200 2011-07-06  Adam Barth  <abarth@webkit.org>
2201
2202         Wean rebaseline-server off unexpected_results.json
2203         https://bugs.webkit.org/show_bug.cgi?id=64063
2204
2205         Reviewed by Eric Seidel.
2206
2207         In the process of changing this code to use full_results.json, I
2208         noticed that the code was broken (because it wasn't tested).  This
2209         patch also adds test coverage for the broken code.
2210
2211         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2212         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2213         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2214
2215 2011-07-06  Adam Barth  <abarth@webkit.org>
2216
2217         Wean resultsjsonparser off unexpected_results.json
2218         https://bugs.webkit.org/show_bug.cgi?id=64061
2219
2220         Reviewed by Eric Seidel.
2221
2222         We're about to delete unexpected_results.json, so we need to remove all
2223         the users.
2224
2225         * Scripts/webkitpy/common/config/ports.py:
2226         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2227         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2228         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2229
2230 2011-07-06  Adam Barth  <abarth@webkit.org>
2231
2232         Cleanup result_summary.py
2233         https://bugs.webkit.org/show_bug.cgi?id=64057
2234
2235         Reviewed by Eric Seidel.
2236
2237         This class had a bunch of out-of-date docstrings that no longer make
2238         any sense.
2239
2240         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2241
2242 2011-07-06  Adam Barth  <abarth@webkit.org>
2243
2244         Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
2245         patches can be landed by the commit-queue.
2246
2247         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2248
2249 2011-07-06  Adam Barth  <abarth@webkit.org>
2250
2251         Normalize callers of logging.getLogger to use __name__
2252         https://bugs.webkit.org/show_bug.cgi?id=64054
2253
2254         Reviewed by Eric Seidel.
2255
2256         Most callers were already using __name__.  This patch makes everyone
2257         consistent.
2258
2259         * Scripts/webkitpy/common/checkout/diff_parser.py:
2260         * Scripts/webkitpy/common/checkout/scm/svn.py:
2261         * Scripts/webkitpy/common/net/statusserver.py:
2262         * Scripts/webkitpy/common/system/executive.py:
2263         * Scripts/webkitpy/common/system/file_lock.py:
2264         * Scripts/webkitpy/common/system/user.py:
2265         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2266         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2267         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2268         * Scripts/webkitpy/layout_tests/port/chromium.py:
2269         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2270         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2271         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2272         * Scripts/webkitpy/layout_tests/port/gtk.py:
2273         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2274         * Scripts/webkitpy/layout_tests/port/mac.py:
2275         * Scripts/webkitpy/layout_tests/port/qt.py:
2276         * Scripts/webkitpy/layout_tests/port/server_process.py:
2277         * Scripts/webkitpy/layout_tests/port/webkit.py:
2278         * Scripts/webkitpy/layout_tests/port/win.py:
2279         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2280         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2281         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2282         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2283         * Scripts/webkitpy/layout_tests/views/printing.py:
2284         * Scripts/webkitpy/python24/versioning.py:
2285         * Scripts/webkitpy/style/checker.py:
2286         * Scripts/webkitpy/style/checkers/test_expectations.py:
2287         * Scripts/webkitpy/style/patchreader.py:
2288         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2289
2290 2011-07-06  Adam Barth  <abarth@webkit.org>
2291
2292         Move model classes out of layout_package and into models
2293         https://bugs.webkit.org/show_bug.cgi?id=64053
2294
2295         Reviewed by Eric Seidel.
2296
2297         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2298         * Scripts/webkitpy/common/net/layouttestresults.py:
2299         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2300         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2301         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2302         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2303         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2304         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2305         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2306         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2307         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2308         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2309         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
2310         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
2311         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
2312         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
2313         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
2314         * Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
2315         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2316         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
2317         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
2318         * Scripts/webkitpy/layout_tests/models: Added.
2319         * Scripts/webkitpy/layout_tests/models/__init__.py: Added.
2320         * Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
2321         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
2322         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
2323         * Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
2324         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
2325         * Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
2326         * Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
2327         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
2328         * Scripts/webkitpy/layout_tests/port/chromium.py:
2329         * Scripts/webkitpy/layout_tests/views/printing.py:
2330         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2331         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2332         * Scripts/webkitpy/style_references.py:
2333         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2334         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2335         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2336         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2337         * Scripts/webkitpy/tool/commands/rebaseline.py:
2338
2339 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
2340
2341         nrwt: fix typo preventing http startup on windows
2342         https://bugs.webkit.org/show_bug.cgi?id=64050
2343
2344         Reviewed by Eric Siedel.
2345
2346         NRWT checks whether it needs to start the servers by looking
2347         for "/http/" in the test names. After r90520, the leading slash
2348         is not present, so the check isn't quite right.
2349
2350         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2351         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2352
2353 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
2354
2355         nrwt: remove --use-apache from the command line
2356         https://bugs.webkit.org/show_bug.cgi?id=63358
2357
2358         Reviewed by Adam Barth.
2359
2360         Re-land the fix in bug 63358 - the prior fix was flawed in that
2361         we were trying to start the http server during check_sys_deps()
2362         but not actually setting up the environment properly. This
2363         broken prior to this change, but exposed by it, since the patch
2364         changes the chromium port to call the base class's checks.
2365
2366         * Scripts/webkitpy/common/system/executive.py:
2367         * Scripts/webkitpy/layout_tests/port/base.py:
2368         * Scripts/webkitpy/layout_tests/port/chromium.py:
2369         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2370         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2371         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2372         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2373         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2375
2376 2011-07-06  Adam Barth  <abarth@webkit.org>
2377
2378         Move view-related code out of layout_package and into views
2379         https://bugs.webkit.org/show_bug.cgi?id=64051
2380
2381         Reviewed by Eric Seidel.
2382
2383         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2384         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2385         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2386         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2387         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
2388         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
2389         * Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
2390         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
2391         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2392         * Scripts/webkitpy/layout_tests/views: Added.
2393         * Scripts/webkitpy/layout_tests/views/__init__.py: Added.
2394         * Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
2395         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
2396         * Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
2397         * Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
2398
2399 2011-07-06  Adam Barth  <abarth@webkit.org>
2400
2401         Add goofy comments to explain why we have these files.
2402
2403         * Scripts/webkitpy/layout_tests/controllers/__init__.py:
2404         * Scripts/webkitpy/layout_tests/layout_package/__init__.py:
2405
2406 2011-07-06  Adam Barth  <abarth@webkit.org>
2407
2408         Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
2409         https://bugs.webkit.org/show_bug.cgi?id=64048
2410
2411         Reviewed by Eric Seidel.
2412
2413         * Scripts/webkitpy/layout_tests/controllers: Added.
2414         * Scripts/webkitpy/layout_tests/controllers/__init__.py: Added.
2415         * Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
2416         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
2417         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
2418         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
2419         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
2420         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
2421         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
2422         * Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
2423         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
2424         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
2425         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
2426         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
2427         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
2428         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
2429         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2430         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
2431         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
2432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2433
2434 2011-07-06  Adam Barth  <abarth@webkit.org>
2435
2436         Attempt to fix unittest on Leopard.  Let's enumerate the keys in sorted
2437         order so the test results are predictable.
2438
2439         * Scripts/webkitpy/tool/bot/irc_command.py:
2440         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2441
2442 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
2443
2444         Reviewed by Eric Siedel.
2445
2446         nrwt: make the code be consistent about using test names instead of filenames or paths
2447
2448         https://bugs.webkit.org/show_bug.cgi?id=63597
2449
2450         It can be hard to figure out where in the code we're assuming
2451         test names are listed as unix-style relative filenames and where
2452         they are either absolute paths or relative paths following the
2453         host filesystem convention.
2454
2455         This patch changes things so that everything outside of the
2456         Port object uses (and must assume) unix-style relative
2457         filenames (with one exception, which is specifying host-local
2458         filenames as a list of test arguments on the command line).
2459
2460         This should make things clearer and more consistent, and also
2461         removes a lot of path conversion calls.
2462
2463         The changes in this patch outside of port/base.py are largely
2464         cosmetic changes of "filename" to "test". We add a few routines
2465         to the base Port implementation to manipulate test names to
2466         split them, figure out if we're referring to a directory of
2467         tests, etc.
2468
2469         * Scripts/webkitpy/common/net/layouttestresults.py:
2470         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2471         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2472         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2473         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2474         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
2475         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2476         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2477         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2478         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2479         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2480         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2481         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2482         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2483         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2484         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2485         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2486         * Scripts/webkitpy/layout_tests/port/base.py:
2487         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2488         * Scripts/webkitpy/layout_tests/port/chromium.py:
2489         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2490         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2491         * Scripts/webkitpy/layout_tests/port/test.py:
2492         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2493         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2494         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2495         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2496         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2497         * Scripts/webkitpy/tool/commands/rebaseline.py:
2498         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2499
2500 2011-07-06  Chris Guillory  <ctguil@chromium.org>
2501
2502         No review necessary.
2503
2504         Adding myself to committers list in committers.py.
2505         https://bugs.webkit.org/show_bug.cgi?id=63478
2506
2507         * Scripts/webkitpy/common/config/committers.py:
2508
2509 2011-07-06  Johnny Ding  <jnd@chromium.org>
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=63857
2512         Implement createPopupMenu for Chromium DRT.
2513
2514         Reviewed by Tony Chang.
2515
2516         * DumpRenderTree/chromium/WebViewHost.cpp:
2517         (WebViewHost::createPopupMenu):
2518         (WebViewHost::~WebViewHost):
2519         * DumpRenderTree/chromium/WebViewHost.h:
2520
2521 2011-07-06  Mihai Parparita  <mihaip@chromium.org>
2522
2523         Unreviewed, rolling out r90503.
2524         http://trac.webkit.org/changeset/90503
2525         https://bugs.webkit.org/show_bug.cgi?id=63358
2526
2527         Makes Chromium Windows canary bots hang.
2528
2529         * Scripts/webkitpy/layout_tests/port/base.py:
2530         * Scripts/webkitpy/layout_tests/port/chromium.py:
2531         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2532         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2533         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2534         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2535         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2537
2538 2011-07-06  Adam Barth  <abarth@webkit.org>
2539
2540         Move buildbot URL in webkitpy to config.urls
2541         https://bugs.webkit.org/show_bug.cgi?id=64041
2542
2543         Reviewed by Eric Seidel.
2544
2545         This patch prepares for using the buildbot class to talk to the
2546         Chromium buildbots.
2547
2548         * Scripts/webkitpy/common/config/urls.py:
2549         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2550         * Scripts/webkitpy/tool/commands/download_unittest.py:
2551         * Scripts/webkitpy/tool/commands/queries.py:
2552         * Scripts/webkitpy/tool/mocktool.py:
2553         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2554
2555 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
2556
2557         [wx] Unreviewed build fix, add the correct path to the waf build settings.
2558         
2559         * wx/packaging/build-win-installer.py:
2560
2561 2011-07-06  Adam Barth  <abarth@webkit.org>
2562
2563         Add missing include.
2564
2565         * Scripts/webkitpy/tool/bot/irc_command.py:
2566
2567 2011-07-06  Adam Barth  <abarth@webkit.org>
2568
2569         Add roll-chromium-deps command to sheriff-bot
2570         https://bugs.webkit.org/show_bug.cgi?id=64037
2571
2572         Reviewed by Eric Seidel.
2573
2574         Lo, and the DEPS were rolled on command.
2575
2576         * Scripts/webkitpy/tool/bot/irc_command.py:
2577         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2578         * Scripts/webkitpy/tool/bot/sheriff.py:
2579         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2580         * Scripts/webkitpy/tool/commands/roll.py:
2581         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2582         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
2583
2584 2011-07-06  Eric Seidel  <eric@webkit.org>
2585
2586         Split Driver, DriverOutput and DriverInput out into a new driver.py file
2587         https://bugs.webkit.org/show_bug.cgi?id=64031
2588
2589         Reviewed by Adam Barth.
2590
2591         This ended up kinda large and I'm happy to break it up if desired.
2592
2593         As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
2594         out into its own driver.py file.
2595
2596         I also cleaned up how we import Port objects, by making port/__init__.py
2597         expose Port, Driver, DriverInput, and DriverOutput.  I removed exposure of
2598         some various test objects as they were causing circular dependencies.
2599         base.py is now an implementation detail of port.  No longer is "base" referenced
2600         anywhere in the code.
2601
2602         I also made Driver.__init__ non-virtual so that sub-classers could all share
2603         the data storage on Driver.  This more closely matches how other subclasses
2604         work throughout our python code.
2605
2606         Standard line-unwrapping and doc-string removal as I went through the code.
2607
2608         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2609         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2610         * Scripts/webkitpy/layout_tests/port/__init__.py:
2611         * Scripts/webkitpy/layout_tests/port/base.py:
2612         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2613         * Scripts/webkitpy/layout_tests/port/chromium.py:
2614         * Scripts/webkitpy/layout_tests/port/driver.py: Added.
2615         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2616         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2617         * Scripts/webkitpy/layout_tests/port/test.py:
2618         * Scripts/webkitpy/layout_tests/port/webkit.py:
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2620         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2621         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2622
2623 2011-07-06  Adam Roben  <aroben@apple.com>
2624
2625         Clear TestFailures's getNumberOfFailingTests cache
2626
2627         Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
2628         have been cached by old versions of TestFailures.
2629
2630         Fixes <http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
2631         used it recently
2632
2633         Reviewed by Adam Barth.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2636         (Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
2637         that must match the current version. Otherwise we'll ignore the cached data.
2638
2639 2011-06-24  Dirk Pranke  <dpranke@chromium.org>
2640
2641         Reviewed by Adam Barth.
2642
2643         nrwt: remove --use-apache from the command line
2644         https://bugs.webkit.org/show_bug.cgi?id=63358
2645
2646         This change removes the --use-apache command line argument. It
2647         was initially put in when we were trying to get the cygwin
2648         apache instance to work with Chromium win, but that code has
2649         bitrotted and doesn't work at all now.
2650
2651         Arguably we should remove all of the code to allow for a choice
2652         of web servers, but since we may still want to switch off of
2653         LigHTTPd at some point on Windows, I'll leave the rest in for
2654         now (or at least yank it in a different change.)
2655
2656         * Scripts/webkitpy/layout_tests/port/base.py:
2657         * Scripts/webkitpy/layout_tests/port/chromium.py:
2658         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2659         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2660         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2662
2663 2011-07-06  Dimitri Glazkov  <dglazkov@chromium.org>
2664
2665         garden-o-matic should use a favicon to indicate current state.
2666         https://bugs.webkit.org/show_bug.cgi?id=64027
2667
2668         Reviewed by Adam Barth.
2669
2670         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
2671         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
2672         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
2673         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
2674         * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
2675
2676 2011-07-06  Daniel Bates  <dbates@rim.com>
2677
2678         Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing
2679         parameter to _fetch_file_from_results lamdba function.
2680
2681         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2682
2683 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
2684
2685         [wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.
2686
2687         * wx/packaging/build-mac-installer.py:
2688
2689 2011-07-06  Xan Lopez  <xlopez@igalia.com>
2690
2691         [GTK] Only set env. variables in start when strictly needed
2692         https://bugs.webkit.org/show_bug.cgi?id=64026
2693
2694         Reviewed by Eric Seidel.
2695
2696         * Scripts/webkitpy/layout_tests/port/gtk.py: add a
2697         setup_environ_for_server method in GtkPort and set as many
2698         env. variables as possible there.
2699
2700 2011-07-06  Adam Roben  <aroben@apple.com>
2701
2702         Teach TestFailures how to load, parse, and interpret NRWT test results
2703
2704         Fixes <http://webkit.org/b/61877> TestFailures page doesn't show testers that use
2705         new-run-webkit-tests
2706
2707         Reviewed by Adam Barth.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2710         (Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
2711         type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
2712         pixel tests at all currently).
2713         (Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
2714         of failing tests from the buildbot output. Make sure not to count "new passes" (a new
2715         category introduced by NRWT) as failures.
2716
2717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2718         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
2719         _fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
2720         to loading ORWT results.
2721         (LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
2722         parse the full_results.json file for the given build.
2723         (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
2724         Fixed a bug along the way where we were sometimes calling the error callback instead of the
2725         success callback when all tests passed.
2726
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.
2728         (NRWTResultsParser): Do-nothing constructor.
2729         (NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
2730         JS string, then iterates over all the tests in the results data and builds up a data
2731         structure matching what ORWTResultsParser returns.
2732
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
2734         (Array.prototype.contains):
2735         (String.prototype.contains):
2736         Added these simple helper functions.
2737
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
2739         NRWTResultsParser.js.
2740
2741 2011-07-06  Adam Roben  <aroben@apple.com>
2742
2743         Extract code to parse ORWT's results.html file into its own class
2744
2745         Prep work for fixing <http://webkit.org/b/61877> TestFailures page doesn't show testers that
2746         use new-run-webkit-tests
2747
2748         Reviewed by Adam Barth.
2749
2750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2751         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...
2752
2753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.
2754         (ORWTResultsParser):
2755         (ORWTResultsParser.prototype.parse):
2756         ...to here.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
2759         ORWTResultsParser.js.
2760
2761 2011-07-06  Eric Seidel  <eric@webkit.org>
2762
2763         Unreviewed.  Fix a unittest from hitting the network. :)
2764
2765         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2766
2767 2011-07-06  Eric Seidel  <eric@webkit.org>
2768
2769         Unreviewed.  Fixing an exception in test-webkitpy, caused by bug 64006.
2770
2771         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2772
2773 2011-07-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2774
2775         Run an Xvfb instance to run the API tests on, like we do for the
2776         layout tests.
2777
2778         Reviewed by Xan Lopez.
2779
2780         * Scripts/run-gtk-tests:
2781
2782 2011-07-06  Daniel Bates  <dbates@webkit.org>
2783
2784         Make SCM unit tests faster
2785         https://bugs.webkit.org/show_bug.cgi?id=63883
2786
2787         Speeds up the SCM unit tests by a factor of 4. Currently, we create a
2788         mock SVN repo for each test_ method in SVNTest and GitTest and creating
2789         this repo is expensive.
2790
2791         Instead, it is significantly faster to create the mock SVN repo once
2792         and then perform a filesystem copy of it for each test_ method.
2793
2794         Note, Python 2.7's unittest module implements support for per class and
2795         per module setup and tear down methods which could be used to implement
2796         similar functionality. At the time of writing, test-webkitpy is designed
2797         to support Python 2.5. So, we can't take advantage of these Python 2.7
2798         features :(
2799
2800         Reviewed by Eric Seidel.
2801
2802         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2803
2804 2011-07-06  Adam Barth  <abarth@webkit.org>
2805
2806         Remove unused parameter from _add_test in test_expectations.py
2807         https://bugs.webkit.org/show_bug.cgi?id=64008
2808
2809         Reviewed by Eric Seidel.
2810
2811         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2812
2813 2011-07-06  Adam Barth  <abarth@webkit.org>
2814
2815         Use old-run-webkit-tests when --leaks is present
2816         https://bugs.webkit.org/show_bug.cgi?id=64012
2817
2818         Reviewed by Adam Roben.
2819
2820         We'll remove this branch once support of --leaks is added to
2821         new-run-webkit-tests.
2822
2823         * Scripts/run-webkit-tests:
2824
2825 2011-07-06  Benjamin Poulain  <benjamin@webkit.org>
2826
2827         [Qt] [WK2] Add touch mocking to Qt's MiniBrowser
2828         https://bugs.webkit.org/show_bug.cgi?id=63995
2829
2830         Reviewed by Andreas Kling.
2831
2832         The mouse events are intercepted through QCoreApplication::notify(),
2833         and fake touch events are generated for mouse events when necessary.
2834
2835         If touch events are received from the platform, we assume the current
2836         hardware has a touch screen and we stop generating fake events.
2837
2838         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2839         (isTouchEvent):
2840         (isMouseEvent):
2841         (MiniBrowserApplication::MiniBrowserApplication):
2842         (MiniBrowserApplication::notify):
2843         * MiniBrowser/qt/MiniBrowserApplication.h:
2844
2845 2011-07-06  Xan Lopez  <xlopez@igalia.com>
2846
2847         Reviewed by Gustavo Noronha.
2848
2849         * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
2850
2851 2011-07-06  Eric Seidel  <eric@webkit.org>
2852
2853         webkit-patch failure-reason does not understand NRWT results
2854         https://bugs.webkit.org/show_bug.cgi?id=64006
2855
2856         Reviewed by Adam Barth.
2857
2858         Adam Barth tells me failure-reason should be deleted soon,
2859         but aroben's fancy new TestFailures/ page doesn't work for
2860         NRWT yet, and I needed to know when
2861         third-party-cookie-relaxing started failing.
2862
2863         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2864         * Scripts/webkitpy/tool/commands/queries.py:
2865
2866 2011-07-06  Xan Lopez  <xlopez@igalia.com>
2867
2868         [GTK] Add missing environment variables in NWRT
2869         https://bugs.webkit.org/show_bug.cgi?id=64004
2870
2871         Reviewed by Gustavo Noronha Silva.
2872
2873         Add missing environment variables needed by the GTK+ port.
2874
2875         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
2876
2877 2011-07-06  Adam Roben  <aroben@apple.com>
2878
2879         Make run-api-tests output intelligible on the bots
2880
2881         run-api-tests's output on the bots was very hard to read for two reasons:
2882           1) It was mixing its own output with gtest's
2883           2) It was using ANSI escape sequences to print colored text, but the bots don't support
2884              that
2885
2886         Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
2887         output will not be obscured. We still print "Timeout" messages even in verbose mode, since
2888         gtest doesn't have any native support for timeouts. Also, when our output is being
2889         redirected to a file, we don't print ANSI escape sequences.
2890
2891         Fixes <http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots
2892
2893         Reviewed by Sam Weinig.
2894
2895         * Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to
2896         use the colored function instead.
2897         (runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
2898         context that they aren't needed.
2899         (runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
2900         that for us. Also, use the new possiblyColored function instead of always coloring output.
2901         (possiblyColored): Added. When printing to a tty, returns the string with the appropriate
2902         ANSI color escape sequences added. Otherwise just returns the string unmodified.
2903
2904 2011-07-06  Xan Lopez  <xlopez@igalia.com>
2905
2906         Reviewed by Gustavo Noronha.
2907
2908         Launch Xvfb (mostly) the same way we were launching it in the
2909         bots, for maximum compatibility.
2910
2911         * Scripts/webkitpy/layout_tests/port/gtk.py:
2912
2913 2011-07-06  Andreas Kling  <kling@webkit.org>
2914
2915         [Qt][WK2] Split Qt API into two different web views (touch and desktop)
2916         https://bugs.webkit.org/show_bug.cgi?id=63950
2917
2918         Co-authored with Benjamin Poulain <benjamin@webkit.org>.
2919
2920         Reviewed by Kenneth Rohde Christiansen.
2921
2922         Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.
2923
2924         The Qt MiniBrowser now defaults to QDesktopWebView but can be started
2925         in QTouchWebView mode by passing -touch on the command line.
2926
2927         A lot of functionality has been removed and/or disabled from
2928         MiniBrowser until we reintroduce the necessary API's.
2929
2930         * MiniBrowser/qt/BrowserView.cpp:
2931         (BrowserView::BrowserView):
2932         (BrowserView::~BrowserView):
2933         (BrowserView::load):
2934         (BrowserView::view):
2935         (BrowserView::touchWebView):
2936         (BrowserView::desktopWebView):
2937         * MiniBrowser/qt/BrowserView.h:
2938         * MiniBrowser/qt/BrowserWindow.cpp:
2939         (newPageFunction):
2940         (BrowserWindow::BrowserWindow):
2941         (BrowserWindow::webView):
2942         (BrowserWindow::newWindow):
2943         (BrowserWindow::showUserAgentDialog):
2944         (BrowserWindow::updateUserAgentList):
2945         * MiniBrowser/qt/BrowserWindow.h:
2946         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2947         (MiniBrowserApplication::handleUserOptions):
2948         * MiniBrowser/qt/MiniBrowserApplication.h:
2949         (WindowOptions::WindowOptions):
2950         * MiniBrowser/qt/UrlLoader.cpp:
2951         (UrlLoader::UrlLoader):
2952         * MiniBrowser/qt/main.cpp:
2953         (main):
2954         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2955         (WTR::WebView::wkView):
2956         (WTR::WebView::pageRef):
2957         (WTR::WebView::WebView):
2958         (WTR::PlatformWebView::page):
2959         (WTR::PlatformWebView::windowFrame):
2960         (WTR::PlatformWebView::setWindowFrame):
2961
2962 2011-07-06  Eric Seidel  <eric@webkit.org>
2963
2964         Unreviewed..
2965
2966         * Scripts/run-webkit-tests:
2967         (useNewRunWebKitTests):
2968          - Fix the pass-thru of --gtk and --qt for old-run-webkit-tests,
2969            it was previously broken by the existence of isGtk/isQt checks which
2970            removed the --gtk/--qt args from @ARGV.
2971
2972 2011-07-06  Eric Seidel  <eric@webkit.org>
2973
2974         new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
2975         https://bugs.webkit.org/show_bug.cgi?id=63983
2976
2977         Reviewed by Xan Lopez.
2978
2979         All WebKit ports want to use a 35s timeout.  Only chromium currently
2980         uses a 6s timeout.  Eventually we'll move all WebKit ports to 6s too
2981         to further speed up new-run-webkit-tests runs, but that's going to be a while.
2982
2983         * Scripts/webkitpy/layout_tests/port/mac.py:
2984         * Scripts/webkitpy/layout_tests/port/webkit.py:
2985         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2986
2987 2011-07-06  Xan Lopez  <xlopez@igalia.com>
2988
2989         Unreviewed.
2990
2991         NWRT actually seems to work locally, so it should work in the bots
2992         as long as we take care of the TIMEOUT issue (which is being fixed
2993         as I write this). Let's give this another shot and fix whatever
2994         breaks.
2995
2996         * Scripts/run-webkit-tests:
2997         (useNewRunWebKitTests):
2998
2999 2011-07-06  Xan Lopez  <xlopez@igalia.com>
3000
3001         Unreviewed.
3002
3003         Disable NWRT on GTK. At the very least it needs an updated exected
3004         results file since NWRT is more sensitive to timeouts, not sure
3005         what the exact problem is.
3006
3007         * Scripts/run-webkit-tests:
3008         (useNewRunWebKitTests):
3009
3010 2011-07-06  Adam Barth  <abarth@webkit.org>
3011
3012         Fix global variable leak detected by noglobals.
3013
3014         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3015
3016 2011-07-06  Adam Barth  <abarth@webkit.org>
3017
3018         garden-o-matic shouldn't show flaky tests by default
3019         https://bugs.webkit.org/show_bug.cgi?id=63979
3020
3021         Reviewed by Ojan Vafai.
3022
3023         If any of the actual test results are PASS, the test is flaky and we
3024         can ignore it (at least for now).  If we get awesome at dealing with
3025         failing tests, we might want to tackle flaky tests by refering the user
3026         to the flakiness dashboard, which is way more awesome at dealing with
3027         flaky tests that this tool ever will be.
3028
3029         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3030         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3031
3032 2011-07-05  Adam Barth  <abarth@webkit.org>
3033
3034         garden-o-matic should list the failing tests
3035         https://bugs.webkit.org/show_bug.cgi?id=63978
3036
3037         Reviewed by Eric Seidel.
3038
3039         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
3040         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3041         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3042         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3043         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3044         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
3045         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
3046         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
3047         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3048
3049
3050 2011-07-05  Eric Seidel  <eric@webkit.org>
3051
3052         Re-enable NRWT on Leopard now that bug 63973 is fixed.
3053
3054         Reviewed by Adam Barth.
3055
3056         I also made the should-enable expression a black-list instead
3057         of a white-list since every bot on build.webkit.org is
3058         now using NRWT except windows and WebKit2 bots.
3059
3060         * Scripts/run-webkit-tests:
3061         (useNewRunWebKitTests):
3062
3063 2011-07-05  Eric Seidel  <eric@webkit.org>
3064
3065         Perl string concat failure on Leopard (causes NRWT to fail)
3066         https://bugs.webkit.org/show_bug.cgi?id=63973
3067
3068         Reviewed by Daniel Bates.
3069
3070         Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
3071         thus the version parsing logic in webkitdirs.pm seems to fail.
3072
3073         Default to "3.0" instead of undef when we can't parse the version number.
3074         This should send us down the correct path for Leopard.
3075
3076         * Scripts/webkitdirs.pm:
3077         (determineBaseProductDir):
3078
3079 2011-07-05  Kevin Ollivier  <kevino@theolliviers.com>
3080
3081         [wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.
3082
3083         * waf/build/settings.py:
3084
3085 2011-07-05  Eric Seidel  <eric@webkit.org>
3086
3087         Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.
3088
3089         Reviewed by Adam Barth.
3090
3091         * Scripts/run-webkit-tests:
3092         (useNewRunWebKitTests):
3093
3094 2011-07-05  Eric Seidel  <eric@webkit.org>
3095
3096         Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.
3097
3098         Reviewed by Adam Barth.
3099
3100         * Scripts/run-webkit-tests:
3101         (runningOnBuildBot):
3102
3103 2011-07-05  Adam Barth  <abarth@webkit.org>
3104
3105         Add results_unittests.js to garden-o-matic
3106         https://bugs.webkit.org/show_bug.cgi?id=63971
3107
3108         Reviewed by Eric Seidel.
3109
3110         Adding these unit tests forced me to commit to an API for the results
3111         module.  I'm not sure if this is the API we'll end up with, but it's
3112         something not entirely unreasonable.
3113
3114         Also, I've changed results.js over to WebKit style, as discussed previously.
3115
3116         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3117         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3118         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
3119         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
3120
3121 2011-07-05  Eric Seidel  <eric@webkit.org>
3122
3123         Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
3124
3125         Reviewed by Adam Barth.
3126
3127         * Scripts/run-webkit-tests:
3128
3129 2011-07-05  Adam Barth  <abarth@webkit.org>
3130
3131         Add first unit tests for garden-o-matic
3132         https://bugs.webkit.org/show_bug.cgi?id=63969
3133
3134         Reviewed by Eric Seidel.
3135
3136         I've also reformated base.js to match WebKit style, as discussed in the
3137         previous bug.
3138
3139         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
3140         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
3141         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
3142
3143 2011-07-05  Eric Seidel  <eric@webkit.org>
3144
3145         Move Qt, Gtk and Leopard to NRWT.
3146
3147         We'll roll out any of these if we see problems.
3148
3149         Reviewed by Adam Barth.
3150
3151         * Scripts/run-webkit-tests:
3152         (useNewRunWebKitTests):
3153
3154 2011-07-05  Adam Barth  <abarth@webkit.org>
3155
3156         garden-o-matic should understand which tests have unexpected failures
3157         https://bugs.webkit.org/show_bug.cgi?id=63965
3158
3159         Reviewed by Eric Seidel.
3160
3161         Currently, this code just logs the list of unexpected failures to the
3162         console.  A future patch will do something useful with this
3163         information.  A testing harness will also come in the next patch.
3164
3165         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
3166         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3167         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3168         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3169
3170 2011-07-05  Adam Barth  <abarth@webkit.org>
3171
3172         garden-o-matic should know how to fetch test results from the (NRWT) bots
3173         https://bugs.webkit.org/show_bug.cgi?id=63959
3174
3175         Reviewed by Eric Seidel.
3176
3177         Currently, this code just fetches the results and expectations JSON
3178         blob for Linux from the server and logs it to the console.
3179
3180         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3181         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
3182         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3183
3184 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
3185
3186         Reviewed by Eric Seidel.
3187
3188         Python tests are failing on leopard
3189         https://bugs.webkit.org/show_bug.cgi?id=63842
3190
3191         Fix the missing flush() call that appears to be needed by the
3192         logging package in python 2.5. Also fix the regressions
3193         introduced in the run_webkit_test tests when we switched from
3194         thread to processes (since processes aren't available on 2.5).
3195
3196         Also fix a missing "from __future__ import with_statement' in
3197         testfilehandler (unreviewed).
3198
3199         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
3200         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3201         * TestResultServer/handlers/testfilehandler.py:
3202
3203 2011-07-05  Eric Seidel  <eric@webkit.org>
3204
3205         Reviewed by Adam Barth.
3206
3207         re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
3208         now that we believe the stray http-server issue to be solved.
3209
3210         * Scripts/run-webkit-tests:
3211         (useNewRunWebKitTests):
3212
3213 2011-07-05  Adam Barth  <abarth@webkit.org>
3214
3215         Turns out we need to support numerals too because that's what jQuery
3216         uses by default.
3217
3218         * TestResultServer/handlers/testfilehandler.py:
3219
3220 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
3221
3222         nrwt: allow for multiple http shards
3223         https://bugs.webkit.org/show_bug.cgi?id=63116
3224
3225         Reviewed by Tony Chang.
3226
3227         This modifies the sharding logic to support multiple http
3228         shards, but for now we clamp to one shard until we can test
3229         perf impact and flakiness impact.
3230
3231         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3232         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
3233
3234 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
3235
3236         Re-land nrwt: make sharding tests needing locks less hard-coded
3237         https://bugs.webkit.org/show_bug.cgi?id=63112
3238
3239         Reviewed by Ojan Vafai.
3240
3241         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3242         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
3243
3244 2011-07-05  Adam Barth  <abarth@webkit.org>
3245
3246         TestResultServer should support callback parameter for JSON
3247         https://bugs.webkit.org/show_bug.cgi?id=63961
3248
3249         Reviewed by Ojan Vafai.
3250
3251         This makes using jQuery.ajax so much more pleasant.
3252
3253         * TestResultServer/handlers/testfilehandler.py:
3254
3255 2011-07-05  Eric Seidel  <eric@webkit.org>
3256
3257         buildbot needs to understand whether NRWT exited early after having too many failures
3258         https://bugs.webkit.org/show_bug.cgi?id=63839
3259
3260         Reviewed by Adam Barth.
3261
3262         Fix-up the exited early messages printed by NRWT so that
3263         the buildbot can parse them as expected.
3264         It looks for lines using "if line.find('Exiting early') >= 0:"
3265
3266         I also plumbed the "early exit" status through to results.json
3267         in the form of an "interrupted" bool.  It was unclear to me
3268         if results.json already had enough information to compute this bool
3269         itself.  It's possible Ojan could come up with a better fix.
3270
3271         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3272         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
3273         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3274         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3275
3276 2011-07-05  Eric Seidel  <eric@webkit.org>
3277
3278         new-run-webkit-tests fails to start http server if one is already running
3279         https://bugs.webkit.org/show_bug.cgi?id=63956
3280
3281         Reviewed by Adam Barth.
3282
3283         * BuildSlaveSupport/kill-old-processes:
3284          - Removed ^M line endings and sorted the process names.
3285          - There are no functional changes to this file.
3286            (except that now that its using unix line endings it can be executed directly!)
3287         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3288          - Change the name to 'httpd' to match old-run-webkit-test paths.
3289
3290 2011-07-05  Adam Barth  <abarth@webkit.org>
3291
3292         Add basic ajax support to garden-o-matic
3293         https://bugs.webkit.org/show_bug.cgi?id=63874
3294
3295         Reviewed by Eric Seidel.
3296
3297         This patch adds some basic infrastructure to garden-o-matic.
3298         Currently, the infrastructure is just used to make the "quit" command
3299         use Ajax, but in the future, this infrastructure will be used to do
3300         more sophistocated remote proceedure calls.
3301
3302         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3303         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
3304         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3305         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3306
3307 2011-07-05  Adam Barth  <abarth@webkit.org>
3308
3309         Add trivial garden-o-matic command (with server)
3310         https://bugs.webkit.org/show_bug.cgi?id=63872
3311
3312         Reviewed by Eric Seidel.
3313
3314         This patch adds a trivial "Hello, world" garden-o-matic command,
3315         complete with an HTTP server.  This command re-uses a bunch of code
3316         from the existing rebaseline-server command.  Over time, this command
3317         will grow to be a tool useful for gardening the WebKit tree.
3318
3319         * Scripts/webkitpy/tool/commands/__init__.py:
3320         * Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
3321         * Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
3322         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3323         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
3324         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
3325         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3326
3327 2011-07-05  Adam Roben  <aroben@apple.com>
3328
3329         Make prepare-ChangeLog include modified Perl functions in its ChangeLog template
3330
3331         This is a very simple first cut. Functions must start with a line that starts with "sub "
3332         and end with a line that starts with a closing brace. No leading whitespace is allowed.
3333         Package names aren't parsed at all.
3334
3335         Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
3336         Perl files
3337
3338         Reviewed by David Kilzer.
3339
3340         * Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when
3341         searching for function line ranges. This is already done inside the get_function_line_ranges
3342         function.
3343         (get_function_line_ranges): Cleaned up coding style a little bit. Call
3344         get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
3345         unknown extension or no extension, read the shebang line to try to determine the script
3346         interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
3347         (get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
3348         lines starting with "sub " or "}".
3349
3350 2011-07-05  Adam Roben  <aroben@apple.com>
3351
3352         Clean up run-api-tests output on Windows
3353
3354         We were mixing run-api-tests output with gtest output, and the result was a mess.
3355
3356         Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows
3357
3358         Reviewed by Dan Bates.
3359
3360         * Scripts/run-api-tests:
3361         (runTest):
3362         (populateTests):
3363         Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
3364         except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
3365         the only Mac-specific thing in these functions. Some other platform-specific code was moved
3366         from here...
3367
3368         (prepareEnvironmentForRunningTestTool):
3369         (testToolPath):
3370         ...to here.
3371
3372 2011-07-04  Gavin Barraclough  <barraclough@apple.com>
3373
3374         Reviewed by Sam Weinig.
3375
3376         https://bugs.webkit.org/show_bug.cgi?id=16652
3377         Firefox and JavaScriptCore differ in Number.toString(integer)
3378
3379         Added forwarding header.
3380
3381         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
3382
3383 2011-07-04  Anders Carlsson  <andersca@apple.com>
3384
3385         Try to fix Qt build.
3386
3387         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
3388
3389 2011-07-04  Anders Carlsson  <andersca@apple.com>
3390
3391         NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
3392         https://bugs.webkit.org/show_bug.cgi?id=63915
3393         <rdar://problem/7124300>
3394
3395         Reviewed by Sam Weinig.
3396
3397         Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.
3398
3399         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3400         (PluginTest::NPN_IdentifierIsString):
3401         (PluginTest::NPN_UTF8FromIdentifier):
3402         (PluginTest::NPN_IntFromIdentifier):
3403         (PluginTest::NPN_RetainObject):
3404         (PluginTest::NPN_ReleaseObject):
3405         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3406         (PluginTest::Object::removeProperty):
3407         (PluginTest::Object::identifierIs):
3408         (PluginTest::Object::NP_RemoveProperty):
3409         (PluginTest::Object::npClass):
3410         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
3411         (NPRuntimeRemoveProperty::TestObject::TestObject):
3412         (NPRuntimeRemoveProperty::TestObject::hasProperty):
3413         (NPRuntimeRemoveProperty::TestObject::getProperty):
3414         (NPRuntimeRemoveProperty::TestObject::removeProperty):
3415         (NPRuntimeRemoveProperty::PluginObject::PluginObject):
3416         (NPRuntimeRemoveProperty::PluginObject::~PluginObject):
3417         (NPRuntimeRemoveProperty::PluginObject::hasMethod):
3418         (NPRuntimeRemoveProperty::PluginObject::invoke):
3419         (NPRuntimeRemoveProperty::PluginObject::hasProperty):
3420         (NPRuntimeRemoveProperty::PluginObject::getProperty):
3421         (NPRuntimeRemoveProperty::NPP_GetValue):
3422
3423 2011-07-04  Leandro Pereira  <leandro@profusion.mobi>
3424
3425         Reviewed by Kent Tamura.
3426
3427         [EFL] Add LayoutTestControllerEfl.
3428         https://bugs.webkit.org/show_bug.cgi?id=61974
3429
3430         Only the core features are implemented. Most functions are actually
3431         stubs and will be implemented as soon as its features are needed.
3432         Build system changes will be made as soon as DRT is completely
3433         upstreamed.
3434
3435         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added.
3436         (LayoutTestController::~LayoutTestController):
3437         (LayoutTestController::addDisallowedURL):
3438         (LayoutTestController::clearBackForwardList):
3439         (LayoutTestController::copyDecodedHostName):
3440         (LayoutTestController::copyEncodedHostName):
3441         (LayoutTestController::dispatchPendingLoadRequests):
3442         (LayoutTestController::display):
3443         (LayoutTestController::counterValueForElementById):
3444         (LayoutTestController::keepWebHistory):
3445         (LayoutTestController::computedStyleIncludingVisitedInfo):
3446         (LayoutTestController::nodesFromRect):
3447         (LayoutTestController::layerTreeAsText):
3448         (LayoutTestController::pageNumberForElementById):
3449         (LayoutTestController::numberOfPages):
3450         (LayoutTestController::pageProperty):
3451         (LayoutTestController::isPageBoxVisible):
3452         (LayoutTestController::pageSizeAndMarginsInPixels):
3453         (LayoutTestController::webHistoryItemCount):
3454         (LayoutTestController::workerThreadCount):
3455         (LayoutTestController::notifyDone):
3456         (LayoutTestController::pathToLocalResource):
3457         (LayoutTestController::queueLoad):
3458         (LayoutTestController::setAcceptsEditing):
3459         (LayoutTestController::setAlwaysAcceptCookies):
3460         (LayoutTestController::setCustomPolicyDelegate):
3461         (LayoutTestController::waitForPolicyDelegate):
3462         (LayoutTestController::setScrollbarPolicy):
3463         (LayoutTestController::addOriginAccessWhitelistEntry):
3464         (LayoutTestController::removeOriginAccessWhitelistEntry):
3465         (LayoutTestController::setMainFrameIsFirstResponder):
3466         (LayoutTestController::setTabKeyCyclesThroughElements):
3467         (LayoutTestController::setUseDashboardCompatibilityMode):
3468         (LayoutTestController::setUserStyleSheetEnabled):
3469         (LayoutTestController::setUserStyleSheetLocation):
3470         (LayoutTestController::setValueForUser):
3471         (LayoutTestController::setViewModeMediaFeature):
3472         (LayoutTestController::setWindowIsKey):
3473         (LayoutTestController::setSmartInsertDeleteEnabled):
3474         (waitToDumpWatchdogFired):
3475         (LayoutTestController::setWaitToDump):
3476         (LayoutTestController::windowCount):
3477         (LayoutTestController::setPrivateBrowsingEnabled):
3478         (LayoutTestController::setJavaScriptCanAccessClipboard):
3479         (LayoutTestController::setXSSAuditorEnabled):
3480         (LayoutTestController::setFrameFlatteningEnabled):
3481         (LayoutTestController::setSpatialNavigationEnabled):
3482         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3483         (LayoutTestController::setAllowFileAccessFromFileURLs):
3484         (LayoutTestController::setAuthorAndUserStylesEnabled):
3485         (LayoutTestController::setAutofilled):
3486         (LayoutTestController::disableImageLoading):
3487         (LayoutTestController::setMockDeviceOrientation):
3488         (LayoutTestController::setMockGeolocationPosition):
3489         (LayoutTestController::setMockGeolocationError):
3490         (LayoutTestController::setGeolocationPermission):
3491         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3492         (LayoutTestController::addMockSpeechInputResult):
3493         (LayoutTestController::setIconDatabaseEnabled):
3494         (LayoutTestController::setJavaScriptProfilingEnabled):
3495         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
3496         (LayoutTestController::setPopupBlockingEnabled):
3497         (LayoutTestController::setPluginsEnabled):
3498         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3499         (LayoutTestController::execCommand):
3500         (LayoutTestController::findString):
3501         (LayoutTestController::isCommandEnabled):
3502         (LayoutTestController::setCacheModel):
3503         (LayoutTestController::setPersistentUserStyleSheetLocation):
3504         (LayoutTestController::clearPersistentUserStyleSheet):
3505         (LayoutTestController::clearAllApplicationCaches):
3506         (LayoutTestController::setApplicationCacheOriginQuota):
3507         (LayoutTestController::clearApplicationCacheForOrigin):
3508         (LayoutTestController::localStorageDiskUsageForOrigin):
3509         (LayoutTestController::originsWithApplicationCache):
3510         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3511         (LayoutTestController::clearAllDatabases):
3512         (LayoutTestController::setDatabaseQuota):
3513         (LayoutTestController::originsWithLocalStorage):
3514         (LayoutTestController::deleteAllLocalStorage):
3515         (LayoutTestController::deleteLocalStorageForOrigin):
3516         (LayoutTestController::observeStorageTrackerNotifications):
3517         (LayoutTestController::syncLocalStorage):
3518         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3519         (LayoutTestController::goBack):
3520         (LayoutTestController::setDefersLoading):
3521         (LayoutTestController::setAppCacheMaximumSize):
3522         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3523         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3524         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3525         (LayoutTestController::numberOfActiveAnimations):
3526         (LayoutTestController::suspendAnimations):
3527         (LayoutTestController::resumeAnimations):
3528         (LayoutTestController::overridePreference):
3529         (LayoutTestController::addUserScript):
3530         (LayoutTestController::addUserStyleSheet):
3531         (LayoutTestController::setDeveloperExtrasEnabled):
3532         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3533         (LayoutTestController::showWebInspector):
3534         (LayoutTestController::closeWebInspector):
3535         (LayoutTestController::evaluateInWebInspector):
3536         (LayoutTestController::evaluateScriptInIsolatedWorld):
3537         (LayoutTestController::removeAllVisitedLinks):
3538         (LayoutTestController::callShouldCloseOnWebView):
3539         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
3540         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
3541         (LayoutTestController::setWebViewEditable):
3542         (LayoutTestController::markerTextForListItem):
3543         (LayoutTestController::authenticateSession):
3544         (LayoutTestController::setEditingBehavior):
3545         (LayoutTestController::abortModal):
3546         (LayoutTestController::hasSpellingMarker):
3547         (LayoutTestController::hasGrammarMarker):
3548         (LayoutTestController::dumpConfigurationForViewport):
3549         (LayoutTestController::setSerializeHTTPLoads):
3550         (LayoutTestController::setMinimumTimerInterval):
3551         (LayoutTestController::setTextDirection):
3552         (LayoutTestController::allowRoundingHacks):
3553
3554 2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>
3555
3556         Unreviewed, add myself as committer.
3557
3558         * Scripts/webkitpy/common/config/committers.py:
3559
3560 2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3561
3562         Unreviewed, rolling out r90347.
3563         http://trac.webkit.org/changeset/90347
3564         https://bugs.webkit.org/show_bug.cgi?id=63886
3565
3566         Build breaks on Leopard, Chro