Fix the MiniBrowser build with newer clang
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2
3         Fix the MiniBrowser build with newer clang
4
5         * MiniBrowser/mac/SettingsController.m:
6         (-[SettingsController _toggleBooleanDefault:]):
7         * MiniBrowser/mac/WK1BrowserWindowController.m:
8         (-[WK1BrowserWindowController windowWillClose:]):
9         * MiniBrowser/mac/WK2BrowserWindowController.m:
10         (-[WK2BrowserWindowController windowWillClose:]):
11         NSApp is id and clang gets confused about which -delegate we're talking about.
12
13 2015-02-16  Antti Koivisto  <antti@apple.com>
14
15         Develop/Disable Caches does not properly disable disk cache
16         https://bugs.webkit.org/show_bug.cgi?id=141636
17
18         Reviewed by Anders Carlsson.
19
20         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
21         the network process too.
22
23         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
24
25         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
26         (WTR::InjectedBundle::beginTesting):
27         (WTR::InjectedBundle::setCacheModel):
28         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
29         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
30
31             Forward to TestController.
32
33         (WTR::TestRunner::setCacheModel):
34         * WebKitTestRunner/TestInvocation.cpp:
35         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
36
37 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
38
39         Unreviewed. Add myself as a committer.
40
41         * Scripts/webkitpy/common/config/contributors.json:
42
43 2015-02-15  David Kilzer  <ddkilzer@apple.com>
44
45         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
46         <http://webkit.org/b/141607>
47
48         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
49         externals in Source/WebCore/Configurations/WebCore.unexp when
50         building with Xcode 5.x.
51         (readXcode5SymbolsToIgnore): Add.
52
53 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
54
55         [EFL] fix Evas GL engine error.
56         https://bugs.webkit.org/show_bug.cgi?id=141621
57
58         Reviewed by Gyuyoung Kim.
59
60         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
61
62         * MiniBrowser/efl/main.c:
63         (elm_main):
64
65 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
66
67         [buildbot] Enable run-api-tests on release Mac bots
68         https://bugs.webkit.org/show_bug.cgi?id=141518
69
70         Reviewed by Darin Adler.
71
72         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
73         (RunUnitTests):
74         (BuildFactory.__init__):
75         (TestFactory.__init__):
76         (BuildAndTestFactory.__init__):
77         (RunUnitTests.start): Deleted.
78         (unitTestsSupported): Deleted.
79
80 2015-02-13  Anders Carlsson  <andersca@apple.com>
81
82         Add a move constructor and move assignment operator to Deque
83         https://bugs.webkit.org/show_bug.cgi?id=141571
84
85         Reviewed by Andreas Kling.
86
87         * TestWebKitAPI/Tests/WTF/Deque.cpp:
88         (TestWebKitAPI::TEST):
89
90 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
91
92         run-jsc-stress-tests --remote should skip profiler tests
93         https://bugs.webkit.org/show_bug.cgi?id=141470
94
95         Reviewed by Filip Pizlo.
96
97         * Scripts/run-jsc-stress-tests:
98
99 2015-02-13  Anders Carlsson  <andersca@apple.com>
100
101         Add an initializer list constructor to Deque
102         https://bugs.webkit.org/show_bug.cgi?id=141565
103
104         Reviewed by Andreas Kling.
105
106         * TestWebKitAPI/Tests/WTF/Deque.cpp:
107         (TestWebKitAPI::TEST):
108
109 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
110
111         [buildbot] Remove buildJSCTool cruft from master.cfg
112         https://bugs.webkit.org/show_bug.cgi?id=141513
113
114         Reviewed by Alexey Proskuryakov.
115
116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
117         (RunJavaScriptCoreTests):
118         (RunJavaScriptCoreTests.start):
119         (RunWebKitTests):
120         (RunWebKitTests.start):
121         (TestFactory.__init__):
122         (TestLeaksFactory.__init__):
123         (RunJavaScriptCoreTests.__init__): Deleted.
124         (RunWebKitTests.__init__): Deleted.
125
126 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
127
128         Unreviewed, remove empty directories.
129
130         * DumpRenderTree/gtk: Removed.
131         * DumpRenderTree/gtk/fonts: Removed.
132         * DumpRenderTree/unix: Removed.
133         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
134         * GtkLauncher: Removed.
135         * TestWebKitAPI/Tests/WebKitGtk: Removed.
136         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
137         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
138         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
139
140 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
141
142         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
143         https://bugs.webkit.org/show_bug.cgi?id=141519
144
145         Reviewed by Alexey Proskuryakov.
146
147         * Scripts/build-webkittestrunner:
148
149 2015-02-12  Alex Christensen  <achristensen@webkit.org>
150
151         Removed empty directory.
152
153         * WinCELauncher: Removed.
154
155 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
156
157         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
158         https://bugs.webkit.org/show_bug.cgi?id=141202
159
160         Reviewed by Darin Adler.
161
162         * Scripts/run-jsc-stress-tests:
163
164 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
165
166         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
167         https://bugs.webkit.org/show_bug.cgi?id=141517
168
169         Reviewed by Anders Carlsson.
170
171         We do not need to locate or use the DLL's that came with Safari, so stop
172         failing when we cannot find them. Also remove some old Qt cruft from this
173         script.
174
175         * BuildSlaveSupport/built-product-archive:
176         (archiveBuiltProduct): 
177         (extractBuiltProduct):
178
179 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
180
181         [Win] [64-bit] Work around MSVC2013 Runtime Bug
182         https://bugs.webkit.org/show_bug.cgi?id=141498
183         <rdar://problem/19803642>
184
185         Reviewed by Anders Carlsson.
186
187         Disable FMA3 instruction use in the MSVC math library to
188         work around a VS2013 runtime crash. We can remove this
189         workaround when we switch to VS2015.
190
191         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
192         disable FMA3 support.
193         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
194         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
195         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
196         * Scripts/webkitperl/httpd.pm: Ditto.
197         * TestWebKitAPI/win/main.cpp: Ditto.
198         * WinLauncher/Common.cpp: Ditto.
199         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
200
201 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
202
203         run-jsc-stress-tests should accept remote host config from JSON file
204         https://bugs.webkit.org/show_bug.cgi?id=141509
205
206         Reviewed by Michael Saboff.
207
208         * Scripts/run-javascriptcore-tests:
209         (runJSCStressTests):
210         * Scripts/run-jsc-stress-tests:
211
212 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
213
214         [GTK] Add API to allow overriding the default color chooser implementation
215         https://bugs.webkit.org/show_bug.cgi?id=98935
216
217         Reviewed by Gustavo Noronha Silva.
218
219         Add a color chooser implementation for MiniBrowser using
220         GtkPopover when the GTK+ version is recent enough.
221         And a test case to check the new color chooser API.
222
223         * MiniBrowser/gtk/BrowserWindow.c:
224         (colorChooserRGBAChanged):
225         (popoverColorClosed):
226         (colorChooserRequestFinished):
227         (runColorChooserCallback):
228         (browserWindowConstructed):
229         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
230         (testWebViewColorChooserRequest):
231         (beforeAll):
232
233 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
234
235         Make run-jsc-stress-tests --remote work with make-based runner
236         https://bugs.webkit.org/show_bug.cgi?id=141079
237
238         Reviewed by Darin Adler.
239
240         * Scripts/run-javascriptcore-tests:
241         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
242         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
243         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
244         to avoid code duplication.
245
246 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
247
248         run-jsc-stress tests should detect the number of processors on the remote machine too
249         https://bugs.webkit.org/show_bug.cgi?id=141196
250
251         Reviewed by Darin Adler.
252
253         * Scripts/run-javascriptcore-tests:
254         (runJSCStressTests): Pass through the --child-processes argument.
255         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
256         to detect the number of local and remote processors with the same algorithm.
257         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
258         same as $numProcessors.
259
260 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
261
262         run-jsc-stress-tests should pass JSC_timeout to remote hosts
263         https://bugs.webkit.org/show_bug.cgi?id=141164
264
265         Reviewed by Darin Adler.
266
267         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
268
269         * Scripts/run-jsc-stress-tests:
270
271 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
272
273         [GTK] Add default color chooser implementation using GtkColorChooserDialog
274         https://bugs.webkit.org/show_bug.cgi?id=141392
275
276         Reviewed by Gustavo Noronha Silva.
277
278         Enable INPUT_TYPE_COLOR by default for GTK+ port.
279
280         * Scripts/webkitperl/FeatureList.pm:
281
282 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
283
284         run-jsc-stress-tests shell test runner should run tests in fixed order
285         https://bugs.webkit.org/show_bug.cgi?id=141383
286
287         Reviewed by Darin Adler.
288
289         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
290
291 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
292
293         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
294         https://bugs.webkit.org/show_bug.cgi?id=140485
295
296         Reviewed by Anders Carlsson.
297
298         Implement takeFocus() as a way to set focus through accessibility wrappers.
299
300         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
301         (AccessibilityUIElement::takeFocus):
302         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
303         (WTR::AccessibilityUIElement::takeFocus):
304
305 2015-02-08  Darin Adler  <darin@apple.com>
306
307         Remove the SVG instance tree
308         https://bugs.webkit.org/show_bug.cgi?id=140602
309
310         Reviewed by Dean Jackson.
311
312         * Scripts/check-for-global-initializers: Removed special case for
313         SVGElementInstance.o.
314
315 2015-02-07  David Kilzer  <ddkilzer@apple.com>
316
317         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
318         <http://webkit.org/b/141365>
319
320         Reviewed by Daniel Bates.
321
322         * Scripts/webkitpy/xcode/simulator.py:
323         (Simulator): Add unavailable_version_re precompiled regex.
324         (Simulator._parse_devices): Check for unavailable versions and
325         ignore them if found when parsing the output of
326         `xcrun simctl list`.
327         * Scripts/webkitpy/xcode/simulator_unittest.py:
328         (test_unavailable_devices): Add test with output from
329         `xcrun simctl list` with unavailable runtimes that fails before
330         the fix.
331
332 2015-02-07  Chris Dumez  <cdumez@apple.com>
333
334         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
335         https://bugs.webkit.org/show_bug.cgi?id=141321
336
337         Reviewed by Darin Adler.
338
339         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
340
341 2015-02-07  David Kilzer  <ddkilzer@apple.com>
342
343         [iOS] Make Simulator class testable
344         <http://webkit.org/b/141358>
345
346         Rubber-stamped by Darin Adler.
347
348         * Scripts/webkitpy/common/system/platforminfo.py:
349         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
350         command to here from Simulator.refresh() in xcode/simulator.py
351         so that the output of the command can be mocked.
352
353         * Scripts/webkitpy/common/system/platforminfo_mock.py:
354         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
355         to None.
356         (MockPlatformInfo.xcode_simctl_list): Add method that returns
357         self.expected_xcode_simctl_list expectation.
358
359         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
360         and license header.
361         (Simulator.__init__): Add optional 'host' parameter to make it
362         possible to pass in a mock object for testing.  Set self._host
363         to 'host' parameter or create Host() object.
364         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
365         method.
366
367         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
368         for current code.
369         (SimulatorTest):
370         (SimulatorTest.setUp):
371         (SimulatorTest._set_expected_xcrun_simctl_list):
372         (SimulatorTest.test_simulator_device_types):
373         (test_invalid_device_types_header):
374         (test_invalid_runtimes_header):
375         (test_invalid_devices_header):
376
377 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
378
379         run-jsc-stress-tests --remote should use the default ssh port
380         https://bugs.webkit.org/show_bug.cgi?id=141287
381
382         Reviewed by Darin Adler.
383
384         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
385
386 2015-02-06  Dana Burkart  <dburkart@apple.com>
387
388         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
389         https://bugs.webkit.org/show_bug.cgi?id=141349
390
391         Reviewed by Alexey Proskuryakov.
392
393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
394         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
395         (BuildbotTesterQueueView.prototype.update):
396
397 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
398
399         Report network process crashes during layout tests
400         https://bugs.webkit.org/show_bug.cgi?id=139646
401
402         Reviewed by Anders Carlsson.
403
404         * WebKitTestRunner/TestController.cpp:
405         (WTR::TestController::initialize):
406         (WTR::TestController::networkProcessName):
407         (WTR::TestController::networkProcessDidCrash):
408         * WebKitTestRunner/TestController.h:
409
410 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
411
412         run-jsc-stress-tests --remote should create remote directory before copying the bundle
413         https://bugs.webkit.org/show_bug.cgi?id=141329
414
415         Reviewed by Michael Saboff.
416
417         * Scripts/run-jsc-stress-tests:
418
419 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
420
421         [GTK] Remove WebKitWebView::close-notification signal
422         https://bugs.webkit.org/show_bug.cgi?id=141330
423
424         Reviewed by Gustavo Noronha Silva.
425
426         Update notifications unit tests according to the API changes, and
427         add a test case to check that onclose event is fired when a
428         notification is closed by the user.
429
430         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
431         (testWebViewNotification):
432
433 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
434
435         Dashboard doesn't consider building ASan a productive step
436         https://bugs.webkit.org/show_bug.cgi?id=141312
437
438         Reviewed by Simon Fraser.
439
440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
441
442 2015-02-05  Daniel Bates  <dabates@apple.com>
443
444         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
445         https://bugs.webkit.org/show_bug.cgi?id=141306
446
447         Reviewed by Alexey Proskuryakov.
448
449         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
450         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
451         existent runtime.
452
453         * Scripts/webkitpy/xcode/simulator.py:
454         (Runtime.from_identifier):
455
456 2015-02-05  Daniel Bates  <dabates@apple.com>
457
458         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
459         https://bugs.webkit.org/show_bug.cgi?id=139746
460         <rdar://problem/19283658>
461
462         Reviewed by Alexey Proskuryakov.
463
464         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
465         if the simulator device is not in state Booted.
466
467         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
468         launching/relaunching the iOS Simulator app and a simulator app can only be installed
469         on a device that is in the Booted state. LayoutTestRelay may run before the
470         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
471         We should defer executing LayoutTestRelay until the simulator device booted by
472         iOS Simulator is in the Booted state.
473
474         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
475         Simulator methods with the module name, simulator.
476         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
477         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
478         before launching iOS Simulator to boot it.
479         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
480         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
481         * Scripts/webkitpy/xcode/simulator.py:
482         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
483         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
484         interested in the state of the device are more likely interested in the current state of the device as
485         opposed to the state of the device when the Device object was created.
486         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
487         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
488         from both this function and Simulator.device_state().
489         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
490         (Simulator.DeviceState): Added; class of constants.
491         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
492         device is in the specified state.
493         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
494         (Simulator.device_directory): Added.
495         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
496
497 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
498
499         Disable retries on Mac debug testers
500         https://bugs.webkit.org/show_bug.cgi?id=141296
501
502         Reviewed by Simon Fraser.
503
504         * BuildSlaveSupport/build.webkit.org-config/config.json:
505
506 2015-02-05  Dan Bernstein  <mitz@apple.com>
507
508         Need a way to force $xcodeSDK in webkitdirs.pm
509         https://bugs.webkit.org/show_bug.cgi?id=141291
510
511         Reviewed by Anders Carlsson.
512
513         * Scripts/webkitdirs.pm:
514         (setXcodeSDK): Added.
515
516 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
517
518         [Streams API] Implement a barebone ReadableStream interface
519         https://bugs.webkit.org/show_bug.cgi?id=141045
520
521         Reviewed by Benjamin Poulain.
522
523         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
524
525 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
526
527         filter-build-webkit: reduce more unfiltered output
528         https://bugs.webkit.org/show_bug.cgi?id=141282
529
530         Reviewed by Daniel Bates.
531
532         * Scripts/filter-build-webkit:
533         Report CompileDTraceScript and Preprocess lines as successful.
534
535 2015-02-04  Dana Burkart  <dburkart@apple.com>
536
537         Botwatcher's Dashboard is cramped
538         https://bugs.webkit.org/show_bug.cgi?id=140273
539
540         Reviewed by Alexey Proskuryakov.
541
542         Add a heading key which will allow for arbitrary headings in builder queues.
543
544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
545         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
546         (BuildbotBuilderQueueView.prototype.update):
547         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
549         (BuildbotIteration.prototype._parseData):
550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
551         (BuildbotLeaksQueueView.prototype.update):
552         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
554         (BuildbotPerformanceQueueView.prototype.update):
555         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
556         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
557         (BuildbotQueue):
558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
559         (BuildbotQueueView.prototype._unauthorizedAccess):
560         (BuildbotQueueView.prototype._appendBuild):
561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
562         (BuildbotTestResults):
563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
564         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
565         (BuildbotTesterQueueView.prototype.update):
566         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
567
568 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
569
570         WKTR should not use -mainScreen to pick a color profile
571         https://bugs.webkit.org/show_bug.cgi?id=141265
572
573         Reviewed by Tim Horton.
574         
575         -[NSScreen mainScreen] depends on the active window, so use the first screen
576         (which is the one we put the window on anyway).
577         
578         Do some cleanup in DRT that makes the code look similar.
579
580         * DumpRenderTree/mac/DumpRenderTree.mm:
581         (createWebViewAndOffscreenWindow):
582         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
583         (WTR::PlatformWebView::PlatformWebView):
584
585 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
586
587         LayoutTestHelper should set the color profile of all displays
588         https://bugs.webkit.org/show_bug.cgi?id=141260
589
590         Reviewed by Tim Horton.
591         
592         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
593         which is the screen with the active window. Make things more robust by changing
594         the colorspace of all displays, not just the main screen, when running layout tests.
595
596         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
597         * DumpRenderTree/mac/LayoutTestHelper.m: 
598         (originalColorProfileURLs):
599         (colorProfileURLForDisplay):
600         (displayUUIDStrings):
601         (saveDisplayColorProfiles):
602         (setDisplayColorProfile):
603         (restoreDisplayColorProfiles):
604         (installLayoutTestColorProfile):
605         (restoreUserColorProfile):
606         (main):        
607         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
608         toll-free bridged, sadly). Use the map to restore all profiles on exit.
609         Convert to use more Obj-C types.
610
611 2015-02-04  Daniel Bates  <dabates@apple.com>
612
613         test-webkitpy fails on Mac without iphoneos SDK
614         https://bugs.webkit.org/show_bug.cgi?id=141255
615         <rdar://problem/19619691>
616
617         I inadvertently committed the wrong exception message. Fix up the exception message
618         to instruct a person to install the iOS SDK when it cannot be found.
619
620         * Scripts/webkitpy/port/ios.py:
621         (IOSPort.determine_full_port_name):
622
623 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
624
625         W3C test importer should sort the list of files when generating the w3c-import.log
626         https://bugs.webkit.org/show_bug.cgi?id=141156
627
628         Reviewed by Bem Jones-Bey.
629
630         Sort explicitly the list of imported files written in the w3c-import.log.
631         Removed logging of the import date.
632
633         * Scripts/webkitpy/w3c/test_importer.py:
634         (TestImporter.write_import_log):
635
636 2015-02-04  Daniel Bates  <dabates@apple.com>
637
638         test-webkitpy fails on Mac without iphoneos SDK
639         https://bugs.webkit.org/show_bug.cgi?id=141255
640         <rdar://problem/19619691>
641
642         Reviewed by David Kilzer and Alexey Proskuryakov.
643
644         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
645         should not require the iphoneos SDK to be installed to run the webkitpy tests.
646
647         * Scripts/webkitpy/common/system/platforminfo.py:
648         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
649         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
650         to standard output if the SDK is installed to return the empty string if the SDK is
651         not installed.
652         * Scripts/webkitpy/common/system/platforminfo_mock.py:
653         (MockPlatformInfo.xcode_sdk_version): Added.
654         * Scripts/webkitpy/port/ios.py:
655         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
656         to get the version of the iphoneos SDK, if installed.
657
658 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
659
660         run-webkit-tests doesn't always capture ASan violation reports
661         https://bugs.webkit.org/show_bug.cgi?id=141231
662
663         Reviewed by Darin Adler.
664
665         * Scripts/webkitpy/port/driver.py:
666         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
667         by the driver already (as is the case with ASan violations, which are printed to
668         stderr).
669         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
670         report.
671         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
672         a separate variable for reporting.
673
674 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
675
676         [webkitpy] Add platform specific Skipped file mechanism for performance tests
677         https://bugs.webkit.org/show_bug.cgi?id=141152
678
679         Reviewed by Csaba Osztrogonác.
680
681         Support a test-expectation-like syntax in performance tests' skipped files.
682         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
683
684         * Scripts/webkitpy/port/base.py:
685         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
686
687         * Scripts/webkitpy/port/base_unittest.py:
688         (PortTest.test_skipped_perf_tests): Test the new syntax.
689
690 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
691
692         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
693         https://bugs.webkit.org/show_bug.cgi?id=141236
694
695         Reviewed by Sam Weinig.
696
697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
698         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
699
700 2015-02-04  Chris Dumez  <cdumez@apple.com>
701
702         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
703         https://bugs.webkit.org/show_bug.cgi?id=141192
704
705         Reviewed by Benjamin Poulain.
706
707         Add API tests for Vector::removeFirst(value) and
708         Vector::removeAll(value).
709
710         * TestWebKitAPI/Tests/WTF/Vector.cpp:
711         (TestWebKitAPI::TEST):
712
713 2015-02-03  Tim Horton  <timothy_horton@apple.com>
714
715         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
716         https://bugs.webkit.org/show_bug.cgi?id=141217
717
718         Reviewed by Sam Weinig.
719
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::copyWebCryptoMasterKey):
722         (WTR::TestController::createOtherPage):
723         (WTR::TestController::createWebViewWithOptions):
724         (WTR::TestController::ensureViewSupportsOptions):
725         (WTR::TestController::didCommitNavigation):
726         (WTR::TestController::didFinishNavigation):
727         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
728         (WTR::TestController::didReceiveAuthenticationChallenge):
729         (WTR::TestController::decidePolicyForPluginLoad):
730         (WTR::TestController::decidePolicyForNavigationAction):
731         (WTR::TestController::decidePolicyForNavigationResponse):
732         (WTR::TestController::didCommitLoadForFrame): Deleted.
733         (WTR::TestController::didFinishLoadForFrame): Deleted.
734         * WebKitTestRunner/TestController.h:
735         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
736
737 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
738
739         Unreviewed. Add myself as a committer.
740
741         * Scripts/webkitpy/common/config/contributors.json:
742
743 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
744
745         [Win] Unreviewed test fix.
746
747         * DumpRenderTree/win/PolicyDelegate.cpp:
748         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
749         so was not matching expected output.
750
751 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
752
753         Unreviewed. Moving myself to the committer section at last.
754
755         * Scripts/webkitpy/common/config/contributors.json:
756
757 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
758
759         [Win] Tests fail because DRT reports '(null)' instead of an empty string
760         https://bugs.webkit.org/show_bug.cgi?id=141205
761
762         Reviewed by Anders Carlsson.
763
764         * DumpRenderTree/win/HistoryDelegate.cpp:
765         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
766         properly so that we match expected DumpRenderTree output.
767
768 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
769
770         [GTK] TestWebKitAccessibility is not skipped
771         https://bugs.webkit.org/show_bug.cgi?id=141179
772
773         Reviewed by Carlos Garcia Campos.
774
775         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
776         skipped, and it apparently works reliably on the bots.
777
778         * Scripts/run-gtk-tests:
779         (TestRunner):
780
781 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
782
783         run-perf-tests: allow to specify a wrapper command.
784         https://bugs.webkit.org/show_bug.cgi?id=141172
785
786         Reviewed by Ryosuke Niwa.
787
788         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
789         (parse_args): Update text to indicate is also valid for WTR.
790         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
791         (PerfTestsRunner._parse_args): Add wrapper command.
792
793 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Correct version parsing warning in update-webkit
796         https://bugs.webkit.org/show_bug.cgi?id=141200
797
798         Reviewed by Anders Carlsson.
799
800         * Scripts/webkitdirs.pm:
801         (setupAppleWinEnv): Strip out any specific version build level
802         from the Cygwin version information.
803   
804
805 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
806
807         [Win] Attempt to improve the reliability of HTTP service
808         https://bugs.webkit.org/show_bug.cgi?id=141191
809
810         Reviewed by Darin Adler.
811
812         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
813         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
814         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
815         when stopping the service doesn't do so on its own (for Windows runs).
816
817 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
818
819         Web platform test server should not need to create __init__.py files
820         https://bugs.webkit.org/show_bug.cgi?id=141030
821
822         Reviewed by Ryosuke Niwa.
823
824         W3C TestImporter ensures that copied __init__.py files are not empty.
825         If needed, a comment is inserted in __init__.py files.
826         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
827
828         * Scripts/webkitpy/common/system/filesystem.py:
829         (FileSystem.getsize):
830         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
831         (TestWebPlatformTestServer.test_start_cmd):
832         (TestWebPlatformTestServer):
833         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
834         * Scripts/webkitpy/w3c/test_importer.py:
835         (TestImporter.import_tests):
836
837 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
838
839         Unreviewed. Moving myself to the committer section.
840
841         * Scripts/webkitpy/common/config/contributors.json:
842
843 2015-02-02  Saam Barati  <saambarati1@gmail.com>
844
845         Create tests for JSC's Control Flow Profiler
846         https://bugs.webkit.org/show_bug.cgi?id=141123
847
848         Reviewed by Filip Pizlo.
849
850         * Scripts/run-javascriptcore-tests:
851         (runJSCStressTests):
852         * Scripts/run-jsc-stress-tests:
853
854 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
855
856         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
857         https://bugs.webkit.org/show_bug.cgi?id=141158
858
859         Reviewed by Darin Adler.
860
861         * Scripts/run-jsc-stress-tests:
862
863 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
864
865         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
866         https://bugs.webkit.org/show_bug.cgi?id=141142
867
868         Reviewed by Carlos Garcia Campos.
869
870         * MiniBrowser/gtk/BrowserWindow.c:
871         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
872
873 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
874
875         Web platform test server is not always launching properly on Mac EWS bots
876         https://bugs.webkit.org/show_bug.cgi?id=141141
877
878         Unreviewed.
879
880         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
881         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
882
883 2015-01-31  Sam Weinig  <sam@webkit.org>
884
885         Remove even more Mountain Lion support
886         https://bugs.webkit.org/show_bug.cgi?id=141124
887
888         Reviewed by Alexey Proskuryakov.
889
890         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
891         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
892         * DumpRenderTree/mac/Configurations/Base.xcconfig:
893         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
894         * DumpRenderTree/mac/DumpRenderTree.mm:
895         (activateTestingFonts):
896         (prepareConsistentTestingEnvironment):
897         * DumpRenderTree/mac/EventSendingController.mm:
898         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
899         (-[EventSendingController contextClick]):
900         * DumpRenderTree/mac/TextInputController.m:
901         * LayoutTestRelay/Configurations/Base.xcconfig:
902         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
903         * MiniBrowser/Configurations/Base.xcconfig:
904         * MiniBrowser/Configurations/DebugRelease.xcconfig:
905         * MiniBrowser/mac/WK2BrowserWindowController.m:
906         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
907         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
908         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
909         * TestWebKitAPI/Configurations/Base.xcconfig:
910         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
911         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
912         (-[DownloadDelegate _downloadDidFinish:]):
913         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
916         (TestWebKitAPI::InjectedBundleController::platformInitialize):
917         * WebKitLauncher/Configurations/Base.xcconfig:
918         * WebKitTestRunner/Configurations/Base.xcconfig:
919         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
920         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
921         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
922         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
923         (WTR::activateFonts):
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::TestController::initialize):
926         (WTR::TestController::webProcessName):
927         * WebKitTestRunner/mac/EventSenderProxy.mm:
928         * asan/asan.xcconfig:
929
930 2015-01-31  Commit Queue  <commit-queue@webkit.org>
931
932         Unreviewed, rolling out r179408.
933         https://bugs.webkit.org/show_bug.cgi?id=141117
934
935         This didn't fully fix the issue (Requested by anttik on
936         #webkit).
937
938         Reverted changeset:
939
940         "OSObjectPtr does not work with dispatch_data_t on Maverics"
941         https://bugs.webkit.org/show_bug.cgi?id=141081
942         http://trac.webkit.org/changeset/179408
943
944 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
945
946         https://trac.webkit.org/changeset/179439 breaks a python test
947         https://bugs.webkit.org/show_bug.cgi?id=141114
948
949         Unreviewed.
950
951         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
952         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
953
954 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
955
956         Import W3C web platform tests infrastructure
957         https://bugs.webkit.org/show_bug.cgi?id=140934
958
959         Reviewed by Ryosuke Niwa.
960
961         Loading necessary web platform tests modules before launching server.
962         Ensuring that some empty __init__.py files are present and create them if necessary. 
963
964         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
965         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
966
967 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
968
969         [Win] Another unreviewed test fix.
970
971         Correct copy/paste error in buildbot handling.
972
973         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
974         (LayoutTestApacheHttpd.__init__):
975         (LayoutTestApacheHttpd._get_apache_config_file_path):
976
977 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
978
979         [Win] Unreviewed test fix.
980
981         Correct path handling based on failures on test bots to get things running again.
982
983         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
984         (LayoutTestApacheHttpd.__init__):
985         (LayoutTestApacheHttpd._get_apache_config_file_path):
986
987 2015-01-30  Chris Dumez  <cdumez@apple.com>
988
989         Unreviewed. Fix Windows build after r179409.
990
991         * DumpRenderTree/win/TestRunnerWin.cpp:
992         (TestRunner::notifyDone):
993         (TestRunner::queueLoad):
994
995 2015-01-30  Chris Dumez  <cdumez@apple.com>
996
997         Rename shared() static member functions to singleton() for singleton classes.
998         https://bugs.webkit.org/show_bug.cgi?id=141088
999
1000         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1001
1002         Rename shared() static member functions to singleton() for singleton
1003         classes as per the recent coding style change.
1004
1005 2015-01-30  Antti Koivisto  <antti@apple.com>
1006
1007         OSObjectPtr does not work with dispatch_data_t on Maverics
1008         https://bugs.webkit.org/show_bug.cgi?id=141081
1009
1010         Reviewed by Pratik Solanki.
1011
1012         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1013         (TestWebKitAPI::TEST):
1014
1015 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1016
1017         [Win] Switch to Apache on Windows
1018         https://bugs.webkit.org/show_bug.cgi?id=141060
1019
1020         Reviewed by Alexey Proskuryakov.
1021
1022         Update our scripts under Windows (and Cygwin) to locate and use
1023         the XAMPP installation of Apache for running tests.
1024
1025         * Scripts/run-webkit-httpd:
1026         * Scripts/webkitperl/httpd.pm:
1027         (getHTTPDPath):
1028         (getDefaultConfigForTestDirectory):
1029         (getHTTPDConfigPathForTestDirectory):
1030         * Scripts/webkitpy/common/system/executive_unittest.py:
1031         (ExecutiveTest.serial_test_kill_process):
1032         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1033         (LayoutTestApacheHttpd.__init__):
1034         (LayoutTestApacheHttpd._get_apache_config_file_path):
1035         (LayoutTestApacheHttpd._stop_running_server):
1036         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1037         (HttpServerBase._is_server_running_on_all_ports):
1038         * Scripts/webkitpy/port/base.py:
1039         (Port._apache_config_file_name_for_platform):
1040         * Scripts/webkitpy/port/port_testcase.py:
1041         (test_apache_config_file_name_for_platform):
1042         * Scripts/webkitpy/port/win.py:
1043         (WinPort.show_results_html_file):
1044         (WinPort._uses_apache):
1045         (WinPort):
1046         (WinPort._path_to_apache):
1047
1048 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1049
1050         Built result takes too long to be compressed on bots
1051         https://bugs.webkit.org/show_bug.cgi?id=141056
1052
1053         Reviewed by Daniel Bates.
1054
1055         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1056
1057         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1058
1059 2015-01-29  Sam Weinig  <sam@webkit.org>
1060
1061         Remove support for screen font substitution
1062         https://bugs.webkit.org/show_bug.cgi?id=141038
1063
1064         Reviewed by Tim Horton.
1065
1066         * DumpRenderTree/win/DumpRenderTree.cpp:
1067         (resetWebPreferencesToConsistentValues):
1068         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1069
1070 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1071
1072         Make run-jsc-stress-tests --remote work on Linux too
1073         https://bugs.webkit.org/show_bug.cgi?id=141000
1074
1075         Reviewed by Darin Adler.
1076
1077         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1078         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1079         use bash/dash compatible functions.
1080         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1081
1082 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1083
1084         [buildbot] Simplify jscore-test buildstep
1085         https://bugs.webkit.org/show_bug.cgi?id=140821
1086
1087         Reviewed by Alexey Proskuryakov.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1090         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1091         (RunJavaScriptCoreTests.countFailures): Added.
1092         (RunJavaScriptCoreTests.commandComplete): Deleted.
1093         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1094         (RunJavaScriptCoreTests.getText): Deleted.
1095         (RunJavaScriptCoreTests.getText2): Deleted.
1096         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1097         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1098         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1099         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1100         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1101
1102 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1103
1104         Unreviewed, revert r179337, we don't need this dependency.
1105
1106         * efl/install-dependencies:
1107         * gtk/install-dependencies:
1108
1109 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1110
1111         Unreviewed. Moving myself to the committer section.
1112
1113         * Scripts/webkitpy/common/config/contributors.json:
1114
1115 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1116
1117         URTBF after r179326, added uuid-dev package as new dependency.
1118
1119         * efl/install-dependencies:
1120         * gtk/install-dependencies:
1121
1122 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1123
1124         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1125         https://bugs.webkit.org/show_bug.cgi?id=140673
1126
1127         Reviewed by Sam Weinig.
1128
1129         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1130         Add a DTrace script that outputs a small blob of JSON per message.
1131
1132 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1133
1134         Removed fastMallocForbid / fastMallocAllow
1135         https://bugs.webkit.org/show_bug.cgi?id=141012
1136
1137         Reviewed by Mark Hahnenberg.
1138
1139         Fixed a test bug I noticed while testing.
1140
1141         * DumpRenderTree/JavaScriptThreading.cpp:
1142         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1143         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1144
1145 2015-01-28  Dana Burkart  <dburkart@apple.com>
1146
1147         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1148         https://bugs.webkit.org/show_bug.cgi?id=141015
1149
1150         Reviewed by Alexey Proskuryakov.
1151
1152         * asan/asan.xcconfig:
1153
1154 2015-01-28  Sam Weinig  <sam@webkit.org>
1155
1156         Fix the build.
1157
1158         * Scripts/copy-webkitlibraries-to-product-directory:
1159
1160 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1161
1162         Increase the FileUpload block size in an attempt to improve network performance.
1163         
1164         Reviewed by Alexey Proskuryakov.
1165         
1166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1167         (UploadBuiltProduct.__init__):
1168
1169 2015-01-28  Dana Burkart  <dburkart@apple.com>
1170
1171         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1172         https://bugs.webkit.org/show_bug.cgi?id=136765
1173
1174         Reviewed by Alexey Proskuryakov.
1175
1176         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1177         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1178         * LayoutTestRelay/Configurations/Base.xcconfig:
1179         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1180         * MiniBrowser/Configurations/Base.xcconfig:
1181         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1182         * TestWebKitAPI/Configurations/Base.xcconfig:
1183         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1184         * WebKitLauncher/Configurations/Base.xcconfig:
1185         * WebKitTestRunner/Configurations/Base.xcconfig:
1186         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1187
1188 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1189
1190         AX: [ATK] Implement support for new AtkRole types for MathML
1191         https://bugs.webkit.org/show_bug.cgi?id=140916
1192
1193         Reviewed by Chris Fleizach.
1194
1195         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1196         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1197
1198 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1199
1200         [GTK] Stop removing color marks from unit tests output
1201         https://bugs.webkit.org/show_bug.cgi?id=140996
1202
1203         Reviewed by Philippe Normand.
1204
1205         Since r178236 google tests use a custom simplified output without
1206         any colors, so we don't need to handle the case of non ttys to
1207         remove the color marks.
1208
1209         * Scripts/run-gtk-tests:
1210         (TestRunner.__init__):
1211         (TestRunner._run_test_command.parse_line):
1212
1213 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1216         https://bugs.webkit.org/show_bug.cgi?id=131731
1217
1218         Reviewed by Žan Doberšek.
1219
1220         A web page loaded offscreen is in prerender state not hidden.
1221
1222         * Scripts/run-gtk-tests:
1223         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1224         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1225         (testWebViewPageVisibility):
1226
1227 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1228
1229         Partially revert r178802.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1233
1234 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1235
1236         build.webkit.org/dashboard asserts on some commits
1237         https://bugs.webkit.org/show_bug.cgi?id=140926
1238
1239         Reviewed by Tim Horton.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1242         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1243
1244 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1245
1246         Make flakiness dashboard OS list actually match test_expectations.py
1247         https://bugs.webkit.org/show_bug.cgi?id=140969
1248
1249         Reviewed by Ryosuke Niwa.
1250
1251         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1252
1253 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1254
1255         [Win] WinLauncher crashes on eleventh site visited
1256         https://bugs.webkit.org/show_bug.cgi?id=140960
1257
1258         Reviewed by Anders Carlsson.
1259
1260         * WinLauncher/WinLauncher.cpp:
1261         (WinLauncher::showLastVisitedSites): Don't access off the end of
1262         the history array.
1263
1264 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1265
1266         [Mac] Disable building Java applets by default
1267         https://bugs.webkit.org/show_bug.cgi?id=140957
1268         rdar://problem/19619529
1269
1270         Reviewed by Anders Carlsson.
1271
1272         It was actually already disabled unconditionally, by accident.
1273
1274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1275         * Scripts/webkitpy/port/mac.py:
1276         (MacPort._check_port_build):
1277         (MacPort._build_java_test_support):
1278
1279 2015-01-27  Daniel Bates  <dabates@apple.com>
1280
1281         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1282         https://bugs.webkit.org/show_bug.cgi?id=140949
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1287         builders so that run-webkit-tests can lint the appropriate TestExpectation
1288         files.
1289
1290         * Scripts/webkitpy/port/builders.py:
1291         * Scripts/webkitpy/port/ios.py:
1292         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1293         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1294         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1295         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1296         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1297         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1298         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1299
1300
1301 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1302
1303         Update bots on the flakiness dashboard
1304         https://bugs.webkit.org/show_bug.cgi?id=140956
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         * TestResultServer/static-dashboards/builders.jsonp:
1309         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1310
1311 2015-01-27  Daniel Bates  <dabates@apple.com>
1312
1313         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1314         https://bugs.webkit.org/show_bug.cgi?id=140942
1315
1316         Reviewed by Alexey Proskuryakov.
1317
1318         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1319         are applicable to all WebKit2 ports. We should make use of this information when
1320         running layout tests using iOS WebKit2.
1321
1322         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1323         of the WebKit2 port instead of directly using string concatenation.
1324
1325         * Scripts/webkitpy/port/ios.py:
1326         (IOSSimulatorPort.default_baseline_search_path):
1327
1328 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1329
1330         [Win] Disable FTL stress tests
1331         https://bugs.webkit.org/show_bug.cgi?id=140932
1332
1333         Reviewed by Brent Fulgham.
1334
1335         * Scripts/run-javascriptcore-tests:
1336
1337 2015-01-27  Daniel Bates  <dabates@apple.com>
1338
1339         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1340         https://bugs.webkit.org/show_bug.cgi?id=140939
1341
1342         Reviewed by Eric Carlson.
1343
1344         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1345
1346         * Scripts/webkitdirs.pm:
1347         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1348         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1349         and define a function called wanted.
1350
1351 2015-01-27  Daniel Bates  <dabates@apple.com>
1352
1353         Teach run-webkit-app --simulator how to install custom built app
1354         https://bugs.webkit.org/show_bug.cgi?id=140691
1355
1356         Fix inadvertent omission of directory test flag in expression to check for the
1357         existence of the iOS simulator device-specific directory for user installed apps.
1358
1359         * Scripts/webkitdirs.pm:
1360         (hasUserInstalledAppInSimulatorDevice):
1361
1362 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1363
1364         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1365         https://bugs.webkit.org/show_bug.cgi?id=87426
1366         <rdar://problem/11527899>
1367
1368         Reviewed by Darin Adler.
1369
1370         Revise COMPtr to work better with our HashMap implementation. Use
1371         modern loop syntax.
1372
1373         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1374         (AccessibilityController::~AccessibilityController):
1375         (AccessibilityController::winNotificationReceived):
1376         * DumpRenderTree/win/DumpRenderTree.cpp:
1377         (dumpBackForwardListForAllWindows):
1378
1379 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1380
1381         [Win] Enable JSC stress tests by default
1382         https://bugs.webkit.org/show_bug.cgi?id=128307
1383
1384         Reviewed by Brent Fulgham.
1385
1386         * Scripts/run-javascriptcore-tests:
1387
1388 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1389
1390         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1391         arguments for build and test scripts
1392         https://bugs.webkit.org/show_bug.cgi?id=139748
1393
1394         Reviewed by Daniel Bates.
1395
1396         There was much confusion resulting from the multitude of aliases used to build/test for
1397         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1398         tests directory.
1399
1400         This fixes an issue where run-api-tests and some other scripts failed when run with
1401         --simulator.
1402
1403         * Scripts/build-webkit:
1404         * Scripts/package-root:
1405         (usage):
1406         * Scripts/webkitdirs.pm:
1407         (argumentsForConfiguration):
1408         (determineXcodeSDK):
1409         * Scripts/webkitpy/port/factory.py:
1410         (platform_options):
1411
1412 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1413
1414         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1415         https://bugs.webkit.org/show_bug.cgi?id=140203
1416         rdar://problem/19198492
1417
1418         Reviewed by Sam Weinig.
1419
1420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1421         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1422         (TEST):
1423
1424 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1425
1426         Add iOS EWS to build.webkit.org/dashboard
1427         <http://webkit.org/b/140627>
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1434         (BubbleQueueServer): Add ios-ews queue info.
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1436         Add iOS8Device platform.
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1438         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1439         iOS device logo.
1440
1441 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1442
1443         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1444         https://bugs.webkit.org/show_bug.cgi?id=140896
1445
1446         Reviewed by Michael Saboff.
1447         
1448         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1449         makes our script do this.
1450         
1451         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1452         this would be harder given llvm's autoconf setup.
1453
1454         * Scripts/copy-webkitlibraries-to-product-directory:
1455
1456 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1457
1458         Update bot assignments.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/config.json:
1461
1462 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1463
1464         Integrate WP python server into WebKit test framework
1465         https://bugs.webkit.org/show_bug.cgi?id=127094
1466
1467         Reviewed by Ryosuke Niwa.
1468
1469         This patch adds W3C web server (wptserver) as a new HTTP server.
1470         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1471         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1472
1473         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1474         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1475         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1476
1477         * Scripts/webkitpy/common/system/executive_mock.py:
1478         (MockProcess.communicate):
1479         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1480         (LayoutTestRunner.__init__):
1481         (LayoutTestRunner.run_tests):
1482         (LayoutTestRunner.start_servers):
1483         (LayoutTestRunner.stop_servers):
1484         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1485         (LayoutTestRunnerTests._run_tests):
1486         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1487         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1488         (LayoutTestRunnerTests):
1489         (LayoutTestRunnerTests.test_servers_started):
1490         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1491         (Manager.__init__):
1492         (Manager._is_http_test):
1493         (Manager._is_web_platform_test):
1494         (Manager._run_tests):
1495         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1496         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1497         (ManagerTest.test_needs_servers.get_manager):
1498         (ManagerTest.test_needs_servers):
1499         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1500         (parse_args):
1501         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1502         (main):
1503         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1504         (doc_root):
1505         (base_url):
1506         (WebPlatformTestServer):
1507         (WebPlatformTestServer.__init__):
1508         (WebPlatformTestServer._set_start_cmd):
1509         (WebPlatformTestServer._copy_webkit_test_files):
1510         (WebPlatformTestServer._clean_webkit_test_files):
1511         (WebPlatformTestServer._prepare_config):
1512         (WebPlatformTestServer._spawn_process):
1513         (WebPlatformTestServer._stop_running_server):
1514         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1515         (TestWebPlatformTestServer):
1516         (TestWebPlatformTestServer.test_start_cmd):
1517         * Scripts/webkitpy/port/base.py:
1518         (Port.__init__):
1519         (Port.to.start_web_platform_test_server):
1520         (Port.to):
1521         (Port.to.web_platform_test_server_doc_root):
1522         (Port.to.web_platform_test_server_base_url):
1523         (Port.to.stop_web_platform_test_server):
1524         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1525         (Driver.__init__):
1526         (Driver.is_web_platform_test):
1527         (Driver.test_to_uri):
1528         (Driver.uri_to_test):
1529         (Driver._command_from_driver_input):
1530         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1531         (DriverTest.test_test_to_uri):
1532         (DriverTest.test_uri_to_test):
1533
1534 2015-01-26  Daniel Bates  <dabates@apple.com>
1535
1536         Teach run-webkit-app --simulator how to install custom built app
1537         https://bugs.webkit.org/show_bug.cgi?id=140691
1538
1539         Reviewed by David Kilzer.
1540
1541         We should teach run-webkit-app --simulator how to install a custom built app.
1542
1543         Currently run-webkit-app --simulator can only run a system app or an app that
1544         was installed using the simctl command line tool. For convenience we should
1545         teach run-webkit-app --simulator how to install a custom built app.
1546
1547         As a side effect of this change run-safari --simulator will install and run
1548         a custom built of MobileSafari (if it exists).
1549
1550         * Scripts/webkitdirs.pm:
1551         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1552         Perl from the structure of the device.plist file.
1553         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1554         file system check to determine the plist path for a Mac app bundle.
1555         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1556         it will complain that it cannot find the file: "Domain ... does not exist".
1557         (appDisplayNameFromBundle): Ditto.
1558         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1559         until a simulator device is the specified state.
1560         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1561         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1562         the specified device.
1563         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1564         As implied by its name, this function will not return until the specified simulator
1565         device UDID is in the shutdown state.
1566         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1567         device with the specified UDID.
1568         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1569         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1570         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1571         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1572         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1573         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1574         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1575         (hasUserInstalledAppInSimulatorDevice): Added.
1576         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1577         "Booted" state.
1578         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1579         switching between a system installed app and a custom built version of the same app (e.g.
1580         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1581         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1582         as that was the only caller of this function.
1583         (bootedIOSSimulatorDevice): Deleted.
1584         (openIOSSimulator): Deleted.
1585
1586 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1587
1588         Update bot assignments.
1589
1590         * BuildSlaveSupport/build.webkit.org-config/config.json:
1591
1592 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1593
1594         Leaks bot shouldn't run JSC tests
1595         https://bugs.webkit.org/show_bug.cgi?id=140877
1596
1597         Reviewed by Darin Adler.
1598
1599         Shaves off 48 minutes of time.
1600
1601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1602         (TestLeaksFactory): Slim down the leaks queue.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1605         * Scripts/webkitpy/port/ios.py:
1606         (IOSSimulatorPort.print_leaks_summary):
1607         * Scripts/webkitpy/port/mac.py:
1608         (MacPort.print_leaks_summary):
1609         Don't yell when leaks are detected.
1610
1611 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1612
1613         Refactor run-javascriptcore-tests
1614         https://bugs.webkit.org/show_bug.cgi?id=140824
1615
1616         Reviewed by Darin Adler.
1617
1618         Separated mozilla, stress test code paths and
1619         determining skipped mozilla tests into subroutines.
1620
1621         * Scripts/run-javascriptcore-tests:
1622         (runMozillaTests):
1623         (runJSCStressTests):
1624         (defaultJsDriverArgsForMozillaTests):
1625
1626 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1627
1628         [buildbot] Fix grammar of TestWithFailureCount
1629         https://bugs.webkit.org/show_bug.cgi?id=140884
1630
1631         Reviewed by Alexey Proskuryakov.
1632
1633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1634         (TestWithFailureCount):
1635         (TestWithFailureCount.commandComplete):
1636         (TestWithFailureCount.getText2):
1637         (RunUnitTests):
1638         (RunPythonTests):
1639         (RunPerlTests):
1640         (RunLLINTCLoopTests):
1641         (Run32bitJSCTests):
1642         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1643         (RunLLINTCLoopTestsTest.test_failure):
1644         (Run32bitJSCTestsTest.test_failure):
1645         (RunUnitTestsTest.assertFailures):
1646
1647 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1648
1649         Unreviewed. Moving myself to the committer section.
1650
1651         * Scripts/webkitpy/common/config/contributors.json:
1652
1653 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1654
1655         [GTK] gtkdoc does not appear in DevHelp
1656         https://bugs.webkit.org/show_bug.cgi?id=139369
1657
1658         Reviewed by Philippe Normand.
1659
1660         * gtk/generate-gtkdoc: Create the generators in the main function
1661         and use them to get the local cross renference dependencies. Also
1662         pass the generator module name to webkitdom.write_doc_files().
1663         (get_gtkdoc_module_paths): Receive a list of local cross reference
1664         dependencies.
1665         (get_generator_for_config): Set the main_sgml_file property of the
1666         GtkDoc object from the configuration file.
1667         (generate_documentation): Generate the documentation for the given
1668         generator.
1669         (generate_documentation_for_config): Deleted.
1670         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1671         * gtk/webkitdom.py:
1672         (write_doc_files): Receive the module name used to build the
1673         -sections.txt filename.
1674
1675 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1676
1677         Unreviewed, rolling out r179107.
1678         https://bugs.webkit.org/show_bug.cgi?id=140880
1679
1680         The GCC in the bots doesn't support the AsyncTask
1681         implementation (Requested by KaL on #webkit).
1682
1683         Reverted changeset:
1684
1685         "[GTK] Enable IndexedDB"
1686         https://bugs.webkit.org/show_bug.cgi?id=98932
1687         http://trac.webkit.org/changeset/179107
1688
1689 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1690
1691         [EFL] Bump libseccomp version to 2.1.1
1692         https://bugs.webkit.org/show_bug.cgi?id=140357
1693
1694         Reviewed by Gyuyoung Kim.
1695
1696         * efl/jhbuild.modules:
1697
1698 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1699
1700         [GTK] Enable IndexedDB
1701         https://bugs.webkit.org/show_bug.cgi?id=98932
1702
1703         Reviewed by Žan Doberšek.
1704
1705         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1706
1707 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1708
1709         Would like leaks bot results at build.webkit.org/dashboard
1710         https://bugs.webkit.org/show_bug.cgi?id=122657
1711
1712         Reviewed by Darin Adler.
1713
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1715         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1716         than necessary, could use the ones from buildbot in more places.
1717
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1719         (BuildbotQueue): Reflect configuration option for leaks queues.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1722         Add leaks queues to performance column. First, leaks are about performance indeed,
1723         and second, this is where we have some space to spare.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1726         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1727         least a year.
1728
1729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1730         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1731         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1732         results - once the results are loaded, all rows are currently higher than that.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1735         (.leaks-popover): Added.
1736
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1738         Added.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1741         Load BuildbotLeaksQueueView.js.
1742
1743 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1744
1745         [Win] Add WebKit message loop interface.
1746         https://bugs.webkit.org/show_bug.cgi?id=140857
1747
1748         Reviewed by Brent Fulgham.
1749
1750         Added message loop interface which will run the message loop,
1751         and perform required tasks (like calling CFRunLoopRunInMode)
1752         on each iteration of the loop.
1753
1754         * WinLauncher/WinMain.cpp:
1755         (wWinMain): Use new message loop interface.
1756
1757 2015-01-24  Dan Bernstein  <mitz@apple.com>
1758
1759         update-webkit’s --internal option is unused
1760         https://bugs.webkit.org/show_bug.cgi?id=140861
1761
1762         Reviewed by Anders Carlsson.
1763
1764         * Scripts/update-webkit: Removed the option.
1765
1766 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1767
1768         DumpRenderTree needs to run with Windows native controls on Windows
1769         https://bugs.webkit.org/show_bug.cgi?id=25592
1770
1771         Reviewed by Anders Carlsson.
1772
1773         * DumpRenderTree/win/DumpRenderTree.cpp:
1774         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1775         (prepareConsistentTestingEnvironment): Ditto.
1776
1777 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1778
1779         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1780         <http://webkit.org/b/140787>
1781
1782         Reviewed by Daniel Bates.
1783
1784         * Scripts/webkitpy/port/ios.py:
1785         (IOSPort.determine_full_port_name): Instead of checking the type
1786         of the current host, test if /usr/bin/xcrun exists before trying
1787         to use it.
1788
1789 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         Fix the false positive build failures on the Windows buildbots
1792         https://bugs.webkit.org/show_bug.cgi?id=140819
1793
1794         Reviewed by Brent Fulgham.
1795
1796         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1797         the default 20 minutes is enough for others since they produce output during the build.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1800         (BuildFactory.__init__):
1801
1802 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1803
1804         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1805         https://bugs.webkit.org/show_bug.cgi?id=140839
1806
1807         Reviewed by Dean Jackson.
1808
1809         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1810         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1811         from the IA2Locale structure and pass it to DRT.
1812
1813 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1814
1815         [Win] Update DRT Accessibility implementation to better match Mac.
1816         https://bugs.webkit.org/show_bug.cgi?id=140830
1817
1818         Reviewed by Dean Jackson.
1819
1820         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1821         (AccessibilityUIElement::titleUIElement):
1822         (AccessibilityUIElement::parentElement):
1823         (convertToDRTLabel):
1824         (AccessibilityUIElement::role):
1825         (AccessibilityUIElement::title):
1826         (AccessibilityUIElement::description):
1827         (AccessibilityUIElement::stringValue):
1828         (AccessibilityUIElement::helpText):
1829         (AccessibilityUIElement::isFocused):
1830
1831 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1832
1833         REGRESSION: run-perf-tests --profiler= seems to have broken
1834         https://bugs.webkit.org/show_bug.cgi?id=113528
1835
1836         Reviewed by Daniel Bates.
1837
1838         The problem is that "perf --record" (or the equivalent call for
1839         other profilers) is never called whenever there is a wrapper
1840         option in the port. We should inject the profiler call first
1841         (should it exists) and then use the port wrapper.
1842
1843         * Scripts/webkitpy/port/driver.py:
1844         (Driver._command_wrapper):
1845         * Scripts/webkitpy/port/driver_unittest.py:
1846         (DriverTest.test_profiler_and_wrapper): New unit test.
1847
1848 2015-01-22  David Kilzer  <ddkilzer@apple.com>
1849
1850         configure-xcode-for-ios-development needs to import webkitdirs.pm
1851         <http://webkit.org/b/140704>
1852
1853         Fixes the following runtime error:
1854
1855             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
1856
1857         * Scripts/configure-xcode-for-ios-development: Add back code to
1858         import webkitdirs.pm for the exitStatus() method.  Not sure why
1859         I removed it before patch review.
1860
1861 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
1862
1863         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
1864         https://bugs.webkit.org/show_bug.cgi?id=140795
1865
1866         Reviewed by Jon Honeycutt.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/config.json:
1869         r178847 accidentally remove the scheduler for this bot. Re-add it to the
1870         Yosemite scheduler.
1871
1872 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
1873
1874         [Win] Expose missing editing features through WebView interface
1875         https://bugs.webkit.org/show_bug.cgi?id=140773
1876         <rdar://problem/19565421>
1877
1878         Reviewed by Dean Jackson.
1879
1880         Connect the various WebView editing delegate methods to our
1881         test infrastructure. Also prefer _bstr_t to raw BSTR types
1882         to simplify life cycle management.
1883
1884         * DumpRenderTree/win/DumpRenderTree.cpp:
1885         (resetWebViewToConsistentStateBeforeTesting):
1886         * DumpRenderTree/win/EditingDelegate.cpp:
1887         (EditingDelegate::QueryInterface):
1888         (dumpPath):
1889         (dump):
1890         (EditingDelegate::shouldBeginEditingInDOMRange):
1891         (EditingDelegate::shouldEndEditingInDOMRange):
1892         (EditingDelegate::shouldInsertNode):
1893         (EditingDelegate::shouldInsertText):
1894         (EditingDelegate::shouldDeleteDOMRange):
1895         (EditingDelegate::shouldChangeSelectedDOMRange):
1896         (EditingDelegate::shouldApplyStyle):
1897         (EditingDelegate::shouldChangeTypingStyle):
1898         (EditingDelegate::doPlatformCommand):
1899         (EditingDelegate::webViewDidBeginEditing):
1900         (EditingDelegate::webViewDidChange):
1901         (EditingDelegate::webViewDidEndEditing):
1902         (EditingDelegate::webViewDidChangeTypingStyle):
1903         (EditingDelegate::webViewDidChangeSelection):
1904         (EditingDelegate::checkSpellingOfString):
1905         (EditingDelegate::onNotify):
1906         * DumpRenderTree/win/EditingDelegate.h:
1907
1908 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1909
1910         Add a build flag for ES6 class syntax
1911         https://bugs.webkit.org/show_bug.cgi?id=140760
1912
1913         Reviewed by Michael Saboff.
1914
1915         * Scripts/webkitperl/FeatureList.pm:
1916
1917 2015-01-22  Daniel Bates  <dabates@apple.com>
1918
1919         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
1920         runtime in simctl output
1921         https://bugs.webkit.org/show_bug.cgi?id=140751
1922
1923         Reviewed by David Kilzer.
1924
1925         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
1926         with an error because it does not know how to parse the output of the simctl tool
1927         to identify an Apple Internal runtime.
1928
1929         * Scripts/webkitpy/xcode/simulator.py:
1930         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
1931         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
1932         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
1933         the runtime is an internal runtime.
1934         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
1935         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
1936         appropriate value.
1937         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
1938         it updates the appropriate Runtime object.
1939         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
1940         looking up a Runtime object for an internal runtime.
1941
1942 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
1943
1944         LeaksViewer doesn't show recent builds if there are less than 10
1945         https://bugs.webkit.org/show_bug.cgi?id=140716
1946
1947         Reviewed by Tim Horton.
1948
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1950
1951 2015-01-22  Lucas Forschler  <lforschler@apple.com>
1952
1953         Add Apple build slaves.
1954         Fixed text alignment for slave list.
1955         
1956         Unreviewed.
1957         
1958         * BuildSlaveSupport/build.webkit.org-config/config.json:
1959
1960 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1961
1962         Teach build.webkit.org about bot308 and bot309.
1963         
1964         Unreviewed.
1965         
1966         * BuildSlaveSupport/build.webkit.org-config/config.json:
1967
1968 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1969
1970         Add two Apple Mavericks slaves.
1971         
1972         Unreviewed.
1973         
1974         * BuildSlaveSupport/build.webkit.org-config/config.json:
1975
1976 2015-01-21  Daniel Bates  <dabates@apple.com>
1977
1978         Add iOS WebKit1 TestExpectation file
1979         https://bugs.webkit.org/show_bug.cgi?id=140739
1980
1981         Reviewed by David Kilzer.
1982
1983         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
1984         expectations in directory LayoutTests/platform/ios-simulator-wk1.
1985
1986         * Scripts/webkitpy/port/ios.py:
1987         (IOSSimulatorPort.default_baseline_search_path):
1988
1989 2015-01-21  David Kilzer  <ddkilzer@apple.com>
1990
1991         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
1992         <http://webkit.org/b/140704>
1993
1994         Reviewed by Daniel Bates.
1995
1996         * Scripts/configure-xcode-for-ios-development:
1997         - Update copyright.
1998         - Remove FIXME addressed by r178709.
1999         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2000         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2001         missing headers from iphonesimulator SDK to iphoneos SDK.
2002         (sdkDirectory): Add method that returns SDK directory.
2003         (sdkPlatformDirectory): Extract method from
2004         xcodeSDKSpecificationsPath() that returns SDK platform
2005         directory.
2006         (xcodeSDKSpecificationsPath): Update to use
2007         sdkPlatformDirectory().
2008
2009 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2010
2011         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2012         https://bugs.webkit.org/show_bug.cgi?id=140731
2013
2014         Reviewed by Tim Horton.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2017         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2018
2019 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2020
2021         [Win] eventSender does not support scalePageBy
2022         https://bugs.webkit.org/show_bug.cgi?id=140726
2023         <rdar://problem/19549865>
2024
2025         Reviewed by Dean Jackson.
2026
2027         * DumpRenderTree/win/EventSender.cpp:
2028         (scalePageByCallback): Provide implementation using new WebView method.
2029
2030 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2031
2032         Remove Apple Mountain Lion Build & Test slaves.
2033         
2034         Unreviewed.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/config.json:
2037
2038 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2039
2040         Remove ENABLE(INSPECTOR) ifdef guards
2041         https://bugs.webkit.org/show_bug.cgi?id=140668
2042
2043         Reviewed by Darin Adler.
2044
2045         * DumpRenderTree/mac/TestRunnerMac.mm:
2046         (TestRunner::showWebInspector):
2047         (TestRunner::closeWebInspector):
2048         (TestRunner::evaluateInWebInspector):
2049         * Scripts/webkitperl/FeatureList.pm:
2050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2051         (WTR::TestRunner::showWebInspector):
2052         (WTR::TestRunner::closeWebInspector):
2053         (WTR::TestRunner::evaluateInWebInspector):
2054         * WebKitTestRunner/TestInvocation.cpp:
2055         (WTR::TestInvocation::invoke):
2056
2057 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2058
2059         Update build.webkit.org/dashboard to match current Mac queues.
2060
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2068         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2069         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2070
2071 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2072
2073         Update Apple MountainLion Leaks slave to Yosemite
2074         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2075         
2076         Unreviewed.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/config.json:
2079
2080 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2081
2082         Update LeaksViewer from MountainLion to Yosemite
2083         
2084         Reviewed by Alexey Proskuryakov.
2085
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2087         (LeaksViewer._displayURLPrompt):
2088
2089 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2090
2091         Fix EWS python unit tests and address code comments as per 140476
2092         https://bugs.webkit.org/show_bug.cgi?id=140637
2093
2094         Reviewed by David Kilzer.
2095
2096         * Scripts/webkitpy/port/base.py:
2097         (Port):
2098         (Port.__init__):
2099         Adds DEFAULT_ARCHITECTURE member.
2100         (Port.architecture):
2101         Removes architecture member and instead uses
2102         self.get_option('architecture'). Also removes redundant architecture
2103         method.
2104         (Port.set_architecture):
2105         Adds a setter for the architecture variable to be able to set a flag
2106         upon modification.
2107         (Port.test_configuration):
2108         Uses self.architecture() instead of self._architecture.
2109         * Scripts/webkitpy/port/ios.py:
2110         Overrides DEFAULT_ARCHITECTURE.
2111         (IOSPort):
2112         (IOSPort.determine_full_port_name):
2113         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2114         strip. Fixes regex to not match arbitrary characters after the
2115         relevent digits are matched.
2116         (IOSPort.__init__):
2117         Removes old _architecture defaulting strategy.
2118         (IOSPort._build_driver_flags):
2119         Uses self.architecture() instead of self._architecture.
2120         (IOSSimulatorPort):
2121         Overrides DEFAULT_ARCHITECTURE.
2122         (IOSSimulatorPort.__init__):
2123         Removes old _architecture defaulting strategy.
2124         * Scripts/webkitpy/port/mac.py:
2125         (MacPort):
2126         Overrides DEFAULT_ARCHITECTURE.
2127         (MacPort.__init__):
2128         Removes old _architecture defaulting strategy.
2129         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2130         (AbstractEarlyWarningSystem.run_command):
2131         Checks the did_override_architecture flag to determine whether to add
2132         the --architecture option.
2133         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2134         Uses ews.architecture rather than trying to discern the correct
2135         architecture using a port object.
2136         (EarlyWarningSystemTest._default_expected_logs):
2137         * Scripts/webkitpy/tool/commands/queues.py:
2138         Removes use of optparse, and removes the import statement.
2139         (AbstractQueue.__init__):
2140         (PatchProcessingQueue.begin_work_queue):
2141
2142 2015-01-20  Sam Weinig  <sam@webkit.org>
2143
2144         Attempt to fix Mountain Lion and EFL tests.
2145
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::initialize):
2148         Disable Process-per-tab and network process on Mountain Lion and EFL.
2149
2150 2015-01-20  Darin Adler  <darin@apple.com>
2151
2152         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2153         https://bugs.webkit.org/show_bug.cgi?id=140679
2154
2155         Reviewed by Anders Carlsson.
2156
2157         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2158         Removed a reference to SVGElementInstanceList.
2159
2160 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2161
2162         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2163         https://bugs.webkit.org/show_bug.cgi?id=140028
2164
2165         Reviewed by Carlos Garcia Campos.
2166
2167         This won't work as expected, since this function is called before the
2168         WebViewTest constructor completes.
2169
2170         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2171
2172 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2173
2174         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2175         <http://webkit.org/b/140661>
2176
2177         Reviewed by Daniel Bates.
2178
2179         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2180         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2181         "iphoneos" and "iphonesimulator" SDKs.
2182         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2183         the main body of the script.
2184
2185 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2186
2187         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2188         https://bugs.webkit.org/show_bug.cgi?id=139443
2189
2190         Reviewed by Carlos Garcia Campos.
2191
2192         Create the new test cases for setting the editable property on the web
2193         view and on the contenteditable enabled document. Also rework the
2194         current tests that are expecting that the web view is editable.
2195
2196         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2197         (loadTestHtml):
2198         (testWebViewEditorCutCopyPasteNonEditable):
2199         (testWebViewEditorCutCopyPasteEditable):
2200         (testWebViewEditorSelectAllNonEditable):
2201         (testWebViewEditorSelectAllEditable):
2202         (runEditorEditableCutTests):
2203         (testWebViewEditorEditableOnNonEditable):
2204         (testWebViewEditorEditableOnContentEditable):
2205         (testWebViewEditorNonEditable):
2206         (beforeAll):
2207         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2208         (WebViewTest::isEditable):
2209         (WebViewTest::setEditable):
2210
2211 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2212
2213         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2214         https://bugs.webkit.org/show_bug.cgi?id=140617
2215
2216         Reviewed by Gustavo Noronha Silva.
2217
2218         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2219         (testWebViewSnapshot): Check that the same snapshot with
2220         transparent background is different than the default one filled
2221         with white.
2222
2223 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2224
2225         [GTK] Add API to change the WebKitWebView background color
2226         https://bugs.webkit.org/show_bug.cgi?id=140610
2227
2228         Reviewed by Gustavo Noronha Silva.
2229
2230         Add --bg-color command line option to MiniBrowser to be able to
2231         manually test the API passing any RGBA color to MiniBrowser.
2232         Also add a simple unit test to check that getting and setting
2233         colors from the API point of view.
2234
2235         * MiniBrowser/gtk/BrowserWindow.c:
2236         (browser_window_set_background_color):
2237         * MiniBrowser/gtk/BrowserWindow.h:
2238         * MiniBrowser/gtk/main.c:
2239         (createBrowserWindow):
2240         (parseBackgroundColor):
2241         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2242         (testWebViewBackgroundColor):
2243         (beforeAll):
2244
2245 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2246
2247         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2248         https://bugs.webkit.org/show_bug.cgi?id=140665
2249
2250         Reviewed by Brian Burg.
2251
2252         * DumpRenderTree/win/UIDelegate.cpp:
2253         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2254         match expected test output.
2255
2256 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2257
2258         Remove the support for custom suffixes on ChangeLog
2259         https://bugs.webkit.org/show_bug.cgi?id=140648
2260
2261         Reviewed by David Kilzer.
2262
2263         Custom suffixes were used for the iOS branch of WebKit.
2264         Now that everything is opensource, there is no need for it.
2265
2266         * Scripts/VCSUtils.pm:
2267         (changeLogSuffix): Deleted.
2268         (changeLogFileName): Deleted.
2269         * Scripts/commit-log-editor:
2270         * Scripts/prepare-ChangeLog:
2271         (getLatestChangeLogs):
2272         (generateNewChangeLogs):
2273         (generateFileList):
2274         * Scripts/resolve-ChangeLogs:
2275         (findChangeLog):
2276
2277 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2278
2279         Adjust naming of action menu SPI
2280         https://bugs.webkit.org/show_bug.cgi?id=140644
2281         <rdar://problem/19448129>
2282
2283         Reviewed by Brian Weinstein.
2284
2285         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2286         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2287         (TestWebKitAPI::TEST):
2288
2289 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2290
2291         [GTK] Generate the make dist manifest from a CMake template file
2292         https://bugs.webkit.org/show_bug.cgi?id=139387
2293
2294         Reviewed by Martin Robinson.
2295
2296         Remove the code that performs variable substitution on manifest.txt.
2297         Replace the custom variables used in that file with CMake variables.
2298
2299         * gtk/make-dist.py:
2300         (Manifest.add_directory):
2301         (Manifest.get_full_source_path):
2302         (Manifest.process_line):
2303         (Manifest.resolve_variables): Deleted.
2304         (Manifest.get_full_tarball_path): Deleted.
2305         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2306
2307 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2308
2309         [Win] Correct merge error in last commit.
2310
2311         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2312         (findAccessibleObjectById): Undo accidental paste made during landing.
2313
2314 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2315
2316         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2317         https://bugs.webkit.org/show_bug.cgi?id=139906
2318
2319         Reviewed by Dean Jackson.
2320
2321         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2322         to use them. This patch fixes that.
2323
2324         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2325         (findAccessibleObjectById):
2326         (AccessibilityController::focusedElement):
2327         (logEventProc):
2328         (notificationListenerProc):
2329         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2330         (AccessibilityUIElement::getChildAtIndex):
2331         (AccessibilityUIElement::titleUIElement):
2332         (self):
2333         (AccessibilityUIElement::role):
2334         (AccessibilityUIElement::valueDescription):
2335         (accessibilityState):
2336         (AccessibilityUIElement::isChecked):
2337         * DumpRenderTree/win/DumpRenderTree.cpp:
2338         (dumpFrameScrollPosition):
2339         (dumpFramesAsText):
2340         * DumpRenderTree/win/PolicyDelegate.cpp:
2341         (PolicyDelegate::decidePolicyForNavigationAction):
2342         * DumpRenderTree/win/UIDelegate.cpp:
2343         (UIDelegate::exceededDatabaseQuota):
2344         * WinLauncher/Common.cpp:
2345         (setWindowText):
2346
2347 2015-01-19  Dean Jackson  <dino@apple.com>
2348
2349         Add "override" to fix the build with newer clangs.
2350
2351         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2352         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2353
2354 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2355
2356         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2357         <http://webkit.org/b/140623>
2358
2359         Reviewed by Daniel Bates.
2360
2361         * Scripts/build-webkit: Update help for --device switch.
2362         * Scripts/webkitdirs.pm:
2363         (determineXcodeSDK): When passing --device, prefer the internal
2364         iOS SDK if it exists, else fall back to the external iOS SDK.
2365         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2366         xcodebuild instead of trying to sanitize values.
2367
2368 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2369
2370         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2371         https://bugs.webkit.org/show_bug.cgi?id=140606
2372
2373         Reviewed by Csaba Osztrogonác.
2374
2375         * Scripts/webkitpy/bindings/main.py:
2376         (BindingsTests.generate_supplemental_dependency):
2377         (BindingsTests.main):
2378
2379 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2380
2381         [GTK] [WK2] TestWebKitWebView snapshot fails
2382         https://bugs.webkit.org/show_bug.cgi?id=120404
2383
2384         Reviewed by Žan Doberšek.
2385
2386         Rework the test to make sure the snapshot is always created at the
2387         desired size.
2388
2389         * Scripts/run-gtk-tests:
2390         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2391         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2392         (testWebViewSnapshot): Use a fixed size for the document, and
2393         disable scrollbars to make sure the visible area is always the
2394         WebView size.
2395         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2396         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2397         and height parameters to create the window with a given size.
2398         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2399
2400 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2401
2402         iOS EWS queue name should be consistent
2403         <http://webkit.org/b/140585>
2404
2405         Reviewed by Daniel Bates.
2406
2407         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2408         to 'ios'.
2409         * Scripts/webkitpy/common/config/ports.py: Ditto.
2410         (DeprecatedPort.port):
2411         (IOSPort):
2412         * Scripts/webkitpy/port/ios.py: Ditto.
2413         (IOSPort):
2414
2415         * Scripts/webkitpy/port/factory.py:
2416         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2417         appears before ios.IOSPort.  If this is not done,
2418         `run-webkit-tests --ios-simulator` will get the wrong Port class
2419         (IOSPort instead of IOSSimulatorPort) due to the way that
2420         PortFactory.get() uses prefix matching of <Port>.port_name to
2421         find the correct class to use.
2422
2423 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2424
2425         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2426         https://bugs.webkit.org/show_bug.cgi?id=140595
2427
2428         Reviewed by Csaba Osztrogonác.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2431         (BubbleQueueServer):
2432
2433 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2434
2435         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2436
2437         * Scripts/webkitpy/port/ios.py:
2438         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2439         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2440         the Mountain Lion and Mavericks bots.
2441
2442 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2443
2444         Attempt to fix webkitpy tests on GTK Linux ports
2445
2446         * Scripts/webkitpy/port/ios.py:
2447         (IOSPort.determine_full_port_name): Set a sensible default if
2448         not running on a Mac platform or if no iOS SDK is installed.
2449
2450 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2451
2452         Create iOS-EWS client queue
2453         https://bugs.webkit.org/show_bug.cgi?id=140476
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         * EWSTools/start-queue-mac.sh:
2458         Adds call to configure-xcode-for-ios-development for iOS EWS.
2459         * Scripts/webkitpy/common/config/ews.json:
2460         Adds the iOS EWS config entry.
2461         * Scripts/webkitpy/common/config/ports.py:
2462         (DeprecatedPort.port):
2463         Adds IOSPort to the port map.
2464         (IOSPort):
2465         (IOSPort.build_webkit_command):
2466         Adds --sdk=iphoneos to the webkit build command.
2467         * Scripts/webkitpy/port/base.py:
2468         (Port.architecture):
2469         Adds an accessor for the architecture member variable.
2470         * Scripts/webkitpy/port/factory.py:
2471         (PortFactory):
2472         Adds IOSPort to the port class list.
2473         * Scripts/webkitpy/port/ios.py:
2474         Adds the IOSPort to encapsulate iOS-specific things.
2475         (IOSPort):
2476         (IOSPort.determine_full_port_name):
2477         (IOSPort.__init__):
2478         (IOSPort._build_driver_flags):
2479         (IOSPort.operating_system):
2480         * Scripts/webkitpy/tool/commands/download_unittest.py:
2481         Adds the archetecture option to the mock options.
2482         (DownloadCommandsTest._default_options):
2483         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2484         Appends the archetecture option into calls to webkit-patch.
2485         (AbstractEarlyWarningSystem.review_patch):
2486         (AbstractEarlyWarningSystem.run_command):
2487         (AbstractEarlyWarningSystem.load_ews_classes):
2488         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2489         Adds logic to soothe the unittest now that --architecture is being
2490         thrown around everywhere.
2491         (EarlyWarningSystemTest._default_expected_logs):
2492         * Scripts/webkitpy/tool/commands/queues.py:
2493         Adds glue code to ferry the --architecture option around.
2494         (AbstractQueue.__init__):
2495         (PatchProcessingQueue.begin_work_queue):
2496         * Scripts/webkitpy/tool/steps/abstractstep.py:
2497         Adds the archetecture option to all AbstractSteps so that
2498         EarlyWarningSystem doesn't start shoving --architecture into
2499         unsuspecting commands.
2500         (AbstractStep.options):
2501         * Scripts/webkitpy/tool/steps/build.py:
2502         Translates the --architecture option into an ARCHS= format to pass to
2503         build-webkit.
2504         (Build.build):
2505         * Scripts/webkitpy/tool/steps/options.py:
2506         Adds a definition for the --architecture option.
2507         (Options):
2508
2509 2015-01-16  Sam Weinig  <sam@webkit.org>
2510
2511         Add a basic configuration object for WKView
2512         https://bugs.webkit.org/show_bug.cgi?id=140559
2513
2514         Reviewed by Anders Carlsson.
2515
2516         Add tests for WKPageConfigurationRef.
2517
2518         * TestWebKitAPI/PlatformWebView.h:
2519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2520         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2521         (TestWebKitAPI::TEST):
2522         (TestWebKitAPI::didFinishLoadForFrame):
2523         (TestWebKitAPI::setPageLoaderClient):
2524         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2525         (TestWebKitAPI::PlatformWebView::initialize):
2526         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2527
2528 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2529
2530         WeakPtr functions crash when created with default constructor
2531         https://bugs.webkit.org/show_bug.cgi?id=140479
2532
2533         Reviewed by Andreas Kling.
2534
2535         Add WeakPtr API tests.
2536
2537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2538         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2539         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2540
2541 2015-01-16  Chris Dumez  <cdumez@apple.com>
2542
2543         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2544         https://bugs.webkit.org/show_bug.cgi?id=140568
2545
2546         Reviewed by Alexey Proskuryakov.
2547
2548         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2549         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2550         e.g. "Longhands=background-position-x|background-position-y".
2551         This would confuse the script and treat this as a CSS property:
2552         "background-position-x|background-position-y".
2553
2554         We now split on white space and treat the first string on the line
2555         to be the property name (this is the syntax in this file).
2556
2557         * Scripts/webkitpy/w3c/test_converter.py:
2558         (_W3CTestConverter.__init__):
2559         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2560
2561 2015-01-16  Daniel Bates  <dabates@apple.com>
2562
2563         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2564         https://bugs.webkit.org/show_bug.cgi?id=135589
2565
2566         Reviewed by David Kilzer.
2567
2568         Derived from a patch by David Farler.
2569
2570         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2571         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2572         in terms of the simctl command line utility.
2573
2574         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2575         (eraseIOSSimulatorDevice): Added.
2576         (bootedIOSSimulatorDevice): Added.
2577         (iosSimulatorApplicationsPath): Added.
2578         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2579         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2580         (quitIOSSimulator): Added.
2581         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2582         the specified name and currently selected iOS runtime.
2583         (isIOSSimulatorSystemInstalledApp): Added.
2584         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2585         (deleteiOSSimulatorDevice): Deleted.
2586         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2587         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2588
2589 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2590
2591         Resurrect the WinCairo bot.
2592         https://bugs.webkit.org/show_bug.cgi?id=139908
2593
2594         Reviewed by Csaba Osztrogonác.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/config.json:
2597         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2598         (appendCustomBuildFlags):
2599         * BuildSlaveSupport/test-result-archive:
2600         (archiveTestResults):
2601         Add WinCairo buildbot.
2602
2603 2015-01-16  Chris Dumez  <cdumez@apple.com>
2604
2605         webkit-patch should auto-install the keyring python module
2606         https://bugs.webkit.org/show_bug.cgi?id=140547
2607
2608         Reviewed by David Kilzer.
2609
2610         Auto-install the keyring python module. This is the module that
2611         webkit-patch uses for cross-platform access to the keyring
2612         service.
2613
2614         Without this module, if the password if not in the keychain,
2615         webkit-patch will keep asking for your username / password and
2616         never remember them.
2617
2618         * Scripts/webkitpy/common/net/credentials.py:
2619         * Scripts/webkitpy/thirdparty/__init__.py:
2620         (AutoinstallImportHook.find_module):
2621         (AutoinstallImportHook._install_keyring):
2622
2623 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2624
2625         Remove ENABLE(SQL_DATABASE) guards
2626         https://bugs.webkit.org/show_bug.cgi?id=140434
2627
2628         Reviewed by Darin Adler.
2629
2630         * Scripts/webkitperl/FeatureList.pm:
2631
2632 2015-01-15  Daniel Bates  <dabates@apple.com>
2633
2634         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2635         https://bugs.webkit.org/show_bug.cgi?id=139685
2636         <rdar://problem/19281317>
2637
2638         Reviewed by Simon Fraser.
2639
2640         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2641         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2642
2643         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2644         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2645         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2646         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2647         dumping the test result again. Instead we want DRT to dump the test result synchronously
2648         such that we capture the state of the web page either when the page is loaded or when
2649         window.testRunner.notifyDone() is called.
2650
2651         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2652         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2653         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2654         flush CA transactions to the window.
2655         * DumpRenderTree/mac/DumpRenderTree.mm:
2656         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2657         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2658         (dump): Renamed; formerly named dumpTestResults().
2659         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2660         enabling repaint support on iOS.
2661         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2662         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2663         (dumpTestResults): Deleted.
2664
2665 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2666
2667         [Win] Miscellaneous DRT fixes
2668         https://bugs.webkit.org/show_bug.cgi?id=116562
2669
2670         Reviewed by Tim Horton.
2671
2672         While investigating the cause of several Windows crashes, I found:
2673         (1) Messy conversions to and from BSTR types
2674         (2) Weird mixes of wide-string and narrow string conversions
2675         (3) Passing nullptr to some CoreFoundation routines that do not
2676             permit null arguments.
2677         (4) Commands to link the executable to the VS2005 runtime.
2678
2679         This patch cleans up these issues to improve DRT reliability on
2680         Windows.
2681
2682         * DumpRenderTree/cg/ImageDiffCG.cpp:
2683         (main): Get rid of VS2005 runtime linking.
2684         * DumpRenderTree/win/DumpRenderTree.cpp:
2685         (urlSuitableForTestResult): Protect against being asked
2686         to process an empty URL.
2687         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2688         than converting to/from wchar_t buffers.
2689         (runTest): Simplify string and BSTR handling.
2690         (createWebViewAndOffscreenWindow): Ditto.
2691         (main): Get rid of VS2005 runtime linking.
2692         * DumpRenderTree/win/TestRunnerWin.cpp:
2693         (jsStringRefToWString): Simplify code.
2694         (TestRunner::pathToLocalResource):
2695         (TestRunner::setUserStyleSheetLocation):
2696         * TestWebKitAPI/win/main.cpp: Get rid of
2697         VS2005 runtime linking.
2698         * win/DLLLauncher/DLLLauncherMain.cpp:
2699         (wWinMain): Ditto.
2700
2701 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2702
2703         Stop hardcoding mac-mountainlion in commit queue
2704         https://bugs.webkit.org/show_bug.cgi?id=140492
2705
2706         Reviewed by Anders Carlsson.
2707
2708         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2709         there should be no change in behavior, because:
2710         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2711         using it to create a port object.
2712         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2713         is actually correct to use "mac" for the name there. We only used to get the expected
2714         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2715         for unknown deprecated port names.
2716
2717         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2718
2719 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2720
2721         Create iOS-EWS server queue
2722         https://bugs.webkit.org/show_bug.cgi?id=140473
2723
2724         Reviewed by Benjamin Poulain.
2725
2726         * QueueStatusServer/app.yaml: Updates the SVN version number.
2727         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2728         * QueueStatusServer/model/queues.py:         
2729         (Queue.display_name): Makes sure the display name is pretty!
2730
2731 2015-01-14  Daniel Bates  <dabates@apple.com>
2732
2733         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2734         https://bugs.webkit.org/show_bug.cgi?id=140301
2735         <rdar://problem/19389266>
2736
2737         Reviewed by Jon Honeycutt.
2738
2739         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2740         with an unavailable runtime.
2741
2742         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2743         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2744         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2745         specified runtime cannot be used because it is unavailable.
2746         * Scripts/webkitpy/port/ios.py:
2747         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2748         which was formerly named testing_device.
2749         * Scripts/webkitpy/xcode/simulator.py:
2750         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2751         more robust than looking up the simulator device by name and runtime. This approach also
2752         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2753         unavailable runtimes under the same iOS heading it would use to show it as available).
2754         (Simulator.find_device_by_udid): Added.
2755         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2756         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2757         (Simulator.available_runtimes): Added.
2758         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2759         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2760         first element of the sorted list is the runtime with the highest version number.
2761         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2762
2763 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2764
2765         Remove WK2 Windows cruft
2766         https://bugs.webkit.org/show_bug.cgi?id=140440
2767
2768         Reviewed by Anders Carlsson.
2769
2770         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2771         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2772         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2773
2774 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2775
2776         Fix TestWTF failed in TestWebKitAPI
2777         https://bugs.webkit.org/show_bug.cgi?id=140333
2778
2779         Reviewed by Sam Weinig.
2780
2781         Clear the std::ostringstream before starting test.
2782
2783         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2784         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2785
2786 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2787
2788         TestWebKitWebContext depends on British English spellcheck dictionary
2789         https://bugs.webkit.org/show_bug.cgi?id=140403
2790
2791         Reviewed by Martin Robinson.
2792
2793         Install all English hunspell dictionaries on Fedora and Arch.
2794
2795         * gtk/install-dependencies:
2796
2797 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2798
2799         [GTK] install-dependencies should grok dnf
2800         https://bugs.webkit.org/show_bug.cgi?id=140396
2801
2802         Reviewed by Martin Robinson.
2803
2804         Fedora: install dependencies with dnf if yum is not installed.
2805
2806         * gtk/install-dependencies:
2807
2808 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2809
2810         [EFL][GTK] Fix build after r178309  
2811         https://bugs.webkit.org/show_bug.cgi?id=140381
2812
2813         Reviewed by Gyuyoung Kim.
2814
2815         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2816
2817 2015-01-11  Sam Weinig  <sam@webkit.org>
2818
2819         Remove support for SharedWorkers
2820         https://bugs.webkit.org/show_bug.cgi?id=140344
2821
2822         Reviewed by Anders Carlsson.
2823
2824         * Scripts/webkitperl/FeatureList.pm:
2825
2826 2015-01-12  Anders Carlsson  <andersca@apple.com>
2827
2828         Make delegates conform to formal delegate protocols
2829         https://bugs.webkit.org/show_bug.cgi?id=140370
2830
2831         Reviewed by Dan Bernstein.
2832
2833         * DumpRenderTree/mac/TestRunnerMac.mm:
2834         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2835         (TestRunner::setGeolocationPermission):
2836
2837 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2838
2839         build-webkit: silence output of 'which'
2840         https://bugs.webkit.org/show_bug.cgi?id=140278
2841
2842         Reviewed by Daniel Bates.
2843
2844         Use a more elegent test for the existance of ninja and eclipse.
2845
2846         * Scripts/webkitdirs.pm:
2847         (commandExists): Don't assume the command supports --version
2848         (canUseNinja): Use commandExists()
2849         (canUseEclipse): Use commandExists()
2850
2851 2015-01-09  Sam Weinig  <sam@webkit.org>
2852
2853         Update the output format for run-api-tests
2854         https://bugs.webkit.org/show_bug.cgi?id=140332
2855
2856         Reviewed by Dan Bernstein.
2857
2858         Changes the output format for run-api-tests be a bit simpler (no longer 
2859         indented based on suite, as we were not really using suite very well) but
2860         also include details in the case of failure.
2861
2862         Changes verbose mode to no longer spew out the gtest default printer output,
2863         as the custom printer now includes the failure information.
2864
2865         * Scripts/run-api-tests:
2866         (runTestsBySuite):
2867         (runTest):
2868         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
2869         with colorized variants and strip out leaks spew (the leaks can be added back using
2870         the new --show-leaks argument).
2871
2872         * TestWebKitAPI/TestsController.cpp:
2873         (TestWebKitAPI::Printer::OnTestPartResult):
2874         (TestWebKitAPI::Printer::OnTestEnd):
2875         (TestWebKitAPI::TestsController::run):
2876         Implement a custom result printer that just prints out the information we want.
2877
2878 2015-01-09  Sam Weinig  <sam@webkit.org>
2879
2880         TestWebKitAPI should print out the lists that fail at the end
2881         https://bugs.webkit.org/show_bug.cgi?id=140329
2882
2883         Reviewed by Tim Horton.
2884
2885         * Scripts/run-api-tests:
2886         (runTestsBySuite):
2887         Print out failures and timeouts in all modes, not just verbose.
2888
2889 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
2890
2891         Make bmalloc work with ASan
2892         https://bugs.webkit.org/show_bug.cgi?id=140194
2893
2894         Reviewed by Mark Lam.
2895
2896         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
2897         ASan automatically (by forwarding to system malloc at runtime).
2898
2899 2015-01-09  Daniel Bates  <dabates@apple.com>
2900
2901         [iOS] Make DumpRenderTree build with public SDK
2902         https://bugs.webkit.org/show_bug.cgi?id=140311
2903
2904         Reviewed by Sam Weinig.
2905
2906         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
2907         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
2908         Additionally, remove unused header CoreGraphics/CGFontDB.h.
2909
2910         * DumpRenderTree/mac/DumpRenderTree.mm:
2911         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
2912
2913 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
2914
2915         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
2916         https://bugs.webkit.org/show_bug.cgi?id=140300
2917
2918         Reviewed by Simon Fraser.
2919
2920         * WebKitTestRunner/TestController.cpp:
2921         (WTR::TestController::createOtherPage):
2922         (WTR::TestController::updateWindowScaleForTest):
2923         (WTR::TestController::configureViewForTest):
2924         * WebKitTestRunner/TestController.h:
2925
2926 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2927
2928         Unreviewed. Moving myself to the committer section.
2929
2930         * Scripts/webkitpy/common/config/contributors.json:
2931
2932 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2933
2934         Add a script to check for platform layering violations
2935         https://bugs.webkit.org/show_bug.cgi?id=140248
2936
2937         Reviewed by Darin Adler.
2938
2939         It prints all the cases where files inside platform include
2940         headers that are not in platform directory.
2941
2942         * Scripts/check-for-platform-layering-violations: Added.
2943         (get_platform_headers):
2944         (check_source_file):
2945
2946 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2947
2948         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
2949         https://bugs.webkit.org/show_bug.cgi?id=139884
2950
2951         Reviewed by Tim Horton.
2952
2953         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2954         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
2955         what the "nominal resolution" is, but this appears to work in practice.
2956
2957 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
2958
2959         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
2960         https://bugs.webkit.org/show_bug.cgi?id=140256
2961
2962         Reviewed by Anders Carlsson.
2963
2964         * DumpRenderTree/win/DumpRenderTree.cpp:
2965         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
2966         running with heap validation checks.
2967         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
2968         the "svg\\W3C-SVG-1.1" test directory.
2969         (removeFontFallbackIfPresent): Use nullptr instead of 0.
2970         * DumpRenderTree/win/TestRunnerWin.cpp:
2971         (TestRunner::clearPersistentUserStyleSheet): Ditto.
2972
2973 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2974
2975         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2976         https://bugs.webkit.org/show_bug.cgi?id=140218
2977
2978         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
2979         Undone an accidental change - check for self.has_crashed() again. This code path
2980         is for ports that don't have a signal handler printing #CRASHED when main process
2981         crashes.
2982
2983         * Scripts/webkitpy/port/driver_unittest.py:
2984         (DriverTest.test_check_for_driver_crash.assert_crash):
2985         (DriverTest.test_check_for_driver_crash):
2986         Updated the tests, all changes are expected.
2987
2988 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2989
2990         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2991         https://bugs.webkit.org/show_bug.cgi?id=140218
2992
2993         Reviewed by Darin Adler.
2994
2995         * Scripts/webkitpy/port/driver.py:
2996         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
2997         "process crashed" condition. These don't make sense together - it's either a crash
2998         or a timeout, and we should detect those properly at a much lower level.
2999         (Driver.run_test): Ditto.
3000         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3001         cases.
3002
3003         * WebKitTestRunner/TestController.h:
3004         * WebKitTestRunner/TestController.cpp:
3005         (WTR::TestController::webProcessName): 
3006         (WTR::TestController::processDidCrash):
3007         Factored out hardcoded child process names, as we now use these in two places.
3008
3009         * WebKitTestRunner/TestInvocation.cpp:
3010         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3011         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3012
3013 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3014
3015         Reorder my list of email addresses, keeping the Bugzilla address at the
3016         top since Bugzilla and other webkitpy scripts rely on that ordering.
3017
3018         * Scripts/webkitpy/common/config/contributors.json:
3019
3020 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3021
3022         Moving myself to the reviewers section and updating
3023         the list of my email addresses.
3024
3025         * Scripts/webkitpy/common/config/contributors.json:
3026
3027 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3028
3029         [GTK] Build gtk-doc without gtkdoc-mktmpl
3030         https://bugs.webkit.org/show_bug.cgi?id=140225
3031
3032         Reviewed by Darin Adler.
3033
3034         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3035         don't modify the tmpl files that it generates, it's not doing anything
3036         for us.
3037
3038         * gtk/gtkdoc.py:
3039         (GTKDoc.generate):
3040         (GTKDoc._run_gtkdoc_scangobj):
3041         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3042
3043 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3044
3045         [GTK][ThreadedCompositor] Add support for threaded compositor.
3046         https://bugs.webkit.org/show_bug.cgi?id=118265
3047
3048         Reviewed by Martin Robinson.
3049
3050         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3051         autotools build systems. The feature is disabled by default.
3052         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3053         from the feature flags.
3054
3055         * Scripts/webkitperl/FeatureList.pm:
3056
3057 2015-01-07  Daniel Bates  <dabates@apple.com>
3058
3059         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3060         https://bugs.webkit.org/show_bug.cgi?id=137371
3061
3062         Reviewed by David Kilzer.
3063
3064         Use SPI wrapper headers instead of directly referencing private SPI headers.
3065
3066         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3067         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3068         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3069         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3070         * DumpRenderTree/mac/DumpRenderTree.mm:
3071         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3072         * DumpRenderTree/mac/EventSendingController.mm:
3073         * DumpRenderTree/mac/TestRunnerMac.mm:
3074
3075 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3076
3077         Unreviewed, rolling out r178068.
3078         https://bugs.webkit.org/show_bug.cgi?id=140235
3079
3080         Breaks the iOS build (Requested by enrica on #webkit).
3081
3082         Reverted changeset:
3083
3084         "[iOS] Make WebKit2 build with public iOS SDK and more build
3085         fixes for DRT"
3086         https://bugs.webkit.org/show_bug.cgi?id=137371
3087         http://trac.webkit.org/changeset/178068
3088
3089 2015-01-07  Daniel Bates  <dabates@apple.com>
3090
3091         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3092         https://bugs.webkit.org/show_bug.cgi?id=137371
3093
3094         Reviewed by David Kilzer.
3095
3096         Use SPI wrapper headers instead of directly referencing private SPI headers.
3097
3098         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3099         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3100         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3101         to the list of header search directories so that we can include header UIKitSPI.h.
3102         * DumpRenderTree/mac/DumpRenderTree.mm:
3103         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3104         * DumpRenderTree/mac/EventSendingController.mm:
3105         * DumpRenderTree/mac/TestRunnerMac.mm:
3106
3107 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3108
3109         [Win] Unreviewed test change to improve run reproducibility
3110
3111         * Scripts/webkitpy/port/win.py:
3112         (WinPort.default_child_processes): Run a single DRT instance to help
3113         identify failures caused by earlier test runs.
3114
3115 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3116
3117         Myles C. Maxfield is a reviewer now
3118         https://bugs.webkit.org/show_bug.cgi?id=140196
3119
3120         Reviewed by Dean Jackson.
3121
3122         * Scripts/webkitpy/common/config/contributors.json:
3123
3124 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3125
3126         Make webkit-patch try harder to find keychain credentials
3127         https://bugs.webkit.org/show_bug.cgi?id=140170
3128
3129         Reviewed by Ryosuke Niwa.
3130
3131         When the user manually enters a password into webkit-patch, we hand that off to the
3132         Keyring Python module. However, that module creates a generic password entry instead
3133         of an internet password entry. We should look for both kinds.
3134
3135         * Scripts/webkitpy/common/net/credentials.py:
3136         (Credentials._run_security_tool):
3137         (Credentials._credentials_from_keychain):
3138         * Scripts/webkitpy/common/net/credentials_unittest.py:
3139         (test_security_output_parse_entry_not_found):
3140         (_assert_security_call):
3141
3142 2015-01-06  Anders Carlsson  <andersca@apple.com>
3143
3144         Try to fix the Mountain Lion build.
3145
3146         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3147         (TestWebKitAPI::didGetImageForMatchResult):
3148
3149 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3150
3151         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3152         https://bugs.webkit.org/show_bug.cgi?id=140095
3153
3154         Reviewed by Anders Carlsson.
3155
3156         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3157         builds, but not in debug ones.
3158
3159 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3160
3161         [Win] Extend WinLauncher with support for Page Zoom
3162         https://bugs.webkit.org/show_bug.cgi?id=140152
3163
3164         Reviewed by Anders Carlsson.
3165
3166         * WinLauncher/Common.cpp:
3167         (WndProc):
3168         * WinLauncher/WinLauncher.cpp:
3169         (WinLauncher::resetZoom):
3170         (WinLauncher::zoomIn):
3171         (WinLauncher::zoomOut):
3172         * WinLauncher/WinLauncher.h:
3173         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3174         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3175         * win/DLLLauncher/DLLLauncherMain.cpp:
3176         (wWinMain):
3177
3178 2015-01-06  Anders Carlsson  <andersca@apple.com>
3179
3180         Fix API tests that are broken under HiDPI
3181         https://bugs.webkit.org/show_bug.cgi?id=140146
3182
3183         Reviewed by Tim Horton.
3184
3185         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3186         (TestWebKitAPI::didGetImageForMatchResult):
3187         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3188
3189         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3190         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3191         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3192         out in a window that has a backing scale factor of 1.
3193  
3194         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3195         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3196         Ditto.
3197
3198 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3199
3200         ADDRESS_SANITIZER macro is overloaded
3201         https://bugs.webkit.org/show_bug.cgi?id=140130
3202
3203         Reviewed by Anders Carlsson.
3204
3205         * WebKitTestRunner/TestController.cpp: Use the new macro.
3206
3207 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3208
3209         Remove some stale class names in check-for-inappropriate-objc-class-names
3210         https://bugs.webkit.org/show_bug.cgi?id=140104
3211
3212         Reviewed by Darin Adler.
3213
3214         * Scripts/check-for-inappropriate-objc-class-names:
3215         These UIWK* classes no longer exist.
3216
3217 2015-01-05  Anders Carlsson  <andersca@apple.com>
3218
3219         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3220         https://bugs.webkit.org/show_bug.cgi?id=140096
3221         rdar://problem/19368938
3222
3223         Reviewed by Alexey Proskuryakov.
3224
3225         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3226         since clientInfo points to a web view, not the test controller.
3227
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::createOtherPage):
3230
3231 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3232
3233         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3234         https://bugs.webkit.org/show_bug.cgi?id=140077
3235
3236         Reviewed by Csaba Osztrogonác.
3237
3238         WebKit C SPI is available on EFL,GTK.
3239         Changed the define order to pass the API test.
3240
3241         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3242         (TestWebKitAPI::TEST):
3243
3244 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3245
3246         Simplify WebKitTestRunner timeout tracking
3247         https://bugs.webkit.org/show_bug.cgi?id=140036
3248
3249         Reviewed by Darin Adler.
3250
3251         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3252         passes the --timeout option to WebKitTestRunner.
3253
3254         * WebKitTestRunner/Options.h:
3255         * WebKitTestRunner/Options.cpp:
3256         (WTR::Options::Options):
3257         (WTR::OptionsHandler::OptionsHandler):
3258         (WTR::handleOptionTimeout): Deleted.
3259         Removed support for --timeout. Timeouts are passed for each test individually,
3260         and defaults are good enough for the rare cases where WebKitTestRunner is run
3261         manually without run-webkit-tests.
3262
3263         * WebKitTestRunner/TestController.cpp:
3264         (WTR::TestController::TestController):
3265         (WTR::TestController::initialize):
3266         (WTR::TestController::resetStateToConsistentValues):
3267         (WTR::TestController::reattachPageToWebProcess):
3268         (WTR::TestController::runUntil):
3269         * WebKitTestRunner/TestController.h:
3270         Simplified runUntil by passing the actual timeout, not an enum.
3271         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3272         quite a while.
3273
3274         * WebKitTestRunner/TestInvocation.cpp:
3275         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3276
3277         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3278         (WTR::TestController::platformRunUntil):
3279         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3280         (WTR::TestController::platformRunUntil):
3281         Build fixes.
3282
3283 2015-01-02  Anders Carlsson  <andersca@apple.com>
3284
3285         Remove now unused storage tracker glue from DumpRenderTree
3286         https://bugs.webkit.org/show_bug.cgi?id=140045
3287
3288         Reviewed by Darin Adler.
3289
3290         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3291         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3292         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3293         * DumpRenderTree/TestRunner.cpp:
3294         (TestRunner::staticFunctions):
3295         (syncLocalStorageCallback): Deleted.
3296         (observeStorageTrackerNotificationsCallback): Deleted.
3297         (deleteAllLocalStorageCallback): Deleted.
3298         (deleteLocalStorageForOriginCallback): Deleted.
3299         (localStorageDiskUsageForOriginCallback): Deleted.
3300         (originsWithLocalStorageCallback): Deleted.
3301         * DumpRenderTree/TestRunner.h:
3302         * DumpRenderTree/mac/DumpRenderTree.mm:
3303         (allocateGlobalControllers):
3304         (releaseGlobalControllers):
3305         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3306         * DumpRenderTree/mac/TestRunnerMac.mm:
3307         (TestRunner::syncLocalStorage): Deleted.
3308         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3309         (TestRunner::observeStorageTrackerNotifications): Deleted.
3310         (TestRunner::deleteAllLocalStorage): Deleted.
3311         (TestRunner::originsWithLocalStorage): Deleted.
3312         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3313         * DumpRenderTree/win/TestRunnerWin.cpp:
3314         (TestRunner::syncLocalStorage): Deleted.
3315         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3316         (TestRunner::observeStorageTrackerNotifications): Deleted.
3317         (TestRunner::deleteAllLocalStorage): Deleted.
3318         (TestRunner::originsWithLocalStorage): Deleted.
3319         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3320
3321 2015-01-01  Darin Adler  <darin@apple.com>
3322
3323         We often misspell identifier as "identifer"
3324         https://bugs.webkit.org/show_bug.cgi?id=140025
3325
3326         Reviewed by Michael Saboff.
3327
3328         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3329         * Scripts/webkitdirs.pm:
3330         (appIdentifierFromBundle):
3331         (installAndLaunchIOSWebKitAppInSimulator):
3332         Fix misspellings
3333
3334 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3335
3336         Saturated arithmetics: Incorrect float/double clamping.
3337         https://bugs.webkit.org/show_bug.cgi?id=139888
3338         rdar://problem/19330885
3339
3340         Reviewed by Simon Fraser.
3341
3342         Clamp float and double values correctly when applying saturated arithmetics.
3343
3344         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3345         (TestWebKitAPI::TEST):
3346
3347 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3348
3349         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3350         https://bugs.webkit.org/show_bug.cgi?id=139816
3351
3352         Reviewed by Gyuyoung Kim.
3353
3354         Bump version of ATK used by jhbuild to 2.15.2
3355
3356         * efl/jhbuild.modules:
3357
3358 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3359
3360         [jhBuild] cairo build error (-flto)
3361         https://bugs.webkit.org/show_bug.cgi?id=139056
3362
3363         Reviewed by Philippe Normand.
3364
3365         cairo fails to link  with gcc 4.9 due to lto
3366         related issue. This problem has been partially
3367         addressed by cairo:
3368         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3369         use the cairo --disable-lto option and remove jhbuild
3370         makeargs fixes the issue.
3371
3372         * gtk/jhbuild.modules:
3373         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3374
3375 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3376         [Mac] Enable kerning, ligatures, and printer fonts 
3377         https://bugs.webkit.org/show_bug.cgi?id=139970
3378
3379         Rubber stamped by Simon Fraser.
3380
3381         Flip the switch.
3382
3383         * DumpRenderTree/mac/DumpRenderTree.mm:
3384         * WebKitTestRunner/TestController.cpp:
3385         * WebKitTestRunner/mac/main.mm:
3386
3387 2014-12-26  Dan Bernstein  <mitz@apple.com>
3388
3389         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3390         https://bugs.webkit.org/show_bug.cgi?id=139950
3391
3392         Reviewed by David Kilzer.
3393
3394         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3395         in a manner that works with Xcode 5.1.1.
3396
3397 2014-12-24  Dan Bernstein  <mitz@apple.com>
3398
3399         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3400         https://bugs.webkit.org/show_bug.cgi?id=139941
3401
3402         Reviewed by Darin Adler.
3403
3404         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3405         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3406         to YES.
3407         * MiniBrowser/mac/AppDelegate.m:
3408         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3409         deprecated NSOKButton.
3410
3411 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3412
3413         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3414         https://bugs.webkit.org/show_bug.cgi?id=134763
3415
3416         Reviewed by Ryosuke Niwa.
3417
3418         Adding an option to disable test harness link conversion.
3419
3420         * Scripts/webkitpy/w3c/test_converter.py:
3421         (convert_for_webkit):
3422         (_W3CTestConverter.__init__):
3423         (_W3CTestConverter.convert_attributes_if_needed):
3424         * Scripts/webkitpy/w3c/test_importer.py:
3425         (parse_args):
3426         (TestImporter.import_tests):
3427
3428 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3429
3430         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3431         https://bugs.webkit.org/show_bug.cgi?id=139933
3432
3433         Reviewed by Daniel Bates.
3434
3435         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3436         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3437         until ReportCrash lets it go.
3438
3439         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3440         even get the actual crash log eventually - even when it times out waiting for the log, it
3441         makes a second lookup at the very end, after all tests finish. There may be further
3442         improvements needed here, but this small fix addresses most cases that happen in practice.
3443
3444         * DumpRenderTree/mac/DumpRenderTree.mm:
3445         (writeCrashedMessageOnFatalError):
3446         (dumpRenderTree):
3447         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3448
3449         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3450         unhelpful comment.
3451
3452 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3453
3454         Don't force -O1 for debug ASan builds
3455         https://bugs.webkit.org/show_bug.cgi?id=139926
3456
3457         Reviewed by Darin Adler.
3458
3459         * asan/asan.xcconfig:
3460
3461 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3462
3463         Simplify building with ASan
3464         https://bugs.webkit.org/show_bug.cgi?id=139916
3465
3466         Reviewed by Mark Rowe.
3467
3468         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3469         We could also update Configuration file format, but that's a little scary because
3470         of how many places in code read it.
3471
3472         * Scripts/webkitdirs.pm:
3473         (determineASanIsEnabled): Read it from ASan configuration file.
3474         (argumentsForConfiguration): Added a FIXME.
3475         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3476         (XcodeOptions): Pass the options needed for ASan.
3477
3478         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3479         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3480         that automatically.
3481
3482 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3483
3484         TestWebKitAPI build is broken when ASan is enabled
3485         https://bugs.webkit.org/show_bug.cgi?id=139902
3486
3487         Reviewed by Darin Adler.
3488
3489         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3490         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
3491         Inherit linker flags from DebugRelease, which respects ASAN.
3492
3493 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
3494
3495         Sort the Xcode project file.
3496
3497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3498
3499 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3500
3501         Update apple-mac-114 to bot629.
3502         
3503         Unreviewed.
3504         
3505         * BuildSlaveSupport/build.webkit.org-config/config.json:
3506
3507 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3508
3509         Replace Apple bot104 with bot124.
3510         
3511         Unreviewed.
3512         
3513         * BuildSlaveSupport/build.webkit.org-config/config.json:
3514
3515 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3516
3517         URTBF after r177639.
3518
3519         * TestWebKitAPI/CMakeLists.txt:
3520
3521 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3522
3523         [EFL] MiniBrowser steals web view's focus
3524         https://bugs.webkit.org/show_bug.cgi?id=139482
3525
3526         Reviewed by Gyuyoung Kim.
3527
3528         Although we set focus on ewk_view while MiniBrowser initialization
3529         Ecore steals it in a favor of main window. As a result
3530         focused element on web page is unable to receive events.
3531
3532         * MiniBrowser/efl/main.c:
3533         (window_create):
3534         Prevent window from stealing web view's focus on start up.
3535
3536 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3537
3538         [Win] Revise DRT logic to match Mac.
3539
3540         Rubberstamped by Anders Carlsson.
3541
3542         Update the Windows logic to perform initialization of preferences and WebKit
3543         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
3544         the same circumstances as the Mac version.
3545
3546         * DumpRenderTree/win/DumpRenderTree.cpp:
3547         (dump):
3548         (resetWebPreferencesToConsistentValues):
3549         (setDefaultsToConsistentValuesForTesting):
3550         (resetWebViewToConsistentStateBeforeTesting):
3551         (sizeWebViewForCurrentTest):
3552         (runTest):
3553         (createWebViewAndOffscreenWindow):
3554         (allocateGlobalControllers):
3555         (prepareConsistentTestingEnvironment):
3556         (main):
3557         (resetDefaultsToConsistentValues): Deleted.
3558
3559 2014-12-19  Roger Fong  <roger_fong@apple.com>
3560
3561         Unreviewed. Rollout r177605.
3562
3563         * EWSTools/start-queue-win.sh:
3564
3565 2014-12-19  Roger Fong  <roger_fong@apple.com>
3566
3567         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
3568
3569         * EWSTools/start-queue-win.sh:
3570
3571 2014-12-19  Daniel Bates  <dabates@apple.com>
3572
3573         [iOS] Add WebKitSystemInterface for iOS 8.1
3574         https://bugs.webkit.org/show_bug.cgi?id=139831
3575
3576         Reviewed by Alexey Proskuryakov.
3577
3578         Implement support in copy-webkitlibraries-to-product-directory to copy
3579         WebKitSystemInterface for iOS to the product directory and have build-webkit
3580         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
3581
3582         * Scripts/build-webkit:
3583         * Scripts/copy-webkitlibraries-to-product-directory:
3584
3585 2014-12-19  Daniel Bates  <dabates@apple.com>
3586
3587         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
3588         https://bugs.webkit.org/show_bug.cgi?id=139829
3589
3590         Reviewed by Alexey Proskuryakov.
3591
3592         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
3593         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
3594         expects the Xcode SDK to be specified using the --sdk-name command line argument.
3595
3596         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
3597         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
3598         logic to both avoid duplicating effort and make the command line options for
3599         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
3600         with the approach used in other WebKit tools.
3601
3602         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
3603         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
3604         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
3605
3606         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
3607         improve the readability of the code.
3608         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
3609         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
3610         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
3611         be included in a library.
3612         (unpackIfNecessary): Modified to call executeRanlib().
3613
3614 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3615
3616         REGRESSION (177368): Some tests started to immediately time out
3617         https://bugs.webkit.org/show_bug.cgi?id=139826
3618
3619         Reviewed by Daniel Bates.
3620
3621         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3623         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3624         ends in a load failure, we don't dump, so we used to leak the timer.
3625         
3626         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3627         Added a comment.
3628
3629 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3630
3631         [Win] Add accessor for serializing HTTP loads
3632         https://bugs.webkit.org/show_bug.cgi?id=139817
3633
3634         Reviewed by Mark Lam.
3635
3636         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3637         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3638         remove some redundant code from the destructor.
3639
3640 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3641
3642         Clean up a fix for performance test bot failing to build
3643         https://bugs.webkit.org/show_bug.cgi?id=139818
3644
3645         Reviewed by Csaba Osztrogonác.
3646
3647         The "_1" in step name was annoying.
3648
3649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3650         (CleanBuildIfScheduled.start):
3651         (RunAndUploadPerfTests):
3652         (DownloadAndPerfTestFactory.__init__):
3653         (DownloadAndPerfTestWebKit2Factory.__init__):
3654         (CleanBuildUnconditionally): Deleted.
3655         (CleanBuildUnconditionally.start): Deleted.
3656
3657 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
3658
3659         REGRESSION(r177535): It broke the GTK performance bot
3660         https://bugs.webkit.org/show_bug.cgi?id=139811