Adjust naming of action menu SPI
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2
3         Adjust naming of action menu SPI
4         https://bugs.webkit.org/show_bug.cgi?id=140644
5         <rdar://problem/19448129>
6
7         Reviewed by Brian Weinstein.
8
9         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
10         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
11         (TestWebKitAPI::TEST):
12
13 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
14
15         [GTK] Generate the make dist manifest from a CMake template file
16         https://bugs.webkit.org/show_bug.cgi?id=139387
17
18         Reviewed by Martin Robinson.
19
20         Remove the code that performs variable substitution on manifest.txt.
21         Replace the custom variables used in that file with CMake variables.
22
23         * gtk/make-dist.py:
24         (Manifest.add_directory):
25         (Manifest.get_full_source_path):
26         (Manifest.process_line):
27         (Manifest.resolve_variables): Deleted.
28         (Manifest.get_full_tarball_path): Deleted.
29         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
30
31 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
32
33         [Win] Correct merge error in last commit.
34
35         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
36         (findAccessibleObjectById): Undo accidental paste made during landing.
37
38 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
39
40         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
41         https://bugs.webkit.org/show_bug.cgi?id=139906
42
43         Reviewed by Dean Jackson.
44
45         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
46         to use them. This patch fixes that.
47
48         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
49         (findAccessibleObjectById):
50         (AccessibilityController::focusedElement):
51         (logEventProc):
52         (notificationListenerProc):
53         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
54         (AccessibilityUIElement::getChildAtIndex):
55         (AccessibilityUIElement::titleUIElement):
56         (self):
57         (AccessibilityUIElement::role):
58         (AccessibilityUIElement::valueDescription):
59         (accessibilityState):
60         (AccessibilityUIElement::isChecked):
61         * DumpRenderTree/win/DumpRenderTree.cpp:
62         (dumpFrameScrollPosition):
63         (dumpFramesAsText):
64         * DumpRenderTree/win/PolicyDelegate.cpp:
65         (PolicyDelegate::decidePolicyForNavigationAction):
66         * DumpRenderTree/win/UIDelegate.cpp:
67         (UIDelegate::exceededDatabaseQuota):
68         * WinLauncher/Common.cpp:
69         (setWindowText):
70
71 2015-01-19  Dean Jackson  <dino@apple.com>
72
73         Add "override" to fix the build with newer clangs.
74
75         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
76         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
77
78 2015-01-19  David Kilzer  <ddkilzer@apple.com>
79
80         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
81         <http://webkit.org/b/140623>
82
83         Reviewed by Daniel Bates.
84
85         * Scripts/build-webkit: Update help for --device switch.
86         * Scripts/webkitdirs.pm:
87         (determineXcodeSDK): When passing --device, prefer the internal
88         iOS SDK if it exists, else fall back to the external iOS SDK.
89         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
90         xcodebuild instead of trying to sanitize values.
91
92 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
93
94         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
95         https://bugs.webkit.org/show_bug.cgi?id=140606
96
97         Reviewed by Csaba Osztrogonác.
98
99         * Scripts/webkitpy/bindings/main.py:
100         (BindingsTests.generate_supplemental_dependency):
101         (BindingsTests.main):
102
103 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         [GTK] [WK2] TestWebKitWebView snapshot fails
106         https://bugs.webkit.org/show_bug.cgi?id=120404
107
108         Reviewed by Žan Doberšek.
109
110         Rework the test to make sure the snapshot is always created at the
111         desired size.
112
113         * Scripts/run-gtk-tests:
114         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
116         (testWebViewSnapshot): Use a fixed size for the document, and
117         disable scrollbars to make sure the visible area is always the
118         WebView size.
119         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
120         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
121         and height parameters to create the window with a given size.
122         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
123
124 2015-01-18  David Kilzer  <ddkilzer@apple.com>
125
126         iOS EWS queue name should be consistent
127         <http://webkit.org/b/140585>
128
129         Reviewed by Daniel Bates.
130
131         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
132         to 'ios'.
133         * Scripts/webkitpy/common/config/ports.py: Ditto.
134         (DeprecatedPort.port):
135         (IOSPort):
136         * Scripts/webkitpy/port/ios.py: Ditto.
137         (IOSPort):
138
139         * Scripts/webkitpy/port/factory.py:
140         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
141         appears before ios.IOSPort.  If this is not done,
142         `run-webkit-tests --ios-simulator` will get the wrong Port class
143         (IOSPort instead of IOSSimulatorPort) due to the way that
144         PortFactory.get() uses prefix matching of <Port>.port_name to
145         find the correct class to use.
146
147 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
148
149         build.webkit.org/dashboard: OS X EWS is now on Mavericks
150         https://bugs.webkit.org/show_bug.cgi?id=140595
151
152         Reviewed by Csaba Osztrogonác.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
155         (BubbleQueueServer):
156
157 2015-01-17  David Kilzer  <ddkilzer@apple.com>
158
159         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
160
161         * Scripts/webkitpy/port/ios.py:
162         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
163         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
164         the Mountain Lion and Mavericks bots.
165
166 2015-01-17  David Kilzer  <ddkilzer@apple.com>
167
168         Attempt to fix webkitpy tests on GTK Linux ports
169
170         * Scripts/webkitpy/port/ios.py:
171         (IOSPort.determine_full_port_name): Set a sensible default if
172         not running on a Mac platform or if no iOS SDK is installed.
173
174 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
175
176         Create iOS-EWS client queue
177         https://bugs.webkit.org/show_bug.cgi?id=140476
178
179         Reviewed by Alexey Proskuryakov.
180
181         * EWSTools/start-queue-mac.sh:
182         Adds call to configure-xcode-for-ios-development for iOS EWS.
183         * Scripts/webkitpy/common/config/ews.json:
184         Adds the iOS EWS config entry.
185         * Scripts/webkitpy/common/config/ports.py:
186         (DeprecatedPort.port):
187         Adds IOSPort to the port map.
188         (IOSPort):
189         (IOSPort.build_webkit_command):
190         Adds --sdk=iphoneos to the webkit build command.
191         * Scripts/webkitpy/port/base.py:
192         (Port.architecture):
193         Adds an accessor for the architecture member variable.
194         * Scripts/webkitpy/port/factory.py:
195         (PortFactory):
196         Adds IOSPort to the port class list.
197         * Scripts/webkitpy/port/ios.py:
198         Adds the IOSPort to encapsulate iOS-specific things.
199         (IOSPort):
200         (IOSPort.determine_full_port_name):
201         (IOSPort.__init__):
202         (IOSPort._build_driver_flags):
203         (IOSPort.operating_system):
204         * Scripts/webkitpy/tool/commands/download_unittest.py:
205         Adds the archetecture option to the mock options.
206         (DownloadCommandsTest._default_options):
207         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
208         Appends the archetecture option into calls to webkit-patch.
209         (AbstractEarlyWarningSystem.review_patch):
210         (AbstractEarlyWarningSystem.run_command):
211         (AbstractEarlyWarningSystem.load_ews_classes):
212         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
213         Adds logic to soothe the unittest now that --architecture is being
214         thrown around everywhere.
215         (EarlyWarningSystemTest._default_expected_logs):
216         * Scripts/webkitpy/tool/commands/queues.py:
217         Adds glue code to ferry the --architecture option around.
218         (AbstractQueue.__init__):
219         (PatchProcessingQueue.begin_work_queue):
220         * Scripts/webkitpy/tool/steps/abstractstep.py:
221         Adds the archetecture option to all AbstractSteps so that
222         EarlyWarningSystem doesn't start shoving --architecture into
223         unsuspecting commands.
224         (AbstractStep.options):
225         * Scripts/webkitpy/tool/steps/build.py:
226         Translates the --architecture option into an ARCHS= format to pass to
227         build-webkit.
228         (Build.build):
229         * Scripts/webkitpy/tool/steps/options.py:
230         Adds a definition for the --architecture option.
231         (Options):
232
233 2015-01-16  Sam Weinig  <sam@webkit.org>
234
235         Add a basic configuration object for WKView
236         https://bugs.webkit.org/show_bug.cgi?id=140559
237
238         Reviewed by Anders Carlsson.
239
240         Add tests for WKPageConfigurationRef.
241
242         * TestWebKitAPI/PlatformWebView.h:
243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
244         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
245         (TestWebKitAPI::TEST):
246         (TestWebKitAPI::didFinishLoadForFrame):
247         (TestWebKitAPI::setPageLoaderClient):
248         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
249         (TestWebKitAPI::PlatformWebView::initialize):
250         (TestWebKitAPI::PlatformWebView::PlatformWebView):
251
252 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
253
254         WeakPtr functions crash when created with default constructor
255         https://bugs.webkit.org/show_bug.cgi?id=140479
256
257         Reviewed by Andreas Kling.
258
259         Add WeakPtr API tests.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
263         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
264
265 2015-01-16  Chris Dumez  <cdumez@apple.com>
266
267         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
268         https://bugs.webkit.org/show_bug.cgi?id=140568
269
270         Reviewed by Alexey Proskuryakov.
271
272         Fix the script parsing CSSPropertyNames.in to stop splitting lines
273         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
274         e.g. "Longhands=background-position-x|background-position-y".
275         This would confuse the script and treat this as a CSS property:
276         "background-position-x|background-position-y".
277
278         We now split on white space and treat the first string on the line
279         to be the property name (this is the syntax in this file).
280
281         * Scripts/webkitpy/w3c/test_converter.py:
282         (_W3CTestConverter.__init__):
283         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
284
285 2015-01-16  Daniel Bates  <dabates@apple.com>
286
287         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
288         https://bugs.webkit.org/show_bug.cgi?id=135589
289
290         Reviewed by David Kilzer.
291
292         Derived from a patch by David Farler.
293
294         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
295         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
296         in terms of the simctl command line utility.
297
298         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
299         (eraseIOSSimulatorDevice): Added.
300         (bootedIOSSimulatorDevice): Added.
301         (iosSimulatorApplicationsPath): Added.
302         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
303         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
304         (quitIOSSimulator): Added.
305         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
306         the specified name and currently selected iOS runtime.
307         (isIOSSimulatorSystemInstalledApp): Added.
308         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
309         (deleteiOSSimulatorDevice): Deleted.
310         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
311         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
312
313 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
314
315         Resurrect the WinCairo bot.
316         https://bugs.webkit.org/show_bug.cgi?id=139908
317
318         Reviewed by Csaba Osztrogonác.
319
320         * BuildSlaveSupport/build.webkit.org-config/config.json:
321         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
322         (appendCustomBuildFlags):
323         * BuildSlaveSupport/test-result-archive:
324         (archiveTestResults):
325         Add WinCairo buildbot.
326
327 2015-01-16  Chris Dumez  <cdumez@apple.com>
328
329         webkit-patch should auto-install the keyring python module
330         https://bugs.webkit.org/show_bug.cgi?id=140547
331
332         Reviewed by David Kilzer.
333
334         Auto-install the keyring python module. This is the module that
335         webkit-patch uses for cross-platform access to the keyring
336         service.
337
338         Without this module, if the password if not in the keychain,
339         webkit-patch will keep asking for your username / password and
340         never remember them.
341
342         * Scripts/webkitpy/common/net/credentials.py:
343         * Scripts/webkitpy/thirdparty/__init__.py:
344         (AutoinstallImportHook.find_module):
345         (AutoinstallImportHook._install_keyring):
346
347 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
348
349         Remove ENABLE(SQL_DATABASE) guards
350         https://bugs.webkit.org/show_bug.cgi?id=140434
351
352         Reviewed by Darin Adler.
353
354         * Scripts/webkitperl/FeatureList.pm:
355
356 2015-01-15  Daniel Bates  <dabates@apple.com>
357
358         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
359         https://bugs.webkit.org/show_bug.cgi?id=139685
360         <rdar://problem/19281317>
361
362         Reviewed by Simon Fraser.
363
364         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
365         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
366
367         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
368         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
369         before DRT dumps the output of a test. In particular, the WebThread may start a new page
370         load (say, as a result of continued JavaScript execution), which will ultimately lead to
371         dumping the test result again. Instead we want DRT to dump the test result synchronously
372         such that we capture the state of the web page either when the page is loaded or when
373         window.testRunner.notifyDone() is called.
374
375         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
376         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
377         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
378         flush CA transactions to the window.
379         * DumpRenderTree/mac/DumpRenderTree.mm:
380         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
381         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
382         (dump): Renamed; formerly named dumpTestResults().
383         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
384         enabling repaint support on iOS.
385         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
386         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
387         (dumpTestResults): Deleted.
388
389 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
390
391         [Win] Miscellaneous DRT fixes
392         https://bugs.webkit.org/show_bug.cgi?id=116562
393
394         Reviewed by Tim Horton.
395
396         While investigating the cause of several Windows crashes, I found:
397         (1) Messy conversions to and from BSTR types
398         (2) Weird mixes of wide-string and narrow string conversions
399         (3) Passing nullptr to some CoreFoundation routines that do not
400             permit null arguments.
401         (4) Commands to link the executable to the VS2005 runtime.
402
403         This patch cleans up these issues to improve DRT reliability on
404         Windows.
405
406         * DumpRenderTree/cg/ImageDiffCG.cpp:
407         (main): Get rid of VS2005 runtime linking.
408         * DumpRenderTree/win/DumpRenderTree.cpp:
409         (urlSuitableForTestResult): Protect against being asked
410         to process an empty URL.
411         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
412         than converting to/from wchar_t buffers.
413         (runTest): Simplify string and BSTR handling.
414         (createWebViewAndOffscreenWindow): Ditto.
415         (main): Get rid of VS2005 runtime linking.
416         * DumpRenderTree/win/TestRunnerWin.cpp:
417         (jsStringRefToWString): Simplify code.
418         (TestRunner::pathToLocalResource):
419         (TestRunner::setUserStyleSheetLocation):
420         * TestWebKitAPI/win/main.cpp: Get rid of
421         VS2005 runtime linking.
422         * win/DLLLauncher/DLLLauncherMain.cpp:
423         (wWinMain): Ditto.
424
425 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
426
427         Stop hardcoding mac-mountainlion in commit queue
428         https://bugs.webkit.org/show_bug.cgi?id=140492
429
430         Reviewed by Anders Carlsson.
431
432         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
433         there should be no change in behavior, because:
434         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
435         using it to create a port object.
436         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
437         is actually correct to use "mac" for the name there. We only used to get the expected
438         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
439         for unknown deprecated port names.
440
441         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
442
443 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
444
445         Create iOS-EWS server queue
446         https://bugs.webkit.org/show_bug.cgi?id=140473
447
448         Reviewed by Benjamin Poulain.
449
450         * QueueStatusServer/app.yaml: Updates the SVN version number.
451         * QueueStatusServer/config/queues.py: Add ios-ews queue.
452         * QueueStatusServer/model/queues.py:         
453         (Queue.display_name): Makes sure the display name is pretty!
454
455 2015-01-14  Daniel Bates  <dabates@apple.com>
456
457         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
458         https://bugs.webkit.org/show_bug.cgi?id=140301
459         <rdar://problem/19389266>
460
461         Reviewed by Jon Honeycutt.
462
463         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
464         with an unavailable runtime.
465
466         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
467         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
468         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
469         specified runtime cannot be used because it is unavailable.
470         * Scripts/webkitpy/port/ios.py:
471         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
472         which was formerly named testing_device.
473         * Scripts/webkitpy/xcode/simulator.py:
474         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
475         more robust than looking up the simulator device by name and runtime. This approach also
476         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
477         unavailable runtimes under the same iOS heading it would use to show it as available).
478         (Simulator.find_device_by_udid): Added.
479         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
480         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
481         (Simulator.available_runtimes): Added.
482         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
483         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
484         first element of the sorted list is the runtime with the highest version number.
485         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
486
487 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
488
489         Remove WK2 Windows cruft
490         https://bugs.webkit.org/show_bug.cgi?id=140440
491
492         Reviewed by Anders Carlsson.
493
494         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
495         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
496         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
497
498 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
499
500         Fix TestWTF failed in TestWebKitAPI
501         https://bugs.webkit.org/show_bug.cgi?id=140333
502
503         Reviewed by Sam Weinig.
504
505         Clear the std::ostringstream before starting test.
506
507         * TestWebKitAPI/Tests/WTF/RefLogger.h:
508         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
509
510 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
511
512         TestWebKitWebContext depends on British English spellcheck dictionary
513         https://bugs.webkit.org/show_bug.cgi?id=140403
514
515         Reviewed by Martin Robinson.
516
517         Install all English hunspell dictionaries on Fedora and Arch.
518
519         * gtk/install-dependencies:
520
521 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
522
523         [GTK] install-dependencies should grok dnf
524         https://bugs.webkit.org/show_bug.cgi?id=140396
525
526         Reviewed by Martin Robinson.
527
528         Fedora: install dependencies with dnf if yum is not installed.
529
530         * gtk/install-dependencies:
531
532 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
533
534         [EFL][GTK] Fix build after r178309  
535         https://bugs.webkit.org/show_bug.cgi?id=140381
536
537         Reviewed by Gyuyoung Kim.
538
539         * TestWebKitAPI/CMakeLists.txt: Added the API directory
540
541 2015-01-11  Sam Weinig  <sam@webkit.org>
542
543         Remove support for SharedWorkers
544         https://bugs.webkit.org/show_bug.cgi?id=140344
545
546         Reviewed by Anders Carlsson.
547
548         * Scripts/webkitperl/FeatureList.pm:
549
550 2015-01-12  Anders Carlsson  <andersca@apple.com>
551
552         Make delegates conform to formal delegate protocols
553         https://bugs.webkit.org/show_bug.cgi?id=140370
554
555         Reviewed by Dan Bernstein.
556
557         * DumpRenderTree/mac/TestRunnerMac.mm:
558         (TestRunner::numberOfPendingGeolocationPermissionRequests):
559         (TestRunner::setGeolocationPermission):
560
561 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
562
563         build-webkit: silence output of 'which'
564         https://bugs.webkit.org/show_bug.cgi?id=140278
565
566         Reviewed by Daniel Bates.
567
568         Use a more elegent test for the existance of ninja and eclipse.
569
570         * Scripts/webkitdirs.pm:
571         (commandExists): Don't assume the command supports --version
572         (canUseNinja): Use commandExists()
573         (canUseEclipse): Use commandExists()
574
575 2015-01-09  Sam Weinig  <sam@webkit.org>
576
577         Update the output format for run-api-tests
578         https://bugs.webkit.org/show_bug.cgi?id=140332
579
580         Reviewed by Dan Bernstein.
581
582         Changes the output format for run-api-tests be a bit simpler (no longer 
583         indented based on suite, as we were not really using suite very well) but
584         also include details in the case of failure.
585
586         Changes verbose mode to no longer spew out the gtest default printer output,
587         as the custom printer now includes the failure information.
588
589         * Scripts/run-api-tests:
590         (runTestsBySuite):
591         (runTest):
592         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
593         with colorized variants and strip out leaks spew (the leaks can be added back using
594         the new --show-leaks argument).
595
596         * TestWebKitAPI/TestsController.cpp:
597         (TestWebKitAPI::Printer::OnTestPartResult):
598         (TestWebKitAPI::Printer::OnTestEnd):
599         (TestWebKitAPI::TestsController::run):
600         Implement a custom result printer that just prints out the information we want.
601
602 2015-01-09  Sam Weinig  <sam@webkit.org>
603
604         TestWebKitAPI should print out the lists that fail at the end
605         https://bugs.webkit.org/show_bug.cgi?id=140329
606
607         Reviewed by Tim Horton.
608
609         * Scripts/run-api-tests:
610         (runTestsBySuite):
611         Print out failures and timeouts in all modes, not just verbose.
612
613 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
614
615         Make bmalloc work with ASan
616         https://bugs.webkit.org/show_bug.cgi?id=140194
617
618         Reviewed by Mark Lam.
619
620         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
621         ASan automatically (by forwarding to system malloc at runtime).
622
623 2015-01-09  Daniel Bates  <dabates@apple.com>
624
625         [iOS] Make DumpRenderTree build with public SDK
626         https://bugs.webkit.org/show_bug.cgi?id=140311
627
628         Reviewed by Sam Weinig.
629
630         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
631         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
632         Additionally, remove unused header CoreGraphics/CGFontDB.h.
633
634         * DumpRenderTree/mac/DumpRenderTree.mm:
635         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
636
637 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
638
639         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
640         https://bugs.webkit.org/show_bug.cgi?id=140300
641
642         Reviewed by Simon Fraser.
643
644         * WebKitTestRunner/TestController.cpp:
645         (WTR::TestController::createOtherPage):
646         (WTR::TestController::updateWindowScaleForTest):
647         (WTR::TestController::configureViewForTest):
648         * WebKitTestRunner/TestController.h:
649
650 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
651
652         Unreviewed. Moving myself to the committer section.
653
654         * Scripts/webkitpy/common/config/contributors.json:
655
656 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
657
658         Add a script to check for platform layering violations
659         https://bugs.webkit.org/show_bug.cgi?id=140248
660
661         Reviewed by Darin Adler.
662
663         It prints all the cases where files inside platform include
664         headers that are not in platform directory.
665
666         * Scripts/check-for-platform-layering-violations: Added.
667         (get_platform_headers):
668         (check_source_file):
669
670 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
671
672         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
673         https://bugs.webkit.org/show_bug.cgi?id=139884
674
675         Reviewed by Tim Horton.
676
677         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
678         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
679         what the "nominal resolution" is, but this appears to work in practice.
680
681 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
682
683         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
684         https://bugs.webkit.org/show_bug.cgi?id=140256
685
686         Reviewed by Anders Carlsson.
687
688         * DumpRenderTree/win/DumpRenderTree.cpp:
689         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
690         running with heap validation checks.
691         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
692         the "svg\\W3C-SVG-1.1" test directory.
693         (removeFontFallbackIfPresent): Use nullptr instead of 0.
694         * DumpRenderTree/win/TestRunnerWin.cpp:
695         (TestRunner::clearPersistentUserStyleSheet): Ditto.
696
697 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
698
699         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
700         https://bugs.webkit.org/show_bug.cgi?id=140218
701
702         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
703         Undone an accidental change - check for self.has_crashed() again. This code path
704         is for ports that don't have a signal handler printing #CRASHED when main process
705         crashes.
706
707         * Scripts/webkitpy/port/driver_unittest.py:
708         (DriverTest.test_check_for_driver_crash.assert_crash):
709         (DriverTest.test_check_for_driver_crash):
710         Updated the tests, all changes are expected.
711
712 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
713
714         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
715         https://bugs.webkit.org/show_bug.cgi?id=140218
716
717         Reviewed by Darin Adler.
718
719         * Scripts/webkitpy/port/driver.py:
720         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
721         "process crashed" condition. These don't make sense together - it's either a crash
722         or a timeout, and we should detect those properly at a much lower level.
723         (Driver.run_test): Ditto.
724         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
725         cases.
726
727         * WebKitTestRunner/TestController.h:
728         * WebKitTestRunner/TestController.cpp:
729         (WTR::TestController::webProcessName): 
730         (WTR::TestController::processDidCrash):
731         Factored out hardcoded child process names, as we now use these in two places.
732
733         * WebKitTestRunner/TestInvocation.cpp:
734         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
735         process name, so that it can be sampled (fixes sampling on Mavericks and above).
736
737 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
738
739         Reorder my list of email addresses, keeping the Bugzilla address at the
740         top since Bugzilla and other webkitpy scripts rely on that ordering.
741
742         * Scripts/webkitpy/common/config/contributors.json:
743
744 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
745
746         Moving myself to the reviewers section and updating
747         the list of my email addresses.
748
749         * Scripts/webkitpy/common/config/contributors.json:
750
751 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
752
753         [GTK] Build gtk-doc without gtkdoc-mktmpl
754         https://bugs.webkit.org/show_bug.cgi?id=140225
755
756         Reviewed by Darin Adler.
757
758         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
759         don't modify the tmpl files that it generates, it's not doing anything
760         for us.
761
762         * gtk/gtkdoc.py:
763         (GTKDoc.generate):
764         (GTKDoc._run_gtkdoc_scangobj):
765         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
766
767 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
768
769         [GTK][ThreadedCompositor] Add support for threaded compositor.
770         https://bugs.webkit.org/show_bug.cgi?id=118265
771
772         Reviewed by Martin Robinson.
773
774         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
775         autotools build systems. The feature is disabled by default.
776         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
777         from the feature flags.
778
779         * Scripts/webkitperl/FeatureList.pm:
780
781 2015-01-07  Daniel Bates  <dabates@apple.com>
782
783         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
784         https://bugs.webkit.org/show_bug.cgi?id=137371
785
786         Reviewed by David Kilzer.
787
788         Use SPI wrapper headers instead of directly referencing private SPI headers.
789
790         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
791         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
792         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
793         to the list of iOS header search directories so that we can include header UIKitSPI.h.
794         * DumpRenderTree/mac/DumpRenderTree.mm:
795         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
796         * DumpRenderTree/mac/EventSendingController.mm:
797         * DumpRenderTree/mac/TestRunnerMac.mm:
798
799 2015-01-07  Commit Queue  <commit-queue@webkit.org>
800
801         Unreviewed, rolling out r178068.
802         https://bugs.webkit.org/show_bug.cgi?id=140235
803
804         Breaks the iOS build (Requested by enrica on #webkit).
805
806         Reverted changeset:
807
808         "[iOS] Make WebKit2 build with public iOS SDK and more build
809         fixes for DRT"
810         https://bugs.webkit.org/show_bug.cgi?id=137371
811         http://trac.webkit.org/changeset/178068
812
813 2015-01-07  Daniel Bates  <dabates@apple.com>
814
815         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
816         https://bugs.webkit.org/show_bug.cgi?id=137371
817
818         Reviewed by David Kilzer.
819
820         Use SPI wrapper headers instead of directly referencing private SPI headers.
821
822         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
823         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
824         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
825         to the list of header search directories so that we can include header UIKitSPI.h.
826         * DumpRenderTree/mac/DumpRenderTree.mm:
827         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
828         * DumpRenderTree/mac/EventSendingController.mm:
829         * DumpRenderTree/mac/TestRunnerMac.mm:
830
831 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
832
833         [Win] Unreviewed test change to improve run reproducibility
834
835         * Scripts/webkitpy/port/win.py:
836         (WinPort.default_child_processes): Run a single DRT instance to help
837         identify failures caused by earlier test runs.
838
839 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
840
841         Myles C. Maxfield is a reviewer now
842         https://bugs.webkit.org/show_bug.cgi?id=140196
843
844         Reviewed by Dean Jackson.
845
846         * Scripts/webkitpy/common/config/contributors.json:
847
848 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
849
850         Make webkit-patch try harder to find keychain credentials
851         https://bugs.webkit.org/show_bug.cgi?id=140170
852
853         Reviewed by Ryosuke Niwa.
854
855         When the user manually enters a password into webkit-patch, we hand that off to the
856         Keyring Python module. However, that module creates a generic password entry instead
857         of an internet password entry. We should look for both kinds.
858
859         * Scripts/webkitpy/common/net/credentials.py:
860         (Credentials._run_security_tool):
861         (Credentials._credentials_from_keychain):
862         * Scripts/webkitpy/common/net/credentials_unittest.py:
863         (test_security_output_parse_entry_not_found):
864         (_assert_security_call):
865
866 2015-01-06  Anders Carlsson  <andersca@apple.com>
867
868         Try to fix the Mountain Lion build.
869
870         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
871         (TestWebKitAPI::didGetImageForMatchResult):
872
873 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
874
875         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
876         https://bugs.webkit.org/show_bug.cgi?id=140095
877
878         Reviewed by Anders Carlsson.
879
880         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
881         builds, but not in debug ones.
882
883 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
884
885         [Win] Extend WinLauncher with support for Page Zoom
886         https://bugs.webkit.org/show_bug.cgi?id=140152
887
888         Reviewed by Anders Carlsson.
889
890         * WinLauncher/Common.cpp:
891         (WndProc):
892         * WinLauncher/WinLauncher.cpp:
893         (WinLauncher::resetZoom):
894         (WinLauncher::zoomIn):
895         (WinLauncher::zoomOut):
896         * WinLauncher/WinLauncher.h:
897         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
898         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
899         * win/DLLLauncher/DLLLauncherMain.cpp:
900         (wWinMain):
901
902 2015-01-06  Anders Carlsson  <andersca@apple.com>
903
904         Fix API tests that are broken under HiDPI
905         https://bugs.webkit.org/show_bug.cgi?id=140146
906
907         Reviewed by Tim Horton.
908
909         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
910         (TestWebKitAPI::didGetImageForMatchResult):
911         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
912
913         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
914         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
915         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
916         out in a window that has a backing scale factor of 1.
917  
918         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
919         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
920         Ditto.
921
922 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
923
924         ADDRESS_SANITIZER macro is overloaded
925         https://bugs.webkit.org/show_bug.cgi?id=140130
926
927         Reviewed by Anders Carlsson.
928
929         * WebKitTestRunner/TestController.cpp: Use the new macro.
930
931 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
932
933         Remove some stale class names in check-for-inappropriate-objc-class-names
934         https://bugs.webkit.org/show_bug.cgi?id=140104
935
936         Reviewed by Darin Adler.
937
938         * Scripts/check-for-inappropriate-objc-class-names:
939         These UIWK* classes no longer exist.
940
941 2015-01-05  Anders Carlsson  <andersca@apple.com>
942
943         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
944         https://bugs.webkit.org/show_bug.cgi?id=140096
945         rdar://problem/19368938
946
947         Reviewed by Alexey Proskuryakov.
948
949         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
950         since clientInfo points to a web view, not the test controller.
951
952         * WebKitTestRunner/TestController.cpp:
953         (WTR::TestController::createOtherPage):
954
955 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
956
957         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
958         https://bugs.webkit.org/show_bug.cgi?id=140077
959
960         Reviewed by Csaba Osztrogonác.
961
962         WebKit C SPI is available on EFL,GTK.
963         Changed the define order to pass the API test.
964
965         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
966         (TestWebKitAPI::TEST):
967
968 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
969
970         Simplify WebKitTestRunner timeout tracking
971         https://bugs.webkit.org/show_bug.cgi?id=140036
972
973         Reviewed by Darin Adler.
974
975         The code for configuring timeouts was mostly dead, because run-webkit-tests never
976         passes the --timeout option to WebKitTestRunner.
977
978         * WebKitTestRunner/Options.h:
979         * WebKitTestRunner/Options.cpp:
980         (WTR::Options::Options):
981         (WTR::OptionsHandler::OptionsHandler):
982         (WTR::handleOptionTimeout): Deleted.
983         Removed support for --timeout. Timeouts are passed for each test individually,
984         and defaults are good enough for the rare cases where WebKitTestRunner is run
985         manually without run-webkit-tests.
986
987         * WebKitTestRunner/TestController.cpp:
988         (WTR::TestController::TestController):
989         (WTR::TestController::initialize):
990         (WTR::TestController::resetStateToConsistentValues):
991         (WTR::TestController::reattachPageToWebProcess):
992         (WTR::TestController::runUntil):
993         * WebKitTestRunner/TestController.h:
994         Simplified runUntil by passing the actual timeout, not an enum.
995         Increased short timeout for ASan enabled builds, as WebProcess launching takes
996         quite a while.
997
998         * WebKitTestRunner/TestInvocation.cpp:
999         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1000
1001         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1002         (WTR::TestController::platformRunUntil):
1003         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1004         (WTR::TestController::platformRunUntil):
1005         Build fixes.
1006
1007 2015-01-02  Anders Carlsson  <andersca@apple.com>
1008
1009         Remove now unused storage tracker glue from DumpRenderTree
1010         https://bugs.webkit.org/show_bug.cgi?id=140045
1011
1012         Reviewed by Darin Adler.
1013
1014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1015         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1016         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1017         * DumpRenderTree/TestRunner.cpp:
1018         (TestRunner::staticFunctions):
1019         (syncLocalStorageCallback): Deleted.
1020         (observeStorageTrackerNotificationsCallback): Deleted.
1021         (deleteAllLocalStorageCallback): Deleted.
1022         (deleteLocalStorageForOriginCallback): Deleted.
1023         (localStorageDiskUsageForOriginCallback): Deleted.
1024         (originsWithLocalStorageCallback): Deleted.
1025         * DumpRenderTree/TestRunner.h:
1026         * DumpRenderTree/mac/DumpRenderTree.mm:
1027         (allocateGlobalControllers):
1028         (releaseGlobalControllers):
1029         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1030         * DumpRenderTree/mac/TestRunnerMac.mm:
1031         (TestRunner::syncLocalStorage): Deleted.
1032         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1033         (TestRunner::observeStorageTrackerNotifications): Deleted.
1034         (TestRunner::deleteAllLocalStorage): Deleted.
1035         (TestRunner::originsWithLocalStorage): Deleted.
1036         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1037         * DumpRenderTree/win/TestRunnerWin.cpp:
1038         (TestRunner::syncLocalStorage): Deleted.
1039         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1040         (TestRunner::observeStorageTrackerNotifications): Deleted.
1041         (TestRunner::deleteAllLocalStorage): Deleted.
1042         (TestRunner::originsWithLocalStorage): Deleted.
1043         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1044
1045 2015-01-01  Darin Adler  <darin@apple.com>
1046
1047         We often misspell identifier as "identifer"
1048         https://bugs.webkit.org/show_bug.cgi?id=140025
1049
1050         Reviewed by Michael Saboff.
1051
1052         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1053         * Scripts/webkitdirs.pm:
1054         (appIdentifierFromBundle):
1055         (installAndLaunchIOSWebKitAppInSimulator):
1056         Fix misspellings
1057
1058 2015-01-01  Zalan Bujtas  <zalan@apple.com>
1059
1060         Saturated arithmetics: Incorrect float/double clamping.
1061         https://bugs.webkit.org/show_bug.cgi?id=139888
1062         rdar://problem/19330885
1063
1064         Reviewed by Simon Fraser.
1065
1066         Clamp float and double values correctly when applying saturated arithmetics.
1067
1068         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1069         (TestWebKitAPI::TEST):
1070
1071 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
1072
1073         [EFL] Bump version of ATK used by jhbuild to 2.15.2
1074         https://bugs.webkit.org/show_bug.cgi?id=139816
1075
1076         Reviewed by Gyuyoung Kim.
1077
1078         Bump version of ATK used by jhbuild to 2.15.2
1079
1080         * efl/jhbuild.modules:
1081
1082 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
1083
1084         [jhBuild] cairo build error (-flto)
1085         https://bugs.webkit.org/show_bug.cgi?id=139056
1086
1087         Reviewed by Philippe Normand.
1088
1089         cairo fails to link  with gcc 4.9 due to lto
1090         related issue. This problem has been partially
1091         addressed by cairo:
1092         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1093         use the cairo --disable-lto option and remove jhbuild
1094         makeargs fixes the issue.
1095
1096         * gtk/jhbuild.modules:
1097         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1098
1099 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
1100         [Mac] Enable kerning, ligatures, and printer fonts 
1101         https://bugs.webkit.org/show_bug.cgi?id=139970
1102
1103         Rubber stamped by Simon Fraser.
1104
1105         Flip the switch.
1106
1107         * DumpRenderTree/mac/DumpRenderTree.mm:
1108         * WebKitTestRunner/TestController.cpp:
1109         * WebKitTestRunner/mac/main.mm:
1110
1111 2014-12-26  Dan Bernstein  <mitz@apple.com>
1112
1113         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1114         https://bugs.webkit.org/show_bug.cgi?id=139950
1115
1116         Reviewed by David Kilzer.
1117
1118         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1119         in a manner that works with Xcode 5.1.1.
1120
1121 2014-12-24  Dan Bernstein  <mitz@apple.com>
1122
1123         Engineering builds of MiniBrowser ignore deprecated declaration warnings
1124         https://bugs.webkit.org/show_bug.cgi?id=139941
1125
1126         Reviewed by Darin Adler.
1127
1128         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1129         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1130         to YES.
1131         * MiniBrowser/mac/AppDelegate.m:
1132         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1133         deprecated NSOKButton.
1134
1135 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1136
1137         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1138         https://bugs.webkit.org/show_bug.cgi?id=134763
1139
1140         Reviewed by Ryosuke Niwa.
1141
1142         Adding an option to disable test harness link conversion.
1143
1144         * Scripts/webkitpy/w3c/test_converter.py:
1145         (convert_for_webkit):
1146         (_W3CTestConverter.__init__):
1147         (_W3CTestConverter.convert_attributes_if_needed):
1148         * Scripts/webkitpy/w3c/test_importer.py:
1149         (parse_args):
1150         (TestImporter.import_tests):
1151
1152 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1153
1154         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1155         https://bugs.webkit.org/show_bug.cgi?id=139933
1156
1157         Reviewed by Daniel Bates.
1158
1159         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1160         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1161         until ReportCrash lets it go.
1162
1163         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1164         even get the actual crash log eventually - even when it times out waiting for the log, it
1165         makes a second lookup at the very end, after all tests finish. There may be further
1166         improvements needed here, but this small fix addresses most cases that happen in practice.
1167
1168         * DumpRenderTree/mac/DumpRenderTree.mm:
1169         (writeCrashedMessageOnFatalError):
1170         (dumpRenderTree):
1171         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1172
1173         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1174         unhelpful comment.
1175
1176 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1177
1178         Don't force -O1 for debug ASan builds
1179         https://bugs.webkit.org/show_bug.cgi?id=139926
1180
1181         Reviewed by Darin Adler.
1182
1183         * asan/asan.xcconfig:
1184
1185 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1186
1187         Simplify building with ASan
1188         https://bugs.webkit.org/show_bug.cgi?id=139916
1189
1190         Reviewed by Mark Rowe.
1191
1192         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1193         We could also update Configuration file format, but that's a little scary because
1194         of how many places in code read it.
1195
1196         * Scripts/webkitdirs.pm:
1197         (determineASanIsEnabled): Read it from ASan configuration file.
1198         (argumentsForConfiguration): Added a FIXME.
1199         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1200         (XcodeOptions): Pass the options needed for ASan.
1201
1202         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1203         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1204         that automatically.
1205
1206 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1207
1208         TestWebKitAPI build is broken when ASan is enabled
1209         https://bugs.webkit.org/show_bug.cgi?id=139902
1210
1211         Reviewed by Darin Adler.
1212
1213         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1214         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1215         Inherit linker flags from DebugRelease, which respects ASAN.
1216
1217 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1218
1219         Sort the Xcode project file.
1220
1221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1222
1223 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1224
1225         Update apple-mac-114 to bot629.
1226         
1227         Unreviewed.
1228         
1229         * BuildSlaveSupport/build.webkit.org-config/config.json:
1230
1231 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1232
1233         Replace Apple bot104 with bot124.
1234         
1235         Unreviewed.
1236         
1237         * BuildSlaveSupport/build.webkit.org-config/config.json:
1238
1239 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1240
1241         URTBF after r177639.
1242
1243         * TestWebKitAPI/CMakeLists.txt:
1244
1245 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1246
1247         [EFL] MiniBrowser steals web view's focus
1248         https://bugs.webkit.org/show_bug.cgi?id=139482
1249
1250         Reviewed by Gyuyoung Kim.
1251
1252         Although we set focus on ewk_view while MiniBrowser initialization
1253         Ecore steals it in a favor of main window. As a result
1254         focused element on web page is unable to receive events.
1255
1256         * MiniBrowser/efl/main.c:
1257         (window_create):
1258         Prevent window from stealing web view's focus on start up.
1259
1260 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1261
1262         [Win] Revise DRT logic to match Mac.
1263
1264         Rubberstamped by Anders Carlsson.
1265
1266         Update the Windows logic to perform initialization of preferences and WebKit
1267         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1268         the same circumstances as the Mac version.
1269
1270         * DumpRenderTree/win/DumpRenderTree.cpp:
1271         (dump):
1272         (resetWebPreferencesToConsistentValues):
1273         (setDefaultsToConsistentValuesForTesting):
1274         (resetWebViewToConsistentStateBeforeTesting):
1275         (sizeWebViewForCurrentTest):
1276         (runTest):
1277         (createWebViewAndOffscreenWindow):
1278         (allocateGlobalControllers):
1279         (prepareConsistentTestingEnvironment):
1280         (main):
1281         (resetDefaultsToConsistentValues): Deleted.
1282
1283 2014-12-19  Roger Fong  <roger_fong@apple.com>
1284
1285         Unreviewed. Rollout r177605.
1286
1287         * EWSTools/start-queue-win.sh:
1288
1289 2014-12-19  Roger Fong  <roger_fong@apple.com>
1290
1291         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1292
1293         * EWSTools/start-queue-win.sh:
1294
1295 2014-12-19  Daniel Bates  <dabates@apple.com>
1296
1297         [iOS] Add WebKitSystemInterface for iOS 8.1
1298         https://bugs.webkit.org/show_bug.cgi?id=139831
1299
1300         Reviewed by Alexey Proskuryakov.
1301
1302         Implement support in copy-webkitlibraries-to-product-directory to copy
1303         WebKitSystemInterface for iOS to the product directory and have build-webkit
1304         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1305
1306         * Scripts/build-webkit:
1307         * Scripts/copy-webkitlibraries-to-product-directory:
1308
1309 2014-12-19  Daniel Bates  <dabates@apple.com>
1310
1311         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1312         https://bugs.webkit.org/show_bug.cgi?id=139829
1313
1314         Reviewed by Alexey Proskuryakov.
1315
1316         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1317         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1318         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1319
1320         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1321         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1322         logic to both avoid duplicating effort and make the command line options for
1323         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1324         with the approach used in other WebKit tools.
1325
1326         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1327         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1328         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1329
1330         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1331         improve the readability of the code.
1332         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1333         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1334         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1335         be included in a library.
1336         (unpackIfNecessary): Modified to call executeRanlib().
1337
1338 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1339
1340         REGRESSION (177368): Some tests started to immediately time out
1341         https://bugs.webkit.org/show_bug.cgi?id=139826
1342
1343         Reviewed by Daniel Bates.
1344
1345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1346         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1347         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1348         ends in a load failure, we don't dump, so we used to leak the timer.
1349         
1350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1351         Added a comment.
1352
1353 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1354
1355         [Win] Add accessor for serializing HTTP loads
1356         https://bugs.webkit.org/show_bug.cgi?id=139817
1357
1358         Reviewed by Mark Lam.
1359
1360         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1361         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1362         remove some redundant code from the destructor.
1363
1364 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1365
1366         Clean up a fix for performance test bot failing to build
1367         https://bugs.webkit.org/show_bug.cgi?id=139818
1368
1369         Reviewed by Csaba Osztrogonác.
1370
1371         The "_1" in step name was annoying.
1372
1373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1374         (CleanBuildIfScheduled.start):
1375         (RunAndUploadPerfTests):
1376         (DownloadAndPerfTestFactory.__init__):
1377         (DownloadAndPerfTestWebKit2Factory.__init__):
1378         (CleanBuildUnconditionally): Deleted.
1379         (CleanBuildUnconditionally.start): Deleted.
1380
1381 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
1382
1383         REGRESSION(r177535): It broke the GTK performance bot
1384         https://bugs.webkit.org/show_bug.cgi?id=139811
1385
1386         Reviewed by Carlos Garcia Campos.
1387
1388         Trigger clean build only on mac platform.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1391         (DownloadAndPerfTestFactory.__init__):
1392         (DownloadAndPerfTestWebKit2Factory.__init__):
1393
1394 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
1395
1396         Unreviewed, moved myself to the list of committers.
1397
1398         * Scripts/webkitpy/common/config/contributors.json:
1399
1400 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1401
1402         [Win] Update DumpRenderTree to more closely match Mac version
1403         https://bugs.webkit.org/show_bug.cgi?id=139799
1404
1405         Reviewed by Tim Horton.
1406
1407         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1408         (AccessibilityController::accessibleElementById): Correct
1409         use of BSTR to avoid leak.
1410         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1411         update to match Mac version more closely.
1412         (dumpFramesAsText):
1413         (dump):
1414         (resetDefaultsToConsistentValues):
1415         (resetWebViewToConsistentStateBeforeTesting):
1416         (sizeWebViewForCurrentTest):
1417         (runTest):
1418         (openWindows):
1419         (windowToWebViewMap):
1420         (createWebViewAndOffscreenWindow):
1421         (sharedCFURLCache):
1422         (initializeGlobalsFromCommandLineOptions):
1423         (main):
1424         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1425         (TestRunner::addDisallowedURL):
1426         (TestRunner::applicationCacheDiskUsageForOrigin):
1427         (TestRunner::syncLocalStorage):
1428         (TestRunner::localStorageDiskUsageForOrigin):
1429         (TestRunner::observeStorageTrackerNotifications):
1430         (TestRunner::clearApplicationCacheForOrigin):
1431         (TestRunner::originsWithApplicationCache):
1432         (TestRunner::deleteAllLocalStorage):
1433         (TestRunner::setStorageDatabaseIdleInterval):
1434         (TestRunner::closeIdleLocalStorageDatabases):
1435         (TestRunner::originsWithLocalStorage):
1436         (TestRunner::deleteLocalStorageForOrigin):
1437         (TestRunner::copyDecodedHostName):
1438         (TestRunner::copyEncodedHostName):
1439         (TestRunner::keepWebHistory):
1440         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1441         (TestRunner::setAppCacheMaximumSize):
1442         (TestRunner::setCustomPolicyDelegate):
1443         (TestRunner::goBack):
1444         (TestRunner::setDefersLoading):
1445         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1446         (TestRunner::setMockDeviceOrientation):
1447         (TestRunner::setMockGeolocationPosition):
1448         (TestRunner::setMockGeolocationPositionUnavailableError):
1449         (TestRunner::setIconDatabaseEnabled):
1450         (TestRunner::setMainFrameIsFirstResponder):
1451         (TestRunner::setSpatialNavigationEnabled):
1452         (TestRunner::setPluginsEnabled):
1453         (TestRunner::setAutomaticLinkDetectionEnabled):
1454         (TestRunner::setUseDashboardCompatibilityMode):
1455         (TestRunner::dispatchPendingLoadRequests):
1456         (TestRunner::findString):
1457         (TestRunner::setCacheModel):
1458         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1459         (TestRunner::setWebViewEditable):
1460         (TestRunner::authenticateSession):
1461         (TestRunner::abortModal):
1462         (TestRunner::setSerializeHTTPLoads):
1463         (TestRunner::addChromeInputField):
1464         (TestRunner::removeChromeInputField):
1465         (TestRunner::focusWebView):
1466         (TestRunner::setBackingScaleFactor):
1467         (TestRunner::grantWebNotificationPermission):
1468         (TestRunner::denyWebNotificationPermission):
1469         (TestRunner::removeAllWebNotificationPermissions):
1470         (TestRunner::simulateWebNotificationClick):
1471
1472 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
1473
1474         Add strong typing to RefCounter interface, return value as a bool.
1475         https://bugs.webkit.org/show_bug.cgi?id=139776
1476
1477         Reviewed by Geoff Garen.
1478
1479         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1480         This means there is no compile time type checking to prevent mistakes. Update the count()
1481         method to token<>(), templated on type used to identify the token being returned.
1482         Calls to token<T>() will return a result of type RefCounter::Token<T>.
1483
1484         There are a few problems with the fact the counter will return you an exact count of the
1485         number of outstanding tokens:
1486           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1487             to do so if the value is only readable as a boolean.
1488           - It is desirable to provide the value as an argument to the callback, however to make
1489             this useful for integer values it is also necessary to indicate the direction of change
1490             (0->1 is often interesting where 2->1 is not).
1491           - There is a mismatch between the precision of returning a count, and the inherent
1492             imprecision of a token based mechanism, where it may be difficult to guarantee
1493             absolutely no unnecessary refcount churn, and thus unintentional counter values.
1494
1495         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1496         (TestWebKitAPI::TEST):
1497             - update API test.
1498
1499 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1500
1501         Disable retries on Mac Release WK2 testers
1502         https://bugs.webkit.org/show_bug.cgi?id=139798
1503
1504         Reviewed by Simon Fraser.
1505
1506         * BuildSlaveSupport/build.webkit.org-config/config.json:
1507
1508 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1509
1510         Perf tests frequently fail saying "build not up to date"
1511         https://bugs.webkit.org/show_bug.cgi?id=139786
1512
1513         Illegitimately yet authoritatively reviewed by Lucas Forschler.
1514
1515         Undo the rest of the first fix, and implement the behavior differently.
1516
1517         is_clean isn't automatically forwarded from config.json to properties.
1518
1519         * BuildSlaveSupport/build.webkit.org-config/config.json:
1520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1521         (CleanBuildUnconditionally):
1522         (CleanBuildUnconditionally.start):
1523         (DownloadAndPerfTestFactory.__init__):
1524         (DownloadAndPerfTestWebKit2Factory.__init__):
1525
1526 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1527
1528         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1529         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1530         found nothing.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1533         (BuildAndPerfTestFactory):
1534         (BuildAndPerfTestWebKit2Factory):
1535
1536 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1537
1538         Perf tests frequently fail saying "build not up to date"
1539         https://bugs.webkit.org/show_bug.cgi?id=139786
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
1544         directory to get rid of stale precompiled headers, and let it rebuild
1545         DumpRenderTree each time, that's fast.
1546
1547         Also, removed unused "build and perf test" code.
1548
1549         * BuildSlaveSupport/build.webkit.org-config/config.json:
1550
1551 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1552
1553         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
1554
1555         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
1556         it easier to see what steps are missing when running under Windows.
1557
1558         * DumpRenderTree/win/TestRunnerWin.cpp:
1559         (TestRunner::callShouldCloseOnWebView):
1560         (TestRunner::clearAllApplicationCaches):
1561         (TestRunner::applicationCacheDiskUsageForOrigin):
1562         (TestRunner::syncLocalStorage):
1563         (TestRunner::localStorageDiskUsageForOrigin):
1564         (TestRunner::observeStorageTrackerNotifications):
1565         (TestRunner::clearApplicationCacheForOrigin):
1566         (TestRunner::originsWithApplicationCache):
1567         (TestRunner::clearAllDatabases):
1568         (TestRunner::deleteAllLocalStorage):
1569         (TestRunner::setStorageDatabaseIdleInterval):
1570         (TestRunner::closeIdleLocalStorageDatabases):
1571         (TestRunner::originsWithLocalStorage):
1572         (TestRunner::deleteLocalStorageForOrigin):
1573         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1574         (jsStringRefToWString):
1575         (TestRunner::setAppCacheMaximumSize):
1576         (TestRunner::setDatabaseQuota):
1577         (TestRunner::goBack):
1578         (TestRunner::setDefersLoading):
1579         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1580         (TestRunner::setAutomaticLinkDetectionEnabled):
1581         (TestRunner::dispatchPendingLoadRequests):
1582         (TestRunner::overridePreference):
1583         (TestRunner::removeAllVisitedLinks):
1584         (TestRunner::waitForPolicyDelegate):
1585         (TestRunner::resetPageVisibility):
1586         (TestRunner::setPageVisibility):
1587         (TestRunner::grantWebNotificationPermission):
1588         (TestRunner::denyWebNotificationPermission):
1589         (TestRunner::removeAllWebNotificationPermissions):
1590         (TestRunner::simulateWebNotificationClick):
1591         (TestRunner::simulateLegacyWebNotificationClick):
1592
1593 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1594
1595         [Win] Correct Windows tests after Bug 139149 (edit)
1596         https://bugs.webkit.org/show_bug.cgi?id=139781
1597
1598         Reviewed by Anders Carlsson.
1599
1600         * DumpRenderTree/win/TestRunnerWin.cpp:
1601         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
1602         interface.
1603
1604 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1605
1606         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
1607         https://bugs.webkit.org/show_bug.cgi?id=139748
1608
1609         Reviewed by Daniel Bates.
1610         
1611         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
1612         have all been updated.
1613
1614         * Scripts/webkitpy/port/factory.py:
1615         (platform_options):
1616
1617 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1618
1619         Build more of TestWebKitAPI for iOS
1620         https://bugs.webkit.org/show_bug.cgi?id=139747
1621
1622         Reviewed by Daniel Bates.
1623         
1624         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
1625         which excluded some tests that should be run for iOS.
1626         
1627         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
1628         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
1629         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
1630         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
1631         
1632         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
1633         to share code between Mac and iOS.
1634
1635         * TestWebKitAPI/Configurations/Base.xcconfig:
1636         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1637         * TestWebKitAPI/InjectedBundleController.cpp:
1638         * TestWebKitAPI/InjectedBundleMain.cpp:
1639         * TestWebKitAPI/JavaScriptTest.cpp:
1640         * TestWebKitAPI/PlatformUtilities.cpp:
1641         * TestWebKitAPI/PlatformUtilities.h:
1642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1643         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1644         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1645         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1646         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1647         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1648         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1649         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1650         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1651         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1652         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1653         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1654         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1655         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1656         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1657         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1658         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1659         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1660         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1661         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1662         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1663         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1664         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1665         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1666         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1667         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1668         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1669         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1670         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1671         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1672         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1673         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1674         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1675         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1676         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1677         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1678         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1679         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1680         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1681         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1682         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1683         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1684         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1685         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
1686         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1687         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1688         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1689         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1690         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1691         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1692         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1693         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1694         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1695         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1696         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1697         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1698         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1699         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1700         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1701         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1702         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1703         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1704         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1705         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1706         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
1707         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1708         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1709         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1710         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1711         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1712         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1713         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1714         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1715         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1716         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1717         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
1718         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
1719         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1720         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1721         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1722         (TestWebKitAPI::TEST):
1723         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1724         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1725         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1726         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1727         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
1728         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1729         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1730         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1731         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1732         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
1733         (TEST):
1734         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1736         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1737         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1738         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1739         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1740         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1741         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1742         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1743         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1744         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
1745         (TestWebKitAPI::Util::run):
1746         (TestWebKitAPI::Util::sleep):
1747         (TestWebKitAPI::Util::toSTD):
1748         * TestWebKitAPI/config.h:
1749         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1750         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1751         (TestWebKitAPI::Util::run): Deleted.
1752         (TestWebKitAPI::Util::sleep): Deleted.
1753         (TestWebKitAPI::Util::toSTD): Deleted.
1754
1755 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1756
1757         [GTK] Add support for FTL JIT on ARM64
1758         https://bugs.webkit.org/show_bug.cgi?id=139677
1759
1760         Reviewed by Csaba Osztrogonác.
1761
1762         * gtk/jhbuild-optional.modules:
1763         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
1764         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
1765
1766 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
1767
1768         [GTK] Implement webkit_web_view_is_playing_audio()
1769         https://bugs.webkit.org/show_bug.cgi?id=138918
1770
1771         Reviewed by Carlos Garcia Campos.
1772
1773         Add test case case for webkit_web_view_is_playing_audio() and the
1774         WebKitWebView::is-playing-audio property.
1775
1776         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1777         (urlForResource): Utility function to get URLs pointing to resources
1778         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
1779         (testWebViewIsPlayingAudio): Added.
1780         (beforeAll):
1781         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1782         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
1783         API tests resources directory, or the WebKit2 C API tests resources
1784         directory. The default value of the flag is to use the WebKit2 GTK
1785         one, to avoid having to change existing tests.
1786         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1787         (isPlayingAudioChanged): Added.
1788         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
1789         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1790
1791 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1792
1793         [GTK] [EFL] Enable per_test_timeout
1794         https://bugs.webkit.org/show_bug.cgi?id=139771
1795
1796         Reviewed by Csaba Osztrogonác.
1797
1798         This is needed to make WKTR use either the default port timeout, or the
1799         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
1800         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
1801
1802         * Scripts/webkitpy/port/efl.py:
1803         (EflPort.supports_per_test_timeout): Enabled.
1804         * Scripts/webkitpy/port/gtk.py:
1805         (GtkPort.supports_per_test_timeout): Enabled.
1806
1807 2014-12-17  Lucas Forschler  <lforschler@apple.com>
1808
1809         Move Apple buildbot slaves to their new home.
1810         
1811         Reviewed by Roger Fong.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/config.json:
1814
1815 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
1816
1817         REGRESSION (r177363): Gtk and Efl testing is broken
1818         https://bugs.webkit.org/show_bug.cgi?id=139734
1819
1820         Reviewed by Simon Fraser.
1821
1822         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1823         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
1824         affected both script and tool timeout. This is still the right place for this logic,
1825         but it would be a larger refactoring than I can do right now.
1826
1827         * Scripts/webkitpy/port/base.py:
1828         (Port.supports_per_test_timeout): Added a FIXME.
1829         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
1830         to avoid making tests take more time.
1831
1832         * Scripts/webkitpy/port/driver.py:
1833         (Driver.run_test): Adjust script timeout here.
1834         (Driver._check_for_driver_timeout): Fix the timeout detection.
1835         (Driver._read_block): Actually use the timeout detection code.
1836
1837         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
1838         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
1839
1840         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
1841         Update results for the new default.
1842
1843         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1844         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
1845         actually a good one.
1846
1847 2014-12-17  Commit Queue  <commit-queue@webkit.org>
1848
1849         Unreviewed, rolling out r177456.
1850         https://bugs.webkit.org/show_bug.cgi?id=139749
1851
1852         Broke webkitpy and Mac tests (Requested by ap on #webkit).
1853
1854         Reverted changeset:
1855
1856         "REGRESSION (r177363): Gtk and Efl testing is broken"
1857         https://bugs.webkit.org/show_bug.cgi?id=139734
1858         http://trac.webkit.org/changeset/177456
1859
1860 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
1861
1862         REGRESSION (r177363): Gtk and Efl testing is broken
1863         https://bugs.webkit.org/show_bug.cgi?id=139734
1864
1865         Reviewed by Simon Fraser.
1866
1867         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1868         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
1869         affected both script and tool timeout. This is still the right place for this logic,
1870         but it would be a larger refactoring than I can do right now.
1871
1872         * Scripts/webkitpy/port/base.py:
1873         (Port.supports_per_test_timeout): Added a FIXME.
1874         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
1875         to avoid making tests take more time.
1876
1877         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
1878
1879         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
1880         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
1881
1882 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1883
1884         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
1885         https://bugs.webkit.org/show_bug.cgi?id=139725
1886
1887         Reviewed by Martin Robinson.
1888
1889         The timeout is already in milliseconds, so we don't need to do any conversion.
1890
1891         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1892         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1893
1894 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
1895
1896         [EFL]Fix build warning in MiniBrowser
1897         https://bugs.webkit.org/show_bug.cgi?id=139723
1898
1899         Reviewed by Darin Adler.
1900
1901         The warning is caused by the compiler wanting the first argument to be a
1902         string literal, not a dynamically created string.
1903
1904         * MiniBrowser/efl/main.c:
1905         (quit):
1906
1907 2014-12-16  Sam Weinig  <sam@webkit.org>
1908
1909         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
1910         https://bugs.webkit.org/show_bug.cgi?id=139718
1911
1912         Reviewed by Mark Rowe.
1913
1914         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
1915         files into a static lib which the command line utility can link link against.
1916         This will allow us to create a TestWebKitAPI.app that can run on iOS.
1917
1918         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1919         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921
1922 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
1923
1924         Sort out timeout implementations in DRT and WKTR
1925         https://bugs.webkit.org/show_bug.cgi?id=139671
1926
1927         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
1928         with the tool.
1929
1930         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1931         (RunTest.test_hung_thread):
1932
1933 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
1934
1935         Sort out timeout implementations in DRT and WKTR
1936         https://bugs.webkit.org/show_bug.cgi?id=139671
1937
1938         Reviewed by Simon Fraser.
1939
1940         Test timeout implementation had many deficiencies, please see the bug for details.
1941         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
1942         [ Slow ] modifiers should work a lot better.
1943
1944         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
1945         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
1946         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
1947         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
1948         DumpRenderTree already read the --timeout option from command line, and webkitpy
1949         was already configured to pass it on Mac and iOS. Let's actually use it.
1950         TestCommand already had the same 30 second default, so this doesn't change behavior
1951         when DRT is ran manually without the option.
1952         Windows DumpRenderTree will need to be fixed separately (that's easy).
1953
1954         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
1955         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
1956         slightly better to use stderr in both, as this is an out of band message, but
1957         that's a larger refactoring, and the difference is minimal in practice.
1958
1959         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1960         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
1961         different. We want the tool to reliably detect timeouts that can be detected, and
1962         not race with the script for that.
1963
1964         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
1965         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
1966         is honored inmore cases, that could make tests run slower.
1967         * Scripts/webkitpy/port/driver.py:
1968         (Driver.__init__):
1969         (Driver.run_test):
1970         (Driver.cmd_line):
1971         (Driver._check_for_driver_timeout):
1972         Detect tests that have the timeout output, and make these have the proper Timeout result.
1973
1974         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
1975         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
1976
1977         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1978         (WTR::TestRunner::setCustomTimeout): Deleted.
1979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1980         (WTR::TestRunner::setCustomTimeout):
1981         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1982         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1983         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1984         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1985         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1986         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1987         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1988         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1989         Updated to use a timeout passed from UI process, which used to be ignored.
1990
1991         * WebKitTestRunner/TestController.cpp:
1992         (WTR::TestController::TestController):
1993         (WTR::TestController::runUntil):
1994         (WTR::TestController::getCustomTimeout): Deleted.
1995         * WebKitTestRunner/TestController.h:
1996         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
1997         Changed default message timeouts to match new run-webkit-tests timeout. These don't
1998         affect ports where timeout is passed per test (shouldn't they all be like that?).
1999
2000         * WebKitTestRunner/TestInvocation.cpp:
2001         (WTR::TestInvocation::invoke):
2002         (WTR::TestInvocation::setCustomTimeout): Deleted.
2003         * WebKitTestRunner/TestInvocation.h:
2004         (WTR::TestInvocation::setCustomTimeout):
2005         (WTR::TestInvocation::customTimeout):
2006         Ditto.
2007
2008 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2009
2010         [EFL] Add logging domain for MiniBrowser
2011         https://bugs.webkit.org/show_bug.cgi?id=139642
2012
2013         Reviewed by Gyuyoung Kim.
2014
2015         Similarly to EWebKit2, provide logging facility for MiniBrowser
2016         based on Eina Log module to have a convenient way to display
2017         all/subset/none messages for EFL based libraries and MiniBrowser.
2018
2019         Usage:
2020         1. Disable all messages:
2021            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2022
2023         2. Enable all messages:
2024            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2025
2026         3. Enable MiniBrowser and EWebkit2 messages only:
2027            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2028
2029         More information and examples you can find here:
2030         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2031
2032         * MiniBrowser/efl/main.c:
2033         (on_mouse_wheel):
2034         (on_window_resize):
2035         (save_page_contents_callback):
2036         (script_execute_callback):
2037         (on_key_down):
2038         (on_download_request):
2039         (on_download_finished):
2040         (on_download_failed):
2041         (quit):
2042         (on_refresh_button_clicked):
2043         (on_stop_button_clicked):
2044         (navigation_button_longpress_process):
2045         (on_popup_menu_item_clicked):
2046         (popup_menu_populate):
2047         (on_popup_menu_show):
2048         (on_window_create):
2049         (context_menu_item_selected_cb):
2050         (context_menu_populate):
2051         (on_context_menu_show):
2052         (on_context_menu_hide):
2053         (on_navigation_policy_decision):
2054         (window_create):
2055         (parse_cookies_policy):
2056         (elm_main):
2057         (has_scheme):
2058         (list_item_label_get):
2059         (on_popup_menu_hide):
2060         (on_window_close):
2061         (on_home_button_clicked):
2062         Replace locally info() macro with newly introduced
2063         one which uses Eina Log module. There is no logic change.
2064
2065 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2066
2067         [EFL] FTL JIT not working on ARM64
2068         https://bugs.webkit.org/show_bug.cgi?id=139295
2069
2070         Reviewed by Michael Saboff.
2071
2072         Added patches for llvm to add ARM64 support for FTL JIT
2073
2074         * efl/jhbuild.modules:
2075         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2076         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2077
2078 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2079
2080         Move Said to the committers section.
2081
2082         * Scripts/webkitpy/common/config/contributors.json:
2083
2084 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2085
2086         Implement Data Detectors immediate actions for WebKit2
2087         https://bugs.webkit.org/show_bug.cgi?id=139617
2088         <rdar://problem/19198539>
2089
2090         Reviewed by Beth Dakin.
2091
2092         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2093         (TestWebKitAPI::TEST):
2094         Temporarily disable the action menu tests while the
2095         underlying code is in flux.
2096
2097 2014-12-14  Andreas Kling  <akling@apple.com>
2098
2099         Replace PassRef with Ref/Ref&& across the board.
2100         <https://webkit.org/b/139587>
2101
2102         Reviewed by Darin Adler.
2103
2104         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2105         (TestWebKitAPI::passWithRef):
2106         (TestWebKitAPI::TEST):
2107         (TestWebKitAPI::passWithPassRef): Deleted.
2108         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2109         (TestWebKitAPI::TEST):
2110         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2113         (TestWebKitAPI::createTestValue):
2114
2115 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2116
2117         [EFL] MiniBrowser's window_create may return NULL
2118         https://bugs.webkit.org/show_bug.cgi?id=139585
2119
2120         Reviewed by Gyuyoung Kim.
2121
2122         Move NULL checking before using object which window_create
2123         returns.
2124
2125         * MiniBrowser/efl/main.c:
2126         (elm_main):
2127
2128 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
2129
2130         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2131         https://bugs.webkit.org/show_bug.cgi?id=73030
2132
2133         Reviewed by Anders Carlsson.
2134
2135         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2136         database to empty to avoid having it fetch default favicons at random times.
2137         DumpRenderTree also disables it, and also it has a way for tests to temporarily
2138         enable it.
2139
2140 2014-12-12  Lucas Forschler  <lforschler@apple.com>
2141
2142         Update Apple owned build slaves after infrastructure update.
2143         
2144         Reviewed by Ryosuke Niwa.
2145
2146         * BuildSlaveSupport/build.webkit.org-config/config.json:
2147
2148 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2149
2150         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2151         https://bugs.webkit.org/show_bug.cgi?id=139537
2152
2153         Reviewed by Carlos Garcia Campos.
2154
2155         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2156         of get_dependencies_path().
2157         * jhbuild/jhbuildutils.py:
2158         (get_dependencies_path): Fix the function to return the new
2159         dependencies path: DependenciesPORT.
2160         (enter_jhbuild_environment_if_available): Pass the port name
2161         when invoking get_dependencies_path().
2162
2163 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2164
2165         Update Apple owned build slaves.
2166         
2167         Rubber-stamped by Dana Burkart.
2168         
2169         * BuildSlaveSupport/build.webkit.org-config/config.json:
2170
2171 2014-12-10  Daniel Bates  <dabates@apple.com>
2172
2173         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2174         timeout instead of test failure
2175         https://bugs.webkit.org/show_bug.cgi?id=139525
2176
2177         Reviewed by Zalan Bujtas.
2178
2179         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2180         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2181         output.
2182
2183         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2184         for the WebThread to spin its run loop before dumping its output. A test that
2185         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2186         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2187         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2188         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2189         exceeds its process time limit (defaults to 35ms) regardless of whether such
2190         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2191
2192         * Scripts/webkitpy/port/ios.py:
2193         (IOSSimulatorPort.default_timeout_ms):
2194
2195 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2196
2197         [GTK][WK2] Add HTML5 Notifications support
2198         https://bugs.webkit.org/show_bug.cgi?id=61140
2199
2200         Reviewed by Carlos Garcia Campos.
2201
2202         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2203         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2204         (testWebViewNotification):
2205         (beforeAll):
2206         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2207         (permissionRequestDialogCallback):
2208         (webViewDecidePermissionRequest):
2209         (geolocationRequestDialogCallback): Deleted.
2210
2211 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2212
2213         Fix webkitpy test expectation
2214
2215         Not sure what I messed up, but TOTAL_SKIPS was not right.
2216
2217         * Scripts/webkitpy/port/test.py:
2218
2219 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2220
2221         Remove virtual test support from webkitpy
2222         https://bugs.webkit.org/show_bug.cgi?id=139427
2223
2224         Reviewed by Alexey Proskuryakov.
2225
2226         It seems that the only concrete client of virtual tests is the unit tests :D
2227
2228         This patch tries to clean as much useless code as possible.
2229
2230         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2231         (RunTest.test_tolerance):
2232         (RunTest.test_virtual): Deleted.
2233         * Scripts/webkitpy/layout_tests/views/printing.py:
2234         (Printer._print_test_trace):
2235         * Scripts/webkitpy/port/base.py:
2236         (Port.expected_filename):
2237         (Port.tests):
2238         (Port.test_isfile):
2239         (Port.test_isdir):
2240         (Port.sample_process):
2241         (Port.find_system_pid):
2242         (Port.test_expectations_file_position):
2243         (Port.virtual_test_suites): Deleted.
2244         (Port): Deleted.
2245         (Port.populated_virtual_test_suites): Deleted.
2246         (Port._virtual_tests): Deleted.
2247         (Port.lookup_virtual_test_base): Deleted.
2248         (Port.lookup_virtual_test_args): Deleted.
2249         (VirtualTestSuite): Deleted.
2250         (VirtualTestSuite.__init__): Deleted.
2251         (VirtualTestSuite.__repr__): Deleted.
2252         * Scripts/webkitpy/port/base_unittest.py:
2253         (PortTest.test_test_exists):
2254         (PortTest.test_test_isfile):
2255         (PortTest.test_test_isdir):
2256         (PortTest.test_tests):
2257         * Scripts/webkitpy/port/driver.py:
2258         (DriverProxy.run_test): Deleted.
2259         * Scripts/webkitpy/port/test.py:
2260         (TestPort._skipped_tests_for_unsupported_features):
2261         (TestPort.all_baseline_variants):
2262         (TestPort.virtual_test_suites): Deleted.
2263         * Scripts/webkitpy/tool/commands/queries.py:
2264         (PrintBaselines.__init__):
2265         (PrintBaselines.execute):
2266         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2267         (PrintBaselinesTest.test_basic):
2268         (PrintBaselinesTest.test_multiple):
2269         (PrintBaselinesTest.test_csv):
2270
2271 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2272
2273         Blink Merge: Remove 'http_lock' code from webkitpy
2274         https://bugs.webkit.org/show_bug.cgi?id=136722
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2279         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2280
2281         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2282         (LayoutTestRunner.__init__):
2283         (LayoutTestRunner.run_tests):
2284         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2285         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2286         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2287         (FakePrinter.flush):
2288         (LayoutTestRunnerTests._runner):
2289         (LayoutTestRunnerTests._run_tests):
2290         (LayoutTestRunnerTests.test_servers_started):
2291         (LockCheckingRunner): Deleted.
2292         (LockCheckingRunner.__init__): Deleted.
2293         (LockCheckingRunner.handle_finished_list): Deleted.
2294         (LayoutTestRunnerTests.test_http_locking): Deleted.
2295         * Scripts/webkitpy/port/base.py:
2296         (Port.__init__):
2297         (Port.to.http_server_supports_ipv6):
2298         (Port.to.stop_websocket_server):
2299         (Port.to.acquire_http_lock): Deleted.
2300         (Port.to.release_http_lock): Deleted.
2301         * Scripts/webkitpy/port/http_lock.py: Removed.
2302         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2303         * Scripts/webkitpy/port/ios.py:
2304         (IOSSimulatorPort.show_results_html_file):
2305         (IOSSimulatorPort.acquire_http_lock): Deleted.
2306         (IOSSimulatorPort): Deleted.
2307         (IOSSimulatorPort.release_http_lock): Deleted.
2308         * Scripts/webkitpy/port/mac.py:
2309         (MacPort.show_results_html_file):
2310         (MacPort): Deleted.
2311         (MacPort.acquire_http_lock): Deleted.
2312         (MacPort.release_http_lock): Deleted.
2313         * Scripts/webkitpy/port/mock_drt.py:
2314         (MockDRTPort.start_websocket_server):
2315         (MockDRTPort.stop_websocket_server):
2316         (MockDRTPort.acquire_http_lock): Deleted.
2317         (MockDRTPort.release_http_lock): Deleted.
2318         * Scripts/webkitpy/port/mock_drt_unittest.py:
2319         (MockDRTPortTest.test_uses_apache):
2320         (MockDRTPortTest.integration_test_http_lock): Deleted.
2321         * Scripts/webkitpy/port/port_testcase.py:
2322         (PortTestCase.assert_servers_are_up):
2323         (PortTestCase.integration_test_http_lock): Deleted.
2324         * Scripts/webkitpy/port/test.py:
2325         (TestPort.start_websocket_server):
2326         (TestPort.stop_websocket_server):
2327         (TestPort.acquire_http_lock): Deleted.
2328         (TestPort.release_http_lock): Deleted.
2329
2330 2014-12-09  Alberto Garcia  <berto@igalia.com>
2331
2332         convertToUTF8String converts null string to empty string
2333         https://bugs.webkit.org/show_bug.cgi?id=133904
2334
2335         Reviewed by Carlos Garcia Campos.
2336
2337         Test that trying to get the value of a non-existent attribute
2338         returns 0 instead of an empty string.
2339
2340         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2341         (WebKitDOMNodeTest::testInsertion):
2342
2343 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2344
2345         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2346         https://bugs.webkit.org/show_bug.cgi?id=139070
2347
2348         Reviewed by Carlos Garcia Campos.
2349
2350         * gtk/jhbuild.modules:
2351
2352 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2353
2354         Add action menu tests
2355         https://bugs.webkit.org/show_bug.cgi?id=139156
2356
2357         Reviewed by Dean Jackson.
2358
2359         * TestWebKitAPI/PlatformWebView.h:
2360         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2361         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2362         Add a mechanism allowing tests to provide their own WKView subclass.
2363
2364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2365         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2366         Add a file with lots of menu targets.
2367
2368         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2369         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2370         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2371         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2372         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2373
2374         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2375
2376         (TestWebKitAPI::didFinishLoadForFrameCallback):
2377         (TestWebKitAPI::didFinishDownloadCallback):
2378         (TestWebKitAPI::didCreateDownloadDestinationCallback):
2379         Watch downloads and ensure that they match the content we expect.
2380
2381         (TestWebKitAPI::watchPasteboardForString):
2382         (TestWebKitAPI::watchPasteboardForImage):
2383         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2384         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2385         (TestWebKitAPI::javaScriptStringCallback):
2386         (TestWebKitAPI::javaScriptBoolCallback):
2387         (TestWebKitAPI::callJavaScriptReturningString):
2388         (TestWebKitAPI::callJavaScriptReturningBool):
2389         (TestWebKitAPI::watchEditableAreaForString):
2390         (TestWebKitAPI::waitForVideoReady):
2391         (TestWebKitAPI::retrieveSelection):
2392         (TestWebKitAPI::retrieveSelectionInElement):
2393         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2394         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2395         Add many helpers for testing, especially to make asynchronous things synchronous.
2396
2397         (TestWebKitAPI::windowPointForTarget):
2398         (TestWebKitAPI::inset8):
2399         Hard-code points in action-menu-targets.html for hit testing.
2400
2401         (TestWebKitAPI::TEST):
2402         Add a suite of tests for WebKit2 action menus.
2403
2404         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2405         (TestWebKitAPI::createActionContextForPhoneNumber):
2406         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2407         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2408         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2409         (TestWebKitAPI::ActionMenuTest::drawRect):
2410         (TestWebKitAPI::ActionMenuTest::didCreatePage):
2411         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2412         so that we can test that infrastructure.
2413
2414 2014-12-08  Philippe Normand  <pnormand@igalia.com>
2415
2416         [GTK] UserMedia Permission Request API
2417         https://bugs.webkit.org/show_bug.cgi?id=136449
2418
2419         Reviewed by Carlos Garcia Campos.
2420
2421         The GTK version of the MiniBrowser has gained UserMedia permission
2422         request support.
2423
2424         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2425         requires user permission to access audio/video devices.
2426         (permissionRequestDialogCallback):
2427         (webViewDecidePermissionRequest):
2428         (geolocationRequestDialogCallback): Deleted.
2429
2430 2014-12-08  Anders Carlsson  <andersca@apple.com>
2431
2432         Add a stubbed out method for clearing out the website data store
2433         https://bugs.webkit.org/show_bug.cgi?id=139404
2434
2435         Reviewed by Antti Koivisto.
2436
2437         Add a debug menu item for testing clearing of website data.
2438
2439         * MiniBrowser/mac/MainMenu.xib:
2440         * MiniBrowser/mac/WK2BrowserWindowController.m:
2441         (-[WK2BrowserWindowController clearWebsiteData:]):
2442
2443 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
2444
2445         Update style checker to deal with "const override"
2446         https://bugs.webkit.org/show_bug.cgi?id=139371
2447
2448         Reviewed by Csaba Osztrogonác.
2449
2450         check-webkit-style shouldn't complain about an open brace to start a
2451         line after a function definition with const override.
2452
2453         * Scripts/webkitpy/style/checkers/cpp.py:
2454         (check_braces):
2455         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2456         (CppStyleTest.test_brace_at_begin_of_line):
2457
2458 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2459
2460         [GTK] Fix GObject DOM bindings API break tests after r176920
2461         https://bugs.webkit.org/show_bug.cgi?id=139368
2462
2463         Reviewed by Gustavo Noronha Silva.
2464
2465         Remove the @version from the symbol name before comparing.
2466
2467         * gtk/check-for-webkitdom-api-breaks:
2468         (read_expected_api):
2469
2470 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2471
2472         Remove the option to automatically update the GObject DOM bindings symbols file
2473         https://bugs.webkit.org/show_bug.cgi?id=139366
2474
2475         Reviewed by Martin Robinson.
2476
2477         It's currently broken, because symbols now need to be in a
2478         specific order. Now that the symbols file only contains stable
2479         API, it's not a problem to manually update it every time new API
2480         is added.
2481
2482         * gtk/check-for-webkitdom-api-breaks:
2483         (read_expected_api):
2484         (check_api):
2485         (write_expected_api): Deleted.
2486
2487 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2488
2489         [GTK] Use GMainLoopSource in WebKitTestRunner
2490         https://bugs.webkit.org/show_bug.cgi?id=138831
2491
2492         Reviewed by Sergio Villar Senin.
2493
2494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2495         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2496         (WTR::TestRunner::platformInitialize):
2497         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2498         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2499         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2500         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2501         (WTR::TestController::notifyDone):
2502         (WTR::TestController::platformRunUntil):
2503         (WTR::cancelTimeout): Deleted.
2504
2505 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2506
2507         [GTK] Missing API detected in GObject DOM bindings after r176630
2508         https://bugs.webkit.org/show_bug.cgi?id=139201
2509
2510         Reviewed by Gustavo Noronha Silva.
2511
2512         Handle deprecated symbols again when generating the GObject DOM
2513         bindings documentation.
2514
2515         * gtk/webkitdom.py:
2516         (WebKitDOMDocGenerator):
2517         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2518         (WebKitDOMDocGenerator.generate):
2519         (WebKitDOMDocGeneratorSections.__init__):
2520         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2521         (WebKitDOMDocGeneratorSections.write_section):
2522
2523 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2524
2525         [EFL][jhbuild] Fix libsoup build with clang
2526         https://bugs.webkit.org/show_bug.cgi?id=139088
2527
2528         Reviewed by Gyuyoung Kim.
2529
2530         * efl/jhbuild.modules:
2531         * efl/patches/soup-clang-warning-fix1.patch: Added.
2532         * efl/patches/soup-clang-warning-fix2.patch: Added.
2533
2534 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
2535
2536         [Mac] DumpRenderTree sets storage directory incorrectly
2537         https://bugs.webkit.org/show_bug.cgi?id=139347
2538
2539         Reviewed by Dan Bernstein.
2540
2541         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2542         Don't use user defaults to pass per-instance paths, as user defaults are shared
2543         across all instances.
2544
2545 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
2546
2547         AX: I cannot activate links on the mobile version of news.google.com
2548         https://bugs.webkit.org/show_bug.cgi?id=139330
2549
2550         Reviewed by Simon Fraser.
2551
2552         Implement press for iOS.
2553
2554         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2555         (AccessibilityUIElement::press):
2556
2557 2014-12-05  Daniel Bates  <dabates@apple.com>
2558
2559         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
2560         https://bugs.webkit.org/show_bug.cgi?id=139326
2561
2562         Reviewed by Anders Carlsson.
2563
2564         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
2565         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
2566         using the same scale factor as used in WebKit.
2567
2568         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2569         (createBitmapContextFromWebView):
2570
2571 2014-12-05  Anders Carlsson  <andersca@apple.com>
2572
2573         REGRESSION (r176677): All tests crash on Windows
2574         https://bugs.webkit.org/show_bug.cgi?id=139321
2575
2576         Reviewed by Alexey Proskuryakov.
2577
2578         * DumpRenderTree/win/DumpRenderTree.cpp:
2579         (runTest):
2580         Don't call CFRelease on the url while we have an outstanding pointer to its string,
2581         and use the right number of bytes when allocating the testURL buffer.
2582
2583 2014-12-05  Daniel Bates  <dabates@apple.com>
2584
2585         [iOS] DumpRenderTree produces many reference test mismatches
2586         https://bugs.webkit.org/show_bug.cgi?id=139314
2587
2588         Reviewed by Simon Fraser.
2589
2590         Fixes an issue where the scale factor used to render the snapshot taken by
2591         DumpRenderTree may differ from the device scale factor. In particular, the
2592         scale factor used to render a snapshot of a test may differ from the scale
2593         factor used to render the snapshot of its expected result.
2594
2595         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
2596         snapshot the UIWebBrowserView. This SPI always render using a scale factor
2597         of one when the backing store for the LegacyTileLayer objects were out-of-
2598         date regardless of the device scale factor. Instead we should use UIImage
2599         and CALayer API to perform the snapshot with respect to the device scale
2600         factor.
2601
2602         Additionally write iOS pixel dump support logic in terms of existing
2603         DumpRenderTree abstractions so as to support generating and comparing
2604         pixel dump checksums as well as make the iOS code more consistent with
2605         the logic used by other ports.
2606
2607         * DumpRenderTree/PixelDumpSupport.cpp:
2608         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
2609         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2610         (BitmapContext::createFromUIImage): Added.
2611         (BitmapContext::pixelData): Added.
2612         (BitmapContext::BitmapContext): Added.
2613         (computeMD5HashStringForBitmapContext): Added.
2614         (dumpBitmap): Added.
2615         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
2616         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
2617
2618 2014-12-05  Anders Carlsson  <andersca@apple.com>
2619
2620         Give all web pages a website data store
2621         https://bugs.webkit.org/show_bug.cgi?id=139317
2622
2623         Reviewed by Tim Horton.
2624
2625         * MiniBrowser/mac/AppDelegate.m:
2626         (-[BrowserAppDelegate newPrivateWindow:]):
2627         Don't release the controller - it's implicitly retained by the window.
2628
2629 2014-12-05  Daniel Bates  <dabates@apple.com>
2630
2631         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
2632         https://bugs.webkit.org/show_bug.cgi?id=137581
2633         <rdar://problem/18642906>
2634
2635         Reviewed by Simon Fraser.
2636
2637         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
2638         of the test that proceeded the currently running test.
2639
2640         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2641         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
2642         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
2643         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
2644
2645 2014-12-05  Jer Noble  <jer.noble@apple.com>
2646
2647         [WTF] MediaTime should support round-tripping from and to doubles.
2648         https://bugs.webkit.org/show_bug.cgi?id=139248
2649
2650         Reviewed by Eric Carlson.
2651
2652         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
2653         the MediaTimes after this change.
2654
2655         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2656         (WTF::operator<<):
2657         (TestWebKitAPI::TEST):
2658         * lldb/lldb_webkit.py:
2659         (WTFMediaTime_SummaryProvider):
2660         (WTFMediaTimeProvider.timeValueAsDouble):
2661         (WTFMediaTimeProvider.isIndefinite):
2662         (WTFMediaTimeProvider):
2663         (WTFMediaTimeProvider.hasDoubleValue):
2664
2665 2014-12-05  Anders Carlsson  <andersca@apple.com>
2666
2667         Add a private browsing mode to MiniBrowser
2668         https://bugs.webkit.org/show_bug.cgi?id=139308
2669
2670         Reviewed by Sam Weinig.
2671
2672         * MiniBrowser/mac/AppDelegate.m:
2673         (defaultConfiguration):
2674         (-[BrowserAppDelegate newWindow:]):
2675         (-[BrowserAppDelegate newPrivateWindow:]):
2676         * MiniBrowser/mac/MainMenu.xib:
2677         * MiniBrowser/mac/WK2BrowserWindowController.h:
2678         * MiniBrowser/mac/WK2BrowserWindowController.m:
2679         (-[WK2BrowserWindowController awakeFromNib]):
2680         (-[WK2BrowserWindowController initWithConfiguration:]):
2681         (-[WK2BrowserWindowController dealloc]):
2682         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2683
2684 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
2685
2686         Run http tests parallel
2687         https://bugs.webkit.org/show_bug.cgi?id=138958
2688
2689         Reviewed by Daniel Bates.
2690
2691         Remove the concept of "locked shard". Now http tests are just like any other tests.
2692         We start HTTP and WebSocket servers at the start if we need them, and terminate them
2693         when done with all the tests (not when the last http test runs, which is unnecessarily
2694         unpredictable).
2695
2696         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
2697         patch, they used to take over 15 minutes.
2698
2699         As part of the fix, we no longer pass the number of servers to Apache. I don't
2700         think that these parameters did what we wanted them to do; Apache handles the load
2701         just fine without them.
2702
2703         The change applies to all platforms. I fixed everything I could find on Mac, and
2704         Ossy told me that he's been running http tests in parallel for a long time. If
2705         there is increased instability for some ports, it will need to be fixed - there is
2706         generally nothing special about http tests at this point, and most code is
2707         cross-platform in WebKit2.
2708
2709         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2710         (LayoutTestRunner.__init__):
2711         (LayoutTestRunner.run_tests):
2712         (LayoutTestRunner.start_servers_with_lock):
2713         (LayoutTestRunner._handle_started_test):
2714         (Worker.handle):
2715         (Sharder.__init__):
2716         (Sharder.shard_tests):
2717         (Sharder._shard_every_file):
2718         (Sharder._shard_by_directory):
2719         (LayoutTestRunner._handle_finished_test_list): Deleted.
2720         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
2721         (Sharder._shard_in_two): Deleted.
2722         (Sharder): Deleted.
2723         (Sharder._resize_shards): Deleted.
2724         (Sharder._resize_shards.divide_and_round_up): Deleted.
2725         (Sharder._resize_shards.extract_and_flatten): Deleted.
2726         (Sharder._resize_shards.split_at): Deleted.
2727         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2728         (FakePrinter.print_workers_and_shards):
2729         (LayoutTestRunnerTests.test_servers_started.start_http_server):
2730         (LayoutTestRunnerTests.test_servers_started):
2731         (SharderTests.get_shards):
2732         (SharderTests.test_shard_by_dir):
2733         (SharderTests.test_shard_every_file):
2734         (SharderTests): Deleted.
2735         (SharderTests.test_shard_in_two): Deleted.
2736         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
2737         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
2738         (SharderTests.test_multiple_locked_shards): Deleted.
2739         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2740         (ManagerTest.test_needs_servers.get_manager):
2741         (ManagerTest.integration_test_needs_servers.get_manager):
2742         (ManagerTest.test_look_for_new_crash_logs.get_manager):
2743         (ManagerTest):
2744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2745         (_set_up_derived_options):
2746         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2747         (RunTest.test_batch_size):
2748         (RunTest.test_max_locked_shards): Deleted.
2749         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2750         (LayoutTestApacheHttpd.__init__):
2751         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2752         (TestLayoutTestApacheHttpd.test_start_cmd):
2753         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2754         (Lighttpd.__init__):
2755         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2756         (HttpServerBase.__init__):
2757         * Scripts/webkitpy/layout_tests/views/printing.py:
2758         (Printer.print_workers_and_shards):
2759         * Scripts/webkitpy/port/base.py:
2760         (Port.default_child_processes):
2761         (Port.to.start_http_server):
2762         (Port.default_max_locked_shards): Deleted.
2763         * Scripts/webkitpy/port/port_testcase.py:
2764         (PortTestCase.make_port):
2765         (PortTestCase.test_default_max_locked_shards): Deleted.
2766         * Scripts/webkitpy/port/test.py:
2767         (TestPort.start_http_server):
2768
2769 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
2770
2771         Don't lock perf tests in run-webkit-tests
2772         https://bugs.webkit.org/show_bug.cgi?id=139264
2773
2774         Reviewed by Daniel Bates.
2775
2776         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2777         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2778         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2779         * Scripts/webkitpy/layout_tests/models/test_input.py:
2780         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2781
2782 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
2783
2784         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
2785         https://bugs.webkit.org/show_bug.cgi?id=139243
2786
2787         Reviewed by Anders Carlsson.
2788
2789         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
2790         chance to allow untrusted certificates.
2791
2792         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
2793         Set up more client objects for secondary windows. We may be able to share some of the
2794         code with main view creation function, but it's not exactly the same (notably, we
2795         do not focus a secondary window when it's done loading).
2796
2797 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
2798
2799         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
2800         https://bugs.webkit.org/show_bug.cgi?id=139071
2801
2802         Reviewed by Chris Fleizach.
2803
2804         Add string value for ATK_ROLE_STATIC in roleToString.
2805
2806         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2807
2808 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
2809
2810         check-webkit-style is confused by ternary expression inside first member initializer
2811         https://bugs.webkit.org/show_bug.cgi?id=136442
2812
2813         Reviewed by Csaba Osztrogonác.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (check_member_initialization_list):
2817
2818 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2819
2820         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
2821         https://bugs.webkit.org/show_bug.cgi?id=139220
2822
2823         Reviewed by Philippe Normand.
2824
2825         * gtk/jhbuild.modules:
2826         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2827
2828 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2829
2830         Remove unused JSC runtime options
2831         https://bugs.webkit.org/show_bug.cgi?id=133070
2832
2833         Reviewed by Csaba Osztrogonác.
2834
2835         * Scripts/run-jsc-stress-tests:
2836
2837 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2838
2839         [EFL] Add subtle crypto to the build system
2840         https://bugs.webkit.org/show_bug.cgi?id=138612
2841
2842         Reviewed by Csaba Osztrogonác.
2843
2844         * Scripts/webkitperl/FeatureList.pm:
2845
2846 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
2847
2848         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
2849         https://bugs.webkit.org/show_bug.cgi?id=139005
2850
2851         Reviewed by Chris Fleizach.
2852
2853         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2854         Add mapping for ATK_ROLE_CAPTION to roleToString
2855
2856 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2857
2858         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2859         https://bugs.webkit.org/show_bug.cgi?id=139149
2860
2861         Reviewed by Anders Carlsson.
2862
2863         WebKit2 already cleared application caches between runs (although it wasn't entirely
2864         effective without WebCore changes in this patch).
2865
2866         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
2867
2868         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
2869         function is not implemented on Windows, see below).
2870
2871         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
2872         Ameded a FIXME.
2873
2874 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
2875
2876         Generalize PageActivityAssertionToken
2877         https://bugs.webkit.org/show_bug.cgi?id=139106
2878
2879         Reviewed by Sam Weinig.
2880
2881         Add an API test for WTF::RefCounter.
2882
2883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
2885         (TestWebKitAPI::TEST):
2886             - added RefCounter test.
2887
2888 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2889
2890         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
2891         https://bugs.webkit.org/show_bug.cgi?id=139174
2892
2893         Reviewed by Simon Fraser.
2894
2895         * DumpRenderTree/TestRunner.cpp:
2896         * DumpRenderTree/TestRunner.h:
2897         Renamed testPathOrURL to testURL, because this variable always contains a URL.
2898
2899         * DumpRenderTree/mac/DumpRenderTree.mm:
2900         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
2901         (testPathFromURL): Moved from FrameLoadDelegate.mm.
2902         (runTest): Set crash reporter information here, as we know the exact test URL.
2903
2904         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2905         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
2906         reporter information here.
2907
2908         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2909         * DumpRenderTree/mac/TestRunnerMac.mm:
2910         Updated for testPathOrURL renaming.
2911
2912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2913         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
2914         test URL until load starts, so save it into TestRunner now. A new TestRunner object
2915         is created for each test.
2916
2917         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2918         (WTR::TestRunner::testURL):
2919         (WTR::TestRunner::setTestURL):
2920         Make TestRunner know the test name. For now, it's good enough to have it once load
2921         starts, but if we ever need it earlier, we can send it with BeginTest message.
2922
2923         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2924         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2925         Use test URL, not currently loading URL for CrashReporter.
2926
2927         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2928         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
2929         (WebKit1 already had it right).
2930
2931         * DumpRenderTree/win/DumpRenderTree.cpp:
2932         (sizeWebViewForCurrentTest):
2933         (runTest):
2934         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2935         (ResourceLoadDelegate::willSendRequest):
2936         Changed Windows DumpRenderTree to also use URL in TestRunner.
2937
2938 2014-12-02  Daniel Bates  <dabates@apple.com>
2939
2940         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
2941         https://bugs.webkit.org/show_bug.cgi?id=139143
2942
2943         Reviewed by David Kilzer.
2944
2945         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
2946         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
2947         crashes. Run-webkit-tests will record as crashing the test associated with the
2948         DumpRenderTree instance that wrote that string.
2949
2950         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
2951         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
2952         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
2953         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
2954         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
2955         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
2956         about a crash.
2957
2958         Additionally, update the crash message format written to standard error when LayoutTestRelay
2959         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
2960         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
2961         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
2962         when they crash in their test machinery logic/UI process code.
2963
2964         * DumpRenderTree/mac/DumpRenderTree.mm:
2965         (writeCrashedMessageOnFatalError): Added.
2966         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
2967         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
2968         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2969         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
2970         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
2971         the crash logs for WebKitTestRunner/DumpRenderTree.app.
2972         * Scripts/webkitpy/port/driver.py:
2973         (Driver.__init__): Update comment.
2974         (Driver._check_for_driver_crash): Ditto.
2975         * Scripts/webkitpy/port/ios.py:
2976         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
2977         regular expression. This constant is used as an optimization to avoid compiling the same
2978         regular expression across invocations of _get_crash_log().
2979         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
2980         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
2981         closer to where they are used.
2982
2983 2014-12-01  Anders Carlsson  <andersca@apple.com>
2984
2985         Remove WKBundleRemoveAllVisitedLinks
2986         https://bugs.webkit.org/show_bug.cgi?id=139163
2987
2988         Reviewed by Sam Weinig.
2989
2990         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
2991
2992         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2993         (WTR::InjectedBundle::beginTesting):
2994         * WebKitTestRunner/TestInvocation.cpp:
2995         (WTR::TestInvocation::invoke):
2996
2997 2014-12-02  Anders Carlsson  <andersca@apple.com>
2998
2999         Fix Windows build.
3000
3001         * DumpRenderTree/win/DumpRenderTree.cpp:
3002         (setAlwaysAcceptCookies):
3003
3004 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3005
3006         [EFL] Remove edbus dependency from jhbuild
3007         https://bugs.webkit.org/show_bug.cgi?id=139130
3008
3009         Reviewed by Gyuyoung Kim.
3010
3011         After http://trac.webkit.org/changeset/176555 we
3012         don't need it anymore.
3013
3014         * efl/jhbuild.modules:
3015
3016 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3017
3018         [jhbuild] wrong Dependencies path
3019         https://bugs.webkit.org/show_bug.cgi?id=139176
3020
3021         Reviewed by Martin Robinson.
3022
3023         * Scripts/webkitpy/port/base.py:
3024         (Port._should_use_jhbuild):
3025
3026 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3027
3028         [GStreamer] Bump internal jhbuild versions to 1.4.4
3029         https://bugs.webkit.org/show_bug.cgi?id=138866
3030
3031         Reviewed by Carlos Garcia Campos.
3032
3033         * gtk/jhbuild.modules:
3034         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3035         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3036         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3037
3038 2014-12-01  Commit Queue  <commit-queue@webkit.org>
3039
3040         Unreviewed, rolling out r176566.
3041         https://bugs.webkit.org/show_bug.cgi?id=139124
3042
3043         It broke the GTK performance tests. (Requested by clopez on
3044         #webkit).
3045
3046         Reverted changeset:
3047
3048         "[GTK] Use GMainLoopSource in WebKitTestRunner"
3049         https://bugs.webkit.org/show_bug.cgi?id=138831
3050         http://trac.webkit.org/changeset/176566
3051
3052 2014-11-29  Anders Carlsson  <andersca@apple.com>
3053
3054         Crash when calling WKPageClose on the originated page from within createNewPage callback
3055         https://bugs.webkit.org/show_bug.cgi?id=139099
3056         <rdar://problem/19052564>
3057
3058         Reviewed by Sam Weinig.
3059
3060         Add a test.
3061
3062         * TestWebKitAPI/PlatformWebView.h:
3063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3064         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
3065         (TestWebKitAPI::runJavaScriptAlert):
3066         (TestWebKitAPI::createNewPage):
3067         (TestWebKitAPI::TEST):
3068         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
3069         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3070         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3071
3072 2014-11-28  Commit Queue  <commit-queue@webkit.org>
3073
3074         Unreviewed, rolling out r176564.
3075         https://bugs.webkit.org/show_bug.cgi?id=139093
3076
3077         massive failures on release test bot (Requested by philn on
3078         #webkit).
3079
3080         Reverted changeset:
3081
3082         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
3083         https://bugs.webkit.org/show_bug.cgi?id=138866
3084         http://trac.webkit.org/changeset/176564
3085
3086 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3087
3088         [GTK] Use GMainLoopSource in WebKitTestRunner
3089         https://bugs.webkit.org/show_bug.cgi?id=138831
3090
3091         Reviewed by Sergio Villar Senin.
3092
3093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3094         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3095         (WTR::TestRunner::platformInitialize):
3096         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3097         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3098         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3099         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3100         (WTR::TestController::notifyDone):
3101         (WTR::TestController::platformRunUntil):
3102         (WTR::cancelTimeout): Deleted.
3103
3104 2014-11-24  Philippe Normand  <pnormand@igalia.com>
3105
3106         [GStreamer] Bump internal jhbuild versions to 1.4.4
3107         https://bugs.webkit.org/show_bug.cgi?id=138866
3108
3109         Reviewed by Carlos Garcia Campos.
3110
3111         * gtk/jhbuild.modules:
3112         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3113         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3114         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3115
3116 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
3119         https://bugs.webkit.org/show_bug.cgi?id=138834
3120
3121         Reviewed by Sergio Villar Senin.
3122
3123         It makes everyting simpler and the tests run faster too, since we
3124         don't need to spawn the private bus and wait until the DBus name
3125         is registered. The web extension registers a new JavaSCript class
3126         with a status method to run the tests, similar to the DBus
3127         method. In the UI process side, tests use webkit_web_view_run_java_script()
3128         instead of sending a DBus message.
3129
3130         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3131         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3132         (WebKitDOMNodeFilterTest::create):
3133         (WebKitDOMNodeFilterTest::testTreeWalker):
3134         (WebKitDOMNodeFilterTest::testNodeIterator):
3135         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
3136         (WebKitDOMNodeFilterTest::runTest): Deleted.
3137         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3138         (WebKitDOMNodeTest::create):
3139         (WebKitDOMNodeTest::testHierarchyNavigation):
3140         (WebKitDOMNodeTest::testInsertion):
3141         (WebKitDOMNodeTest::testTagNames):
3142         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
3143         (WebKitDOMNodeTest::runTest): Deleted.
3144         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3145         (WebKitDOMXPathNSResolverTest::create):
3146         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3147         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3148         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3149         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3150         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3151         (WebKitFrameTest::create):
3152         (WebKitFrameTest::testMainFrame):
3153         (WebKitFrameTest::testURI):
3154         (WebKitFrameTest::testJavaScriptContext):
3155         (WebKitFrameTest::webPageFromArgs): Deleted.
3156         (WebKitFrameTest::runTest): Deleted.
3157         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3158         (testWebKitDOMNodeHierarchyNavigation):
3159         (testWebKitDOMNodeInsertion):
3160         (testWebKitDOMNodeTagNames):
3161         (beforeAll):
3162         (afterAll):
3163         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3164         (runTest):
3165         (beforeAll):
3166         (afterAll):
3167         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3168         (testWebKitDOMXPathNSResolverNative):
3169         (testWebKitDOMXPathNSResolverCustom):
3170         (beforeAll):
3171         (afterAll):
3172         (runTest): Deleted.
3173         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3174         (webkitFrameTestRun):
3175         (beforeAll):
3176         (afterAll):
3177         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3178         (testsMap):
3179         (WebProcessTest::add):
3180         (WebProcessTest::create):
3181         (runTest):
3182         (windowObjectClearedCallback):
3183         (webkit_web_extension_initialize):
3184         (methodCallCallback): Deleted.
3185         (webkit_web_extension_initialize_with_user_data): Deleted.
3186         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3187         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
3188         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
3189         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3190         (WebViewTest::runWebProcessTest):
3191         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3192
3193 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
3194
3195         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
3196         https://bugs.webkit.org/show_bug.cgi?id=139086
3197
3198         Reviewed by Gyuyoung Kim.
3199
3200         * efl/jhbuild.modules:
3201         * efl/patches/libseccomp-pick-up-CC.patch: Added.
3202
3203 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
3204
3205         [EFL] Add warning if CMake version is too old for building with ninja.
3206         https://bugs.webkit.org/show_bug.cgi?id=139055
3207
3208         Reviewed by Gyuyoung Kim.
3209
3210         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
3211         that version in their repositories.
3212
3213         * efl/install-dependencies:
3214
3215 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
3216
3217         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
3218         https://bugs.webkit.org/show_bug.cgi?id=139044
3219
3220         Reviewed by Chris Fleizach.
3221
3222         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
3223         The proposed solution will enable the use of this method for the object table.
3224         Existing test shows the result.
3225
3226         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3227         (WTR::AccessibilityUIElement::columnHeaders):
3228
3229 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
3230
3231         [EFL] Remove E_Dbus dependency
3232         https://bugs.webkit.org/show_bug.cgi?id=136355
3233
3234         Reviewed by Gyuyoung Kim.
3235
3236         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
3237
3238 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3239
3240         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
3241         https://bugs.webkit.org/show_bug.cgi?id=139047
3242
3243         Reviewed by Carlos Garcia Campos.
3244
3245         * efl/jhbuild.modules:
3246         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3247         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3248         * gtk/jhbuild-optional.modules:
3249         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3250         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3251
3252 2014-11-25  Tanay C  <tanay.c@samsung.com>
3253
3254         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
3255         https://bugs.webkit.org/show_bug.cgi?id=138090
3256
3257         Reviewed by Carlos Garcia Campos.
3258
3259         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
3260         (browserWindowZoomIn): Added.
3261         (browserWindowZoomOut): Added.
3262         (scrollEventCallback): Added.
3263         (zoomInCallback): Modified.
3264         (zoomOutCallback): Modified.
3265         (browserWindowConstructed): Modified.
3266
3267 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
3268
3269         [EFL] REGRESSION(r176514): It made performance tests fail
3270         https://bugs.webkit.org/show_bug.cgi?id=139037
3271
3272         Reviewed by Gyuyoung Kim.
3273
3274         * Scripts/webkitpy/port/efl.py:
3275         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
3276         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
3277         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
3278
3279 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3280
3281         [GTK] update-webkitgtk-libs fails to build fontconfig
3282         https://bugs.webkit.org/show_bug.cgi?id=139032
3283
3284         Reviewed by Martin Robinson.
3285
3286         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
3287         fontconfig will try to generate documentation and fail.
3288
3289         * gtk/install-dependencies:
3290
3291 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3292
3293         Unreviewed. Fix GTK+ make distcheck.
3294
3295         * gtk/manifest.txt: Remove deleted files.
3296
3297 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
3298
3299         [EFL] Utilize Eail library to support accessibility in EFL
3300         https://bugs.webkit.org/show_bug.cgi?id=137742
3301
3302         Reviewed by Gyuyoung Kim.
3303
3304         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
3305
3306         * efl/jhbuild-optional.modules: Added.
3307         * efl/jhbuild.modules:
3308
3309 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3310
3311         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
3312         https://bugs.webkit.org/show_bug.cgi?id=139023
3313
3314         Reviewed by Sergio Villar Senin.
3315
3316         Rename WebKitWebView/default-context as WebKitWebView/web-context
3317         and check we are always using the right context for new web views.
3318
3319         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3320         (testWebViewWebContext):
3321         (beforeAll):
3322         (testWebViewDefaultContext): Deleted.
3323
3324 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3325
3326         [GTK] Add API to override the default local storage directory
3327         https://bugs.webkit.org/show_bug.cgi?id=138828
3328
3329         Reviewed by Gustavo Noronha Silva.
3330
3331         Add test to check that the local storage directory is created at
3332         the path given on construction.
3333
3334         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3335         (testWebContextConfiguration):
3336         (beforeAll):
3337         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3338         (Test::Test):
3339         (Test::~Test): Deleted.
3340
3341 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3342
3343         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3344         https://bugs.webkit.org/show_bug.cgi?id=138981
3345
3346         Reviewed by Simon Fraser.
3347
3348         * MiniBrowser/mac/SettingsController.h:
3349         * MiniBrowser/mac/SettingsController.m:
3350         (-[SettingsController _populateMenu]):
3351         (-[SettingsController validateMenuItem:]):
3352         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
3353         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
3354         * MiniBrowser/mac/WK1BrowserWindowController.m:
3355         (-[WK1BrowserWindowController didChangeSettings]):
3356         * MiniBrowser/mac/WK2BrowserWindowController.m:
3357         (-[WK2BrowserWindowController didChangeSettings]):
3358
3359 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
3360
3361         Remove http lock code from webkitperl
3362         https://bugs.webkit.org/show_bug.cgi?id=138959
3363
3364         Reviewed by Alexey Proskuryakov.
3365
3366         * Scripts/webkitperl/httpd.pm:
3367         (cleanUp):
3368         (extractLockNumber): Deleted.
3369         (getLockFiles): Deleted.
3370         (getNextAvailableLockNumber): Deleted.
3371         (getLockNumberForCurrentRunning): Deleted.
3372         (waitForHTTPDLock): Deleted.
3373         (scheduleHttpTesting): Deleted.
3374         (getWaitTime): Deleted.
3375
3376 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
3377
3378         [EFL] The option value of fixed layout is false in MiniBrowser
3379         https://bugs.webkit.org/show_bug.cgi?id=138830
3380
3381         Reviewed by Gyuyoung Kim.
3382
3383         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
3384
3385         * MiniBrowser/efl/main.c:
3386
3387 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
3388
3389         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
3390         https://bugs.webkit.org/show_bug.cgi?id=138871
3391
3392         Reviewed by Carlos Garcia Campos.
3393
3394         Add a test case for the convenience API for posting user messages
3395         added to the DOM bindings.
3396
3397         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3398         (testUserContentManagerMessageFromConvenienceDOMBindings):
3399         (beforeAll):
3400         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3401         (documentLoadedCallback):
3402
3403 2014-11-19  Dana Burkart  <dburkart@apple.com>
3404
3405         Work around the fact that different masters may have different names for their codebases.
3406         https://bugs.webkit.org/show_bug.cgi?id=138878
3407
3408         Reviewed by Mark Rowe.
3409
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3411         (parseRevisionProperty): Changed.
3412         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
3413         opensource / internal codebase naming convention.
3414
3415 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3416
3417         AX: Screen braille input doesn't work on forms.
3418         https://bugs.webkit.org/show_bug.cgi?id=138804
3419
3420         Unreviewed build fix.
3421
3422         * DumpRenderTree/AccessibilityUIElement.cpp:
3423         (AccessibilityUIElement::setValue):
3424
3425 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3426
3427         AX: Screen braille input doesn't work on forms.
3428         https://bugs.webkit.org/show_bug.cgi?id=138804
3429
3430         Reviewed by Mario Sanchez Prada.
3431
3432         Add a method to setValue through the AX API in DRT.
3433
3434         * DumpRenderTree/AccessibilityUIElement.cpp:
3435         (setValueCallback):
3436         (AccessibilityUIElement::getJSClass):
3437         * DumpRenderTree/AccessibilityUIElement.h:
3438         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3439         (AccessibilityUIElement::setValue):
3440         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3441         (AccessibilityUIElement::setValue):
3442
3443 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
3444
3445         Remove the WinCairo buildbot
3446         https://bugs.webkit.org/show_bug.cgi?id=138805
3447
3448         Reviewed by Alex Christensen.
3449
3450         * BuildSlaveSupport/build.webkit.org-config/config.json:
3451         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3452         (appendCustomBuildFlags):
3453         * BuildSlaveSupport/test-result-archive:
3454         (archiveTestResults):
3455
3456 2014-11-18  Daniel Bates  <dabates@apple.com>
3457
3458         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3459         SPI are not available in public SDK
3460         https://bugs.webkit.org/show_bug.cgi?id=138802
3461
3462         Reviewed by David Kilzer.
3463
3464         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
3465
3466         * DumpRenderTree/mac/CheckedMalloc.cpp:
3467
3468 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3469
3470         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
3471
3472         Forgot to fix this test before landing.
3473
3474         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3475         (testWebViewDefaultContext):
3476
3477 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3478
3479         [GTK] Add API to create a WebKitWebContext
3480         https://bugs.webkit.org/show_bug.cgi?id=138826
3481
3482         Reviewed by Gustavo Noronha Silva.
3483
3484         Use a different WebKitWebContext for every test to ensure test
3485         cases are independent to each other. Tests using DBus to
3486         communicate with the injected bundle extension now use a unique
3487         name for the well known DBus name.
3488
3489         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3490         (beforeAll): Remove comment about the order of the tests and
3491         move the success test before the failed one now that tests don't
3492         depend on each others.
3493         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3494         (beforeAll): Remove call to set the web extensions directory,
3495         since this is now done for all test in the Test constructor.
3496         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3497         (beforeAll): Do not create a temporary directory, a temporary data
3498         directory is now created for all tests.
3499         (afterAll):
3500         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3501         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
3502         to the web process test runner.
3503         (testWebKitDOMNodeInsertion): Ditto.
3504         (testWebKitDOMNodeTagNames): Ditto.
3505         (beforeAll): Remove call to set the web extensions directory.
3506         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3507         (runTest): Pass the web extension ID to the web process test runner.
3508         (beforeAll): Remove call to set the web extensions directory.
3509         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3510         (runTest): Pass the web extension ID to the web process test runner.
3511         (beforeAll): Remove call to set the web extensions directory.
3512         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3513         (createFileAtDestination): Use Test::dataDirectory() as base dir
3514         for temporary files.
3515         (beforeAll): Do not create a temporary directory.
3516         (afterAll):
3517         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3518         (webkitFrameTestRun): Pass the web extension ID to the web process
3519         test runner.
3520         (beforeAll): Remove call to set the web extensions directory.
3521         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3522         (beforeAll): Remove call to set the web extensions directory.
3523         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3524         (testProcessPerWebView): Use local member instead of global variable.
3525         (testMultiprocessWebViewCreateReadyClose): Ditto.
3526         (beforeAll): Do not connect to initialize-web-extensions, Test now
3527         connects to the signal for all tests and calls a virtual method
3528         that test can override.
3529         (afterAll):
3530         (initializeWebExtensions): Deleted.
3531         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3532         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
3533         for temporary files.
3534         (beforeAll): Do not create a temporary directory.
3535         (afterAll):
3536         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3537         (beforeAll): Remove call to set the web extensions directory.
3538         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3539         (beforeAll): Remove comment about the tests order.
3540         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3541         (testWebExtensionGetTitle): Build the DBus service name using the
3542         web extension ID.
3543         (testDocumentLoadedSignal): Ditto.
3544         (testWebKitWebViewProcessCrashed): Ditto.
3545         (testWebExtensionIsolatedWorld): Ditto.
3546         (beforeAll): Remove initialization-user-data test, since now all
3547         tests are passing user data to the web extension.
3548         (testWebExtensionInitializationUserData): Deleted.
3549         (initializeWebExtensions): Deleted.
3550         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3551         (testSetDirectory): Use the web context member inherited from Test.
3552         (testClearDatabase): Ditto.
3553         (testGetFaviconURI): Ditto.
3554         (beforeAll): Do not create a temporary directory.
3555         (afterAll):
3556         (webkitFaviconDatabaseFinalizedCallback): Deleted.
3557         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3558         (UserContentManagerTest::UserContentManagerTest):
3559         (beforeAll): Remove call to set the web extensions directory.
3560         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3561         (testWebContextDefault): Check also that a newly create web
3562         context is not the default web context.
3563         (testWebContextSpellChecker): Use the web context member inherited
3564         from Test.
3565         (testWebContextLanguages): Ditto.
3566         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3567         (methodCallCallback): Remove GetInitializationUserData method.
3568         (webkit_web_extension_initialize_with_user_data): Always create
3569         the DBus name using the user data provided.
3570         (makeBusName): Deleted.
3571         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3572         (webkit_web_extension_initialize_with_user_data): Create the DBus
3573         name using the user data provided.
3574         (webkit_web_extension_initialize): Deleted.
3575         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3576         (Test::dataDirectory): Return the temporary data directory.
3577         (removeNonEmptyDirectory): Also remove directories recursively.
3578         (main): Remove the disk cache directory initialization, since this
3579         is now done in the Test constructor.
3580         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3581         (Test::initializeWebExtensionsCallback): Call the virtual method
3582         initializeWebExtensions()
3583         (Test::Test): Create a new WebKitWebContext and initialize it.
3584         (Test::~Test): Disconnect initialize-web-extensions signal.
3585         (Test::initializeWebExtensions): Set the web extensions directory
3586         and user data.
3587         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
3588         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
3589         (WebProcessTestRunner::runTest): Build the DBus proxy using a
3590         unique name created with the Test web extension ID.
3591         (WebProcessTestRunner::proxy): Deleted.
3592         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
3593         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3594         (WebViewTest::WebViewTest): Create the web view with the Test web
3595         context.
3596         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
3597         content manager parameter to the constructor.
3598
3599 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
3600
3601         [GTK] Mesa build fails over llvm-3.5
3602         https://bugs.webkit.org/show_bug.cgi?id=138825
3603
3604         Reviewed by Gustavo Noronha Silva.
3605
3606         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
3607
3608         * gtk/jhbuild.modules:
3609         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
3610
3611 2014-11-17  Daniel Bates  <dabates@apple.com>
3612
3613         Unreviewed, rolling out r176232.
3614
3615         Broke the Mac build. Will investigate offline.
3616