test-webkitpy fails on Mac without iphoneos SDK
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-04  Daniel Bates  <dabates@apple.com>
2
3         test-webkitpy fails on Mac without iphoneos SDK
4         https://bugs.webkit.org/show_bug.cgi?id=141255
5         <rdar://problem/19619691>
6
7         I inadvertently committed the wrong exception message. Fix up the exception message
8         to instruct a person to install the iOS SDK when it cannot be found.
9
10         * Scripts/webkitpy/port/ios.py:
11         (IOSPort.determine_full_port_name):
12
13 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
14
15         W3C test importer should sort the list of files when generating the w3c-import.log
16         https://bugs.webkit.org/show_bug.cgi?id=141156
17
18         Reviewed by Bem Jones-Bey.
19
20         Sort explicitly the list of imported files written in the w3c-import.log.
21         Removed logging of the import date.
22
23         * Scripts/webkitpy/w3c/test_importer.py:
24         (TestImporter.write_import_log):
25
26 2015-02-04  Daniel Bates  <dabates@apple.com>
27
28         test-webkitpy fails on Mac without iphoneos SDK
29         https://bugs.webkit.org/show_bug.cgi?id=141255
30         <rdar://problem/19619691>
31
32         Reviewed by David Kilzer and Alexey Proskuryakov.
33
34         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
35         should not require the iphoneos SDK to be installed to run the webkitpy tests.
36
37         * Scripts/webkitpy/common/system/platforminfo.py:
38         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
39         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
40         to standard output if the SDK is installed to return the empty string if the SDK is
41         not installed.
42         * Scripts/webkitpy/common/system/platforminfo_mock.py:
43         (MockPlatformInfo.xcode_sdk_version): Added.
44         * Scripts/webkitpy/port/ios.py:
45         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
46         to get the version of the iphoneos SDK, if installed.
47
48 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
49
50         run-webkit-tests doesn't always capture ASan violation reports
51         https://bugs.webkit.org/show_bug.cgi?id=141231
52
53         Reviewed by Darin Adler.
54
55         * Scripts/webkitpy/port/driver.py:
56         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
57         by the driver already (as is the case with ASan violations, which are printed to
58         stderr).
59         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
60         report.
61         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
62         a separate variable for reporting.
63
64 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
65
66         [webkitpy] Add platform specific Skipped file mechanism for performance tests
67         https://bugs.webkit.org/show_bug.cgi?id=141152
68
69         Reviewed by Csaba Osztrogonác.
70
71         Support a test-expectation-like syntax in performance tests' skipped files.
72         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
73
74         * Scripts/webkitpy/port/base.py:
75         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
76
77         * Scripts/webkitpy/port/base_unittest.py:
78         (PortTest.test_skipped_perf_tests): Test the new syntax.
79
80 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
81
82         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
83         https://bugs.webkit.org/show_bug.cgi?id=141236
84
85         Reviewed by Sam Weinig.
86
87         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
88         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
89
90 2015-02-04  Chris Dumez  <cdumez@apple.com>
91
92         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
93         https://bugs.webkit.org/show_bug.cgi?id=141192
94
95         Reviewed by Benjamin Poulain.
96
97         Add API tests for Vector::removeFirst(value) and
98         Vector::removeAll(value).
99
100         * TestWebKitAPI/Tests/WTF/Vector.cpp:
101         (TestWebKitAPI::TEST):
102
103 2015-02-03  Tim Horton  <timothy_horton@apple.com>
104
105         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
106         https://bugs.webkit.org/show_bug.cgi?id=141217
107
108         Reviewed by Sam Weinig.
109
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::copyWebCryptoMasterKey):
112         (WTR::TestController::createOtherPage):
113         (WTR::TestController::createWebViewWithOptions):
114         (WTR::TestController::ensureViewSupportsOptions):
115         (WTR::TestController::didCommitNavigation):
116         (WTR::TestController::didFinishNavigation):
117         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
118         (WTR::TestController::didReceiveAuthenticationChallenge):
119         (WTR::TestController::decidePolicyForPluginLoad):
120         (WTR::TestController::decidePolicyForNavigationAction):
121         (WTR::TestController::decidePolicyForNavigationResponse):
122         (WTR::TestController::didCommitLoadForFrame): Deleted.
123         (WTR::TestController::didFinishLoadForFrame): Deleted.
124         * WebKitTestRunner/TestController.h:
125         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
126
127 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
128
129         Unreviewed. Add myself as a committer.
130
131         * Scripts/webkitpy/common/config/contributors.json:
132
133 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
134
135         [Win] Unreviewed test fix.
136
137         * DumpRenderTree/win/PolicyDelegate.cpp:
138         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
139         so was not matching expected output.
140
141 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
142
143         Unreviewed. Moving myself to the committer section at last.
144
145         * Scripts/webkitpy/common/config/contributors.json:
146
147 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
148
149         [Win] Tests fail because DRT reports '(null)' instead of an empty string
150         https://bugs.webkit.org/show_bug.cgi?id=141205
151
152         Reviewed by Anders Carlsson.
153
154         * DumpRenderTree/win/HistoryDelegate.cpp:
155         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
156         properly so that we match expected DumpRenderTree output.
157
158 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
159
160         [GTK] TestWebKitAccessibility is not skipped
161         https://bugs.webkit.org/show_bug.cgi?id=141179
162
163         Reviewed by Carlos Garcia Campos.
164
165         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
166         skipped, and it apparently works reliably on the bots.
167
168         * Scripts/run-gtk-tests:
169         (TestRunner):
170
171 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
172
173         run-perf-tests: allow to specify a wrapper command.
174         https://bugs.webkit.org/show_bug.cgi?id=141172
175
176         Reviewed by Ryosuke Niwa.
177
178         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
179         (parse_args): Update text to indicate is also valid for WTR.
180         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
181         (PerfTestsRunner._parse_args): Add wrapper command.
182
183 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
184
185         [Win] Correct version parsing warning in update-webkit
186         https://bugs.webkit.org/show_bug.cgi?id=141200
187
188         Reviewed by Anders Carlsson.
189
190         * Scripts/webkitdirs.pm:
191         (setupAppleWinEnv): Strip out any specific version build level
192         from the Cygwin version information.
193   
194
195 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
196
197         [Win] Attempt to improve the reliability of HTTP service
198         https://bugs.webkit.org/show_bug.cgi?id=141191
199
200         Reviewed by Darin Adler.
201
202         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
203         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
204         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
205         when stopping the service doesn't do so on its own (for Windows runs).
206
207 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
208
209         Web platform test server should not need to create __init__.py files
210         https://bugs.webkit.org/show_bug.cgi?id=141030
211
212         Reviewed by Ryosuke Niwa.
213
214         W3C TestImporter ensures that copied __init__.py files are not empty.
215         If needed, a comment is inserted in __init__.py files.
216         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
217
218         * Scripts/webkitpy/common/system/filesystem.py:
219         (FileSystem.getsize):
220         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
221         (TestWebPlatformTestServer.test_start_cmd):
222         (TestWebPlatformTestServer):
223         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
224         * Scripts/webkitpy/w3c/test_importer.py:
225         (TestImporter.import_tests):
226
227 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
228
229         Unreviewed. Moving myself to the committer section.
230
231         * Scripts/webkitpy/common/config/contributors.json:
232
233 2015-02-02  Saam Barati  <saambarati1@gmail.com>
234
235         Create tests for JSC's Control Flow Profiler
236         https://bugs.webkit.org/show_bug.cgi?id=141123
237
238         Reviewed by Filip Pizlo.
239
240         * Scripts/run-javascriptcore-tests:
241         (runJSCStressTests):
242         * Scripts/run-jsc-stress-tests:
243
244 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
245
246         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
247         https://bugs.webkit.org/show_bug.cgi?id=141158
248
249         Reviewed by Darin Adler.
250
251         * Scripts/run-jsc-stress-tests:
252
253 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
254
255         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
256         https://bugs.webkit.org/show_bug.cgi?id=141142
257
258         Reviewed by Carlos Garcia Campos.
259
260         * MiniBrowser/gtk/BrowserWindow.c:
261         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
262
263 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
264
265         Web platform test server is not always launching properly on Mac EWS bots
266         https://bugs.webkit.org/show_bug.cgi?id=141141
267
268         Unreviewed.
269
270         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
271         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
272
273 2015-01-31  Sam Weinig  <sam@webkit.org>
274
275         Remove even more Mountain Lion support
276         https://bugs.webkit.org/show_bug.cgi?id=141124
277
278         Reviewed by Alexey Proskuryakov.
279
280         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
281         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
282         * DumpRenderTree/mac/Configurations/Base.xcconfig:
283         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
284         * DumpRenderTree/mac/DumpRenderTree.mm:
285         (activateTestingFonts):
286         (prepareConsistentTestingEnvironment):
287         * DumpRenderTree/mac/EventSendingController.mm:
288         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
289         (-[EventSendingController contextClick]):
290         * DumpRenderTree/mac/TextInputController.m:
291         * LayoutTestRelay/Configurations/Base.xcconfig:
292         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
293         * MiniBrowser/Configurations/Base.xcconfig:
294         * MiniBrowser/Configurations/DebugRelease.xcconfig:
295         * MiniBrowser/mac/WK2BrowserWindowController.m:
296         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
297         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
298         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
299         * TestWebKitAPI/Configurations/Base.xcconfig:
300         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
301         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
302         (-[DownloadDelegate _downloadDidFinish:]):
303         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
306         (TestWebKitAPI::InjectedBundleController::platformInitialize):
307         * WebKitLauncher/Configurations/Base.xcconfig:
308         * WebKitTestRunner/Configurations/Base.xcconfig:
309         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
310         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
311         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
312         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
313         (WTR::activateFonts):
314         * WebKitTestRunner/TestController.cpp:
315         (WTR::TestController::initialize):
316         (WTR::TestController::webProcessName):
317         * WebKitTestRunner/mac/EventSenderProxy.mm:
318         * asan/asan.xcconfig:
319
320 2015-01-31  Commit Queue  <commit-queue@webkit.org>
321
322         Unreviewed, rolling out r179408.
323         https://bugs.webkit.org/show_bug.cgi?id=141117
324
325         This didn't fully fix the issue (Requested by anttik on
326         #webkit).
327
328         Reverted changeset:
329
330         "OSObjectPtr does not work with dispatch_data_t on Maverics"
331         https://bugs.webkit.org/show_bug.cgi?id=141081
332         http://trac.webkit.org/changeset/179408
333
334 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
335
336         https://trac.webkit.org/changeset/179439 breaks a python test
337         https://bugs.webkit.org/show_bug.cgi?id=141114
338
339         Unreviewed.
340
341         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
342         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
343
344 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
345
346         Import W3C web platform tests infrastructure
347         https://bugs.webkit.org/show_bug.cgi?id=140934
348
349         Reviewed by Ryosuke Niwa.
350
351         Loading necessary web platform tests modules before launching server.
352         Ensuring that some empty __init__.py files are present and create them if necessary. 
353
354         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
355         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
356
357 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
358
359         [Win] Another unreviewed test fix.
360
361         Correct copy/paste error in buildbot handling.
362
363         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
364         (LayoutTestApacheHttpd.__init__):
365         (LayoutTestApacheHttpd._get_apache_config_file_path):
366
367 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
368
369         [Win] Unreviewed test fix.
370
371         Correct path handling based on failures on test bots to get things running again.
372
373         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
374         (LayoutTestApacheHttpd.__init__):
375         (LayoutTestApacheHttpd._get_apache_config_file_path):
376
377 2015-01-30  Chris Dumez  <cdumez@apple.com>
378
379         Unreviewed. Fix Windows build after r179409.
380
381         * DumpRenderTree/win/TestRunnerWin.cpp:
382         (TestRunner::notifyDone):
383         (TestRunner::queueLoad):
384
385 2015-01-30  Chris Dumez  <cdumez@apple.com>
386
387         Rename shared() static member functions to singleton() for singleton classes.
388         https://bugs.webkit.org/show_bug.cgi?id=141088
389
390         Reviewed by Ryosuke Niwa and Benjamin Poulain.
391
392         Rename shared() static member functions to singleton() for singleton
393         classes as per the recent coding style change.
394
395 2015-01-30  Antti Koivisto  <antti@apple.com>
396
397         OSObjectPtr does not work with dispatch_data_t on Maverics
398         https://bugs.webkit.org/show_bug.cgi?id=141081
399
400         Reviewed by Pratik Solanki.
401
402         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
403         (TestWebKitAPI::TEST):
404
405 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
406
407         [Win] Switch to Apache on Windows
408         https://bugs.webkit.org/show_bug.cgi?id=141060
409
410         Reviewed by Alexey Proskuryakov.
411
412         Update our scripts under Windows (and Cygwin) to locate and use
413         the XAMPP installation of Apache for running tests.
414
415         * Scripts/run-webkit-httpd:
416         * Scripts/webkitperl/httpd.pm:
417         (getHTTPDPath):
418         (getDefaultConfigForTestDirectory):
419         (getHTTPDConfigPathForTestDirectory):
420         * Scripts/webkitpy/common/system/executive_unittest.py:
421         (ExecutiveTest.serial_test_kill_process):
422         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
423         (LayoutTestApacheHttpd.__init__):
424         (LayoutTestApacheHttpd._get_apache_config_file_path):
425         (LayoutTestApacheHttpd._stop_running_server):
426         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
427         (HttpServerBase._is_server_running_on_all_ports):
428         * Scripts/webkitpy/port/base.py:
429         (Port._apache_config_file_name_for_platform):
430         * Scripts/webkitpy/port/port_testcase.py:
431         (test_apache_config_file_name_for_platform):
432         * Scripts/webkitpy/port/win.py:
433         (WinPort.show_results_html_file):
434         (WinPort._uses_apache):
435         (WinPort):
436         (WinPort._path_to_apache):
437
438 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
439
440         Built result takes too long to be compressed on bots
441         https://bugs.webkit.org/show_bug.cgi?id=141056
442
443         Reviewed by Daniel Bates.
444
445         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
446
447         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
448
449 2015-01-29  Sam Weinig  <sam@webkit.org>
450
451         Remove support for screen font substitution
452         https://bugs.webkit.org/show_bug.cgi?id=141038
453
454         Reviewed by Tim Horton.
455
456         * DumpRenderTree/win/DumpRenderTree.cpp:
457         (resetWebPreferencesToConsistentValues):
458         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
459
460 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
461
462         Make run-jsc-stress-tests --remote work on Linux too
463         https://bugs.webkit.org/show_bug.cgi?id=141000
464
465         Reviewed by Darin Adler.
466
467         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
468         use bash/dash compatible signal names, use Linux/Mac compatible find options,
469         use bash/dash compatible functions.
470         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
471
472 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
473
474         [buildbot] Simplify jscore-test buildstep
475         https://bugs.webkit.org/show_bug.cgi?id=140821
476
477         Reviewed by Alexey Proskuryakov.
478
479         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
480         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
481         (RunJavaScriptCoreTests.countFailures): Added.
482         (RunJavaScriptCoreTests.commandComplete): Deleted.
483         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
484         (RunJavaScriptCoreTests.getText): Deleted.
485         (RunJavaScriptCoreTests.getText2): Deleted.
486         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
487         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
488         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
489         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
490         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
491
492 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
493
494         Unreviewed, revert r179337, we don't need this dependency.
495
496         * efl/install-dependencies:
497         * gtk/install-dependencies:
498
499 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
500
501         Unreviewed. Moving myself to the committer section.
502
503         * Scripts/webkitpy/common/config/contributors.json:
504
505 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
506
507         URTBF after r179326, added uuid-dev package as new dependency.
508
509         * efl/install-dependencies:
510         * gtk/install-dependencies:
511
512 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
513
514         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
515         https://bugs.webkit.org/show_bug.cgi?id=140673
516
517         Reviewed by Sam Weinig.
518
519         * Scripts/dtrace/trace-webkit2-messages.d: Added.
520         Add a DTrace script that outputs a small blob of JSON per message.
521
522 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
523
524         Removed fastMallocForbid / fastMallocAllow
525         https://bugs.webkit.org/show_bug.cgi?id=141012
526
527         Reviewed by Mark Hahnenberg.
528
529         Fixed a test bug I noticed while testing.
530
531         * DumpRenderTree/JavaScriptThreading.cpp:
532         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
533         accessing javaScriptThreads -- otherwise, you'll ASSERT.
534
535 2015-01-28  Dana Burkart  <dburkart@apple.com>
536
537         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
538         https://bugs.webkit.org/show_bug.cgi?id=141015
539
540         Reviewed by Alexey Proskuryakov.
541
542         * asan/asan.xcconfig:
543
544 2015-01-28  Sam Weinig  <sam@webkit.org>
545
546         Fix the build.
547
548         * Scripts/copy-webkitlibraries-to-product-directory:
549
550 2015-01-28  Lucas Forschler  <lforschler@apple.com>
551
552         Increase the FileUpload block size in an attempt to improve network performance.
553         
554         Reviewed by Alexey Proskuryakov.
555         
556         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
557         (UploadBuiltProduct.__init__):
558
559 2015-01-28  Dana Burkart  <dburkart@apple.com>
560
561         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
562         https://bugs.webkit.org/show_bug.cgi?id=136765
563
564         Reviewed by Alexey Proskuryakov.
565
566         * DumpRenderTree/mac/Configurations/Base.xcconfig:
567         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
568         * LayoutTestRelay/Configurations/Base.xcconfig:
569         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
570         * MiniBrowser/Configurations/Base.xcconfig:
571         * MiniBrowser/Configurations/DebugRelease.xcconfig:
572         * TestWebKitAPI/Configurations/Base.xcconfig:
573         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
574         * WebKitLauncher/Configurations/Base.xcconfig:
575         * WebKitTestRunner/Configurations/Base.xcconfig:
576         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
577
578 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
579
580         AX: [ATK] Implement support for new AtkRole types for MathML
581         https://bugs.webkit.org/show_bug.cgi?id=140916
582
583         Reviewed by Chris Fleizach.
584
585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
586         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
587
588 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
589
590         [GTK] Stop removing color marks from unit tests output
591         https://bugs.webkit.org/show_bug.cgi?id=140996
592
593         Reviewed by Philippe Normand.
594
595         Since r178236 google tests use a custom simplified output without
596         any colors, so we don't need to handle the case of non ttys to
597         remove the color marks.
598
599         * Scripts/run-gtk-tests:
600         (TestRunner.__init__):
601         (TestRunner._run_test_command.parse_line):
602
603 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
606         https://bugs.webkit.org/show_bug.cgi?id=131731
607
608         Reviewed by Žan Doberšek.
609
610         A web page loaded offscreen is in prerender state not hidden.
611
612         * Scripts/run-gtk-tests:
613         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
614         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
615         (testWebViewPageVisibility):
616
617 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
618
619         Partially revert r178802.
620
621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
623
624 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
625
626         build.webkit.org/dashboard asserts on some commits
627         https://bugs.webkit.org/show_bug.cgi?id=140926
628
629         Reviewed by Tim Horton.
630
631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
632         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
633
634 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
635
636         Make flakiness dashboard OS list actually match test_expectations.py
637         https://bugs.webkit.org/show_bug.cgi?id=140969
638
639         Reviewed by Ryosuke Niwa.
640
641         * TestResultServer/static-dashboards/flakiness_dashboard.js:
642
643 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
644
645         [Win] WinLauncher crashes on eleventh site visited
646         https://bugs.webkit.org/show_bug.cgi?id=140960
647
648         Reviewed by Anders Carlsson.
649
650         * WinLauncher/WinLauncher.cpp:
651         (WinLauncher::showLastVisitedSites): Don't access off the end of
652         the history array.
653
654 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
655
656         [Mac] Disable building Java applets by default
657         https://bugs.webkit.org/show_bug.cgi?id=140957
658         rdar://problem/19619529
659
660         Reviewed by Anders Carlsson.
661
662         It was actually already disabled unconditionally, by accident.
663
664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
665         * Scripts/webkitpy/port/mac.py:
666         (MacPort._check_port_build):
667         (MacPort._build_java_test_support):
668
669 2015-01-27  Daniel Bates  <dabates@apple.com>
670
671         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
672         https://bugs.webkit.org/show_bug.cgi?id=140949
673
674         Reviewed by Alexey Proskuryakov.
675
676         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
677         builders so that run-webkit-tests can lint the appropriate TestExpectation
678         files.
679
680         * Scripts/webkitpy/port/builders.py:
681         * Scripts/webkitpy/port/ios.py:
682         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
683         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
684         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
685         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
686         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
687         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
688         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
689
690
691 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
692
693         Update bots on the flakiness dashboard
694         https://bugs.webkit.org/show_bug.cgi?id=140956
695
696         Reviewed by Ryosuke Niwa.
697
698         * TestResultServer/static-dashboards/builders.jsonp:
699         * TestResultServer/static-dashboards/flakiness_dashboard.js:
700
701 2015-01-27  Daniel Bates  <dabates@apple.com>
702
703         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
704         https://bugs.webkit.org/show_bug.cgi?id=140942
705
706         Reviewed by Alexey Proskuryakov.
707
708         The directory LayoutTests/platform/wk2 contains test expectations and test results that
709         are applicable to all WebKit2 ports. We should make use of this information when
710         running layout tests using iOS WebKit2.
711
712         Additionally, make use of the convenience function Port._wk2_port_name() for the name
713         of the WebKit2 port instead of directly using string concatenation.
714
715         * Scripts/webkitpy/port/ios.py:
716         (IOSSimulatorPort.default_baseline_search_path):
717
718 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
719
720         [Win] Disable FTL stress tests
721         https://bugs.webkit.org/show_bug.cgi?id=140932
722
723         Reviewed by Brent Fulgham.
724
725         * Scripts/run-javascriptcore-tests:
726
727 2015-01-27  Daniel Bates  <dabates@apple.com>
728
729         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
730         https://bugs.webkit.org/show_bug.cgi?id=140939
731
732         Reviewed by Eric Carlson.
733
734         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
735
736         * Scripts/webkitdirs.pm:
737         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
738         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
739         and define a function called wanted.
740
741 2015-01-27  Daniel Bates  <dabates@apple.com>
742
743         Teach run-webkit-app --simulator how to install custom built app
744         https://bugs.webkit.org/show_bug.cgi?id=140691
745
746         Fix inadvertent omission of directory test flag in expression to check for the
747         existence of the iOS simulator device-specific directory for user installed apps.
748
749         * Scripts/webkitdirs.pm:
750         (hasUserInstalledAppInSimulatorDevice):
751
752 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
753
754         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
755         https://bugs.webkit.org/show_bug.cgi?id=87426
756         <rdar://problem/11527899>
757
758         Reviewed by Darin Adler.
759
760         Revise COMPtr to work better with our HashMap implementation. Use
761         modern loop syntax.
762
763         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
764         (AccessibilityController::~AccessibilityController):
765         (AccessibilityController::winNotificationReceived):
766         * DumpRenderTree/win/DumpRenderTree.cpp:
767         (dumpBackForwardListForAllWindows):
768
769 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
770
771         [Win] Enable JSC stress tests by default
772         https://bugs.webkit.org/show_bug.cgi?id=128307
773
774         Reviewed by Brent Fulgham.
775
776         * Scripts/run-javascriptcore-tests:
777
778 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
779
780         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
781         arguments for build and test scripts
782         https://bugs.webkit.org/show_bug.cgi?id=139748
783
784         Reviewed by Daniel Bates.
785
786         There was much confusion resulting from the multitude of aliases used to build/test for
787         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
788         tests directory.
789
790         This fixes an issue where run-api-tests and some other scripts failed when run with
791         --simulator.
792
793         * Scripts/build-webkit:
794         * Scripts/package-root:
795         (usage):
796         * Scripts/webkitdirs.pm:
797         (argumentsForConfiguration):
798         (determineXcodeSDK):
799         * Scripts/webkitpy/port/factory.py:
800         (platform_options):
801
802 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
803
804         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
805         https://bugs.webkit.org/show_bug.cgi?id=140203
806         rdar://problem/19198492
807
808         Reviewed by Sam Weinig.
809
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
811         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
812         (TEST):
813
814 2015-01-26  David Kilzer  <ddkilzer@apple.com>
815
816         Add iOS EWS to build.webkit.org/dashboard
817         <http://webkit.org/b/140627>
818
819         Reviewed by Alexey Proskuryakov.
820
821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
824         (BubbleQueueServer): Add ios-ews queue info.
825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
826         Add iOS8Device platform.
827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
828         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
829         iOS device logo.
830
831 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
832
833         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
834         https://bugs.webkit.org/show_bug.cgi?id=140896
835
836         Reviewed by Michael Saboff.
837         
838         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
839         makes our script do this.
840         
841         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
842         this would be harder given llvm's autoconf setup.
843
844         * Scripts/copy-webkitlibraries-to-product-directory:
845
846 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
847
848         Update bot assignments.
849
850         * BuildSlaveSupport/build.webkit.org-config/config.json:
851
852 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
853
854         Integrate WP python server into WebKit test framework
855         https://bugs.webkit.org/show_bug.cgi?id=127094
856
857         Reviewed by Ryosuke Niwa.
858
859         This patch adds W3C web server (wptserver) as a new HTTP server.
860         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
861         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
862
863         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
864         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
865         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
866
867         * Scripts/webkitpy/common/system/executive_mock.py:
868         (MockProcess.communicate):
869         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
870         (LayoutTestRunner.__init__):
871         (LayoutTestRunner.run_tests):
872         (LayoutTestRunner.start_servers):
873         (LayoutTestRunner.stop_servers):
874         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
875         (LayoutTestRunnerTests._run_tests):
876         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
877         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
878         (LayoutTestRunnerTests):
879         (LayoutTestRunnerTests.test_servers_started):
880         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
881         (Manager.__init__):
882         (Manager._is_http_test):
883         (Manager._is_web_platform_test):
884         (Manager._run_tests):
885         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
886         (ManagerTest.test_needs_servers.get_wpt_doc_root):
887         (ManagerTest.test_needs_servers.get_manager):
888         (ManagerTest.test_needs_servers):
889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
890         (parse_args):
891         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
892         (main):
893         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
894         (doc_root):
895         (base_url):
896         (WebPlatformTestServer):
897         (WebPlatformTestServer.__init__):
898         (WebPlatformTestServer._set_start_cmd):
899         (WebPlatformTestServer._copy_webkit_test_files):
900         (WebPlatformTestServer._clean_webkit_test_files):
901         (WebPlatformTestServer._prepare_config):
902         (WebPlatformTestServer._spawn_process):
903         (WebPlatformTestServer._stop_running_server):
904         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
905         (TestWebPlatformTestServer):
906         (TestWebPlatformTestServer.test_start_cmd):
907         * Scripts/webkitpy/port/base.py:
908         (Port.__init__):
909         (Port.to.start_web_platform_test_server):
910         (Port.to):
911         (Port.to.web_platform_test_server_doc_root):
912         (Port.to.web_platform_test_server_base_url):
913         (Port.to.stop_web_platform_test_server):
914         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
915         (Driver.__init__):
916         (Driver.is_web_platform_test):
917         (Driver.test_to_uri):
918         (Driver.uri_to_test):
919         (Driver._command_from_driver_input):
920         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
921         (DriverTest.test_test_to_uri):
922         (DriverTest.test_uri_to_test):
923
924 2015-01-26  Daniel Bates  <dabates@apple.com>
925
926         Teach run-webkit-app --simulator how to install custom built app
927         https://bugs.webkit.org/show_bug.cgi?id=140691
928
929         Reviewed by David Kilzer.
930
931         We should teach run-webkit-app --simulator how to install a custom built app.
932
933         Currently run-webkit-app --simulator can only run a system app or an app that
934         was installed using the simctl command line tool. For convenience we should
935         teach run-webkit-app --simulator how to install a custom built app.
936
937         As a side effect of this change run-safari --simulator will install and run
938         a custom built of MobileSafari (if it exists).
939
940         * Scripts/webkitdirs.pm:
941         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
942         Perl from the structure of the device.plist file.
943         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
944         file system check to determine the plist path for a Mac app bundle.
945         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
946         it will complain that it cannot find the file: "Domain ... does not exist".
947         (appDisplayNameFromBundle): Ditto.
948         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
949         until a simulator device is the specified state.
950         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
951         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
952         the specified device.
953         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
954         As implied by its name, this function will not return until the specified simulator
955         device UDID is in the shutdown state.
956         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
957         device with the specified UDID.
958         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
959         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
960         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
961         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
962         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
963         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
964         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
965         (hasUserInstalledAppInSimulatorDevice): Added.
966         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
967         "Booted" state.
968         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
969         switching between a system installed app and a custom built version of the same app (e.g.
970         custom build of MobileSafari) will erase all contents and settings in the simulator device.
971         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
972         as that was the only caller of this function.
973         (bootedIOSSimulatorDevice): Deleted.
974         (openIOSSimulator): Deleted.
975
976 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
977
978         Update bot assignments.
979
980         * BuildSlaveSupport/build.webkit.org-config/config.json:
981
982 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
983
984         Leaks bot shouldn't run JSC tests
985         https://bugs.webkit.org/show_bug.cgi?id=140877
986
987         Reviewed by Darin Adler.
988
989         Shaves off 48 minutes of time.
990
991         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
992         (TestLeaksFactory): Slim down the leaks queue.
993
994         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
995         * Scripts/webkitpy/port/ios.py:
996         (IOSSimulatorPort.print_leaks_summary):
997         * Scripts/webkitpy/port/mac.py:
998         (MacPort.print_leaks_summary):
999         Don't yell when leaks are detected.
1000
1001 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1002
1003         Refactor run-javascriptcore-tests
1004         https://bugs.webkit.org/show_bug.cgi?id=140824
1005
1006         Reviewed by Darin Adler.
1007
1008         Separated mozilla, stress test code paths and
1009         determining skipped mozilla tests into subroutines.
1010
1011         * Scripts/run-javascriptcore-tests:
1012         (runMozillaTests):
1013         (runJSCStressTests):
1014         (defaultJsDriverArgsForMozillaTests):
1015
1016 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1017
1018         [buildbot] Fix grammar of TestWithFailureCount
1019         https://bugs.webkit.org/show_bug.cgi?id=140884
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1024         (TestWithFailureCount):
1025         (TestWithFailureCount.commandComplete):
1026         (TestWithFailureCount.getText2):
1027         (RunUnitTests):
1028         (RunPythonTests):
1029         (RunPerlTests):
1030         (RunLLINTCLoopTests):
1031         (Run32bitJSCTests):
1032         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1033         (RunLLINTCLoopTestsTest.test_failure):
1034         (Run32bitJSCTestsTest.test_failure):
1035         (RunUnitTestsTest.assertFailures):
1036
1037 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1038
1039         Unreviewed. Moving myself to the committer section.
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1044
1045         [GTK] gtkdoc does not appear in DevHelp
1046         https://bugs.webkit.org/show_bug.cgi?id=139369
1047
1048         Reviewed by Philippe Normand.
1049
1050         * gtk/generate-gtkdoc: Create the generators in the main function
1051         and use them to get the local cross renference dependencies. Also
1052         pass the generator module name to webkitdom.write_doc_files().
1053         (get_gtkdoc_module_paths): Receive a list of local cross reference
1054         dependencies.
1055         (get_generator_for_config): Set the main_sgml_file property of the
1056         GtkDoc object from the configuration file.
1057         (generate_documentation): Generate the documentation for the given
1058         generator.
1059         (generate_documentation_for_config): Deleted.
1060         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1061         * gtk/webkitdom.py:
1062         (write_doc_files): Receive the module name used to build the
1063         -sections.txt filename.
1064
1065 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1066
1067         Unreviewed, rolling out r179107.
1068         https://bugs.webkit.org/show_bug.cgi?id=140880
1069
1070         The GCC in the bots doesn't support the AsyncTask
1071         implementation (Requested by KaL on #webkit).
1072
1073         Reverted changeset:
1074
1075         "[GTK] Enable IndexedDB"
1076         https://bugs.webkit.org/show_bug.cgi?id=98932
1077         http://trac.webkit.org/changeset/179107
1078
1079 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1080
1081         [EFL] Bump libseccomp version to 2.1.1
1082         https://bugs.webkit.org/show_bug.cgi?id=140357
1083
1084         Reviewed by Gyuyoung Kim.
1085
1086         * efl/jhbuild.modules:
1087
1088 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1089
1090         [GTK] Enable IndexedDB
1091         https://bugs.webkit.org/show_bug.cgi?id=98932
1092
1093         Reviewed by Žan Doberšek.
1094
1095         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1096
1097 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1098
1099         Would like leaks bot results at build.webkit.org/dashboard
1100         https://bugs.webkit.org/show_bug.cgi?id=122657
1101
1102         Reviewed by Darin Adler.
1103
1104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1105         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1106         than necessary, could use the ones from buildbot in more places.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1109         (BuildbotQueue): Reflect configuration option for leaks queues.
1110
1111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1112         Add leaks queues to performance column. First, leaks are about performance indeed,
1113         and second, this is where we have some space to spare.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1116         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1117         least a year.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1120         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1121         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1122         results - once the results are loaded, all rows are currently higher than that.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1125         (.leaks-popover): Added.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1128         Added.
1129
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1131         Load BuildbotLeaksQueueView.js.
1132
1133 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1134
1135         [Win] Add WebKit message loop interface.
1136         https://bugs.webkit.org/show_bug.cgi?id=140857
1137
1138         Reviewed by Brent Fulgham.
1139
1140         Added message loop interface which will run the message loop,
1141         and perform required tasks (like calling CFRunLoopRunInMode)
1142         on each iteration of the loop.
1143
1144         * WinLauncher/WinMain.cpp:
1145         (wWinMain): Use new message loop interface.
1146
1147 2015-01-24  Dan Bernstein  <mitz@apple.com>
1148
1149         update-webkit’s --internal option is unused
1150         https://bugs.webkit.org/show_bug.cgi?id=140861
1151
1152         Reviewed by Anders Carlsson.
1153
1154         * Scripts/update-webkit: Removed the option.
1155
1156 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1157
1158         DumpRenderTree needs to run with Windows native controls on Windows
1159         https://bugs.webkit.org/show_bug.cgi?id=25592
1160
1161         Reviewed by Anders Carlsson.
1162
1163         * DumpRenderTree/win/DumpRenderTree.cpp:
1164         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1165         (prepareConsistentTestingEnvironment): Ditto.
1166
1167 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1168
1169         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1170         <http://webkit.org/b/140787>
1171
1172         Reviewed by Daniel Bates.
1173
1174         * Scripts/webkitpy/port/ios.py:
1175         (IOSPort.determine_full_port_name): Instead of checking the type
1176         of the current host, test if /usr/bin/xcrun exists before trying
1177         to use it.
1178
1179 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1180
1181         Fix the false positive build failures on the Windows buildbots
1182         https://bugs.webkit.org/show_bug.cgi?id=140819
1183
1184         Reviewed by Brent Fulgham.
1185
1186         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1187         the default 20 minutes is enough for others since they produce output during the build.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1190         (BuildFactory.__init__):
1191
1192 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1193
1194         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1195         https://bugs.webkit.org/show_bug.cgi?id=140839
1196
1197         Reviewed by Dean Jackson.
1198
1199         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1200         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1201         from the IA2Locale structure and pass it to DRT.
1202
1203 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1204
1205         [Win] Update DRT Accessibility implementation to better match Mac.
1206         https://bugs.webkit.org/show_bug.cgi?id=140830
1207
1208         Reviewed by Dean Jackson.
1209
1210         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1211         (AccessibilityUIElement::titleUIElement):
1212         (AccessibilityUIElement::parentElement):
1213         (convertToDRTLabel):
1214         (AccessibilityUIElement::role):
1215         (AccessibilityUIElement::title):
1216         (AccessibilityUIElement::description):
1217         (AccessibilityUIElement::stringValue):
1218         (AccessibilityUIElement::helpText):
1219         (AccessibilityUIElement::isFocused):
1220
1221 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1222
1223         REGRESSION: run-perf-tests --profiler= seems to have broken
1224         https://bugs.webkit.org/show_bug.cgi?id=113528
1225
1226         Reviewed by Daniel Bates.
1227
1228         The problem is that "perf --record" (or the equivalent call for
1229         other profilers) is never called whenever there is a wrapper
1230         option in the port. We should inject the profiler call first
1231         (should it exists) and then use the port wrapper.
1232
1233         * Scripts/webkitpy/port/driver.py:
1234         (Driver._command_wrapper):
1235         * Scripts/webkitpy/port/driver_unittest.py:
1236         (DriverTest.test_profiler_and_wrapper): New unit test.
1237
1238 2015-01-22  David Kilzer  <ddkilzer@apple.com>
1239
1240         configure-xcode-for-ios-development needs to import webkitdirs.pm
1241         <http://webkit.org/b/140704>
1242
1243         Fixes the following runtime error:
1244
1245             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
1246
1247         * Scripts/configure-xcode-for-ios-development: Add back code to
1248         import webkitdirs.pm for the exitStatus() method.  Not sure why
1249         I removed it before patch review.
1250
1251 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
1252
1253         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
1254         https://bugs.webkit.org/show_bug.cgi?id=140795
1255
1256         Reviewed by Jon Honeycutt.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/config.json:
1259         r178847 accidentally remove the scheduler for this bot. Re-add it to the
1260         Yosemite scheduler.
1261
1262 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
1263
1264         [Win] Expose missing editing features through WebView interface
1265         https://bugs.webkit.org/show_bug.cgi?id=140773
1266         <rdar://problem/19565421>
1267
1268         Reviewed by Dean Jackson.
1269
1270         Connect the various WebView editing delegate methods to our
1271         test infrastructure. Also prefer _bstr_t to raw BSTR types
1272         to simplify life cycle management.
1273
1274         * DumpRenderTree/win/DumpRenderTree.cpp:
1275         (resetWebViewToConsistentStateBeforeTesting):
1276         * DumpRenderTree/win/EditingDelegate.cpp:
1277         (EditingDelegate::QueryInterface):
1278         (dumpPath):
1279         (dump):
1280         (EditingDelegate::shouldBeginEditingInDOMRange):
1281         (EditingDelegate::shouldEndEditingInDOMRange):
1282         (EditingDelegate::shouldInsertNode):
1283         (EditingDelegate::shouldInsertText):
1284         (EditingDelegate::shouldDeleteDOMRange):
1285         (EditingDelegate::shouldChangeSelectedDOMRange):
1286         (EditingDelegate::shouldApplyStyle):
1287         (EditingDelegate::shouldChangeTypingStyle):
1288         (EditingDelegate::doPlatformCommand):
1289         (EditingDelegate::webViewDidBeginEditing):
1290         (EditingDelegate::webViewDidChange):
1291         (EditingDelegate::webViewDidEndEditing):
1292         (EditingDelegate::webViewDidChangeTypingStyle):
1293         (EditingDelegate::webViewDidChangeSelection):
1294         (EditingDelegate::checkSpellingOfString):
1295         (EditingDelegate::onNotify):
1296         * DumpRenderTree/win/EditingDelegate.h:
1297
1298 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1299
1300         Add a build flag for ES6 class syntax
1301         https://bugs.webkit.org/show_bug.cgi?id=140760
1302
1303         Reviewed by Michael Saboff.
1304
1305         * Scripts/webkitperl/FeatureList.pm:
1306
1307 2015-01-22  Daniel Bates  <dabates@apple.com>
1308
1309         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
1310         runtime in simctl output
1311         https://bugs.webkit.org/show_bug.cgi?id=140751
1312
1313         Reviewed by David Kilzer.
1314
1315         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
1316         with an error because it does not know how to parse the output of the simctl tool
1317         to identify an Apple Internal runtime.
1318
1319         * Scripts/webkitpy/xcode/simulator.py:
1320         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
1321         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
1322         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
1323         the runtime is an internal runtime.
1324         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
1325         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
1326         appropriate value.
1327         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
1328         it updates the appropriate Runtime object.
1329         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
1330         looking up a Runtime object for an internal runtime.
1331
1332 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
1333
1334         LeaksViewer doesn't show recent builds if there are less than 10
1335         https://bugs.webkit.org/show_bug.cgi?id=140716
1336
1337         Reviewed by Tim Horton.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1340
1341 2015-01-22  Lucas Forschler  <lforschler@apple.com>
1342
1343         Add Apple build slaves.
1344         Fixed text alignment for slave list.
1345         
1346         Unreviewed.
1347         
1348         * BuildSlaveSupport/build.webkit.org-config/config.json:
1349
1350 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1351
1352         Teach build.webkit.org about bot308 and bot309.
1353         
1354         Unreviewed.
1355         
1356         * BuildSlaveSupport/build.webkit.org-config/config.json:
1357
1358 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1359
1360         Add two Apple Mavericks slaves.
1361         
1362         Unreviewed.
1363         
1364         * BuildSlaveSupport/build.webkit.org-config/config.json:
1365
1366 2015-01-21  Daniel Bates  <dabates@apple.com>
1367
1368         Add iOS WebKit1 TestExpectation file
1369         https://bugs.webkit.org/show_bug.cgi?id=140739
1370
1371         Reviewed by David Kilzer.
1372
1373         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
1374         expectations in directory LayoutTests/platform/ios-simulator-wk1.
1375
1376         * Scripts/webkitpy/port/ios.py:
1377         (IOSSimulatorPort.default_baseline_search_path):
1378
1379 2015-01-21  David Kilzer  <ddkilzer@apple.com>
1380
1381         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
1382         <http://webkit.org/b/140704>
1383
1384         Reviewed by Daniel Bates.
1385
1386         * Scripts/configure-xcode-for-ios-development:
1387         - Update copyright.
1388         - Remove FIXME addressed by r178709.
1389         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
1390         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
1391         missing headers from iphonesimulator SDK to iphoneos SDK.
1392         (sdkDirectory): Add method that returns SDK directory.
1393         (sdkPlatformDirectory): Extract method from
1394         xcodeSDKSpecificationsPath() that returns SDK platform
1395         directory.
1396         (xcodeSDKSpecificationsPath): Update to use
1397         sdkPlatformDirectory().
1398
1399 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
1400
1401         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
1402         https://bugs.webkit.org/show_bug.cgi?id=140731
1403
1404         Reviewed by Tim Horton.
1405
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1407         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
1408
1409 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
1410
1411         [Win] eventSender does not support scalePageBy
1412         https://bugs.webkit.org/show_bug.cgi?id=140726
1413         <rdar://problem/19549865>
1414
1415         Reviewed by Dean Jackson.
1416
1417         * DumpRenderTree/win/EventSender.cpp:
1418         (scalePageByCallback): Provide implementation using new WebView method.
1419
1420 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1421
1422         Remove Apple Mountain Lion Build & Test slaves.
1423         
1424         Unreviewed.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/config.json:
1427
1428 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1429
1430         Remove ENABLE(INSPECTOR) ifdef guards
1431         https://bugs.webkit.org/show_bug.cgi?id=140668
1432
1433         Reviewed by Darin Adler.
1434
1435         * DumpRenderTree/mac/TestRunnerMac.mm:
1436         (TestRunner::showWebInspector):
1437         (TestRunner::closeWebInspector):
1438         (TestRunner::evaluateInWebInspector):
1439         * Scripts/webkitperl/FeatureList.pm:
1440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1441         (WTR::TestRunner::showWebInspector):
1442         (WTR::TestRunner::closeWebInspector):
1443         (WTR::TestRunner::evaluateInWebInspector):
1444         * WebKitTestRunner/TestInvocation.cpp:
1445         (WTR::TestInvocation::invoke):
1446
1447 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
1448
1449         Update build.webkit.org/dashboard to match current Mac queues.
1450
1451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
1453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
1455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1458         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
1459         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
1460
1461 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1462
1463         Update Apple MountainLion Leaks slave to Yosemite
1464         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
1465         
1466         Unreviewed.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/config.json:
1469
1470 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1471
1472         Update LeaksViewer from MountainLion to Yosemite
1473         
1474         Reviewed by Alexey Proskuryakov.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1477         (LeaksViewer._displayURLPrompt):
1478
1479 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
1480
1481         Fix EWS python unit tests and address code comments as per 140476
1482         https://bugs.webkit.org/show_bug.cgi?id=140637
1483
1484         Reviewed by David Kilzer.
1485
1486         * Scripts/webkitpy/port/base.py:
1487         (Port):
1488         (Port.__init__):
1489         Adds DEFAULT_ARCHITECTURE member.
1490         (Port.architecture):
1491         Removes architecture member and instead uses
1492         self.get_option('architecture'). Also removes redundant architecture
1493         method.
1494         (Port.set_architecture):
1495         Adds a setter for the architecture variable to be able to set a flag
1496         upon modification.
1497         (Port.test_configuration):
1498         Uses self.architecture() instead of self._architecture.
1499         * Scripts/webkitpy/port/ios.py:
1500         Overrides DEFAULT_ARCHITECTURE.
1501         (IOSPort):
1502         (IOSPort.determine_full_port_name):
1503         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
1504         strip. Fixes regex to not match arbitrary characters after the
1505         relevent digits are matched.
1506         (IOSPort.__init__):
1507         Removes old _architecture defaulting strategy.
1508         (IOSPort._build_driver_flags):
1509         Uses self.architecture() instead of self._architecture.
1510         (IOSSimulatorPort):
1511         Overrides DEFAULT_ARCHITECTURE.
1512         (IOSSimulatorPort.__init__):
1513         Removes old _architecture defaulting strategy.
1514         * Scripts/webkitpy/port/mac.py:
1515         (MacPort):
1516         Overrides DEFAULT_ARCHITECTURE.
1517         (MacPort.__init__):
1518         Removes old _architecture defaulting strategy.
1519         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1520         (AbstractEarlyWarningSystem.run_command):
1521         Checks the did_override_architecture flag to determine whether to add
1522         the --architecture option.
1523         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1524         Uses ews.architecture rather than trying to discern the correct
1525         architecture using a port object.
1526         (EarlyWarningSystemTest._default_expected_logs):
1527         * Scripts/webkitpy/tool/commands/queues.py:
1528         Removes use of optparse, and removes the import statement.
1529         (AbstractQueue.__init__):
1530         (PatchProcessingQueue.begin_work_queue):
1531
1532 2015-01-20  Sam Weinig  <sam@webkit.org>
1533
1534         Attempt to fix Mountain Lion and EFL tests.
1535
1536         * WebKitTestRunner/TestController.cpp:
1537         (WTR::TestController::initialize):
1538         Disable Process-per-tab and network process on Mountain Lion and EFL.
1539
1540 2015-01-20  Darin Adler  <darin@apple.com>
1541
1542         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
1543         https://bugs.webkit.org/show_bug.cgi?id=140679
1544
1545         Reviewed by Anders Carlsson.
1546
1547         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1548         Removed a reference to SVGElementInstanceList.
1549
1550 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1551
1552         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
1553         https://bugs.webkit.org/show_bug.cgi?id=140028
1554
1555         Reviewed by Carlos Garcia Campos.
1556
1557         This won't work as expected, since this function is called before the
1558         WebViewTest constructor completes.
1559
1560         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1561
1562 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1563
1564         configure-xcode-for-ios-development needs to update iPhoneOS SDK
1565         <http://webkit.org/b/140661>
1566
1567         Reviewed by Daniel Bates.
1568
1569         * Scripts/configure-xcode-for-ios-development: Add for() loop to
1570         run createXcodeSpecificationFilesForSDKIfNeeded() for both
1571         "iphoneos" and "iphonesimulator" SDKs.
1572         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
1573         the main body of the script.
1574
1575 2015-01-20  Tomas Popela  <tpopela@redhat.com>
1576
1577         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
1578         https://bugs.webkit.org/show_bug.cgi?id=139443
1579
1580         Reviewed by Carlos Garcia Campos.
1581
1582         Create the new test cases for setting the editable property on the web
1583         view and on the contenteditable enabled document. Also rework the
1584         current tests that are expecting that the web view is editable.
1585
1586         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1587         (loadTestHtml):
1588         (testWebViewEditorCutCopyPasteNonEditable):
1589         (testWebViewEditorCutCopyPasteEditable):
1590         (testWebViewEditorSelectAllNonEditable):
1591         (testWebViewEditorSelectAllEditable):
1592         (runEditorEditableCutTests):
1593         (testWebViewEditorEditableOnNonEditable):
1594         (testWebViewEditorEditableOnContentEditable):
1595         (testWebViewEditorNonEditable):
1596         (beforeAll):
1597         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1598         (WebViewTest::isEditable):
1599         (WebViewTest::setEditable):
1600
1601 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1602
1603         [GTK] Add an option to create WebKitWebView snapshots with transparent background
1604         https://bugs.webkit.org/show_bug.cgi?id=140617
1605
1606         Reviewed by Gustavo Noronha Silva.
1607
1608         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1609         (testWebViewSnapshot): Check that the same snapshot with
1610         transparent background is different than the default one filled
1611         with white.
1612
1613 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         [GTK] Add API to change the WebKitWebView background color
1616         https://bugs.webkit.org/show_bug.cgi?id=140610
1617
1618         Reviewed by Gustavo Noronha Silva.
1619
1620         Add --bg-color command line option to MiniBrowser to be able to
1621         manually test the API passing any RGBA color to MiniBrowser.
1622         Also add a simple unit test to check that getting and setting
1623         colors from the API point of view.
1624
1625         * MiniBrowser/gtk/BrowserWindow.c:
1626         (browser_window_set_background_color):
1627         * MiniBrowser/gtk/BrowserWindow.h:
1628         * MiniBrowser/gtk/main.c:
1629         (createBrowserWindow):
1630         (parseBackgroundColor):
1631         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1632         (testWebViewBackgroundColor):
1633         (beforeAll):
1634
1635 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1636
1637         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
1638         https://bugs.webkit.org/show_bug.cgi?id=140665
1639
1640         Reviewed by Brian Burg.
1641
1642         * DumpRenderTree/win/UIDelegate.cpp:
1643         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
1644         match expected test output.
1645
1646 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
1647
1648         Remove the support for custom suffixes on ChangeLog
1649         https://bugs.webkit.org/show_bug.cgi?id=140648
1650
1651         Reviewed by David Kilzer.
1652
1653         Custom suffixes were used for the iOS branch of WebKit.
1654         Now that everything is opensource, there is no need for it.
1655
1656         * Scripts/VCSUtils.pm:
1657         (changeLogSuffix): Deleted.
1658         (changeLogFileName): Deleted.
1659         * Scripts/commit-log-editor:
1660         * Scripts/prepare-ChangeLog:
1661         (getLatestChangeLogs):
1662         (generateNewChangeLogs):
1663         (generateFileList):
1664         * Scripts/resolve-ChangeLogs:
1665         (findChangeLog):
1666
1667 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1668
1669         Adjust naming of action menu SPI
1670         https://bugs.webkit.org/show_bug.cgi?id=140644
1671         <rdar://problem/19448129>
1672
1673         Reviewed by Brian Weinstein.
1674
1675         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1676         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1677         (TestWebKitAPI::TEST):
1678
1679 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1680
1681         [GTK] Generate the make dist manifest from a CMake template file
1682         https://bugs.webkit.org/show_bug.cgi?id=139387
1683
1684         Reviewed by Martin Robinson.
1685
1686         Remove the code that performs variable substitution on manifest.txt.
1687         Replace the custom variables used in that file with CMake variables.
1688
1689         * gtk/make-dist.py:
1690         (Manifest.add_directory):
1691         (Manifest.get_full_source_path):
1692         (Manifest.process_line):
1693         (Manifest.resolve_variables): Deleted.
1694         (Manifest.get_full_tarball_path): Deleted.
1695         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
1696
1697 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1698
1699         [Win] Correct merge error in last commit.
1700
1701         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1702         (findAccessibleObjectById): Undo accidental paste made during landing.
1703
1704 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
1705
1706         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
1707         https://bugs.webkit.org/show_bug.cgi?id=139906
1708
1709         Reviewed by Dean Jackson.
1710
1711         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
1712         to use them. This patch fixes that.
1713
1714         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1715         (findAccessibleObjectById):
1716         (AccessibilityController::focusedElement):
1717         (logEventProc):
1718         (notificationListenerProc):
1719         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1720         (AccessibilityUIElement::getChildAtIndex):
1721         (AccessibilityUIElement::titleUIElement):
1722         (self):
1723         (AccessibilityUIElement::role):
1724         (AccessibilityUIElement::valueDescription):
1725         (accessibilityState):
1726         (AccessibilityUIElement::isChecked):
1727         * DumpRenderTree/win/DumpRenderTree.cpp:
1728         (dumpFrameScrollPosition):
1729         (dumpFramesAsText):
1730         * DumpRenderTree/win/PolicyDelegate.cpp:
1731         (PolicyDelegate::decidePolicyForNavigationAction):
1732         * DumpRenderTree/win/UIDelegate.cpp:
1733         (UIDelegate::exceededDatabaseQuota):
1734         * WinLauncher/Common.cpp:
1735         (setWindowText):
1736
1737 2015-01-19  Dean Jackson  <dino@apple.com>
1738
1739         Add "override" to fix the build with newer clangs.
1740
1741         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1742         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
1743
1744 2015-01-19  David Kilzer  <ddkilzer@apple.com>
1745
1746         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
1747         <http://webkit.org/b/140623>
1748
1749         Reviewed by Daniel Bates.
1750
1751         * Scripts/build-webkit: Update help for --device switch.
1752         * Scripts/webkitdirs.pm:
1753         (determineXcodeSDK): When passing --device, prefer the internal
1754         iOS SDK if it exists, else fall back to the external iOS SDK.
1755         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
1756         xcodebuild instead of trying to sanitize values.
1757
1758 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
1759
1760         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
1761         https://bugs.webkit.org/show_bug.cgi?id=140606
1762
1763         Reviewed by Csaba Osztrogonác.
1764
1765         * Scripts/webkitpy/bindings/main.py:
1766         (BindingsTests.generate_supplemental_dependency):
1767         (BindingsTests.main):
1768
1769 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         [GTK] [WK2] TestWebKitWebView snapshot fails
1772         https://bugs.webkit.org/show_bug.cgi?id=120404
1773
1774         Reviewed by Žan Doberšek.
1775
1776         Rework the test to make sure the snapshot is always created at the
1777         desired size.
1778
1779         * Scripts/run-gtk-tests:
1780         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
1781         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1782         (testWebViewSnapshot): Use a fixed size for the document, and
1783         disable scrollbars to make sure the visible area is always the
1784         WebView size.
1785         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1786         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
1787         and height parameters to create the window with a given size.
1788         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1789
1790 2015-01-18  David Kilzer  <ddkilzer@apple.com>
1791
1792         iOS EWS queue name should be consistent
1793         <http://webkit.org/b/140585>
1794
1795         Reviewed by Daniel Bates.
1796
1797         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
1798         to 'ios'.
1799         * Scripts/webkitpy/common/config/ports.py: Ditto.
1800         (DeprecatedPort.port):
1801         (IOSPort):
1802         * Scripts/webkitpy/port/ios.py: Ditto.
1803         (IOSPort):
1804
1805         * Scripts/webkitpy/port/factory.py:
1806         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
1807         appears before ios.IOSPort.  If this is not done,
1808         `run-webkit-tests --ios-simulator` will get the wrong Port class
1809         (IOSPort instead of IOSSimulatorPort) due to the way that
1810         PortFactory.get() uses prefix matching of <Port>.port_name to
1811         find the correct class to use.
1812
1813 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
1814
1815         build.webkit.org/dashboard: OS X EWS is now on Mavericks
1816         https://bugs.webkit.org/show_bug.cgi?id=140595
1817
1818         Reviewed by Csaba Osztrogonác.
1819
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1821         (BubbleQueueServer):
1822
1823 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1824
1825         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
1826
1827         * Scripts/webkitpy/port/ios.py:
1828         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
1829         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
1830         the Mountain Lion and Mavericks bots.
1831
1832 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1833
1834         Attempt to fix webkitpy tests on GTK Linux ports
1835
1836         * Scripts/webkitpy/port/ios.py:
1837         (IOSPort.determine_full_port_name): Set a sensible default if
1838         not running on a Mac platform or if no iOS SDK is installed.
1839
1840 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
1841
1842         Create iOS-EWS client queue
1843         https://bugs.webkit.org/show_bug.cgi?id=140476
1844
1845         Reviewed by Alexey Proskuryakov.
1846
1847         * EWSTools/start-queue-mac.sh:
1848         Adds call to configure-xcode-for-ios-development for iOS EWS.
1849         * Scripts/webkitpy/common/config/ews.json:
1850         Adds the iOS EWS config entry.
1851         * Scripts/webkitpy/common/config/ports.py:
1852         (DeprecatedPort.port):
1853         Adds IOSPort to the port map.
1854         (IOSPort):
1855         (IOSPort.build_webkit_command):
1856         Adds --sdk=iphoneos to the webkit build command.
1857         * Scripts/webkitpy/port/base.py:
1858         (Port.architecture):
1859         Adds an accessor for the architecture member variable.
1860         * Scripts/webkitpy/port/factory.py:
1861         (PortFactory):
1862         Adds IOSPort to the port class list.
1863         * Scripts/webkitpy/port/ios.py:
1864         Adds the IOSPort to encapsulate iOS-specific things.
1865         (IOSPort):
1866         (IOSPort.determine_full_port_name):
1867         (IOSPort.__init__):
1868         (IOSPort._build_driver_flags):
1869         (IOSPort.operating_system):
1870         * Scripts/webkitpy/tool/commands/download_unittest.py:
1871         Adds the archetecture option to the mock options.
1872         (DownloadCommandsTest._default_options):
1873         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1874         Appends the archetecture option into calls to webkit-patch.
1875         (AbstractEarlyWarningSystem.review_patch):
1876         (AbstractEarlyWarningSystem.run_command):
1877         (AbstractEarlyWarningSystem.load_ews_classes):
1878         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1879         Adds logic to soothe the unittest now that --architecture is being
1880         thrown around everywhere.
1881         (EarlyWarningSystemTest._default_expected_logs):
1882         * Scripts/webkitpy/tool/commands/queues.py:
1883         Adds glue code to ferry the --architecture option around.
1884         (AbstractQueue.__init__):
1885         (PatchProcessingQueue.begin_work_queue):
1886         * Scripts/webkitpy/tool/steps/abstractstep.py:
1887         Adds the archetecture option to all AbstractSteps so that
1888         EarlyWarningSystem doesn't start shoving --architecture into
1889         unsuspecting commands.
1890         (AbstractStep.options):
1891         * Scripts/webkitpy/tool/steps/build.py:
1892         Translates the --architecture option into an ARCHS= format to pass to
1893         build-webkit.
1894         (Build.build):
1895         * Scripts/webkitpy/tool/steps/options.py:
1896         Adds a definition for the --architecture option.
1897         (Options):
1898
1899 2015-01-16  Sam Weinig  <sam@webkit.org>
1900
1901         Add a basic configuration object for WKView
1902         https://bugs.webkit.org/show_bug.cgi?id=140559
1903
1904         Reviewed by Anders Carlsson.
1905
1906         Add tests for WKPageConfigurationRef.
1907
1908         * TestWebKitAPI/PlatformWebView.h:
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
1911         (TestWebKitAPI::TEST):
1912         (TestWebKitAPI::didFinishLoadForFrame):
1913         (TestWebKitAPI::setPageLoaderClient):
1914         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1915         (TestWebKitAPI::PlatformWebView::initialize):
1916         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1917
1918 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
1919
1920         WeakPtr functions crash when created with default constructor
1921         https://bugs.webkit.org/show_bug.cgi?id=140479
1922
1923         Reviewed by Andreas Kling.
1924
1925         Add WeakPtr API tests.
1926
1927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1928         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
1929         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
1930
1931 2015-01-16  Chris Dumez  <cdumez@apple.com>
1932
1933         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
1934         https://bugs.webkit.org/show_bug.cgi?id=140568
1935
1936         Reviewed by Alexey Proskuryakov.
1937
1938         Fix the script parsing CSSPropertyNames.in to stop splitting lines
1939         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
1940         e.g. "Longhands=background-position-x|background-position-y".
1941         This would confuse the script and treat this as a CSS property:
1942         "background-position-x|background-position-y".
1943
1944         We now split on white space and treat the first string on the line
1945         to be the property name (this is the syntax in this file).
1946
1947         * Scripts/webkitpy/w3c/test_converter.py:
1948         (_W3CTestConverter.__init__):
1949         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1950
1951 2015-01-16  Daniel Bates  <dabates@apple.com>
1952
1953         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
1954         https://bugs.webkit.org/show_bug.cgi?id=135589
1955
1956         Reviewed by David Kilzer.
1957
1958         Derived from a patch by David Farler.
1959
1960         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
1961         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
1962         in terms of the simctl command line utility.
1963
1964         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
1965         (eraseIOSSimulatorDevice): Added.
1966         (bootedIOSSimulatorDevice): Added.
1967         (iosSimulatorApplicationsPath): Added.
1968         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
1969         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
1970         (quitIOSSimulator): Added.
1971         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
1972         the specified name and currently selected iOS runtime.
1973         (isIOSSimulatorSystemInstalledApp): Added.
1974         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
1975         (deleteiOSSimulatorDevice): Deleted.
1976         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
1977         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
1978
1979 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
1980
1981         Resurrect the WinCairo bot.
1982         https://bugs.webkit.org/show_bug.cgi?id=139908
1983
1984         Reviewed by Csaba Osztrogonác.
1985
1986         * BuildSlaveSupport/build.webkit.org-config/config.json:
1987         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1988         (appendCustomBuildFlags):
1989         * BuildSlaveSupport/test-result-archive:
1990         (archiveTestResults):
1991         Add WinCairo buildbot.
1992
1993 2015-01-16  Chris Dumez  <cdumez@apple.com>
1994
1995         webkit-patch should auto-install the keyring python module
1996         https://bugs.webkit.org/show_bug.cgi?id=140547
1997
1998         Reviewed by David Kilzer.
1999
2000         Auto-install the keyring python module. This is the module that
2001         webkit-patch uses for cross-platform access to the keyring
2002         service.
2003
2004         Without this module, if the password if not in the keychain,
2005         webkit-patch will keep asking for your username / password and
2006         never remember them.
2007
2008         * Scripts/webkitpy/common/net/credentials.py:
2009         * Scripts/webkitpy/thirdparty/__init__.py:
2010         (AutoinstallImportHook.find_module):
2011         (AutoinstallImportHook._install_keyring):
2012
2013 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2014
2015         Remove ENABLE(SQL_DATABASE) guards
2016         https://bugs.webkit.org/show_bug.cgi?id=140434
2017
2018         Reviewed by Darin Adler.
2019
2020         * Scripts/webkitperl/FeatureList.pm:
2021
2022 2015-01-15  Daniel Bates  <dabates@apple.com>
2023
2024         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2025         https://bugs.webkit.org/show_bug.cgi?id=139685
2026         <rdar://problem/19281317>
2027
2028         Reviewed by Simon Fraser.
2029
2030         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2031         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2032
2033         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2034         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2035         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2036         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2037         dumping the test result again. Instead we want DRT to dump the test result synchronously
2038         such that we capture the state of the web page either when the page is loaded or when
2039         window.testRunner.notifyDone() is called.
2040
2041         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2042         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2043         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2044         flush CA transactions to the window.
2045         * DumpRenderTree/mac/DumpRenderTree.mm:
2046         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2047         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2048         (dump): Renamed; formerly named dumpTestResults().
2049         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2050         enabling repaint support on iOS.
2051         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2052         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2053         (dumpTestResults): Deleted.
2054
2055 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2056
2057         [Win] Miscellaneous DRT fixes
2058         https://bugs.webkit.org/show_bug.cgi?id=116562
2059
2060         Reviewed by Tim Horton.
2061
2062         While investigating the cause of several Windows crashes, I found:
2063         (1) Messy conversions to and from BSTR types
2064         (2) Weird mixes of wide-string and narrow string conversions
2065         (3) Passing nullptr to some CoreFoundation routines that do not
2066             permit null arguments.
2067         (4) Commands to link the executable to the VS2005 runtime.
2068
2069         This patch cleans up these issues to improve DRT reliability on
2070         Windows.
2071
2072         * DumpRenderTree/cg/ImageDiffCG.cpp:
2073         (main): Get rid of VS2005 runtime linking.
2074         * DumpRenderTree/win/DumpRenderTree.cpp:
2075         (urlSuitableForTestResult): Protect against being asked
2076         to process an empty URL.
2077         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2078         than converting to/from wchar_t buffers.
2079         (runTest): Simplify string and BSTR handling.
2080         (createWebViewAndOffscreenWindow): Ditto.
2081         (main): Get rid of VS2005 runtime linking.
2082         * DumpRenderTree/win/TestRunnerWin.cpp:
2083         (jsStringRefToWString): Simplify code.
2084         (TestRunner::pathToLocalResource):
2085         (TestRunner::setUserStyleSheetLocation):
2086         * TestWebKitAPI/win/main.cpp: Get rid of
2087         VS2005 runtime linking.
2088         * win/DLLLauncher/DLLLauncherMain.cpp:
2089         (wWinMain): Ditto.
2090
2091 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2092
2093         Stop hardcoding mac-mountainlion in commit queue
2094         https://bugs.webkit.org/show_bug.cgi?id=140492
2095
2096         Reviewed by Anders Carlsson.
2097
2098         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2099         there should be no change in behavior, because:
2100         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2101         using it to create a port object.
2102         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2103         is actually correct to use "mac" for the name there. We only used to get the expected
2104         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2105         for unknown deprecated port names.
2106
2107         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2108
2109 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2110
2111         Create iOS-EWS server queue
2112         https://bugs.webkit.org/show_bug.cgi?id=140473
2113
2114         Reviewed by Benjamin Poulain.
2115
2116         * QueueStatusServer/app.yaml: Updates the SVN version number.
2117         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2118         * QueueStatusServer/model/queues.py:         
2119         (Queue.display_name): Makes sure the display name is pretty!
2120
2121 2015-01-14  Daniel Bates  <dabates@apple.com>
2122
2123         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2124         https://bugs.webkit.org/show_bug.cgi?id=140301
2125         <rdar://problem/19389266>
2126
2127         Reviewed by Jon Honeycutt.
2128
2129         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2130         with an unavailable runtime.
2131
2132         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2133         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2134         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2135         specified runtime cannot be used because it is unavailable.
2136         * Scripts/webkitpy/port/ios.py:
2137         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2138         which was formerly named testing_device.
2139         * Scripts/webkitpy/xcode/simulator.py:
2140         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2141         more robust than looking up the simulator device by name and runtime. This approach also
2142         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2143         unavailable runtimes under the same iOS heading it would use to show it as available).
2144         (Simulator.find_device_by_udid): Added.
2145         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2146         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2147         (Simulator.available_runtimes): Added.
2148         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2149         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2150         first element of the sorted list is the runtime with the highest version number.
2151         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2152
2153 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2154
2155         Remove WK2 Windows cruft
2156         https://bugs.webkit.org/show_bug.cgi?id=140440
2157
2158         Reviewed by Anders Carlsson.
2159
2160         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2161         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2162         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2163
2164 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2165
2166         Fix TestWTF failed in TestWebKitAPI
2167         https://bugs.webkit.org/show_bug.cgi?id=140333
2168
2169         Reviewed by Sam Weinig.
2170
2171         Clear the std::ostringstream before starting test.
2172
2173         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2174         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2175
2176 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2177
2178         TestWebKitWebContext depends on British English spellcheck dictionary
2179         https://bugs.webkit.org/show_bug.cgi?id=140403
2180
2181         Reviewed by Martin Robinson.
2182
2183         Install all English hunspell dictionaries on Fedora and Arch.
2184
2185         * gtk/install-dependencies:
2186
2187 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2188
2189         [GTK] install-dependencies should grok dnf
2190         https://bugs.webkit.org/show_bug.cgi?id=140396
2191
2192         Reviewed by Martin Robinson.
2193
2194         Fedora: install dependencies with dnf if yum is not installed.
2195
2196         * gtk/install-dependencies:
2197
2198 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2199
2200         [EFL][GTK] Fix build after r178309  
2201         https://bugs.webkit.org/show_bug.cgi?id=140381
2202
2203         Reviewed by Gyuyoung Kim.
2204
2205         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2206
2207 2015-01-11  Sam Weinig  <sam@webkit.org>
2208
2209         Remove support for SharedWorkers
2210         https://bugs.webkit.org/show_bug.cgi?id=140344
2211
2212         Reviewed by Anders Carlsson.
2213
2214         * Scripts/webkitperl/FeatureList.pm:
2215
2216 2015-01-12  Anders Carlsson  <andersca@apple.com>
2217
2218         Make delegates conform to formal delegate protocols
2219         https://bugs.webkit.org/show_bug.cgi?id=140370
2220
2221         Reviewed by Dan Bernstein.
2222
2223         * DumpRenderTree/mac/TestRunnerMac.mm:
2224         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2225         (TestRunner::setGeolocationPermission):
2226
2227 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2228
2229         build-webkit: silence output of 'which'
2230         https://bugs.webkit.org/show_bug.cgi?id=140278
2231
2232         Reviewed by Daniel Bates.
2233
2234         Use a more elegent test for the existance of ninja and eclipse.
2235
2236         * Scripts/webkitdirs.pm:
2237         (commandExists): Don't assume the command supports --version
2238         (canUseNinja): Use commandExists()
2239         (canUseEclipse): Use commandExists()
2240
2241 2015-01-09  Sam Weinig  <sam@webkit.org>
2242
2243         Update the output format for run-api-tests
2244         https://bugs.webkit.org/show_bug.cgi?id=140332
2245
2246         Reviewed by Dan Bernstein.
2247
2248         Changes the output format for run-api-tests be a bit simpler (no longer 
2249         indented based on suite, as we were not really using suite very well) but
2250         also include details in the case of failure.
2251
2252         Changes verbose mode to no longer spew out the gtest default printer output,
2253         as the custom printer now includes the failure information.
2254
2255         * Scripts/run-api-tests:
2256         (runTestsBySuite):
2257         (runTest):
2258         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
2259         with colorized variants and strip out leaks spew (the leaks can be added back using
2260         the new --show-leaks argument).
2261
2262         * TestWebKitAPI/TestsController.cpp:
2263         (TestWebKitAPI::Printer::OnTestPartResult):
2264         (TestWebKitAPI::Printer::OnTestEnd):
2265         (TestWebKitAPI::TestsController::run):
2266         Implement a custom result printer that just prints out the information we want.
2267
2268 2015-01-09  Sam Weinig  <sam@webkit.org>
2269
2270         TestWebKitAPI should print out the lists that fail at the end
2271         https://bugs.webkit.org/show_bug.cgi?id=140329
2272
2273         Reviewed by Tim Horton.
2274
2275         * Scripts/run-api-tests:
2276         (runTestsBySuite):
2277         Print out failures and timeouts in all modes, not just verbose.
2278
2279 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
2280
2281         Make bmalloc work with ASan
2282         https://bugs.webkit.org/show_bug.cgi?id=140194
2283
2284         Reviewed by Mark Lam.
2285
2286         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
2287         ASan automatically (by forwarding to system malloc at runtime).
2288
2289 2015-01-09  Daniel Bates  <dabates@apple.com>
2290
2291         [iOS] Make DumpRenderTree build with public SDK
2292         https://bugs.webkit.org/show_bug.cgi?id=140311
2293
2294         Reviewed by Sam Weinig.
2295
2296         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
2297         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
2298         Additionally, remove unused header CoreGraphics/CGFontDB.h.
2299
2300         * DumpRenderTree/mac/DumpRenderTree.mm:
2301         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
2302
2303 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
2304
2305         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
2306         https://bugs.webkit.org/show_bug.cgi?id=140300
2307
2308         Reviewed by Simon Fraser.
2309
2310         * WebKitTestRunner/TestController.cpp:
2311         (WTR::TestController::createOtherPage):
2312         (WTR::TestController::updateWindowScaleForTest):
2313         (WTR::TestController::configureViewForTest):
2314         * WebKitTestRunner/TestController.h:
2315
2316 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2317
2318         Unreviewed. Moving myself to the committer section.
2319
2320         * Scripts/webkitpy/common/config/contributors.json:
2321
2322 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         Add a script to check for platform layering violations
2325         https://bugs.webkit.org/show_bug.cgi?id=140248
2326
2327         Reviewed by Darin Adler.
2328
2329         It prints all the cases where files inside platform include
2330         headers that are not in platform directory.
2331
2332         * Scripts/check-for-platform-layering-violations: Added.
2333         (get_platform_headers):
2334         (check_source_file):
2335
2336 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2337
2338         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
2339         https://bugs.webkit.org/show_bug.cgi?id=139884
2340
2341         Reviewed by Tim Horton.
2342
2343         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2344         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
2345         what the "nominal resolution" is, but this appears to work in practice.
2346
2347 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
2348
2349         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
2350         https://bugs.webkit.org/show_bug.cgi?id=140256
2351
2352         Reviewed by Anders Carlsson.
2353
2354         * DumpRenderTree/win/DumpRenderTree.cpp:
2355         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
2356         running with heap validation checks.
2357         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
2358         the "svg\\W3C-SVG-1.1" test directory.
2359         (removeFontFallbackIfPresent): Use nullptr instead of 0.
2360         * DumpRenderTree/win/TestRunnerWin.cpp:
2361         (TestRunner::clearPersistentUserStyleSheet): Ditto.
2362
2363 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2364
2365         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2366         https://bugs.webkit.org/show_bug.cgi?id=140218
2367
2368         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
2369         Undone an accidental change - check for self.has_crashed() again. This code path
2370         is for ports that don't have a signal handler printing #CRASHED when main process
2371         crashes.
2372
2373         * Scripts/webkitpy/port/driver_unittest.py:
2374         (DriverTest.test_check_for_driver_crash.assert_crash):
2375         (DriverTest.test_check_for_driver_crash):
2376         Updated the tests, all changes are expected.
2377
2378 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2379
2380         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2381         https://bugs.webkit.org/show_bug.cgi?id=140218
2382
2383         Reviewed by Darin Adler.
2384
2385         * Scripts/webkitpy/port/driver.py:
2386         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
2387         "process crashed" condition. These don't make sense together - it's either a crash
2388         or a timeout, and we should detect those properly at a much lower level.
2389         (Driver.run_test): Ditto.
2390         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
2391         cases.
2392
2393         * WebKitTestRunner/TestController.h:
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::TestController::webProcessName): 
2396         (WTR::TestController::processDidCrash):
2397         Factored out hardcoded child process names, as we now use these in two places.
2398
2399         * WebKitTestRunner/TestInvocation.cpp:
2400         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
2401         process name, so that it can be sampled (fixes sampling on Mavericks and above).
2402
2403 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2404
2405         Reorder my list of email addresses, keeping the Bugzilla address at the
2406         top since Bugzilla and other webkitpy scripts rely on that ordering.
2407
2408         * Scripts/webkitpy/common/config/contributors.json:
2409
2410 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2411
2412         Moving myself to the reviewers section and updating
2413         the list of my email addresses.
2414
2415         * Scripts/webkitpy/common/config/contributors.json:
2416
2417 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2418
2419         [GTK] Build gtk-doc without gtkdoc-mktmpl
2420         https://bugs.webkit.org/show_bug.cgi?id=140225
2421
2422         Reviewed by Darin Adler.
2423
2424         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
2425         don't modify the tmpl files that it generates, it's not doing anything
2426         for us.
2427
2428         * gtk/gtkdoc.py:
2429         (GTKDoc.generate):
2430         (GTKDoc._run_gtkdoc_scangobj):
2431         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
2432
2433 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
2434
2435         [GTK][ThreadedCompositor] Add support for threaded compositor.
2436         https://bugs.webkit.org/show_bug.cgi?id=118265
2437
2438         Reviewed by Martin Robinson.
2439
2440         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
2441         autotools build systems. The feature is disabled by default.
2442         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
2443         from the feature flags.
2444
2445         * Scripts/webkitperl/FeatureList.pm:
2446
2447 2015-01-07  Daniel Bates  <dabates@apple.com>
2448
2449         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2450         https://bugs.webkit.org/show_bug.cgi?id=137371
2451
2452         Reviewed by David Kilzer.
2453
2454         Use SPI wrapper headers instead of directly referencing private SPI headers.
2455
2456         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2457         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2458         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2459         to the list of iOS header search directories so that we can include header UIKitSPI.h.
2460         * DumpRenderTree/mac/DumpRenderTree.mm:
2461         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2462         * DumpRenderTree/mac/EventSendingController.mm:
2463         * DumpRenderTree/mac/TestRunnerMac.mm:
2464
2465 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2466
2467         Unreviewed, rolling out r178068.
2468         https://bugs.webkit.org/show_bug.cgi?id=140235
2469
2470         Breaks the iOS build (Requested by enrica on #webkit).
2471
2472         Reverted changeset:
2473
2474         "[iOS] Make WebKit2 build with public iOS SDK and more build
2475         fixes for DRT"
2476         https://bugs.webkit.org/show_bug.cgi?id=137371
2477         http://trac.webkit.org/changeset/178068
2478
2479 2015-01-07  Daniel Bates  <dabates@apple.com>
2480
2481         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2482         https://bugs.webkit.org/show_bug.cgi?id=137371
2483
2484         Reviewed by David Kilzer.
2485
2486         Use SPI wrapper headers instead of directly referencing private SPI headers.
2487
2488         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2489         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2490         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2491         to the list of header search directories so that we can include header UIKitSPI.h.
2492         * DumpRenderTree/mac/DumpRenderTree.mm:
2493         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2494         * DumpRenderTree/mac/EventSendingController.mm:
2495         * DumpRenderTree/mac/TestRunnerMac.mm:
2496
2497 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
2498
2499         [Win] Unreviewed test change to improve run reproducibility
2500
2501         * Scripts/webkitpy/port/win.py:
2502         (WinPort.default_child_processes): Run a single DRT instance to help
2503         identify failures caused by earlier test runs.
2504
2505 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
2506
2507         Myles C. Maxfield is a reviewer now
2508         https://bugs.webkit.org/show_bug.cgi?id=140196
2509
2510         Reviewed by Dean Jackson.
2511
2512         * Scripts/webkitpy/common/config/contributors.json:
2513
2514 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
2515
2516         Make webkit-patch try harder to find keychain credentials
2517         https://bugs.webkit.org/show_bug.cgi?id=140170
2518
2519         Reviewed by Ryosuke Niwa.
2520
2521         When the user manually enters a password into webkit-patch, we hand that off to the
2522         Keyring Python module. However, that module creates a generic password entry instead
2523         of an internet password entry. We should look for both kinds.
2524
2525         * Scripts/webkitpy/common/net/credentials.py:
2526         (Credentials._run_security_tool):
2527         (Credentials._credentials_from_keychain):
2528         * Scripts/webkitpy/common/net/credentials_unittest.py:
2529         (test_security_output_parse_entry_not_found):
2530         (_assert_security_call):
2531
2532 2015-01-06  Anders Carlsson  <andersca@apple.com>
2533
2534         Try to fix the Mountain Lion build.
2535
2536         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2537         (TestWebKitAPI::didGetImageForMatchResult):
2538
2539 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
2540
2541         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
2542         https://bugs.webkit.org/show_bug.cgi?id=140095
2543
2544         Reviewed by Anders Carlsson.
2545
2546         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
2547         builds, but not in debug ones.
2548
2549 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
2550
2551         [Win] Extend WinLauncher with support for Page Zoom
2552         https://bugs.webkit.org/show_bug.cgi?id=140152
2553
2554         Reviewed by Anders Carlsson.
2555
2556         * WinLauncher/Common.cpp:
2557         (WndProc):
2558         * WinLauncher/WinLauncher.cpp:
2559         (WinLauncher::resetZoom):
2560         (WinLauncher::zoomIn):
2561         (WinLauncher::zoomOut):
2562         * WinLauncher/WinLauncher.h:
2563         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
2564         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2565         * win/DLLLauncher/DLLLauncherMain.cpp:
2566         (wWinMain):
2567
2568 2015-01-06  Anders Carlsson  <andersca@apple.com>
2569
2570         Fix API tests that are broken under HiDPI
2571         https://bugs.webkit.org/show_bug.cgi?id=140146
2572
2573         Reviewed by Tim Horton.
2574
2575         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2576         (TestWebKitAPI::didGetImageForMatchResult):
2577         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
2578
2579         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2580         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
2581         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
2582         out in a window that has a backing scale factor of 1.
2583  
2584         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2585         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
2586         Ditto.
2587
2588 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
2589
2590         ADDRESS_SANITIZER macro is overloaded
2591         https://bugs.webkit.org/show_bug.cgi?id=140130
2592
2593         Reviewed by Anders Carlsson.
2594
2595         * WebKitTestRunner/TestController.cpp: Use the new macro.
2596
2597 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
2598
2599         Remove some stale class names in check-for-inappropriate-objc-class-names
2600         https://bugs.webkit.org/show_bug.cgi?id=140104
2601
2602         Reviewed by Darin Adler.
2603
2604         * Scripts/check-for-inappropriate-objc-class-names:
2605         These UIWK* classes no longer exist.
2606
2607 2015-01-05  Anders Carlsson  <andersca@apple.com>
2608
2609         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
2610         https://bugs.webkit.org/show_bug.cgi?id=140096
2611         rdar://problem/19368938
2612
2613         Reviewed by Alexey Proskuryakov.
2614
2615         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
2616         since clientInfo points to a web view, not the test controller.
2617
2618         * WebKitTestRunner/TestController.cpp:
2619         (WTR::TestController::createOtherPage):
2620
2621 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
2622
2623         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
2624         https://bugs.webkit.org/show_bug.cgi?id=140077
2625
2626         Reviewed by Csaba Osztrogonác.
2627
2628         WebKit C SPI is available on EFL,GTK.
2629         Changed the define order to pass the API test.
2630
2631         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2632         (TestWebKitAPI::TEST):
2633
2634 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
2635
2636         Simplify WebKitTestRunner timeout tracking
2637         https://bugs.webkit.org/show_bug.cgi?id=140036
2638
2639         Reviewed by Darin Adler.
2640
2641         The code for configuring timeouts was mostly dead, because run-webkit-tests never
2642         passes the --timeout option to WebKitTestRunner.
2643
2644         * WebKitTestRunner/Options.h:
2645         * WebKitTestRunner/Options.cpp:
2646         (WTR::Options::Options):
2647         (WTR::OptionsHandler::OptionsHandler):
2648         (WTR::handleOptionTimeout): Deleted.
2649         Removed support for --timeout. Timeouts are passed for each test individually,
2650         and defaults are good enough for the rare cases where WebKitTestRunner is run
2651         manually without run-webkit-tests.
2652
2653         * WebKitTestRunner/TestController.cpp:
2654         (WTR::TestController::TestController):
2655         (WTR::TestController::initialize):
2656         (WTR::TestController::resetStateToConsistentValues):
2657         (WTR::TestController::reattachPageToWebProcess):
2658         (WTR::TestController::runUntil):
2659         * WebKitTestRunner/TestController.h:
2660         Simplified runUntil by passing the actual timeout, not an enum.
2661         Increased short timeout for ASan enabled builds, as WebProcess launching takes
2662         quite a while.
2663
2664         * WebKitTestRunner/TestInvocation.cpp:
2665         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
2666
2667         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2668         (WTR::TestController::platformRunUntil):
2669         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2670         (WTR::TestController::platformRunUntil):
2671         Build fixes.
2672
2673 2015-01-02  Anders Carlsson  <andersca@apple.com>
2674
2675         Remove now unused storage tracker glue from DumpRenderTree
2676         https://bugs.webkit.org/show_bug.cgi?id=140045
2677
2678         Reviewed by Darin Adler.
2679
2680         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2681         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
2682         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
2683         * DumpRenderTree/TestRunner.cpp:
2684         (TestRunner::staticFunctions):
2685         (syncLocalStorageCallback): Deleted.
2686         (observeStorageTrackerNotificationsCallback): Deleted.
2687         (deleteAllLocalStorageCallback): Deleted.
2688         (deleteLocalStorageForOriginCallback): Deleted.
2689         (localStorageDiskUsageForOriginCallback): Deleted.
2690         (originsWithLocalStorageCallback): Deleted.
2691         * DumpRenderTree/TestRunner.h:
2692         * DumpRenderTree/mac/DumpRenderTree.mm:
2693         (allocateGlobalControllers):
2694         (releaseGlobalControllers):
2695         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2696         * DumpRenderTree/mac/TestRunnerMac.mm:
2697         (TestRunner::syncLocalStorage): Deleted.
2698         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
2699         (TestRunner::observeStorageTrackerNotifications): Deleted.
2700         (TestRunner::deleteAllLocalStorage): Deleted.
2701         (TestRunner::originsWithLocalStorage): Deleted.
2702         (TestRunner::deleteLocalStorageForOrigin): Deleted.
2703         * DumpRenderTree/win/TestRunnerWin.cpp:
2704         (TestRunner::syncLocalStorage): Deleted.
2705         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
2706         (TestRunner::observeStorageTrackerNotifications): Deleted.
2707         (TestRunner::deleteAllLocalStorage): Deleted.
2708         (TestRunner::originsWithLocalStorage): Deleted.
2709         (TestRunner::deleteLocalStorageForOrigin): Deleted.
2710
2711 2015-01-01  Darin Adler  <darin@apple.com>
2712
2713         We often misspell identifier as "identifer"
2714         https://bugs.webkit.org/show_bug.cgi?id=140025
2715
2716         Reviewed by Michael Saboff.
2717
2718         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2719         * Scripts/webkitdirs.pm:
2720         (appIdentifierFromBundle):
2721         (installAndLaunchIOSWebKitAppInSimulator):
2722         Fix misspellings
2723
2724 2015-01-01  Zalan Bujtas  <zalan@apple.com>
2725
2726         Saturated arithmetics: Incorrect float/double clamping.
2727         https://bugs.webkit.org/show_bug.cgi?id=139888
2728         rdar://problem/19330885
2729
2730         Reviewed by Simon Fraser.
2731
2732         Clamp float and double values correctly when applying saturated arithmetics.
2733
2734         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2735         (TestWebKitAPI::TEST):
2736
2737 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
2738
2739         [EFL] Bump version of ATK used by jhbuild to 2.15.2
2740         https://bugs.webkit.org/show_bug.cgi?id=139816
2741
2742         Reviewed by Gyuyoung Kim.
2743
2744         Bump version of ATK used by jhbuild to 2.15.2
2745
2746         * efl/jhbuild.modules:
2747
2748 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
2749
2750         [jhBuild] cairo build error (-flto)
2751         https://bugs.webkit.org/show_bug.cgi?id=139056
2752
2753         Reviewed by Philippe Normand.
2754
2755         cairo fails to link  with gcc 4.9 due to lto
2756         related issue. This problem has been partially
2757         addressed by cairo:
2758         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
2759         use the cairo --disable-lto option and remove jhbuild
2760         makeargs fixes the issue.
2761
2762         * gtk/jhbuild.modules:
2763         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
2764
2765 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
2766         [Mac] Enable kerning, ligatures, and printer fonts 
2767         https://bugs.webkit.org/show_bug.cgi?id=139970
2768
2769         Rubber stamped by Simon Fraser.
2770
2771         Flip the switch.
2772
2773         * DumpRenderTree/mac/DumpRenderTree.mm:
2774         * WebKitTestRunner/TestController.cpp:
2775         * WebKitTestRunner/mac/main.mm:
2776
2777 2014-12-26  Dan Bernstein  <mitz@apple.com>
2778
2779         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2780         https://bugs.webkit.org/show_bug.cgi?id=139950
2781
2782         Reviewed by David Kilzer.
2783
2784         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2785         in a manner that works with Xcode 5.1.1.
2786
2787 2014-12-24  Dan Bernstein  <mitz@apple.com>
2788
2789         Engineering builds of MiniBrowser ignore deprecated declaration warnings
2790         https://bugs.webkit.org/show_bug.cgi?id=139941
2791
2792         Reviewed by Darin Adler.
2793
2794         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
2795         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
2796         to YES.
2797         * MiniBrowser/mac/AppDelegate.m:
2798         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
2799         deprecated NSOKButton.
2800
2801 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2802
2803         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
2804         https://bugs.webkit.org/show_bug.cgi?id=134763
2805
2806         Reviewed by Ryosuke Niwa.
2807
2808         Adding an option to disable test harness link conversion.
2809
2810         * Scripts/webkitpy/w3c/test_converter.py:
2811         (convert_for_webkit):
2812         (_W3CTestConverter.__init__):
2813         (_W3CTestConverter.convert_attributes_if_needed):
2814         * Scripts/webkitpy/w3c/test_importer.py:
2815         (parse_args):
2816         (TestImporter.import_tests):
2817
2818 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2819
2820         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
2821         https://bugs.webkit.org/show_bug.cgi?id=139933
2822
2823         Reviewed by Daniel Bates.
2824
2825         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
2826         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
2827         until ReportCrash lets it go.
2828
2829         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
2830         even get the actual crash log eventually - even when it times out waiting for the log, it
2831         makes a second lookup at the very end, after all tests finish. There may be further
2832         improvements needed here, but this small fix addresses most cases that happen in practice.
2833
2834         * DumpRenderTree/mac/DumpRenderTree.mm:
2835         (writeCrashedMessageOnFatalError):
2836         (dumpRenderTree):
2837         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
2838
2839         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
2840         unhelpful comment.
2841
2842 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2843
2844         Don't force -O1 for debug ASan builds
2845         https://bugs.webkit.org/show_bug.cgi?id=139926
2846
2847         Reviewed by Darin Adler.
2848
2849         * asan/asan.xcconfig:
2850
2851 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2852
2853         Simplify building with ASan
2854         https://bugs.webkit.org/show_bug.cgi?id=139916
2855
2856         Reviewed by Mark Rowe.
2857
2858         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
2859         We could also update Configuration file format, but that's a little scary because
2860         of how many places in code read it.
2861
2862         * Scripts/webkitdirs.pm:
2863         (determineASanIsEnabled): Read it from ASan configuration file.
2864         (argumentsForConfiguration): Added a FIXME.
2865         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
2866         (XcodeOptions): Pass the options needed for ASan.
2867
2868         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
2869         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
2870         that automatically.
2871
2872 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2873
2874         TestWebKitAPI build is broken when ASan is enabled
2875         https://bugs.webkit.org/show_bug.cgi?id=139902
2876
2877         Reviewed by Darin Adler.
2878
2879         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2880         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
2881         Inherit linker flags from DebugRelease, which respects ASAN.
2882
2883 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
2884
2885         Sort the Xcode project file.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888
2889 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2890
2891         Update apple-mac-114 to bot629.
2892         
2893         Unreviewed.
2894         
2895         * BuildSlaveSupport/build.webkit.org-config/config.json:
2896
2897 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2898
2899         Replace Apple bot104 with bot124.
2900         
2901         Unreviewed.
2902         
2903         * BuildSlaveSupport/build.webkit.org-config/config.json:
2904
2905 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
2906
2907         URTBF after r177639.
2908
2909         * TestWebKitAPI/CMakeLists.txt:
2910
2911 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2912
2913         [EFL] MiniBrowser steals web view's focus
2914         https://bugs.webkit.org/show_bug.cgi?id=139482
2915
2916         Reviewed by Gyuyoung Kim.
2917
2918         Although we set focus on ewk_view while MiniBrowser initialization
2919         Ecore steals it in a favor of main window. As a result
2920         focused element on web page is unable to receive events.
2921
2922         * MiniBrowser/efl/main.c:
2923         (window_create):
2924         Prevent window from stealing web view's focus on start up.
2925
2926 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
2927
2928         [Win] Revise DRT logic to match Mac.
2929
2930         Rubberstamped by Anders Carlsson.
2931
2932         Update the Windows logic to perform initialization of preferences and WebKit
2933         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
2934         the same circumstances as the Mac version.
2935
2936         * DumpRenderTree/win/DumpRenderTree.cpp:
2937         (dump):
2938         (resetWebPreferencesToConsistentValues):
2939         (setDefaultsToConsistentValuesForTesting):
2940         (resetWebViewToConsistentStateBeforeTesting):
2941         (sizeWebViewForCurrentTest):
2942         (runTest):
2943         (createWebViewAndOffscreenWindow):
2944         (allocateGlobalControllers):
2945         (prepareConsistentTestingEnvironment):
2946         (main):
2947         (resetDefaultsToConsistentValues): Deleted.
2948
2949 2014-12-19  Roger Fong  <roger_fong@apple.com>
2950
2951         Unreviewed. Rollout r177605.
2952
2953         * EWSTools/start-queue-win.sh:
2954
2955 2014-12-19  Roger Fong  <roger_fong@apple.com>
2956
2957         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
2958
2959         * EWSTools/start-queue-win.sh:
2960
2961 2014-12-19  Daniel Bates  <dabates@apple.com>
2962
2963         [iOS] Add WebKitSystemInterface for iOS 8.1
2964         https://bugs.webkit.org/show_bug.cgi?id=139831
2965
2966         Reviewed by Alexey Proskuryakov.
2967
2968         Implement support in copy-webkitlibraries-to-product-directory to copy
2969         WebKitSystemInterface for iOS to the product directory and have build-webkit
2970         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
2971
2972         * Scripts/build-webkit:
2973         * Scripts/copy-webkitlibraries-to-product-directory:
2974
2975 2014-12-19  Daniel Bates  <dabates@apple.com>
2976
2977         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
2978         https://bugs.webkit.org/show_bug.cgi?id=139829
2979
2980         Reviewed by Alexey Proskuryakov.
2981
2982         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
2983         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
2984         expects the Xcode SDK to be specified using the --sdk-name command line argument.
2985
2986         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
2987         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
2988         logic to both avoid duplicating effort and make the command line options for
2989         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
2990         with the approach used in other WebKit tools.
2991
2992         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
2993         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
2994         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
2995
2996         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
2997         improve the readability of the code.
2998         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
2999         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
3000         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
3001         be included in a library.
3002         (unpackIfNecessary): Modified to call executeRanlib().
3003
3004 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3005
3006         REGRESSION (177368): Some tests started to immediately time out
3007         https://bugs.webkit.org/show_bug.cgi?id=139826
3008
3009         Reviewed by Daniel Bates.
3010
3011         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3013         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3014         ends in a load failure, we don't dump, so we used to leak the timer.
3015         
3016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3017         Added a comment.
3018
3019 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3020
3021         [Win] Add accessor for serializing HTTP loads
3022         https://bugs.webkit.org/show_bug.cgi?id=139817
3023
3024         Reviewed by Mark Lam.
3025
3026         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3027         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3028         remove some redundant code from the destructor.
3029
3030 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3031
3032         Clean up a fix for performance test bot failing to build
3033         https://bugs.webkit.org/show_bug.cgi?id=139818
3034
3035         Reviewed by Csaba Osztrogonác.
3036
3037         The "_1" in step name was annoying.
3038
3039         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3040         (CleanBuildIfScheduled.start):
3041         (RunAndUploadPerfTests):
3042         (DownloadAndPerfTestFactory.__init__):
3043         (DownloadAndPerfTestWebKit2Factory.__init__):
3044         (CleanBuildUnconditionally): Deleted.
3045         (CleanBuildUnconditionally.start): Deleted.
3046
3047 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
3048
3049         REGRESSION(r177535): It broke the GTK performance bot
3050         https://bugs.webkit.org/show_bug.cgi?id=139811
3051
3052         Reviewed by Carlos Garcia Campos.
3053
3054         Trigger clean build only on mac platform.
3055
3056         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3057         (DownloadAndPerfTestFactory.__init__):
3058         (DownloadAndPerfTestWebKit2Factory.__init__):
3059
3060 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
3061
3062         Unreviewed, moved myself to the list of committers.
3063
3064         * Scripts/webkitpy/common/config/contributors.json:
3065
3066 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3067
3068         [Win] Update DumpRenderTree to more closely match Mac version
3069         https://bugs.webkit.org/show_bug.cgi?id=139799
3070
3071         Reviewed by Tim Horton.
3072
3073         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3074         (AccessibilityController::accessibleElementById): Correct
3075         use of BSTR to avoid leak.
3076         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
3077         update to match Mac version more closely.
3078         (dumpFramesAsText):
3079         (dump):
3080         (resetDefaultsToConsistentValues):
3081         (resetWebViewToConsistentStateBeforeTesting):
3082         (sizeWebViewForCurrentTest):
3083         (runTest):
3084         (openWindows):
3085         (windowToWebViewMap):
3086         (createWebViewAndOffscreenWindow):
3087         (sharedCFURLCache):
3088         (initializeGlobalsFromCommandLineOptions):
3089         (main):
3090         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3091         (TestRunner::addDisallowedURL):
3092         (TestRunner::applicationCacheDiskUsageForOrigin):
3093         (TestRunner::syncLocalStorage):
3094         (TestRunner::localStorageDiskUsageForOrigin):
3095         (TestRunner::observeStorageTrackerNotifications):
3096         (TestRunner::clearApplicationCacheForOrigin):
3097         (TestRunner::originsWithApplicationCache):
3098         (TestRunner::deleteAllLocalStorage):
3099         (TestRunner::setStorageDatabaseIdleInterval):
3100         (TestRunner::closeIdleLocalStorageDatabases):
3101         (TestRunner::originsWithLocalStorage):
3102         (TestRunner::deleteLocalStorageForOrigin):
3103         (TestRunner::copyDecodedHostName):
3104         (TestRunner::copyEncodedHostName):
3105         (TestRunner::keepWebHistory):
3106         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3107         (TestRunner::setAppCacheMaximumSize):
3108         (TestRunner::setCustomPolicyDelegate):
3109         (TestRunner::goBack):
3110         (TestRunner::setDefersLoading):
3111         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3112         (TestRunner::setMockDeviceOrientation):
3113         (TestRunner::setMockGeolocationPosition):
3114         (TestRunner::setMockGeolocationPositionUnavailableError):
3115         (TestRunner::setIconDatabaseEnabled):
3116         (TestRunner::setMainFrameIsFirstResponder):
3117         (TestRunner::setSpatialNavigationEnabled):
3118         (TestRunner::setPluginsEnabled):
3119         (TestRunner::setAutomaticLinkDetectionEnabled):
3120         (TestRunner::setUseDashboardCompatibilityMode):
3121         (TestRunner::dispatchPendingLoadRequests):
3122         (TestRunner::findString):
3123         (TestRunner::setCacheModel):
3124         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3125         (TestRunner::setWebViewEditable):
3126         (TestRunner::authenticateSession):
3127         (TestRunner::abortModal):
3128         (TestRunner::setSerializeHTTPLoads):
3129         (TestRunner::addChromeInputField):
3130         (TestRunner::removeChromeInputField):
3131         (TestRunner::focusWebView):
3132         (TestRunner::setBackingScaleFactor):
3133         (TestRunner::grantWebNotificationPermission):
3134         (TestRunner::denyWebNotificationPermission):
3135         (TestRunner::removeAllWebNotificationPermissions):
3136         (TestRunner::simulateWebNotificationClick):
3137
3138 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
3139
3140         Add strong typing to RefCounter interface, return value as a bool.
3141         https://bugs.webkit.org/show_bug.cgi?id=139776
3142
3143         Reviewed by Geoff Garen.
3144
3145         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
3146         This means there is no compile time type checking to prevent mistakes. Update the count()
3147         method to token<>(), templated on type used to identify the token being returned.
3148         Calls to token<T>() will return a result of type RefCounter::Token<T>.
3149
3150         There are a few problems with the fact the counter will return you an exact count of the
3151         number of outstanding tokens:
3152           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
3153             to do so if the value is only readable as a boolean.
3154           - It is desirable to provide the value as an argument to the callback, however to make
3155             this useful for integer values it is also necessary to indicate the direction of change
3156             (0->1 is often interesting where 2->1 is not).
3157           - There is a mismatch between the precision of returning a count, and the inherent
3158             imprecision of a token based mechanism, where it may be difficult to guarantee
3159             absolutely no unnecessary refcount churn, and thus unintentional counter values.
3160
3161         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3162         (TestWebKitAPI::TEST):
3163             - update API test.
3164
3165 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3166
3167         Disable retries on Mac Release WK2 testers
3168         https://bugs.webkit.org/show_bug.cgi?id=139798
3169
3170         Reviewed by Simon Fraser.
3171
3172         * BuildSlaveSupport/build.webkit.org-config/config.json:
3173
3174 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3175
3176         Perf tests frequently fail saying "build not up to date"
3177         https://bugs.webkit.org/show_bug.cgi?id=139786
3178
3179         Illegitimately yet authoritatively reviewed by Lucas Forschler.
3180
3181         Undo the rest of the first fix, and implement the behavior differently.
3182
3183         is_clean isn't automatically forwarded from config.json to properties.
3184
3185         * BuildSlaveSupport/build.webkit.org-config/config.json:
3186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3187         (CleanBuildUnconditionally):
3188         (CleanBuildUnconditionally.start):
3189         (DownloadAndPerfTestFactory.__init__):
3190         (DownloadAndPerfTestWebKit2Factory.__init__):
3191
3192 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3193
3194         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
3195         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
3196         found nothing.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3199         (BuildAndPerfTestFactory):
3200         (BuildAndPerfTestWebKit2Factory):
3201
3202 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
3203
3204         Perf tests frequently fail saying "build not up to date"
3205         https://bugs.webkit.org/show_bug.cgi?id=139786
3206
3207         Reviewed by Ryosuke Niwa.
3208
3209         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
3210         directory to get rid of stale precompiled headers, and let it rebuild
3211         DumpRenderTree each time, that's fast.
3212
3213         Also, removed unused "build and perf test" code.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/config.json:
3216
3217 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3218
3219         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
3220
3221         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
3222         it easier to see what steps are missing when running under Windows.
3223
3224         * DumpRenderTree/win/TestRunnerWin.cpp:
3225         (TestRunner::callShouldCloseOnWebView):
3226         (TestRunner::clearAllApplicationCaches):
3227         (TestRunner::applicationCacheDiskUsageForOrigin):
3228         (TestRunner::syncLocalStorage):
3229         (TestRunner::localStorageDiskUsageForOrigin):
3230         (TestRunner::observeStorageTrackerNotifications):
3231         (TestRunner::clearApplicationCacheForOrigin):
3232         (TestRunner::originsWithApplicationCache):
3233         (TestRunner::clearAllDatabases):
3234         (TestRunner::deleteAllLocalStorage):
3235         (TestRunner::setStorageDatabaseIdleInterval):
3236         (TestRunner::closeIdleLocalStorageDatabases):
3237         (TestRunner::originsWithLocalStorage):
3238         (TestRunner::deleteLocalStorageForOrigin):
3239         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3240         (jsStringRefToWString):
3241         (TestRunner::setAppCacheMaximumSize):
3242         (TestRunner::setDatabaseQuota):
3243         (TestRunner::goBack):
3244         (TestRunner::setDefersLoading):
3245         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3246         (TestRunner::setAutomaticLinkDetectionEnabled):
3247         (TestRunner::dispatchPendingLoadRequests):
3248         (TestRunner::overridePreference):
3249         (TestRunner::removeAllVisitedLinks):
3250         (TestRunner::waitForPolicyDelegate):
3251         (TestRunner::resetPageVisibility):
3252         (TestRunner::setPageVisibility):
3253         (TestRunner::grantWebNotificationPermission):
3254         (TestRunner::denyWebNotificationPermission):
3255         (TestRunner::removeAllWebNotificationPermissions):
3256         (TestRunner::simulateWebNotificationClick):
3257         (TestRunner::simulateLegacyWebNotificationClick):
3258
3259 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3260
3261         [Win] Correct Windows tests after Bug 139149 (edit)
3262         https://bugs.webkit.org/show_bug.cgi?id=139781
3263
3264         Reviewed by Anders Carlsson.
3265
3266         * DumpRenderTree/win/TestRunnerWin.cpp:
3267         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
3268         interface.
3269
3270 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
3271
3272         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
3273         https://bugs.webkit.org/show_bug.cgi?id=139748
3274
3275         Reviewed by Daniel Bates.
3276         
3277         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
3278         have all been updated.
3279
3280         * Scripts/webkitpy/port/factory.py:
3281         (platform_options):
3282
3283 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
3284
3285         Build more of TestWebKitAPI for iOS
3286         https://bugs.webkit.org/show_bug.cgi?id=139747
3287
3288         Reviewed by Daniel Bates.
3289         
3290         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
3291         which excluded some tests that should be run for iOS.
3292         
3293         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
3294         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
3295         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
3296         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
3297         
3298         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
3299         to share code between Mac and iOS.
3300
3301         * TestWebKitAPI/Configurations/Base.xcconfig:
3302         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3303         * TestWebKitAPI/InjectedBundleController.cpp:
3304         * TestWebKitAPI/InjectedBundleMain.cpp:
3305         * TestWebKitAPI/JavaScriptTest.cpp:
3306         * TestWebKitAPI/PlatformUtilities.cpp:
3307         * TestWebKitAPI/PlatformUtilities.h:
3308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3309         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3310         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3311         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3312         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3313         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
3314         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
3315         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3316         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3317         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3318         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3319         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3320         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
3321         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3322         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
3323         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3324         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3325         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3326         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3327         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3328         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3329         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3330         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3331         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3332         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3333         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3334         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3335         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
3336         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
3337         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3338         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3339         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3340         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3341         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
3342         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
3343         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
3344         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
3345         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
3346         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3347         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
3348         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
3349         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
3350         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3351         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
3352         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3353         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3354         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3355         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3356         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
3357         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3358         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3359         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3360         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3361         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3362         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
3363         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
3364         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
3365         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
3366         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3367         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3368         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
3369         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3370         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
3371         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3372         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
3373         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3374         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3375         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
3376         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
3377         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3378         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3379         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
3380         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
3381         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3382         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3383         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
3384         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
3385         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
3386         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3387         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3388         (TestWebKitAPI::TEST):
3389         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3390         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3391         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3392         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
3393         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
3394         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
3395         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3396         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
3397         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
3398         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
3399         (TEST):
3400         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3401         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3402         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3403         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3404         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3405         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3406         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3407         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3408         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
3409         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3410         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
3411         (TestWebKitAPI::Util::run):
3412         (TestWebKitAPI::Util::sleep):
3413         (TestWebKitAPI::Util::toSTD):
3414         * TestWebKitAPI/config.h:
3415         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
3416         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3417         (TestWebKitAPI::Util::run): Deleted.
3418         (TestWebKitAPI::Util::sleep): Deleted.
3419         (TestWebKitAPI::Util::toSTD): Deleted.
3420
3421 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3422
3423         [GTK] Add support for FTL JIT on ARM64
3424         https://bugs.webkit.org/show_bug.cgi?id=139677
3425
3426         Reviewed by Csaba Osztrogonác.
3427
3428         * gtk/jhbuild-optional.modules:
3429         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
3430         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
3431
3432 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
3433
3434         [GTK] Implement webkit_web_view_is_playing_audio()
3435         https://bugs.webkit.org/show_bug.cgi?id=138918
3436
3437         Reviewed by Carlos Garcia Campos.
3438
3439         Add test case case for webkit_web_view_is_playing_audio() and the
3440         WebKitWebView::is-playing-audio property.
3441
3442         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3443         (urlForResource): Utility function to get URLs pointing to resources
3444         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
3445         (testWebViewIsPlayingAudio): Added.
3446         (beforeAll):
3447         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3448         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
3449         API tests resources directory, or the WebKit2 C API tests resources
3450         directory. The default value of the flag is to use the WebKit2 GTK
3451         one, to avoid having to change existing tests.
3452         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3453         (isPlayingAudioChanged): Added.
3454         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
3455         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3456
3457 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3458
3459         [GTK] [EFL] Enable per_test_timeout
3460         https://bugs.webkit.org/show_bug.cgi?id=139771
3461
3462         Reviewed by Csaba Osztrogonác.
3463
3464         This is needed to make WKTR use either the default port timeout, or the
3465         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
3466         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
3467
3468         * Scripts/webkitpy/port/efl.py:
3469         (EflPort.supports_per_test_timeout): Enabled.
3470         * Scripts/webkitpy/port/gtk.py:
3471         (GtkPort.supports_per_test_timeout): Enabled.
3472
3473 2014-12-17  Lucas Forschler  <lforschler@apple.com>
3474
3475         Move Apple buildbot slaves to their new home.
3476         
3477         Reviewed by Roger Fong.
3478
3479         * BuildSlaveSupport/build.webkit.org-config/config.json:
3480
3481 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
3482
3483         REGRESSION (r177363): Gtk and Efl testing is broken
3484         https://bugs.webkit.org/show_bug.cgi?id=139734
3485
3486         Reviewed by Simon Fraser.
3487
3488         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3489         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
3490         affected both script and tool timeout. This is still the right place for this logic,
3491         but it would be a larger refactoring than I can do right now.
3492
3493         * Scripts/webkitpy/port/base.py:
3494         (Port.supports_per_test_timeout): Added a FIXME.
3495         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
3496         to avoid making tests take more time.
3497
3498         * Scripts/webkitpy/port/driver.py:
3499         (Driver.run_test): Adjust script timeout here.
3500         (Driver._check_for_driver_timeout): Fix the timeout detection.
3501         (Driver._read_block): Actually use the timeout detection code.
3502
3503         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
3504         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
3505
3506         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
3507         Update results for the new default.
3508
3509         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3510         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
3511         actually a good one.
3512
3513 2014-12-17  Commit Queue  <commit-queue@webkit.org>
3514
3515         Unreviewed, rolling out r177456.
3516         https://bugs.webkit.org/show_bug.cgi?id=139749
3517
3518         Broke webkitpy and Mac tests (Requested by ap on #webkit).
3519
3520         Reverted changeset:
3521
3522         "REGRESSION (r177363): Gtk and Efl testing is broken"
3523         https://bugs.webkit.org/show_bug.cgi?id=139734
3524         http://trac.webkit.org/changeset/177456
3525
3526 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
3527
3528         REGRESSION (r177363): Gtk and Efl testing is broken
3529         https://bugs.webkit.org/show_bug.cgi?id=139734
3530
3531         Reviewed by Simon Fraser.
3532
3533         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3534         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
3535         affected both script and tool timeout. This is still the right place for this logic,
3536         but it would be a larger refactoring than I can do right now.
3537
3538         * Scripts/webkitpy/port/base.py:
3539         (Port.supports_per_test_timeout): Added a FIXME.
3540         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
3541         to avoid making tests take more time.
3542
3543         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
3544
3545         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
3546         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
3547
3548 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3549
3550         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
3551         https://bugs.webkit.org/show_bug.cgi?id=139725
3552
3553         Reviewed by Martin Robinson.
3554
3555         The timeout is already in milliseconds, so we don't need to do any conversion.
3556
3557         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3558         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3559
3560 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
3561
3562         [EFL]Fix build warning in MiniBrowser
3563         https://bugs.webkit.org/show_bug.cgi?id=139723
3564
3565         Reviewed by Darin Adler.
3566
3567         The warning is caused by the compiler wanting the first argument to be a
3568         string literal, not a dynamically created string.
3569
3570         * MiniBrowser/efl/main.c:
3571         (quit):
3572
3573 2014-12-16  Sam Weinig  <sam@webkit.org>
3574
3575         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
3576         https://bugs.webkit.org/show_bug.cgi?id=139718
3577
3578         Reviewed by Mark Rowe.
3579
3580         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
3581         files into a static lib which the command line utility can link link against.
3582         This will allow us to create a TestWebKitAPI.app that can run on iOS.
3583
3584         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3585         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587
3588 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
3589
3590         Sort out timeout implementations in DRT and WKTR
3591         https://bugs.webkit.org/show_bug.cgi?id=139671
3592
3593         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
3594         with the tool.
3595
3596         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3597         (RunTest.test_hung_thread):
3598
3599 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
3600
3601         Sort out timeout implementations in DRT and WKTR
3602         https://bugs.webkit.org/show_bug.cgi?id=139671
3603
3604         Reviewed by Simon Fraser.
3605
3606         Test timeout implementation had many deficiencies, please see the bug for details.
3607         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
3608         [ Slow ] modifiers should work a lot better.
3609
3610         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
3611         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
3612         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
3613         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
3614         DumpRenderTree already read the --timeout option from command line, and webkitpy
3615         was already configured to pass it on Mac and iOS. Let's actually use it.
3616         TestCommand already had the same 30 second default, so this doesn't change behavior
3617         when DRT is ran manually without the option.
3618         Windows DumpRenderTree will need to be fixed separately (that's easy).
3619
3620         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
3621         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
3622         slightly better to use stderr in both, as this is an out of band message, but
3623         that's a larger refactoring, and the difference is minimal in practice.
3624
3625         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3626         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
3627         different. We want the tool to reliably detect timeouts that can be detected, and
3628         not race with the script for that.
3629
3630         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
3631         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
3632         is honored inmore cases, that could make tests run slower.