[WinCairo] Preparation for GStreamer on Windows.
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-18  Alex Christensen  <achristensen@webkit.org>
2
3         [WinCairo] Preparation for GStreamer on Windows.
4         https://bugs.webkit.org/show_bug.cgi?id=125946
5
6         Reviewed by Brent Fulgham.
7
8         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
9         Use new GStreamer property sheets for WinCairo.
10         * win/DLLLauncher/DLLLauncherMain.cpp:
11         (modifyPath):
12         (wWinMain):
13         Prepend GStreamer bin directory to path if it exists.
14
15 2013-12-18  Anders Carlsson  <andersca@apple.com>
16
17         Remove now useless test.
18
19         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
21         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
22         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
23
24 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
25
26         Fix page visibility api test, initialization in WebKit2
27         https://bugs.webkit.org/show_bug.cgi?id=125933
28
29         Reviewed by Anders Carlsson.
30
31         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
32         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
33
34         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
35         (TestWebKitAPI::TEST_F):
36             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
37
38 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
39
40         Should not have identifiers with underscores in them, especially not leading underscores.
41         https://bugs.webkit.org/show_bug.cgi?id=125847
42
43         Reviewed by Darin Adler.
44
45         * Scripts/webkitpy/style/checkers/cpp.py:
46         (check_identifier_name_in_declaration):
47         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
48         (CppStyleTest.test_runtime_selfinit):
49         (WebKitStyleTest.test_names):
50
51 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
52
53         False webkit-check-style warnings on *.
54         https://bugs.webkit.org/show_bug.cgi?id=125915
55
56         Reviewed by Darin Adler.
57
58         * Scripts/webkitpy/style/checkers/cpp.py:
59         (check_spacing):
60         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
61         (CppStyleTest.test_pointer_reference_marker_location):
62
63 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
64
65         prepare-ChangeLog doesn't handle templates properly
66         https://bugs.webkit.org/show_bug.cgi?id=125853
67
68         Reviewed by Daniel Bates.
69
70         * Scripts/prepare-ChangeLog:
71         (get_function_line_ranges_for_cpp):
72         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
73         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
74         (Class110<TemplateClass>::func36):
75
76 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
77
78         Move expectation parsing out of the constructor of TestExpectations
79         https://bugs.webkit.org/show_bug.cgi?id=125439
80
81         Reviewed by Csaba Osztrogonác.
82
83         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
84         (LayoutTestRunnerTests._run_tests):
85         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
86         (LayoutTestRunnerTests.test_update_summary_with_result):
87         * Scripts/webkitpy/layout_tests/controllers/manager.py:
88         (Manager.run):
89         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
90         (ManagerTest.test_look_for_new_crash_logs):
91         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
92         (lint):
93         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
94         (TestExpectations.suffixes_for_expectations):
95         (TestExpectations.__init__):
96         (TestExpectations):
97         (TestExpectations.parse_generic_expectations):
98         (TestExpectations.parse_default_port_expectations):
99         (TestExpectations.parse_override_expectations):
100         (TestExpectations.parse_all_expectations):
101         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
102         (parse_exp):
103         (SkippedTests.check):
104         (SkippedTests.test_skipped_entry_dont_exist):
105         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
106         (run_results):
107         * Scripts/webkitpy/tool/commands/queries.py:
108         (PrintExpectations._model):
109         * Scripts/webkitpy/tool/commands/rebaseline.py:
110         (RebaselineTest._update_expectations_file):
111         (RebaselineExpectations._update_expectations_files):
112         (RebaselineExpectations._tests_to_rebaseline):
113
114 2013-12-17  Jer Noble  <jer.noble@apple.com>
115
116         Fix TimeRanges::intersectWith
117         https://bugs.webkit.org/show_bug.cgi?id=118802
118
119         Reviewed by Eric Carlson.
120
121         Add unit tests for WebCore/TimeRanges.
122
123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
124         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
125         (TestWebKitAPI::ToString):
126         (TestWebKitAPI::TEST):
127
128 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
129
130         Botwatcher's dashboard ceases to update itself after a while
131         https://bugs.webkit.org/show_bug.cgi?id=125885
132
133         Reviewed by Timothy Hatcher.
134
135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
136         Removed code that checked for the view being hidden. It's none of model's business.
137
138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
139         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
140         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
141         We now stop the timer for hidden views.
142         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
143
144 2013-12-17  Anders Carlsson  <andersca@apple.com>
145
146         Fix the 32-bit build.
147
148         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
149         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
150
151 2013-12-17  Anders Carlsson  <andersca@apple.com>
152
153         Give the MiniBrowser a bundle
154         https://bugs.webkit.org/show_bug.cgi?id=125882
155
156         Reviewed by Sam Weinig.
157
158         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
159         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
160         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
161         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
162         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
163         * MiniBrowser/mac/AppDelegate.m:
164         (-[BrowserAppDelegate init]):
165         * MiniBrowser/mac/Bundle/Info.plist: Added.
166         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
167
168 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
169
170         Remove PageVisibilityStateUnloaded
171         https://bugs.webkit.org/show_bug.cgi?id=125869
172
173         Reviewed by Anders Carlsson.
174
175         This is not currently supported by WebKit, remove this enum value.
176         We can always add this back later if/when we add support for this state.
177
178         * DumpRenderTree/mac/TestRunnerMac.mm:
179         (TestRunner::setPageVisibility):
180         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
181         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
183         (WTR::TestRunner::setPageVisibility):
184             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
185
186 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
187
188         [GTK] [CMake] Build the plugin process against GTK+ 2
189         https://bugs.webkit.org/show_bug.cgi?id=116374
190
191         Reviewed by Gustavo Noronha Silva.
192
193         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
194         libraries required for WebCore unit tests.
195
196 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
197
198         [Win] Revise filter-build-webkit to deal with Windows build logs
199         https://bugs.webkit.org/show_bug.cgi?id=125866
200
201         Reviewed by David Kilzer.
202
203         Enhance the script to accept a 'platform' argument. When platform
204         'win' is provided, use processing for the Windows build file format.
205         Otherwise, process the files as normal.
206
207         * Scripts/filter-build-webkit:
208         (usageAndExit): Add a 'platform' argument
209         (shouldIgnoreLine): When platform == 'win' use the new Windows
210         rules for processing the build file.
211
212 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
213
214         Update style checker now that ENUM_CLASS is gone
215         https://bugs.webkit.org/show_bug.cgi?id=125864
216
217         Reviewed by Anders Carlsson.
218
219         * Scripts/webkitpy/style/checkers/cpp.py:
220         (_EnumState.process_clean_line):
221         (check_braces):
222         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
223         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
224         (NoNonVirtualDestructorsTest.test_enum_casing):
225         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
226         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
227         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
228         (WebKitStyleTest.test_braces.CPP11EnumClass):
229
230 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
231
232         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
233         https://bugs.webkit.org/show_bug.cgi?id=125857
234
235         Reviewed by Chris Fleizach.
236
237         Add mappings to DRT & WKTR for the newly exposed roles, and
238         increase the version of ATK used by the internal jhbuild.
239
240         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
242         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
243
244 2013-12-17  Alex Christensen  <achristensen@webkit.org>
245
246         [WinCairo] Adding support for GStreamer and GLib.
247         https://bugs.webkit.org/show_bug.cgi?id=124867
248
249         Reviewed by Philippe Normand.
250
251         * WinLauncher/WinLauncher.cpp:
252         (wWinMain):
253         Added g_main_context_iteration in main event loop.
254
255 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
256
257         Fix for C++ should have the & or * beside the type not the variable name check.
258         https://bugs.webkit.org/show_bug.cgi?id=125846
259
260         Reviewed by Darin Adler.
261
262         * Scripts/webkitpy/style/checkers/cpp.py:
263         (check_spacing):
264         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
265         (CppStyleTest.test_pointer_reference_marker_location):
266
267 2013-12-16  Rob Buis  <rob.buis@samsung.com>
268
269         Add my Samsung email address.
270
271         Unreviewed.
272
273         * Scripts/webkitpy/common/config/contributors.json:
274
275 2013-12-16  Oliver Hunt  <oliver@apple.com>
276
277         Cache getters and custom accessors on the prototype chain
278         https://bugs.webkit.org/show_bug.cgi?id=125602
279
280         Reviewed by Michael Saboff.
281
282         Make sure bencher scripts also make noInline exist
283
284         * Scripts/bencher:
285
286 2013-12-16  Anders Carlsson  <andersca@apple.com>
287
288         Fix crash when trying to load a null HTML string
289         https://bugs.webkit.org/show_bug.cgi?id=125801
290
291         Reviewed by Dan Bernstein.
292
293         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
294         (TestWebKitAPI::TEST_F):
295         Update test results.
296
297 2013-12-16  Alex Christensen  <achristensen@webkit.org>
298
299         Fixed Win64 build on VS2013.
300         https://bugs.webkit.org/show_bug.cgi?id=125753
301
302         Reviewed by Brent Fulgham.
303
304         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
305         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
306         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
307         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
308         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
309         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
310         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
311         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
312         * win/record-memory/record-memory.vcxproj:
313         Added correct PlatformToolset for 64-bit builds.
314
315 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
316
317         Add a menu option to MiniBrowser to enable UI-side compositing
318         https://bugs.webkit.org/show_bug.cgi?id=125793
319
320         Reviewed by Anders Carlsson.
321         
322         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
323
324         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
325         to toggle UI-side compositing.
326         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
327         * MiniBrowser/mac/WK2BrowserWindowController.m:
328         (-[WK2BrowserWindowController validateMenuItem:]):
329         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
330         (-[WK2BrowserWindowController toggleUISideCompositing:]):
331         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
332         Adjust the window title to indicate whether the window is using UI-side compositing.
333
334 2013-12-16  Commit Queue  <commit-queue@webkit.org>
335
336         Unreviewed, rolling out r160645.
337         http://trac.webkit.org/changeset/160645
338         https://bugs.webkit.org/show_bug.cgi?id=125787
339
340         Change breaks test-webkitpy (Requested by bfulgham on
341         #webkit).
342
343         * Scripts/prepare-ChangeLog:
344         (get_selector_line_ranges_for_css):
345
346 2013-12-16  David Farler  <dfarler@apple.com>
347
348         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
349         https://bugs.webkit.org/show_bug.cgi?id=124610
350
351         Reviewed by Mark Rowe.
352
353         * WebKitLauncher/WebKitNightlyEnabler.m:
354         (enableWebKitNightlyBehaviour):
355         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
356         * WebKitLauncher/main.m:
357         (main):
358         Include both libasancrashreporter and the nightly enabler to
359         the list of libraries to insert.
360
361 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
362
363         Resolve inconsistant style warning caused by r160319.
364         https://bugs.webkit.org/show_bug.cgi?id=125772
365
366         Reviewed by Darin Adler.
367
368         * Scripts/webkitpy/style/checkers/cpp.py:
369         (check_for_extra_new_line_at_eof):
370         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
371         (CppStyleTest.test_newline_at_eof):
372         (CppStyleTest.test_extra_newlines_at_eof):
373
374 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
375
376         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
377         https://bugs.webkit.org/show_bug.cgi?id=125780
378
379         Reviewed by Darin Adler.
380
381         * Scripts/webkitpy/port/mock_drt.py:
382         (main):
383         (parse_options):
384         (MockDRT.write_test_output):
385         * Scripts/webkitpy/port/mock_drt_unittest.py:
386         (MockDRTTest.assertTest):
387         (MockDRTTest.test_reftest_mismatch):
388
389 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
390
391         prepare-Changelog treats CSS keyframes as mismatched parentheses.
392         https://bugs.webkit.org/show_bug.cgi?id=125435
393
394         Reviewed by Darin Adler.
395
396         * Scripts/prepare-ChangeLog:
397         (get_selector_line_ranges_for_css):
398
399 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
400
401         [ATK] Expose accessibility objects for more WAI-ARIA roles
402         https://bugs.webkit.org/show_bug.cgi?id=125596
403
404         Reviewed by Chris Fleizach.
405
406         Add mappings to DRT & WKTR for the newly exposed roles.
407
408         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
409         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
410
411 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
412
413         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
414         https://bugs.webkit.org/show_bug.cgi?id=125594
415
416         Reviewed by Chris Fleizach.
417
418         Add mappings to DRT & WKTR for checkmenuitem role.
419
420         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
421         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
422
423 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
424
425         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
426         https://bugs.webkit.org/show_bug.cgi?id=125587
427
428         Reviewed by Chris Fleizach.
429
430         Add mappings to DRT & WKTR for article roles.
431
432         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
433         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
434
435 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
436
437         [FTL] Allow EFL to build FTL with the build-jsc script.
438         https://bugs.webkit.org/show_bug.cgi?id=125774
439
440         Reviewed by Zoltan Herczeg.
441
442         * Scripts/build-jsc:
443
444 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
445
446         Add myself as a committer
447
448         Unreviewed.
449
450         * Scripts/webkitpy/common/config/contributors.json:
451
452 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
453
454         Refactor option handling in WebKitTestRunner.
455         https://bugs.webkit.org/show_bug.cgi?id=123185
456
457         Reviewed by Darin Adler.
458
459         Option handling is refactored (according to the FIXME) that allows
460         to automatically generate the help message.
461
462         * WebKitTestRunner/CMakeLists.txt:
463         * WebKitTestRunner/GNUmakefile.am:
464         * WebKitTestRunner/Options.cpp: Added.
465         (WTR::Options::Options):
466         (WTR::handleOptionTimeout):
467         (WTR::handleOptionNoTimeout):
468         (WTR::handleOptionNoTimeoutAtAll):
469         (WTR::handleOptionVerbose):
470         (WTR::handleOptionGcBetweenTests):
471         (WTR::handleOptionPixelTests):
472         (WTR::handleOptionPrintSupportedFeatures):
473         (WTR::handleOptionComplexText):
474         (WTR::handleOptionAcceleratedDrawing):
475         (WTR::handleOptionRemoteLayerTree):
476         (WTR::handleOptionUnmatched):
477         (WTR::OptionsHandler::OptionsHandler):
478         (WTR::Option::Option):
479         (WTR::Option::matches):
480         (WTR::OptionsHandler::parse):
481         (WTR::OptionsHandler::printHelp):
482         * WebKitTestRunner/Options.h: Added.
483         * WebKitTestRunner/TestController.cpp:
484         (WTR::TestController::initialize):
485         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
486
487 2013-12-15  Dan Bernstein  <mitz@apple.com>
488
489         32-bit build fix.
490
491         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
492         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
493
494 2013-12-14  Tim Horton  <timothy_horton@apple.com>
495
496         stylebot should warn when FeatureDefines differ
497         https://bugs.webkit.org/show_bug.cgi?id=125748
498
499         Reviewed by Dan Bernstein.
500
501         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
502         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
503         an unlikely occurrance, to add them to the list).
504
505         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
506         but that is the most straightforward way to implement it (and we're at zero diffs right now).
507
508         * Scripts/webkitpy/style/checker.py:
509         (_all_categories):
510         (FileType):
511         (CheckerDispatcher._file_type):
512         (CheckerDispatcher._create_checker):
513         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
514         (FeatureDefinesChecker):
515         (FeatureDefinesChecker.__init__):
516         (FeatureDefinesChecker.check):
517
518 2013-12-13  Sam Weinig  <sam@webkit.org>
519
520         Fix API tests.
521
522         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
523         (TestWebKitAPI::TEST_F):
524
525 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
526
527         [Win] Remove Pre-VS2013 support code.
528         https://bugs.webkit.org/show_bug.cgi?id=125693
529
530         Reviewed by Darin Adler.
531
532         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
533         the math library.
534         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
535
536 2013-12-13  Lucas Forschler  <lforschler@apple.com>
537
538         Update Webkit bots.
539         
540         Unreviewed.
541         
542         * BuildSlaveSupport/build.webkit.org-config/config.json:
543
544 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
545
546         [Win] Unreviewed build fix after r160548
547
548         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
549         we are using vs12_xp target for Makefile-based projects.
550
551 2013-12-13  Lucas Forschler  <lforschler@apple.com>
552
553         Update Apple Webkit Bots
554         
555         Unreviewed.
556
557         * BuildSlaveSupport/build.webkit.org-config/config.json:
558
559 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
560
561         Unreviewed build fix after r160548.
562
563         * Scripts/webkitdirs.pm:
564         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
565
566 2013-12-13  Lucas Forschler  <lforschler@apple.com>
567
568         Update Apple bots.
569         
570         Unreviewed.
571
572         * BuildSlaveSupport/build.webkit.org-config/config.json:
573
574 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
575
576         [Win] Switch WebKit solution to Visual Studio 2013
577         https://bugs.webkit.org/show_bug.cgi?id=125192
578
579         Reviewed by Anders Carlsson.
580
581         Project files must reference vs12_xp for 32-bit builds. 
582
583         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
584         Update for VS2013
585         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
586         Ditto
587         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
588         Ditto
589         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
590         Ditto
591         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
592         Ditto
593         * Scripts/webkitdirs.pm:
594         (visualStudioInstallDir): Specify VS2013
595         (visualStudioVersion): Ditto.
596         (setupAppleWinEnv): Use VS2013 in messages
597         (setupCygwinEnv): Ditto
598         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
599         Update for VS2013
600         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
601         Ditto
602         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
603         Ditto
604         * win/record-memory/record-memory.vcxproj:
605         Ditto
606
607 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
608
609         Adding a .ycm_extra_conf file for webkitGtk
610         https://bugs.webkit.org/show_bug.cgi?id=119618
611
612         Reviewed by Gustavo Noronha Silva.
613
614         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
615         read the GTK+ build files to determine dynamically what flags to compile a source
616         file with. This allows Vim to provide auto-complete for C++/C language. See
617         https://github.com/Valloric/YouCompleteMe for how to use this file.
618
619         * gtk/common.py:
620         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
621         * gtk/ycm_extra_conf.py: Added.
622
623 2013-12-12  Tim Horton  <timothy_horton@apple.com>
624
625         [wk2] Handle pinch-to-zoom gesture
626         https://bugs.webkit.org/show_bug.cgi?id=125604
627
628         Reviewed by Simon Fraser.
629
630         * MiniBrowser/mac/WK2BrowserWindowController.m:
631         (-[WK2BrowserWindowController awakeFromNib]):
632         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
633
634 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
635
636         Unreviewed. Add myself as a committer.
637
638         * Scripts/webkitpy/common/config/contributors.json:
639
640 2013-12-12  Lucas Forschler  <lforschler@apple.com>
641
642         Update hardware for Apple bots.
643         
644         Unreviewed.
645
646         * BuildSlaveSupport/build.webkit.org-config/config.json:
647
648 2013-12-12  Lucas Forschler  <lforschler@apple.com>
649
650         Remove unused Apple Bots.
651         
652         Unreviewed.
653
654         * BuildSlaveSupport/build.webkit.org-config/config.json:
655
656 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
657
658         Unreviewed. Add myself as a committer.
659
660         * Scripts/webkitpy/common/config/contributors.json:
661
662 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
663
664         Test new JSContext name APIs
665         https://bugs.webkit.org/show_bug.cgi?id=125607
666
667         Reviewed by Darin Adler.
668
669         * Scripts/run-javascriptcore-tests:
670         Remove trailing whitespace.
671
672 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
673
674         [Autotools] Prepend the WebCore layer archives' names with 'lib'
675         https://bugs.webkit.org/show_bug.cgi?id=125627
676
677         Reviewed by Martin Robinson.
678
679         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
680         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
681
682 2013-12-12  Commit Queue  <commit-queue@webkit.org>
683
684         Unreviewed, rolling out r160446.
685         http://trac.webkit.org/changeset/160446
686         https://bugs.webkit.org/show_bug.cgi?id=125630
687
688         The upower-glib-based implementation is using API that was
689         recently removed (Requested by zdobersek1 on #webkit).
690
691         * Scripts/webkitperl/FeatureList.pm:
692
693 2013-12-12  Commit Queue  <commit-queue@webkit.org>
694
695         Unreviewed, rolling out r160417.
696         http://trac.webkit.org/changeset/160417
697         https://bugs.webkit.org/show_bug.cgi?id=125629
698
699         The patch is causing crashes (Requested by zdobersek1 on
700         #webkit).
701
702         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
703         (axObjectEventListener):
704         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
705
706 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
707
708         Use of ar T option not supported by older binutils
709         https://bugs.webkit.org/show_bug.cgi?id=118732
710
711         Reviewed by Gustavo Noronha Silva.
712
713         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
714         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
715         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
716         of the member's object file, and not the full path to it. To work around that, all the object files
717         under the build directory are listed by their relative paths. The members of various archives then have
718         the basenames of their paths grepped against that list, with the found path correlating to the member
719         finally added as the new member of the WebCoreLayer archive.
720
721 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
722
723         check-webkit-style shouldn't check spacing in #if preprocessor lines
724         https://bugs.webkit.org/show_bug.cgi?id=125534
725
726         Reviewed by Ryosuke Niwa.
727
728         Preprocessor lines that start with #if shouldn't have to adhere to
729         the same spacing requirements that regular code does
730
731         * Scripts/webkitpy/style/checkers/cpp.py:
732         (check_spacing):
733         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
734         (CppStyleTest.test_spacing_for_binary_ops):
735         (WebKitStyleTest.test_line_breaking):
736
737 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
738
739         check-webkit-style can't determine if a comma is part of an initialization list
740         https://bugs.webkit.org/show_bug.cgi?id=125537
741
742         Reviewed by Darin Adler.
743
744         The original check to make sure that initialization list lines start with
745         a comma didn't distinguish between commas that belong to the initialization
746         list and commas that are part of function calls. Because we don't want to
747         match parentheses with regular expressions, we should weaken this check to
748         only check for commas at the end of initialization list lines.
749
750         * Scripts/webkitpy/style/checkers/cpp.py:
751         (check_member_initialization_list):
752         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
753         (WebKitStyleTest.test_member_initialization_list):
754
755 2013-12-11  Tim Horton  <timothy_horton@apple.com>
756
757         Make it possible to compare layout test results between various configurations of WebKit
758         https://bugs.webkit.org/show_bug.cgi?id=125212
759         <rdar://problem/15199108>
760
761         Reviewed by Darin Adler.
762
763         * Scripts/compare-webkit-configurations: Added.
764         Add a script that allows comparison between the "normal" WebKit configuration
765         used for testing and a different configuration (e.g. with accelerated drawing
766         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
767
768         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
769
770         This script runs the tests once in the default configuration, ignoring
771         all test expectations, writing the results out to a temporary directory.
772
773         It then runs the tests again in the modified configuration, against the
774         just-written temporary results.
775
776         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
777
778         * DumpRenderTree/mac/DumpRenderTree.mm:
779         (resetWebPreferencesToConsistentValues):
780         (initializeGlobalsFromCommandLineOptions):
781         Enable accelerated drawing if requested.
782
783         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
784         (parse_args):
785         Add --accelerated-drawing and --remote-layer-tree feature switches, which
786         are forwarded on to the test drivers.
787         Move those two and --complex-text into their own "feature switches" section.
788         Drive-by change "Mac OS X" to "OS X".
789         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
790         as traditional pixel tests (with PNGs dumped on disk), and
791         ignores e.g. -expected.html files.
792
793         * Scripts/webkitpy/port/base.py:
794         (Port.reference_files):
795         Pretend that there are no ref tests.
796         Since is_reference_html_file is intact, our mechanism to ignore
797         the expected files will continue working in this case.
798
799         * Scripts/webkitpy/port/driver.py:
800         (Driver.cmd_line):
801         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
802
803         * WebKitTestRunner/TestController.cpp:
804         (WTR::TestController::TestController):
805         (WTR::TestController::initialize):
806         (WTR::TestController::resetPreferencesToConsistentValues):
807         * WebKitTestRunner/TestController.h:
808         (WTR::TestController::shouldUseRemoteLayerTree):
809         * WebKitTestRunner/TestInvocation.cpp:
810         (WTR::updateThreadedScrollingForCurrentTest):
811         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
812         (WTR::PlatformWebView::PlatformWebView):
813         Parse and implement the three feature switches.
814
815 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
816
817         [ATK] Expose accessibility objects WAI-ARIA landmark roles
818         https://bugs.webkit.org/show_bug.cgi?id=125584
819
820         Reviewed by Chris Fleizach.
821
822         Add mappings to DRT & WKTR for landmark roles.
823
824         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
825         (AccessibilityUIElement::role):
826         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
827         (WTR::AccessibilityUIElement::role):
828         * gtk/jhbuild.modules:
829
830 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
831
832         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
833         https://bugs.webkit.org/show_bug.cgi?id=125441
834
835         Reviewed by Martin Robinson.
836
837         Just avoid the double quotations when building the parameter
838         because some versions of valgrind are not handling it correctly.
839
840         * Scripts/webkitpy/port/gtk.py:
841         (GtkPort.setup_environ_for_server):
842
843 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
844
845         [GTK] Enable Battery Status API
846         https://bugs.webkit.org/show_bug.cgi?id=125453
847
848         Reviewed by Martin Robinson.
849
850         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
851
852 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
853
854         [GTK][WK2] Add the WebKitBatteryProvider class
855         https://bugs.webkit.org/show_bug.cgi?id=115720
856
857         Reviewed by Martin Robinson.
858
859         * gtk/generate-gtkdoc:
860         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
861
862 2013-12-11  Mark Rowe  <mrowe@apple.com>
863
864         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
865
866         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
867         to build and maintain this custom Perl module.
868
869         Reviewed by Anders Carlsson.
870
871         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
872         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
873         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
874         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
875         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
876         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
877         build DumpRenderTree.
878         (dumpToolDidCrash): Stop importing and using the module.
879         * Scripts/webkitpy/port/base.py:
880         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
881
882 2013-12-11  Brendan Long  <b.long@cablelabs.com>
883
884         [GTK] Add "enable-mediasource" property to WebKitWebSettings
885         https://bugs.webkit.org/show_bug.cgi?id=125566
886
887         Reviewed by Philippe Normand.
888
889         * DumpRenderTree/gtk/DumpRenderTree.cpp:
890         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
891         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
892         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
893
894 2013-12-11  Dan Bernstein  <mitz@apple.com>
895
896         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
897         https://bugs.webkit.org/show_bug.cgi?id=125579
898
899         Reviewed by Anders Carlsson.
900
901         * MiniBrowser/mac/WK2BrowserWindowController.m:
902         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
903         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
904         activeURL property changes, update the URL field with its value.
905         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
906         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
907         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
908         Ditto.
909         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
910         Ditto.
911         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
912         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
913
914 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
915
916         Fixed test-wepkitpy logging for buildslaves
917         https://bugs.webkit.org/show_bug.cgi?id=125445
918
919         Reviewed by Csaba Osztrogonác.
920
921         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
922         (RunPythonTests):
923
924 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
925
926         Programmatically-inserted children lack accessibility events
927         https://bugs.webkit.org/show_bug.cgi?id=100275
928
929         Reviewed by Chris Fleizach.
930
931         Update DRT and WebKitTestRunner to handle the children-changed
932         signal properly, considering the detail and optional parameters.
933
934         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
935         (axObjectEventListener):
936         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
937
938 2013-12-03  Mark Rowe  <mrowe@apple.com>
939
940         <https://webkit.org/b/125139> Modernize the WebKit API headers
941         <rdar://problem/15540175>
942
943         Reviewed by Anders Carlsson.
944
945         * DumpRenderTree/mac/TestRunnerMac.mm:
946         (TestRunner::setCacheModel): Cast to the enum type.
947
948 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
949
950         Get rid of forward exit on DoubleAsInt32
951         https://bugs.webkit.org/show_bug.cgi?id=125552
952
953         Reviewed by Oliver Hunt.
954         
955         Add some support for testing the generic (non-X86) paths on X86 by disabling
956         architecture-specific optimizations (ASO's).
957
958         * Scripts/run-javascriptcore-tests:
959         * Scripts/run-jsc-stress-tests:
960
961 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
962
963         Unreviewed EFL build fix attempt
964
965         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
966         * WebKitTestRunner/CMakeLists.txt: Ditto.
967
968 2013-12-10  Anders Carlsson  <andersca@apple.com>
969
970         Add a HashMap constructor that takes an initializer list
971         https://bugs.webkit.org/show_bug.cgi?id=125551
972
973         Reviewed by Dan Bernstein.
974
975         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
976         (TestWebKitAPI::TEST):
977
978 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
979
980         Use std::array when computing MD5 checksum
981         https://bugs.webkit.org/show_bug.cgi?id=125509
982
983         Reviewed by Anders Carlsson.
984
985         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
986
987         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
988         (computeMD5HashStringForBitmapContext):
989         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
990         (computeMD5HashStringForBitmapContext):
991         * TestWebKitAPI/Tests/WTF/MD5.cpp:
992         (TestWebKitAPI::expectMD5):
993         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
994         (WTR::computeMD5HashStringForCairoSurface):
995         * WebKitTestRunner/cg/TestInvocationCG.cpp:
996         (WTR::computeMD5HashStringForContext):
997
998 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
999
1000         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1001         https://bugs.webkit.org/show_bug.cgi?id=125522
1002
1003         Reviewed by Chris Fleizach.
1004
1005         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1006
1007         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1008         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1009
1010 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1011
1012         Add --makeargs option to build-jsc
1013         https://bugs.webkit.org/show_bug.cgi?id=125344
1014
1015         Reviewed by Filip Pizlo.
1016
1017         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1018
1019 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1020
1021         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1022         https://bugs.webkit.org/show_bug.cgi?id=125497
1023
1024         Reviewed by Mario Sanchez Prada.
1025
1026         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1027         (AccessibilityUIElement::stringForRange): Implemented.
1028         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1029         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1030
1031 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1032
1033         Various fixes for the CMake GTK+ build
1034
1035         Reviewed by Gustavo Noronha.
1036
1037         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1038         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1039
1040 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1041
1042         --cloop option does not work in Tools/Scripts/build-jsc.
1043         https://bugs.webkit.org/show_bug.cgi?id=125214
1044
1045         Reviewed by Csaba Osztrogonác.
1046
1047         * Scripts/build-jsc:
1048
1049 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1050
1051         Merge mark_for_landing and mark_for_commit_queue into one argument
1052         https://bugs.webkit.org/show_bug.cgi?id=125448
1053
1054         Reviewed by Ryosuke Niwa.
1055
1056         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1057         (CommitQueueFlag):
1058         (Bugzilla._commit_queue_flag):
1059         (Bugzilla._fill_attachment_form):
1060         (Bugzilla.add_patch_to_bug):
1061         (Bugzilla.create_bug):
1062         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1063         (test_commit_queue_flag.assert_commit_queue_flag):
1064         (test_commit_queue_flag):
1065
1066 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1067
1068         Remove dead extract_reference_link.py (and the reftests module)
1069         https://bugs.webkit.org/show_bug.cgi?id=125116
1070
1071         Reviewed by Ryosuke Niwa.
1072
1073         This code doesn't seem to have ever been used.
1074
1075         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1076         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1077         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1078
1079 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1080
1081         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1082         https://bugs.webkit.org/show_bug.cgi?id=125456
1083
1084         Reviewed by Chris Fleizach.
1085
1086         Return 'AXSection' for section roles instead of 'AXDiv'.
1087
1088         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1089         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1090
1091 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1092
1093         check-webkit-style should check for extra newlines at EOF
1094         https://bugs.webkit.org/show_bug.cgi?id=125424
1095
1096         Reviewed by Darin Adler.
1097
1098         Report a style violation if extraneous newlines are added
1099         to the end of a C++ file. There should only be one newline at EOF.
1100
1101         * Scripts/webkitpy/style/checkers/cpp.py:
1102         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1103         (check_for_extra_new_line_at_eof): Added.
1104         (_process_lines): Added new check and renamed existing EOF check.
1105         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1106         (CppStyleTest.test_extra_newlines_at_eof): Added.
1107         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1108
1109 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1110
1111         check-webkit-style: ternary operator in macro call identified as initialization list
1112         https://bugs.webkit.org/show_bug.cgi?id=125443
1113
1114         Reviewed by Ryosuke Niwa.
1115
1116         Do not match initialization list when questionmark is placed before :
1117
1118         * Scripts/webkitpy/style/checkers/cpp.py:
1119         (check_member_initialization_list):
1120
1121 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1122
1123         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1124         https://bugs.webkit.org/show_bug.cgi?id=125451
1125
1126         Reviewed by Mario Sanchez Prada.
1127
1128         Create the needed callbacks for DRT and WKTR.
1129
1130         * DumpRenderTree/AccessibilityUIElement.cpp:
1131         (characterAtOffsetCallback): added
1132         (wordAtOffsetCallback): added
1133         (lineAtOffsetCallback): added
1134         (sentenceAtOffsetCallback): added
1135         (AccessibilityUIElement::getJSClass):
1136         * DumpRenderTree/AccessibilityUIElement.h:
1137         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1138         (stringAtOffset): added
1139         (AccessibilityUIElement::characterAtOffset): added
1140         (AccessibilityUIElement::wordAtOffset): added
1141         (AccessibilityUIElement::lineAtOffset): added
1142         (AccessibilityUIElement::sentenceAtOffset): added
1143         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1144         (WTR::AccessibilityUIElement::characterAtOffset): added
1145         (WTR::AccessibilityUIElement::wordAtOffset): added
1146         (WTR::AccessibilityUIElement::lineAtOffset): added
1147         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1148         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1149         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1150         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1151         (WTR::stringAtOffset): added
1152         (WTR::AccessibilityUIElement::characterAtOffset): added
1153         (WTR::AccessibilityUIElement::wordAtOffset): added
1154         (WTR::AccessibilityUIElement::lineAtOffset): added
1155         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1156
1157 2013-12-08  Sam Weinig  <sam@webkit.org>
1158
1159         32-bit MiniBrowser doesn't build
1160         https://bugs.webkit.org/show_bug.cgi?id=125420
1161
1162         Reviewed by Dan Bernstein.
1163
1164         * MiniBrowser/mac/AppDelegate.h:
1165         * MiniBrowser/mac/AppDelegate.m:
1166         (-[BrowserAppDelegate init]):
1167         (-[BrowserAppDelegate applicationWillTerminate:]):
1168
1169 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1170
1171         [WK2] Add ENABLE_NETWORK_PROCESS flag
1172         https://bugs.webkit.org/show_bug.cgi?id=125421
1173
1174         Add support to build with the Network Process enabled.
1175
1176         Reviewed by Martin Robinson.
1177
1178         * Scripts/webkitperl/FeatureList.pm:
1179
1180 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1181
1182         Fold typedArray.length if typedArray is constant
1183         https://bugs.webkit.org/show_bug.cgi?id=125252
1184
1185         Reviewed by Sam Weinig.
1186         
1187         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1188         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1189         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1190
1191         * Scripts/run-javascriptcore-tests:
1192
1193 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1194
1195         [gdb] Update printers for WTF::CString, JSC::JSString
1196         https://bugs.webkit.org/show_bug.cgi?id=124600
1197
1198         Reviewed by Gustavo Noronha Silva.
1199
1200         Update the two printers after they fell behind the changes in implementation.
1201
1202         * gdb/webkit.py:
1203         (WTFCStringPrinter.to_string):
1204         (JSCJSStringPrinter.to_string):
1205
1206 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1207
1208         [webkitpy] Add a WestonDriver unit test
1209         https://bugs.webkit.org/show_bug.cgi?id=125408
1210
1211         Reviewed by Gustavo Noronha Silva.
1212
1213         Add a webkitpy unit test for the Weston driver.
1214
1215         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1216         (WestonDriverTest):
1217         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1218         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1219         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1220         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1221         the driver cleans up the temporary directory.
1222         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1223         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1224
1225 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1226
1227         [Gtk] install-dependencies doesn't install libgtk-3-dev
1228         https://bugs.webkit.org/show_bug.cgi?id=125320
1229
1230         Reviewed by Gustavo Noronha Silva.
1231
1232         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1233
1234 2013-12-07  Sam Weinig  <sam@webkit.org>
1235
1236         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1237         https://bugs.webkit.org/show_bug.cgi?id=125401
1238
1239         Reviewed by Dan Bernstein.
1240
1241         * MiniBrowser/mac/WK2BrowserWindowController.m:
1242         (-[WK2BrowserWindowController fetch:]):
1243         (-[WK2BrowserWindowController reload:]):
1244         (-[WK2BrowserWindowController goBack:]):
1245         (-[WK2BrowserWindowController goForward:]):
1246         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1247         (-[WK2BrowserWindowController currentZoomFactor]):
1248         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1249         (-[WK2BrowserWindowController zoomIn:]):
1250         (-[WK2BrowserWindowController zoomOut:]):
1251         (-[WK2BrowserWindowController canResetZoom]):
1252         (-[WK2BrowserWindowController resetZoom:]):
1253         (-[WK2BrowserWindowController toggleZoomMode:]):
1254         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1255
1256 2013-12-07  Sam Weinig  <sam@webkit.org>
1257
1258         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1259         https://bugs.webkit.org/show_bug.cgi?id=125400
1260
1261         Reviewed by Dan Bernstein.
1262
1263         * MiniBrowser/mac/AppDelegate.h:
1264         * MiniBrowser/mac/AppDelegate.m:
1265         * MiniBrowser/mac/WK2BrowserWindowController.h:
1266         * MiniBrowser/mac/WK2BrowserWindowController.m:
1267         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1268         (-[WK2BrowserWindowController dealloc]):
1269         (createNewPage):
1270         (-[WK2BrowserWindowController awakeFromNib]):
1271         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1272         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1273         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1274         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1275         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1276         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1277
1278 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1279
1280         [GTK] Run each gtest subtest separately instead of in one go
1281         https://bugs.webkit.org/show_bug.cgi?id=125386
1282
1283         Reviewed by Martin Robinson.
1284
1285         This is what other ports are doing (except they build each test as a separate binary)
1286         and will help with the timeouts we sometimes hit because it applies to the full test
1287         run.
1288
1289         * Scripts/run-gtk-tests:
1290         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1291         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1292         (TestRunner._run_google_test_suite): call the binary once per subtest.
1293
1294 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1295
1296         Move PrettyPatch related code to prettypatch.py
1297         https://bugs.webkit.org/show_bug.cgi?id=124937
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         This code seems to have a better place here than in Port, since PrettyPatch already knows
1302         pretty_patch_path, and this also unifies the usage of PrettyPatch
1303
1304         * Scripts/webkitpy/common/prettypatch.py:
1305         (PrettyPatch.__init__):
1306         (PrettyPatch.pretty_diff):
1307         (PrettyPatch):
1308         (PrettyPatch.pretty_patch_available):
1309         (PrettyPatch.check_pretty_patch):
1310         (PrettyPatch.pretty_patch_text):
1311         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1312         (TestResultWriter.create_text_diff_and_write_result):
1313         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1314         (summarize_results):
1315         * Scripts/webkitpy/port/base.py:
1316         (Port.__init__):
1317         (Port.wdiff_available):
1318         (Port.check_image_diff):
1319         (Port.wdiff_text):
1320         * Scripts/webkitpy/port/base_unittest.py:
1321         (PortTest.test_pretty_patch_os_error):
1322         (PortTest.test_pretty_patch_script_error):
1323
1324 2013-12-06  Dan Bernstein  <mitz@apple.com>
1325
1326         [Mac] MiniBrowser Debug builds are compiled with -Os
1327         https://bugs.webkit.org/show_bug.cgi?id=125376
1328
1329         Reviewed by Tim Horton.
1330
1331         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1332         the Debug configuration at the project level.
1333
1334 2013-12-06  Jer Noble  <jer.noble@apple.com>
1335
1336         [MSE] Add a runtime-setting for the MediaSource constructor.
1337         https://bugs.webkit.org/show_bug.cgi?id=125336
1338
1339         Reviewed by Eric Carlson.
1340
1341         Enable MediaSource in DRT and WKTR.
1342
1343         * DumpRenderTree/mac/DumpRenderTree.mm:
1344         (resetWebPreferencesToConsistentValues):
1345         * WebKitTestRunner/TestController.cpp:
1346         (WTR::TestController::resetPreferencesToConsistentValues):
1347
1348 2013-12-06  Jer Noble  <jer.noble@apple.com>
1349
1350         Strip out extraneous logging from AppleGVA in media tests.
1351         https://bugs.webkit.org/show_bug.cgi?id=125357
1352
1353         Reviewed by Simon Fraser.
1354
1355         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1356
1357         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1358         (SingleTestRunner._run_compare_test): Strip out logging
1359         * Scripts/webkitpy/port/base.py:
1360         (Port.logging_patterns_to_strip): Return an empty list by default.
1361         * Scripts/webkitpy/port/driver.py:
1362         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1363         * Scripts/webkitpy/port/mac.py:
1364         (MacPort.logging_patterns_to_strip): Return a complete list.
1365
1366 2013-12-06  Dean Jackson  <dino@apple.com>
1367
1368         Updating ANGLE should point to instructions
1369         https://bugs.webkit.org/show_bug.cgi?id=125361
1370
1371         Reviewed by Eric Carlson.
1372
1373         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1374         someone wants to patch ANGLE.
1375
1376         * Scripts/webkitpy/common/config/watchlist:
1377
1378 2013-12-06  Dan Bernstein  <mitz@apple.com>
1379
1380         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1381         https://bugs.webkit.org/show_bug.cgi?id=125334
1382
1383         Reviewed by Darin Adler.
1384
1385         * MiniBrowser/mac/WK2BrowserWindowController.m:
1386         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1387         title property.
1388         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1389         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1390         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1391         window title with the title property changes.
1392         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1393         set the load delegate instead of the load client.
1394         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1395         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1396         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1397         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1398         Implemented this load delegate method.
1399         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1400         Ditto.
1401         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1402         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1403         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1404         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1405         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1406         Ditto.
1407         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1408         Ditto.
1409         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1410
1411 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1412
1413         Remove function from style/checkers/cpp.py.
1414         https://bugs.webkit.org/show_bug.cgi?id=125341
1415
1416         Reviewed by Darin Adler.
1417
1418         Corrects a FIXME: by removing a function from cpp.py.
1419
1420         * Scripts/webkitpy/style/checkers/cpp.py:
1421         (CppChecker.__init__):
1422         (CppChecker.check):
1423         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1424         (CppStyleTestBase.process_file_data):
1425
1426 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1427
1428         check-webkit-style: false positive warning for indentation of #ifdef code.
1429         https://bugs.webkit.org/show_bug.cgi?id=125254
1430
1431         Reviewed by Darin Adler.
1432
1433         * Scripts/webkitpy/style/checkers/cpp.py:
1434         (check_member_initialization_list):
1435         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1436         (WebKitStyleTest.test_member_initialization_list):
1437
1438 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1439
1440         Fix spelling error in style checker: beggining
1441         https://bugs.webkit.org/show_bug.cgi?id=125347
1442
1443         Reviewed by Anders Carlsson.
1444
1445         * Scripts/webkitpy/style/checkers/cpp.py:
1446         (check_member_initialization_list):
1447         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1448         (WebKitStyleTest.test_member_initialization_list):
1449
1450 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1451
1452         [ATK] Missing aria roles mappings
1453         https://bugs.webkit.org/show_bug.cgi?id=117729
1454
1455         Reviewed by Mario Sanchez Prada.
1456
1457         Added new mappings to AccessibilityUIElementAtk.cpp.
1458
1459         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1461
1462 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1463
1464         Typo fix after r160218.
1465
1466         * Scripts/webkitpy/test/main.py:
1467         (main):
1468
1469 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1470
1471         Unreviewed fix after r160206.
1472
1473         * Scripts/webkitpy/test/main.py:
1474         (main): sys.platform can be win32 or cygwin too on Windows.
1475
1476 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1477
1478         Disable WebKit2 webkitpy unittests on Windows
1479         https://bugs.webkit.org/show_bug.cgi?id=125318
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         * Scripts/webkitpy/test/main.py:
1484         (main):
1485
1486 2013-12-05  Anders Carlsson  <andersca@apple.com>
1487
1488         Tweak WeakObjCPtr
1489         https://bugs.webkit.org/show_bug.cgi?id=125311
1490
1491         Reviewed by Darin Adler.
1492
1493         Split up tests into more logical groups. Add new tests for new functionality.
1494
1495         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1496
1497 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1498
1499         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1500         https://bugs.webkit.org/show_bug.cgi?id=125302
1501
1502         Reviewed by Philippe Normand.
1503
1504         * gtk/generate-webkitdom-doc-files:
1505         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1506         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1507         and WEBKIT_DEPRECATED_FOR macros.
1508
1509 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1510
1511         Fix cross compilation on x86
1512         https://bugs.webkit.org/show_bug.cgi?id=125295
1513
1514         Reviewed by Zoltan Herczeg.
1515
1516         Certain compiler flags should not be added when cross compilation is enabled.
1517
1518         * Scripts/webkitdirs.pm:
1519         (runAutogenForAutotoolsProjectIfNecessary):
1520         (generateBuildSystemFromCMakeProject):
1521
1522 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1523
1524         Remove duplicated/dead code from cpp style checker unit tests.
1525         https://bugs.webkit.org/show_bug.cgi?id=125226
1526
1527         Reviewed by Ryosuke Niwa.
1528
1529         Remove the first definition of OrderOfIncludesTest class as it is
1530         overwritten by the second. Remove a duplicated assert statement
1531         from the second class.
1532
1533         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1534         (OrderOfIncludesTest.setUp):
1535         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1536           The last assert was duplicated.
1537
1538 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1539
1540         Remove Scripts/generate-qt-inspector-resource.
1541         https://bugs.webkit.org/show_bug.cgi?id=125288
1542
1543         Reviewed by Andreas Kling.
1544
1545         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1546         We don't need this file.
1547
1548 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1549
1550         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1551         https://bugs.webkit.org/show_bug.cgi?id=125218
1552
1553         Reviewed by Ryosuke Niwa.
1554
1555         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1556         (LayoutTestFinder.skip_tests):
1557         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1558         (LayoutTestRunner.run_tests):
1559         (LayoutTestRunner._update_summary_with_result):
1560         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1561         (Manager._test_is_slow):
1562         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1563         (JSONLayoutResultsGenerator._insert_failure_summaries):
1564         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1565         (TestExpectations.get_rebaselining_failures):
1566         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1567         (assert_exp):
1568         (MiscTests.test_multiple_results):
1569         (MiscTests.test_category_expectations):
1570         (MiscTests.test_get_modifiers):
1571         (MiscTests.test_get_expectations_string):
1572         (MiscTests.test_expectation_to_string):
1573         (MiscTests.test_get_test_set):
1574         (MiscTests.test_more_specific_override_resets_skip):
1575         (SkippedTests.check):
1576         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1577         (TestRunResults.__init__):
1578         (summarize_results):
1579         * Scripts/webkitpy/tool/commands/rebaseline.py:
1580         (RebaselineExpectations._tests_to_rebaseline):
1581
1582 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1583
1584         Enable HTMLTemplateElement by default
1585         https://bugs.webkit.org/show_bug.cgi?id=123851
1586
1587         Reviewed by Antti Koivisto.
1588
1589         * Scripts/webkitperl/FeatureList.pm:
1590
1591 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1592
1593         [EFL] Bumping GStreamer version to 1.2.1
1594         https://bugs.webkit.org/show_bug.cgi?id=125155
1595
1596         Reviewed by Gyuyoung Kim.
1597
1598         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1599
1600
1601 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1602
1603         Update jhbuild revision.
1604         https://bugs.webkit.org/show_bug.cgi?id=124966
1605         
1606         Reviewed by Gyuyoung Kim.
1607
1608         Used version of Jhbuild failed to create directories and caused
1609         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1610
1611         * jhbuild/jhbuild-wrapper:
1612
1613 2013-12-04  Anders Carlsson  <andersca@apple.com>
1614
1615         Add a WeakObjCPtr class
1616         https://bugs.webkit.org/show_bug.cgi?id=125267
1617
1618         Reviewed by Geoffrey Garen.
1619
1620         Add API tests for WeakObjCPtr.
1621
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1624         (TEST):
1625
1626 2013-12-04  Anders Carlsson  <andersca@apple.com>
1627
1628         Make the estimatedProgress property observable using KVO
1629         https://bugs.webkit.org/show_bug.cgi?id=125259
1630
1631         Reviewed by Dan Bernstein.
1632
1633         Bind the progress indicator value to the "estimatedProgress" property.
1634
1635         * MiniBrowser/mac/WK2BrowserWindowController.m:
1636         (-[WK2BrowserWindowController dealloc]):
1637         (-[WK2BrowserWindowController awakeFromNib]):
1638
1639 2013-12-04  Anders Carlsson  <andersca@apple.com>
1640
1641         Add a loading property to WKBrowsingContextController
1642         https://bugs.webkit.org/show_bug.cgi?id=125256
1643
1644         Reviewed by Dan Bernstein.
1645
1646         Bind the progress indicator visibility to the "loading" property.
1647
1648         * MiniBrowser/mac/WK2BrowserWindowController.m:
1649         (-[WK2BrowserWindowController dealloc]):
1650         (-[WK2BrowserWindowController awakeFromNib]):
1651         (-[WK2BrowserWindowController didStartProgress]):
1652         (-[WK2BrowserWindowController didFinishProgress]):
1653
1654 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1655
1656         [EFL][WK2] Buildfix after r160104
1657         https://bugs.webkit.org/show_bug.cgi?id=125231
1658
1659         Reviewed by Anders Carlsson.
1660
1661         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1662         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1663         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1664         (TestWebKitAPI::setViewClient): Ditto.
1665
1666 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1667
1668         check-webkit-style detected some ternary statements as initialization lists
1669         https://bugs.webkit.org/show_bug.cgi?id=125246
1670
1671         Reviewed by Dean Jackson.
1672
1673         The regular expression that check-webkit-tests uses to detect initialization
1674         lists was too broad, resulting in false positives. This patch makes the
1675         regex more specific
1676
1677         * Scripts/webkitpy/style/checkers/cpp.py:
1678         (check_member_initialization_list):
1679         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1680         (WebKitStyleTest.test_member_initialization_list):
1681
1682 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1683
1684         run-jsc-stress-tests can only run locally
1685         https://bugs.webkit.org/show_bug.cgi?id=124551
1686
1687         Reviewed by Filip Pizlo.
1688
1689         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1690         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1691         added a couple more signals to handle gracefully at shutdown. 
1692         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1693         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1694         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1695         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1696         toward the end of the script to make it easier to tell which of the various modes do what.
1697
1698 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1699
1700         [EFL][WK2] Buildfix after r160104
1701         https://bugs.webkit.org/show_bug.cgi?id=125233
1702
1703         Reviewed by Anders Carlsson.
1704
1705         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1706         (TestWebKitAPI::TEST):
1707         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1708         (TestWebKitAPI::setPageLoaderClient):
1709
1710 2013-12-03  Anders Carlsson  <andersca@apple.com>
1711
1712         Deprecate all unversioned client structs in favor of having explicit versioned structs
1713         https://bugs.webkit.org/show_bug.cgi?id=125203
1714
1715         Reviewed by Dan Bernstein.
1716
1717         Update for WebKit2 API changes.
1718
1719         * MiniBrowser/mac/AppDelegate.m:
1720         (-[BrowserAppDelegate init]):
1721         * MiniBrowser/mac/WK2BrowserWindowController.m:
1722         (-[WK2BrowserWindowController awakeFromNib]):
1723         * TestWebKitAPI/InjectedBundleController.cpp:
1724         (TestWebKitAPI::InjectedBundleController::initialize):
1725         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1728         (TestWebKitAPI::setInjectedBundleClient):
1729         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1730         (TestWebKitAPI::TEST):
1731         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1732         (TestWebKitAPI::TEST):
1733         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1734         (TestWebKitAPI::TEST):
1735         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1736         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1737         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1738         (TestWebKitAPI::TEST):
1739         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1740         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1741         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1742         (TestWebKitAPI::setInjectedBundleClient):
1743         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1744         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1745         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1746         (TestWebKitAPI::TEST):
1747         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1748         (TestWebKitAPI::TEST):
1749         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1750         (TestWebKitAPI::setContextDownloadClient):
1751         (TestWebKitAPI::setPagePolicyClient):
1752         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1755         (TestWebKitAPI::TEST):
1756         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1765         (TestWebKitAPI::setupGeolocationProvider):
1766         (TestWebKitAPI::setupView):
1767         (TestWebKitAPI::TEST):
1768         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1771         (TestWebKitAPI::setPageLoaderClient):
1772         (TestWebKitAPI::setInjectedBundleClient):
1773         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1774         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1775         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1776         (TestWebKitAPI::TEST):
1777         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1778         (TestWebKitAPI::setInjectedBundleClient):
1779         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1780         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
1781         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1782         (TestWebKitAPI::TEST):
1783         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1786         (TestWebKitAPI::TEST):
1787         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1788         (TestWebKitAPI::TEST):
1789         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1790         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
1791         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1792         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1793         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1794         (TestWebKitAPI::setPageLoaderClient):
1795         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1796         (TestWebKitAPI::setPageLoaderClient):
1797         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1798         (TestWebKitAPI::setPageLoaderClient):
1799         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1800         (TestWebKitAPI::setPageLoaderClient):
1801         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1802         (TestWebKitAPI::setPageLoaderClient):
1803         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1804         (TestWebKitAPI::TEST):
1805         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1806         (TestWebKitAPI::TEST):
1807         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1808         (TestWebKitAPI::setInjectedBundleClient):
1809         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1810         (TestWebKitAPI::ParentFrameTest::didCreatePage):
1811         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1812         (TestWebKitAPI::setInjectedBundleClient):
1813         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1814         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
1815         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1816         (TestWebKitAPI::TEST):
1817         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1818         (TestWebKitAPI::TEST):
1819         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1820         (TestWebKitAPI::TEST):
1821         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1822         (TestWebKitAPI::TEST):
1823         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1824         (TestWebKitAPI::setInjectedBundleClient):
1825         (TestWebKitAPI::setPageLoaderClient):
1826         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1827         (TestWebKitAPI::setPageLoaderClient):
1828         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1829         (TestWebKitAPI::TEST):
1830         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1831         (TestWebKitAPI::setPageLoaderClient):
1832         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1833         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1834         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1837         (TestWebKitAPI::TEST):
1838         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1839         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1840         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1841         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
1842         (TestWebKitAPI::TEST):
1843         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
1844         (TestWebKitAPI::WKConnectionTest::initialize):
1845         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1846         (TestWebKitAPI::setPageLoaderClient):
1847         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1848         (TestWebKitAPI::setInjectedBundleClient):
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1851         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
1852         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1853         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1854         (TestWebKitAPI::setInjectedBundleClient):
1855         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1856         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1857         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1858         (TestWebKitAPI::TEST):
1859         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1860         (TestWebKitAPI::setInjectedBundleClient):
1861         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1862         (TestWebKitAPI::TEST):
1863         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1864         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1865         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1866         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1867         (TestWebKitAPI::didCreateConnection):
1868         (TestWebKitAPI::TEST):
1869         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1870         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1871         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1872         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1873         (TestWebKitAPI::setPageLoaderClient):
1874         * WebKitTestRunner/GeolocationProviderMock.cpp:
1875         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1877         (WTR::InjectedBundle::initialize):
1878         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1879         (WTR::InjectedBundlePage::InjectedBundlePage):
1880         * WebKitTestRunner/TestController.cpp:
1881         (WTR::TestController::createOtherPage):
1882         (WTR::TestController::initialize):
1883         (WTR::TestController::createWebViewWithOptions):
1884
1885 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1886
1887         Style checker for .messages.in files (WTF:: prefix)
1888         https://bugs.webkit.org/show_bug.cgi?id=125142
1889
1890         Reviewed by Anders Carlsson.
1891
1892         A new style checker for .messages.in files, that checks for the use of WTF::
1893         prefix in these files. (Also checks for tabs as these files were previously
1894         handled as text files.)
1895
1896         * Scripts/webkitpy/style/checker.py:
1897         (CheckerDispatcher._create_checker):
1898           New checker is returned for .messages.in files.
1899         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
1900           The new style checker class.
1901         (MessagesInChecker):
1902         (MessagesInChecker.__init__):
1903         (MessagesInChecker.check):
1904         (MessagesInChecker.check_WTF_prefix):
1905         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
1906           Unit test for the new style  checker class.
1907         (MessagesInCheckerStyleTestCase):
1908         (test_checker):
1909         (test_checker.error_handler_for_test):
1910         (MessagesInCheckerTestCase):
1911         (MessagesInCheckerTestCase.test_init):
1912         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
1913
1914 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1915
1916         Style checker requires alphabetical ordering in cmake lists even it contains variable.
1917         https://bugs.webkit.org/show_bug.cgi?id=124918
1918
1919         Reviewed by Csaba Osztrogonác.
1920
1921         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1922         (CMakeCheckerTest.test_check):
1923         * Scripts/webkitpy/style/checkers/cmake.py:
1924         (CMakeChecker._check_list_order):
1925         This will ignore lines with variable substitution.
1926
1927 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1928
1929         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
1930         https://bugs.webkit.org/show_bug.cgi?id=124731
1931
1932         Reviewed by Zoltan Herczeg.
1933
1934         * Scripts/webkitpy/style/checkers/cpp.py:
1935         (check_spacing):
1936         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1937         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
1938
1939 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1940
1941         Remove codecs and os dependencies from filereader.py in webkitpy/style.
1942         https://bugs.webkit.org/show_bug.cgi?id=124719
1943
1944         Although TextFileReader requires a FileSystem it circumvents it in two places!
1945         We should use the FileSystem only and remove codecs and os imports.
1946
1947         Reviewed by Zoltan Herczeg.
1948
1949         * Scripts/webkitpy/common/system/filesystem.py:
1950         (FileSystem.open_stdin): Moved from TextFileReader
1951         * Scripts/webkitpy/style/filereader.py:
1952         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1953         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1954
1955 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1956
1957         check-webkit-style should check member initialization indentation.
1958         https://bugs.webkit.org/show_bug.cgi?id=124820
1959
1960         Reviewed by Zoltan Herczeg.
1961
1962         check-webkit-style should check member initialization indentation
1963         belongs to webkit coding style:
1964         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1965
1966         * Scripts/webkitpy/style/checkers/cpp.py:
1967         (check_member_initialization_list): Add new method to check member
1968         initialization list.
1969         (check_style): Add the call of the new method.
1970         (check_language): Move self initialization checking into the new method.
1971         (CppChecker): Add a new category for initialization list.
1972         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1973         (CppStyleTest.test_runtime_selfinit):
1974         (CppStyleTest.test_deprecated_cast):
1975         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1976         the new feature.
1977
1978 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1979
1980         style-bot should reject Committer additions to committers.py
1981         https://bugs.webkit.org/show_bug.cgi?id=107574
1982
1983         Reviewed by Zoltan Herczeg.
1984
1985         The style check when executed in non-interactive mode (probably by a
1986         bot) will raise an additional error if the contributors.json file is
1987         modified. Non-interactive mode information is propagated to the
1988         Dispatcher, which creates a special JSON checker for the
1989         contributors.json file.
1990
1991         * Scripts/webkitpy/style/checker.py:
1992         (check_webkit_style_configuration):
1993         (CheckerDispatcher._create_checker):
1994         (CheckerDispatcher.dispatch):
1995         (StyleProcessorConfiguration.__init__):
1996         (StyleProcessor.process):
1997         * Scripts/webkitpy/style/checker_unittest.py:
1998         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1999         (CheckerDispatcherDispatchTest.dispatch):
2000         (StyleProcessorConfigurationTest._style_checker_configuration):
2001         (StyleProcessor_EndToEndTest.test_init):
2002         (StyleProcessor_EndToEndTest.test_process):
2003         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2004         (StyleProcessor_CodeCoverageTest.setUp):
2005         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2006         (JSONChecker.line_number_from_json_exception):
2007         (JSONContributorsChecker):
2008         (JSONContributorsChecker.check):
2009         * Scripts/webkitpy/style/error_handlers_unittest.py:
2010         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2011         * Scripts/webkitpy/style/optparser.py:
2012         (CommandOptionValues.__init__):
2013         (ArgumentParser._create_option_parser):
2014         (ArgumentParser.parse):
2015         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2016         (test_post):
2017         (test_upload):
2018         * Scripts/webkitpy/tool/steps/checkstyle.py:
2019         (CheckStyle.run):
2020
2021 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2022
2023         [EFL][WK2] Fix build after API::Client changes
2024         https://bugs.webkit.org/show_bug.cgi?id=125206
2025
2026         Reviewed by Csaba Osztrogonác.
2027
2028         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2029         (TestWebKitAPI::TEST):
2030         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2031         (TestWebKitAPI::setViewClient):
2032
2033 2013-12-03  Dan Bernstein  <mitz@apple.com>
2034
2035         Fixed a test timing out after r160040.
2036
2037         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2038         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2039         Updated for the delegate method rename.
2040
2041 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2042
2043         REGRESSION: repro scripts disappear when you rerun tests
2044         https://bugs.webkit.org/show_bug.cgi?id=125184
2045
2046         Reviewed by Mark Hahnenberg.
2047         
2048         This bug made it difficult to quickly see if a test that recently failed is still
2049         failing while also running a new batch of tests.
2050
2051         Repro scripts are supposed to stay around until you delete them explicitly. This
2052         patch accomplishes that.
2053
2054         * Scripts/run-jsc-stress-tests:
2055
2056 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2057
2058         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2059         https://bugs.webkit.org/show_bug.cgi?id=125111
2060
2061         Reviewed by Filip Pizlo.
2062
2063         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2064
2065         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2066         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2067
2068 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2069
2070         Add a script to automatically configure a git clone
2071         https://bugs.webkit.org/show_bug.cgi?id=110073
2072
2073         Revert the change to use https for now since git.webkit.org is setup with http.
2074
2075         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2076         (SetupGitClone.execute):
2077
2078 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2079
2080         Add a script to automatically configure a git clone
2081         https://bugs.webkit.org/show_bug.cgi?id=110073
2082
2083         Reviewed by Benjamin Poulain.
2084
2085         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2086
2087         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2088
2089         * Scripts/webkitpy/tool/commands/__init__.py:
2090         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2091         (SetupGitClone):
2092         (SetupGitClone.execute):
2093
2094 2013-12-03  Anders Carlsson  <andersca@apple.com>
2095
2096         Deprecate WKNotificationProvider
2097         https://bugs.webkit.org/show_bug.cgi?id=125178
2098
2099         Reviewed by Sam Weinig.
2100
2101         Update for WebKit2 changes.
2102
2103         * WebKitTestRunner/TestController.cpp:
2104         (WTR::TestController::initialize):
2105         * WebKitTestRunner/WebNotificationProvider.cpp:
2106         (WTR::WebNotificationProvider::provider):
2107         * WebKitTestRunner/WebNotificationProvider.h:
2108
2109 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2110
2111         [Win] Support 64-bit Application Support Libraries Location 
2112         https://bugs.webkit.org/show_bug.cgi?id=125179
2113
2114         Reviewed by Tim Horton.
2115
2116         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2117         on Windows until an official distribution is available that properly creates registry settings
2118         to specify these locations.
2119
2120         * Scripts/webkitdirs.pm:
2121         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2122         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2123         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2124         running 64-bit builds.
2125
2126 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2127
2128         run-jsc-stress-tests only supports host environments that have make installed
2129         https://bugs.webkit.org/show_bug.cgi?id=124550
2130
2131         Reviewed by Darin Adler.
2132
2133         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2134         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2135         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2136         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2137         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2138         of the make-based runner.
2139
2140         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2141         the bundle and controls all of the parallel aspects of the shell-based test runner.
2142         * Scripts/run-jsc-stress-tests:
2143
2144 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2145
2146         Remove function from TextChecker
2147         https://bugs.webkit.org/show_bug.cgi?id=125148
2148
2149         Reviewed by Darin Adler.
2150
2151         The process_file_data is used only from the unit tests, so it is simply moved there.
2152
2153         * Scripts/webkitpy/style/checkers/text.py:
2154         (TextChecker.check):
2155         * Scripts/webkitpy/style/checkers/text_unittest.py:
2156         (TextStyleTestCase.process_file_data):
2157         (TextStyleTestCase.assertNoError):
2158         (TextStyleTestCase.assertError):
2159
2160 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2161
2162         Remove get_test() and reference test names directly instead.
2163         https://bugs.webkit.org/show_bug.cgi?id=124962
2164
2165         Reviewed by Csaba Osztrogonác.
2166
2167         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2168         (Base.__init__):
2169         (Base.get_basic_tests):
2170         (assert_exp):
2171         (MiscTests.test_multiple_results):
2172         (MiscTests.test_category_expectations):
2173         (MiscTests.test_get_modifiers):
2174         (MiscTests.test_get_expectations_string):
2175         (MiscTests.test_get_test_set):
2176         (MiscTests.test_parse_warning):
2177         (MiscTests.test_pixel_tests_flag.match):
2178
2179 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2180
2181         Style Checker false pass.
2182         https://bugs.webkit.org/show_bug.cgi?id=112456
2183
2184         Reviewed by Csaba Osztrogonác.
2185
2186         * Scripts/webkitpy/style/checkers/changelog.py:
2187         (ChangeLogChecker.check_entry):
2188         simple regex fix to check "No new tests (...)."
2189         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2190         (ChangeLogCheckerTest.test_no_new_tests):
2191
2192 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2193
2194         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2195         https://bugs.webkit.org/show_bug.cgi?id=125130
2196
2197         Reviewed by Geoffrey Garen.
2198
2199         * Scripts/run-jsc-stress-tests:
2200
2201 2013-12-02  Samuel White  <samuel_white@apple.com>
2202
2203         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2204         https://bugs.webkit.org/show_bug.cgi?id=124561
2205
2206         Reviewed by Chris Fleizach.
2207
2208         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2209
2210         * DumpRenderTree/AccessibilityUIElement.cpp:
2211         (uiElementCountForSearchPredicateCallback):
2212         (uiElementForSearchPredicateCallback):
2213         (AccessibilityUIElement::getJSClass):
2214         * DumpRenderTree/AccessibilityUIElement.h:
2215         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2216         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2217         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2218         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2219         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2220         (searchPredicateParameterizedAttributeForSearchCriteria):
2221         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2222         (AccessibilityUIElement::uiElementForSearchPredicate):
2223         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2224         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2226         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2227         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2228         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2230         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2231         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2232         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2233         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2234         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2235
2236 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2237
2238         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2239         https://bugs.webkit.org/show_bug.cgi?id=124714
2240
2241         Reviewed by Ryosuke Niwa.
2242
2243         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2244         (write_test_result):
2245         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2246         (TestFailure.write_failure):
2247         (FailureText):
2248         (FailureText.write_failure):
2249         (FailureAudio):
2250         (FailureAudio.write_failure):
2251         (FailureCrash.write_failure):
2252         (FailureMissingResult):
2253         (FailureTextMismatch):
2254         (FailureMissingImageHash.write_failure):
2255         (FailureMissingImage.write_failure):
2256         (FailureImageHashMismatch.write_failure):
2257         (FailureReftestMismatch.write_failure):
2258         (FailureReftestMismatchDidNotOccur.write_failure):
2259         (FailureMissingAudio):
2260         (FailureAudioMismatch):
2261
2262 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2263
2264         Remove the stderr_write attribute from StyleProcessorConfiguration
2265         https://bugs.webkit.org/show_bug.cgi?id=124703
2266
2267         Reviewed by Ryosuke Niwa.
2268
2269         Remove the stderr_write attribute from this class in checker and
2270         replace its use with calls to a logging module logger. We Should 
2271         use logging module instead of writing to stderr directly.
2272
2273         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2274         (check_webkit_style_configuration):
2275         (CheckerDispatcher.dispatch): Remove FIXME comment.
2276         (StyleProcessorConfiguration):
2277         (StyleProcessorConfiguration.__init__):
2278         (StyleProcessorConfiguration.write_style_error):
2279         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2280         There is an "ERROR" prefix in log messiges from now.
2281         (StyleProcessorConfigurationTest):
2282         (StyleProcessorConfigurationTest._style_checker_configuration):
2283         (StyleProcessorConfigurationTest.test_init):
2284         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2285         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2286         (StyleProcessor_EndToEndTest.with):
2287         (StyleProcessor_EndToEndTest.test_init):
2288         (StyleProcessor_EndToEndTest.test_process):
2289         (StyleProcessor_CodeCoverageTest.setUp):
2290         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2291         (DefaultStyleErrorHandler.__call__):
2292         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2293         There is an "ERROR" prefix in log messiges from now.
2294         (DefaultStyleErrorHandlerTest):
2295         (DefaultStyleErrorHandlerTest.setUp):
2296         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2297         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2298         (DefaultStyleErrorHandlerTest._check_initialized):
2299         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2300         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2301         (DefaultStyleErrorHandlerTest.test_line_numbers):
2302
2303 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2304
2305         Add JavaScript style checker and teach checker.py about .js files
2306         https://bugs.webkit.org/show_bug.cgi?id=125049
2307
2308         Reviewed by Joseph Pecoraro.
2309
2310         Add a JavaScript file type, extension, and checker (JSChecker).
2311         Use TextChecker for JavaScript tests, libraries, website resources,
2312         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2313
2314         Amended tests for TextChecker to reflect the rule above.
2315
2316         * Scripts/webkitpy/style/checker.py:
2317         (_all_categories): Add categories defined by JSChecker.
2318         (FileType): Add file type for JS and re-number the enum.
2319         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2320         (CheckerDispatcher._create_checker):
2321         Create a JSChecker or TextChecker depending on the file's path.
2322
2323         * Scripts/webkitpy/style/checker_unittest.py:
2324         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2325         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2326         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2327         that end in .js but should be checked with TextChecker.
2328         * Scripts/webkitpy/style/checkers/js.py: Added.
2329         (JSChecker):
2330         (JSChecker.__init__):
2331         (JSChecker.check):
2332         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2333         (JSTestCase):
2334         (JSTestCase.assertNoError):
2335         (JSTestCase.assertNoError.error_for_test):
2336         (JSTestCase.assertError):
2337         (JSTestCase.assertError.error_for_test):
2338         (JSTestCase.test_no_error):
2339         (JSTestCase.test_error):
2340
2341 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2342
2343         run-jsc-stress-tests always copies the VM
2344         https://bugs.webkit.org/show_bug.cgi?id=125092
2345
2346         Reviewed by Filip Pizlo.
2347
2348         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2349         bundle by default and do a full copy only when asked.
2350
2351         * Scripts/run-jsc-stress-tests:
2352
2353 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2354
2355         [Win] Port run-jsc-stress-tests
2356         https://bugs.webkit.org/show_bug.cgi?id=124801
2357
2358         Reviewed by Filip Pizlo.
2359
2360         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2361         command on Windows so that stress tests can run.
2362
2363 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2364
2365         Build fix after r159955
2366
2367         * Scripts/run-jsc-stress-tests:
2368
2369 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2370
2371         run-jsc-stress-tests should be able to package its tests and move them places
2372         https://bugs.webkit.org/show_bug.cgi?id=124549
2373
2374         Reviewed by Filip Pizlo.
2375
2376         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2377         of grep -i -q
2378         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2379         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2380         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2381         All of the generated scripts now are completely relative within the results directory. This allows
2382         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2383         tarball of the generated results directory. Also refactored several portions of the script into
2384         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2385
2386 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2387
2388         [ATK] Support active state for listbox elements.
2389         https://bugs.webkit.org/show_bug.cgi?id=125009
2390
2391         Reviewed by Chris Fleizach.
2392
2393         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2394
2395         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2396         (AccessibilityUIElement::isSelectedOptionActive):
2397         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2398         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2399         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2400         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2402         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2403         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2404         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2405
2406 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2407
2408         Unreviewed GTK gardening.
2409
2410         * Scripts/run-gtk-tests:
2411         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2412
2413 2013-12-01  Dan Bernstein  <mitz@apple.com>
2414
2415         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2416         https://bugs.webkit.org/show_bug.cgi?id=125046
2417
2418         Reviewed by Sam Weinig.
2419
2420         * MiniBrowser/mac/AppDelegate.m:
2421         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2422         (-[BrowserAppDelegate openDocument:]): Ditto.
2423         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2424         interface to the implementation.
2425         * MiniBrowser/mac/WK2BrowserWindowController.m:
2426         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2427         the policy client.
2428         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2429         Moved policy client implementation into this delegate method.
2430         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2431         Ditto.
2432         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2433         Ditto.
2434
2435 2013-12-01  Dan Bernstein  <mitz@apple.com>
2436
2437         [Mac] Remove the MiniBrowser injected bundle
2438         https://bugs.webkit.org/show_bug.cgi?id=125041
2439
2440         Reviewed by Anders Carlsson.
2441
2442         It had no ops!
2443
2444         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2445         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2446         * MiniBrowser/mac/AppDelegate.m:
2447         (-[BrowserAppDelegate init]):
2448         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2449         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2450
2451 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2452
2453         check-webkit-style should check for extraneous newline between config.h and primary header.
2454         https://bugs.webkit.org/show_bug.cgi?id=124821
2455
2456         Reviewed by Csaba Osztrogonác.
2457
2458         * Scripts/webkitpy/style/checkers/cpp.py:
2459         (check_include_line):
2460         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2461         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2462         (OrderOfIncludesTest):
2463         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2464
2465 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2466
2467         test-webkit-scripts should show the failing tests and use an appropriate exit code
2468         https://bugs.webkit.org/show_bug.cgi?id=124840
2469
2470         Reviewed by Ryosuke Niwa.
2471
2472         A fixme in test-webkit-scripts asked that the script should display success or failiure
2473         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2474
2475         * Scripts/test-webkit-scripts:
2476         (ScriptsTester.run_test_script):
2477         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2478         because at this point we don't need to pass on more information other than success or failiure.
2479         (ScriptsTester.main):
2480         The return values are now stored for each script and when all tests have completed successfully,
2481         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2482
2483 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2484
2485         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2486         https://bugs.webkit.org/show_bug.cgi?id=124923
2487
2488         Reviewed by Mario Sanchez Prada.
2489
2490         Added missing implementation of isAttributeSettable. Using
2491         ATK_STATE_EDITABLE for checking whether attribute is settable.
2492
2493         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2494         (AccessibilityUIElement::isAttributeSettable):
2495         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2496         (WTR::AccessibilityUIElement::isAttributeSettable):
2497
2498 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2499
2500         Unreviewed, rolling out r159839.
2501         http://trac.webkit.org/changeset/159839
2502         https://bugs.webkit.org/show_bug.cgi?id=124974
2503
2504         run-webkit-tests doesn't generate pretty diff (Requested by
2505         Ossy on #webkit).
2506
2507         * Scripts/webkitpy/common/prettypatch.py:
2508         (PrettyPatch.__init__):
2509         (PrettyPatch.pretty_diff):
2510         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2511         (TestResultWriter.create_text_diff_and_write_result):
2512         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2513         (summarize_results):
2514         * Scripts/webkitpy/port/base.py:
2515         (Port.__init__):
2516         (Port.pretty_patch_available):
2517         (Port.check_pretty_patch):
2518         (Port.variable):
2519         (Port.variable.pretty_patch_text):
2520         * Scripts/webkitpy/port/base_unittest.py:
2521         (PortTest.test_pretty_patch_os_error):
2522         (PortTest.test_pretty_patch_script_error):
2523
2524 2013-11-28  Antti Koivisto  <antti@apple.com>
2525
2526         Remove feature: CSS variables
2527         https://bugs.webkit.org/show_bug.cgi?id=114119
2528
2529         Reviewed by Andreas Kling.
2530
2531         * Scripts/webkitperl/FeatureList.pm:
2532
2533 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2534
2535         Move PrettyPatch related code to prettypatch.py
2536         https://bugs.webkit.org/show_bug.cgi?id=124937
2537
2538         Reviewed by Ryosuke Niwa.
2539
2540         This code seems to have a better place here than in Port, since PrettyPatch already knows
2541         pretty_patch_path, and this also unifies the usage of PrettyPatch
2542
2543         * Scripts/webkitpy/common/prettypatch.py:
2544         (PrettyPatch.__init__):
2545         (PrettyPatch.pretty_diff):
2546         (PrettyPatch):
2547         (PrettyPatch.pretty_patch_available):
2548         (PrettyPatch.check_pretty_patch):
2549         (PrettyPatch.pretty_patch_text):
2550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2551         (TestResultWriter.create_text_diff_and_write_result):
2552         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2553         (summarize_results):
2554         * Scripts/webkitpy/port/base.py:
2555         (Port.__init__):
2556         (Port.wdiff_available):
2557         (Port.check_image_diff):
2558         (Port.wdiff_text):
2559         * Scripts/webkitpy/port/base_unittest.py:
2560         (PortTest.test_pretty_patch_os_error):
2561         (PortTest.test_pretty_patch_script_error):
2562
2563 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2564
2565         Checkout should own the scm object in Host
2566         https://bugs.webkit.org/show_bug.cgi?id=124943
2567
2568         Reviewed by Ryosuke Niwa.
2569
2570         * Scripts/webkitpy/common/host.py:
2571         (Host.__init__):
2572         (Host.initialize_scm):
2573         (Host.scm):
2574
2575 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2576
2577         Do bytecode validation as part of testing
2578         https://bugs.webkit.org/show_bug.cgi?id=124913
2579
2580         Reviewed by Oliver Hunt.
2581
2582         * Scripts/run-jsc-stress-tests:
2583
2584 2013-11-27  Andres Gomez  <agomez@igalia.com>
2585
2586         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2587         https://bugs.webkit.org/show_bug.cgi?id=124940
2588
2589         Reviewed by Martin Robinson.
2590
2591         xserver-font-utils is needed for building gtk port dependencies
2592         with jhbuild.
2593
2594         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2595         dependecies.
2596
2597 2013-11-27  Andres Gomez  <agomez@igalia.com>
2598
2599         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2600         https://bugs.webkit.org/show_bug.cgi?id=124938
2601
2602         Reviewed by Philippe Normand.
2603
2604         Added needed git dependency for building the gtk port with
2605         jhbuild. Also, the dependencies needed for building the gtk port
2606         are now sorted alphabetically.
2607
2608         * gtk/install-dependencies: Added git as jhbuild dependency and
2609         sorted dependencies alphabetically.
2610
2611 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2612
2613         run_webkit_tests.py: error: no such option: --wincairo
2614         https://bugs.webkit.org/show_bug.cgi?id=124927
2615
2616         Reviewed by Ryosuke Niwa.
2617
2618         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2619         the layout testing on wincairo, so it is turned off.
2620
2621 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2622
2623         Nix upstreaming - Adding build files and supporting scripts
2624         https://bugs.webkit.org/show_bug.cgi?id=118367
2625
2626         Reviewed by Ryosuke Niwa.
2627
2628         * Scripts/build-webkit:
2629         * Scripts/run-nix-tests: Added.
2630         * Scripts/run-webkit-tests:
2631         * Scripts/update-webkit-libs-jhbuild:
2632         * Scripts/update-webkitnix-libs: Added.
2633         * Scripts/webkitdirs.pm:
2634         (determineArchitecture):
2635         (argumentsForConfiguration):
2636         (jscProductDir):
2637         (builtDylibPathForName):
2638         (determineIsNix):
2639         (isNix):
2640         (isAppleWebKit):
2641         (launcherPath):
2642         (launcherName):
2643         (checkRequiredSystemConfig):
2644         (copyInspectorFrontendFiles):
2645         (jhbuildWrapperPrefixIfNeeded):
2646         (buildCMakeProjectOrExit):
2647         (cmakeBasedPortName):
2648         * Scripts/webkitpy/common/config/ports.py:
2649         (DeprecatedPort.port):
2650         (EflWK2Port.build_webkit_command):
2651         (NixPort):
2652         (NixPort.build_webkit_command):
2653         * Scripts/webkitpy/port/factory.py:
2654         (platform_options):
2655         (PortFactory):
2656         * Scripts/webkitpy/port/nix.py: Added.
2657         (NixPort):
2658         (NixPort._wk2_port_name):
2659         (NixPort.determine_full_port_name):
2660         (NixPort.__init__):
2661         (NixPort._port_flag_for_scripts):
2662         (NixPort.setup_test_run):
2663         (NixPort.setup_environ_for_server):
2664         (NixPort.default_timeout_ms):
2665         (NixPort.clean_up_test_run):
2666         (NixPort._generate_all_test_configurations):
2667         (NixPort._path_to_driver):
2668         (NixPort._path_to_image_diff):
2669         (NixPort._image_diff_command):
2670         (NixPort._search_paths):
2671         (NixPort.show_results_html_file):
2672         (NixPort._port_specific_expectations_files):
2673         (NixPort.default_baseline_search_path):
2674         * Scripts/webkitpy/port/nix_unittest.py: Added.
2675         (NixPortTest):
2676         (NixPortTest._assert_search_path):
2677         (NixPortTest._assert_expectations_files):
2678         (NixPortTest.test_baseline_search_path):
2679         (NixPortTest.test_expectations_files):
2680         (NixPortTest.test_default_timeout_ms):
2681         * jhbuild/jhbuild-wrapper:
2682         (determine_platform):
2683         * nix/common.py: Added.
2684         (script_path):
2685         (top_level_path):
2686         * nix/jhbuild.modules: Added.
2687         * nix/jhbuildrc: Added.
2688
2689 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2690
2691         Record subtest values in Dromaeo tests
2692         https://bugs.webkit.org/show_bug.cgi?id=124498
2693
2694         Reviewed by Andreas Kling.
2695
2696         Supported parsing subtest results.
2697
2698         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2699         which contains a dictionary with its name and an ordered list of subtest's metrics.
2700         (PerfTest.__init__): Initialize _metrics as a list.
2701         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2702         (PerfTest._run_with_driver):
2703         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2704
2705         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2706         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2707         (TestPerfTest.test_parse_output): Ditto.
2708         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2709         assertions to ensure subtest results are parsed properly.
2710         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2711         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2712
2713         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2714         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2715         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2716         adding new results.
2717
2718         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2719         (TestWithSubtestsData): Added.
2720         (TestDriver.run_test):
2721         (MainTest.test_run_test_with_subtests): Added.
2722
2723 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2724
2725         Enable HTML template element on Windows ports
2726         https://bugs.webkit.org/show_bug.cgi?id=124758
2727
2728         Reviewed by Andreas Kling.
2729
2730         * Scripts/webkitperl/FeatureList.pm:
2731
2732 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2733
2734         Remove replay performance tests as it's not actively maintained
2735         https://bugs.webkit.org/show_bug.cgi?id=124764
2736
2737         Reviewed by Andreas Kling.
2738
2739         Removed the feature.
2740
2741         * Scripts/webkitpy/performance_tests/perftest.py:
2742         (SingleProcessPerfTest.__init__):
2743         (PerfTestFactory):
2744         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2745         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2746         (PerfTestsRunner._parse_args):
2747         (PerfTestsRunner._collect_tests):
2748         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2749         (MainTest.test_collect_tests_with_ignored_skipped_list):
2750         (MainTest.test_default_args):
2751         * Scripts/webkitpy/thirdparty/__init__.py:
2752         (AutoinstallImportHook.find_module):
2753         (AutoinstallImportHook._install_unittest2):
2754         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2755         (ThirdpartyTest.test_imports):
2756
2757 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2758
2759         Enable aggressive DFG validation in testing
2760         https://bugs.webkit.org/show_bug.cgi?id=124911
2761
2762         Rubber stamped by Ryosuke Niwa.
2763         
2764         This enables validation testing in non-concurrent-JIT runs.
2765
2766         * Scripts/run-jsc-stress-tests:
2767
2768 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2769
2770         Moved methods which belong to Checkout into checkout.py
2771         https://bugs.webkit.org/show_bug.cgi?id=124889
2772
2773         Reviewed by Ryosuke Niwa.
2774
2775         * Scripts/webkitpy/common/checkout/checkout.py:
2776         (Checkout.scripts_directory):
2777         (Checkout):
2778         (Checkout.script_path):
2779         (Checkout.commit_message_for_this_commit):
2780         (Checkout.apply_patch):
2781         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2782         (test_commit_message_for_this_commit):
2783         (CheckoutTest.test_apply_patch):
2784         * Scripts/webkitpy/common/checkout/scm/scm.py:
2785         (SCM.absolute_path):
2786         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2787         (SCMTest._setup_webkittools_scripts_symlink):
2788         * Scripts/webkitpy/common/checkout/scm/svn.py:
2789         (SVN.create_patch):
2790
2791 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
2792
2793         [EFL] Use Config mode of find_package for EFL 1.8
2794         https://bugs.webkit.org/show_bug.cgi?id=124555
2795
2796         Reviewed by Gyuyoung Kim.
2797
2798         * MiniBrowser/efl/CMakeLists.txt:
2799         Added optional config mode and made version requirement optional.
2800
2801 2013-11-25  Andres Gomez  <agomez@igalia.com>
2802
2803         [GTK] Search functionality in MiniBrowser provides feedback on search fail
2804         https://bugs.webkit.org/show_bug.cgi?id=122681
2805
2806         Reviewed by Mario Sanchez Prada.
2807
2808         When using the search functionality in MiniBrowser, if the search
2809         fails, the entry background color gets red to report the user
2810         about the failing condition. When the entry is cleaned or the
2811         search is again succesful the background turns back to its
2812         original color.
2813
2814         * MiniBrowser/gtk/BrowserSearchBar.c:
2815         (setFailedStyleForEntry): Added.
2816         (doSearch): Sets the entry's background to its original style if
2817         there is no text to search.
2818         (findControllerFailedToFindTextCallback): Added.
2819         (findControllerFoundTextCallback): Added.
2820         (browser_search_bar_init): Creates and adds a new CSS provider to
2821         the text entry so we can change its style based on the success
2822         condition of the search.
2823         (browserSearchBarFinalize): Frees the new CSS provider.
2824         (browser_search_bar_new): Connects the two new handlers to the
2825         "failed-to-find-text" and "found-text" signals emitted by the
2826         WebKitFindController.
2827
2828 2013-11-25  Dan Bernstein  <mitz@apple.com>
2829
2830         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
2831         https://bugs.webkit.org/show_bug.cgi?id=124850
2832
2833         Reviewed by Brady Eidson.
2834
2835         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
2836
2837         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2838         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2839         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2840         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2841         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2842         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2843         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2844
2845 2013-11-25  Commit Queue  <commit-queue@webkit.org>
2846
2847         Unreviewed, rolling out r159752 and r159754.
2848         http://trac.webkit.org/changeset/159752
2849         http://trac.webkit.org/changeset/159754
2850         https://bugs.webkit.org/show_bug.cgi?id=124847
2851
2852         Broke linux test bots. (Requested by mhahnenberg on #webkit).
2853
2854         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2855         * Scripts/run-javascriptcore-tests:
2856         * Scripts/run-jsc-stress-tests:
2857
2858 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2859
2860         Followup fix after r159752
2861
2862         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
2863
2864 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2865
2866         run-jsc-stress-tests should be able to package its tests and move them places
2867         https://bugs.webkit.org/show_bug.cgi?id=124549
2868
2869         Reviewed by Filip Pizlo.
2870
2871         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
2872         of grep -i -q
2873         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2874         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
2875         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
2876         All of the generated scripts now are completely relative within the results directory. This allows 
2877         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
2878         tarball of the generated results directory. Also refactored several portions of the script into 
2879         separate functions to make it easier to run them conditionally depending on which mode we're running in.
2880
2881 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
2882
2883         EWS creates 0 byte sized log files
2884         https://bugs.webkit.org/show_bug.cgi?id=107606
2885
2886         Reviewed by Ryosuke Niwa.
2887
2888         There was a modification in r138264, that tried to make less log,
2889         because some of the messeges were duplicated. After this the EWS
2890         created the log file (with the same name as the bugID) but doesn't
2891         write anything into it, even if there were errors during the build.
2892         From now only creates the log file only if there is some error.
2893
2894         * Scripts/webkitpy/tool/bot/queueengine.py:
2895         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2896         there is nothing to log. Open the log file only if a ScriptError was raised to
2897         avoid to make empty log files for bugs.
2898         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2899         because of changes in r138264. Teeing is used for locally testing purposes and
2900         this feature is not used anymore.
2901         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
2902         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2903         change.
2904         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2905         (LoggingDelegate): The order of the callbacks was changed by this patch.
2906         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
2907         so we have to update this test.
2908         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
2909         this patch.
2910         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2911         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2912         to be able to handle it in QueueEngine.run. Without this change, the existing
2913         exception handler never run (the process_work_item method never raise ScriptError)
2914         We can get the error message only from the ScriptError at this point.
2915
2916 2013-11-22  Dean Jackson  <dino@apple.com>
2917
2918         Speculative Mountain Lion build fix.
2919
2920         * MiniBrowser/mac/AppDelegate.m:
2921         (-[BrowserAppDelegate openDocument:]):
2922
2923 2013-11-22  Anders Carlsson  <andersca@apple.com>
2924
2925         Fix Mountain Lion bug.
2926
2927         * MiniBrowser/mac/AppDelegate.m:
2928         (-[BrowserAppDelegate openDocument:]):
2929
2930 2013-11-22  Anders Carlsson  <andersca@apple.com>
2931
2932         MiniBrowser should use the blocks-based NSOpenPanel API
2933         https://bugs.webkit.org/show_bug.cgi?id=124786
2934
2935         Reviewed by Simon Fraser.
2936
2937         * MiniBrowser/mac/AppDelegate.m:
2938         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2939         Account for windows that don't have a BrowserWindowController.
2940
2941         (-[BrowserAppDelegate openDocument:]):
2942
2943 2013-11-22  Commit Queue  <commit-queue@webkit.org>
2944
2945         Unreviewed, rolling out r159690.
2946         http://trac.webkit.org/changeset/159690
2947         https://bugs.webkit.org/show_bug.cgi?id=124782
2948
2949         Broke webkitpy tests (Requested by ap on #webkit).
2950
2951         * Scripts/webkitpy/tool/bot/queueengine.py:
2952         (QueueEngine.run):
2953         (QueueEngine._open_work_log):
2954         (QueueEngine._ensure_work_log_closed):
2955         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2956         (AbstractEarlyWarningSystem.review_patch):
2957
2958 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2959
2960         EWS creates 0 byte sized log files
2961         https://bugs.webkit.org/show_bug.cgi?id=107606
2962
2963         Reviewed by Ryosuke Niwa.
2964
2965         There was a modification in r138264, that tried to make less log, 
2966         because some of the messeges were duplicated. After this the EWS 
2967         created the log file (with the same name as the bugID) but doesn't 
2968         write anything into it, even if there were errors during the build. 
2969         From now only creates the log file only if there is some error.
2970
2971         * Scripts/webkitpy/tool/bot/queueengine.py:
2972         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2973         there is nothing to log. Open the log file only if a ScriptError was raised to
2974         avoid to make empty log files for bugs.
2975         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2976         because of changes in r138264. Teeing is used for locally testing purposes and
2977         this feature is not used anymore.
2978         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2979         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2980         change.
2981         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2982         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2983         to be able to handle it in QueueEngine.run. Without this change, the existing
2984         exception handler never run (the process_work_item method never raise ScriptError)
2985         We can get the error message only from the ScriptError at this point.
2986
2987 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2988
2989         Remove ENABLE_WORKERS
2990         https://bugs.webkit.org/show_bug.cgi?id=105784
2991
2992         Reviewed by Darin Adler.
2993
2994         * Scripts/webkitperl/FeatureList.pm:
2995
2996 2013-11-21  Darin Adler  <darin@apple.com>
2997
2998         Try to fix buildbot Dashboard for people who have not hidden anything.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3001         Add a null check for hidden platforms.
3002
3003 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3004
3005         Remove chrome/chromium related things from webkitpy.
3006         https://bugs.webkit.org/show_bug.cgi?id=124493
3007
3008         Reviewed by Darin Adler.
3009
3010         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3011         (PortTest.assert_mock_port_works):
3012         * Scripts/webkitpy/port/base.py:
3013         (Port.to.setup_environ_for_server):
3014         * Scripts/webkitpy/port/mac_unittest.py:
3015         (test_tests_for_other_platforms):
3016         * Scripts/webkitpy/port/mock_drt.py:
3017         (MockTestShell.output_for_test):
3018         * Scripts/webkitpy/tool/bot/irc_command.py:
3019         (Restart.execute):
3020         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3021         (IRCBotTest.test_help):
3022
3023 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3024
3025         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3026         https://bugs.webkit.org/show_bug.cgi?id=124717
3027
3028         Reviewed by Ryosuke Niwa.
3029
3030         * Scripts/webkitpy/style/filereader.py:
3031         (TextFileReader.process_file):
3032         * Scripts/webkitpy/style/filereader_unittest.py:
3033         (TextFileReaderTest.test_process_file__does_not_exist):
3034
3035 2013-11-21  Mark Rowe  <mrowe@apple.com>
3036
3037         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3038
3039         All modern versions of Xcode set it appropriately for our needs.
3040
3041         Reviewed by Alexey Proskuryakov.
3042
3043         * MiniBrowser/Configurations/Base.xcconfig:
3044         * WebKitTestRunner/Configurations/Base.xcconfig:
3045
3046 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3047
3048         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3049         https://bugs.webkit.org/show_bug.cgi?id=124676
3050
3051         Reviewed by Daniel Bates.
3052
3053         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3054         elements when there were more then one occurrence of that argument.
3055         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3056         {b, a}, when it should be {b, c}.
3057
3058         * Scripts/webkitdirs.pm:
3059         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3060         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3061         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3062
3063 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         Update build-webkit after r159550.
3066
3067         * Scripts/webkitperl/FeatureList.pm:
3068
3069 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3070
3071         Bring a new bot online, replacing the previous ones.
3072         
3073         Unreviewed.
3074
3075         * BuildSlaveSupport/build.webkit.org-config/config.json:
3076
3077 2013-11-21  Dean Jackson  <dino@apple.com>
3078
3079         Don't fetch hidden platforms on build.webkit.org/dashboard
3080         https://bugs.webkit.org/show_bug.cgi?id=124750
3081
3082         Reviewed by Tim Horton.
3083
3084         If a platform is hidden, don't fetch its data. If it
3085         becomes unhidden, try to fetch immediately (unless
3086         you've recently fetched).
3087
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3090
3091 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3092
3093         Unreviewed, rolling out r159633.
3094         http://trac.webkit.org/changeset/159633
3095         https://bugs.webkit.org/show_bug.cgi?id=124726
3096
3097         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3098
3099         * Scripts/webkitpy/style/checker.py:
3100         (check_webkit_style_configuration):
3101         (CheckerDispatcher.dispatch):
3102         (StyleProcessorConfiguration):
3103         (StyleProcessorConfiguration.__init__):
3104         (StyleProcessorConfiguration.write_style_error):
3105
3106 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3107
3108         Remove the stderr_write attribute from StyleProcessorConfiguration.
3109         https://bugs.webkit.org/show_bug.cgi?id=124703
3110
3111         Reviewed by Brent Fulgham.
3112
3113         * Scripts/webkitpy/style/checker.py:
3114         (check_webkit_style_configuration):
3115         (CheckerDispatcher.dispatch):
3116         (StyleProcessorConfiguration):
3117         (StyleProcessorConfiguration.__init__):
3118         (StyleProcessorConfiguration.write_style_error):
3119
3120 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3121
3122         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3123         https://bugs.webkit.org/show_bug.cgi?id=124623
3124
3125         Removed the dependency on test objects from results JSON generation.
3126         This allows single test.run to return metrics for multiple tests
3127
3128         Reviewed by Antti Koivisto.
3129
3130         * Scripts/webkitpy/performance_tests/perftest.py:
3131         (PerfTestMetric.__init__): Takes the test path and test name.
3132         (PerfTestMetric.path): Added.
3133         (PerfTestMetric.test_file_name): Added.
3134         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3135         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3136         The path is going to have the names of subtests at the end once we support them.
3137
3138         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3139         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3140         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3141         (TestPerfTestMetric.test_has_values): Ditto.
3142         (TestPerfTestMetric.test_append): Ditto.
3143
3144         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3145         (_generate_results_dict): Only use metrics.
3146         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3147
3148 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3149
3150         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3151         https://bugs.webkit.org/show_bug.cgi?id=124697
3152
3153         Reviewed by Ryosuke Niwa.
3154
3155         * Scripts/webkitdirs.pm:
3156         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3157         before trying to access to the first element.
3158
3159 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3160
3161         [GTK] Mark all deprecated symbols in GObject DOM bindings
3162         https://bugs.webkit.org/show_bug.cgi?id=124406
3163
3164         Reviewed by Gustavo Noronha Silva.
3165
3166         * Scripts/webkitpy/style/checker.py: Add special case for
3167         WebKitDOMDeprecated.
3168         * gtk/generate-gtkdoc:
3169         (get_webkit2_options): Use the prefix of the methods as namespace,
3170         since this is what gtkdoc expects to sort the index.
3171         (get_webkit1_options): Ditto.
3172         (get_webkitdom_options): Ditto.
3173         * gtk/generate-webkitdom-doc-files:
3174         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3175         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3176         the documentation for classes that are deprecated because they
3177         have been removed.
3178         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3179         for deleted classes too.
3180         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3181         deprecated symbols using the given symbols file.
3182         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3183         deleted class corresponding to the given function.
3184         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3185         dictionary of deprecated symbols for every class.
3186         (WebKitDOMDocGeneratorSections.write_section): Add also the
3187         deprecated symbols in every section.
3188         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3189         sections for deleted classes too.
3190
3191 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3192
3193         check-webkit-style should support C++11 rvalue references.
3194         https://bugs.webkit.org/show_bug.cgi?id=123406
3195
3196         Reviewed by Brent Fulgham.
3197
3198         * Scripts/webkitpy/style/checkers/cpp.py:
3199         (check_style):
3200         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3201         (Cpp11StyleTest):
3202         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3203
3204 2013-11-20  Dean Jackson  <dino@apple.com>
3205
3206         Allow settings to be shown/hidden on build.webkit.org/dashboard
3207         https://bugs.webkit.org/show_bug.cgi?id=124694
3208
3209         Reviewed by Tim Horton.
3210
3211         In preparation for more options/buttons, allow the page to
3212         show or hide all the interactive things using a little gear icon
3213         in the top left corner.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3217         (Settings.prototype.toggleSettingsDisplay):
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3219         (div.cellButton.hide):
3220         (div.cellButton.unhide):
3221         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3222         (.settings):
3223         (.settings:hover):
3224         (.settings-visible .settings):
3225
3226 2013-11-20  Dean Jackson  <dino@apple.com>
3227
3228         No need to base64 SVG on build.webkit.org/dashboard
3229         https://bugs.webkit.org/show_bug.cgi?id=124687
3230
3231         Reviewed by Tim Horton.
3232
3233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3234         (.status-line.good .bubble.pictogram):
3235
3236 2013-11-20  Dean Jackson  <dino@apple.com>
3237
3238         Make links look more like links on build.webkit.org/dashboard
3239         https://bugs.webkit.org/show_bug.cgi?id=124686
3240
3241         Reviewed by Tim Horton.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3244         (.queue-view .queueLabel:hover):
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3246         (.status-line.linked .label:hover):
3247
3248 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3249
3250         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3251         https://bugs.webkit.org/show_bug.cgi?id=124581
3252
3253         Reviewed by Daniel Bates.
3254
3255         Some subroutines are replicating code from checkForArgument**
3256         functions instead of reusing them as is being done by all other functions.
3257
3258         * Scripts/webkitdirs.pm:
3259         (determineXcodeSDK): Added.
3260         (determinePassedConfiguration): Added.
3261         (determinePassedArchitecture): Added.
3262         (checkForArgumentAndRemoveFromARGV): Added.
3263         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
3264
3265 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
3266
3267         Delete baseline optimizer
3268         https://bugs.webkit.org/show_bug.cgi?id=122333
3269
3270         Reviewed by Ryosuke Niwa.
3271
3272         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
3273         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
3274         * Scripts/webkitpy/tool/commands/rebaseline.py:
3275         (RebaselineTest.execute):
3276         (AbstractParallelRebaselineCommand._files_to_add):
3277         (AbstractParallelRebaselineCommand._rebaseline):
3278         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3279         (TestRebaselineJson.test_rebaseline_all):
3280         (TestRebaselineJson.test_rebaseline_debug):
3281         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3282
3283 2013-11-20  Anders Carlsson  <andersca@apple.com>
3284
3285         Enable PageLoadTest assertions again
3286         https://bugs.webkit.org/show_bug.cgi?id=124681
3287
3288         Reviewed by Tim Horton.
3289
3290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3291         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
3292
3293 2013-11-20  Mark Rowe  <mrowe@apple.com>
3294
3295         Remove some obsolete logic from WebKit.app.
3296
3297         Reviewed by Alexey Proskuryakov.
3298
3299         * WebKitLauncher/WebKitNightlyEnabler.m:
3300         (poseAsWebKitApp): Remove a pre-10.6 codepath.
3301         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
3302
3303 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3304
3305         Moved stray urls from svn.py and statusserver.py into common.config.urls
3306         https://bugs.webkit.org/show_bug.cgi?id=124650
3307
3308         Reviewed by Ryosuke Niwa.
3309
3310         * Scripts/webkitpy/common/checkout/scm/svn.py:
3311         (SVNRepository):
3312         * Scripts/webkitpy/common/config/urls.py:
3313         * Scripts/webkitpy/common/net/statusserver.py:
3314         (StatusServer.__init__):
3315         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3316         (_generate_results_dict):
3317
3318 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3319
3320         Unreviewed, rolling out r159496.
3321         http://trac.webkit.org/changeset/159496
3322         https://bugs.webkit.org/show_bug.cgi?id=124641
3323
3324         It caused warning and build break with cmake lower than 2.8.8
3325         (Requested by ryuan on #webkit).
3326
3327         * MiniBrowser/efl/CMakeLists.txt:
3328
3329 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3330
3331         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3332         https://bugs.webkit.org/show_bug.cgi?id=124412
3333
3334         Reviewed by Gyuyoung Kim.
3335
3336         Update libseccomp to a newer 2.1.0 version.
3337
3338         * efl/jhbuild.modules:
3339
3340 2013-11-19  Mark Rowe  <mrowe@apple.com>
3341
3342         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3343
3344         Gestalt is deprecated on recent OS X versions so we should switch off it.
3345
3346         Reviewed by Sam Weinig.
3347
3348         * WebKitLauncher/main.m:
3349         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3350         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3351         two components, then join them back up.
3352         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3353         the version we care about.
3354
3355 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3356
3357         Unreviewed, rolling out r159538.
3358         http://trac.webkit.org/changeset/159538
3359         https://bugs.webkit.org/show_bug.cgi?id=124627
3360
3361         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3362         #webkit).
3363
3364         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3365         * Scripts/run-javascriptcore-tests:
3366         * Scripts/run-jsc-stress-tests:
3367
3368 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3369
3370         run-jsc-stress-tests should be able to package its tests and move them places
3371         https://bugs.webkit.org/show_bug.cgi?id=124549
3372
3373         Reviewed by Geoff Garen and Filip Pizlo.
3374
3375         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3376         of grep -i -q 
3377         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3378         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3379         other files that those tests require to run in any environment along with a fixed root directory into which these
3380         files and their expected directory structure are cloned. The default Bundle class is basically 
3381         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3382         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3383         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3384         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3385         to use MovableBundle instead of just Bundle. 
3386
3387 2013-11-19  Dan Bernstein  <mitz@apple.com>
3388
3389         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3390
3391         Rubber-stamped by Mark Rowe.
3392
3393         Reverted r156840.
3394
3395         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3396
3397 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3398
3399         Yet another build fix. Just allow any character.
3400         There are just too many special characters to be listed here.
3401
3402         * Scripts/webkitpy/performance_tests/perftest.py:
3403         (PerfTest._lines_to_ignore_in_parser_result):
3404         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3405         (TestPerfTest.test_parse_output_with_subtests)
3406
3407 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3408
3409         Another build fix. Allow ':' in subtest names.
3410
3411         * Scripts/webkitpy/performance_tests/perftest.py:
3412         (PerfTest._lines_to_ignore_in_parser_result):
3413         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3414         (TestPerfTest.test_parse_output_with_subtests)
3415
3416 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
3417
3418         [EFL] Use Config mode of find_package for EFL 1.8
3419         https://bugs.webkit.org/show_bug.cgi?id=124555
3420
3421         Reviewed by Gyuyoung Kim.
3422
3423         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
3424
3425 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3426
3427         Build fix. Subtest names need to be more permissive.
3428
3429         * Scripts/webkitpy/performance_tests/perftest.py:
3430         (PerfTest._lines_to_ignore_in_parser_result):
3431         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3432         (TestPerfTest.test_parse_output_with_subtests)
3433
3434 2013-11-18  Mark Rowe  <mrowe@apple.com>
3435
3436         Use hw.activecpu for determining how many processes to spawn.
3437
3438         It's documented as the preferred way to determine the number of threads
3439         or processes to create in a SMP aware application.
3440
3441         Rubber-stamped by Tim Horton.
3442
3443         * Scripts/copy-webkitlibraries-to-product-directory:
3444         * Scripts/run-jsc-stress-tests:
3445         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3446
3447 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3448
3449         build.webkit.org/dashboard builder headers should link to the builder page
3450         https://bugs.webkit.org/show_bug.cgi?id=124553
3451
3452         Reviewed by Timothy Hatcher.
3453
3454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3455         (BuildbotQueue.prototype.get overviewURL):
3456         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
3457
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3459         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
3460         (BuildbotBuilderQueueView.prototype.update):
3461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3462         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3463         (BuildbotTesterQueueView.prototype.update.appendBuild):
3464         (BuildbotTesterQueueView.prototype.update):
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3466         (.queue-view .queueLabel):
3467         (.queue-view .queueLabel:not(:first-child)):
3468         Make the header a link instead of a label, and wire it up to overviewURL.
3469
3470 2013-11-18  Samuel White  <samuel_white@apple.com>
3471
3472         AX: Add ability to fetch only visible table rows.
3473         https://bugs.webkit.org/show_bug.cgi?id=124430
3474
3475         Reviewed by Chris Fleizach.
3476
3477         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
3478         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
3479         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
3480         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
3481         as the test guidelines state, our tests should be more focused and specific about what they test.
3482
3483         * DumpRenderTree/AccessibilityUIElement.cpp:
3484         (uiElementArrayAttributeValueCallback):
3485         (AccessibilityUIElement::uiElementArrayAttributeValue):
3486         (AccessibilityUIElement::getJSClass):
3487         * DumpRenderTree/AccessibilityUIElement.h:
3488         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3489         (AccessibilityUIElement::uiElementArrayAttributeValue):
3490         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3491         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3492         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3493         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3495         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3496         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3497         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
3498         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3499
3500 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3501
3502         Simplify and reformat the output of performance tests inside test runners
3503         https://bugs.webkit.org/show_bug.cgi?id=124496
3504
3505         Reviewed by Antti Koivisto.
3506
3507         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
3508         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
3509         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
3510         the first place.
3511
3512         Also modernize the output to adopt "metric" concept better and make it forward compatible
3513         with subtests.
3514
3515         With this patch, performance tests written using runner.js only produces empty lines or
3516         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
3517         <subtest name> -> [<value 1>, <value 2>, ...]
3518         :<metric name> -> [<value 1>, <value 2>, ...]
3519
3520         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
3521
3522         * Scripts/webkitpy/performance_tests/perftest.py:
3523         (PerfTest): Removed a bunch of regular expressions that are no longer used.
3524         (PerfTest._run_with_driver): Just parse the values and description and treat everything
3525         else as errors.
3526
3527         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3528         (TestPerfTest.test_parse_output): Removed the junk.
3529         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
3530         which was removed in favor of the tests below.
3531         (TestPerfTest.test_parse_output_with_running_five_times): Added.
3532         (TestPerfTest.test_parse_output_with_detailed_info): Added.
3533         (TestPerfTest.test_parse_output_with_statistics): Added.
3534         (TestPerfTest.test_parse_output_with_description): Removed the junk.
3535         (TestPerfTest.test_parse_output_with_subtests): Ditto.
3536         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
3537
3538         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3539         (EventTargetWrapperTestData): Ditto.
3540         (SomeParserTestData): Ditto.
3541         (MemoryTestData): Ditto.
3542
3543 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3544
3545         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3546         https://bugs.webkit.org/show_bug.cgi?id=124312
3547
3548         Reviewed by Simon Fraser.
3549
3550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3551         (Manager._set_up_run):
3552         * Scripts/webkitpy/port/base.py:
3553         (Port.to.reset_preferences):
3554         * Scripts/webkitpy/port/mac.py:
3555         (MacPort.reset_preferences):
3556         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
3557         returning some of the functionality of 158652 after 159364 removed it.
3558
3559 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3560
3561         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3562         https://bugs.webkit.org/show_bug.cgi?id=122909
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
3567
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3569         (.status-line .bubble):
3570         (.status-line.good .bubble.pictogram):
3571
3572 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3573
3574         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
3575         https://bugs.webkit.org/show_bug.cgi?id=124499
3576
3577         Reviewed by Csaba Osztrogonác.
3578
3579         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
3580
3581         * Scripts/webkitpy/performance_tests/perftest.py:
3582         (PerfTest._should_ignore_line):
3583         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3584         (TestPerfTest): Removed the unit test.
3585
3586 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
3587
3588         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
3589         quite as easily.
3590         
3591         With help from Andy Trick.
3592
3593         * Scripts/export-llvm-build:
3594
3595 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
3596
3597         FTL should have an explicit notion of bytecode liveness
3598         https://bugs.webkit.org/show_bug.cgi?id=124181
3599
3600         Reviewed by Mark Hahnenberg.
3601
3602         * Scripts/run-jsc-stress-tests:
3603
3604 2013-11-16  Dan Bernstein  <mitz@apple.com>
3605
3606         No way for policy client to determine if a the response’s MIME type can be shown
3607         https://bugs.webkit.org/show_bug.cgi?id=124445
3608
3609         Reviewed by Sam Weinig.
3610
3611         * MiniBrowser/mac/WK2BrowserWindowController.m:
3612         (decidePolicyForResponse): Added canShowMIMEType parameter.
3613         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3614
3615         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3616         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3617
3618         * WebKitTestRunner/TestController.cpp:
3619         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3620         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3621         * WebKitTestRunner/TestController.h:
3622
3623 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3624
3625         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3626         https://bugs.webkit.org/show_bug.cgi?id=122909
3627
3628         Reviewed by Timothy Hatcher.
3629
3630         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3632         (StatusLineView.prototype.set repeatCount):
3633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3634         (.status-line.good .bubble.pictogram):
3635         Use an SVG image instead of an obscure font for the checkboxes so they
3636         render identically on all platforms.
3637
3638 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3639
3640         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3641         https://bugs.webkit.org/show_bug.cgi?id=124312
3642
3643         Reviewed by Alexey Proskuryakov.
3644
3645         Try reverting the part of r158652 that deleted all of the persistent
3646         defaults, in the thought that there might be some sort of race between
3647         processes causing some settings to be left in the wrong state.