Remove code for Chromium from wkbuild.py
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove code for Chromium from wkbuild.py
4         https://bugs.webkit.org/show_bug.cgi?id=114423
5
6         Reviewed by Benjamin Poulain.
7
8         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
9         (_should_file_trigger_build):
10         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
11         (ShouldBuildTest):
12
13 2013-04-11  Philippe Normand  <pnormand@igalia.com>
14
15         Unreviewed, update my IRC nickname.
16
17         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
18
19 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
20
21         Remove the rest of Chromium code from webkitpy
22         https://bugs.webkit.org/show_bug.cgi?id=114420
23
24         Reviewed by Benjamin Poulain.
25
26         * Scripts/webkitpy/common/config/urls.py:
27         (view_revision_url):
28         * Scripts/webkitpy/common/host.py:
29         (Host._engage_awesome_locale_hacks):
30         (Host.initialize_scm):
31         (Host):
32         * Scripts/webkitpy/common/host_mock.py:
33         (MockHost.__init__):
34         (MockHost.checkout):
35         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
36         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
37         (JSONResultsGeneratorBase._insert_generic_metadata):
38         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
39         (TestExpectationParser._tokenize_line):
40         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
41         (ExpectationSyntaxTests.test_bare_name_and_bugs):
42         (ExpectationSyntaxTests.test_warnings):
43         * Scripts/webkitpy/layout_tests/port/base.py:
44         (Port.skips_perf_test):
45         (Port.path_to_test_expectations_file):
46         (Port._port_flag_for_scripts):
47         * Scripts/webkitpy/style/checkers/cpp.py:
48         (check_function_definition):
49         (check_include_line):
50         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
51         (OrderOfIncludesTest.test_check_wtf_includes):
52         (WebKitStyleTest.test_webkit_export_check):
53         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
54         (TestExpectationsTestCase.test_valid_expectations):
55         * Scripts/webkitpy/tool/bot/irc_command.py:
56         (Rollout.execute):
57         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
58         (IRCCommandTest.test_whois):
59         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
60         (IRCBotTest.test_help):
61         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
62         (SheriffBotTest.test_command_aliases):
63
64 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
65
66         roll-chromium-deps doesn't roll DEPS
67         https://bugs.webkit.org/show_bug.cgi?id=114421
68
69         Reviewed by Antti Koivisto.
70
71         Roll DEPS. Rolling DEPS. Rolled DEPS.
72
73         * Scripts/webkitpy/tool/bot/irc_command.py:
74         (RollChromiumDEPS.execute):
75
76 2013-04-11  Glenn Adams  <glenn@skynav.com>
77
78         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
79         https://bugs.webkit.org/show_bug.cgi?id=114418
80
81         Reviewed by Ryosuke Niwa.
82
83         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
84         (MockSCM.add): Remove optional remove_exit_code argument.
85         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
86         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
87         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
88         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
89
90 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
91
92         Fix roll-chromium-deps and hi.
93
94         * Scripts/webkitpy/tool/bot/irc_command.py:
95         (Hi.execute):
96         (RollChromiumDEPS.execute):
97
98 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
99
100         Remove webkitpy code to roll Chromium DEPS
101         https://bugs.webkit.org/show_bug.cgi?id=114415
102
103         Reviewed by Benjamin Poulain.
104
105         Removed the code to roll Chromium DEPS in WebKit.
106
107         * Scripts/webkitpy/common/checkout/checkout.py:
108         (Checkout.bug_id_for_this_commit):
109         * Scripts/webkitpy/common/checkout/checkout_mock.py:
110         (MockCheckout.commit_message_for_this_commit):
111         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
112         (CheckoutTest.test_suggested_reviewers):
113         * Scripts/webkitpy/common/checkout/deps.py: Removed.
114         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
115         * Scripts/webkitpy/tool/bot/irc_command.py:
116         (RollChromiumDEPS): Teach webkitbot a sense of humor.
117         (RollChromiumDEPS.execute):
118         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
119         (IRCCommandTest.test_create_bug):
120         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
121         (IRCBotTest.test_revert):
122         * Scripts/webkitpy/tool/bot/sheriff.py:
123         (Sheriff.post_rollout_patch):
124         * Scripts/webkitpy/tool/commands/__init__.py:
125         * Scripts/webkitpy/tool/commands/roll.py: Removed.
126         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
127         * Scripts/webkitpy/tool/steps/__init__.py:
128         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
129         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
130         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
131
132 2013-04-11  Glenn Adams  <glenn@skynav.com>
133
134         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
135         https://bugs.webkit.org/show_bug.cgi?id=114386
136
137         Reviewed by Benjamin Poulain.
138
139         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
140         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
141         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
142         by default and to return exit code 1 if a file/dir had already been added.
143
144         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
145         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
146         * Scripts/webkitpy/common/checkout/scm/svn.py:
147         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
148
149 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
150
151         Unreviewed.
152
153         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
154
155 2013-04-10  Glenn Adams  <glenn@skynav.com>
156
157         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
158         https://bugs.webkit.org/show_bug.cgi?id=114410
159
160         Reviewed by Ryosuke Niwa.
161
162         * Scripts/webkitpy/common/checkout/scm/git.py:
163         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
164         * Scripts/webkitpy/common/checkout/scm/scm.py:
165         (SCM.add): Remove optional return_exit_code argument.
166         (SCM.add_list): Remove optional return_exit_code argument.
167         * Scripts/webkitpy/common/checkout/scm/svn.py:
168         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
169
170 2013-04-10  Eric Seidel  <eric@webkit.org>
171
172         Remove myself from the watchlists, I'm getting too much bug mail. :)
173
174         * Scripts/webkitpy/common/config/watchlist:
175
176 2013-04-10  Commit Queue  <rniwa@webkit.org>
177
178         Unreviewed, rolling out r148158.
179         http://trac.webkit.org/changeset/148158
180         https://bugs.webkit.org/show_bug.cgi?id=114405
181
182         We need to migrate status data (Requested by rniwa on
183         #webkit).
184
185         * Scripts/webkitpy/common/net/statusserver.py:
186         (StatusServer):
187
188 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
189
190         Mass remove all the empty directories
191
192         Rubberstamped by Ryosuke Niwa.
193
194         * BuildSlaveSupport/gtk/crashmon/log: Removed.
195         * BuildSlaveSupport/gtk/xvfb/log: Removed.
196         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
197         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
198         * MiniBrowser/gtk/WebBundle: Removed.
199         * MiniBrowser/win: Removed.
200         * QtTestPlatformPlugin/mac: Removed.
201         * Scripts/webkitpy/tool/bot/testdata: Removed.
202         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
203         * efl/ImageDiff: Removed.
204         * iExploder/htdocs: Removed.
205         * iExploder/iexploder-1.7.2/output: Removed.
206         * iExploder/tools: Removed.
207         * qmake/config.tests/libexecdir: Removed.
208         * qmake/config.tests/libjpeg: Removed.
209         * qmake/config.tests/libpng: Removed.
210
211 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
212
213         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
214         https://bugs.webkit.org/show_bug.cgi?id=114397
215
216         Reviewed by Benjamin Poulain.
217
218         * Scripts/webkitpy/common/net/statusserver.py:
219         (StatusServer):
220
221 2013-04-10  Adam Barth  <abarth@webkit.org>
222
223         Remove abarth from watchlists
224         https://bugs.webkit.org/show_bug.cgi?id=114390
225
226         Reviewed by Ryosuke Niwa.
227
228         I'm trying to cut down on the amount of bugmail I get so that I'll have
229         more of a chance to notice a piece of bugmail directed at me.
230
231         * Scripts/webkitpy/common/config/watchlist:
232
233 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
234
235         webkit-test-results.appspot.com loads the dashboard for Chromium by default
236         https://bugs.webkit.org/show_bug.cgi?id=114381
237
238         Reviewed by Benjamin Poulain.
239
240         Changed the defaults.
241
242         * TestResultServer/static-dashboards/builders.js:
243         * TestResultServer/static-dashboards/dashboard_base.js:
244         (currentBuilderGroupCategory):
245
246 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
247
248         Remove Chromium EWS bots from the queue status server
249         https://bugs.webkit.org/show_bug.cgi?id=113988
250
251         Reviewed by Benjamin Poulain.
252
253         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
254
255         * QueueStatusServer/app.yaml:
256         * QueueStatusServer/config/queues.py:
257         * QueueStatusServer/model/queues.py:
258         (Queue.short_name):
259         (Queue.display_name):
260         * QueueStatusServer/model/queues_unittest.py:
261         (QueueTest.test_short_name):
262         (QueueTest.test_display_name):
263         (QueueTest.test_name_with_underscores):
264         * QueueStatusServer/templates/activebots.html:
265
266 2013-04-10  Ojan Vafai  <ojan@chromium.org>
267
268         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
269         https://bugs.webkit.org/show_bug.cgi?id=114370
270
271         Reviewed by Ryosuke Niwa.
272
273         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
274         Unfortunately, there's no way to test this until this is committed and there is
275         a master restart.
276
277         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
283         * TestResultServer/generate_builders_json.py:
284         * TestResultServer/static-dashboards/dashboard_base.js:
285         * TestResultServer/static-dashboards/loader.js:
286
287 2013-04-10  Glenn Adams  <glenn@skynav.com>
288
289         [Qt] Fix regression to test-webkitpy.
290         https://bugs.webkit.org/show_bug.cgi?id=114368
291
292         Reviewed by Ryosuke Niwa.
293
294         * Scripts/webkitpy/layout_tests/port/factory.py:
295         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
296         (PortFactory.get): Remove obsolete chromium port related code.
297         * Scripts/webkitpy/layout_tests/port/mac.py:
298         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
299
300 2013-04-10  Anders Carlsson  <andersca@apple.com>
301
302         Remove unneeded headers from FrameLoader.h
303         https://bugs.webkit.org/show_bug.cgi?id=114223
304
305         Reviewed by Geoffrey Garen.
306
307         Add back headers implicitly included by other headers.
308
309         * WebKitTestRunner/WorkQueueManager.cpp:
310
311 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
312
313         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
314         https://bugs.webkit.org/show_bug.cgi?id=114365
315
316         Reviewed by Martin Robinson.
317
318         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
319         The patch addresses crashes in the tally_event_reply method. It is already committed into the
320         at-spi2-atk source tree and will be available with the next stable release, after which the
321         patch should be removed and the dependency version bumped.
322
323         * gtk/jhbuild.modules:
324         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
325
326 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
327
328         [WinCairo] Unreviewed build fix. Correct DropBox download link.
329
330         * Scripts/update-webkit-wincairo-libs: Revise download URL to
331         match change in DropBox server behavior.
332
333 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
334
335         Removed an annoying message from svn-create-patch
336         https://bugs.webkit.org/show_bug.cgi?id=114332
337
338         Reviewed by Alexey Proskuryakov.
339
340         I see this message basically every time I write a patch, so it must not
341         be true.
342
343         * Scripts/svn-create-patch:
344         (generateDiff):
345
346 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
347
348         [GTK] Add support for Page Visibility
349         https://bugs.webkit.org/show_bug.cgi?id=97324
350
351         Reviewed by Sam Weinig.
352
353         Implemented test runner API for page visibility layout tests.
354
355         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
356         (TestRunner::resetPageVisibility):
357         (TestRunner::setPageVisibility):
358         * Scripts/webkitperl/FeatureList.pm:
359
360 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
361
362         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
363         https://bugs.webkit.org/show_bug.cgi?id=114342
364
365         Reviewed by Gyuyoung Kim.
366
367         Commit 148033 only added an implementation for the Mac port, which made
368         other ports fail most tests since loading the injected bundle failed
369         with a missing symbol.
370
371         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
372         (WTR::AccessibilityUIElement::pathDescription):
373
374 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
375
376         [EFL] Add spell checking option to MiniBrowser
377         https://bugs.webkit.org/show_bug.cgi?id=114282
378
379         Reviewed by Ryosuke Niwa.
380
381         Spell checking is enabled by adding a flag (t/text-checking)
382         with launching MiniBrowser.
383
384         * MiniBrowser/efl/main.c:
385         (window_create):
386         (elm_main):
387
388 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
389
390         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
391         https://bugs.webkit.org/show_bug.cgi?id=113281
392
393         Reviewed by Darin Adler.
394
395         * Scripts/run-gtk-tests:
396         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
397
398 2013-04-09  Glenn Adams  <glenn@skynav.com>
399
400         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
401
402         Unreviewed.
403
404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
405         (RunTest.test_build_check):
406
407 2013-04-09  Glenn Adams  <glenn@skynav.com>
408
409         [webkitpy] Remove chromium ports.
410         https://bugs.webkit.org/show_bug.cgi?id=114326
411
412         Reviewed by Dirk Pranke.
413
414         As a side effect, also:
415
416         - remove chromium builders from webkitpy.layout_tests.port.builders
417         - remove chromium builders from rebaseline
418         - rewrite chromium dependent tests in rebaseline_unittest
419         - remove chromium platform from garden-o-matic
420         - select apple platform as default platform in garden-o-matic
421         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
425         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
426         (BaselineOptimizerTest.test_move_baselines):
427         (BaselineOptimizerTest.test_efl):
428         (BaselineOptimizerTest.test_no_add_mac_future):
429         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
430         (BaselineOptimizerTest.test_common_directory_includes_root):
431         (BaselineOptimizerTest.test_complex_shadowing):
432         (BaselineOptimizerTest.test_virtual_ports_filtered):
433         * Scripts/webkitpy/layout_tests/port/builders.py:
434         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
435         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
436         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
437         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
438         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
439         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
440         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
441         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
442         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
443         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
444         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
445         * Scripts/webkitpy/layout_tests/port/factory.py:
446         (platform_options):
447         (PortFactory):
448         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
449         (FactoryTest.test_qt):
450         (FactoryTest.test_get_from_builder_name):
451         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
452         (RunTest.test_build_check):
453         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
454         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
455         * Scripts/webkitpy/tool/commands/rebaseline.py:
456         (Rebaseline._builders_to_pull_from):
457         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
458         (_BaseTestCase):
459         (_BaseTestCase.setUp):
460         (TestRebaselineTest.setUp):
461         (TestRebaselineTest.test_baseline_directory):
462         (test_rebaseline_updates_expectations_file):
463         (test_rebaseline_does_not_include_overrides):
464         (test_rebaseline_test):
465         (test_rebaseline_test_and_print_scm_changes):
466         (test_rebaseline_and_copy_test):
467         (test_rebaseline_and_copy_test_no_existing_result):
468         (test_rebaseline_and_copy_test_with_lion_result):
469         (test_rebaseline_and_copy_no_overwrite_test):
470         (TestRebaselineExpectations.test_rebaseline_expectations):
471
472 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
473
474         newcommitbot (WKR) requires a subversion checkout
475         https://bugs.webkit.org/show_bug.cgi?id=114309
476
477         Reviewed by Benjamin Poulain.
478
479         Directly talk to the subversion server instead of relying on a local checkout.
480         This allows us to run WKR off of a git clone.
481
482         * Scripts/webkitpy/tool/commands/newcommitbot.py:
483         (NewCommitBot.next_work_item):
484         (NewCommitBot.process_work_item):
485
486 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
487
488         webkitbot refers to sheriffbot in help
489         https://bugs.webkit.org/show_bug.cgi?id=114307
490
491         Reviewed by Benjamin Poulain.
492
493         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
494
495         * Scripts/webkitpy/tool/bot/irc_command.py:
496         (Help):
497         (Help.execute):
498         (RollChromiumDEPS.execute):
499         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
500         (IRCBotTest.test_help):
501         * Scripts/webkitpy/tool/bot/sheriff.py:
502         (Sheriff.name):
503
504 2013-04-06  Roger Fong  <roger_fong@apple.com>
505
506         Kill old processes between runs on WinEWS bots.
507         Temporarily disable tests to let bots catch up again.
508
509         * EWSTools/start-queue-win.sh:
510         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
511         (WinEWS):
512
513 2013-04-09  Glenn Adams  <glenn@skynav.com>
514
515         [webkitpy] Remove chromium deprecated port support.
516         https://bugs.webkit.org/show_bug.cgi?id=114228
517
518         Reviewed by Ryosuke Niwa.
519
520         * Scripts/webkitpy/common/config/ports.py:
521         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
522         (ChromiumPort): Removed.
523         (ChromiumAndroidPort): Removed.
524         (ChromiumXVFBPort): Removed.
525         * Scripts/webkitpy/common/config/ports_unittest.py:
526         (DeprecatedPortTest.test_chromium_port): Removed.
527         (DeprecatedPortTest.test_chromium_android_port): Removed.
528         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
529         * Scripts/webkitpy/tool/steps/update_unittest.py:
530         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
531         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
532
533 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
534
535         AX: The bounding paths should be made available through accessibility
536         https://bugs.webkit.org/show_bug.cgi?id=113817
537
538         Reviewed by David Kilzer.
539
540         Add a pathDescription property for testing so that it's possible
541         to verify that a path is being returned correctly.
542
543         * DumpRenderTree/AccessibilityUIElement.cpp:
544         (getPathDescriptionCallback):
545         (AccessibilityUIElement::pathDescription):
546         (AccessibilityUIElement::getJSClass):
547         * DumpRenderTree/AccessibilityUIElement.h:
548         (AccessibilityUIElement):
549         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
550         (_CGPathEnumerationIteration):
551         (AccessibilityUIElement::pathDescription):
552         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
553         (AccessibilityUIElement::pathDescription):
554         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
555         (WTR::AccessibilityUIElement::pathDescription):
556         (WTR):
557         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
558         (AccessibilityUIElement):
559         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
560         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
561         (WTR::AccessibilityUIElement::pathDescription):
562         (WTR):
563
564 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
565
566         [EFL] Declare TEST_THEME_DIR in a single place.
567         https://bugs.webkit.org/show_bug.cgi?id=114285
568
569         Reviewed by Anders Carlsson.
570
571         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
572
573         * DumpRenderTree/efl/CMakeLists.txt:
574         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
575         (DumpRenderTreeChrome::createView):
576         (DumpRenderTreeChrome::createInspectorView):
577         (DumpRenderTreeChrome::initialize):
578         (DumpRenderTreeChrome::onDownloadRequest):
579         * EWebLauncher/CMakeLists.txt:
580         * EWebLauncher/main.c:
581         (findThemePath):
582         * EWebLauncher/url_bar.c:
583         (url_bar_add):
584         * MiniBrowser/efl/CMakeLists.txt:
585         * MiniBrowser/efl/main.c:
586         (window_create):
587         * TestWebKitAPI/PlatformEfl.cmake:
588         * TestWebKitAPI/efl/PlatformWebView.cpp:
589         (TestWebKitAPI::PlatformWebView::PlatformWebView):
590         * WebKitTestRunner/PlatformEfl.cmake:
591         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
592         (WTR::PlatformWebView::PlatformWebView):
593
594 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
595
596         [GTK][AC] upversion of clutter and its dependecy
597         https://bugs.webkit.org/show_bug.cgi?id=114016
598
599         Reviewed by Gustavo Noronha Silva.
600
601         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
602
603         * gtk/jhbuild-optional.modules:
604
605 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
606
607         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
608         https://bugs.webkit.org/show_bug.cgi?id=89875
609
610         Reviewed by Maciej Stachowiak.
611
612         Add unit tests to verify if the handling of the open, openat, creat syscall
613         is being done right. We check if the Read/Write/ReadAndWrite permissions
614         are respected, if the canonical path is being resolved and if
615         the permissions are falling back to the topmost parent directory with a
616         policy set when the directory being opened has no policy.
617
618         We also test if any attempt of blocking SIGSYS is silently ignored.
619         SIGSYS cannot be blocked because in it's handler is where we hook
620         syscalls to the broker process.
621
622         Also added libseccomp to EFL's jhbuild to make the life of developers
623         willing to help easier.
624
625         * Scripts/webkitperl/FeatureList.pm:
626         * TestWebKitAPI/PlatformEfl.cmake:
627         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
628         (TestWebKitAPI):
629         (SeccompEnvironment):
630         (TestWebKitAPI::SeccompEnvironment::SetUp):
631         (TestWebKitAPI::SeccompEnvironment::TearDown):
632         (TestWebKitAPI::dummyHandler):
633         (TestWebKitAPI::TEST):
634         (TestWebKitAPI::stressTest):
635         * efl/jhbuild.modules:
636         * qmake/mkspecs/features/features.pri:
637
638 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
639
640         REGRESSION: Autocorrection doesn't work in DumpRenderTree
641         https://bugs.webkit.org/show_bug.cgi?id=113846
642
643         Reviewed by Alexey Proskuryakov.
644
645         The problem was that we were replacing NSSpellCheck's dictionary with our own
646         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
647
648         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
649         and "would" respectively in DumpRenderTree.
650
651         * DumpRenderTree/mac/DumpRenderTree.mm:
652         (resetDefaultsToConsistentValues):
653
654 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
655
656         Remove the gyp files for Tools
657         https://bugs.webkit.org/show_bug.cgi?id=114248
658
659         Reviewed by Ryosuke Niwa.
660
661         * DumpRenderTree/DumpRenderTree.gyp: Removed.
662         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
663         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
664         * DumpRenderTree/DumpRenderTree.gypi: Removed.
665         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
666         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
667         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
668         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
669
670 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
671
672         WKR (new-commit-bot) is too slow
673         https://bugs.webkit.org/show_bug.cgi?id=110087
674
675         Reviewed by Geoffrey Garen.
676
677         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
678         Just run "svn log -r <revision>" instead to cut down the delay.
679
680         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
681
682         * Scripts/webkitpy/tool/commands/newcommitbot.py:
683         (NewCommitBot):
684         (NewCommitBot.next_work_item):
685         (NewCommitBot._is_empty_log):
686         (NewCommitBot._update_checkout):
687
688 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
689
690         Build fix. Can't remove appendCustomBuildFlags.
691
692         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
693         (appendCustomBuildFlags):
694
695 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
696
697         Remove Chromium builders from build.webkit.org
698         https://bugs.webkit.org/show_bug.cgi?id=113990
699
700         Reviewed by Benjamin Poulain.
701
702         Removed.
703
704         * BuildSlaveSupport/build.webkit.org-config/config.json:
705         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
706         (InstallGtkDependencies):
707         (RunUnitTests.start):
708         (RunWebKit2Tests.start):
709         (Factory.__init__):
710         (unitTestsSupported):
711         (TestFactory.__init__):
712         (BuildAndTestFactory.__init__):
713         (BuildAndPerfTestFactory.__init__):
714         (BuildAndPerfTestWebKit2Factory.__init__):
715         (DownloadAndPerfTestFactory.__init__):
716         (loadBuilderConfig):
717         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
718
719 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
720
721         Remove HTML Notification
722         https://bugs.webkit.org/show_bug.cgi?id=114231
723
724         Reviewed by Ryosuke Niwa.
725
726         * qmake/mkspecs/features/features.pri:
727
728 2013-04-08  Glenn Adams  <glenn@skynav.com>
729
730         Remove chromium EWS support, and fix broken test.
731         https://bugs.webkit.org/show_bug.cgi?id=114221
732
733         Reviewed by Ryosuke Niwa.
734
735         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
736         (AbstractChromiumEWS): Removed.
737         (ChromiumLinuxEWS): Removed.
738         (ChromiumLinuxDebugEWS): Removed.
739         (ChromiumWindowsEWS): Removed.
740         (ChromiumAndroidEWS): Removed.
741         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
742         (EarlyWarningSystemTest): Fix misspelled class name.
743         (test_ewses): Fix entry point name to ensure test is run.
744
745 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
746
747         [WIN] Remove WebKit2 source code
748         https://bugs.webkit.org/show_bug.cgi?id=114096
749
750         Reviewed by Anders Carlsson.
751
752         Remove the windows specific parts of the MiniBrowser.
753
754         * MiniBrowser/MiniBrowser.vcproj: Removed.
755         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
756         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
757         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
758         * MiniBrowser/win/BrowserView.cpp: Removed.
759         * MiniBrowser/win/BrowserView.h: Removed.
760         * MiniBrowser/win/BrowserWindow.cpp: Removed.
761         * MiniBrowser/win/BrowserWindow.h: Removed.
762         * MiniBrowser/win/MiniBrowser.cpp: Removed.
763         * MiniBrowser/win/MiniBrowser.h: Removed.
764         * MiniBrowser/win/MiniBrowser.rc: Removed.
765         * MiniBrowser/win/main.cpp: Removed.
766         * MiniBrowser/win/resource.h: Removed.
767         * MiniBrowser/win/stdafx.cpp: Removed.
768         * MiniBrowser/win/stdafx.h: Removed.
769
770 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
771
772         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
773
774         * Scripts/webkitpy/common/config/irc.py:
775
776 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
777
778         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
779         https://bugs.webkit.org/show_bug.cgi?id=113139
780
781         Reviewed by Anders Carlsson.
782
783         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
784         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
785         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
786         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
787         (ToStringAndValueOfObject):
788         (ToStringAndValueOfObject::ToStringAndValueOfObject):
789         (ScriptableObject):
790         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
791         (ToStringAndValueOfObject::ScriptableObject::invoke):
792         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
793         (ToStringAndValueOfObject::NPP_GetValue):
794         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
795         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
796         * GNUmakefile.am:
797
798 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
799
800         [GTK] Bump gnome-themes-standard to 3.6.0
801         https://bugs.webkit.org/show_bug.cgi?id=114155
802
803         Reviewed by Martin Robinson.
804
805         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
806         dependency of gnome-themes-standard accordingly.
807
808 2013-04-08  David Levin  <levin@chromium.org>
809
810         Remove my watchlist entries.
811         https://bugs.webkit.org/show_bug.cgi?id=114180
812
813         Reviewed by Adam Barth.
814
815         * Scripts/webkitpy/common/config/committers.py:
816         * Scripts/webkitpy/common/config/watchlist:
817
818 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
819
820         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
821         https://bugs.webkit.org/show_bug.cgi?id=114161
822
823         Reviewed by Gyuyoung Kim.
824
825         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
826         as it is crashing due to Bug 111074.
827
828         * TestWebKitAPI/PlatformEfl.cmake:
829
830 2013-04-07  David Kilzer  <ddkilzer@apple.com>
831
832         Remove the rest of SVG_DOM_OBJC_BINDINGS
833         <http://webkit.org/b/114112>
834
835         Reviewed by Geoffrey Garen.
836
837         * Scripts/webkitperl/FeatureList.pm:
838         - Remove --svg-dom-objc-bindings switch.
839         * qmake/mkspecs/features/features.pri:
840         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
841
842 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
843
844         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
845         https://bugs.webkit.org/show_bug.cgi?id=114089
846
847         Reviewed by Chris Fleizach.
848
849         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
850         * DumpRenderTree/AccessibilityController.cpp:
851         * DumpRenderTree/AccessibilityUIElement.cpp:
852         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
853         (DumpRenderTreeChrome::DumpRenderTreeChrome):
854         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
855         (DumpRenderTreeChrome):
856
857 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
858
859         Build fix after r147857, remove remaining USE(JSC) guards.
860
861         Unreviewed.
862
863         * DumpRenderTree/config.h:
864         * TestWebKitAPI/config.h:
865         * WebKitTestRunner/config.h:
866
867 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
868
869         Rename sheriffbot to webkitbot
870         https://bugs.webkit.org/show_bug.cgi?id=114109
871
872         Reviewed by Benjamin Poulain.
873
874         Renamed since sheriffbot will be used in Blink.
875
876         * Scripts/webkitpy/tool/commands/sheriffbot.py:
877         (SheriffBot):
878         (SheriffBot.begin_work_queue):
879
880 2013-04-06  Oliver Hunt  <oliver@apple.com>
881
882         Unify the many and varied stack trace mechanisms, and make the result sane.
883         https://bugs.webkit.org/show_bug.cgi?id=114072
884
885         Reviewed by Filip Pizlo.
886
887         The commandline jsc executable no longer requires arguments, so
888         I've made run-jsc work without them.
889
890         * Scripts/run-jsc:
891
892 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
893
894         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
895         https://bugs.webkit.org/show_bug.cgi?id=114086
896
897         Reviewed by Tim Horton.
898
899         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
900
901 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
902
903         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
904         https://bugs.webkit.org/show_bug.cgi?id=114083
905
906         Reviewed by Ryosuke Niwa.
907
908         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
909         in TestWebKitAPI and WebKitTestRunner.
910
911         * TestWebKitAPI/config.h:
912         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
913         (TestWebKitAPI::InjectedBundleController::platformInitialize):
914         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
915         (WTR::InjectedBundle::platformInitialize):
916
917 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
918
919         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
920         https://bugs.webkit.org/show_bug.cgi?id=114094
921
922         Reviewed by Anders Carlsson.
923
924         * Scripts/run-jsc:
925
926 2013-04-05  Ojan Vafai  <ojan@chromium.org>
927
928         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
929         https://bugs.webkit.org/show_bug.cgi?id=114080
930
931         Reviewed by Ryosuke Niwa.
932
933         This way, the WebKit and Blink dashboard code can change as appropriate without
934         needing to consider the other project's needs. This still doesn't update the
935         buildbots to upload to the new location, or the dashboard code to pull the
936         results.json files from the new location, but it at least allows for changing the
937         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
938
939         * TestResultServer/app.yaml:
940
941 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
942
943         Re-enable testing on the commit queue
944         https://bugs.webkit.org/show_bug.cgi?id=114078
945
946         Reviewed by Darin Adler.
947
948         Re-enabled the feature and the associated tests.
949
950         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
951         (CommitQueueTask.run):
952         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
953         (CommitQueueTaskTest._run_through_task):
954         * Scripts/webkitpy/tool/commands/queues_unittest.py:
955         (CommitQueueTest._mock_test_result):
956
957 2013-04-05  Oliver Hunt  <oliver@apple.com>
958
959         Unify the many and varied stack trace mechanisms, and make the result sane.
960         https://bugs.webkit.org/show_bug.cgi?id=114072
961
962         Reviewed by Filip Pizlo.
963
964         The commandline jsc executable no longer requires arguments, so
965         I've made run-jsc work without them.
966
967         * Scripts/run-jsc:
968
969 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
970
971         AX: Make SVG Group containers accessible elements
972         https://bugs.webkit.org/show_bug.cgi?id=113939
973
974         Reviewed by Simon Fraser.
975
976         Implement axController.elementAtPoint for iOS.
977         Implement a correct version of clickPoint for iOS.
978
979         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
980         (AccessibilityController::elementAtPoint):
981         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
982         (AccessibilityUIElement::clickPointX):
983         (AccessibilityUIElement::clickPointY):
984
985 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
986
987         Unreviewed, rolling out r147773 and r147774.
988         http://trac.webkit.org/changeset/147773
989         http://trac.webkit.org/changeset/147774
990         https://bugs.webkit.org/show_bug.cgi?id=114056
991
992         Causing some exceptions on AppEngine I don't understand
993         (Requested by rniwa on #webkit).
994
995         * QueueStatusServer/config/queues.py:
996         * QueueStatusServer/model/queues.py:
997         (Queue.short_name):
998         (Queue.display_name):
999         * QueueStatusServer/model/queues_unittest.py:
1000         (QueueTest.test_short_name):
1001         (QueueTest.test_display_name):
1002         (QueueTest.test_name_with_underscores):
1003
1004 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1005
1006         Fixed run-bindings-tests by removing V8
1007         https://bugs.webkit.org/show_bug.cgi?id=114053
1008
1009         Reviewed by Benjamin Poulain.
1010
1011         * Scripts/run-bindings-tests:
1012         (main):
1013
1014 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1015
1016         Build fix.
1017
1018         * QueueStatusServer/model/queues.py:
1019         (Queue.short_name):
1020         (Queue.display_name):
1021
1022 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1023
1024         Remove Chromium EWS bots from the queue status server
1025         https://bugs.webkit.org/show_bug.cgi?id=113988
1026
1027         Reviewed by Benjamin Poulain.
1028
1029         Removed Chromium EWS bots.
1030
1031         * QueueStatusServer/config/queues.py:
1032         * QueueStatusServer/model/queues.py:
1033         (Queue.short_name):
1034         (Queue.display_name):
1035         * QueueStatusServer/model/queues_unittest.py:
1036         (QueueTest.test_short_name):
1037         (QueueTest.test_display_name):
1038         (QueueTest.test_name_with_underscores):
1039
1040 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1041
1042         [EFL] Enable indexed database
1043         https://bugs.webkit.org/show_bug.cgi?id=107248
1044
1045         Reviewed by Alexis Menard.
1046
1047         * Scripts/webkitperl/FeatureList.pm:
1048
1049 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1050
1051         Remove vestiges of Chromium bits from watchlists.
1052         https://bugs.webkit.org/show_bug.cgi?id=114047
1053
1054         Reviewed by Ryosuke Niwa.
1055
1056         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1057
1058 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1059
1060         Add James Craig to the contributors list.
1061
1062         * Scripts/webkitpy/common/config/committers.py:
1063
1064 2013-04-04  Kent Tamura  <tkent@chromium.org>
1065
1066         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1067
1068         * Scripts/webkitpy/common/config/watchlist:
1069
1070 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1071
1072         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1073         https://bugs.webkit.org/show_bug.cgi?id=113997
1074
1075         Reviewed by Ryosuke Niwa.
1076
1077         Disable the tests until Ryosuke gets the time and hardware to have
1078         a testing commit-queue.
1079
1080         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1081         (CommitQueueTaskTest):
1082         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1083         (CommitQueueTest):
1084
1085 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1086
1087         Remove Chromium builders from build.webkit.org
1088         https://bugs.webkit.org/show_bug.cgi?id=113990
1089
1090         Reviewed by Benjamin Poulain.
1091
1092         Land the part to disable triggering of Chromium builders first so that we may start
1093         deleting more Chromium code that breaks the update step.
1094
1095         * BuildSlaveSupport/build.webkit.org-config/config.json:
1096
1097 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1098
1099         Remove Chromium's DumpRenderTree
1100         https://bugs.webkit.org/show_bug.cgi?id=113989
1101
1102         Reviewed by Kent Tamura.
1103
1104         On second thought, let's not go to Camelot. It is a silly place.
1105
1106         * DumpRenderTree/mac/DumpRenderTree.mm:
1107         (resetDefaultsToConsistentValues):
1108
1109 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1110
1111         Nixed the defunct chromium folder from DumpRenderTree
1112         https://bugs.webkit.org/show_bug.cgi?id=113993
1113
1114         Reviewed by Ryosuke Niwa.
1115
1116         * DumpRenderTree/chromium: Removed.
1117         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1118         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1119         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1120         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1121         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1122         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1123         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1124         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1125         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1126         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1127         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1128         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1129         * DumpRenderTree/chromium/Task.cpp: Removed.
1130         * DumpRenderTree/chromium/Task.h: Removed.
1131         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1132         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1133         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1134         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1135         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1136         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1137         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1138         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1139         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1140         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1141         * DumpRenderTree/chromium/TestRunner: Removed.
1142         * DumpRenderTree/chromium/TestRunner/public: Removed.
1143         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1144         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1145         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1146         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1147         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1148         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1149         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1150         * DumpRenderTree/chromium/TestRunner/src: Removed.
1151         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1152         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1153         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1154         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1155         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1156         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1157         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1158         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1159         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1160         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1161         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1162         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1163         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1164         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1165         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1166         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1167         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1168         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1169         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1170         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1171         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1172         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1173         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1174         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1175         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1176         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1177         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1178         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1179         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1180         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1181         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1182         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1183         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1184         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1185         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1186         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1187         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1188         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1189         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1190         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1191         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1192         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1193         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1194         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1195         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1196         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1197         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1198         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1199         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1200         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1201         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1202         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1203         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1204         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1205         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1206         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1207         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1208         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1209         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1210         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1211         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1212         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1213         * DumpRenderTree/chromium/TestShell.h: Removed.
1214         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1215         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1216         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1217         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1218         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1219         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1220         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1221         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1222         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1223         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1224         * DumpRenderTree/chromium/config.h: Removed.
1225         * DumpRenderTree/chromium/fonts.conf: Removed.
1226
1227 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1228
1229         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1230
1231         Rubber stamped by Benjamin Poulain.
1232
1233         * RebaselineQueueServer: Removed.
1234         * RebaselineQueueServer/app.yaml: Removed.
1235         * RebaselineQueueServer/handlers: Removed.
1236         * RebaselineQueueServer/handlers/__init__.py: Removed.
1237         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1238         * RebaselineQueueServer/handlers/pages.py: Removed.
1239         * RebaselineQueueServer/index.yaml: Removed.
1240         * RebaselineQueueServer/main.py: Removed.
1241         * RebaselineQueueServer/model: Removed.
1242         * RebaselineQueueServer/model/__init__.py: Removed.
1243         * RebaselineQueueServer/model/queueentry.py: Removed.
1244         * RebaselineQueueServer/static: Removed.
1245         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1246         * RebaselineQueueServer/static/styles.css: Removed.
1247         * RebaselineQueueServer/templates: Removed.
1248         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1249         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1250         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1251         * RebaselineQueueServer/templates/home.html: Removed.
1252
1253 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1254
1255         Fix setup-commit-queue and temporarily disable testing on commit-queue
1256         https://bugs.webkit.org/show_bug.cgi?id=113979
1257
1258         Reviewed by Benjamin Poulain.
1259
1260         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1261         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1262
1263         * EWSTools/setup-commit-queue.sh:
1264         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1265         (CommitQueueTask.run):
1266
1267 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1268
1269         temporarily make flakiness dashboard work again webkit.org bots
1270         https://bugs.webkit.org/show_bug.cgi?id=113972
1271
1272         Reviewed by Ojan Vafai.
1273
1274         This patch disables the chromium.org layout test bots TestExpectations
1275         parsing temporarily until we can work out the right way to split into
1276         two instances for webkit.org and chromium.org and figure out which
1277         code to delete where :).
1278
1279         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1280
1281 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1282
1283         Fix webkitpy tests after r147678.
1284
1285         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1286         (CommitQueueTest.test_commit_queue):
1287         (test_manual_reject_during_processing):
1288
1289 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1290
1291         The commit queue should use Mac MountainLion port
1292         https://bugs.webkit.org/show_bug.cgi?id=113971
1293
1294         Reviewed by Lucas Forschler.
1295
1296         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1297         * Scripts/webkitpy/tool/commands/queues.py:
1298         (CommitQueue):
1299
1300 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1301
1302         turn off running tests on chromium linux EWS bots
1303         https://bugs.webkit.org/show_bug.cgi?id=113959
1304
1305         Reviewed by Geoffrey Garen.
1306
1307         Now that the Chromium port is no longer being maintained
1308         there's little point in running the tests. Soon we should
1309         just shut this bot off altogether.
1310
1311         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1312         (ChromiumLinuxEWS):
1313
1314 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1315
1316         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1317
1318         * Scripts/webkitpy/common/config/watchlist:
1319
1320 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1321
1322         Indentation fix to get webkit-patch working again after r147625
1323
1324         Unreviewed.
1325
1326         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1327         (MacEWS):
1328         (MacWK2EWS):
1329
1330 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1331
1332         Turn tests back on for Mac WK1/WK2 EWS.
1333         
1334         Unreviewed.
1335         
1336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1337         (MacEWS):
1338         (MacWK2EWS):
1339
1340 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1341
1342         [GTK][WK2] MiniBrowser custom URI scheme support
1343         https://bugs.webkit.org/show_bug.cgi?id=112419
1344
1345         Reviewed by Carlos Garcia Campos.
1346
1347         Add support for about URIs in MiniBrowser. An example about page is show
1348         with URI "about:minibrowser", the rest of the cases it will show a
1349         proper message explaining that the about page didn't exist.
1350
1351         Internally it uses "minibrowser-about" prefix instead of "about", but
1352         from the user point of view it works with "about" prefix.
1353
1354         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1355         (getInternalURI): Method to convert URIs from "about" prefix to
1356         "minibrowser-about".
1357         (getExternalURI): Opposite method.
1358         (webViewURIChanged): Use "about" prefix to show the URI to users.
1359         (webViewEnterFullScreen): Ditto.
1360         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1361         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1362         (aboutURISchemeRequestCallback): Callback to manage about calls.
1363         (main): Register the URI scheme to manage about URIs.
1364
1365 2013-04-03  Roger Fong  <roger_fong@apple.com>
1366
1367         Re-enable WinEWS tests.
1368
1369         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1370         (WinEWS):
1371
1372 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1373
1374         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1375         https://bugs.webkit.org/show_bug.cgi?id=113883
1376
1377         Reviewed by Martin Robinson.
1378
1379         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1380         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1381         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1382
1383 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1384
1385         [GTK] Include Pango in jhbuild-optional.modules
1386         https://bugs.webkit.org/show_bug.cgi?id=113878
1387
1388         Reviewed by Martin Robinson.
1389
1390         Since r147547 Pango 1.32.0 is required. Including the module in the
1391         JHBuild optional moduleset.
1392
1393         * gtk/jhbuild-optional.modules: Add Pango module.
1394
1395 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1396
1397         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1398         https://bugs.webkit.org/show_bug.cgi?id=113864
1399
1400         Moving setDefersLoading from TestRunnerQt to TestRunner
1401         requires access to the non-Qt TestRunner.
1402         As long as we instantiate both TestRunner and TestRunnerQt,
1403         we need a separate getter for the non-Qt TestRunner instance.
1404
1405         Reviewed by Simon Hausmann.
1406
1407         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1408         (WebPage::resetSettings):
1409         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1410         (DumpRenderTree::jscTestRunner):
1411         * DumpRenderTree/qt/TestRunnerQt.cpp:
1412         (TestRunner::setDefersLoading):
1413             Moving setDefersLoading from TestRunnerQt
1414             to TestRunner.
1415         * DumpRenderTree/qt/TestRunnerQt.h:
1416         (TestRunnerQt):
1417
1418 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1419
1420         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1421         https://bugs.webkit.org/show_bug.cgi?id=104779
1422
1423         Reviewed by Carlos Garcia Campos.
1424
1425         * Scripts/run-gtk-tests:
1426         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1427         passing in current trunk.
1428
1429 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1430
1431         Fix HAVE(QTTESTSUPPORT) logic
1432
1433         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1434         resulting in HAVE(QTTESTSUPPORT) never being true.
1435         Move that logic down in sanitizeFeatures.
1436
1437         Rubber-stamped by Tor Arne Vestbø.
1438
1439         * qmake/mkspecs/features/features.prf:
1440
1441 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         [GTK] Bump required versions of some dependencies
1444         https://bugs.webkit.org/show_bug.cgi?id=113282
1445
1446         Reviewed by Martin Robinson.
1447
1448         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1449
1450 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1451
1452         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1453         https://bugs.webkit.org/show_bug.cgi?id=113809
1454
1455         Reviewed by Philippe Normand.
1456
1457         Newer Linux kernels have removed some deprecated macros from v4l2
1458         headers, causing gst-plugins-good's build to break. We don't need it
1459         right now, so just disable it.
1460
1461         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1462
1463 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1464
1465         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1466         https://bugs.webkit.org/show_bug.cgi?id=113535
1467
1468         Reviewed by Simon Hausmann.
1469
1470         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1471
1472         * qmake/mkspecs/features/features.prf:
1473
1474 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1475
1476         [Qt] Move logic of simple forwarding functions to TestRunner.
1477         https://bugs.webkit.org/show_bug.cgi?id=113863
1478
1479         Reviewed by Simon Hausmann.
1480
1481         * DumpRenderTree/qt/TestRunnerQt.cpp:
1482         (TestRunner::setTextDirection):
1483         (TestRunner::goBack):
1484         (TestRunner::evaluateScriptInIsolatedWorld):
1485         (TestRunner::addUserStyleSheet):
1486         * DumpRenderTree/qt/TestRunnerQt.h:
1487         (TestRunnerQt):
1488
1489 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1490
1491         [Qt] Disable media support using QuickTime if deployment target != SDK
1492
1493         We link to a single libWebKitSystemInterface static lib, so unless the
1494         deployment target matches the SDK let's not pretend like we'll be able
1495         to run on anything lower than the SDK version.
1496
1497         Reviewed by Simon Hausmann.
1498
1499         * qmake/mkspecs/features/features.prf:
1500
1501 2013-04-02  James Craig  <james@cookiecrook.com>
1502
1503         AXRoleDescripton for DL is "list"; should be "description list"
1504         https://bugs.webkit.org/show_bug.cgi?id=111665
1505
1506         Reviewed by Chris Fleizach.
1507
1508         Defining the role and description strings.
1509
1510         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1511
1512 2013-04-02  Roger Fong  <roger_fong@apple.com>
1513
1514         Unreviewed. Disable running tests on Win EWS queue.
1515
1516         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1517         (WinEWS):
1518
1519 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1520
1521         Disable running tests on the MAC WK2 EWS queue.
1522         
1523         Unreviewed.
1524         
1525         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1526         (MacWK2EWS):
1527
1528 2013-04-02  Julie Parent  <jparent@chromium.org>
1529
1530         Dashboard refactor: Move dashboard specific history related features to History.
1531         https://bugs.webkit.org/show_bug.cgi?id=113717
1532
1533         Reviewed by Ojan Vafai.
1534         
1535         Each dashboard now creates its own History object, with a custom
1536         configuration. This changes from just overriding global functions
1537         to passing in callbacks for generatePage, handleValidHashParameter,
1538         and handleQueryParameterChange. Same with passing in defaultStateValues
1539         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1540         variables.
1541         
1542         All functions related to these features are now (mostly) private
1543         function on History. 
1544         
1545         Loader no longer needs a loadingComplete callback, since it can just
1546         initialize the history object itself.
1547
1548         * TestResultServer/static-dashboards/aggregate_results.js:
1549         (handleValidHashParameter):
1550         * TestResultServer/static-dashboards/dashboard_base.js:
1551         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1552         (generatePage):
1553         (.switch.return):
1554         (handleQueryParameterChange):
1555         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1556         (resetGlobals):
1557         * TestResultServer/static-dashboards/history.js:
1558         (.):
1559         * TestResultServer/static-dashboards/loader.js:
1560         (.):
1561         * TestResultServer/static-dashboards/loader_unittests.js:
1562         * TestResultServer/static-dashboards/timeline_explorer.js:
1563         (generatePage):
1564         (initCurrentBuilderTestResults):
1565         * TestResultServer/static-dashboards/treemap.js:
1566         (generatePage):
1567         (.switch.return):
1568         (handleQueryParameterChange):
1569
1570 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1571
1572         Unreviewed, rolling out r147401.
1573         http://trac.webkit.org/changeset/147401
1574         https://bugs.webkit.org/show_bug.cgi?id=113767
1575
1576         The patch makes it extremely hard to set up the dependencies
1577         properly on the GTK builders (Requested by zdobersek on
1578         #webkit).
1579
1580         * gtk/jhbuild.modules:
1581
1582 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1583
1584         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1585         https://bugs.webkit.org/show_bug.cgi?id=113382
1586
1587         Reviewed by Gyuyoung Kim.
1588
1589         Do not show the empty tooltip box if the text is null.
1590
1591         * MiniBrowser/efl/main.c:
1592         (popup_menu_populate):
1593
1594 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1595
1596         [GTK] Bump required versions of some dependencies
1597         https://bugs.webkit.org/show_bug.cgi?id=113282
1598
1599         Reviewed by Martin Robinson.
1600
1601         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1602
1603 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1604
1605         Unreviewed, rolling out r147319.
1606         http://trac.webkit.org/changeset/147319
1607         https://bugs.webkit.org/show_bug.cgi?id=113707
1608
1609         The unit test is still failing on the buildbot (Requested by
1610         zdobersek on #webkit).
1611
1612         * Scripts/run-gtk-tests:
1613         (TestRunner):
1614
1615 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1616
1617         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1618         https://bugs.webkit.org/show_bug.cgi?id=104779
1619
1620         Reviewed by Carlos Garcia Campos.
1621
1622         * Scripts/run-gtk-tests:
1623         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1624         passing in current trunk.
1625
1626 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1627
1628         Unreviewed, rolling out r147289.
1629         http://trac.webkit.org/changeset/147289
1630         https://bugs.webkit.org/show_bug.cgi?id=113678
1631
1632         broke Win7 (dbg) build (Requested by shinyak|gardener on
1633         #webkit).
1634
1635         * DumpRenderTree/DumpRenderTree.gypi:
1636         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1637         (WebTestRunner):
1638         (WebUserMediaClientMock):
1639         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1640         (WebTestRunner::WebUserMediaClientMock::taskList):
1641         * Scripts/webkitpy/style/checkers/cpp.py:
1642         (check_function_definition):
1643
1644 2013-03-31  Adam Barth  <abarth@webkit.org>
1645
1646         configure-svn-config.sh fails
1647         https://codereview.chromium.org/13392007/
1648
1649         Reviewed by Eric Seidel.
1650
1651         This script was trying to use "svn checkout" to dowload a file from
1652         svn.webkit.org, but "svn checkout" only works with directories.
1653         Instead, we should use "svn export".
1654
1655         * EWSTools/configure-svn-config.sh:
1656
1657 2013-03-31  Wei Jia  <wjia@chromium.org>
1658
1659         Allow WebUserMediaClientMock to be used by client
1660         https://bugs.webkit.org/show_bug.cgi?id=113633
1661
1662         Reviewed by Adam Barth.
1663
1664         Export WebUserMediaClientMock.
1665         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1666
1667         * DumpRenderTree/DumpRenderTree.gypi:
1668         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1669         (WebUserMediaClientMock):
1670         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         (check_function_definition):
1673
1674 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1675
1676         Expose FeatureObserver data to WebKit clients
1677         https://bugs.webkit.org/show_bug.cgi?id=113613
1678
1679         Reviewed by Sam Weinig.
1680
1681         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1682         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1683
1684 2013-03-29  Greg Hughes  <ghughes@apple.com>
1685
1686         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1687         https://bugs.webkit.org/show_bug.cgi?id=112276
1688
1689         Reviewed by Chris Fleizach.
1690
1691         Added support to test accessibility search predicates with multiple keys.  
1692
1693         * DumpRenderTree/AccessibilityUIElement.cpp:
1694         (uiElementForSearchPredicateCallback):
1695         * DumpRenderTree/AccessibilityUIElement.h:
1696         (AccessibilityUIElement):
1697         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1698         (AccessibilityUIElement::uiElementForSearchPredicate):
1699         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1700         (AccessibilityUIElement::uiElementForSearchPredicate):
1701         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1702         (AccessibilityUIElement::uiElementForSearchPredicate):
1703         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1704         (AccessibilityUIElement::uiElementForSearchPredicate):
1705         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1706         (AccessibilityUIElement::uiElementForSearchPredicate):
1707         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1708         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1709         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1710         (AccessibilityUIElement):
1711         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1712         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1713         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1714         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1715         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1716
1717 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1718
1719         Fix a typo in r147147 to fix Mac EWS.
1720
1721         * Scripts/webkitpy/tool/commands/queues.py:
1722         (PatchProcessingQueue._new_port_name_from_old):
1723
1724 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1725
1726         [EFL] Build break with latest EFL libraries after r146265
1727         https://bugs.webkit.org/show_bug.cgi?id=113558
1728
1729         Unreviewed build fix.
1730
1731         * TestWebKitAPI/PlatformWebView.h:
1732         * WebKitTestRunner/PlatformWebView.h:
1733
1734 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1735
1736         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1737
1738         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1739         in libgcrypt build.
1740
1741 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1742
1743         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1744
1745         Unreviewed.
1746
1747         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1748         (MacEWS):
1749
1750 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1751
1752         Use the right OS name on Mac EWS instead of mac-future.
1753
1754         Rubber-stamped by Dirk Pranke.
1755
1756         * Scripts/webkitpy/tool/commands/queues.py:
1757         (PatchProcessingQueue._new_port_name_from_old):
1758         (PatchProcessingQueue.begin_work_queue):
1759         (PatchProcessingQueue._upload_results_archive_for_patch):
1760
1761 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1762
1763         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1764         https://bugs.webkit.org/show_bug.cgi?id=112546
1765
1766         Reviewed by Martin Robinson.
1767
1768         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1769         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1770
1771 2013-03-28  Ming Xie  <mxie@blackberry.com>
1772
1773         [BlackBerry] Committer Email Updates
1774         https://bugs.webkit.org/show_bug.cgi?id=113435
1775
1776         Reviewed by Rob Buis.
1777
1778         Add the @blackberry.com email address for all our BlackBerry
1779         WebKit committers. This is the first step for our email address
1780         migration.
1781
1782         * Scripts/webkitpy/common/config/committers.py:
1783
1784 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1785
1786         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1787         https://bugs.webkit.org/show_bug.cgi?id=113508
1788
1789         Reviewed by Martin Robinson.
1790
1791         Prevent the GStreamer plugin scanner to load system-wide
1792         plugins. Only the ones built in JHBuild should be loaded and used
1793         at runtime.
1794
1795         * efl/jhbuildrc:
1796         * gtk/jhbuildrc:
1797
1798 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1799
1800         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1801         https://bugs.webkit.org/show_bug.cgi?id=113386
1802
1803         Reviewed by Carlos Garcia Campos.
1804
1805         * Scripts/webkitdirs.pm:
1806         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1807         version to 3.0. Reflect this change so the builtDylibPathForName
1808         function doesn't fail to report the library as found.
1809
1810 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1811
1812         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1813         https://bugs.webkit.org/show_bug.cgi?id=113484
1814
1815         Unreviewed build fix.
1816
1817         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1818
1819         * TestWebKitAPI/CMakeLists.txt:
1820         * WebKitTestRunner/CMakeLists.txt:
1821
1822 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1823
1824         Revision for the internal jhbuild is too old
1825         https://bugs.webkit.org/show_bug.cgi?id=113324
1826
1827         Reviewed by Martin Robinson.
1828
1829         Update the minimum required version to a point where jhbuild won't
1830         fail installing packages when trying to remove a symlink to a directory.
1831
1832         * jhbuild/jhbuild-wrapper: Updated revision.
1833
1834 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1835
1836         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1837         https://bugs.webkit.org/show_bug.cgi?id=113203
1838
1839         Reviewed by Philippe Normand.
1840
1841         We build our libsoup without GNOME support. gst-plugins-good does separate
1842         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1843         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1844         build failures as the headers of those diverge. We do not use souphttpsrc, so
1845         disable it when building gst-plugins-good.
1846
1847         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1848
1849 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1850
1851         Build fix after r146852. Please another reference to the Lion leaks builder.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/config.json:
1854
1855 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1856
1857         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1858         https://bugs.webkit.org/show_bug.cgi?id=113421
1859
1860         Reviewed by Dirk Pranke.
1861
1862         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1863         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1864         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1865         in the GTK-specific TestExpectations files.
1866
1867         To avoid this only enable the warnings only when not using WKTR.
1868
1869         * Scripts/webkitpy/layout_tests/port/gtk.py:
1870         (GtkPort.warn_if_bug_missing_in_test_expectations):
1871
1872 2013-03-27  Antti Koivisto  <antti@apple.com>
1873
1874         Fix Zalan's email.
1875
1876         * Scripts/webkitpy/common/config/committers.py:
1877
1878 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1879
1880         master.cfg cleanup
1881         https://bugs.webkit.org/show_bug.cgi?id=113195
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         * BuildSlaveSupport/build.webkit.org-config/config.json:
1886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1887
1888 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1889
1890         master.cfg fine-tuning for Qt Mountain Lion Release bot
1891         https://bugs.webkit.org/show_bug.cgi?id=113191
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         * BuildSlaveSupport/build.webkit.org-config/config.json:
1896           - Rename the slave due to its location change.
1897           - Update the platform of the slave.
1898         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1899         (RunQtAPITests): Enable running WK2 API tests on Qt.
1900         (RunQtAPITests.start):
1901         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1902         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1903
1904 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1905
1906         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1907         https://bugs.webkit.org/show_bug.cgi?id=113403
1908
1909         Reviewed by Kenneth Rohde Christiansen.
1910
1911         As of Evas 1.7.5, when Wayland is detected on the system, support for
1912         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1913         The code, however, seems to depend on a few other flags which must be
1914         explicitly enabled.
1915
1916         If those additional GL-related options are passed, we end up
1917         having issues on the WebKit side, so disable Wayland support for
1918         now.
1919
1920         * efl/jhbuild.modules:
1921
1922 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1923
1924         Unreviewed, rolling out r146864.
1925         http://trac.webkit.org/changeset/146864
1926         https://bugs.webkit.org/show_bug.cgi?id=113391
1927
1928         causes crashes on Wk2 EFL release bot (Requested by drott on
1929         #webkit).
1930
1931         * Scripts/webkitperl/FeatureList.pm:
1932
1933 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1934
1935         [jhbuild] Correctly specify an alternate number of make jobs.
1936         https://bugs.webkit.org/show_bug.cgi?id=113396
1937
1938         Reviewed by Philippe Normand.
1939
1940         So far, we were using the `MAKEFLAGS' environment variable to pass the
1941         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1942         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1943
1944         We now behave more closely to the rest of the WebKit tools by first
1945         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1946         not set, just letting jhbuild itself figure out how many jobs to use.
1947
1948         * efl/jhbuildrc:
1949         * gtk/jhbuildrc:
1950
1951 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1952
1953         [Qt] Remove Qt specific WorkQueueItem definitions.
1954         https://bugs.webkit.org/show_bug.cgi?id=112891
1955
1956         This patch is preparation work for removing
1957         WorkQueue related code from TestRunnerQt and
1958         replacing it with generic TestRunner code.
1959
1960         Reviewed by Benjamin Poulain.
1961
1962         * DumpRenderTree/qt/TestRunnerQt.cpp:
1963         (TestRunnerQt::queueBackNavigation):
1964         (TestRunnerQt::queueForwardNavigation):
1965         (TestRunnerQt::queueLoadHTMLString):
1966         (TestRunnerQt::queueReload):
1967         (TestRunnerQt::queueLoadingScript):
1968         (TestRunnerQt::queueNonLoadingScript):
1969         (TestRunner::queueLoad):
1970         * DumpRenderTree/qt/TestRunnerQt.h:
1971         (TestRunnerQt):
1972         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1973         (LoadItem::invoke):
1974         (LoadHTMLStringItem::invoke):
1975         (LoadAlternateHTMLStringItem::invoke):
1976         (ReloadItem::invoke):
1977         (ScriptItem::invoke):
1978         (BackForwardItem::invoke):
1979         * DumpRenderTree/qt/WorkQueueItemQt.h:
1980         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1981         (LoadAlternateHTMLStringItem):
1982
1983 2013-03-26  Julie Parent  <jparent@chromium.org>
1984
1985         Flakiness dashboard: simplify logic around which tests to show.
1986         https://bugs.webkit.org/show_bug.cgi?id=113250
1987
1988         Reviewed by Ojan Vafai.
1989         
1990         The different filters for showing results are only used for layout
1991         tests, otherwise, we show everything.
1992         
1993         Change the defaults to false (what layout tests used), and only
1994         look at the values when viewing layout tests.
1995
1996         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1997         (htmlForTestsWithExpectationsButNoFailures):
1998         (shouldHideTest):
1999
2000 2013-03-26  Isaac Levy  <ilevy@google.com>
2001
2002         Update bots on test-results.appspot
2003         https://bugs.webkit.org/show_bug.cgi?id=113333
2004
2005         Reviewed by Ojan Vafai.
2006
2007         * TestResultServer/static-dashboards/builders.jsonp:
2008
2009 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2010
2011         Unreviewed GTK gardening.
2012
2013         * Scripts/run-gtk-tests:
2014         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2015
2016 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2017
2018         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2019         https://bugs.webkit.org/show_bug.cgi?id=113287
2020
2021         Reviewed by Jocelyn Turcotte.
2022
2023         * Scripts/run-qtwebkit-tests:
2024         (Options.__init__):
2025
2026 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2027
2028         [EFL] Enable IndexedDB by default
2029         https://bugs.webkit.org/show_bug.cgi?id=107248
2030
2031         Reviewed by Laszlo Gombos.
2032
2033         * Scripts/webkitperl/FeatureList.pm:
2034         Enable IndexedDB by default on EFL.
2035
2036 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2037
2038         Sheriffbot should explain rollout failures in a human readable form.
2039         https://bugs.webkit.org/show_bug.cgi?id=107092
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2044
2045         * Scripts/webkitpy/tool/bot/irc_command.py:
2046         (Rollout._check_diff_failure):
2047         (Rollout.execute):
2048         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2049         (IRCCommandTest.test_rollout):
2050
2051 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2052
2053         Unreviewed GTK gardening.
2054
2055         * Scripts/run-gtk-tests:
2056         (TestRunner): Skipping a failing unit test after r146518.
2057
2058 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2059
2060         Remove Lion leaks builder
2061         https://bugs.webkit.org/show_bug.cgi?id=113252
2062
2063         Reviewed by Andreas Kling.
2064
2065         Removed.
2066
2067         * BuildSlaveSupport/build.webkit.org-config/config.json:
2068
2069 2013-03-25  Kent Tamura  <tkent@chromium.org>
2070
2071         Rename ENABLE_INPUT_TYPE_DATETIME
2072         https://bugs.webkit.org/show_bug.cgi?id=113254
2073
2074         Reviewed by Kentaro Hara.
2075
2076         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2077         Actually I'd like to remove the code, but we shouldn't remove it yet
2078         because we shipped products with it on some platforms.
2079
2080         * Scripts/webkitperl/FeatureList.pm:
2081         * qmake/mkspecs/features/features.pri:
2082
2083 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2084
2085         Remove one more line that was intended to be removed in r146657.
2086
2087         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2088         (summarize_results):
2089
2090 2013-03-25  Roger Fong  <roger_fong@apple.com>
2091
2092         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2093         Re-enable WinEWS tests.
2094
2095         * Scripts/webkitpy/common/config/ports.py:
2096         (WinPort.run_bindings_tests_command):
2097         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2098         (WinEWS):
2099
2100 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2101
2102         Unreviewed, rolling out r146793.
2103         http://trac.webkit.org/changeset/146793
2104         https://bugs.webkit.org/show_bug.cgi?id=113248
2105
2106         Fix did not work (Requested by rfong on #webkit).
2107
2108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2109         (WinEWS):
2110
2111 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2112
2113         REGRESSION(r146657): Test failures reported incorrectly
2114         https://bugs.webkit.org/show_bug.cgi?id=113223
2115
2116         Reviewed by Dirk Pranke.
2117
2118         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2119
2120         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2121         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2122
2123         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2124         (Manager.run):
2125
2126         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2127         (RunDetails.__init__):
2128         (summarize_results): Remove the line I intended to remove in r146657.
2129
2130         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2131         (logging_run): Return details instead of the exit code.
2132         (run_and_capture): Ditto.
2133
2134         (RunTest.test_full_results_html):
2135         (RunTest.test_hung_thread):
2136         (RunTest.test_no_tests_found):
2137         (RunTest.test_no_tests_found_2):
2138         (RunTest.test_repeat_each_iterations_num_tests):
2139         (RunTest.test_run_singly_actually_runs_tests):
2140         (RunTest.test_test_list):
2141         (RunTest.test_missing_and_unexpected_results):
2142         (RunTest.test_pixel_test_directories):
2143         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2144         (RunTest.test_crash_with_stderr):
2145         (RunTest.test_no_image_failure_with_image_diff):
2146         (RunTest.test_crash_log):
2147         (RunTest.test_exit_after_n_failures_upload):
2148         (RunTest.test_results_directory_absolute):
2149         (RunTest.test_results_directory_relative):
2150         (RunTest.test_retrying_and_flaky_tests):
2151         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2152         (RunTest.test_retrying_uses_retries_directory):
2153         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2154         (RunTest.test_output_diffs):
2155         (EndToEndTest.test_reftest_with_two_notrefs):
2156         (RebaselineTest.test_reset_results):
2157         (RebaselineTest.test_missing_results):
2158         (RebaselineTest.test_new_baseline):
2159
2160         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2161         (BuildBotPrinter.print_results):
2162         (BuildBotPrinter.print_unexpected_results):
2163         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2164         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2165
2166 2013-03-25  Julie Parent  <jparent@chromium.org>
2167
2168         Dashboard refactor: Move cross dashboard history related code into history.js.
2169         https://bugs.webkit.org/show_bug.cgi?id=113104
2170
2171         Reviewed by Ojan Vafai.
2172
2173         All functions relating to cross dashboard behavior move from being
2174         globals to methods on the history.History object. Names stay the same,
2175         except many are made private, ones that should have been constants now
2176         are, and the long standing TODO to change "currentState" to 
2177         dashboardSpecificState is done.
2178         
2179         We now create a global history object in dashboard_base, as an 
2180         intermediate measure.  Once the dashboard specific code is
2181         added to history, each DB will need to create its own, and this
2182         global will be eliminated.
2183         
2184         * TestResultServer/static-dashboards/aggregate_results.js:
2185         (handleValidHashParameter):
2186         (htmlForBuilder):
2187         (rawValuesHTML):
2188         * TestResultServer/static-dashboards/dashboard_base.js:
2189         (parseDashboardSpecificParameters):
2190         (defaultValue):
2191         (currentBuilderGroupCategory):
2192         (currentBuilderGroupName):
2193         (handleLocationChange):
2194         (expectationsMap):
2195         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2196         (generatePage):
2197         (.switch.return):
2198         (platformAndBuildType):
2199         (individualTests):
2200         (substringList):
2201         (processMissingAndExtraExpectations):
2202         (pathToFailureLog):
2203         (showPopupForBuild):
2204         (htmlForTestsWithExpectationsButNoFailures):
2205         (shouldHideTest):
2206         (isCrossBuilderView):
2207         (tableHeaders):
2208         (htmlForSingleTestRow):
2209         (htmlForTableColumnHeader):
2210         (generatePageForExpectationsUpdate):
2211         (handleUpdate):
2212         (nextUpdate):
2213         (setUpdateIndex):
2214         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2215         (.appendExpectationsItem):
2216         (loadExpectations):
2217         (.dummyNode.onload):
2218         (loadExpectationsLayoutTests):
2219         (appendExpectations):
2220         (htmlForNavBar):
2221         (checkBoxToToggleState):
2222         (linkHTMLToToggleState):
2223         (generatePageForBuilder):
2224         (isInvalidKeyForCrossBuilderView):
2225         (handleQueryParameterChange):
2226         (showLegend):
2227         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2228         (resetGlobals):
2229         (test):
2230         * TestResultServer/static-dashboards/history.js:
2231         (.):
2232         * TestResultServer/static-dashboards/history_unittests.js:
2233         * TestResultServer/static-dashboards/loader.js:
2234         (.):
2235         * TestResultServer/static-dashboards/loader_unittests.js:
2236         * TestResultServer/static-dashboards/timeline_explorer.js:
2237         (generatePage):
2238         (initCurrentBuilderTestResults):
2239         (selectBuild):
2240         (showResultsDelta):
2241         * TestResultServer/static-dashboards/treemap.js:
2242         (generatePage):
2243         (.switch.return):
2244         (handleFocus):
2245         * TestResultServer/static-dashboards/ui.js:
2246
2247 2013-03-25  Roger Fong  <roger_fong@apple.com>
2248
2249         Unreviewed. Enable WinEWS tests again.
2250
2251         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2252         (WinEWS):
2253
2254 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2255
2256         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2257         https://bugs.webkit.org/show_bug.cgi?id=112166
2258
2259         HarfBuzz 0.9.14 merged my patch for icu detection without
2260         pkg-config files, as needed by for example Ubuntu 12.04.
2261         This obsoletes our local workaround. Removed it for GTK and EFL.
2262
2263         Reviewed by Martin Robinson.
2264
2265         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2266         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2267         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2268         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2269
2270 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2271
2272         Unreviewed.  Move self from contributor to committer list.
2273
2274         * Scripts/webkitpy/common/config/committers.py:
2275
2276 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2277
2278         EWS should use a human readable port name when uploading layout test archives
2279         https://bugs.webkit.org/show_bug.cgi?id=113099
2280
2281         Reviewed by Dirk Pranke.
2282
2283         Use new port's object's name() method to report human readable port names.
2284         This will also help us resolving the bug to apply layout test results posted by EWS.
2285
2286         * Scripts/webkitpy/tool/bot/botinfo.py:
2287         (BotInfo.__init__): Take port's name.
2288         (BotInfo.summary_text):
2289
2290         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2291         (BotInfoTest.test_summary_text):
2292
2293         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2294         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2295
2296         * Scripts/webkitpy/tool/commands/queues.py:
2297         (PatchProcessingQueue.__init__): Initialize self._port.
2298         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2299         and use that for the attachment filename and the comment posted.
2300
2301         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2302         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2303         "mac-snowleopard" as expected for TestPort.
2304
2305 2013-03-22  Roger Fong  <roger_fong@apple.com>
2306
2307         Unreviewed. Turn off EWS test on Win again.
2308         The battle continues.
2309
2310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2311         (WinEWS):
2312
2313 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2314
2315         NRWT: Enable pixel tests when retrying tests
2316         https://bugs.webkit.org/show_bug.cgi?id=112898
2317
2318         Reviewed by Dirk Pranke.
2319
2320         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2321         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2322         if we've forced pixel tests in the retry.
2323         (Manager._run_tests):
2324         (Manager._clean_up_run): Fixed the capitalizations.
2325         (Manager._force_pixel_tests_if_needed): Added.
2326
2327         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2328         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2329         'image_diff_percent' if it doesn't already exist.
2330
2331         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2332         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2333         treat this as a regular regression instead of a flakiness.
2334
2335         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2336         run had image diffs.
2337
2338         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2339         (summarized_results):
2340
2341         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2342         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2343         Also removed some dead code.
2344
2345         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2346         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2347         is set and pixel_tests_enabled is set to false.
2348         (EndToEndTest.test_reftest_with_two_notrefs):
2349
2350 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2351
2352         Make it possible to run layout tests on Retina MBP
2353         https://bugs.webkit.org/show_bug.cgi?id=93673
2354
2355         Reviewed by Ryosuke Niwa.
2356
2357         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2358         windows on 2x machines still run at 1x.
2359
2360         * DumpRenderTree/mac/DumpRenderTree.mm:
2361         (createWebViewAndOffscreenWindow):
2362         Reset the window resolution to 1x on creation.
2363         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2364         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2365         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2366         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2367         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2368         (WTR::PlatformWebView::PlatformWebView):
2369         Add NSWindow details, reset the window resolution to 1x on creation.
2370
2371 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2372
2373         Leak bots shouldn't build
2374         https://bugs.webkit.org/show_bug.cgi?id=112774
2375
2376         Reviewed by Simon Fraser.
2377
2378         Since leak bots use regular debug builds, there is no need to build on these bots.
2379         Simply downloading builds will dramatically improve the cycle time of these bots.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/config.json:
2382         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2383         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2384         TestFactory instead of BuildAndTestFactory.
2385
2386 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2387
2388         [Qt] Fix the TestWebKitAPI build
2389         https://bugs.webkit.org/show_bug.cgi?id=113044
2390
2391         Reviewed by Tor Arne Vestbø.
2392
2393         The generate-forwarding-headers script would only be run
2394         after the targets in InjectedBundle.pri since the second
2395         addStrictSubdirOrderBetween call in
2396         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2397         the derived_sources -> injected_bundle order in SUBDIRS.
2398
2399         Fix it by only moving the dependent target at the end of
2400         SUBDIRS, don't touch its dependency.
2401
2402         * qmake/mkspecs/features/functions.prf:
2403
2404 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2405
2406         [EFL][WK2] View is not focused when fullscreen mode toggled
2407         https://bugs.webkit.org/show_bug.cgi?id=113009
2408
2409         Reviewed by Laszlo Gombos.
2410
2411         Set focus on view when fullscreen mode enabled/disabled
2412         by FullScreen API.
2413
2414         * MiniBrowser/efl/main.c:
2415         (on_fullscreen_accept):
2416         (on_fullscreen_deny):
2417
2418 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2419
2420         nrwt is no longer saving retry results in the retries/ subdirectory
2421         https://bugs.webkit.org/show_bug.cgi?id=112995
2422
2423         Reviewed by Ojan Vafai.
2424
2425         I think this has been broken a long time, unfortunately. This
2426         patch should fix that.
2427
2428         In order to do so, I had to pass the directory to use from
2429         the Worker object through the SingleTestWriter to the
2430         TestResultWriter. While I was plumbing that through, I rationalized
2431         the order of the parameter arguments a bit ...
2432
2433         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2434         (Worker._run_single_test):
2435         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2436         (run_single_test):
2437         (SingleTestRunner.__init__):
2438         (SingleTestRunner._run_compare_test):
2439         (SingleTestRunner._run_rebaseline):
2440         (SingleTestRunner._run_reftest):
2441         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2442         (write_test_result):
2443         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2444         (TestResultWriterTest.test_reftest_diff_image):
2445         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2446         (RunTest.test_retrying_uses_retries_directory):
2447
2448 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2449
2450         JSC profiler should have an at-a-glance report of the success of DFG optimization
2451         https://bugs.webkit.org/show_bug.cgi?id=112988
2452
2453         Reviewed by Geoffrey Garen.
2454
2455         * Scripts/display-profiler-output:
2456
2457 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2458
2459         [chromium] Linux ASAN WebKit canary is running out of memory
2460         https://bugs.webkit.org/show_bug.cgi?id=112978
2461
2462         Reviewed by Tony Chang.
2463
2464         Running the AddressSanitizer on a crash takes a lot of
2465         memory, so we should serialize access to it to avoid running
2466         out of memory on a machine.
2467
2468         * Scripts/webkitpy/layout_tests/port/chromium.py:
2469         (ChromiumPort._get_crash_log):
2470         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2471         (HttpLock.__init__):
2472         (HttpLock.wait_for_httpd_lock):
2473
2474 2013-03-21  Min Qin  <qinmin@chromium.org>
2475
2476         Cleanup android media layout test code
2477         https://bugs.webkit.org/show_bug.cgi?id=112944
2478
2479         Reviewed by Adam Barth.
2480
2481         Chromium change: https://codereview.chromium.org/12892010/
2482         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2483         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2484         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2485         Instead, we should switch to use content shell for layout tests.
2486
2487         * DumpRenderTree/chromium/TestShell.cpp:
2488         (TestShell::resetTestController):
2489
2490 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2491
2492         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2493         https://bugs.webkit.org/show_bug.cgi?id=112953
2494
2495         Reviewed by Tony Chang.
2496
2497         When I created the DumpRenderTree_resources target in r144863 I
2498         forgot to declare the needed dependencies on the other resource
2499         targets. Due to a quirk of ordering, this appears to have been fine
2500         w/ ninja but not w/ Xcode (which is still being used on the chromium
2501         mac valgrind bots). Declaring the dependencies fixes the build
2502         failures.
2503
2504         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2505
2506 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2507
2508         [WinCairo] Correct assert in Empty BitmapImage Test.
2509         https://bugs.webkit.org/show_bug.cgi?id=112934
2510
2511         Reviewed by Tim Horton.
2512
2513         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2514         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2515         to avoid ref counting assertion when leaving test scope.
2516
2517 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2518
2519         [GTK] generate-feature-defines-files is incompatible with Python3
2520         https://bugs.webkit.org/show_bug.cgi?id=112956
2521
2522         Reviewed by Martin Robinson.
2523
2524         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2525         method on the dictionary objects when iterating through said dictionaries.
2526
2527         * gtk/generate-feature-defines-files:
2528         (write_feature_defines_header):
2529         (write_flattened_feature_defines_file):
2530
2531 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2532
2533         kill-old-processes spits out error messages on Mac
2534         https://bugs.webkit.org/show_bug.cgi?id=112878
2535
2536         Reviewed by Jessie Berlin.
2537
2538         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2539         included in the list of options grep --help shows.
2540
2541         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2542
2543         * BuildSlaveSupport/kill-old-processes:
2544         (main):
2545
2546 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2547
2548         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2549         https://bugs.webkit.org/show_bug.cgi?id=112597
2550
2551         Reviewed by Xan Lopez.
2552
2553         These were introduced for the Chromium port in r105295. We need
2554         dummy implementations in order to compile the BlackBerry port.
2555
2556         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2557         (AccessibilityUIElement::scrollToMakeVisible):
2558         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2559         (AccessibilityUIElement::scrollToGlobalPoint):
2560
2561 2013-03-21  Roger Fong  <roger_fong@apple.com>
2562
2563         Re-enable WinEWS tests following r146376.
2564
2565         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2566         (WinEWS):
2567
2568 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2569
2570         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2571
2572         * Scripts/webkitpy/common/config/committers.py:
2573
2574 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2575
2576         [GTK] Missing atk in install-dependencies script
2577         https://bugs.webkit.org/show_bug.cgi?id=112272
2578
2579         Reviewed by Gustavo Noronha Silva.
2580
2581         * gtk/install-dependencies: Add missing atk dependency.
2582
2583 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2584
2585         [GTK] Missing backslash in install-dependencies script
2586         https://bugs.webkit.org/show_bug.cgi?id=112907
2587
2588         Reviewed by Philippe Normand.
2589
2590         * gtk/install-dependencies: Add missing backslash to dependencies
2591         list.
2592
2593 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2594
2595         EWS bots have stopped uploading results to bugzilla
2596         https://bugs.webkit.org/show_bug.cgi?id=101091
2597
2598         Reviewed by Adam Barth.
2599
2600         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2601         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2602         this relative file path resoled to a file inside a non-existent directory for "zip".
2603
2604         Fixed the bug by resolving both test results directory and zip archive paths in
2605         LayoutTestResultsReader.archive.
2606
2607         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2608         in the future.
2609
2610         * Scripts/webkitpy/common/system/filesystem_mock.py:
2611         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2612
2613         * Scripts/webkitpy/common/system/workspace.py:
2614         (Workspace.create_zip): Log the source path when "zip" failed.
2615
2616         * Scripts/webkitpy/common/system/workspace_mock.py:
2617         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2618
2619         * Scripts/webkitpy/common/system/workspace_unittest.py:
2620         (WorkspaceTest.test_create_zip_exception): Test that.
2621
2622         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2623         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2624         This is the actual bug fix.
2625
2626         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2627         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2628
2629 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2630
2631         [chromium] move WebThemeEngine implementations to TestRunner library
2632         https://bugs.webkit.org/show_bug.cgi?id=112751
2633
2634         Reviewed by Adam Barth.
2635
2636         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2637         * DumpRenderTree/DumpRenderTree.gypi:
2638         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2639         (WebKit):
2640         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2641         (WebTestRunner::TestInterfaces::themeEngine):
2642         (WebTestRunner):
2643         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2644         (WebKit):
2645         (TestInterfaces):
2646         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2647         (WebTestRunner::WebTestInterfaces::themeEngine):
2648         (WebTestRunner):
2649         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2650         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2651         (WebTestRunner):
2652         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2653         (WebTestRunner::WebTestThemeControlWin::box):
2654         (WebTestRunner::WebTestThemeControlWin::line):
2655         (WebTestRunner::WebTestThemeControlWin::triangle):
2656         (WebTestRunner::WebTestThemeControlWin::roundRect):
2657         (WebTestRunner::WebTestThemeControlWin::oval):
2658         (WebTestRunner::WebTestThemeControlWin::circle):
2659         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2660         (WebTestRunner::WebTestThemeControlWin::markState):
2661         (WebTestRunner::WebTestThemeControlWin::draw):
2662         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2663         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2664         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2665         (WebTestRunner):
2666         (WebTestThemeControlWin):
2667         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2668         (WebTestRunner):
2669         (WebTestThemeEngineMac):
2670         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2671         (+[FakeActiveWindow alwaysActiveWindow]):
2672         (+[FakeActiveWindow alwaysInactiveWindow]):
2673         (-[FakeActiveWindow initWithActiveControls:]):
2674         (-[FakeActiveWindow _hasActiveControls]):
2675         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2676         (WebTestRunner):
2677         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2678         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2679         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2680         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2681         (WebTestRunner):
2682         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2683         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2684         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2685         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2686         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2687         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2688         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2689         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2690         (WebTestRunner::WebTestThemeEngineWin::getSize):
2691         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2692         (WebTestRunner):
2693         (WebTestThemeEngineWin):
2694         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2695         * DumpRenderTree/chromium/TestShell.cpp:
2696         (TestShell::initialize):
2697         * DumpRenderTree/chromium/TestShell.h:
2698         (WebKit):
2699         * DumpRenderTree/chromium/TestShellMac.mm:
2700         (platformInit):
2701         * DumpRenderTree/chromium/TestShellWin.cpp:
2702         (platformInit):
2703         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2704
2705 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2706
2707         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2708
2709         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2710         New property sheet that does not link against CoreFoundation and
2711         CFNetwork.
2712         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2713         Use new TestWebKitAPICommonWinCairo property sheet.
2714         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2715         Ditto.
2716
2717 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2718
2719         [WinCairo] Unreviewed build fix for VS2010.
2720
2721         Had to add WinCairo-specific property sheets to deal with some
2722         library and path differences with the main Apple port.
2723
2724         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2725         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2726         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2727         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2728         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2729         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2730
2731 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2732
2733         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2734         https://bugs.webkit.org/show_bug.cgi?id=112849
2735
2736         Reviewed by Sam Weinig.
2737
2738         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2739         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2740         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2741
2742 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2743
2744         [WinCairo] Build WebKit Tools under VS2010
2745         https://bugs.webkit.org/show_bug.cgi?id=112821
2746
2747         Reviewed by Tim Horton.
2748
2749         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2750         Add WinCairo-specific build target.
2751         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2752         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2753         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2754         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2755         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2756         Add WinCairo-specific build target.
2757         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2758         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2759         Add WinCairo-specific build target.
2760         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2761         WinCairo-specific build target.
2762         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2763         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2764         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2765         specific build target.
2766         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2767         WinCairo-specific build target.
2768         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2769         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2770         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2771
2772 2013-03-20  Roger Fong  <roger_fong@apple.com>
2773
2774         API test gardening AppleWin port.
2775
2776         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2777
2778         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2779         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2780
2781 2013-03-20  Roger Fong  <roger_fong@apple.com>
2782
2783         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2784
2785         * EWSTools/start-queue-win.sh:
2786
2787 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2788
2789         Unreviewed, add myself to committers.py.
2790
2791 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2792
2793         Unreviewed. Adding another email for me.
2794
2795         * Scripts/webkitpy/common/config/committers.py:
2796
2797 2013-03-20  Justin Novosad  <junov@google.com>
2798
2799         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2800         https://bugs.webkit.org/show_bug.cgi?id=112605
2801
2802         Reviewed by James Robinson.
2803
2804         Deleting all the code that was used for propagating and supporting
2805         the Chromium setting for disabling deferred 2d canvas rendering.
2806
2807         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2808         (main):
2809         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2810         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2811         (WebTestRunner::WebPreferences::reset):
2812         (WebTestRunner::WebPreferences::applyTo):
2813         * DumpRenderTree/chromium/TestShell.cpp:
2814         (TestShell::TestShell):
2815         (TestShell::resetWebSettings):
2816         (TestShell::runFileTest):
2817         * DumpRenderTree/chromium/TestShell.h:
2818         (TestShell):
2819
2820 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2821
2822         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2823         https://bugs.webkit.org/show_bug.cgi?id=112699.
2824
2825         Reviewed by Adam Barth.
2826
2827         * Scripts/webkitpy/layout_tests/port/qt.py:
2828         (QtPort._search_paths):
2829         (QtPort._port_specific_expectations_files):
2830         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2831         (QtPortTest):
2832         (QtPortTest._assert_search_path):
2833         (QtPortTest._assert_expectations_files):
2834
2835 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2836
2837         [Qt] Enable kerning by default
2838         https://bugs.webkit.org/show_bug.cgi?id=112704
2839
2840         Reviewed by Jocelyn Turcotte.
2841
2842         Disable kerning by default, since some reference test expectations
2843         expect kerning to be default off.
2844
2845         * DumpRenderTree/qt/TestRunnerQt.cpp:
2846         (TestRunnerQt::reset):
2847         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2848         (WTR::activateFonts):
2849
2850 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2851
2852         [Qt] Remove empty function stubs from TestRunnerQt.
2853         https://bugs.webkit.org/show_bug.cgi?id=112799
2854
2855         We are reducing the code in TestRunnerQt step by step,
2856         in order to finally replace all of it with the generic
2857         TestRunner implementation.
2858         This patch removes several simple function stubs that
2859         currently do not implement any actual functionality.
2860
2861         Reviewed by Kenneth Rohde Christiansen.
2862
2863         * DumpRenderTree/qt/TestRunnerQt.cpp:
2864         * DumpRenderTree/qt/TestRunnerQt.h:
2865         (TestRunnerQt):
2866
2867 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2868
2869         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2870         https://bugs.webkit.org/show_bug.cgi?id=112687
2871
2872         Reviewed by Kenneth Rohde Christiansen.
2873
2874         Hide the SearchBar by default on window creation.
2875
2876         * MiniBrowser/efl/main.c:
2877         (window_create):
2878
2879 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2880
2881         Unreviewed, rolling out r146304.
2882         http://trac.webkit.org/changeset/146304
2883         https://bugs.webkit.org/show_bug.cgi?id=112788
2884
2885         to many expectations to update (Requested by antonm on
2886         #webkit).
2887
2888         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2889         * DumpRenderTree/DumpRenderTree.gypi:
2890         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2891         (WebKit):
2892         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2893         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2894         (TestInterfaces):
2895         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2896         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2897         * DumpRenderTree/chromium/TestShell.cpp:
2898         (TestShell::initialize):
2899         * DumpRenderTree/chromium/TestShell.h:
2900         (WebKit):
2901         * DumpRenderTree/chromium/TestShellMac.mm:
2902         (platformInit):
2903         * DumpRenderTree/chromium/TestShellWin.cpp:
2904         (platformInit):
2905         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2906         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2907         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2908         (WebThemeControlDRTWin::box):
2909         (WebThemeControlDRTWin::line):
2910         (WebThemeControlDRTWin::triangle):
2911         (WebThemeControlDRTWin::roundRect):
2912         (WebThemeControlDRTWin::oval):
2913         (WebThemeControlDRTWin::circle):
2914         (WebThemeControlDRTWin::nestedBoxes):
2915         (WebThemeControlDRTWin::markState):
2916         (WebThemeControlDRTWin::draw):
2917         (WebThemeControlDRTWin::drawTextField):
2918         (WebThemeControlDRTWin::drawProgressBar):
2919         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2920         (WebThemeControlDRTWin):
2921         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2922         (WebThemeEngineDRTMac):
2923         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2924         (+[FakeActiveWindow alwaysActiveWindow]):
2925         (+[FakeActiveWindow alwaysInactiveWindow]):
2926         (-[FakeActiveWindow initWithActiveControls:]):
2927         (-[FakeActiveWindow _hasActiveControls]):
2928         (WebThemeEngineDRTMac::paintScrollbarThumb):
2929         (stateToHIEnableState):
2930         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2931         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2932         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2933         (webRectToSkIRect):
2934         (drawControl):
2935         (drawTextField):
2936         (drawProgressBar):
2937         (WebThemeEngineDRTWin::paintButton):
2938         (WebThemeEngineDRTWin::paintMenuList):
2939         (WebThemeEngineDRTWin::paintScrollbarArrow):
2940         (WebThemeEngineDRTWin::paintScrollbarThumb):
2941         (WebThemeEngineDRTWin::paintScrollbarTrack):
2942         (WebThemeEngineDRTWin::paintSpinButton):
2943         (WebThemeEngineDRTWin::paintTextField):
2944         (WebThemeEngineDRTWin::paintTrackbar):
2945         (WebThemeEngineDRTWin::paintProgressBar):
2946         (WebThemeEngineDRTWin::getSize):
2947         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2948         (WebThemeEngineDRTWin):
2949         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2950
2951 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2952
2953         [Qt] Support -webkit-font-smoothing
2954         https://bugs.webkit.org/show_bug.cgi?id=106009
2955
2956         Reviewed by Jocelyn Turcotte.
2957
2958         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2959
2960         * DumpRenderTree/qt/TestRunnerQt.cpp:
2961         (TestRunnerQt::reset):
2962
2963 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2964
2965         [GTK] accessibility/aria-scrollbar-role.html is failing
2966         https://bugs.webkit.org/show_bug.cgi?id=98358
2967
2968         Reviewed by Martin Robinson.
2969
2970         Adds support for checking accessibility object's orientation.
2971         Orientation is checked by retrieving proper state of accessibility object.
2972
2973         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2974         (checkElementState):
2975         (AccessibilityUIElement::orientation):
2976         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2977         (WTR::AccessibilityUIElement::orientation):
2978
2979 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2980
2981         [chromium] move WebThemeEngine implementations to TestRunner library
2982         https://bugs.webkit.org/show_bug.cgi?id=112751
2983
2984         Reviewed by Adam Barth.
2985
2986         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2987         * DumpRenderTree/DumpRenderTree.gypi:
2988         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2989         (WebKit):
2990         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2991         (WebTestRunner::TestInterfaces::themeEngine):
2992         (WebTestRunner):
2993         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2994         (WebKit):
2995         (TestInterfaces):
2996         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2997         (WebTestRunner::WebTestInterfaces::themeEngine):
2998         (WebTestRunner):
2999         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3000         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3001         (WebTestRunner):
3002         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3003         (WebTestRunner::WebTestThemeControlWin::box):
3004         (WebTestRunner::WebTestThemeControlWin::line):
3005         (WebTestRunner::WebTestThemeControlWin::triangle):
3006         (WebTestRunner::WebTestThemeControlWin::roundRect):
3007         (WebTestRunner::WebTestThemeControlWin::oval):
3008         (WebTestRunner::WebTestThemeControlWin::circle):
3009         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3010         (WebTestRunner::WebTestThemeControlWin::markState):
3011         (WebTestRunner::WebTestThemeControlWin::draw):
3012         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3013         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3014         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3015         (WebTestRunner):
3016         (WebTestThemeControlWin):
3017         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3018         (WebTestRunner):
3019         (WebTestThemeEngineMac):
3020         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3021         (+[FakeActiveWindow alwaysActiveWindow]):
3022         (+[FakeActiveWindow alwaysInactiveWindow]):
3023         (-[FakeActiveWindow initWithActiveControls:]):
3024         (-[FakeActiveWindow _hasActiveControls]):
3025         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3026         (WebTestRunner):
3027         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3028         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3029         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3030         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3031         (WebTestRunner):
3032         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3033         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3034         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3035         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3036         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3037         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3038         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3039         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3040         (WebTestRunner::WebTestThemeEngineWin::getSize):
3041         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3042         (WebTestRunner):
3043         (WebTestThemeEngineWin):
3044         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3045         * DumpRenderTree/chromium/TestShell.cpp:
3046         (TestShell::initialize):
3047         * DumpRenderTree/chromium/TestShell.h:
3048         (WebKit):
3049         * DumpRenderTree/chromium/TestShellMac.mm:
3050         (platformInit):
3051         * DumpRenderTree/chromium/TestShellWin.cpp:
3052         (platformInit):
3053         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3054
3055 2013-03-19  Tony Chang  <tony@chromium.org>
3056
3057         Move testRunner.setTouchDragDropEnabled to internals.settings
3058         https://bugs.webkit.org/show_bug.cgi?id=112739
3059
3060         Reviewed by Adam Barth.
3061
3062         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3063         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3064         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3065         (TestRunner): Remove unnecessary code.
3066         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3067         (WebTestRunner::WebPreferences::reset):
3068         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3069
3070 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3071
3072         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3073         https://bugs.webkit.org/show_bug.cgi?id=112754
3074
3075         Reviewed by Darin Fisher.
3076
3077         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3078         now that it's always defined.
3079
3080         * DumpRenderTree/chromium/WebViewHost.cpp:
3081         * DumpRenderTree/chromium/WebViewHost.h:
3082         (WebViewHost):
3083
3084 2013-03-19  Kenneth Russell  <kbr@google.com>
3085
3086         Unreviewed, rolling out r146290.
3087         http://trac.webkit.org/changeset/146290
3088         https://bugs.webkit.org/show_bug.cgi?id=112751
3089
3090         Broke Chromium Mac build.
3091
3092         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3093         * DumpRenderTree/DumpRenderTree.gypi:
3094         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3095         (WebKit):
3096         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3097         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3098         (TestInterfaces):
3099         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3100         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3101         * DumpRenderTree/chromium/TestShell.cpp:
3102         (TestShell::initialize):
3103         * DumpRenderTree/chromium/TestShell.h:
3104         (WebKit):
3105         * DumpRenderTree/chromium/TestShellMac.mm:
3106         (platformInit):
3107         * DumpRenderTree/chromium/TestShellWin.cpp:
3108         (platformInit):
3109         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3110         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3111         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3112         (WebThemeControlDRTWin::box):
3113         (WebThemeControlDRTWin::line):
3114         (WebThemeControlDRTWin::triangle):
3115         (WebThemeControlDRTWin::roundRect):
3116         (WebThemeControlDRTWin::oval):
3117         (WebThemeControlDRTWin::circle):
3118         (WebThemeControlDRTWin::nestedBoxes):
3119         (WebThemeControlDRTWin::markState):
3120         (WebThemeControlDRTWin::draw):
3121         (WebThemeControlDRTWin::drawTextField):
3122         (WebThemeControlDRTWin::drawProgressBar):
3123         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3124         (WebThemeControlDRTWin):
3125         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3126         (WebThemeEngineDRTMac):
3127         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3128         (+[FakeActiveWindow alwaysActiveWindow]):
3129         (+[FakeActiveWindow alwaysInactiveWindow]):
3130         (-[FakeActiveWindow initWithActiveControls:]):
3131         (-[FakeActiveWindow _hasActiveControls]):
3132         (WebThemeEngineDRTMac::paintScrollbarThumb):
3133         (stateToHIEnableState):
3134         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3135         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3136         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3137         (webRectToSkIRect):
3138         (drawControl):
3139         (drawTextField):
3140         (drawProgressBar):
3141         (WebThemeEngineDRTWin::paintButton):
3142         (WebThemeEngineDRTWin::paintMenuList):
3143         (WebThemeEngineDRTWin::paintScrollbarArrow):
3144         (WebThemeEngineDRTWin::paintScrollbarThumb):
3145         (WebThemeEngineDRTWin::paintScrollbarTrack):
3146         (WebThemeEngineDRTWin::paintSpinButton):
3147         (WebThemeEngineDRTWin::paintTextField):
3148         (WebThemeEngineDRTWin::paintTrackbar):
3149         (WebThemeEngineDRTWin::paintProgressBar):
3150         (WebThemeEngineDRTWin::getSize):
3151         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3152         (WebThemeEngineDRTWin):
3153         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3154
3155 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3156
3157         [EFL] canvas-fallback-content.html is failing
3158         https://bugs.webkit.org/show_bug.cgi?id=111998
3159
3160         Reviewed by Chris Fleizach.
3161
3162         Adds support for getting platform name.
3163
3164         * DumpRenderTree/TestRunner.cpp:
3165         (TestRunner::staticValues):
3166         * DumpRenderTree/TestRunner.h:
3167         (TestRunner):
3168         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3169         (TestRunner::platformName):
3170
3171 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3172
3173         [chromium] move WebThemeEngine implementations to TestRunner library
3174         https://bugs.webkit.org/show_bug.cgi?id=112751
3175
3176         Reviewed by Adam Barth.
3177
3178         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3179         * DumpRenderTree/DumpRenderTree.gypi:
3180         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3181         (WebKit):
3182         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3183         (WebTestRunner::TestInterfaces::themeEngine):
3184         (WebTestRunner):
3185         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3186         (WebKit):
3187         (TestInterfaces):
3188         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3189         (WebTestRunner::WebTestInterfaces::themeEngine):
3190         (WebTestRunner):
3191         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3192         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3193         (WebTestRunner):
3194         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3195         (WebTestRunner::WebTestThemeControlWin::box):
3196         (WebTestRunner::WebTestThemeControlWin::line):
3197         (WebTestRunner::WebTestThemeControlWin::triangle):
3198         (WebTestRunner::WebTestThemeControlWin::roundRect):
3199         (WebTestRunner::WebTestThemeControlWin::oval):
3200         (WebTestRunner::WebTestThemeControlWin::circle):
3201         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3202         (WebTestRunner::WebTestThemeControlWin::markState):
3203         (WebTestRunner::WebTestThemeControlWin::draw):
3204         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3205         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3206         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3207         (WebTestRunner):
3208         (WebTestThemeControlWin):
3209         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3210         (WebTestRunner):
3211         (WebTestThemeEngineMac):
3212         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3213         (+[FakeActiveWindow alwaysActiveWindow]):
3214         (+[FakeActiveWindow alwaysInactiveWindow]):
3215         (-[FakeActiveWindow initWithActiveControls:]):
3216         (-[FakeActiveWindow _hasActiveControls]):
3217         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3218         (WebTestRunner):
3219         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3220         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3221         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3222         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3223         (WebTestRunner):
3224         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3225         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3226         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3227         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3228         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3229         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3230         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3231         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3232         (WebTestRunner::WebTestThemeEngineWin::getSize):
3233         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3234         (WebTestRunner):
3235         (WebTestThemeEngineWin):
3236         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3237         * DumpRenderTree/chromium/TestShell.cpp:
3238         (TestShell::initialize):
3239         * DumpRenderTree/chromium/TestShell.h:
3240         (WebKit):
3241         * DumpRenderTree/chromium/TestShellMac.mm:
3242         (platformInit):
3243         * DumpRenderTree/chromium/TestShellWin.cpp:
3244         (platformInit):
3245         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3246
3247 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3248
3249         [EFL][WK2] Separate WebView further from EwkView
3250         https://bugs.webkit.org/show_bug.cgi?id=111591
3251
3252         Reviewed by Caio Marcelo de Oliveira Filho.
3253
3254         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3255         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3256         since we can afford it having EWKViewGetWKView() private API to access WKView.
3257
3258         * TestWebKitAPI/PlatformWebView.h:
3259         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3260         (TestWebKitAPI::TEST):
3261         * TestWebKitAPI/efl/PlatformWebView.cpp:
3262         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3263         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3264         (TestWebKitAPI::PlatformWebView::resizeTo):
3265         (TestWebKitAPI::PlatformWebView::page):
3266         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3267         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3268         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3269         * WebKitTestRunner/PlatformWebView.h:
3270         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3271         (WTR::EventSenderProxy::dispatchEvent):
3272         (WTR::EventSenderProxy::keyDown):
3273         (WTR::EventSenderProxy::sendTouchEvent):
3274         (WTR::EventSenderProxy::setTouchModifier):
3275         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3276         (WTR::PlatformWebView::PlatformWebView):
3277         (WTR::PlatformWebView::~PlatformWebView):
3278         (WTR::PlatformWebView::resizeTo):
3279         (WTR::PlatformWebView::page):
3280         (WTR::PlatformWebView::focus):
3281         (WTR::PlatformWebView::windowSnapshotImage):
3282
3283 2013-03-19  Roger Fong  <roger_fong@apple.com>
3284
3285         Changes to VS2010 project files should only trigger builds on Windows bots.
3286         https://bugs.webkit.org/show_bug.cgi?id=112731
3287
3288         Reviewed by Timothy Horton.
3289
3290         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3291         (_should_file_trigger_build):
3292
3293 2013-03-19  Roger Fong  <roger_fong@apple.com>
3294
3295         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3296
3297         * Scripts/webkitpy/tool/steps/runtests.py:
3298         (RunTests.run):
3299         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3300         (RunTestsTest.test_webkit_run_unit_tests):
3301
3302 2013-03-19  Julie Parent  <jparent@chromium.org>
3303
3304         Dashboards: Introduce history namespace and unit tests.
3305         https://bugs.webkit.org/show_bug.cgi?id=112645
3306
3307         Reviewed by Ojan Vafai.
3308         
3309         Laying the framework for introducing the new history object and
3310         namespace.  This moves only static functions into the history
3311         namespace, and moves corresponding unit tests into seperate
3312         unit test file.
3313
3314         * TestResultServer/static-dashboards/aggregate_results.html:
3315         * TestResultServer/static-dashboards/dashboard_base.js:
3316         (parseCrossDashboardParameters):
3317         (parseDashboardSpecificParameters):
3318         (parseParameters):
3319         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3320         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3321         (.switch.return):
3322         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3323         * TestResultServer/static-dashboards/history.js: Added.
3324         * TestResultServer/static-dashboards/history_unittests.js: Added.
3325         * TestResultServer/static-dashboards/loader.js:
3326         (.):
3327         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3328         * TestResultServer/static-dashboards/run-unittests.html:
3329         * TestResultServer/static-dashboards/timeline_explorer.html:
3330         * TestResultServer/static-dashboards/timeline_explorer.js:
3331         * TestResultServer/static-dashboards/treemap.html:
3332         * TestResultServer/static-dashboards/treemap.js:
3333         (.switch.return):
3334         * TestResultServer/static-dashboards/ui.js:
3335
3336 2013-03-19  Daniel Bates  <dbates@webkit.org>
3337
3338         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3339         https://bugs.webkit.org/show_bug.cgi?id=112732
3340
3341         Reviewed by Eric Seidel.
3342
3343         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3344         of an existing file cannot be applied.
3345
3346         In particular, svn-{apply, unapply} compensate for differences in line endings
3347         by converting the line endings in a diff to match the line endings in the target
3348         file. The diff(1) command precedes the last line of a diff that adds a newline
3349         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3350         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3351         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3352         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3353         the newline characters in this special character sequence to match the line endings
3354         in the target file.
3355
3356         * Scripts/VCSUtils.pm:
3357         (parseDiff):
3358         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3359         Added tests:
3360             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3361             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3362             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3363             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3364         (escapeNewLineCharacters): Added.
3365         (toMacLineEndings): Added.
3366
3367 2013-03-19  James Robinson  <jamesr@chromium.org>
3368
3369         [chromium] Remove compositor settings that don't go through WebKit
3370         https://bugs.webkit.org/show_bug.cgi?id=112718
3371
3372         Reviewed by Adam Barth.
3373
3374         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3375         (main):
3376         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3377         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3378         (WebTestRunner::WebPreferences::reset):
3379         (WebTestRunner::WebPreferences::applyTo):
3380         * DumpRenderTree/chromium/TestShell.cpp:
3381         (TestShell::TestShell):
3382         (TestShell::resetWebSettings):
3383         * DumpRenderTree/chromium/TestShell.h:
3384         (TestShell):
3385
3386 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3387
3388         Unreviewed, rolling out r146101.
3389         https://bugs.webkit.org/show_bug.cgi?id=111884
3390
3391         re-enable custom freetype on asan; this needs to be on
3392         now that the bot is running lucid.
3393
3394         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3395
3396 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3397
3398         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3399         https://bugs.webkit.org/show_bug.cgi?id=112365
3400
3401         Reviewed by Benjamin Poulain.
3402
3403         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3404         harcoding it in wtf/Platform.h
3405
3406         * Scripts/webkitperl/FeatureList.pm:
3407
3408 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3409
3410         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3411         https://bugs.webkit.org/show_bug.cgi?id=94782
3412
3413         Based on patch by Csaba Osztrogonác.
3414         Reviewed by Jocelyn Turcotte.
3415
3416         The diff image is generated with bright red indicating errors, but letting the base image
3417         shine through so the context of the error-pixel can be identified.
3418
3419         * DumpRenderTree/qt/ImageDiff.cpp:
3420         (main):
3421
3422 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3423
3424         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3425
3426         Rubber-stamped by Csaba Osztrogonác.
3427
3428         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3429         since the latter might not cover the former.
3430
3431         * QtTestBrowser/launcherwindow.cpp:
3432         (LauncherWindow::print):
3433
3434 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3435
3436         Style tweeks to default.css.
3437         
3438         Rubber-stamped by David Kilzer.
3439         
3440         Give visited links a different color to other links, so you can
3441         see which builds you've viewed.
3442         
3443         Make the <small> text less tiny.
3444
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3446         (small):
3447         (a:link,a:visited,a:active):
3448         (a:visited):
3449
3450 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3451
3452         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3453         https://bugs.webkit.org/show_bug.cgi?id=112494
3454
3455         Reviewed by Dirk Pranke.
3456
3457         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3458         Also merged two pairs of methods to cleanup the code.
3459
3460         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3461         (PerfTestsRunner.run): Merged _upload_and_show_results.
3462         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3463
3464 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3465
3466         [chromium] build xdisplaycheck when building DRT
3467         https://bugs.webkit.org/show_bug.cgi?id=112636
3468
3469         Reviewed by Tony Chang.
3470
3471         It appears that we need xdisplaycheck to be built in order for
3472         Xvfb to be started correctly on the bots, and DRT was missing
3473         a dependency on it. This may be the cause of the ASAN bot not
3474         starting up properly (it only builds DRT).
3475
3476         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3477
3478 2013-03-18  David Levin  <levin@chromium.org>
3479
3480         Implement icon change notification dump for Chromium's test shell.
3481         https://bugs.webkit.org/show_bug.cgi?id=112614
3482
3483         This was previously implemented for some other platforms in r58111
3484         and r116547.
3485
3486         In r122806, fast/dom/icon-url-property.html stopped using it, but
3487         it is useful for tests, so I plan to re-add it to that test again.
3488
3489         Reviewed by Jochen Eisinger.
3490
3491         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3492         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3493          icon change notifications from WebKit may be logged in test output.
3494         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3495         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3496         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3497         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3498         (WebTestRunner):
3499         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3500         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3501         (TestRunner):
3502         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3503         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3504         (WebTestRunner):
3505         * DumpRenderTree/chromium/WebViewHost.cpp:
3506         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3507         * DumpRenderTree/chromium/WebViewHost.h:
3508         (WebViewHost):
3509
3510 2013-03-18  Julie Parent  <jparent@chromium.org>
3511
3512         Cleanup: Move js for treemap and aggregate_results into own js files.
3513         https://bugs.webkit.org/show_bug.cgi?id=112618
3514
3515         Reviewed by Dirk Pranke.
3516         
3517         No functional changes, just moving the code into separate js file
3518         rather than inlined in the html, so we can test it, make it more
3519         modular, etc.  Other dashboard types are already done this way.
3520
3521         * TestResultServer/static-dashboards/aggregate_results.html:
3522         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3523         (generatePage):
3524         (handleValidHashParameter):
3525         (htmlForBuilder):
3526         (rawValuesHTML):
3527         (chartHTML):
3528         (filteredValues):
3529         (chart):
3530         (htmlForRevisionRows):
3531         (wrapHTMLInTable):
3532         (htmlForSummaryTable):
3533         (valuesPerExpectation):
3534         (htmlForTestType):
3535         (htmlForTableRow):
3536         (extendedEncode):
3537         * TestResultServer/static-dashboards/treemap.html:
3538         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3539         (humanReadableTime):
3540         (convertToWebTreemapFormat):
3541         (reverseSortByAverage):
3542         (generatePage):
3543         (focusPath):
3544         (.switch.return):
3545         (handleQueryParameterChange):
3546         (extractName):
3547         (fullName):
3548         (handleFocus.):
3549         (handleFocus):
3550
3551 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3552
3553         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3554         https://bugs.webkit.org/show_bug.cgi?id=112622
3555
3556         Reviewed by Dirk Pranke.
3557
3558         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3559         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3560
3561 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3562
3563         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3564         https://bugs.webkit.org/show_bug.cgi?id=112619
3565
3566         Reviewed by Dirk Pranke.
3567
3568         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3569         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3570
3571         * Scripts/webkitpy/layout_tests/port/gtk.py:
3572         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3573         Port._webkit_baseline_path method.
3574         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3575         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3576         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3577         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3578         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3579         that are expected based on the builder name.
3580
3581 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3582
3583         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3584         https://bugs.webkit.org/show_bug.cgi?id=112571
3585
3586         Reviewed by Adam Barth.
3587
3588         Update function declarations for new WebFileSystemType enum. (All
3589         changes are behind an #ifdef so we can sync required changes in embedders.)
3590
3591         * DumpRenderTree/chromium/WebViewHost.cpp:
3592         (WebViewHost::openFileSystem):
3593         (WebViewHost::deleteFileSystem):
3594         * DumpRenderTree/chromium/WebViewHost.h:
3595         (WebViewHost):
3596
3597 2013-03-18  Julie Parent  <jparent@chromium.org>
3598
3599         Cleanup: Move timeline_exporer js out of html file into js.
3600         https://bugs.webkit.org/show_bug.cgi?id=112188
3601
3602         Reviewed by Dirk Pranke.
3603         
3604         Moves the javascript out of the html file and into a new js file.
3605         This follows the format of flakiness_dashboard.{html|js}.
3606         
3607         Also moves code from dashboard_base that is used only by this one
3608         dashboard, and makes it private to the dashboard.
3609
3610         * TestResultServer/static-dashboards/dashboard_base.js:
3611         * TestResultServer/static-dashboards/timeline_explorer.html:
3612         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3613         (generatePage):
3614         (initCurrentBuilderTestResults):
3615         (shouldShowWebKitRevisionsOnly):
3616         (updateTimelineForBuilder.):
3617         (updateTimelineForBuilder):
3618         (selectBuild):
3619         (updateBuildIndicator):
3620         (.addRow):
3621         (.addNumberRow):
3622         (.inspectorNode.getElementsByTagName.0.onclick):
3623         (.inspectorNode.getElementsByTagName.1.onclick):
3624         (.inspectorNode.getElementsByTagName.2.onclick):
3625         (updateBuildInspector):
3626         (showResultsDelta):
3627         (decompressResults.addFlakyDelta):
3628         (decompressResults):
3629
3630 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3631
3632         Unreviewed, rolling out r145272.
3633         http://trac.webkit.org/changeset/145272
3634         https://bugs.webkit.org/show_bug.cgi?id=111884
3635
3636         Turns out the ASAN build is still broken; possibly there's
3637         something still setting LD_LIBRARY_PATH, or possibly there's
3638         something else wrong. In the meantime, we need it to work again.
3639
3640         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3641
3642 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3643
3644         delete-stale-build-files is too aggressive
3645         https://bugs.webkit.org/show_bug.cgi?id=112595
3646
3647         Reviewed by Tim Horton.
3648
3649         It appears that whitelisting file extensions to keep is not a good idea.