1 2011-06-14 Dirk Pranke <dpranke@chromium.org>
3 Reviewed by Tony Chang.
5 nrwt: handle worker exceptions cleanly
6 https://bugs.webkit.org/show_bug.cgi?id=62614
8 This change modifiers new-run-webkit-tests to handle exceptions
9 raised by worker threads better, by:
10 - capturing the worker's stack and logging it in the manager
11 - propagating the worker's exception in the caller correctly
12 - attempting to cancel the workers and clean up even when
13 we get an unexpected exception
15 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
16 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
17 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20 2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>
22 Reviewed by Laszlo Gombos.
24 [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
25 https://bugs.webkit.org/show_bug.cgi?id=62227
27 QtWebkit does not yet support different CacheModels. This change will
28 expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
30 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
31 (LayoutTestController::setCacheModel):
32 * DumpRenderTree/qt/LayoutTestControllerQt.h:
34 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
36 Reviewed by Andreas Kling.
38 [Qt] tst_QWebFrame::overloadedSlots() fails
39 https://bugs.webkit.org/show_bug.cgi?id=37319
41 Since we don't implictly convert 'document' object to QWebElement
42 in metacalls anymore, change the controller to expect QVariantMap instead.
44 The method plainText() was updated to use QVariantMap as well to let the bridge
45 do the conversion directly for us.
47 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
48 (LayoutTestController::nodesFromRect):
49 * DumpRenderTree/qt/LayoutTestControllerQt.h:
50 * DumpRenderTree/qt/PlainTextControllerQt.cpp:
51 (PlainTextController::plainText):
52 * DumpRenderTree/qt/PlainTextControllerQt.h:
54 2011-06-14 Andras Becsi <abecsi@webkit.org>
56 Reviewed by Csaba Osztrogonác.
58 Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
59 https://bugs.webkit.org/show_bug.cgi?id=62630
61 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
62 (NPP_New): remove dead variable 'forceCarbon'
64 2011-06-13 Hayato Ito <hayato@chromium.org>
66 Reviewed by Ojan Vafai.
68 [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
69 https://bugs.webkit.org/show_bug.cgi?id=59188
71 A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
72 WebKitDriver should always return an actual hash value if DRT returns that.
74 No tests since I'll add sample reftests to make sure mismatch reftests work later,
75 which should be in a separate patch.
77 * Scripts/webkitpy/layout_tests/port/webkit.py:
79 2011-06-13 Kent Tamura <tkent@chromium.org>
81 [Chromium-win] Fix two wrong assertions exposed by r88757.
83 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
84 (WebThemeEngineDRTWin::paintTrackbar):
86 2011-06-13 Alexey Proskuryakov <ap@apple.com>
88 Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
89 and commit queue happy.
91 * Scripts/webkitpy/common/config/committers.py:
93 2011-06-13 Chris Rogers <crogers@google.com>
97 Build fix to chromium DRT until we can rebaseline some tests
98 https://bugs.webkit.org/show_bug.cgi?id=62608
100 * DumpRenderTree/chromium/TestShell.cpp:
101 (TestShell::TestShell):
103 2011-06-13 Chris Rogers <crogers@google.com>
105 Reviewed by Dirk Pranke.
107 Add Web Audio support to chromium DRT
108 https://bugs.webkit.org/show_bug.cgi?id=62306
110 * DumpRenderTree/chromium/LayoutTestController.cpp:
111 (LayoutTestController::LayoutTestController):
112 (LayoutTestController::reset):
113 (LayoutTestController::setEncodedAudioData):
114 * DumpRenderTree/chromium/LayoutTestController.h:
115 (LayoutTestController::encodedAudioData):
116 (LayoutTestController::shouldDumpAsAudio):
117 (LayoutTestController::setShouldDumpAsAudio):
118 * DumpRenderTree/chromium/TestEventPrinter.cpp:
119 (DRTPrinter::handleAudioHeader):
120 (TestShellPrinter::handleAudioHeader):
121 * DumpRenderTree/chromium/TestEventPrinter.h:
122 * DumpRenderTree/chromium/TestShell.cpp:
123 (TestShell::TestShell):
126 2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
128 Reviewed by Eric Seidel.
130 [EFL] Add load error handler to EWebLauncher
131 https://bugs.webkit.org/show_bug.cgi?id=62347
133 Add a handler function of "load,error" to EWebLauncher.
134 EWebLauncher now displays a simple error page on load errors.
136 * EWebLauncher/main.c:
140 2011-06-13 Martin Robinson <mrobinson@igalia.com>
142 Reviewed by Eric Seidel.
144 [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
145 https://bugs.webkit.org/show_bug.cgi?id=62385
147 Remove duplicate TestNetscapePlugIn implementation. Having two copies
148 of this code makes keeping it in sync much more difficult. The files are
149 almost identical and this change ports the X11 changes to main.cpp.
151 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
152 (NPP_New): Do not set the plugin as windowless always. Doing this breaks
153 some results on Qt and this seems to be unnecessary for the moment.
154 (keyEventToChar): Added this helper which converts a X11 keycode into a char.
155 (handleEventX11): Use the handler to properly convert the keycode. Do not print
156 adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
157 it should not be in the results.
158 (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
159 XP_UNIX block is first by guarding against using a null instance.
160 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
161 the XP_UNIX define for Linux.
162 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
163 * GNUmakefile.am: Update source list.
165 2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
167 Unreviewed, rolling out r88671.
168 http://trac.webkit.org/changeset/88671
169 https://bugs.webkit.org/show_bug.cgi?id=62591
171 "didn't work" (Requested by dpranke on #webkit).
173 * Scripts/new-run-webkit-httpd:
174 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
175 * Scripts/webkitpy/layout_tests/port/http_server.py:
176 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
177 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
178 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
179 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
181 2011-06-13 Nate Chapin <japhet@chromium.org>
183 Reviewed by Darin Fisher.
185 New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
187 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
189 2011-06-13 Dirk Pranke <dpranke@chromium.org>
191 Reviewed by Tony Chang.
193 webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
194 https://bugs.webkit.org/show_bug.cgi?id=62251
196 shut_down_http_server() was a total hack that was only used by
197 new-run-webkit-httpd, so I've moved the code there and switched
198 to using executive.kill_process() for the common case. The
199 method itself will be removed in the patch on bug 59993.
201 * Scripts/new-run-webkit-httpd:
202 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
203 * Scripts/webkitpy/layout_tests/port/http_server.py:
204 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
205 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
207 2011-06-13 Tony Chang <tony@chromium.org>
209 Reviewed by Dimitri Glazkov.
211 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
212 https://bugs.webkit.org/show_bug.cgi?id=62578
214 * Scripts/build-webkit:
216 2011-06-13 Tony Chang <tony@chromium.org>
218 Reviewed by Adam Barth.
220 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
221 https://bugs.webkit.org/show_bug.cgi?id=62545
223 * Scripts/build-webkit:
225 2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
227 Reviewed by Martin Robinson.
229 [GTK] Export an API similar to WebKit1
230 https://bugs.webkit.org/show_bug.cgi?id=57820
232 Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
233 code, but linking to libwebkit2gtk.
236 * GtkLauncher/main.c:
240 2011-06-12 MORITA Hajime <morrita@google.com>
242 Unreviewed, rolling out r88625.
243 http://trac.webkit.org/changeset/88625
244 https://bugs.webkit.org/show_bug.cgi?id=61073
246 Breaks SL Webkit2 Tests
248 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
249 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
250 * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
251 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
252 (WTR::InjectedBundlePage::didClearWindowForFrame):
253 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
255 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
257 Reviewed by Antonio Gomes.
259 [Qt] LayoutTestController needs setTextDirection implementation
260 https://bugs.webkit.org/show_bug.cgi?id=62442
262 Implements LayoutController.setTextDirection.
264 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
265 (LayoutTestController::setTextDirection):
266 * DumpRenderTree/qt/LayoutTestControllerQt.h:
268 2011-06-12 Dominic Cooney <dominicc@chromium.org>
270 Reviewed by Hajime Morita.
272 Add window.internals to WebKit2's WebKitTestRunner.
273 https://bugs.webkit.org/show_bug.cgi?id=61073
275 Test: fast/harness/internals-object.html
277 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
278 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
279 * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
280 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
281 (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
282 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
284 2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
286 Unreviewed, rolling out r88616.
287 http://trac.webkit.org/changeset/88616
288 https://bugs.webkit.org/show_bug.cgi?id=62517
290 It broke editing/text-iterator/findString.html (Requested by
291 tonikitoo on #webkit).
293 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
294 * DumpRenderTree/qt/LayoutTestControllerQt.h:
296 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
298 Reviewed by Antonio Gomes.
300 [Qt] LayoutTestController needs setTextDirection implementation
301 https://bugs.webkit.org/show_bug.cgi?id=62442
303 Implements LayoutController.setTextDirection.
305 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
306 (LayoutTestController::setTextDirection):
307 * DumpRenderTree/qt/LayoutTestControllerQt.h:
309 2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
311 Reviewed by Ojan Vafai.
313 new-run-webkit-tests: 'images' links on results.html don't work
314 https://bugs.webkit.org/show_bug.cgi?id=62194
316 Use relative path when generating images-diffs.html
318 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
319 Added _output_testname.
321 2011-06-10 Lucas Forschler <lforschler@apple.com>
323 Reviewed by Stephanie Lewis.
325 Script to kill old processes on Mac.
326 This matches the windows version.
327 https://bugs.webkit.org/show_bug.cgi?id=62479
329 * BuildSlaveSupport/mac: Added.
330 * BuildSlaveSupport/mac/kill-old-processes: Added.
332 2011-06-10 Adam Barth <abarth@webkit.org>
334 Reviewed by James Robinson.
336 When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
337 https://bugs.webkit.org/show_bug.cgi?id=62489
339 * Scripts/webkitpy/tool/bot/sheriff.py:
340 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
342 2011-06-10 Tony Chang <tony@chromium.org>
344 Reviewed by Ojan Vafai.
346 add a compile guard ENABLE(FLEXBOX)
347 https://bugs.webkit.org/show_bug.cgi?id=62049
349 * Scripts/build-webkit:
351 2011-06-10 Mark Rowe <mrowe@apple.com>
353 Reviewed by Dimitri Glazkov.
355 <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
357 Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
360 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
361 * DumpRenderTree/mac/Configurations/Base.xcconfig:
363 2011-06-09 Csaba Osztrogonác <ossy@webkit.org>
365 Unreviewed rolling out r88471, because it broke plugin tests on Qt.
367 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
370 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
371 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
372 (webkit_test_plugin_new_instance):
373 (webkit_test_plugin_destroy_instance):
374 (webkit_test_plugin_set_window):
376 (webkit_test_plugin_new_stream):
377 (webkit_test_plugin_destroy_stream):
378 (webkit_test_plugin_stream_as_file):
379 (webkit_test_plugin_write_ready):
380 (webkit_test_plugin_write):
381 (webkit_test_plugin_print):
383 (webkit_test_plugin_handle_event):
384 (webkit_test_plugin_url_notify):
385 (webkit_test_plugin_get_value):
386 (webkit_test_plugin_set_value):
387 (NP_GetMIMEDescription):
393 2011-06-09 Martin Robinson <mrobinson@igalia.com>
395 Reviewed by Eric Seidel.
397 [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
398 https://bugs.webkit.org/show_bug.cgi?id=55603
400 Add callbacks to support hasMarkedText and markedRange and also clean up existing
401 TextInputController support.
403 * DumpRenderTree/gtk/TextInputController.cpp:
404 (setMarkedTextCallback): Accept parameters in terms of start and length, instead
405 of start and end. This matches the other ports. Do not use GLib style early returns.
406 (hasMarkedTextCallback): Added.
407 (markedRangeCallback): Added.
408 (insertTextCallback): Cleanup as described above.
409 (unmarkTextCallback): Cleanup as described above.
410 (firstRectForCharacterRangeCallback): Cleanup as described above.
411 (selectedRangeCallback): Cleanup as described above.
413 2011-06-09 Dirk Pranke <dpranke@chromium.org>
415 Reviewed by Tony Chang.
417 nrwt: support webaudio in chromium driver
418 https://bugs.webkit.org/show_bug.cgi?id=62226
420 * Scripts/webkitpy/layout_tests/port/chromium.py:
422 2011-06-09 Dan Bernstein <mitz@apple.com>
424 Reviewed by Anders Carlsson.
426 Added a test for Vector::reverse()
427 https://bugs.webkit.org/show_bug.cgi?id=62393
429 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430 * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
431 (TestWebKitAPI::TEST):
432 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
434 2011-06-09 Martin Robinson <mrobinson@igalia.com>
436 Reviewed by Andreas Kling.
438 [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
439 https://bugs.webkit.org/show_bug.cgi?id=62385
441 Remove duplicate TestNetscapePlugIn implementation. Having two copies
442 of this code makes keeping it in sync much more difficult. The files are
443 almost identical and this change ports the X11 changes to main.cpp.
445 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
446 (keyEventToChar): Added this helper which converts a X11 keycode into a char.
447 (handleEventX11): Use the handler to properly convert the keycode. Do not print
448 adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
449 it should not be in the results.
450 (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
451 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
452 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
453 * GNUmakefile.am: Update source list.
455 2011-06-09 Noel Gordon <noel.gordon@gmail.com>
457 Reviewed by Tony Chang.
459 Test plugin should support event logging on the windows port.
460 https://bugs.webkit.org/show_bug.cgi?id=61721
462 The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
463 calls to mean the plugin handled the event.
465 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
466 (handleEventWin): Return 0 for each event on windows.
468 2011-06-09 Chang Shu <cshu@webkit.org>
470 Reviewed by Andreas Kling.
472 [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
473 https://bugs.webkit.org/show_bug.cgi?id=62381
475 Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
476 QWKPagePrivate::isViewFocused() will check it later.
478 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
479 (WTR::PlatformWebView::PlatformWebView):
481 2011-06-09 Robert Hogan <robert@webkit.org>
483 Reviewed by Andreas Kling.
485 Teach Qt about window.internals
486 https://bugs.webkit.org/show_bug.cgi?id=61074
488 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
489 (WebCore::DumpRenderTree::initJSObjects):
491 2011-06-09 Eric Seidel <eric@webkit.org>
493 Reviewed by Adam Barth.
495 Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
496 https://bugs.webkit.org/show_bug.cgi?id=62362
498 The mac bots are failing inspector tests. We don't know why yet.
499 So for now, turning run-webkit-tests off for the mac-ews.
501 Also noticed that due to the wrong variable name the cr-linux
502 bots weren't running tests!
504 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
506 2011-06-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
508 Reviewed by Csaba Osztrogonac.
510 [Qt][WK2] Canvas tests make css2.1 ones failing
511 https://bugs.webkit.org/show_bug.cgi?id=53427
513 Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
514 Since the Qt port should eventually go to QRawFont, this issue will be resolved
515 in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
516 needed for the workaround.
518 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
519 (WTR::LayoutTestController::platformInitialize):
521 2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
523 Reviewed by Chris Fleizach.
525 [GTK] Provide a way in DRT to check the platform name
526 https://bugs.webkit.org/show_bug.cgi?id=56855
528 Patch for adding 'platformName' static property to DRT's
529 LayoutController and provide platform specific implementations.
531 In principle, this feature will be only of interest for writing
532 accessibility tests, so that's why it's only implemented in the
533 Mac, Gtk and Win platforms.
535 * DumpRenderTree/LayoutTestController.h: New method platformName().
536 * DumpRenderTree/LayoutTestController.cpp:
537 (getPlatformNameCallback): New callback for 'platformName'.
538 (LayoutTestController::staticValues): New static property.
540 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
541 (LayoutTestController::platformName): Implemented.
543 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
544 (LayoutTestController::platformName): Implemented.
546 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
547 (LayoutTestController::platformName): Implemented.
549 2011-06-08 Mike Lawther <mikelawther@chromium.org>
551 Reviewed by James Robinson.
553 Add mikelawther to committers.py
554 https://bugs.webkit.org/show_bug.cgi?id=62354
556 * Scripts/webkitpy/common/config/committers.py:
558 2011-06-08 Kent Tamura <tkent@chromium.org>
560 [Chromium] Fix a typo.
562 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
563 (WebThemeControlDRTWin::draw):
565 2011-06-08 Kent Tamura <tkent@chromium.org>
567 Reviewed by Hajime Morita.
569 [Chromium] Support vertical sliders in Windows DRT
570 https://bugs.webkit.org/show_bug.cgi?id=62352
572 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
573 (WebThemeControlDRTWin::draw):
574 Paint VerticalSliderThumbType and VerticalSliderTrackType.
575 * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
576 Add VerticalSliderTrackType and VerticalSliderThumbType.
577 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
578 (WebThemeEngineDRTWin::paintTrackbar):
579 Convert Windows identifiers to the internal identifiers for vertical sliders.
581 2011-06-08 Ojan Vafai <ojan@chromium.org>
583 Reviewed by Tony Chang.
585 add a short-flag for --experimental-fully-parallel
586 https://bugs.webkit.org/show_bug.cgi?id=62321
588 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
590 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
592 Reviewed by Tony Chang.
594 new-run-webkit-tests: don't turn the tree red when there are new passes
595 https://bugs.webkit.org/show_bug.cgi?id=62311
597 Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
598 to match commandComplete.
600 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
602 2011-06-08 Tom Hudson <tomhudson@google.com>
604 Reviewed by Mihai Parparita.
606 Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
607 https://bugs.webkit.org/show_bug.cgi?id=60964
609 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
610 Add 'Sort tests by metric' link.
611 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
612 (disableSorting): Activate 'Sort tests by metric' link.
613 (enableSorting): Deactivate 'Sort tests by metric' link.
614 (selectDirectory): Call enableSorting()/disableSorting() depending
615 on currently selected failure type, and sort tests if requested.
616 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
617 New .disabled-control class for deactivated links.
619 2011-06-08 Tom Sepez <tsepez@chromium.org>
621 Reviewed by Adam Barth.
623 Add web permissions callbacks for mixed content blocking.
624 https://bugs.webkit.org/show_bug.cgi?id=61946
626 * DumpRenderTree/chromium/LayoutTestController.cpp:
627 (LayoutTestController::setAllowDisplayOfInsecureContent):
628 (LayoutTestController::setAllowRunningOfInsecureContent):
629 (LayoutTestController::overridePreference):
630 * DumpRenderTree/chromium/WebPermissions.cpp:
631 (WebPermissions::allowDisplayingInsecureContent):
632 (WebPermissions::allowRunningInsecureContent):
633 (WebPermissions::setDisplayingInsecureContentAllowed):
634 (WebPermissions::setRunningInsecureContentAllowed):
635 (WebPermissions::reset):
636 * DumpRenderTree/chromium/WebPermissions.h:
638 2011-06-08 Dirk Pranke <dpranke@chromium.org>
640 Reviewed by Tony Chang.
642 webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
643 https://bugs.webkit.org/show_bug.cgi?id=62259
645 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
647 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
649 Reviewed by Tony Chang.
651 new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
652 https://bugs.webkit.org/show_bug.cgi?id=62303
654 Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
656 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
658 2011-06-08 Greg Simon <gregsimon@chromium.org>
660 Reviewed by Dimitri Glazkov.
662 Control Indexeddb backends from LayoutTestController
663 https://bugs.webkit.org/show_bug.cgi?id=61000
665 * DumpRenderTree/chromium/LayoutTestController.cpp:
666 (LayoutTestController::LayoutTestController):
667 (LayoutTestController::setOverrideIndexedDBBackingStore):
668 (LayoutTestController::clearAllDatabases):
669 * DumpRenderTree/chromium/LayoutTestController.h:
671 2011-06-08 Andreas Kling <kling@webkit.org>
673 Add Pierre Rossi to contributors list for EZ-CC.
675 * Scripts/webkitpy/common/config/committers.py:
677 2011-06-08 Ilya Sherman <isherman@chromium.org>
679 Reviewed by Andreas Kling.
681 Add Ilya Sherman to list of committers
682 https://bugs.webkit.org/show_bug.cgi?id=62270
684 * Scripts/webkitpy/common/config/committers.py:
686 2011-06-07 Ryosuke Niwa <rniwa@webkit.org>
688 Reviewed by Tony Chang.
690 new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
691 https://bugs.webkit.org/show_bug.cgi?id=62178
693 Added commandComplete and evaluateCommand for NewRunWebKitTests class
694 to parse new-run-webkit-tests' results.
696 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
698 2011-06-07 Dirk Pranke <dpranke@chromium.org>
700 Reviewed by Eric Seidel.
702 webkitpy: add a popen() call to executive
703 https://bugs.webkit.org/show_bug.cgi?id=62179
705 This change adds a popen() wrapper call to the Executive object.
706 This will allow other webkitpy scripts that currently call
707 subprocess directly to use Executive, instead.
709 No additional tests are necessary (the existing tests cover the code).
711 * Scripts/webkitpy/common/system/executive.py:
713 2011-06-07 Sam Weinig <sam@webkit.org>
715 Reviewed by Anders Carlsson.
717 Remove repeated IPC traffic from SetRenderTreeSize message
718 https://bugs.webkit.org/show_bug.cgi?id=62244
720 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
721 (WTR::InjectedBundlePage::InjectedBundlePage):
722 Add stub for didLayoutForFrame.
724 2011-06-07 Dirk Pranke <dpranke@chromium.org>
726 Reviewed by Tony Chang.
728 rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
729 https://bugs.webkit.org/show_bug.cgi?id=62241
731 * Scripts/webkitpy/layout_tests/port/chromium.py:
733 2011-06-07 Adam Barth <abarth@webkit.org>
735 Rubber-stamped by Eric Seidel.
737 Enable tests on the mac-ews
739 When we bring the mac-ews back up, we're going to try running tests!
741 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
743 2011-06-07 Dmitry Lomov <dslomov@google.com>
745 Reviewed by David Levin.
747 https://bugs.webkit.org/show_bug.cgi?id=62215
748 Allow comparisons with 0 in LIKELY and UNLIKELY macros.
750 * Scripts/webkitpy/style/checkers/cpp.py:
751 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
753 2011-06-07 Nico Weber <thakis@chromium.org>
755 Reviewed by Dimitri Glazkov.
757 [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
758 https://bugs.webkit.org/show_bug.cgi?id=62210
760 The change to TestEventPrinter fixes a latent bug, because
761 objects are deleted through the TestEventPrinter type, but none
762 of the subclasses have destructors or non-POD members.
764 The changes to NotificationPresenter and WebViewHost do _not_ to fix a
765 real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
766 discussed at http://codereview.chromium.org/7094005/, we prefer making
767 leaf class destructors virtual over making the leaf classes final.
769 * DumpRenderTree/chromium/NotificationPresenter.cpp:
770 (NotificationPresenter::~NotificationPresenter):
771 * DumpRenderTree/chromium/NotificationPresenter.h:
772 * DumpRenderTree/chromium/TestEventPrinter.cpp:
773 (TestEventPrinter::~TestEventPrinter):
774 * DumpRenderTree/chromium/TestEventPrinter.h:
775 * DumpRenderTree/chromium/WebViewHost.h:
777 2011-06-06 Ryosuke Niwa <rniwa@webkit.org>
779 Reviewed by Dirk Pranke.
781 [chromium] Chromium bots on build.webkit.org don't upload results.html
782 https://bugs.webkit.org/show_bug.cgi?id=61961
784 Don't fix the path on chromium port erroneously.
786 * BuildSlaveSupport/test-result-archive:
788 2011-06-06 Martin Robinson <mrobinson@igalia.com>
790 Fix the GTK+ build by ensuring that the autogenerated sources
791 necessary for libWebCoreInternals are recorded in a predeclared
792 variable before assigning to BUILT_SOURCES.
794 * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
796 2011-06-06 Yong Li <yoli@rim.com>
798 Reviewed by Eric Seidel.
800 https://bugs.webkit.org/show_bug.cgi?id=62097
801 Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
803 * Scripts/webkitpy/style/checkers/cpp.py:
804 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
806 2011-06-06 Xan Lopez <xlopez@igalia.com>
808 Reviewed by Martin Robinson.
810 [GTK] Enable feature/symbol detection in NWRT/GTK
811 https://bugs.webkit.org/show_bug.cgi?id=62136
813 Disable feature detection through DRT, since we don't support it,
814 and set the libwebcore patch correctly so that symbol detection
817 * Scripts/webkitpy/layout_tests/port/gtk.py:
819 2011-06-06 Shishir Agrawal <shishir@chromium.org>
821 Reviewed by Tony Gentilcore.
823 Add a "prerender" state for page visibility.
824 https://bugs.webkit.org/show_bug.cgi?id=62062
826 * DumpRenderTree/chromium/LayoutTestController.cpp:
827 (LayoutTestController::setPageVisibility):
829 2011-06-06 Csaba Osztrogonác <ossy@webkit.org>
831 [Qt] Implement download feature for QtTestBrowser
832 https://bugs.webkit.org/show_bug.cgi?id=61865
834 Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
836 * QtTestBrowser/launcherwindow.cpp:
837 (LauncherWindow::LauncherWindow):
838 * QtTestBrowser/launcherwindow.h:
840 2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
842 Reviewed by Csaba Osztrogonác.
844 [Qt] Implement download feature for QtTestBrowser
845 https://bugs.webkit.org/show_bug.cgi?id=61865
847 * QtTestBrowser/launcherwindow.cpp:
848 (LauncherWindow::LauncherWindow):
849 (LauncherWindow::downloadRequest):
850 (LauncherWindow::fileDownloadFinished):
851 * QtTestBrowser/launcherwindow.h:
853 2011-06-04 Dominic Cooney <dominicc@chromium.org>
855 Reviewed by Dimitri Glazkov.
857 Make DumpRenderTree initialize window.internals.
858 https://bugs.webkit.org/show_bug.cgi?id=61076
860 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
861 * DumpRenderTree/win/FrameLoadDelegate.cpp:
862 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
864 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
866 Reviewed by Kent Tamura.
868 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
869 https://bugs.webkit.org/show_bug.cgi?id=61628
871 * Scripts/build-webkit:
873 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
875 Reviewed by Kent Tamura.
877 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
878 https://bugs.webkit.org/show_bug.cgi?id=61631
880 * Scripts/build-webkit:
882 2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
884 Unreviewed. Fix the GTK+ build.
886 * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
888 2011-06-05 Alexey Proskuryakov <ap@apple.com>
890 Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
893 * Scripts/webkitpy/common/config/committers.py:
895 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
897 [wx] Unreviewed build fix. Update git branch build dir handling to match what other
898 WebKit scripts expect, so other scripts work properly with wx.
900 * waf/build/build_utils.py:
901 * waf/build/settings.py:
903 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
905 [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
908 * waf/build/settings.py:
909 * wx/install-unix-extras:
911 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
913 [wx] Unreviewed build fixes for recent trunk changes.
915 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
916 (LayoutTestController::setTextDirection):
917 * waf/build/settings.py:
919 2011-06-04 Martin Robinson <mrobinson@igalia.com>
923 * GNUmakefile.am: Add some missing newline escape.
925 2011-06-03 Martin Robinson <mrobinson@igalia.com>
927 Try to fix the GTK+ bulid.
929 * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
932 2011-06-03 Dirk Pranke <dpranke@chromium.org>
934 Reviewed by Adam Barth.
936 nrwt: should skip chromium test expectation overrides on upstream bots
937 https://bugs.webkit.org/show_bug.cgi?id=61888
939 * Scripts/webkitpy/layout_tests/port/chromium.py:
940 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
942 2011-06-03 Dirk Pranke <dpranke@chromium.org>
944 Reviewed by Ojan Vafai.
946 new-run-webkit-tests: minor logging, code cleanup
947 https://bugs.webkit.org/show_bug.cgi?id=62055
949 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
950 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
952 2011-06-03 Martin Robinson <mrobinson@igalia.com>
954 Try to fix the build failure on the GTK+ 32-bit Release bot.
956 * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
958 2011-05-31 Martin Robinson <mrobinson@igalia.com>
960 Reviewed by Ryosuke Niwa.
962 [GTK] Support smart replace for the pasteboard
963 https://bugs.webkit.org/show_bug.cgi?id=61734
965 Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
966 This is required to produce consistent test results.
968 * DumpRenderTree/gtk/DumpRenderTree.cpp:
969 (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
970 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
971 (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
972 methods which calls into DumpRenderTreeSupportGtk.
974 2011-06-03 Martin Robinson <mrobinson@igalia.com>
976 Reviewed by Dimitri Glazkov.
978 Teach Gtk build about window.internals
979 https://bugs.webkit.org/show_bug.cgi?id=61071
981 * DumpRenderTree/gtk/DumpRenderTree.cpp:
982 (webViewWindowObjectCleared): Inject the new internals object when the
983 window object clears.
984 * GNUmakefile.am: Add new source files and includes necessary for window.internals.
985 Also do a little bit of cleanup.
987 2011-06-03 Dirk Pranke <dpranke@chromium.org>
989 Reviewed by Tony Chang.
991 Worker may not be stopped after LT.
992 https://bugs.webkit.org/show_bug.cgi?id=61847
994 Re-submit a variant of the first fix for this bug. It's possible
995 that actually calling cleanup() in the worker threads was taking
996 too long and we triggered the assertions in the manager thread.
998 I've bumped up the timeout in the manager and added better
999 diagnostics. I also cleaned up the cleanup() code a bit because
1000 there was some unnecessary if-checks.
1002 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1003 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1005 2011-06-03 Dirk Pranke <dpranke@chromium.org>
1007 Reviewed by Tony Chang.
1009 nrwt: fix duplicate logging regression
1010 https://bugs.webkit.org/show_bug.cgi?id=61981
1012 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1014 2011-06-03 Robert Kroeger <rjkroege@chromium.org>
1016 Reviewed by Adam Barth.
1018 Modified addTouchPoint to correctly re-use touchPoint id values starting
1019 from the lowest not-un-use touchPoint id as is done by the embedder
1020 APIs. (Fixes BUGCR36415)
1022 https://bugs.webkit.org/show_bug.cgi?id=62016
1024 * DumpRenderTree/chromium/EventSender.cpp:
1025 (EventSender::addTouchPoint):
1027 2011-06-03 Cary Clark <caryclark@google.com>
1029 Reviewed by Eric Seidel.
1031 Draw DRT scroll bar thumb with CG when WebKit renders with Skia
1032 https://bugs.webkit.org/show_bug.cgi?id=61534
1034 Skia on Mac uses Skia to render WebKit, and CG
1035 to render UI elements. The CG elements need a
1036 transcribed graphics context that preserves the
1037 canvas matrix, and the canvas clip.
1039 The SkiaBitLocker utility class sets up a CGContext
1040 from the SkCanvas, locks the bitmap's bits, and
1041 releases the lock when the class goes out of scope.
1043 The SkiaBitLocker implementation is described by
1045 http://codereview.chromium.org/7031006/
1047 When WebKit uses Skia for rendering, the WebCanvas
1048 is an SkCanvas. Create an equivalent CGContext to
1049 draw the scrollbar thumb.
1051 As the Chrome Mac port does not yet use Skia, this
1052 patch has no effect and requires no tests.
1054 * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1055 (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1057 2011-06-03 Andras Becsi <abecsi@webkit.org>
1059 Unreviewed build fix.
1063 * Scripts/old-run-webkit-tests:
1065 2011-06-03 Andras Becsi <abecsi@webkit.org>
1067 Reviewed by Csaba Osztrogonác.
1069 Print error message when there is no httpd present on the system
1070 https://bugs.webkit.org/show_bug.cgi?id=61939
1072 * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
1073 * Scripts/webkitperl/httpd.pm:
1075 2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
1077 Reviewed by Yury Semikhatsky.
1079 Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
1080 https://bugs.webkit.org/show_bug.cgi?id=61533
1082 Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
1084 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1085 (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
1086 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1087 * DumpRenderTree/chromium/LayoutTestController.cpp:
1088 (LayoutTestController::LayoutTestController):
1089 (LayoutTestController::setJavaScriptProfilingEnabled):
1090 * DumpRenderTree/chromium/LayoutTestController.h:
1091 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1092 (LayoutTestController::setJavaScriptProfilingEnabled):
1093 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1094 (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1095 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1097 2011-06-02 Dirk Pranke <dpranke@chromium.org>
1099 Reviewed by Tony Chang.
1101 NRWT needs a way to log to a file without including backspaces without needing --verbose
1102 https://bugs.webkit.org/show_bug.cgi?id=60328
1104 This change modifies NRWT so that if it can tell if it is
1105 writing to a terminal, it will overwrite any messages printed
1106 in the 'one-line-progress' and 'updates' print options, and if
1107 not (or if --verbose was specified) the messages will be printed
1110 If the overwriting updates are disabled, one-line-progress will
1111 only print every 10 seconds instead of on every update. This
1112 ensures that we still get updates once in a while while the
1113 tests are running, even if we're not in --verbose mode. Note
1114 that one-line-progress will now still be printed in --verbose,
1115 since it's useful as long as you're not flooded with the
1118 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1119 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1120 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1122 2011-06-02 Martin Robinson <mrobinson@igalia.com>
1124 Reviewed by Gustavo Noronha Silva.
1126 [GTK] autogen.sh is run twice for each buld on the bots
1127 https://bugs.webkit.org/show_bug.cgi?id=61951
1129 * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1130 for the WebKit project. This prevents build-jsc runs from forcing subsequent
1131 build-webkit runs to re-rerun autogen.sh.
1133 2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
1135 Unreviewed, rolling out r87946.
1136 http://trac.webkit.org/changeset/87946
1137 https://bugs.webkit.org/show_bug.cgi?id=61965
1139 Cause NRWT to break (Requested by abarth|gardener on #webkit).
1141 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1143 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
1145 Reviewed by Darin Adler.
1147 Add build logistics and plumbing for window.internals object.
1148 https://bugs.webkit.org/show_bug.cgi?id=60313
1150 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1151 * DumpRenderTree/chromium/TestShell.cpp:
1152 (TestShell::bindJSObjectsToWindow): Added injection code.
1153 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1154 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1156 2011-06-02 Hao Zheng <zhenghao@chromium.org>
1158 Reviewed by Dirk Pranke.
1160 Call cleanup() explicitly at the end of worker.run().
1161 https://bugs.webkit.org/show_bug.cgi?id=61847
1163 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1165 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
1167 Unreviewed, rolling out r87926.
1168 http://trac.webkit.org/changeset/87926
1169 https://bugs.webkit.org/show_bug.cgi?id=60313
1171 Fails to find WebCoreTestSupport.dylib on bots.
1173 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1174 * DumpRenderTree/chromium/TestShell.cpp:
1175 (TestShell::bindJSObjectsToWindow):
1176 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1177 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1179 2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
1181 Reviewed by Darin Adler.
1183 Add build logistics and plumbing for window.internals object.
1184 https://bugs.webkit.org/show_bug.cgi?id=60313
1186 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1187 * DumpRenderTree/chromium/TestShell.cpp:
1188 (TestShell::bindJSObjectsToWindow): Added injection code.
1189 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1190 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1192 2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1194 Reviewed by Eric Seidel.
1196 Adjust efl coding style to more efl directories
1197 https://bugs.webkit.org/show_bug.cgi?id=61903
1199 * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1201 2011-06-01 Dirk Pranke <dpranke@chromium.org>
1203 Reviewed by Tony Chang.
1205 old-run-webkit-tests: add support for audio files
1206 https://bugs.webkit.org/show_bug.cgi?id=57992
1208 * Scripts/old-run-webkit-tests:
1210 2011-06-01 Jochen Eisinger <jochen@chromium.org>
1212 Reviewed by Adam Barth.
1214 Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1215 https://bugs.webkit.org/show_bug.cgi?id=34314
1217 * DumpRenderTree/DumpRenderTree.gypi:
1218 * DumpRenderTree/chromium/LayoutTestController.cpp:
1219 (LayoutTestController::LayoutTestController):
1220 (LayoutTestController::setImagesAllowed):
1221 (LayoutTestController::setStorageAllowed):
1222 * DumpRenderTree/chromium/LayoutTestController.h:
1223 * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1224 (WebPermissions::WebPermissions):
1225 (WebPermissions::~WebPermissions):
1226 (WebPermissions::allowImages):
1227 (WebPermissions::allowStorage):
1228 (WebPermissions::setImagesAllowed):
1229 (WebPermissions::setStorageAllowed):
1230 (WebPermissions::reset):
1231 * DumpRenderTree/chromium/WebPermissions.h:
1233 2011-06-01 Noel Gordon <noel.gordon@gmail.com>
1235 Reviewed by Tony Chang.
1237 Test plugin should support event logging on the windows port.
1238 https://bugs.webkit.org/show_bug.cgi?id=61721
1240 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1241 (handleEventWin): Well, handle them.
1243 2011-06-01 Daniel Cheng <dcheng@chromium.org>
1245 Reviewed by Tony Chang.
1247 [chromium] Use correct file name for dragging out images.
1248 https://bugs.webkit.org/show_bug.cgi?id=24887
1250 * DumpRenderTree/chromium/EventSender.cpp:
1251 (EventSender::EventSender):
1252 (EventSender::dumpFilenameBeingDragged):
1253 * DumpRenderTree/chromium/EventSender.h:
1255 2011-06-01 Dirk Pranke <dpranke@chromium.org>
1257 Reviewed by Tony Chang.
1259 nrwt: make webaudio work w/o content-length header
1260 https://bugs.webkit.org/show_bug.cgi?id=61819
1262 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1263 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1264 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1265 * Scripts/webkitpy/layout_tests/port/webkit.py:
1267 2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
1269 Reviewed by Andreas Kling.
1271 [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1272 https://bugs.webkit.org/show_bug.cgi?id=61802
1274 Add command line parameter and menu item to MiniBrowser application
1275 enabling use of QGLWidget for browser viewport.
1277 * MiniBrowser/qt/BrowserWindow.cpp:
1278 (BrowserWindow::BrowserWindow):
1279 (BrowserWindow::toggleGLViewport):
1280 * MiniBrowser/qt/BrowserWindow.h:
1281 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1282 (MiniBrowserApplication::handleUserOptions):
1283 * MiniBrowser/qt/MiniBrowserApplication.h:
1284 (WindowOptions::WindowOptions):
1286 2011-06-01 Martin Robinson <mrobinson@igalia.com>
1288 Reviewed by Xan Lopez.
1290 Print out autogen arguments when they differ from the last set, to help
1291 with debugging build issues.
1293 * Scripts/webkitdirs.pm: Print out previous and current build arguments
1296 2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
1298 Reviewed by Martin Robinson.
1300 [GTK] run-launcher should run MiniBrowser in WebKit2
1301 https://bugs.webkit.org/show_bug.cgi?id=61858
1303 * Scripts/run-launcher: Check whether -2 command line option has
1304 been passed and run MiniBrowser instead of GtkLauncher.
1306 2011-05-31 Hao Zheng <zhenghao@chromium.org>
1308 Reviewed by Dirk Pranke.
1310 Fix exception in verbose printing mode.
1311 https://bugs.webkit.org/show_bug.cgi?id=61723
1313 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1315 2011-05-31 Yong Li <yoli@rim.com>
1317 Reviewed by Eric Seidel.
1319 https://bugs.webkit.org/show_bug.cgi?id=54807
1320 We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1321 However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1322 bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1323 http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1324 Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1325 always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1326 rule we should have in order to make our code independent from compilers and compiler flags.
1328 * Scripts/webkitpy/style/checkers/cpp.py:
1330 2011-05-31 Hironori Bono <hbono@chromium.org>
1332 Reviewed by Eric Seidel.
1334 Add a JavaScript function layoutTestController.setTextDirection().
1335 https://bugs.webkit.org/show_bug.cgi?id=50952
1337 This change adds a new JavaScript function setTextDirection() to the
1338 LayoutTestController class of Safari and Chrome to write layout tests
1339 that changes the text direction of an editable element.
1341 * DumpRenderTree/LayoutTestController.cpp:
1342 (setTextDirectionCallback):
1343 (LayoutTestController::staticFunctions):
1344 * DumpRenderTree/LayoutTestController.h:
1345 * DumpRenderTree/chromium/LayoutTestController.cpp:
1346 (LayoutTestController::LayoutTestController):
1347 (LayoutTestController::setTextDirection):
1348 * DumpRenderTree/chromium/LayoutTestController.h:
1349 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1350 (LayoutTestController::setTextDirection):
1351 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1352 (LayoutTestController::setTextDirection):
1353 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1354 (LayoutTestController::setTextDirection):
1356 2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
1358 Reviewed by Simon Hausmann.
1360 [Qt] User-agent list of Qt test browsers is very outdated
1361 https://bugs.webkit.org/show_bug.cgi?id=61531
1363 The user can edit the user-agent manually, so there's no need to have
1364 a super complete and up to date list, but it's nice to have it
1367 * MiniBrowser/qt/useragentlist.txt:
1368 * QtTestBrowser/useragentlist.txt:
1370 2011-03-30 Martin Robinson <mrobinson@igalia.com>
1372 Reviewed by Adam Roben.
1374 [GTK] [WebKit2] Implement a basic WebKitTestRunner
1375 https://bugs.webkit.org/show_bug.cgi?id=57068
1377 Add an implementation of WebKitTestRunner for GTK+.
1379 * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1380 * Scripts/old-run-webkit-tests: Ditto.
1381 * Scripts/run-launcher: Ditto.
1382 * Scripts/webkitdirs.pm: Ditto.
1383 * WebKitTestRunner/GNUmakefile.am: Added.
1384 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1385 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1386 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1387 * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1388 * WebKitTestRunner/PlatformWebView.h:
1389 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1390 * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1391 * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1392 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1393 * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1396 2011-05-31 Dirk Pranke <dpranke@chromium.org>
1398 Reviewed by Tony Chang.
1400 new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1401 https://bugs.webkit.org/show_bug.cgi?id=60241
1403 * Scripts/new-run-webkit-tests:
1405 2011-05-31 Eric Seidel <eric@webkit.org>
1407 Reviewed by David Kilzer.
1409 webkitpy should create zips with zip -9
1410 https://bugs.webkit.org/show_bug.cgi?id=61789
1412 Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1414 * Scripts/webkitpy/common/system/workspace.py:
1415 * Scripts/webkitpy/common/system/workspace_unittest.py:
1417 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1419 Reviewed by Csaba Osztrogonác.
1421 [Qt] Implement find feature for QtTestBrowser
1422 https://bugs.webkit.org/show_bug.cgi?id=61425
1424 Buildfix for --minimal and CONFIG+=qt_minimal build.
1426 * QtTestBrowser/launcherwindow.cpp:
1427 (LauncherWindow::LauncherWindow):
1428 (LauncherWindow::createChrome):
1429 * QtTestBrowser/launcherwindow.h:
1431 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1433 Reviewed by Csaba Osztrogonác.
1435 [Qt] Implement find feature for QtTestBrowser
1436 https://bugs.webkit.org/show_bug.cgi?id=61425
1438 * QtTestBrowser/launcherwindow.cpp:
1439 (LauncherWindow::LauncherWindow):
1440 (LauncherWindow::createChrome):
1441 (LauncherWindow::showFindBar):
1442 (LauncherWindow::find):
1443 * QtTestBrowser/launcherwindow.h:
1445 2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
1447 Reviewed by Martin Robinson.
1449 [GTK] Implement JavaScript dialogs in MiniBrowser
1450 https://bugs.webkit.org/show_bug.cgi?id=61725
1452 * MiniBrowser/gtk/BrowserWindow.c:
1453 (WKStringGetCString): Helper function to get a UTF-8 c string from
1455 (WKURLGetCString): Helper function to get a UTF-8 c string from a
1457 (browserWindowUpdateURL): Update to use WKURLGetCString.
1458 (didReceiveTitleForFrame): Update to use WKStringGetCString.
1459 (createMessageDialog): Create a GtkMessageDialog.
1460 (runJavaScriptAlert):
1461 (runJavaScriptConfirm):
1462 (runJavaScriptPrompt):
1463 (browserWindowUIClientInit):
1465 2011-05-29 Yuta Kitamura <yutak@chromium.org>
1467 Reviewed by Kent Tamura.
1469 WebSocket closing handshake
1470 https://bugs.webkit.org/show_bug.cgi?id=35721
1472 * Scripts/webkitpy/thirdparty/__init__.py:
1473 Pull in pywebsocket 0.6b1. We need to update pywebsocket
1474 to get the right behavior of closing handshake.
1476 2011-05-29 Daniel Bates <dbates@rim.com>
1478 Reviewed by David Kilzer.
1480 REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1481 https://bugs.webkit.org/show_bug.cgi?id=61162
1483 Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1484 that omits a line count. In particular, the chunk range regular expression does
1485 not match a chunk range line that omits a line count. GNU diff(1) will omit the
1486 line count in the chunk range if the line count is exactly 1. For example, appending
1487 a new line to the end of an existing file F that contains exactly one line of text will
1488 be represented in a diff with a chunk range line that omits the line count for F.
1490 * Scripts/VCSUtils.pm:
1491 (parseChunkRange): Added.
1492 * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1493 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1494 - Added unit test "Git: Append new line to the end of an existing file".
1496 2011-05-28 Adam Barth <abarth@webkit.org>
1498 Reviewed by Eric Seidel.
1500 EWS builds patches that fail to build twice, which seems useless and slows down the bots
1501 https://bugs.webkit.org/show_bug.cgi?id=55585
1503 This patch switches all the early warning system bots over to the new
1504 PatchAnalysisTask-based infrastructure. This patch makes these bots
1505 more efficient (in the case where patches fail to build) and paves the
1506 way for running tests on these bots!
1508 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1509 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1510 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1511 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1512 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1513 * Scripts/webkitpy/tool/commands/queues.py:
1515 2011-05-28 Kenichi Ishibashi <bashi@chromium.org>
1517 Reviewed by Kent Tamura.
1519 Add bashi as a committer.
1521 https://bugs.webkit.org/show_bug.cgi?id=61685
1523 * Scripts/webkitpy/common/config/committers.py:
1525 2011-05-27 Adam Barth <abarth@webkit.org>
1527 Reviewed by Eric Seidel.
1529 When checking whether the tree is red, the EWS posts a link to the wrong log
1530 https://bugs.webkit.org/show_bug.cgi?id=61072
1532 We need to cache the original script error because that contains the
1533 failure log we want to upload. If we don't cache that script error,
1534 self._script_error will get overwritten when we sanity check the clean
1535 tree (and it also has test failures).
1537 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1538 - This testing approach is slightly goofy. We'd like to use
1539 assertRaisesRegexp, but that's not available until Python 2.7.
1540 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1542 2011-05-27 Jochen Eisinger <jochen@chromium.org>
1544 Reviewed by Adam Barth.
1546 Add layoutTestController.setStorageAllowed() to control whether access
1547 to the localStorage API is enabled via the WebPermissionClient
1548 https://bugs.webkit.org/show_bug.cgi?id=61581
1550 * DumpRenderTree/chromium/LayoutTestController.cpp:
1551 (LayoutTestController::LayoutTestController):
1552 (LayoutTestController::setStorageAllowed):
1553 * DumpRenderTree/chromium/LayoutTestController.h:
1554 * DumpRenderTree/chromium/TestShell.cpp:
1555 (TestShell::TestShell):
1556 (TestShell::createNewWindow):
1557 * DumpRenderTree/chromium/TestShell.h:
1558 * DumpRenderTree/chromium/WebPermissions.h: Added.
1559 (WebPermissions::WebPermissions):
1560 (WebPermissions::allowStorage):
1561 (WebPermissions::setStorageAllowed):
1562 (WebPermissions::reset):
1564 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1566 Reviewed by Eric Seidel.
1568 NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1569 https://bugs.webkit.org/show_bug.cgi?id=60326
1571 This patch removes a lot of the complexity from the
1572 metered_stream implementation that was unnecessary since there
1573 was only one caller and the logic could be coordinated better.
1575 There should be no functional changes in this patch, just code
1576 getting deleted and cleaned up.
1578 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1579 * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1580 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1581 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1583 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1585 Reviewed by Eric Seidel.
1587 NRWT: minor cleanup in printing module
1588 https://bugs.webkit.org/show_bug.cgi?id=60329
1590 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1592 2011-05-27 Steve Lacey <sjl@chromium.org>
1594 Reviewed by David Levin.
1596 Add sjl@chromium.org as a committer.
1598 https://bugs.webkit.org/show_bug.cgi?id=61672
1600 * Scripts/webkitpy/common/config/committers.py:
1602 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1604 Reviewed by Adam Barth.
1606 NRWT: remove --print detailed-progress
1607 https://bugs.webkit.org/show_bug.cgi?id=60324
1609 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1610 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1611 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1612 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1614 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1616 Reviewed by Ojan Vafai.
1618 NRWT: debug messages from the workers are being logged twice
1619 https://bugs.webkit.org/show_bug.cgi?id=60428
1621 It looks like when the workers are run in separate processes
1622 we end up getting two copies of every log message they print.
1623 This has to do with the multiprocessing module on UNIX cloning
1624 the log configuration in a way I wasn't expecting, and so two
1625 log handlers end up getting registered.
1627 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1628 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1629 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1630 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1632 2011-05-27 Adam Roben <aroben@apple.com>
1634 Always decode tester names from location.hash
1636 When navigating directly to a tester-specific URL (e.g.,
1637 <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1638 with a URL-encoded tester name in the page, and then the encoded name could make its way
1639 into Bugzilla bugs. Bad!
1641 Reviewed by David Kilzer.
1643 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1644 (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1645 decodeURIComponent before trying to use it.
1647 2011-05-27 Adam Roben <aroben@apple.com>
1649 Remove testing code that snuck into r87528
1651 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1652 (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1654 2011-05-27 Adam Roben <aroben@apple.com>
1656 Add links to TestFailures to easily file bugs about failing tests
1658 Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1659 links to file bugs for failing tests
1661 Reviewed by David Kilzer.
1663 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1664 (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1665 for a particular build.
1666 (Builder.prototype._getFailingTests): Use resultsPageURL.
1668 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1669 (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1671 (ViewController.prototype._domForBuildName): Use resultsPageURL.
1672 (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1673 new bug link. The bug has a title, description, and URL already filled in for you!
1675 2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
1677 Unreviewed, rolling out r87464.
1678 http://trac.webkit.org/changeset/87464
1679 https://bugs.webkit.org/show_bug.cgi?id=61643
1681 client-close/server-close tests are flaky on Chromium Mac and
1682 Windows (Requested by aklein on #webkit).
1684 * Scripts/webkitpy/thirdparty/__init__.py:
1686 2011-05-27 Alexey Proskuryakov <ap@apple.com>
1688 Added Douglas Davidson to contributors list for easier CC'ing.
1690 * Scripts/webkitpy/common/config/committers.py:
1692 2011-05-26 Mihai Parparita <mihaip@chromium.org>
1694 Reviewed by Adam Barth.
1696 Fix worldID and destinationDomain argument names
1697 https://bugs.webkit.org/show_bug.cgi?id=61571
1699 As part of working on r87423, I noticed a couple of inconsistencies in
1701 - We would use worldId in .h files but worldID in .cpp files.
1702 Standardize on the latter
1703 - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1704 destinationDomains argument, even though the actual parameter was for
1705 a single domain (renamed to be singular).
1707 * DumpRenderTree/LayoutTestController.h:
1708 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1709 (LayoutTestController::evaluateScriptInIsolatedWorld):
1711 2011-05-26 Yuta Kitamura <yutak@chromium.org>
1713 Reviewed by Kent Tamura.
1715 WebSocket closing handshake
1716 https://bugs.webkit.org/show_bug.cgi?id=35721
1718 * Scripts/webkitpy/thirdparty/__init__.py:
1719 Pull in pywebsocket 0.6b1. We need to update pywebsocket
1720 to get the right behavior of closing handshake.
1722 2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
1724 Reviewed by Andreas Kling.
1726 WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1727 https://bugs.webkit.org/show_bug.cgi?id=42676
1729 Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1731 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1732 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1733 (WTR::InjectedBundle::beginTesting):
1734 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1735 (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1736 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1738 2011-05-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
1740 Reviewed by Andreas Kling.
1742 [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1743 https://bugs.webkit.org/show_bug.cgi?id=61527
1745 The setMaximumHeight() call is unecessary and breaks the dialog at
1748 * QtTestBrowser/launcherwindow.cpp:
1749 (LauncherWindow::showUserAgentDialog):
1751 2011-05-02 Robert Hogan <robert@webkit.org>
1753 Reviewed by Adam Roben.
1755 [Qt] Allow popup windows from plugins when initiated by a user gesture
1757 https://bugs.webkit.org/show_bug.cgi?id=41292
1759 Support parameters introduced in plugin-initiate-popup-window.html
1761 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1762 (webkit_test_plugin_new_instance):
1763 (webkit_test_plugin_handle_event):
1765 2011-05-26 Mihai Parparita <mihaip@chromium.org>
1767 Reviewed by Adam Barth.
1769 Support cross-origin XMLHttpRequest in isolated worlds
1770 https://bugs.webkit.org/show_bug.cgi?id=59843
1772 Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1774 * DumpRenderTree/chromium/LayoutTestController.cpp:
1775 (LayoutTestController::LayoutTestController):
1776 (LayoutTestController::setIsolatedWorldSecurityOrigin):
1777 * DumpRenderTree/chromium/LayoutTestController.h:
1779 2011-05-25 Brian Weinstein <bweinstein@apple.com>
1781 Reviewed by Adam Roben.
1783 WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1784 https://bugs.webkit.org/show_bug.cgi?id=61474
1785 <rdar://problem/9468337>
1787 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1788 (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1790 2011-05-26 Andreas Kling <kling@webkit.org>
1792 Unreviewed, correct address to webkit-committers mailing list.
1794 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1796 2011-05-25 Adam Roben <aroben@apple.com>
1798 Don't assume that builds finish in the order they were started
1800 Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1801 build when one slave is taking a long time to finish a build
1803 Reviewed by Antti Koivisto.
1805 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1806 (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1807 newer than the oldest in-progress build are also themselves in progress. Just check whether
1808 each build is actually in progress (as signified by its presence in the currentBuilds set).
1810 2011-05-25 Adam Roben <aroben@apple.com>
1812 Correctly detect cases where only a single test failed/crashed/timed out
1814 Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1817 Reviewed by Darin Adler.
1819 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1820 (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1821 will be singular when only a single test fails/crashes/times out.
1823 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1824 (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1825 failed/crashed/timed out.
1827 2011-05-26 Tom Hudson <tomhudson@google.com>
1829 Reviewed by Tony Chang.
1831 Add flags to Chromium ImageDiff to write image comparison metrics on
1833 https://bugs.webkit.org/show_bug.cgi?id=60569
1835 * DumpRenderTree/chromium/ImageDiff.cpp:
1836 (Image::createFromStdin): Fix spelling.
1837 (maxOf3): New function to do 3-way maximum.
1838 (getRedComponent): Extract red component from ABGR packed encoding.
1839 (getGreenComponent): Extract green component from ABGR packed encoding.
1840 (getBlueComponent): Extract blue component from ABGR packed encoding.
1841 (weightedPercentageDifferent): Determine % of pixels different in two
1842 images multiplied by intensity difference of each pixel.
1843 (printHelp): Document new arguments.
1844 (compareImages): Parameterize.
1845 (untestedCompareImages): Parameterize.
1846 (diffImages): Parameterize; write results on stdout if requested.
1847 (main): Parse new arguments.
1849 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
1851 Reviewed by Simon Hausmann.
1853 WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1854 https://bugs.webkit.org/show_bug.cgi?id=42697
1856 Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1858 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1859 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1860 (WTR::InjectedBundle::beginTesting):
1861 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1862 (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1863 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1865 2011-05-25 Jon Honeycutt <jhoneycutt@apple.com>
1867 REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1868 https://bugs.webkit.org/show_bug.cgi?id=61428
1869 <rdar://problem/9457006>
1871 Reviewed by Adam Roben.
1873 The crash occurs when Flash posts a message to a window that it
1874 creates, and in processing the message, it calls NPN_Evaluate to
1875 evaluate JavaScript that removes the plug-in from the page. Flash then
1876 crashes when we return to Flash code.
1878 This test emulates that behavior.
1880 * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1881 (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1882 Initialize member vars.
1883 (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1884 Remove our custom property from the message window, and destroy it.
1885 (CallJSThatDestroysPlugin::NPP_Destroy):
1886 Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1887 layout test controller that we're done.
1889 Get the PluginTest object, and call its runTest() function.
1890 (CallJSThatDestroysPlugin::NPP_New):
1891 Setup the test: register a class for the message-only window, create
1892 it, and post a message to it to run the test.
1893 (CallJSThatDestroysPlugin::runTest):
1894 Execute JS that removes the plug-in from the page, and if we're not
1895 destroyed, log a success message.
1897 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1898 Add new test to project.
1900 2011-05-25 Tony Chang <tony@chromium.org>
1902 Reviewed by Adam Barth.
1904 webkitpy's NetworkTransaction shouldn't use mechanize
1905 https://bugs.webkit.org/show_bug.cgi?id=61450
1907 mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1908 use urllib2 directly. Re-add NetworkTransaction to
1909 test_results_uploader.py (reverting r87124).
1911 * Scripts/webkitpy/common/net/networktransaction.py:
1912 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1914 2011-05-25 Kevin Ollivier <kevino@theolliviers.com>
1916 [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1917 until the port begins using those export macros.
1919 * DumpRenderTree/chromium/config.h:
1921 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
1923 Unreviewed, rolling out r87257.
1924 http://trac.webkit.org/changeset/87257
1925 https://bugs.webkit.org/show_bug.cgi?id=61457
1927 This broke layout tests, see bug 61431. (Requested by
1928 hwennborg on #webkit).
1930 * DumpRenderTree/chromium/LayoutTestController.cpp:
1931 (LayoutTestController::LayoutTestController):
1932 (LayoutTestController::clearAllDatabases):
1933 * DumpRenderTree/chromium/LayoutTestController.h:
1935 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
1937 Reviewed by Andreas Kling.
1939 [Qt] fast/css/disabled-author-styles.html failed
1940 https://bugs.webkit.org/show_bug.cgi?id=61438
1942 Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1944 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1945 (WebCore::WebPage::resetSettings):
1946 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1947 (LayoutTestController::setAuthorAndUserStylesEnabled):
1948 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1950 2011-05-25 Adam Roben <aroben@apple.com>
1952 Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1954 Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1955 started exiting early due to too many crashes, timeouts, or failures
1957 Reviewed by David Kilzer.
1959 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1960 (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1961 run-webkit-tests exits early due to too many failures, pass that information in another
1962 argument to the callback.
1963 (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1964 the new structure of the object passed to the callback.
1965 (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1966 getNumberOfFailingTests and to pass that along to our own callbacks.
1967 (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1968 from _getFailingTests and to store that value in the history object.
1970 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1973 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1974 (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1975 object and to add a note when run-webkit-tests exited early due to too many failures.
1976 (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1977 latestBuildInfos since each entry now contains more than just the tester and failure count.
1978 Now displays a message for testers where the latest build exited early due to too many
1979 failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1980 store that value in latestBuildInfos.
1982 2011-05-24 Keishi Hattori <keishi@webkit.org>
1984 Reviewed by Kent Tamura.
1986 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1987 https://bugs.webkit.org/show_bug.cgi?id=61273
1989 * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1991 2011-05-24 Greg Simon <gregsimon@chromium.org>
1993 Reviewed by Dimitri Glazkov.
1995 Control Indexeddb backends from LayoutTestController
1996 https://bugs.webkit.org/show_bug.cgi?id=61000
1998 * DumpRenderTree/chromium/LayoutTestController.cpp:
1999 (LayoutTestController::LayoutTestController):
2000 (LayoutTestController::setOverrideIndexedDBBackingStore):
2001 (LayoutTestController::clearAllDatabases):
2002 * DumpRenderTree/chromium/LayoutTestController.h:
2004 2011-05-24 Robert Hogan <robert@webkit.org>
2006 Reviewed by Ryosuke Niwa.
2008 [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
2009 https://bugs.webkit.org/show_bug.cgi?id=61393
2011 * DumpRenderTree/qt/EventSenderQt.h:
2012 * DumpRenderTree/qt/EventSenderQt.cpp:
2013 (getModifiers): static function for interpreting modifiers
2014 (EventSender::mouseDown): Respect keyboard modifiers
2015 (EventSender::keyDown): use new static function
2016 (EventSender::sendOrQueueEvent): whitespace fix
2018 2011-05-24 Jay Civelli <jcivelli@chromium.org>
2020 Reviewed by Adam Barth.
2022 Adding MHTML reading support.
2023 https://bugs.webkit.org/show_bug.cgi?id=7168
2025 * Scripts/build-webkit:
2026 * Scripts/old-run-webkit-tests:
2027 * Scripts/webkitperl/features.pm:
2028 * Scripts/webkitpy/layout_tests/port/test_files.py:
2029 * Scripts/webkitpy/layout_tests/port/webkit.py:
2031 2011-05-24 Stephen White <senorblanco@chromium.org>
2033 Reviewed by Kenneth Russell.
2035 Remove most style checks on Source/ThirdParty/glu, since it doesn't
2036 follow WebKit style.
2037 https://bugs.webkit.org/show_bug.cgi?id=61365
2039 * Scripts/webkitpy/style/checker.py:
2041 2011-05-24 Adam Roben <aroben@apple.com>
2043 Don't allow forcing builds through the build.webkit.org web interface
2045 Someone has been forcing bogus builds.
2047 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2049 2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
2051 Reviewed by Adam Roben.
2053 WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2054 https://bugs.webkit.org/show_bug.cgi?id=42669
2056 Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
2057 layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
2058 Because that case changed the setting.
2060 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2061 (WTR::InjectedBundle::beginTesting):
2063 2011-05-24 Csaba Osztrogonác <ossy@webkit.org>
2065 Reviewed by Kenneth Rohde Christiansen.
2067 [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
2068 https://bugs.webkit.org/show_bug.cgi?id=61052
2070 * Scripts/old-run-webkit-tests:
2072 2011-05-24 Adam Roben <aroben@apple.com>
2074 Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
2076 Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
2077 that don't have any failing tests, which isn't useful
2079 Reviewed by David Kilzer.
2081 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
2082 (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
2083 instead of name strings.
2084 (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
2085 builder names into an array of builders.
2087 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2088 (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
2089 the most recently completed build, or -1 if there is no such build.
2090 (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
2091 in the given build, or -1 if the number could not be determined. Some of this code came from
2093 (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
2094 (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
2095 getNumberOfFailingTests functions.
2097 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2098 (ViewController.prototype._displayTesters): Get the current number of test failures for each
2099 tester and show it in the list. Omit testers that have no failures at all. We keep the
2100 testers and failure counts in an array and sort it before displaying the current data, as
2101 the order in which data will be fetched is unpredictable.
2103 2011-05-23 Tony Chang <tony@chromium.org>
2105 Reviewed by Ojan Vafai.
2107 [nrwt] don't use NetworkTranslation when uploading results
2108 https://bugs.webkit.org/show_bug.cgi?id=61315
2110 This avoids autoinstalling mechanize. It didn't matter anyway
2111 because test_results_uploader.py wasn't using mechanize to make the
2112 request so NetworkTransaction::run wasn't doing anything extra
2113 (it only matters if it catches mechanize.HTTPError).
2115 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2117 2011-05-23 Tony Chang <tony@chromium.org>
2119 Reviewed by Dirk Pranke.
2121 [chromium] fix the rebaseline tool to work with Linux GPU failures
2122 https://bugs.webkit.org/show_bug.cgi?id=61312
2124 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2126 2011-05-23 Darin Adler <darin@apple.com>
2128 Ignore generated .pyc files in a directory full of python code.
2130 * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2132 2011-05-23 Adam Barth <abarth@webkit.org>
2134 Reviewed by Eric Seidel.
2136 sheriffbot should give more details about the failures in IRC
2137 https://bugs.webkit.org/show_bug.cgi?id=61233
2139 With this patch, sheriffbot will annonce the set of failing tests,
2140 which might help folks triage the problem.
2142 * Scripts/webkitpy/tool/commands/sheriffbot.py:
2143 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2145 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
2147 Unreviewed, rolling out r87078.
2148 http://trac.webkit.org/changeset/87078
2149 https://bugs.webkit.org/show_bug.cgi?id=61294
2151 Patch contains errors and seems likely to break a bunch of
2152 bots (Requested by abarth on #webkit).
2154 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2155 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2156 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2158 2011-05-23 Alice Boxhall <aboxhall@chromium.org>
2160 Reviewed by Ojan Vafai.
2162 Convert json_results_generator.py to output version 4 JSON.
2163 https://bugs.webkit.org/show_bug.cgi?id=60869
2165 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2166 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2167 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2169 2011-05-23 Patrick Gansterer <paroga@webkit.org>
2171 Reviewed by Adam Barth.
2173 Move generation of shell_command from port to executive
2174 https://bugs.webkit.org/show_bug.cgi?id=61251
2176 After move it's possible to use the code in other places too.
2178 * Scripts/webkitpy/common/config/ports.py:
2179 * Scripts/webkitpy/common/system/executive.py:
2181 2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
2183 Reviewed by Darin Adler.
2185 WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2186 https://bugs.webkit.org/show_bug.cgi?id=42669
2188 Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2190 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2191 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2192 (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2193 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2195 2011-05-22 Robert Hogan <robert@webkit.org>
2197 Reviewed by Kenneth Rohde Christiansen.
2199 Fix policyDelegate in Qt DRT
2200 https://bugs.webkit.org/show_bug.cgi?id=61247
2202 Use the 'policy delegate' implemented in FrameLoaderClient
2203 for layout tests. The partial implementation in DumpRenderTreeQt
2204 is redundant, so remove it.
2206 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2207 (WebCore::WebPage::acceptNavigationRequest):
2208 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2209 (LayoutTestController::waitForPolicyDelegate):
2211 2011-05-22 Patrick Gansterer <paroga@webkit.org>
2213 Reviewed by Darin Adler.
2215 Use double quotes for filename arguments
2216 https://bugs.webkit.org/show_bug.cgi?id=61250
2218 Windows does not support single quotes on the command line,
2219 so replace them with double quotes.
2221 * Scripts/prepare-ChangeLog:
2223 2011-05-20 Simon Fraser <simon.fraser@apple.com>
2225 Reviewed by Sam Weinig.
2227 WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2228 https://bugs.webkit.org/show_bug.cgi?id=42550
2230 Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2232 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2233 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2234 Copy the code for pausing animations, FIXME comments and all.
2235 (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2236 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2238 2011-05-20 Alok Priyadarshi <alokp@chromium.org>
2240 Reviewed by Stephen White.
2242 Adding myself to the committers list.
2244 * Scripts/webkitpy/common/config/committers.py:
2246 2011-05-19 Adam Roben <aroben@apple.com>
2248 Test that the WebKit2 UI process doesn't crash when starting a download
2250 Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2251 (preceded by assertion) in fastMalloc when downloading a file
2253 Reviewed by Darin Adler.
2255 * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2257 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2258 (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2259 (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2260 started, cancel the download, and return a bogus string.
2262 (TestWebKitAPI::setContextDownloadClient):
2263 (TestWebKitAPI::setPagePolicyClient):
2264 Simple helper functions.
2266 (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2267 our policy client, and run until we know that the download was started. If we haven't
2270 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2271 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2272 * TestWebKitAPI/win/copy-resources.cmd:
2275 2011-05-20 Kent Tamura <tkent@chromium.org>
2277 Reviewed by Ryosuke Niwa.
2279 Fix style errors in DumpRenderTree/chromium/.
2280 https://bugs.webkit.org/show_bug.cgi?id=61172
2282 * DumpRenderTree/chromium/CppBoundClass.cpp:
2283 (CppBoundClass::getAsCppVariant):
2284 (CppBoundClass::bindToJavascript):
2285 * DumpRenderTree/chromium/CppBoundClass.h:
2286 (CppBoundClass::GetterCallback::~GetterCallback):
2287 (CppBoundClass::CppBoundClass):
2288 (CppBoundClass::Callback::~Callback):
2289 (CppBoundClass::MemberCallback::MemberCallback):
2290 (CppBoundClass::MemberCallback::~MemberCallback):
2291 (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2292 (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2293 * DumpRenderTree/chromium/CppVariant.h:
2294 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2295 (DRTDevToolsAgent::~DRTDevToolsAgent):
2296 * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2297 (DRTDevToolsClient::sendFrontendLoaded):
2298 * DumpRenderTree/chromium/DRTDevToolsClient.h:
2299 * DumpRenderTree/chromium/DumpRenderTree.cpp:
2301 * DumpRenderTree/chromium/EventSender.cpp:
2302 (SavedEvent::SavedEvent):
2303 (EventSender::EventSender):
2304 (EventSender::keyDown):
2305 * DumpRenderTree/chromium/EventSender.h:
2306 * DumpRenderTree/chromium/ImageDiff.cpp:
2308 * DumpRenderTree/chromium/LayoutTestController.cpp:
2309 (LayoutTestController::LayoutTestController):
2310 (LayoutTestController::WorkQueue::reset):
2311 (WorkItemBackForward::WorkItemBackForward):
2312 (WorkItemLoadingScript::WorkItemLoadingScript):
2313 (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2314 (WorkItemLoad::WorkItemLoad):
2315 (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2316 (LayoutTestController::pathToLocalResource):
2317 * DumpRenderTree/chromium/LayoutTestController.h:
2318 (LayoutTestController::WorkItem::~WorkItem):
2319 (LayoutTestController::WorkQueue::WorkQueue):
2320 * DumpRenderTree/chromium/MockSpellCheck.cpp:
2321 (MockSpellCheck::MockSpellCheck):
2322 (MockSpellCheck::~MockSpellCheck):
2323 * DumpRenderTree/chromium/MockSpellCheck.h:
2324 * DumpRenderTree/chromium/NotificationPresenter.h:
2325 (NotificationPresenter::NotificationPresenter):
2326 * DumpRenderTree/chromium/Task.cpp:
2328 * DumpRenderTree/chromium/Task.h:
2329 (TaskList::TaskList):
2330 * DumpRenderTree/chromium/TestEventPrinter.cpp:
2331 (DRTPrinter::DRTPrinter):
2332 (TestShellPrinter::TestShellPrinter):
2333 * DumpRenderTree/chromium/TestNavigationController.cpp:
2334 (TestNavigationEntry::TestNavigationEntry):
2335 (TestNavigationEntry::~TestNavigationEntry):
2336 (TestNavigationController::TestNavigationController):
2337 (TestNavigationController::reload):
2338 (TestNavigationController::loadEntry):
2339 (TestNavigationController::didNavigateToEntry):
2340 * DumpRenderTree/chromium/TestNavigationController.h:
2341 (TestShellExtraData::TestShellExtraData):
2342 * DumpRenderTree/chromium/TestShell.cpp:
2344 * DumpRenderTree/chromium/TestShell.h:
2345 (TestParams::TestParams):
2346 * DumpRenderTree/chromium/TestShellWin.cpp:
2347 (TestShell::waitTestFinished):
2348 * DumpRenderTree/chromium/TestWebWorker.h:
2349 (TestWebWorker::startWorkerContext):
2350 (TestWebWorker::terminateWorkerContext):
2351 (TestWebWorker::postMessageToWorkerContext):
2352 (TestWebWorker::clientDestroyed):
2353 (TestWebWorker::postMessageToWorkerObject):
2354 (TestWebWorker::postExceptionToWorkerObject):
2355 (TestWebWorker::postConsoleMessageToWorkerObject):
2356 (TestWebWorker::confirmMessageFromWorkerObject):
2357 (TestWebWorker::reportPendingActivity):
2358 (TestWebWorker::workerContextClosed):
2359 (TestWebWorker::~TestWebWorker):
2360 * DumpRenderTree/chromium/TextInputController.cpp:
2361 * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2362 * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2363 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2364 (WebThemeEngineDRTWin::paintButton):
2365 (WebThemeEngineDRTWin::paintMenuList):
2366 (WebThemeEngineDRTWin::paintTrackbar):
2367 * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2368 (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2369 * DumpRenderTree/chromium/WebViewHost.cpp:
2370 (WebViewHost::navigate):
2371 (WebViewHost::updateSessionHistory):
2372 (WebViewHost::paintInvalidatedRegion):
2373 * DumpRenderTree/chromium/WebViewHost.h:
2375 2011-05-19 Dmitry Lomov <dslomov@google.com>
2377 Reviewed by Adam Roben.
2379 Detect hangs in run-api-tests
2380 https://bugs.webkit.org/show_bug.cgi?id=48043
2382 * Scripts/run-api-tests: Added test timeouts
2384 2011-05-19 Dmitry Lomov <dslomov@google.com>
2386 Reviewed by Adam Roben.
2388 run-api-tests should run one test per process
2389 https://bugs.webkit.org/show_bug.cgi?id=61088
2391 * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
2392 return code, and parsing GTest output format.
2394 2011-05-15 Robert Hogan <robert@webkit.org>
2396 Reviewed by Antonio Gomes.
2398 [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2399 https://bugs.webkit.org/show_bug.cgi?id=60834
2400 Fix unix test plugin for plugins/get-url-with-javascript-url.html
2402 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2403 (webkit_test_plugin_new_stream):
2404 (webkit_test_plugin_write_ready):
2405 (webkit_test_plugin_write):
2407 2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
2409 Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2410 http://trac.webkit.org/changeset/86869
2411 http://trac.webkit.org/changeset/86873
2412 http://trac.webkit.org/changeset/86875
2413 http://trac.webkit.org/changeset/86877
2414 https://bugs.webkit.org/show_bug.cgi?id=61139
2416 broke builds and debug DRT (Requested by rniwa on #webkit).
2418 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2419 * DumpRenderTree/chromium/TestShell.cpp:
2420 (TestShell::bindJSObjectsToWindow):
2421 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2422 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2424 2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
2426 Reviewed by Darin Adler.
2428 Add build logistics and plumbing for window.internals object.
2429 https://bugs.webkit.org/show_bug.cgi?id=60313
2431 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2432 * DumpRenderTree/chromium/TestShell.cpp:
2433 (TestShell::bindJSObjectsToWindow): Added injection code.
2434 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2435 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2437 2011-05-19 Zsolt Fehér <h490267@stud.u-szeged.hu>
2439 Reviewed by Csaba Osztrogonác.
2441 [Qt] Implement eventSender.scalePageBy
2442 https://bugs.webkit.org/show_bug.cgi?id=60015
2444 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2445 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2446 * DumpRenderTree/qt/EventSenderQt.cpp:
2447 (EventSender::scalePageBy):
2448 * DumpRenderTree/qt/EventSenderQt.h:
2450 2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
2452 Reviewed by Kent Tamura.
2454 [Chromium] IME candidate window appears wrong position in an iframe
2455 https://bugs.webkit.org/show_bug.cgi?id=61023
2457 Call the focused frame's firstRectForCharacterRange() instead of the
2458 main frame so that DRT behaves as the same as Chromium.
2460 * DumpRenderTree/chromium/TextInputController.cpp:
2461 (TextInputController::firstRectForCharacterRange):
2463 2011-05-18 Adam Roben <aroben@apple.com>
2465 Add a new page to build.webkit.org to help find when tests started failing
2467 The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2468 right now, but already shows some useful information. It's somewhat similar to webkit-patch
2469 failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2470 little more convenient than either of them, though, because it's all done in the browser
2471 (and thus it's easy to go directly to the relevant test results).
2473 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2474 (Buildbot): This class represents a Buildbot server.
2475 (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2476 (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2477 (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2479 (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2480 be implemented by a derived class that understands this server's build naming scheme.
2481 (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2484 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2485 (Builder): This class represents one builder on the buildbot.
2486 (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2487 (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2488 information about a particular test failure.
2489 (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2490 information about when tests started failing.
2491 (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2493 (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2495 (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2496 extracts all the failing tests listed in it, passing them to the callback.
2497 (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2498 build, merges them into the build history, and calls the callback telling it whether the
2499 next build should be fetched to provide more information.
2501 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2502 Added. Just some simple styles.
2504 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2505 (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2506 (getResource): Wrapper around XMLHttpRequest.
2507 (Array.prototype.findFirst): Finds the first element matching the given predicate and
2509 (Array.prototype.last): Returns the last element of the array.
2511 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2512 (ViewController): This class contains the main logic for displaying the page.
2513 (ViewController.loaded): Just calls through to parseHash.
2514 (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2515 shows the list of all testers so one can be chosen. This function is called when the page
2516 loads and whenever we get a hashchange event.
2517 (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2518 as it is fetched. The display ends up grouping tests by when they started failing.
2519 (ViewController._displayTesters): Gets the list of testers and displays it.
2521 (ViewController._domForBuildName):
2522 (ViewController._domForFailedTest):
2523 Helper functions to create descriptions and links for a particular build or failed test.
2525 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2526 (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2527 (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2529 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2530 loads all the files and sets up a ViewController, which does the rest.
2532 * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2535 2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
2537 Reviewed by Csaba Osztrogonác.
2539 [Qt] Implement layoutTestController.setValueForUser()
2540 https://bugs.webkit.org/show_bug.cgi?id=60956
2542 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2543 (LayoutTestController::setValueForUser):
2544 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2546 2011-05-16 Robert Hogan <robert@webkit.org>
2548 Reviewed by Kenneth Rohde Christiansen.
2550 plugins/invalidate_rect.html fails on linux ports
2552 - Make the unix test netscape plugin recognize the onPaintEvent
2553 and windowedPlugin parameters.
2555 https://bugs.webkit.org/show_bug.cgi?id=54051
2557 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2559 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2560 (LayoutTestController::displayInvalidatedRegion):
2561 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2562 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2563 (webkit_test_plugin_new_instance):
2564 (webkit_test_plugin_handle_event):
2566 2011-05-17 Tony Chang <tony@chromium.org>
2568 Reviewed by Ojan Vafai.
2570 [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2571 https://bugs.webkit.org/show_bug.cgi?id=60895
2573 Update the tools to handle the move. Lucid 32 results now go in
2574 chromium-linux-x86 and the default platform on Linux is now x86_64.
2576 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2577 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2578 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2579 * Scripts/webkitpy/layout_tests/port/base.py: ditto
2580 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2581 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2582 * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2583 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2584 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2586 2011-05-17 Adam Roben <aroben@apple.com>
2588 Make run-api-tests work on Windows when there are spaces in the path
2590 Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2591 spaces in the path to TestWebKitAPI.exe
2593 Reviewed by David Levin.
2595 * Scripts/run-api-tests:
2596 (runTestTool): Use the "direct object" form of system() to avoid having the path to
2597 TestWebKitAPI.exe be split by the shell.
2599 2011-05-16 Ian Henderson <ianh@apple.com>
2601 Reviewed by Joseph Pecoraro.
2603 Page::goToItem doesn't work while loading is deferred
2604 https://bugs.webkit.org/show_bug.cgi?id=60412
2606 Add setDefersLoading and goBack methods to LayoutTestController. We
2607 need to use goBack() instead of history.back() because the latter goes
2608 through NavigationScheduler, hence doesn't exhibit the bug.
2610 * DumpRenderTree/LayoutTestController.cpp:
2612 (setDefersLoadingCallback):
2613 (LayoutTestController::staticFunctions):
2614 * DumpRenderTree/LayoutTestController.h:
2615 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2616 (LayoutTestController::goBack):
2617 (LayoutTestController::setDefersLoading):
2618 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2619 (LayoutTestController::goBack):
2620 (LayoutTestController::setDefersLoading):
2621 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2622 (LayoutTestController::goBack):
2623 (LayoutTestController::setDefersLoading):
2624 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2625 (LayoutTestController::goBack):
2626 (LayoutTestController::setDefersLoading):
2628 2011-05-16 Sam Weinig <sam@webkit.org>
2630 Reviewed by Anders Carlsson.
2632 TestWebKitAPI should build with clang if it can
2633 https://bugs.webkit.org/show_bug.cgi?id=60918
2635 * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2636 Update CompilerVersion.xcconfig to match others.
2638 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2639 Add CompilerVersion.xcconfig to the project.
2641 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2642 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2643 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2644 (TestWebKitAPI::didSameDocumentNavigationForFrame):
2645 Add some casts to quiet warnings from clang.
2647 2011-05-16 Dirk Pranke <dpranke@chromium.org>
2649 Reviewed by David Levin.
2651 add dpranke as a reviewer
2652 https://bugs.webkit.org/show_bug.cgi?id=60919
2654 * Scripts/webkitpy/common/config/committers.py:
2656 2011-05-16 Robert Hogan <robert@webkit.org>
2658 Reviewed by Anders Carlsson.
2660 [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2662 https://bugs.webkit.org/show_bug.cgi?id=60838
2664 The unix test plugin needs to call the test's NPP_URLNotify
2665 rather than the browsers.
2667 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2668 (webkit_test_plugin_url_notify):
2670 2011-05-16 Brent Fulgham <bfulgham@webkit.org>
2672 Rubber-stamped by Adam Roben.
2674 Adding myself as a reviewer.
2675 * Scripts/webkitpy/common/config/committers.py:
2677 2011-05-16 Sam Weinig <sam@webkit.org>
2679 Fix typo pointed out by Dave Levin.
2681 * TestWebKitAPI/PlatformUtilities.h:
2682 (TestWebKitAPI::Util::assertWKStringEqual):
2685 2011-05-16 Sam Weinig <sam@webkit.org>
2687 Reviewed by David Levin.
2689 Convert api tester over to using gtest expectations directly
2690 https://bugs.webkit.org/show_bug.cgi?id=60862
2692 * TestWebKitAPI/PlatformUtilities.cpp:
2693 (TestWebKitAPI::Util::toSTD):
2694 * TestWebKitAPI/PlatformUtilities.h:
2695 (TestWebKitAPI::Util::assertWKStrigEqual):
2696 Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2697 the implementation of the macro simpler.
2699 * TestWebKitAPI/Test.h:
2700 Remove TEST_ASSERT forwarder.
2702 [Test changes elided]
2704 2011-05-16 David Kilzer <ddkilzer@apple.com>
2706 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2707 <rdar://problem/9446430>
2709 Reviewed by Mark Rowe.
2711 * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2712 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2713 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2715 2011-05-16 Jon Lee <jonlee@apple.com>
2717 Reviewed by Simon Fraser.
2719 Can't horizontally scroll iframes and overflow because wheel events are always accepted
2720 https://bugs.webkit.org/show_bug.cgi?id=60779
2722 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2723 (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2725 2011-05-16 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
2727 Reviewed by Csaba Osztrogonác.
2729 [Qt] Tools.pro misses include(common.pri)
2730 https://bugs.webkit.org/show_bug.cgi?id=60883
2732 It includes features.pri, which depends on common.pri (the build is
2733 not broken today with the default options, but this is the right
2738 2011-05-15 Dominic Cooney <dominicc@chromium.org>
2740 Unreviewed: adding myself to committers.py.
2742 * Scripts/webkitpy/common/config/committers.py:
2744 2011-05-15 Daniel Bates <dbates@webkit.org>
2746 Reviewed by Chris Jerdonek.
2748 svn-apply can't handle Git diff that only changes executable bit
2749 https://bugs.webkit.org/show_bug.cgi?id=60848
2751 Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2752 that only has an executable bit change.
2754 * Scripts/VCSUtils.pm:
2755 - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2756 (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2757 fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2758 * Scripts/svn-apply:
2759 (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2760 * Scripts/svn-unapply:
2762 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2763 - Updated expected results for test cases to account for numTextChunks.
2764 - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2765 - Added test case "Git: file that only has an executable bit change".
2766 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2767 - Updated expected results for test cases to account for numTextChunks.
2769 2011-05-15 Sam Weinig <sam@webkit.org>
2773 * TestWebKitAPI/win/main.cpp:
2776 2011-05-15 Sam Weinig <sam@webkit.org>
2778 Reviewed by David Levin.
2780 Make API tester more gtest friendly
2781 https://bugs.webkit.org/show_bug.cgi?id=60859
2783 * Scripts/run-api-tests:
2785 - Remove logic to run tests one at a time.
2786 - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
2787 the test runner and allow gtest to print it for us.
2788 - Forward stdout from the test tool to stdout, even in non-verbose runs.
2789 - Run test tool from the current working directory instead of the root webkit
2792 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793 Move plist to be with other bundle sources.
2795 * TestWebKitAPI/TestsController.cpp:
2796 (TestWebKitAPI::TestsController::TestsController):
2797 (TestWebKitAPI::TestsController::run):
2798 * TestWebKitAPI/TestsController.h:
2799 * TestWebKitAPI/mac/main.mm:
2800 Simplify TestController down to a single run function. We should consider removing the class
2801 entirely at some point.
2803 2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
2805 Unreviewed, rolling out r86504.
2806 http://trac.webkit.org/changeset/86504
2807 https://bugs.webkit.org/show_bug.cgi?id=60853
2809 "Broke Qt EventSender in editing/selection tests" (Requested
2810 by mwenge on #webkit).
2812 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2813 (WebCore::WebPage::WebPage):
2814 (WebCore::DumpRenderTree::DumpRenderTree):
2815 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2816 (WebCore::DumpRenderTree::initJSObjects):
2817 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2818 (WebCore::DumpRenderTree::eventSender):
2819 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2820 (webkit_test_plugin_new_instance):
2821 (webkit_test_plugin_set_window):
2822 (webkit_test_plugin_handle_event):
2824 2011-05-12 Robert Hogan <robert@webkit.org>
2826 Reviewed by Benjamin Poulain.
2828 [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2830 The support for this test added to the unix test plugin here
2831 may allow other platforms to pass it (nearly everyone
2832 skips it). On Qt it required a bit of trickiness with
2833 the page's EventSender object to get it working fully though,
2834 so only unskipping Qt here.
2836 https://bugs.webkit.org/show_bug.cgi?id=60722
2838 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2839 (WebCore::WebPage::WebPage):
2840 (WebCore::WebPage::eventSender):
2841 (WebCore::DumpRenderTree::DumpRenderTree):
2842 (WebCore::DumpRenderTree::initJSObjects):
2843 (WebCore::DumpRenderTree::createWindow):
2844 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2845 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2846 (webkit_test_plugin_new_instance):
2847 (webkit_test_plugin_set_window):
2848 (webkit_test_plugin_handle_event):
2850 2011-05-14 Arno Renevier <arno@renevier.net>
2852 Reviewed by Martin Robinson.
2854 make run-gtk-tests executable
2855 https://bugs.webkit.org/show_bug.cgi?id=59278
2857 * Scripts/run-gtk-tests:
2859 2011-05-14 Anders Carlsson <andersca@apple.com>
2861 Reviewed by Kevin Decker.
2863 NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2864 https://bugs.webkit.org/show_bug.cgi?id=60823
2865 <rdar://problem/9430386>
2867 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2869 * DumpRenderTree/DumpRenderTree.gypi:
2870 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2871 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2872 (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2873 (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2874 (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2875 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2876 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2879 2011-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
2881 Unreviewed, rolling out r86476.
2882 http://trac.webkit.org/changeset/86476
2883 https://bugs.webkit.org/show_bug.cgi?id=60832
2885 It made plugins/get-url-notify-with-url-that-fails-to-
2886 load.html crash on GTK (Requested by Ossy on #webkit).
2888 * DumpRenderTree/DumpRenderTree.gypi:
2889 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2890 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2891 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2892 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2895 2011-05-13 Anders Carlsson <andersca@apple.com>
2897 Reviewed by Sam Weinig.
2899 NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2900 https://bugs.webkit.org/show_bug.cgi?id=60823
2901 <rdar://problem/9430386>
2903 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2905 * DumpRenderTree/DumpRenderTree.gypi:
2906 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2907 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2908 (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2909 (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2910 (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2911 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2912 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2915 2011-05-13 Anders Carlsson <andersca@apple.com>
2919 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2921 2011-05-13 Anders Carlsson <andersca@apple.com>
2923 Reviewed by Sam Weinig.
2925 NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2926 https://bugs.webkit.org/show_bug.cgi?id=60810
2928 Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2930 * DumpRenderTree/DumpRenderTree.gypi:
2931 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2932 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2933 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2937 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2938 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2939 Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2941 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2942 (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2943 (GetURLWithJavaScriptURL::NPP_New):
2944 (GetURLWithJavaScriptURL::NPP_NewStream):
2945 (GetURLWithJavaScriptURL::NPP_DestroyStream):
2946 (GetURLWithJavaScriptURL::NPP_WriteReady):
2947 (GetURLWithJavaScriptURL::NPP_Write):
2948 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2953 call the PluginTest NPP wrappers.
2955 2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
2957 Unreviewed, rolling out r86447.
2958 http://trac.webkit.org/changeset/86447
2959 https://bugs.webkit.org/show_bug.cgi?id=60809
2961 "Broke some uses of EventSender object on Qt" (Requested by
2964 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965 (WebCore::WebPage::WebPage):
2966 (WebCore::DumpRenderTree::DumpRenderTree):
2967 (WebCore::DumpRenderTree::initJSObjects):
2968 (WebCore::DumpRenderTree::createWindow):
2969 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2970 (WebCore::DumpRenderTree::eventSender):
2971 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2972 (webkit_test_plugin_new_instance):
2973 (webkit_test_plugin_set_window):
2974 (webkit_test_plugin_handle_event):
2976 2011-05-13 Robert Hogan <robert@webkit.org>
2978 Reviewed by Benjamin Poulain.
2980 [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2982 The support for this test added to the unix test plugin here
2983 may allow other platforms to pass it (nearly everyone
2984 skips it). On Qt it required a bit of trickiness with
2985 the page's EventSender object to get it working fully though,
2986 so only unskipping Qt here.
2988 https://bugs.webkit.org/show_bug.cgi?id=60722
2990 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2991 (WebCore::WebPage::WebPage):
2992 (WebCore::WebPage::eventSender):
2993 (WebCore::DumpRenderTree::DumpRenderTree):
2994 (WebCore::DumpRenderTree::initJSObjects):
2995 (WebCore::DumpRenderTree::createWindow):
2996 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2997 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2998 (webkit_test_plugin_new_instance):
2999 (webkit_test_plugin_set_window):
3000 (webkit_test_plugin_handle_event):
3002 2011-05-13 Adam Roben <aroben@apple.com>
3004 Exclude the Leopard NRWT bot from the core builder set
3006 Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
3008 Reviewed by Darin Adler.
3010 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3011 (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
3012 in the core builder set.
3014 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3015 (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
3018 2011-05-13 Adam Roben <aroben@apple.com>
3020 Group all the NRWT bots together
3022 This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
3023 bots are experimental, it seems best not to clutter up the non-experimental bots with
3026 Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
3029 Reviewed by Dan Bernstein.
3031 * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
3032 Chromium testers, which also use new-run-webkit-tests.
3034 2011-05-13 Adam Roben <aroben@apple.com>
3036 Add a plugin test that dumps the plugin window's rect
3038 Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
3039 (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
3041 Reviewed by Dan Bernstein.
3043 * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
3044 (DumpWindowRect::DumpWindowRect): Just call up to the base class.
3045 (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
3046 harness window and log it.
3048 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
3050 2011-05-13 Adam Roben <aroben@apple.com>
3052 Move code required for most tests of plugin window geometry into a base class
3054 WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
3055 having all the trickiness in a shared base class, writing new window geometry tests will be
3058 Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
3060 Reviewed by Anders Carlsson.
3062 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3063 (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
3064 WindowGeometryTest base class. Most of the code from this class was moved to the new base
3066 (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
3067 This is called by the base class when it is safe to check the window's geometry. Note that
3068 the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
3069 just vestigial code from an earlier version of this test.
3071 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
3072 WindowGeometryTest class.
3074 * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
3075 WindowRegionIsSetToClipRect.
3076 (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
3077 We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
3078 Subclasses can implement that function to perform their own tests.
3080 * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
3082 2011-05-13 Zoltan Herczeg <zherczeg@webkit.org>
3084 Reviewed by Csaba Osztrogonác.
3086 Missing 2nd #EOF if WebProcess is killed.
3087 https://bugs.webkit.org/show_bug.cgi?id=60761
3089 If the WebProcess is killed, only one #EOF is yielded
3090 by WebKitTestRunner. However, run-webkit-test wait for
3091 a second #EOF, which signals the finishing of pixel dump.
3092 Since this never happens, run-webkit-test waits forever.
3094 * WebKitTestRunner/TestInvocation.cpp:
3095 (WTR::TestInvocation::dump):
3096 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3097 * WebKitTestRunner/TestInvocation.h:
3099 2011-05-13 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
3101 Reviewed by Csaba Osztrogonác.
3103 [NRWT] chromium-linux tests shouldn't run on other platforms
3104 https://bugs.webkit.org/show_bug.cgi?id=60162
3106 Remove _tests_for_other_platforms defs because r82753
3107 implemented it properly in the baseclass in webkit.py.
3109 * Scripts/webkitpy/layout_tests/port/gtk.py:
3110 * Scripts/webkitpy/layout_tests/port/qt.py:
3111 * Scripts/webkitpy/layout_tests/port/win.py:
3113 2011-05-12 Ryuan Choi <ryuan.choi@samsung.com>
3115 Reviewed by Antonio Gomes.
3117 [EFL] Remove unused option of EWeblauncher
3118 https://bugs.webkit.org/show_bug.cgi?id=60747
3120 Remove sudo-workaround option.
3121 This option is not used and make other option wrong.
3123 * EWebLauncher/main.c:
3125 2011-05-12 Lucas Forschler <lforschler@apple.com>
3127 Reviewed by Stephanie Lewis.
3129 Fix config.json to address missing WK2 builder/tester config.
3130 Fix naming of machines (xserve not macpro)
3132 * BuildSlaveSupport/build.webkit.org-config/config.json:
3134 2011-05-12 Lucas Forschler <lforschler@apple.com>
3136 Reviewed by Stephanie Lewis.
3138 Add SnowLeopard Debug builder and Test bot.
3139 apple-xserve-8 = SL Debug Tester.
3140 apple-xserve-9 = SL Debug Builder.
3142 * BuildSlaveSupport/build.webkit.org-config/config.json:
3144 2011-05-12 Adam Barth <abarth@webkit.org>
3146 This patch disables sheriffbot's bug postings. He's just been way too
3147 spammy recently due to test flakiness.
3149 * Scripts/webkitpy/tool/commands/sheriffbot.py:
3150 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3152 2011-05-11 Brian Weinstein <bweinstein@apple.com>
3154 Reviewed by Anders Carlsson.
3156 After relaunching an unresponsive web process, web page stops responding to mouse movement
3157 https://bugs.webkit.org/show_bug.cgi?id=60669
3158 <rdar://problem/9409934>
3160 This test follows the steps needed to reproduce this bug:
3161 1) Hang the web process
3162 2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3163 3) Kill and restart the WebProcess
3166 We are testing that we receive mouse move events after the WebProcess has restarted.
3168 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3169 (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3170 (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3171 (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3172 (TestWebKitAPI::setPageLoaderClient):
3173 (TestWebKitAPI::TEST):
3174 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3175 (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3176 (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3177 * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3179 * TestWebKitAPI/PlatformWebView.h:
3180 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3181 (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3182 * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3183 (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3186 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3187 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3188 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3189 * TestWebKitAPI/win/copy-resources.cmd:
3191 2011-05-12 Tomasz Morawski <t.morawski@samsung.com>
3193 Reviewed by Antonio Gomes.
3195 [EFL] Added initialization/shutdown for ecore_file library
3196 https://bugs.webkit.org/show_bug.cgi?id=60457
3198 Added initialization and shuthown for ecore_file library and replaced
3199 realpath function to ecore_file_realpath.
3201 * EWebLauncher/main.c:
3206 2011-05-12 Young Han Lee <joybro@company100.net>
3208 Reviewed by Kenneth Rohde Christiansen.
3210 [Qt] Implement layoutTestController.layerTreeAsText()
3211 https://bugs.webkit.org/show_bug.cgi?id=60367
3213 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3214 (LayoutTestController::layerTreeAsText):
3215 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3217 2011-05-11 Eric Seidel <eric@webkit.org>
3219 Reviewed by David Levin.
3221 Teach validate-committer-lists how to validate committers bugzilla_email()
3222 https://bugs.webkit.org/show_bug.cgi?id=60651
3224 It turns out we currently have 9 committers with invalid values for their
3225 bugzilla_email field (meaning we don't know what email is their bugzilla account).
3226 "Alexander Kellett" <lypanov@mac.com>
3227 "Andre Boule" <aboule@apple.com>
3228 "Cameron McCormack" <cam@webkit.org>
3229 "Chris Petersen" <cpetersen@apple.com>
3230 "Eli Fidler" <eli@staikos.net>
3231 "Matt Lilek" <webkit@mattlilek.com>
3232 "Pierre d'Herbemont" <pdherbemont@free.fr>
3233 "Scott Violet" <sky@chromium.org>
3234 "Adam Treat" <treat@kde.org>
3236 Most of those haven't committed in a very long time, so it's not suprising
3237 that we haven't noticed that their bugzilla emails are bogus.
3239 * Scripts/validate-committer-lists:
3240 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3241 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3243 2011-05-11 Dmitry Lomov <dslomov@google.com>
3245 Reviewed by David Levin.
3247 https://bugs.webkit.org/show_bug.cgi?id=59561
3248 Switch TestWebKitAPI to GTest
3250 Fixes Makefiles and WinCairo build as well
3253 * Scripts/build-api-tests:
3254 * Scripts/run-api-tests:
3255 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3256 * TestWebKitAPI/Test.h:
3257 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3258 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3259 (TestWebKitAPI::TEST):
3260 * TestWebKitAPI/TestsController.cpp:
3261 (TestWebKitAPI::TestsController::TestsController):
3262 (TestWebKitAPI::TestsController::dumpTestNames):
3263 (TestWebKitAPI::TestsController::runTestNamed):
3264 (TestWebKitAPI::TestsController::runAllTests):
3265 * TestWebKitAPI/TestsController.h:
3266 * TestWebKitAPI/mac/main.mm:
3269 2011-05-11 Eric Seidel <eric@webkit.org>
3271 Reviewed by Alexey Proskuryakov.
3273 Add Luke Macpherson to committers.py as a Contributor
3274 https://bugs.webkit.org/show_bug.cgi?id=60639
3276 * Scripts/webkitpy/common/config/committers.py:
3278 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
3280 Reviewed by Kenneth Rohde Christiansen.
3282 [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3283 https://bugs.webkit.org/show_bug.cgi?id=60439
3285 Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3287 * Scripts/build-webkit:
3289 2011-05-11 Brian Weinstein <bweinstein@apple.com>
3291 Reviewed by Adam Roben.
3293 REGRESSION (r86161): WKPreferences API test failing on Windows
3294 https://bugs.webkit.org/show_bug.cgi?id=60658
3296 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3297 (TestWebKitAPI::TEST):
3299 2011-05-11 Alice Boxhall <aboxhall@chromium.org>
3301 Reviewed by Ojan Vafai.
3303 Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3304 https://bugs.webkit.org/show_bug.cgi?id=60521
3306 First steps towards making the results JSON all hierarchical.
3308 * TestResultServer/model/jsonresults.py:
3309 * TestResultServer/model/jsonresults_unittest.py:
3311 2011-05-11 Kevin Ollivier <kevino@theolliviers.com>
3313 [wx] Build fix, adding new LayoutTestController method stubs.
3315 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3316 (LayoutTestController::localStorageDiskUsageForOrigin):
3317 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3319 2011-05-11 Jessie Berlin <jberlin@apple.com>
3321 Reviewed by Darin Adler.
3323 [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3324 about the usage for both the origin overall and the database in question.
3325 https://bugs.webkit.org/show_bug.cgi?id=60573
3327 * WebKitTestRunner/TestController.cpp:
3328 (WTR::exceededDatabaseQuota):
3330 2011-05-10 Stephen White <senorblanco@chromium.org>
3332 Reviewed by David Levin.
3334 Adding myself as a reviewer.
3335 https://bugs.webkit.org/show_bug.cgi?id=60587
3337 * Scripts/webkitpy/common/config/committers.py:
3339 2011-05-11 Eric Seidel <eric@webkit.org>
3341 Reviewed by Csaba Osztrogonác.
3343 queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3344 https://bugs.webkit.org/show_bug.cgi?id=60614
3346 AppEngine has a result limit of 1000. We hit that when trying
3347 to find out how many patches the style-queue (and other queues)
3348 have passed in the last 30 days. So lets display 1000+ instead
3349 of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3351 I also made the status pages show "never" instead of just "ago" when we
3352 haven't seen a pass or boot message in the last 1000 messages.
3354 * QueueStatusServer/handlers/queuestatus.py:
3355 * QueueStatusServer/templates/queuestatus.html:
3357 2011-05-11 Adam Barth <abarth@webkit.org>
3359 Reviewed by Eric Seidel.
3361 sheriffbot shouldn't spam bugs when it can't figure out who to blame
3362 https://bugs.webkit.org/show_bug.cgi?id=60613
3364 This patch limits the number of bugs sheriffbot will spam to three.
3365 Ideally, we'd come up with some smarter huerstics, but hopefully this
3366 will cut down on the bugmail spam for slow bots.
3368 * Scripts/webkitpy/tool/commands/sheriffbot.py:
3370 2011-05-10 Eric Seidel <eric@webkit.org>
3372 Reviewed by Adam Barth.
3374 EWS bots should be robust against test-webkitpy hangs
3375 https://bugs.webkit.org/show_bug.cgi?id=60579
3377 Added a killAfterTimeout subroutine, which takes a child_pid
3378 and timeout, and will setup a watchdog process to kill that child
3379 after the timeout. killAfterTimeout will waitpid on the child.
3381 * EWSTools/start-queue.sh:
3383 2011-05-10 MORITA Hajime <morrita@google.com>
3385 Unreviewed, moved myself to the reviewers list.
3387 * Scripts/webkitpy/common/config/committers.py:
3389 2011-05-10 Anton D'Auria <adauria@apple.com>
3391 Reviewed by David Levin.
3393 StorageTracker should report actual local storage usage on disk
3394 https://bugs.webkit.org/show_bug.cgi?id=60558
3396 * DumpRenderTree/LayoutTestController.cpp:
3397 (localStorageDiskUsageForOriginCallback):
3398 (LayoutTestController::staticFunctions):
3399 * DumpRenderTree/LayoutTestController.h:
3400 * DumpRenderTree/chromium/LayoutTestController.cpp:
3401 (LayoutTestController::LayoutTestController):
3402 (LayoutTestController::localStorageDiskUsageForOrigin):
3403 * DumpRenderTree/chromium/LayoutTestController.h:
3404 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3405 (LayoutTestController::localStorageDiskUsageForOrigin):
3406 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3407 (LayoutTestController::localStorageDiskUsageForOrigin):
3408 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3409 (LayoutTestController::localStorageDiskUsageForOrigin):
3410 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3411 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3412 (LayoutTestController::localStorageDiskUsageForOrigin):
3414 2011-05-10 Anton D'Auria <adauria@apple.com>
3416 Reviewed by Alexey Proskuryakov.
3418 Add ApplicationCache API to get disk usage per origin
3419 https://bugs.webkit.org/show_bug.cgi?id=57127
3421 Added test that loads two frames with ~15Kb image, checks usage,
3422 deletes app cache, verifies usage is 0.
3424 * DumpRenderTree/LayoutTestController.cpp:
3425 (applicationCacheDiskUsageForOriginCallback):
3426 (LayoutTestController::staticFunctions):
3427 * DumpRenderTree/LayoutTestController.h:
3428 * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3429 (LayoutTestController::LayoutTestController):
3430 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3431 * DumpRenderTree/chromium/LayoutTestController.h:
3432 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3433 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3434 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3435 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3436 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3437 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3438 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3439 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3440 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3442 2011-05-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
3444 Unreviewed, adding Rafael Antognolli as a committer.
3446 * Scripts/webkitpy/common/config/committers.py:
3448 2011-05-10 Chris Evans <cevans@chromium.org>
3450 Reviewed by Adam Barth.
3452 Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3453 https://bugs.webkit.org/show_bug.cgi?id=58378
3455 * DumpRenderTree/chromium/LayoutTestController.cpp:
3456 (LayoutTestController::LayoutTestController):
3457 (LayoutTestController::setAllowDisplayOfInsecureContent):
3458 (LayoutTestController::setAllowRunningOfInsecureContent):
3459 * DumpRenderTree/chromium/LayoutTestController.h:
3460 * DumpRenderTree/chromium/WebPreferences.cpp:
3461 (WebPreferences::reset):
3462 (WebPreferences::applyTo):
3463 * DumpRenderTree/chromium/WebPreferences.h:
3464 Add plumbing for new settings to Chromium DRT.
3466 2011-05-10 Enrica Casucci <enrica@apple.com>
3468 Reviewed by Beth Dakin.
3470 Added my name to the reviewers list and removed my name from
3471 to committer-only list.
3473 * Scripts/webkitpy/common/config/committers.py:
3475 2011-05-10 David Levin <levin@chromium.org>
3477 Reviewed by Shinichiro Hamaji.
3479 check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3480 https://bugs.webkit.org/show_bug.cgi?id=60466
3482 * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3483 * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3484 that property was removed.
3485 * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3486 filtering for errors.
3487 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3488 verify that the line filtering is turned off.
3489 * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3490 and remove the unused file_path parameter.
3491 * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3492 line filtering is turned off (and fix test_no_error).
3493 * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3494 of errors based on the lines changed in the patch.
3495 * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3498 2011-05-10 Adam Roben <aroben@apple.com>
3500 Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3502 Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3503 platform/win/plugins/window-geometry-initialized-before-set-window.html and
3504 platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3507 Reviewed by Anders Carlsson.
3509 * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3510 (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3511 WindowedPluginTest::testHarnessWindow function.
3513 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3514 (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3515 its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3516 turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3519 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3520 (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3521 WindowedPluginTest, and initialized new members.
3522 (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3523 to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3524 (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3525 then clean up and tell the test harness we're done.
3526 (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3527 from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3528 (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3529 if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3530 window becomes visible.
3531 (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3532 if it was hidden at the start of the test.
3533 (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3534 This should cause our window to become visible and our window region to get set. When we get
3535 a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3536 (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3537 (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3539 (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3541 * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3542 (WindowedPluginTest::testHarnessWindow):
3543 * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3544 Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3546 2011-05-10 Csaba Osztrogonác <ossy@webkit.org>
3548 Reviewed by Kenneth Rohde Christiansen.
3550 [Qt] Add new qt-4.8 platform for layout testing
3551 https://bugs.webkit.org/show_bug.cgi?id=60544
3553 * Scripts/old-run-webkit-tests:
3554 * Scripts/webkitdirs.pm:
3556 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
3558 Unreviewed, rolling out r86108.
3559 http://trac.webkit.org/changeset/86108
3560 https://bugs.webkit.org/show_bug.cgi?id=60533
3562 Broke makefile based builds and Cairo (Requested by weinig on
3565 * Scripts/build-api-tests:
3566 * Scripts/run-api-tests:
3567 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3568 * TestWebKitAPI/Test.h:
3569 (TestWebKitAPI::Test::~Test):
3570 (TestWebKitAPI::Test::name):
3571 (TestWebKitAPI::Test::Register::Register):
3572 (TestWebKitAPI::Test::Register::create):
3573 (TestWebKitAPI::Test::Test):
3574 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3576 (TestWebKitAPI::TEST):
3577 * TestWebKitAPI/TestsController.cpp:
3578 (TestWebKitAPI::TestsController::TestsController):
3579 (TestWebKitAPI::TestsController::dumpTestNames):
3580 (TestWebKitAPI::TestsController::runTestNamed):
3581 (TestWebKitAPI::TestsController::testFailed):
3582 (TestWebKitAPI::TestsController::registerCreateTestFunction):
3583 * TestWebKitAPI/TestsController.h:
3584 * TestWebKitAPI/mac/main.mm:
3587 2011-05-09 Hayato Ito <hayato@chromium.org>
3589 Reviewed by Ojan Vafai.
3591 Skip reftests if pixel tests are disabled.
3593 https://bugs.webkit.org/show_bug.cgi?id=59078
3595 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3596 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3597 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3598 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3600 2011-05-09 Chang Shu <cshu@webkit.org>
3602 Reviewed by Kenneth Rohde Christiansen.
3604 [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3605 https://bugs.webkit.org/show_bug.cgi?id=60499
3607 The implementation is similar to gtk.
3609 * DumpRenderTree/qt/TextInputControllerQt.cpp:
3610 (TextInputController::unmarkText):
3611 * DumpRenderTree/qt/TextInputControllerQt.h:
3613 2011-05-09 James Robinson <jamesr@chromium.org>
3615 Reviewed by Eric Seidel.
3617 [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3618 https://bugs.webkit.org/show_bug.cgi?id=60520
3620 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3622 2011-05-09 Dmitry Lomov <dslomov@google.com>
3624 Reviewed by Sam Weinig.
3626 Switch TestWebKitAPI to GTest
3627 https://bugs.webkit.org/show_bug.cgi?id=59561
3629 * Scripts/build-api-tests:
3630 * Scripts/run-api-tests:
3631 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3632 * TestWebKitAPI/Test.h:
3633 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3634 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3635 (TestWebKitAPI::TEST):
3636 * TestWebKitAPI/TestsController.cpp:
3637 (TestWebKitAPI::TestsController::TestsController):
3638 (TestWebKitAPI::TestsController::dumpTestNames):
3639 (TestWebKitAPI::TestsController::runTestNamed):
3640 (TestWebKitAPI::TestsController::runAllTests):
3641 * TestWebKitAPI/TestsController.h:
3642 * TestWebKitAPI/mac/main.mm:
3645 2011-05-09 Igor Oliveira <igor.oliveira@openbossa.org>
3647 Reviewed by Andreas Kling.
3649 [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3650 https://bugs.webkit.org/show_bug.cgi?id=60487
3652 When adding a new touch point, the start position of this point needs to be set.
3654 * DumpRenderTree/qt/EventSenderQt.cpp:
3655 (EventSender::addTouchPoint):
3657 2011-05-09 Robert Hogan <robert@webkit.org>
3659 Reviewed by Adam Roben.
3661 https://bugs.webkit.org/show_bug.cgi?id=57137
3663 Unskip plugins/embed-prefers-plugins-for-images.html
3665 Add image/png mime-type to test netscape plugin on Unix.
3667 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3668 (NP_GetMIMEDescription):
3670 2011-05-09 Alice Boxhall <aboxhall@chromium.org>
3672 Reviewed by Ojan Vafai