45c84a5c40348d6fcfeec2bc6e246a94ed0bf357
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-03  Chris Dumez  <cdumez@apple.com>
2
3         Drop ResourceLoadStatisticsStore's statisticsLock
4         https://bugs.webkit.org/show_bug.cgi?id=174080
5
6         Reviewed by Brent Fulgham.
7
8         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
9
10         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
11         (WTR::TestController::isStatisticsPrevalentResource):
12         (WTR::TestController::isStatisticsHasHadUserInteraction):
13         (WTR::TestController::isStatisticsGrandfathered):
14
15 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
16
17         Pasting single words copied to UIPasteboard inserts URLs in editable areas
18         https://bugs.webkit.org/show_bug.cgi?id=174082
19         <rdar://problem/33046992>
20
21         Reviewed by Tim Horton.
22
23         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
24
25         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
26         (TestWebKitAPI::setUpWebViewForPasteboardTests):
27         (TestWebKitAPI::TEST):
28
29 2017-07-02  Brady Eidson  <beidson@apple.com>
30
31         Add API test for all parts of WebKit1 API related to favicons.
32         https://bugs.webkit.org/show_bug.cgi?id=174069
33
34         Reviewed by Andy Estes.
35
36         These two API tests cover all WebKit1 API related to icons.
37         
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
40         (mainResourceData):
41         (defaultFaviconData):
42         (customFaviconData):
43         (imageFromData):
44         (+[IconLoadingProtocol canInitWithRequest:]):
45         (+[IconLoadingProtocol canonicalRequestForRequest:]):
46         (-[IconLoadingProtocol startLoading]):
47         (-[IconLoadingProtocol stopLoading]):
48         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
49         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
50         (TestWebKitAPI::TEST):
51
52 2017-07-01  Dan Bernstein  <mitz@apple.com>
53
54         [iOS] Remove code only needed when building for iOS 9.x
55         https://bugs.webkit.org/show_bug.cgi?id=174068
56
57         Reviewed by Tim Horton.
58
59         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
60         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
61         (WTR::initializeWebViewConfiguration):
62         * WebKitTestRunner/ios/HIDEventGenerator.mm:
63         (-[HIDEventGenerator _createIOHIDEventType:]):
64
65 2017-07-01  Brady Eidson  <beidson@apple.com>
66
67         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
68         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
69
70         Reviewed by Alex Christensen.
71
72         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
73
74 2017-07-01  Dan Bernstein  <mitz@apple.com>
75
76         [macOS] Remove code only needed when building for OS X Yosemite
77         https://bugs.webkit.org/show_bug.cgi?id=174067
78
79         Reviewed by Tim Horton.
80
81         * DumpRenderTree/mac/Configurations/Base.xcconfig:
82         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (setDefaultsToConsistentValuesForTesting):
85         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
86         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
87         * MiniBrowser/Configurations/Base.xcconfig:
88         * MiniBrowser/Configurations/DebugRelease.xcconfig:
89         * TestWebKitAPI/Configurations/Base.xcconfig:
90         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
91         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
92         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
93         (TestWebKitAPI::TEST_F):
94         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
95         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
96         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
97         (TestWebKitAPI::TEST_F):
98         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
99         (TestWebKitAPI::TEST):
100         * WebKitTestRunner/Configurations/Base.xcconfig:
101         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
102         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
103         (WTR::InjectedBundle::platformInitialize):
104         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
105         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
106
107 2017-07-01  Chris Dumez  <cdumez@apple.com>
108
109         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
110         https://bugs.webkit.org/show_bug.cgi?id=174060
111
112         Reviewed by Brent Fulgham.
113
114         Port WebKitTestRunner over to the new Cocoa SPI.
115
116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
117         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
118         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
119         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
120         no-ops since this code runs in the WebContent process, not the
121         UIProcess.
122
123         * WebKitTestRunner/TestController.cpp:
124         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
125
126 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
127
128         Unreviewed mac build fix.
129
130         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
131         (TestWebKitAPI::TEST):
132
133 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
134
135         Add API to get WKActivatedElementInfo
136         https://bugs.webkit.org/show_bug.cgi?id=174001
137         <rdar://problem/29165518>
138         
139         Tests for now SPI to get activatedElementInfo.
140
141         Reviewed by Tim Horton.
142
143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
144         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
145         (TestWebKitAPI::TEST):
146
147 2017-06-30  Chris Dumez  <cdumez@apple.com>
148
149         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
150         https://bugs.webkit.org/show_bug.cgi?id=174038
151
152         Reviewed by Brent Fulgham.
153
154         Fix typo in API name.
155
156         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
157         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
158         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
159         * WebKitTestRunner/InjectedBundle/TestRunner.h:
160         * WebKitTestRunner/TestController.cpp:
161         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
162         * WebKitTestRunner/TestController.h:
163         * WebKitTestRunner/TestInvocation.cpp:
164         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
165
166 2017-06-30  Alex Christensen  <achristensen@webkit.org>
167
168         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
169         https://bugs.webkit.org/show_bug.cgi?id=174051
170         <rdar://problem/33002846>
171
172         Reviewed by Tim Horton.
173
174         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
175         (TestWebKitAPI::TEST_F):
176
177 2017-06-30  Daniel Bates  <dabates@apple.com>
178
179         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
180         https://bugs.webkit.org/show_bug.cgi?id=165160
181         <rdar://problem/29451999>
182
183         Reviewed by Brady Eidson.
184
185         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
186         for navigations and window creation.
187
188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
189         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
190         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
191         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
192         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
193         (TEST):
194
195 2017-06-29  Jer Noble  <jer.noble@apple.com>
196
197         Make Legacy EME API controlled by RuntimeEnabled setting.
198         https://bugs.webkit.org/show_bug.cgi?id=173994
199
200         Reviewed by Sam Weinig.
201
202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
203
204 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
205
206         Follow-up fix for r218996
207
208         Unreviewed infrastructure fix.
209
210         Repeated calls to 'ios_version' make the log noisy, memoize the function.
211
212         * Scripts/webkitpy/port/ios_simulator.py:
213         (IOSSimulatorPort): Memoize ios_version().
214
215 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
216
217         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
218         https://bugs.webkit.org/show_bug.cgi?id=174017
219         <rdar://problem/32959782>
220
221         Reviewed by Simon Fraser.
222
223         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
224         changes, the caret would appear outside of the iframe.
225
226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
227         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
228         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
229         (checkDragCaretRectIsContainedInRect):
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/ios/DataInteractionSimulator.h:
232         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
233         (-[DataInteractionSimulator _resetSimulatedState]):
234         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
235         (-[DataInteractionSimulator _advanceProgress]):
236         (-[DataInteractionSimulator lastKnownDragCaretRect]):
237
238 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
239
240         Add support for different versions of iOS when loading test expectations
241         https://bugs.webkit.org/show_bug.cgi?id=173774
242         <rdar://problem/32951132>
243
244         Rubber-stamped by Aakash Jain.
245
246         When running layout tests, we should support multiple version of iOS the same way we do Mac.
247
248         * Scripts/webkitpy/port/ios.py:
249         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
250         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
251         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
252         * Scripts/webkitpy/port/ios_device.py:
253         (IOSDevicePort.ios_version): Ask connected devices for implementation.
254         * Scripts/webkitpy/port/ios_device_unittest.py:
255         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
256         (IOSDeviceTest.test_baseline_searchpath): Ditto.
257         (IOSDeviceTest.test_expectations_ordering): Ditto.
258         * Scripts/webkitpy/port/ios_simulator.py:
259         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
260         ask the platform.
261
262 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
263
264         Fontconfig build breaks with glibc 2.15+
265         https://bugs.webkit.org/show_bug.cgi?id=174019
266
267         Reviewed by Carlos Alberto Lopez Perez.
268
269         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
270
271         * wpe/jhbuild.modules:
272         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
273
274 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
275
276         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
277         https://bugs.webkit.org/show_bug.cgi?id=174010
278         <rdar://problem/32597802>
279
280         Reviewed by Tim Horton.
281
282         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
283         snapshot fails for any reason.
284
285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
286         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
287         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
288         (TestWebKitAPI::TEST):
289
290 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
291
292         AX: Cannot call setValue() on contenteditable or ARIA text controls
293         https://bugs.webkit.org/show_bug.cgi?id=173520
294
295         Reviewed by Ryosuke Niwa.
296
297         Add setValue() method to WKTR (already existed in DRT).
298
299         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
300         (WTR::AccessibilityUIElement::setValue):
301         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
302         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
303         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
304         (WTR::AccessibilityUIElement::setValue):
305
306 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
307
308         getBoundingClientRect returns wrong value for combination of page zoom and scroll
309         https://bugs.webkit.org/show_bug.cgi?id=173841
310         rdar://problem/32983841
311
312         Reviewed by Dean Jackson.
313
314         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
315         always did text zooming.
316
317         * MiniBrowser/mac/WK1BrowserWindowController.m:
318         (-[WK1BrowserWindowController zoomIn:]):
319         (-[WK1BrowserWindowController zoomOut:]):
320         (-[WK1BrowserWindowController canResetZoom]):
321         (-[WK1BrowserWindowController resetZoom:]):
322
323 2017-06-29  John Wilander  <wilander@apple.com>
324
325         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
326         https://bugs.webkit.org/show_bug.cgi?id=173940
327         <rdar://problem/33018125>
328
329         Reviewed by Brent Fulgham.
330
331         This change allows the TestController to turn off
332         regular resource load statistics telemetry submission
333         and to manually control when telemetry is calculated
334         and submitted.
335
336         * WebKitTestRunner/TestController.cpp:
337         (WTR::TestController::initialize):
338             Turns off automatic resource load statistics telemetry submission.
339
340 2017-06-29  Commit Queue  <commit-queue@webkit.org>
341
342         Unreviewed, rolling out r218512.
343         https://bugs.webkit.org/show_bug.cgi?id=173981
344
345         "It changes the behavior of the JS API's JSEvaluateScript
346         which breaks TurboTax" (Requested by saamyjoon on #webkit).
347
348         Reverted changeset:
349
350         "test262: Completion values for control flow do not match the
351         spec"
352         https://bugs.webkit.org/show_bug.cgi?id=171265
353         http://trac.webkit.org/changeset/218512
354
355 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
356
357         Add WebKitSystemInterface for iOS 11
358         https://bugs.webkit.org/show_bug.cgi?id=173936
359
360         Reviewed by Lucas Forschler.
361
362         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
363
364 2017-06-28  Keith Miller  <keith_miller@apple.com>
365
366         VMTraps has some races
367         https://bugs.webkit.org/show_bug.cgi?id=173941
368
369         Reviewed by Michael Saboff.
370
371         Add new testing mode for testing the Watchdog with our stress
372         tests.
373
374         * Scripts/run-jsc-stress-tests:
375
376 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
377
378         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
379         https://bugs.webkit.org/show_bug.cgi?id=173877
380
381         Reviewed by Brady Eidson.
382
383         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
384         the next tests.
385
386         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
387         (testGetFavicon):
388
389 2017-06-28  Tim Horton  <timothy_horton@apple.com>
390
391         MobileSafari was constantly using 10-15% CPU viewing a PDF
392         https://bugs.webkit.org/show_bug.cgi?id=173944
393         <rdar://problem/33039910>
394
395         Reviewed by Simon Fraser.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
399         Add a test that we ever call the stable presentation update callback
400         when we have a WKPDFView up, instead of infinitely looping.
401
402 2017-06-28  Alex Christensen  <achristensen@webkit.org>
403
404         Prevent displaying URLs with small capital letters
405         https://bugs.webkit.org/show_bug.cgi?id=173949
406         <rdar://problem/32952058>
407
408         Reviewed by Brent Fulgham.
409
410         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
411         (TestWebKitAPI::TEST):
412
413 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
414
415         Unreviewed test fix.
416
417         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
418
419         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
420
421 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
422
423         Teach ResourceLoadStatistics to recognize changes in the file system
424         https://bugs.webkit.org/show_bug.cgi?id=173800
425         <rdar://problem/32937842>
426
427         Reviewed by Chris Dumez.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
431         (TestWebKitAPI::FileMonitorTest::tempFilePath):
432         (TestWebKitAPI::handleFileModification):
433         (TestWebKitAPI::handleFileDeletion):
434         (TestWebKitAPI::resetTestState):
435         (TestWebKitAPI::TEST_F):
436
437 2017-06-28  Brady Eidson  <beidson@apple.com>
438
439         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
440         https://bugs.webkit.org/show_bug.cgi?id=173874
441
442         Reviewed by Alex Christensen.
443
444         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
445
446 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
447
448         Unreviewed, adding Don Olmstead to contributors.json
449
450         * Scripts/webkitpy/common/config/contributors.json:
451
452 2017-06-28  Alex Christensen  <achristensen@webkit.org>
453
454         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
455         https://bugs.webkit.org/show_bug.cgi?id=173886
456         <rdar://problem/32543191>
457
458         Reviewed by Andy Estes.
459
460         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
461         (ParsedRange::ParsedRange):
462         (-[TestSchemeHandler initWithVideoData:]):
463         (-[TestSchemeHandler webView:startURLSchemeTask:]):
464         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
465         (TEST):
466
467 2017-06-27  JF Bastien  <jfbastien@apple.com>
468
469         WebAssembly: running out of executable memory should throw OoM
470         https://bugs.webkit.org/show_bug.cgi?id=171537
471         <rdar://problem/32963338>
472
473         Reviewed by Saam Barati.
474
475         * Scripts/run-jsc-stress-tests: add a configuration which runs the
476         tests under limited executable memory and avoids non-WebAssembly
477         code generation so that we more reliably run out of executable
478         memory in WebAssembly.
479
480 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
481
482         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
483         https://bugs.webkit.org/show_bug.cgi?id=173854
484         <rdar://problem/32236827>
485
486         Reviewed by Ryosuke Niwa and Tim Horton.
487
488         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
489
490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
491         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
492         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
493         (TestWebKitAPI::TEST):
494
495 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
496
497         [PAL] Add symbol export macros for PAL
498         https://bugs.webkit.org/show_bug.cgi?id=171519
499
500         Reviewed by Konstantin Tokarev.
501
502         * DumpRenderTree/config.h:
503         * TestWebKitAPI/CMakeLists.txt:
504         * TestWebKitAPI/config.h:
505         * WebKitTestRunner/config.h:
506
507 2017-06-27  John Wilander  <wilander@apple.com>
508
509         Resource Load Statistics: Add telemetry
510         https://bugs.webkit.org/show_bug.cgi?id=173499
511         <rdar://problem/32826094>
512
513         Reviewed by Brent Fulgham.
514
515         Adds three new testRunner functions:
516         - installStatisticsDidRunTelemetryCallback()
517         - statisticsFireTelemetryHandler()
518         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
519
520         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
521         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
522         (WTR::InjectedBundle::didReceiveMessageToPage):
523         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
524         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
525         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
526         (WTR::TestRunner::statisticsFireTelemetryHandler):
527         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
529         * WebKitTestRunner/TestController.cpp:
530         (WTR::TestController::resetStateToConsistentValues):
531         (WTR::TestController::statisticsFireTelemetryHandler):
532         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
533         * WebKitTestRunner/TestController.h:
534         * WebKitTestRunner/TestInvocation.cpp:
535         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
536
537 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
538
539         Add missing includes to fix compilation error on FreeBSD
540         https://bugs.webkit.org/show_bug.cgi?id=172919
541
542         Reviewed by Mark Lam.
543
544         * ImageDiff/cairo/PlatformImageCairo.cpp:
545
546 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
547
548         Unreviewed, rolling out r218783.
549
550         Causing accessibility/mac/setting-attributes-is-
551         asynchronous.html to crash consistently on mac-wk2 Debug
552
553         Reverted changeset:
554
555         "AX: Cannot call setValue() on contenteditable or ARIA text
556         controls"
557         https://bugs.webkit.org/show_bug.cgi?id=173520
558         http://trac.webkit.org/changeset/218783
559
560 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
561
562         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
563         https://bugs.webkit.org/show_bug.cgi?id=173825
564
565         Reviewed by Saam Barati.
566
567         * DumpRenderTree/JavaScriptThreading.cpp:
568         (runJavaScriptThread):
569         (startJavaScriptThreads):
570         * DumpRenderTree/mac/DumpRenderTree.mm:
571         (runThread):
572         (runPthread):
573         (testThreadIdentifierMap):
574
575 2017-06-26  David Kilzer  <ddkilzer@apple.com>
576
577         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
578         <https://webkit.org/b/173837>
579
580         Reviewed by Geoffrey Garen.
581
582         The clang static analyzer can't reason about objects that are
583         assigned to a delegate as +1 retained, and then released
584         later in a different method when the delegate is cleared.
585
586         Instead, use a common idiom where the object setting the
587         delegate retains it as an instance variable on initialization.
588         Then the same object clears the delegate and releases its
589         instance variable during teardown.
590
591         Also add EXPECT_TRUE() tests to make sure the delegate objects
592         match before teardown.
593
594         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
595         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
596         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
597         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
598         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
599         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
600
601 2017-06-26  David Kilzer  <ddkilzer@apple.com>
602
603         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
604         <https://webkit.org/b/173836>
605
606         Reviewed by Brady Eidson.
607
608         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
609         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
610         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
611         objects in this test.
612
613 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
614
615         [ATK] Add support for aria-details and aria-errormessage
616         https://bugs.webkit.org/show_bug.cgi?id=172588
617
618         Reviewed by Chris Fleizach.
619
620         Add additional methods to test ARIA properties which are exposed via
621         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
622         to versions which support the details and error-message relation types.
623
624         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
625         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
626         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
627         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
628         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
629         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
630         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
631         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
632         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
633         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
634         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
635         * gtk/jhbuild.modules:
636
637 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
638
639         Unreviewed. Add libfii to GTK+ install dependencies script.
640
641         * gtk/install-dependencies:
642
643 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
644
645         Unreviewed, rolling out r215190.
646
647         Broke product select element on GNOME Bugzilla
648
649         Reverted changeset:
650
651         "[GTK] Misplaced right click menu on web page due to
652         deprecated gtk_menu_popup()"
653         https://bugs.webkit.org/show_bug.cgi?id=170553
654         http://trac.webkit.org/changeset/215190
655
656 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
657
658         Remove Reflect.enumerate
659         https://bugs.webkit.org/show_bug.cgi?id=173806
660
661         Reviewed by Yusuke Suzuki.
662
663         * Scripts/run-jsc-stress-tests:
664
665 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
666
667         AX: Cannot call setValue() on contenteditable or ARIA text controls
668         https://bugs.webkit.org/show_bug.cgi?id=173520
669
670         Reviewed by Ryosuke Niwa.
671
672         Add setValue() method to WKTR (already existed in DRT).
673
674         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
675         (WTR::AccessibilityUIElement::setValue):
676         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
677         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
678         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
679         (WTR::AccessibilityUIElement::setValue):
680
681 2017-06-23  Keith Miller  <keith_miller@apple.com>
682
683         Switch VMTraps to use halt instructions rather than breakpoint instructions
684         https://bugs.webkit.org/show_bug.cgi?id=173677
685
686         Reviewed by JF Bastien.
687
688         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
689         (TEST):
690
691 2017-06-23  Youenn Fablet  <youenn@apple.com>
692
693         Set getUserMedia permission to true by default on WTR
694         https://bugs.webkit.org/show_bug.cgi?id=173610
695
696         Reviewed by Alex Christensen.
697
698         Adding a way to reset the getUserMedia permission to pending.
699
700         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
701         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
702         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
703         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
704         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
705         (WTR::TestRunner::setUserMediaPermissionAsUnset):
706         * WebKitTestRunner/InjectedBundle/TestRunner.h:
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::TestController::resetStateToConsistentValues):
709         (WTR::TestController::setUserMediaPermissionAsUnset):
710         * WebKitTestRunner/TestController.h:
711         * WebKitTestRunner/TestInvocation.cpp:
712         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
713
714 2017-06-23  Alex Christensen  <achristensen@webkit.org>
715
716         Add SPI to WKURLSchemeTask for redirection
717         https://bugs.webkit.org/show_bug.cgi?id=173730
718
719         Reviewed by Brady Eidson.
720
721         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
722         (-[SchemeHandler webView:startURLSchemeTask:]):
723         (-[SchemeHandler webView:stopURLSchemeTask:]):
724         (TEST):
725         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
726         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
727         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
728         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
729         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
730
731 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
732
733         [WPE] Use JSC API to send script messages from web extension in tests
734         https://bugs.webkit.org/show_bug.cgi?id=173757
735
736         Reviewed by Žan Doberšek.
737
738         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
739         to run postMessage().
740
741         Fixes: /wpe/WebKitSecurityManager/file-xhr
742                /wpe/WebKitConsoleMessage/console-api
743                /wpe/WebKitConsoleMessage/js-exception
744                /wpe/WebKitConsoleMessage/network-error
745                /wpe/WebKitConsoleMessage/security-error
746
747         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
748         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
749         (beforeAll): Ditto.
750         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
751         (testWebContextSecurityFileXHR): Ditto.
752         (beforeAll): Ditto.
753         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
754         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
755         (pageCreatedCallback): Remove ifdefs.
756
757 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
758
759         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
760
761         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
762         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
763         doesn't exist yet in WPE.
764
765         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
766         (testWebViewJavaScriptDialogs):
767         (testWebViewWindowProperties):
768
769 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
770
771         [GTK] Upgrade pixman and cairo in jhbuild
772         https://bugs.webkit.org/show_bug.cgi?id=173710
773
774         Reviewed by Carlos Alberto Lopez Perez.
775
776         * gtk/jhbuild.modules:
777
778 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
779
780         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
781         https://bugs.webkit.org/show_bug.cgi?id=173711
782
783         Reviewed by Carlos Alberto Lopez Perez.
784
785         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
786         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
787
788         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
789         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
790
791 2017-06-22  David Kilzer  <ddkilzer@apple.com>
792
793         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
794         <https://webkit.org/b/173721>
795
796         Reviewed by Joseph Pecoraro.
797
798         Use RetainPtr<> to create NSMutableDictionary and NSNumber
799         objects to fix leaks and to avoid the autoreleasepool.
800
801         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
802         (TEST):
803
804 2017-06-22  Matt Lewis  <jlewis3@apple.com>
805
806         Unreviewed, rolling out r218633.
807
808         The test is failing frequently on Sierra Debug and Windows
809
810         Reverted changeset:
811
812         "AX: Cannot call setValue() on contenteditable or ARIA text
813         controls"
814         https://bugs.webkit.org/show_bug.cgi?id=173520
815         http://trac.webkit.org/changeset/218633
816
817 2017-06-22  David Kilzer  <ddkilzer@apple.com>
818
819         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
820         <https://webkit.org/b/173690>
821
822         Reviewed by Chris Dumez.
823
824         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
825         ownership of malloc()-ed memory, then frees it when it's
826         released.  These tests were passing global variables into the
827         method, which is not malloc()-ed memory, which violates the API
828         contract.
829
830         The fix is to switch to use
831         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
832         NO for the last argument.
833
834         Caught by the clang static analyzer.
835
836         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
837         (TEST):
838         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
839         (TEST):
840
841 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
842
843         [GTK] Upgrade Harfbuzz to version 1.4.2
844         https://bugs.webkit.org/show_bug.cgi?id=173592
845
846         Reviewed by Carlos Alberto Lopez Perez.
847
848         * gtk/jhbuild.modules:
849
850 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
851
852         [WPE] Update WPEBackend-mesa
853         https://bugs.webkit.org/show_bug.cgi?id=173705
854
855         Reviewed by Carlos Alberto Lopez Perez.
856
857         A crash has been fixed, needed for unit tests to work.
858
859         * wpe/jhbuild.modules:
860
861 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         Remove unused coordinated graphics C API
864         https://bugs.webkit.org/show_bug.cgi?id=173706
865
866         Reviewed by Žan Doberšek.
867
868         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
869         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
870         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
871         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
872         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
873         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
874
875 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
876
877         [WPE] Build glib API tests
878         https://bugs.webkit.org/show_bug.cgi?id=173702
879
880         Reviewed by Žan Doberšek.
881
882         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
883         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
884         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
885         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
886         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
887         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
888         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
889         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
890         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
891         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
892         and implement the missing features.
893
894         * CMakeLists.txt:
895         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
896         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
897         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
898         (testAutomationSessionRequestSession):
899         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
900         (testWebKitWebViewSessionState):
901         (testWebKitWebViewSessionStateWithFormData):
902         (testWebKitWebViewNavigationAfterSessionRestore):
903         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
904         (beforeAll):
905         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
906         (testCookieManagerEphemeral):
907         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
908         (testBlobDownload):
909         (beforeAll):
910         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
911         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
912         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
913         (testProcessPerWebView):
914         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
915         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
916         (testWebViewCreateNavigationData):
917         (testWebViewJavaScriptDialogs):
918         (testWebViewWindowProperties):
919         (testWebViewMouseTarget):
920         (testWebViewGeolocationPermissionRequests):
921         (testWebViewUserMediaPermissionRequests):
922         (testWebViewAudioOnlyUserMediaPermissionRequests):
923         (testWebViewFileChooserRequest):
924         (beforeAll):
925         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
926         (beforeAll):
927         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
928         (testPrivateBrowsing):
929         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
930         (testFindControllerHide):
931         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
932         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
933         (testWebKitSettings):
934         (beforeAll):
935         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
936         (testWebViewNewWithUserContentManager):
937         (beforeAll):
938         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
939         (testWebContextEphemeral):
940         (testWebContextProxySettings):
941         (beforeAll):
942         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
943         (testWebViewWebContext):
944         (testWebViewWebContextLifetime):
945         (testWebViewEphemeral):
946         (testWebViewSettings):
947         (testWebViewCanShowMIMEType):
948         (testWebViewPageVisibility):
949         (testWebViewIsPlayingAudio):
950         (beforeAll):
951         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
952         (testWebsiteDataEphemeral):
953         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
954         (documentLoadedCallback):
955         (pageCreatedCallback):
956         (methodCallCallback):
957         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
958         * TestWebKitAPI/glib/CMakeLists.txt:
959         * TestWebKitAPI/glib/PlatformGTK.cmake:
960         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
961         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
962         (main):
963         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
964         (Test::adoptView):
965         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
966         (WebKitTestBus::run):
967         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
968         (WebViewTest::~WebViewTest):
969         (WebViewTest::initializeWebView):
970         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
971         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
972         (WebViewTest::platformDestroy):
973         (WebViewTest::platformInitializeWebView):
974         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
975         (WebViewTest::resizeView):
976         (WebViewTest::hideView):
977         (parentWindowMapped):
978         (WebViewTest::showInWindow):
979         (WebViewTest::showInWindowAndWaitUntilMapped):
980         (WebViewTest::mouseMoveTo):
981         (WebViewTest::clickMouseButton):
982         (WebViewTest::emitPopupMenuSignal):
983         (WebViewTest::keyStroke):
984         (WebViewTest::doMouseButtonEvent):
985         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
986         (WebViewTest::platformDestroy):
987         (WebViewTest::platformInitializeWebView):
988         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
989         (WebViewTest::resizeView):
990         (WebViewTest::hideView):
991         (WebViewTest::mouseMoveTo):
992         (WebViewTest::clickMouseButton):
993         (WebViewTest::keyStroke):
994
995 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
996
997         [GTK] Move WebKit2 GLib API tests to glib directories
998         https://bugs.webkit.org/show_bug.cgi?id=173642
999
1000         Reviewed by Žan Doberšek.
1001
1002         * CMakeLists.txt:
1003         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
1004         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
1005         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
1006         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
1007         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
1008         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
1009         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
1010         (testWebKitConsoleMessageNetworkError):
1011         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
1012         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
1013         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
1014         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
1015         (testLoadFromGResource):
1016         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
1017         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
1018         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
1019         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
1020         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
1021         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
1022         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
1023         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
1024         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
1025         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
1026         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
1027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
1028         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
1029         (testWebViewRunJavaScript):
1030         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
1031         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
1032         (registerGResource):
1033         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
1034         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
1035         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
1036         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
1037         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
1038         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
1039         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
1040         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
1041         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
1042         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
1043         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
1044         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
1045         * TestWebKitAPI/glib/CMakeLists.txt: Added.
1046         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
1047         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
1048         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
1049         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
1050         (registerGResource):
1051         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
1052         (Test::getResourcesDir):
1053         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
1054         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
1055         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
1056         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
1057         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
1058         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
1059
1060 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1061
1062         [WPE] Add initial web extensions API
1063         https://bugs.webkit.org/show_bug.cgi?id=173640
1064
1065         Reviewed by Žan Doberšek.
1066
1067         Add style checker exceptions for WPE web extensions API files.
1068
1069         * Scripts/webkitpy/style/checker.py:
1070
1071 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1072
1073         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
1074         https://bugs.webkit.org/show_bug.cgi?id=173659
1075         <rdar://problem/32879788>
1076
1077         Reviewed by Tim Horton.
1078
1079         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
1080
1081         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
1082
1083         Augment this test page to log dragend and dragstart events on the drag source as well.
1084
1085         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1086         (checkStringArraysAreEqual):
1087         (TestWebKitAPI::TEST):
1088
1089 2017-06-21  Antoine Quint  <graouts@apple.com>
1090
1091         Ensure DRT always logs rAF suspension debugging code
1092         https://bugs.webkit.org/show_bug.cgi?id=173681
1093
1094         Reviewed by Tim "Mr. T" Horton.
1095
1096         * DumpRenderTree/mac/DumpRenderTree.mm:
1097         (resetWebPreferencesToConsistentValues):
1098
1099 2017-06-21  Chris Dumez  <cdumez@apple.com>
1100
1101         Allow constructing a WTF:Function from a function pointer
1102         https://bugs.webkit.org/show_bug.cgi?id=173660
1103
1104         Reviewed by Alex Christensen.
1105
1106         Add API test coverage.
1107
1108         * TestWebKitAPI/Tests/WTF/Function.cpp:
1109         (TestWebKitAPI::returnThree):
1110         (TestWebKitAPI::returnFour):
1111         (TestWebKitAPI::returnPassedValue):
1112         (TestWebKitAPI::TEST):
1113
1114 2017-06-21  Antoine Quint  <graouts@apple.com>
1115
1116         Add logging to identify when the Page suspends scripted animations
1117         https://bugs.webkit.org/show_bug.cgi?id=173626
1118
1119         Reviewed by Tim Horton.
1120
1121         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
1122
1123         * DumpRenderTree/mac/DumpRenderTree.mm:
1124         (resetWebPreferencesToConsistentValues):
1125
1126 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
1127
1128         AX: Cannot call setValue() on contenteditable or ARIA text controls
1129         https://bugs.webkit.org/show_bug.cgi?id=173520
1130
1131         Reviewed by Ryosuke Niwa.
1132
1133         Add setValue() method to WKTR (already existed in DRT).
1134
1135         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1136         (WTR::AccessibilityUIElement::setValue):
1137         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1138         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1139         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1140         (WTR::AccessibilityUIElement::setValue):
1141
1142 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
1143
1144         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
1145         as one of the dependencies required to build the product.
1146
1147         Rubber-stamped by Carlos Garcia Campos.
1148
1149         * gtk/install-dependencies:
1150         * wpe/install-dependencies:
1151
1152 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1153
1154         Disable font variations on macOS Sierra and iOS 10
1155         https://bugs.webkit.org/show_bug.cgi?id=173618
1156         <rdar://problem/32879164>
1157
1158         Reviewed by Jon Lee.
1159
1160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1161
1162 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1163
1164         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
1165         https://bugs.webkit.org/show_bug.cgi?id=173578
1166         <rdar://problem/32825028>
1167
1168         Reviewed by Tim Horton.
1169
1170         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
1171         a custom popover does not cause dragging to fail when the popover is presented.
1172
1173         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1174         (-[DataInteractionSimulator _advanceProgress]):
1175
1176 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1177
1178         [WPE] Add initial implementation of glib API
1179         https://bugs.webkit.org/show_bug.cgi?id=173546
1180
1181         Reviewed by Žan Doberšek.
1182
1183         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
1184         include WPE glib API files.
1185
1186         * Scripts/webkitperl/FeatureList.pm:
1187         * Scripts/webkitpy/style/checker.py:
1188         * Scripts/webkitpy/style/checkers/cpp.py:
1189         (check_identifier_name_in_declaration):
1190
1191 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         [GTK] Upgrade to ICU to version 57.1
1194         https://bugs.webkit.org/show_bug.cgi?id=173538
1195
1196         Reviewed by Žan Doberšek.
1197
1198         * gtk/jhbuild.modules:
1199
1200 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1201
1202         [GTK] Remove unneeded modules from the jhbuild
1203         https://bugs.webkit.org/show_bug.cgi?id=170540
1204
1205         Reviewed by Michael Catanzaro.
1206
1207         We are building libxslt and libffi that we don't really need to build from sources.
1208
1209         * gtk/jhbuild.modules:
1210
1211 2017-06-19  Frederic Wang  <fwang@igalia.com>
1212
1213         [Mac] Add an experimental feature setting for async frame scrolling
1214         https://bugs.webkit.org/show_bug.cgi?id=173359
1215
1216         Reviewed by Simon Fraser.
1217
1218         * DumpRenderTree/mac/DumpRenderTree.mm:
1219         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1220         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1221         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1222         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1223
1224 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1225
1226         Unreviewed, adding myself to contributors.json
1227
1228         * Scripts/webkitpy/common/config/contributors.json:
1229
1230 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1231
1232         test262: Completion values for control flow do not match the spec
1233         https://bugs.webkit.org/show_bug.cgi?id=171265
1234
1235         Reviewed by Saam Barati.
1236
1237         * Scripts/run-jsc-stress-tests:
1238         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1239
1240 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1241
1242         Opening certain mails brings up a mail that grows indefinitely.
1243         https://bugs.webkit.org/show_bug.cgi?id=173562
1244         <rdar://problem/32766579>
1245
1246         Reviewed by Tim Horton.
1247
1248         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1249         (TEST):
1250
1251 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1252
1253         [iOS DnD] Support .zip archives for file uploads via drag and drop
1254         https://bugs.webkit.org/show_bug.cgi?id=173511
1255         <rdar://problem/32521025>
1256
1257         Reviewed by Tim Horton.
1258
1259         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1260         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1264         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1265         (testZIPArchive):
1266         (TestWebKitAPI::TEST):
1267
1268 2017-06-18  Darin Adler  <darin@apple.com>
1269
1270         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1271         https://bugs.webkit.org/show_bug.cgi?id=173526
1272
1273         Reviewed by Sam Weinig.
1274
1275         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1277
1278         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1279         tests for assignment before destruction ones.
1280
1281         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1282         as a function, so it can be used in WTF::Function tests.
1283
1284         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1285         Added tests for swap and for assignment before deref.
1286
1287         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1288         to inline everything. Also removed the unnecessary clearing of the log every time
1289         the DerivedRefLogger constructor is called.
1290         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1291
1292         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1293         Added tests for assignment before deref and similar for releaseNonNull.
1294
1295 2017-06-19  Sam Weinig  <sam@webkit.org>
1296
1297         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1298         https://bugs.webkit.org/show_bug.cgi?id=173513
1299
1300         Reviewed by Alex Christensen.
1301
1302         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1303         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1304         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1305
1306 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1307
1308         [Win] fast/dom/assign-to-window-status.html is flaky.
1309         https://bugs.webkit.org/show_bug.cgi?id=173512
1310
1311         Reviewed by Alex Christensen.
1312
1313         We should not dump status callbacks when test is done.
1314
1315         * DumpRenderTree/win/UIDelegate.cpp:
1316         (UIDelegate::setStatusText):
1317
1318 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1319
1320         [WPE][JHBuild] Update WPEBackend-mesa
1321         https://bugs.webkit.org/show_bug.cgi?id=173433
1322
1323         Unreviewed.
1324
1325         Update WPEBackend-mesa back (like it was done originally in r218344)
1326         after fixing the issue with the DISPLAY environment variables that
1327         caused the crashes.
1328
1329         * wpe/jhbuild.modules:
1330
1331 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1332
1333         Rename unit test file after r218482
1334         https://bugs.webkit.org/show_bug.cgi?id=173483
1335
1336         Unreviewed.
1337
1338         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1339
1340 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1341
1342         Unreviewed. Fix wrong style checker condition added in r218487.
1343
1344         * Scripts/webkitpy/style/checkers/cpp.py:
1345         (check_identifier_name_in_declaration):
1346
1347 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1348
1349         Missing <functional> includes make builds fail with GCC 7.x
1350         https://bugs.webkit.org/show_bug.cgi?id=173544
1351
1352         Unreviewed gardening.
1353
1354         Fix compilation with GCC 7.
1355
1356         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1357         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1358
1359 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1360
1361         [GTK] Move GTK+ API files that could be shared to glib dirs
1362         https://bugs.webkit.org/show_bug.cgi?id=173545
1363
1364         Reviewed by Žan Doberšek.
1365
1366         Update paths of GTK+ API in watchlist and style checker.
1367
1368         * Scripts/webkitpy/common/config/watchlist:
1369         * Scripts/webkitpy/style/checker.py:
1370         * Scripts/webkitpy/style/checkers/cpp.py:
1371         (check_identifier_name_in_declaration):
1372
1373 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1374
1375         Port setup_environ_for_server should not set environment variables related with the driver.
1376         https://bugs.webkit.org/show_bug.cgi?id=173483
1377
1378         Reviewed by Carlos Garcia Campos.
1379
1380         The port setup_environ_for_server() should not set environment variables
1381         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1382         This varibles should be only set on the driver setup_environ_for_test().
1383
1384         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1385         into the test environment even when running the tests with a driver
1386         that is not the Xorg or Xvfb one.
1387
1388         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1389         (Port.to.setup_environ_for_server):
1390         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1391         (Driver._setup_environ_for_driver):
1392         * Scripts/webkitpy/port/driver_unittest.py:
1393         (DriverTest.test_setup_environ_for_test):
1394         (DriverTest):
1395         (DriverTest.test_setup_environ_base_vars):
1396         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1397         (GtkPort.setup_environ_for_server):
1398         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1399         (WaylandDriverTest):
1400         (WaylandDriverTest.make_driver):
1401         (WaylandDriverTest.make_environment):
1402         (WaylandDriverTest.test_checkdriver):
1403         (WaylandDriverTest.test_environment_needed_variables):
1404         (WaylandDriverTest.test_environment_forbidden_variables):
1405         (WaylandDriverTest.test_environment_optional_variables):
1406         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1407         (WaylandDriver.check_driver):
1408         (WaylandDriver._setup_environ_for_test):
1409         * Scripts/webkitpy/port/xorgdriver.py:
1410         (XorgDriver.check_driver):
1411         (XorgDriver._setup_environ_for_test):
1412         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1413         (XorgDriverTest):
1414         (XorgDriverTest.make_driver):
1415         (XorgDriverTest.make_environment):
1416         (XorgDriverTest.test_checkdriver):
1417         (XorgDriverTest.test_environment_needed_variables):
1418         (XorgDriverTest.test_environment_forbidden_variables):
1419         (XorgDriverTest.test_environment_optional_variables):
1420         * Scripts/webkitpy/port/xvfbdriver.py:
1421         (XvfbDriver._setup_environ_for_test):
1422         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1423         (XvfbDriverTest.assertDriverStartSuccessful):
1424
1425
1426 2017-05-14 Frederic Wang  <fwang@igalia.com>
1427
1428         Add heuristic to avoid flattening "fullscreen" iframes
1429         https://bugs.webkit.org/show_bug.cgi?id=171914
1430
1431         Reviewed by Simon Fraser.
1432
1433         * DumpRenderTree/mac/DumpRenderTree.mm:
1434         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1435
1436 2017-06-18  Chris Dumez  <cdumez@apple.com>
1437
1438         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1439         https://bugs.webkit.org/show_bug.cgi?id=173522
1440         <rdar://problem/31185739>
1441
1442         Reviewed by Darin Adler.
1443
1444         Add API test for re-entering Function's assignment operators.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1448         (TestWebKitAPI::TestObject::TestObject):
1449         (TestWebKitAPI::TestObject::~TestObject):
1450         (TestWebKitAPI::TestObject::operator()):
1451         (TestWebKitAPI::TEST):
1452
1453 2017-06-16  Dan Bernstein  <mitz@apple.com>
1454
1455         [Cocoa] Some declarations have missing or incorrect availability attributes
1456         https://bugs.webkit.org/show_bug.cgi?id=173508
1457
1458         Reviewed by Tim Horton.
1459
1460         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1461         (TestWebKitAPI::TEST): Updated for renames.
1462
1463 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1464
1465         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1466         https://bugs.webkit.org/show_bug.cgi?id=173366
1467         <rdar://problem/32767014>
1468
1469         Reviewed by Tim Horton.
1470
1471         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1472         change in behavior.
1473
1474         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1476         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1477         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1478         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1479         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1480         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1481         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1482         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1483         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1484         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1485         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1486         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1487         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1488         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1489         (-[MockDragDropSession initWithItems:location:window:]):
1490         (-[MockDragDropSession allowsMoveOperation]):
1491         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1492         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1493         (-[MockDragDropSession canLoadObjectsOfClass:]):
1494         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1495         (-[MockDragDropSession items]):
1496         (-[MockDragDropSession setItems:]):
1497         (-[MockDragDropSession locationInView:]):
1498         (-[MockDataOperationSession initWithProviders:location:window:]):
1499         (-[MockDataOperationSession session]):
1500         (-[MockDataOperationSession isLocal]):
1501         (-[MockDataOperationSession progress]):
1502         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1503         (-[MockDataOperationSession progressIndicatorStyle]):
1504         (-[MockDataOperationSession operationMask]):
1505         (-[MockDataOperationSession localDragSession]):
1506         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1507         (-[MockDataOperationSession canCreateItemsOfClass:]):
1508         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1509         (-[MockDataInteractionSession initWithWindow:]):
1510         (-[MockDataInteractionSession localOperationMask]):
1511         (-[MockDataInteractionSession externalOperationMask]):
1512         (-[MockDataInteractionSession session]):
1513         (-[DataInteractionSimulator _advanceProgress]):
1514
1515 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1516
1517         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1518         https://bugs.webkit.org/show_bug.cgi?id=173431
1519
1520         Reviewed by Darin Adler.
1521
1522         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1523         (TestWebKitAPI::TEST):
1524
1525 2017-06-16  Chris Dumez  <cdumez@apple.com>
1526
1527         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1528         https://bugs.webkit.org/show_bug.cgi?id=173472
1529         <rdar://problem/28858817>
1530
1531         Reviewed by Brady Eidson.
1532
1533         Add API test coverage.
1534
1535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1536         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1537         (TEST):
1538
1539 2017-06-16  Brady Eidson  <beidson@apple.com>
1540
1541         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1542         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1543
1544         Reviewed by Daniel Bates.
1545
1546         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1547
1548 2017-06-16  Chris Dumez  <cdumez@apple.com>
1549
1550         DRT fails to reset page visibility between tests
1551         https://bugs.webkit.org/show_bug.cgi?id=173485
1552
1553         Reviewed by Alexey Proskuryakov.
1554
1555         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1556         Fix this to address flakiness.
1557
1558         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1559         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1560         The test became flaky without the DRT change and was no longer flaky with the DRT
1561         change.
1562
1563         WebKitTestRunner already does this.
1564
1565         * DumpRenderTree/mac/DumpRenderTree.mm:
1566         (resetWebViewToConsistentStateBeforeTesting):
1567
1568 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1569
1570         Implement basic authentication in MiniBrowser
1571         https://bugs.webkit.org/show_bug.cgi?id=173443
1572
1573         Reviewed by Tim Horton.
1574
1575         * MiniBrowser/mac/WK2BrowserWindowController.m:
1576         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1577
1578 2017-06-16  Jer Noble  <jer.noble@apple.com>
1579
1580         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1581         https://bugs.webkit.org/show_bug.cgi?id=173398
1582         <rdar://problem/32592961>
1583
1584         Reviewed by Eric Carlson.
1585
1586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1587         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1588         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1589         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1590         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1591         (TestWebKitAPI::TEST):
1592         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1593
1594 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1595
1596         Unreviewed, rolling out r218375.
1597
1598         The API test MediaStreamTrackDetached is still timing out
1599         after the patch
1600
1601         Reverted changeset:
1602
1603         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1604         reports no recording to WebKit clients"
1605         https://bugs.webkit.org/show_bug.cgi?id=173398
1606         http://trac.webkit.org/changeset/218375
1607
1608 2017-06-15  Jer Noble  <jer.noble@apple.com>
1609
1610         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1611         https://bugs.webkit.org/show_bug.cgi?id=173398
1612         <rdar://problem/32592961>
1613
1614         Reviewed by Eric Carlson.
1615
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1618         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1619         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1620         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1623
1624 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1625
1626         Unreviewed, rolling out r218365.
1627
1628         The revision caused API timeouts on all builds.
1629
1630         Reverted changeset:
1631
1632         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1633         reports no recording to WebKit clients"
1634         https://bugs.webkit.org/show_bug.cgi?id=173398
1635         http://trac.webkit.org/changeset/218365
1636
1637 2017-06-15  Jer Noble  <jer.noble@apple.com>
1638
1639         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1640         https://bugs.webkit.org/show_bug.cgi?id=173398
1641         <rdar://problem/32592961>
1642
1643         Reviewed by Eric Carlson.
1644
1645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1646         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1647         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1648         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1649         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1652
1653 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1654
1655         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1656         https://bugs.webkit.org/show_bug.cgi?id=173433
1657
1658         Unreviewed.
1659
1660         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1661
1662 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1663
1664         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1665         https://bugs.webkit.org/show_bug.cgi?id=173061
1666
1667         Reviewed by Žan Doberšek.
1668
1669         Launch dyz <https://github.com/Igalia/dyz> with the script
1670         run-minibrowser for the wpe port. It is now built as part of the
1671         WPE dependencies with JHBuild.
1672
1673         * Scripts/run-minibrowser:
1674         * Scripts/webkitdirs.pm:
1675         (launcherPath):
1676         (launcherName):
1677         * wpe/install-dependencies: Luajit is needed for building dyz.
1678         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1679
1680 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1681
1682         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1683         https://bugs.webkit.org/show_bug.cgi?id=173338
1684         <rdar://problem/32777720>
1685
1686         Reviewed by Tim Horton.
1687
1688         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1689         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1690         these remaining items on drop.
1691
1692         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1693         (TestWebKitAPI::TEST):
1694         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1695         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1696
1697         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1698
1699         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1700
1701 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1702
1703         [Win] Crash in accessibility layout test.
1704         https://bugs.webkit.org/show_bug.cgi?id=173401
1705
1706         Reviewed by Brent Fulgham.
1707
1708         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1709         member will be automatically released when the _variant_t object goes out of scope if the vt member
1710         does not equal VT_UNKNOWN | VT_BYREF.
1711         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1712
1713         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1714         (AccessibilityUIElement::titleUIElement):
1715
1716 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [GTK] Add API to allow overriding popup menus
1719         https://bugs.webkit.org/show_bug.cgi?id=172905
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         Add a unit test to check the new API.
1724
1725         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1726         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1727         (OptionMenuTest::OptionMenuTest):
1728         (OptionMenuTest::~OptionMenuTest):
1729         (OptionMenuTest::destroyMenu):
1730         (OptionMenuTest::showOptionMenuCallback):
1731         (OptionMenuTest::menuCloseCallback):
1732         (OptionMenuTest::showOptionMenu):
1733         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1734         (OptionMenuTest::close):
1735         (OptionMenuTest::activateItem):
1736         (OptionMenuTest::selectItem):
1737         (testOptionMenuSimple):
1738         (testOptionMenuGroups):
1739         (testOptionMenuActivate):
1740         (testOptionMenuSelect):
1741         (beforeAll):
1742         (afterAll):
1743
1744 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1745
1746         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1747         https://bugs.webkit.org/show_bug.cgi?id=173399
1748
1749         Reviewed by Per Arne Vollan.
1750
1751         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1752         Curl port needs to do nothing because libcurl doesn't have disk cache.
1753
1754         * DumpRenderTree/win/DumpRenderTree.cpp:
1755         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1756         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1757
1758 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1759
1760         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1761         https://bugs.webkit.org/show_bug.cgi?id=173356
1762
1763         Reviewed by Michael Catanzaro.
1764
1765         Use the correct operator to compare the strings.
1766
1767         * gtk/install-dependencies:
1768
1769 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1770
1771         Unreviewed, rolling out r218285.
1772         https://bugs.webkit.org/show_bug.cgi?id=173391
1773
1774         API test fails on iOS (Requested by alexchristensen on
1775         #webkit).
1776
1777         Reverted changeset:
1778
1779         "Add SPI for immediate injection of user scripts"
1780         https://bugs.webkit.org/show_bug.cgi?id=173342
1781         http://trac.webkit.org/changeset/218285
1782
1783 2017-06-14  Chris Dumez  <cdumez@apple.com>
1784
1785         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1786         https://bugs.webkit.org/show_bug.cgi?id=173384
1787         <rdar://problem/32723779>
1788
1789         Reviewed by Dan Bernstein.
1790
1791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1792         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1793         Add API test coverage.
1794
1795         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1796         (TestWebKitAPI::Util::sleep):
1797         Update implementation of Util::sleep() so that we actually run the run loop.
1798         Otherwise, we don't process events while sleeping.
1799
1800 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1801
1802         Add SPI for immediate injection of user scripts
1803         https://bugs.webkit.org/show_bug.cgi?id=173342
1804         <rdar://problem/29202285>
1805
1806         Reviewed by Brady Eidson.
1807
1808         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1809         (waitForMessage):
1810         (TEST):
1811
1812 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1813
1814         Add WPE to the flakiness dashboard
1815         https://bugs.webkit.org/show_bug.cgi?id=173365
1816
1817         Reviewed by Carlos Alberto Lopez Perez.
1818
1819         * TestResultServer/static-dashboards/builders.jsonp:
1820         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1821         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1822         (resetGlobals):
1823         * TestResultServer/static-dashboards/loader_unittests.js:
1824
1825 2017-06-14  Brady Eidson  <beidson@apple.com>
1826
1827         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1828         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1829
1830         Reviewed by Alex Christensen.
1831
1832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1833         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1834         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1835         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1836         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1837         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1838         (TEST):
1839
1840 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1841
1842         WKContentViewEditingActions API test always fails
1843         https://bugs.webkit.org/show_bug.cgi?id=173374
1844
1845         Reviewed by Wenson Hsieh.
1846
1847         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1848         (TEST):
1849         selectAll isn't working, because canPerformAction for selectAll returns NO
1850         if selectionIsNone (which is true in the non-contenteditable case).
1851         Instead, make use of r218180's test page, which knows how to select itself.
1852         Also, reset the pasteboard at the beginning of the test to reduce confusion
1853         (I landed the test broken because my simulator had the correct text
1854         stuck in its pasteboard).
1855
1856 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1857
1858         Configure screen scale for running layout tests on plus devices
1859         https://bugs.webkit.org/show_bug.cgi?id=173319
1860
1861         Reviewed by Tim Horton.
1862
1863         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1864         * DumpRenderTree/mac/DumpRenderTree.mm:
1865         (dumpRenderTree): Set screen scale to 2.0.
1866         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1867         add _setScale for UIScreen.
1868         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1869         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1870         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1871         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1872         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1873         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1874         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1875         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1876         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1877         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1878
1879 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1880
1881         Add iOS 11 support to the bot watcher's dashboard
1882         https://bugs.webkit.org/show_bug.cgi?id=173369
1883
1884         Reviewed by Lucas Forschler.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1892
1893 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1894
1895         [GTK][WPE] Raise the timeout values for layout tests
1896         https://bugs.webkit.org/show_bug.cgi?id=173368
1897
1898         Reviewed by Carlos Garcia Campos.
1899
1900         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1901         When running under valgrind a 10x multiplier is applied.
1902
1903         * Scripts/webkitpy/port/gtk.py:
1904         (GtkPort.default_timeout_ms):
1905         * Scripts/webkitpy/port/gtk_unittest.py:
1906         (GtkPortTest.test_default_timeout_ms):
1907         * Scripts/webkitpy/port/wpe.py:
1908         (WPEPort.default_timeout_ms):
1909         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1910         (WPEPortTest):
1911         (WPEPortTest.make_port):
1912         (WPEPortTest.test_default_timeout_ms):
1913         (WPEPortTest.test_get_crash_log):
1914
1915 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1916
1917         Test persistent WKHTTPCookieStorages on iOS.
1918         https://bugs.webkit.org/show_bug.cgi?id=173284
1919
1920         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1921         (TEST):
1922         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1923
1924 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1925
1926         [Win] DRT should not use disk cache.
1927         https://bugs.webkit.org/show_bug.cgi?id=173361
1928
1929         Reviewed by Darin Adler.
1930
1931         Like on macOS/iOS, DRT on Windows should only use memory cache.
1932
1933         * DumpRenderTree/win/DumpRenderTree.cpp:
1934         (setDefaultsToConsistentValuesForTesting):
1935         (prepareConsistentTestingEnvironment):
1936
1937 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1938
1939         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1940         https://bugs.webkit.org/show_bug.cgi?id=171668
1941
1942         Reviewed by Jer Noble.
1943
1944         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1945         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1946         Infinity when the double value passed as argument is greater than 2^64.
1947
1948         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1949         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1950         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1951         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1952         method. No behavior change for rational MediaTime.
1953
1954         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1955         (TestWebKitAPI::TEST):
1956
1957 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1958
1959         Test persistent WKHTTPCookieStorages on iOS
1960         https://bugs.webkit.org/show_bug.cgi?id=173284
1961         <rdar://problem/32260156>
1962
1963         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1964         (TEST):
1965
1966 2017-06-13  Matt Rajca  <mrajca@apple.com>
1967
1968         WebsitePolicies: let clients select specific autoplay quirks
1969         https://bugs.webkit.org/show_bug.cgi?id=173343
1970
1971         Reviewed by Alex Christensen.
1972
1973         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1974         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1975         (TEST): Updated tests.
1976
1977 2017-06-13  Daniel Bates  <dabates@apple.com>
1978
1979         Implement W3C Secure Contexts Draft Specification
1980         https://bugs.webkit.org/show_bug.cgi?id=158121
1981         <rdar://problem/26012994>
1982
1983         Reviewed by Brent Fulgham.
1984
1985         Part 4
1986
1987         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1988         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1989         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1990
1991         * DumpRenderTree/TestOptions.h:
1992         * DumpRenderTree/TestOptions.mm:
1993         (TestOptions::TestOptions):
1994         * DumpRenderTree/mac/DumpRenderTree.mm:
1995         (setWebPreferencesForTestOptions):
1996         * DumpRenderTree/win/DumpRenderTree.cpp:
1997         (enableExperimentalFeatures):
1998         * WebKitTestRunner/TestController.cpp:
1999         (WTR::TestController::resetPreferencesToConsistentValues):
2000         (WTR::updateTestOptionsFromTestHeader):
2001         * WebKitTestRunner/TestOptions.h:
2002         (WTR::TestOptions::hasSameInitializationOptions):
2003
2004 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2005
2006         Test persistent WKHTTPCookieStorages on iOS
2007         https://bugs.webkit.org/show_bug.cgi?id=173284
2008         <rdar://problem/32260156>
2009
2010         Reviewed by Alexey Proskuryakov.
2011
2012         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2013         (TEST):
2014
2015 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2016
2017         [GTK] Blob download doesn't work
2018         https://bugs.webkit.org/show_bug.cgi?id=172442
2019
2020         Reviewed by Carlos Alberto Lopez Perez.
2021
2022         Add a unit test to check blob downloads.
2023
2024         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2025         (testBlobDownload):
2026         (beforeAll):
2027
2028 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2029
2030         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
2031         https://bugs.webkit.org/show_bug.cgi?id=173316
2032
2033         Reviewed by Alex Christensen.
2034
2035         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
2036
2037         * gtk/manifest.txt.in:
2038
2039 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2040
2041         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
2042         https://bugs.webkit.org/show_bug.cgi?id=173315
2043
2044         Reviewed by Darin Adler.
2045
2046         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
2047         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
2048         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
2049         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
2050         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
2051         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
2052         WKGeolocationManagerRef is not destroyed.
2053
2054         * WebKitTestRunner/GeolocationProviderMock.cpp:
2055         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2056         * WebKitTestRunner/GeolocationProviderMock.h:
2057
2058 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2059
2060         Unable to paste text that was copied from a page into the universal search field
2061         https://bugs.webkit.org/show_bug.cgi?id=173293
2062         <rdar://problem/32440918>
2063
2064         Reviewed by Ryosuke Niwa.
2065
2066         Adds 2 new unit tests for copying plain and rich selected web content.
2067         See WebCore and WebKit ChangeLogs for more detail.
2068
2069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2070         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
2071         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
2072         (TestWebKitAPI::dataForPasteboardType):
2073         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2074         (TestWebKitAPI::TEST):
2075
2076 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
2077
2078         AX: [ATK] Implement missing AtkRelation types
2079         https://bugs.webkit.org/show_bug.cgi?id=155494
2080
2081         Reviewed by Darin Adler.
2082
2083         Add additional methods to test ARIA properties which are exposed via
2084         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
2085
2086         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2087         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2088         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2089         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2090         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2091         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2092         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2093         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2094         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2096         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2097         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2098         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2099         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2100         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2101         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2102         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2103         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2104
2105 2017-06-12  Daniel Bates  <dabates@apple.com>
2106
2107         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
2108         https://bugs.webkit.org/show_bug.cgi?id=173286
2109         <rdar://problem/32726102>
2110
2111         Reviewed by Brent Fulgham.
2112
2113         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2114         (TestWebKitAPI::TEST_F):
2115
2116 2017-06-12  Lucas Forschler  <lforschler@apple.com>
2117
2118         <rdar://problem/32683422>
2119         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
2120
2121         Reviewed by Conrad Schultz.
2122
2123         * Scripts/copy-webkitlibraries-to-product-directory:
2124
2125 2017-06-12  Tim Horton  <timothy_horton@apple.com>
2126
2127         [iOS] Cmd-C doesn't copy text from WKWebView
2128         https://bugs.webkit.org/show_bug.cgi?id=173277
2129         <rdar://problem/32396742>
2130
2131         Reviewed by Dan Bernstein.
2132
2133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2134         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2135         Add a test ensuring that -copy on WKContentView will cause text to be copied.
2136
2137 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2138
2139         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2140         https://bugs.webkit.org/show_bug.cgi?id=173197
2141         <rdar://problem/32688148>
2142
2143         Reviewed by Brent Fulgham.
2144
2145         * DumpRenderTree/mac/DumpRenderTree.mm:
2146         (enableExperimentalFeatures):
2147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2148         (WTR::InjectedBundle::beginTesting):
2149         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2150         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
2151         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2152
2153 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2154
2155         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
2156         https://bugs.webkit.org/show_bug.cgi?id=173238
2157         <rdar://problem/31943370>
2158
2159         Reviewed by Ryosuke Niwa and Tim Horton.
2160
2161         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
2162         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
2163         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
2164
2165         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2166         (TestWebKitAPI::TEST):
2167         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2168         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2169         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2170         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
2171
2172 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2173
2174         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
2175         https://bugs.webkit.org/show_bug.cgi?id=173225
2176         <rdar://problem/32713144>
2177
2178         Reviewed by Tim Horton.
2179
2180         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
2181         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
2182
2183         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2184         (TestWebKitAPI::TEST):
2185
2186 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
2187
2188         Return correct process names for iOS on-device testing
2189         https://bugs.webkit.org/show_bug.cgi?id=173263
2190
2191         Reviewed by Alex Christensen.
2192
2193         When running tests on iOS devices, process names do not end with '.Development'
2194         as they do on Mac and iOS simulator.
2195
2196         * WebKitTestRunner/TestController.cpp:
2197         (WTR::TestController::webProcessName): Return correct process name without '.Development'
2198         for iOS on-device testing.
2199         (WTR::TestController::networkProcessName): Ditto.
2200         (WTR::TestController::databaseProcessName): Ditto.
2201
2202 2017-06-12  Chris Dumez  <cdumez@apple.com>
2203
2204         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2205         https://bugs.webkit.org/show_bug.cgi?id=173267
2206         <rdar://problem/32701257>
2207
2208         Reviewed by Simon Fraser.
2209
2210         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2211         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2212         though as this covers the crash that r217867 was fixing.
2213
2214         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2215         (TestWebKitAPI::createSessionStateData):
2216         (TestWebKitAPI::TEST):
2217         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2218
2219 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2220
2221         [GTK] Stop dismissing menus attached to the web view for every injected event
2222         https://bugs.webkit.org/show_bug.cgi?id=172708
2223
2224         Reviewed by Alex Christensen.
2225
2226         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2227         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2228         events while the menu is open.
2229
2230         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2231         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2232         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2233         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2234
2235 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2236
2237         [GTK][WPE] Enable GStreamer GL on development builds
2238         https://bugs.webkit.org/show_bug.cgi?id=173248
2239
2240         Enable GStreamer GL for GTK and WPE.
2241
2242         Reviewed by Carlos Garcia Campos.
2243
2244         * Scripts/webkitperl/FeatureList.pm:
2245
2246 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2249
2250         Notifications are no longer cleared on page navigation.
2251
2252         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2253         (testWebViewNotification):
2254
2255 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2258
2259         DBus interface and object path names were updated in r217831.
2260
2261         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2262
2263 2017-06-10  Dan Bernstein  <mitz@apple.com>
2264
2265         Reverted r218056 because it made the IDE reindex constantly.
2266
2267         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2268         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2269         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2270         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2271         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2272         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2273         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2274         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2275
2276 2017-06-10  Dan Bernstein  <mitz@apple.com>
2277
2278         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2279         https://bugs.webkit.org/show_bug.cgi?id=173223
2280
2281         Reviewed by Sam Weinig.
2282
2283         The rebuilds were happening due to a difference in the compiler options that the IDE and
2284         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2285         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2286         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2287
2288         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2289         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2290         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2291         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2292         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2293         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2294         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2295         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2296
2297 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2298
2299         webkitpy: Reduce polling in ServerProcess
2300         https://bugs.webkit.org/show_bug.cgi?id=173116
2301
2302         Reviewed by Ryosuke Niwa.
2303
2304         We should be smarter about polling. We do not need to poll every time a line is read from
2305         stdout and stderr since lines are usually read from cached data. We should only poll
2306         when extracting that cached data from stdout and stderr.
2307
2308         * Scripts/webkitpy/port/driver.py:
2309         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2310         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2311         * Scripts/webkitpy/port/driver_unittest.py:
2312         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2313         ServerProcess.
2314         * Scripts/webkitpy/port/server_process.py:
2315         (ServerProcess._read): Allow for data to be read from _output even if the process has
2316         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
2317         * Scripts/webkitpy/port/server_process_mock.py:
2318         (MockServerProcess): Add number_of_times_polled.
2319         (MockServerProcess.poll): Increment number_of_times_polled.
2320         (MockServerProcess.has_crashed): Poll before returning crash state.
2321         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2322         just like a ServerProcess would.
2323         (MockServerProcess.read_stdout): Ditto.
2324         * Scripts/webkitpy/port/server_process_unittest.py:
2325         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2326         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2327         (TestServerProcess):
2328         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2329         the processes is polled.
2330         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2331         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2332
2333 2017-06-10  Andy Estes  <aestes@apple.com>
2334
2335         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2336         https://bugs.webkit.org/show_bug.cgi?id=173190
2337         <rdar://problem/31360659>
2338
2339         Reviewed by Brady Eidson.
2340         
2341         Added a release assert that tries to create a proper test failure if the web process crashes.
2342
2343         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2344         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2345
2346 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2347
2348         [iOS DnD] Add a hook to perform two-step drops in editable content
2349         https://bugs.webkit.org/show_bug.cgi?id=172992
2350         <rdar://problem/32590174>
2351
2352         Reviewed by Tim Horton.
2353
2354         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2355         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2356                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2357
2358         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2359         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2360         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2361
2362         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2363         be overridden. Currently, this is overridden to just return true.
2364
2365         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2366         (TestWebKitAPI::TEST):
2367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2368         (WTR::InjectedBundlePage::InjectedBundlePage):
2369
2370 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2371
2372         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2373         https://bugs.webkit.org/show_bug.cgi?id=173103
2374
2375         Reviewed by Xabier Rodriguez-Calvar.
2376
2377         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2378         when building the WPE port through build-webkit.
2379
2380 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2381
2382         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2383         https://bugs.webkit.org/show_bug.cgi?id=173136
2384
2385         Reviewed by Xabier Rodriguez-Calvar.
2386
2387         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2388
2389 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2390
2391         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2392         https://bugs.webkit.org/show_bug.cgi?id=173098
2393
2394         Reviewed by Žan Doberšek.
2395
2396         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2397         assuming that all tests containing forms define ids for the form elements like
2398         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2399
2400         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2401         (formControlsAssociatedCallback):
2402
2403 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2404
2405         webkitpy: Run sample/spindump on iOS devices
2406         https://bugs.webkit.org/show_bug.cgi?id=171881
2407         <rdar://problem/32084602>
2408
2409         Reviewed by Daniel Bates.
2410
2411         * Scripts/webkitpy/port/darwin.py:
2412         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2413         requires sudo to run spindump.
2414         * Scripts/webkitpy/port/ios_device.py:
2415         (IOSDevicePort.look_for_new_samples): Deleted.
2416         (IOSDevicePort.sample_process): Deleted.
2417         * Scripts/webkitpy/port/ios_device_unittest.py:
2418         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2419         (IOSDeviceTest.test_spindump):
2420         (IOSDeviceTest.test_sample_process):
2421         (IOSDeviceTest.test_sample_process_exception):
2422         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2423         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2424
2425 2017-06-08  Keith Miller  <keith_miller@apple.com>
2426
2427         WebAssembly: We should only create wrappers for functions that can be exported
2428         https://bugs.webkit.org/show_bug.cgi?id=173088
2429
2430         Reviewed by Saam Barati.
2431
2432         Add quick mode for wasm tests.
2433
2434         * Scripts/run-jsc-stress-tests:
2435
2436 2017-06-08  Darin Adler  <darin@apple.com>
2437
2438         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2439         https://bugs.webkit.org/show_bug.cgi?id=173106
2440
2441         Reviewed by Sam Weinig.
2442
2443         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2444         destroyed last.
2445         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2446         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2447
2448 2017-06-07  Dan Bernstein  <mitz@apple.com>
2449
2450         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2451         https://bugs.webkit.org/show_bug.cgi?id=173086
2452
2453         Reviewed by Andy Estes.
2454
2455         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2456         (TEST):
2457
2458 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2459
2460         Add High Sierra support to WebKit tools
2461         https://bugs.webkit.org/show_bug.cgi?id=173080
2462
2463         Rubber-stamped by Daniel Bates.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2469         Added dashboard support.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2472         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2473         Trigger the right build queues on check-in.
2474
2475         * Scripts/webkitpy/common/system/platforminfo.py:
2476         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2477         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2478         * Scripts/webkitpy/port/mac.py:
2479         * Scripts/webkitpy/port/mac_unittest.py:
2480         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2481         Added cases for Sierra, and updated tests for new baseline search paths.
2482
2483 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2484
2485         Unreviewed, rolling out r217902.
2486
2487         This change appears to have caused imported/w3c/web-platform-
2488         tests/fetch/api/cors tests to fail on El Capitan.
2489
2490         Reverted changeset:
2491
2492         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2493         https://bugs.webkit.org/show_bug.cgi?id=172930
2494         http://trac.webkit.org/changeset/217902
2495
2496 2017-06-07  Daniel Bates  <dabates@apple.com>
2497
2498         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2499         https://bugs.webkit.org/show_bug.cgi?id=172930
2500         <rdar://problem/32570201>
2501
2502         Reviewed by Youenn Fablet.
2503
2504         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2505         that is conditioned on the page being delivered over a secure protocol. One example of such
2506         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2507
2508         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2509         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2510         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2511
2512         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2513         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2514         to the Web Platform Tests HTTPS server.
2515         * Scripts/webkitpy/port/base.py:
2516         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2517         * Scripts/webkitpy/port/driver.py:
2518         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2519         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2520         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2521         indicate that they should be considered private instance variables.
2522         (Driver.is_web_platform_test): Update code for renamed instance variables.
2523         (Driver):
2524         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2525         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2526         determine the base URL to use to access the test.
2527         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2528         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2529
2530 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2531
2532         Support removal of authentication data through the Website data store API.
2533         https://bugs.webkit.org/show_bug.cgi?id=171217
2534
2535         Reviewed by Brady Eidson.
2536
2537         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2538         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2539         (WTR::InjectedBundle::didReceiveMessageToPage):
2540         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2541         (WTR::TestRunner::removeAllSessionCredentials):
2542         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2543         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2544         * WebKitTestRunner/TestController.h:
2545         * WebKitTestRunner/TestInvocation.cpp:
2546         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2547         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2548         * WebKitTestRunner/TestInvocation.h:
2549         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2550         (WTR::TestController::removeAllSessionCredentials):
2551
2552 2017-06-07  Charlie Turner  <cturner@igalia.com>
2553
2554         Add Charlie Turner as contributor
2555         https://bugs.webkit.org/show_bug.cgi?id=173055
2556
2557         Reviewed by Carlos Alberto Lopez Perez.
2558
2559         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2560         of webkit-patch upload, which reordered some fields and removed a newline.
2561
2562         * Scripts/webkitpy/common/config/contributors.json:
2563
2564 2017-06-06  Chris Dumez  <cdumez@apple.com>
2565
2566         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2567         https://bugs.webkit.org/show_bug.cgi?id=173033
2568         <rdar://problem/32591099>
2569
2570         Reviewed by Simon Fraser.
2571
2572         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2573         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2574
2575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2576         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2577         (TestWebKitAPI::didFinishLoadForFrame):
2578         (TestWebKitAPI::setPageLoaderClient):
2579         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2580         (TestWebKitAPI::TEST):
2581
2582 2017-06-06  Andy Estes  <aestes@apple.com>
2583
2584         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2585         https://bugs.webkit.org/show_bug.cgi?id=172849
2586         <rdar://problem/32567454>
2587
2588         Reviewed by Darin Adler.
2589
2590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2591         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2592         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2593         (TestWebKitAPI::TEST):
2594
2595 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2596
2597         [preload] Conditional support for media preloading and align media `as` values.
2598         https://bugs.webkit.org/show_bug.cgi?id=172501
2599
2600         Reviewed by Dean Jackson.
2601
2602         Turn on media preloading preference for tests.
2603
2604         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2605         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2606         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2607
2608 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2609
2610         webkitpy: Return correct process names from SimulatorProcess
2611         https://bugs.webkit.org/show_bug.cgi?id=172940
2612
2613         Reviewed by Aakash Jain.
2614
2615         * Scripts/webkitpy/port/darwin.py:
2616         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2617         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2618         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2619         * Scripts/webkitpy/port/driver.py:
2620         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2621         _server_process.name() will not return the correct process name for iOS.
2622         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2623         (Driver._read_block): Ditto.
2624         * Scripts/webkitpy/port/driver_unittest.py:
2625         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2626         process_name() instead of name().
2627         * Scripts/webkitpy/port/server_process.py:
2628         (ServerProcess._start): Use process_name() instead of name().
2629         (ServerProcess.stop): Ditto.
2630         (ServerProcess.name): Deleted.
2631         * Scripts/webkitpy/port/simulator_process.py:
2632         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2633
2634 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2635
2636         test-webkitpy: stop forking unsafely from within a spawned process
2637         https://bugs.webkit.org/show_bug.cgi?id=172774
2638
2639         Reviewed by Darin Adler.
2640
2641         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2642         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2643         it's going to be used.
2644         (Builder.force_build):
2645
2646 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2647
2648         webkitpy: Process crash-logs for iOS devices
2649         https://bugs.webkit.org/show_bug.cgi?id=171976
2650         <rdar://problem/32134551>
2651
2652         Reviewed by David Kilzer.
2653
2654         When running layout tests on an iOS device, crash logs should be processed.
2655         Implement crash log searching and parsing for iOS devices.
2656
2657         * Scripts/webkitpy/common/system/crashlogs.py:
2658         (CrashLogs): Moved process regular expression for Darwin to class variable.
2659         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2660         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2661         (CrashLogs.find_all_logs): Ditto.
2662         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2663         Do not assume that a Darwin crash log starts with the process.
2664         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2665         shared code for parsing Darwin crash logs.
2666         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2667         object so that crash logs already on the system before testing are not parsed.
2668         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2669         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2670         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2671         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2672         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2673         * Scripts/webkitpy/common/system/systemhost.py:
2674         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2675         systems is just the crashlog, use this behavior by default.
2676         * Scripts/webkitpy/common/system/systemhost_mock.py:
2677         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2678         systems is just the crashlog, use this behavior by default.
2679         * Scripts/webkitpy/port/apple.py:
2680         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2681         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2682         the system before testing begins
2683         * Scripts/webkitpy/port/base.py:
2684         (Port._get_crash_log): Pass optional target host when getting crash logs.
2685         * Scripts/webkitpy/port/darwin.py:
2686         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2687         CrashLogs object.
2688         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2689         logs to be skipped to CrashLogs object.
2690         * Scripts/webkitpy/port/darwin_testcase.py:
2691         (DarwinTest.test_get_crash_log): Removed unused local function.
2692         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2693         * Scripts/webkitpy/port/device.py:
2694         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2695         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2696         * Scripts/webkitpy/port/driver.py:
2697         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2698         * Scripts/webkitpy/port/gtk.py:
2699         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2700         * Scripts/webkitpy/port/ios.py: Ditto.
2701         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2702         to be skipped for each host.
2703         * Scripts/webkitpy/port/ios_device.py:
2704         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2705         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2706         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2707         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2708         host is specified. Else, search all connected devices for the specified crash-log.
2709         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2710         * Scripts/webkitpy/port/ios_device_unittest.py:
2711         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2712         (IOSDeviceTest.test_get_crash_log): Ditto.
2713         * Scripts/webkitpy/port/simulator_process.py:
2714         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2715         * Scripts/webkitpy/port/win.py:
2716         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2717         logs to be skipped to CrashLogs object.
2718         * Scripts/webkitpy/port/wpe.py:
2719         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2720
2721 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2722
2723         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2724         <https://webkit.org/b/172804>
2725
2726         Reviewed by Darin Adler.
2727
2728         WTF_ATTRIBUTE_PRINTF() only works outside the current
2729         compilation unit if it's on the declaration, not the
2730         implementation, of a function or class method.
2731
2732         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2733         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2734         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2735         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2736         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2737         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2738         - Remove redundant CRASH() macro definition.  Use the one from
2739           <wtf/Assertions.h> instead.
2740
2741 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2742
2743         Move Resource Timing / User Timing from experimental features into main preferences
2744         https://bugs.webkit.org/show_bug.cgi?id=172950
2745
2746         Reviewed by Darin Adler.
2747
2748         * DumpRenderTree/mac/DumpRenderTree.mm:
2749         (enableExperimentalFeatures):
2750         (resetWebPreferencesToConsistentValues):
2751         * DumpRenderTree/win/DumpRenderTree.cpp:
2752         (enableExperimentalFeatures):
2753         (resetWebPreferencesToConsistentValues):
2754         * WebKitTestRunner/TestController.cpp:
2755         (WTR::TestController::resetPreferencesToConsistentValues):
2756         Move out no longer experimental features to the main list.
2757
2758 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2759
2760         [WPE] Add an install-dependencies script
2761         https://bugs.webkit.org/show_bug.cgi?id=172948
2762
2763         Reviewed by Žan Doberšek.
2764
2765         It is based on the gtk/install-dependencies script.
2766         Includes support for Debian based distrubutions, Fedora and Arch.
2767         It has been tested on a minimal Debian 9 chroot.
2768
2769         * wpe/install-dependencies: Added.
2770
2771 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2772
2773         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2774         https://bugs.webkit.org/show_bug.cgi?id=172891
2775         <rdar://problem/32204540>
2776
2777         Reviewed by Darin Adler.
2778
2779         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2780         contenteditable. See WebCore ChangeLog for more details.
2781
2782         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2783         (TestWebKitAPI::TEST):
2784
2785 2017-06-05  Daniel Bates  <dabates@apple.com>
2786
2787         webkitpy: Abstract Executive class
2788         https://bugs.webkit.org/show_bug.cgi?id=172928
2789         <rdar://problem/32569531>
2790
2791         Reviewed by Ryosuke Niwa.
2792
2793         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2794         This will make it straightforward to create additional derived classes that
2795         adhere to the same interface, say for iOS on-device testing.
2796
2797         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2798         (AbstractExecutive):
2799         (AbstractExecutive.run_and_throw_if_fail):
2800         (AbstractExecutive.cpu_count):
2801         (AbstractExecutive.interpreter_for_script):
2802         (AbstractExecutive.shell_command_for_script):
2803         (AbstractExecutive.kill_process):
2804         (AbstractExecutive.check_running_pid):
2805         (AbstractExecutive.running_pids):
2806         (AbstractExecutive.wait_newest):
2807         (AbstractExecutive.wait_limited):
2808         (AbstractExecutive.interrupt):
2809         (AbstractExecutive.default_error_handler):
2810         (AbstractExecutive.ignore_error):
2811         (AbstractExecutive._stringify_args):
2812         (AbstractExecutive.command_for_printing):
2813         (AbstractExecutive.run_command):
2814         (AbstractExecutive.popen):
2815         (AbstractExecutive.run_in_parallel):
2816         * Scripts/webkitpy/common/system/executive.py:
2817         (Executive):
2818         (Executive.cpu_count):
2819         (Executive.running_pids):
2820         (Executive.kill_all):
2821         (Executive._compute_stdin):
2822         (Executive.interpreter_for_script): Deleted.
2823         (Executive.shell_command_for_script): Deleted.
2824         (Executive.wait_newest): Deleted.
2825         (Executive.wait_limited): Deleted.
2826         (Executive.default_error_handler): Deleted.
2827         (Executive.ignore_error): Deleted.
2828         (Executive.command_for_printing): Deleted.
2829
2830 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2831
2832         webkitpy: Add iOS to platform
2833         https://bugs.webkit.org/show_bug.cgi?id=172931
2834
2835         Reviewed by Daniel Bates.
2836
2837         * Scripts/webkitpy/common/system/platforminfo.py:
2838         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2839         (PlatformInfo.is_ios): Added.
2840         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2841         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2842         (MockPlatformInfo.is_ios): Added.
2843
2844 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2845
2846         [WPE][JHBuild] Switch github repository from git:// to https://
2847         https://bugs.webkit.org/show_bug.cgi?id=172921
2848
2849         Reviewed by Alex Christensen.
2850
2851         * wpe/jhbuild.modules:
2852
2853 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2854
2855         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2856         https://bugs.webkit.org/show_bug.cgi?id=172887
2857         <rdar://problem/32546061>
2858
2859         Reviewed by Sam Weinig.
2860
2861         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2862         (WTR::UIScriptController::applyAutocorrection):
2863         applyAutocorrection can call its completion handler synchronously,
2864         which makes UIScriptController unhappy (see bug 172884).
2865
2866 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2867
2868         webkitpy: Add contextmanager to disable logging for a block
2869         https://bugs.webkit.org/show_bug.cgi?id=172876
2870
2871         Reviewed by Daniel Bates.
2872
2873         Add a context manager which will use an OutputCapture object to capture logging
2874         in a block and hold it in a variable.
2875
2876         * Scripts/webkitpy/common/system/outputcapture.py:
2877         (OutputCaptureScope):
2878         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2879         (OutputCaptureScope.__enter__): Begin capturing output. 
2880         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2881         output and retain the resulting log.
2882         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2883         (OutputCaptureTest.test_output_capture_scope): Added.
2884
2885 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2886
2887         Cleanup FrameView::autoSizeIfEnabled.
2888         https://bugs.webkit.org/show_bug.cgi?id=172889
2889         <rdar://problem/32550783>
2890
2891         Reviewed by Tim Horton.
2892
2893         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2894         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2895         (TEST):
2896
2897 2017-06-02  Chris Dumez  <cdumez@apple.com>
2898
2899         ResourceLoadStatistics are not using unique paths during test runs
2900         https://bugs.webkit.org/show_bug.cgi?id=172861
2901         <rdar://problem/32442251>
2902
2903         Reviewed by Darin Adler.
2904
2905         Make sure WebKitTestRunner sets a temporary path for saving resource
2906         load statistics.
2907
2908         * WebKitTestRunner/TestController.cpp:
2909         (WTR::TestController::generateContextConfiguration):
2910
2911 2017-06-02  Brady Eidson  <beidson@apple.com>
2912
2913         Prevent scheme handlers from handling all built-in URL schemes.
2914         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2915
2916         Reviewed by Andy Estes.
2917
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2919
2920 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2921
2922         [JSCOnly] Build static jsc.exe on Windows
2923         https://bugs.webkit.org/show_bug.cgi?id=172833
2924
2925         Reviewed by Konstantin Tokarev.
2926
2927         * CMakeLists.txt:
2928         * Scripts/build-jsc:
2929
2930 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2931
2932         Disable ViewportSizeForViewportUnits tests on iOS.
2933         https://bugs.webkit.org/show_bug.cgi?id=172872
2934
2935         Reviewed by Tim Horton.
2936
2937         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2938
2939 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2940
2941         Allow clients to override viewport size for CSS viewport units.
2942         https://bugs.webkit.org/show_bug.cgi?id=172838
2943         <rdar://problem/32523441>
2944
2945         Reviewed by Tim Horton.
2946
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2949         (TEST):
2950
2951 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2952
2953         Get <chrono> out of StdLibExtras.h
2954         https://bugs.webkit.org/show_bug.cgi?id=172744
2955
2956         Reviewed by Zalan Bujtas.
2957
2958         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2959
2960 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2961
2962         [WPE] Enable SUBTLE_CRYPTO
2963         https://bugs.webkit.org/show_bug.cgi?id=172756
2964
2965         Reviewed by Michael Catanzaro.
2966
2967         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2968         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2969         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2970         exhausting entropy when running the crypto layout tests.
2971
2972 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2973
2974         [GTK] Bump GTK+ and its dependencies in jhbuild
2975         https://bugs.webkit.org/show_bug.cgi?id=171918
2976
2977         Reviewed by Carlos Alberto Lopez Perez.
2978
2979         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2980         (WTR::initializeGtkSettings):
2981         * gtk/jhbuild.modules:
2982         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2983         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2984
2985 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2986
2987         [GTK] Bump wayland and weston in jhbuild
2988         https://bugs.webkit.org/show_bug.cgi?id=171921
2989
2990         Reviewed by Carlos Alberto Lopez Perez.
2991
2992         * gtk/jhbuild.modules:
2993         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2994
2995 2017-06-01  Andy Estes  <aestes@apple.com>
2996
2997         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2998         https://bugs.webkit.org/show_bug.cgi?id=172828
2999
3000         Reviewed by Beth Dakin.
3001
3002         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3003
3004 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3005
3006         webkitpy: Remove unneeded simulator teardown
3007         https://bugs.webkit.org/show_bug.cgi?id=171891
3008
3009         Reviewed by Aakash Jain.
3010
3011         * Scripts/webkitpy/port/ios_simulator.py:
3012         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
3013         for communication between Python and WebKitTestRunner/DumpRenderTree.
3014
3015 2017-06-01  Keith Miller  <keith_miller@apple.com>
3016
3017         Undo rollout in r217638 with bug fix
3018         https://bugs.webkit.org/show_bug.cgi?id=172824
3019
3020         Unreviewed, reland patch with unused set_state code removed.
3021
3022         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3023         (runThreadMessageTest):
3024         (TEST):
3025
3026 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3027
3028         webkitpy: Do not send 0 or -1 as a pid to kill_process
3029         https://bugs.webkit.org/show_bug.cgi?id=172818
3030
3031         Reviewed by Darin Adler.
3032
3033         Sending a signal to process 0 will result in all processes in the group receiving 
3034         the signal. Sending a signal to process -1 will result in all non-system processes
3035         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
3036         should consider these cases
3037
3038         * Scripts/webkitpy/common/system/executive.py:
3039         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
3040         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
3041         never be running, although os.kill may succeed.
3042         * Scripts/webkitpy/port/simulator_process.py:
3043         (SimulatorProcess.stop): Do not kill process if it is undefined.
3044
3045 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
3046
3047         JSC EWS bot does not run on WTF only patches
3048         https://bugs.webkit.org/show_bug.cgi?id=172777
3049         rdar://problem/32495975
3050
3051         Reviewed by Aakash Jain.
3052
3053         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3054         (CheckPatchRelevance): Add a missing comma.
3055
3056 2017-05-31  Commit Queue  <commit-queue@webkit.org>
3057
3058         Unreviewed, rolling out r217611 and r217631.
3059         https://bugs.webkit.org/show_bug.cgi?id=172785
3060
3061         "caused wasm-hashset-many.html to become flaky." (Requested by
3062         keith_miller on #webkit).
3063
3064         Reverted changesets:
3065
3066         "Reland r216808, underlying lldb bug has been fixed."
3067         https://bugs.webkit.org/show_bug.cgi?id=172759
3068         http://trac.webkit.org/changeset/217611
3069
3070         "Use dispatch queues for mach exceptions"
3071         https://bugs.webkit.org/show_bug.cgi?id=172775
3072         http://trac.webkit.org/changeset/217631
3073
3074 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3075
3076         EWS bots should reboot themselves more frequently
3077         https://bugs.webkit.org/show_bug.cgi?id=172402
3078
3079         Reviewed by Alexey Proskuryakov.
3080
3081         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
3082
3083         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
3084
3085 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3086
3087         Reallocate hardware for iOS bots.
3088         https://bugs.webkit.org/show_bug.cgi?id=172657
3089
3090         Reviewed by Alexey Proskuryakov.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/config.json:
3093
3094 2017-05-31  Andy Estes  <aestes@apple.com>
3095
3096         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3097         https://bugs.webkit.org/show_bug.cgi?id=172366
3098
3099         Reviewed by Daniel Bates.
3100
3101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3102
3103 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
3104
3105         Unreviewed, add Jiewen Tan as a reviewer
3106
3107         * Scripts/webkitpy/common/config/contributors.json:
3108
3109 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
3110
3111         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
3112         https://bugs.webkit.org/show_bug.cgi?id=172770
3113
3114         Reviewed by Michael Catanzaro.
3115
3116         * MiniBrowser/gtk/BrowserWindow.c:
3117         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
3118         which caused the body of the if-clause to be accidentally empty.
3119
3120 2017-05-31  Keith Miller  <keith_miller@apple.com>
3121
3122         Reland r216808, underlying lldb bug has been fixed.
3123         https://bugs.webkit.org/show_bug.cgi?id=172759
3124
3125         Unreviewed, relanding old patch. See: rdar://problem/31183352
3126
3127         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3128         (runThreadMessageTest):
3129         (TEST):
3130
3131 2017-05-31  Matt Lewis  <jlewis3@apple.com>
3132
3133         Unreviewed, rolling out r217603.
3134
3135         This patch broke the internal builds.
3136
3137         Reverted changeset:
3138
3139         "Get <chrono> out of StdLibExtras.h"
3140         https://bugs.webkit.org/show_bug.cgi?id=172744
3141         http://trac.webkit.org/changeset/217603
3142
3143 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
3144
3145         Make ResourceLoadStatistics testing more reliable
3146         https://bugs.webkit.org/show_bug.cgi?id=172730
3147         <rdar://problem/32028373>
3148
3149         Reviewed by Andy Estes.
3150
3151         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
3152         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
3153
3154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3155         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3156
3157 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3158
3159         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
3160         https://bugs.webkit.org/show_bug.cgi?id=172757
3161
3162         Reviewed by Xabier Rodriguez-Calvar.
3163
3164         When needed, add the jhbuild wrapper at the beginning of the array
3165         that will be invoked to execute the run-jsc-stress-test or testapi
3166         commands.
3167
3168         * Scripts/run-javascriptcore-tests:
3169         (runJSCStressTests):
3170         * Scripts/webkitdirs.pm:
3171         (shouldUseJhbuild):
3172
3173 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
3174
3175         Get <chrono> out of StdLibExtras.h
3176         https://bugs.webkit.org/show_bug.cgi?id=172744
3177
3178         Reviewed by Saam Barati.
3179
3180         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3181
3182 2017-05-30  Tim Horton  <timothy_horton@apple.com>
3183
3184         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
3185         https://bugs.webkit.org/show_bug.cgi?id=172735
3186         <rdar://problem/32015977>
3187
3188         Reviewed by Enrica Casucci.
3189
3190         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3191         (WTR::UIScriptController::applyAutocorrection):
3192         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3193         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3194         (WTR::UIScriptController::applyAutocorrection):
3195         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3196         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3197         (WTR::UIScriptController::applyAutocorrection):
3198         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
3199         because I don't know how to tap the button in the autocorrection bar from a test.
3200
3201 2017-05-30  Daniel Bates  <dabates@apple.com>
3202
3203         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3204         https://bugs.webkit.org/show_bug.cgi?id=172671
3205
3206         Reviewed by Alex Christensen.
3207
3208         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3209         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3210
3211         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3212         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3213         to trigger a navigation to test it.
3214         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3215         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3216
3217 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3218
3219         webkitpy: Start servers before setting-up for testing
3220         https://bugs.webkit.org/show_bug.cgi?id=172176
3221         <rdar://problem/32225538>
3222
3223         Reviewed by Alexey Proskuryakov.
3224
3225         On-device testing requires that servers are started before ports set-up their
3226         test environments.
3227
3228         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3229         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3230         Servers are unconditionally stopped on exit.
3231         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3232         Manager now stops servers.
3233         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3234         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3235         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3236         (Manager.__init__): Delay construction of the test runner until we can determine
3237         if servers need to be started.
3238         (Manager.run): Determine if servers need to be started and construct the test runner.
3239         Shut servers down when the test run is finished.
3240         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3241         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3242         (is_wpt_server_running): Server is not running if no config is found.
3243         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3244         (PyWebSocket.is_running): Check if this WebSocket server is running.
3245         * Scripts/webkitpy/port/base.py:
3246         (Port.__init__): Define secure WebSocket server.
3247         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3248
3249 2017-05-30  Daniel Bates  <dabates@apple.com>
3250
3251         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3252         https://bugs.webkit.org/show_bug.cgi?id=172603
3253         <rdar://problem/32471306>
3254
3255         Reviewed by Brady Eidson.
3256
3257         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3258         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3259         unloading is initiated for a page that registered a onbeforeunload handler.
3260
3261         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3262         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3263         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3264
3265         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3266         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3267         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3268         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3269
3270         * MiniBrowser/mac/WK2BrowserWindowController.m:
3271         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3272         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3273         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3274         (sawDialog):
3275         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3276         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3277         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3278
3279 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3280
3281         Update libwebrtc configuration
3282         https://bugs.webkit.org/show_bug.cgi?id=172727
3283
3284         Reviewed by Geoffrey Garen.
3285
3286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3287
3288 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3289
3290         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
3291         https://bugs.webkit.org/show_bug.cgi?id=172702
3292
3293         Reviewed by Alex Christensen.
3294
3295         EGL PlatformDisplay needs to be shut down before existing a
3296         program on Windows.
3297
3298         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
3299         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
3300         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3301         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
3302
3303 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3304
3305         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3306         https://bugs.webkit.org/show_bug.cgi?id=172709
3307
3308         Reviewed by Brent Fulgham.
3309
3310         Exit fullscreen mode after a fullscreen test.
3311
3312         * DumpRenderTree/win/DumpRenderTree.cpp:
3313         (resetWebViewToConsistentStateBeforeTesting):
3314
3315 2017-05-30  Antti Koivisto  <antti@apple.com>
3316
3317         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
3318         https://bugs.webkit.org/show_bug.cgi?id=172713
3319
3320         Reviewed by Zalan Bujtas.
3321
3322         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3323         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3324
3325             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
3326             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
3327             because on Mac WK1 it may get invoked from middle of a layout.
3328
3329             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
3330
3331 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3332
3333         Add a WPE EWS queue
3334         https://bugs.webkit.org/show_bug.cgi?id=172693
3335
3336         Reviewed by Carlos Garcia Campos.
3337
3338         * QueueStatusServer/config/queues.py:
3339         * QueueStatusServer/model/queues.py: Capitalize the name of the
3340         port on the tooltip of the bubbles. Do the same for the GTK port.
3341         (Queue.display_name):
3342         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
3343         for the GTK+ EWS also. Set for both ports as watcher the alias
3344         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
3345         * Scripts/webkitpy/common/config/ports.py:
3346         (DeprecatedPort.port):
3347         (WpePort):
3348         (WpePort.build_webkit_command):
3349         (WpePort.run_webkit_tests_command):
3350         * Scripts/webkitpy/common/config/ports_unittest.py:
3351         (DeprecatedPortTest):
3352         (DeprecatedPortTest.test_wpe_port):
3353         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3354         (test_ews_name):
3355
3356 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3357
3358         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3359
3360         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3361         priorities for IPC communication.
3362
3363 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3364
3365         [JSC] Map and Set constructors should have fast path for cloning
3366         https://bugs.webkit.org/show_bug.cgi?id=172413
3367
3368         Reviewed by Saam Barati.
3369
3370         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3371         (TestWebKitAPI::TEST):
3372
3373 2017-05-27  Zalan Bujtas  <zalan@apple.com>
3374
3375         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
3376         https://bugs.webkit.org/show_bug.cgi?id=172676
3377
3378         Reviewed by Simon Fraser.
3379
3380         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3381         (TestWebKitAPI::TEST):
3382
3383 2017-05-26  Zalan Bujtas  <zalan@apple.com>
3384
3385         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
3386         https://bugs.webkit.org/show_bug.cgi?id=172674
3387
3388         Reviewed by Simon Fraser.
3389
3390         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3391         (TestWebKitAPI::TEST):
3392
3393 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3394
3395         Add test resources back into TestWebKitAPI Copy Resources phase
3396
3397         Rubber-stamped by Beth Dakin.
3398
3399         Add two files back into the Copy Resources phase after they were unintentionally
3400         removed in r217447 and r217496.
3401
3402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3403
3404 2017-05-26  Beth Dakin  <bdakin@apple.com>
3405
3406         Media documents inside iframes should not get controls in the TouchBar unless the 
3407         video is playing
3408         https://bugs.webkit.org/show_bug.cgi?id=172620
3409         -and corresponding-
3410         rdar://problem/32165477
3411
3412         Reviewed by Jon Lee.
3413
3414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3415         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3416         (TestWebKitAPI::TEST):
3417         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
3418
3419 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
3420
3421         _WKUserStyleSheet and WKUserScript leak string data
3422         https://bugs.webkit.org/show_bug.cgi?id=172583
3423         <rdar://problem/32395209>
3424
3425         Reviewed by Sam Weinig.
3426
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3428         We should not have been adopting an autoreleased object.
3429
3430 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3431
3432         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3433         https://bugs.webkit.org/show_bug.cgi?id=172554
3434         <rdar://problem/31247133>
3435
3436         Reviewed by Simon Fraser.
3437
3438         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
3439         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
3440         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
3441         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
3442         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
3443         codepath.
3444
3445         * DumpRenderTree/TestOptions.h:
3446         * DumpRenderTree/TestOptions.mm:
3447         (TestOptions::TestOptions):
3448         (TestOptions::webViewIsCompatibleWithOptions):
3449         * DumpRenderTree/mac/DumpRenderTree.mm:
3450         (shouldIgnoreWebCoreNodeLeaks):
3451         (allowedFontFamilySet):
3452         (-[DRTMockScroller rectForPart:]):
3453         (-[DRTMockScroller drawKnob]):
3454         (-[DRTMockScroller drawRect:]):
3455         (createWebViewAndOffscreenWindow):
3456         (initializeGlobalsFromCommandLineOptions):
3457         (prepareConsistentTestingEnvironment):
3458         (dumpRenderTree):
3459         (dumpAudio):
3460         (dumpHistoryItem):
3461         (dumpBackForwardListForWebView):
3462         (resetWebViewToConsistentStateBeforeTesting):
3463         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
3464         (runTest):
3465
3466 2017-05-25  Sam Weinig  <sam@webkit.org>
3467
3468         [WebIDL] Use the term 'operation' more consistently
3469         https://bugs.webkit.org/show_bug.cgi?id=172601
3470
3471         Reviewed by Chris Dumez.
3472
3473         We were using the term 'operation', a WebIDL term for function-like
3474         constructs, inconsistently in the code generator. Now, when we use
3475         'operation' when referring to the IDL concept (usually the object the
3476         parser produces) and 'function' when referring to code being generated.
3477
3478         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3479         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3480
3481 2017-05-25  Jer Noble  <jer.noble@apple.com>
3482
3483         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
3484
3485         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3486
3487 2017-05-25  Jer Noble  <jer.noble@apple.com>
3488
3489         System sleeps while playing to wireless target, ending stream.
3490         https://bugs.webkit.org/show_bug.cgi?id=172541
3491
3492         Reviewed by Eric Carlson.
3493
3494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3495         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
3496         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
3497         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3498         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3499         (TestWebKitAPI::simulateKeyDown):
3500         (TestWebKitAPI::hasAssertionType):
3501         (TestWebKitAPI::TEST):
3502
3503 2017-05-25  Commit Queue  <commit-queue@webkit.org>
3504
3505         Unreviewed, rolling out r217423 and r217424.
3506         https://bugs.webkit.org/show_bug.cgi?id=172607
3507
3508         These caused an api failure on all testers. (Requested by
3509         mlewis13 on #webkit).
3510
3511         Reverted changesets:
3512
3513         "REGRESSION (r216977): 4 leaks introduced in new
3514         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
3515         https://bugs.webkit.org/show_bug.cgi?id=172558
3516         http://trac.webkit.org/changeset/217423
3517
3518         "REGRESSION (r217423): Fix last-second typo in 'auto'"
3519         http://trac.webkit.org/changeset/217424
3520
3521 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
3522
3523         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
3524         https://bugs.webkit.org/show_bug.cgi?id=172355
3525
3526         Reviewed by Chris Fleizach.
3527
3528         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
3529         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
3530         releases which support the new platform footnote accessibility role.
3531
3532         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3533         * gtk/jhbuild.modules:
3534
3535 2017-05-25  David Kilzer  <ddkilzer@apple.com>
3536
3537         REGRESSION (r217423): Fix last-second typo in 'auto'
3538
3539         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3540         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
3541
3542 2017-05-24  David Kilzer  <ddkilzer@apple.com>
3543
3544         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
3545         <https://webkit.org/b/172558>
3546
3547         Reviewed by Sam Weinig.
3548
3549         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3550         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
3551
3552 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
3553
3554         [CMake] Consolidate CMake code related to Cairo
3555         https://bugs.webkit.org/show_bug.cgi?id=172568
3556
3557         Reviewed by Alex Christensen.
3558
3559         * DumpRenderTree/config.h:
3560         * TestWebKitAPI/config.h:
3561
3562 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3563
3564         Plumb additional image metadata to item providers when beginning data interaction on an image
3565         https://bugs.webkit.org/show_bug.cgi?id=172536
3566         <rdar://problem/32371300>
3567
3568         Reviewed by Beth Dakin.
3569
3570         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3571         source item providers.
3572
3573         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3574         (checkSuggestedNameAndEstimatedSize):
3575         (TestWebKitAPI::TEST):
3576
3577 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3578
3579         [Win] Create unique network storage session for each DRT.
3580         https://bugs.webkit.org/show_bug.cgi?id=172540
3581
3582         Reviewed by Brent Fulgham.
3583
3584         During layout testing, each DRT instance should have its own network storage session.
3585
3586         * DumpRenderTree/win/DumpRenderTree.cpp:
3587         (prepareConsistentTestingEnvironment):
3588
3589 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3590
3591         Respect image UTIs when writing to item providers when beginning data interaction on an image
3592         https://bugs.webkit.org/show_bug.cgi?id=172436
3593         <rdar://problem/31786569>
3594
3595         Reviewed by Beth Dakin.
3596
3597         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3598         details.
3599
3600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3601         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3602         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3603
3604         Create a new test page containing a GIF and a file input.
3605
3606         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3607         (checkTypeIdentifierIsRegisteredAtIndex):
3608         (TestWebKitAPI::TEST):
3609
3610 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
3611
3612         [Win] Increase test timeout for slow tests.
3613         https://bugs.webkit.org/show_bug.cgi?id=172449
3614
3615         Reviewed by Alexey Proskuryakov.
3616
3617         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
3618         timeout member in the TestRunner class.
3619
3620         * DumpRenderTree/win/TestRunnerWin.cpp:
3621         (TestRunner::setWaitToDump):
3622
3623 2017-05-15  Matt Rajca  <mrajca@apple.com>
3624
3625         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
3626         https://bugs.webkit.org/show_bug.cgi?id=172138
3627
3628         Reviewed by Alex Christensen.
3629
3630         Added API tests.
3631
3632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3633         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
3634         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3635         (TEST):
3636         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
3637
3638 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3639
3640         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3641         https://bugs.webkit.org/show_bug.cgi?id=172522
3642         rdar://problem/31071812
3643
3644         Reviewed by Sam Weinig.
3645
3646         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
3647         We set this in the .xib file now.
3648
3649         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3650
3651 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3652
3653         Snapshotting via -renderInContext: should do synchronous image decodes
3654         https://bugs.webkit.org/show_bug.cgi?id=172485
3655         rdar://problem/32276146
3656
3657         Reviewed by Tim Horton.
3658
3659         New API test.
3660
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
3663         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3664         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3665         (TestWebKitAPI::getPixelIndex):
3666         (TestWebKitAPI::TEST):
3667
3668 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3669
3670         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3671         https://bugs.webkit.org/show_bug.cgi?id=172517
3672
3673         Rubber-stamped by Simon Fraser.
3674
3675         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3676
3677 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3678
3679         Multiple links should be inserted separately when performing data interaction
3680         https://bugs.webkit.org/show_bug.cgi?id=172489
3681         <rdar://problem/31510832>
3682
3683         Reviewed by Dan Bernstein.
3684
3685         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
3686
3687         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3688         (TestWebKitAPI::TEST):
3689
3690 2017-05-23  Tim Horton  <timothy_horton@apple.com>
3691
3692         REGRESSION: API test WebKit2.WKObject is failing
3693         https://bugs.webkit.org/show_bug.cgi?id=172497
3694         <rdar://problem/31694641>
3695
3696         Reviewed by Geoff Garen.
3697
3698         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3699         (TestWebKitAPI::TEST):
3700         Add a test that ensures that we pretend to at least be *some* kind of
3701         NSString, which my first fix would not have passed.
3702
3703 2017-05-23  youenn fablet  <youenn@apple.com>
3704
3705         There should be an easy way to run HTTP/WPT served tests on a browser
3706         https://bugs.webkit.org/show_bug.cgi?id=172068
3707
3708         Reviewed by Sam Weinig.
3709
3710         Adding a new script open-layout-test to open a layout-test in a
3711         browser and making sure it is served as done through run-webkit-tests.
3712         In case tests should be run using a server, detecting whether the
3713         server are running. If not, calling run-webkit-httpd to run the
3714         servers and open the URL in a browser.
3715         Otherwise, open directly the URL.
3716
3717         Adding an option in run-webkit-httpd to open an URL after having
3718         started the servers.
3719
3720         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
3721         This allows running run-webkit-httpd once and not having to restart
3722         servers everytime a test should be served.
3723
3724         Moving most of run-webkit-httpd logic in its own python file to reuse
3725         it in open-layout-test script.
3726
3727         Adding routines to check whether HTTP and WPT servers are running.
3728
3729         * Scripts/open-layout-test: Added.
3730         (parse_args):
3731         (main):
3732         * Scripts/run-webkit-httpd:
3733         (main):
3734         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3735         (LayoutTestFinder.find_tests):
3736         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3737         (LayoutTestRunner.run_tests):
3738         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3739         (parse_args):
3740         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3741         (HttpServerBase._is_server_running_on_all_ports):
3742         (HttpServerBase):
3743         (HttpServerBase._is_running_on_port):
3744         (HttpServerBase._check_that_all_ports_are_available):
3745         (is_http_server_running):
3746         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
3747         (parse_args):
3748         (main):
3749         (run_server):
3750         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3751         (is_wpt_server_running):
3752         * Scripts/webkitpy/port/base.py:
3753         (Port.to.is_http_server_running):
3754         (Port.to):
3755         (Port.to.is_wpt_server_running):
3756         (Port.to.start_web_platform_test_server):
3757         * Scripts/webkitpy/port/driver.py:
3758         (DriverProxy.is_web_platform_test):
3759         (DriverProxy):
3760         (DriverProxy.is_webkit_specific_web_platform_test):
3761
3762 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3763
3764         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3765         https://bugs.webkit.org/show_bug.cgi?id=171984
3766
3767         Reviewed by Antti Koivisto.
3768
3769         * DumpRenderTree/mac/DumpRenderTree.mm:
3770         (enableExperimentalFeatures):
3771         * WebKitTestRunner/TestController.cpp:
3772         (WTR::TestController::resetPreferencesToConsistentValues):
3773
3774 2017-05-20  Alex Christensen  <achristensen@webkit.org>
3775
3776         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
3777         https://bugs.webkit.org/show_bug.cgi?id=172406
3778         <rdar://32109532>
3779
3780         Reviewed by Brady Eidson.
3781
3782         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3783         (TestWebKitAPI::checkBuffer):
3784         (TestWebKitAPI::TEST_F):
3785
3786 2017-05-22  Jason Marcell  <jmarcell@apple.com>
3787
3788         Do not enter Subversion-specific logic when parsing Git-based Trac data.
3789         https://bugs.webkit.org/show_bug.cgi?id=172433
3790         <rdar://problem/32234188>
3791
3792         Reviewed by Alexey Proskuryakov.
3793
3794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3795         (Trac.prototype._convertCommitInfoElementToObject):
3796
3797 2017-05-22  Tim Horton  <timothy_horton@apple.com>
3798
3799         ExplicitSnapshotsChangeUponNavigation API test often fails
3800         https://bugs.webkit.org/show_bug.cgi?id=172475
3801         <rdar://problem/31688322>
3802
3803         Reviewed by Simon Fraser.
3804
3805         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3806         (-[TestWKWebView _setUpTestWindow:]):
3807         Make TestWKWebView's window layer-backed. This is now the default,
3808         and it's also easy to accidentally write a test that depends on it
3809         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
3810         which becomes layer backed, just like the WKWebView, but with no
3811         common layer-backed ancestor).
3812
3813 2017-05-22  youenn fablet  <youenn@apple.com>
3814
3815         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
3816         https://bugs.webkit.org/show_bug.cgi?id=172426
3817
3818         Reviewed by Chris Dumez.
3819
3820         * Scripts/webkitpy/w3c/test_importer.py:
3821         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
3822
3823 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
3824
3825         Unreviewed, change my status to reviewer and fill "expertise" field
3826
3827         * Scripts/webkitpy/common/config/contributors.json:
3828
3829 2017-05-22  Tomas Popela  <tpopela@redhat.com>
3830
3831         Remove some of the EFL port leftovers
3832         https://bugs.webkit.org/show_bug.cgi?id=172440
3833
3834         Reviewed by Carlos Garcia Campos.
3835
3836         * BuildSlaveSupport/built-product-archive:
3837         (archiveBuiltProduct):
3838         (extractBuiltProduct):
3839         * BuildSlaveSupport/test-result-archive:
3840         (archiveTestResults):
3841         * ImageDiff/PlatformEfl.cmake: Removed.
3842         * Scripts/run-efl-tests: Removed.
3843         * Scripts/webkit-build-directory:
3844         * Scripts/webkitpy/common/config/contributionareas.py:
3845         * Scripts/webkitpy/common/config/watchlist:
3846         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3847         (parse_args):
3848         (_set_up_derived_options):
3849         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3850         (PerfTestsRunner.__init__):
3851         * Scripts/webkitpy/style/checker.py:
3852         * Scripts/webkitpy/style/checker_unittest.py:
3853         (GlobalVariablesTest.test_path_rules_specifier):
3854         * gtk/manifest.txt.in:
3855         * jhbuild/jhbuild-wrapper:
3856
3857 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3858
3859         Unreviewed. Do not include WPE files in GTK+ tarballs.
3860
3861         * gtk/manifest.txt.in:
3862
3863 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3864
3865         [GTK] Add webkit_context_menu_item_new_from_gaction
3866         https://bugs.webkit.org/show_bug.cgi?id=159631
3867
3868         Reviewed by Michael Catanzaro.
3869
3870         Update context menu tests to check the new GAction API.
3871
3872         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3873         (testContextMenuPopulateMenu):
3874
3875 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3876
3877         [GTK] Remove Firefox user agent quirk for Google domains
3878         https://bugs.webkit.org/show_bug.cgi?id=171941
3879
3880         Reviewed by Carlos Garcia Campos.
3881
3882         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3883         (TestWebKitAPI::TEST):
3884         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
3885
3886 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
3887
3888         [GTK] gtkdoc-fixxref needs --module argument to work
3889         https://bugs.webkit.org/show_bug.cgi?id=172415
3890
3891         Reviewed by Michael Catanzaro.
3892
3893         * gtk/gtkdoc.py:
3894         (GTKDoc._run_gtkdoc_fixxref):
3895
3896 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
3897
3898         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
3899         https://bugs.webkit.org/show_bug.cgi?id=172416
3900
3901         Reviewed by Daniel Bates.
3902
3903         * Scripts/make-new-script-test:
3904
3905 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3906
3907         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
3908         https://bugs.webkit.org/show_bug.cgi?id=172267
3909
3910         Reviewed by Per Arne Vollan.
3911
3912         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
3913         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
3914         should link only with WebKit.
3915
3916         Unfortunately, there is a layer violation at the moment.
3917         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
3918         in WebKit. This change contains a stub of loadResourceIntoBuffer
3919         in TestWebCoreLib for the workaround.
3920
3921         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
3922         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
3923         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
3924         (loadResourceIntoBuffer): Added a stub.
3925
3926 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
3927
3928         Fix dump-class-layout to handle different file architectures
3929         https://bugs.webkit.org/show_bug.cgi?id=172392
3930
3931         Reviewed by Zalan Bujtas.
3932
3933         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
3934         and use the first architecture reported. Also add a "--architecture" argument
3935         to allow the user to specify an architecture.
3936
3937         * Scripts/dump-class-layout:
3938         (import_lldb):
3939         (verify_type_recursive):
3940         (get_first_file_architecture):
3941         (dump_class):
3942         (main):
3943         (find_build_directory): Deleted.
3944
3945 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3946
3947         Unreviewed infrastructure fix.
3948
3949         * Scripts/webkitpy/port/ios_simulator.py:
3950         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
3951
3952 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3953
3954         webkitpy: Use simctl boot to run multiple simulators at once
3955         https://bugs.webkit.org/show_bug.cgi?id=172374
3956
3957         Reviewed by Alexey Proskuryakov.
3958
3959         * Scripts/webkitpy/common/system/platforminfo.py:
3960         (PlatformInfo.xcode_version): Return the current version of Xcode.
3961         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3962         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
3963         * Scripts/webkitpy/port/ios_simulator.py:
3964         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
3965         run multiple Simulator.app instances.
3966         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
3967         versions of Xcode.
3968         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
3969         an older version of Xcode.
3970
3971 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3972
3973         Unreviewed, fix the build on the latest internal SDK.
3974
3975         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3976         (TestWebKitAPI::TEST):
3977
3978 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
3979
3980         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
3981         https://bugs.webkit.org/show_bug.cgi?id=172369
3982
3983         Reviewed by Mark Lam.
3984         
3985         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
3986         would be a good idea to write this down.
3987
3988         * Scripts/run-jsc-stress-tests:
3989
3990 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3991
3992         webkitpy: Layout tests which have no output will succeed
3993         https://bugs.webkit.org/show_bug.cgi?id=172322
3994         <rdar://problem/32258350>
3995
3996         Reviewed by David Kilzer.
3997
3998         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3999         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
4000         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4001         (determine_result_type): FailureNotTested means that the test could not be loaded. This
4002         is classified as a MISSING failure.
4003         (FailureNotTested): Added.
4004         (FailureNotTested.message):
4005
4006 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4007
4008         Add SixSpeed benchmark to PerformanceTests
4009         https://bugs.webkit.org/show_bug.cgi?id=172326
4010
4011         Reviewed by Sam Weinig.
4012
4013         * Scripts/run-jsc-benchmarks:
4014
4015 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
4016
4017         [WK1] MiniBrowser should navigate when handling a dropped URL
4018         https://bugs.webkit.org/show_bug.cgi?id=172350
4019
4020         Reviewed by Tim Horton.
4021
4022         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
4023
4024         * MiniBrowser/mac/WK1BrowserWindowController.m:
4025         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
4026
4027 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
4028
4029         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
4030         https://bugs.webkit.org/show_bug.cgi?id=172077
4031
4032         Reviewed by Chris Dumez.
4033
4034         Fixed perftest.py by updating the lines to ignore in Speedometer.
4035
4036         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
4037
4038         * Scripts/webkitpy/performance_tests/perftest.py:
4039         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
4040         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4041         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
4042         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
4043         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4044         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
4045
4046 2017-05-18  Andy Estes  <aestes@apple.com>
4047
4048         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
4049         https://bugs.webkit.org/show_bug.cgi?id=172305
4050
4051         Reviewed by Anders Carlsson.
4052
4053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4054
4055 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4056
4057         Selection around attachment elements should not persist when beginning a drag
4058         https://bugs.webkit.org/show_bug.cgi?id=172319
4059         <rdar://problem/32283008>
4060
4061         Reviewed by Tim Horton.
4062
4063         Tests that temporary selection around an attachment does not persist longer than it needs to.
4064
4065         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4066         (TestWebKitAPI::TEST):
4067
4068 2017-05-18  John Wilander  <wilander@apple.com>
4069
4070         Resource Load Statistics: Grandfather domains for existing data records
4071         https://bugs.webkit.org/show_bug.cgi?id=172155
4072         <rdar://problem/24913532>
4073
4074         Reviewed by Alex Christensen.
4075
4076         Adds test infrastructure needed for the added functionality.
4077
4078         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4079         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4080         (WTR::InjectedBundle::didReceiveMessageToPage):
4081         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4082         (WTR::TestRunner::setStatisticsGrandfathered):
4083         (WTR::TestRunner::isStatisticsGrandfathered):
4084         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
4085         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
4086         (WTR::TestRunner::setStatisticsGrandfatheringTime):
4087         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4088         * WebKitTestRunner/TestController.cpp:
4089         (WTR::TestController::setStatisticsGrandfathered):
4090         (WTR::TestController::isStatisticsGrandfathered):
4091         (WTR::TestController::setStatisticsGrandfatheringTime):
4092         * WebKitTestRunner/TestController.h:
4093         * WebKitTestRunner/TestInvocation.cpp:
4094         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4095
4096 2017-05-18  Saam Barati  <sbarati@apple.com>
4097
4098         WebAssembly: perform stack checks
4099         https://bugs.webkit.org/show_bug.cgi?id=165546
4100         <rdar://problem/29760307>
4101
4102         Reviewed by Filip Pizlo.
4103
4104         Add some new testing modes for using and not using fast TLS wasm contexts.
4105
4106         * Scripts/run-jsc-stress-tests:
4107
4108 2017-05-18  Daniel Bates  <dabates@apple.com>
4109
4110         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
4111         window CSP when object-src 'none' is set
4112         https://bugs.webkit.org/show_bug.cgi?id=172038
4113         <rdar://problem/32258262>
4114
4115         Reviewed by Andy Estes.
4116
4117         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
4118         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
4119
4120         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4121         (NPP_New):
4122
4123 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
4124
4125         [Win] Many layout tests are failing.
4126         https://bugs.webkit.org/show_bug.cgi?id=172286
4127
4128         Reviewed by Brent Fulgham.
4129
4130         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
4131  
4132         * DumpRenderTree/win/TestRunnerWin.cpp:
4133         (TestRunner::grantWebNotificationPermission):
4134         (TestRunner::denyWebNotificationPermission):
4135         (TestRunner::removeAllWebNotificationPermissions):
4136         (TestRunner::simulateWebNotificationClick):
4137
4138 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
4139
4140         [Win] Remove usage of _snprintf
4141         https://bugs.webkit.org/show_bug.cgi?id=172251
4142
4143         Reviewed by Per Arne Vollan.
4144
4145         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4146         * MiniBrowser/win/PageLoadTestClient.cpp:
4147         (PageLoadTestClient::dumpRunStatistics):
4148
4149 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
4150
4151         Unreviewed, rolling out r217014.
4152
4153         This change caused mac-wk2 LayoutTests to exit early due to
4154         crashes.
4155
4156         Reverted changeset:
4157
4158         "Resource Load Statistics: Grandfather domains for existing
4159         data records"
4160         https://bugs.webkit.org/show_bug.cgi?id=172155
4161         http://trac.webkit.org/changeset/217014
4162
4163 2017-05-17  John Wilander  <wilander@apple.com>
4164
4165         Resource Load Statistics: Grandfather domains for existing data records
4166         https://bugs.webkit.org/show_bug.cgi?id=172155
4167         <rdar://problem/24913532>
4168
4169         Reviewed by Alex Christensen.
4170
4171         Adds test infrastructure needed for the added functionality.
4172
4173         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4174         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4175         (WTR::InjectedBundle::didReceiveMessageToPage):
4176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4177         (WTR::TestRunner::setStatisticsGrandfathered):
4178         (WTR::TestRunner::isStatisticsGrandfathered):
4179         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
4180         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
4181         (WTR::TestRunner::setStatisticsGrandfatheringTime):
4182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4183         * WebKitTestRunner/TestController.cpp:
4184         (WTR::TestController::setStatisticsGrandfathered):
4185         (WTR::TestController::isStatisticsGrandfathered):
4186         (WTR::TestController::setStatisticsGrandfatheringTime):
4187         * WebKitTestRunner/TestController.h:
4188         * WebKitTestRunner/TestInvocation.cpp:
4189         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4190
4191 2017-05-17  Alex Christensen  <achristensen@webkit.org>
4192
4193         Fix ios-simulator API test after r216977
4194         https://bugs.webkit.org/show_bug.cgi?id=171987
4195
4196         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
4197         (TEST):
4198         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
4199         not as urgent as having the rest of this working. Notably the ephemeral part of the
4200         test works, so something is just wrong with the persistent part.
4201
4202 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
4203
4204         Unreviewed, rolling out r216955.
4205
4206         This change caused strange behavior with web-platform-tests
4207         locally and on EWS.
4208
4209         Reverted changeset:
4210
4211         "webkitpy: Start servers before setting-up for testing"
4212         https://bugs.webkit.org/show_bug.cgi?id=172176
4213         http://trac.webkit.org/changeset/216955
4214
4215 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4216
4217         A URL type is vended for a non-URL plain text string when starting data interaction
4218         https://bugs.webkit.org/show_bug.cgi?id=172228
4219         <rdar://problem/32166729>
4220
4221         Reviewed by Andy Estes.
4222
4223         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
4224         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
4225         still vended when beginning data interaction on something that resembles a link.
4226
4227         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4228
4229 2017-05-17  David Kilzer  <ddkilzer@apple.com>
4230
4231         BlobDataFileReference::generateReplacementFile() should use mkstemp()
4232         <https://webkit.org/b/172192>
4233
4234         Reviewed by Brent Fulgham.
4235
4236         * Scripts/webkitpy/style/checkers/cpp.py:
4237         (check_language): Add check for mktemp.
4238         (CppChecker): Add 'security/temp_file' category.
4239         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4240         (CppStyleTest.test_insecure_temp_file): Add test.
4241
4242 2017-05-17  Devin Rousso  <drousso@apple.com>
4243
4244         Unreviewed, change my email.
4245
4246         * Scripts/webkitpy/common/config/contributors.json:
4247
4248 2017-05-17  Matt Lewis  <jlewis3@apple.com>
4249
4250         Unreviewed, rolling out r216974.
4251
4252         Revision caused consistent timeouts on all platforms.
4253
4254         Reverted changeset:
4255
4256         "Add a RuntimeEnabledFeature for display: contents, defaulted
4257         to false."
4258         https://bugs.webkit.org/show_bug.cgi?id=171984
4259         http://trac.webkit.org/changeset/216974
4260
4261 2017-05-17  Alex Christensen  <achristensen@webkit.org>
4262
4263         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
4264         https://bugs.webkit.org/show_bug.cgi?id=171987
4265
4266         Reviewed by Brady Eidson.
4267
4268         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
4269         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4270         (TEST):
4271
4272 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
4273
4274         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
4275         https://bugs.webkit.org/show_bug.cgi?id=171984
4276
4277         Reviewed by Antti Koivisto.
4278
4279         * DumpRenderTree/mac/DumpRenderTree.mm:
4280         (enableExperimentalFeatures):
4281         * WebKitTestRunner/TestController.cpp:
4282         (WTR::TestController::resetPreferencesToConsistentValues):
4283
4284 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
4285
4286         Fix the build
4287
4288         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4289         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
4290
4291 2017-05-16  Tim Horton  <timothy_horton@apple.com>
4292
4293         PageVisibilityStateWithWindowChanges tests sometimes time out
4294         https://bugs.webkit.org/show_bug.cgi?id=172202
4295         <rdar://problem/29653266>
4296
4297         Reviewed by Dean Jackson.
4298
4299 &n