44b386277a5e0f12d99227bbb50a97eea836a0a9
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-02  Julie Parent  <jparent@chromium.org>
2
3         Dashboard refactor: Move dashboard specific history related features to History.
4         https://bugs.webkit.org/show_bug.cgi?id=113717
5
6         Reviewed by Ojan Vafai.
7         
8         Each dashboard now creates its own History object, with a custom
9         configuration. This changes from just overriding global functions
10         to passing in callbacks for generatePage, handleValidHashParameter,
11         and handleQueryParameterChange. Same with passing in defaultStateValues
12         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
13         variables.
14         
15         All functions related to these features are now (mostly) private
16         function on History. 
17         
18         Loader no longer needs a loadingComplete callback, since it can just
19         initialize the history object itself.
20
21         * TestResultServer/static-dashboards/aggregate_results.js:
22         (handleValidHashParameter):
23         * TestResultServer/static-dashboards/dashboard_base.js:
24         * TestResultServer/static-dashboards/flakiness_dashboard.js:
25         (generatePage):
26         (.switch.return):
27         (handleQueryParameterChange):
28         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
29         (resetGlobals):
30         * TestResultServer/static-dashboards/history.js:
31         (.):
32         * TestResultServer/static-dashboards/loader.js:
33         (.):
34         * TestResultServer/static-dashboards/loader_unittests.js:
35         * TestResultServer/static-dashboards/timeline_explorer.js:
36         (generatePage):
37         (initCurrentBuilderTestResults):
38         * TestResultServer/static-dashboards/treemap.js:
39         (generatePage):
40         (.switch.return):
41         (handleQueryParameterChange):
42
43 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
44
45         Unreviewed, rolling out r147401.
46         http://trac.webkit.org/changeset/147401
47         https://bugs.webkit.org/show_bug.cgi?id=113767
48
49         The patch makes it extremely hard to set up the dependencies
50         properly on the GTK builders (Requested by zdobersek on
51         #webkit).
52
53         * gtk/jhbuild.modules:
54
55 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
56
57         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
58         https://bugs.webkit.org/show_bug.cgi?id=113382
59
60         Reviewed by Gyuyoung Kim.
61
62         Do not show the empty tooltip box if the text is null.
63
64         * MiniBrowser/efl/main.c:
65         (popup_menu_populate):
66
67 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         [GTK] Bump required versions of some dependencies
70         https://bugs.webkit.org/show_bug.cgi?id=113282
71
72         Reviewed by Martin Robinson.
73
74         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
75
76 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
77
78         Unreviewed, rolling out r147319.
79         http://trac.webkit.org/changeset/147319
80         https://bugs.webkit.org/show_bug.cgi?id=113707
81
82         The unit test is still failing on the buildbot (Requested by
83         zdobersek on #webkit).
84
85         * Scripts/run-gtk-tests:
86         (TestRunner):
87
88 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
89
90         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
91         https://bugs.webkit.org/show_bug.cgi?id=104779
92
93         Reviewed by Carlos Garcia Campos.
94
95         * Scripts/run-gtk-tests:
96         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
97         passing in current trunk.
98
99 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
100
101         Unreviewed, rolling out r147289.
102         http://trac.webkit.org/changeset/147289
103         https://bugs.webkit.org/show_bug.cgi?id=113678
104
105         broke Win7 (dbg) build (Requested by shinyak|gardener on
106         #webkit).
107
108         * DumpRenderTree/DumpRenderTree.gypi:
109         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
110         (WebTestRunner):
111         (WebUserMediaClientMock):
112         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
113         (WebTestRunner::WebUserMediaClientMock::taskList):
114         * Scripts/webkitpy/style/checkers/cpp.py:
115         (check_function_definition):
116
117 2013-03-31  Adam Barth  <abarth@webkit.org>
118
119         configure-svn-config.sh fails
120         https://codereview.chromium.org/13392007/
121
122         Reviewed by Eric Seidel.
123
124         This script was trying to use "svn checkout" to dowload a file from
125         svn.webkit.org, but "svn checkout" only works with directories.
126         Instead, we should use "svn export".
127
128         * EWSTools/configure-svn-config.sh:
129
130 2013-03-31  Wei Jia  <wjia@chromium.org>
131
132         Allow WebUserMediaClientMock to be used by client
133         https://bugs.webkit.org/show_bug.cgi?id=113633
134
135         Reviewed by Adam Barth.
136
137         Export WebUserMediaClientMock.
138         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
139
140         * DumpRenderTree/DumpRenderTree.gypi:
141         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
142         (WebUserMediaClientMock):
143         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
144         * Scripts/webkitpy/style/checkers/cpp.py:
145         (check_function_definition):
146
147 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
148
149         Expose FeatureObserver data to WebKit clients
150         https://bugs.webkit.org/show_bug.cgi?id=113613
151
152         Reviewed by Sam Weinig.
153
154         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
155         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
156
157 2013-03-29  Greg Hughes  <ghughes@apple.com>
158
159         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
160         https://bugs.webkit.org/show_bug.cgi?id=112276
161
162         Reviewed by Chris Fleizach.
163
164         Added support to test accessibility search predicates with multiple keys.  
165
166         * DumpRenderTree/AccessibilityUIElement.cpp:
167         (uiElementForSearchPredicateCallback):
168         * DumpRenderTree/AccessibilityUIElement.h:
169         (AccessibilityUIElement):
170         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
171         (AccessibilityUIElement::uiElementForSearchPredicate):
172         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
173         (AccessibilityUIElement::uiElementForSearchPredicate):
174         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
175         (AccessibilityUIElement::uiElementForSearchPredicate):
176         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
177         (AccessibilityUIElement::uiElementForSearchPredicate):
178         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
179         (AccessibilityUIElement::uiElementForSearchPredicate):
180         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
181         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
182         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
183         (AccessibilityUIElement):
184         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
186         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
187         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
188         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
189
190 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
191
192         Fix a typo in r147147 to fix Mac EWS.
193
194         * Scripts/webkitpy/tool/commands/queues.py:
195         (PatchProcessingQueue._new_port_name_from_old):
196
197 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
198
199         [EFL] Build break with latest EFL libraries after r146265
200         https://bugs.webkit.org/show_bug.cgi?id=113558
201
202         Unreviewed build fix.
203
204         * TestWebKitAPI/PlatformWebView.h:
205         * WebKitTestRunner/PlatformWebView.h:
206
207 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
208
209         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
210
211         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
212         in libgcrypt build.
213
214 2013-03-28  Lucas Forschler  <lforschler@apple.com>
215
216         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
217
218         Unreviewed.
219
220         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
221         (MacEWS):
222
223 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Use the right OS name on Mac EWS instead of mac-future.
226
227         Rubber-stamped by Dirk Pranke.
228
229         * Scripts/webkitpy/tool/commands/queues.py:
230         (PatchProcessingQueue._new_port_name_from_old):
231         (PatchProcessingQueue.begin_work_queue):
232         (PatchProcessingQueue._upload_results_archive_for_patch):
233
234 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
235
236         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
237         https://bugs.webkit.org/show_bug.cgi?id=112546
238
239         Reviewed by Martin Robinson.
240
241         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
242         moved back to Source/WebCore/platform. Fix an indentation issue as well.
243
244 2013-03-28  Ming Xie  <mxie@blackberry.com>
245
246         [BlackBerry] Committer Email Updates
247         https://bugs.webkit.org/show_bug.cgi?id=113435
248
249         Reviewed by Rob Buis.
250
251         Add the @blackberry.com email address for all our BlackBerry
252         WebKit committers. This is the first step for our email address
253         migration.
254
255         * Scripts/webkitpy/common/config/committers.py:
256
257 2013-03-28  Philippe Normand  <pnormand@igalia.com>
258
259         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
260         https://bugs.webkit.org/show_bug.cgi?id=113508
261
262         Reviewed by Martin Robinson.
263
264         Prevent the GStreamer plugin scanner to load system-wide
265         plugins. Only the ones built in JHBuild should be loaded and used
266         at runtime.
267
268         * efl/jhbuildrc:
269         * gtk/jhbuildrc:
270
271 2013-03-27  Philippe Normand  <pnormand@igalia.com>
272
273         [GTK] run-launcher --gtk -2 fails on a WK2-only build
274         https://bugs.webkit.org/show_bug.cgi?id=113386
275
276         Reviewed by Carlos Garcia Campos.
277
278         * Scripts/webkitdirs.pm:
279         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
280         version to 3.0. Reflect this change so the builtDylibPathForName
281         function doesn't fail to report the library as found.
282
283 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
284
285         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
286         https://bugs.webkit.org/show_bug.cgi?id=113484
287
288         Unreviewed build fix.
289
290         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
291
292         * TestWebKitAPI/CMakeLists.txt:
293         * WebKitTestRunner/CMakeLists.txt:
294
295 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
296
297         Revision for the internal jhbuild is too old
298         https://bugs.webkit.org/show_bug.cgi?id=113324
299
300         Reviewed by Martin Robinson.
301
302         Update the minimum required version to a point where jhbuild won't
303         fail installing packages when trying to remove a symlink to a directory.
304
305         * jhbuild/jhbuild-wrapper: Updated revision.
306
307 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
308
309         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
310         https://bugs.webkit.org/show_bug.cgi?id=113203
311
312         Reviewed by Philippe Normand.
313
314         We build our libsoup without GNOME support. gst-plugins-good does separate
315         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
316         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
317         build failures as the headers of those diverge. We do not use souphttpsrc, so
318         disable it when building gst-plugins-good.
319
320         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
321
322 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
323
324         Build fix after r146852. Please another reference to the Lion leaks builder.
325
326         * BuildSlaveSupport/build.webkit.org-config/config.json:
327
328 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
329
330         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
331         https://bugs.webkit.org/show_bug.cgi?id=113421
332
333         Reviewed by Dirk Pranke.
334
335         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
336         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
337         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
338         in the GTK-specific TestExpectations files.
339
340         To avoid this only enable the warnings only when not using WKTR.
341
342         * Scripts/webkitpy/layout_tests/port/gtk.py:
343         (GtkPort.warn_if_bug_missing_in_test_expectations):
344
345 2013-03-27  Antti Koivisto  <antti@apple.com>
346
347         Fix Zalan's email.
348
349         * Scripts/webkitpy/common/config/committers.py:
350
351 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
352
353         master.cfg cleanup
354         https://bugs.webkit.org/show_bug.cgi?id=113195
355
356         Reviewed by Ryosuke Niwa.
357
358         * BuildSlaveSupport/build.webkit.org-config/config.json:
359         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
360
361 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
362
363         master.cfg fine-tuning for Qt Mountain Lion Release bot
364         https://bugs.webkit.org/show_bug.cgi?id=113191
365
366         Reviewed by Ryosuke Niwa.
367
368         * BuildSlaveSupport/build.webkit.org-config/config.json:
369           - Rename the slave due to its location change.
370           - Update the platform of the slave.
371         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
372         (RunQtAPITests): Enable running WK2 API tests on Qt.
373         (RunQtAPITests.start):
374         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
375         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
376
377 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
378
379         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
380         https://bugs.webkit.org/show_bug.cgi?id=113403
381
382         Reviewed by Kenneth Rohde Christiansen.
383
384         As of Evas 1.7.5, when Wayland is detected on the system, support for
385         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
386         The code, however, seems to depend on a few other flags which must be
387         explicitly enabled.
388
389         If those additional GL-related options are passed, we end up
390         having issues on the WebKit side, so disable Wayland support for
391         now.
392
393         * efl/jhbuild.modules:
394
395 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
396
397         Unreviewed, rolling out r146864.
398         http://trac.webkit.org/changeset/146864
399         https://bugs.webkit.org/show_bug.cgi?id=113391
400
401         causes crashes on Wk2 EFL release bot (Requested by drott on
402         #webkit).
403
404         * Scripts/webkitperl/FeatureList.pm:
405
406 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
407
408         [jhbuild] Correctly specify an alternate number of make jobs.
409         https://bugs.webkit.org/show_bug.cgi?id=113396
410
411         Reviewed by Philippe Normand.
412
413         So far, we were using the `MAKEFLAGS' environment variable to pass the
414         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
415         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
416
417         We now behave more closely to the rest of the WebKit tools by first
418         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
419         not set, just letting jhbuild itself figure out how many jobs to use.
420
421         * efl/jhbuildrc:
422         * gtk/jhbuildrc:
423
424 2013-03-27  Zeno Albisser  <zeno@webkit.org>
425
426         [Qt] Remove Qt specific WorkQueueItem definitions.
427         https://bugs.webkit.org/show_bug.cgi?id=112891
428
429         This patch is preparation work for removing
430         WorkQueue related code from TestRunnerQt and
431         replacing it with generic TestRunner code.
432
433         Reviewed by Benjamin Poulain.
434
435         * DumpRenderTree/qt/TestRunnerQt.cpp:
436         (TestRunnerQt::queueBackNavigation):
437         (TestRunnerQt::queueForwardNavigation):
438         (TestRunnerQt::queueLoadHTMLString):
439         (TestRunnerQt::queueReload):
440         (TestRunnerQt::queueLoadingScript):
441         (TestRunnerQt::queueNonLoadingScript):
442         (TestRunner::queueLoad):
443         * DumpRenderTree/qt/TestRunnerQt.h:
444         (TestRunnerQt):
445         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
446         (LoadItem::invoke):
447         (LoadHTMLStringItem::invoke):
448         (LoadAlternateHTMLStringItem::invoke):
449         (ReloadItem::invoke):
450         (ScriptItem::invoke):
451         (BackForwardItem::invoke):
452         * DumpRenderTree/qt/WorkQueueItemQt.h:
453         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
454         (LoadAlternateHTMLStringItem):
455
456 2013-03-26  Julie Parent  <jparent@chromium.org>
457
458         Flakiness dashboard: simplify logic around which tests to show.
459         https://bugs.webkit.org/show_bug.cgi?id=113250
460
461         Reviewed by Ojan Vafai.
462         
463         The different filters for showing results are only used for layout
464         tests, otherwise, we show everything.
465         
466         Change the defaults to false (what layout tests used), and only
467         look at the values when viewing layout tests.
468
469         * TestResultServer/static-dashboards/flakiness_dashboard.js:
470         (htmlForTestsWithExpectationsButNoFailures):
471         (shouldHideTest):
472
473 2013-03-26  Isaac Levy  <ilevy@google.com>
474
475         Update bots on test-results.appspot
476         https://bugs.webkit.org/show_bug.cgi?id=113333
477
478         Reviewed by Ojan Vafai.
479
480         * TestResultServer/static-dashboards/builders.jsonp:
481
482 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
483
484         Unreviewed GTK gardening.
485
486         * Scripts/run-gtk-tests:
487         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
488
489 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
490
491         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
492         https://bugs.webkit.org/show_bug.cgi?id=113287
493
494         Reviewed by Jocelyn Turcotte.
495
496         * Scripts/run-qtwebkit-tests:
497         (Options.__init__):
498
499 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
500
501         [EFL] Enable IndexedDB by default
502         https://bugs.webkit.org/show_bug.cgi?id=107248
503
504         Reviewed by Laszlo Gombos.
505
506         * Scripts/webkitperl/FeatureList.pm:
507         Enable IndexedDB by default on EFL.
508
509 2013-03-26  Alan Cutter  <alancutter@chromium.org>
510
511         Sheriffbot should explain rollout failures in a human readable form.
512         https://bugs.webkit.org/show_bug.cgi?id=107092
513
514         Reviewed by Ryosuke Niwa.
515
516         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
517
518         * Scripts/webkitpy/tool/bot/irc_command.py:
519         (Rollout._check_diff_failure):
520         (Rollout.execute):
521         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
522         (IRCCommandTest.test_rollout):
523
524 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
525
526         Unreviewed GTK gardening.
527
528         * Scripts/run-gtk-tests:
529         (TestRunner): Skipping a failing unit test after r146518.
530
531 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
532
533         Remove Lion leaks builder
534         https://bugs.webkit.org/show_bug.cgi?id=113252
535
536         Reviewed by Andreas Kling.
537
538         Removed.
539
540         * BuildSlaveSupport/build.webkit.org-config/config.json:
541
542 2013-03-25  Kent Tamura  <tkent@chromium.org>
543
544         Rename ENABLE_INPUT_TYPE_DATETIME
545         https://bugs.webkit.org/show_bug.cgi?id=113254
546
547         Reviewed by Kentaro Hara.
548
549         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
550         Actually I'd like to remove the code, but we shouldn't remove it yet
551         because we shipped products with it on some platforms.
552
553         * Scripts/webkitperl/FeatureList.pm:
554         * qmake/mkspecs/features/features.pri:
555
556 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
557
558         Remove one more line that was intended to be removed in r146657.
559
560         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
561         (summarize_results):
562
563 2013-03-25  Roger Fong  <roger_fong@apple.com>
564
565         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
566         Re-enable WinEWS tests.
567
568         * Scripts/webkitpy/common/config/ports.py:
569         (WinPort.run_bindings_tests_command):
570         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
571         (WinEWS):
572
573 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
574
575         Unreviewed, rolling out r146793.
576         http://trac.webkit.org/changeset/146793
577         https://bugs.webkit.org/show_bug.cgi?id=113248
578
579         Fix did not work (Requested by rfong on #webkit).
580
581         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
582         (WinEWS):
583
584 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
585
586         REGRESSION(r146657): Test failures reported incorrectly
587         https://bugs.webkit.org/show_bug.cgi?id=113223
588
589         Reviewed by Dirk Pranke.
590
591         The bug was caused by BuildBotPrinter not taking the new behavior into account.
592
593         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
594         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
595
596         * Scripts/webkitpy/layout_tests/controllers/manager.py:
597         (Manager.run):
598
599         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
600         (RunDetails.__init__):
601         (summarize_results): Remove the line I intended to remove in r146657.
602
603         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
604         (logging_run): Return details instead of the exit code.
605         (run_and_capture): Ditto.
606
607         (RunTest.test_full_results_html):
608         (RunTest.test_hung_thread):
609         (RunTest.test_no_tests_found):
610         (RunTest.test_no_tests_found_2):
611         (RunTest.test_repeat_each_iterations_num_tests):
612         (RunTest.test_run_singly_actually_runs_tests):
613         (RunTest.test_test_list):
614         (RunTest.test_missing_and_unexpected_results):
615         (RunTest.test_pixel_test_directories):
616         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
617         (RunTest.test_crash_with_stderr):
618         (RunTest.test_no_image_failure_with_image_diff):
619         (RunTest.test_crash_log):
620         (RunTest.test_exit_after_n_failures_upload):
621         (RunTest.test_results_directory_absolute):
622         (RunTest.test_results_directory_relative):
623         (RunTest.test_retrying_and_flaky_tests):
624         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
625         (RunTest.test_retrying_uses_retries_directory):
626         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
627         (RunTest.test_output_diffs):
628         (EndToEndTest.test_reftest_with_two_notrefs):
629         (RebaselineTest.test_reset_results):
630         (RebaselineTest.test_missing_results):
631         (RebaselineTest.test_new_baseline):
632
633         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
634         (BuildBotPrinter.print_results):
635         (BuildBotPrinter.print_unexpected_results):
636         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
637         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
638
639 2013-03-25  Julie Parent  <jparent@chromium.org>
640
641         Dashboard refactor: Move cross dashboard history related code into history.js.
642         https://bugs.webkit.org/show_bug.cgi?id=113104
643
644         Reviewed by Ojan Vafai.
645
646         All functions relating to cross dashboard behavior move from being
647         globals to methods on the history.History object. Names stay the same,
648         except many are made private, ones that should have been constants now
649         are, and the long standing TODO to change "currentState" to 
650         dashboardSpecificState is done.
651         
652         We now create a global history object in dashboard_base, as an 
653         intermediate measure.  Once the dashboard specific code is
654         added to history, each DB will need to create its own, and this
655         global will be eliminated.
656         
657         * TestResultServer/static-dashboards/aggregate_results.js:
658         (handleValidHashParameter):
659         (htmlForBuilder):
660         (rawValuesHTML):
661         * TestResultServer/static-dashboards/dashboard_base.js:
662         (parseDashboardSpecificParameters):
663         (defaultValue):
664         (currentBuilderGroupCategory):
665         (currentBuilderGroupName):
666         (handleLocationChange):
667         (expectationsMap):
668         * TestResultServer/static-dashboards/flakiness_dashboard.js:
669         (generatePage):
670         (.switch.return):
671         (platformAndBuildType):
672         (individualTests):
673         (substringList):
674         (processMissingAndExtraExpectations):
675         (pathToFailureLog):
676         (showPopupForBuild):
677         (htmlForTestsWithExpectationsButNoFailures):
678         (shouldHideTest):
679         (isCrossBuilderView):
680         (tableHeaders):
681         (htmlForSingleTestRow):
682         (htmlForTableColumnHeader):
683         (generatePageForExpectationsUpdate):
684         (handleUpdate):
685         (nextUpdate):
686         (setUpdateIndex):
687         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
688         (.appendExpectationsItem):
689         (loadExpectations):
690         (.dummyNode.onload):
691         (loadExpectationsLayoutTests):
692         (appendExpectations):
693         (htmlForNavBar):
694         (checkBoxToToggleState):
695         (linkHTMLToToggleState):
696         (generatePageForBuilder):
697         (isInvalidKeyForCrossBuilderView):
698         (handleQueryParameterChange):
699         (showLegend):
700         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
701         (resetGlobals):
702         (test):
703         * TestResultServer/static-dashboards/history.js:
704         (.):
705         * TestResultServer/static-dashboards/history_unittests.js:
706         * TestResultServer/static-dashboards/loader.js:
707         (.):
708         * TestResultServer/static-dashboards/loader_unittests.js:
709         * TestResultServer/static-dashboards/timeline_explorer.js:
710         (generatePage):
711         (initCurrentBuilderTestResults):
712         (selectBuild):
713         (showResultsDelta):
714         * TestResultServer/static-dashboards/treemap.js:
715         (generatePage):
716         (.switch.return):
717         (handleFocus):
718         * TestResultServer/static-dashboards/ui.js:
719
720 2013-03-25  Roger Fong  <roger_fong@apple.com>
721
722         Unreviewed. Enable WinEWS tests again.
723
724         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
725         (WinEWS):
726
727 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
728
729         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
730         https://bugs.webkit.org/show_bug.cgi?id=112166
731
732         HarfBuzz 0.9.14 merged my patch for icu detection without
733         pkg-config files, as needed by for example Ubuntu 12.04.
734         This obsoletes our local workaround. Removed it for GTK and EFL.
735
736         Reviewed by Martin Robinson.
737
738         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
739         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
740         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
741         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
742
743 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
744
745         Unreviewed.  Move self from contributor to committer list.
746
747         * Scripts/webkitpy/common/config/committers.py:
748
749 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
750
751         EWS should use a human readable port name when uploading layout test archives
752         https://bugs.webkit.org/show_bug.cgi?id=113099
753
754         Reviewed by Dirk Pranke.
755
756         Use new port's object's name() method to report human readable port names.
757         This will also help us resolving the bug to apply layout test results posted by EWS.
758
759         * Scripts/webkitpy/tool/bot/botinfo.py:
760         (BotInfo.__init__): Take port's name.
761         (BotInfo.summary_text):
762
763         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
764         (BotInfoTest.test_summary_text):
765
766         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
767         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
768
769         * Scripts/webkitpy/tool/commands/queues.py:
770         (PatchProcessingQueue.__init__): Initialize self._port.
771         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
772         and use that for the attachment filename and the comment posted.
773
774         * Scripts/webkitpy/tool/commands/queues_unittest.py:
775         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
776         "mac-snowleopard" as expected for TestPort.
777
778 2013-03-22  Roger Fong  <roger_fong@apple.com>
779
780         Unreviewed. Turn off EWS test on Win again.
781         The battle continues.
782
783         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
784         (WinEWS):
785
786 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
787
788         NRWT: Enable pixel tests when retrying tests
789         https://bugs.webkit.org/show_bug.cgi?id=112898
790
791         Reviewed by Dirk Pranke.
792
793         * Scripts/webkitpy/layout_tests/controllers/manager.py:
794         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
795         if we've forced pixel tests in the retry.
796         (Manager._run_tests):
797         (Manager._clean_up_run): Fixed the capitalizations.
798         (Manager._force_pixel_tests_if_needed): Added.
799
800         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
801         (_interpret_test_failures): Now that this function maybe called multiple times, only set
802         'image_diff_percent' if it doesn't already exist.
803
804         (summarize_results): When the first attempt resulted in a text failure and the second attempt
805         resulted in image and text failures and we've forced to run pixel tests in the retry run,
806         treat this as a regular regression instead of a flakiness.
807
808         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
809         run had image diffs.
810
811         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
812         (summarized_results):
813
814         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
815         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
816         Also removed some dead code.
817
818         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
819         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
820         is set and pixel_tests_enabled is set to false.
821         (EndToEndTest.test_reftest_with_two_notrefs):
822
823 2013-03-22  Tim Horton  <timothy_horton@apple.com>
824
825         Make it possible to run layout tests on Retina MBP
826         https://bugs.webkit.org/show_bug.cgi?id=93673
827
828         Reviewed by Ryosuke Niwa.
829
830         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
831         windows on 2x machines still run at 1x.
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (createWebViewAndOffscreenWindow):
835         Reset the window resolution to 1x on creation.
836         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
837         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
838         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
839         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
840         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
841         (WTR::PlatformWebView::PlatformWebView):
842         Add NSWindow details, reset the window resolution to 1x on creation.
843
844 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
845
846         Leak bots shouldn't build
847         https://bugs.webkit.org/show_bug.cgi?id=112774
848
849         Reviewed by Simon Fraser.
850
851         Since leak bots use regular debug builds, there is no need to build on these bots.
852         Simply downloading builds will dramatically improve the cycle time of these bots.
853
854         * BuildSlaveSupport/build.webkit.org-config/config.json:
855         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
856         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
857         TestFactory instead of BuildAndTestFactory.
858
859 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
860
861         [Qt] Fix the TestWebKitAPI build
862         https://bugs.webkit.org/show_bug.cgi?id=113044
863
864         Reviewed by Tor Arne Vestbø.
865
866         The generate-forwarding-headers script would only be run
867         after the targets in InjectedBundle.pri since the second
868         addStrictSubdirOrderBetween call in
869         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
870         the derived_sources -> injected_bundle order in SUBDIRS.
871
872         Fix it by only moving the dependent target at the end of
873         SUBDIRS, don't touch its dependency.
874
875         * qmake/mkspecs/features/functions.prf:
876
877 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
878
879         [EFL][WK2] View is not focused when fullscreen mode toggled
880         https://bugs.webkit.org/show_bug.cgi?id=113009
881
882         Reviewed by Laszlo Gombos.
883
884         Set focus on view when fullscreen mode enabled/disabled
885         by FullScreen API.
886
887         * MiniBrowser/efl/main.c:
888         (on_fullscreen_accept):
889         (on_fullscreen_deny):
890
891 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
892
893         nrwt is no longer saving retry results in the retries/ subdirectory
894         https://bugs.webkit.org/show_bug.cgi?id=112995
895
896         Reviewed by Ojan Vafai.
897
898         I think this has been broken a long time, unfortunately. This
899         patch should fix that.
900
901         In order to do so, I had to pass the directory to use from
902         the Worker object through the SingleTestWriter to the
903         TestResultWriter. While I was plumbing that through, I rationalized
904         the order of the parameter arguments a bit ...
905
906         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
907         (Worker._run_single_test):
908         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
909         (run_single_test):
910         (SingleTestRunner.__init__):
911         (SingleTestRunner._run_compare_test):
912         (SingleTestRunner._run_rebaseline):
913         (SingleTestRunner._run_reftest):
914         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
915         (write_test_result):
916         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
917         (TestResultWriterTest.test_reftest_diff_image):
918         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
919         (RunTest.test_retrying_uses_retries_directory):
920
921 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
922
923         JSC profiler should have an at-a-glance report of the success of DFG optimization
924         https://bugs.webkit.org/show_bug.cgi?id=112988
925
926         Reviewed by Geoffrey Garen.
927
928         * Scripts/display-profiler-output:
929
930 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
931
932         [chromium] Linux ASAN WebKit canary is running out of memory
933         https://bugs.webkit.org/show_bug.cgi?id=112978
934
935         Reviewed by Tony Chang.
936
937         Running the AddressSanitizer on a crash takes a lot of
938         memory, so we should serialize access to it to avoid running
939         out of memory on a machine.
940
941         * Scripts/webkitpy/layout_tests/port/chromium.py:
942         (ChromiumPort._get_crash_log):
943         * Scripts/webkitpy/layout_tests/port/http_lock.py:
944         (HttpLock.__init__):
945         (HttpLock.wait_for_httpd_lock):
946
947 2013-03-21  Min Qin  <qinmin@chromium.org>
948
949         Cleanup android media layout test code
950         https://bugs.webkit.org/show_bug.cgi?id=112944
951
952         Reviewed by Adam Barth.
953
954         Chromium change: https://codereview.chromium.org/12892010/
955         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
956         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
957         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
958         Instead, we should switch to use content shell for layout tests.
959
960         * DumpRenderTree/chromium/TestShell.cpp:
961         (TestShell::resetTestController):
962
963 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
964
965         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
966         https://bugs.webkit.org/show_bug.cgi?id=112953
967
968         Reviewed by Tony Chang.
969
970         When I created the DumpRenderTree_resources target in r144863 I
971         forgot to declare the needed dependencies on the other resource
972         targets. Due to a quirk of ordering, this appears to have been fine
973         w/ ninja but not w/ Xcode (which is still being used on the chromium
974         mac valgrind bots). Declaring the dependencies fixes the build
975         failures.
976
977         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
978
979 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
980
981         [WinCairo] Correct assert in Empty BitmapImage Test.
982         https://bugs.webkit.org/show_bug.cgi?id=112934
983
984         Reviewed by Tim Horton.
985
986         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
987         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
988         to avoid ref counting assertion when leaving test scope.
989
990 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
991
992         [GTK] generate-feature-defines-files is incompatible with Python3
993         https://bugs.webkit.org/show_bug.cgi?id=112956
994
995         Reviewed by Martin Robinson.
996
997         Make the generate-feature-defines-files compatible with Python3 by calling the items()
998         method on the dictionary objects when iterating through said dictionaries.
999
1000         * gtk/generate-feature-defines-files:
1001         (write_feature_defines_header):
1002         (write_flattened_feature_defines_file):
1003
1004 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1005
1006         kill-old-processes spits out error messages on Mac
1007         https://bugs.webkit.org/show_bug.cgi?id=112878
1008
1009         Reviewed by Jessie Berlin.
1010
1011         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1012         included in the list of options grep --help shows.
1013
1014         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1015
1016         * BuildSlaveSupport/kill-old-processes:
1017         (main):
1018
1019 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1020
1021         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1022         https://bugs.webkit.org/show_bug.cgi?id=112597
1023
1024         Reviewed by Xan Lopez.
1025
1026         These were introduced for the Chromium port in r105295. We need
1027         dummy implementations in order to compile the BlackBerry port.
1028
1029         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1030         (AccessibilityUIElement::scrollToMakeVisible):
1031         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1032         (AccessibilityUIElement::scrollToGlobalPoint):
1033
1034 2013-03-21  Roger Fong  <roger_fong@apple.com>
1035
1036         Re-enable WinEWS tests following r146376.
1037
1038         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1039         (WinEWS):
1040
1041 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1042
1043         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1044
1045         * Scripts/webkitpy/common/config/committers.py:
1046
1047 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1048
1049         [GTK] Missing atk in install-dependencies script
1050         https://bugs.webkit.org/show_bug.cgi?id=112272
1051
1052         Reviewed by Gustavo Noronha Silva.
1053
1054         * gtk/install-dependencies: Add missing atk dependency.
1055
1056 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1057
1058         [GTK] Missing backslash in install-dependencies script
1059         https://bugs.webkit.org/show_bug.cgi?id=112907
1060
1061         Reviewed by Philippe Normand.
1062
1063         * gtk/install-dependencies: Add missing backslash to dependencies
1064         list.
1065
1066 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1067
1068         EWS bots have stopped uploading results to bugzilla
1069         https://bugs.webkit.org/show_bug.cgi?id=101091
1070
1071         Reviewed by Adam Barth.
1072
1073         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1074         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1075         this relative file path resoled to a file inside a non-existent directory for "zip".
1076
1077         Fixed the bug by resolving both test results directory and zip archive paths in
1078         LayoutTestResultsReader.archive.
1079
1080         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1081         in the future.
1082
1083         * Scripts/webkitpy/common/system/filesystem_mock.py:
1084         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1085
1086         * Scripts/webkitpy/common/system/workspace.py:
1087         (Workspace.create_zip): Log the source path when "zip" failed.
1088
1089         * Scripts/webkitpy/common/system/workspace_mock.py:
1090         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1091
1092         * Scripts/webkitpy/common/system/workspace_unittest.py:
1093         (WorkspaceTest.test_create_zip_exception): Test that.
1094
1095         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1096         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1097         This is the actual bug fix.
1098
1099         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1100         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1101
1102 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1103
1104         [chromium] move WebThemeEngine implementations to TestRunner library
1105         https://bugs.webkit.org/show_bug.cgi?id=112751
1106
1107         Reviewed by Adam Barth.
1108
1109         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1110         * DumpRenderTree/DumpRenderTree.gypi:
1111         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1112         (WebKit):
1113         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1114         (WebTestRunner::TestInterfaces::themeEngine):
1115         (WebTestRunner):
1116         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1117         (WebKit):
1118         (TestInterfaces):
1119         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1120         (WebTestRunner::WebTestInterfaces::themeEngine):
1121         (WebTestRunner):
1122         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1123         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1124         (WebTestRunner):
1125         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1126         (WebTestRunner::WebTestThemeControlWin::box):
1127         (WebTestRunner::WebTestThemeControlWin::line):
1128         (WebTestRunner::WebTestThemeControlWin::triangle):
1129         (WebTestRunner::WebTestThemeControlWin::roundRect):
1130         (WebTestRunner::WebTestThemeControlWin::oval):
1131         (WebTestRunner::WebTestThemeControlWin::circle):
1132         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1133         (WebTestRunner::WebTestThemeControlWin::markState):
1134         (WebTestRunner::WebTestThemeControlWin::draw):
1135         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1136         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1137         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1138         (WebTestRunner):
1139         (WebTestThemeControlWin):
1140         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1141         (WebTestRunner):
1142         (WebTestThemeEngineMac):
1143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1144         (+[FakeActiveWindow alwaysActiveWindow]):
1145         (+[FakeActiveWindow alwaysInactiveWindow]):
1146         (-[FakeActiveWindow initWithActiveControls:]):
1147         (-[FakeActiveWindow _hasActiveControls]):
1148         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1149         (WebTestRunner):
1150         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1151         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1152         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1153         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1154         (WebTestRunner):
1155         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1156         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1157         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1158         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1159         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1160         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1161         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1162         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1163         (WebTestRunner::WebTestThemeEngineWin::getSize):
1164         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1165         (WebTestRunner):
1166         (WebTestThemeEngineWin):
1167         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1168         * DumpRenderTree/chromium/TestShell.cpp:
1169         (TestShell::initialize):
1170         * DumpRenderTree/chromium/TestShell.h:
1171         (WebKit):
1172         * DumpRenderTree/chromium/TestShellMac.mm:
1173         (platformInit):
1174         * DumpRenderTree/chromium/TestShellWin.cpp:
1175         (platformInit):
1176         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1177
1178 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1179
1180         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1181
1182         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1183         New property sheet that does not link against CoreFoundation and
1184         CFNetwork.
1185         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1186         Use new TestWebKitAPICommonWinCairo property sheet.
1187         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1188         Ditto.
1189
1190 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1191
1192         [WinCairo] Unreviewed build fix for VS2010.
1193
1194         Had to add WinCairo-specific property sheets to deal with some
1195         library and path differences with the main Apple port.
1196
1197         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1198         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1199         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1200         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1201         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1202         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1203
1204 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1205
1206         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1207         https://bugs.webkit.org/show_bug.cgi?id=112849
1208
1209         Reviewed by Sam Weinig.
1210
1211         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1214
1215 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1216
1217         [WinCairo] Build WebKit Tools under VS2010
1218         https://bugs.webkit.org/show_bug.cgi?id=112821
1219
1220         Reviewed by Tim Horton.
1221
1222         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1223         Add WinCairo-specific build target.
1224         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1225         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1226         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1227         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1228         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1229         Add WinCairo-specific build target.
1230         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1231         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1232         Add WinCairo-specific build target.
1233         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1234         WinCairo-specific build target.
1235         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1236         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1237         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1238         specific build target.
1239         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1240         WinCairo-specific build target.
1241         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1242         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1243         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1244
1245 2013-03-20  Roger Fong  <roger_fong@apple.com>
1246
1247         API test gardening AppleWin port.
1248
1249         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1250
1251         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1252         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1253
1254 2013-03-20  Roger Fong  <roger_fong@apple.com>
1255
1256         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1257
1258         * EWSTools/start-queue-win.sh:
1259
1260 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1261
1262         Unreviewed, add myself to committers.py.
1263
1264 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1265
1266         Unreviewed. Adding another email for me.
1267
1268         * Scripts/webkitpy/common/config/committers.py:
1269
1270 2013-03-20  Justin Novosad  <junov@google.com>
1271
1272         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1273         https://bugs.webkit.org/show_bug.cgi?id=112605
1274
1275         Reviewed by James Robinson.
1276
1277         Deleting all the code that was used for propagating and supporting
1278         the Chromium setting for disabling deferred 2d canvas rendering.
1279
1280         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1281         (main):
1282         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1283         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1284         (WebTestRunner::WebPreferences::reset):
1285         (WebTestRunner::WebPreferences::applyTo):
1286         * DumpRenderTree/chromium/TestShell.cpp:
1287         (TestShell::TestShell):
1288         (TestShell::resetWebSettings):
1289         (TestShell::runFileTest):
1290         * DumpRenderTree/chromium/TestShell.h:
1291         (TestShell):
1292
1293 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1294
1295         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1296         https://bugs.webkit.org/show_bug.cgi?id=112699.
1297
1298         Reviewed by Adam Barth.
1299
1300         * Scripts/webkitpy/layout_tests/port/qt.py:
1301         (QtPort._search_paths):
1302         (QtPort._port_specific_expectations_files):
1303         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1304         (QtPortTest):
1305         (QtPortTest._assert_search_path):
1306         (QtPortTest._assert_expectations_files):
1307
1308 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1309
1310         [Qt] Enable kerning by default
1311         https://bugs.webkit.org/show_bug.cgi?id=112704
1312
1313         Reviewed by Jocelyn Turcotte.
1314
1315         Disable kerning by default, since some reference test expectations
1316         expect kerning to be default off.
1317
1318         * DumpRenderTree/qt/TestRunnerQt.cpp:
1319         (TestRunnerQt::reset):
1320         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1321         (WTR::activateFonts):
1322
1323 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1324
1325         [Qt] Remove empty function stubs from TestRunnerQt.
1326         https://bugs.webkit.org/show_bug.cgi?id=112799
1327
1328         We are reducing the code in TestRunnerQt step by step,
1329         in order to finally replace all of it with the generic
1330         TestRunner implementation.
1331         This patch removes several simple function stubs that
1332         currently do not implement any actual functionality.
1333
1334         Reviewed by Kenneth Rohde Christiansen.
1335
1336         * DumpRenderTree/qt/TestRunnerQt.cpp:
1337         * DumpRenderTree/qt/TestRunnerQt.h:
1338         (TestRunnerQt):
1339
1340 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1341
1342         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1343         https://bugs.webkit.org/show_bug.cgi?id=112687
1344
1345         Reviewed by Kenneth Rohde Christiansen.
1346
1347         Hide the SearchBar by default on window creation.
1348
1349         * MiniBrowser/efl/main.c:
1350         (window_create):
1351
1352 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1353
1354         Unreviewed, rolling out r146304.
1355         http://trac.webkit.org/changeset/146304
1356         https://bugs.webkit.org/show_bug.cgi?id=112788
1357
1358         to many expectations to update (Requested by antonm on
1359         #webkit).
1360
1361         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1362         * DumpRenderTree/DumpRenderTree.gypi:
1363         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1364         (WebKit):
1365         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1366         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1367         (TestInterfaces):
1368         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1369         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1370         * DumpRenderTree/chromium/TestShell.cpp:
1371         (TestShell::initialize):
1372         * DumpRenderTree/chromium/TestShell.h:
1373         (WebKit):
1374         * DumpRenderTree/chromium/TestShellMac.mm:
1375         (platformInit):
1376         * DumpRenderTree/chromium/TestShellWin.cpp:
1377         (platformInit):
1378         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1379         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1380         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1381         (WebThemeControlDRTWin::box):
1382         (WebThemeControlDRTWin::line):
1383         (WebThemeControlDRTWin::triangle):
1384         (WebThemeControlDRTWin::roundRect):
1385         (WebThemeControlDRTWin::oval):
1386         (WebThemeControlDRTWin::circle):
1387         (WebThemeControlDRTWin::nestedBoxes):
1388         (WebThemeControlDRTWin::markState):
1389         (WebThemeControlDRTWin::draw):
1390         (WebThemeControlDRTWin::drawTextField):
1391         (WebThemeControlDRTWin::drawProgressBar):
1392         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1393         (WebThemeControlDRTWin):
1394         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1395         (WebThemeEngineDRTMac):
1396         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1397         (+[FakeActiveWindow alwaysActiveWindow]):
1398         (+[FakeActiveWindow alwaysInactiveWindow]):
1399         (-[FakeActiveWindow initWithActiveControls:]):
1400         (-[FakeActiveWindow _hasActiveControls]):
1401         (WebThemeEngineDRTMac::paintScrollbarThumb):
1402         (stateToHIEnableState):
1403         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1404         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1405         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1406         (webRectToSkIRect):
1407         (drawControl):
1408         (drawTextField):
1409         (drawProgressBar):
1410         (WebThemeEngineDRTWin::paintButton):
1411         (WebThemeEngineDRTWin::paintMenuList):
1412         (WebThemeEngineDRTWin::paintScrollbarArrow):
1413         (WebThemeEngineDRTWin::paintScrollbarThumb):
1414         (WebThemeEngineDRTWin::paintScrollbarTrack):
1415         (WebThemeEngineDRTWin::paintSpinButton):
1416         (WebThemeEngineDRTWin::paintTextField):
1417         (WebThemeEngineDRTWin::paintTrackbar):
1418         (WebThemeEngineDRTWin::paintProgressBar):
1419         (WebThemeEngineDRTWin::getSize):
1420         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1421         (WebThemeEngineDRTWin):
1422         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1423
1424 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1425
1426         [Qt] Support -webkit-font-smoothing
1427         https://bugs.webkit.org/show_bug.cgi?id=106009
1428
1429         Reviewed by Jocelyn Turcotte.
1430
1431         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1432
1433         * DumpRenderTree/qt/TestRunnerQt.cpp:
1434         (TestRunnerQt::reset):
1435
1436 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1437
1438         [GTK] accessibility/aria-scrollbar-role.html is failing
1439         https://bugs.webkit.org/show_bug.cgi?id=98358
1440
1441         Reviewed by Martin Robinson.
1442
1443         Adds support for checking accessibility object's orientation.
1444         Orientation is checked by retrieving proper state of accessibility object.
1445
1446         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1447         (checkElementState):
1448         (AccessibilityUIElement::orientation):
1449         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1450         (WTR::AccessibilityUIElement::orientation):
1451
1452 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1453
1454         [chromium] move WebThemeEngine implementations to TestRunner library
1455         https://bugs.webkit.org/show_bug.cgi?id=112751
1456
1457         Reviewed by Adam Barth.
1458
1459         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1460         * DumpRenderTree/DumpRenderTree.gypi:
1461         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1462         (WebKit):
1463         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1464         (WebTestRunner::TestInterfaces::themeEngine):
1465         (WebTestRunner):
1466         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1467         (WebKit):
1468         (TestInterfaces):
1469         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1470         (WebTestRunner::WebTestInterfaces::themeEngine):
1471         (WebTestRunner):
1472         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1473         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1474         (WebTestRunner):
1475         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1476         (WebTestRunner::WebTestThemeControlWin::box):
1477         (WebTestRunner::WebTestThemeControlWin::line):
1478         (WebTestRunner::WebTestThemeControlWin::triangle):
1479         (WebTestRunner::WebTestThemeControlWin::roundRect):
1480         (WebTestRunner::WebTestThemeControlWin::oval):
1481         (WebTestRunner::WebTestThemeControlWin::circle):
1482         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1483         (WebTestRunner::WebTestThemeControlWin::markState):
1484         (WebTestRunner::WebTestThemeControlWin::draw):
1485         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1486         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1487         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1488         (WebTestRunner):
1489         (WebTestThemeControlWin):
1490         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1491         (WebTestRunner):
1492         (WebTestThemeEngineMac):
1493         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1494         (+[FakeActiveWindow alwaysActiveWindow]):
1495         (+[FakeActiveWindow alwaysInactiveWindow]):
1496         (-[FakeActiveWindow initWithActiveControls:]):
1497         (-[FakeActiveWindow _hasActiveControls]):
1498         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1499         (WebTestRunner):
1500         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1501         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1502         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1503         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1504         (WebTestRunner):
1505         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1506         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1507         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1508         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1509         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1510         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1511         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1512         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1513         (WebTestRunner::WebTestThemeEngineWin::getSize):
1514         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1515         (WebTestRunner):
1516         (WebTestThemeEngineWin):
1517         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1518         * DumpRenderTree/chromium/TestShell.cpp:
1519         (TestShell::initialize):
1520         * DumpRenderTree/chromium/TestShell.h:
1521         (WebKit):
1522         * DumpRenderTree/chromium/TestShellMac.mm:
1523         (platformInit):
1524         * DumpRenderTree/chromium/TestShellWin.cpp:
1525         (platformInit):
1526         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1527
1528 2013-03-19  Tony Chang  <tony@chromium.org>
1529
1530         Move testRunner.setTouchDragDropEnabled to internals.settings
1531         https://bugs.webkit.org/show_bug.cgi?id=112739
1532
1533         Reviewed by Adam Barth.
1534
1535         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1536         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1537         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1538         (TestRunner): Remove unnecessary code.
1539         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1540         (WebTestRunner::WebPreferences::reset):
1541         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1542
1543 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1544
1545         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1546         https://bugs.webkit.org/show_bug.cgi?id=112754
1547
1548         Reviewed by Darin Fisher.
1549
1550         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1551         now that it's always defined.
1552
1553         * DumpRenderTree/chromium/WebViewHost.cpp:
1554         * DumpRenderTree/chromium/WebViewHost.h:
1555         (WebViewHost):
1556
1557 2013-03-19  Kenneth Russell  <kbr@google.com>
1558
1559         Unreviewed, rolling out r146290.
1560         http://trac.webkit.org/changeset/146290
1561         https://bugs.webkit.org/show_bug.cgi?id=112751
1562
1563         Broke Chromium Mac build.
1564
1565         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1566         * DumpRenderTree/DumpRenderTree.gypi:
1567         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1568         (WebKit):
1569         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1570         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1571         (TestInterfaces):
1572         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1573         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1574         * DumpRenderTree/chromium/TestShell.cpp:
1575         (TestShell::initialize):
1576         * DumpRenderTree/chromium/TestShell.h:
1577         (WebKit):
1578         * DumpRenderTree/chromium/TestShellMac.mm:
1579         (platformInit):
1580         * DumpRenderTree/chromium/TestShellWin.cpp:
1581         (platformInit):
1582         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1583         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1584         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1585         (WebThemeControlDRTWin::box):
1586         (WebThemeControlDRTWin::line):
1587         (WebThemeControlDRTWin::triangle):
1588         (WebThemeControlDRTWin::roundRect):
1589         (WebThemeControlDRTWin::oval):
1590         (WebThemeControlDRTWin::circle):
1591         (WebThemeControlDRTWin::nestedBoxes):
1592         (WebThemeControlDRTWin::markState):
1593         (WebThemeControlDRTWin::draw):
1594         (WebThemeControlDRTWin::drawTextField):
1595         (WebThemeControlDRTWin::drawProgressBar):
1596         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1597         (WebThemeControlDRTWin):
1598         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1599         (WebThemeEngineDRTMac):
1600         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1601         (+[FakeActiveWindow alwaysActiveWindow]):
1602         (+[FakeActiveWindow alwaysInactiveWindow]):
1603         (-[FakeActiveWindow initWithActiveControls:]):
1604         (-[FakeActiveWindow _hasActiveControls]):
1605         (WebThemeEngineDRTMac::paintScrollbarThumb):
1606         (stateToHIEnableState):
1607         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1608         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1609         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1610         (webRectToSkIRect):
1611         (drawControl):
1612         (drawTextField):
1613         (drawProgressBar):
1614         (WebThemeEngineDRTWin::paintButton):
1615         (WebThemeEngineDRTWin::paintMenuList):
1616         (WebThemeEngineDRTWin::paintScrollbarArrow):
1617         (WebThemeEngineDRTWin::paintScrollbarThumb):
1618         (WebThemeEngineDRTWin::paintScrollbarTrack):
1619         (WebThemeEngineDRTWin::paintSpinButton):
1620         (WebThemeEngineDRTWin::paintTextField):
1621         (WebThemeEngineDRTWin::paintTrackbar):
1622         (WebThemeEngineDRTWin::paintProgressBar):
1623         (WebThemeEngineDRTWin::getSize):
1624         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1625         (WebThemeEngineDRTWin):
1626         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1627
1628 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1629
1630         [EFL] canvas-fallback-content.html is failing
1631         https://bugs.webkit.org/show_bug.cgi?id=111998
1632
1633         Reviewed by Chris Fleizach.
1634
1635         Adds support for getting platform name.
1636
1637         * DumpRenderTree/TestRunner.cpp:
1638         (TestRunner::staticValues):
1639         * DumpRenderTree/TestRunner.h:
1640         (TestRunner):
1641         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1642         (TestRunner::platformName):
1643
1644 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1645
1646         [chromium] move WebThemeEngine implementations to TestRunner library
1647         https://bugs.webkit.org/show_bug.cgi?id=112751
1648
1649         Reviewed by Adam Barth.
1650
1651         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1652         * DumpRenderTree/DumpRenderTree.gypi:
1653         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1654         (WebKit):
1655         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1656         (WebTestRunner::TestInterfaces::themeEngine):
1657         (WebTestRunner):
1658         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1659         (WebKit):
1660         (TestInterfaces):
1661         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1662         (WebTestRunner::WebTestInterfaces::themeEngine):
1663         (WebTestRunner):
1664         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1665         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1666         (WebTestRunner):
1667         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1668         (WebTestRunner::WebTestThemeControlWin::box):
1669         (WebTestRunner::WebTestThemeControlWin::line):
1670         (WebTestRunner::WebTestThemeControlWin::triangle):
1671         (WebTestRunner::WebTestThemeControlWin::roundRect):
1672         (WebTestRunner::WebTestThemeControlWin::oval):
1673         (WebTestRunner::WebTestThemeControlWin::circle):
1674         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1675         (WebTestRunner::WebTestThemeControlWin::markState):
1676         (WebTestRunner::WebTestThemeControlWin::draw):
1677         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1678         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1679         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1680         (WebTestRunner):
1681         (WebTestThemeControlWin):
1682         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1683         (WebTestRunner):
1684         (WebTestThemeEngineMac):
1685         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1686         (+[FakeActiveWindow alwaysActiveWindow]):
1687         (+[FakeActiveWindow alwaysInactiveWindow]):
1688         (-[FakeActiveWindow initWithActiveControls:]):
1689         (-[FakeActiveWindow _hasActiveControls]):
1690         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1691         (WebTestRunner):
1692         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1693         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1694         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1695         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1696         (WebTestRunner):
1697         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1698         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1699         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1700         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1701         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1702         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1703         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1704         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1705         (WebTestRunner::WebTestThemeEngineWin::getSize):
1706         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1707         (WebTestRunner):
1708         (WebTestThemeEngineWin):
1709         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1710         * DumpRenderTree/chromium/TestShell.cpp:
1711         (TestShell::initialize):
1712         * DumpRenderTree/chromium/TestShell.h:
1713         (WebKit):
1714         * DumpRenderTree/chromium/TestShellMac.mm:
1715         (platformInit):
1716         * DumpRenderTree/chromium/TestShellWin.cpp:
1717         (platformInit):
1718         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1719
1720 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1721
1722         [EFL][WK2] Separate WebView further from EwkView
1723         https://bugs.webkit.org/show_bug.cgi?id=111591
1724
1725         Reviewed by Caio Marcelo de Oliveira Filho.
1726
1727         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
1728         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
1729         since we can afford it having EWKViewGetWKView() private API to access WKView.
1730
1731         * TestWebKitAPI/PlatformWebView.h:
1732         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1733         (TestWebKitAPI::TEST):
1734         * TestWebKitAPI/efl/PlatformWebView.cpp:
1735         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1736         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1737         (TestWebKitAPI::PlatformWebView::resizeTo):
1738         (TestWebKitAPI::PlatformWebView::page):
1739         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1740         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1741         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1742         * WebKitTestRunner/PlatformWebView.h:
1743         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1744         (WTR::EventSenderProxy::dispatchEvent):
1745         (WTR::EventSenderProxy::keyDown):
1746         (WTR::EventSenderProxy::sendTouchEvent):
1747         (WTR::EventSenderProxy::setTouchModifier):
1748         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1749         (WTR::PlatformWebView::PlatformWebView):
1750         (WTR::PlatformWebView::~PlatformWebView):
1751         (WTR::PlatformWebView::resizeTo):
1752         (WTR::PlatformWebView::page):
1753         (WTR::PlatformWebView::focus):
1754         (WTR::PlatformWebView::windowSnapshotImage):
1755
1756 2013-03-19  Roger Fong  <roger_fong@apple.com>
1757
1758         Changes to VS2010 project files should only trigger builds on Windows bots.
1759         https://bugs.webkit.org/show_bug.cgi?id=112731
1760
1761         Reviewed by Timothy Horton.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1764         (_should_file_trigger_build):
1765
1766 2013-03-19  Roger Fong  <roger_fong@apple.com>
1767
1768         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
1769
1770         * Scripts/webkitpy/tool/steps/runtests.py:
1771         (RunTests.run):
1772         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1773         (RunTestsTest.test_webkit_run_unit_tests):
1774
1775 2013-03-19  Julie Parent  <jparent@chromium.org>
1776
1777         Dashboards: Introduce history namespace and unit tests.
1778         https://bugs.webkit.org/show_bug.cgi?id=112645
1779
1780         Reviewed by Ojan Vafai.
1781         
1782         Laying the framework for introducing the new history object and
1783         namespace.  This moves only static functions into the history
1784         namespace, and moves corresponding unit tests into seperate
1785         unit test file.
1786
1787         * TestResultServer/static-dashboards/aggregate_results.html:
1788         * TestResultServer/static-dashboards/dashboard_base.js:
1789         (parseCrossDashboardParameters):
1790         (parseDashboardSpecificParameters):
1791         (parseParameters):
1792         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1793         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1794         (.switch.return):
1795         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1796         * TestResultServer/static-dashboards/history.js: Added.
1797         * TestResultServer/static-dashboards/history_unittests.js: Added.
1798         * TestResultServer/static-dashboards/loader.js:
1799         (.):
1800         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1801         * TestResultServer/static-dashboards/run-unittests.html:
1802         * TestResultServer/static-dashboards/timeline_explorer.html:
1803         * TestResultServer/static-dashboards/timeline_explorer.js:
1804         * TestResultServer/static-dashboards/treemap.html:
1805         * TestResultServer/static-dashboards/treemap.js:
1806         (.switch.return):
1807         * TestResultServer/static-dashboards/ui.js:
1808
1809 2013-03-19  Daniel Bates  <dbates@webkit.org>
1810
1811         svn-apply has trouble applying a patch that adds a Windows newline to EOF
1812         https://bugs.webkit.org/show_bug.cgi?id=112732
1813
1814         Reviewed by Eric Seidel.
1815
1816         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
1817         of an existing file cannot be applied.
1818
1819         In particular, svn-{apply, unapply} compensate for differences in line endings
1820         by converting the line endings in a diff to match the line endings in the target
1821         file. The diff(1) command precedes the last line of a diff that adds a newline
1822         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
1823         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
1824         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
1825         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
1826         the newline characters in this special character sequence to match the line endings
1827         in the target file.
1828
1829         * Scripts/VCSUtils.pm:
1830         (parseDiff):
1831         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1832         Added tests:
1833             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1834             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1835             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1836             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1837         (escapeNewLineCharacters): Added.
1838         (toMacLineEndings): Added.
1839
1840 2013-03-19  James Robinson  <jamesr@chromium.org>
1841
1842         [chromium] Remove compositor settings that don't go through WebKit
1843         https://bugs.webkit.org/show_bug.cgi?id=112718
1844
1845         Reviewed by Adam Barth.
1846
1847         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1848         (main):
1849         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1850         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1851         (WebTestRunner::WebPreferences::reset):
1852         (WebTestRunner::WebPreferences::applyTo):
1853         * DumpRenderTree/chromium/TestShell.cpp:
1854         (TestShell::TestShell):
1855         (TestShell::resetWebSettings):
1856         * DumpRenderTree/chromium/TestShell.h:
1857         (TestShell):
1858
1859 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
1860
1861         Unreviewed, rolling out r146101.
1862         https://bugs.webkit.org/show_bug.cgi?id=111884
1863
1864         re-enable custom freetype on asan; this needs to be on
1865         now that the bot is running lucid.
1866
1867         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1868
1869 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
1870
1871         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
1872         https://bugs.webkit.org/show_bug.cgi?id=112365
1873
1874         Reviewed by Benjamin Poulain.
1875
1876         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
1877         harcoding it in wtf/Platform.h
1878
1879         * Scripts/webkitperl/FeatureList.pm:
1880
1881 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1882
1883         [Qt] Make ImageDiff similar to Chromium's ImageDiff
1884         https://bugs.webkit.org/show_bug.cgi?id=94782
1885
1886         Based on patch by Csaba Osztrogonác.
1887         Reviewed by Jocelyn Turcotte.
1888
1889         The diff image is generated with bright red indicating errors, but letting the base image
1890         shine through so the context of the error-pixel can be identified.
1891
1892         * DumpRenderTree/qt/ImageDiff.cpp:
1893         (main):
1894
1895 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
1896
1897         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
1898
1899         Rubber-stamped by Csaba Osztrogonác.
1900
1901         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
1902         since the latter might not cover the former.
1903
1904         * QtTestBrowser/launcherwindow.cpp:
1905         (LauncherWindow::print):
1906
1907 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
1908
1909         Style tweeks to default.css.
1910         
1911         Rubber-stamped by David Kilzer.
1912         
1913         Give visited links a different color to other links, so you can
1914         see which builds you've viewed.
1915         
1916         Make the <small> text less tiny.
1917
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1919         (small):
1920         (a:link,a:visited,a:active):
1921         (a:visited):
1922
1923 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
1924
1925         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
1926         https://bugs.webkit.org/show_bug.cgi?id=112494
1927
1928         Reviewed by Dirk Pranke.
1929
1930         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
1931         Also merged two pairs of methods to cleanup the code.
1932
1933         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1934         (PerfTestsRunner.run): Merged _upload_and_show_results.
1935         (PerfTestsRunner._generate_results): Merged _generate_output_files.
1936
1937 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
1938
1939         [chromium] build xdisplaycheck when building DRT
1940         https://bugs.webkit.org/show_bug.cgi?id=112636
1941
1942         Reviewed by Tony Chang.
1943
1944         It appears that we need xdisplaycheck to be built in order for
1945         Xvfb to be started correctly on the bots, and DRT was missing
1946         a dependency on it. This may be the cause of the ASAN bot not
1947         starting up properly (it only builds DRT).
1948
1949         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1950
1951 2013-03-18  David Levin  <levin@chromium.org>
1952
1953         Implement icon change notification dump for Chromium's test shell.
1954         https://bugs.webkit.org/show_bug.cgi?id=112614
1955
1956         This was previously implemented for some other platforms in r58111
1957         and r116547.
1958
1959         In r122806, fast/dom/icon-url-property.html stopped using it, but
1960         it is useful for tests, so I plan to re-add it to that test again.
1961
1962         Reviewed by Jochen Eisinger.
1963
1964         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1965         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
1966          icon change notifications from WebKit may be logged in test output.
1967         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1968         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
1969         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
1970         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
1971         (WebTestRunner):
1972         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
1973         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1974         (TestRunner):
1975         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1976         (WebTestRunner::WebTestProxyBase::didChangeIcon):
1977         (WebTestRunner):
1978         * DumpRenderTree/chromium/WebViewHost.cpp:
1979         (WebViewHost::didChangeIcon): Add the output about changing the icon.
1980         * DumpRenderTree/chromium/WebViewHost.h:
1981         (WebViewHost):
1982
1983 2013-03-18  Julie Parent  <jparent@chromium.org>
1984
1985         Cleanup: Move js for treemap and aggregate_results into own js files.
1986         https://bugs.webkit.org/show_bug.cgi?id=112618
1987
1988         Reviewed by Dirk Pranke.
1989         
1990         No functional changes, just moving the code into separate js file
1991         rather than inlined in the html, so we can test it, make it more
1992         modular, etc.  Other dashboard types are already done this way.
1993
1994         * TestResultServer/static-dashboards/aggregate_results.html:
1995         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
1996         (generatePage):
1997         (handleValidHashParameter):
1998         (htmlForBuilder):
1999         (rawValuesHTML):
2000         (chartHTML):
2001         (filteredValues):
2002         (chart):
2003         (htmlForRevisionRows):
2004         (wrapHTMLInTable):
2005         (htmlForSummaryTable):
2006         (valuesPerExpectation):
2007         (htmlForTestType):
2008         (htmlForTableRow):
2009         (extendedEncode):
2010         * TestResultServer/static-dashboards/treemap.html:
2011         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2012         (humanReadableTime):
2013         (convertToWebTreemapFormat):
2014         (reverseSortByAverage):
2015         (generatePage):
2016         (focusPath):
2017         (.switch.return):
2018         (handleQueryParameterChange):
2019         (extractName):
2020         (fullName):
2021         (handleFocus.):
2022         (handleFocus):
2023
2024 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2025
2026         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2027         https://bugs.webkit.org/show_bug.cgi?id=112622
2028
2029         Reviewed by Dirk Pranke.
2030
2031         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2032         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2033
2034 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2035
2036         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2037         https://bugs.webkit.org/show_bug.cgi?id=112619
2038
2039         Reviewed by Dirk Pranke.
2040
2041         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2042         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2043
2044         * Scripts/webkitpy/layout_tests/port/gtk.py:
2045         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2046         Port._webkit_baseline_path method.
2047         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2048         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2049         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2050         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2051         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2052         that are expected based on the builder name.
2053
2054 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2055
2056         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2057         https://bugs.webkit.org/show_bug.cgi?id=112571
2058
2059         Reviewed by Adam Barth.
2060
2061         Update function declarations for new WebFileSystemType enum. (All
2062         changes are behind an #ifdef so we can sync required changes in embedders.)
2063
2064         * DumpRenderTree/chromium/WebViewHost.cpp:
2065         (WebViewHost::openFileSystem):
2066         (WebViewHost::deleteFileSystem):
2067         * DumpRenderTree/chromium/WebViewHost.h:
2068         (WebViewHost):
2069
2070 2013-03-18  Julie Parent  <jparent@chromium.org>
2071
2072         Cleanup: Move timeline_exporer js out of html file into js.
2073         https://bugs.webkit.org/show_bug.cgi?id=112188
2074
2075         Reviewed by Dirk Pranke.
2076         
2077         Moves the javascript out of the html file and into a new js file.
2078         This follows the format of flakiness_dashboard.{html|js}.
2079         
2080         Also moves code from dashboard_base that is used only by this one
2081         dashboard, and makes it private to the dashboard.
2082
2083         * TestResultServer/static-dashboards/dashboard_base.js:
2084         * TestResultServer/static-dashboards/timeline_explorer.html:
2085         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2086         (generatePage):
2087         (initCurrentBuilderTestResults):
2088         (shouldShowWebKitRevisionsOnly):
2089         (updateTimelineForBuilder.):
2090         (updateTimelineForBuilder):
2091         (selectBuild):
2092         (updateBuildIndicator):
2093         (.addRow):
2094         (.addNumberRow):
2095         (.inspectorNode.getElementsByTagName.0.onclick):
2096         (.inspectorNode.getElementsByTagName.1.onclick):
2097         (.inspectorNode.getElementsByTagName.2.onclick):
2098         (updateBuildInspector):
2099         (showResultsDelta):
2100         (decompressResults.addFlakyDelta):
2101         (decompressResults):
2102
2103 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2104
2105         Unreviewed, rolling out r145272.
2106         http://trac.webkit.org/changeset/145272
2107         https://bugs.webkit.org/show_bug.cgi?id=111884
2108
2109         Turns out the ASAN build is still broken; possibly there's
2110         something still setting LD_LIBRARY_PATH, or possibly there's
2111         something else wrong. In the meantime, we need it to work again.
2112
2113         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2114
2115 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2116
2117         delete-stale-build-files is too aggressive
2118         https://bugs.webkit.org/show_bug.cgi?id=112595
2119
2120         Reviewed by Tim Horton.
2121
2122         It appears that whitelisting file extensions to keep is not a good idea.
2123         Blacklist files to delete instead, and only delete .o files for now.
2124         We can add more file extensions as needed.
2125
2126         * BuildSlaveSupport/delete-stale-build-files:
2127
2128 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2129
2130         Disable accessibility notifications after each test
2131         https://bugs.webkit.org/show_bug.cgi?id=112579
2132
2133         Reviewed by Tim Horton.
2134         
2135         In WebKitTestRunner, if any tests triggered accessibility notifications,
2136         the global notification handler would thereafter be active, and fire
2137         notifications for all subsequent tests.
2138         
2139         Fix by implementing AccessibilityController::resetToConsistentState() for
2140         Mac, and using it to clear the global notification handler.
2141
2142         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2143         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2144         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2145         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2146         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2147         (e.g. because of -autorelease).
2148         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2149         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2150         if there is one.
2151         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2152         Add -stopObserving
2153         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2154         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2155         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2156         center.
2157
2158 2013-03-18  Dana Jansens  <danakj@chromium.org>
2159
2160         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2161         https://bugs.webkit.org/show_bug.cgi?id=112392
2162
2163         Reviewed by James Robinson.
2164
2165         Removes the command line flag option from DRT.
2166
2167         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2168         (main):
2169
2170 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2171
2172         [GTK] plugins/plugin-clip-subframe.html is failing
2173         https://bugs.webkit.org/show_bug.cgi?id=112570
2174
2175         Reviewed by Martin Robinson.
2176
2177         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2178
2179 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2180
2181         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2182         https://bugs.webkit.org/show_bug.cgi?id=112442
2183
2184         Reviewed by Gustavo Noronha Silva.
2185
2186         * GtkLauncher/main.c:
2187         (reloadCb):
2188         (createToolbar):
2189         (createWindow):
2190
2191 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2192
2193         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2194         https://bugs.webkit.org/show_bug.cgi?id=112205
2195
2196         Disable this API test until Geoff can fix it.
2197
2198         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2199         (TestWebKitAPI::TEST):
2200
2201 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2202
2203         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2204         https://bugs.webkit.org/show_bug.cgi?id=112478
2205
2206         Reviewed by Tony Chang.
2207
2208         There is nothing that ensures that the log messages from the plugin
2209         come in before the layout test finished loading.
2210
2211         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2212         (PassDifferentNPPStruct::NPP_SetWindow):
2213         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2214         (NPP_SetWindow):
2215
2216 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2217
2218         Have the mac port support per_test_timeout in webkitpy
2219         https://bugs.webkit.org/show_bug.cgi?id=112466
2220
2221         Reviewed by Dirk Pranke.
2222         
2223         Both WTR and DRT handle --timeout arguments, so we can
2224         have the scripts pass the timeout values down to the tools.
2225
2226         * Scripts/webkitpy/layout_tests/port/mac.py:
2227         (MacPort.supports_per_test_timeout):
2228
2229 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2230
2231         Remove setAsynchronousSpellCheckingEnabled from test runners
2232         https://bugs.webkit.org/show_bug.cgi?id=112362
2233
2234         Reviewed by Tony Chang.
2235
2236         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2237         in internals.settings, so all ports can share it.
2238
2239         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2240         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2241         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2242         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2243         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2244         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2245         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2246         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2247         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2248         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2249         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2250         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2251
2252 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2253
2254         Fix the stupid unit tests.
2255
2256         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2257         (test_sample_process):
2258
2259 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2260
2261         Collect samples for unresponsive web processes
2262         https://bugs.webkit.org/show_bug.cgi?id=112409
2263
2264         Reviewed by Tim Horton.
2265         
2266         When we detect that a subprocess was unresponsive, run the 'sample'
2267         tool on that process, for the Mac port.
2268         
2269         The sample will be linked to from the results.html page, next
2270         to the crash log link.
2271
2272         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2273         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2274         look for samples on disk.
2275         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2276         (TestResultWriter):
2277         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2278         -sample.txt files, and have it copy their contents to a new file
2279         next to the test that spawned them (as we do for crash logs).
2280         * Scripts/webkitpy/layout_tests/port/base.py:
2281         (Port.look_for_new_samples): Base class does nothing for sampling.
2282         * Scripts/webkitpy/layout_tests/port/driver.py:
2283         (Driver._check_for_driver_crash): Kick off a sample if we detected
2284         that the subprocess was unresponsive.
2285         * Scripts/webkitpy/layout_tests/port/mac.py:
2286         (MacPort.sample_file_path): Utility to generate the file path
2287         to the generated sample files at the top level of layout-test-results.
2288         (MacPort.look_for_new_crash_logs): Fix typo
2289         (MacPort.look_for_new_samples): New function to find sample files.
2290         (MacPort.sample_process): Use the utility function to get the file path.
2291
2292 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2293
2294         [Qt] Remove simple getters and setters from TestRunnerQt
2295         https://bugs.webkit.org/show_bug.cgi?id=112343
2296
2297         Reviewed by Benjamin Poulain.
2298
2299         The removed functions and boolean members
2300         are being replaced by the implementations in the
2301         generic TestRunner.h.
2302
2303         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2304         (DumpRenderTree::dumpFrameScrollPosition):
2305         (DumpRenderTree::dumpFramesAsText):
2306         (DumpRenderTree::dump):
2307         (DumpRenderTree::titleChanged):
2308         (DumpRenderTree::dumpDatabaseQuota):
2309         (DumpRenderTree::dumpApplicationCacheQuota):
2310         (DumpRenderTree::statusBarMessage):
2311         (DumpRenderTree::createWindow):
2312         * DumpRenderTree/qt/TestRunnerQt.cpp:
2313         (TestRunnerQt::reset):
2314         * DumpRenderTree/qt/TestRunnerQt.h:
2315         (TestRunnerQt):
2316
2317 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2318
2319         Update the link on build.webkit.org to refer to perf.webkit.org
2320         https://bugs.webkit.org/show_bug.cgi?id=112416
2321
2322         Reviewed by Philip Rogers.
2323
2324         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2325
2326         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2327
2328 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2329
2330         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2331         https://bugs.webkit.org/show_bug.cgi?id=112394
2332
2333         Reviewed by Philippe Normand.
2334
2335         * GtkLauncher/main.c:
2336         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2337
2338 2013-03-14  Andreas Kling  <akling@apple.com>
2339
2340         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2341         <http://webkit.org/b/111815>
2342         <rdar://problem/13380145>
2343
2344         Reviewed by Anders Carlsson.
2345
2346         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2347         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2348         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2349
2350         * WebKitTestRunner/PlatformWebView.h:
2351         (PlatformWebView):
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::TestController::createOtherPage):
2354         (WTR::TestController::createWebViewWithOptions):
2355         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2356         (WTR::PlatformWebView::didInitializeClients):
2357
2358 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2359
2360         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2361         https://bugs.webkit.org/show_bug.cgi?id=112122
2362
2363         Reviewed by Kenneth Rohde Christiansen.
2364
2365         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2366
2367         * MiniBrowser/efl/main.c:
2368         (_Browser_Window):
2369         (search_box_show):
2370         (search_box_hide):
2371         (on_key_down):
2372         (on_url_changed):
2373         (on_search_field_aborted):
2374         (on_search_field_activated):
2375         (on_search_field_clicked):
2376         (on_search_backward_button_clicked):
2377         (on_search_forward_button_clicked):
2378         (window_create):
2379
2380 2013-03-14  Julie Parent  <jparent@chromium.org>
2381
2382         Cleanup: Remove g_resourceLoader.
2383         https://bugs.webkit.org/show_bug.cgi?id=112305
2384
2385         Reviewed by Dirk Pranke.
2386         
2387         Removing another global.
2388         
2389         Now, each dashboard creates its own loader, rather than having
2390         a general global one.
2391         
2392         Remove usage of g_resourceLoader.isLoadingComplete from 
2393         handleLocationChange by ensuring that handleLocationChange is
2394         never called before the loader is done.  It was called in two
2395         places before: 1 was from the callback when the loader is done,
2396         so that was obviously true, and the other was from onhashchange,
2397         where it would just return rather than running.  Instead, lets
2398         only register the onhashchange handler once the loader is
2399         setup, so the check is no longer necessary.
2400         
2401         Remove isLoadingComplete since it is now unused.
2402         
2403         Callback for loader is now initializeHistory, rather than just
2404         handleLocationChange which will set up the hashchange handler now.
2405         This will all eventually be moving to a new History object.
2406
2407         * TestResultServer/static-dashboards/aggregate_results.html:
2408         * TestResultServer/static-dashboards/dashboard_base.js:
2409         (handleLocationChange):
2410         (intializeHistory):
2411         (decompressResults):
2412         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2413         (generatePage):
2414         * TestResultServer/static-dashboards/loader.js:
2415         (.):
2416         * TestResultServer/static-dashboards/loader_unittests.js:
2417         * TestResultServer/static-dashboards/timeline_explorer.html:
2418         * TestResultServer/static-dashboards/treemap.html:
2419
2420 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2421
2422         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2423         https://bugs.webkit.org/show_bug.cgi?id=109404
2424
2425         Reviewed by Tony Chang.
2426
2427         Removes all the code related to smartInsertDeleteEnabled and
2428         selectTrailingWhitespaceEnabled settings as they will be managed from
2429         internals from now on.
2430
2431         * DumpRenderTree/TestRunner.cpp:
2432         (TestRunner::staticFunctions):
2433         * DumpRenderTree/TestRunner.h:
2434         (TestRunner):
2435         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2436         (WebKit):
2437         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2438         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2439         (DumpRenderTree):
2440         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2441         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2442         (WebTestRunner::WebTestProxy::didStopLoading):
2443         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2444         (WebTestRunner::TestRunner::TestRunner):
2445         (WebTestRunner::TestRunner::reset):
2446         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2447         (TestRunner):
2448         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2449         (WebTestRunner::WebPreferences::applyTo): Set default values for
2450         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2451         Chromium DRT default values are different from Chromium browser.
2452         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2453         * DumpRenderTree/chromium/WebViewHost.cpp:
2454         * DumpRenderTree/chromium/WebViewHost.h:
2455         (WebViewHost):
2456         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2457         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2458         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2460         (resetDefaultsToConsistentValues):
2461         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2462         * DumpRenderTree/mac/DumpRenderTree.mm:
2463         (resetWebViewToConsistentStateBeforeTesting):
2464         * DumpRenderTree/mac/TestRunnerMac.mm:
2465         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2466         (WebCore::WebPage::resetSettings):
2467         * DumpRenderTree/qt/TestRunnerQt.cpp:
2468         * DumpRenderTree/qt/TestRunnerQt.h:
2469         (TestRunnerQt):
2470         * DumpRenderTree/win/DumpRenderTree.cpp:
2471         (resetWebViewToConsistentStateBeforeTesting):
2472         * DumpRenderTree/win/TestRunnerWin.cpp:
2473         * DumpRenderTree/wx/TestRunnerWx.cpp:
2474
2475 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2476
2477         [Qt] Disable DRT on Windows
2478
2479         Reviewed by Jocelyn Turcotte.
2480
2481         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2482
2483         * qmake/mkspecs/features/configure.prf:
2484
2485 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2486
2487         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2488         https://bugs.webkit.org/show_bug.cgi?id=110728
2489
2490         Reviewed by Gyuyoung Kim.
2491
2492         Use the page group to create the view object.
2493
2494         * MiniBrowser/efl/main.c:
2495         (window_create):
2496
2497 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2498
2499         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2500
2501         Reviewed by Tor Arne Vestbø.
2502
2503         The mock versions of these web facing features should be instantiated when
2504         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2505         such as QtLocation are actually needed.
2506
2507         This patch decouples enabling device orientation/motion and geolocation from
2508         the underlying Qt modules and makes them available in developer builds
2509         (!production_build) and backed by mock backends when running in drt.
2510
2511         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2512         developers the web facing features are always enabled (although requests will
2513         time out) and the mock backends are enabled inside DRT, allowing for the layout
2514         tests to run with less dependencies.
2515
2516         In addition this also enables the mock device motion client, which was
2517         previously never instantiated.
2518
2519         * qmake/mkspecs/features/features.prf:
2520
2521 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2522
2523         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2524         https://bugs.webkit.org/show_bug.cgi?id=112340
2525
2526         Reviewed by Simon Hausmann.
2527
2528         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2529         (DumpRenderTree::dump):
2530             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2531         (DumpRenderTree::dumpApplicationCacheQuota):
2532         * DumpRenderTree/qt/TestRunnerQt.cpp:
2533         (TestRunnerQt::reset):
2534         * DumpRenderTree/qt/TestRunnerQt.h:
2535         (TestRunnerQt):
2536
2537 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2538
2539         [Qt] Port DRT to use TestRunner::dumpAsText()
2540         https://bugs.webkit.org/show_bug.cgi?id=112260
2541
2542         Reviewed by Benjamin Poulain.
2543
2544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2545         (WebCore::DumpRenderTree::open):
2546         (WebCore::methodNameStringForFailedTest):
2547             Change parameter from type TestRunnerQt* to TestRunner*.
2548         (WebCore::DumpRenderTree::dump):
2549             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2550             Instead we should rely on TestRunner::generatePixelResults().
2551         * DumpRenderTree/qt/TestRunnerQt.cpp:
2552         (TestRunnerQt::reset):
2553         * DumpRenderTree/qt/TestRunnerQt.h:
2554         (TestRunnerQt):
2555
2556 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2557
2558         Implement FontLoader interface
2559         https://bugs.webkit.org/show_bug.cgi?id=98395
2560
2561         Reviewed by Eric Seidel.
2562
2563         Enable FontLoadEvents runtime flag for TestShell.
2564
2565         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2566         (WebTestRunner::TestInterfaces::TestInterfaces):
2567
2568 2013-03-13  Julie Parent  <jparent@chromium.org>
2569
2570         CLeanup: remove unnecessary call to parseParameters.
2571         https://bugs.webkit.org/show_bug.cgi?id=112309
2572
2573         Reviewed by Ojan Vafai.
2574         
2575         We call parseCrossDashboardParameters when the dashboard initially
2576         loads to set the state required for loadBuildersList, and then we
2577         call it again once we are fully done with loading, so there is no
2578         reason to call it in the middle of the loading process here.
2579
2580         * TestResultServer/static-dashboards/loader.js:
2581         (.):
2582
2583 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2584
2585         Unreviewed. Now I'm a reviewer :)
2586
2587         * Scripts/webkitpy/common/config/committers.py:
2588
2589 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2590
2591         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2592         https://bugs.webkit.org/show_bug.cgi?id=112277
2593
2594         Reviewed by Adam Barth.
2595
2596         * Scripts/webkitperl/FeatureList.pm:
2597         * qmake/mkspecs/features/features.pri:
2598
2599 2013-03-13  Adam Barth  <abarth@webkit.org>
2600
2601         run-perf-tests should support content_shell
2602         https://bugs.webkit.org/show_bug.cgi?id=112291
2603
2604         Reviewed by Eric Seidel.
2605
2606         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2607         (PerfTestsRunner._parse_args):
2608
2609 2013-03-13  Oliver Hunt  <oliver@apple.com>
2610
2611         Simplify Checked<> multiplication
2612         https://bugs.webkit.org/show_bug.cgi?id=112286
2613
2614         Reviewed by James Robinson.
2615
2616         Add tests for multiplication by zero and max to ensure we don't
2617         mess them up should we ever make changes to Checked<> in future.
2618
2619         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2620         (TestWebKitAPI):
2621
2622 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2623
2624         [Qt] Unreviewed prospective Windows build fix
2625
2626         Do the usual thing, include the moc generated code in the .cpp file instead
2627         of compiling it standalone, to ensure that config.h is included, too, and
2628         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2629
2630         * DumpRenderTree/qt/EventSenderQt.cpp:
2631
2632 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2633
2634         [Qt] Port TestRunner::findString to shared interface
2635         https://bugs.webkit.org/show_bug.cgi?id=112147
2636
2637         Reviewed by Jocelyn Turcotte.
2638
2639         This patch also removes DumpRenderTree and some other helper classes from
2640         the WebCore namespace, to which they do not really belong.
2641
2642         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2643         (main):
2644         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2645         (DumpRenderTree::DumpRenderTree):
2646         (DumpRenderTree::~DumpRenderTree):
2647         (DumpRenderTree::instance):
2648         (DumpRenderTree::setShouldTimeout):
2649         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2650         (DumpRenderTree):
2651         * DumpRenderTree/qt/EventSenderQt.cpp:
2652         (EventSender::contextClick):
2653         (EventSender::sendEvent):
2654         (EventSender::postEvent):
2655         * DumpRenderTree/qt/EventSenderQt.h:
2656         (EventSender::isGraphicsBased):
2657         * DumpRenderTree/qt/TestRunnerQt.cpp:
2658         (TestRunnerQt::TestRunnerQt):
2659         (TestRunner::findString):
2660         (TestRunnerQt::setMockDeviceOrientation):
2661         (TestRunnerQt::setGeolocationPermission):
2662         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2663         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2664         (TestRunnerQt::setMockGeolocationPosition):
2665         * DumpRenderTree/qt/TestRunnerQt.h:
2666         (TestRunnerQt):
2667
2668 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2669
2670         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2671         https://bugs.webkit.org/show_bug.cgi?id=112129
2672
2673         Reviewed by Adam Barth.
2674
2675         Following Chromium
2676         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2677         this is being renamed to better explain what it does.
2678
2679         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2680
2681 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2682
2683         [Qt] Unreviewed trivial typo fix
2684
2685         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2686         TextRunner.h. Thanks Zeno :)
2687
2688 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2689
2690         [Qt] Prepare DRT for transition to shared TestRunner interface
2691         https://bugs.webkit.org/show_bug.cgi?id=112144
2692
2693         Reviewed by Benjamin Poulain.
2694
2695         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2696         the JSC C API based one.
2697
2698         This is impplemented by instantiating the QObject based testRunner in
2699         the global object, then instantiating the JSC C based TestRunner
2700         separately and placing it "behind" the QObject based testRunner through
2701         injection of the individual functions through proxies. (prototype
2702         chaining doesn't work due to the this object and Function.prototype.bind
2703         doesn't work due to the native function)
2704
2705         This allows for porting over method by method by removing the method
2706         from the QObject TestRunnerQt and implementing it in the JSC C based
2707         TestRunner.
2708
2709         In order for this to link and run dummy implementations of all the
2710         necessary TestRunner functions are provided.
2711
2712         * DumpRenderTree/qt/DumpRenderTree.pro:
2713         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2714         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2715         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2716         (WebCore::DumpRenderTree::initJSObjects):
2717         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2718         (DumpRenderTree):
2719         * DumpRenderTree/qt/TestRunnerQt.cpp:
2720         (TestRunner::~TestRunner):
2721         (TestRunner::addDisallowedURL):
2722         (TestRunner::queueLoad):
2723         (TestRunner::removeAllVisitedLinks):
2724         (TestRunner::setAcceptsEditing):
2725         (TestRunner::simulateLegacyWebNotificationClick):
2726         (TestRunner::setWindowIsKey):
2727         (TestRunner::setAlwaysAcceptCookies):
2728         (TestRunner::addOriginAccessWhitelistEntry):
2729         (TestRunner::setWebViewEditable):
2730         (TestRunner::clearAllApplicationCaches):
2731         (TestRunner::setTextDirection):
2732         (TestRunner::notifyDone):
2733         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2734         (TestRunner::overridePreference):
2735         (TestRunner::pathToLocalResource):
2736         (TestRunner::removeAllWebNotificationPermissions):
2737         (TestRunner::simulateWebNotificationClick):
2738         (TestRunner::closeIdleLocalStorageDatabases):
2739         (TestRunner::focusWebView):
2740         (TestRunner::setBackingScaleFactor):
2741         (TestRunner::removeChromeInputField):
2742         (TestRunner::addChromeInputField):
2743         (TestRunner::originsWithLocalStorage):
2744         (TestRunner::deleteAllLocalStorage):
2745         (TestRunner::deleteLocalStorageForOrigin):
2746         (TestRunner::observeStorageTrackerNotifications):
2747         (TestRunner::syncLocalStorage):
2748         (TestRunner::windowCount):
2749         (TestRunner::setWaitToDump):
2750         (TestRunner::waitForPolicyDelegate):
2751         (TestRunner::webHistoryItemCount):
2752         (TestRunner::showWebInspector):
2753         (TestRunner::closeWebInspector):
2754         (TestRunner::evaluateInWebInspector):
2755         (TestRunner::setSerializeHTTPLoads):
2756         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2757         (TestRunner::setCustomPolicyDelegate):
2758         (TestRunner::setDatabaseQuota):
2759         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2760         (TestRunner::resetPageVisibility):
2761         (TestRunner::keepWebHistory):
2762         (TestRunner::goBack):
2763         (TestRunner::originsWithApplicationCache):
2764         (TestRunner::applicationCacheDiskUsageForOrigin):
2765         (TestRunner::display):
2766         (TestRunner::dispatchPendingLoadRequests):
2767         (TestRunner::clearPersistentUserStyleSheet):
2768         (TestRunner::callShouldCloseOnWebView):
2769         (TestRunner::copyDecodedHostName):
2770         (TestRunner::clearBackForwardList):
2771         (TestRunner::clearAllDatabases):
2772         (TestRunner::clearApplicationCacheForOrigin):
2773         (TestRunner::apiTestGoToCurrentBackForwardItem):
2774         (TestRunner::authenticateSession):
2775         (TestRunner::abortModal):
2776         (TestRunner::setStorageDatabaseIdleInterval):
2777         (TestRunner::setAsynchronousSpellCheckingEnabled):
2778         (TestRunner::setXSSAuditorEnabled):
2779         (TestRunner::setSpatialNavigationEnabled):
2780         (TestRunner::setScrollbarPolicy):
2781         (TestRunner::setJavaScriptCanAccessClipboard):
2782         (TestRunner::setAutomaticLinkDetectionEnabled):
2783         (TestRunner::setUserStyleSheetEnabled):
2784         (TestRunner::setUserStyleSheetLocation):
2785         (TestRunner::setUseDashboardCompatibilityMode):
2786         (TestRunner::setTabKeyCyclesThroughElements):
2787         (TestRunner::setSmartInsertDeleteEnabled):
2788         (TestRunner::setSelectTrailingWhitespaceEnabled):
2789         (TestRunner::setPrivateBrowsingEnabled):
2790         (TestRunner::setPluginsEnabled):
2791         (TestRunner::setPopupBlockingEnabled):
2792         (TestRunner::setMockSpeechInputDumpRect):
2793         (TestRunner::setPersistentUserStyleSheetLocation):
2794         (TestRunner::setMockGeolocationPosition):
2795         (TestRunner::setMockGeolocationPositionUnavailableError):
2796         (TestRunner::setMockDeviceOrientation):
2797         (TestRunner::setMainFrameIsFirstResponder):
2798         (TestRunner::setIconDatabaseEnabled):
2799         (TestRunner::setGeolocationPermission):
2800         (TestRunner::setDefersLoading):
2801         (TestRunner::setCacheModel):
2802         (TestRunner::setAuthorAndUserStylesEnabled):
2803         (TestRunner::setAllowFileAccessFromFileURLs):
2804         (TestRunner::setAppCacheMaximumSize):
2805         (TestRunner::setAllowUniversalAccessFromFileURLs):
2806         (TestRunner::setApplicationCacheOriginQuota):
2807         (TestRunner::denyWebNotificationPermission):
2808         (TestRunner::grantWebNotificationPermission):
2809         (TestRunner::setValueForUser):
2810         (TestRunner::setViewModeMediaFeature):
2811         (TestRunner::setPageVisibility):
2812         (TestRunner::addMockSpeechInputResult):
2813         (TestRunner::removeOriginAccessWhitelistEntry):
2814         (TestRunner::addUserScript):
2815         (TestRunner::isCommandEnabled):
2816         (TestRunner::evaluateScriptInIsolatedWorld):
2817         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2818         (TestRunner::copyEncodedHostName):
2819         (TestRunner::addUserStyleSheet):
2820         (TestRunner::findString):
2821         (TestRunner::execCommand):
2822         (TestRunner::localStorageDiskUsageForOrigin):
2823
2824 2013-03-12  Julie Parent  <jparent@chromium.org>
2825
2826         Cleanup: Move flatten-trie to loader.
2827         https://bugs.webkit.org/show_bug.cgi?id=112196
2828
2829         Reviewed by Dirk Pranke.
2830
2831         flatten-trie is used only by the loader, so move it there and make it
2832         private, rather than global in dashbaord_base. Moved the corresponding
2833         unit test from flakiness_dashboard_unittests to loader_unittests.
2834         
2835         * TestResultServer/static-dashboards/dashboard_base.js:
2836         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2837         * TestResultServer/static-dashboards/loader.js:
2838         (.):
2839         * TestResultServer/static-dashboards/loader_unittests.js:
2840
2841 2013-03-12  Oliver Hunt  <oliver@apple.com>
2842
2843         Unbreak api tests
2844
2845         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2846         (TestWebKitAPI):
2847
2848 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2849
2850         Unreviewed, disabling tests for Win EWS.
2851
2852         win-ews obviously cannot keep up with running tests, it's >300 behind.
2853         Probably doesn't help that its (likely) running tests serially.
2854
2855         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2856         (WinEWS):
2857
2858 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2859
2860         Add a --build-directory argument to delete-stale-build-files
2861         https://bugs.webkit.org/show_bug.cgi?id=112198
2862
2863         Reviewed by Ryosuke Niwa.
2864
2865         * BuildSlaveSupport/delete-stale-build-files:
2866         (main): Add --build-directory argument.
2867
2868 2013-03-12  Oliver Hunt  <oliver@apple.com>
2869
2870         Appease MSVC
2871
2872         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2873         (TestWebKitAPI):
2874
2875 2013-03-12  Oliver Hunt  <oliver@apple.com>
2876
2877         Add more Checked<> tests
2878         https://bugs.webkit.org/show_bug.cgi?id=112190
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         Tests!
2883
2884         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2885         (TestWebKitAPI):
2886
2887 2013-03-12  Julie Parent  <jparent@chromium.org>
2888
2889         Cleanup: Move loading complete function into callback, rather than global.
2890         https://bugs.webkit.org/show_bug.cgi?id=112167
2891
2892         Reviewed by Dirk Pranke.
2893         
2894         Stop calling global functions, pass in proper handler to Loader
2895         constructor. Note that the callback is optional, as tests, and
2896         some potential dashboards, do not need one.
2897
2898         * TestResultServer/static-dashboards/dashboard_base.js:
2899         * TestResultServer/static-dashboards/loader.js:
2900         (.):
2901         * TestResultServer/static-dashboards/loader_unittests.js:
2902
2903 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2904
2905         [EFL][WK2] Add popup menu support to MiniBrowser
2906         https://bugs.webkit.org/show_bug.cgi?id=108934
2907
2908         Reviewed by Kenneth Rohde Christiansen.
2909
2910         Implement popup menu support in MiniBrowser by handling popup_menu_show
2911         and popup_menu_hide smart functions on the view and using the Ewk popup
2912         menu API.
2913
2914         * MiniBrowser/efl/main.c:
2915         (_Browser_Window):
2916         (on_popup_menu_discarded):
2917         (on_popup_menu_item_clicked):
2918         (popup_menu_populate):
2919         (on_popup_menu_show):
2920         (on_popup_menu_hide):
2921         (window_create): Use calloc() instead of malloc() to allocate memory for
2922         Browser_Window. This makes sure all the structs members are initialized
2923         to 0 (such as the new elm_popup_menu pointer).
2924
2925 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2926
2927         [GTK] Set up the libPlatformGtk.la library
2928         https://bugs.webkit.org/show_bug.cgi?id=111738
2929
2930         Reviewed by Martin Robinson.
2931
2932         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2933         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
2934         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2935
2936 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2937
2938         [GTK] Enable Web Audio in development builds
2939         https://bugs.webkit.org/show_bug.cgi?id=111831
2940
2941         Reviewed by Philippe Normand.
2942
2943         Web Audio is already quite well supported on the GTK port but still has a few issues
2944         that must be addressed before it is enabled by default. Despite that it should be enabled
2945         in development builds just so we are up-to-date with future feature infrastructure changes.
2946         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
2947         that's an obvious goal before enabling the feature in release builds.
2948
2949         * Scripts/webkitperl/FeatureList.pm:
2950
2951 2013-03-11  Andreas Kling  <akling@apple.com>
2952
2953         [Mac][WK1] Add support for alert() in MiniBrowser.
2954         <http://webkit.org/b/112090>
2955
2956         Reviewed by Anders Carlsson.
2957
2958         * MiniBrowser/mac/WK1BrowserWindowController.m:
2959         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2960
2961 2013-03-11  Julie Parent  <jparent@chromium.org>
2962
2963         Dashboard cleanup: Create ui.Errors
2964         https://bugs.webkit.org/show_bug.cgi?id=111785
2965
2966         Reviewed by Ojan Vafai.
2967         
2968         Create ui.Errors for handling errors the dashboards
2969         encounter. Loader now has a Error object that it can add to,
2970         and individual dashboards can show errors when desired.
2971         Currently, only flakiness_db shows errors, but this is 
2972         generic and there is no reason why other dbs wouldn't want to
2973         show errors.
2974
2975         * TestResultServer/static-dashboards/dashboard_base.js:
2976         (resourceLoadingComplete):
2977         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2978         (generatePage):
2979         * TestResultServer/static-dashboards/loader.js:
2980         (.):
2981         * TestResultServer/static-dashboards/ui.js:
2982         (.):
2983
2984 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
2985
2986         Some StringHasher tests are broken because of missing null termination
2987         https://bugs.webkit.org/show_bug.cgi?id=111284
2988
2989         Reviewed by Darin Adler.
2990
2991         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2992         (TestWebKitAPI): Added null termination since C strings are null-terminated.
2993         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
2994         the bug caught by it is now fixed.
2995
2996 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2997
2998         Unreviewed, rolling out r145200.
2999         http://trac.webkit.org/changeset/145200
3000         https://bugs.webkit.org/show_bug.cgi?id=112063
3001
3002         Broke a couple of unit tests (Requested by zdobersek on
3003         #webkit).
3004
3005         * Scripts/webkitperl/FeatureList.pm:
3006
3007 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3008
3009         [GTK] WebKit2-only build fails
3010         https://bugs.webkit.org/show_bug.cgi?id=112033
3011
3012         Reviewed by Gustavo Noronha Silva.
3013
3014         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3015         generic part, WebKit1-specific part and WebKit2-specific part.
3016         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3017         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3018         directly.
3019
3020 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3021
3022         Adding myself to the committers list.
3023
3024         Unreviewed.
3025
3026         * Scripts/webkitpy/common/config/committers.py:
3027
3028 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3029
3030         [BlackBerry] Disable MathML support
3031         https://bugs.webkit.org/show_bug.cgi?id=111929
3032
3033         Reviewed by Rob Buis.
3034
3035         * Scripts/webkitperl/FeatureList.pm:
3036
3037 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3038
3039         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3040         https://bugs.webkit.org/show_bug.cgi?id=111970
3041
3042         Reviewed by Chris Fleizach.
3043
3044         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3045         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3046         undefined symbol.
3047
3048         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3049         (WTR::AccessibilityUIElement::supportedActions):
3050         (WTR):
3051
3052 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3053
3054         [chromium] Android apk targets should depend directly on Java library targets
3055         https://bugs.webkit.org/show_bug.cgi?id=111746
3056
3057         Reviewed by Eric Seidel.
3058
3059         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3060         Make DumpRenderTree_apk depend directly on base_java and net_java.
3061         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3062         Make TestWebKitAPI_apk depend directly on base_java.
3063
3064 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3065
3066         [chromium] remove obsolete user gesture methods from WebFrame
3067         https://bugs.webkit.org/show_bug.cgi?id=111696
3068
3069         Reviewed by Adam Barth.
3070
3071         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3072         (WebTestRunner::TestPlugin::handleInputEvent):
3073         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3074
3075 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3076
3077         Unreviewed, add myself to commiters.py.
3078
3079         * Scripts/webkitpy/common/config/committers.py:
3080
3081 2013-03-08  Julie Parent  <jparent@chromium.org>
3082
3083         Cleanup: Remove dead code.
3084         https://bugs.webkit.org/show_bug.cgi?id=111900
3085
3086         Reviewed by Dirk Pranke.
3087         
3088         Treemap overrides a global function that used to be in 
3089         dashboard_base, but was removed months ago in
3090         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3091         no caller. 
3092
3093         * TestResultServer/static-dashboards/treemap.html:
3094
3095 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3096
3097         Implemented new API for RTCStatsReport object.
3098         https://bugs.webkit.org/show_bug.cgi?id=110333
3099
3100         Reviewed by Adam Barth.
3101
3102         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3103         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3104
3105 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3106
3107         [chromium] use custom freetype on linux asan builds again
3108         https://bugs.webkit.org/show_bug.cgi?id=111884
3109
3110         Reviewed by Tony Chang.
3111
3112         We no longer need the workaround after chromium r186540.
3113
3114         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3115
3116 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3117
3118         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3119         https://bugs.webkit.org/show_bug.cgi?id=111798
3120
3121         Reviewed by Dirk Pranke.
3122
3123         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3124
3125         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3126
3127 2013-03-08  James Robinson  <jamesr@chromium.org>
3128
3129         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3130         https://bugs.webkit.org/show_bug.cgi?id=111632
3131
3132         Reviewed by Adrienne Walker.
3133
3134         * DumpRenderTree/chromium/WebViewHost.cpp:
3135         (WebViewHost::initializeLayerTreeView):
3136         * DumpRenderTree/chromium/WebViewHost.h:
3137         (WebViewHost):
3138
3139 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3140
3141         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3142         https://bugs.webkit.org/show_bug.cgi?id=111297
3143
3144         Reviewed by Kenneth Rohde Christiansen.
3145
3146         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3147         (WTR::TestRunner::setViewModeMediaFeature):
3148
3149 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3150
3151         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3152         https://bugs.webkit.org/show_bug.cgi?id=111814
3153
3154         Reviewed by Ryosuke Niwa.
3155
3156         Add the needed supportedActions() attribute to WKTestRunner.
3157
3158         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3159         (WTR::AccessibilityUIElement::supportedActions):
3160         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3161         (AccessibilityUIElement):
3162         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3164         (WTR::AccessibilityUIElement::supportedActions):
3165
3166 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3167
3168         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3169         https://bugs.webkit.org/show_bug.cgi?id=111851
3170
3171         Reviewed by Kenneth Rohde Christiansen.
3172
3173         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3174         (TestWebKitAPI::TEST):
3175
3176             Fixed WKURLRef instance leaking.
3177
3178 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3179
3180         [EFL] [WK2] Some authentication tests fail in WebKit2
3181         https://bugs.webkit.org/show_bug.cgi?id=106407
3182
3183         Reviewed by Kenneth Rohde Christiansen.
3184
3185         Add patch from upstream for libsoup 2.40 to fix several authentication
3186         test cases.
3187
3188         * efl/jhbuild.modules:
3189         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3190
3191 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3192
3193         [GTK] Enable Web Audio in development builds
3194         https://bugs.webkit.org/show_bug.cgi?id=111831
3195
3196         Reviewed by Philippe Normand.
3197
3198         Web Audio is already quite well supported on the GTK port but still has a few issues
3199         that must be addressed before it is enabled by default. Despite that it should be enabled
3200         in development builds just so we are up-to-date with future feature infrastructure changes.
3201         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3202         that's an obvious goal before enabling the feature in release builds.
3203
3204         * Scripts/webkitperl/FeatureList.pm:
3205
3206 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3207
3208         [chromium] delay clearing the TestRunners until the main view was deleted
3209         https://bugs.webkit.org/show_bug.cgi?id=111823
3210
3211         Reviewed by Eric Seidel.
3212
3213         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3214         This may call into the test runners which assume that the delegate is
3215         always non-NULL.
3216
3217         * DumpRenderTree/chromium/TestShell.cpp:
3218         (TestShell::~TestShell):
3219
3220 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3221
3222         Sheriffbot whois command can't search by full name
3223         https://bugs.webkit.org/show_bug.cgi?id=111825
3224
3225         Reviewed by Eric Seidel.
3226
3227         Allowed multiple arguments to Sheriffbot's whois command.
3228         Updated test expectations.
3229
3230         * Scripts/webkitpy/tool/bot/irc_command.py:
3231         (Whois.execute):
3232         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3233         (IRCCommandTest.test_whois):
3234
3235 2013-03-07  Nils Barth  <nbarth@chromium.org>
3236
3237         Add Nils Barth and Koji Hara to committers.py
3238         https://bugs.webkit.org/show_bug.cgi?id=111806
3239
3240         Reviewed by Eric Seidel.
3241
3242         * Scripts/webkitpy/common/config/committers.py:
3243
3244 2013-03-07  Glenn Adams  <glenn@skynav.com>
3245
3246         run-pert-tests should have a --test-runner-count option
3247         https://bugs.webkit.org/show_bug.cgi?id=111726
3248
3249         Reviewed by Ryosuke Niwa.
3250
3251         Add --test-runner-count option to run-perf-tests, with default value of 4.
3252         This option allows command line configuration of the number of times to invoke
3253         the test runner (serially, not in parallel) when running a specific test in
3254         a test set.
3255
3256         * Scripts/webkitpy/performance_tests/perftest.py:
3257         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3258         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3259         (PerfTest.run): Rename process_run_count to test_runner_count.
3260         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3261         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3262         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3263         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3264         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3265         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3266         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3267         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3268         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3269         (MainTest.test_run_with_repeat):
3270         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3271         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3272         (MainTest.test_default_args): Add test for default option argument values.
3273         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3274
3275 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3276
3277         Add myself to reviewers.py
3278         https://bugs.webkit.org/show_bug.cgi?id=111757
3279
3280         Reviewed by Eric Seidel.
3281
3282         * Scripts/webkitpy/common/config/committers.py:
3283
3284 2013-03-07  Glenn Adams  <glenn@skynav.com>
3285
3286         run-perf-tests should have a --repeat option
3287         https://bugs.webkit.org/show_bug.cgi?id=100030
3288
3289         Reviewed by Ryosuke Niwa.
3290
3291         Add --repeat option to run-perf-tests, with default value of 1. When greater
3292         than 1, runs test set specified number of times. Note that multiple runs are
3293         not aggregated for statistical purposes.
3294
3295         Incidentally fixed typo: s/suceeds/succeeds/.
3296
3297         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3298         (PerfTestsRunner._parse_args): Add repeat option.
3299         (PerfTestsRunner.run): Add outer repeat loop.
3300         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3301         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3302         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3303         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3304         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3305         (MainTest.test_run_with_json_output): Fix typo.
3306         (MainTest.test_run_with_description): Fix typo.
3307         (MainTest.test_run_respects_no_results): Fix typo.
3308         (MainTest.test_run_with_slave_config_json): Fix typo.
3309         (MainTest.test_run_with_multiple_repositories): Fix typo.
3310         (MainTest.test_run_with_upload_json): Fix typo.
3311         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3312         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3313         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3314         (MainTest.test_parse_args): Add test for repeat option parsing.
3315
3316 2013-03-07  Julie Parent  <jparent@chromium.org>
3317
3318         showAllRuns checkbox no longer works on the stats dashboard
3319         https://bugs.webkit.org/show_bug.cgi?id=111673
3320
3321         Reviewed by Ojan Vafai.
3322
3323         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3324         so we were trying to index into an undefined object.
3325         
3326         * TestResultServer/static-dashboards/dashboard_base.js:
3327         (invalidateQueryParameters):
3328
3329 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3330
3331         [Chromium] Update #include for WebStorageNamespace.h
3332         https://bugs.webkit.org/show_bug.cgi?id=111748
3333
3334         Reviewed by Adam Barth.
3335
3336         In anticipation of removing
3337         WK/chromium/public/WebStorageNamespace.h (once downstream
3338         references have been updated)
3339
3340         * DumpRenderTree/chromium/WebViewHost.cpp:
3341
3342 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3343
3344         run-perf-tests fails due to svn_revision not working on a pure git clone
3345         https://bugs.webkit.org/show_bug.cgi?id=110839
3346
3347         Reviewed by Ryosuke Niwa.
3348
3349         Previously we would call git svn find-rev to look up the commit for
3350         a given revision, and that'll hang in a pure git checkout.
3351
3352         This patch changes the way we look up svn revisions in a git
3353         repository to use git log --grep 'git-svn-id', which is much faster
3354         than grepping ourselves. It also renames timestamp_of_latest_commit()
3355         to timestamp_of_revision() in order to accurately reflect what
3356         the method is doing. Note that this patch only changes the logic
3357         inside latest_revision() and svn_revision(). I'll file a separate
3358         bug to change git_commit_from_svn_revision().
3359
3360         This patch also contains some fixes to unit tests that had bit-rotted
3361         or were otherwise fragile, so that test-webkitpy --all would pass
3362         cleanly, and a fix to outputcapture so that
3363         test-webkitpy -p would work correctly again.
3364
3365         * Scripts/webkitpy/common/checkout/scm/git.py:
3366         (Git.svn_revision):
3367         (Git.timestamp_of_revision):
3368         * Scripts/webkitpy/common/checkout/scm/scm.py:
3369         (SCM.svn_revision):
3370         (SCM.timestamp_of_revision):
3371         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3372         (MockSCM.timestamp_of_revision):
3373         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3374         (_shared_test_commit_with_message):
3375         (test_commit_without_authorization):
3376         (test_timestamp_of_revision):
3377         * Scripts/webkitpy/common/checkout/scm/svn.py:
3378         (SVN.timestamp_of_revision):
3379         * Scripts/webkitpy/common/system/outputcapture.py:
3380           Importing unittest2 directly may not be safe if this module is
3381           imported before the autoinstaller gets a chance to set things up
3382           properly. We don't actually need unittest2 here.
3383         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3384         (PerfTestsRunner._generate_results_dict):
3385
3386 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3387
3388         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3389         https://bugs.webkit.org/show_bug.cgi?id=111756
3390
3391         Reviewed by Kenneth Rohde Christiansen.
3392
3393         Bump libsoup to v2.40.3 to fix the regressions introduced by
3394         previous v2.40.0 bump.
3395
3396         * efl/jhbuild.modules:
3397
3398 2013-03-07  Roger Fong  <roger_fong@apple.com>
3399
3400         Re-enable Win EWS tests.
3401
3402         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3403         (WinEWS):
3404
3405 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3406
3407         [nrwt] handle corrupt http server pid files cleanly
3408         https://bugs.webkit.org/show_bug.cgi?id=111628
3409
3410         Reviewed by Eric Seidel.
3411
3412         If the pid file from a previous http server is corrupt for some
3413         reason, NRWT will just raise errors and not clean it up or recover.
3414         This patch fixes that to at least delete the pid file and
3415         not throw; not that we may still have stale http servers left on
3416         the system, since there's no way to know which pid to kill if
3417         the file was corrupted.
3418
3419         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3420         (HttpServerBase.start):
3421         (HttpServerBase.stop):
3422         (HttpServerBase._remove_pid_file):
3423         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3424         (TestHttpServerBase):
3425         (TestHttpServerBase.test_corrupt_pid_file):
3426
3427 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3428
3429         AX: Can't activate links with VoiceOver in Safari
3430         https://bugs.webkit.org/show_bug.cgi?id=111755
3431
3432         Reviewed by Tim Horton.
3433
3434         * DumpRenderTree/AccessibilityUIElement.cpp:
3435         (supportedActionsCallback):
3436         (AccessibilityUIElement::getJSClass):
3437         * DumpRenderTree/AccessibilityUIElement.h:
3438         (AccessibilityUIElement):
3439         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3440         (AccessibilityUIElement::supportedActions):
3441
3442 2013-03-07  Roger Fong  <roger_fong@apple.com>
3443
3444         Windows debug layout tests are crashing like crazy again.
3445         Disable tests on Win EWS bots temporarily.
3446
3447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3448         (WinEWS):
3449
3450 2013-03-07  Roger Fong  <roger_fong@apple.com>
3451
3452         Make EWS bots build and test in release.
3453
3454         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3455         (WinEWS):
3456         * Scripts/webkitpy/tool/steps/runtests.py:
3457         (RunTests.run):
3458
3459 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3460
3461         [chromium] don't track the top loading frame if no layout test is currently running
3462         https://bugs.webkit.org/show_bug.cgi?id=111716
3463
3464         Reviewed by Kentaro Hara.
3465
3466         In DRT, we synchronously stop the test and start loading the next test
3467         URL. However, in content_shell, this happens asynchronously. It's
3468         important that the top loading frame is not changed due to stray
3469         navigation events before the next test starts.
3470
3471         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3472         (WebTestRunner::TestRunner::setTopLoadingFrame):
3473
3474 2013-03-06  Julie Parent  <jparent@chromium.org>
3475
3476         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3477         https://bugs.webkit.org/show_bug.cgi?id=111621
3478
3479         Reviewed by Ojan Vafai.
3480         
3481         Creates ui.js, a package for the common UI code the various
3482         dashboards use. HTML generation is now in the ui.html namespace
3483         and popup handling is in ui.popup.
3484         Also moves the event listening for popups to ui.popup.show and
3485         removes it on ui.popup.hid rather than having listener always
3486         around.
3487
3488         * TestResultServer/static-dashboards/aggregate_results.html:
3489         * TestResultServer/static-dashboards/dashboard_base.js:
3490         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3491         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3492         (showPopupForBuild):
3493         (htmlForNavBar):
3494         (generatePageForIndividualTests.if):
3495         (generatePageForIndividualTests):
3496         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3497         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3498         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3499         * TestResultServer/static-dashboards/run-unittests.html:
3500         * TestResultServer/static-dashboards/timeline_explorer.html:
3501         * TestResultServer/static-dashboards/treemap.html:
3502         * TestResultServer/static-dashboards/ui.js: Added.
3503         (.):
3504
3505 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3506
3507         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3508         https://bugs.webkit.org/show_bug.cgi?id=110584
3509
3510         Reviewed by Gyuyoung Kim.
3511
3512         Adds missing implementation of AccessibilityControllerEfl
3513         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3514         so that it can make accessibilityController as a js object.
3515
3516         * DumpRenderTree/AccessibilityController.h:
3517         (AccessibilityController):
3518         * DumpRenderTree/AccessibilityUIElement.h:
3519         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3520         (AccessibilityController::childElementById): Moved declaration to base class.
3521         Implementation can be shared among other ports.
3522         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3523         (AccessibilityController::focusedElement):
3524         (AccessibilityController::rootElement):
3525         (AccessibilityController::accessibleElementById):
3526         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3527         (AccessibilityUIElement::helpText):
3528         * DumpRenderTree/efl/CMakeLists.txt:
3529         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3530         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3531         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3532         (DumpRenderTreeChrome::onWindowObjectCleared):
3533         (DumpRenderTreeChrome::accessibilityController):
3534         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3535         (DumpRenderTreeChrome):
3536         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3537
3538 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3539
3540         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3541         https://bugs.webkit.org/show_bug.cgi?id=42696
3542
3543         Reviewed by Andreas Kling.
3544
3545         * DumpRenderTree/TestRunner.cpp:
3546         (TestRunner::staticFunctions):
3547         * DumpRenderTree/TestRunner.h:
3548         (TestRunner):
3549         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3550         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3551         (WebTestRunner::TestRunner::TestRunner):
3552         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3553         (TestRunner):
3554         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3555         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3556         * DumpRenderTree/mac/TestRunnerMac.mm:
3557         * DumpRenderTree/qt/TestRunnerQt.cpp:
3558         * DumpRenderTree/qt/TestRunnerQt.h:
3559         (TestRunnerQt):
3560         * DumpRenderTree/win/TestRunnerWin.cpp:
3561         * DumpRenderTree/wx/TestRunnerWx.cpp:
3562
3563 2013-03-06  Roger Fong  <roger_fong@apple.com>
3564
3565         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3566
3567         * EWSTools/start-queue-win.sh:
3568         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3569         (WinEWS):
3570
3571 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3572
3573         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3574         https://bugs.webkit.org/show_bug.cgi?id=82866
3575
3576         Reviewed by Martin Robinson.
3577
3578         * Scripts/run-gtk-tests:
3579         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3580         it is passing now.
3581
3582 2013-03-06  Julie Parent  <jparent@chromium.org>
3583
3584         Dashboard cleanup: remove dashboard time logging.
3585         https://bugs.webkit.org/show_bug.cgi?id=111608
3586
3587         Reviewed by Dirk Pranke.
3588
3589         Remove logTime.  It was never accurate, and the dev tools
3590         have better ways to measure this if anyone cares to look
3591         into dashboard perf.
3592         
3593         * TestResultServer/static-dashboards/dashboard_base.js:
3594         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3595         (processTestRunsForBuilder):
3596         (appendHTML):
3597
3598 2013-03-06  Tony Chang  <tony@chromium.org>
3599
3600         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3601         https://bugs.webkit.org/show_bug.cgi?id=111509
3602
3603         Reviewed by Dirk Pranke.
3604
3605         Add DumpRenderTree.pak to DumpRenderTree.app again.
3606
3607         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3608
3609 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3610
3611         [chromium] introduce WebUserGestureIndicator
3612         https://bugs.webkit.org/show_bug.cgi?id=111531
3613
3614         Reviewed by Adam Barth.
3615
3616         * DumpRenderTree/chromium/WebViewHost.cpp:
3617         (WebViewHost::createView):
3618
3619 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3620
3621         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3622         https://bugs.webkit.org/show_bug.cgi?id=73482
3623
3624         Reviewed by Ryosuke Niwa.
3625
3626         Added input checking to the UpdateChromiumDEPS step.
3627         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3628
3629         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3630         (RollChromiumDEPS):
3631         (RollChromiumDEPS._parse_args):
3632         (RollChromiumDEPS.execute):
3633         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
3634         (IRCCommandTest.test_roll_chromium_deps):
3635         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
3636         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3637         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
3638         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
3639         (UpdateChromiumDEPS._fetch_last_known_good_revision):
3640         (UpdateChromiumDEPS):
3641         (UpdateChromiumDEPS._parse_revision_number):
3642         (UpdateChromiumDEPS._validate_revisions):
3643         (UpdateChromiumDEPS.run):
3644         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
3645         (UpdateChromiumDEPSTest):
3646         (UpdateChromiumDEPSTest.test_parse_revision_number):
3647         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
3648         (RollChromiumDEPS):
3649         (PostChromiumDEPSRoll):
3650
3651 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
3652
3653         [Qt][MiniBrowser] Touch mocking broken for chained getures
3654         https://bugs.webkit.org/show_bug.cgi?id=111430
3655
3656         Reviewed by Jocelyn Turcotte.
3657
3658         Make it possible again to use touch mocking to test gesture chains
3659         like pan->pinch->pan->pinch without lifting the primary "finger".
3660         For this to work we need to track the pressed mouse buttons and
3661         only synthesize touch release events when the ctrl key is released
3662         if no mouse button is pressed. Else the pressed mouse button(s)
3663         should result in a stationary touch point in a touch update event.
3664         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
3665         to check for the state of the ctrl key modifier instead of getting
3666         it from the mouse events.
3667
3668         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3669         (MiniBrowserApplication::MiniBrowserApplication):
3670         (MiniBrowserApplication::notify):
3671
3672 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3673
3674         [chromium] don't use custom freetype on linux asan for now
3675         https://bugs.webkit.org/show_bug.cgi?id=111516
3676
3677         Unreviewed, build fix.
3678
3679         Turns out the custom lib is getting picked up by other binaries
3680         on our bot, which is bad.
3681
3682         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3683
3684 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3685
3686         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3687         https://bugs.webkit.org/show_bug.cgi?id=111509
3688
3689         Unreviewed, build fix.
3690
3691         Actually comment out the flag :(.
3692
3693         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3694
3695 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3696
3697         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3698         https://bugs.webkit.org/show_bug.cgi?id=111509
3699
3700         Unreviewed, build fix.
3701
3702         r144863 appears to have broken the xcode build; I'm temporarily
3703         trying this instead, and if this doesn't work, I'll revert the
3704         other changes.
3705
3706         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3707
3708 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3709
3710         [chromium] build a DumpRenderTree.pak even on windows
3711         https://bugs.webkit.org/show_bug.cgi?id=111504
3712
3713         Reviewed by Tony Chang.
3714
3715         The Chromium Aura build uses the default theme to draw
3716         controls, and that theme requires the ui ResourceBundle
3717         to be initialized. On every other platform, we build
3718         a DumpRenderTree.pak that works for this, but on Windows we
3719         still compile the resources directly into DRT. As a first step,
3720         let's build the pak file. I will then need to land a patch
3721         in Chromium to actually load it. Then I can go back and move
3722         the resources over to just use the .pak file and no longer need
3723         the .rc's.
3724
3725         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3726
3727 2013-03-05  Julie Parent  <jparent@chromium.org>
3728         Dashboard cleanup: move string utilities into their own namespace.
3729         
3730         https://bugs.webkit.org/show_bug.cgi?id=111485
3731
3732         Reviewed by Ojan Vafai.
3733         
3734         One of many pieces to clean up dashboard_base.
3735         
3736         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
3737
3738         * TestResultServer/static-dashboards/aggregate_results.html:
3739         * TestResultServer/static-dashboards/dashboard_base.js:
3740         (isTreeMap):
3741         (isFlakinessDashboard):
3742         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3743         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3744         (determineWKPlatform):
3745         (chromiumPlatform):
3746         (platformAndBuildType):
3747         (substringList):
3748         (individualTestsForSubstringList):
3749         (filterBugs):
3750         (populateExpectationsData):
3751         (processMissingTestsWithExpectations):
3752         (processMissingAndExtraExpectations):
3753         (htmlForSingleTestRow):
3754         (.dummyNode.onload):
3755         (expectationsTitle):
3756         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3757         * TestResultServer/static-dashboards/run-unittests.html:
3758         * TestResultServer/static-dashboards/string.js: Added.
3759         * TestResultServer/static-dashboards/timeline_explorer.html:
3760         * TestResultServer/static-dashboards/treemap.html:
3761
3762 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
3763
3764         [EFL] Build break with latest EFL libraries
3765         https://bugs.webkit.org/show_bug.cgi?id=111028
3766
3767         Reviewed by Dirk Pranke.
3768
3769         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
3770         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
3771         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
3772
3773 2013-03-05  Roger Fong  <roger_fong@apple.com>
3774
3775         Increase number of WinEWS iterations to 20.
3776         Don't reboot after each iteration set.
3777         Make EWS bots just build temporarily so that the queue catches up again.
3778
3779         * EWSTools/start-queue-win.sh:
3780         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3781         (WinEWS):
3782
3783 2013-03-04  James Robinson  <jamesr@chromium.org>
3784
3785         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
3786         https://bugs.webkit.org/show_bug.cgi?id=111386
3787
3788         Reviewed by Adrienne Walker.
3789
3790         * DumpRenderTree/chromium/TestShell.cpp:
3791         (TestShell::initialize):
3792
3793 2013-03-05  Min Qin  <qinmin@chromium.org>
3794
3795         Copy dictionary to the external storage before running layout test on android
3796         https://bugs.webkit.org/show_bug.cgi?id=111480
3797
3798         Reviewed by Adam Barth.
3799
3800         TestWebKitPlatformSupport now needs to read an external dictionary file.
3801         This file does not exist on the device. We need to copy it before running layout tests.
3802
3803         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3804         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3805         (ChromiumAndroidDriver._push_platform_resources):
3806
3807 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3808
3809         [chromium] DRT crashes in an Aura/Win build
3810         https://bugs.webkit.org/show_bug.cgi?id=111394
3811
3812         Reviewed by Tony Chang.
3813
3814         When building (and running) with use_aura=1, we assume that
3815         we're using the default theme engine, but DRT creates the
3816         DRTWin theme engine and overwrites the default, leading to crashes
3817         in basically every test from the mismatch.
3818
3819         This fix gets us down to at least "lots of crashes" :).
3820
3821         * DumpRenderTree/chromium/TestShellWin.cpp:
3822         (platformInit):
3823
3824 2013-03-05  Eric Seidel  <eric@webkit.org>
3825
3826         Add html-parser-threaded perf test now that the threaded parser is enabled by default
3827         https://bugs.webkit.org/show_bug.cgi?id=111200
3828
3829         Reviewed by Ryosuke Niwa.
3830
3831         Had to teach run-perf-tests to ignore one more warning.
3832
3833         * Scripts/webkitpy/performance_tests/perftest.py:
3834         (PerfTest):
3835
3836 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3837
3838         Update list of builders for test results server
3839         https://bugs.webkit.org/show_bug.cgi?id=111166
3840
3841         Reviewed by Ojan Vafai.
3842
3843         * TestResultServer/static-dashboards/builders.jsonp:
3844
3845 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
3846
3847         [GTK] Move basic dependency installation to a script
3848         https://bugs.webkit.org/show_bug.cgi?id=110692
3849
3850         Reviewed by Gustavo Noronha Silva.
3851
3852         * gtk/install-dependencies: Added. A Script which installs all dependencies
3853         necessary for building for Debian-based distributions and Fedora.
3854
3855 2013-03-05  James Robinson  <jamesr@chromium.org>
3856
3857         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
3858         https://bugs.webkit.org/show_bug.cgi?id=111440
3859
3860         Reviewed by Adrienne Walker.
3861
3862         Remove unnecessary WebCompositorSupport::shutdown call
3863
3864         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3865         (main):
3866
3867 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
3868
3869         Unreviewed build fix.
3870
3871         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
3872
3873 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
3874
3875         [Qt][MiniBrowser] Improve the update of touch indicators
3876         https://bugs.webkit.org/show_bug.cgi?id=111429
3877
3878         Reviewed by Jocelyn Turcotte.
3879
3880         MiniBrowserApplication::sendTouchEvent sends an empty list
3881         to BrowserWindow::updateVisualMockTouchPoints if the control
3882         button is released, in which case the touch indicators should
3883         be hidden so that we never end up with a leftover indicator
3884         sticking on the screen.
3885         This patch also simplifies the lookup of the indicator items by
3886         replacing the findChild search in the item tree with a QHash
3887         that stores the touch ID's and the pointers to the corresponding
3888         indicator items.
3889
3890         * MiniBrowser/qt/BrowserWindow.cpp:
3891         (BrowserWindow::updateVisualMockTouchPoints):
3892         * MiniBrowser/qt/BrowserWindow.h:
3893         (BrowserWindow):
3894
3895 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3896
3897         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
3898         https://bugs.webkit.org/show_bug.cgi?id=81042
3899
3900         Reviewed by Enrica Casucci.
3901
3902         Add setAsynchronousSpellCheckingEnabled implementation for
3903         WebKitTestRunner to have the possibility to test asynchronous
3904         spell checking implementation from bug 109577.
3905
3906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3908         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
3909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3910         * WebKitTestRunner/TestController.cpp:
3911         (WTR::TestController::resetStateToConsistentValues):
3912
3913 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
3914
3915         MediaStream API: Add the getStreamById method on RTCPeerConnection
3916         https://bugs.webkit.org/show_bug.cgi?id=111311
3917
3918         Reviewed by Adam Barth.
3919
3920         Changing mocks to be more realistic.
3921
3922         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3923         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
3924         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
3925         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3926         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3927
3928 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3929
3930         Add content shell bots to garden-o-matic for general failurse
3931         https://bugs.webkit.org/show_bug.cgi?id=111168
3932
3933         Reviewed by Adam Barth.
3934
3935         All but the WebKit (Content Shell) Android bot is stable enough. While
3936         they're not green yet, there must not be any non-layout test failures on
3937         them.
3938
3939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3940         (.):
3941
3942 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3943
3944         [chromium] remove deprecated WebTestRunner::setFocus API
3945         https://bugs.webkit.org/show_bug.cgi?id=111354
3946
3947         Reviewed by James Robinson.
3948
3949         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3950         (WebTestDelegate):
3951
3952 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3953
3954         Run the bindings generation tests on EWS and CQ bots
3955         https://bugs.webkit.org/show_bug.cgi?id=111358
3956
3957         Reviewed by Adam Barth.
3958
3959         The tests are super fast and not flaky.
3960
3961         * Scripts/webkitpy/common/config/ports.py:
3962         (DeprecatedPort.run_bindings_tests_command):
3963         * Scripts/webkitpy/common/config/ports_mock.py:
3964         (MockPort.run_webkit_tests_command):
3965         (MockPort):
3966         (MockPort.run_bindings_tests_command):
3967         * Scripts/webkitpy/tool/commands/download_unittest.py:
3968         * Scripts/webkitpy/tool/steps/runtests.py:
3969         (RunTests.run):
3970         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3971         (RunTestsTest.test_webkit_run_unit_tests):
3972         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3973
3974 2013-03-04  Eric Seidel  <eric@webkit.org>
3975
3976         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
3977         https://bugs.webkit.org/show_bug.cgi?id=111384
3978
3979         Reviewed by Ryosuke Niwa.
3980
3981         Sometimes I want to know why various LayoutTests are slow
3982         without having to convert them into PerformanceTests in order
3983         to use our fancy profiling.  The Driver already knows how to
3984         do the right thing, we just need to expose the options to the user.
3985
3986         Handling of these options is already unittested in the perftests_unittest.
3987
3988         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3989         (parse_args):
3990
3991 2013-03-04  Alan Cutter  <alancutter@chromium.org>
3992
3993         check-webkit-style says "Have to enable auto props in the subversion config file"
3994         https://bugs.webkit.org/show_bug.cgi?id=107724
3995
3996         Reviewed by Tony Chang.
3997
3998         Added a standard svn config file for WebKit developers to use.
3999         Updated the style and commit queue bot build scripts to load this file.
4000
4001         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
4002         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4003         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
4004         * svn-config: Added.
4005
4006 2013-03-04  James Robinson  <jamesr@chromium.org>
4007
4008         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
4009         https://bugs.webkit.org/show_bug.cgi?id=111285
4010
4011         Reviewed by Adrienne Walker.
4012
4013         This removes the need for WebCompositorSupport::initialize and exposes
4014         slightly fewer entry points across the repository boundary.
4015
4016         * DumpRenderTree/chromium/TestShell.cpp:
4017         (TestShell::initialize):
4018         * DumpRenderTree/chromium/TestShell.h:
4019         (TestShell::webCompositorThread):
4020         (TestShell):
4021         * DumpRenderTree/chromium/WebViewHost.cpp:
4022         (WebViewHost::initializeLayerTreeView):
4023
4024 2013-03-04  Roger Fong  <roger_fong@apple.com>
4025
4026         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
4027
4028         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
4029
4030 2013-03-04  David Kilzer  <ddkilzer@apple.com>
4031
4032         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
4033
4034             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
4035                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
4036                                         ^         ~~~~~~~~~~~~~~~~~~~~~
4037             1 error generated.
4038
4039         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
4040         AccessibilityCommonMac.h.
4041
4042 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4043
4044         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
4045         https://bugs.webkit.org/show_bug.cgi?id=109828
4046
4047         Reviewed by Kenneth Rohde Christiansen.
4048
4049         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
4050         callbacks.
4051
4052         * TestWebKitAPI/CMakeLists.txt:
4053
4054             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
4055             considered.
4056
4057         * TestWebKitAPI/PlatformEfl.cmake:
4058         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
4059         (TestWebKitAPI):
4060         (TestWebKitAPI::didFinishLoadForFrame):
4061         (TestWebKitAPI::setPageLoaderClient):
4062         (TestWebKitAPI::webProcessCrashed):
4063         (TestWebKitAPI::webProcessDidRelaunch):
4064         (TestWebKitAPI::setViewClient):
4065         (TestWebKitAPI::TEST):
4066
4067 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
4068
4069         AX: Upstream iOS Accessibility DumpRenderTree changes
4070         https://bugs.webkit.org/show_bug.cgi?id=111220
4071
4072         Reviewed by David Kilzer.
4073
4074         Upstream the iOS changes for accessibility in DumpRenderTree.
4075
4076         * DumpRenderTree/AccessibilityUIElement.cpp:
4077         (headerElementAtIndexCallback):
4078         (linkedElementCallback):
4079         (elementsForRangeCallback):
4080         (increaseTextSelectionCallback):
4081         (decreaseTextSelectionCallback):
4082         (assistiveTechnologySimulatedFocusCallback):
4083         (stringForSelectionCallback):
4084         (getIPhoneLabelCallback):
4085         (getIPhoneHintCallback):
4086         (getIPhoneValueCallback):
4087         (getIPhoneIdentifierCallback):
4088         (getIPhoneTraitsCallback):
4089         (getIPhoneIsElementCallback):
4090         (getIPhoneElementTextPositionCallback):
4091         (getIPhoneElementTextLengthCallback):
4092         (AccessibilityUIElement::getJSClass):
4093         * DumpRenderTree/AccessibilityUIElement.h:
4094         (AccessibilityUIElement):
4095         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4096         * DumpRenderTree/ios: Added.
4097         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
4098         (AccessibilityController::AccessibilityController):
4099         (AccessibilityController::~AccessibilityController):
4100         (AccessibilityController::elementAtPoint):
4101         (AccessibilityController::focusedElement):
4102         (AccessibilityController::rootElement):
4103         (findAccessibleObjectById):
4104         (AccessibilityController::accessibleElementById):
4105         (AccessibilityController::setLogFocusEvents):
4106         (AccessibilityController::setLogScrollingStartEvents):
4107         (AccessibilityController::setLogValueChangeEvents):
4108         (AccessibilityController::setLogAccessibilityEvents):
4109         (AccessibilityController::addNotificationListener):
4110         (AccessibilityController::removeNotificationListener):
4111         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
4112         (AccessibilityUIElement::AccessibilityUIElement):
4113         (AccessibilityUIElement::~AccessibilityUIElement):
4114         (concatenateAttributeAndValue):
4115         (AccessibilityUIElement::iphoneLabel):
4116         (AccessibilityUIElement::iphoneHint):
4117         (AccessibilityUIElement::iphoneValue):
4118         (AccessibilityUIElement::iphoneIdentifier):
4119         (AccessibilityUIElement::iphoneTraits):
4120         (AccessibilityUIElement::iphoneIsElement):
4121         (AccessibilityUIElement::iphoneElementTextPosition):
4122         (AccessibilityUIElement::iphoneElementTextLength):
4123         (AccessibilityUIElement::url):
4124         (AccessibilityUIElement::x):
4125         (AccessibilityUIElement::y):
4126         (AccessibilityUIElement::width):
4127         (AccessibilityUIElement::height):
4128         (AccessibilityUIElement::clickPointX):
4129         (AccessibilityUIElement::clickPointY):
4130         (AccessibilityUIElement::getChildren):
4131         (AccessibilityUIElement::getChildrenWithRange):
4132         (AccessibilityUIElement::childrenCount):
4133         (AccessibilityUIElement::elementAtPoint):
4134         (AccessibilityUIElement::indexOfChild):
4135         (AccessibilityUIElement::getChildAtIndex):
4136         (AccessibilityUIElement::headerElementAtIndex):
4137         (AccessibilityUIElement::linkedElement):
4138         (AccessibilityUIElement::linkedUIElementAtIndex):
4139         (AccessibilityUIElement::ariaOwnsElementAtIndex):
4140         (AccessibilityUIElement::ariaFlowToElementAtIndex):
4141         (AccessibilityUIElement::disclosedRowAtIndex):
4142         (AccessibilityUIElement::selectedRowAtIndex):
4143         (AccessibilityUIElement::rowAtIndex):
4144         (AccessibilityUIElement::titleUIElement):
4145         (AccessibilityUIElement::parentElement):
4146         (AccessibilityUIElement::disclosedByRow):
4147         (AccessibilityUIElement::increaseTextSelection):
4148         (AccessibilityUIElement::decreaseTextSelection):
4149         (AccessibilityUIElement::stringForSelection):
4150         (AccessibilityUIElement::stringForRange):
4151         (AccessibilityUIElement::attributedStringForRange):
4152         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
4153         (AccessibilityUIElement::elementsForRange):
4154         (AccessibilityUIElement::getLinkedUIElements):
4155         (AccessibilityUIElement::getDocumentLinks):
4156         (AccessibilityUIElement::attributesOfLinkedUIElements):
4157         (AccessibilityUIElement::attributesOfDocumentLinks):
4158         (AccessibilityUIElement::attributesOfChildren):
4159         (AccessibilityUIElement::allAttributes):
4160         (AccessibilityUIElement::stringAttributeValue):
4161         (AccessibilityUIElement::isPressActionSupported):
4162         (AccessibilityUIElement::isIncrementActionSupported):
4163         (AccessibilityUIElement::isDecrementActionSupported):
4164         (AccessibilityUIElement::boolAttributeValue):
4165         (AccessibilityUIElement::isAttributeSettable):
4166         (AccessibilityUIElement::isAttributeSupported):
4167         (AccessibilityUIElement::parameterizedAttributeNames):
4168         (AccessibilityUIElement::role):
4169         (AccessibilityUIElement::subrole):
4170         (AccessibilityUIElement::roleDescription):
4171         (AccessibilityUIElement::title):
4172         (AccessibilityUIElement::description):
4173         (AccessibilityUIElement::orientation):
4174         (AccessibilityUIElement::stringValue):
4175         (AccessibilityUIElement::language):
4176         (AccessibilityUIElement::helpText):
4177         (AccessibilityUIElement::intValue):
4178         (AccessibilityUIElement::minValue):
4179         (AccessibilityUIElement::maxValue):
4180         (AccessibilityUIElement::valueDescription):
4181         (AccessibilityUIElement::insertionPointLineNumber):
4182         (AccessibilityUIElement::isEnabled):
4183         (AccessibilityUIElement::isRequired):
4184         (AccessibilityUIElement::isFocused):
4185         (AccessibilityUIElement::isSelected):
4186         (AccessibilityUIElement::isExpanded):
4187         (AccessibilityUIElement::isChecked):
4188         (AccessibilityUIElement::hierarchicalLevel):
4189         (AccessibilityUIElement::ariaIsGrabbed):
4190         (AccessibilityUIElement::ariaDropEffects):
4191         (AccessibilityUIElement::lineForIndex):
4192         (AccessibilityUIElement::boundsForRange):
4193         (AccessibilityUIElement::attributesOfColumnHeaders):
4194         (AccessibilityUIElement::attributesOfRowHeaders):
4195         (AccessibilityUIElement::attributesOfColumns):
4196         (AccessibilityUIElement::attributesOfRows):
4197         (AccessibilityUIElement::attributesOfVisibleCells):
4198         (AccessibilityUIElement::attributesOfHeader):
4199         (AccessibilityUIElement::rowCount):
4200         (AccessibilityUIElement::columnCount):
4201         (AccessibilityUIElement::indexInTable):
4202         (AccessibilityUIElement::rowIndexRange):
4203         (AccessibilityUIElement::columnIndexRange):
4204         (AccessibilityUIElement::cellForColumnAndRow):
4205         (AccessibilityUIElement::selectedTextRange):
4206         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
4207         (AccessibilityUIElement::setSelectedTextRange):
4208         (AccessibilityUIElement::increment):
4209         (AccessibilityUIElement::decrement):
4210         (AccessibilityUIElement::showMenu):
4211         (AccessibilityUIElement::press):
4212         (AccessibilityUIElement::accessibilityValue):
4213         (AccessibilityUIElement::documentEncoding):
4214         (AccessibilityUIElement::documentURI):
4215         (_accessibilityNotificationCallback):
4216         (AccessibilityUIElement::addNotificationListener):
4217         (AccessibilityUIElement::removeNotificationListener):
4218         (AccessibilityUIElement::isFocusable):
4219         (AccessibilityUIElement::isSelectable):
4220         (AccessibilityUIElement::isMultiSelectable):
4221         (AccessibilityUIElement::isSelectedOptionActive):
4222         (AccessibilityUIElement::isVisible):
4223         (AccessibilityUIElement::isOffScreen):
4224         (AccessibilityUIElement::isCollapsed):
4225         (AccessibilityUIElement::isIgnored):
4226         (AccessibilityUIElement::hasPopup):
4227         (AccessibilityUIElement::takeFocus):
4228         (AccessibilityUIElement::takeSelection):
4229         (AccessibilityUIElement::addSelection):
4230         (AccessibilityUIElement::removeSelection):
4231         (AccessibilityUIElement::uiElementForSearchPredicate):
4232         (AccessibilityUIElement::numberAttributeValue):
4233
4234 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4235
4236         [chromium] pass all focus handling methods through the WebTestDelegate
4237         https://bugs.webkit.org/show_bug.cgi?id=111328
4238
4239         Reviewed by Nico Weber.
4240
4241         In content_shell, the focus handling is asynchronous. To allow for
4242         switching the focus synchronously between WebViews, we need to intercept
4243         didFocus and didBlur and forward it to the WebTestDelegate.
4244
4245         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4246         (WebTestDelegate):
4247         (WebTestRunner::WebTestDelegate::setFocus):
4248         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4249         (WebTestRunner::WebTestProxy::didFocus):
4250         (WebTestRunner::WebTestProxy::didBlur):
4251         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4252         (WebTestRunner::TestRunner::setWindowIsKey):
4253         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4254         (WebTestRunner::WebTestProxyBase::didFocus):
4255         (WebTestRunner):
4256         (WebTestRunner::WebTestProxyBase::didBlur):
4257         * DumpRenderTree/chromium/WebViewHost.cpp:
4258         (WebViewHost::didFocus):
4259         (WebViewHost::didBlur):
4260         (WebViewHost::setFocus):
4261         * DumpRenderTree/chromium/WebViewHost.h:
4262         (WebViewHost):
4263
4264 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
4265
4266         [GTK] No need to manually add system paths to jhbuildrc
4267         https://bugs.webkit.org/show_bug.cgi?id=110850
4268
4269         Reviewed by Gustavo Noronha Silva.
4270
4271         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
4272         already takes care of.
4273
4274 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
4275
4276         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
4277         https://bugs.webkit.org/show_bug.cgi?id=111284
4278
4279         Disabling the failing two tests on Android.
4280
4281         Reviewed by Jochen Eisinger.
4282
4283         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4284         (TestWebKitAPI):
4285         (TestWebKitAPI::TEST):
4286
4287 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4288
4289         Add build flag for FontLoader
4290         https://bugs.webkit.org/show_bug.cgi?id=111289
4291
4292         Reviewed by Benjamin Poulain.
4293
4294         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
4295
4296         * Scripts/webkitperl/FeatureList.pm:
4297         * qmake/mkspecs/features/features.pri:
4298
4299 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
4300
4301         [Mac] Get rid of a useless method from DOMHTMLInputElement
4302         https://bugs.webkit.org/show_bug.cgi?id=111279