1 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
3 NRWT: Add the ability to upload test results to new test results server
4 https://bugs.webkit.org/show_bug.cgi?id=120146
6 Reviewed by Andreas Kling.
8 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
9 that contains the full summary of the test run including information about passed tests.
11 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
16 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
17 so we should be able to delete --test-results-server in time.
19 * Scripts/webkitpy/layout_tests/controllers/manager.py:
21 (Manager._upload_json_files):
23 (Manager.upload_results):
24 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
26 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
28 (SummarizedResultsTest.test_summarized_results_wontfix):
29 (SummarizedResultsTest):
30 (SummarizedResultsTest.test_summarized_results_include_passes):
31 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
34 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
36 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
38 * Scripts/webkitpy/tool/bot/irc_command.py:
41 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
43 [Qt] DRT bug revealed/caused by r154300
44 https://bugs.webkit.org/show_bug.cgi?id=120151
46 Reviewed by Simon Hausmann.
48 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
49 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
52 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
53 between native Qt methods and JSC bound methods. This patch changes the check to see if the
54 property is writable since the Qt methods are ReadOnly.
56 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
57 (DumpRenderTree::initJSObjects):
59 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
61 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
63 Reviewed by Benjamin Poulain.
65 WTFString moved the is8bit bit by one in r152201.
67 * lldb/lldb_webkit.py:
68 (WTFStringImplProvider.is_8bit):
70 2013-08-21 Tim Horton <timothy_horton@apple.com>
72 Revert http://trac.webkit.org/changeset/154022, as it failed to update
73 a variety of scripts that depended on the old format.
75 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
77 * Scripts/prepare-ChangeLog:
79 (generateNewChangeLogs):
81 2013-08-21 Brent Fulgham <bfulgham@apple.com>
83 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
85 * WinLauncher/WinLauncher.cpp:
86 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
88 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
90 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
92 Reviewed by Andreas Kling.
94 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
95 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
96 (WTR::activateFonts): Ditto.
98 2013-08-21 Brian Holt <brian.holt@samsung.com>
100 [GTK] Suppress irrelevant or known leaks for Valgrind
101 https://bugs.webkit.org/show_bug.cgi?id=119448
103 Reviewed by Martin Robinson.
105 Add a suppressions file to suppress known leaks for Valgrind.
106 Valgrind also takes longer when using suppressions and
107 times out unless the driver timeout is increased.
109 * Scripts/valgrind/suppressions.txt: Added.
110 * Scripts/webkitpy/port/gtk.py:
111 (GtkPort.driver_stop_timeout):
112 (GtkPort.setup_environ_for_server):
114 2013-08-20 Alex Christensen <achristensen@apple.com>
116 [Windows] Linking fix for Win64.
118 Rubberstamped by Brent Fulgham.
120 * win/DLLLauncher/DLLLauncherMain.cpp:
121 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
123 2013-08-20 Brent Fulgham <bfulgham@apple.com>
125 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
127 Reviewed by Tim Horton.
129 * win/DLLLauncher/DLLLauncherMain.cpp:
130 (getLastErrorString): New method to convert GetLastError to text.
131 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
133 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
135 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
137 Reviewed by Martin Robinson.
139 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
140 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
142 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
144 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
146 Reviewed by Martin Robinson.
148 Added stop button in MiniBrowser
150 * MiniBrowser/gtk/BrowserWindow.c:
151 (reloadOrStopCallback): Callback to handle stop or reload button click.
152 (webViewLoadProgressChanged): Update reload or stop button icon.
153 (browser_window_init): Save button pointer for further icon updates.
155 2013-08-20 Simon Pena <simon.pena@samsung.com>
157 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
159 Reviewed by Alexey Proskuryakov.
161 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
162 printing didFailLoadWithError.
164 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
165 DumpRenderTree, printing didFailLoadWithError.
167 * DumpRenderTree/gtk/DumpRenderTree.cpp:
168 (webFrameLoadStatusNotified):
170 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
172 <https://webkit.org/b/120049> Delete code for Snow Leopard
174 Reviewed by Benjamin Poulain.
176 * DumpRenderTree/mac/CheckedMalloc.cpp:
177 (protectionOfRegion):
178 (makeLargeMallocFailSilently):
179 * DumpRenderTree/mac/DumpRenderTree.mm:
180 (resetDefaultsToConsistentValues):
181 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
182 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
183 * DumpRenderTree/mac/FrameLoadDelegate.mm:
185 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
186 * DumpRenderTree/mac/LayoutTestHelper.m:
187 * DumpRenderTree/mac/TestRunnerMac.mm:
188 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
189 (WTR::InjectedBundle::platformInitialize):
190 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
191 (WTR::testPathFromURL):
192 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
194 2013-08-19 Alexey Proskuryakov <ap@apple.com>
196 https://bugs.webkit.org/show_bug.cgi?id=119915
197 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
199 Reviewed by Darin Adler.
201 The issue was that we ended up having no CFNetwork cache in the testing session due
202 to an incorrect cache model. There is a number of things not implemented when it
203 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
204 the easiest way to get this going is to initialize it to correct value upfront.
206 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
208 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
210 REGRESSION(r154275): webkitpy tests failing
211 https://bugs.webkit.org/show_bug.cgi?id=120010
213 Reviewed by Jocelyn Turcotte.
215 Update unit-tests to tests the new search-path structure,
216 but reverting the architecture search path addition.
218 * Scripts/webkitpy/port/qt.py:
221 (QtPort._generate_all_test_configurations):
222 (QtPort.qt_architecture):
223 * Scripts/webkitpy/port/qt_unittest.py:
225 (QtPortTest._assert_search_path):
226 (QtPortTest._assert_expectations_files):
227 (QtPortTest._qt_version):
229 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
231 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
233 Unreviewed meta gardening.
235 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
237 * Scripts/webkitpy/port/qt.py:
238 (QtPort._search_paths):
240 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
242 Restructure Qt test expectations
244 Unreviewed meta gardening.
246 Removed 5.0 name from WK1 and WK2 results and made it possible to set
247 expectations by both Qt version and mayor architectures.
249 * Scripts/webkitpy/port/qt.py:
250 (QtPort._wk2_port_name):
253 (QtPort.architecture):
254 (QtPort._search_paths):
255 (QtPort._port_specific_expectations_files):
257 2013-08-16 Brent Fulgham <bfulgham@apple.com>
259 [Windows] DRT is not using the same preferences as the Mac build.
260 https://bugs.webkit.org/show_bug.cgi?id=119822
262 Reviewed by Darin Adler.
264 * DumpRenderTree/win/DumpRenderTree.cpp:
265 (runTest): Process Windows message queue using CFRunLoop to allow
266 dispatch routines to run properly.
267 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
268 to prevent problems on WinCairo port.
270 2013-08-16 Brent Fulgham <bfulgham@apple.com>
272 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
273 https://bugs.webkit.org/show_bug.cgi?id=119583
275 Reviewed by Alexey Proskuryakov.
277 * DumpRenderTree/win/DumpRenderTree.cpp:
278 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
279 component if the URL does not contain the expected base URL.
281 2013-08-16 Pratik Solanki <psolanki@apple.com>
283 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
285 Reviewed by Andreas Kling.
287 m_script is never NULL so we can just return a reference. Also remove some pointless null
288 checks as a result of doing this.
290 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
291 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
293 2013-08-15 Alexey Proskuryakov <ap@apple.com>
295 [WK2] NetworkProcess should use a temporary storage session for test
296 https://bugs.webkit.org/show_bug.cgi?id=119855
298 Reviewed by Darin Adler.
300 Use a new API that takes care of both WebProcess and NetworkProcess.
302 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
303 (WTR::InjectedBundle::initialize):
304 * WebKitTestRunner/TestController.cpp:
305 (WTR::TestController::initialize):
307 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
309 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
311 Reviewed by Dirk Pranke.
313 This is a port from Blink of
314 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
315 originally by Dirk Pranke.
317 From the original commit:
319 This gives something like a 15x speedup over compiling and matching
320 one property at a time and doing multiple passes over the file.
322 * Scripts/webkitpy/w3c/test_converter.py:
323 (W3CTestConverter.__init__):
324 (W3CTestConverter.convert_prefixed_properties):
325 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
327 2013-08-15 Dan Bernstein <mitz@apple.com>
329 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
331 Reviewed by Darin Adler.
333 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
334 added a message that points to the source code. Removed some unnecessary repetition of what
335 is already in the file.
337 2013-08-15 Andy Estes <aestes@apple.com>
339 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
341 Reviewed by Brady Eidson.
343 Wrote an API test that verifies -[WebView stopLoading:] can be called
344 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
346 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
348 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
349 (TestWebKitAPI::TEST):
351 2013-08-15 Alexey Proskuryakov <ap@apple.com>
353 Adding Myles Maxfield to contributors.json.
355 Oops, wrong section, fixing.
357 * Scripts/webkitpy/common/config/contributors.json:
359 2013-08-15 Alexey Proskuryakov <ap@apple.com>
361 Adding Myles Maxfield to contributors.json.
363 * Scripts/webkitpy/common/config/contributors.json:
365 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
367 [Qt] Do not check specifically for version 5.0
368 https://bugs.webkit.org/show_bug.cgi?id=119846
370 Reviewed by Jocelyn Turcotte.
372 For Qt 5.x we should always use both wk1 and wk2 basepath results.
374 * Scripts/webkitpy/port/qt.py:
375 (QtPort._search_paths):
377 2013-08-15 Simon Pena <simon.pena@samsung.com>
379 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
381 Reviewed by Gustavo Noronha Silva.
383 Following a similar approach as in r153977, return a path string
384 that is relative to main frame URL or just file name if the
385 resource is not in the same directory subtree, and replace empty
386 strings with "(null)".
388 Update pathFromSoupURI so it behaves more closely to the other
389 ports, and remove the unused code after we no longer print
390 <unknown> in certain cases. Also move
391 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
392 be used both in TestRunnerGtk and in DumpRenderTree.
394 * DumpRenderTree/gtk/DumpRenderTree.cpp:
395 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
396 we can print Soup URIs with the password, since soup_uri_to_string
397 doesn't preserve them.
398 (pathFromSoupURI): Updated following EFL implementation in
399 r153977, and return a WTFString instead of a CString.
400 (convertSoupMessageToURLPath): Return "(null)" instead of empty
401 strings, and handle the new return type of pathFromSoupURI.
402 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
403 reference, and handle the new return type of pathFromSoupURI.
404 (descriptionSuitableForTestResult): Remove unused code.
405 (didFinishLoading): Use convertResourceToURLPath.
406 (didFailLoadingWithError): Use convertResourceToURLPath.
407 (authenticationCallback): Display the URL of the authentication
409 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
410 soupURIToStringPreservingPassword.
411 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
412 soupURIToStringPreservingPassword.
414 2013-08-14 Tim Horton <timothy_horton@apple.com>
416 Un-inline dataLog dumpers for IntSize and IntPoint
417 https://bugs.webkit.org/show_bug.cgi?id=119697
419 Reviewed by Sam Weinig.
421 * TestWebKitAPI/GNUmakefile.am:
423 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
425 Flakiness dashboard build fix.
427 * TestResultServer/static-dashboards/flakiness_dashboard.js:
428 (processTestRunsForBuilder):
430 2013-08-14 Martin Robinson <mrobinson@igalia.com>
432 [GTK] [CMake] Add support for building TestWebKitAPI
433 https://bugs.webkit.org/show_bug.cgi?id=116987
435 Reviewed by Philippe Normand.
437 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
438 platform-specific file, so that GTK+ can override them.
439 * TestWebKitAPI/PlatformGTK.cmake: Added.
441 2013-08-14 Brent Fulgham <bfulgham@apple.com>
443 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
444 https://bugs.webkit.org/show_bug.cgi?id=119775
446 This bug updates the WinLauncher program with a few useful menu
447 options to toggle certain debugging and development features of
450 Reviewed by Tim Horton.
452 * WinLauncher/WinLauncher.cpp:
453 (dllLauncherEntryPoint): Clean up preference objects on exit.
454 (ToggleMenuItem): New function.
455 (LaunchInspector): New function.
456 (WndProc): Add handler for new menu items. Also properly terminate
457 CFRunLoop operation on program exit.
458 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
460 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
461 resource folder to search path.
462 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
465 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
467 Add a hyperlink from build.webkit.org to the flakiness dashboard.
469 Rubbers-tamped by Simon Fraser.
471 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
473 2013-08-14 Benjamin Dupont <bdupont@nds.com>
475 [Qt] Activate visibility API layout tests
476 https://bugs.webkit.org/show_bug.cgi?id=119790
478 Reviewed by Allan Sandfeld Jensen.
480 * DumpRenderTree/qt/TestRunnerQt.cpp:
481 (TestRunner::resetPageVisibility):
482 (TestRunner::setPageVisibility):
484 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
486 [GTK] WK does not link properly against libxslt
487 https://bugs.webkit.org/show_bug.cgi?id=119688
489 Reviewed by Gustavo Noronha Silva.
491 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
493 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
495 2013-08-13 Alexey Proskuryakov <ap@apple.com>
497 [Mac] fast/dom/attr-style-too-lazy.html is flaky
498 https://bugs.webkit.org/show_bug.cgi?id=119763
500 Reviewed by Darin Adler.
502 * DumpRenderTree/mac/UIDelegate.mm:
503 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
504 a test, it would just semi-randomly leak to the next one.
505 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
508 2013-08-13 Tim Horton <timothy_horton@apple.com>
510 [mac] Give MiniBrowser a reasonable bundle identifier
511 https://bugs.webkit.org/show_bug.cgi?id=119773
513 Rubber-stamped by Simon Fraser.
515 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
517 * MiniBrowser/mac/Info.plist:
518 * MiniBrowser/mac/WebBundle/Info.plist:
520 2013-08-13 Dean Jackson <dino@apple.com>
522 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
524 Reviewed by Mark Rowe.
526 Have prepare-ChangeLog produce webkit.org/b/id style
527 URLs rather than exposing the inner workings of our
528 cgi. I was going to use the term "Future Proofing"
529 but that seems excessive :)
531 * Scripts/prepare-ChangeLog:
532 (main): Generate a more human readable form.
533 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
535 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
537 [EFL][DRT] Simplify call to reverseFind()
538 https://bugs.webkit.org/show_bug.cgi?id=119746
540 Reviewed by Christophe Dumez.
542 Follow-up to r153977.
544 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
545 (pathSuitableForTestResult): Instead of defining a static variable
546 that's only used in a single place, pass '/' to reverseFind() directly.
548 2013-08-13 Alberto Garcia <berto@igalia.com>
550 [GTK] Closing inspector window crashes wk
551 https://bugs.webkit.org/show_bug.cgi?id=110865
553 Reviewed by Carlos Garcia Campos.
555 Disconnect all signal handlers if the inspector window is
558 * GtkLauncher/LauncherInspectorWindow.c:
559 (inspectorWindowDestroyed):
560 (launcherInspectorWindowNew):
562 2013-08-12 Dan Bernstein <mitz@apple.com>
564 extract-localizable-strings output is not suited for parsing by Xcode
565 https://bugs.webkit.org/show_bug.cgi?id=119728
567 Reviewed by Darin Adler.
569 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
570 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
571 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
574 * Scripts/extract-localizable-strings:
576 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
578 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
579 https://bugs.webkit.org/show_bug.cgi?id=119585
581 Reviewed by Gyuyoung Kim.
583 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
584 (pathSuitableForTestResult):
585 Return path string that's relative to main frame URL, or just file name if
586 the resource is not in the same directory subtree.
587 Referenced WebKitTestRunner code in r153852.
588 (descriptionSuitableForTestResult):
589 (DumpRenderTreeChrome::onFrameRedirectRequested):
590 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
592 2013-08-12 Dan Bernstein <mitz@apple.com>
594 extract-localizable-strings doesn't know how to verify an existing strings file
595 https://bugs.webkit.org/show_bug.cgi?id=119704
597 Reviewed by Darin Adler.
599 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
600 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
601 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
602 the way directories to skip are specified from prefixing the directory with a “-” to
603 specifying it with --skip.
604 Finally, added a --verify option. When specified, the strings file is not written to, but
605 instead read in and checked for consistency with the comments, keys and values derived from
606 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
607 mismatching comments are reported as errors.
608 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
609 directories to skip and no exceptions file.
611 2013-08-12 Alexey Proskuryakov <ap@apple.com>
613 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
614 https://bugs.webkit.org/show_bug.cgi?id=85522
616 Reviewed by Andy Estes.
618 * DumpRenderTree/mac/UIDelegate.mm:
619 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
620 when already done with a test. We already had this check in all UI delegate functions,
621 except for -webView:addMessageToConsole:withSource: somehow.
623 2013-08-12 Alexey Proskuryakov <ap@apple.com>
625 https://bugs.webkit.org/show_bug.cgi?id=119693
626 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
627 because of connect-src-websocket-allowed.html
629 Reviewed by Darin Adler.
631 Starting a load of about:blank and immediately stopping it cancels outstanding
632 resource loads, but the page has to transition to committed state to have timers
633 or WebSockets stopped too.
635 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
636 ensure that transition to committed state happens before we start the next test.
638 2013-08-12 Beth Dakin <bdakin@apple.com>
640 The LayoutMilestones didLayout callback should only fire for the main frame
641 https://bugs.webkit.org/show_bug.cgi?id=119457
643 Reviewed by Sam Weinig.
645 Now that the didLayout callback only fires for the main frame, we want to make
646 sure it will fire even when all of the content is in a subframe.
648 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
650 (TestWebKitAPI::didLayout):
651 (TestWebKitAPI::TEST):
652 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
654 2013-08-12 Beth Dakin <bdakin@apple.com>
656 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
657 https://bugs.webkit.org/show_bug.cgi?id=119658
659 Reviewed by Darin Adler.
661 * MiniBrowser/mac/WK2BrowserWindowController.m:
662 (-[WK2BrowserWindowController awakeFromNib]):
663 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664 (WTR::InjectedBundlePage::InjectedBundlePage):
665 * WebKitTestRunner/TestController.cpp:
666 (WTR::TestController::createWebViewWithOptions):
668 2013-08-12 Seokju Kwon <seokju@webkit.org>
670 Remove glu's libtest rule from checker.py
671 https://bugs.webkit.org/show_bug.cgi?id=119674
673 Reviewed by Darin Adler.
675 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
677 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
679 Unreviewed. Change my primary mail address.
681 * Scripts/webkitpy/common/config/contributors.json:
683 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
685 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
686 https://bugs.webkit.org/show_bug.cgi?id=115751
688 Reviewed by Martin Robinson.
690 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
693 2013-08-09 Beth Dakin <bdakin@apple.com>
695 AX: Not able to use arrow keys to read text in a WK2 app
696 https://bugs.webkit.org/show_bug.cgi?id=119605
698 <rdar://problem/14281275>
700 Reviewed by Darin Adler.
702 New test verifies that didNotHandleKeyEvent will be called when there is nothing
704 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
705 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
706 (TestWebKitAPI::didFinishLoadForFrame):
707 (TestWebKitAPI::didNotHandleKeyEventCallback):
708 (TestWebKitAPI::TEST):
710 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
712 Add support for KeyboardEvent.location attribute
713 https://bugs.webkit.org/show_bug.cgi?id=119326
715 Reviewed by Benjamin Poulain.
717 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
719 * DumpRenderTree/mac/EventSendingController.mm:
720 (-[EventSendingController keyDown:withModifiers:withLocation:]):
721 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
722 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
723 (-[EventSendingController handleEvent:]):
724 (-[EventSendingController fireKeyboardEventsToElement:]):
726 2013-08-09 Alexey Proskuryakov <ap@apple.com>
728 <unknown> is often dumped instead of path in test output
729 https://bugs.webkit.org/show_bug.cgi?id=119590
731 Reviewed by Anders Carlsson.
733 There were two reasons for <unknown>:
734 1. When delegate logging is enabled via a testRunner call, that obviously happens
735 after main resource load starts, so we don't record its URL.
736 2. Authentication delegate logging relied on URL recording, but it's only turned on
737 when enabling resource loading delegate logging, not auth one.
739 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
740 landed without posted rationale and unreviewed. Just undoing that change now.
742 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
743 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
744 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
745 (WTR::InjectedBundlePage::didInitiateLoadForResource):
747 2013-08-08 Alex Christensen <achristensen@apple.com>
751 Rubberstamped by Brent Fulgham.
753 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
754 Removed /SAFESEH link option which doesn't work with x64.
756 2013-08-08 Daniel Bates <dabates@apple.com>
758 Add iOS support to run-javascriptcore-tests
759 https://bugs.webkit.org/show_bug.cgi?id=119602
761 Reviewed by Joseph Pecoraro.
763 Make run-javascriptcore-tests work for iOS WebKit.
765 * Scripts/run-javascriptcore-tests:
767 2013-08-08 Alexey Proskuryakov <ap@apple.com>
769 [WK2] loader/go-back-cached-main-resource.html fails
770 https://bugs.webkit.org/show_bug.cgi?id=116491
772 Reviewed by Tim Horton.
774 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
775 * DumpRenderTree/gtk/DumpRenderTree.cpp:
776 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
777 * DumpRenderTree/win/DumpRenderTree.cpp:
778 Added FIXMEs about making path printing normalization more compatible.
780 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
781 Return last path component in cases where we used to return a full path, which is
782 never desirable. Added a null check to basePath to prevent potentially getting
783 an Objective C exception.
785 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
786 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
787 for a currently loading one (which is different for tests that use multiple windows).
788 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
789 last path component as last fallback.
790 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
791 frame URL here, and it was potentially a wrong frame.
792 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
793 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
794 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
795 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
796 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
798 2013-08-08 Alex Christensen <achristensen@apple.com>
800 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
801 https://bugs.webkit.org/show_bug.cgi?id=116125
803 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
805 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
806 (WTR::pathSuitableForTestResult):
807 Changed string operations to match _drt_descriptionSuitableForTestResult.
808 (WTR::dumpRequestDescriptionSuitableForTestResult):
809 (WTR::dumpResponseDescriptionSuitableForTestResult):
810 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
811 (WTR::InjectedBundlePage::didInitiateLoadForResource):
812 (WTR::InjectedBundlePage::willSendRequestForFrame):
813 (WTR::InjectedBundlePage::didReceiveResponseForResource):
814 Pass the main frame's URL to pathSuitableForTestResult.
815 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
816 Added WKBundlePageRef to willPerformClientRedirectForFrame.
818 2013-08-07 Simon Fraser <simon.fraser@apple.com>
820 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
821 https://bugs.webkit.org/show_bug.cgi?id=119317
823 Reviewed by Tim Horton.
825 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
826 the test to complete, which is not power friendly. Although DRT instances
827 are generally busy anyway, not sitting in a busy loop should free up some CPU
828 cycles for other instances of DRT.
830 Editing tests continue to pass. All Java tests are skipped and were not
831 tested, but when run fail similarly with and without the patch.
833 * DumpRenderTree/mac/DumpRenderTree.mm:
837 2013-08-07 Daniel Bates <dabates@apple.com>
839 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
840 <https://bugs.webkit.org/show_bug.cgi?id=119558>
842 Reviewed by Martin Robinson.
844 Currently we build the command line to execute jsDriver.pl twice so as to both
845 print it to standard output and actually execute it. We should only build up
846 this command line once. Moreover, we should print to standard output the actual
847 command line that we are going to use including the GTK- and EFL-specific call
848 to /Tools/jhbuild/jhbuild-wrapper.
850 * Scripts/run-javascriptcore-tests:
852 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
854 [EFL] REGRESSION after r153432: some accessibility tests crash.
855 https://bugs.webkit.org/show_bug.cgi?id=119333
857 Reviewed by Darin Adler.
859 Use a RefPtr to store a reference to the parent element of
860 an AccessibilityUIElement instead of the raw pointer, so we
861 never derefence a function from an invalid pointer.
863 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
864 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
866 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
868 Unreviewed. Add myself as a committer.
870 * Scripts/webkitpy/common/config/contributors.json:
872 2013-08-04 Sam Weinig <sam@webkit.org>
874 Remove support for HTML5 MicroData
875 https://bugs.webkit.org/show_bug.cgi?id=119480
877 Reviewed by Anders Carlsson.
879 * Scripts/webkitperl/FeatureList.pm:
880 * qmake/mkspecs/features/features.pri:
882 2013-07-23 David Farler <dfarler@apple.com>
884 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
885 https://bugs.webkit.org/show_bug.cgi?id=117762
887 Reviewed by Mark Rowe.
889 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
890 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
891 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
892 Add ASAN_OTHER_LDFLAGS.
893 * MiniBrowser/Configurations/DebugRelease.xcconfig:
894 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
895 * Scripts/check-for-weak-vtables-and-externals:
896 Ignore ___asan externals, these are populated by compiler-rt.
897 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
898 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
899 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
900 Add ASAN_OTHER_LDFLAGS.
901 * WebKitLauncher/Configurations/Base.xcconfig:
902 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
903 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
904 Add ASAN_OTHER_LDFLAGS.
905 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
906 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
907 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
908 Add ASAN_OTHER_LDFLAGS.
909 * asan/asan.xcconfig: Added.
910 * asan/webkit-asan-ignore.txt: Added.
912 2013-08-05 Brian Holt <brian.holt@samsung.com>
914 [GTK] Implement leak checking with valgrind
915 https://bugs.webkit.org/show_bug.cgi?id=118785
917 Reviewed by Dirk Pranke.
919 Launch the DRT under Valgrind to generate xml files with details
922 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
924 * Scripts/webkitpy/port/gtk.py:
926 (GtkPort.default_timeout_ms): Allow extra time to run under
928 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
929 using environment variables.
931 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
933 [EFL] REGRESSION after r153432: some accessibility tests crash.
934 https://bugs.webkit.org/show_bug.cgi?id=119333
936 Reviewed by Gustavo Noronha Silva.
938 Add missing null-check to avoid dereferencing a non-existent parent.
940 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
941 (WTR::attributesOfElement): Ditto.
943 2013-08-02 Patrick Gansterer <paroga@webkit.org>
945 Add --rmdir option to git svn dcommit
946 https://bugs.webkit.org/show_bug.cgi?id=119398
948 Reviewed by Ryosuke Niwa.
950 Add this option tells git-svn to remove empty directories
951 from the svn tree so they do not leave over there.
953 * Scripts/webkitpy/common/checkout/scm/git.py:
954 (Git.push_local_commits_to_server):
956 2013-08-01 Brent Fulgham <bfulgham@apple.com>
958 [Windows] WebKit1 Fullscreen Video Play is Broken
959 https://bugs.webkit.org/show_bug.cgi?id=119415
961 Reviewed by Jer Noble.
963 * WinLauncher/WinLauncher.cpp:
964 (dllLauncherEntryPoint): Activate full screen mode via
965 IWebPreferencesInternal interface.
967 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
969 Unreviewed. Add an alternative address to show my affiliation in team.html.
971 * Scripts/webkitpy/common/config/contributors.json:
973 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
975 Duplicate property names can cause test to fail
976 https://bugs.webkit.org/show_bug.cgi?id=119399
978 Reviewed by Dirk Pranke.
980 This problem was noticed when porting the patch for
981 http://wkb.ug/119357 to Blink: a test would fail because the converted
982 and test property lists weren't the same length, but they contained
983 all of the same property names. It looks like this is actually caused
984 by a bug in converting the HTML, which is being currently rewritten.
985 In the meantime, as long as this compares the number of unique
986 properties, it makes the test more robust.
988 * Scripts/webkitpy/w3c/test_converter_unittest.py:
989 (verify_prefixed_properties):
991 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
993 Unreviewed. Adding my expertise.
995 * Scripts/webkitpy/common/config/contributors.json:
997 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
999 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1001 * Scripts/webkitpy/common/config/contributors.json:
1003 2013-08-01 Commit Queue <commit-queue@webkit.org>
1005 Unreviewed, rolling out r153518.
1006 http://trac.webkit.org/changeset/153518
1007 https://bugs.webkit.org/show_bug.cgi?id=119386
1009 The Jhbuild dep bump of GTK+ is not actually required by
1010 layout testing, is causing pango dep problems (Requested by
1011 zdobersek on #webkit).
1013 * gtk/jhbuild.modules:
1015 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
1017 Unreviewed. Add myself as a committer.
1019 * Scripts/webkitpy/common/config/contributors.json:
1021 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
1023 Unreviewed. Add myself as a committer.
1025 * Scripts/webkitpy/common/config/contributors.json:
1027 2013-07-31 Jinwoo Song <jinwoo7.song@samsung.com>
1029 Unreviewed. Add myself as a committer.
1031 * Scripts/webkitpy/common/config/contributors.json:
1033 2013-08-01 Alberto Garcia <berto@igalia.com>
1035 Unreviewed. Add myself as a committer.
1037 * Scripts/webkitpy/common/config/contributors.json:
1039 2013-07-31 Seokju Kwon <seokju@webkit.org>
1041 Unreviewed. Add myself as a committer.
1043 * Scripts/webkitpy/common/config/contributors.json:
1045 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1047 W3C test import script prefixes some properties that it shouldn't
1048 https://bugs.webkit.org/show_bug.cgi?id=119357
1050 Reviewed by Dirk Pranke.
1052 Some prefixed properties also have unprefixed implemetations, but when
1053 the implementations aren't identical, they aren't declared in
1054 CSSPropertyNames.in on the same line. This fixes the import script so
1055 that it catches all instances of prefixed properties that have an
1056 unprefixed variant, and does not add the prefix in those cases.
1058 * Scripts/webkitpy/w3c/test_converter.py:
1059 (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1060 the properties on every line and record if they are prefixed or not.
1061 Use this information to only return prefixed properties that do not
1062 have any unprefixed variant. The prefixed property list has also
1063 changed to not include the '-webkit-' prefix, making it much easier to
1064 do the comparison, and removing the need to remove the prefix later.
1065 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1066 longer needs to remove the '-webkit-' prefix, but needs to add it in
1067 the case where a property that needs a prefix is found.
1068 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1069 (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1070 for '-webkit-' prefix, as it is no longer included in the properties
1071 in the prefixed property list.
1073 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1075 Update location of w3c shapes tests to reflect new import location
1076 https://bugs.webkit.org/show_bug.cgi?id=118156
1078 Reviewed by Dirk Pranke.
1080 Partial imports should not be imported to the same place as the full
1081 import, so this adds an option to allow importing to a different
1082 location than the default. In doing that, I found that imports from
1083 contributor directories didn't seem to be working correctly, so I
1084 updated the import to be smarter about both contributor directories
1085 and the test status directories. It should now be more likely that the
1086 script guesses the root directory properly.
1088 * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1089 script not working with the full set of contributors, as that is
1090 no longer true, and I didn't see a good way to keep that behavior.
1091 Also update documentation to properly explain what happens when a
1092 contributor dir is imported.
1093 (main): Attempt to find the proper repo dir by looking at the
1094 directory above the "test status" in the given path, this is still
1095 not exactly right, but is less error prone than just trimming.
1096 (parse_args): Add -d option to set the import directory.
1097 (TestImporter.__init__): Stop appending the subdirs to the
1098 destination_directory because it was making things more complex
1099 and isn't really needed.
1100 (TestImporter.update_test_status): Remove hardcoded strings and use
1101 the TEST_STATUS constants instead.
1102 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1103 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1104 support for new option.
1105 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1107 2013-07-31 Brent Fulgham <bfulgham@apple.com>
1109 [Windows] Winlauncher shouldn't look for Safari Install Directory
1110 https://bugs.webkit.org/show_bug.cgi?id=119351
1112 Reviewed by Darin Adler.
1114 * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1115 the Safari install location. Instead, use the proper support
1116 library path for the build architecture.
1118 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1120 Update scripts to reference contributors.json instead of committers.py in messaging
1121 https://bugs.webkit.org/show_bug.cgi?id=119342
1123 Reviewed by Ryosuke Niwa.
1125 Change the scripts to point people to contributors.json instead of
1126 committers.py since the latter no longer contains the list of
1129 * Scripts/webkitpy/common/config/committervalidator.py:
1130 (CommitterValidator._contributors_json_path):
1131 (CommitterValidator._flag_permission_rejection_message):
1132 * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1133 (CommitterValidatorTest.test_flag_permission_rejection_message):
1134 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1135 (Bugzilla._commit_queue_flag):
1136 * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1137 (WatchListParser._validate):
1138 * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1139 (WatchListParserTest.test_cc_rule_with_invalid_email):
1140 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1141 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1142 * Scripts/webkitpy/tool/steps/validatereviewer.py:
1143 (ValidateReviewer.run):
1145 2013-07-31 Roger Fong <roger_fong@apple.com>
1147 Unreviewed. Re-enable WinEWS tests following r153527.
1149 * Scripts/webkitpy/common/config/ews.json:
1151 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1153 Unreviewed: Adding myself to the committers' list.
1155 * Scripts/webkitpy/common/config/contributors.json:
1157 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1159 [Qt] Build WebKit with C++11
1160 https://bugs.webkit.org/show_bug.cgi?id=119337
1162 Reviewed by Csaba Osztrogonác.
1164 Enable building with C++11.
1166 * qmake/mkspecs/features/default_pre.prf:
1167 * qmake/mkspecs/features/unix/default_post.prf:
1168 * qmake/mkspecs/features/unix/default_pre.prf:
1170 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1172 [Qt] ASSERTS trigger in release builds
1173 https://bugs.webkit.org/show_bug.cgi?id=119336
1175 Reviewed by Jocelyn Turcotte.
1177 Ensure the qmake also defaults to release if no configuration is known.
1179 * qmake/mkspecs/features/default_post.prf:
1181 2013-07-31 Zan Dobersek <zdobersek@igalia.com>
1183 [texmap][GStreamer][GTK] composited video shows tearing
1184 https://bugs.webkit.org/show_bug.cgi?id=118253
1186 Reviewed by Martin Robinson.
1188 * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1189 The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1190 screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1192 2013-07-30 Ruth Fong <ruth_fong@apple.com>
1194 Unreviewed: Adding myself to the committers' list.
1196 * Scripts/webkitpy/common/config/contributors.json:
1198 2013-07-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1200 Unreviewed, add my new email to contributors.json.
1202 * Scripts/webkitpy/common/config/contributors.json:
1204 2013-07-30 Krzysztof Czech <k.czech@samsung.com>
1206 [EFL] REGRESSION after r153439: layout tests do not run.
1207 https://bugs.webkit.org/show_bug.cgi?id=119240
1209 Reviewed by Christophe Dumez.
1211 Changed attribute name from check_xvfb to check_driver.
1213 * Scripts/webkitpy/port/efl.py:
1214 (EflPort.check_sys_deps):
1216 2013-07-29 Commit Queue <commit-queue@webkit.org>
1218 Unreviewed, rolling out r152860.
1219 http://trac.webkit.org/changeset/152860
1220 https://bugs.webkit.org/show_bug.cgi?id=119227
1222 Disable WinEWS tests until tests stop crashing (Requested by
1225 * Scripts/webkitpy/common/config/ews.json:
1227 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1229 [GTK] Add WestonDriver, use it when appropriate
1230 https://bugs.webkit.org/show_bug.cgi?id=119100
1232 Reviewed by Dirk Pranke.
1234 Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1235 and sets up an environment that enables the test runner to run inside it.
1237 The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1238 environment variable is set, that is when NRWT is being run under a Wayland display.
1240 * Scripts/webkitpy/port/base.py:
1241 (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1242 * Scripts/webkitpy/port/gtk.py:
1244 (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1245 should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1246 (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1247 instead of hard-coding the XvfbDriver class in the check.
1248 * Scripts/webkitpy/port/westondriver.py: Added.
1250 (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1251 (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1252 (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1253 driver and then launches the driver in said environment, using the driver's Weston display.
1254 (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1255 (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1256 and returns the absolute path to it.
1257 * Scripts/webkitpy/port/xvfbdriver.py:
1258 (XvfbDriver.check_driver): Renamed from check_xvfb.
1259 (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1261 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1263 [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1264 https://bugs.webkit.org/show_bug.cgi?id=118967
1266 Reviewed by Gustavo Noronha Silva.
1268 Implemented AccessibilityUIElement::attributesOfChildren() both
1269 in DumpRenderTree and the WebKitTestRunner.
1271 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1272 (AccessibilityUIElement::attributesOfChildren): Implemented.
1274 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1275 (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1277 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1279 [ATK] Implement allAttributes() for AccessibilityUIElement
1280 https://bugs.webkit.org/show_bug.cgi?id=118966
1282 Reviewed by Gustavo Noronha Silva.
1284 Implemented AccessibilityUIElement::allAttributes() both in
1285 DumpRenderTree and the WebKitTestRunner.
1287 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1288 (getAtkAttributeSetAsString): Moved up in the file, and refactored
1289 to use StringBuilder and return a String instead of a gchar*.
1290 (roleToString): Changed not to return the "AXRole: " prefix, so
1291 we can use it as well from attributesOfElement().
1292 (attributesOfElement): New function to dump attributes for an object.
1293 (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1294 (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1296 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1297 (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1298 a String instead of a gchar*.
1300 (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1301 so we can use it as well from attributesOfElement().
1302 (WTF::attributesOfElement): New function to dump attributes for an object.
1303 (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1304 (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1306 2013-07-29 Daniel Bates <dabates@apple.com>
1308 Add support infrastructure for iOS WebKit port
1309 https://bugs.webkit.org/show_bug.cgi?id=119168
1311 Reviewed by Ryosuke Niwa.
1313 Implement support infrastructure towards building iOS WebKit.
1315 * Scripts/webkitdirs.pm:
1316 (xcodeSDKPlatformName): Added.
1317 (determineConfigurationProductDir):
1318 (builtDylibPathForName):
1319 (willUseIOSDeviceSDKWhenBuilding): Added.
1320 (willUseIOSSimulatorSDKWhenBuilding): Added.
1321 (isIOSWebKit): Added.
1322 (copyInspectorFrontendFiles):
1324 2013-07-29 Sergio Correia <sergio.correia@openbossa.org>
1326 CoordinatedGraphics: Add API to get and set the active state of a WebView
1327 https://bugs.webkit.org/show_bug.cgi?id=119067
1329 Reviewed by Noam Rosenthal.
1331 Added API tests for WKViewIsActive and WKViewSetIsActive.
1333 * TestWebKitAPI/PlatformEfl.cmake:
1334 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1335 (TestWebKitAPI::didFinishLoadForFrame):
1336 (TestWebKitAPI::webProcessCrashed):
1337 (TestWebKitAPI::webProcessRelaunched):
1338 (TestWebKitAPI::TEST):
1339 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1340 Bundle added to allow crashing the WebProcess and testing the active state of a view
1341 under such condition.
1342 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1343 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1345 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1347 [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1348 https://bugs.webkit.org/show_bug.cgi?id=119212
1350 Reviewed by Carlos Garcia Campos.
1352 * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1353 variables that are not defined during the configuration process.
1354 * TestWebKitAPI/GNUmakefile.am: Ditto.
1355 * WebKitTestRunner/GNUmakefile.am: Ditto.
1357 2013-07-28 Andy Estes <aestes@apple.com>
1359 Include <stdio.h> to declare perror()
1360 https://bugs.webkit.org/show_bug.cgi?id=119198
1362 Reviewed by Andreas Kling.
1364 Silences an implicit declaration warning.
1366 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1368 2013-07-27 Ryuan Choi <ryuan.choi@samsung.com>
1370 [EFL] Bump required version of EFL to 1.7
1371 https://bugs.webkit.org/show_bug.cgi?id=119144
1373 Reviewed by Christophe Dumez.
1375 * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1377 2013-07-26 Filip Pizlo <fpizlo@apple.com>
1379 WKTR should know about the JSC extensions to testRunner
1380 https://bugs.webkit.org/show_bug.cgi?id=119154
1382 Reviewed by Mark Hahnenberg and Geoffrey Garen.
1384 This makes some fast/js tests pass.
1386 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1387 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1388 (WTR::TestRunner::numberOfDFGCompiles):
1389 (WTR::TestRunner::neverInlineFunction):
1390 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1392 2013-07-25 Mark Rowe <mrowe@apple.com>
1394 Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1396 * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1397 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1398 so they pull the version out of the SDK.
1400 2013-07-25 Anders Carlsson <andersca@apple.com>
1402 Localizable.strings generated by extract-localizable-strings should be UTF-8
1403 https://bugs.webkit.org/show_bug.cgi?id=119106
1405 Reviewed by Mark Rowe.
1407 Output strings as UTF-8.
1409 * Scripts/extract-localizable-strings:
1411 2013-07-25 Sam Weinig <sam@webkit.org>
1413 -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1414 https://bugs.webkit.org/show_bug.cgi?id=119099
1415 <rdar://problem/13439291>
1417 Reviewed by Enrica Casucci.
1419 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1420 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1421 (TestWebKitAPI::attributedString):
1422 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1423 (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1424 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1425 (TestWebKitAPI::TEST_F):
1426 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1427 (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1428 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1429 * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1430 Add tests for attributed strings with strikethrough. Refactor the attributed string tests
1431 to make adding more easier in the future.
1433 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1435 fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1436 https://bugs.webkit.org/show_bug.cgi?id=118948
1438 Reviewed by Sam Weinig.
1440 - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1441 by exporting it as a function.
1443 - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1444 it even if you know that you've already done so. See processIRDump.sh.
1446 - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1447 runs it through ReducedFTL automatically. You typically want to say something like:
1449 jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1450 ./processIRDump.sh --timing < jsc-output.txt
1452 * ReducedFTL/ReducedFTL.c:
1454 * ReducedFTL/combineModules.rb:
1455 * ReducedFTL/processIRDump.sh: Added.
1457 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1459 fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1460 https://bugs.webkit.org/show_bug.cgi?id=118947
1462 Reviewed by Dan Bernstein.
1464 * Scripts/copy-webkitlibraries-to-product-directory:
1466 2013-07-16 Filip Pizlo <fpizlo@apple.com>
1468 fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1469 https://bugs.webkit.org/show_bug.cgi?id=118647
1471 Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1473 Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1474 way that the FTL would.
1476 Also add a tool that combines multiple LLVM modules generated by FTL into a
1479 * ReducedFTL: Added.
1480 * ReducedFTL/ReducedFTL.c: Added.
1484 (mmAllocateCodeSection):
1485 (mmAllocateDataSection):
1486 (mmApplyPermissions):
1488 (symbolLookupCallback):
1490 * ReducedFTL/build.sh: Added.
1491 * ReducedFTL/combineModules.rb: Added.
1493 2013-06-09 Filip Pizlo <fpizlo@apple.com>
1495 Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1496 for the "/" that is printed between engine counts.
1498 * Scripts/display-profiler-output:
1500 2013-05-28 Filip Pizlo <fpizlo@apple.com>
1502 testRunner should have a way of disabling inlining of functions
1503 https://bugs.webkit.org/show_bug.cgi?id=116875
1505 Reviewed by Mark Hahnenberg.
1507 * DumpRenderTree/TestRunner.cpp:
1508 (neverInlineFunction):
1509 (TestRunner::staticFunctions):
1511 2013-05-27 Filip Pizlo <fpizlo@apple.com>
1513 testRunner should be able to tell you if a function is DFG compiled
1514 https://bugs.webkit.org/show_bug.cgi?id=116847
1516 Reviewed by Mark Hahnenberg.
1518 * DumpRenderTree/TestRunner.cpp:
1519 (numberOfDFGCompiles):
1520 (TestRunner::staticFunctions):
1522 2013-05-21 Filip Pizlo <fpizlo@apple.com>
1524 fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1525 https://bugs.webkit.org/show_bug.cgi?id=116556
1527 Reviewed by Oliver Hunt.
1529 This adds three new capabilities:
1531 - 'display' now accepts negative compilation indices, and allows specifying
1532 wildcard hashes combined with combination indices. Previously you could say
1533 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1534 latter would display every compilation. This improves this so that you can
1535 say 'display *-<index>-<engine>'. It also makes it so that you can give a
1536 negative index, which allows you to say things like 'display blah--1-dfg',
1537 which displays just the last DFG compilation. Also you can say
1538 'display *--1-dfg', which displays the last DFG compilation for each code
1539 block. I realize that this is kind of ugly, but gosh is it practical.
1541 - You can now say 'sort hash', which will henceforth sort all of the output
1542 by code hash rather than by the time when it was compiled. This means that
1543 if you're doing 'dispay *--1-dfg' and then want to diff the results against
1544 something else, you can ensure that this doesn't get confused just by
1545 changes in compilation order.
1547 - You can now say 'counts off', which will henceforth disable the display of
1548 execution counts from 'bytecode' and 'display'. This is also useful for
1549 diffs, since if you're trying to figure out why two compilations are
1550 different, they probably have radically different counts. 'counts off' gets
1551 this out of the output so that it doesn't confuse your diff.
1553 Note that to use this effectively you should also have a script that scrubs
1554 pointers from text so that the diff doesn't get confused by pointers. I'll
1555 post my elimptr script to the bug. Maybe at some point I'll integrate that
1556 into display-profiler-output.
1558 Put together this is pretty awesome. I was able to do the following:
1560 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1561 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1562 diff -u richards-serial.asm richards-concurrent.asm
1564 And this immediately told me that the reason why richards is slower in the
1565 concurrent compilation case is just that we end up compiling *tons* more
1566 functions, most of which are trivially inlineable. Basically, concurrent
1567 compilation breaks our previous heuristics for delaying compilation of
1568 inlineables just enough that they never trigger compilation. We should fix
1569 that in a separate bug.
1571 * Scripts/display-profiler-output:
1573 2013-04-30 Filip Pizlo <fpizlo@apple.com>
1575 fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1577 Rubber stamped by Mark Rowe.
1579 * Scripts/copy-webkitlibraries-to-product-directory:
1581 2013-07-16 Oliver Hunt <oliver@apple.com>
1583 Merge dfgFourthTier r148853
1585 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1587 fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1588 https://bugs.webkit.org/show_bug.cgi?id=114933
1590 Reviewed by Andy Estes.
1592 This makes it easy to get set up for tandem LLVM builds.
1594 * Scripts/copy-webkitlibraries-to-product-directory:
1596 2013-07-16 Oliver Hunt <oliver@apple.com>
1598 Merge dfgFourthTier r148850
1600 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1602 fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1603 https://bugs.webkit.org/show_bug.cgi?id=114926
1605 Reviewed by Geoffrey Garen.
1607 If the LLVM libraries change, then touch a phony header, which will force relink
1610 * Scripts/copy-webkitlibraries-to-product-directory:
1611 (unpackIfNecessary):
1613 2013-07-16 Oliver Hunt <oliver@apple.com>
1615 Merge dfgFourthTier r148848
1617 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1619 fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1620 https://bugs.webkit.org/show_bug.cgi?id=114925
1622 Reviewed by Geoffrey Garen.
1624 This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1625 will also optionally build LLVM and quickly symlink LLVM's built products into
1628 Most WebKit and JSC hackers will want to rely on the checked-in already-built
1629 versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1630 increasingly common use-case for me, and it may become a common use case for a
1631 handful of others. Currently, this is really painful: you first have to build
1632 LLVM, then you have to export-llvm-build (which takes a while), and then you
1633 have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1634 variables are set to point to the thing you exported. The whole process loses
1635 track of dependencies very quickly: making a tiny change in LLVM requires
1636 packaging, and then unpackaging, a large number of potentially large headers and
1637 static libraries. Not only is this slow but it then causes the WebKit build
1638 system to rebuild anything that transitively includes any LLVM header, which is
1639 now quite a few files. While this sort of use pattern is still worthwhile if
1640 you're trying to package a binary drop and test it, it's not great if you're
1641 just trying to do experimental development that involves making small changes
1644 This change fixes this use case while keeping the old use cases intact. You can
1645 do tandem development using one of two modes:
1647 Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1648 the LLVM directory you're using. Once this is done, any invocation of a WebKit
1649 build via build-jsc or build-webkit will also build LLVM, and then quickly
1650 symlink things into place without perturbing dependency tracking.
1652 Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1653 right off of the WebKit source tree, then the build system will automatically
1656 Here's how this takes care of dependencies:
1658 Headers: the include/llvm and include/llvm-c directories are symlinked into
1659 $productsDir/usr/local/include. And then everything just works.
1661 Libraries: the build system detects, by reading LLVM's Makefile.config, which
1662 mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1663 the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1664 if they have changed, by checking both the modification time and also whether
1665 the last time we had a symlink, that symlink was from the same directory.
1666 This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1667 but that build wasn't yet ranlib'd.
1669 One problem that this does not yet solve is that xcodebuild will not relink
1670 JavaScriptCore if the only thing that changed was the libraries. I will work
1671 on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1673 * Scripts/copy-webkitlibraries-to-product-directory:
1674 (unpackIfNecessary):
1676 (fileContentsEquals):
1678 2013-04-15 Filip Pizlo <fpizlo@apple.com>
1680 fourthTier: Update LLVM-related build scripts to copy generated headers as well
1681 https://bugs.webkit.org/show_bug.cgi?id=114551
1683 Reviewed by Oliver Hunt.
1685 Also added the ability to use something other than bzip2 compression, since although
1686 it is great for checking things into the tree, it increases turn-around times when
1689 * Scripts/copy-webkitlibraries-to-product-directory:
1690 (unpackIfNecessary):
1691 * Scripts/export-llvm-build:
1693 2013-04-03 Filip Pizlo <fpizlo@apple.com>
1695 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1696 https://bugs.webkit.org/show_bug.cgi?id=113921
1698 Reviewed by Oliver Hunt.
1700 The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1701 the export script to do this.
1703 * Scripts/export-llvm-build:
1705 2013-03-29 Filip Pizlo <fpizlo@apple.com>
1707 fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1708 https://bugs.webkit.org/show_bug.cgi?id=113452
1710 Rubber stamped by Mark Hahnenberg.
1712 * Scripts/copy-webkitlibraries-to-product-directory:
1713 * Scripts/export-llvm-build:
1715 2013-03-29 Filip Pizlo <fpizlo@apple.com>
1717 fourthTier: FTL JIT should be able run some simple function
1718 https://bugs.webkit.org/show_bug.cgi?id=113481
1720 Reviewed by Geoffrey Garen.
1722 Give the scripts the ability to find an LLVM build and use it.
1724 Also added a script, export-llvm-build, that allows you to take your
1725 own build of LLVM and package it for use by WebKit's build system.
1727 The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1728 one for the library archives and one for the headers. It then unpacks
1729 them into your built products directory in a mannner that is mostly
1730 analogous to how WebKitSystemInterface works.
1732 * Scripts/build-jsc:
1733 * Scripts/copy-webkitlibraries-to-product-directory:
1734 (unpackIfNecessary):
1736 * Scripts/export-llvm-build: Added.
1738 2013-07-24 Anders Carlsson <andersca@apple.com>
1740 Crash when calling WKPageGetProcessIdentifier after aborted process launch
1741 https://bugs.webkit.org/show_bug.cgi?id=119069
1742 <rdar://problem/14494064>
1744 Reviewed by Andreas Kling.
1748 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1749 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1750 (TestWebKitAPI::didFinishLoadForFrame):
1751 (TestWebKitAPI::TEST):
1753 2013-07-24 Zan Dobersek <zdobersek@igalia.com>
1755 Make KURL::hasPath private
1756 https://bugs.webkit.org/show_bug.cgi?id=118279
1758 Reviewed by Darin Adler.
1760 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1761 (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1763 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
1765 [GTK] TestInspectorServer unit test is timing out
1766 https://bugs.webkit.org/show_bug.cgi?id=105866
1768 Reviewed by Gustavo Noronha Silva.
1770 * Scripts/run-gtk-tests:
1773 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
1775 [GTK] [WK2] Handle wheel event with delta zero
1776 https://bugs.webkit.org/show_bug.cgi?id=118973
1778 Reviewed by Gustavo Noronha Silva.
1780 Added handling of zero mouse scroll deltas in EventSenderProxy similar
1781 to WK1 and Qt/EFL ports.
1783 fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1786 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1787 (WTR::EventSenderProxy::mouseScrollBy):
1789 2013-07-23 Andreas Kling <akling@apple.com>
1791 REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1792 <rdar://problem/14324895>
1793 <http://webkit.org/b/119023>
1795 Reviewed by Simon Fraser.
1797 Add a test for this rather specific problem.
1799 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1800 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1801 (TestWebKitAPI::TEST):
1802 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1803 (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1804 (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1805 (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1807 2013-07-23 Tim Horton <timothy_horton@apple.com>
1809 Add a test for plug-in unavailability indicator obscurity detection
1810 https://bugs.webkit.org/show_bug.cgi?id=119007
1812 Reviewed by Anders Carlsson.
1814 Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1816 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1817 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1818 (WTR::TestRunner::setBlockAllPlugins):
1819 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1820 * WebKitTestRunner/TestInvocation.cpp:
1821 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1822 Add testRunner.setBlockAllPlugins function (and corresponding message to
1823 forward it through to TestController).
1825 * WebKitTestRunner/TestController.cpp:
1826 Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1828 (WTR::TestController::createWebViewWithOptions):
1829 Register our pluginLoadPolicy callback.
1831 (WTR::TestController::resetStateToConsistentValues):
1832 Reset m_shouldBlockAllPlugins to false.
1834 (WTR::TestController::pluginLoadPolicy):
1835 Return the existing plugin load policy, unless setBlockAllPlugins(true)
1836 was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1838 * WebKitTestRunner/TestController.h:
1839 (WTR::TestController::setBlockAllPlugins):
1841 2013-07-21 Andreas Kling <akling@apple.com>
1843 KURL creates duplicate strings when completing data: URIs.
1844 <http://webkit.org/b/118952>
1845 <rdar://problem/14504480>
1847 Reviewed by Anders Carlsson.
1849 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1850 (TestWebKitAPI::TEST_F):
1852 2013-07-19 Chris Fleizach <cfleizach@apple.com>
1854 AX: VoiceOver not detecting misspelled words don't work in all cases
1855 https://bugs.webkit.org/show_bug.cgi?id=118924
1857 Reviewed by Tim Horton.
1859 Make the misspelled detection dependent on both types of attributes being present.
1861 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1862 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1863 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1864 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1866 2013-07-19 Alex Christensen <achristensen@apple.com>
1868 Improved code coverage generation.
1869 https://bugs.webkit.org/show_bug.cgi?id=118926
1871 Reviewed by Tim Horton.
1873 * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
1874 * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
1875 (generateReport): Moved report generation to a subroutine.
1877 2013-07-19 Stephanie Lewis <slewis@apple.com>
1879 <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
1883 Rebaseline pagination test after http://trac.webkit.org/changeset/152911
1885 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1886 (TestWebKitAPI::didLayout):
1888 2013-07-19 Daniel Bates <dabates@apple.com>
1890 Make Perl tools work when using git bisect with Git branch build setup
1891 https://bugs.webkit.org/show_bug.cgi?id=118512
1893 Reviewed by Martin Robinson.
1895 The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
1896 during a git bisect session with a Git branch build setup (i.e. git config
1897 core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
1898 specific build of WebKit because they cannot determine the branch Git is on (since
1899 git bisect puts Git into a detached HEAD state). We should teach our tooling to
1900 parse the file .git/BISECT_START (created by git bisect start) for the name of the
1901 branch Git was on when we began a git bisect session. Then the tools can determine
1902 the path to the built WebKit.
1904 * Scripts/VCSUtils.pm:
1905 (gitDirectory): Added.
1906 (gitBisectStartBranch): Added.
1907 (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
1908 HEAD (e.g. running git bisect).
1909 (determineVCSRoot): Modified to call gitDirectory() to determine the path to
1910 the .git directory in the Git checkout.
1912 2013-07-19 Alex Christensen <achristensen@apple.com>
1914 Added x64 configuration to Visual Studio build.
1915 https://bugs.webkit.org/show_bug.cgi?id=118888
1917 Reviewed by Brent Fulgham.
1919 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1920 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1921 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1922 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1923 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1924 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1925 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1926 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1927 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1928 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1929 * win/record-memory/record-memory.vcxproj:
1931 2013-07-19 Martin Robinson <mrobinson@igalia.com>
1933 Add a couple people to the MathML watchlist
1934 https://bugs.webkit.org/show_bug.cgi?id=118909
1936 Reviewed by Andreas Kling.
1938 Add a couple people to the MathML watchlist and add Kalyan's other
1939 email address to fix style checker warnings about the watchlist
1942 * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
1943 list of contributors and add Kalyan's second email address.
1944 * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
1947 2013-07-19 Simon Pena <simon.pena@samsung.com>
1949 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
1950 https://bugs.webkit.org/show_bug.cgi?id=118895
1952 Reviewed by Philippe Normand.
1954 In r152782 an uri is used to create an string representation without checking first if it
1955 is valid. That fails later when the string is used to check for existing redirections. This
1956 patch ensures that the uri is valid before using it.
1958 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1959 (willSendRequestCallback): Ensure an uri is valid before using it.
1961 2013-07-18 Timothy Hatcher <timothy@apple.com>
1963 Add extract-localizable-js-strings and use it for WebInspectorUI.
1965 https://bugs.webkit.org/show_bug.cgi?id=118851
1967 Reviewed by Joseph Pecoraro.
1969 * Scripts/extract-localizable-js-strings: Added.
1970 * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
1971 * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
1972 the WebInspectorUI project.
1974 2013-07-18 Brent Fulgham <bfulgham@apple.com>
1976 [Windows] Build correction #2 after r152861.
1978 * WinLauncher/WinLauncher.cpp: Declare proper linkage.
1980 2013-07-18 Brent Fulgham <bfulgham@apple.com>
1982 [Windows] Build correction after r152861.
1984 * WinLauncher/WinLauncher.cpp: Don't reference private header.
1986 2013-07-16 Brent Fulgham <bfulgham@apple.com>
1988 [Win] Support in-band text tracks.
1989 https://bugs.webkit.org/show_bug.cgi?id=103770
1991 Reviewed by Eric Carlson.
1993 Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
1994 libdispatch and CFRunLoop elements are services during the run loop.
1996 * WinLauncher/WinLauncher.cpp:
1997 (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
1998 a CoreFoundation (or CFLite) support library.
1999 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2000 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2001 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2002 and WinLauncherCFLite.props.
2004 2013-07-18 Roger Fong <roger_fong@apple.com>
2006 Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2008 * Scripts/webkitpy/common/config/ews.json:
2010 2013-07-18 Daniel Bates <dabates@apple.com>
2012 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2013 https://bugs.webkit.org/show_bug.cgi?id=118854
2014 <rdar://problem/14081339>
2016 Reviewed by David Kilzer.
2018 Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2019 Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2020 run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2021 listen on these ports so that we can run tests that use port 8443 and 8080.
2023 * Scripts/old-run-webkit-tests:
2024 (configureAndOpenHTTPDIfNeeded):
2026 2013-07-17 Tim Horton <timothy_horton@apple.com>
2028 Update blocked/missing plug-in UI
2029 https://bugs.webkit.org/show_bug.cgi?id=118347
2030 <rdar://problem/14209318>
2032 Reviewed by Sam Weinig.
2034 * MiniBrowser/mac/WK2BrowserWindowController.m:
2035 (-[WK2BrowserWindowController awakeFromNib]):
2036 * WebKitTestRunner/TestController.cpp:
2037 (WTR::TestController::createWebViewWithOptions):
2038 Match new WKPageLoaderClient entry.
2040 2013-07-17 Commit Queue <commit-queue@webkit.org>
2042 Unreviewed, rolling out r152701, r152703, r152739, r152754,
2044 http://trac.webkit.org/changeset/152701
2045 http://trac.webkit.org/changeset/152703
2046 http://trac.webkit.org/changeset/152739
2047 http://trac.webkit.org/changeset/152754
2048 http://trac.webkit.org/changeset/152756
2049 https://bugs.webkit.org/show_bug.cgi?id=118821
2051 this was a buggy fix and we're going to try something
2052 different (Requested by thorton on #webkit).
2054 * MiniBrowser/mac/WK2BrowserWindowController.m:
2055 (-[WK2BrowserWindowController awakeFromNib]):
2056 * WebKitTestRunner/TestController.cpp:
2057 (WTR::TestController::createWebViewWithOptions):
2059 2013-07-17 Commit Queue <commit-queue@webkit.org>
2061 Unreviewed, rolling out r151535.
2062 http://trac.webkit.org/changeset/151535
2063 https://bugs.webkit.org/show_bug.cgi?id=118804
2065 Re-disable WinEWS tests (Requested by rfong on #webkit).
2067 * Scripts/webkitpy/common/config/ews.json:
2069 2013-07-17 Simon Pena <simon.pena@samsung.com>
2071 [GTK] Make DRT obbey testRunner's addURLToRedirect
2072 https://bugs.webkit.org/show_bug.cgi?id=118239
2074 Reviewed by Gustavo Noronha Silva.
2076 Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2077 to the proper URI when indicated.
2079 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2080 (willSendRequestCallback):
2082 2013-07-17 Gabor Abraham <abrhm@inf.u-szeged.hu>
2084 Add a new find-resolved-bugs command to webkit-patch.
2085 https://bugs.webkit.org/show_bug.cgi?id=118060
2087 Reviewed by Csaba Osztrogonác.
2089 * Scripts/webkitpy/tool/commands/queries.py:
2090 (PrintBaselines._platform_for_path):
2092 (FindResolvedBugs.execute):
2094 2013-07-16 Balazs Kelemen <kbalazs@webkit.org>
2096 [CMake] Undefined references should be detected at build time
2097 https://bugs.webkit.org/show_bug.cgi?id=110236
2099 Reviewed by Christophe Dumez.
2101 Add library dependencies that were not defined explicitly before.
2103 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2104 * TestWebKitAPI/CMakeLists.txt:
2105 * WebKitTestRunner/CMakeLists.txt:
2107 2013-07-16 Kwang Yul Seo <skyul@company100.net>
2109 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2110 https://bugs.webkit.org/show_bug.cgi?id=118755
2112 Reviewed by Ryosuke Niwa.
2114 Fix r152719 to check "using namespace foo;" only in headers.
2116 * Scripts/webkitpy/style/checkers/cpp.py:
2117 (check_using_namespace):
2119 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2120 (WebKitStyleTest.test_using_namespace):
2122 2013-07-16 Christophe Dumez <ch.dumez@sisa.samsung.com>
2124 Get rid of multiple inheritance support from the bindings generators
2125 https://bugs.webkit.org/show_bug.cgi?id=118353
2127 Reviewed by Kentaro Hara.
2129 Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2130 deprecated domInterface->parents.
2132 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2135 2013-07-16 Brian Holt <brian.holt@samsung.com>
2137 check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2138 https://bugs.webkit.org/show_bug.cgi?id=57241
2140 Reviewed by Ryosuke Niwa.
2142 Added check for "using namespace foo" and unit test.
2144 * Scripts/webkitpy/style/checkers/cpp.py:
2145 (check_using_namespace):
2148 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2149 (WebKitStyleTest.test_using_namespace):
2151 2013-07-16 Anton Obzhirov <a.obzhirov@samsung.com>
2153 [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2154 https://bugs.webkit.org/show_bug.cgi?id=110222
2156 Reviewed by Gustavo Noronha Silva.
2158 Added handling of zero mouse scroll deltas in EventSender.
2160 * DumpRenderTree/gtk/EventSender.cpp:
2161 (mouseScrollByCallback):
2163 2013-07-16 Brian Holt <brian.holt@samsung.com>
2165 webkitpy: replace urllib with urllib2 for downloading additional modules
2166 https://bugs.webkit.org/show_bug.cgi?id=118671
2168 Reviewed by Ryosuke Niwa.
2170 Urllib2 is available whereever urllib is, but has better proxy support.
2172 * Scripts/webkitpy/common/system/autoinstall.py:
2173 (AutoInstaller._download_to_stream):
2175 2013-07-16 Krzysztof Czech <k.czech@samsung.com>
2177 [ATK] Adds support for aria-haspopup property.
2178 https://bugs.webkit.org/show_bug.cgi?id=117834
2180 Reviewed by Christophe Dumez.
2182 Adds implementation for testing aria-haspopup property.
2184 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2185 (getAttributeSetValueForId):
2186 (AccessibilityUIElement::stringAttributeValue):
2187 (AccessibilityUIElement::hasPopup):
2188 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2189 (WTR::getAttributeSetValueForId):
2190 (WTR::AccessibilityUIElement::stringAttributeValue):
2191 (WTR::AccessibilityUIElement::hasPopup):
2193 2013-07-16 Michael Brüning <michael.bruning@digia.com>
2195 [Qt] Replace Nokia references.
2196 https://bugs.webkit.org/show_bug.cgi?id=118728
2198 Reviewed by Simon Hausmann.
2200 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2201 (MiniBrowserApplication::MiniBrowserApplication):
2202 * QtTestBrowser/qttestbrowser.cpp:
2203 (LauncherApplication::LauncherApplication):
2205 2013-07-15 Tim Horton <timothy_horton@apple.com>
2207 Update blocked/missing plug-in UI
2208 https://bugs.webkit.org/show_bug.cgi?id=118347
2209 <rdar://problem/14209318>
2211 Reviewed by Sam Weinig.
2213 * MiniBrowser/mac/WK2BrowserWindowController.m:
2214 (-[WK2BrowserWindowController awakeFromNib]):
2215 * WebKitTestRunner/TestController.cpp:
2216 (WTR::TestController::createWebViewWithOptions):
2217 Match new WKPageLoaderClient entry.
2219 2013-07-15 Chris Fleizach <cfleizach@apple.com>
2221 Update James Craig's email address.
2223 * Scripts/webkitpy/common/config/contributors.json:
2225 2013-07-15 Dong-Gwan Kim <donggwan.kim@samsung.com>
2227 [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2228 https://bugs.webkit.org/show_bug.cgi?id=118583
2230 Reviewed by Christophe Dumez.
2232 There're many fails on efl webkit2 API test if opengl is not available.
2233 So, add fallback to non-opengl evas engine.
2235 * TestWebKitAPI/efl/PlatformWebView.cpp:
2236 (TestWebKitAPI::initEcoreEvas):
2238 2013-07-15 Brian Holt <brian.holt@samsung.com>
2240 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2241 https://bugs.webkit.org/show_bug.cgi?id=118592
2243 Reviewed by Martin Robinson.
2245 Added a suppression for pylint false positives and a unit test.
2247 * Scripts/webkitpy/style/checkers/python.py:
2249 * Scripts/webkitpy/style/checkers/python_unittest.py:
2250 (PythonCheckerTest.test_check):
2251 (PythonCheckerTest):
2252 (PythonCheckerTest.test_pylint_false_positives):
2253 (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2254 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2257 2013-07-15 Xabier Rodriguez Calvar <calvaris@igalia.com>
2259 [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2260 https://bugs.webkit.org/show_bug.cgi?id=115166
2262 Reviewed by Philippe Normand.
2264 * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2266 2013-07-12 Kwang Yul Seo <skyul@company100.net>
2268 Unreviewed. Add an email address and update my domain of experts.
2270 * Scripts/webkitpy/common/config/contributors.json:
2272 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2274 [jhbuild] Avoid restarting from scratch failed initial checkouts
2275 https://bugs.webkit.org/show_bug.cgi?id=118603
2277 Reviewed by Martin Robinson.
2279 If the initial checkout is interrupted midway (eg. because the internet
2280 connection went down) config files do not get generated and that causes
2281 the next checkout to start from scratch (the missing files cause the
2282 script to delete the build root and the downloaded sources).
2284 By generating the files before invoking jhbuild, subsequent runs are able
2285 to start where the previous run left.
2287 * Scripts/update-webkit-libs-jhbuild:
2288 (saveJhbuildMd5): invoke it before runJhbuild().
2290 2013-07-12 Brent Fulgham <bfulgham@apple.com>
2292 [Windows] Remove single-worker restriction on tests.
2294 * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2296 2013-07-12 Commit Queue <commit-queue@webkit.org>
2298 Unreviewed, rolling out r152599.
2299 http://trac.webkit.org/changeset/152599
2300 https://bugs.webkit.org/show_bug.cgi?id=118612
2302 This patch includes a failing unit test (Requested by
2303 mrobinson on #webkit).
2305 * Scripts/webkitpy/style/checkers/python.py:
2307 * Scripts/webkitpy/style/checkers/python_unittest.py:
2308 (PythonCheckerTest.test_check):
2309 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2311 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2313 [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2314 https://bugs.webkit.org/show_bug.cgi?id=91223
2316 Reviewed by Martin Robinson.
2318 When run on a clean checkout, `build-webkit` complains that no
2319 GNUmakefile exists when trying to detect the previously configured
2320 architecture, but in this case there's no previous configuration so
2321 the warning is pointless.
2323 * Scripts/webkitdirs.pm:
2324 (determineArchitecture): Redirect grep stderr to /dev/null.
2326 2013-07-12 Brian Holt <brian.holt@samsung.com>
2328 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2329 https://bugs.webkit.org/show_bug.cgi?id=118592
2331 Reviewed by Martin Robinson.
2333 Added a suppression for pylint false positives and a unit test.
2335 * Scripts/webkitpy/style/checkers/python.py:
2337 * Scripts/webkitpy/style/checkers/python_unittest.py:
2338 (PythonCheckerTest.test_check):
2339 (PythonCheckerTest):
2340 (PythonCheckerTest.test_pylint_false_positives):
2341 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2342 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2345 2013-07-11 Arnaud Renevier <a.renevier@samsung.com>
2347 Unreviewed. Add myself as a committer.
2349 * Scripts/webkitpy/common/config/contributors.json:
2351 2013-07-10 Sergio Correia <sergio.correia@openbossa.org>
2353 Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2354 https://bugs.webkit.org/show_bug.cgi?id=118538
2356 Reviewed by Christophe Dumez.
2358 When attempting some odd url such as ``foo'', MiniBrowser will now show an
2359 error message such as "Cannot resolve hostname (foo)".
2361 Previously, it had the following behavior if MiniBrowser was started with
2362 such urls, e.g ``./MiniBrowser foo'':
2365 It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2368 No asserts, naturally, but the view would remain blank, even if we tried to
2369 change to a valid url.
2371 * MiniBrowser/efl/main.c:
2374 2013-07-10 Simon Pena <simon.pena@samsung.com>
2376 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2377 https://bugs.webkit.org/show_bug.cgi?id=118509
2379 Reviewed by Martin Robinson.
2381 In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2382 when trying to remove an event already removed, if another event is
2383 processed in the middle. By using a Deque's takeFirst, we ensure the
2384 element is removed before we dispatch it.
2386 fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2387 crashes after this fix is added.
2389 * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2390 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2391 (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2394 2013-07-09 Ryuan Choi <ryuan.choi@samsung.com>
2396 [EFL] Add ewk_view_device_pixel_ratio_set
2397 https://bugs.webkit.org/show_bug.cgi?id=118521
2399 Reviewed by Gyuyoung Kim.
2401 * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2403 (parseUserArguments):
2405 2013-07-09 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
2407 Unreviewed change of my email addresses.
2408 https://bugs.webkit.org/show_bug.cgi?id=100122
2410 * Scripts/webkitpy/common/config/contributors.json:
2412 2013-07-09 Anders Carlsson <andersca@apple.com>
2414 DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2415 https://bugs.webkit.org/show_bug.cgi?id=118514
2416 <rdar://problem/13686836>
2418 Reviewed by Sam Weinig.
2420 Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2422 * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2423 * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2424 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2425 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2426 Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2428 * DumpRenderTree/mac/DumpRenderTree.mm:
2429 (allocateGlobalControllers):
2430 Allocate a DefaultPolicyDelegate object.
2432 (resetWebViewToConsistentStateBeforeTesting):
2433 Set the policy delegate to the default policy delegate.
2435 * DumpRenderTree/mac/DumpRenderTreeMac.h:
2436 Declare the defaultPolicyDelegate object.
2438 * DumpRenderTree/mac/TestRunnerMac.mm:
2439 (TestRunner::setCustomPolicyDelegate):
2440 Set the policy delegate to the default delegate if setDelegate is false.
2442 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
2444 KURL unit test fixture class should have a meaningful name
2445 https://bugs.webkit.org/show_bug.cgi?id=118467
2447 Reviewed by Sam Weinig.
2449 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2450 (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2451 instead of the generic and inappropriate 'WebCore' name.
2453 2013-07-08 Antti Koivisto <antti@apple.com>
2455 Add Deque::removeLast
2456 https://bugs.webkit.org/show_bug.cgi?id=118466
2458 Reviewed by Andreas Kling.
2460 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2461 * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2462 (TestWebKitAPI::TEST):
2464 2013-07-08 Brian Holt <brian.holt@samsung.com>
2466 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2467 https://bugs.webkit.org/show_bug.cgi?id=118412
2469 Reviewed by Martin Robinson.
2471 An adoptRef is required to balance ref and deref calls.
2473 * DumpRenderTree/gtk/EventSender.cpp:
2474 (beginDragWithFilesCallback):
2476 2013-07-06 Sergio Correia <sergio.correia@openbossa.org>
2478 Update list of EFL WK2 API tests
2479 https://bugs.webkit.org/show_bug.cgi?id=118443
2481 Reviewed by Christophe Dumez.
2483 The following tests were included:
2486 - CloseThenTerminate
2487 - DidAssociateFormControls
2488 - PageVisibilityState
2489 - ResponsivenessTimerDoesntFireEarly
2494 - ResizeReversePaginatedWebView
2495 - ScrollPinningBehaviors
2497 This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2500 * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2501 * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2503 2013-07-05 Tim Horton <timothy_horton@apple.com>
2505 Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2506 https://bugs.webkit.org/show_bug.cgi?id=118439
2507 <rdar://problem/14366120>
2509 Reviewed by Anders Carlsson.
2511 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2512 (TestWebKitAPI::didLayout):
2513 (TestWebKitAPI::TEST):
2514 - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2515 - Assert that we got the right number of pages for sanity.
2516 - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2517 so much memory that SharedMemory asserts and makes the test time out.
2518 - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2519 because paint doesn't fire if the window is offscreen.
2521 2013-07-05 Tim Horton <timothy_horton@apple.com>
2523 [wk2] Add API to lock the scroll position at the top or bottom of the page
2524 https://bugs.webkit.org/show_bug.cgi?id=118429
2525 <rdar://problem/14120323>
2527 Reviewed by Anders Carlsson.
2529 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2530 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2531 (TestWebKitAPI::didFinishDocumentLoadForFrame):
2532 (TestWebKitAPI::TEST):
2533 Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2534 all work correctly in the face of resizing the view and scrolling from JS.
2536 2013-07-05 Michael Pruett <michael@68k.org>
2538 Unreviewed. Add myself as a committer.
2540 * Scripts/webkitpy/common/config/contributors.json:
2542 2013-07-05 Xabier Rodriguez Calvar <calvaris@igalia.com>
2544 [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2545 https://bugs.webkit.org/show_bug.cgi?id=111434
2547 Reviewed by Carlos Garcia Campos.
2549 * Scripts/run-gtk-tests:
2550 (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2552 2013-07-04 Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
2554 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2555 https://bugs.webkit.org/show_bug.cgi?id=118370
2557 Reviewed by Christophe Dumez.
2559 Add fallback to software X11 engine if opengl_x11 engine creation fails.
2561 * DumpRenderTree/efl/DumpRenderTree.cpp:
2564 2013-07-04 Brian Holt <brian.holt@samsung.com>
2566 [ATK] Leak: AtkAttributeSet* should be freed
2567 https://bugs.webkit.org/show_bug.cgi?id=118307
2569 Reviewed by Christophe Dumez.
2571 Fixed memory leaks for AtkAttributeSet by calling
2572 atk_attribute_set_free().
2574 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2575 (AccessibilityController::childElementById):
2576 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2577 (getAtkAttributeSetAsString):
2578 (AccessibilityUIElement::allAttributes):
2579 (AccessibilityUIElement::stringAttributeValue):
2580 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2581 (WTR::childElementById):
2582 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2583 (WTR::getAtkAttributeSetAsString):
2584 (WTR::AccessibilityUIElement::allAttributes):
2585 (WTR::AccessibilityUIElement::stringAttributeValue):
2587 2013-07-03 David Farler <dfarler@apple.com>
2589 Add Makefile to WebKitLauncher
2590 https://bugs.webkit.org/show_bug.cgi?id=118365
2592 Reviewed by Mark Rowe.
2594 * WebKitLauncher/Makefile: Added.
2596 2013-07-03 Brian Holt <brian.holt@samsung.com>
2598 [ATK] Leak: more leaks in AccessibilityUIElement
2599 https://bugs.webkit.org/show_bug.cgi?id=118362
2601 Reviewed by Christophe Dumez.
2603 Free the memory created by g_strdup_printf.
2605 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2606 (AccessibilityUIElement::language):
2607 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2608 (WTR::AccessibilityUIElement::language):
2610 2013-07-03 Jer Noble <jer.noble@apple.com>
2612 Xcode often gets in a state where the debugger is completely unresponsive
2613 https://bugs.webkit.org/show_bug.cgi?id=118157
2615 The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2616 Rather than pull the character data out of the debugger one byte at a time
2617 through the GetPointeeData() API, retrieve the memory contents of the string through
2618 the ReadMemory() API, and convert the retrieved memory into a python string.
2620 Reviewed by Anders Carlsson.
2622 * lldb/lldb_webkit.py:
2623 (__lldb_init_module.lldb_webkit):
2624 (guess_string_length):
2625 (ustring_to_string):
2626 (lstring_to_string):
2628 2013-07-03 Morten Stenshorne <mstensho@opera.com>
2630 [GTK] Let F5 refresh the page in MiniBrowser
2631 https://bugs.webkit.org/show_bug.cgi?id=117638
2633 Reviewed by Carlos Garcia Campos.
2635 Also use the correct icon for the refresh button that was already there.
2637 * MiniBrowser/gtk/BrowserWindow.c:
2638 (browser_window_init):
2640 2013-07-02 Kondapally Kalyan <kalyan.kondapally@intel.com>
2642 Unreviewed. Add my email to a few watchlists.
2644 * Scripts/webkitpy/common/config/watchlist:
2646 2013-07-02 David Farler <dfarler@apple.com>
2648 Unreviewed. Adding myself to contributors.json.
2650 * Scripts/webkitpy/common/config/contributors.json:
2652 2013-07-02 Brian Holt <brian.holt@samsung.com>
2654 [ATK] Leak: leaks in AccessibilityUIElement
2655 https://bugs.webkit.org/show_bug.cgi?id=118297
2659 Reviewed by Christophe Dumez.
2661 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2662 (AccessibilityUIElement::stringValue):
2664 2013-07-02 Byungwoo Lee <bw80.lee@samsung.com>
2666 Fix WebKitTestRunner crashes.
2667 https://bugs.webkit.org/show_bug.cgi?id=117630
2669 Reviewed by Darin Adler.
2671 Create static function to dump for WebProcess unresponsiveness status,
2672 and use it before calling TestController::runTest().
2674 Accessing TestController::m_currentInvocation before calling
2675 TestController::runTest() can make crash because the invocation
2676 instance will be assigned at the function.
2678 * WebKitTestRunner/TestController.cpp:
2679 (WTR::TestController::run):
2680 * WebKitTestRunner/TestInvocation.cpp:
2681 (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2682 * WebKitTestRunner/TestInvocation.h:
2684 2013-07-02 Allan Sandfeld Jensen <allan.jensen@digia.com>
2686 [Qt][WK1] Support WebGL with EGL on Linux
2687 https://bugs.webkit.org/show_bug.cgi?id=118251
2689 Reviewed by Kenneth Rohde Christiansen.
2691 * qmake/mkspecs/features/features.prf:
2693 2013-07-01 Nick Diego Yamane <nick.yamane@openbossa.org>
2695 [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2696 https://bugs.webkit.org/show_bug.cgi?id=118267
2698 Reviewed by Gyuyoung Kim.
2700 After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2701 WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2702 Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2707 2013-07-01 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
2709 [GTK] Remove unsupported AC backends
2710 https://bugs.webkit.org/show_bug.cgi?id=117362
2712 Reviewed by Martin Robinson.
2714 * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2715 and cogl, so removed.
2717 2013-07-01 Timothy Hatcher <timothy@apple.com>
2719 Link to WebInspectorUI.framework at build time instead of soft linking.
2721 https://bugs.webkit.org/show_bug.cgi?id=118261
2723 Reviewed by Joseph Pecoraro.
2725 * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2727 2013-07-01 Tim Horton <timothy_horton@apple.com>
2729 Maximum scroll position can be negative in some cases
2730 https://bugs.webkit.org/show_bug.cgi?id=118175
2731 <rdar://problem/14301217>
2733 Reviewed by Anders Carlsson.
2735 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2737 (TestWebKitAPI::didRunJavaScript):
2738 (TestWebKitAPI::didLayout):
2739 (TestWebKitAPI::TEST):
2740 * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2741 Add a test that loads a vertical-lr document, paginates it horizontally
2742 from right to left, resizes the view to fit the entire document, and
2743 verifies that the scroll position is negative, as it must be for the
2744 document to be enclosed by the view.
2746 2013-07-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
2748 [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2749 https://bugs.webkit.org/show_bug.cgi?id=117249
2751 Reviewed by Brent Fulgham.
2753 Finish converting all use cases of WEBKITOUTPUTDIR to
2754 WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2756 * DumpRenderTree/efl/FontManagement.cpp:
2757 (getCustomBuildDir):
2758 (getPlatformFontsPath):
2759 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2761 * Scripts/webkitdirs.pm:
2762 (determineBaseProductDir):
2763 (usesPerConfigurationBuildDirectory):
2764 * Scripts/webkitpy/port/base.py:
2765 (Port.to.setup_environ_for_server):
2766 * Scripts/webkitpy/port/driver.py:
2767 (Driver._setup_environ_for_driver):
2768 * Scripts/webkitpy/port/gtk.py:
2769 (GtkPort.setup_environ_for_server):
2770 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2771 (WTR::getOutputDir):
2772 * jhbuild/jhbuildutils.py:
2773 (get_dependencies_path):
2775 2013-07-01 Rafael Brandao <rafael.lobo@webkit.org>
2777 Unreviewed change of my email address.
2779 * Scripts/webkitpy/common/config/contributors.json:
2781 2013-06-28 Andreas Kling <akling@apple.com>
2783 Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2785 * DumpRenderTree/win/DumpRenderTree.cpp:
2786 (addFontFallbackIfPresent):
2787 (removeFontFallbackIfPresent):
2789 2013-06-28 Anders Carlsson <andersca@apple.com>
2791 Remove String::deprecatedCharactersWithNullTermination() and related code
2792 https://bugs.webkit.org/show_bug.cgi?id=118211
2794 Reviewed by Benjamin Poulain.
2796 Remove all hasTerminatingNullCharacter() checks.
2798 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2799 (TestWebKitAPI::TEST):
2800 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2801 (TestWebKitAPI::TEST):
2802 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2803 (TestWebKitAPI::TEST):
2805 2013-06-28 Alexey Proskuryakov <ap@apple.com>
2807 [Mac] Crash when loading is stopped from -didReceiveResponse
2808 https://bugs.webkit.org/show_bug.cgi?id=118209
2809 <rdar://problem/14259249>
2811 Reviewed by Brady Eidson.
2813 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2815 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2816 (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2817 (TestWebKitAPI::TEST):
2819 2013-06-28 Andy Estes <aestes@apple.com>
2821 [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2822 https://bugs.webkit.org/show_bug.cgi?id=118208
2824 Reviewed by Mark Rowe.
2826 Newer versions of clang use a default template depth of 128, but this
2827 is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2830 Clang lowered the default to keep recursive template instantiation
2831 from overflowing the stack (see <rdar://problem/13935016>), but
2832 TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2833 higher limit. If for some reason this starts happening then we can
2834 lower the limit back down.
2836 * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2838 2013-06-28 Nick Diego Yamane <nick.yamane@openbossa.org>
2840 [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2841 https://bugs.webkit.org/show_bug.cgi?id=118195
2843 Reviewed by Daniel Bates.
2845 Currently, ports that use jhbuild fail to determine jhbuild directory
2846 when "webKitBranchBuild" git configuration property is enabled. To reproduce
2847 that issue in Efl port, enable that flag in .git/config, switch to a git branch
2848 other than "master" and try to build webkit. The build will fail to
2849 locate dependencies due to lack of pkg-config paths which should be set
2852 For more details about "webKitBranchBuild" option, see:
2853 https://trac.webkit.org/wiki/UsingGitWithWebKit
2855 * Scripts/webkitdirs.pm:
2858 2013-06-28 Jessie Berlin <jberlin@apple.com>
2860 WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
2861 https://bugs.webkit.org/show_bug.cgi?id=118201
2863 Reviewed by Dean Jackson.
2865 * WebKitTestRunner/mac/main.mm:
2867 Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
2868 setAutomaticDashSubstitutionEnabled are not exposed on WKView.
2870 2013-06-28 David Farler <dfarler@apple.com>
2872 Upstream WebKit Nightly’s WebKitLauncher
2873 https://bugs.webkit.org/show_bug.cgi?id=117418
2875 Reviewed by Mark Rowe.
2877 Literal patch from Nightly's OpenSource repo.
2879 * WebKitLauncher/Configurations/Base.xcconfig:
2880 * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
2881 * WebKitLauncher/Info.plist:
2882 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2883 * WebKitLauncher/WebKitLauncherURLProtocol.m:
2884 (+[WebKitLauncherURLProtocol load]):
2885 (+[WebKitLauncherURLProtocol canInitWithRequest:]):
2886 (-[WebKitLauncherURLProtocol startLoading]):
2887 (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
2888 (-[WebKitLauncherURLProtocol resourceNotFound]):
2889 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2890 (initializeSparkle):
2891 * WebKitLauncher/main.m:
2892 (determineExecutablePath):
2893 (currentMacOSXVersion):
2895 * WebKitLauncher/start.html:
2897 2013-06-28 Balazs Kelemen <b.kelemen@samsung.com>
2899 [EFL] back/forward keyboard shortcuts are non-intuitive
2900 https://bugs.webkit.org/show_bug.cgi?id=118193
2902 Reviewed by Christophe Dumez.
2904 Changed shortcuts for go-back/go-forward to alt+left and alt+right.
2906 * EWebLauncher/main.c:
2908 * MiniBrowser/efl/main.c:
2911 2013-06-28 Roger Fong <roger_fong@apple.com>
2913 Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
2914 https://bugs.webkit.org/show_bug.cgi?id=118194.
2916 Reviewed by Brent Fulgham.
2918 * DumpRenderTree/win/DumpRenderTree.cpp:
2919 (dllLauncherEntryPoint):
2920 * WinLauncher/WinLauncher.cpp:
2921 (dllLauncherEntryPoint):
2923 2013-06-28 Roger Fong <roger_fong@apple.com>
2925 Unreviewed build fix for AppleWin port. Fix some file paths.
2927 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2928 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2930 2013-06-27 Roger Fong <roger_fong@apple.com>
2932 Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
2933 https://bugs.webkit.org/show_bug.cgi?id=118160.
2935 Reviewed by Brent Fulgham.
2937 * WinLauncher/AccessibilityDelegate.cpp: Added.
2938 (AccessibilityDelegate::QueryInterface):
2939 (AccessibilityDelegate::AddRef):
2940 (AccessibilityDelegate::Release):
2941 (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
2942 (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
2943 * WinLauncher/AccessibilityDelegate.h: Added.
2944 (AccessibilityDelegate::AccessibilityDelegate):
2945 * WinLauncher/WinLauncher.cpp:
2946 (dllLauncherEntryPoint):
2947 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2948 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2950 2013-06-28 Christophe Dumez <ch.dumez@sisa.samsung.com>
2952 Clean up temporary files created by the bindings test script
2953 https://bugs.webkit.org/show_bug.cgi?id=118189
2955 Reviewed by Kentaro Hara.
2957 Remove temporary files created by preprocess-idls.pl script after
2958 the bindings tests are executed.
2960 Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
2962 * Scripts/webkitpy/bindings/main.py:
2963 (BindingsTests.main):
2965 2013-06-26 Dean Jackson <dino@apple.com>
2967 [Mac] Add Mavericks system font to Test systems
2968 https://bugs.webkit.org/show_bug.cgi?id=118109
2970 Reviewed by Simon Fraser.
2972 OS X Mavericks uses a different font for system controls. Tell DRT and
2973 WKTR about them otherwise they use a fallback font. Unfortunately the
2974 fonts are hidden (not found in the list of available fonts) so I
2975 had to add them manually.
2977 Even though there is only one at the moment, I implemented this
2978 as a set so it will be easier to add new fonts if necessary.
2980 * DumpRenderTree/mac/DumpRenderTree.mm:
2981 (allowedFontFamilySet): Fixed typo.
2982 (systemHiddenFontFamilySet): New method that returns the system control font.
2983 (drt_NSFontManager_availableFonts): Merge the hidden fonts.
2984 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2985 (WTR::allowedFontFamilySet): Fixed typo.
2986 (WTR::systemHiddenFontFamilySet): As above.
2987 (WTR::wtr_NSFontManager_availableFonts):
2989 2013-06-27 Anders Carlsson <andersca@apple.com>
2991 Get rid of the last uses of deprecatedCharactersWithNullTermination()
2992 https://bugs.webkit.org/show_bug.cgi?id=118159
2994 Reviewed by Andreas Kling.
2996 Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
2998 * DumpRenderTree/win/DumpRenderTree.cpp:
3001 2013-06-27 Bem Jones-Bey <bjonesbe@adobe.com>
3003 Sync up w3c import script with changes in Blink
3004 https://bugs.webkit.org/show_bug.cgi?id=118149
3006 Reviewed by Dirk Pranke.
3008 This is a port of the following blink changes:
3010 https://codereview.chromium.org/15366004
3011 https://chromiumcodereview.appspot.com/15592005
3012 https://codereview.chromium.org/16021006
3013 https://codereview.chromium.org/15590004
3014 https://codereview.chromium.org/15901008
3015 https://codereview.chromium.org/16171009
3016 https://codereview.chromium.org/16465007
3017 https://codereview.chromium.org/15981013
3019 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3021 (test_commit_message_for_this_commit):
3022 * Scripts/webkitpy/port/base.py:
3024 * Scripts/webkitpy/port/test.py:
3025 * Scripts/webkitpy/w3c/test_converter.py:
3026 (W3CTestConverter.__init__):
3027 (W3CTestConverter.read_webkit_prefixed_css_property_list):
3028 (W3CTestConverter.convert_for_webkit):
3029 (W3CTestConverter.convert_css):
3030 (W3CTestConverter.convert_html):
3031 (W3CTestConverter.convert_testharness_paths):
3032 (W3CTestConverter.convert_prefixed_properties):
3033 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3034 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3035 * Scripts/webkitpy/w3c/test_importer.py:
3037 (configure_logging):
3038 (configure_logging.LogHandler):
3039 (configure_logging.LogHandler.format):
3041 (TestImporter.__init__):
3042 (TestImporter.find_importable_tests):
3043 (TestImporter.import_tests):
3044 (TestImporter.setup_destination_directory):
3045 (TestImporter.remove_deleted_files):
3046 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3047 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3048 (TestImporterTest.test_import_dir_with_no_tests):
3050 * Scripts/webkitpy/w3c/test_parser.py:
3051 (TestParser.load_file):
3052 (TestParser.analyze_test):
3053 (TestParser.support_files):
3054 * Scripts/webkitpy/w3c/test_parser_unittest.py:
3056 2013-06-27 Csaba Osztrogonác <ossy@webkit.org>
3058 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3059 https://bugs.webkit.org/show_bug.cgi?id=118128
3061 Reviewed by Ryosuke Niwa.
3063 It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3064 https://bugs.webkit.org/show_bug.cgi?id=117831
3066 * Scripts/webkitpy/tool/commands/download.py:
3067 (AbstractPatchSequencingCommand):
3068 (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3069 (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3070 (AbstractPatchSequencingCommand._prepare_state): Added.
3072 2013-06-27 Brendan Long <b.long@cablelabs.com>
3074 [Qt] Build overrides -j when given --makeargs="-sj40"
3075 https://bugs.webkit.org/show_bug.cgi?id=116897
3077 Reviewed by Csaba Osztrogonác.
3079 * Scripts/webkitdirs.pm:
3080 (buildQMakeProjects):
3081 Change regex checking for -j* to also check for -*j*
3083 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3085 Remove [NoInterfaceObject] from WorkerGlobalScope
3086 https://bugs.webkit.org/show_bug.cgi?id=118071
3088 Reviewed by Kentaro Hara.
3090 Update bindings test script to pass 2 additional parameters
3091 now needed by the preprocess-idls.pl script.
3093 * Scripts/webkitpy/bindings/main.py:
3094 (BindingsTests.generate_supplemental_dependency):
3095 (BindingsTests.main):
3097 2013-06-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
3099 Fixing some compiler warnings
3100 https://bugs.webkit.org/show_bug.cgi?id=117791
3102 Reviewed by Martin Robinson.
3104 * GNUmakefile.am: Silenced format warning.
3105 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3106 (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3107 Solved warning about uninitialized variable.
3109 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3111 Fix bindings tests after r152080
3112 https://bugs.webkit.org/show_bug.cgi?id=118118
3114 Reviewed by Gyuyoung Kim.
3116 r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3117 to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3120 * Scripts/webkitpy/bindings/main.py:
3121 (BindingsTests.generate_supplemental_dependency):
3122 (BindingsTests.main):
3124 2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
3126 [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3127 https://bugs.webkit.org/show_bug.cgi?id=117982
3129 Reviewed by Rob Buis.
3131 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3132 (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3133 m_policyDelegateIsPermissive.
3134 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3135 Reset m_policyDelegateIsPermissive.
3136 (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3137 m_policyDelegateIsPermissive.
3138 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3139 (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3140 Return whether custom policy is enabled.
3141 (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3142 Return whether custom policy is permissive.
3144 2013-06-26 Anders Carlsson <andersca@apple.com>
3146 Deprecate StringImpl::charactersWithNullTermination
3147 https://bugs.webkit.org/show_bug.cgi?id=118108
3149 Reviewed by Beth Dakin.
3151 Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3153 * DumpRenderTree/win/DumpRenderTree.cpp:
3155 (addFontFallbackIfPresent):
3156 (removeFontFallbackIfPresent):
3158 2013-06-26 Nico Weber <thakis@chromium.org>
3160 Remove detect-mismached-virtual-const.
3161 https://bugs.webkit.org/show_bug.cgi?id=117999
3163 Reviewed by Anders Carlsson.
3165 Clang warns on mismatched virtual const, so there's no need for this
3168 * Scripts/detect-mismatched-virtual-const: Removed.
3170 2013-06-26 Alex Christensen <achristensen@apple.com>
3172 Added a code coverage report.
3173 https://bugs.webkit.org/show_bug.cgi?id=117941
3175 Reviewed by Joseph Pecoraro.
3177 * CodeCoverage: Added.
3178 * CodeCoverage/results-template.html: Added.
3179 * Scripts/generate-coverage-data: Generate and open the new report.
3181 2013-06-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3183 gdb: Remove the webcore.py pretty printer.
3184 https://bugs.webkit.org/show_bug.cgi?id=117992
3186 Reviewed by Jochen Eisinger.
3188 webcore.py has been only a placeholder for backwards compatibility
3189 for almost 3 years. It should be safe enough to remove it now.
3191 * gdb/webcore.py: Removed.
3193 2013-05-26 Peter Gal <galpeter@inf.u-szeged.hu>
3195 Creating cURL watchlist and adding myself to it.
3197 Reviewed by Csaba Osztrogonác.
3199 * Scripts/webkitpy/common/config/watchlist:
3201 2013-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3203 Unreviewed, change my email address for watch list.
3205 * Scripts/webkitpy/common/config/watchlist:
3207 2013-06-25 Byungwoo Lee <bw80.lee@samsung.com>
3209 [EFL] Add a script to install dependencies.
3210 https://bugs.webkit.org/show_bug.cgi?id=117968
3212 Reviewed by Christophe Dumez.
3214 Add a script which installs basic dependencies for building WebKit EFL.
3216 The dependencies are from the current EFLWebKit wiki page.
3217 After this patch is landed, the wiki page will be updated to use
3220 * efl/install-dependencies: Added.
3222 2013-06-24 Dean Jackson <dino@apple.com>
3224 [Mac] Update font used for Chinese in test systems
3225 https://bugs.webkit.org/show_bug.cgi?id=117970
3227 Reviewed by Alexey Proskuryakov.
3229 Add "Songti TC" and "Songti SC" to the list of allowed fonts
3232 * DumpRenderTree/mac/DumpRenderTree.mm:
3233 (allowedFontFamilySet):
3234 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3235 (WTR::allowedFontFamilySet):
3237 2013-06-24 Tim Horton <timothy_horton@apple.com>
3239 Make MiniBrowser paginated mode work with WebKit1
3240 https://bugs.webkit.org/show_bug.cgi?id=117950
3242 Reviewed by Beth Dakin.
3244 * MiniBrowser/mac/WK1BrowserWindowController.m:
3245 (-[WK1BrowserWindowController isPaginated]):
3246 (-[WK1BrowserWindowController togglePaginationMode:]):
3247 Hook up isPaginated and togglePaginationMode just as for WebKit2.
3249 2013-06-24 David Kilzer <ddkilzer@apple.com>
3251 bisect-builds: improve heuristic for choosing the next build after a broken build
3252 <http://webkit.org/b/117918>
3254 Reviewed by Simon Fraser.
3256 * Scripts/bisect-builds: When a build is broken, use a heuristic
3257 that "bisects" the left side or the right side of the remaining
3258 revisions to pick a revision that's sufficiently different from
3259 the revision of the broken build. This heuristic assumes there
3260 is a sequential range of broken builds whenever one broken build
3263 2013-06-24 Chris Rogers <crogers@google.com>
3265 WaveTable name has changed to PeriodicWave
3266 https://bugs.webkit.org/show_bug.cgi?id=117748
3268 Reviewed by Jer Noble.
3270 * Scripts/do-webcore-rename:
3272 2013-06-22 Santosh Mahto <santosh.ma@samsung.com>
3274 [EFL] Add support for MHTML save/load feature to MiniBrowser
3275 https://bugs.webkit.org/show_bug.cgi?id=106620
3277 Reviewed by Christophe Dumez.
3279 Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3282 * MiniBrowser/efl/CMakeLists.txt:
3283 * MiniBrowser/efl/main.c:
3284 (page_contents_callback):
3286 (show_file_entry_dialog): generic function to show file enrty
3289 2013-06-21 Brent Fulgham <bfulgham@apple.com>
3291 [Windows] Unreviewed crash protection for DRT
3293 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3294 to avoid crashing during test runs.
3296 2013-06-21 Christophe Dumez <ch.dumez@sisa.samsung.com>
3298 REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3299 https://bugs.webkit.org/show_bug.cgi?id=117825
3301 Reviewed by Kentaro Hara.
3303 DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3305 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3306 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3307 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3308 (TestRunner::overridePreference):
3310 2013-06-21 Krzysztof Czech <k.czech@samsung.com>
3312 [ATK] Added support for aria-required attribute.
3313 https://bugs.webkit.org/show_bug.cgi?id=117730
3315 Reviewed by Chris Fleizach.
3317 Added support for testing aria-required attribute.
3319 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3320 (AccessibilityUIElement::isRequired):
3321 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3322 (WTR::AccessibilityUIElement::isRequired):
3324 2013-06-20 Ryuan Choi <ryuan.choi@samsung.com>
3326 [CMAKE][EFL] Enable DOM4 Events Constructor
3327 https://bugs.webkit.org/show_bug.cgi?id=117858
3329 Reviewed by Laszlo Gombos.
3331 * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3333 2013-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
3335 [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3336 https://bugs.webkit.org/show_bug.cgi?id=117827
3338 Reviewed by Rob Buis.
3340 Reset the passed in request if willSendRequestReturnsNull() is
3341 true or willSendRequestReturnsNullOnRedirect() is true and it's a
3344 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3345 (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3346 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3348 2013-06-20 Csaba Osztrogonác <ossy@webkit.org>
3350 Commit queue shouldn't reopen unrelated bugs because of flakiness
3351 https://bugs.webkit.org/show_bug.cgi?id=117503
3353 Reviewed by Ryosuke Niwa.
3355 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3356 (_follow_duplicate_chain):
3357 (_update_bug_for_flaky_test):
3359 2013-06-19 Brent Fulgham <bfulgham@apple.com>
3361 [Windows] AX: Expand notification support.
3362 https://bugs.webkit.org/show_bug.cgi?id=117761
3364 Reviewed by Anders Carlsson.
3366 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3367 (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3368 (AccessibilityUIElement::press): Provide implementation.
3370 2013-06-19 Benjamin Poulain <bpoulain@apple.com>
3372 Use the PlatformEvent timestamp when creating a DOM Event
3373 https://bugs.webkit.org/show_bug.cgi?id=117179
3375 Reviewed by Darin Adler.
3377 * WebKitTestRunner/mac/EventSenderProxy.mm:
3378 (WTR::EventSenderProxy::mouseDown):
3379 (WTR::EventSenderProxy::mouseUp):
3380 (WTR::EventSenderProxy::mouseMoveTo):
3381 (WTR::EventSenderProxy::keyDown):
3383 2013-06-18 Alex Christensen <achristensen@apple.com>
3385 Working on coverage script, added xml to json data extraction script.
3386 https://bugs.webkit.org/show_bug.cgi?id=117648
3388 This is part of a new test code coverage analysis tool. This compiles WebKit to generate
3389 coverage data, runs the tests, and collects all of the data in json format.
3391 Reviewed by Stephanie Lewis.
3393 * Scripts/generate-coverage-data:
3395 (getFileHitsAndBranches):
3398 * Scripts/webkitpy/tool/gcovr: Added.
3400 2013-06-18 Ryuan Choi <ryuan.choi@samsung.com>
3402 Unreviewed build fix after r151699.
3404 * TestWebKitAPI/CMakeLists.txt:
3405 * WebKitTestRunner/CMakeLists.txt:
3406 Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3408 2013-06-18 Roger Fong <roger_fong@apple.com>
3410 Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3411 <rdar://problem/14118143>.
3413 Rubberstamped by Brent Fulgham.
3415 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3416 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3417 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3418 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3419 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3420 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3421 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3422 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3423 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3424 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3425 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3426 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3427 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3428 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3429 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3430 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3431 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3432 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3433 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3434 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3435 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3436 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3437 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3438 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3439 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3440 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3441 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3442 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3443 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3444 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3445 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3446 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3447 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3448 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3449 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3450 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3451 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3452 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3453 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3454 * win/record-memory/record-memory.vcxproj:
3455 * win/record-memory/record-memoryDebug.props:
3456 * win/record-memory/record-memoryDebugWinCairo.props:
3457 * win/record-memory/record-memoryProduction.props:
3458 * win/record-memory/record-memoryRelease.props:
3459 * win/record-memory/record-memoryReleaseWinCairo.props:
3461 2013-06-17 Kangil Han <kangil.han@samsung.com>
3463 Unreviewed. Add my email to a DOM watchlist.
3465 * Scripts/webkitpy/common/config/watchlist:
3467 2013-06-17 Zan Dobersek <zdobersek@igalia.com>
3469 Unreviewed GTK gardening.
3471 * Scripts/run-gtk-tests:
3472 (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3474 2013-06-15 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
3476 Unreviewed. Reorder my email addresses.
3477 https://bugs.webkit.org/show_bug.cgi?id=100122
3479 * Scripts/webkitpy/common/config/contributors.json:
3481 2013-06-14 Enrica Casucci <enrica@apple.com>
3483 WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3484 https://bugs.webkit.org/show_bug.cgi?id=117647
3485 <rdar://problem/13881024>
3487 Reviewed by Darin Adler.
3489 The test now uses content with a selection and tests both
3490 forwards and backward find as well as the case of a find
3491 that has no matches after the user selection.
3493 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3494 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3495 (TestWebKitAPI::didFindStringMatches):
3496 * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3498 2013-06-14 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
3500 Remove myself from Qt build system watchlist
3502 Reviewed by Simon Hausmann.
3504 * Scripts/webkitpy/common/config/watchlist:
3506 2013-06-13 Michael Brüning <michael.bruning@digia.com>
3508 [Qt][Mac] Disable QTKit video on OS X.
3509 https://bugs.webkit.org/show_bug.cgi?id=117591
3511 Reviewed by Tor Arne Vestbø.
3513 Deployment of Qt binaries to different Mac OS X
3514 platform version makes it impossible to link against
3515 the correct version of the WebKitSystemInterface library,
3516 so we need to disable QTKit for media elements.
3518 * qmake/mkspecs/features/features.prf:
3520 2013-06-13 Michał Pakuła vel Rutka <m.pakula@samsung.com>
3522 [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3523 https://bugs.webkit.org/show_bug.cgi?id=116610
3525 Reviewed by Noam Rosenthal.
3527 Remove unnecessary code adjusting context menu position to webview position.
3528 Now position is calculcated in EwkView.
3530 * MiniBrowser/efl/main.c:
3531 (on_context_menu_show):
3533 2013-06-12 Roger Fong <roger_fong@apple.com>
3535 Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3537 * Scripts/webkitpy/common/config/ews.json:
3539 2013-06-12 Eduardo Lima Mitev <elima@igalia.com>
3541 [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3542 https://bugs.webkit.org/show_bug.cgi?id=115647
3544 Reviewed by Martin Robinson.
3546 Locale resolution is moved to WebKitAccessibleWrapperAtk using
3547 AtkObject::get_object_locale() API. Now, implementation of
3548 AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3549 be leveraged to get_object_locale() of AtkObject.
3551 Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3554 No new functionality, no new tests.
3556 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3557 (AccessibilityUIElement::language): Leverage locale resolution to
3558 AtkObject::get_object_locale().
3559 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3560 (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3561 AtkObject::get_object_locale().
3563 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3565 Remove last bits of GYP from build-webkit and update-webkit scripts
3566 https://bugs.webkit.org/show_bug.cgi?id=117557
3568 Reviewed by Ryosuke Niwa.
3570 * Scripts/build-webkit:
3571 * Scripts/update-webkit:
3573 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3575 Remove forgotten unused Tools/Script/make-gypi script
3576 https://bugs.webkit.org/show_bug.cgi?id=117558
3578 Reviewed by Ryosuke Niwa.
3580 This script isn't used since the GYP removal from WebKit.
3582 * Scripts/make-gypi: Removed.
3584 2013-06-12 Andres Gomez <agomez@igalia.com>
3586 [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3587 https://bugs.webkit.org/show_bug.cgi?id=117533
3589 Reviewed by Carlos Garcia Campos.
3591 MiniBrowser now starts automatically the download of the documents
3592 that cannot be shown just by WebKit itself on link left clicking.
3594 * MiniBrowser/gtk/BrowserWindow.c:
3595 (webViewDecidePolicy): handled the
3596 WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3598 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
3600 [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3601 https://bugs.webkit.org/show_bug.cgi?id=116723
3603 Reviewed by Carlos Garcia Campos.
3605 * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3606 remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3607 and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3608 not expensive and produces a working archive without problems even on incremental builds.
3610 2013-06-11 Santosh Mahto <santosh.ma@samsung.com>
3612 [EFL] Window resize should close the popupmenu
3613 https://bugs.webkit.org/show_bug.cgi?id=117391
3615 Reviewed by Christophe Dumez.
3617 Added the code to close the popup when main window is resized.
3619 * MiniBrowser/efl/main.c:
3622 2013-06-11 Alex Christensen <achristensen@apple.com>
3624 Removed old broken code coverage tool.
3625 https://bugs.webkit.org/show_bug.cgi?id=117520
3627 Reviewed by Sam Weinig.
3629 * CodeCoverage: Removed.
3630 * CodeCoverage/README: Removed.
3631 * CodeCoverage/amber.png: Removed.
3632 * CodeCoverage/cov.py: Removed.
3633 * CodeCoverage/emerald.png: Removed.
3634 * CodeCoverage/gcov.css: Removed.
3635 * CodeCoverage/glass.png: Removed.
3636 * CodeCoverage/regenerate-coverage-display: Removed.
3637 * CodeCoverage/ruby.png: Removed.
3638 * CodeCoverage/run-generate-coverage-data: Removed.
3639 * CodeCoverage/snow.png: Removed.
3641 2013-06-11 Timothy Hatcher <timothy@apple.com>
3643 Have build-webkit build the WebInspectorUI project.
3645 * Scripts/build-webkit:
3647 2013-06-11 Ryosuke Niwa <rniwa@webkit.org>
3649 Add an option to run-webkit-tests to skip java dependency check
3650 https://bugs.webkit.org/show_bug.cgi?id=117516
3652 Reviewed by Andreas Kling.
3654 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3656 * Scripts/webkitpy/port/mac.py:
3657 (MacPort._check_port_build):
3659 2013-06-11 Alex Christensen <achristensen@apple.com>
3661 https://bugs.webkit.org/show_bug.cgi?id=117514
3662 Removed extra Xcode code coverage flags.
3664 Reviewed by Sam Weinig.