Build fix after r188982
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2
3         Build fix after r188982
4
5         * MiniBrowser/win/CMakeLists.txt:
6         Find .rc files in correct directory.
7
8 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
9
10         [EFL] Bump cairo version to 1.14.2
11         https://bugs.webkit.org/show_bug.cgi?id=148474
12
13         Reviewed by Csaba Osztrogonác.
14
15         * efl/jhbuild.modules:
16
17 2015-08-26  Andy Estes  <aestes@apple.com>
18
19         Crash when following a Google search link to Twitter with Limit Adult Content enabled
20         https://bugs.webkit.org/show_bug.cgi?id=147651
21
22         Rubber-stamped by Brady Eidson.
23
24         Taught TestRunner how to decide the navigation policy after a delay.
25
26         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
27         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
28         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
29         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
30         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
31         * WebKitTestRunner/InjectedBundle/TestRunner.h:
32         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::TestController::initialize):
35         (WTR::TestController::resetStateToConsistentValues):
36         (WTR::TestController::decidePolicyForNavigationAction):
37         * WebKitTestRunner/TestController.h:
38         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
39         * WebKitTestRunner/TestInvocation.cpp:
40         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
41
42 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
43
44         [Win] Rename 'WinLauncher' to 'MiniBrowser'
45         https://bugs.webkit.org/show_bug.cgi?id=148485
46
47         Reviewed by Alex Christensen
48
49         Move the WinLauncher project and source files to a subdirectory
50         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
51         source code and project files.
52         
53         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
54         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
55         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
56         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
57         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
58         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
59         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
60         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
61         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
62         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
63         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
64         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
65         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
66         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
67         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
68         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
69         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
70         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
71         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
72         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
73         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
74         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
75         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
76         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
77         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
78         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
79         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
80         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
81         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
82         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
83         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
84         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
85         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
86         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
87         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
88         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
89         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
90         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
91         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
92         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
93         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
94         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
95         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
96         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
97         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
98         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
99         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
100         * MiniBrowser/win: Copied from WinLauncher.
101         * MiniBrowser/win/Common.cpp:
102         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
103         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
104         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
105         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
106         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
107         * MiniBrowser/win/PageLoadTestClient.cpp:
108         * MiniBrowser/win/PageLoadTestClient.h:
109         * MiniBrowser/win/ResourceLoadDelegate.cpp:
110         * MiniBrowser/win/ResourceLoadDelegate.h:
111         * MiniBrowser/win/WinLauncher.cpp: Removed.
112         * MiniBrowser/win/WinLauncher.h: Removed.
113         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
121         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
122         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
123         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
124         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
125         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
126         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
127         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
128         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
129         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
130         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
131         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
132         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
133         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
134         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
135         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
136         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
137         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
138         * MiniBrowser/win/WinLauncherReplace.h: Removed.
139         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
140         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
141         * MiniBrowser/win/WinMain.cpp:
142         * WinLauncher: Removed.
143         * WinLauncher/AccessibilityDelegate.cpp: Removed.
144         * WinLauncher/AccessibilityDelegate.h: Removed.
145         * WinLauncher/CMakeLists.txt: Removed.
146         * WinLauncher/Common.cpp: Removed.
147         * WinLauncher/DOMDefaultImpl.cpp: Removed.
148         * WinLauncher/DOMDefaultImpl.h: Removed.
149         * WinLauncher/PageLoadTestClient.cpp: Removed.
150         * WinLauncher/PageLoadTestClient.h: Removed.
151         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
152         * WinLauncher/PrintWebUIDelegate.h: Removed.
153         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
154         * WinLauncher/ResourceLoadDelegate.h: Removed.
155         * WinLauncher/WebDownloadDelegate.cpp: Removed.
156         * WinLauncher/WebDownloadDelegate.h: Removed.
157         * WinLauncher/WinLauncher.cpp: Removed.
158         * WinLauncher/WinLauncher.h: Removed.
159         * WinLauncher/WinLauncher.vcxproj: Removed.
160         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
161         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
162         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
163         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
164         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
165         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
166         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
167         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
168         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
170         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
171         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
172         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
173         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
174         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
175         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
176         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
177         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
178         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
179         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
180         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
181         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
182         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
183         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
184         * WinLauncher/WinLauncherReplace.h: Removed.
185         * WinLauncher/WinLauncherWebHost.cpp: Removed.
186         * WinLauncher/WinLauncherWebHost.h: Removed.
187         * WinLauncher/WinMain.cpp: Removed.
188         * WinLauncher/resource.h: Removed.
189         * WinLauncher/stdafx.cpp: Removed.
190         * WinLauncher/stdafx.h: Removed.
191         * win/AssembleBuildLogs/AssembleLogs.cmd:
192
193 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
194
195         [Win] Simplify menu handling code in WinLauncher
196         https://bugs.webkit.org/show_bug.cgi?id=148461
197
198         Reviewed by Zalan Bujtas.
199
200         Revise 'ToggleMenuItem' to return a boolean value indicating if
201         it handled the message. Revise WndProc to use this to decide if it
202         should pass the message on to the default handler, rather than
203         duplicating the logic in both places.
204         
205         * WinLauncher/Common.cpp:
206         (ToggleMenuItem): Return true if the menu item message was handled.
207         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
208         the message tothe default handler.
209
210 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
211
212         Remove unused code after r188948
213         https://bugs.webkit.org/show_bug.cgi?id=148467
214
215         Reviewed by Gyuyoung Kim.
216
217         * WebKitTestRunner/TestController.cpp:
218         (WTR::TestController::platformPreferences): Deleted.
219
220 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
221
222         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
223         https://bugs.webkit.org/show_bug.cgi?id=148377
224
225         Reviewed by Carlos Garcia Campos.
226
227         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
228         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
229         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
230         EFL and GTK at the moment.
231
232         * WebKitTestRunner/TestController.cpp:
233         (WTR::TestController::platformWillRunTest):
234         * WebKitTestRunner/efl/TestControllerEfl.cpp:
235         (WTR::TestController::platformPreferences):
236         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
237         (WTR::TestController::platformPreferences):
238
239 2015-08-25  Nan Wang  <n_wang@apple.com>
240
241         AX: Enable accessibility/aria-controls.html test for mac
242         https://bugs.webkit.org/show_bug.cgi?id=148458
243
244         Reviewed by Chris Fleizach.
245
246         Implemented ariaControlsElementAtIndex(unsigned index).
247
248         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
249         (AccessibilityUIElement::ariaControlsElementAtIndex):
250         (AccessibilityUIElement::disclosedRowAtIndex):
251         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
252         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
253
254 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
255
256         Remove python tests for PassRefPtr 
257         https://bugs.webkit.org/show_bug.cgi?id=148463
258
259         Reviewed by Andy Estes.
260
261         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
262
263         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
264         (PassPtrTest): Deleted.
265         (PassPtrTest.assert_pass_ptr_check): Deleted.
266         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
267         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
268         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
269         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
270         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
271         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
272
273 2015-08-25  Andy Estes  <aestes@apple.com>
274
275         [iOS] run-webkit-tests fails if watchOS SDK is installed
276         https://bugs.webkit.org/show_bug.cgi?id=148453
277
278         Reviewed by David Kilzer.
279
280         * Scripts/webkitpy/xcode/simulator.py:
281         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
282         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
283
284 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
285
286         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
287         https://bugs.webkit.org/show_bug.cgi?id=148197
288         rdar://problem/22334382
289
290         Reviewed by Daniel Bates.
291
292         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
293         * Scripts/webkitpy/port/ios.py:
294         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
295         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
296         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
297         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
298         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
299
300 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
301
302         Remove PassRefPtr style check rule
303         https://bugs.webkit.org/show_bug.cgi?id=148432
304
305         Reviewed by Andreas Kling.
306
307         PassRefPtr is being removed. Thus style rule needs to be removed as well.
308
309         * Scripts/webkitpy/style/checkers/cpp.py:
310         (_check_parameter_name_against_text): Deleted.
311         (check_function_definition_and_pass_ptr): Deleted.
312         (check_function_definition): Deleted.
313         (check_pass_ptr_usage): Deleted.
314         (process_line): Deleted.
315         (CppChecker): Deleted.
316
317 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
318
319         [Win] Expose "Inverted Colors" option in WinLauncher
320         https://bugs.webkit.org/show_bug.cgi?id=148451
321
322         Reviewed by Tim Horton.
323
324         Add the ability to toggle the "Inverted Colors" preference
325         in WinLauncher.
326         
327         * WinLauncher/Common.cpp:
328         (ToggleMenuItem): Toggle the feature when the menu item
329         is selected.
330         (WndProc): Recognize the new menu option.
331         * WinLauncher/WinLauncher.cpp:
332         (WinLauncher::setToDefaultPreferences): Launch with "Invert
333         Colors" turned off.
334         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
335         entry for "Invert Colors".
336         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
337
338 2015-08-25  Nan Wang  <n_wang@apple.com>
339
340         [Mac] accessibility/document-attributes.html fails
341         https://bugs.webkit.org/show_bug.cgi?id=116636
342
343         Reviewed by Chris Fleizach.
344
345         Implemented documentURI() and documentEncoding().
346
347         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
348         (AccessibilityUIElement::documentEncoding):
349         (AccessibilityUIElement::documentURI):
350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
351         (WTR::AccessibilityUIElement::documentEncoding):
352         (WTR::AccessibilityUIElement::documentURI):
353
354 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
355
356         [Win] Unreviewed test gardening.
357
358         Fix another case where the logging string is constructed using the variable 'frame',
359         but the method argument is not given a name. This causes the global 'frame' value to
360         be used, producing incorrect output.
361
362         * DumpRenderTree/win/FrameLoadDelegate.cpp:
363         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
364         argument.
365
366 2015-08-24  Tim Horton  <timothy_horton@apple.com>
367
368         (Finally...) get rid of WKViewIOS
369         https://bugs.webkit.org/show_bug.cgi?id=148404
370
371         Reviewed by Anders Carlsson.
372
373         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
374         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
375         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
376         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
377         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
378         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
379         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
380         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
381         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
382         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
383         Mark tests that use WKBrowsingContextController as Mac-only.
384
385         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
386         (WTR::AccessibilityController::addNotificationListener):
387         * WebKitTestRunner/ios/mainIOS.mm:
388         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
389         Import UIKit instead of depending on WKView.h to do so.
390
391 2015-08-24  Jason Marcell  <jmarcell@apple.com>
392
393         Add support to dashboard for displaying Git SHA's as revisions.
394         https://bugs.webkit.org/show_bug.cgi?id=148387
395
396         Reviewed by Daniel Bates.
397
398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
399         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
401         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
403         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
404
405 2015-08-24  Andy Estes  <aestes@apple.com>
406
407         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
408
409         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
410
411 2015-08-23  Andy Estes  <aestes@apple.com>
412
413         Addressed a missed piece of review feedback from r188851.
414
415         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
416
417 2015-08-23  Andy Estes  <aestes@apple.com>
418
419         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
420         https://bugs.webkit.org/show_bug.cgi?id=147872
421         rdar://problem/22044000
422
423         Reviewed by Dan Bernstein.
424         
425         Added an API test.
426
427         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
429         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
430         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
431         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
432         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
433         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
434         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
435         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
436         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
437         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
438
439 2015-08-23  Andy Estes  <aestes@apple.com>
440
441         Fixed the 32-bit Mac build after r188844.
442
443         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
444         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
445
446 2015-08-22  Andy Estes  <aestes@apple.com>
447
448         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
449         https://bugs.webkit.org/show_bug.cgi?id=148317
450
451         Reviewed by Dan Bernstein.
452
453         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
454         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
455         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
456         when creating WKWebViews.
457
458         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
459         added a new API test for bundle parameters.
460
461         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
462         named its executable TestWebKitAPI.bundle.
463         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
465         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
466         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
467         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
468         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
469         bundle parameter and asked for an initial notification.
470         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
471         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
472         mirror its value in the main frame's JSContext.
473         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
474         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
475         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
476         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
477         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
478         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
479         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
480         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
481         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
482         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
483
484 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
485
486         URTBF after r188828.
487
488         * WebKitTestRunner/PlatformWebView.h:
489
490 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
491
492         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
493         https://bugs.webkit.org/show_bug.cgi?id=148356
494
495         Reviewed by Darin Adler.
496
497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
498         (BuildbotCombinedQueueView.prototype.update):
499
500 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
501
502         build.webkit.org/dashboard: Respect step's hidden flag
503         https://bugs.webkit.org/show_bug.cgi?id=148357
504
505         Reviewed by Darin Adler.
506
507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
508         (BuildbotIteration.prototype._parseData):
509
510 2015-08-23  Nan Wang  <n_wang@apple.com>
511
512         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
513         https://bugs.webkit.org/show_bug.cgi?id=148328
514
515         Reviewed by Darin Adler.
516
517         We should only expose stringValue() when value attribute is set.
518
519         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
520         (AccessibilityUIElement::stringValue):
521         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
522         (WTR::AccessibilityUIElement::stringValue):
523
524 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
525
526         Remove style checking rule regarding OwnPtr and PassOwnPtr
527         https://bugs.webkit.org/show_bug.cgi?id=148360
528
529         Reviewed by Darin Adler.
530
531         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
532         Removed it.
533
534         * Scripts/do-webcore-rename:
535         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
536         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
537         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
538         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
539         (WebKitStyleTest.test_names): Deleted.
540
541 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
542
543         WebKitTestRunner should use WKWebView on OS X and iOS
544         https://bugs.webkit.org/show_bug.cgi?id=143743
545         <rdar://problem/16947123>
546
547         Reviewed by Anders Carlsson.
548         Patch by Enrica Casucci and myself.
549
550         * WebKitTestRunner/PlatformWebView.h:
551         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
552         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
553         instead of WKContext and WKPageGroup.
554
555         Remove the unused, always-true windowSnapshotEnabled().
556         While technically some platforms don't have window snapshotting,
557         they just return null instead of implementing windowSnapshotEnabled().
558
559         * WebKitTestRunner/TestController.h:
560         * WebKitTestRunner/TestController.cpp:
561         (WTR::TestController::createOtherPage):
562         (WTR::TestController::initialize):
563         (WTR::TestController::createWebViewWithOptions):
564         Delegate to the various platforms for creating PlatformWebView instances,
565         for creating WKContexts, and for accessing WKPreferences,
566         so that they can do special things (like, use WKWebView instead!).
567
568         (WTR::TestController::resetPreferencesToConsistentValues):
569         Make explicit WebKitTestRunner's desired default for two preferences
570         which have differing defaults between the antique and modern API,
571         for consistency's sake.
572
573         (WTR::TestController::resetStateToConsistentValues):
574         Add platformResetStateToConsistentValues.
575
576         * WebKitTestRunner/TestInvocation.cpp:
577         (WTR::TestInvocation::dumpResults):
578         Adjust to the aforementioned removal of windowSnapshotEnabled().
579
580         * WebKitTestRunner/ios/TestControllerCocoa.mm:
581         (WTR::TestController::platformResetStateToConsistentValues):
582         (WTR::TestController::platformPreferences):
583         (WTR::TestController::platformCreateWebView):
584         (WTR::TestController::platformCreateOtherPage):
585         (WTR::TestController::platformInitializeConfiguration):
586         Implement the new platform functions for the Modern WebKit2 API,
587         in a new TestControllerCocoa file that is shared between iOS and Mac.
588         
589         For platformMaybeCreateContext, use the trick that we know we can cast
590         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
591         WKWebView's configuration.
592
593         Ditto for WKPreferencesRef and WKPreferences.
594
595         Remove user content filters on the WKWebView's userContentController.
596
597         * WebKitTestRunner/mac/TestControllerMac.mm:
598         * WebKitTestRunner/ios/TestControllerIOS.mm:
599         Move code into TestControllerCocoa.
600
601         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
602         (WTR::InjectedBundle::beginTesting):
603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
604         (WTR::TestRunner::addUserScript):
605         (WTR::TestRunner::addUserStyleSheet):
606         Adopt WKBundlePage API for user scripts/sheets.
607
608         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
609         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
610         Make and keep a WKWebView instead of a WKView.
611         
612         * WebKitTestRunner/mac/EventSenderProxy.mm:
613         (WTR::EventSenderProxy::mouseUp):
614         (WTR::EventSenderProxy::mouseMoveTo):
615         Reach inside the WKWebView to the WKView when dispatching events.
616         This is fairly ugly and we should come up with a better solution.
617         Also, fix some flipping and style errors.
618
619 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
620
621         Unreviewed, attempt to fix GTK build after r188718
622
623         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
624         (WTR::PlatformWebView::PlatformWebView):
625
626 2015-08-21  Commit Queue  <commit-queue@webkit.org>
627
628         Unreviewed, rolling out r188807, r188813, and r188815.
629         https://bugs.webkit.org/show_bug.cgi?id=148349
630
631         lots of 32-bit build problems, better to resolve separately
632         and try again (Requested by thorton on #webkit).
633
634         Reverted changesets:
635
636         "WebKitTestRunner should use WKWebView on OS X and iOS"
637         https://bugs.webkit.org/show_bug.cgi?id=143743
638         http://trac.webkit.org/changeset/188807
639
640         "Stop building WebKitTestRunner for 32-bit platforms"
641         https://bugs.webkit.org/show_bug.cgi?id=143743
642         http://trac.webkit.org/changeset/188813
643
644         "Stop building WebKitTestRunner for 32-bit platforms"
645         https://bugs.webkit.org/show_bug.cgi?id=143743
646         http://trac.webkit.org/changeset/188815
647
648 2015-08-21  Tim Horton  <timothy_horton@apple.com>
649
650         Stop building WebKitTestRunner for 32-bit platforms
651         https://bugs.webkit.org/show_bug.cgi?id=143743
652         <rdar://problem/16947123>
653
654         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
655         This is a restriction on the valid set, not the desired set.
656
657 2015-08-21  Jason Marcell  <jmarcell@apple.com>
658
659         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
660         to work with these new objects.
661         https://bugs.webkit.org/show_bug.cgi?id=148188
662
663         Reviewed by Daniel Bates.
664
665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
666         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
668         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
669         (repository, "branch name")-pair.
670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
672         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
674         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
675         objects which represent a (repository, "branch name")-pair.
676         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
677         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
678         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
679         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
681         BuildbotQueue.branch to BuildbotQueue.branches.
682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
683         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
684
685 2015-08-21  Tim Horton  <timothy_horton@apple.com>
686
687         Stop building WebKitTestRunner for 32-bit platforms
688         https://bugs.webkit.org/show_bug.cgi?id=143743
689         <rdar://problem/16947123>
690
691         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
692         WKWebView is not available on 32-bit OS X.
693
694 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
695
696         [Win] Unreviewed test correction after r188709.
697
698         I removed a function argument that happened to be mirrored by a global
699         value with the same name. This prevented a compile error, but testing
700         showed that the wrong value was being used in the function.
701
702         * DumpRenderTree/win/FrameLoadDelegate.cpp:
703         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
704         back
705
706 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
707
708         WebKitTestRunner should use WKWebView on OS X and iOS
709         https://bugs.webkit.org/show_bug.cgi?id=143743
710         <rdar://problem/16947123>
711
712         Reviewed by Anders Carlsson.
713         Patch by Enrica Casucci and myself.
714
715         * WebKitTestRunner/PlatformWebView.h:
716         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
717         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
718         instead of WKContext and WKPageGroup.
719
720         Remove the unused, always-true windowSnapshotEnabled().
721         While technically some platforms don't have window snapshotting,
722         they just return null instead of implementing windowSnapshotEnabled().
723
724         * WebKitTestRunner/TestController.h:
725         * WebKitTestRunner/TestController.cpp:
726         (WTR::TestController::createOtherPage):
727         (WTR::TestController::initialize):
728         (WTR::TestController::createWebViewWithOptions):
729         Delegate to the various platforms for creating PlatformWebView instances,
730         for creating WKContexts, and for accessing WKPreferences,
731         so that they can do special things (like, use WKWebView instead!).
732
733         (WTR::TestController::resetPreferencesToConsistentValues):
734         Make explicit WebKitTestRunner's desired default for two preferences
735         which have differing defaults between the antique and modern API,
736         for consistency's sake.
737
738         (WTR::TestController::resetStateToConsistentValues):
739         Add platformResetStateToConsistentValues.
740
741         * WebKitTestRunner/TestInvocation.cpp:
742         (WTR::TestInvocation::dumpResults):
743         Adjust to the aforementioned removal of windowSnapshotEnabled().
744
745         * WebKitTestRunner/ios/TestControllerCocoa.mm:
746         (WTR::TestController::platformResetStateToConsistentValues):
747         (WTR::TestController::platformPreferences):
748         (WTR::TestController::platformCreateWebView):
749         (WTR::TestController::platformCreateOtherPage):
750         (WTR::TestController::platformInitializeConfiguration):
751         Implement the new platform functions for the Modern WebKit2 API,
752         in a new TestControllerCocoa file that is shared between iOS and Mac.
753         
754         For platformMaybeCreateContext, use the trick that we know we can cast
755         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
756         WKWebView's configuration.
757
758         Ditto for WKPreferencesRef and WKPreferences.
759
760         Remove user content filters on the WKWebView's userContentController.
761
762         * WebKitTestRunner/mac/TestControllerMac.mm:
763         * WebKitTestRunner/ios/TestControllerIOS.mm:
764         Move code into TestControllerCocoa.
765
766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
767         (WTR::InjectedBundle::beginTesting):
768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
769         (WTR::TestRunner::addUserScript):
770         (WTR::TestRunner::addUserStyleSheet):
771         Adopt WKBundlePage API for user scripts/sheets.
772
773         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
774         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
775         Make and keep a WKWebView instead of a WKView.
776         
777         * WebKitTestRunner/mac/EventSenderProxy.mm:
778         (WTR::EventSenderProxy::mouseUp):
779         (WTR::EventSenderProxy::mouseMoveTo):
780         Reach inside the WKWebView to the WKView when dispatching events.
781         This is fairly ugly and we should come up with a better solution.
782         Also, fix some flipping and style errors.
783
784 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
785
786         Improve how UI events are dispatched by WebKitTestRunner
787         https://bugs.webkit.org/show_bug.cgi?id=148326
788
789         Reviewed by Anders Carlsson.
790
791         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
792         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
793         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
794         asynchronous (and really, it has always been for the most part).
795
796         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
797         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
798         (WTR::EventSendingController::mouseUp): Ditto.
799         (WTR::EventSendingController::mouseMoveTo): Ditto.
800         (WTR::EventSendingController::mouseForceDown): Ditto.
801         (WTR::EventSendingController::mouseForceUp): Ditto.
802         (WTR::EventSendingController::mouseForceChanged): Ditto.
803         (WTR::EventSendingController::leapForward): Ditto.
804         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
805         (WTR::EventSendingController::keyDown): Ditto.
806         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
807         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
808         to be done in custom WebKit2 code for test wheel event handling.
809         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
810         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
811         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
812         (WTR::EventSendingController::addTouchPoint): Ditto.
813         (WTR::EventSendingController::updateTouchPoint): Ditto.
814         (WTR::EventSendingController::setTouchModifier): Ditto.
815         (WTR::EventSendingController::setTouchPointRadius): Ditto.
816         (WTR::EventSendingController::touchStart): Ditto.
817         (WTR::EventSendingController::touchMove): Ditto.
818         (WTR::EventSendingController::touchEnd): Ditto.
819         (WTR::EventSendingController::touchCancel): Ditto.
820         (WTR::EventSendingController::clearTouchPoints): Ditto.
821         (WTR::EventSendingController::releaseTouchPoint): Ditto.
822         (WTR::EventSendingController::cancelTouchPoint): Ditto.
823
824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
825         (WTR::InjectedBundle::postSetWindowIsKey):
826         (WTR::InjectedBundle::postSimulateWebNotificationClick):
827         (WTR::InjectedBundle::isGeolocationProviderActive):
828         (WTR::InjectedBundle::shouldProcessWorkQueue):
829         Updated for WKBundlePagePostSynchronousMessage renaming.
830
831         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
832         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
833
834         * WebKitTestRunner/TestController.cpp:
835         (WTR::TestController::initialize): Allow handling the new test style messages.
836         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
837         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
838         (WTR::TestController::didReceiveMessageFromInjectedBundle):
839         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
840         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
841
842         * WebKitTestRunner/mac/EventSenderProxy.mm:
843         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
844         (WTR::EventSenderProxy::keyDown): Ditto.
845         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
846         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
847
848 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
849
850         Skip no-llint tests that fail due to running out of executable memory after r188969
851         https://bugs.webkit.org/show_bug.cgi?id=148273
852
853         Reviewed by Michael Saboff.
854
855         * Scripts/run-jsc-stress-tests:
856
857 2015-08-21  Nan Wang  <n_wang@apple.com>
858
859         [Mac] accessibility/selection-states.html fails
860         https://bugs.webkit.org/show_bug.cgi?id=116637
861
862         Reviewed by Chris Fleizach.
863
864         Implemented isSelectable() and isMultiSelectable().
865
866         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
867         (AccessibilityUIElement::isSelectable):
868         (AccessibilityUIElement::isMultiSelectable):
869         (AccessibilityUIElement::isSelectedOptionActive):
870         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
871         (WTR::AccessibilityUIElement::isSelectable):
872         (WTR::AccessibilityUIElement::isMultiSelectable):
873         (WTR::AccessibilityUIElement::isVisible):
874
875 2015-08-21  Jason Marcell  <jmarcell@apple.com>
876
877         Fix iteration over repositories on bot watcher's dashboard.
878
879         Reviewed by Alexey Proskuryakov.
880
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
882         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
883
884 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
885
886         [EFL] Revise PlatformWebView ctor according to r188718
887         https://bugs.webkit.org/show_bug.cgi?id=148282
888
889         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
890         instead of WKContextRef and WKPageGroupRef respectively.
891
892         Reviewed by Gyuyoung Kim.
893
894         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
895         (WTR::PlatformWebView::PlatformWebView):
896
897 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
898
899         Unreviewed, changed Devin Rousso's email.
900
901         * Scripts/webkitpy/common/config/contributors.json:
902
903 2015-08-20  Anders Carlsson  <andersca@apple.com>
904
905         Use WKPageConfigurationRef in WebKitTestRunner
906         https://bugs.webkit.org/show_bug.cgi?id=147996
907
908         Reviewed by Tim Horton.
909
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::TestController::createOtherPage):
912         (WTR::TestController::initialize):
913         (WTR::TestController::createWebViewWithOptions):
914         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
915         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
916         (WTR::PlatformWebView::PlatformWebView):
917         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
918
919 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
920
921         [Win] Update Windows tools for revised MIDL interfaces
922         https://bugs.webkit.org/show_bug.cgi?id=148249
923
924         Reviewed by Dean Jackson.
925
926         This is a follow-up to Bug 148001.
927
928         Revise the testing software to use compatible signatures and
929         implementations to match the requirements of the IDL generated
930         with the SAL annotations.
931
932         * DumpRenderTree/win/DRTDataObject.cpp:
933         * DumpRenderTree/win/DRTDataObject.h:
934         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
935         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
936         * DumpRenderTree/win/DRTDropSource.cpp:
937         * DumpRenderTree/win/DRTDropSource.h:
938         * DumpRenderTree/win/DumpRenderTree.cpp:
939         * DumpRenderTree/win/EditingDelegate.cpp:
940         * DumpRenderTree/win/EditingDelegate.h:
941         * DumpRenderTree/win/FrameLoadDelegate.cpp:
942         * DumpRenderTree/win/FrameLoadDelegate.h:
943         * DumpRenderTree/win/HistoryDelegate.cpp:
944         * DumpRenderTree/win/HistoryDelegate.h:
945         * DumpRenderTree/win/PolicyDelegate.cpp:
946         * DumpRenderTree/win/PolicyDelegate.h:
947         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
948         * DumpRenderTree/win/ResourceLoadDelegate.h:
949         * DumpRenderTree/win/TestRunnerWin.cpp:
950         * DumpRenderTree/win/UIDelegate.cpp:
951         * DumpRenderTree/win/UIDelegate.h:
952         * WinLauncher/AccessibilityDelegate.cpp:
953         * WinLauncher/AccessibilityDelegate.h:
954         * WinLauncher/Common.cpp:
955         * WinLauncher/DOMDefaultImpl.cpp:
956         * WinLauncher/DOMDefaultImpl.h:
957         * WinLauncher/PageLoadTestClient.cpp:
958         * WinLauncher/PageLoadTestClient.h:
959         * WinLauncher/PrintWebUIDelegate.cpp:
960         * WinLauncher/PrintWebUIDelegate.h:
961         * WinLauncher/ResourceLoadDelegate.cpp:
962         * WinLauncher/ResourceLoadDelegate.h:
963         * WinLauncher/WebDownloadDelegate.cpp:
964         * WinLauncher/WebDownloadDelegate.h:
965         * WinLauncher/WinLauncherWebHost.cpp:
966         * WinLauncher/WinLauncherWebHost.h:
967         * WinLauncher/WinMain.cpp:
968         * win/DLLLauncher/DLLLauncherMain.cpp:
969
970 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
971
972         Unreviewed, shorten a test that runs too long and times out.
973
974         * TestWebKitAPI/Tests/WTF/Lock.cpp:
975         (TestWebKitAPI::TEST):
976
977 2015-08-20  Alex Christensen  <achristensen@webkit.org>
978
979         Clean up CMake build after r188673
980         https://bugs.webkit.org/show_bug.cgi?id=148234
981
982         Reviewed by Tim Horton.
983
984         * DumpRenderTree/PlatformWin.cmake:
985         * TestWebKitAPI/CMakeLists.txt:
986         * TestWebKitAPI/PlatformWin.cmake:
987         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
988         gtest needs to be a static library on Windows to not crash.
989
990 2015-08-19  Alex Christensen  <achristensen@webkit.org>
991
992         CMake Windows build should not include files directly from other Source directories
993         https://bugs.webkit.org/show_bug.cgi?id=148198
994
995         Reviewed by Brent Fulgham.
996
997         * DumpRenderTree/DumpRenderTreePrefix.h:
998         Include cmakeconfig.h to properly define all enabled features.
999         * DumpRenderTree/PlatformWin.cmake:
1000         * TestWebKitAPI/PlatformWin.cmake:
1001
1002 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1003
1004         Build TestWTF on Mac with CMake.
1005         https://bugs.webkit.org/show_bug.cgi?id=147972
1006
1007         Reviewed by Tim Horton.
1008
1009         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1010         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1011
1012         * TestWebKitAPI/CMakeLists.txt:
1013         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1014         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1015         * TestWebKitAPI/PlatformMac.cmake: Added.
1016         * TestWebKitAPI/config.h:
1017         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1018
1019 2015-08-19  Brian Burg  <bburg@apple.com>
1020
1021         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1022
1023         * Scripts/webkitpy/common/config/contributors.json:
1024
1025 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1026
1027         REGRESSION(r188548): [GTK] Build broken.
1028         https://bugs.webkit.org/show_bug.cgi?id=148154
1029
1030         Reviewed by Martin Robinson.
1031
1032         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1033         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1034         Even if we don't need to add/override any settings in ViewOptions,
1035         we need to define this as an empty function to make it build.
1036
1037 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1038
1039         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1040         https://bugs.webkit.org/show_bug.cgi?id=148073
1041
1042         Reviewed by Alexey Proskuryakov.
1043
1044         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1045         (TestWebKitAPI::TEST):
1046
1047 2015-08-18  Anders Carlsson  <andersca@apple.com>
1048
1049         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1050
1051         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1052         (TestWebKitAPI::setUpClients):
1053
1054 2015-08-18  Brian Burg  <bburg@apple.com>
1055
1056         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1057         https://bugs.webkit.org/show_bug.cgi?id=147955
1058
1059         Reviewed by Timothy Hatcher.
1060
1061         To enable sharing of common test code between protocol and model tests,
1062         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1063
1064         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1065         protocol-test.js uses to load the inspector frontend stub into its iframe
1066         from an arbitrary local file URL.
1067
1068         * DumpRenderTree/TestRunner.cpp:
1069         (getInspectorTestStubURLCallback):
1070         (TestRunner::staticValues):
1071         * DumpRenderTree/TestRunner.h:
1072         * DumpRenderTree/mac/TestRunnerMac.mm:
1073         (SOFT_LINK_STAGED_FRAMEWORK):
1074         (TestRunner::inspectorTestStubURL):
1075         * DumpRenderTree/win/TestRunnerWin.cpp:
1076         (TestRunner::inspectorTestStubURL):
1077         * WebKitTestRunner/Configurations/Base.xcconfig:
1078         Since WebKitTestRunner now includes WebCore private headers, also search
1079         for the WebCore framework inside the WebKit umbrella framework.
1080
1081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1082         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1083         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1084         (WTR::TestRunner::inspectorTestStubURL):
1085         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1086         (WTR::TestRunner::inspectorTestStubURL):
1087         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1088         (WTR::TestRunner::inspectorTestStubURL):
1089
1090 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1091
1092         Unreviewed, fix GTK build.
1093
1094         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1095         (TestWebKitAPI::TEST):
1096
1097 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1098
1099         Replace all remaining uses of WTF::Mutex with WTF::Lock
1100         https://bugs.webkit.org/show_bug.cgi?id=148089
1101
1102         Reviewed by Geoffrey Garen.
1103
1104         * DumpRenderTree/JavaScriptThreading.cpp:
1105         (javaScriptThreadsMutex):
1106         (runJavaScriptThread):
1107         (startJavaScriptThreads):
1108         (stopJavaScriptThreads):
1109         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1110         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1111         (TestWebKitAPI::TEST):
1112         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1113         (TestWebKitAPI::TEST):
1114
1115 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1116
1117         Unreviewed, rolling out r188539, r188544, r188552, and
1118         r188564.
1119         https://bugs.webkit.org/show_bug.cgi?id=148122
1120
1121         Broke tests and some build styles (Requested by ap on
1122         #webkit).
1123
1124         Reverted changesets:
1125
1126         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1127         bundle"
1128         https://bugs.webkit.org/show_bug.cgi?id=147955
1129         http://trac.webkit.org/changeset/188539
1130
1131         "Web Inspector: split TestStub.js into multiple files and
1132         modernize it"
1133         https://bugs.webkit.org/show_bug.cgi?id=148077
1134         http://trac.webkit.org/changeset/188544
1135
1136         "Web Inspector: InspectorTest should be a subclass of
1137         TestHarness"
1138         https://bugs.webkit.org/show_bug.cgi?id=148079
1139         http://trac.webkit.org/changeset/188552
1140
1141         "Unreviewed internal build fix attempt after r188539."
1142         http://trac.webkit.org/changeset/188564
1143
1144 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1145
1146         [OS X] Remove support for composite fonts
1147         https://bugs.webkit.org/show_bug.cgi?id=147920
1148
1149         Reviewed by Dan Bernstein.
1150
1151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1152         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1153         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1154         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (allowedFontFamilySet): Deleted.
1157         (activateTestingFonts): Deleted.
1158         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1159         (WTR::allowedFontFamilySet): Deleted.
1160         (WTR::activateFonts): Deleted.
1161         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1162         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1163         * WebKitTestRunner/mac/TestControllerMac.mm:
1164         (WTR::allowedFontFamilySet): Deleted.
1165
1166 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1167
1168         Unreviewed internal build fix attempt after r188539.
1169
1170         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1171
1172 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1173
1174         Fix the build
1175
1176         Unreviewed.
1177
1178         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1179
1180 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1181
1182         Build Debug Suffix on Windows with CMake
1183         https://bugs.webkit.org/show_bug.cgi?id=148083
1184
1185         Reviewed by Brent Fulgham.
1186
1187         * TestWebKitAPI/CMakeLists.txt:
1188         * TestWebKitAPI/PlatformWin.cmake:
1189         Add DEBUG_SUFFIX
1190
1191 2015-08-17  Anders Carlsson  <andersca@apple.com>
1192
1193         Simplify how PlatformWebViews are created when view options change
1194         https://bugs.webkit.org/show_bug.cgi?id=148093
1195
1196         Reviewed by Sam Weinig.
1197
1198         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1199
1200         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1201         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1202         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1203
1204         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1205
1206         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1207         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1208
1209         * WebKitTestRunner/TestController.cpp:
1210         (WTR::TestController::ensureViewSupportsOptionsForTest):
1211         (WTR::shouldUseFixedLayout):
1212         (WTR::TestController::viewOptionsForTest):
1213         (WTR::TestController::updateWebViewSizeForTest):
1214         (WTR::TestController::updateWindowScaleForTest):
1215         (WTR::TestController::configureViewForTest):
1216         (WTR::TestController::initialize): Deleted.
1217         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1218         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1219         (WTR::TestController::platformConfigureViewForTest): Deleted.
1220         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1221         (WTR::TestController::run): Deleted.
1222         * WebKitTestRunner/TestController.h:
1223         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1224         (WTR::shouldUseFixedLayout):
1225         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1226         (WTR::TestController::platformConfigureViewForTest):
1227         (WTR::TestController::platformResetPreferencesToConsistentValues):
1228         * WebKitTestRunner/ios/TestControllerIOS.mm:
1229         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1230         * WebKitTestRunner/mac/TestControllerMac.mm:
1231         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1232         (WTR::TestController::platformConfigureViewForTest):
1233
1234 2015-08-17  Sam Weinig  <sam@webkit.org>
1235
1236         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1237         https://bugs.webkit.org/show_bug.cgi?id=148097
1238
1239         Reviewed by Anders Carlsson.
1240
1241         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1242         Add tests for WebsiteDataStores in the WKPageConfiguration.
1243
1244 2015-08-17  Brian Burg  <bburg@apple.com>
1245
1246         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1247         https://bugs.webkit.org/show_bug.cgi?id=147955
1248
1249         Reviewed by Timothy Hatcher.
1250
1251         To enable sharing of common test code between protocol and model tests,
1252         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1253
1254         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1255         protocol-test.js uses to load the inspector frontend stub into its iframe
1256         from an arbitrary local file URL.
1257
1258         * DumpRenderTree/TestRunner.cpp:
1259         (getInspectorTestStubURLCallback):
1260         (TestRunner::staticValues):
1261         * DumpRenderTree/TestRunner.h:
1262         * DumpRenderTree/mac/TestRunnerMac.mm:
1263         (SOFT_LINK_STAGED_FRAMEWORK):
1264         (TestRunner::inspectorTestStubURL):
1265         * DumpRenderTree/win/TestRunnerWin.cpp:
1266         (TestRunner::inspectorTestStubURL):
1267         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1269         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1270         (WTR::TestRunner::inspectorTestStubURL):
1271         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1272         (WTR::TestRunner::inspectorTestStubURL):
1273         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1274         (WTR::TestRunner::inspectorTestStubURL):
1275
1276 2015-08-17  Saam barati  <sbarati@apple.com>
1277
1278         Change email address from saambarati1@gmail.com to sbarati@apple.com
1279
1280         * Scripts/webkitpy/common/config/contributors.json:
1281
1282 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1283
1284         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1285         repositories other than "openSource" and "internal".
1286         https://bugs.webkit.org/show_bug.cgi?id=147961
1287
1288         Reviewed by Daniel Bates.
1289
1290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1291         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1292         generically with repositories other than "openSource" and "internal".
1293
1294 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1295
1296         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1297         https://bugs.webkit.org/show_bug.cgi?id=148081
1298
1299         Reviewed by Tim Horton.
1300
1301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1302         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1303
1304 2015-08-11  Andy Estes  <aestes@apple.com>
1305
1306         [Cocoa] Add redirect support to CustomProtocolManager
1307         https://bugs.webkit.org/show_bug.cgi?id=147871
1308
1309         Reviewed by Dan Bernstein.
1310
1311         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1312
1313         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1314         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1315         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1316         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1317         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1318         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1319         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1320         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1321         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1322         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1323         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1324         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1325         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1326         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1327
1328 2015-08-13  Andy Estes  <aestes@apple.com>
1329
1330         [Cocoa] Downloads do not start if policy decision is made asynchronously
1331         https://bugs.webkit.org/show_bug.cgi?id=147985
1332
1333         Reviewed by Brady Eidson.
1334
1335         Added a new API test.
1336
1337         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1338         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1339         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1340         (TEST):
1341
1342 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1343
1344         Unreviewed, rolling out r187357.
1345         https://bugs.webkit.org/show_bug.cgi?id=148032
1346
1347         webkit-patch generates incorrect patches that cannot be
1348         applied (Requested by dydz on #webkit).
1349
1350         Reverted changeset:
1351
1352         "Call fixChangeLogPatch when generating patches from webkit-
1353         patch"
1354         https://bugs.webkit.org/show_bug.cgi?id=147248
1355         http://trac.webkit.org/changeset/187357
1356
1357 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1358
1359         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1360         other than "openSource" and "internal".
1361         https://bugs.webkit.org/show_bug.cgi?id=147938
1362
1363         Reviewed by Daniel Bates.
1364
1365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1366         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1367         repositories other than "openSource" and "internal".
1368
1369 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1370
1371         Unreviewed, shorten another test that is timing out.
1372
1373         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1374         (TestWebKitAPI::TEST):
1375
1376 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1377
1378         AppScale: Assertion hit when hovering a webkit-queue bubble
1379         https://bugs.webkit.org/show_bug.cgi?id=147997
1380
1381         Reviewed by Alexey Proskuryakov.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1384         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1385
1386 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1387
1388         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1389         
1390         Unreviewed.
1391         
1392         * Scripts/copy-webkitlibraries-to-product-directory:
1393
1394 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1395
1396         Run benchmark customized Dromaeo should not assume there is an internet connection.
1397         https://bugs.webkit.org/show_bug.cgi?id=147995
1398
1399         Reviewed by Ryosuke Niwa.
1400
1401         Add several dependency js libs to local.
1402
1403         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1404
1405 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1406
1407         WTF should have a compact Condition object to use with Lock
1408         https://bugs.webkit.org/show_bug.cgi?id=147986
1409
1410         Reviewed by Geoffrey Garen.
1411
1412         Add a test for WTF::Condition.
1413
1414         * TestWebKitAPI/CMakeLists.txt:
1415         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1420         (TestWebKitAPI::runLockTest): Change the name of the thread.
1421
1422 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1423
1424         Unreviewed, shorten another test. It's timing out in debug on some bot.
1425
1426         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1427         (TestWebKitAPI::TEST):
1428
1429 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1430
1431         WTF::Lock should not suffer from the thundering herd
1432         https://bugs.webkit.org/show_bug.cgi?id=147947
1433
1434         Reviewed by Geoffrey Garen.
1435
1436         Add testing that checks that locks return to a pristine state after contention is over.
1437
1438         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1439         (TestWebKitAPI::LockInspector::isFullyReset):
1440         (TestWebKitAPI::runLockTest):
1441         (TestWebKitAPI::TEST):
1442
1443 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1444
1445         Benchmarks supported by run_benchmark script should not assume we have internet access.
1446         https://bugs.webkit.org/show_bug.cgi?id=147959
1447
1448         Reviewed by Ryosuke Niwa.
1449
1450         For JSBench we should not request jquery.min.js from google through the internet.
1451
1452         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1453
1454 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1455
1456         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1457         other than "openSource" and "internal".
1458         https://bugs.webkit.org/show_bug.cgi?id=147796
1459
1460         Reviewed by Daniel Bates.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1463         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1464         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1465         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1466         and another assertion that, if the previousIteration is non-null, the given repository is in
1467         previousIteration.revision.
1468         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1469         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1470         fragment has at least one child node.
1471
1472 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1473
1474         Add a tool that dumps class and struct member layout, showing padding
1475         https://bugs.webkit.org/show_bug.cgi?id=147898
1476
1477         Reviewed by Zalan Bujtas.
1478         
1479         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1480         about data member layout, and displays it.
1481         
1482         Sample output:
1483
1484               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1485               +0 < 56>     WebCore::URL m_value;
1486               +0 <  8>         WTF::String m_string;
1487               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1488               +0 <  8>                 WTF::StringImpl * m_ptr;
1489               +8 <  1>         bool:1 m_isValid;
1490               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1491               +9 <  3>         <PADDING>
1492              +12 <  4>         int m_schemeEnd;
1493              +16 <  4>         int m_userStart;
1494              +20 <  4>         int m_userEnd;
1495              +24 <  4>         int m_passwordEnd;
1496              +28 <  4>         int m_hostEnd;
1497              +32 <  4>         int m_portEnd;
1498              +36 <  4>         int m_pathAfterLastSlash;
1499              +40 <  4>         int m_pathEnd;
1500              +44 <  4>         int m_queryEnd;
1501              +48 <  4>         int m_fragmentEnd;
1502              +52 <  4>         <PADDING>
1503              +52 <  4>     <PADDING>
1504              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1505              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1506             Total byte size: 72
1507             Total pad bytes: 11
1508             Padding percentage: 15.28 %
1509
1510         * Scripts/dump-class-layout: Added.
1511         (webkit_build_dir):
1512         (developer_dir):
1513         (import_lldb):
1514         (find_build_directory):
1515         (verify_type):
1516         (verify_type_recursive):
1517         (dump_class):
1518         (main):
1519         (main.or):
1520
1521 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1522
1523         Fix Debug CMake builds on Windows
1524         https://bugs.webkit.org/show_bug.cgi?id=147940
1525
1526         Reviewed by Chris Dumez.
1527
1528         * DumpRenderTree/PlatformWin.cmake:
1529         * TestWebKitAPI/PlatformWin.cmake:
1530         The BitmapImage test is not enabled on the AppleWin port.
1531         * WinLauncher/CMakeLists.txt:
1532         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1533
1534 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1535
1536         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1537
1538         In r188125 I added a way to mark tests as slow to use a longer
1539         timeout. But it seems it was not enough for
1540         WTF_Lock.ContendedShortSection, so let's try again with a longer
1541         timeout now.
1542
1543         * Scripts/run-gtk-tests:
1544         (TestRunner._run_google_test):
1545
1546 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1547
1548         Allow --debug option in run-jsc
1549         https://bugs.webkit.org/show_bug.cgi?id=147923
1550
1551         Reviewed by Csaba Osztrogonác.
1552
1553         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1554
1555         * Scripts/run-jsc:
1556
1557 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1558
1559         Fix test after build fix in r188286.
1560         https://bugs.webkit.org/show_bug.cgi?id=147907
1561
1562         Reviewed by Anders Carlsson.
1563
1564         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1565         sleep_for can now be used, but we need to include <thread>
1566
1567 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1568
1569         Always use a byte-sized lock implementation
1570         https://bugs.webkit.org/show_bug.cgi?id=147908
1571
1572         Reviewed by Geoffrey Garen.
1573
1574         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1575         now tests of Lock.
1576
1577         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1578         (TestWebKitAPI::runLockTest):
1579         (TestWebKitAPI::TEST):
1580
1581 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1582
1583         Make ASan build not depend on asan.xcconfig
1584         https://bugs.webkit.org/show_bug.cgi?id=147840
1585         rdar://problem/21093702
1586
1587         Reviewed by Daniel Bates.
1588
1589         * asan/asan.xcconfig:
1590         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1591         are now marked in source code.
1592
1593 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1594
1595         Unreviewed, shorten another test since it timed out.
1596
1597         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1598         (TestWebKitAPI::TEST):
1599
1600 2015-08-11  Mark Lam  <mark.lam@apple.com>
1601
1602         Fix names of Lock tests: should be "Contended", not "Contented".
1603         https://bugs.webkit.org/show_bug.cgi?id=147905
1604
1605         Reviewed by Saam Barati.
1606
1607         We're testing the behavior of lock contention (i.e. when threads contend), not
1608         whether the locks are happy (contented).
1609
1610         * Scripts/run-gtk-tests:
1611         (TestRunner):
1612         (TestRunner.__init__): Deleted.
1613         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1614         (TestWebKitAPI::runLockTest):
1615         (TestWebKitAPI::TEST):
1616
1617 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1618
1619         Update WinCairoRequirements to VS2015.
1620
1621         * Scripts/update-webkit-wincairo-libs:
1622         Update WinCairoRequirements location.
1623
1624 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1625
1626         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1627         for internalTrac.
1628         https://bugs.webkit.org/show_bug.cgi?id=147805
1629
1630         Reviewed by Daniel Bates.
1631
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1633         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1634         Dashboard.Repository.Internal.trac for internalTrac.
1635         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1636         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1637         respectively.
1638         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1639         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1640         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1641         internalTrac.
1642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1645         (Analyzer): Ditto.
1646         (Analyzer.prototype.analyze): Ditto.
1647
1648 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1649
1650         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1651
1652         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1653         (TestWebKitAPI::TEST):
1654
1655 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1656
1657         [Win] Switch Windows build to Visual Studio 2015
1658         https://bugs.webkit.org/show_bug.cgi?id=147887
1659         <rdar://problem/22235098>
1660
1661         Reviewed by Alex Christensen.
1662
1663         Update Visual Studio project file settings to use the current Visual
1664         Studio and compiler. Continue targeting binaries to run on our minimum
1665         supported configuration of Windows 7.
1666
1667         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1668         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1669         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1670         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1671         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1672         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1673         prefer the newer MSBuild included in Visual Studio 2015.
1674         (visualStudioInstallDir):
1675         (msBuildInstallDir):
1676         (visualStudioVersion):
1677         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1678         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1679         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1680         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1681         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1682         * win/record-memory/record-memory.vcxproj:
1683
1684 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1685
1686         Another speculative build fix after r188280.
1687
1688         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1689         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1690         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1691
1692 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1693
1694         Unreviewed build fix after r188280.
1695
1696         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1697         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1698
1699 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1700
1701         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1702         https://bugs.webkit.org/show_bug.cgi?id=147665
1703
1704         Reviewed by Mark Lam.
1705
1706         * TestWebKitAPI/CMakeLists.txt:
1707         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1710         (TestWebKitAPI::TEST):
1711         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1712         (TestWebKitAPI::TEST):
1713
1714 2015-08-11  Brian Burg  <bburg@apple.com>
1715
1716         webkit-patch should not explode when $EDITOR is set incorrectly
1717         https://bugs.webkit.org/show_bug.cgi?id=147884
1718
1719         Reviewed by Darin Adler.
1720
1721         If $EDITOR doesn't exist, log a warning and continue.
1722
1723         * Scripts/webkitpy/common/system/user.py: 
1724         (User.edit):
1725         (User.edit_changelog):
1726
1727 2015-08-11  Dan Bernstein  <mitz@apple.com>
1728
1729         Reverted r188255, because it turned out that delegates do nonot need this information.
1730
1731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1733
1734 2015-08-11  Dan Bernstein  <mitz@apple.com>
1735
1736         [Cocoa] The UI delegate can't tell if printing was user-initiated
1737         https://bugs.webkit.org/show_bug.cgi?id=147869
1738
1739         Reviewed by Sam Weinig.
1740
1741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1742         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1743         (-[PrintFrameController webView:didFinishNavigation:]):
1744         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1745         (TEST):
1746
1747 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1748
1749         Another build fix after r188239.
1750
1751         * TestWebKitAPI/PlatformWin.cmake:
1752         Link with more libraries.
1753         * WinLauncher/CMakeLists.txt:
1754         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1755
1756 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1757
1758         Build fix after r188237.
1759
1760         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1761         (BenchmarkBuilder.__enter__):
1762
1763 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1764
1765         Update ReadMe and correct the way to use abstract abstract class.
1766         https://bugs.webkit.org/show_bug.cgi?id=147860
1767
1768         Reviewed by Ryosuke Niwa.
1769
1770         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1771         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1772
1773         * Scripts/webkitpy/benchmark_runner/README.md:
1774         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1775         (BrowserDriver):
1776         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1777         (OSXBrowserDriver.restore_env):
1778         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1779         (HTTPServerDriver):
1780         (HTTPServerDriver.set_device_id):
1781         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1782         (SimpleHTTPServerDriver.get_return_code):
1783         (SimpleHTTPServerDriver):
1784         (SimpleHTTPServerDriver.set_device_id):
1785
1786 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1787
1788         Build TestWebKitAPI with CMake on Windows
1789         https://bugs.webkit.org/show_bug.cgi?id=147851
1790
1791         Reviewed by Chris Dumez.
1792
1793         * CMakeLists.txt:
1794         * TestWebKitAPI/CMakeLists.txt:
1795         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1796         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1797         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1798         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1799         * TestWebKitAPI/PlatformEfl.cmake:
1800         * TestWebKitAPI/PlatformGTK.cmake:
1801         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1802         I did this without changing the directory structure of the existing EFL and GTK builds.
1803         * TestWebKitAPI/PlatformWin.cmake: Added.
1804         * TestWebKitAPI/win/main.cpp:
1805         (main):
1806         (dllLauncherEntryPoint):
1807         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1808         * WinLauncher/CMakeLists.txt:
1809         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1810
1811 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1812
1813         Make cleanup more robust and minor code cleaning in run benchmark script.
1814         https://bugs.webkit.org/show_bug.cgi?id=147800
1815
1816         Reviewed by Ryosuke Niwa.
1817
1818         Use 'finnaly' block to make sure cleanup code is always executed.
1819
1820         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1821         (built_benchmark):
1822         (built_benchmark.__init__):
1823         (built_benchmark.__enter__):
1824         (built_benchmark.__exit__):
1825         (test_environment):
1826         (test_environment.__init__):
1827         (test_environment.__enter__):
1828         (test_environment.__exit__):
1829         (BenchmarkRunner.__init__):
1830         (BenchmarkRunner.execute):
1831         (BenchmarkRunner._dump):
1832         (BenchmarkRunner._wrap):
1833         (BenchmarkRunner): Deleted.
1834         (BenchmarkRunner._cleanup): Deleted.
1835         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1836         (BrowserDriver.close_browsers):
1837         (BrowserDriver):
1838         (BrowserDriver.restore_env):
1839         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1840         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1841
1842 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1843
1844         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1845         https://bugs.webkit.org/show_bug.cgi?id=146414
1846
1847         Reviewed by Darin Adler.
1848
1849         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1850         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1851
1852 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1855         https://bugs.webkit.org/show_bug.cgi?id=147727
1856
1857         Reviewed by Sergio Villar Senin.
1858
1859         I think it was not this test in particular, but
1860         /webkit2/WebKitWebView/custom-charset that is affecting the
1861         others. This is because changing the encoding reloads the page,
1862         but we don't wait for the page to be reloaded, so when the test
1863         finishes and other test starts the web process is still reloading
1864         the page.
1865
1866         * Scripts/run-gtk-tests:
1867         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1868         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1869         (testWebViewCustomCharset): Wait until page is reloaded after
1870         changing the charset.
1871
1872 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1873
1874         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1875
1876         It's timing out in the bots. My guess is that there's no installer
1877         installed in the bots and gst_install_plugins_supported() returns
1878         false, so we don't even get a permission request because no
1879         installer will be launched.
1880
1881         * Scripts/run-gtk-tests:
1882         (TestRunner):
1883
1884 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1885
1886         [GTK] Another build fix after r188157.
1887
1888         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1889         (WTR::PlatformWebView::viewSupportsOptions):
1890         Name all the things correctly!
1891
1892 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1893
1894         [EFL, GTK] Build fix after r188176.
1895
1896         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1897         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
1898
1899 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1900
1901         [GTK] Speculative build fix after r188157.
1902
1903         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1904         (WTR::PlatformWebView::PlatformWebView):
1905         Update parameter list.
1906
1907 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1908
1909         Build more testing binaries with CMake on Windows
1910         https://bugs.webkit.org/show_bug.cgi?id=147799
1911
1912         Reviewed by Brent Fulgham.
1913
1914         * DumpRenderTree/CMakeLists.txt:
1915         Build TestNetscapePlugin.
1916         * DumpRenderTree/PlatformWin.cmake:
1917         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
1918         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
1919         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
1920         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
1921         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
1922         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
1923         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
1924         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1925         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
1926
1927 2015-08-07  Jason Marcell  <jmarcell@apple.com>
1928
1929         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
1930         https://bugs.webkit.org/show_bug.cgi?id=147667
1931
1932         Reviewed by Daniel Bates.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1935         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
1936         other than "openSource" and "internal".
1937         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1939         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
1940         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1942         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1943         (sortedPlatforms): Deleted.
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1945         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1946         (sortedPlatforms): Deleted.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1948         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
1949         and sorts them by this property returning the new sorted array.
1950
1951 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
1952
1953         Lightweight locks should be adaptive
1954         https://bugs.webkit.org/show_bug.cgi?id=147545
1955
1956         Reviewed by Geoffrey Garen.
1957
1958         * TestWebKitAPI/CMakeLists.txt:
1959         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1961         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
1962         (TestWebKitAPI::runLockTest):
1963         (TestWebKitAPI::TEST):
1964
1965 2015-08-07  Anders Carlsson  <andersca@apple.com>
1966
1967         Fix a tyop.
1968
1969         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1970         (WTR::PlatformWebView::viewSupportsOptions):
1971
1972 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
1973
1974         Update AppEngine app version numbers to the latest commit.
1975
1976         * QueueStatusServer/app.yaml:
1977         * TestResultServer/app.yaml:
1978
1979 2015-08-07  Anders Carlsson  <andersca@apple.com>
1980
1981         Simplify WKTR's view options
1982         https://bugs.webkit.org/show_bug.cgi?id=147791
1983
1984         Reviewed by Sam Weinig.
1985
1986         Instead of using a WKDictionaryRef, just use a struct for the options.
1987
1988         * WebKitTestRunner/PlatformWebView.h:
1989         (WTR::PlatformWebView::options):
1990         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1991         * WebKitTestRunner/TestController.cpp:
1992         (WTR::TestController::initialize):
1993         (WTR::TestController::createWebViewWithOptions):
1994         (WTR::TestController::ensureViewSupportsOptions):
1995         (WTR::TestController::updateLayoutTypeForTest):
1996         * WebKitTestRunner/TestController.h:
1997         * WebKitTestRunner/ViewOptions.h: Added.
1998         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1999         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2000         (WTR::PlatformWebView::PlatformWebView):
2001         (WTR::PlatformWebView::viewSupportsOptions):
2002         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2003         (WTR::PlatformWebView::viewSupportsOptions):
2004         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2005         (WTR::PlatformWebView::viewSupportsOptions):
2006         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2007         (WTR::PlatformWebView::PlatformWebView):
2008         (WTR::PlatformWebView::viewSupportsOptions):
2009         * WebKitTestRunner/mac/TestControllerMac.mm:
2010         (WTR::TestController::platformConfigureViewForTest):
2011
2012 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2013
2014         Running tests for a long time results in some tests running very slowly (throttling)
2015         https://bugs.webkit.org/show_bug.cgi?id=147718
2016
2017         Reviewed by Chris Dumez.
2018
2019         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2020         Although COCOA ports default this setting to be disabled in WebKit1,
2021         we should make both test harnesses disable the setting for consistency.
2022
2023         * DumpRenderTree/mac/DumpRenderTree.mm:
2024         (resetWebPreferencesToConsistentValues):
2025
2026 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2027
2028         Use a specific version of Speedometer in run-benchmark
2029         https://bugs.webkit.org/show_bug.cgi?id=147769
2030
2031         Reviewed by Chris Dumez.
2032
2033         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2034
2035         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2036
2037 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2038
2039         twisted_http_server.py should support --port
2040         https://bugs.webkit.org/show_bug.cgi?id=147771
2041
2042         Reviewed by Chris Dumez.
2043
2044         Added the option. This makes the script more useful on its own.
2045
2046         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2047
2048 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2049
2050         [GTK] WTF unit tests are timing out in the bots
2051         https://bugs.webkit.org/show_bug.cgi?id=147777
2052
2053         Reviewed by Filip Pizlo.
2054
2055         Add a way to mark google unit tests as slow and add
2056         WTF_Lock.ContentedShortSection to the list. In case of slow test
2057         we use the double of the given timeout for that particular test.
2058
2059         * Scripts/run-gtk-tests:
2060         (TestRunner):
2061         (TestRunner._run_google_test):
2062
2063 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2064
2065         [GTK] run-gtk-tests should not stop when a google test case fails
2066         https://bugs.webkit.org/show_bug.cgi?id=147778
2067
2068         Reviewed by Philippe Normand.
2069
2070         For glib based tests we run the test runner with the -k option,
2071         but for google tests we are aborting as soon as we find a failure.
2072
2073         * Scripts/run-gtk-tests:
2074         (TestRunner._run_google_test_suite): Use a global return code that
2075         is set to 1 when any test has failed.
2076
2077 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2078
2079         [GStreamer] Do not automatically show PackageKit codec installation notifications
2080         https://bugs.webkit.org/show_bug.cgi?id=135973
2081
2082         Reviewed by Philippe Normand.
2083
2084         Handle the missing media plugins installation permission request
2085         in MiniBrowser and add a test case for the new API.
2086
2087         * MiniBrowser/gtk/BrowserWindow.c:
2088         (webViewDecidePermissionRequest):
2089         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2090         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2091         (permissionRequestCallback):
2092         (testInstallMissingPluginsPermissionRequest):
2093         (beforeAll):
2094         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2095         (methodCallCallback):
2096
2097 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2098
2099         Running tests for a long time results in some tests running very slowly (throttling)
2100         https://bugs.webkit.org/show_bug.cgi?id=147718
2101
2102         Reviewed by Alexey Proskuryakov.
2103
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::resetPreferencesToConsistentValues):
2106         Ensure throttling settings are disabled for tests for all ports, as
2107         COCOA ports default to having these setting enabled. Note, there is
2108         still other timer throttling not covered by these setting.
2109
2110 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2111
2112         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2113         https://bugs.webkit.org/show_bug.cgi?id=147752
2114
2115         Reviewed by Chris Dumez.
2116
2117         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2118
2119         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2120         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2121
2122         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2123         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2124         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2125         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2126         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2127         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2128         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2129         HTTPServerDriverFactory taking the platform name as an argument.
2130         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2131         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2132         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2133         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2134         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2135         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2136         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2137         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2138         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2139         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2140         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2141         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2142         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2143         (HTTPServerDriver): Replaced name by platforms.
2144         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2145         (SimpleHTTPServerDriver): Ditto.
2146         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2147         (parse_args): Removed --http-server-driver option.
2148         (start): Ditto.
2149
2150 2015-08-06  Chris Dumez  <cdumez@apple.com>
2151
2152         Toggle GPS state based on page visibility to save battery
2153         https://bugs.webkit.org/show_bug.cgi?id=147685
2154
2155         Reviewed by Benjamin Poulain.
2156
2157         Add testRunner.isGeolocationProviderActive() test support function.
2158
2159         * DumpRenderTree/TestRunner.cpp:
2160         (isGeolocationProviderActiveCallback):
2161         (TestRunner::staticFunctions):
2162         * DumpRenderTree/TestRunner.h:
2163         * DumpRenderTree/mac/MockGeolocationProvider.h:
2164         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2165         (-[MockGeolocationProvider isActive]):
2166         * DumpRenderTree/mac/TestRunnerMac.mm:
2167         (TestRunner::isGeolocationProviderActive):
2168         * DumpRenderTree/win/TestRunnerWin.cpp:
2169         (TestRunner::isGeolocationProviderActive):
2170         * WebKitTestRunner/GeolocationProviderMock.h:
2171         (WTR::GeolocationProviderMock::isActive):
2172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2173         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2174         (WTR::InjectedBundle::isGeolocationProviderActive):
2175         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2177         (WTR::TestRunner::isGeolocationProviderActive):
2178         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2179         * WebKitTestRunner/TestController.cpp:
2180         (WTR::TestController::isGeolocationProviderActive):
2181         * WebKitTestRunner/TestController.h:
2182         * WebKitTestRunner/TestInvocation.cpp:
2183         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2184
2185 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2186
2187         Automate JSBench with run-benchmark
2188         https://bugs.webkit.org/show_bug.cgi?id=147716
2189
2190         Reviewed by Chris Dumez.
2191
2192         Added JSBench plan to run-benchmark.
2193
2194         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2195         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2196         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2197         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2198         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2199         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2200         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2201         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2202         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2203         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2204         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2205         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2206         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2207         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2208         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2209         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2210
2211 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2212
2213         Pass-through the undefined options in run-jsc
2214         https://bugs.webkit.org/show_bug.cgi?id=147717
2215
2216         Undefined options in run-jsc is just passed to the actual jsc shell.
2217         We can execute `Tools/Scripts/run-jsc -d`.
2218
2219         Reviewed by Csaba Osztrogonác.
2220
2221         * Scripts/run-jsc:
2222
2223 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2224
2225         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2226
2227         It's flaky.
2228
2229         * Scripts/run-gtk-tests:
2230         (TestRunner):
2231
2232 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2233
2234         [EFL] Bump EFL version to 1.15.0
2235         https://bugs.webkit.org/show_bug.cgi?id=147450
2236
2237         Reviewed by Gyuyoung Kim.
2238
2239         * efl/jhbuild.modules:
2240
2241 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2242
2243         Unreviewed. Unksip TestContextMenu GTK+ API test.
2244
2245         This has been skipped for a long time, and it's very
2246         unconvenient. It has never failed for me locally, so let's try
2247         again to see if it works in the bots. I'll skip it again if it
2248         keeps failing.
2249
2250         * Scripts/run-gtk-tests:
2251         (TestRunner):
2252
2253 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2254
2255         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2256
2257         * DumpRenderTree/JavaScriptThreading.cpp:
2258         (javaScriptThreadsMutex):
2259         (runJavaScriptThread):
2260         (startJavaScriptThreads):
2261         (stopJavaScriptThreads):
2262         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2263         (TestWebKitAPI::TEST):
2264         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2265         (TestWebKitAPI::TEST):
2266
2267 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2268
2269         Build DumpRenderTree with CMake.
2270         https://bugs.webkit.org/show_bug.cgi?id=147519
2271
2272         Reviewed by Brent Fulgham.
2273
2274         * CMakeLists.txt:
2275         Build the DumpRenderTree directory now that it builds successfully.
2276         * DumpRenderTree/CMakeLists.txt:
2277         Added missing source file and don't link with WebCore.lib.
2278         * DumpRenderTree/PlatformWin.cmake:
2279         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2280         * WinLauncher/CMakeLists.txt:
2281         We need libcmt now that we are not linking with WebCore.lib.
2282
2283 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2284
2285         AppScale: Use https URLs for subresources and links
2286         https://bugs.webkit.org/show_bug.cgi?id=147686
2287
2288         Reviewed by Ryosuke Niwa.
2289
2290         * QueueStatusServer/filters/webkit_extras.py:
2291         * TestResultServer/static-dashboards/dashboard_base.js:
2292         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2293         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2294         * TestResultServer/static-dashboards/treemap.js:
2295         * TestResultServer/static-dashboards/ui.js:
2296
2297 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2298
2299         Rename Mutex to DeprecatedMutex
2300         https://bugs.webkit.org/show_bug.cgi?id=147675
2301
2302         Reviewed by Geoffrey Garen.
2303
2304         * DumpRenderTree/JavaScriptThreading.cpp:
2305         (javaScriptThreadsMutex):
2306         (runJavaScriptThread):
2307         (startJavaScriptThreads):
2308         (stopJavaScriptThreads):
2309         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2310         (TestWebKitAPI::TEST):
2311         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2312         (TestWebKitAPI::TEST):
2313
2314 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2315
2316         Update the WebKit nightly icon
2317         https://bugs.webkit.org/show_bug.cgi?id=147684
2318
2319         Reviewed by Sam Weinig.
2320
2321         * WebKitLauncher/webkit.icns: Replaced.
2322
2323 2015-08-05  Daniel Bates  <dabates@apple.com>
2324
2325         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2326         https://bugs.webkit.org/show_bug.cgi?id=147678
2327         <rdar://problem/21827815>
2328
2329         Reviewed by Brady Eidson.
2330
2331         Add a test to ensure that we restore the "should open external URLs" policy on
2332         page reload after the web content process crashes.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2336         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2337         (TEST):
2338
2339 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2340
2341         [EFL] Editing tests have been broken since r186694
2342         https://bugs.webkit.org/show_bug.cgi?id=146888
2343
2344         Reviewed by Brent Fulgham.
2345
2346         Restored some codes for the context click on GTK+ and EFL port.
2347
2348         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2349         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2350
2351 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2352
2353         Install twisted package for http server when necessary.
2354         https://bugs.webkit.org/show_bug.cgi?id=147082
2355
2356         Reviewed by Ryosuke Niwa.
2357
2358         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2359         * Scripts/webkitpy/thirdparty/__init__.py:
2360         (AutoinstallImportHook.find_module):
2361         (AutoinstallImportHook._install_twisted):
2362
2363 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2364
2365         [Win] Update Apple Windows build for VS2015
2366         https://bugs.webkit.org/show_bug.cgi?id=147653
2367
2368         Reviewed by Dean Jackson.
2369
2370         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2371         something older than VS2015, define snprintf as _snprintf.
2372         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2373         Remove unneeded macro definition for snprintf.
2374         * Scripts/webkitpy/common/system/platforminfo.py:
2375         (PlatformInfo._determine_win_version): Recognize Windows 10.
2376         * Scripts/webkitpy/port/win.py:
2377         (WinPort): Ditto.
2378         * Scripts/webkitpy/port/win_unittest.py:
2379         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2380         (WinPortTest._assert_version): Ditto.
2381
2382 2015-08-04  Brian Burg  <bburg@apple.com>
2383
2384         Unreviewed, update email addresses in contributors.json and watchlist.
2385
2386         * Scripts/webkitpy/common/config/contributors.json:
2387         * Scripts/webkitpy/common/config/watchlist:
2388
2389 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2390
2391         Implement NPAPI redirect handling
2392         https://bugs.webkit.org/show_bug.cgi?id=138675
2393         rdar://problem/15779101
2394
2395         Patch by Jeffrey Pfau, updated and tweaked by me.
2396
2397         Reviewed by Anders Carlsson.
2398
2399         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2400         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2401         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2402         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2403         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2404         (PluginTest::NPP_URLNotify):
2405         (PluginTest::NPP_URLRedirectNotify):
2406         (PluginTest::NPP_GetValue):
2407         (PluginTest::NPN_GetURLNotify):
2408         (PluginTest::NPN_PostURLNotify):
2409         (PluginTest::NPN_GetValue):
2410         (PluginTest::NPN_ReleaseVariantValue):
2411         (PluginTest::NPN_URLRedirectResponse):
2412         (PluginTest::NPN_ConvertPoint):
2413         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2414         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2415         (URLRedirect::URLRedirect):
2416         (URLRedirect::ScriptableObject::hasMethod):
2417         (URLRedirect::ScriptableObject::get):
2418         (URLRedirect::ScriptableObject::serviceAsync):
2419         (URLRedirect::ScriptableObject::invoke):
2420         (URLRedirect::NPP_GetValue):
2421         (URLRedirect::NPP_URLNotify):
2422         (URLRedirect::NPP_URLRedirectNotify):
2423         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2424         (NP_GetEntryPoints):
2425         (NPP_URLNotify):
2426         (NPP_URLRedirectNotify):
2427         (NPP_GetValue):
2428
2429 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2430
2431         Move Matt Daiter to committers.
2432
2433         * Scripts/webkitpy/common/config/contributors.json:
2434
2435 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2436
2437         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2438         https://bugs.webkit.org/show_bug.cgi?id=147636
2439
2440         Reviewed by Alex Christensen.
2441         
2442         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2443         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2444         on EWS machines)
2445
2446         * Scripts/build-webkit:
2447
2448 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2449
2450         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2451         https://bugs.webkit.org/show_bug.cgi?id=147280
2452
2453         Reviewed by Daniel Bates.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2456         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2457         Refactored _parseData to handle repositories more generically.
2458         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2460         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2461         "opensourceRevision" and "internalRevision".
2462         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2464         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2465         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2466         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2467         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2468         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2469         and "internalRevision".
2470         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2471         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2472         "opensourceRevision" and "internalRevision".
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2474         constants for internal and opensource repositories.
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2476         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2477         instead of "opensourceRevision" and "internalRevision".
2478         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2479         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2480         (Analyzer.prototype._countTimes): Ditto.
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2482         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2483
2484 2015-08-04  Mark Lam  <mark.lam@apple.com>
2485
2486         Removed a local debugging line I accidentally left in from a previous commit.
2487
2488         Not Reviewed.
2489
2490         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2491
2492 2015-08-04  Mark Lam  <mark.lam@apple.com>
2493
2494         Unreviewed. Make Saam Barati a WebKit reviewer.
2495
2496         * Scripts/webkitpy/common/config/contributors.json:
2497
2498 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2499
2500         Unreviewed, updated Streams API watchlist.
2501
2502         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2503
2504 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2505
2506         [CMake] Add an option to build AllInOne files
2507         https://bugs.webkit.org/show_bug.cgi?id=102647
2508
2509         Reviewed by Alex Christensen.
2510
2511         * Scripts/webkitperl/FeatureList.pm:
2512
2513 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2514
2515         AppScale: Add required indices
2516         https://bugs.webkit.org/show_bug.cgi?id=147593
2517
2518         Reviewed by Tim Horton.
2519
2520         * QueueStatusServer/index.yaml:
2521
2522 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2523
2524         Check in LLVM 3.6.2 binary drops for El Capitan
2525         https://bugs.webkit.org/show_bug.cgi?id=147582
2526
2527         Reviewed by Alexey Proskuryakov.
2528         
2529         Recognize 10.11 and use the right drops.
2530
2531         * Scripts/copy-webkitlibraries-to-product-directory:
2532
2533 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2534
2535         [Win] Build fix after r187733.
2536
2537         * WinLauncher/PageLoadTestClient.cpp:
2538         (PageLoadTestClient::dumpRunStatistics):
2539         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2540
2541 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2542
2543         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2544         https://bugs.webkit.org/show_bug.cgi?id=118455
2545
2546         Reviewed by Filip Pizlo.
2547
2548         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2549         (TestWebKitAPI::TEST):
2550
2551 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2552
2553         Prepare for VS2015
2554         https://bugs.webkit.org/show_bug.cgi?id=146579
2555
2556         Reviewed by Jon Honeycutt.
2557
2558         * WinLauncher/stdafx.h:
2559         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2560
2561 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2562
2563         [EFL] Fix pixman build on ARM with GCC 4.9.3
2564         https://bugs.webkit.org/show_bug.cgi?id=147224
2565
2566         Reviewed by Gyuyoung Kim.
2567
2568         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2569
2570 2015-07-30  Anders Carlsson  <andersca@apple.com>
2571
2572         Add support for window.open to WK1BrowserWindowController
2573         https://bugs.webkit.org/show_bug.cgi?id=147474
2574
2575         Reviewed by Dan Bernstein.
2576
2577         * MiniBrowser/mac/WK1BrowserWindowController.m:
2578         (-[WK1BrowserWindowController awakeFromNib]):
2579         Set javaScriptCanOpenWindowsAutomatically to YES. 
2580         If this becomes a nuisance, we can always add a menu item to toggle this.
2581
2582         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2583         Implement this UI delegate method.
2584
2585 2015-07-30  Anders Carlsson  <andersca@apple.com>
2586
2587         Undo stray commit.
2588
2589         * MiniBrowser/mac/WK1BrowserWindowController.m:
2590         (-[WK1BrowserWindowController awakeFromNib]):
2591         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2592
2593 2015-07-29  Dean Jackson  <dino@apple.com>
2594
2595         Don't use (Details) when exposing SPI
2596         https://bugs.webkit.org/show_bug.cgi?id=147426
2597         <rdar://problem/22062407>
2598
2599         Reviewed by Dan Bernstein.
2600
2601         If we are declaring the interface without any implementation,
2602         we should use class extensions.
2603
2604         * DumpRenderTree/mac/DumpRenderTree.mm:
2605         * DumpRenderTree/mac/EventSendingController.mm:
2606         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2607         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2608         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2609         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2610         * WebKitTestRunner/mac/TestControllerMac.mm:
2611
2612 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2613
2614         Replace Google App Engine with AppScale
2615         https://bugs.webkit.org/show_bug.cgi?id=147178
2616
2617         Reviewed by Daniel Bates.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2620         (RunWebKitTests):
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2626         (.):
2627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2628         (BubbleQueueServer):
2629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2630         (TestHistory):
2631         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2632         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2633         * TestResultServer/app.yaml: Ditto
2634         * Scripts/webkitpy/common/config/urls.py:
2635         * TestResultServer/main.py:
2636         * TestResultServer/static-dashboards/dashboard_base.js:
2637         * TestResultServer/static-dashboards/loader.js:
2638
2639 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2640
2641         [EFL] Enable IndexedDB based on DatabaseProcess
2642         https://bugs.webkit.org/show_bug.cgi?id=147221
2643
2644         Reviewed by Csaba Osztrogonác.
2645
2646         * Scripts/webkitperl/FeatureList.pm:
2647
2648 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2649
2650         Build AppleWin port with CMake
2651         https://bugs.webkit.org/show_bug.cgi?id=147385
2652
2653         Reviewed by Martin Robinson.
2654
2655         * WinLauncher/CMakeLists.txt:
2656         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2657
2658 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2659
2660         Implement basic types for ECMAScript Internationalization API
2661         https://bugs.webkit.org/show_bug.cgi?id=146926
2662
2663         Reviewed by Benjamin Poulain.
2664
2665         Enable flag now that the basic objects are in place.
2666
2667         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2668
2669 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2670
2671         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2672         https://bugs.webkit.org/show_bug.cgi?id=147108
2673
2674         Reviewed by Gustavo Noronha Silva.
2675
2676         Add test case to check the web process limit.
2677
2678         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2679         (testWebProcessLimit):
2680         (beforeAll):
2681
2682 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2683
2684         [GTK] Missing casts in BrowserWindow.c
2685         https://bugs.webkit.org/show_bug.cgi?id=147395
2686
2687         Reviewed by Carlos Garcia Campos.
2688
2689         * MiniBrowser/gtk/BrowserWindow.c:
2690         (browserWindowSetupEditorToolbar):
2691
2692 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2693
2694         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2695         https://bugs.webkit.org/show_bug.cgi?id=147350
2696
2697         Reviewed by Sam Weinig.
2698
2699         * Scripts/webkitperl/FeatureList.pm:
2700
2701 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2702
2703         [Freetype] Always allow font matching for strong aliases
2704         https://bugs.webkit.org/show_bug.cgi?id=147057
2705
2706         Reviewed by Martin Robinson.
2707
2708         Create family aliases needed for the new layout tests.
2709
2710         * WebKitTestRunner/gtk/fonts/fonts.conf:
2711
2712 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2713
2714         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2715         https://bugs.webkit.org/show_bug.cgi?id=147359
2716
2717         Reviewed by Ryosuke Niwa.
2718
2719         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2720         (NewCommitBot.begin_work_queue):
2721         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2722         (SheriffBot.begin_work_queue):
2723
2724 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2725
2726         Use Ninja on Windows.
2727         https://bugs.webkit.org/show_bug.cgi?id=147228
2728
2729         Reviewed by Martin Robinson.
2730
2731         * WinLauncher/CMakeLists.txt:
2732         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2733         * Scripts/build-webkit:
2734         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2735
2736 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2737
2738         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2739         highlight after being tapped to style a selection"
2740         https://bugs.webkit.org/show_bug.cgi?id=147278
2741
2742         Reviewed by Ryosuke Niwa.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745
2746         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2747         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2748         (TestWebKitAPI::TEST):
2749         Load a page with the string "Hello, world!", then select "world" and
2750         underline it. Test that the typing attributes for the current selection
2751         include the underline attribute.
2752
2753 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2754
2755         Unreviewed, updated my nick name in contributors.json
2756
2757         * Scripts/webkitpy/common/config/contributors.json:
2758
2759 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2760
2761         AX: scrollable elements do not allow 3-finger swipe
2762         https://bugs.webkit.org/show_bug.cgi?id=141893
2763
2764         Reviewed by Mario Sanchez Prada.
2765
2766         Support global notification listeners for iOS code.
2767         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2768         Implement scrollUp/Down/Left/Right.
2769
2770         * DumpRenderTree/AccessibilityController.h:
2771         * DumpRenderTree/AccessibilityUIElement.cpp:
2772         (increaseTextSelectionCallback):
2773         (scrollPageUpCallback):
2774         (scrollPageDownCallback):
2775         (scrollPageLeftCallback):
2776         (scrollPageRightCallback):
2777         (decreaseTextSelectionCallback):
2778         (getElementTextLengthCallback):
2779         (AccessibilityUIElement::getJSClass):
2780         * DumpRenderTree/AccessibilityUIElement.h:
2781         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2782         (AccessibilityController::~AccessibilityController):
2783         (AccessibilityController::elementAtPoint):
2784         (AccessibilityController::addNotificationListener):
2785         (AccessibilityController::platformResetToConsistentState):
2786         (AccessibilityController::removeNotificationListener):
2787         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2788         (AccessibilityUIElement::AccessibilityUIElement):
2789         (AccessibilityUIElement::subrole):
2790         (AccessibilityUIElement::scrollPageUp):
2791         (AccessibilityUIElement::scrollPageDown):
2792         (AccessibilityUIElement::scrollPageLeft):
2793         (AccessibilityUIElement::scrollPageRight):
2794         (AccessibilityUIElement::roleDescription):
2795         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2796         (-[AccessibilityNotificationHandler _notificationReceived:]):
2797         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2798         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2799         (WTR::AccessibilityUIElement::linkedElement):
2800         (WTR::AccessibilityUIElement::headerElementAtIndex):
2801         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2802         (WTR::AccessibilityUIElement::scrollPageUp):
2803         (WTR::AccessibilityUIElement::scrollPageDown):
2804         (WTR::AccessibilityUIElement::scrollPageLeft):
2805         (WTR::AccessibilityUIElement::scrollPageRight):
2806         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2807         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2808         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2809         (WTR::AccessibilityController::addNotificationListener):
2810         (WTR::AccessibilityController::removeNotificationListener):
2811         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2812         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2813         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2814         (WTR::AccessibilityUIElement::scrollPageUp):
2815         (WTR::AccessibilityUIElement::scrollPageDown):
2816         (WTR::AccessibilityUIElement::scrollPageLeft):
2817         (WTR::AccessibilityUIElement::scrollPageRight):
2818         (WTR::AccessibilityUIElement::increaseTextSelection):
2819
2820 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2821
2822         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2823         https://bugs.webkit.org/show_bug.cgi?id=147279
2824         <rdar://problem/21990767>
2825
2826         Reviewed by Dean Jackson.
2827
2828         * DumpRenderTree/win/TestRunnerWin.cpp:
2829         (TestRunner::addUserScript):
2830         (TestRunner::addUserStyleSheet):
2831         (TestRunner::setDeveloperExtrasEnabled):
2832
2833 2015-07-24  Basile Clement  <basile_clement@apple.com>
2834
2835         Call fixChangeLogPatch when generating patches from webkit-patch
2836         https://bugs.webkit.org/show_bug.cgi?id=147248
2837
2838         Reviewed by Geoffrey Garen.
2839
2840         When two consecutive patches are from the same author, diff tools
2841         create wrong-looking diffs for ChangeLog files where the apparent added
2842         author is actually the previous patch's author line, making it awkward
2843         to read - and things only get worse when committing a patch and a
2844         followup fix for the same bug shortly after.
2845
2846         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2847         this, which we use in perl scripts (svn-create-patch et al). But it is
2848         not used by webkit-patch, which is a python script, and thus creates
2849         "bad" diffs.
2850
2851         In the long term, we should probably port fixChangeLogPatch to python -
2852         but in the short term, let's make webkit-patch call perl to run
2853         fixChangeLogPatch. We are already making various external calls there
2854         anyway.
2855
2856         * Scripts/webkitpy/common/checkout/scm/git.py:
2857         (Git.create_patch):
2858         * Scripts/webkitpy/common/checkout/scm/scm.py:
2859         (SCM.fix_changelog_patch):
2860         * Scripts/webkitpy/common/checkout/scm/svn.py:
2861         (SVN.create_patch):
2862
2863 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2864
2865         commit-queue flags in webkit-patch are confusing
2866         https://bugs.webkit.org/show_bug.cgi?id=88694
2867
2868         Reviewed by Csaba Osztrogonác.
2869
2870         * Scripts/webkitpy/tool/steps/options.py:
2871         (Options): Updated help string to be more descriptive.
2872
2873 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2874
2875         [Win] Implement proper High DPI support features
2876         https://bugs.webkit.org/show_bug.cgi?id=146335
2877         <rdar://problem/21558269>
2878
2879         Reviewed by Alex Christensen.
2880
2881         Update WinLauncher to take device scaling factor into account.
2882
2883         * WinLauncher/Common.cpp:
2884         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2885         a valid font.
2886         (computeFullDesktopFrame): Handle high DPI desktops.
2887         (WndProc): Make comments more precise.
2888         * WinLauncher/WinLauncher.cpp:
2889         (WinLauncher::init): Determine device scale factor at launch.
2890         (WinLauncher::updateDeviceScaleFactor): Added.
2891         * WinLauncher/WinLauncher.h:
2892         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
2893         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
2894         (wWinMain): Ditto.
2895         * win/DLLLauncher/DLLLauncherMain.cpp:
2896         (wWinMain): Tell Windows we understand high DPI.
2897
2898 2015-07-23  Alex Christensen  <achristensen@webkit.org>
2899
2900         [Win] Unreviewed build fix after r187169.
2901
2902         * Scripts/build-webkit:
2903         Correctly find WebKit.sln.
2904
2905 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2906
2907         [GTK] Add API to allow executing editing commands that require an argument
2908         https://bugs.webkit.org/show_bug.cgi?id=146781
2909
2910         Reviewed by Gustavo Noronha Silva.
2911
2912         Add buttons to insert image/link to the MiniBrowser edit toolbar,
2913         and test cases for insert image/link commands too.
2914
2915         * MiniBrowser/gtk/BrowserWindow.c:
2916         (insertImageCommandCallback):
2917         (insertLinkCommandCallback):
2918         (browserWindowSetupEditorToolbar):
2919         (browserWindowConstructed):
2920         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2921         (testWebViewEditorInsertImage):
2922         (testWebViewEditorCreateLink):
2923         (beforeAll):
2924
2925 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2926
2927         Unregistering and re-registering a user message handler does not work
2928         https://bugs.webkit.org/show_bug.cgi?id=138142
2929
2930         Reviewed by Martin Robinson.
2931
2932         This has probably been fixed in r184846, enable the test case
2933         blocked on it.
2934
2935         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2936         (testUserContentManagerScriptMessageReceived):
2937
2938 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2939
2940         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
2941         https://bugs.webkit.org/show_bug.cgi?id=147212
2942
2943         Reviewed by Filip Pizlo.
2944
2945         * Scripts/webkitperl/FeatureList.pm:
2946
2947 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
2948
2949         Add --ios-simulator to run-api-tests --help.
2950
2951         Rubber-stamped by Dan Bates.
2952
2953         * Scripts/run-api-tests:
2954
2955 2015-07-22  Jason Marcell  <jmarcell@apple.com>
2956
2957         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
2958         https://bugs.webkit.org/show_bug.cgi?id=147043
2959
2960         Reviewed by Daniel Bates and Alexey Proskuryakov.
2961
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2963         (Buildbot.prototype._normalizeQueueInfo):
2964         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
2965         in cases where the queue.branch property is not set and the queue is not a combined queue.
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2967         (BuildbotCombinedQueueView):
2968         Ensuring uniformity of repository branches within a combined queue.
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2970         (WebKitBuildbot.prototype.get defaultBranches):
2971         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
2972         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
2973         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
2974         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
2975         implement defaultBranches so that a person can either update the definition of the sub-queue or
2976         implement defaultBranches in the derived Buildbot class they are using.
2977
2978 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2979
2980         Switch WinCairo build to use CMake.
2981         https://bugs.webkit.org/show_bug.cgi?id=147169
2982
2983         Reviewed by Brent Fulgham.
2984
2985         * Scripts/build-webkit:
2986         * Scripts/webkitdirs.pm:
2987         (determineConfiguration):
2988         (determineArchitecture):
2989         (determinePassedConfiguration):
2990         (passedConfiguration):
2991         (jhbuildWrapperPrefixIfNeeded):
2992         (generateBuildSystemFromCMakeProject):
2993         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
2994
2995 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2996
2997         Fix quirks in CMake build on Mac and Windows
2998         https://bugs.webkit.org/show_bug.cgi?id=147174
2999
3000         Reviewed by Gyuyoung Kim.
3001
3002         * CMakeLists.txt:
3003         Don't build DumpRenderTree with CMake for now (until we get that working).
3004         * WinLauncher/CMakeLists.txt:
3005         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3006
3007 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3008
3009         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3010         https://bugs.webkit.org/show_bug.cgi?id=147146
3011
3012         Reviewed by Darin Adler.
3013
3014         * Scripts/webkitpy/style/checkers/cpp.py:
3015         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3016         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3017         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3018
3019 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3020
3021         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3022         https://bugs.webkit.org/show_bug.cgi?id=147154
3023         rdar://problem/21847618
3024
3025         Reviewed by Geoffrey Garen.
3026         
3027         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3028         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3029
3030         * Scripts/run-jsc-stress-tests:
3031
3032 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3033
3034         [GTK] Add API to be notified about editor state changes
3035         https://bugs.webkit.org/show_bug.cgi?id=145875
3036
3037         Reviewed by Gustavo Noronha Silva.
3038
3039         Update the typing attributes toggle buttons state according to the
3040         editor state in MiniBrowser, and add a test case to the
3041         WebViewEditor unit tests.
3042
3043         * MiniBrowser/gtk/BrowserWindow.c:
3044         (browserWindowEditingCommandToggleButtonSetActive):
3045         (typingAttributesChanged):
3046         (browserWindowSetupEditorToolbar):
3047         (browserWindowConstructed):
3048         (browser_window_init):
3049         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3050         (testWebViewEditorEditorStateTypingAttributes):
3051         (beforeAll):
3052
3053 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3054
3055         [GTK] Add selection-changed signal to the WebKit2 API
3056         https://bugs.webkit.org/show_bug.cgi?id=137116
3057
3058         Reviewed by Carlos Garcia Campos.
3059
3060         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3061         (namely the selection-changed signal).
3062
3063         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3064         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3065         (WebKitWebEditorTest::create):
3066         (WebKitWebEditorTest::selectionChangedCallback):
3067         (WebKitWebEditorTest::testSelectionSelectAll):
3068         (WebKitWebEditorTest::testSelectionCollapse):
3069         (WebKitWebEditorTest::testSelectionModifyMove):
3070         (WebKitWebEditorTest::testSelectionModifyExtend):
3071         (WebKitWebEditorTest::testSelectionUnselect):
3072         (registerTests):
3073         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3074         (testWebKitWebEditorSelectionChanged):
3075         (beforeAll):
3076         (afterAll):
3077
3078 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3079
3080         Resurrect CMake build on Windows.
3081         https://bugs.webkit.org/show_bug.cgi?id=147083
3082
3083         Reviewed by Gyuyoung Kim.
3084
3085         * DumpRenderTree/CMakeLists.txt:
3086         * DumpRenderTree/PlatformWin.cmake: Added.
3087         * WinLauncher/CMakeLists.txt:
3088
3089 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         [GTK] Enable seccomp filter API tests
3092         https://bugs.webkit.org/show_bug.cgi?id=140071
3093
3094         Reviewed by Žan Doberšek.
3095
3096         These tests will now be run by the run-gtk-tests script.
3097
3098         * TestWebKitAPI/PlatformGTK.cmake:
3099
3100 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3101
3102         [GTK] Add seccomp filters support
3103         https://bugs.webkit.org/show_bug.cgi?id=110014
3104
3105         Reviewed by Žan Doberšek.
3106
3107         Add libseccomp to jhbuild modulesets.
3108
3109         * gtk/jhbuild.modules:
3110
3111 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3112
3113         MiniBrowser window title is just "Window" when page has no <title>
3114         https://bugs.webkit.org/show_bug.cgi?id=147076
3115
3116         Reviewed by Tim Horton.
3117         
3118         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3119         notification.
3120
3121         * MiniBrowser/mac/WK1BrowserWindowController.m:
3122         (-[WK1BrowserWindowController updateTitle:]):
3123         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3124         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3125         * MiniBrowser/mac/WK2BrowserWindowController.m:
3126         (-[WK2BrowserWindowController updateTitle:]):
3127         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3128         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3129
3130 2015-07-17  Andy Estes  <aestes@apple.com>
3131
3132         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3133         https://bugs.webkit.org/show_bug.cgi?id=147044
3134         rdar://problem/21567820
3135
3136         Reviewed by Brady Eidson.
3137
3138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3139         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3140         This matches the behavior of DumpRenderTree.
3141
3142 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3143
3144         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3145         https://bugs.webkit.org/show_bug.cgi?id=147032
3146
3147         Reviewed by Alex Christensen.
3148
3149         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3150         Test that the useless terms are eliminated by counting
3151         the number of NFA nodes generated.
3152
3153 2015-07-17  Dan Bernstein  <mitz@apple.com>
3154
3155         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3156         https://bugs.webkit.org/show_bug.cgi?id=147040
3157
3158         Reviewed by Dean Jackson.
3159
3160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3161         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3162         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3163         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3164         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3165         (TEST):
3166
3167 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3168
3169         webkit-patch uses incorrect credentials from keychain to login until account lockout
3170         https://bugs.webkit.org/show_bug.cgi?id=146923
3171
3172         Reviewed by Daniel Bates.
3173
3174         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3175         provide incorrect credentials then ask for them to be saved to the keychain
3176         webkit-patch will then use those incorrect credentials until 5 total attempts
3177         have been made to log in. This will lock the user out of Bugzilla for a
3178         half hour.
3179
3180         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3181         (Bugzilla.authenticate): Added argument to read_credentials() that
3182         passes in whether or not to use stored credentials.
3183         * Scripts/webkitpy/common/net/credentials.py:
3184         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3185         that specifies whether or not to use credentials stored on the system. If it
3186         does, we do not auto-fill credentials since either the credentials caused
3187         the failure, or they weren't used in the first place so there is no reason
3188         to try and use them again if a failure happened.
3189         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3190         use_stored_credentials argument.
3191         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3192         retrieve username/password information from the local system (environment, Git, keychain,
3193         keyring) are never called. It also tests that we get back our mocked username and password.
3194         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3195         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3196         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3197         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3198         is never called.
3199         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3200         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3201         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3202         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3203         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3204         against.
3205
3206 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3207
3208         Unreviewed, remove my redundant email information.
3209
3210         * Scripts/webkitpy/common/config/contributors.json:
3211
3212 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3213
3214         Unreviewed. Add Hyungwook Lee as a committer.
3215
3216         * Scripts/webkitpy/common/config/contributors.json:
3217
3218 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3219
3220         Added myself to the list of contributors.
3221
3222         Reviewed by Brent Fulgham.
3223
3224         * Scripts/webkitpy/common/config/contributors.json:
3225
3226 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3227
3228         [Content Extensions] Cache domain actions
3229         https://bugs.webkit.org/show_bug.cgi?id=146817
3230
3231         Reviewed by Benjamin Poulain.
3232
3233         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3234         (TestWebKitAPI::TEST_F):
3235         Test if-domain and unless-domain with multiple load types.
3236
3237 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3238
3239         [Content extensions] Combine suffixes when generating NFAs
3240         https://bugs.webkit.org/show_bug.cgi?id=146961
3241
3242         Reviewed by Alex Christensen.
3243
3244         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3245         (TestWebKitAPI::compareContents):
3246         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3247
3248 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3249
3250         [GTK] Input method filter is always enabled when the view is focused
3251         https://bugs.webkit.org/show_bug.cgi?id=146965
3252
3253         Reviewed by Martin Robinson.
3254
3255         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3256
3257         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3258         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3259
3260 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3261
3262         [EFL] Bump libseccomp version to 2.2.3
3263         https://bugs.webkit.org/show_bug.cgi?id=146980
3264
3265         Reviewed by Gyuyoung Kim.
3266
3267         * efl/jhbuild.modules:
3268
3269 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3270
3271         [Win] Maintain consistent COM Interfaces
3272         https://bugs.webkit.org/show_bug.cgi?id=146983
3273         <rdar://problem/21822278>
3274
3275         Reviewed by Dean Jackson.
3276
3277         Update DumpRenderTree and WinLauncher to use the properly
3278         versioned COM interface objects.
3279
3280         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3281         (AccessibilityController::rootElement):
3282         * DumpRenderTree/win/DumpRenderTree.cpp:
3283         (resetWebPreferencesToConsistentValues):
3284         (resetWebViewToConsistentStateBeforeTesting):
3285         (runTest):
3286         (createWebViewAndOffscreenWindow):
3287         * DumpRenderTree/win/EditingDelegate.cpp:
3288         (EditingDelegate::QueryInterface):
3289         (EditingDelegate::shouldEndEditingInDOMRange):
3290         (EditingDelegate::shouldInsertNode):
3291         * DumpRenderTree/win/EditingDelegate.h:
3292         * DumpRenderTree/win/EventSender.cpp:
3293         (scalePageByCallback):
3294         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3295         (FrameLoadDelegate::didCommitLoadForFrame):
3296         * DumpRenderTree/win/TestRunnerWin.cpp:
3297         (TestRunner::callShouldCloseOnWebView):
3298         (TestRunner::applicationCacheDiskUsageForOrigin):
3299         (TestRunner::clearApplicationCacheForOrigin):
3300         (TestRunner::setDefersLoading):
3301         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3302         (TestRunner::setTabKeyCyclesThroughElements):
3303         (TestRunner::setValueForUser):
3304         (TestRunner::dispatchPendingLoadRequests):
3305         (TestRunner::setWindowIsKey):
3306         (TestRunner::execCommand):
3307         (TestRunner::addOriginAccessWhitelistEntry):
3308         (TestRunner::removeOriginAccessWhitelistEntry):
3309         (TestRunner::addUserScript):
3310         (TestRunner::addUserStyleSheet):
3311         (TestRunner::showWebInspector):
3312         (TestRunner::closeWebInspector):
3313         (TestRunner::evaluateInWebInspector):
3314         (TestRunner::setSerializeHTTPLoads):
3315         * DumpRenderTree/win/TextInputControllerWin.cpp:
3316         (TextInputController::setMarkedText):
3317         (TextInputController::hasMarkedText):
3318         (TextInputController::unmarkText):
3319         (TextInputController::markedRange):
3320         (TextInputController::insertText):
3321         (TextInputController::firstRectForCharacterRange):
3322         (TextInputController::selectedRange):
3323         * DumpRenderTree/win/UIDelegate.h:
3324         (UIDelegate::unused2):
3325         (UIDelegate::unused3):
3326         (UIDelegate::webViewScrolled):
3327         (UIDelegate::webViewShouldInterruptJavaScript):
3328         (UIDelegate::webViewReceivedFocus):
3329         (UIDelegate::unused4): Deleted.
3330         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3331         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3332         * WinLauncher/PageLoadTestClient.cpp:
3333         (PageLoadTestClient::didStartProvisionalLoad):
3334         * WinLauncher/WinLauncher.cpp:
3335         (WinLauncher::init):
3336         * WinLauncher/WinLauncher.h:
3337         * WinLauncher/WinLauncherWebHost.cpp:
3338         (WinLauncherWebHost::didFinishLoadForFrame):
3339         (WinLauncherWebHost::didFirstLayoutInFrame):
3340         * WinLauncher/WinLauncherWebHost.h:
3341
3342 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3343
3344         Many test failures in scm_unittest.py
3345         https://bugs.webkit.org/show_bug.cgi?id=143967
3346
3347         Reviewed by Daniel Bates. 
3348
3349         * Scripts/webkitpy/common/checkout/scm/detection.py:
3350         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3351         absolute canonical file paths. Two mutually exclusive issues cause this
3352         to be a problem.
3353             1) Python's os.path.relpath() function does not return correct relative
3354             paths between two filepaths that point to the same file, if symlinks are
3355             involved.
3356                 On Mac, /tmp points to /private/tmp
3357                 ex. os.path.relpath('/tmp', '/private/tmp')
3358                     returns '../../tmp'
3359             What we want is actually just '.'
3360             2) Git does not allow file paths to trace outside of
3361             the Git repository. This means that if you have a repository in
3362             /tmp and you refer to that repository when invoking a git command as
3363             ../tmp, Git will produce errors about working outside of the repository.
3364         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3365         its default behavior and such, needed to be updated.
3366         (Git.changed_files): '--' was added into the command so that patch_directories
3367         were taken as positional arguments.
3368         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3369         in the GitSVNTest class to more closely emulate the version of Git that the tests
3370         assumed a system had. Also fixed a small side-effect from the absolute canonical
3371         path fix in SCMDetector.detect_scm_system
3372         (SVNTestRepository.setup): A relative filepath was previously passed as the
3373         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3374         an absolute canonical path before being passed in. The failing test
3375         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3376         were the same.
3377         (GitSVNTest._setup_git_checkout):
3378             1) Added "--prefix ''" option to `git clone` since Git changed its default
3379             behavior in version 2.0.
3380             2) The branch master was renamed to trunk to more closely emulate what
3381             tests expected when they were written. 
3382         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3383         original tests failed because the tests expected the trunk branch
3384         to produce its parent's commit, whereas Git merely provides the HEAD commit
3385         for a given branch (trunk in this case). Based on other tests written
3386         in the same commit, it appears these tests were failing from the point they
3387         were written.
3388
3389 2015-07-14  Anders Carlsson  <andersca@apple.com>
3390
3391         Assertions.h should include ExportMacros.h
3392         https://bugs.webkit.org/show_bug.cgi?id=146948
3393
3394         Reviewed by Tim Horton.
3395
3396         Remove now unneeded WTF_EXPORT_PRIVATE define.
3397
3398         * DumpRenderTree/cg/ImageDiffCG.cpp:
3399
3400 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3401
3402         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3403         https://bugs.webkit.org/show_bug.cgi?id=146057
3404
3405         Reviewed by Carlos Garcia Campos.
3406
3407         * gtk/install-dependencies:
3408
3409 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3410
3411         [Mac] Unable to dismiss context menu during test runs
3412         https://bugs.webkit.org/show_bug.cgi?id=146836
3413
3414         Reviewed by Tim Horton.
3415
3416         Since Context Menus are modal, the test system would block on the displayed context menu,
3417         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3418         mouse click and generate the menu contents, but not ask AppKit to display it.
3419
3420         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3421
3422         * DumpRenderTree/mac/EventSendingController.mm:
3423         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3424         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3425         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3426         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3427         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3428         work without actually calling on AppKit to display the menu.
3429         ask WebCore to do all the work EXCEPT displaying the menu.
3430         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3431         * WebKitTestRunner/mac/EventSenderProxy.mm:
3432         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3433
3434 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3435
3436         It should be possible to run the OSR exit fuzzer
3437         https://bugs.webkit.org/show_bug.cgi?id=146814
3438
3439         Reviewed by Mark Lam.
3440         
3441         This runs a test command to detect how many static OSR exit sites it had, and then for
3442         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3443         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3444         search, so in the future it'll be very appropriate for cases where we have a simple test
3445         and we want to see what happens when you eventually exit in this test.
3446         
3447         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3448         and it seems to do the right thing.
3449
3450         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3451         (fail):
3452
3453 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3454
3455         Add tests for r186649
3456         https://bugs.webkit.org/show_bug.cgi?id=146821
3457
3458         Reviewed by Darin Adler.
3459
3460         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3461         (TestWebKitAPI::TEST_F):
3462         (TestWebKitAPI::compareContents):
3463         (TestWebKitAPI::expectedIndex):
3464         Add some larger tests to test large jumps.
3465
3466 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3467
3468         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3469         https://bugs.webkit.org/show_bug.cgi?id=146820
3470
3471         Reviewed by Ryosuke Niwa.
3472
3473         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3474         (OSXBrowserDriver):
3475         (OSXBrowserDriver.close_browsers):
3476         (OSXBrowserDriver._terminiate_processes):
3477         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3478         (OSXChromeDriver):
3479         (OSXChromeCanaryDriver):
3480         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3481         (OSXFirefoxDriver):
3482         (OSXFirefoxNightlyDriver):
3483         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3484         (OSXSafariDriver):
3485
3486 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3487
3488         [GTK] pango should be included in the default jhbuild moduleset
3489         https://bugs.webkit.org/show_bug.cgi?id=146683
3490
3491         Reviewed by Martin Robinson.
3492
3493         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
3494         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
3495         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
3496         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
3497         the same problem again the next time pango wants to use a new fontconfig feature), or remove
3498         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
3499         best.
3500
3501         * gtk/jhbuild-optional.modules: Remove pango
3502         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
3503
3504 2015-07-09  Devin Rousso  <drousso@apple.com>
3505
3506         Unreviewed.  Added myself as a committer.
3507
3508         * Scripts/webkitpy/common/config/contributors.json:
3509
3510 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3511
3512         Add a way to set the default URL from Minibrowser UI
3513         https://bugs.webkit.org/show_bug.cgi?id=146780
3514
3515         Reviewed by Simon Fraser.
3516
3517         * MiniBrowser/mac/AppDelegate.m:
3518         (-[BrowserAppDelegate didChangeSettings]):
3519         * MiniBrowser/mac/BrowserWindowController.h:
3520         * MiniBrowser/mac/BrowserWindowController.m:
3521         (-[BrowserWindowController fetch:]):
3522         (-[BrowserWindowController reload:]):
3523         (-[BrowserWindowController forceRepaint:]):
3524         (-[BrowserWindowController goBack:]):
3525         (-[BrowserWindowController goForward:]):
3526         (-[BrowserWindowController showHideWebView:]):
3527         (-[BrowserWindowController removeReinsertWebView:]):
3528         (-[BrowserWindowController zoomIn:]):
3529         (-[BrowserWindowController zoomOut:]):
3530         (-[BrowserWindowController resetZoom:]):
3531         (-[BrowserWindowController canZoomIn]):
3532         (-[BrowserWindowController canZoomOut]):
3533         (-[BrowserWindowController canResetZoom]):
3534         (-[BrowserWindowController toggleZoomMode:]):
3535         (-[BrowserWindowController setScale:]):
3536         (-[BrowserWindowController toggleShrinkToFit:]):
3537         (-[BrowserWindowController dumpSourceToConsole:]):
3538         (-[BrowserWindowController find:]):
3539         (-[BrowserWindowController didChangeSettings]):
3540         (-[BrowserWindowController currentURL]):
3541         Get rid of the BrowserController protocol. It was a bad idea and confused
3542         Interface Builder more than I thought possible.
3543
3544         * MiniBrowser/mac/SettingsController.m:
3545         (-[SettingsController _populateMenu]):
3546         (-[SettingsController setDefaultURLToCurrentURL:]):
3547         If we have a BrowserWindowController, grab its URL and set the relevant default.
3548
3549         * MiniBrowser/mac/WK1BrowserWindowController.h:
3550         * MiniBrowser/mac/WK1BrowserWindowController.m:
3551         (-[WK1BrowserWindowController currentURL]):
3552         * MiniBrowser/mac/WK2BrowserWindowController.h:
3553         * MiniBrowser/mac/WK2BrowserWindowController.m:
3554         (-[WK2BrowserWindowController currentURL]):
3555         Retrieve the current URL from the WKView/WebView.
3556
3557 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3558
3559         Increase MiniBrowser location bar maximum width
3560         https://bugs.webkit.org/show_bug.cgi?id=146779
3561
3562         Reviewed by Simon Fraser.
3563
3564         * MiniBrowser/mac/BrowserWindow.xib:
3565         Have an enormous maximum width on the location bar, so that it doesn't
3566         stop expanding with the window at 800px.
3567
3568 2015-07-08  Brady Eidson  <beidson@apple.com>
3569
3570         Crash calling [WebView close] in didFinishLoadForFrame callback.
3571         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
3572
3573         Reviewed by David Kilzer.
3574
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         
3577         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
3578         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
3579         (TestWebKitAPI::TEST):
3580
3581 2015-07-08  Hyungwook Lee&