Choose the compiler based on the Xcode version for Snow Leopard debug builds.
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-26  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Mark Rowe.
4
5         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
6
7         * DumpRenderTree/mac/Configurations/Base.xcconfig:
8         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
9         * MiniBrowser/Configurations/Base.xcconfig:
10         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
11         * TestWebKitAPI/Configurations/Base.xcconfig:
12         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
13         * WebKitTestRunner/Configurations/Base.xcconfig:
14         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
15
16 2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>
17
18         Reviewed by David Levin.
19
20         Adding myself as a Chromium contributors to committers.py.
21
22         https://bugs.webkit.org/show_bug.cgi?id=59444
23
24         * Scripts/webkitpy/common/config/committers.py:
25
26 2011-04-26  Adam Barth  <abarth@webkit.org>
27
28         Reviewed by Eric Seidel.
29
30         DumpRenderTree/chromium should play nice with strict OwnPtrs
31         https://bugs.webkit.org/show_bug.cgi?id=59458
32
33         All these changes are pretty straight forward.
34
35         * DumpRenderTree/chromium/CppBoundClass.cpp:
36         (GetterPropertyCallback::GetterPropertyCallback):
37         (CppBoundClass::bindGetterCallback):
38         * DumpRenderTree/chromium/CppBoundClass.h:
39         (CppBoundClass::bindProperty):
40         (CppBoundClass::bindFallbackCallback):
41         (CppBoundClass::bindFallbackMethod):
42         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
43         (DRTDevToolsClient::DRTDevToolsClient):
44         * DumpRenderTree/chromium/TestEventPrinter.cpp:
45         (TestEventPrinter::createDRTPrinter):
46         (TestEventPrinter::createTestShellPrinter):
47         * DumpRenderTree/chromium/TestEventPrinter.h:
48         * DumpRenderTree/chromium/TestShell.cpp:
49         (TestShell::TestShell):
50         (TestShell::createMainWindow):
51         (TestShell::createDRTDevToolsClient):
52         * DumpRenderTree/chromium/WebViewHost.cpp:
53         (WebViewHost::geolocationClientMock):
54         (WebViewHost::speechInputController):
55         (WebViewHost::deviceOrientationClientMock):
56         (WebViewHost::reset):
57         (WebViewHost::navigate):
58         (WebViewHost::setPendingExtraData):
59         (WebViewHost::canvas):
60         * DumpRenderTree/chromium/WebViewHost.h:
61
62 2011-04-26  Adam Roben  <aroben@apple.com>
63
64         Make DRT/win log loading errors the same way DRT/mac does
65
66         Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
67         http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
68
69         Reviewed by Alexey Proskuryakov.
70
71         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
72         (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
73         <rdar://problem/5064234>, which has long since been fixed, and then made this function match
74         -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
75
76 2011-04-26  Dan Bernstein  <mitz@apple.com>
77
78         REGRESSION (84876): build-webkit produces an error message
79         https://bugs.webkit.org/show_bug.cgi?id=59460
80
81         * Scripts/webkitdirs.pm:
82
83 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
84
85         Reviewed by Eric Seidel.
86
87         Fix timestamp comparison in check-for-weak-vtables-and-externals
88         https://bugs.webkit.org/show_bug.cgi?id=59416
89         
90         We should only re-run the check-for-weak-vtables-and-externals script
91         if the executable is more recent than the last run.
92
93         * Scripts/check-for-weak-vtables-and-externals:
94
95 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
96
97         Reviewed by Csaba Osztrogonác.
98
99         [Qt] Implement LayoutTestController::setAutofilled
100         https://bugs.webkit.org/show_bug.cgi?id=59439
101
102         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
103         (LayoutTestController::setAutofilled):
104         * DumpRenderTree/qt/LayoutTestControllerQt.h:
105
106 2011-04-25  Dan Bernstein  <mitz@apple.com>
107
108         Reviewed by Mark Rowe.
109
110         Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
111
112         * Scripts/webkitdirs.pm:
113
114 2011-04-25  Sam Weinig  <sam@webkit.org>
115
116         Reviewed by Adam Roben.
117
118         Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
119         https://bugs.webkit.org/show_bug.cgi?id=56090
120
121         Make LeaksViewer work with versions of browsers that don't support message
122         passing of cyclic structures.
123
124         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
125         (LeaksParser.this._worker.onmessage):
126         (LeaksParser):
127         (LeaksParser.prototype.addLeaksFile):
128         Use LeaksParserImpl directly if we don't support passing cyclic structures.
129
130         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
131         (LeaksParserImpl):
132         (LeaksParserImpl.prototype.addLeaksFile):
133         (LeaksParserImpl.prototype._incorporateLeaks):
134         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
135         (onmessage):
136         Factor out LeaksParser implementation into LeaksParserImpl.js.
137
138         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
139         (workersSupportCyclicStructures):
140         Add function to detect if workers support passing cyclic structures.
141
142         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
143         Add LeaksParserImpl.js include.
144
145 2011-04-25  Jeff Miller  <jeffm@apple.com>
146
147         Reviewed by Timothy Hatcher.
148
149         Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
150         https://bugs.webkit.org/show_bug.cgi?id=59373
151
152         * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
153
154 2011-04-25  Andrew Scherkus  <scherkus@chromium.org>
155
156         Reviewed by Dimitri Glazkov.
157
158         Adding a few Chromium contributors to committers.py.
159
160         https://bugs.webkit.org/show_bug.cgi?id=59327
161
162         * Scripts/webkitpy/common/config/committers.py:
163
164 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
165
166         Reviewed by Dimitri Glazkov.
167
168         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
169         https://bugs.webkit.org/show_bug.cgi?id=59284
170
171         Chromium DRT over-refcounted the NPObject wrappers it used to
172         marshal shadowRoot nodes back to tests (WebBindings::makeNode
173         births NPObjects with referenceCount == 1). This masked the GC bug
174         59284 in tests by making shadowRoot nodes live forever.
175
176         * DumpRenderTree/chromium/LayoutTestController.cpp:
177         (LayoutTestController::shadowRoot):
178         (LayoutTestController::ensureShadowRoot):
179
180 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
181
182         [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
183         and update the URL for downloading waf.
184         
185         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
186         (LayoutTestController::ensureShadowRoot):
187         (LayoutTestController::removeShadowRoot):
188         * Scripts/webkitdirs.pm:
189
190 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
191
192         Unreviewed, rolling out r84627.
193         http://trac.webkit.org/changeset/84627
194         https://bugs.webkit.org/show_bug.cgi?id=59271
195
196         It broke Symbian build (Requested by Ossy on #webkit).
197
198         * Scripts/webkitpy/style/checker.py:
199         * Scripts/webkitpy/style/checker_unittest.py:
200
201 2011-04-22  Dirk Pranke  <dpranke@chromium.org>
202
203         Reviewed by Adam Barth.
204
205         rebaseline-chromium-webkit-tests: clean up output
206         https://bugs.webkit.org/show_bug.cgi?id=59240
207
208         This change dramatically changes the output the tool provides
209         by default. The previous output (more or less) is still there
210         in -v / verbose / debug mode, but the default output is
211         way terser and more readable. It mostly says which files are
212         updated, which are duplicates, and which are not found in an
213         archive. Feedback desired :).
214
215         This change also adds a scm.exists() method to the SCM object
216         so that we can cleanly figure out what we're doing while
217         rebaselining.
218
219         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
220         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
221         * Scripts/webkitpy/common/system/filesystem_mock.py:
222         * Scripts/webkitpy/common/checkout/scm.py:
223         * Scripts/webkitpy/common/checkout/scm_unittest.py:
224
225 2011-04-22  Ilya Sherman  <isherman@chromium.org>
226
227         Reviewed by Alexey Proskuryakov.
228
229         Add Ilya Sherman (isherman@chromium.org) to the list of contributors
230         https://bugs.webkit.org/show_bug.cgi?id=59231
231
232         * Scripts/webkitpy/common/config/committers.py:
233
234 2011-04-22  Yuta Kitamura  <yutak@chromium.org>
235
236         Reviewed by Ojan Vafai.
237
238         new-run-webkit-tests: Exception raised when stderr contains binary data
239         https://bugs.webkit.org/show_bug.cgi?id=59083
240
241         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
242         Use write_binary_file() instead of write_text_file().
243
244 2011-04-22  Chang Shu  <cshu@webkit.org>
245
246         Reviewed by Kenneth Rohde Christiansen.
247
248         WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
249         https://bugs.webkit.org/show_bug.cgi?id=42536
250
251         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
252         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
253         (WTR::LayoutTestController::setFrameFlatteningEnabled):
254         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
255
256 2011-04-22  Adam Barth  <abarth@webkit.org>
257
258         Reviewed by Eric Seidel.
259
260         CommitQueue should remember the expected failures from patch to patch
261         https://bugs.webkit.org/show_bug.cgi?id=59253
262
263         Previously, we stored the set of expected failures on the task object,
264         which meant the commit-queue forgot about them after each patch.  This
265         patch moves them to the CommitQueue object so they will have a longer
266         lifetime.
267
268         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
269         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
270         * Scripts/webkitpy/tool/commands/queues.py:
271
272 2011-04-22  Sam Weinig  <sam@webkit.org>
273
274         Reviewed by Brian Weinstein.
275
276         WebKit2: Implement JavaScript unresponsiveness timer/callbacks
277         https://bugs.webkit.org/show_bug.cgi?id=59248
278
279         Stub out shouldInterruptJavaScript callbacks.
280
281         * MiniBrowser/mac/BrowserWindowController.m:
282         (-[BrowserWindowController awakeFromNib]):
283         * MiniBrowser/win/BrowserView.cpp:
284         (BrowserView::create):
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::TestController::createOtherPage):
287         (WTR::TestController::initialize):
288
289 2011-04-22  Daniel Bates  <dbates@webkit.org>
290
291         Reviewed by Csaba Osztrogonác.
292
293         webkit-patch land hangs if svn prompts for credentials
294         https://bugs.webkit.org/show_bug.cgi?id=31500
295
296         Make has_authorization_for_realm() return True only if there exists a credentials file
297         that contains either the word "password" or "passtype". We assume that these words don't
298         coincide with the actual credential data (e.g. a person's username is "password").
299
300         * Scripts/webkitpy/common/checkout/scm.py:
301         * Scripts/webkitpy/common/checkout/scm_unittest.py:
302           - Added test cases:
303             test_has_authorization_for_realm_using_credentials_with_passtype(),
304             test_has_authorization_for_realm_using_credentials_with_password(),
305             test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
306           - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
307             to better describe what it's testing.
308           - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
309             and return the result of calling has_authorization_for_realm() so that the caller can
310             assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
311             better reflect its new purpose.
312
313 2011-04-22  Adam Barth  <abarth@webkit.org>
314
315         Remove double-negative.  (Sorry this was bugging me.)
316
317         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
318
319 2011-04-22  Adam Barth  <abarth@webkit.org>
320
321         Reviewed by Eric Seidel.
322
323         Factor LayoutTestResultsReader out of CommitQueue
324         https://bugs.webkit.org/show_bug.cgi?id=59244
325
326         This code will be shared with the EWS when they start running tests.
327
328         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
329         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
330         * Scripts/webkitpy/tool/commands/queues.py:
331         * Scripts/webkitpy/tool/commands/queues_unittest.py:
332
333 2011-04-22  Eric Seidel  <eric@webkit.org>
334
335         Reviewed by Dimitri Glazkov.
336
337         webkit-patch rebaseline is broken
338         https://bugs.webkit.org/show_bug.cgi?id=59207
339
340         My recent changes to how LayoutTestResults.results_from_string
341         uncovered a bug in our use of urllib2.
342         We now are treating the return value from _fetch_results_html()
343         (which returns urllib2.openurl()) as a string.  That's incorrect,
344         the return value is a file-like object (which auto-converts to a
345         string in most cases).
346
347         I've updated our urllib2-using code to correctly call .read() on the
348         resulting object before treating it like a string.
349         Unfortunately there is no easy way to test this mis-understanding
350         of the openurl() semantics.
351
352         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
353
354 2011-04-22  Adam Barth  <abarth@webkit.org>
355
356         Reviewed by Eric Seidel.
357
358         Factor PatchAnalysis task out of CommitQueueTask
359         https://bugs.webkit.org/show_bug.cgi?id=59220
360
361         This is a first step towards teaching the EWS to run tests.
362
363         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
364         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
365         * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
366
367 2011-04-22  Philippe Normand  <pnormand@igalia.com>
368
369         Reviewed by Martin Robinson.
370
371         [GTK] DRT: implement eventSender.scalePageBy
372         https://bugs.webkit.org/show_bug.cgi?id=59082
373
374         * DumpRenderTree/gtk/EventSender.cpp:
375         (scalePageByCallback): scalePageBy() support.
376
377 2011-04-21  Eric Seidel  <eric@webkit.org>
378
379         Reviewed by Adam Barth.
380
381         LayoutTestResults should know how to handle NRWT json files
382         https://bugs.webkit.org/show_bug.cgi?id=59168
383
384         LayoutTestResults was originally created to be a parallel
385         to existing NRWT architecture for dealing with results files.
386         But then it turns out that NRWT has no such architecture. :(
387         So this patch writes the necessary code to handle reading
388         full_results.json and unexpected_results.json files from
389         NRWT layout-test-results directories.
390
391         LayoutTestResults has thus morphed from being ORWT-only to
392         supporting both ORWT and NRWT.  It's possible at some future
393         point that other pieces of the NRWT architecture will learn
394         how to read JSON files in which case this can go away.
395
396         This is all done for making it possible for the commit-queue
397         to run the tests using NWRT and be able to understand the results
398         (for flaky test reporting, etc.)
399
400         * Scripts/webkitpy/common/net/layouttestresults.py:
401         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
402         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
403         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
404         * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
405         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
406
407 2011-04-22  Yi Shen  <yi.4.shen@nokia.com>
408
409         Reviewed by Kenneth Rohde Christiansen.
410
411         [Qt] Upstream Symbian platform plugin
412         https://bugs.webkit.org/show_bug.cgi?id=58435
413
414         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
415
416         * Scripts/webkitpy/style/checker.py:
417         * Scripts/webkitpy/style/checker_unittest.py:
418
419 2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>
420
421         Reviewed by Csaba Osztrogonác.
422
423         [Qt][WK2] Qt should use the mac-wk2 skipped list
424         https://bugs.webkit.org/show_bug.cgi?id=58536
425
426         * Scripts/old-run-webkit-tests:
427
428 2011-04-21  Tony Chang  <tony@chromium.org>
429
430         Reviewed by Mihai Parparita.
431
432         Remove find-mismatched-layout-test-results since it's not needed in a
433         checksum free world.
434         https://bugs.webkit.org/show_bug.cgi?id=59156
435
436         * Scripts/find-mismatched-layout-test-results: Removed.
437
438 2011-04-21  Brent Fulgham  <bfulgham@webkit.org>
439
440         Reviewed by Martin Robinson.
441
442         Teach build-webkit and update-webkit that the WinCairo port does
443         not need the non-redistributable WebKitSupportLibraries.zip file.
444         Also append the _Cairo_CFLite label to the build target for the
445         default (no argument) case when building with '--wincairo'
446     
447         https://bugs.webkit.org/show_bug.cgi?id=58801
448
449         * Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
450           doesn't exist.
451         * Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
452           'Release' build target when passed the '--wincairo' flag.
453         * Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
454           doesn't exist.
455
456 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
457
458         Reviewed by Eric Seidel.
459
460         new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
461         https://bugs.webkit.org/show_bug.cgi?id=58758
462
463         Since worker_mixin is now only used by worker, there's no point
464         in having it split across two files.
465
466         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
467         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
468         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
469         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
470         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
471         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
472
473 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
474
475         Reviewed by Tony Chang.
476
477         new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
478         https://bugs.webkit.org/show_bug.cgi?id=58756
479
480         Since worker_mixin is now only used by worker, there's no point
481         in having it split across two files.
482
483         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
484         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
485
486 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
487
488         Reviewed by Tony Chang.
489
490         new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
491         https://bugs.webkit.org/show_bug.cgi?id=58754
492
493         test_runner hasn't been a great name for some time, since all of
494         the test running is actually done in worker and
495         single_test_runner. Rename to manager to match the terminology
496         elsewhere.
497
498         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
499         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
500         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
501         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
502         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
504
505 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Tony Chang.
508
509         new-run-webkit-tests: obsolete old threading code, part 2
510         https://bugs.webkit.org/show_bug.cgi?id=58753
511
512         This merges the test_runner2 code back into test_runner since
513         there's only a single type of test runner now.
514
515         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
516         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
518
519 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
520
521         Reviewed by Adam Roben.
522
523         Add a feature define to allow <details> and <summary> to be disabled
524         https://bugs.webkit.org/show_bug.cgi?id=59118
525         <rdar://problem/9257045>
526
527         * Scripts/build-webkit:
528         * Tools.pro:
529
530 2011-04-21  Adam Barth  <abarth@webkit.org>
531
532         Reviewed by Eric Seidel.
533
534         webkit-patch upload should assign the bug to you
535         https://bugs.webkit.org/show_bug.cgi?id=33699
536
537         This patch only re-assigns the bug if it is currently unassigned.  We
538         can be more aggressive in the future if people want us to be more
539         agressive.
540
541         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
542         * Scripts/webkitpy/tool/commands/upload_unittest.py:
543         * Scripts/webkitpy/tool/mocktool.py:
544         * Scripts/webkitpy/tool/steps/postdiff.py:
545
546 2011-04-21  Ojan Vafai  <ojan@chromium.org>
547
548         Reviewed by Tony Chang.
549
550         move json_results.html over to LayoutTests/fast/harness
551         https://bugs.webkit.org/show_bug.cgi?id=59154
552
553         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
554
555 2011-04-21  Adam Barth  <abarth@webkit.org>
556
557         Reviewed by Eric Seidel.
558
559         ValidateChangeLogs doesn't work on SVN
560         https://bugs.webkit.org/show_bug.cgi?id=59115
561
562         svn-create-patch lies about the diff in the working copy by moving
563         ChangeLog entries to the top of the diff.  That's fine on most cases,
564         but causes problems for ValidateChangeLogs, which is trying validate
565         the where the ChangeLog entry appears.
566
567         I haven't added a test for this change because I couldn't figure out
568         how to write one.  The issue is more of an integration issue, which
569         we're not really set up to test in our unit testing framework.  If this
570         patch had worked around the output from svn-create-patch, then I could
571         have tested that we behave correctly on sample svn-create-patch output,
572         but, in this case, I've removed the dependency on svn-create-patch.  I
573         could test that we behave correctly on "svn diff" output, but we
574         already have those tests.
575
576         * Scripts/webkitpy/tool/commands/download_unittest.py:
577         * Scripts/webkitpy/tool/mocktool.py:
578         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
579
580 2011-04-21  Tony Chang  <tony@chromium.org>
581
582         Reviewed by Ojan Vafai.
583
584         old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
585         https://bugs.webkit.org/show_bug.cgi?id=58402
586
587         * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
588         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
589         * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
590         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
591         * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
592         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
593
594 2011-04-21  Ojan Vafai  <ojan@chromium.org>
595
596         Reviewed by Tony Chang.
597
598         final tests for results.html file
599         https://bugs.webkit.org/show_bug.cgi?id=59150
600
601         This gets us close to 100% code coverage. Once this is
602         checked in, I'll move this file over to LayoutTests/fast/harness
603         and make it a proper layout test.
604
605         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
606         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
607
608 2011-04-21  Ojan Vafai  <ojan@chromium.org>
609
610         Reviewed by Tony Chang.
611
612         only expand visible rows
613         https://bugs.webkit.org/show_bug.cgi?id=59130
614
615         For the chromium port, where there are many expected failures,
616         expanding all of them is quite slow. Only expand the visible ones.
617         This makes the default case. Also, make the expanding async to
618         avoid totally killing the process.
619
620         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
621         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
622
623 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
624
625         [GTK] DRT: implement eventSender.scalePageBy
626         https://bugs.webkit.org/show_bug.cgi?id=59082
627
628         Rolling out r84507 since it broke many GTK+ tests.
629
630         * DumpRenderTree/gtk/EventSender.cpp:
631
632 2011-04-21  Sam Weinig  <sam@webkit.org>
633
634         Reviewed by Simon Fraser.
635
636         Add way to garbage collect between each test when running layout tests
637         https://bugs.webkit.org/show_bug.cgi?id=59126
638
639         * DumpRenderTree/mac/DumpRenderTree.mm:
640         (initializeGlobalsFromCommandLineOptions):
641         (runTest):
642         * Scripts/old-run-webkit-tests:
643         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
644         (WTR::InjectedBundle::didReceiveMessage):
645         * WebKitTestRunner/TestController.cpp:
646         (WTR::TestController::TestController):
647         (WTR::TestController::initialize):
648         (WTR::TestController::resetStateToConsistentValues):
649         * WebKitTestRunner/TestController.h:
650
651 2011-04-21  Ojan Vafai  <ojan@chromium.org>
652
653         Reviewed by Mihai Parparita.
654
655         fix another innocuous JS error in expand/collapseAllExpectations
656         https://bugs.webkit.org/show_bug.cgi?id=59122
657
658         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
659         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
660
661 2011-04-20  Ojan Vafai  <ojan@chromium.org>
662
663         Reviewed by Tony Chang.
664
665         put unexpected passes into their own table
666         https://bugs.webkit.org/show_bug.cgi?id=59016
667
668         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
669
670 2011-04-20  Ojan Vafai  <ojan@chromium.org>
671
672         Reviewed by Tony Chang.
673
674         initial set of tests for new results.html file
675         https://bugs.webkit.org/show_bug.cgi?id=59031
676
677         Also, fix the bugs (mostly innocuous JS errors) the tests found.
678
679         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
680         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
681
682 2011-04-21  Philippe Normand  <pnormand@igalia.com>
683
684         Reviewed by Martin Robinson.
685
686         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
687         https://bugs.webkit.org/show_bug.cgi?id=59086
688
689         callShouldCloseOnWebView() implementation.
690
691         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
692         (LayoutTestController::callShouldCloseOnWebView):
693
694 2011-04-21  Philippe Normand  <pnormand@igalia.com>
695
696         Reviewed by Martin Robinson.
697
698         [GTK] DRT: implement eventSender.scalePageBy
699         https://bugs.webkit.org/show_bug.cgi?id=59082
700
701         * DumpRenderTree/gtk/EventSender.cpp:
702         (scalePageByCallback): scalePageBy() support.
703
704 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
705
706         Reviewed by Dimitri Glazkov.
707
708         layoutTestController can create and destroy shadow DOM
709         https://bugs.webkit.org/show_bug.cgi?id=59058
710
711         Chromium, Mac, GTK and Qt DRT; and WK2 test runner.
712
713         * DumpRenderTree/LayoutTestController.cpp:
714         (ensureShadowRootCallback):
715         (removeShadowRootCallback):
716         (LayoutTestController::staticFunctions):
717         * DumpRenderTree/LayoutTestController.h:
718         * DumpRenderTree/chromium/LayoutTestController.cpp:
719         (LayoutTestController::LayoutTestController):
720         (LayoutTestController::ensureShadowRoot):
721         (LayoutTestController::removeShadowRoot):
722         * DumpRenderTree/chromium/LayoutTestController.h:
723         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
724         (LayoutTestController::ensureShadowRoot):
725         (LayoutTestController::removeShadowRoot):
726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
727         (LayoutTestController::shadowRoot):
728         (LayoutTestController::ensureShadowRoot):
729         (LayoutTestController::removeShadowRoot):
730         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
731         (LayoutTestController::ensureShadowRoot):
732         (LayoutTestController::removeShadowRoot):
733         * DumpRenderTree/qt/LayoutTestControllerQt.h:
734         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
735         (LayoutTestController::ensureShadowRoot):
736         (LayoutTestController::removeShadowRoot):
737         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
738         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
739         (WTR::LayoutTestController::shadowRoot):
740         (WTR::LayoutTestController::ensureShadowRoot):
741         (WTR::LayoutTestController::removeShadowRoot):
742         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
743
744 2011-04-20  Dirk Pranke  <dpranke@chromium.org>
745
746         Reviewed by Eric Seidel.
747
748         new-run-webkit-tests: handle ctrl-c more cleanly
749         https://bugs.webkit.org/show_bug.cgi?id=58849
750
751         * Scripts/new-run-webkit-tests:
752         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
753
754 2011-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
755
756         Unreviewed, rolling out r84431.
757         http://trac.webkit.org/changeset/84431
758         https://bugs.webkit.org/show_bug.cgi?id=59061
759
760         Breaks for folks who don't have editbugs (Requested by abarth
761         on #webkit).
762
763         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
764         * Scripts/webkitpy/tool/commands/upload_unittest.py:
765         * Scripts/webkitpy/tool/mocktool.py:
766         * Scripts/webkitpy/tool/steps/postdiff.py:
767
768 2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>
769
770         Unreviewed.
771
772         Adding myself to committers.py.
773
774         * Scripts/webkitpy/common/config/committers.py:
775
776 2011-04-20  Adam Barth  <abarth@webkit.org>
777
778         Reviewed by Eric Seidel.
779
780         webkit-patch upload should assign the bug to you
781         https://bugs.webkit.org/show_bug.cgi?id=33699
782
783         This patch only re-assigns the bug if it is currently unassigned.  We
784         can be more aggressive in the future if people want us to be more
785         agressive.
786
787         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
788         * Scripts/webkitpy/tool/commands/upload_unittest.py:
789         * Scripts/webkitpy/tool/mocktool.py:
790         * Scripts/webkitpy/tool/steps/postdiff.py:
791
792 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
793
794         Reviewed by Csaba Osztrogonác.
795
796         Modify builder.html template to allow easy access
797         to list more builds on the builder's page.
798
799         https://bugs.webkit.org/show_bug.cgi?id=59008
800
801         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
802
803 2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>
804
805         Reviewed by Csaba Osztrogonác.
806
807         Add the default template for builder page.
808
809         https://bugs.webkit.org/show_bug.cgi?id=59008
810
811         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
812
813 2011-04-20  Ojan Vafai  <ojan@chromium.org>
814
815         Reviewed by Eric Seidel.
816
817         move page generation into a single function
818         https://bugs.webkit.org/show_bug.cgi?id=59027
819
820         Now executing the script doesn't create any state. We should then
821         be able to write tests for this by setting custom results data.
822
823         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
824
825 2011-04-20  Ojan Vafai  <ojan@chromium.org>
826
827         Reviewed by Eric Seidel.
828
829         move global state into a shared object
830         https://bugs.webkit.org/show_bug.cgi?id=59023
831
832         This makes the code more testable.
833
834         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
835
836 2011-04-20  Ojan Vafai  <ojan@chromium.org>
837
838         Reviewed by Tony Chang.
839
840         move global state into a shared object
841         https://bugs.webkit.org/show_bug.cgi?id=59023
842
843         This makes the code more testable.
844
845         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
846
847 2011-04-20  Ojan Vafai  <ojan@chromium.org>
848
849         Reviewed by Eric Seidel.
850
851         add expandAll/collapseAll links
852         https://bugs.webkit.org/show_bug.cgi?id=59011
853
854         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
855
856 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
857
858         [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
859
860         * Scripts/webkitdirs.pm:
861         * wx/build/build_utils.py:
862         * wx/build/settings.py:
863         * wx/install-unix-extras:
864         * wx/packaging/build-mac-installer.py:
865         * wx/packaging/build-win-installer.py:
866
867 2011-04-20  Adam Roben  <aroben@apple.com>
868
869         Replace old-run-webkit-tests's win-7 platform with win-7sp0
870
871         It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
872         version of Windows we cared about, so its results should just go in win. But now that
873         Windows 7 SP1 exists (and has different results for some tests), we need a place to store
874         results for Windows 7 without SP1 (and older versions of Windows).
875
876         Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
877         differences from Windows 7 "SP0"
878
879         Reviewed by David Kilzer.
880
881         * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
882         will just use "win".
883
884         * Scripts/webkitdirs.pm:
885         (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
886
887 2011-04-20  Adam Roben  <aroben@apple.com>
888
889         Teach webkitdirs::winVersion about build numbers
890
891         The build number isn't currently used, but soon will be.
892
893         As a bonus, winVersion now works on non-Cygwin variants of Perl!
894
895         Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
896         SP1
897
898         Reviewed by Anders Carlsson.
899
900         * Scripts/webkitdirs.pm:
901         (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
902         (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
903         number. Parse the version number into a hash, similar to how osXVersion() works.
904
905         (isWindows7):
906         (isWindowsVista):
907         (isWindowsXP):
908         Updated for changes to winVersion().
909
910 2011-04-20  W. James MacLean  <wjmaclean@chromium.org>
911
912         Reviewed by Kenneth Russell.
913
914         Add support for composite-to-texture to DumpRenderTree.
915         https://bugs.webkit.org/show_bug.cgi?id=58675
916
917         * DumpRenderTree/chromium/DumpRenderTree.cpp:
918         (main):
919         * DumpRenderTree/chromium/TestShell.cpp:
920         (TestShell::TestShell):
921         (TestShell::resetWebSettings):
922         * DumpRenderTree/chromium/TestShell.h:
923         (TestShell::setCompositeToTexture):
924         * DumpRenderTree/chromium/WebPreferences.cpp:
925         (WebPreferences::reset):
926         (WebPreferences::applyTo):
927         * DumpRenderTree/chromium/WebPreferences.h:
928
929 2011-04-19  Eric Seidel  <eric@webkit.org>
930
931         Reviewed by Adam Barth.
932
933         The commit-queue is confused when non-layout tests fail
934         https://bugs.webkit.org/show_bug.cgi?id=58955
935
936         As seen in http://queues.webkit.org/results/8474435
937
938         It fails to create an archive of the layout test results
939         and then throws an exception.
940
941         I've fixed this by making it catch the exception as well
942         as made it so it never calls that path in the common case.
943
944         I've updated MockFileSystem to understand rmtree's affect on
945         directories as well as files.
946
947         * Scripts/webkitpy/common/system/filesystem_mock.py:
948         * Scripts/webkitpy/common/system/workspace.py:
949         * Scripts/webkitpy/tool/commands/queues.py:
950         * Scripts/webkitpy/tool/commands/queues_unittest.py:
951         * Scripts/webkitpy/tool/mocktool.py:
952
953 2011-04-19  Ojan Vafai  <ojan@chromium.org>
954
955         Fix check for whether a failure is expected to deal with
956         flaky tests and FAIL expectations.
957         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
958
959 2011-04-19  Ojan Vafai  <ojan@chromium.org>
960
961         Reviewed by Eric Seidel.
962
963         don't show missing text results for tests that only dump image results
964         https://bugs.webkit.org/show_bug.cgi?id=58931
965
966         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
967         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
968
969 2011-04-19  Ojan Vafai  <ojan@chromium.org>
970
971         Reviewed by Eric Seidel.
972
973         don't show failures table if there are only new tests
974         https://bugs.webkit.org/show_bug.cgi?id=58929
975
976         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
977
978 2011-04-19  Ojan Vafai  <ojan@chromium.org>
979
980         Reviewed by Eric Seidel.
981
982         don't show failures table if there are only new tests
983         https://bugs.webkit.org/show_bug.cgi?id=58929
984
985         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
986
987 2011-04-19  Ojan Vafai  <ojan@chromium.org>
988
989         Fix unittest failures from http://trac.webkit.org/changeset/84294.
990
991         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
992         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
993
994 2011-04-18  Ojan Vafai  <ojan@chromium.org>
995
996         Reviewed by Eric Seidel.
997
998         switch new-run-webkit-tests to using the new results file
999         https://bugs.webkit.org/show_bug.cgi?id=58861
1000
1001         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1002         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1003         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1004
1005 2011-04-19  Renata Hodovan  <reni@webkit.org>
1006
1007         Reviewed by Eric Seidel.
1008
1009         Move the alignment related macros from Vector.h to new Alignment.h.
1010         https://bugs.webkit.org/show_bug.cgi?id=56000
1011
1012         Adding the new file to the forwarding headers of Tools.
1013
1014         * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
1015
1016 2011-04-19  Kevin Ollivier  <kevino@theolliviers.com>
1017
1018         [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
1019
1020         * wx/packaging/build-win-installer.py:
1021         * wx/packaging/wxWebKitInstaller.iss.in:
1022
1023 2011-04-19  Adam Roben  <aroben@apple.com>
1024
1025         Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
1026
1027         * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
1028         accelerated compositing is disabled.
1029
1030 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1031
1032         Remove accidentally committed debug code.
1033         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1034
1035 2011-04-19  Brent Fulgham  <bfulgham@webkit.org>
1036
1037         Unreviewed build correction.
1038
1039         Avoid duplicate stub implementation of test routine
1040         for WinCairo build.
1041
1042         * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
1043         WinCairo from using this stub.
1044
1045 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1046
1047         Reviewed by Eric Seidel.
1048
1049         make results file work with audio and reftests
1050         https://bugs.webkit.org/show_bug.cgi?id=58860
1051
1052         Also fix bug with timeout tests and store a bit in the JSON
1053         for new image tests instead of loading the image result to check if it's there.
1054
1055         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1056         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1057
1058 2011-04-19  Jer Noble  <jer.noble@apple.com>
1059
1060         Reviewed by Adam Roben.
1061
1062         REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
1063         https://bugs.webkit.org/show_bug.cgi?id=58890
1064
1065         Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
1066         Defaults to false.
1067
1068         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
1069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1070         (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
1071         (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
1072         (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
1073         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1074         (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
1075         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1076         (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
1077         (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
1078
1079 2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1080
1081         Reviewed by Andreas Kling.
1082
1083         [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
1084         https://bugs.webkit.org/show_bug.cgi?id=35086
1085
1086         fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
1087         a DRT sideeffect problem, because the resetSettings didn't set
1088         the default value of LocalContentCanAccessFileUrls.
1089
1090         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1091         (WebCore::WebPage::resetSettings):
1092
1093 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
1094
1095         Reviewed by Martin Robinson.
1096
1097         [GTK] Need support for dumping focus rectangles in pixel results
1098         https://bugs.webkit.org/show_bug.cgi?id=53647
1099
1100         Dump the selection rect if it has been requested.
1101
1102         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1103         (createBitmapContextFromWebView):
1104
1105 2011-04-18  Eric Seidel  <eric@webkit.org>
1106
1107         Reviewed by Adam Barth.
1108
1109         test-webkitpy should run the ActiveWorkItems tests
1110         https://bugs.webkit.org/show_bug.cgi?id=58859
1111
1112         Also make the unit tests pass. :)
1113
1114         * QueueStatusServer/model/activeworkitems.py:
1115         * QueueStatusServer/model/queue.py:
1116         * QueueStatusServer/model/workitems.py:
1117
1118 2011-04-18  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by Adam Barth.
1121
1122         queues.webkit.org should show trailing-days pass counts for queues
1123         https://bugs.webkit.org/show_bug.cgi?id=58812
1124
1125         This lets us see if each bot is pulling its own weight or not.
1126         Before I wrote this patch our suspicious was that one of the
1127         cq bots was doing most of the work.  Turns out they're actually
1128         pretty even in their recent pass counts.
1129
1130         * QueueStatusServer/handlers/queuestatus.py:
1131         * QueueStatusServer/index.yaml:
1132         * QueueStatusServer/templates/queuestatus.html:
1133
1134 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1135
1136         Reviewed by Eric Seidel.
1137
1138         new-run-webkit-tests: obsolete old threading code, part 1
1139         https://bugs.webkit.org/show_bug.cgi?id=58752
1140
1141         This patch removes support for the 'old-inline' and
1142         'old-threads' worker models, and deletes the corresponding code.
1143         Now that the new code is stable, this stuff is no longer
1144         necessary.
1145
1146         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
1147         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
1148         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
1149         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1151         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1152
1153 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Eric Seidel.
1156
1157         new-run-webkit-tests: add an --additional-drt-flag option
1158         https://bugs.webkit.org/show_bug.cgi?id=58680
1159
1160         NRWT has a bunch of command line flags that exist to pass
1161         custom flags to DRT, especially on chromium. It would be nice
1162         if there was a generic mechanism to pass through flags so we
1163         didn't have all the custom ones.
1164
1165         * Scripts/webkitpy/layout_tests/port/chromium.py:
1166         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1167         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1168         * Scripts/webkitpy/layout_tests/port/test.py:
1169         * Scripts/webkitpy/layout_tests/port/webkit.py:
1170         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1171
1172 2011-04-05  Jer Noble  <jer.noble@apple.com>
1173
1174         Reviewed by Sam Weinig.
1175
1176         WebKit2: WKTR should support WebKit2 full screen APIs
1177         https://bugs.webkit.org/show_bug.cgi?id=56318
1178
1179         Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing 
1180         WKTR to test the LayoutTest/fullscreen/ tests.
1181
1182         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1183         (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
1184         (WTR::InjectedBundlePage::supportsFullScreen): Added.
1185         (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
1186         (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
1187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1188         * WebKitTestRunner/TestController.cpp:
1189         (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
1190
1191 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1192
1193         Reviewed by Tony Chang.
1194
1195         new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
1196         https://bugs.webkit.org/show_bug.cgi?id=58388
1197
1198         * Scripts/webkitpy/layout_tests/port/chromium.py:
1199
1200 2011-04-18  Evan Martin  <evan@chromium.org>
1201
1202         Reviewed by Eric Seidel.
1203
1204         [chromium] expose title direction to webkit client
1205         https://bugs.webkit.org/show_bug.cgi?id=58823
1206
1207         * DumpRenderTree/chromium/LayoutTestController.cpp:
1208         (LayoutTestController::LayoutTestController):
1209         (LayoutTestController::reset):
1210         * DumpRenderTree/chromium/LayoutTestController.h:
1211         (LayoutTestController::setTitleTextDirection):
1212         Add member and setter to let us stash the title direction at load time.
1213
1214         * DumpRenderTree/chromium/WebViewHost.cpp:
1215         (WebViewHost::didReceiveTitle):
1216         * DumpRenderTree/chromium/WebViewHost.h:
1217         Adapt to new API; push the title into layoutTestController when we
1218         receive it.
1219
1220 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1221
1222         Unreviewed.
1223
1224         Re-land r84112. It was rolled out in r84127 but it didn't need
1225         to be. Only r84111 actually broke things.
1226
1227         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1228         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1229
1230 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1231
1232         Reviewed by Tony Chang.
1233
1234         new-run-webkit-tests: don't run more processes than necessary
1235         https://bugs.webkit.org/show_bug.cgi?id=58751
1236
1237         Previously NRWT would start up 1 process for each processor on
1238         the machine by default, which was a waste if we were only
1239         running a few shards of tests.
1240
1241         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1242         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1243         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1244
1245 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1246
1247         Reviewed by Eric Seidel.
1248
1249         include links to actual.png files for new pixel tests
1250         https://bugs.webkit.org/show_bug.cgi?id=58831
1251
1252         Load image elements to confirm whether the files exist.
1253         Image elements will load without being appended to the DOM.
1254
1255         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1256
1257 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1258
1259         Reviewed by Eric Seidel.
1260
1261         add a zoomed view for pixel results to the new results html file
1262         https://bugs.webkit.org/show_bug.cgi?id=58827
1263
1264         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1265
1266 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1267
1268         Reviewed by Eric Seidel.
1269
1270         add labels to results html page
1271         https://bugs.webkit.org/show_bug.cgi?id=58803
1272
1273         -fix iframe size to be the size of the png results
1274         -fix a bunch of aesthetic nits
1275         -fix some incorrectly styled code
1276
1277         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1278
1279 2011-04-18  Chang Shu  <cshu@webkit.org>
1280
1281         Reviewed by Eric Seidel.
1282
1283         WebKitTestRunner needs layoutTestController.pathToLocalResource
1284         https://bugs.webkit.org/show_bug.cgi?id=42541
1285
1286         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1287         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1288         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1289         (WTR::LayoutTestController::pathToLocalResource):
1290         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1291         (WTR::LayoutTestController::pathToLocalResource):
1292         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1293         (WTR::LayoutTestController::pathToLocalResource):
1294
1295 2011-04-18  Timothy Hatcher  <timothy@apple.com>
1296
1297         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
1298         now that all localized strings in WebKit/win use WEB_UI_STRING.
1299
1300         https://webkit.org/b/58747
1301
1302         Reviewed by Dan Bernstein.
1303
1304         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
1305
1306 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
1307
1308         Reviewed by Adam Roben.
1309
1310         [WIN] Use WCHAR instead of TCHAR
1311         https://bugs.webkit.org/show_bug.cgi?id=58755
1312
1313         We always use the UNICODE versions of windows functions, so
1314         the usage of TCHAR makes no sense and mixing them is bad style.
1315
1316         * WinLauncher/PrintWebUIDelegate.cpp:
1317           Also fix various style issues (including indentation and removal of ugly C-casts).
1318         * WinLauncher/WinLauncher.cpp:
1319
1320 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
1321
1322         Reviewed by Andreas Kling.
1323
1324         Add layoutTestController.shadowRoot to Qt DRT.
1325         https://bugs.webkit.org/show_bug.cgi?id=58759
1326
1327         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1328         (LayoutTestController::shadowRoot): Added.
1329         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1330
1331 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1332
1333         Unreviewed, rolling out r84111.
1334         http://trac.webkit.org/changeset/84111
1335         https://bugs.webkit.org/show_bug.cgi?id=58771
1336
1337         Chromium linux layout tests are broken. (Requested by loislo2
1338         on #webkit).
1339
1340         * Scripts/webkitpy/layout_tests/port/chromium.py:
1341         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1342         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1343
1344 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1345
1346         Unreviewed, rolling out r84112.
1347         http://trac.webkit.org/changeset/84112
1348         https://bugs.webkit.org/show_bug.cgi?id=58770
1349
1350         Chromium linux layout tests are broken. (Requested by loislo2
1351         on #webkit).
1352
1353         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1354         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1355
1356 2011-04-17  Daniel Bates  <dbates@webkit.org>
1357
1358         Reviewed by Eric Seidel and Adam Barth.
1359
1360         webkit-patch land hangs if svn prompts for credentials
1361         https://bugs.webkit.org/show_bug.cgi?id=31500
1362
1363         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
1364
1365         * Scripts/webkitpy/common/checkout/scm.py:
1366           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
1367           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
1368             for argument realm; modified call sites as needed.
1369           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
1370           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
1371           - Modified Git._commit_on_branch() to take optional username and password argument.
1372           - Modified Git.push_local_commits_to_server() to take optional username and password
1373             argument and to call has_authorization_for_realm().
1374         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1375           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
1376           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
1377             SVN.has_authorization_for_realm().
1378         * Scripts/webkitpy/common/net/credentials.py:
1379           - Modified Credentials.read_credentials() to call User.prompt_password() instead
1380             of using getpass.getpass() directly.
1381         * Scripts/webkitpy/common/system/user.py:
1382           - Added User.prompt_password().
1383         * Scripts/webkitpy/tool/steps/commit.py:
1384           - Modified Commit.run() to prompt for a password if needed.
1385
1386 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
1387
1388         Reviewed by Ojan Vafai.
1389
1390         new-run-webkit-tests: save stderr into the layout-test-results dir
1391         https://bugs.webkit.org/show_bug.cgi?id=58690
1392
1393         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1394         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1395
1396 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Ojan Vafai.
1399
1400         new-run-webkit-tests: read stderr from chromium DRT separately
1401         https://bugs.webkit.org/show_bug.cgi?id=58708
1402
1403         * Scripts/webkitpy/layout_tests/port/chromium.py:
1404         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1405         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1406
1407 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1408
1409         Reviewed by Adam Barth.
1410
1411         Rename PLATFORM(CA) to USE(CA)
1412         https://bugs.webkit.org/show_bug.cgi?id=58742
1413
1414         * DumpRenderTree/mac/DumpRenderTree.mm:
1415         (resetDefaultsToConsistentValues):
1416
1417 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1418
1419         Reviewed by Adam Barth.
1420
1421         Rename PLATFORM(CG) to USE(CG)
1422         https://bugs.webkit.org/show_bug.cgi?id=58729
1423
1424         * DumpRenderTree/PixelDumpSupport.cpp:
1425         * DumpRenderTree/chromium/WebViewHost.cpp:
1426         (WebViewHost::paintRect):
1427         * DumpRenderTree/config.h:
1428         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1429         (createBitmapContextFromWebView):
1430         * TestWebKitAPI/PlatformWebView.h:
1431         * WebKitTestRunner/config.h:
1432         * WebKitTestRunner/win/TestInvocationWin.cpp:
1433
1434 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         Rename PLATFORM(CAIRO) to USE(CAIRO)
1439         https://bugs.webkit.org/show_bug.cgi?id=55192
1440
1441         * DumpRenderTree/PixelDumpSupport.cpp:
1442         * DumpRenderTree/config.h:
1443         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1444         (createBitmapContextFromWebView):
1445         * WebKitTestRunner/config.h:
1446
1447 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1448
1449         Reviewed by Eric Seidel.
1450
1451         show diffs+test inline in the results page
1452         https://bugs.webkit.org/show_bug.cgi?id=58723
1453         
1454         Put each row in it's own tbody and sort based on tbodies. That way
1455         we can append the results to the tbody inline as another table row.
1456
1457         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1458
1459 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1460
1461         Reviewed by Eric Seidel.
1462
1463         handle new tests in the new results html file
1464         https://bugs.webkit.org/show_bug.cgi?id=58715
1465
1466         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1467
1468 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1469
1470         Reviewed by Ojan Vafai.
1471
1472         old-run-webkit-tests: save the list of tests actually run to a file
1473         https://bugs.webkit.org/show_bug.cgi?id=58692
1474
1475         * Scripts/old-run-webkit-tests:
1476
1477 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1478
1479         Reviewed by Ojan Vafai.
1480
1481         fix MockFileSystem.abspath() on windows
1482         https://bugs.webkit.org/show_bug.cgi?id=58713
1483
1484         The existing code was borked on Windows if a path was passed
1485         in using a drive letter (e.g., "d:\foo.txt"), and would go
1486         into an infinite recursive loop. While win paths shouldn't
1487         normally be passed into the mock filesystem, this just
1488         bulletproofs things a bit (note that "/foo.txt" is considered
1489         an absolute path on windows python as well.
1490
1491         * Scripts/webkitpy/common/system/filesystem_mock.py:
1492
1493 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1494
1495         Reviewed by Eric Seidel.
1496
1497         show stderr files and httpd log files
1498         https://bugs.webkit.org/show_bug.cgi?id=58714
1499
1500         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1501         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1502
1503 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1504
1505         Reviewed by James Robinson.
1506
1507         Add a flag to guard Page Visibility API changes.
1508         https://bugs.webkit.org/show_bug.cgi?id=58464
1509
1510         * Scripts/build-webkit:
1511
1512 2011-04-15  Chang Shu  <cshu@webkit.org>
1513
1514         Reviewed by Alexey Proskuryakov.
1515
1516         When a message with url embedded is added to console, the "file:" scheme
1517         and path should be stripped.
1518         https://bugs.webkit.org/show_bug.cgi?id=58665
1519
1520         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1521         (WTR::lastFileURLPathComponent):
1522         (WTR::InjectedBundlePage::willAddMessageToConsole):
1523
1524 2011-04-15  Jeff Miller  <jeffm@apple.com>
1525
1526         Reviewed by Sam Weinig.
1527
1528         Add takeFocus callback to WKPageUIClient
1529         https://bugs.webkit.org/show_bug.cgi?id=58686
1530
1531         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
1532
1533         * MiniBrowser/mac/BrowserWindowController.m:
1534         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
1535         * MiniBrowser/win/BrowserView.cpp:
1536         (BrowserView::create): Added empty takeFocus entry.
1537         * WebKitTestRunner/TestController.cpp:
1538         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
1539         (WTR::TestController::initialize): Added empty takeFocus entry.
1540
1541 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1542
1543         Reviewed by Eric Seidel.
1544
1545         only show pretty-diff/wdiff if they were generated
1546         https://bugs.webkit.org/show_bug.cgi?id=58682
1547
1548         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1549         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1550         * Scripts/webkitpy/layout_tests/port/base.py:
1551
1552 2011-04-15  Andreas Kling  <kling@webkit.org>
1553
1554         Reviewed by Antonio Gomes.
1555
1556         [Qt] DRT: Default custom policy delegate decision should be Ignore.
1557
1558         If layoutTestController.setCustomPolicyDelegate() is called with only
1559         one argument, the second ("permissive") should default to false.
1560
1561         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1562
1563 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1564
1565         Reviewed by Eric Seidel.
1566
1567         fix path to layout test in new results file
1568         https://bugs.webkit.org/show_bug.cgi?id=58618
1569
1570         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1571         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1572
1573 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1574
1575         Reviewed by Eric Seidel.
1576
1577         fix sorting in new results file
1578         https://bugs.webkit.org/show_bug.cgi?id=58616
1579
1580         -Fix the custom sort to return -1, 0, 1 instead of true/false.
1581         -Secondary sort by test name when sort values are equal.
1582         -Sort by test name by default.
1583
1584         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1585
1586 2011-04-15  Dmitry Lomov  <dslomov@google.com>
1587
1588         Reviewed by David Levin.
1589
1590         check-webkit-style shouldn't complain about not including a primary header file 
1591         if none exists
1592         https://bugs.webkit.org/show_bug.cgi?id=39514
1593
1594         * Scripts/webkitpy/style/checkers/cpp.py:
1595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1596
1597 2011-04-15  Eric Seidel  <eric@webkit.org>
1598
1599         Reviewed by Mihai Parparita.
1600
1601         queues.webkit.org should display when a bot last rebooted
1602         https://bugs.webkit.org/show_bug.cgi?id=58562
1603
1604         There is more repeated code here than I would like.  I fear
1605         my django-fu isn't quite up to snuff.
1606
1607         * QueueStatusServer/handlers/queuestatus.py:
1608         * QueueStatusServer/templates/queuestatus.html:
1609
1610 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1611
1612         Reviewed by Adam Barth.
1613
1614         Remove dependency on chromium skia::PlatformCanvas
1615         https://bugs.webkit.org/show_bug.cgi?id=57563
1616         
1617         Fixed compile error on Mac when using Core Graphics.
1618
1619         * DumpRenderTree/chromium/WebViewHost.cpp:
1620         (WebViewHost::paintRect):
1621
1622 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1623
1624         Reviewed by James Robinson.
1625
1626         Remove dependency on chromium skia::PlatformCanvas
1627         https://bugs.webkit.org/show_bug.cgi?id=57563
1628
1629         * DumpRenderTree/chromium/TestShell.cpp:
1630         (makeCanvasOpaque):
1631         (TestShell::dumpImage):
1632         * DumpRenderTree/chromium/TestShell.h:
1633         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1634         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1635         (WebThemeControlDRTWin::draw):
1636         (WebThemeControlDRTWin::drawTextField):
1637         (WebThemeControlDRTWin::drawProgressBar):
1638         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1639         * DumpRenderTree/chromium/WebViewHost.cpp:
1640         (WebViewHost::canvas):
1641         * DumpRenderTree/chromium/WebViewHost.h:
1642
1643 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
1644
1645         Reviewed by Laszlo Gombos.
1646
1647         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
1648         https://bugs.webkit.org/show_bug.cgi?id=58007
1649
1650         Adds flag to start the test browsers maximized.
1651         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
1652         suit.
1653         Also fixes some ToggleFullScreen issues so that prior window state is
1654         restored.
1655
1656         * MiniBrowser/qt/BrowserWindow.cpp:
1657         (BrowserWindow::BrowserWindow):
1658         (BrowserWindow::toggleFullScreenMode):
1659         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1660         (MiniBrowserApplication::handleUserOptions):
1661         * MiniBrowser/qt/MiniBrowserApplication.h:
1662         (WindowOptions::WindowOptions):
1663         * QtTestBrowser/launcherwindow.cpp:
1664         (LauncherWindow::init):
1665         (LauncherWindow::toggleFullScreenMode):
1666         * QtTestBrowser/launcherwindow.h:
1667         (WindowOptions::WindowOptions):
1668         * QtTestBrowser/main.cpp:
1669         (LauncherApplication::handleUserOptions):
1670
1671 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1672
1673         Reviewed by Eric Seidel.
1674
1675         add checkbox to only show unexpected results to new results file
1676         https://bugs.webkit.org/show_bug.cgi?id=58606
1677
1678         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1679
1680 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1681
1682         Reviewed by Martin Robinson.
1683
1684         [WinCairo] Implement ImageDiff Logic.
1685         http://bugs.webkit.org/show_bug.cgi?id=58486
1686
1687         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
1688         (strtof):
1689         (readFromData):
1690         (createImageFromStdin):
1691         (releaseMallocBuffer):
1692         (createDifferenceImage):
1693         (imageHasAlpha):
1694         (writeToData):
1695         (main):
1696         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
1697           ImageDiffCairo.cpp (excluding from Apple builds).
1698         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
1699           new ImageDiffWinCairoCommon.vsprops file.
1700         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
1701           new ImageDiffWinCairoCommon.vsprops file.
1702         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
1703         * Scripts/old-run-webkit-tests: Make sure proper executable
1704           is built and executed for WinCairo port.
1705
1706 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1707
1708         Reviewed by Eric Seidel.
1709
1710         only show expected failure type for ports that use an expectations file
1711         https://bugs.webkit.org/show_bug.cgi?id=58588
1712
1713         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1714         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1715
1716 2011-04-14  Eric Seidel  <eric@webkit.org>
1717
1718         Reviewed by Adam Barth.
1719
1720         commit-queue fails to catch IOError when results.html is missing
1721         https://bugs.webkit.org/show_bug.cgi?id=58589
1722
1723         * Scripts/webkitpy/tool/commands/queues.py:
1724         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1725
1726 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1727
1728         [wx] Unreviewed build fix for Mac installation script.
1729
1730         * wx/packaging/build-mac-installer.py:
1731
1732 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1733
1734         Reviewed by Tony Chang.
1735
1736         sort columns in the new json_results.html file
1737         https://bugs.webkit.org/show_bug.cgi?id=58581
1738
1739         Also fix padding on TDs and the path to layout tests.
1740
1741         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1742
1743 2011-04-14  Eric Seidel  <eric@webkit.org>
1744
1745         Reviewed by Dimitri Glazkov.
1746
1747         queues.webkit.org should display when a bot last passed a patch
1748         https://bugs.webkit.org/show_bug.cgi?id=58546
1749
1750         I am suspicious that some of our commit-queue instances are never
1751         actually passing anything.
1752
1753         This will let us know if those bots are never passing patches.
1754
1755         * QueueStatusServer/handlers/queuestatus.py:
1756         * QueueStatusServer/index.yaml:
1757         * QueueStatusServer/templates/queuestatus.html:
1758
1759 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
1760
1761         Reviewed by Adam Roben.
1762
1763         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
1764         https://bugs.webkit.org/show_bug.cgi?id=58545
1765
1766         Remove platform-specific overrides; the default behavior should
1767         be working everywhere now, I think.
1768
1769         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1770         * Scripts/webkitpy/layout_tests/port/mac.py:
1771
1772 2011-04-14  Eric Seidel  <eric@webkit.org>
1773
1774         Reviewed by Adam Barth.
1775
1776         commit-queues are hitting an exception trying to land when the tree is red
1777         https://bugs.webkit.org/show_bug.cgi?id=58558
1778
1779         Just an un-tested (and thus broken) code path from yesterday's changes.
1780
1781         * Scripts/webkitpy/common/net/layouttestresults.py:
1782         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1783         * Scripts/webkitpy/tool/commands/queues.py:
1784         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1785
1786 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1787
1788         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
1789
1790         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1791         (LayoutTestController::shadowRoot):
1792         * wx/build/wxpresets.py:
1793
1794 2011-04-14  Victoria Kirst  <vrk@google.com>
1795
1796         Reviewed by James Robinson.
1797
1798         [chromium] Failing GPU video tests
1799         https://bugs.webkit.org/show_bug.cgi?id=57926
1800
1801         Added/updated GPU directory names for rebaseline tool.
1802
1803         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1804
1805 2011-04-13  Daniel Bates  <dbates@rim.com>
1806
1807         Reviewed by Adam Barth.
1808
1809         Perl unit test removeEOL.pl should print test case name on failure
1810         https://bugs.webkit.org/show_bug.cgi?id=58513
1811
1812         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
1813           second argument of Test::Simple::ok().
1814
1815 2011-04-13  Kent Tamura  <tkent@chromium.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         gdb-safari should pass arguments to safari.
1820         https://bugs.webkit.org/show_bug.cgi?id=58439
1821
1822         We can do:
1823           gdb-safari --debug LayoutTests/.../foo.html
1824
1825         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
1826
1827 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1828
1829         Unreviewed, build fix.
1830         https://bugs.webkit.org/show_bug.cgi?id=52763
1831
1832         r83799 broke test-webkitpy because it assumed we always have
1833         access to a real filesystem (we don't during the unit tests).
1834         Stubbing out the copy for now but we might need a better
1835         solution at some point.
1836
1837         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1838
1839 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Reviewed by Tony Chang.
1842
1843         new-run-webkit-tests --run-singly option is busted
1844         https://bugs.webkit.org/show_bug.cgi?id=55909
1845
1846         Python's broken lexical scoping strikes again :(.
1847
1848         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1849         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1850
1851 2011-04-13  Ojan Vafai  <ojan@chromium.org>
1852
1853         Reviewed by Eric Seidel.
1854
1855         generated unexpected_results.html from unexpected_results.json
1856         https://bugs.webkit.org/show_bug.cgi?id=52763
1857
1858         Eventually, we'll merge this with results.html and have a single richer results page.
1859         For now, I just want to get something checked in that we can iterate on.
1860
1861         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
1862         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1863
1864 2011-04-13  Eric Seidel  <eric@webkit.org>
1865
1866         Reviewed by Adam Barth.
1867
1868         Up the failure limit to allow the commit-queue to actually land when the tree is red
1869         https://bugs.webkit.org/show_bug.cgi?id=58499
1870
1871         This change increases the --exit-after-N-failures limit used by the commit-queue
1872         from 1 to 10.  This will cause the code added in bug 58494 to actually get
1873         exercised and the queues should start being able to land when the trees are red.
1874
1875         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
1876         only unit test to actually detect this change!  Since we don't actually
1877         run on leopard anymore, I removed the hack code and repurposed the test.
1878
1879         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1880         * Scripts/webkitpy/tool/steps/runtests.py:
1881         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1882
1883 2011-04-13  Eric Seidel  <eric@webkit.org>
1884
1885         Reviewed by Adam Barth.
1886
1887         commit-queue should be able to land when tree is red
1888         https://bugs.webkit.org/show_bug.cgi?id=58494
1889
1890         There is some yak hair on my hands, I will admit.
1891
1892         This change is mostly about adding an ExpectedFailures
1893         class to track when the bots are red and we should be
1894         ignoring failures when landing from the commit-queue.
1895
1896         However, to make intelligent decisions about patches we
1897         need to know whether the run hit the --exit-after-N-failures limit
1898         or not.  Right now that information is not saved off in results.html
1899         so we have to pull the information from RunTests.
1900
1901         I've plumbed the --exit-after-N-failures information into
1902         LayoutTestResults for now to make the ExpectedFailures code cleaner.
1903
1904         As a result of adding all these additional calls to delegate.layout_test_results()
1905         I broke some of our flaky test detection tests and had to re-write them
1906         to not depend on the number of layout_test_results code.
1907
1908         At the same time I updated the commit-queue to use the newer filesystem
1909         API (to allow us to use MockFileSystem) which required further changes
1910         to the layout tests.  Changes were required in either case, since
1911         we're now calling layout_test_results() in more cases, which previously
1912         would try and hit the disk (until I moved it to use tool.filesystem).
1913
1914         I should note that *all* of this code is disabled for now, since our
1915         --exit-after-N-failures limit is currently 1!  (Thus were always in the
1916         case where we can't actually tell if the layout test results are legit.)
1917         I will up that limit in a second patch (which may require a couple more unit test tweaks).
1918
1919         * Scripts/webkitpy/common/net/layouttestresults.py:
1920         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1921         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1922         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
1923         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
1924         * Scripts/webkitpy/tool/commands/queues.py:
1925         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1926         * Scripts/webkitpy/tool/commands/queuestest.py:
1927         * Scripts/webkitpy/tool/steps/runtests.py:
1928
1929 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1930
1931         Unreviewed build correction.
1932
1933         * TestWebKitAPI/PlatformWebView.h: Limit include of
1934           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
1935
1936 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1937
1938         Reviewed by Eric Seidel.
1939
1940         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
1941         https://bugs.webkit.org/show_bug.cgi?id=58489
1942         
1943         r83743 added --additional-platform-directory to old-run-webkit-tests,
1944         rename the equivalent flag in new-run-webkit-tests to be consistent.
1945
1946         * Scripts/webkitpy/layout_tests/port/base.py:
1947         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1948         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1950
1951 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1952
1953         Reviewed by Eric Seidel.
1954
1955         Rebaseline queue server
1956         https://bugs.webkit.org/show_bug.cgi?id=57891
1957
1958         Adds a simple rebaseline queue server (meant to run at
1959         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
1960         builders and their failing tests, and allows those tests to be added to
1961         a per-builer rebaseline queue.
1962
1963         A subsequent change will add a mode to NRWT (and/or a wrapper script)
1964         for pulling the tests to be rebaselined from the server and running them
1965         with --reset-results (the initial use-case is for the GPU hardware bots,
1966         which do not have checked-in baselines, therefore there is no need for a
1967         check-in step yet).
1968
1969         * RebaselineQueueServer/app.yaml: Added.
1970         * RebaselineQueueServer/handlers/__init__.py: Added.
1971         * RebaselineQueueServer/handlers/builderqueue.py: Added.
1972         * RebaselineQueueServer/handlers/pages.py: Added.
1973         * RebaselineQueueServer/index.yaml: Added.
1974         * RebaselineQueueServer/main.py: Added.
1975         * RebaselineQueueServer/model/__init__.py: Added.
1976         * RebaselineQueueServer/model/queueentry.py: Added.
1977         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
1978         * RebaselineQueueServer/static/styles.css: Added.
1979         * RebaselineQueueServer/templates/builder-picker.html: Added.
1980         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
1981         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
1982         * RebaselineQueueServer/templates/home.html: Added.
1983
1984 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1985
1986         Reviewed by Mihai Parparita.
1987
1988         nrwt: enable multiple processes by default on Chromium Win.
1989         https://bugs.webkit.org/show_bug.cgi?id=55163
1990
1991         Re-land r79268; it should be more stable now and will hopefully
1992         work.
1993
1994         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1995         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1996
1997 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1998
1999         Reviewed by Ojan Vafai.
2000
2001         new-run-webkit-tests: configure logging in child processes properly
2002         https://bugs.webkit.org/show_bug.cgi?id=58296
2003
2004         Logging propagated properly from manager to worker processes on
2005         Unix but not on Windows; this fixes that.
2006
2007         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2008         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2009
2010 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2011
2012         Reviewed by Ojan Vafai.
2013
2014         new-run-webkit-tests: suppress extraneous pretty patch warnings
2015         https://bugs.webkit.org/show_bug.cgi?id=58295
2016
2017         NRWT wasn't being careful about when it logged messages from
2018         PrettyPatch not being available; it should only log during
2019         check_build(), and be silent otherwise. This was causing us to
2020         get multiple errors at runtime, which was confusing.
2021
2022         * Scripts/webkitpy/layout_tests/port/base.py:
2023         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2024         * Scripts/webkitpy/layout_tests/port/chromium.py:
2025
2026 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2027
2028         Reviewed by Jian Li.
2029
2030         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
2031         https://bugs.webkit.org/show_bug.cgi?id=58461
2032
2033         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2034
2035 2011-04-13  Tony Chang  <tony@chromium.org>
2036
2037         Unreviewed, fix NRWT.  Stack:
2038
2039             return super(ChromiumPort, self).results_directory(self)
2040         TypeError: results_directory() takes exactly 1 argument (2 given)
2041
2042         * Scripts/webkitpy/layout_tests/port/chromium.py:
2043
2044 2011-04-13  Adam Roben  <aroben@apple.com>
2045
2046         Teach ORWT about extra platform-specific directories to be searched before the default ones
2047
2048         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
2049         platform-specific results
2050
2051         Reviewed by Anders Carlsson.
2052
2053         * Scripts/old-run-webkit-tests:
2054         (top-level): Added @additionalPlatformDirectories and hooked up
2055         --additional-platform-directories to populate it.
2056         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
2057         list (after filtering out any of the additional directories that don't exist).
2058
2059 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2060
2061         Reviewed by Adam Roben.
2062
2063         Add the /T command to taskkill.exe.
2064         This will kill spawned child processes.
2065         
2066         * BuildSlaveSupport/win/kill-old-processes:
2067
2068 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2069
2070         Reviewed by Adam Roben.
2071
2072         Sort kill list alphabeticaly.
2073         Fixed capitalization on VcBuildHelper.  
2074
2075         * BuildSlaveSupport/win/kill-old-processes:
2076
2077 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2078
2079         Reviewed by Adam Roben.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=58384
2082         Update kill-old-processes to include a few new ones.
2083         
2084         * BuildSlaveSupport/win/kill-old-processes:
2085
2086 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
2087
2088         Reviewed by Martin Robinson.
2089
2090         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
2091         https://bugs.webkit.org/show_bug.cgi?id=58297
2092
2093         Do not disable flash specifically when built with GTK+ 3 -
2094         PluginPackage should do the right thing while loading plugins.
2095
2096         * GtkLauncher/main.c:
2097         (main):
2098
2099 2011-04-12  Kent Tamura  <tkent@chromium.org>
2100
2101         Reviewed by Dimitri Glazkov.
2102
2103         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
2104         https://bugs.webkit.org/show_bug.cgi?id=57426
2105
2106         * DumpRenderTree/chromium/WebPreferences.cpp:
2107         (WebPreferences::applyTo): Disable the validation message timer.
2108
2109 2011-04-12  James Kozianski  <koz@chromium.org>
2110
2111         Unreviewed.
2112
2113         Adding myself to committers.py.
2114
2115         * Scripts/webkitpy/common/config/committers.py:
2116
2117 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
2118
2119         Unreviewed build correction for WinCairo bot after r83639.
2120         https://bugs.webkit.org/show_bug.cgi?id=51790
2121
2122         Correct typo for the new "update-webkit-wincairo-libs" script.
2123
2124         * Scripts/build-webkit: Incorrectly calling the
2125           update-webkit-cairo-libs which does not exist.
2126
2127 2011-04-12  Alice Liu  <alice.liu@apple.com>
2128
2129         Reviewed by Jon Honeycutt.
2130
2131         A change that should have been part of http://trac.webkit.org/changeset/83628
2132
2133         * DumpRenderTree/win/DumpRenderTree.cpp:
2134         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
2135
2136 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2137
2138         Reviewed by Tony Chang.
2139
2140         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
2141         https://bugs.webkit.org/show_bug.cgi?id=58272
2142
2143         NRWT was interpreting the --results-directory cmd line arg as
2144         relative to the build directory, not the current working
2145         directory (ORWT uses the latter, which is much more intuitive).
2146         
2147         This patch fixes the base case, but includes an override for
2148         Chromium that is needed until the bots can be updated.
2149
2150         * Scripts/webkitpy/layout_tests/port/base.py:
2151         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2152         * Scripts/webkitpy/layout_tests/port/chromium.py:
2153         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2154         * Scripts/webkitpy/layout_tests/port/test.py:
2155         * Scripts/webkitpy/layout_tests/port/webkit.py:
2156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2157         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2158
2159 2011-04-12  Philippe Normand  <pnormand@igalia.com>
2160
2161         Unreviewed, roll out r83621 as it broke the GTK build.
2162
2163         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
2164         https://bugs.webkit.org/show_bug.cgi?id=58333
2165
2166         * Scripts/build-jsc:
2167         * Scripts/build-webkit:
2168
2169 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
2170
2171         Reviewed by Adam Roben.
2172
2173         Patch to download the WinCairo dependancies as part of build-webkit.
2174         https://bugs.webkit.org/show_bug.cgi?id=51790
2175
2176         This patch downloads the dependancies from 
2177             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
2178         checking the modification timestamp etc. 
2179
2180         * Tools/Scripts/build-webkit
2181         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
2182           flag, and to update WinCairo dependencies when used.
2183         * Tools/Scripts/update-webkit-cairo-libs: added
2184         * Tools/Scripts/update-webkit-dependency: added
2185         * Tools/Scripts/update-webkit-auxiliary-libs
2186
2187 2011-04-12  Jeff Miller  <jeffm@apple.com>
2188
2189         Reviewed by Adam Roben.
2190
2191         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
2192         https://bugs.webkit.org/show_bug.cgi?id=56020
2193
2194         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
2195         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
2196         which would generate two characters for every keypress (for example).  I didn't bother doing this for
2197         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
2198         
2199         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
2200
2201         * MiniBrowser/win/main.cpp:
2202         (shouldTranslateMessage): Added.
2203         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
2204         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
2205         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
2206         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
2207         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
2208         (TestWebKitAPI::runAndWatchForWMChar): Added.
2209         (TestWebKitAPI::TEST): Added.
2210         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2211         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
2212         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
2213         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2214         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
2215         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
2216
2217 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2218
2219         Reviewed by Tony Chang.
2220
2221         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
2222         https://bugs.webkit.org/show_bug.cgi?id=58290
2223
2224         This is some preliminary refactoring for bug 58272.
2225
2226         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2227         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2228         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2229         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2230         * Scripts/webkitpy/layout_tests/port/test.py:
2231         * Scripts/webkitpy/layout_tests/port/chromium.py:
2232         * Scripts/webkitpy/layout_tests/port/base.py:
2233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2234
2235 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Eric Seidel.
2238
2239         webkitpy: fix mock_filesystem abspath to handle relative paths
2240         and add filesystem.chdir() and filesystem.getcwd() to be able
2241         to test this and mock it out.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=58288
2244
2245         * Scripts/webkitpy/common/system/filesystem.py:
2246         * Scripts/webkitpy/common/system/filesystem_mock.py:
2247         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2248
2249 2011-04-12  Alice Liu  <alice.liu@apple.com>
2250
2251         Reviewed by Sam Weinig.
2252
2253         https://bugs.webkit.org/show_bug.cgi?id=58292
2254         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
2258
2259 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
2260
2261         Reviewed by Eric Seidel.
2262
2263         [Qt] Enable JIT build for SH4 platforms.
2264         https://bugs.webkit.org/show_bug.cgi?id=58317
2265
2266
2267         * DumpRenderTree/qt/DumpRenderTree.pro:
2268         * QtTestBrowser/QtTestBrowser.pro:
2269         * Scripts/webkitdirs.pm:
2270
2271 2011-04-12  Tony Chang  <tony@chromium.org>
2272
2273         Reviewed by Andreas Kling.
2274
2275         [Qt] embed checksums in PNGs written by Qt-DRT
2276         https://bugs.webkit.org/show_bug.cgi?id=58173
2277
2278         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2279         (WebCore::DumpRenderTree::dump):
2280
2281 2011-04-12  Eric Seidel  <eric@webkit.org>
2282
2283         Reviewed by Adam Barth.
2284
2285         commit-queue should upload failure diffs when tests fail
2286         https://bugs.webkit.org/show_bug.cgi?id=58348
2287
2288         This change was mostly just plumbing.  We were already saving
2289         this information for flaky test reporting.  I just made it possible
2290         for normal failures to report archives as well.
2291
2292         I did a little abstraction work to try and share some code between
2293         flakytestreporter.py and this new code.  There is still more we could do.
2294
2295         In making this change I also went through and updated the various
2296         places we have urls hard-coded in our python and pointed them at
2297         common.config.urls.
2298
2299         * Scripts/webkitpy/common/checkout/scm.py:
2300         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2301         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2302         * Scripts/webkitpy/common/net/statusserver.py:
2303         * Scripts/webkitpy/layout_tests/port/base.py:
2304         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
2305         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
2306         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2307         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2308         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2309         * Scripts/webkitpy/tool/commands/queues.py:
2310
2311 2011-04-12  Daniel Bates  <dbates@rim.com>
2312
2313         Rubber-stamped by Eric Seidel.
2314
2315         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
2316         with Windows line endings
2317         https://bugs.webkit.org/show_bug.cgi?id=53625
2318
2319         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
2320         applied to an SCM checkout on a Windows file system and vice-versa.
2321
2322         This issue manifests itself due to custom SCM settings as well as differences in
2323         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
2324         into svn-apply/unapply to compensate for differences in line endings by converting
2325         the line endings in a patch to match the line endings in the target file (if it exists).
2326
2327         * Scripts/VCSUtils.pm:
2328           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
2329             content read from the specified file handle. Obviously, this heuristic will not work
2330             for files with mixed line endings, but I don't envision such files to be the norm. If
2331             this turns out to be an issue then we can improve the heuristic.
2332           - Added firstEOLInFile().
2333           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
2334             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
2335             endings in the diff instead of the line endings in the target file.
2336           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
2337             re-used in parseDiff().
2338         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
2339           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
2340           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
2341         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
2342         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
2343
2344 2011-04-12  Sam Weinig  <sam@webkit.org>
2345
2346         Reviewed by Adam Roben.
2347
2348         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
2349         https://bugs.webkit.org/show_bug.cgi?id=58336
2350
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::TestController::resetStateToConsistentValues):
2353         Remove cache clearing as that is causing tests to crash on Windows 7.
2354
2355 2011-04-11  Sam Weinig  <sam@webkit.org>
2356
2357         Reviewed by Anders Carlsson.
2358
2359         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
2360         <rdar://problem/8981346>
2361         https://bugs.webkit.org/show_bug.cgi?id=54159
2362
2363         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2364         (WTR::InjectedBundlePage::InjectedBundlePage):
2365         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2366         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
2367         (WTR::InjectedBundlePage::decidePolicyForResponse):
2368         (WTR::InjectedBundlePage::unableToImplementPolicy):
2369         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2370         Add short-circuited policy client which matches WebKit1.
2371
2372         * WebKitTestRunner/TestController.cpp:
2373         (WTR::TestController::resetStateToConsistentValues):
2374         Clear the cache between tests to ensure consistent results.
2375
2376 2011-04-11  George Guo  <George.Guo@nokia.com>
2377
2378         Reviewed by Eric Seidel.
2379
2380         prepare-ChangeLog support email input but -h did not show the option
2381         https://bugs.webkit.org/show_bug.cgi?id=58164
2382
2383         Add email option to -h to improve the usability
2384
2385         * Scripts/prepare-ChangeLog:
2386
2387 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
2388
2389         Reviewed by Eric Carlson.
2390
2391         Rename MediaControls to MediaControlRootElement.
2392         https://bugs.webkit.org/show_bug.cgi?id=58250
2393
2394         * Scripts/do-webcore-rename: Documented the renaming.
2395
2396 2011-04-11  Sam Weinig  <sam@webkit.org>
2397
2398         Fix Windows build.
2399
2400         * MiniBrowser/win/BrowserView.cpp:
2401         (BrowserView::create):
2402
2403 2011-04-11  Sam Weinig  <sam@webkit.org>
2404
2405         Reviewed by Anders Carlsson.
2406
2407         Move focus management out of WebKit via  the UIClient
2408         <rdar://problem/8784068>
2409         https://bugs.webkit.org/show_bug.cgi?id=58278
2410
2411         * MiniBrowser/mac/BrowserWindowController.m:
2412         (-[BrowserWindowController awakeFromNib]):
2413         * WebKitTestRunner/TestController.cpp:
2414         (WTR::TestController::createOtherPage):
2415         (WTR::TestController::initialize):
2416         Add stubs for new UIClient functions.
2417
2418 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2419
2420         Reviewed by Eric Seidel.
2421
2422         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
2423         https://bugs.webkit.org/show_bug.cgi?id=53605
2424
2425         Add an implementation of the PlainTextController for the GTK+ DRT.
2426
2427         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2428         (addControllerToWindow): Added this helper method.
2429         (webViewWindowObjectCleared): Use the new helper to add EventSender
2430         and the PlainTextController to the window object.
2431         * GNUmakefile.am: Added PlainTextController source files.
2432         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
2433         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
2434         until that functionality exists somewhere in the WebKitGTK+ stack.
2435         * DumpRenderTree/gtk/PlainTextController.h: Added.
2436
2437 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
2438
2439         Unreviewed.
2440
2441         Adding my IRC nick.
2442
2443         * Scripts/webkitpy/common/config/committers.py:
2444
2445 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2446
2447         Reviewed by Adam Roben.
2448
2449         new-run-webkit-tests: fix crash when running under windows cmd.exe
2450         https://bugs.webkit.org/show_bug.cgi?id=58197
2451
2452         We would intermittently crash when running NRWT directly under
2453         cmd.exe on windows because we were sharing the stdin file
2454         descriptor between the python process and the http server.
2455         cmd.exe really didn't like that, and there was no reason to
2456         share the descriptor, so we now use a PIPE instead.
2457
2458         * Scripts/webkitpy/layout_tests/port/http_server.py:
2459
2460 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2461
2462         Reviewed by Ojan Vafai.
2463
2464         new-run-webkit-tests: add unit tests for Port.diff_image()
2465         https://bugs.webkit.org/show_bug.cgi?id=58196
2466
2467         Add the unit tests for the fix in bug 58195.
2468
2469         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2470         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2471         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2472
2473 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2474
2475         Reviewed by Tony Chang.
2476
2477         new-run-webkit-tests: implement support for audio, take two
2478         https://bugs.webkit.org/show_bug.cgi?id=58195
2479
2480         Attempt to re-land the fix for bug 58101 (which was initially
2481         landed in r83330, but rolled out). This is the same patch but
2482         fixes crashes in Port.diff_image() caused by the change for
2483         empty image files being None instead of ''.
2484
2485         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2486         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2487         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2488         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2489         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2490         * Scripts/webkitpy/layout_tests/port/base.py:
2491         * Scripts/webkitpy/layout_tests/port/chromium.py:
2492         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2493         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2494         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2495         * Scripts/webkitpy/layout_tests/port/test.py:
2496         * Scripts/webkitpy/layout_tests/port/webkit.py:
2497
2498 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2499
2500         Reviewed by Xan Lopez.
2501
2502         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
2503         https://bugs.webkit.org/show_bug.cgi?id=57854
2504
2505         Implement missing features in GTK's DRT.
2506
2507         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2508         (indexRangeInTable): New helper function to get the range string
2509         for the current cell inside the parent table, either from the
2510         point of view of rows or columns.
2511         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
2512         the new helper function indexRangeInTable().
2513         (AccessibilityUIElement::columnIndexRange): Ditto.
2514
2515 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2516
2517         Reviewed by Chris Fleizach.
2518
2519         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
2520         https://bugs.webkit.org/show_bug.cgi?id=57826
2521
2522         Implement missing feature in GTK's DRT.
2523
2524         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2525         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
2526         relying on the analogous function from the AtkTable interface.
2527
2528 2011-04-05  Timothy Hatcher  <timothy@apple.com>
2529
2530         Fix the extract-localizable-strings script errors that started after
2531         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
2532
2533         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
2534
2535 2011-04-11  Tony Chang  <tony@chromium.org>
2536
2537         Reviewed by Eric Seidel.
2538
2539         fix crc computation on 64 bit machines
2540         https://bugs.webkit.org/show_bug.cgi?id=58243
2541
2542         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
2543
2544         * DumpRenderTree/CyclicRedundancyCheck.cpp:
2545         (makeCrcTable):
2546         (computeCrc):
2547         * DumpRenderTree/CyclicRedundancyCheck.h:
2548         * DumpRenderTree/PixelDumpSupport.cpp:
2549         (appendIntToVector):
2550         (convertChecksumToPNGComment):
2551
2552 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
2553
2554         Reviewed by Eric Seidel.
2555
2556         Require no undefined symbols during compilation.
2557
2558         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
2559         https://bugs.webkit.org/show_bug.cgi?id=54896
2560
2561         Add -Wl,--no-undefined to catch missing symbols early.
2562
2563         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2564         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2565
2566 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2567
2568         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
2569
2570         * wx/build/settings.py:
2571
2572 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2573
2574         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
2575
2576         * wx/build/settings.py:
2577
2578 2011-04-10  David Levin  <levin@chromium.org>
2579
2580         Reviewed by Dimitri Glazkov.
2581
2582         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
2583         https://bugs.webkit.org/show_bug.cgi?id=58201
2584
2585         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
2586         and filed bug 58202.
2587
2588 2011-04-09  David Levin  <levin@chromium.org>
2589
2590         Unreviewed, rolling out r83394.
2591         http://trac.webkit.org/changeset/83394
2592         https://bugs.webkit.org/show_bug.cgi?id=53625
2593
2594         Patch was incorrect as noted in the bug.
2595
2596         * Scripts/svn-apply:
2597
2598 2011-04-09  David Levin  <levin@chromium.org>
2599
2600         Reviewed by Adam Barth.
2601
2602         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
2603         https://bugs.webkit.org/show_bug.cgi?id=53625
2604
2605         * Scripts/svn-apply: Ensure that the portions of patches
2606         which are for vcproj/vsprops files has DOS line endings.
2607
2608 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
2609
2610         Reviewed by Tony Chang.
2611
2612         It looks like NRWT has not been stopping DRT/TestShell
2613         instances properly on windows, probably for a long time.
2614         This would go a long way to explaining why we often have
2615         processes lying around :)
2616
2617         https://bugs.webkit.org/show_bug.cgi?id=57807
2618
2619         * Scripts/webkitpy/layout_tests/port/chromium.py:
2620         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2621
2622 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
2623
2624         Reviewed by Laszlo Gombos.
2625
2626         [Qt] Don't link against fontconfig or X11 if embedded
2627         https://bugs.webkit.org/show_bug.cgi?id=58104
2628
2629         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
2630         * QtTestBrowser/QtTestBrowser.pro: ditto
2631         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
2632         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
2633
2634 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
2635
2636         http/tests/loading/preload-append-scan.php is failing on Windows
2637         https://bugs.webkit.org/show_bug.cgi?id=58178
2638
2639         Reviewed by Brian Weinstein.
2640
2641         * DumpRenderTree/win/DumpRenderTree.cpp:
2642         (lastPathComponent):
2643         Use CFURL API to find the last path component, rather than
2644         PathFindFileName(), because the latter will include the query string.
2645
2646 2011-04-08  Jian Li  <jianli@chromium.org>
2647
2648         Unreviewed, rolling out r83327, r83330 since these patches are very
2649         likely to break chromium webkit mac10.6 builders.
2650
2651         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2652         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2653         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2654         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2655         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2656         * Scripts/webkitpy/layout_tests/port/base.py:
2657         * Scripts/webkitpy/layout_tests/port/chromium.py:
2658         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2659         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2660         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2661         * Scripts/webkitpy/layout_tests/port/test.py:
2662         * Scripts/webkitpy/layout_tests/port/webkit.py:
2663
2664 2011-04-08  Vincent Scheib  <scheib@chromium.org>
2665
2666         Reviewed by Eric Seidel.
2667
2668         add chromium-gpu-linux-x86_64 to the recognized list of ports
2669         https://bugs.webkit.org/show_bug.cgi?id=58099
2670
2671         Add chromium-gpu-linux-x86_64 to fix assert.
2672
2673         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2674
2675 2011-04-08  Alpha Lam  <hclam@chromium.org>
2676
2677         Unreviewed, rolling out r83335.
2678         http://trac.webkit.org/changeset/83335
2679         https://bugs.webkit.org/show_bug.cgi?id=53556
2680
2681         GTK and QT bots are broken
2682
2683         * Scripts/build-webkit:
2684
2685 2011-04-07  Anna Cavender  <annacc@chromium.org>
2686
2687         Reviewed by Eric Carlson.
2688
2689         Setup ENABLE(TRACK) feature define
2690         https://bugs.webkit.org/show_bug.cgi?id=53556
2691
2692         * Scripts/build-webkit:
2693
2694 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
2695
2696         Reviewed by Adam Roben.
2697
2698         new-run-webkit-tests: configure a NRWT test bot for Mac SL
2699         https://bugs.webkit.org/show_bug.cgi?id=58114
2700
2701         This change removes the old new-run-webkit-tests entry and
2702         updates it for a new test-only bot.
2703
2704         * BuildSlaveSupport/build.webkit.org-config/config.json:
2705
2706 2011-04-08  Dominic Cooney  <dominicc@google.com>
2707
2708         Reviewed by Adam Roben.
2709
2710         Make layoutTestController.shadowRoot return null, not undefined,
2711         when its argument is invalid.
2712         https://bugs.webkit.org/show_bug.cgi?id=58121
2713
2714         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2715         (LayoutTestController::shadowRoot):
2716         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2717         (WTR::LayoutTestController::shadowRoot):
2718
2719 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
2720
2721         Reviewed by Adam Roben.
2722
2723         Locate NSTD.EXE in 64-bit Windows
2724         https://bugs.webkit.org/show_bug.cgi?id=57847
2725
2726         * Scripts/old-run-webkit-tests:
2727
2728 2011-04-08  Adam Roben  <aroben@apple.com>
2729
2730         Qt build fix
2731
2732         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
2733
2734 2011-04-07  Adam Roben  <aroben@apple.com>
2735
2736         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
2737
2738         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
2739         plugin
2740
2741         Reviewed by Anders Carlsson.
2742
2743         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2744         (pluginLogWithArguments): Moved code to format and log the message here...
2745         (pluginLog): ...from here.
2746
2747         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
2748
2749         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2750         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
2751
2752         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
2753
2754         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
2755         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
2756         to begin.
2757         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
2758         constructor.
2759         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
2760         can be used to invoke our setWillBeDestroyed function.
2761         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
2762         anything unexpected happens).
2763         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
2764         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
2765         NPP_SetWindow was *not* called during destruction.
2766         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
2767         method, setWillBeDestroyed.
2768         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
2769         object.
2770
2771         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2772         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2773         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2774         * GNUmakefile.am:
2775         Added new test.
2776
2777         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
2778         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
2779
2780 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
2781
2782         Reviewed by Martin Robinson.
2783
2784         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
2785         https://bugs.webkit.org/show_bug.cgi?id=58039
2786
2787         Implement missing functions in GTK's DRT.
2788
2789         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2790         (AccessibilityUIElement::increment): Implemented.
2791         (AccessibilityUIElement::decrement): Implemented.
2792
2793 2011-04-08  Dominic Cooney  <dominicc@google.com>
2794
2795         Reviewed by Kent Tamura.
2796
2797         Make WK2 layoutTestController.shadowRoot return undefined, not
2798         null, when its argument is not an element.
2799         https://bugs.webkit.org/show_bug.cgi?id=58121
2800
2801         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2802         (WTR::LayoutTestController::shadowRoot):
2803
2804 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
2805
2806         Reviewed by Mihai Parparita.
2807
2808         Change reference port for Mac GPU baselines from
2809         Leopard to SnowLeopard, XP to Win7, and Linux-x86
2810         to Linux x86-64.
2811
2812         https://bugs.webkit.org/show_bug.cgi?id=58099
2813
2814         * Scripts/webkitpy/layout_tests/port/chromium.py:
2815
2816 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
2817
2818         Revert ENABLE_TRACK patch due to compile failures.
2819
2820         * Scripts/build-webkit:
2821
2822 2011-04-07  Tony Chang  <tony@chromium.org>
2823
2824         Reviewed by Eric Seidel.
2825
2826         update DRT to embed checksums in png files
2827         https://bugs.webkit.org/show_bug.cgi?id=57871
2828
2829         We insert the bytes for the comment in printPNG rather than at encode
2830         time because each platform does its own PNG encoding (either using CG
2831         or cairo).  Putting this in pringPNG avoids having to duplicate this
2832         code, although it's not as clean as doing it at encoding time.
2833
2834         We insert the comment right after the IHDR chunk of the PNG.
2835
2836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2837         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
2838         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2839         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2840         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
2841         * DumpRenderTree/PixelDumpSupport.cpp:
2842         (dumpWebViewAsPixelsAndCompareWithExpected):
2843         (convertChecksumToPNGComment): Generate the bytes to insert.
2844         (printPNG): Insert the png comment before the first IDAT section.
2845         * DumpRenderTree/PixelDumpSupport.h:
2846         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2847         (printPNG):
2848         (dumpBitmap):
2849         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2850         (printPNG):
2851         (dumpBitmap):
2852         * DumpRenderTree/win/DumpRenderTree.vcproj:
2853         * GNUmakefile.am:
2854
2855 2011-04-07  Jeff Miller  <jeffm@apple.com>
2856
2857         Reviewed by Adam Roben.
2858
2859         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
2860         https://bugs.webkit.org/show_bug.cgi?id=58058
2861
2862         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2863         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
2864
2865 2011-04-07  Chang Shu  <cshu@webkit.org>
2866
2867         Reviewed by Darin Adler.
2868
2869         WebKitTestRunner needs layoutTestController.isPageBoxVisible
2870         https://bugs.webkit.org/show_bug.cgi?id=42695
2871
2872         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2873         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2874         (WTR::LayoutTestController::isPageBoxVisible):
2875         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2876
2877 2011-04-07  Adam Roben  <aroben@apple.com>
2878
2879         Build fix
2880
2881         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
2882
2883 2011-04-07  Adam Roben  <aroben@apple.com>
2884
2885         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
2886
2887         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
2888         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
2889         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
2890         be overridden by subclasses to provide extra URLs before we call up to the base class (after
2891         which adding more URLs is no longer possible).
2892
2893         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
2894         bot results page
2895
2896         Reviewed by John Sullivan.
2897
2898         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2899         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
2900         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
2901         method is never called for MasterShellCommands.
2902         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
2903         with this method (which is).
2904
2905 2011-04-07  Adam Roben  <aroben@apple.com>
2906
2907         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
2908
2909         This matches how most of our other build steps work, so is good just for improving
2910         consistency between build steps. It should also make it possible for
2911         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
2912         trying to do this in finished() after we had called up to the base class, but that was
2913         apparently too late to add more URLs.)
2914
2915         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
2916         results page
2917
2918         Reviewed by John Sullivan.
2919
2920         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2921         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
2922         call setText to get the right text to show up for this step. This matches how most of our
2923         other build steps work.
2924         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
2925         This is how most of our other build steps work.
2926         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
2927         function, to match the base class.
2928
2929 2011-04-07  Adam Barth  <abarth@webkit.org>
2930
2931         Reviewed by Maciej Stachowiak.
2932
2933         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
2934         https://bugs.webkit.org/show_bug.cgi?id=58022
2935
2936         Previously, we were ignoring the args variable!  This patch fixes the
2937         regression introduced in http://trac.webkit.org/changeset/82771.
2938
2939         * Scripts/webkitpy/tool/commands/download_unittest.py:
2940         * Scripts/webkitpy/tool/mocktool.py:
2941         * Scripts/webkitpy/tool/steps/checkstyle.py:
2942
2943 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
2944
2945         Reviewed by Adam Barth.
2946
2947         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
2948         https://bugs.webkit.org/show_bug.cgi?id=58017
2949
2950         * Scripts/webkitpy/common/checkout/scm.py:
2951         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2952
2953 2011-04-06  Chang Shu  <cshu@webkit.org>
2954
2955         Reviewed by Darin Adler.
2956
2957         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
2958         https://bugs.webkit.org/show_bug.cgi?id=57984
2959
2960         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2961         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2962         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
2963         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2964
2965 2011-04-06  Chris Rogers  <crogers@google.com>
2966
2967         Reviewed by Tony Chang.
2968
2969         Add web audio support to DumpRenderTree (mac port)
2970         https://bugs.webkit.org/show_bug.cgi?id=57969
2971
2972         * DumpRenderTree/LayoutTestController.cpp:
2973         (LayoutTestController::LayoutTestController):
2974         (setEncodedAudioDataCallback):
2975         (LayoutTestController::staticFunctions):
2976         * DumpRenderTree/LayoutTestController.h:
2977         (LayoutTestController::dumpAsAudio):
2978         (LayoutTestController::setDumpAsAudio):
2979         (LayoutTestController::encodedAudioData):
2980         (LayoutTestController::setEncodedAudioData):
2981         * DumpRenderTree/mac/DumpRenderTree.mm:
2982         (dumpAudio):
2983         (dump):
2984
2985 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
2986
2987         Reviewed by Kenneth Rohde Christiansen.
2988
2989         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
2990         https://bugs.webkit.org/show_bug.cgi?id=56086
2991
2992         Add the missing method.
2993
2994         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2995         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
2996         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2997         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2998         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2999
3000 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
3001
3002         Reviewed by David Levin.
3003
3004         Add QUOTA build flag for unified quota API
3005         https://bugs.webkit.org/show_bug.cgi?id=57918
3006
3007         * Scripts/build-webkit: Added QUOTA build flag
3008
3009 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
3010
3011         Reviewed by Tony Chang.
3012
3013         Adjust the apple webkit port's default timeout to match
3014         old-run-webkit-tests at 35 seconds.
3015
3016         https://bugs.webkit.org/show_bug.cgi?id=37738
3017
3018         * Scripts/webkitpy/layout_tests/port/mac.py:
3019
3020 2011-04-06  Scott Cameron  <sccameron@rim.com>
3021
3022         Reviewed by Eric Seidel.
3023
3024         Remove global variable $httpdPath and replace with the return value of
3025         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
3026         https://bugs.webkit.org/show_bug.cgi?id=53499
3027
3028         * Scripts/run-iexploder-tests:
3029         * Scripts/webkitperl/httpd.pm:
3030
3031 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
3032
3033         Reviewed by Darin Adler.
3034
3035         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
3036         
3037         https://bugs.webkit.org/show_bug.cgi?id=27551
3038         
3039         * DumpRenderTree/config.h:
3040         * WebKitAPITest/config.h:
3041         * WebKitTestRunner/config.h:
3042
3043 2011-04-06  Tony Chang  <tony@chromium.org>
3044
3045         Reviewed by Darin Adler.
3046
3047         teach run-webkit-tests to read checksums from png files
3048         https://bugs.webkit.org/show_bug.cgi?id=57993
3049
3050         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
3051           no .checksum and look for the checksum in there.
3052
3053 2011-04-06  David Dorwin  <ddorwin@chromium.org>
3054
3055         Reviewed by David Levin.
3056
3057         Enable fullscreen layout tests for Chromium
3058         https://bugs.webkit.org/show_bug.cgi?id=55726
3059
3060         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
3061
3062         * DumpRenderTree/chromium/WebPreferences.cpp:
3063         (WebPreferences::applyTo):
3064
3065 2011-04-06  Adam Roben  <aroben@apple.com>
3066
3067         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
3068
3069         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
3070
3071         Reviewed by David Kilzer.
3072
3073         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3074         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
3075         build's results directory here...
3076         (ExtractTestResults.finished): ...from here.
3077         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
3078         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
3079         leaks" link to point to Leaks Viewer for this build.
3080         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
3081         but it seemed good to add for consistency with BuildAndTestFactory.
3082         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
3083         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
3084         that we'll get a "view leaks" link.
3085
3086 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
3087
3088         Reviewed by Eric Seidel.
3089
3090         [Gtk] plugins/set-status.html fails
3091         https://bugs.webkit.org/show_bug.cgi?id=57844
3092
3093         Allow an empty status text to be dumped.
3094
3095         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3096         (webViewStatusBarTextChanged):
3097
3098 2011-04-06  Chang Shu  <cshu@webkit.org>
3099
3100         Reviewed by Darin Adler.
3101
3102         WebKitTestRunner needs layoutTestController.pageNumberForElementById
3103         https://bugs.webkit.org/show_bug.cgi?id=42329
3104
3105         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3106         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3107         (WTR::LayoutTestController::pageNumberForElementById):
3108         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3109
3110 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
3111
3112         Reviewed by Martin Robinson.
3113
3114         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
3115         https://bugs.webkit.org/show_bug.cgi?id=57932
3116
3117         Some Layout tests have invalid URIs that do not generate valid
3118         SoupURI instances. Do not try to free those NULL SoupURIs.
3119
3120         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3121         (willSendRequestCallback):
3122
3123 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
3124
3125         Reviewed by Andreas Kling.
3126
3127         ORWT shouldn't generate diff files for tests without expected files
3128         https://bugs.webkit.org/show_bug.cgi?id=57846
3129
3130         * Scripts/old-run-webkit-tests:
3131
3132 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
3133
3134         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
3135         to deps.
3136
3137         * wx/install-unix-extras:
3138
3139 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3140
3141         Unreviewed, rolling out r82978, r82999, and r83001.
3142         http://trac.webkit.org/changeset/82978
3143         http://trac.webkit.org/changeset/82999
3144         http://trac.webkit.org/changeset/83001
3145         https://bugs.webkit.org/show_bug.cgi?id=57913
3146
3147         Does not work in Python 2.5 (Requested by abarth on #webkit).
3148
3149         * Scripts/webkitpy/common/system/executive.py:
3150         * Scripts/webkitpy/common/system/executive_unittest.py:
3151
3152 2011-04-05  Chang Shu  <cshu@webkit.org>
3153
3154         Reviewed by Darin Adler.
3155
3156         WebKitTestRunner needs layoutTestController.numberOfPages
3157         https://bugs.webkit.org/show_bug.cgi?id=42694
3158
3159         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3160         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3161         (WTR::LayoutTestController::numberOfPages):
3162         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3163
3164 2011-04-05  Tony Chang  <tony@chromium.org>
3165
3166         Reviewed by Mihai Parparita.
3167
3168         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
3169         https://bugs.webkit.org/show_bug.cgi?id=57889
3170
3171         * Scripts/webkitpy/layout_tests/port/chromium.py:
3172         * Scripts/webkitpy/layout_tests/port/test.py:
3173         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3174
3175 2011-04-05  Adam Barth  <abarth@webkit.org>
3176
3177         Silly with statement, from the future!
3178
3179         * Scripts/webkitpy/common/system/executive.py:
3180
3181 2011-04-05  Adam Barth  <abarth@webkit.org>
3182
3183         Reviewed by Tony Chang.
3184
3185         Don't use Exception.message because it's deprecated
3186         https://bugs.webkit.org/show_bug.cgi?id=57892
3187
3188         Suppress the warning for now.  When we move to Python 3, we might need
3189         to something more dramatic.
3190
3191         * Scripts/webkitpy/common/system/executive.py:
3192
3193 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
3194
3195         Reviewed by Ojan Vafai.
3196
3197         Add builders.js to dashboard file list
3198         https://bugs.webkit.org/show_bug.cgi?id=57899
3199
3200         Add file added by http://crrev.com/80538 to dashboard file list.
3201
3202         * TestResultServer/handlers/dashboardhandler.py:
3203
3204 2011-04-05  MORITA Hajime  <morrita@google.com>
3205
3206         Reviewed by Adam Barth.
3207
3208         webkit-patch should print git's stderr when git svn dcommit fail
3209         http://webkit.org/b/57861
3210
3211         * Scripts/webkitpy/common/checkout/scm.py:
3212
3213 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
3214
3215         Reviewed by Tony Chang.
3216
3217         Add --baseline-search-path to NRWT
3218         https://bugs.webkit.org/show_bug.cgi?id=56233
3219         
3220         Add NRWT option to specify additional directories to look for baselines
3221         (will be used by hardware GPU bots which will have local per-bot
3222         expectations for some tests)
3223
3224         * Scripts/webkitpy/common/system/filesystem_mock.py:
3225         * Scripts/webkitpy/layout_tests/port/base.py:
3226         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3228
3229 2011-04-05  Adam Roben  <aroben@apple.com>
3230
3231         Strip off /results.html from results URLs before trying to load leaks files from them
3232
3233         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
3234         files, rather than pointing to the directory that contains them. This is more convenient for
3235         people browsing build.webkit.org, but confused Leaks Viewer.
3236
3237         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
3238         list don't work
3239
3240         Reviewed by Joseph Pecoraro.
3241
3242         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3243         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
3244
3245 2011-04-05  Carol Szabo  <carol@webkit.org>
3246
3247         Unreviewed.
3248
3249         Updated my info in committers.py
3250
3251         Scripts\webkitpy\common\config\committers.py 
3252
3253 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
3254
3255         Reviewed by Laszlo Gombos.
3256
3257         [Qt] Make WebKitLibraries optional for building QtWebKit
3258         https://bugs.webkit.org/show_bug.cgi?id=57542
3259
3260         * Scripts/build-webkit:
3261
3262 2011-04-05  Chang Shu  <cshu@webkit.org>
3263
3264         Reviewed by Laszlo Gombos.
3265
3266         [Qt] MiniBrowser defaultUrl does not work
3267         https://bugs.webkit.org/show_bug.cgi?id=57021
3268
3269         Match the behavior and coding of MiniBrowser to QtTestBrowser.
3270         * MiniBrowser/qt/main.cpp:
3271         (main):
3272
3273 2011-04-05  Jade Han  <jade.han@nokia.com>
3274
3275         Reviewed by Laszlo Gombos.
3276
3277         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
3278         https://bugs.webkit.org/show_bug.cgi?id=54977
3279
3280         This change is a preparation to enable building webkit2 for Symbian.
3281         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
3282
3283         * Tools.pro:
3284
3285 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3286
3287         Reviewed by Andreas Kling.
3288
3289         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
3290         https://bugs.webkit.org/show_bug.cgi?id=57832
3291
3292         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
3293
3294         * MiniBrowser/qt/UrlLoader.cpp:
3295         (UrlLoader::UrlLoader):
3296
3297 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3298
3299         [Qt] Linux Release minimal build fix after r82919.
3300
3301         * MiniBrowser/qt/BrowserWindow.cpp:
3302         (BrowserWindow::loadURLListFromFile):
3303         * QtTestBrowser/launcherwindow.cpp:
3304         (LauncherWindow::loadURLListFromFile):
3305
3306 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3307
3308         Reviewed by Andreas Kling.
3309
3310         [Qt] Make URL loader accessible from testbrowser's menus
3311         https://bugs.webkit.org/show_bug.cgi?id=57823
3312
3313         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
3314
3315         * MiniBrowser/qt/BrowserWindow.cpp:
3316         (BrowserWindow::BrowserWindow):
3317         (BrowserWindow::loadURLListFromFile):
3318         (BrowserWindow::~BrowserWindow):
3319         * MiniBrowser/qt/BrowserWindow.h:
3320         * QtTestBrowser/launcherwindow.cpp:
3321         (LauncherWindow::LauncherWindow):
3322         (LauncherWindow::~LauncherWindow):
3323         (LauncherWindow::createChrome):
3324         (LauncherWindow::loadURLListFromFile):
3325         * QtTestBrowser/launcherwindow.h:
3326
3327 2011-04-04  Sam Weinig  <sam@webkit.org>
3328
3329         Reviewed by Brian Weinstein.
3330
3331         Remove duplicate API from WKContext
3332         <rdar://problem/8727879>
3333         https://bugs.webkit.org/show_bug.cgi?id=57815
3334
3335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3336         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
3337         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3338         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
3339
3340 2011-04-04  Tony Chang  <tony@chromium.org>
3341
3342         Reviewed by Ojan Vafai.
3343
3344         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
3345         https://bugs.webkit.org/show_bug.cgi?id=57783
3346
3347         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3348         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3349
3350 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
3351
3352         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
3353         from WebKitBuild.
3354
3355         * Scripts/webkitdirs.pm:
3356
3357 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
3358
3359         Reviewed by Gustavo Noronha Silva.
3360
3361         [GTK] WebGL support
3362         https://bugs.webkit.org/show_bug.cgi?id=31517
3363
3364         Add support to the DRT for turning on WebGL when a layout tests requests it.
3365
3366         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3367         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
3368
3369 2011-04-04  Chang Shu  <cshu@webkit.org>
3370
3371         Reviewed by Darin Adler.
3372
3373         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
3374         https://bugs.webkit.org/show_bug.cgi?id=57572
3375
3376         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3377         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3378         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
3379         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3380
3381 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
3382
3383         Reviewed by Csaba Osztrogonác.
3384
3385         [Qt] DumpRenderTree breaks compilation in some uClibc environments
3386         https://bugs.webkit.org/show_bug.cgi?id=57602
3387
3388         * DumpRenderTree/qt/main.cpp:
3389         (get_backtrace):
3390
3391 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
3392
3393         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
3394
3395         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3396         (LayoutTestController::shadowRoot):
3397
3398 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
3399
3400         Unreviewed, fix exception in rebaseline tool.
3401
3402         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3403
3404 2011-04-02  Beth Dakin  <bdakin@apple.com>
3405
3406         Rubber-stamped by Geoff Garen.
3407
3408         For Dan!
3409         * DumpRenderTree/mac/DumpRenderTree.mm:
3410         (resetWebViewToConsistentStateBeforeTesting):
3411
3412 2011-04-02  Beth Dakin  <bdakin@apple.com>
3413
3414         Rubber-stamped by Geoff Garen.
3415
3416         Need to reset the scale, much like zoom.
3417         * DumpRenderTree/mac/DumpRenderTree.mm:
3418         (resetWebViewToConsistentStateBeforeTesting):
3419
3420 2011-04-02  Sam Weinig  <sam@webkit.org>
3421
3422         Reviewed by Beth Dakin.
3423
3424         https://bugs.webkit.org/show_bug.cgi?id=57605
3425         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
3426         getClientRects()
3427         -and corresponding-
3428         <rdar://problem/9194541>
3429
3430         Add DRT support for the scaleWebView SPI.
3431         * DumpRenderTree/mac/EventSendingController.mm:
3432         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3433         (+[EventSendingController webScriptNameForSelector:]):
3434         (-[EventSendingController scalePageBy:atX:andY:]):
3435         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3436         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3437         (WTR::EventSendingController::scalePageBy):
3438         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3439         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3440         (WTR::InjectedBundlePage::reset):
3441
3442 2011-04-02  Dominic Cooney  <dominicc@google.com>
3443
3444         Reviewed by Martin Robinson.
3445
3446         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
3447         https://bugs.webkit.org/show_bug.cgi?id=57551
3448
3449         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3450         (LayoutTestController::shadowRoot):
3451
3452 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3453
3454         Reviewed by Eric Seidel.
3455
3456         Remove AbstractStep._run_script and move script names to ports.py
3457         https://bugs.webkit.org/show_bug.cgi?id=57704
3458
3459         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
3460
3461         * Scripts/webkitpy/common/config/ports.py:
3462         * Scripts/webkitpy/tool/commands/download_unittest.py:
3463         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3464         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3465         * Scripts/webkitpy/tool/steps/abstractstep.py:
3466         * Scripts/webkitpy/tool/steps/checkstyle.py:
3467         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3468         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3469         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3470
3471 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3472
3473         Reviewed by Eric Seidel.
3474
3475         Emulate shebang on Win32
3476         https://bugs.webkit.org/show_bug.cgi?id=55927
3477
3478         Scripts on Windows work only if they are called with the explicit interpreter.
3479         Read the first line of scripts to detect the correct executable.
3480
3481         * Scripts/webkitpy/common/config/ports.py:
3482         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
3483         * Scripts/webkitpy/common/system/executive_unittest.py:
3484
3485 2011-04-01  Adam Barth  <abarth@webkit.org>
3486
3487         Reviewed by Eric Seidel.
3488
3489         apos entities shouldn't show up in ChangeLogs when using webkit-patch
3490         https://bugs.webkit.org/show_bug.cgi?id=57692
3491
3492         Previously, we were using BeautifulSoup to process XML from
3493         bugs.webkit.org, but that's incorrect.  We should be using
3494         BeautifulStoneSoup to process the XML.  We were getting the &apos;
3495         entity wrong because &apos; is an XML entity but not an HTML entity.
3496
3497         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3498         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3499
3500 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3501
3502         Unreviewed, rolling out r82721.
3503         http://trac.webkit.org/changeset/82721
3504         https://bugs.webkit.org/show_bug.cgi?id=57687
3505
3506         This patch introduced assertion failures on the GTK+ bots.
3507         (Requested by mrobinson on #webkit).
3508
3509         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3510         (LayoutTestController::shadowRoot):
3511
3512 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3513
3514         Unreviewed buildfix.
3515
3516         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3517         https://bugs.webkit.org/show_bug.cgi?id=55074
3518
3519         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
3520         (The isWK2() function removes it from @ARGV, but not from @options.)
3521
3522 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
3523
3524         Reviewed by Csaba Osztrogonác.
3525
3526         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
3527         https://bugs.webkit.org/show_bug.cgi?id=57666
3528
3529         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
3530
3531 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3532
3533         Reviewed by Adam Barth.
3534
3535         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
3536
3537         We apparently never implemented the code to skip tests based on
3538         what was compiled into DRT. Also, change the logic used to skip
3539         platform directories to match what old-run-webkit-tests does: 
3540         skip every test not in a directory in the baseline search path.
3541
3542         https://bugs.webkit.org/show_bug.cgi?id=57662
3543
3544         * Scripts/webkitpy/layout_tests/port/mac.py:
3545         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3546         * Scripts/webkitpy/layout_tests/port/webkit.py:
3547
3548 2011-03-29  Mark Rowe  <mrowe@apple.com>
3549
3550         Reviewed by Jon Honeycutt.
3551
3552         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
3553
3554         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
3555
3556         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3557         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3558         * Scripts/webkitpy/layout_tests/port/mac.py:
3559         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3560
3561 2011-04-01  Chang Shu  <cshu@webkit.org>
3562
3563         Reviewed by Csaba Osztrogonác.
3564
3565         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3566         https://bugs.webkit.org/show_bug.cgi?id=55074
3567
3568         * Scripts/build-webkit:
3569
3570 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3571
3572         Reviewed by Tony Chang.
3573
3574         new-run-webkit-tests: remove spurious port version override in webkit.py
3575         base.py provides a default implementation so this is just
3576         breaking things.
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=57667
3579
3580         * Scripts/webkitpy/layout_tests/port/webkit.py:
3581         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3582
3583 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3584
3585         Reviewed by Adam Roben.
3586
3587         Make view results on waterfall direct link to results.html
3588         https://bugs.webkit.org/show_bug.cgi?id=57671
3589
3590         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
3591         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
3592
3593 2011-04-01  Sam Weinig  <sam@webkit.org>
3594
3595         Fix windows build.
3596
3597         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3598         (TestWebKitAPI::TEST):
3599         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3600         (TestWebKitAPI::flushMessages):
3601
3602 2011-04-01  Sam Weinig  <sam@webkit.org>
3603
3604         Reviewed by Adam Roben.
3605
3606         Add adoptWK to WKRetainPtr.h
3607         https://bugs.webkit.org/show_bug.cgi?id=57670
3608
3609         * TestWebKitAPI/PlatformUtilities.h:
3610         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3611         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3612         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3613         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3614         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3615         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3616         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3617         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3618         (TestWebKitAPI::createSessionStateContainingFormData):
3619         * WebKitTestRunner/StringFunctions.h:
3620         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
3621
3622 2011-04-01  Sam Weinig  <sam@webkit.org>
3623
3624         Reviewed by Adam Roben.
3625
3626         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
3627
3628         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3629         (WTR::LayoutTestController::shadowRoot):
3630         Make judicious use of adoptWK().
3631
3632 2011-04-01  Sam Weinig  <sam@webkit.org>
3633
3634         Reviewed by Timothy Hatcher.
3635
3636         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
3637
3638         * Scripts/extract-localizable-strings:
3639
3640 2011-04-01  Anders Carlsson  <andersca@apple.com>
3641
3642         Reviewed by Sam Weinig.
3643
3644         Shockwave plug-in doesn't accept mouse events
3645         https://bugs.webkit.org/show_bug.cgi?id=57653
3646         <rdar://problem/8483273>
3647
3648         Add a plug-in test.
3649
3650         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3651         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3652         (PluginTest::indicateTestFailure):
3653         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
3654
3655         (PluginTest::NPN_ConvertPoint):
3656         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3657         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3658         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3659         Call indicateTestFailure.
3660
3661         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
3662         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
3663         (ConvertPoint::ConvertPoint):
3664         (ConvertPoint::testConvert):
3665         (ConvertPoint::NPP_New):
3666
3667 2011-04-01  Dominic Cooney  <dominicc@google.com>
3668
3669         Reviewed by Martin Robinson.
3670
3671         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
3672         https://bugs.webkit.org/show_bug.cgi?id=57551
3673
3674         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3675         (LayoutTestController::shadowRoot):
3676
3677 2011-04-01  Sam Weinig  <sam@webkit.org>
3678
3679         Reviewed by Anders Carlsson.
3680
3681         WebKitTestRunner needs layoutTestController.shadowRoot
3682         https://bugs.webkit.org/show_bug.cgi?id=57661
3683
3684         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3685         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3686         (WTR::LayoutTestController::shadowRoot):
3687         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3688         Implement layoutTestController.shadowRoot for WebKit2.
3689
3690 2011-04-01  Chang Shu  <cshu@webkit.org>
3691
3692         Reviewed by Darin Adler.
3693
3694         WebKitTestRunner needs layoutTestController.setDatabaseQuota
3695         https://bugs.webkit.org/show_bug.cgi?id=57568
3696
3697         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3698         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3699         (WTR::LayoutTestController::setDatabaseQuota):
3700         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3701
3702 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3703
3704         Reviewed by Tony Chang.
3705
3706         This patch completes the cleanup of
3707         rebaseline-chromium-webkit-tests to work with all of the
3708         variants of a platform (we can now rebaseline gpu- and non-gpu
3709         files&n