Remove assertion from revisionContentForIteration that is causing errors on the dashb...
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-19  Jason Marcell  <jmarcell@apple.com>
2
3         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
4         https://bugs.webkit.org/show_bug.cgi?id=153262
5
6         Reviewed by Alexey Proskuryakov.
7
8         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
9         such cases this revisionContentForIteration method does not have any content to return, thus the
10         assertion fails.
11
12         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
13         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
14
15 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [GTK] Runtime critical warnings when loading a URL after a session restore
18         https://bugs.webkit.org/show_bug.cgi?id=153233
19
20         Reviewed by Michael Catanzaro.
21
22         Add new test case.
23
24         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
25         (viewLoadChanged):
26         (testWebKitWebViewNavigationAfterSessionRestore):
27         (beforeAll):
28
29 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
30
31         [GTK] Remove jhbuild-optional.modules
32         https://bugs.webkit.org/show_bug.cgi?id=152964
33
34         Reviewed by Alex Christensen.
35
36         * gtk/jhbuild-optional.modules: Removed.
37         * gtk/jhbuild.modules:
38
39 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         [GTK] Add support to load/save session in MiniBrowser
42         https://bugs.webkit.org/show_bug.cgi?id=153201
43
44         Reviewed by Michael Catanzaro.
45
46         It makes it easier to test the new WebView session API.
47
48         * MiniBrowser/gtk/BrowserWindow.c:
49         (browserWindowFinalize): Free the session file path.
50         (browserWindowSaveSession): Save the current WebView session if
51         there's a session file path.
52         (browserWindowDeleteEvent): Call browserWindowSaveSession().
53         (browser_window_load_session): Try to load the session from the
54         given file path, otherwise fall back to homepage and keep the
55         session file to save the session on window close.
56         * MiniBrowser/gtk/BrowserWindow.h:
57         * MiniBrowser/gtk/main.c:
58         (createBrowserWindow): Pass the given session file path when
59         shouldLoadSession is TRUE.
60         (main): Only allow to restore/save session when MiniBrowser is
61         launched without URL arguments.
62
63 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
64
65         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
66
67         Geolocation is no longer allowed for unique origins after r195075.
68
69         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
70         (testWebViewGeolocationPermissionRequests):
71
72 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
73
74         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
75         https://bugs.webkit.org/show_bug.cgi?id=153216
76
77         Reviewed by Michael Catanzaro.
78
79         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
80         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
81
82 2016-01-18  Nan Wang  <n_wang@apple.com>
83
84         AX: [Mac] Implement next/previous text marker functions using TextIterator
85         https://bugs.webkit.org/show_bug.cgi?id=152728
86
87         Reviewed by Chris Fleizach.
88
89         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
90         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
91
92 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
93
94         [cmake] Add testair to the build system
95         https://bugs.webkit.org/show_bug.cgi?id=153126
96
97         Reviewed by Michael Catanzaro.
98
99         * Scripts/build-jsc:
100
101 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
102
103         Remove TextRun::allowsRoundingHacks()
104         https://bugs.webkit.org/show_bug.cgi?id=153185
105
106         Reviewed by Simon Fraser.
107
108         * DumpRenderTree/mac/DumpRenderTree.mm:
109         (resetWebViewToConsistentStateBeforeTesting): Deleted.
110
111 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
112
113         [webkitdirs] Avoid list form of open because it broke WinCairo
114         https://bugs.webkit.org/show_bug.cgi?id=153106
115
116         Reviewed by Alex Christensen.
117
118         * Scripts/webkitdirs.pm:
119         (determineArchitecture):
120
121 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
122
123         Add kdebug_trace signposts for a few WebCore operations
124         https://bugs.webkit.org/show_bug.cgi?id=153136
125         rdar://problem/24208487
126
127         Reviewed by Sam Weinig.
128         
129         Plist used by kdebug_trace() viewing tools.
130
131         * Tracing/SystemTracePoints.plist: Added.
132
133 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
134
135         [webkitdirs] Replaced grep invocation with perl code
136         https://bugs.webkit.org/show_bug.cgi?id=153106
137
138         Reviewed by Alex Christensen.
139
140         * Scripts/webkitdirs.pm:
141         (determineArchitecture):
142
143 2016-01-14  Brian Burg  <bburg@apple.com>
144
145         prepare-changelog does not read paths containing spaces properly
146         https://bugs.webkit.org/show_bug.cgi?id=137982
147
148         Reviewed by Joseph Pecoraro.
149
150         Escape whitespace in filenames before passing the file path to other functions.
151
152         * Scripts/prepare-ChangeLog:
153         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
154
155 2016-01-14  Jason Marcell  <jmarcell@apple.com>
156
157         Standardize the usage of "branch" vs. "branchName".
158         https://bugs.webkit.org/show_bug.cgi?id=152982
159
160         Reviewed by Daniel Bates.
161
162         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
163         "branchName" implies that the variable or property in question is simply a string.
164
165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
166         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
167         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
168         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
170         (Trac.prototype.commitsOnBranch): Change branch to branchName.
171         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
173         (MockTrac): Ditto.
174
175 2016-01-14  Jason Marcell  <jmarcell@apple.com>
176
177         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
178         https://bugs.webkit.org/show_bug.cgi?id=152910
179
180         Reviewed by Daniel Bates.
181
182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
183         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
185         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
186         the need to talk to a real Buildbot server.
187         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
188         without the need to talk to a real Buildbot server.
189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
190         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
191         server.
192         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
193         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
194         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
195         trying to talk to Trac.
196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
197         QUnit unit tests.
198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
199
200 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
201
202         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
203         https://bugs.webkit.org/show_bug.cgi?id=132599
204
205         Reviewed by Michael Catanzaro.
206
207         Check if cmake Ninja generators are installed.
208
209         * Scripts/webkitdirs.pm:
210         (canUseNinjaGenerator):
211         (canUseEclipseNinjaGenerator):
212         (generateBuildSystemFromCMakeProject):
213         (canUseEclipse): Deleted.
214
215 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
216
217         [Cocoa] Testing with font family name "System Font" is unused
218         https://bugs.webkit.org/show_bug.cgi?id=153073
219         <rdar://problem/24091683>
220
221         Reviewed by Brent Fulgham.
222
223         * DumpRenderTree/mac/DumpRenderTree.mm:
224         (allowedFontFamilySet): Deleted.
225         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
226         (WTR::allowedFontFamilySet): Deleted.
227         * WebKitTestRunner/mac/TestControllerMac.mm:
228         (WTR::allowedFontFamilySet): Deleted.
229
230 2016-01-13  Daniel Bates  <dabates@apple.com>
231
232         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
233         https://bugs.webkit.org/show_bug.cgi?id=152871
234
235         Reviewed by Brent Fulgham.
236
237         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
238         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
239
240         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
241
242 2016-01-08  Andy Estes  <aestes@apple.com>
243
244         [Content Filtering] Lazily load platform frameworks
245         https://bugs.webkit.org/show_bug.cgi?id=152881
246         rdar://problem/23270886
247
248         Reviewed by Brady Eidson.
249
250         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
251         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
252         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
253         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
254         is loaded after an HTTPS request.
255
256         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
257         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
258         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
259         also re-enabled on iOS after mistakenly being disabled by r188892.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
265         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
266         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
267         (TEST):
268         (downloadTest):
269         (-[LazilyLoadPlatformFrameworksController init]):
270         (-[LazilyLoadPlatformFrameworksController webView]):
271         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
272         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
273         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
274         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
275         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
276         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
277         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
278         (TestWebKitAPI::TEST):
279         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
280         (TestWebKitAPI::TEST): Deleted.
281         * TestWebKitAPI/cocoa/TestProtocol.h:
282         * TestWebKitAPI/cocoa/TestProtocol.mm:
283         (+[TestProtocol registerWithScheme:]):
284         (+[TestProtocol unregister]):
285
286 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
287
288         Fix the Sunpider converage in slow device.
289         https://bugs.webkit.org/show_bug.cgi?id=152938
290         <rdar://problem/22511411>
291
292         Reviewed by Ryosuke Niwa.
293
294         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
295
296         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
297
298 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
299
300         Add a build flag for custom element
301         https://bugs.webkit.org/show_bug.cgi?id=153005
302
303         Reviewed by Alex Christensen.
304
305         Added --custom-elements option to enable custom elements support.
306
307         * Scripts/webkitperl/FeatureList.pm:
308
309 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
310
311         [JSC] Add a help message when run-jsc-stress-tests fails
312         https://bugs.webkit.org/show_bug.cgi?id=153014
313
314         Reviewed by Csaba Osztrogonác.
315
316         * Scripts/run-jsc-stress-tests:
317
318 2016-01-11  Saam barati  <sbarati@apple.com>
319
320         run-jsc-stress-tests should try to figure out a JSC path
321         https://bugs.webkit.org/show_bug.cgi?id=152971
322
323         Reviewed by Yusuke Suzuki.
324
325         This patch now allows run-jsc-stress-tests to be run
326         without a "--jsc <jsc-path>" argument. It tries
327         to take its best guess at a <jsc-path> automagically.
328         
329         This makes it much easier to just run run-jsc-stress-tests
330         with a directory or a yaml file as an argument.
331         You now just do this:
332         `run-jsc-stress-tests <path-to-yaml>`
333         or
334         `run-jsc-stress-tests <path-to-directory-of-js-files>`
335         
336         I wrote this patch because I'd often find myself hacking the 
337         run-javascriptcore-tests file just to run a particular subset of tests.
338         Because I always forget the arguments to run-jsc-stress-tests (which means
339         I always forgot to provide a --jsc argument), I always found it easier to 
340         just hack on that file instead of calling run-jsc-stress-tests directly.
341         No longer is this true!
342
343         * Scripts/run-jsc-stress-tests:
344
345 2016-01-09  Andy Estes  <aestes@apple.com>
346
347         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
348         https://bugs.webkit.org/show_bug.cgi?id=152950
349         rdar://problem/24066652
350
351         Reviewed by Tim Horton.
352
353         Added an API test.
354
355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
356         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
357         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
358         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
359         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
360         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
361         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
362         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
363         (TEST):
364
365 2016-01-11  Commit Queue  <commit-queue@webkit.org>
366
367         Unreviewed, rolling out r194866.
368         https://bugs.webkit.org/show_bug.cgi?id=152986
369
370         This change broke the mac build (Requested by ryanhaddad on
371         #webkit).
372
373         Reverted changeset:
374
375         "[Cocoa] Add SPI to opt out a URL scheme from the memory
376         cache"
377         https://bugs.webkit.org/show_bug.cgi?id=152950
378         http://trac.webkit.org/changeset/194866
379
380 2016-01-11  Andy Estes  <aestes@apple.com>
381
382         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
383         https://bugs.webkit.org/show_bug.cgi?id=152950
384         rdar://problem/24066652
385
386         Reviewed by Tim Horton.
387
388         Added an API test.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
392         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
393         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
394         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
395         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
396         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
397         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
398         (TEST):
399
400 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
401
402         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
403         https://bugs.webkit.org/show_bug.cgi?id=152959
404
405         Reviewed by Brent Fulgham.
406
407         * Scripts/webkitdirs.pm:
408         (determineArchitecture):
409
410 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
411
412         [GTK] W3C CSS2.1 anonymous table tests are failing
413         https://bugs.webkit.org/show_bug.cgi?id=152455
414
415         Reviewed by Mario Sanchez Prada.
416
417         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
418         tests. Add upstream patches to fix detection of XHTML files.
419
420         * gtk/jhbuild.modules:
421         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
422         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
423
424 2016-01-10  Saam barati  <sbarati@apple.com>
425
426         Implement a sampling profiler
427         https://bugs.webkit.org/show_bug.cgi?id=151713
428
429         Reviewed by Filip Pizlo.
430
431         * Scripts/run-jsc-stress-tests:
432
433 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
434
435         [webkitdirs] Try arch and uname commands on non-windows OS
436         https://bugs.webkit.org/show_bug.cgi?id=152958
437
438         Reviewed by Michael Catanzaro.
439
440         Right now, determineArchitecture()  uses `arch` and `uname -m`
441         commands to determine architecture in case of condition (isGtk() ||
442         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
443         instead, because this code is applicable to any non-windows OS WebKit
444         supports (even Haiku which once was supported is moderately
445         POSIX-compliant and has uname command).
446
447         * Scripts/webkitdirs.pm:
448         (determineArchitecture):
449
450 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
451
452         run-webkit-tests mis-counts totals when there are other crashes
453         https://bugs.webkit.org/show_bug.cgi?id=152894
454         <rdar://problem/24098697>
455
456         Reviewed by Alexey Proskuryakov.
457
458         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
459         (TestRunResults.add): Do not update result counters for other crashes.
460
461 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
462
463         webkit-patch build-and-test should have an option to iterate over new tests
464         https://bugs.webkit.org/show_bug.cgi?id=143093
465
466         Reviewed by Michael Catanzaro.
467
468         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
469         It allows running run-webkit-tests on modified or new paths in LayoutTests.
470         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
471         It implements the translation of -expected.* paths to their related tests.
472         It also implements the removal of skipped tests.
473
474         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
475         (LayoutTestFinder.find_touched_tests):
476         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
477         (MockPort):
478         (MockPort.__init__):
479         (MockPort.tests):
480         (LayoutTestFinderTests):
481         (LayoutTestFinderTests.touched_files):
482         (LayoutTestFinderTests.test_touched_test):
483         (LayoutTestFinderTests.test_expected_touched_test):
484         (LayoutTestFinderTests.test_platform_expected_touched_test):
485         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
486         (LayoutTestFinderTests.test_touched_but_skipped_test):
487         * Scripts/webkitpy/port/base.py:
488         (Port.potential_test_names_from_expected_file):
489         * Scripts/webkitpy/tool/commands/download_unittest.py:
490         (DownloadCommandsTest._default_options):
491         * Scripts/webkitpy/tool/steps/options.py:
492         (Options):
493         * Scripts/webkitpy/tool/steps/runtests.py:
494         (RunTests.options):
495         (RunTests.run):
496         (RunTests):
497         (RunTests._new_or_modified_tests):
498         (RunTests._run_webkit_tests):
499         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
500         (RunTestsTest.test_webkit_run_unit_tests):
501         * Scripts/webkitpy/tool/steps/steps_unittest.py:
502         (StepsTest._step_options):
503
504 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
505
506         prepare-ChangeLog should include radar number
507         https://bugs.webkit.org/show_bug.cgi?id=152839
508         <rdar://problem/24093563>
509
510         Reviewed by Daniel Bates.
511
512         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
513         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
514         in the ChangeLog description after the bug URL.
515
516         * Scripts/prepare-ChangeLog:
517         (main): Update signatures.
518         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
519         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
520         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
521         (generateNewChangeLogs): Include radar URL if we found one.
522
523         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
524         Tests for the radar URL extraction.
525
526 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
527
528         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
529         https://bugs.webkit.org/show_bug.cgi?id=152390
530         <rdar://problem/23948321>
531
532         Reviewed by Simon Fraser.
533
534         Fix two use-after-frees.
535
536         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
537         but we may have already progressed to another test by the time the callback fires,
538         having destroyed the TestInvocation.
539         2. UIScriptController is a RefCounted object, but it has a raw pointer to
540         UIScriptContext which has the same lifetime as a TestInvocation.
541         As a result, completion blocks of UIScriptController actions would use a destroyed
542         TestInvocation.
543
544         * WebKitTestRunner/TestInvocation.cpp:
545         (WTR::TestInvocation::~TestInvocation):
546         (WTR::TestInvocation::url):
547         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
548         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
549         (WTR::TestInvocation::runUISideScript):
550         * WebKitTestRunner/TestInvocation.h:
551         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
552         (UIScriptContext::UIScriptContext):
553         (UIScriptContext::~UIScriptContext):
554         (UIScriptContext::runUIScript):
555         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
556         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
557         (WTR::UIScriptController::UIScriptController):
558         (WTR::UIScriptController::contextDestroyed):
559         (WTR::UIScriptController::makeWindowObject):
560         (WTR::UIScriptController::setWillBeginZoomingCallback):
561         (WTR::UIScriptController::willBeginZoomingCallback):
562         (WTR::UIScriptController::setDidEndZoomingCallback):
563         (WTR::UIScriptController::didEndZoomingCallback):
564         (WTR::UIScriptController::setDidEndScrollingCallback):
565         (WTR::UIScriptController::didEndScrollingCallback):
566         (WTR::UIScriptController::setDidShowKeyboardCallback):
567         (WTR::UIScriptController::didShowKeyboardCallback):
568         (WTR::UIScriptController::setDidHideKeyboardCallback):
569         (WTR::UIScriptController::didHideKeyboardCallback):
570         (WTR::UIScriptController::uiScriptComplete):
571         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
572         (WTR::UIScriptController::create):
573         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
574         (WTR::UIScriptController::doAsyncTask):
575         (WTR::UIScriptController::zoomToScale):
576         (WTR::UIScriptController::singleTapAtPoint):
577         (WTR::UIScriptController::doubleTapAtPoint):
578         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
579         (WTR::UIScriptController::contentVisibleRect):
580         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
581         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
582         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
583         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
584         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
585         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
586         (WTR::UIScriptController::doAsyncTask):
587
588 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
589
590         [buildbot] clean-build script should remove untracked files and revert local changes too
591         https://bugs.webkit.org/show_bug.cgi?id=142400
592
593         Reviewed by Ryosuke Niwa.
594
595         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
596         A helper routine SCM.discard_untracked_files is added for that purpose.
597
598         * BuildSlaveSupport/clean-build:
599         (main): Making call to Scripts/clean-webkit
600         * Scripts/clean-webkit: Added.
601         (main): Revert changes and delete untracked files.
602         * Scripts/webkitpy/common/checkout/scm/scm.py:
603         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
604         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
605         (SCMTest._shared_test_discard_untracked_files):
606         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
607
608 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
609
610         Add a setting and preferences to enable display-list drawing. Does nothing yet.
611         https://bugs.webkit.org/show_bug.cgi?id=152807
612
613         Reviewed by Zalan Bujtas.
614         
615         Add an item to the Settings menu to toggle display-list drawing.
616
617         * MiniBrowser/mac/SettingsController.h:
618         * MiniBrowser/mac/SettingsController.m:
619         (-[SettingsController _populateMenu]):
620         (-[SettingsController validateMenuItem:]):
621         (-[SettingsController toggleDisplayListDrawingEnabled:]):
622         (-[SettingsController displayListDrawingEnabled]):
623         * MiniBrowser/mac/WK2BrowserWindowController.m:
624         (-[WK2BrowserWindowController didChangeSettings]):
625
626 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
627
628         Python SCM should be able to retrieve untracked files - Add GIT support
629         https://bugs.webkit.org/show_bug.cgi?id=143135
630
631         Reviewed by Michael Catanzaro.
632
633         * Scripts/webkitpy/common/checkout/scm/git.py:
634         (Git.untracked_files): Adding support for git.
635         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
636         (GitTest.setUp):
637         (GitTest.test_untracked_files): Adding test.
638
639 2016-01-05  Mark Lam  <mark.lam@apple.com>
640
641         Rename badly named JSC_timeout env var to JSCTEST_timeout.
642         https://bugs.webkit.org/show_bug.cgi?id=152748
643
644         Reviewed by Geoffrey Garen.
645
646         Now that we validate JSC options, the badly named JSC_timeout env var causes the
647         bots to have a bad time.
648
649         * Scripts/run-javascriptcore-tests:
650         * Scripts/run-jsc-stress-tests:
651
652 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         [GTK] Allow to save and restore session
655         https://bugs.webkit.org/show_bug.cgi?id=115600
656
657         Reviewed by Michael Catanzaro.
658
659         Add test case to check the new session API.
660
661         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
662         (testWebKitWebViewSessionState):
663         (testWebKitWebViewSessionStateWithFormData):
664         (beforeAll):
665
666 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
667
668         [EFL] Bump EFL version to 1.16.1
669         https://bugs.webkit.org/show_bug.cgi?id=152688
670
671         Reviewed by Gyuyoung Kim.
672
673         * efl/jhbuild.modules:
674
675 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
676
677         error running layout tests on iOS simulator on latest build
678         https://bugs.webkit.org/show_bug.cgi?id=152719
679         <rdar://problem/24009549>
680
681         Reviewed by Alexey Proskuryakov.
682
683         * Scripts/webkitpy/xcode/simulator.py:
684         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
685           before running simctl spawn command.
686
687 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
688
689         Unreviewed, move Frédéric Wang to committers list
690
691         He seems to be on the contributors list by accident. He has been landing his own commits for
692         about two years now.
693
694         * Scripts/webkitpy/common/config/contributors.json:
695
696 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
697
698         Unreviewed, move Sebastian Dröge to committers list harder
699
700         He accidentally added himself to the reviewers list because the file is confusing. Then I
701         accidentially moved him to the contributors list because the file is confusing, even though
702         I knew the contributors list existed in this file and was attempting to add him to the
703         committers list. Really move him to the committers list now.
704
705         * Scripts/webkitpy/common/config/contributors.json:
706
707 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
708
709         Python SCM should be able to retrieve untracked files - Add SVN support
710         https://bugs.webkit.org/show_bug.cgi?id=152546
711
712         Reviewed by Michael Catanzaro.
713
714         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
715         (test_untracked_files): Activating test for SVN.
716         * Scripts/webkitpy/common/checkout/scm/svn.py:
717         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
718
719 2015-12-31  Andy Estes  <aestes@apple.com>
720
721         Replace WTF::move with WTFMove
722         https://bugs.webkit.org/show_bug.cgi?id=152601
723
724         Reviewed by Brady Eidson.
725
726         * DumpRenderTree/TestRunner.h:
727         (TestRunner::setAllowedHosts):
728         * DumpRenderTree/win/DRTDataObject.cpp:
729         (DRTDataObject::SetData):
730         * TestWebKitAPI/Tests/WTF/Deque.cpp:
731         (TestWebKitAPI::TEST):
732         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
735         (TestWebKitAPI::TEST):
736         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
737         (TestWebKitAPI::TEST):
738         * TestWebKitAPI/Tests/WTF/Ref.cpp:
739         (TestWebKitAPI::passWithRef):
740         (TestWebKitAPI::TEST):
741         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
742         (TestWebKitAPI::TEST):
743         * TestWebKitAPI/Tests/WTF/Vector.cpp:
744         (TestWebKitAPI::TEST):
745         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
746         (TestWebKitAPI::TEST):
747         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
748         (TestWebKitAPI::TEST):
749         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
750         (TestWebKitAPI::createTestValue):
751         (TestWebKitAPI::TEST):
752         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
753         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
754         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
755         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
756         (TestWebKitAPI::createNFAs):
757         (TestWebKitAPI::TEST_F):
758         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
759         (TestWebKitAPI::combine):
760         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
761         (TestWebKitAPI::createNFAs):
762         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
763         (TEST):
764         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
765         (WebProcessTest::add):
766
767 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
768
769         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
770         https://bugs.webkit.org/show_bug.cgi?id=152634
771
772         Reviewed by Carlos Garcia Campos.
773
774         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
775         (testLoadFromGResource): Added test.
776         (beforeAll):
777         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
778         (registerGResource): Added.
779         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
780         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
781         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
782
783 2015-12-31  David Kilzer  <ddkilzer@apple.com>
784
785         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
786         <https://bugs.webkit.org/show_bug.cgi?id=152601>
787
788         Ignore unknown pragmas on older clangs.  Fixes the following
789         build failure:
790
791             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
792             #pragma clang diagnostic ignored "-Wself-move"
793                                              ^
794             1 error generated.
795
796         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
797         (TestWebKitAPI::TEST):
798         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
799         (TestWebKitAPI::TEST):
800
801 2015-12-31  Andy Estes  <aestes@apple.com>
802
803         Update the style checker to advise using WTFMove() instead of WTF::move()
804         https://bugs.webkit.org/show_bug.cgi?id=152601
805
806         Reviewed by Daniel Bates.
807
808         * Scripts/webkitpy/style/checkers/cpp.py:
809         (check_wtf_move):
810         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
811         (WebKitStyleTest.test_wtf_move):
812
813 2015-12-31  Andy Estes  <aestes@apple.com>
814
815         Fix warnings uncovered by migrating to WTF_MOVE
816         https://bugs.webkit.org/show_bug.cgi?id=152601
817
818         Reviewed by Daniel Bates.
819
820         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
821         self-move, even if doing so would trigger a warning.
822
823         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
824         (TestWebKitAPI::TEST):
825         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
826         (TestWebKitAPI::TEST):
827
828 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
829
830         [GTK] The install-dependencies script has a syntax error
831         https://bugs.webkit.org/show_bug.cgi?id=152613
832
833         Reviewed by Michael Catanzaro.
834
835         * gtk/install-dependencies: Add the missing 'then.'
836
837 2015-12-30  Philippe Normand  <pnormand@igalia.com>
838
839         [Mac][GTK] Jhbuild support for OSX
840         https://bugs.webkit.org/show_bug.cgi?id=150799
841
842         Reviewed by Michael Catanzaro.
843
844         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
845         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
846         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
847         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
848
849 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
850
851         Unreviewed, move Sebastian Dröge to committers list
852
853         He accidentally added himself to the reviewers list because the file is confusing.
854
855         * Scripts/webkitpy/common/config/contributors.json:
856
857 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
858
859         Remove the unused #define _USE_MATH_DEFINES
860         https://bugs.webkit.org/show_bug.cgi?id=152034
861
862         Reviewed by Tim Horton.
863         
864         Update this test to use piDouble from MathExtras.h, and
865         std::numeric_limits<>.
866
867         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
868
869 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
870
871         Python SCM should be able to retrieve untracked files - Generic changes
872         https://bugs.webkit.org/show_bug.cgi?id=152536
873
874         Reviewed by Brent Fulgham.
875
876         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
877         No support is yet added to GIT and SVN specific implementations.
878
879         * Scripts/webkitpy/common/checkout/scm/scm.py:
880         (SCM.untracked_files):
881         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
882         (SCMTest._shared_test_untracked_files):
883
884 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
885
886         SVN checkout used by RunBenchmark should be non-interactive
887         https://bugs.webkit.org/show_bug.cgi?id=152542
888
889         Reviewed by Ryosuke Niwa.
890
891         RunBenchmark should not require user interaction while running.
892
893         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
894         (BenchmarkBuilder._checkout_with_subversion):
895
896 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
897
898         Web Inspector: add support for running protocol-test.js tests on Windows
899         https://bugs.webkit.org/show_bug.cgi?id=148037
900         <rdar://problem/22292237>
901
902         Reviewed by Simon Fraser.
903
904         * DumpRenderTree/win/TestRunnerWin.cpp:
905         (TestRunner::inspectorTestStubURL): Provide implementation.
906
907 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
908
909         [MediaStream] MediaDeviceInfo.label must be empty in some situations
910         https://bugs.webkit.org/show_bug.cgi?id=152000
911
912         Reviewed by Brent Fulgham.
913
914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
915         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
916         (WTR::InjectedBundle::setUserMediaPermission):
917         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
918         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
919
920         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
921         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
922         * WebKitTestRunner/InjectedBundle/TestRunner.h:
923
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::TestController::setUserMediaPermissionForOrigin):
926         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
927         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
928           persistent permission for origin, that can be done from script now.
929         * WebKitTestRunner/TestController.h:
930
931         * WebKitTestRunner/TestInvocation.cpp:
932         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
933           SetUserMediaPermissionForOrigin.
934
935 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
936
937         [Win] Unreviewed build fix: Recognize Windows 10 variants.
938
939         * Scripts/webkitpy/common/system/platforminfo.py:
940         (PlatformInfo._determine_win_version):
941
942 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
943
944         Content blockers should be able to promote http to https
945         https://bugs.webkit.org/show_bug.cgi?id=148966
946
947         Reviewed by Benjamin Poulain.
948
949         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
950         (WebCore::ContentExtensions::operator<<):
951         (TestWebKitAPI::TEST_F):
952
953 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
954
955         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
956         https://bugs.webkit.org/show_bug.cgi?id=152516
957
958         Reviewed by Gyuyoung Kim.
959
960         * MiniBrowser/efl/main.c:
961
962 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
963
964         Unreviewed: Add John Wilander as a contributor.
965
966         * Scripts/webkitpy/common/config/contributors.json:
967
968 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
969
970         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
971         https://bugs.webkit.org/show_bug.cgi?id=152482
972
973         Reviewed by Brent Fulgham.
974
975         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
976         for the same property. On WK2, the element returned will not be valid, but is still present and
977         that can lead to looping.
978
979         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
980         (AccessibilityUIElement::horizontalScrollbar):
981         (AccessibilityUIElement::verticalScrollbar):
982         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
983         (WTR::AccessibilityUIElement::horizontalScrollbar):
984         (WTR::AccessibilityUIElement::verticalScrollbar):
985
986 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
987
988         Unreviewed.
989
990         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
991
992 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
993
994         [EFL] test_ewk2_context failed after r192808
995         https://bugs.webkit.org/show_bug.cgi?id=151846
996
997         Reviewed by Gyuyoung Kim.
998
999         Used the added ewk_context_web_process_count_limit_set api
1000         instead of the deprecated ewk_context_process_model_set.
1001
1002         * MiniBrowser/efl/main.c:
1003         (elm_main):
1004
1005 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1006
1007         Unreviewed, move myself to reviewer list.
1008
1009         * Scripts/webkitpy/common/config/contributors.json:
1010
1011 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1012
1013         Unreviewed, add myself to the committers list.
1014
1015         * Scripts/webkitpy/common/config/contributors.json:
1016
1017 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1018
1019         [GTK] jquery.min.js violates DFSG
1020         https://bugs.webkit.org/show_bug.cgi?id=152428
1021
1022         Reviewed by Joseph Pecoraro.
1023
1024         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1025         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1026
1027         * gtk/manifest.txt.in:
1028
1029 2015-12-19  Dan Bernstein  <mitz@apple.com>
1030
1031         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1032         https://bugs.webkit.org/show_bug.cgi?id=152462
1033
1034         Reviewed by Alexey Proskuryakov.
1035
1036         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1037           OS X 10.9:
1038
1039         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1040         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1041         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1042         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1043         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1044
1045         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1046           never getting compiled:
1047
1048         * DumpRenderTree/mac/TextInputController.m:
1049         * MiniBrowser/mac/BrowserWindowController.m:
1050         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1051         * WebKitTestRunner/mac/EventSenderProxy.mm:
1052
1053 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1054
1055         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1056
1057         This is to make it easy to CC it on Bugzilla.
1058
1059         * Scripts/webkitpy/common/config/contributors.json:
1060
1061 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1062
1063         Pasteboard get messed up after running kill-old-processes
1064         https://bugs.webkit.org/show_bug.cgi?id=152426
1065
1066         Reviewed by Alexey Proskuryakov.
1067
1068         * BuildSlaveSupport/kill-old-processes:
1069         (main): Do not kill pasteboard anymore.
1070
1071 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1072
1073         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1074         https://bugs.webkit.org/show_bug.cgi?id=152157
1075         <rdar://problem/23851817>
1076
1077         Reviewed by Alexey Proskuryakov.
1078
1079         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1080         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1081         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1082         (Manager._get_test_inputs): Common method to calculate test_inputs.
1083         (Manager._update_worker_count): Calculate and update required number of workers.
1084
1085 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1086
1087         run-webkit-tests fails to delete Simulator device during cleanup
1088         https://bugs.webkit.org/show_bug.cgi?id=152363
1089
1090         Reviewed by Alexey Proskuryakov.
1091
1092         * Scripts/webkitpy/xcode/simulator.py:
1093         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1094
1095 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1096
1097         [mac-wk2] fast/events force click tests crashing
1098         https://bugs.webkit.org/show_bug.cgi?id=152339
1099
1100         Reviewed by Beth Dakin.
1101
1102         * WebKitTestRunner/mac/EventSenderProxy.mm:
1103         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1104         Set the NSEvent's _type member in addition to overriding -type,
1105         because there are assertions in touch event handling code that depend on it.
1106
1107 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1108
1109         Enforce temporarily bots to sync WebKit and WPT testharness.js
1110         https://bugs.webkit.org/show_bug.cgi?id=152334
1111
1112         Reviewed by Darin Adler.
1113
1114         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1115         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1116
1117 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1118
1119         [Fetch API] Add fetch API compile time flag
1120         https://bugs.webkit.org/show_bug.cgi?id=152254
1121
1122         Reviewed by Darin Adler.
1123
1124         * Scripts/webkitperl/FeatureList.pm:
1125
1126 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1127
1128         Unreviewed.
1129
1130         Added files that have impact in building Streams API to the watchlist.
1131
1132         * Scripts/webkitpy/common/config/watchlist:
1133
1134 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1135
1136         Unreviewed.
1137
1138         Added imported tests to Streams API watchlist.
1139
1140         * Scripts/webkitpy/common/config/watchlist:
1141
1142 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1143
1144         Remove default copy of wpt testharness.js when launching wpt server
1145         https://bugs.webkit.org/show_bug.cgi?id=152298
1146
1147         Reviewed by Darin Adler.
1148
1149         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1150         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1151
1152 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1153
1154         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1155         <http://webkit.org/b/152314>
1156
1157         Reviewed by Daniel Bates.
1158
1159         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1160         code path to exit immediately when calling main().
1161         Unfortunately, DumpRenderTreeMain.mm was used for both
1162         DumpRenderTree command-line binary and DumpRenderTree.app, which
1163         meant that the app would exit immediately with no error code
1164         when run!
1165
1166         The workaround is to introduce a separate source file called
1167         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1168         already does.
1169
1170         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1171         DumpRenderTreeAppMain.mm to the project.  Make it the only
1172         compiled source for the DumpRenderTree.app target.
1173         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1174         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1175         case someone tries mistakenly to use the app.
1176         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1177         Link to JavaScriptCore.framework on iOS for the assert.
1178         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1179         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1180         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1181         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1182         (main): Add assert for iOS so that a crash occurs if someone
1183         tries to run the wrong command.
1184
1185 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1186
1187         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1188         https://bugs.webkit.org/show_bug.cgi?id=152266
1189         <rdar://problem/22092676>
1190
1191         Reviewed by Simon Fraser.
1192
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1195         Add a test that crashed before this change, and doesn't crash after.
1196
1197 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1198
1199         AX: iOS: Text field variations do not have the correct traits
1200         https://bugs.webkit.org/show_bug.cgi?id=152237
1201
1202         Reviewed by Mario Sanchez Prada.
1203
1204         Add iOS calls for determing if an object is a search field or a text area.
1205
1206         * DumpRenderTree/AccessibilityUIElement.cpp:
1207         (getIsSearchFieldCallback):
1208         (getIsTextAreaCallback):
1209         (stringForSelectionCallback):
1210         (AccessibilityUIElement::getJSClass):
1211         * DumpRenderTree/AccessibilityUIElement.h:
1212         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1213         (AccessibilityUIElement::identifier):
1214         (AccessibilityUIElement::isTextArea):
1215         (AccessibilityUIElement::isSearchField):
1216         (AccessibilityUIElement::traits):
1217         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1218         (WTR::AccessibilityUIElement::scrollPageRight):
1219         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1220         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1221         (WTR::AccessibilityUIElement::isSearchField):
1222         (WTR::AccessibilityUIElement::isTextArea):
1223         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1224         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1225         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1226         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1227         (WTR::AccessibilityUIElement::isTextArea):
1228         (WTR::AccessibilityUIElement::isSearchField):
1229         (WTR::AccessibilityUIElement::rowCount):
1230
1231 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1232
1233         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1234         https://bugs.webkit.org/show_bug.cgi?id=152252
1235
1236         Reviewed by Sergio Villar Senin.
1237
1238         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1239         for building the JHBuild on Debian systems.
1240
1241 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1242
1243         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1244         https://bugs.webkit.org/show_bug.cgi?id=152156
1245
1246         Reviewed by Dan Bernstein.
1247
1248         Our frameworks should appropriately prefix all ObjC classes,
1249         not just external symbols.
1250
1251         * Scripts/check-for-inappropriate-objc-class-names:
1252         Remove the -g switch to check all ObjC class names.
1253
1254 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1255
1256         [MediaStream] Expose media capture devices persistent permissions to WebCore
1257         https://bugs.webkit.org/show_bug.cgi?id=152087
1258
1259         Add support for the new user media permission checker page UI client method.
1260
1261         Reviewed by Chris Dumez.
1262
1263         * WebKitTestRunner/TestController.cpp:
1264         (WTR::decidePolicyForUserMediaPermissionRequest):
1265         (WTR::checkUserMediaPermissionForOrigin):
1266         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1267         (WTR::TestController::createWebViewWithOptions): Ditto.
1268         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1269         (WTR::originUserVisibleName): New, create a string for the origin.
1270         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1271           according to the state of the origin permission map.
1272         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1273           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1274         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1275           origin permission map.
1276         * WebKitTestRunner/TestController.h:
1277
1278 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1279
1280         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1281         https://bugs.webkit.org/show_bug.cgi?id=152022
1282         rdar://problem/23763584
1283
1284         Reviewed by Darin Adler.
1285
1286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1288         (WTR::InjectedBundlePage::willSendRequestForFrame):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1290         (WTR::TestRunner::setWillSendRequestReturnsNull):
1291         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1292         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1293         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1294         (WTR::TestRunner::willSendRequestHTTPBody):
1295         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1296
1297 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1298
1299         Remove additional simulator checks before running layout-tests
1300         https://bugs.webkit.org/show_bug.cgi?id=152146
1301
1302         Reviewed by Darin Adler.
1303
1304         * Scripts/webkitpy/port/ios.py:
1305         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1306         * Scripts/webkitpy/xcode/simulator.py:
1307         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1308         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1309
1310 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1311
1312         Run atleast one simulator even if max process limit is low
1313         https://bugs.webkit.org/show_bug.cgi?id=152081
1314         <rdar://problem/23819694>
1315
1316         Reviewed by Alexey Proskuryakov.
1317
1318 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1319
1320         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1321         https://bugs.webkit.org/show_bug.cgi?id=144262
1322
1323         Reviewed by Carlos Garcia Campos.
1324
1325         Added new unit test to check the additional scenarios we now
1326         handle for custom URI schemes.
1327
1328         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1329         (generateHTMLContent): New helper function to generate big enough content.
1330         (testWebContextURIScheme): New unit test.
1331
1332 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1333
1334         [EFL] Fix unhandled web process message when launching MiniBrowser
1335         https://bugs.webkit.org/show_bug.cgi?id=152048
1336
1337         Reviewed by Gyuyoung Kim.
1338
1339         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1340         (TestWebKitAPI::TEST):
1341
1342 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1343
1344         [GTK] Add API to handle beforeunload events
1345         https://bugs.webkit.org/show_bug.cgi?id=139090
1346
1347         Reviewed by Gustavo Noronha Silva.
1348
1349         * MiniBrowser/gtk/BrowserWindow.c:
1350         (browserWindowConstructed):
1351         (browserWindowDeleteEvent):
1352         (browser_window_class_init):
1353         Handle delete-event to prevent the window from being closed when
1354         the page has beforeunload handlers. Use
1355         webkit_web_view_try_close() when the window is requested to be
1356         closed.
1357         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1358         (testWebViewJavaScriptDialogs):
1359         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1360         script dialog type.
1361
1362 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1363
1364         Refactored initialization code in LoadTrackingTest.
1365
1366         Rubber-stamped by Carlos Garcia Campos.
1367
1368         Small refactoring to make sure that the state of a LoadTrackingTest
1369         gets properly reset before loading new web content.
1370
1371         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1372         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1373         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1374         functions and reset the remaining local variables.
1375         (LoadTrackingTest::loadURI): Call reset();
1376         (LoadTrackingTest::loadHtml): Ditto.
1377         (LoadTrackingTest::loadPlainText): Ditto.
1378         (LoadTrackingTest::loadBytes): Ditto.
1379         (LoadTrackingTest::loadRequest): Ditto.
1380         (LoadTrackingTest::reload): Ditto.
1381         (LoadTrackingTest::goBack): Ditto.
1382         (LoadTrackingTest::goForward): Ditto.
1383
1384 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1385
1386         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1387         https://bugs.webkit.org/show_bug.cgi?id=151942
1388
1389         Reviewed by Darin Adler.
1390
1391         * MiniBrowser/efl/main.c:
1392         (window_create): Enable offline web application cache feature on MiniBrowser.
1393         (elm_main):
1394
1395 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=151243
1398         <rdar://problem/22955197>
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * LayoutTestRelay/LayoutTestRelay/main.m:
1403         (getTestingSimDevice): Use separate testing device for each worker.
1404         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1405         (Manager.run): Perform cleanup even if setup fails.
1406         * Scripts/webkitpy/port/ios.py:
1407         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1408         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1409         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1410         (IOSSimulatorPort._quit_ios_simulator): Same
1411         (IOSSimulatorPort.clean_up_test_run): Same
1412         (IOSSimulatorPort.check_sys_deps): Same
1413         (IOSSimulatorPort.testing_device): Same
1414         (IOSSimulatorPort.reset_preferences): Same
1415         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1416         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1417         * Scripts/webkitpy/xcode/simulator.py:
1418         (Device.delete): Delete the simulator device.
1419         (Simulator.delete_device): Same
1420         (Simulator.wait_until_device_is_booted): Wait for device booting.
1421
1422 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1423
1424         [EFL] Add API to provide preferences before creating ewk_view
1425         https://bugs.webkit.org/show_bug.cgi?id=151587
1426
1427         Reviewed by Gyuyoung Kim.
1428
1429         * MiniBrowser/efl/main.c:
1430         (on_key_down):
1431         (quit):
1432         (window_create):
1433         Moved settings related code to configuration() not to update settings
1434         whenever ewk_view is created.
1435         (configuration):
1436         (elm_main):
1437
1438 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1439
1440         Unreviewed. Fix GTK+ API tests after r193639.
1441
1442         The new jhbuild version needs some more variables ot be present in
1443         the builtin dict, even if they are set to None.
1444
1445         * jhbuild/jhbuildutils.py:
1446         (enter_jhbuild_environment_if_available):
1447
1448 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1449
1450         [GTK] Notify WebCore when notification is clicked
1451         https://bugs.webkit.org/show_bug.cgi?id=151951
1452
1453         Reviewed by Carlos Garcia Campos.
1454
1455         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1456         (testWebViewNotification): test the new API.
1457
1458 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1459
1460         'jhbuild build' should fail immediately when building any module fails
1461         https://bugs.webkit.org/show_bug.cgi?id=145697
1462
1463         Reviewed by Carlos Garcia Campos.
1464
1465         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1466         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1467         Everything is placed under lib instead of lib64 now.
1468         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1469         --exit-on-error when running 'jhbuild build'.
1470         * jhbuild/jhbuildrc_common.py:
1471         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1472         jhbuild should be able to handle these for us without breaking things....
1473
1474 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1475
1476         Add support to import w3c tests from a repository with a different root that the main repo dir
1477         https://bugs.webkit.org/show_bug.cgi?id=151751
1478
1479         Reviewed by Ryosuke Niwa and Youenn Fablet.
1480
1481         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1482         in a different directory than the repository root.
1483
1484         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1485         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1486         requires having the copy_path lists including tuples of origin and destination directories.
1487
1488         * Scripts/webkitpy/w3c/test_downloader.py:
1489         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1490         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1491         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1492         (TestImporterTest.test_tests_directory): Test.
1493
1494 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1495
1496         Mock TestRepositories in W3C importer tests
1497         https://bugs.webkit.org/show_bug.cgi?id=151938
1498
1499         Reviewed by Youenn Fablet.
1500
1501         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1502         is because the test repository method reading the file was using the filesystem directly instead of taking the
1503         host one. This patch changes that.
1504
1505         * Scripts/webkitpy/w3c/test_downloader.py:
1506         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1507         default one.
1508         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1509         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1510         (TestImporterTest.test_harnesslinks_conversion):
1511         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1512
1513 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1514
1515         TestNetscapePlugIn: Address review comment on 193607
1516         <http://webkit.org/b/151881>
1517
1518         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1519         (testSetStatus): Initializing std::unique_ptr<char[]> with
1520         nullptr is redundant.
1521
1522 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1523
1524         [GTK] Add webkit_uri_request_get_http_method
1525         https://bugs.webkit.org/show_bug.cgi?id=151601
1526
1527         Reviewed by Martin Robinson.
1528
1529         Add test case to check HTTP method of WebKitURIRequest.
1530
1531         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1532         (testURIRequestHTTPMethod):
1533         (serverCallback):
1534         (beforeAll):
1535         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1536         (sendRequestCallback):
1537
1538 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1539
1540         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1541         https://bugs.webkit.org/show_bug.cgi?id=79918
1542
1543         Reviewed by Gustavo Noronha Silva.
1544
1545         Add unit tests to check the different console messages.
1546
1547         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1548         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1549         (ConsoleMessageTest::ConsoleMessage::operator==):
1550         (ConsoleMessageTest::consoleMessageReceivedCallback):
1551         (ConsoleMessageTest::ConsoleMessageTest):
1552         (ConsoleMessageTest::~ConsoleMessageTest):
1553         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1554         (testWebKitConsoleMessageConsoleAPI):
1555         (testWebKitConsoleMessageJavaScriptException):
1556         (testWebKitConsoleMessageNetworkError):
1557         (testWebKitConsoleMessageSecurityError):
1558         (beforeAll):
1559         (afterAll):
1560         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1561         (consoleMessageSentCallback):
1562         (pageCreatedCallback):
1563
1564 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1565
1566         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1567         https://bugs.webkit.org/show_bug.cgi?id=151934
1568
1569         Reviewed by Csaba Osztrogonác.
1570
1571         * MiniBrowser/efl/main.c:
1572         (on_window_deletion): Revert the changes of r192767.
1573
1574 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1575
1576         [GTK] update-webkitgtk-libs cannot build mesa
1577         https://bugs.webkit.org/show_bug.cgi?id=151535
1578
1579         Reviewed by Martin Robinson.
1580
1581         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1582         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1583         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1584         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1585         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1586         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1587
1588         * gtk/jhbuild.modules:
1589
1590 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1591
1592         [GTK][Mac] libWebExtensionTest link error
1593         https://bugs.webkit.org/show_bug.cgi?id=150802
1594
1595         Reviewed by Carlos Garcia Campos.
1596
1597         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1598
1599 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1600
1601         TestNetscapePlugIn: Fix leaks found by static analyzer
1602         <http://webkit.org/b/151881>
1603
1604         Reviewed by Darin Adler.
1605
1606         Fixes the following leaks found by the static analyzer:
1607             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1608                     return false;
1609                            ^~~~~
1610             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1611                     return false;
1612                            ^~~~~
1613             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1614                     return false;
1615                            ^~~~~
1616
1617         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1618         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1619         early return if allocation fails.
1620         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1621         Make sure to call fclose() on filehandle, even for an early
1622         return.
1623         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1624
1625 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1626
1627         prepare-ChangeLog: Fix some warning messages when using svn
1628         <http://webkit.org/b/151914>
1629
1630         Reviewed by Daniel Bates.
1631
1632         * Scripts/prepare-ChangeLog:
1633         (generateFunctionLists): Simplify logic so that we never call
1634         normalizePath() with an undefined value.
1635         (attributeCommand): Quote $subPath for the shell so that we
1636         don't try to run "svn propget" on invalid paths.
1637
1638 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1639
1640         TestNetscapePlugIn: Fix remaining static analyzer warnings
1641         <http://webkit.org/b/151888>
1642
1643         Reviewed by Alexey Proskuryakov.
1644
1645         Fixes the following static analyzer warnings:
1646             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1647                     CRASH();
1648                     ^~~~~~~
1649             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1650                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1651                 ^~~~~~~~~~~~~~~~
1652             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1653                 return obj->pluginTest->NPP_SetWindow(window);
1654                        ^~~~~~~~~~~~~~~
1655             2 warnings generated.
1656
1657         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1658         (CRASH): Use __builtin_trap() for gcc/clang.
1659         (NPP_SetWindow): Add early return if obj is nullptr.
1660
1661 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1662
1663         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1664         https://bugs.webkit.org/show_bug.cgi?id=151797
1665
1666         Reviewed by Martin Robinson.
1667
1668         Since we switched to use the network process to run the unit tests
1669         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1670         sometimes passes. We are now also getting the notification for the
1671         css image. Since we wait for 3 resources, sometimes the css image
1672         is loaded before and then checkResourceData is called for it, but
1673         not handled. When the css image is the last one loaded the test
1674         passes. So, we just need to wait for the 4 resources.
1675
1676         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1677         (testWebResourceGetData):
1678
1679 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1680
1681         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1682         <http://webkit.org/b/151845>
1683
1684         Reviewed by Simon Fraser.
1685
1686         Fixes the following static analyzer warning:
1687             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1688                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1689                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1690
1691         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1692         (createBitmapContext): Free 'buffer' after using it in logging
1693         to fix the use-after-free.  Assign a value of nullptr to buffer
1694         so we don't return with it set to a freed address.
1695
1696 2015-12-03  Jer Noble  <jer.noble@apple.com>
1697
1698         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1699         https://bugs.webkit.org/show_bug.cgi?id=151830
1700
1701         Reviewed by Anders Carlsson.
1702
1703         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1704
1705         * DumpRenderTree/mac/DumpRenderTree.mm:
1706         (resetWebPreferencesToConsistentValues):
1707         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1708         (WTR::initializeWebViewConfiguration):
1709
1710 2015-12-03  Anders Carlsson  <andersca@apple.com>
1711
1712         Remove Objective-C GC support
1713         https://bugs.webkit.org/show_bug.cgi?id=151819
1714         rdar://problem/23746991
1715
1716         Reviewed by Dan Bernstein.
1717
1718         * asan/asan.xcconfig:
1719
1720 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1721
1722         Allow nil for unspecified benchmark pathes
1723         https://bugs.webkit.org/show_bug.cgi?id=151784
1724
1725         Reviewed by Filip Pizlo.
1726
1727         `Pathname.new(nil)` will raise an error.
1728         Only generate Pathname if the benchmark path is specified.
1729
1730         * Scripts/run-jsc-benchmarks:
1731
1732 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1733
1734         [Win] Run non-http tests without Cygwin
1735         https://bugs.webkit.org/show_bug.cgi?id=151721
1736
1737         Reviewed by Andy Estes.
1738
1739         Support native 32-bit and 64-bit Python (and Perl) builds
1740         for running tests:
1741
1742         1. Use "startswith('win')", rather than "== 'win32'" to support
1743         various Windows build types.
1744         2. Supply full path for some native Windows utilities, since the
1745         path environment does not always have the specified, and they are
1746         guaranteed to exist in those specific locations.
1747         3. Make sure native Windows Python test runs pass proper environment
1748         variables to run programs.
1749         4. Append 'exe' suffix when running Windows executables.
1750         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1751         command doesn't exist.
1752         
1753         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1754         the current Perl executable, rather than requiring a new path search.
1755         * Scripts/webkitpy/common/find_files_unittest.py:
1756         (TestWinNormalize.test_win): Use startswith('win').
1757         * Scripts/webkitpy/common/prettypatch_unittest.py:
1758         (test_pretty_diff_encodings): Ditto.
1759         * Scripts/webkitpy/common/system/executive.py:
1760         (Executive._should_close_fds): Ditto.
1761         (Executive.shell_command_for_script): Use startswith('win').
1762         (Executive.kill_process): Use full path to killall executable.
1763         (Executive.check_running_pid): Use startswith('win').
1764         (Executive.running_pids): Ditto.
1765         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1766         running under native Windows Python.
1767         (Executive._child_process_encoding): Use startswith('win').
1768         (Executive._should_encode_child_process_arguments): Ditto.
1769         (Executive.popen): Recognize proper script engine on Windows, since it
1770         does not support the shebang syntax.
1771         (Executive.run_in_parallel): Use startswith('win').
1772         * Scripts/webkitpy/common/system/executive_unittest.py:
1773         (never_ending_command): Ditto.
1774         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1775         (ExecutiveTest.serial_test_kill_process): Ditto.
1776         (ExecutiveTest.serial_test_kill_all): Ditto.
1777         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1778         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1779         (main): Ditto.
1780         * Scripts/webkitpy/common/system/file_lock.py:
1781         (FileLock._create_lock): Ditto.
1782         (FileLock._remove_lock): Ditto.
1783         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1784         (RealFileSystemTest.test_chdir): Ditto.
1785         (RealFileSystemTest.test_chdir__notexists): Ditto.
1786         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1787         * Scripts/webkitpy/common/system/path_unittest.py:
1788         (AbspathTest.test_abspath_to_uri_win): Ditto.
1789         * Scripts/webkitpy/common/system/platforminfo.py:
1790         (PlatformInfo._determine_os_name): Ditto.
1791         * Scripts/webkitpy/common/system/user.py: Ditto.
1792         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1793         (ManagerTest.integration_test_needs_servers): Ditto.
1794         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1795         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1796         driver letters.
1797         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1798         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1799         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1800         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1801         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1802         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1803         (TestHttpServer.test_start_cmd): Ditto.
1804         * Scripts/webkitpy/port/base.py:
1805         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1806         and 'SYSTEMROOT' in environment passed to test runners.
1807         (Port._apache_config_file_name_for_platform): Use startswith('win').
1808         (Port._build_path): Ditto.
1809         (Port._path_to_driver): Include 'exe' suffix when running under native
1810         Windows.
1811         * Scripts/webkitpy/port/driver.py:
1812         (Driver._setup_environ_for_driver): Explicitly make some environment
1813         variables strings.
1814         * Scripts/webkitpy/port/server_process.py:
1815         (ServerProcess.__init__): Use startswith('win').
1816         * Scripts/webkitpy/port/win.py:
1817         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1818         registry key formats.
1819         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1820         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1821         and regtool on Cygwin.
1822         (WinPort.write_registry_value): Ditto.
1823         (WinPort.setup_crash_log_saving): Ditto.
1824         (WinPort.restore_crash_log_saving): Ditto.
1825         (WinPort.prevent_error_dialogs): Ditto.
1826         (WinPort.allow_error_dialogs): Ditto.
1827         (WinPort.find_system_pid): Revise to use Windows management
1828         infrastructure on native Windows, continue using 'ps' on Cygwin.
1829         (WinPort.read_registry_string): Deleted.
1830         (WinPort.write_registry_string): Deleted.
1831         * Scripts/webkitpy/test/main.py:
1832         (main): Use startswith('win').
1833         (Tester._parse_args): Ditto.
1834
1835 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1836
1837         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1838         https://bugs.webkit.org/show_bug.cgi?id=150792
1839
1840         Reviewed by Saam Barati.
1841
1842         * Scripts/webkitperl/FeatureList.pm:
1843
1844 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1845
1846         Unreviewed, rolling out r192914.
1847         https://bugs.webkit.org/show_bug.cgi?id=151734
1848
1849         JSC tests for this change are failing on 32 and 64-bit bots
1850         (Requested by ryanhaddad on #webkit).
1851
1852         Reverted changeset:
1853
1854         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1855         enable this feature"
1856         https://bugs.webkit.org/show_bug.cgi?id=150792
1857         http://trac.webkit.org/changeset/192914
1858
1859 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1860
1861         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1862         <http://webkit.org/b/151726>
1863
1864         Reviewed by Simon Fraser.
1865
1866         * WebKitTestRunner/mac/EventSenderProxy.mm:
1867         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1868         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1869
1870 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1871
1872         Give String and AtomicString an existingHash() function
1873         https://bugs.webkit.org/show_bug.cgi?id=151717
1874
1875         Reviewed by Andreas Kling.
1876
1877         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1878         (TestWebKitAPI::TEST):
1879         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1880         (TestWebKitAPI::TEST):
1881
1882 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1883
1884         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1885         https://bugs.webkit.org/show_bug.cgi?id=150792
1886
1887         Reviewed by Saam Barati.
1888
1889         * Scripts/webkitperl/FeatureList.pm:
1890
1891 2015-12-01  Sam Weinig  <sam@webkit.org>
1892
1893         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1894         <rdar://problem/23320863>
1895         https://bugs.webkit.org/show_bug.cgi?id=151708
1896
1897         Reviewed by Anders Carlsson.
1898
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::TestController::createOtherPage):
1901         (WTR::TestController::createWebViewWithOptions):
1902         Update for new WKPageUIClient.
1903
1904 2015-12-01  Anders Carlsson  <andersca@apple.com>
1905
1906         Remove WebKit2.framework
1907         https://bugs.webkit.org/show_bug.cgi?id=151715
1908
1909         Reviewed by Dan Bernstein.
1910
1911         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1912         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1913         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1914         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1915         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1916         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1917         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1918
1919 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1920
1921         Unreviewed common typo fix "occurance" => "occurrence".
1922
1923         * Scripts/webkitpy/tool/commands/queries.py:
1924         (FindFlakyTests._print_statistics):
1925
1926 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1927
1928         Make ProcessModel always MultipleSecondaryProcesses
1929         https://bugs.webkit.org/show_bug.cgi?id=151662
1930
1931         Reviewed by Antti Koivisto.
1932
1933         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1934         (TestWebKitAPI::TEST):
1935         * WebKitTestRunner/TestController.cpp:
1936         (WTR::TestController::generatePageConfiguration):
1937
1938 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1939
1940         Make usesNetworkProcess always true
1941         https://bugs.webkit.org/show_bug.cgi?id=151580
1942
1943         Reviewed by Darin Adler.
1944
1945         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1946         (TestWebKitAPI::TEST):
1947         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1948         (TestWebKitAPI::TEST):
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::generatePageConfiguration):
1951
1952 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1953
1954         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1955
1956         Add a way to skip unit tests only for Debug or Release builds and
1957         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1958
1959         * Scripts/run-gtk-tests:
1960         (SkippedTest):
1961         (SkippedTest.__init__):
1962         (SkippedTest.__str__):
1963         (SkippedTest.skip_entire_suite):
1964         (SkippedTest.skip_for_build_type):
1965         (TestRunner):
1966         (TestRunner.__init__):
1967
1968 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1969
1970         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1971
1972         It's an assert hit because we are reloading a view loaded with
1973         HTML data which is not supported. Use loadURI instead.
1974
1975         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1976         (testWebViewCustomCharset):
1977
1978 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1979
1980         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1981         https://bugs.webkit.org/show_bug.cgi?id=151633
1982
1983         Reviewed by Csaba Osztrogonác.
1984
1985         * TestWebKitAPI/PlatformGTK.cmake:
1986         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1987
1988 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1989
1990         [GTK] Remove the remaining uses of GMainLoopSource
1991         https://bugs.webkit.org/show_bug.cgi?id=151632
1992
1993         Reviewed by Žan Doberšek.
1994
1995         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1996         (testWebViewSyncRequestOnMaxConns):
1997         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1998         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1999         (WTR::TestRunner::TestRunner):
2000         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2001         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2002         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2003         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2004         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2005         (WTR::timeoutSource):
2006         (WTR::TestController::notifyDone):
2007         (WTR::TestController::platformRunUntil):
2008
2009 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2010
2011         [cmake] Add testb3 to the build system
2012         https://bugs.webkit.org/show_bug.cgi?id=151619
2013
2014         Reviewed by Gyuyoung Kim.
2015
2016         * Scripts/build-jsc:
2017
2018 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2019
2020         [jhbuild] Fix pixman build with clang
2021         https://bugs.webkit.org/show_bug.cgi?id=151441
2022
2023         Reviewed by Carlos Garcia Campos.
2024
2025         * efl/jhbuild.modules:
2026         * gtk/jhbuild.modules:
2027
2028 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2029
2030         Extract prependToEnvironmentVariableList
2031         <http://webkit.org/b/151536>
2032
2033         Reviewed by Daniel Bates.
2034
2035         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2036                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2037
2038         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2039         and prependToEnvironmentVariableList.
2040         (appendToEnvironmentVariableList): Simplify variable name.
2041         Switch to use $Config{path_sep}.
2042         (prependToEnvironmentVariableList): Add new method.
2043         (setupMacWebKitEnvironment): Switch to use
2044         prependToEnvironmentVariableList().
2045         (setupIOSWebKitEnvironment): Ditto.
2046
2047         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2048         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2049
2050 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2051
2052         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2053         https://bugs.webkit.org/show_bug.cgi?id=151567
2054
2055         Reviewed by Darin Adler.
2056
2057         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2058         (on_window_deletion):
2059
2060 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2061
2062         [GTK] Use the network process unconditionally
2063         https://bugs.webkit.org/show_bug.cgi?id=151541
2064
2065         Reviewed by Alex Christensen.
2066
2067         Fix TestInspectorServer test. Do not assume we already have the
2068         title we want when the page has been loaded, since the title is
2069         changed afterwards. So, check if the title has already been set,
2070         and if not wait for it.
2071
2072         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2073         (openRemoteDebuggingSession):
2074
2075 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2076
2077         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2078         https://bugs.webkit.org/show_bug.cgi?id=151532
2079
2080         Reviewed by Benjamin Poulain.
2081
2082         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2083         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2084         (TestWebKitAPI::TEST):
2085         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2086         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2087         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2088         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2089         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2090         so it was calling a function on a test object that had gone out of scope.
2091         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2092         but that will become the default soon and that call will be removed.
2093
2094 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2095
2096         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2097         <http://webkit.org/b/151542>
2098
2099         Reviewed by Daniel Bates.
2100
2101         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2102         (base_url): Use the Port object (already passed in) to give us
2103         the path to the LayoutTests directory, which already checks for a
2104         --layout-tests-directory command-line switch.
2105         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2106         argument since we can get this from the Port object already
2107         passed in via Port.results_directory().  Also switch to use
2108         Port.layout_tests_dir() to get the LayoutTests directory.
2109
2110         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2111         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2112         Add test case for custom LayoutTests directory.
2113         (TestWebPlatformTestServer.test_previously_spawned_instance):
2114         Update Port object to set mock results directory as if it was
2115         set on the command-line.  Remove unneeded argument from
2116         WebPlatformTestServer constructor.
2117         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2118
2119         * Scripts/webkitpy/port/base.py:
2120         (Port.to.start_web_platform_test_server): Remove unneeded
2121         argument from WebPlatformTestServer constuctor.
2122
2123 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2124
2125         [GTK] Some unit tests fail when using the network process
2126         https://bugs.webkit.org/show_bug.cgi?id=151490
2127
2128         Reviewed by Martin Robinson.
2129
2130         Run the soup server in a separate thread in TestResources test to
2131         avoid deadlocks.
2132
2133         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2134         /webkit2/WebKitWebResource/get-data when using the network process.
2135
2136         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2137         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2138         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2139         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2140         present, create a WorkQueue to run the server.
2141         (WebKitTestServer::run): Run the server in the work queue if it
2142         has been created.
2143         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2144         type into server options as flags.
2145
2146 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2147
2148         [GTK] ImageDiff should normalize the diff image
2149         https://bugs.webkit.org/show_bug.cgi?id=151261
2150
2151         Reviewed by Sergio Villar Senin.
2152
2153         * ImageDiff/gtk/ImageDiff.cpp:
2154         (readPixbufFromStdin): Fix memory leak.
2155         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2156         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2157
2158 == Rolled over to ChangeLog-2015-11-21 ==