Unreviewed. Adding myself to committers.
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
2
3         Unreviewed. Adding myself to committers.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
8
9         Unreviewed. Adding myself to committers.
10
11         * Scripts/webkitpy/common/config/contributors.json:
12
13 2014-06-20  Tim Horton  <timothy_horton@apple.com>
14
15         Make WebKit2 more accessible in MiniBrowser
16         https://bugs.webkit.org/show_bug.cgi?id=134099
17
18         Reviewed by Anders Carlsson.
19
20         * MiniBrowser/mac/AppDelegate.h:
21         * MiniBrowser/mac/AppDelegate.m:
22         (-[BrowserAppDelegate newWindow:]):
23         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
24         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
25         (-[BrowserAppDelegate _useWebKit2ByDefault]):
26         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
27         (-[BrowserAppDelegate validateMenuItem:]):
28         * MiniBrowser/mac/MainMenu.xib:
29         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
30         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
31         Make the non-default new-window menu item always show up, because people often don't find it
32         when you have to press option to have it show up.
33
34         * MiniBrowser/mac/BrowserWindowController.h:
35         * MiniBrowser/mac/BrowserWindowController.m:
36         (-[BrowserWindowController initWithWindow:]):
37         
38         * MiniBrowser/mac/WK1BrowserWindowController.m:
39         (-[WK1BrowserWindowController validateMenuItem:]):
40         * MiniBrowser/mac/WK2BrowserWindowController.m:
41         (-[WK2BrowserWindowController validateMenuItem:]):
42         Use the cached [menuItem action] like the earlier cases do.
43
44 2014-06-20  Daniel Bates  <dabates@apple.com>
45
46         Teach run-{safari, webkit-app} about iOS Simulator
47         https://bugs.webkit.org/show_bug.cgi?id=133986
48
49         Reviewed by David Kilzer.
50
51         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
52         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
53         and run-safari.
54
55         * Scripts/old-run-webkit-tests:
56         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
57         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
58         to call it.
59         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
60         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
61         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
62         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
63         when the iOS device SDK is used as we don't support launching an app on the device at this time.
64         * Scripts/webkitdirs.pm:
65         (xcodeSDKVersion): Added.
66         (setupIOSWebKitEnvironment): Added.
67         (installedMobileSafariBundle): Added.
68         (mobileSafariBundle): Added.
69         (plistPathFromBundle): Added.
70         (appIdentiferFromBundle): Added.
71         (appDisplayNameFromBundle): Added.
72         (loadIPhoneSimulatorNotificationIfNeeded): Added.
73         (openIOSSimulator): Added.
74         (quitIOSSimulator): Added.
75         (iosSimulatorDeviceByName): Added.
76         (iosSimulatorRuntime): Added.
77         (findOrCreateSimulatorForIOSDevice): Added.
78         (runIOSWebKitAppInSimulator): Added.
79         (installAndLaunchIOSWebKitAppInSimulator): Added.
80         (runIOSWebKitApp): Added.
81         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
82         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
83         device at this time.
84
85 2014-06-19  Anders Carlsson  <andersca@apple.com>
86
87         Add WTF::Optional class
88         https://bugs.webkit.org/show_bug.cgi?id=134083
89
90         Reviewed by Andreas Kling.
91
92         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
93         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
94         (TestWebKitAPI::TEST):
95
96 2014-06-20  Ion Rosca  <rosca@adobe.com>
97
98         Unreviewed. Adding myself to Committers list.
99
100         * Scripts/webkitpy/common/config/contributors.json:
101
102 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
103
104         [EFL] Add gstreamer as dependecy of EFL after r169785
105         https://bugs.webkit.org/show_bug.cgi?id=134066
106
107         Reviewed by Gyuyoung Kim.
108
109         * efl/jhbuild.modules:
110
111 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
112
113         [EFL] Merge url_utils.c to MiniBrowser
114         https://bugs.webkit.org/show_bug.cgi?id=134095
115
116         Reviewed by Csaba Osztrogonác.
117
118         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
119         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
120
121         * MiniBrowser/efl/CMakeLists.txt:
122         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
123         * MiniBrowser/efl/main.c:
124         (has_scheme): Copied from url_utils.c
125         (url_from_user_input): Ditto.
126
127 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
128
129         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
130
131         Reviewed by Csaba Osztrogonác.
132
133         * Scripts/webkitpy/common/config/ports_unittest.py:
134         (DeprecatedPortTest.test_gtk_wk2_port):
135         (DeprecatedPortTest.test_efl_port): Deleted.
136         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
137         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
138         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
139         (TestRebaselineExpectations.test_rebaseline_expectations):
140
141 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
142
143         [EFL][CMAKE] Disable WebKit1 build as a default
144         https://bugs.webkit.org/show_bug.cgi?id=134093
145
146         Reviewed by Gyuyoung Kim.
147
148         * CMakeLists.txt:
149
150 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
151
152         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
153         https://bugs.webkit.org/show_bug.cgi?id=93002
154
155         Reviewed by Gustavo Noronha Silva.
156
157         Add unit tests to check WebKitDOMNodefilter API used from both
158         TreeWalker and NodeIterator.
159
160         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
161         public headers and add WebKitDOMNodeFilter to the list of exceptions.
162         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
163         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
164         (webkitNodeFilterAcceptNode):
165         (webkitNodeFilterDOMNodeFilterIfaceInit):
166         (webkit_node_filter_init):
167         (webkit_node_filter_class_init):
168         (WebKitDOMNodeFilterTest::create):
169         (WebKitDOMNodeFilterTest::webPageFromArgs):
170         (WebKitDOMNodeFilterTest::testTreeWalker):
171         (WebKitDOMNodeFilterTest::testNodeIterator):
172         (WebKitDOMNodeFilterTest::runTest):
173         (registerTests):
174         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
175         (runTest):
176         (testWebKitDOMNodeFilterTreeWalker):
177         (testWebKitDOMNodeFilterNodeIterator):
178         (beforeAll):
179         (afterAll):
180         * gtk/webkitdom.py:
181         (WebKitDOMDocGeneratorSections.__init__):
182         (WebKitDOMDocGeneratorSections._symbol_list):
183         (WebKitDOMDocGeneratorSections.write_section):
184
185 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
186
187         [GTK] Limit the amount of API exposed to GObject DOM bindings API
188         https://bugs.webkit.org/show_bug.cgi?id=133726
189
190         Reviewed by Gustavo Noronha Silva.
191
192         Don't make fatal finding files without a .symbols file, since now
193         only the stable DOM API has .symbols files.
194
195         * gtk/webkitdom.py:
196         (get_all_webkitdom_symbol_files):
197
198 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
199
200         Remove efl wk1 buildbot and ews
201         https://bugs.webkit.org/show_bug.cgi?id=134089
202
203         Reviewed by Benjamin Poulain.
204
205         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
206
207         * BuildSlaveSupport/build.webkit.org-config/config.json:
208         * QueueStatusServer/config/queues.py:
209         * Scripts/webkitpy/common/config/ews.json:
210         * Scripts/webkitpy/common/config/ports.py:
211         (DeprecatedPort.port):
212         (QtWK2Port.run_webkit_tests_command):
213         (EflPort): Deleted.
214         (EflPort.build_webkit_command): Deleted.
215         * Scripts/webkitpy/port/builders.py:
216         * TestResultServer/static-dashboards/flakiness_dashboard.js:
217         * TestResultServer/static-dashboards/loader_unittests.js:
218
219 2014-06-19  David Kilzer  <ddkilzer@apple.com>
220
221         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
222         <http://webkit.org/b/134061>
223
224         Reviewed by Dan Bernstein.
225
226         * Scripts/webkitpy/style/checkers/cpp.py:
227         (check_spacing): Ignore '@' immediately before '{'.
228         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
229         (CppStyleTest.test_spacing_before_braces): Add unit test for
230         '^{' block syntax and '@{' Objective-C liternal NSDitionary
231         syntax.
232
233 2014-06-18  Tim Horton  <timothy_horton@apple.com>
234
235         All of MiniBrowser's WKWebViews should share a configuration
236         https://bugs.webkit.org/show_bug.cgi?id=134017
237
238         Reviewed by Anders Carlsson.
239
240         * MiniBrowser/mac/WK2BrowserWindowController.m:
241         (-[WK2BrowserWindowController awakeFromNib]):
242         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
243         This means that they'll share things like preferences, visited links, etc.
244         It also means that we'll properly share processes once we hit the process limit.
245
246 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
247
248         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
249         https://bugs.webkit.org/show_bug.cgi?id=133971
250
251         Reviewed by Martin Robinson.
252
253         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
254         building for the Wayland target. The latest 3.12 version is required to match
255         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
256         as well due to GTK+ depending on a newer version.
257
258 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
259
260         [EFL] Turn on NOSNIFF in FeatureList.pm
261         https://bugs.webkit.org/show_bug.cgi?id=134010
262
263         Reviewed by Csaba Osztrogonác.
264
265         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
266
267         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
268
269 2014-06-17  Tim Horton  <timothy_horton@apple.com>
270
271         MiniBrowser should show Web Content process pids in the window title
272         https://bugs.webkit.org/show_bug.cgi?id=134016
273
274         Reviewed by Sam Weinig.
275
276         * MiniBrowser/mac/WK2BrowserWindowController.m:
277         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
278
279 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
280
281         [GTK] Fix the handling of resize events after r169505.
282         https://bugs.webkit.org/show_bug.cgi?id=133517
283
284         Reviewed by Martin Robinson.
285
286         * Scripts/webkitpy/port/xvfbdriver.py:
287         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
288         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
289         need at least 900x640 pixels to pass.
290         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
291         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
292         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
293         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
294         (XvfbDriverTest.test_start_next_worker): Update resolution.
295         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
296         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
297         be requested over the main widget instead of the window.
298         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
299         the Mac port.
300         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
301         (WTR::PlatformWebView::setWindowFrame): Set the size and position
302         of the Window and the web view.
303
304 2014-06-17  Matthew Mirman <mmirman@apple.com>
305
306         Unreviewed. Added myself to list of contributors.
307
308         * Scripts/webkitpy/common/config/contributors.json: Added myself.
309
310 2014-06-17  Commit Queue  <commit-queue@webkit.org>
311
312         Unreviewed, rolling out r170058.
313         https://bugs.webkit.org/show_bug.cgi?id=133993
314
315         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
316         on #webkit).
317
318         Reverted changeset:
319
320         "[GTK] Fix the handling of resize events after r169505."
321         https://bugs.webkit.org/show_bug.cgi?id=133517
322         http://trac.webkit.org/changeset/170058
323
324 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
325
326         Update import-w3c-tests to reflect current W3C test repo directory structure
327         https://bugs.webkit.org/show_bug.cgi?id=133460
328
329         Reviewed by Bem Jones-Bey.
330
331         Removed all references to test status, which are no longer reflected in the
332         directory names in the W3C CSS test repo.  No tests are required for this 
333         change, the existing tests pass.
334
335         * Scripts/webkitpy/w3c/test_importer.py:
336         (main):
337         (TestImporter.__init__):
338         (TestImporter.find_importable_tests):
339         (TestImporter.setup_destination_directory):
340         (TestImporter.write_import_log):
341         (TestImporter.update_test_status): Deleted.
342
343 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
344
345         [GTK] Fix the handling of resize events after r169505.
346         https://bugs.webkit.org/show_bug.cgi?id=133517
347
348         Reviewed by Martin Robinson.
349
350         * Scripts/webkitpy/port/xvfbdriver.py:
351         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
352         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
353         need at least 900x640 pixels to pass.
354         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
355         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
356         be requested over the main widget instead of the window.
357         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
358         the Mac port.
359         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
360         (WTR::PlatformWebView::setWindowFrame): Set the size and position
361         of the Window and the web view.
362
363 2014-06-17  Dan Bernstein  <mitz@apple.com>
364
365         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
366         https://bugs.webkit.org/show_bug.cgi?id=133968
367
368         Reviewed by Anders Carlsson.
369
370         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
371         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
372         share an impl() with the original.
373
374 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
375
376         [EFL][WK2] Skip failing EFL API tests
377         https://bugs.webkit.org/show_bug.cgi?id=133981
378
379         Reviewed by Csaba Osztrogonác.
380
381         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
382
383         * TestWebKitAPI/PlatformEfl.cmake:
384
385 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
386
387         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
388         https://bugs.webkit.org/show_bug.cgi?id=133962
389
390         Reviewed by Gyuyoung Kim.
391
392         Since we bumped EFL to 1.9, this workaround is unnecessary.
393
394         * MiniBrowser/efl/main.c:
395         (update_view_favicon):
396
397 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
398
399         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
400         https://bugs.webkit.org/show_bug.cgi?id=131472
401
402         Reviewed by Martin Robinson.
403
404         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
405
406         * Scripts/webkitpy/port/xvfbdriver.py:
407         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
408         when running WebKitTestRunner with the Xvfb driver.
409         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
410         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
411         installed.
412         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
413         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
414         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
415         deal.
416
417 2014-06-16  Tanay C  <tanay.c@samsung.com>
418
419         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
420         https://bugs.webkit.org/show_bug.cgi?id=133792
421
422         Reviewed by Gyuyoung Kim.
423
424         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
425         (show_file_entry_dialog):
426         (window_create):
427
428 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
429
430         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
431         https://bugs.webkit.org/show_bug.cgi?id=133512
432
433         Reviewed by Chris Fleizach.
434
435         Added support for connecting to AtkSelection's 'selection-changed'
436         signal, and print it out as AXSelectedChildrenChanged in the tests.
437
438         Also removed some dead code, that became useless after r169487.
439
440         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
441         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
442
443 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
444
445         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
446         https://bugs.webkit.org/show_bug.cgi?id=133841
447
448         Reviewed by Gyuyoung Kim.
449
450         * MiniBrowser/efl/main.c:
451         (window_create):
452
453 2014-06-15  Dan Bernstein  <mitz@apple.com>
454
455         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
456
457         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
458
459 2014-06-15  Anders Carlsson  <andersca@apple.com>
460
461         Fix build.
462
463         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
464         (callRunJavaScriptBlockAndRelease):
465         (runJavaScriptInMainFrame):
466         (TEST_F):
467
468 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
469
470         Create MSE and EME watchlist
471         https://bugs.webkit.org/show_bug.cgi?id=133810
472
473         Reviewed by Eric Carlson.
474
475         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
476         definition and add Eric Carlson and myself to it.
477
478 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] Remove all deprecated API from GObject DOM bindings
481         https://bugs.webkit.org/show_bug.cgi?id=133728
482
483         Reviewed by Martin Robinson.
484
485         * gtk/webkitdom.py:
486         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
487         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
488
489 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
490
491         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
492         https://bugs.webkit.org/show_bug.cgi?id=133835
493
494         Reviewed by Tim Horton.
495         
496         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
497
498         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
499         (-[WebKitTestRunnerWindow initWithFrame:]):
500         (-[WebKitTestRunnerWindow setFrame:]):
501
502 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
503
504         [GTK] Performance tests should be always ran with WKTR.
505         https://bugs.webkit.org/show_bug.cgi?id=133780
506
507         Reviewed by Ryosuke Niwa.
508
509         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
510         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
511         is GTK.
512
513 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
514
515         [GTK] REGRESSION: application name is not correctly appended to the UA
516         https://bugs.webkit.org/show_bug.cgi?id=133793
517
518         Reviewed by Carlos Garcia Campos.
519
520         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
521         (testWebKitSettingsUserAgent):
522
523 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
524
525         [GTK] Unsupported browser in www.icloud.com
526         https://bugs.webkit.org/show_bug.cgi?id=133403
527
528         Reviewed by Martin Robinson.
529
530         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
531         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
532         quirk that was removed.
533
534 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
535
536         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
537         https://bugs.webkit.org/show_bug.cgi?id=133779
538
539         Reviewed by Benjamin Poulain.
540         
541         Tell the WebPage to use the testing viewport configuration from the injected bundle.
542
543         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
544         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
545         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
546         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
547         on iOS.
548
549 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
550
551         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
552         https://bugs.webkit.org/show_bug.cgi?id=133770
553
554         Reviewed by Anders Carlsson.
555         
556         Push the per-test view configuration up to TestController, so that platforms
557         can modify the behavior. This also allows platform-specific changes (e.g.
558         for threaded scrolling) to made without #ifefs.
559
560         * WebKitTestRunner/TestController.cpp:
561         (WTR::TestController::updateWebViewSizeForTest):
562         (WTR::TestController::updateWindowScaleForTest):
563         (WTR::shouldUseFixedLayout):
564         (WTR::TestController::updateLayoutTypeForTest):
565         (WTR::TestController::platformConfigureViewForTest):
566         (WTR::TestController::configureViewForTest):
567         * WebKitTestRunner/TestController.h:
568         * WebKitTestRunner/TestInvocation.cpp:
569         (WTR::TestInvocation::invoke):
570         (WTR::sizeWebViewForCurrentTest): Deleted.
571         (WTR::changeWindowScaleIfNeeded): Deleted.
572         (WTR::shouldUseThreadedScrolling): Deleted.
573         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
574         (WTR::shouldUseFixedLayout): Deleted.
575         (WTR::updateLayoutType): Deleted.
576         * WebKitTestRunner/TestInvocation.h:
577         (WTR::TestInvocation::pathOrURL):
578         * WebKitTestRunner/ios/TestControllerIOS.mm:
579         (WTR::shouldMakeViewportFlexible):
580         (WTR::TestController::platformConfigureViewForTest):
581         * WebKitTestRunner/mac/TestControllerMac.mm:
582         (WTR::shouldUseThreadedScrolling):
583         (WTR::TestController::platformConfigureViewForTest):
584
585 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
586
587         [EFL] Add dependencies packages to efl install-dependencies file
588         https://bugs.webkit.org/show_bug.cgi?id=133720
589
590         Reviewed by Csaba Osztrogonác.
591
592         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
593         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
594
595         * efl/install-dependencies:
596
597 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
598
599         Unreviewed. Moving myself to the list of reviewers.
600
601         * Scripts/webkitpy/common/config/contributors.json:
602
603 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
604
605         [EFL] Drop to maintain EFL 32bit release bot
606         https://bugs.webkit.org/show_bug.cgi?id=133710
607
608         Reviewed by Csaba Osztrogonác.
609
610         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
611
612 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
613
614         [GTK] Use a different user agent string depending on the site
615         https://bugs.webkit.org/show_bug.cgi?id=132681
616
617         Reviewed by Anders Carlsson.
618
619         Add a unit test to check user agent quirks.
620
621         * TestWebKitAPI/PlatformGTK.cmake:
622         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
623         (TestWebKitAPI::TEST):
624         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
625         (testWebKitSettings): Site specific quirks setting is now enabled
626         by default.
627
628 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
629
630         Unreviewed, update my list of email addresses in contributors.json.
631
632         * Scripts/webkitpy/common/config/contributors.json:
633
634 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
635
636         Always switch to an sRGB screen color profile when running tests
637         https://bugs.webkit.org/show_bug.cgi?id=133712
638
639         Reviewed by Tim Horton.
640         
641         Switch the screen color profile to sRGB when running tests, because even ref
642         tests need the screen to use the correct color profile.
643
644         * DumpRenderTree/mac/LayoutTestHelper.m:
645         (installLayoutTestColorProfile):
646         * Scripts/webkitpy/port/mac.py:
647         (MacPort.start_helper):
648
649 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
650
651         [EFL] Bump EFL libraries to 1.9
652         https://bugs.webkit.org/show_bug.cgi?id=125479
653
654         Reviewed by Gyuyoung Kim.
655
656         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
657         and László Langó <llango.u-szeged@partner.samsung.com>.
658
659         * ImageDiff/CMakeLists.txt:
660         * MiniBrowser/efl/CMakeLists.txt:
661         * efl/install-dependencies:
662         * efl/jhbuild.modules:
663         * efl/jhbuildrc:
664
665 2014-06-10  David Farler  <dfarler@apple.com>
666
667         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
668         https://bugs.webkit.org/show_bug.cgi?id=133663
669
670         Reviewed by David Kilzer.
671
672         * Scripts/old-run-webkit-tests:
673         (installAndLaunchDumpToolAppUsingNotification):
674         - Remove obsolete notification keys
675         - Key off of mandatory device UDID (a UUID)
676         - Create a device on demand via CoreSimulator if necessary
677         -- Grab the UDID from the created device plist.
678         * Scripts/webkitdirs.pm:
679         (iOSSimulatorDevicesPath): Added
680         (iOSSimulatorDevices): Added
681         (createiOSSimulatorDevice): Added
682         (deleteiOSSimulatorDevice): Added
683
684 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
685
686         [GTK][gtkdoc] remove -Wcast-align
687         https://bugs.webkit.org/show_bug.cgi?id=133640
688
689         Apparently gcc warns that GParamSpec is not castable to
690         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
691         though ARM hackers claim that those only need 4byte alignment. As long as gcc
692         behaves that way, this warning is not very useful, also they break the Debian
693         packaging.
694
695         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
696         scanner compilation, thus the compiler ignores the previous
697         -Waling-cast flag.
698
699         Reviewed by Martin Robinson.
700
701         * gtk/generate-gtkdoc:
702         (get_generator_for_config):
703
704 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
705
706         Disable button animations in regression tests
707         https://bugs.webkit.org/show_bug.cgi?id=133647
708         <rdar://problem/16677530>
709
710         Reviewed by Tim Horton.
711
712         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
713         (WTR::InjectedBundle::platformInitialize):
714
715 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
716
717         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
718         https://bugs.webkit.org/show_bug.cgi?id=133650
719
720         Reviewed by Tim Horton.
721         
722         No point checking for a Windows-style path in Cocoa code.
723
724         * WebKitTestRunner/TestInvocation.cpp:
725         (WTR::shouldUseThreadedScrolling):
726
727 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
728
729         Fix more latched scrolling test flakiness and slowness
730         https://bugs.webkit.org/show_bug.cgi?id=133601
731
732         Reviewed by Brent Fulgham.
733         
734         Latched scrolling tests were flakey for two reasons. First, the EventSender
735         wheel events were async from the web to the UI process, and the resulting
736         synthetic events also async from the UI to the web process. Make them sync
737         for testing.
738         
739         Secondly, the timer-based scrolling tree commit could result in the scrolling
740         tree (specifically the frame node's notion of the scrollable area and content
741         size) not being updated before the scrolling thread starts getting wheel events.
742         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
743         
744         Finally remove all the now-unnecessary timeouts from the tests.
745
746         * WebKitTestRunner/mac/EventSenderProxy.mm:
747         (WTR::EventSenderProxy::mouseMoveTo):
748         (WTR::EventSenderProxy::mouseScrollBy):
749         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
750
751 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
752
753         [EFL] Add parameter to MiniBrowser to disable web security
754         https://bugs.webkit.org/show_bug.cgi?id=121095
755
756         Reviewed by Gyuyoung Kim.
757
758         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
759         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
760         resources from other domains (cross-domain requests) such as access map location on another server.
761         Another possibility is to launch in a webkit browser local file tests that will refer to the links
762         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
763
764         * MiniBrowser/efl/main.c:
765         (window_create):
766         (elm_main):
767
768 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
769
770         32-bit build fix.
771
772         * WebKitTestRunner/mac/EventSenderProxy.mm:
773         (WTR::EventSenderProxy::mouseMoveTo):
774         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
775
776 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
777
778         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
779
780         * DumpRenderTree/mac/DumpRenderTree.mm:
781         (createWebViewAndOffscreenWindow):
782         * DumpRenderTree/mac/EventSendingController.mm:
783         (-[EventSendingController mouseScrollByX:andY:continuously:]):
784         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
785         * WebKitTestRunner/mac/EventSenderProxy.mm:
786         (WTR::EventSenderProxy::mouseScrollBy):
787         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
788
789 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
790
791         Latched scrolling tests are flakey on Mavericks
792         https://bugs.webkit.org/show_bug.cgi?id=133578
793         <rdar://problem/17180591>
794
795         Reviewed by Brent Fulgham.
796         
797         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
798         be wrong on machines with more than one screen. This is because we use
799         [NSScreen mainScreen] when computing the global coordinates of the events, but
800         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
801         
802         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
803         add comments clarifying why the coordinate math works (which is not obvious given
804         the events have no target window).
805         
806         Some scrolling tests also dispatched events outside the 800x600 test window, so
807         fix those tests, and add logging that will appear in test output when this happens.
808
809         * DumpRenderTree/mac/DumpRenderTree.mm:
810         (createWebViewAndOffscreenWindow):
811         * DumpRenderTree/mac/EventSendingController.mm:
812         (-[EventSendingController mouseScrollByX:andY:continuously:]):
813         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
814         * WebKitTestRunner/mac/EventSenderProxy.mm:
815         (WTR::EventSenderProxy::mouseMoveTo):
816         (WTR::EventSenderProxy::mouseScrollBy):
817         (WTR::EventSenderProxy::continuousMouseScrollBy):
818         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
819
820 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
821
822         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
823         https://bugs.webkit.org/show_bug.cgi?id=133533
824
825         Reviewed by Carlos Garcia Campos.
826
827         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
828         (run): Remove the jhbuild-wrapper wrapper from here. It should be
829         on Scripts/webkitpy/port/gtk.py.
830         * Scripts/webkitpy/port/base.py:
831         (Port.set_option): Add a set_option(name, value) function to set
832         the optparse parameter "name" to the value "value", even if the
833         parameter "name" is already initialized.
834         * Scripts/webkitpy/port/gtk.py:
835         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
836         If another wrapper is specified via the option "-l --wrapper=x",
837         then prepend the jhbuild-wrapper to the one specified.
838
839 2014-06-04  David Farler  <dfarler@apple.com>
840
841         Build ASan WebKit for iOS Simulator
842         https://bugs.webkit.org/show_bug.cgi?id=133489
843
844         Reviewed by Darin Adler.
845
846         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
847         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
848         - Add missing ASan LDFLAGS.
849         * asan/asan.xcconfig:
850         - Split compiler-rt linker flags for OS X and iOS Simulator
851
852 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
853
854         Add myself (yoav@yoav.ws) to contributors.json
855         https://bugs.webkit.org/show_bug.cgi?id=133492
856
857         * Scripts/webkitpy/common/config/contributors.json:
858
859 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
860
861         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
862         https://bugs.webkit.org/show_bug.cgi?id=133149
863
864         Reviewed by Csaba Osztrogonác.
865
866         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
867
868 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
869
870         Add a verbose flag to binding tests
871         https://bugs.webkit.org/show_bug.cgi?id=122303
872
873         Reviewed by Csaba Osztrogonác.
874
875         This patch will:
876         - Add a verbose keyword argument to the BindingsTests constructor,
877         - Add --no-verbose option to the run-bindigs-test.
878         Verbose mode, which is on by default, prints positive results to stdout as before.
879         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
880
881         Original patch from Matthew Hanson <matthew_hanson@apple.com>
882
883         * Scripts/run-bindings-tests:
884         (main):
885         * Scripts/webkitpy/bindings/main.py:
886         (BindingsTests.__init__):
887         (BindingsTests.detect_changes):
888
889 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
890
891         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
892         https://bugs.webkit.org/show_bug.cgi?id=133455
893
894         Reviewed by Timothy Hatcher.
895
896         Since the perf. dashboard doesn't support following renamed benchmarks,
897         keep reporting Speedometer results as DoYouEvenBench results.
898
899         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
900         (_generate_results_dict):
901
902 2014-05-31  Darin Adler  <darin@apple.com>
903
904         Viewport percentage tests that resize the viewport are flaky
905         https://bugs.webkit.org/show_bug.cgi?id=133351
906
907         Reviewed by Anders Carlsson.
908
909         * DumpRenderTree/mac/DumpRenderTree.mm:
910         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
911         happens to be stored in the UI delegate object. This is part of resetting the
912         window position.
913
914         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
915         a frame rectangle. The size is stored in the size of the web view itself.
916         * DumpRenderTree/mac/UIDelegate.mm:
917         (-[UIDelegate resetWindowOrigin]): Added.
918         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
919         old version would store the frame, but not resize the web view!
920         (-[UIDelegate webViewFrame:]): Get the size from the web view.
921
922         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
923         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
924
925         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
926         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
927         the window.
928
929         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
930         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
931         window gets resized too, not just the web view.
932         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
933
934         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
935         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
936         window gets resized too, not just the web view.
937         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
938
939 2014-05-30  Michael Saboff  <msaboff@apple.com>
940
941         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
942         https://bugs.webkit.org/show_bug.cgi?id=133409
943
944         Reviewed by Filip Pizlo.
945
946         Handle creating a tarball the same way as running remote when processing
947         paths in prepareBundle.
948
949         * Scripts/run-jsc-stress-tests:
950
951 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
952
953         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
954         https://bugs.webkit.org/show_bug.cgi?id=132280
955
956         Reviewed by Chris Fleizach.
957
958         Remove implementation of logAccessibilityEvents() for ATK based
959         ports, as this has proved to be a flaky method of checking that
960         ATK events are being properly emitted. Instead, it's better to use
961         the addNotificationListener() functions and provide a JS callback
962         to check that the right events are being emmitted from the tests.
963
964         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
965         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
966         with dummy implementation.
967         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
968         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
969
970 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
971
972         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
973         https://bugs.webkit.org/show_bug.cgi?id=132280
974
975         Rubber stamped by Carlos Garcia Campos.
976
977         Fix two small issues with previous patch (r169483), that caused some tests to break.
978
979         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
980         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
981         duplicated entry.
982         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
983         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
984
985 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
986
987         [ATK] Added new accessibility signal: text-caret-moved.
988         Make AccessibilityUIElement.setSelectedTextRange work
989         as atk_text_set_caret_offset when given offset == 0.
990         https://bugs.webkit.org/show_bug.cgi?id=132527
991
992         Reviewed by Mario Sanchez Prada.
993
994         text-caret-moved signal in accessibilityController is needed to
995         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
996         as LayoutTests. Add the signal to the controller.
997
998         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
999         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1000         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1001         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1002         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1003         (setSelectedTextRange): Change return type to bool.
1004         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1005         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
1006         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1007         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
1008         for extra arguments passed to handler and use it for text-caret-moved offset.
1009         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1010         Connect callback to new listener for ATK:AtkText:text-caret-moved.
1011         Refactor so that failures be reported.
1012         Initialize atk interfaces before trying to connect to them, see
1013         https://bugzilla.gnome.org/show_bug.cgi?id=729922
1014         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1015         Simplify code by using a vector in place of dozen variables.
1016         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1017         Comment about not synchronizing with accessibilityController.
1018
1019 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1020
1021         [GTK] Add a WebKit2 Performance bot.
1022         https://bugs.webkit.org/show_bug.cgi?id=132862
1023
1024         Reviewed by Csaba Osztrogonác.
1025
1026         This adds a GTK WebKit2 perf bot.
1027
1028         * BuildSlaveSupport/build.webkit.org-config/config.json:
1029
1030 2014-05-29  Dan Bernstein  <mitz@apple.com>
1031
1032         Fixed the WebKitTestRunner build after r169452.
1033
1034         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1035         (WTR::InjectedBundle::initialize):
1036
1037 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
1038
1039         Unreviewed. Update my email addresses in contributors.json.
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
1044
1045         Need an API test for bug #133193 (r169315)
1046         <https://bugs.webkit.org/show_bug.cgi?id=133324>
1047
1048         This adds an API test that ensures that calling "stop loading" during a
1049         "did fail provisional load" callback doesn't crash.
1050
1051         Reviewed by Andy Estes.
1052
1053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1054         Add new files to project.
1055
1056         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
1057         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1058         If the message is the "test done" message, record that.
1059         (TestWebKitAPI::setInjectedBundleClient):
1060         Register a function for the "did receive message from injected bundle"
1061         callback.
1062         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1063         Assert that we received the message from the injected bundle, and set
1064         'done' to finish the test.
1065         (TestWebKitAPI::TEST):
1066         Create a WebView, register a page loader client for the "did fail
1067         provisional load" callback, and load a non-existent resource.
1068
1069         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
1070         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
1071         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
1072         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
1073         provisional load failed.
1074         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
1075         Register a page loader client for the "did fail provisional load"
1076         callback.
1077         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
1078         Call WKBundlePageStopLoading() during the callback. This not crashing
1079         is what we're ensuring with this test.
1080
1081 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         [GTK] Make it possible to build with FTL enabled
1084         https://bugs.webkit.org/show_bug.cgi?id=133219
1085
1086         Reviewed by Philippe Normand.
1087
1088         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
1089         same revision than mac.
1090
1091 2014-05-27  Michael Saboff  <msaboff@apple.com>
1092
1093         REGRESSION(r169265): sh: line 0: cd: ../.vm
1094         https://bugs.webkit.org/show_bug.cgi?id=133242
1095
1096         Rubber stamped by Oliver Hunt.
1097
1098         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
1099         array since the command may contain character escapes that don't work with the
1100         array form of system().
1101
1102         * Scripts/run-jsc-stress-tests:
1103
1104 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1105
1106         [EFL] Change download url of freetype6
1107         https://bugs.webkit.org/show_bug.cgi?id=133303
1108
1109         Reviewed by Csaba Osztrogonác.
1110
1111         freetype6 tarball isn't downloaded in Korea. So, we need to
1112         change the url for now.
1113
1114         * efl/jhbuild.modules:
1115
1116 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1117
1118         Remove BLOB guards
1119         https://bugs.webkit.org/show_bug.cgi?id=132863
1120
1121         Reviewed by Csaba Osztrogonác.
1122
1123         * Scripts/webkitperl/FeatureList.pm:
1124
1125 2014-05-27  Alberto Garcia  <berto@igalia.com>
1126
1127         Remove leftover comment from r165182.
1128
1129         Rubber stamped by Carlos Garcia Campos.
1130
1131         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1132
1133 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1134
1135         [EFL] Add LLVM as optional jhbuild module for FTL developers
1136         https://bugs.webkit.org/show_bug.cgi?id=133216
1137
1138         Reviewed by Gyuyoung Kim.
1139
1140         * efl/jhbuild.modules:
1141
1142 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1143
1144         Fix test failures on python test
1145         https://bugs.webkit.org/show_bug.cgi?id=133297
1146
1147         Reviewed by Dirk Schulze.
1148
1149         2 tests are failing because of unbounded local variable reference in test_importer.py.
1150
1151         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
1152         (TestImporter.import_tests):
1153
1154 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1155
1156         [GTK] GObject DOM bindings API break test fails in the tests bots
1157         https://bugs.webkit.org/show_bug.cgi?id=133211
1158
1159         Reviewed by Martin Robinson.
1160
1161         When generating the built product archive on platform GTK, we need
1162         to copy also the file gtkdoc-webkitdom.cfg and the directory
1163         DerivedSources/webkitdom.
1164
1165         * BuildSlaveSupport/built-product-archive:
1166         (archiveBuiltProduct):
1167
1168 2014-05-26  Commit Queue  <commit-queue@webkit.org>
1169
1170         Unreviewed, rolling out r169122.
1171         https://bugs.webkit.org/show_bug.cgi?id=133288
1172
1173         Broke CJK font fallback (Requested by ap on #webkit).
1174
1175         Reverted changeset:
1176
1177         "[Mac] WebProcess doesn't follow localization of UI process
1178         when run as a service"
1179         https://bugs.webkit.org/show_bug.cgi?id=133126
1180         http://trac.webkit.org/changeset/169122
1181
1182 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         [GTK] WebProcess leaked when closing pages with network process enabled
1185         https://bugs.webkit.org/show_bug.cgi?id=129684
1186
1187         Reviewed by Anders Carlsson.
1188
1189         Enable the test to check that web processes finish when the web
1190         view is destroyed.
1191
1192         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1193
1194 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1195
1196         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
1197         https://bugs.webkit.org/show_bug.cgi?id=133279
1198
1199         Reviewed by Philippe Normand.
1200
1201         generator.saw_warnings is only set by GTKDoc::generate(), so it
1202         should only be used after generate.
1203
1204         * gtk/generate-gtkdoc:
1205         (generate_documentation_for_config): Do not check
1206         generator.saw_warnings again, simply return the value returned by
1207         generate_doc() which is generator.saw_warnings. When rebasing,
1208         returns always False since there aren't warnings.
1209
1210 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1211
1212         W3C test importer should catch exceptions coming from HTML/CSS conversion
1213         https://bugs.webkit.org/show_bug.cgi?id=133176
1214
1215         Reviewed by Darin Adler.
1216
1217         Exceptions raised when converting HTML/CSS are caught.
1218         Files for which conversion failed are still copied to the target directory.
1219         Each individual conversion failure is logged.
1220         Total conversion failure number is logged at the end of the import process.
1221
1222         * Scripts/webkitpy/w3c/test_importer.py:
1223         (TestImporter.import_tests):
1224
1225 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1226
1227         [GTK] Allow to run the tests on the native X display.
1228         https://bugs.webkit.org/show_bug.cgi?id=133157
1229
1230         Reviewed by Benjamin Poulain.
1231
1232         This adds a new driver (xorgdriver) that runs the tests on the
1233         X display referenced by the environment variable DISPLAY.
1234
1235         This new driver will be activated only if the environment variable
1236         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
1237         tests and performance tests.
1238
1239         This patch also makes the script run-perf-tests to check the
1240         system dependencies before starting the tests. Previously this
1241         was not checked, and if the system dependencies were not met,
1242         the script tried to execute the tests anyway, causing massive
1243         failures. For example, if you had Xvfb not installed and you
1244         wanted to use the Xvfb driver (the default on GTK and EFL),
1245         run-perf-tests would not abort.
1246
1247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1248         (PerfTestsRunner._parse_args): Check the system dependencies of
1249         the driver before starting the tests.
1250         * Scripts/webkitpy/port/driver.py:
1251         (Driver): Implement generic check_driver method.
1252         (Driver.check_driver):
1253         (Driver.check_driver.implementation):
1254         * Scripts/webkitpy/port/gtk.py:
1255         (GtkPort._driver_class): Check for environment variable
1256         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
1257         * Scripts/webkitpy/port/xorgdriver.py: Added.
1258         (XorgDriver): Implement Xorg driver.
1259         (XorgDriver.check_driver):
1260         (XorgDriver._start):
1261
1262 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1263
1264         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
1265         https://bugs.webkit.org/show_bug.cgi?id=133215
1266
1267         Reviewed by Csaba Osztrogonác.
1268
1269         This reverts r166798.
1270
1271         * BuildSlaveSupport/kill-old-processes:
1272         (main):
1273
1274 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1275
1276         [EFL] Turn on ENABLE_CSS_FILTERS in build script
1277         https://bugs.webkit.org/show_bug.cgi?id=133278
1278
1279         Reviewed by Gyuyoung Kim.
1280
1281         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
1282
1283 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1284
1285         run-javascriptcore-tests warning fix on non Mac platforms
1286         https://bugs.webkit.org/show_bug.cgi?id=133260
1287
1288         Reviewed by Darin Adler.
1289
1290         * Scripts/webkitdirs.pm:
1291         (argumentsForConfiguration):
1292
1293 2014-05-23  Michael Saboff  <msaboff@apple.com>
1294
1295         REGRESSION(r169265): sh: line 0: cd: ../.vm
1296         https://bugs.webkit.org/show_bug.cgi?id=133242
1297
1298         Rubber stamped by Geoffrey Garen.
1299
1300         Added missing shell escapes '\' required as part of previous fix.
1301
1302         * Scripts/run-jsc-stress-tests:
1303
1304 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
1305
1306         Revert the erroneous change committed in r169286.
1307
1308         * Scripts/webkitpy/performance_tests/perftest.py:
1309         (PerfTest._run_with_driver):
1310
1311 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
1312
1313         run-perf-tests should ignore whitespace lines when snarfing test output
1314         https://bugs.webkit.org/show_bug.cgi?id=133238
1315
1316         Reviewed by Ryosuke Niwa.
1317
1318         Required for PerformanceTests/Canvas/terrain.html.
1319
1320         * Scripts/webkitpy/performance_tests/perftest.py:
1321         (PerfTest._run_with_driver):
1322         (PerfTest):
1323
1324 2014-05-23  Michael Saboff  <msaboff@apple.com>
1325
1326         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
1327         https://bugs.webkit.org/show_bug.cgi?id=133223
1328
1329         Reviewed by Geoffrey Garen.
1330
1331         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
1332         string before calling IO.popen() to work with older versions of ruby.
1333         Changed the remote path in runShellTestRunner to quote the command
1334         string we want to run via ssh so that it will work correctly with array
1335         to string conversion needed for popen.
1336
1337         * Scripts/run-jsc-stress-tests:
1338
1339 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1340
1341         Remove 'css-shaders' option from the build-webkit
1342         https://bugs.webkit.org/show_bug.cgi?id=133212
1343
1344         Reviewed by Daniel Bates.
1345
1346         Original CSS shaders removed in r162644.
1347
1348         * Scripts/webkitperl/FeatureList.pm:
1349
1350 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1351
1352         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
1353         https://bugs.webkit.org/show_bug.cgi?id=133209
1354
1355         Reviewed by Sergio Villar Senin.
1356
1357         Return FAILURE when the command failed to run.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1360         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
1361
1362 2014-05-23  Alberto Garcia  <berto@igalia.com>
1363
1364         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1365         https://bugs.webkit.org/show_bug.cgi?id=133210
1366
1367         Reviewed by Carlos Garcia Campos.
1368
1369         * gtk/install-dependencies:
1370
1371 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1372
1373         Add Yusuke Suzuki to the list of contributors (for real)
1374
1375         Wrong section...
1376
1377         * Scripts/webkitpy/common/config/contributors.json:
1378
1379 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1380
1381         Add Yusuke Suzuki to the list of contributors
1382
1383         * Scripts/webkitpy/common/config/contributors.json:
1384
1385 2014-05-22  Michael Saboff  <msaboff@apple.com>
1386
1387         Eliminate n/total progress update from run-jsc-stress-tests output to file
1388         https://bugs.webkit.org/show_bug.cgi?id=133191
1389
1390         Reviewed by Geoffrey Garen.
1391
1392         Changed progressMeter setting to be based on stdout being a tty instead of
1393         stdin.  Unified the processing of output from the shell runner to match the
1394         same processing as is used by the makefile runner.  As part of this, the 
1395         shell runner script was simplified.  It now forwards the output of each
1396         test_script just like the Makefile and doesn't provide its own progress.
1397
1398         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1399         * Scripts/run-jsc-stress-tests:
1400
1401 2014-05-22  Michael Saboff  <msaboff@apple.com>
1402
1403         Add option to run-jsc-stress-tests to use installed jsc
1404         https://bugs.webkit.org/show_bug.cgi?id=133102
1405
1406         Reviewed by Geoffrey Garen.
1407
1408         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1409         provied with the --jsc option.
1410
1411         * Scripts/run-jsc-stress-tests:
1412
1413 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1414
1415         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1416         https://bugs.webkit.org/show_bug.cgi?id=132907
1417
1418         Reviewed by Gyuyoung Kim.
1419
1420         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1421         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1422
1423         * efl/install-dependencies:
1424
1425 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1426
1427         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1428         https://bugs.webkit.org/show_bug.cgi?id=133145
1429
1430         Reviewed by Csaba Osztrogonác.
1431
1432         * Scripts/run-jsc-stress-tests:
1433
1434 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
1435
1436         [Mac] WebProcess doesn't follow localization of UI process when run as a service
1437         https://bugs.webkit.org/show_bug.cgi?id=133126
1438         <rdar://problem/13396515>
1439         <rdar://problem/16561084>
1440
1441         Reviewed by Sam Weinig and Tim Horton.
1442
1443         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1444         (WTR::InjectedBundle::platformInitialize): It was too late to override language
1445         here, and it's not necessary any more. Keeping the code for older OS versions in
1446         case it did have effect in some code paths.
1447
1448 2014-05-19  David Farler  <dfarler@apple.com>
1449
1450         Move WebKitTestRunner to std::unique_ptr
1451         https://bugs.webkit.org/show_bug.cgi?id=133081
1452
1453         Reviewed by Daniel Bates.
1454
1455         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1456         (WTR::InjectedBundle::didCreatePage):
1457         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1458         * WebKitTestRunner/TestController.cpp:
1459         (WTR::TestController::initialize):
1460         (WTR::TestController::createWebViewWithOptions):
1461         (WTR::TestController::resetStateToConsistentValues):
1462         (WTR::TestController::runTest):
1463         * WebKitTestRunner/TestController.h:
1464         * WebKitTestRunner/TestInvocation.cpp:
1465         * WebKitTestRunner/TestInvocation.h:
1466         * WebKitTestRunner/WorkQueueManager.cpp:
1467         (WTR::WorkQueueManager::processWorkQueue):
1468         (WTR::WorkQueueManager::enqueue):
1469         * WebKitTestRunner/WorkQueueManager.h:
1470
1471 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1474         https://bugs.webkit.org/show_bug.cgi?id=133119
1475
1476         Reviewed by Sergio Villar Senin.
1477
1478         Check that redirect response parameter of
1479         WebKitWebPage::send-request signal is NULL when not redirecting
1480         and a valid WebKitURIResponse object when redirecting.
1481
1482         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1483         (testWebResourceSendRequest):
1484         (serverCallback):
1485         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1486         (sendRequestCallback):
1487
1488 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1489
1490         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1491         https://bugs.webkit.org/show_bug.cgi?id=133117
1492
1493         Reviewed by Philippe Normand.
1494
1495         Bring back missing tests to the build.
1496
1497         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1498
1499 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
1500
1501         Take care of some ARM64 test failures
1502         https://bugs.webkit.org/show_bug.cgi?id=133090
1503
1504         Reviewed by Geoffrey Garen.
1505
1506         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1507
1508 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1509
1510         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1511         <http://webkit.org/b/133089>
1512
1513         Reviewed by Darin Adler.
1514
1515         * Scripts/webkitdirs.pm:
1516         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1517         specified on the command line, we would remove the '--sdk'
1518         arguments, but leave '--sim', potentially passing it along to
1519         xcodebuild causing a build failure.  This happens when
1520         'old-run-webkit-tests --release --sim' invokes
1521         build-dumprendertree when DumpRenderTree hasn't been built yet.
1522
1523 2014-05-19  David Farler  <dfarler@apple.com>
1524
1525         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1526         https://bugs.webkit.org/show_bug.cgi?id=133086
1527
1528         Reviewed by Daniel Bates.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1531
1532 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1533
1534         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1535         <http://webkit.org/b/132954>
1536
1537         * Scripts/webkitdirs.pm:
1538         (sharedCommandLineOptionsUsage): Remove the prototype for the
1539         subroutine.  Older perls don't like the "+@" syntax.
1540
1541 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1542
1543         run-javascriptcore-tests should sort the list of failing stress tests
1544         https://bugs.webkit.org/show_bug.cgi?id=132989
1545
1546         Reviewed by Csaba Osztrogonác.
1547
1548         * Scripts/run-javascriptcore-tests:
1549
1550 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1551
1552         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1553         <http://webkit.org/b/132954>
1554
1555         Reviewed by Darin Adler.
1556
1557         Extract code into setupMacWebKitEnvironment() for setting up
1558         common environment variables so it may be shared.  Sets
1559         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1560         using guardmalloc to some scripts.
1561
1562         Also adds support for parsing shared (common) command-line
1563         switches, initially just -g|--guard-malloc.
1564
1565         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1566         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1567         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1568         local copy of %ENV when launching Safari so we don't have to
1569         restore variables.
1570
1571         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1572         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1573         Check result of GetOptions() to catch invalid command-line
1574         switches.
1575         (runTest): Use a local copy of %ENV when running tests so we
1576         don't have to restore variables.
1577         (prepareEnvironmentForRunningTestTool): Call
1578         setupMacWebKitEnvironment().
1579
1580         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1581         using sharedCommandLineOptions() and
1582         sharedCommandLineOptionsUsage().  Call
1583         setupMacWebKitEnvironment().
1584
1585         * Scripts/webkitdirs.pm:
1586         (sharedCommandLineOptions): Return array of common switches to
1587         pass to Getopt::Long::GetOptions().
1588         (sharedCommandLineOptionsUsage): Return formatted string of
1589         common switches for printing usage help text.
1590         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1591         guardmalloc.
1592         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1593         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1594         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1595         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1596         local copy of %ENV when launching Safari so we don't have to
1597         restore variables.
1598         (execMacWebKitAppForDebugging): Call
1599         setupMacWebKitEnvironment().
1600
1601 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1602
1603         support for navigator.hardwareConcurrency
1604         https://bugs.webkit.org/show_bug.cgi?id=132588
1605
1606         Reviewed by Filip Pizlo.
1607
1608         * Scripts/webkitperl/FeatureList.pm:
1609
1610 2014-05-18  Anders Carlsson  <andersca@apple.com>
1611
1612         Implement Navigations for all methods declared returning one
1613         https://bugs.webkit.org/show_bug.cgi?id=133048
1614         <rdar://problem/16830064>
1615
1616         Reviewed by Sam Weinig.
1617
1618         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1619         Import WebKit.h.
1620         
1621         * MiniBrowser/mac/WK2BrowserWindowController.m:
1622         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1623         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1624         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1625         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1626         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1627         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1628         Print out the navigations.
1629
1630 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1631
1632         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1633         https://bugs.webkit.org/show_bug.cgi?id=133029
1634
1635         Reviewed by Simon Fraser.
1636
1637         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1638         toggling it on a WK2 window needs restart.
1639         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1640         the WebPreferences just to support this temporary toggle.
1641
1642         * MiniBrowser/mac/BrowserWindowController.h:
1643         * MiniBrowser/mac/MainMenu.xib:
1644         * MiniBrowser/mac/WK1BrowserWindowController.m:
1645         (-[WK1BrowserWindowController validateMenuItem:]):
1646         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1647         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1648         * MiniBrowser/mac/WK2BrowserWindowController.m:
1649         (-[WK2BrowserWindowController validateMenuItem:]):
1650         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1651         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1652
1653 2014-05-17  Anders Carlsson  <andersca@apple.com>
1654
1655         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1656         https://bugs.webkit.org/show_bug.cgi?id=133033
1657         <rdar://problem/16830143>
1658
1659         Reviewed by Sam Weinig.
1660
1661         Set up the WebSQL and IndexedDB directories.
1662
1663         * WebKitTestRunner/TestController.cpp:
1664         (WTR::TestController::initialize):
1665
1666 2014-05-16  Martin Hock  <mhock@apple.com>
1667
1668         MemoryCache::addImageToCache should return the result of add().
1669         https://bugs.webkit.org/show_bug.cgi?id=132928
1670         <rdar://problem/16651547>
1671
1672         Reviewed by Alexey Proskuryakov.
1673
1674         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1676         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1677         (TestWebKitAPI::TEST):
1678
1679 2014-05-15  David Farler  <dfarler@apple.com>
1680
1681         old-run-webkit-tests: allow specifying a simulator app path
1682         https://bugs.webkit.org/show_bug.cgi?id=132975
1683
1684         Reviewed by Anders Carlsson.
1685
1686         * Scripts/old-run-webkit-tests:
1687         (openIPhoneSimulator):
1688         Add new --simulator-app command line parameter for specifying the
1689         absolute path to the simulator app to launch before starting a
1690         session.
1691
1692 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1693
1694         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1695         https://bugs.webkit.org/show_bug.cgi?id=131363
1696
1697         Reviewed by Csaba Osztrogonác.
1698
1699         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1700         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1701         (MockBugzilla):
1702         * Scripts/webkitpy/tool/commands/download_unittest.py:
1703         (test_create_rollout_multiple_revision_with_one_resolved):
1704         (test_create_rollout_multiple_resolved):
1705         (test_rollout_two_revisions):
1706         (test_rollout_multiple_revisions):
1707         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1708         * Scripts/webkitpy/tool/steps/createbug.py:
1709         (CreateBug.run):
1710         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1711         (ReopenBugAfterRollout.run):
1712
1713 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1714
1715         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1716         https://bugs.webkit.org/show_bug.cgi?id=132956
1717
1718         Reviewed by Sam Weinig.
1719
1720         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1721         * MiniBrowser/mac/AppDelegate.m:
1722         * MiniBrowser/mac/WK2BrowserWindowController.m:
1723         * TestWebKitAPI/InjectedBundleController.h:
1724         * TestWebKitAPI/InjectedBundleMain.cpp:
1725         * TestWebKitAPI/JavaScriptTest.cpp:
1726         * TestWebKitAPI/PlatformUtilities.h:
1727         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1728         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1729         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1730         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1731         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1732         (TestWebKitAPI::TEST):
1733         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1734         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1735         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1736         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1737         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1738         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1739         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1740         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1741         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1742         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1743         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1744         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1745         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1746         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1747         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1748         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1749         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1750         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1751         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1752         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1753         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1754         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1755         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1756         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1757         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1758         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1759         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1760         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1761         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1762         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1763         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1764         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1765         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1766         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1767         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1768         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1769         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1770         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1771         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1772         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1773         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1774         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1775         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1776         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1777         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1778         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1779         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1780         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1781         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1782         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1783         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1784         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1785         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1786         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1787         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1788         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1789         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1790         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1791         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1792         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1793         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1794         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1795         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1796         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1797         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1798         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1799         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1800         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1801         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1802         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1803         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1804         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1805         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1806         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1807         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1808         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1809         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1810         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1811         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1812         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1813         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1814         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1815         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1816         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1817         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1818         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1819         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1820         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1821         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1822         * TestWebKitAPI/config.h:
1823         * TestWebKitAPI/efl/PlatformWebView.cpp:
1824         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1825         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1826         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1827         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1828         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1829         * WebKitTestRunner/EventSenderProxy.h:
1830         * WebKitTestRunner/GeolocationProviderMock.cpp:
1831         * WebKitTestRunner/GeolocationProviderMock.h:
1832         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1833         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1834         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1835         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1836         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1837         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1838         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1840         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1842         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1843         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1844         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1845         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1846         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1847         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1848         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1849         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1850         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1851         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1853         * WebKitTestRunner/PlatformWebView.h:
1854         * WebKitTestRunner/StringFunctions.h:
1855         * WebKitTestRunner/TestController.cpp:
1856         * WebKitTestRunner/TestController.h:
1857         * WebKitTestRunner/TestInvocation.cpp:
1858         * WebKitTestRunner/TestInvocation.h:
1859         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1860         * WebKitTestRunner/WebNotificationProvider.cpp:
1861         * WebKitTestRunner/WebNotificationProvider.h:
1862         * WebKitTestRunner/WorkQueueManager.cpp:
1863         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1864         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1865         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1866         * WebKitTestRunner/config.h:
1867         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1868         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1869         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1870         * WebKitTestRunner/ios/TestControllerIOS.mm:
1871         * WebKitTestRunner/mac/EventSenderProxy.mm:
1872         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1873         * WebKitTestRunner/mac/TestControllerMac.mm:
1874
1875 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1876
1877         [EFL][WK2] Skip failing unit tests
1878         https://bugs.webkit.org/show_bug.cgi?id=132979
1879
1880         Reviewed by Daniel Bates.
1881
1882         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1883
1884 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1885
1886         [iOS] Support TestWebKitAPI in the iOS Simulator
1887         <http://webkit.org/b/129535>
1888         <rdar://problem/16203529>
1889
1890         Reviewed by Daniel Bates.
1891
1892         * Scripts/run-api-tests:
1893         (runTest):
1894         (listAllTests):
1895         - Extract common arguments into local variable.
1896         - Use xcrun to find the sim tool in order to invoke
1897         TestWebKitAPI properly in the iOS Simulator. 
1898
1899         * Scripts/webkitdirs.pm:
1900         (argumentsForConfiguration): Set --device or --sim as
1901         appropriate to fix buildTestTool() in run-api-tests.
1902
1903 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1904
1905         Fix a logging typo in copy-webkitlibraries-to-product-directory
1906
1907         Reviewed by Dean Jackson.
1908
1909         * Scripts/copy-webkitlibraries-to-product-directory:
1910
1911 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1912
1913         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1914         <http://webkit.org/b/132959>
1915
1916         Reviewed by Dan Bernstein.
1917
1918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1919         Cocoa directory to project and move URLExtras.mm into it.
1920         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1921
1922 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         [GTK] Compile all installed resources as GResources
1925         https://bugs.webkit.org/show_bug.cgi?id=131099
1926
1927         Reviewed by Philippe Normand.
1928
1929         * Scripts/webkitpy/port/gtk.py:
1930         (GtkPort.setup_environ_for_server): Removed now unneeded
1931         AUDIO_RESOURCES_PATH env var.
1932
1933 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1934
1935         Remove CSS_STICKY_POSITION guards
1936         https://bugs.webkit.org/show_bug.cgi?id=132676
1937
1938         Reviewed by Simon Fraser.
1939
1940         * Scripts/webkitperl/FeatureList.pm:
1941
1942 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1943
1944         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1945         https://bugs.webkit.org/show_bug.cgi?id=132686
1946
1947         Reviewed by Philippe Normand.
1948
1949         Bring back InputMethodFilter test to the build and compile it into
1950         a single binary TestWebCore with the other WebCore tests. Also
1951         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1952
1953         * Scripts/run-gtk-tests:
1954         (TestRunner): Remove WebCoreGtk from the list of test directories.
1955         * TestWebKitAPI/PlatformGTK.cmake:
1956         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1957
1958 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1959
1960         [EFL] Make XVFBDriver optional
1961         https://bugs.webkit.org/show_bug.cgi?id=131036
1962
1963         Reviewed by Gyuyoung Kim.
1964
1965         * Scripts/webkitpy/port/efl.py:
1966         (EflPort._driver_class):
1967
1968 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1969
1970         Flakiness dashboard contains outdated list of bots on builders.jsonp
1971         https://bugs.webkit.org/show_bug.cgi?id=132874
1972
1973         Reviewed by Darin Adler.
1974
1975         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1976         file by changing to the directory Tools/TestResultServer and executing
1977         the script generate_builders_json.py
1978
1979 2014-05-11  Anders Carlsson  <andersca@apple.com>
1980
1981         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1982         https://bugs.webkit.org/show_bug.cgi?id=132809
1983
1984         Reviewed by Dan Bernstein.
1985
1986         * WebKitTestRunner/TestController.cpp:
1987         (WTR::TestController::initialize):
1988         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1989
1990 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1991
1992         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1993         https://bugs.webkit.org/show_bug.cgi?id=132739
1994
1995         Reviewed Anders Carlsson.
1996
1997         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1998         the JSC unit tests.
1999         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
2000
2001 2014-05-11  Anders Carlsson  <andersca@apple.com>
2002
2003         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
2004         https://bugs.webkit.org/show_bug.cgi?id=132806
2005
2006         Reviewed by Beth Dakin.
2007
2008         Migrate to WKContextConfiguration.
2009
2010         * WebKitTestRunner/TestController.cpp:
2011         (WTR::TestController::initialize):
2012
2013 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2014
2015         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
2016         https://bugs.webkit.org/show_bug.cgi?id=132685
2017
2018         Reviewed by Martin Robinson.
2019
2020         Use a single TestWebKit2 binary for all WebKit2 C API tests.
2021
2022         * TestWebKitAPI/PlatformGTK.cmake:
2023
2024 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
2025
2026         [iOS] Switch geolocation to an explicit authorization query model
2027         https://bugs.webkit.org/show_bug.cgi?id=132717
2028
2029         Reviewed by Sam Weinig.
2030
2031         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2032         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
2033         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
2034
2035 2014-05-09  David Farler  <dfarler@apple.com>
2036
2037         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
2038         https://bugs.webkit.org/show_bug.cgi?id=132718
2039
2040         Reviewed by David Kilzer.
2041
2042         The simulator may not be able to look up runtimes by SDK paths
2043         and instead will map SDK versions to runtimes instead. In
2044         com.apple.iphonesimulator.startSession notifications,
2045         'runtimeIdentifier' (SDK version string) is preferred over
2046         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
2047         when creating a new DRT or WKTR simulator session.
2048
2049         IPhoneSimulatorNotification.pm filters out keys for this
2050         notification's userInfo with a hard-coded list. There's no harm
2051         in including extra key-value pairs in an NSNotification userInfo
2052         dictionary anyway and the simulator may again change its
2053         userInfo schema for this notification.
2054
2055         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2056         (postStartSessionNotification):
2057         * Scripts/old-run-webkit-tests:
2058         (installAndLaunchDumpToolAppUsingNotification):
2059
2060 2014-05-09  Anders Carlsson  <andersca@apple.com>
2061
2062         Another build fix.
2063
2064         * Scripts/build-webkit:
2065         WebKit2 should always be built for OS X and iOS.
2066
2067 2014-05-09  Anders Carlsson  <andersca@apple.com>
2068
2069         Follow-up build fix.
2070
2071         * Scripts/build-webkit:
2072         WebKit2 should no longer be built before WebKit.
2073
2074 2014-05-09  Anders Carlsson  <andersca@apple.com>
2075
2076         Rename WebKit2.framework to WebKit.framework
2077         https://bugs.webkit.org/show_bug.cgi?id=132743
2078         <rdar://problem/15920046>
2079
2080         Reviewed by Dan Bernstein.
2081
2082         * Scripts/check-for-inappropriate-files-in-framework:
2083         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
2084         Change WebKit2 to WebKit.
2085
2086         * Scripts/check-for-webkit-framework-include-consistency:
2087         Change WebKit to WebKitLegacy.
2088
2089 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
2090
2091         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
2092         https://bugs.webkit.org/show_bug.cgi?id=132732
2093
2094         Reviewed by Alexey Proskuryakov.
2095
2096         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
2097
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2099         (EWS): Remove GTK+ WK1 EWS.
2100
2101 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2102
2103         Add new u-szeged contributors.
2104
2105         Reviewed by Csaba Osztrogonác.
2106
2107         * Scripts/webkitpy/common/config/contributors.json:
2108
2109 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2110
2111         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
2112         https://bugs.webkit.org/show_bug.cgi?id=132736
2113
2114         Reviewed by Philippe Normand.
2115
2116         There are two problems, the path returned by common.library_build_path() is wrong when
2117         common.binary_build_path() has previously been called, and the test is still looking for
2118         the .la instead of .so
2119
2120         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
2121         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
2122         of .la as extension of the injected bundle library.
2123         * gtk/common.py:
2124         (binary_build_path): Remove unused global variable and add a new
2125         one for binary_build_dir instead of sharing the same global
2126         variable for library_build_path and binary_build_path.
2127
2128 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
2129
2130         [EFL] Enable MEDIA_STREAM for EFL port
2131         https://bugs.webkit.org/show_bug.cgi?id=132648
2132
2133         Reviewed by Gyuyoung Kim.
2134
2135         Script modified to enable MEDIA_STREAM for EFL build.
2136
2137         * Scripts/webkitperl/FeatureList.pm: 
2138
2139 2014-05-08  David Farler  <dfarler@apple.com>
2140
2141         old-run-webkit-tests: update strings for simulator devices and app name
2142         https://bugs.webkit.org/show_bug.cgi?id=132687
2143
2144         Reviewed by Darin Adler.
2145
2146         iPhone Retina (4-inch) -> iPhone 5
2147         iPhone Retina (4-inch 64-bit) -> iPhone 5s
2148
2149         * Scripts/old-run-webkit-tests:
2150         (installAndLaunchDumpToolAppUsingNotification):
2151         (openIPhoneSimulator):
2152         (quitIPhoneSimulator):
2153         quit iOS Simulator, not iPhone Simulator.
2154
2155 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2156
2157         REGRESSION(r168471): Update the builder names on the scheduler list.
2158         https://bugs.webkit.org/show_bug.cgi?id=132699
2159
2160         Reviewed by Martin Robinson.
2161
2162         On r168471 I missed to update the builder names for the GTK build
2163         bots on the AnyBranchScheduler type scheduler list of bots.
2164
2165         * BuildSlaveSupport/build.webkit.org-config/config.json:
2166
2167 2014-05-08  Brady Eidson  <beidson@apple.com>
2168
2169         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
2170         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
2171
2172         Reviewed by Tim Horton.
2173
2174         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2175         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2176
2177 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2178
2179         REGRESSION(r168471): Duplicate builddirs broke the build master.
2180         https://bugs.webkit.org/show_bug.cgi?id=132688
2181
2182         Reviewed by Carlos Garcia Campos.
2183
2184         Rename the builddirs of the new GTK bots introduced on r168471 to
2185         be unique. Otherwise the master will break.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/config.json:
2188
2189 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2190
2191         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
2192         https://bugs.webkit.org/show_bug.cgi?id=132674
2193
2194         Reviewed by Philippe Normand.
2195
2196         Only ignore mkdir failure when exception is raised because the
2197         file already exists and it's a directory.
2198
2199         * gtk/webkitdom.py:
2200         (write_doc_files):
2201
2202 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2203
2204         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
2205         https://bugs.webkit.org/show_bug.cgi?id=131358
2206
2207         Reviewed by Carlos Garcia Campos.
2208
2209         Current 64-bit GTK build bots (Release and Debug) not only test
2210         the build, but run all tests. Split each one of the bots in
2211         BuildOnly and TestWebKit2.
2212
2213         This will allow us to have a better overview of the status of
2214         the GTK port.
2215
2216         Original patch from Sergio Villar Senin <svillar@igalia.com>
2217
2218         * BuildSlaveSupport/build.webkit.org-config/config.json:
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2221         (WebKitBuildbot):
2222         * Scripts/webkitpy/port/builders.py:
2223         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2224         (TestRebaselineTest.test_baseline_directory):
2225         * TestResultServer/static-dashboards/builders.jsonp:
2226         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2227         (resetGlobals):
2228         * TestResultServer/static-dashboards/loader_unittests.js:
2229
2230 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2231
2232         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
2233         https://bugs.webkit.org/show_bug.cgi?id=126022
2234
2235         Reviewed by Benjamin Poulain.
2236
2237         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
2238
2239         Added an unit test case to check if scroll position and scale are restored properly.
2240
2241         * TestWebKitAPI/PlatformEfl.cmake:
2242         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
2243         (TestWebKitAPI::didFinishLoadForFrame):
2244         (TestWebKitAPI::didChangeContentsPosition):
2245         (TestWebKitAPI::TEST):
2246         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
2247         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
2248
2249 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
2250
2251         WebKit1 is flashy when compositing layers come and go
2252         https://bugs.webkit.org/show_bug.cgi?id=132655
2253         <rdar://problem/16830981&16788846>
2254
2255         Reviewed by Sam Weinig.
2256         
2257         Revert the change from r166117.
2258
2259         * DumpRenderTree/mac/DumpRenderTree.mm:
2260         (updateDisplay):
2261
2262 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
2263
2264         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
2265         https://bugs.webkit.org/show_bug.cgi?id=132622
2266
2267         Reviewed by Mario Sanchez Prada.
2268
2269         * DumpRenderTree/AccessibilityUIElement.cpp:
2270         (selectTextWithCriteriaCallback):
2271         (isEqualCallback):
2272         * DumpRenderTree/AccessibilityUIElement.h:
2273         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2274         (AccessibilityUIElement::selectTextWithCriteria):
2275         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2276         (AccessibilityUIElement::selectTextWithCriteria):
2277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2278         (selectTextParameterizedAttributeForCriteria):
2279         (AccessibilityUIElement::selectTextWithCriteria):
2280         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2281         (AccessibilityUIElement::selectTextWithCriteria):
2282         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2283         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2284         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2285         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2286         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2287         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2288         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2289         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2290         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2291         (WTR::selectTextParameterizedAttributeForCriteria):
2292         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2293
2294 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2295
2296         [SOUP] TLSErrors do not cause page load to fail when not ignored
2297         https://bugs.webkit.org/show_bug.cgi?id=121548
2298
2299         Reviewed by Sergio Villar Senin.
2300
2301         Add unit tests to check that the load fails with TLS errors in
2302         case of a redirection.
2303
2304         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2305         (testTLSErrorsRedirect):
2306         (httpsServerCallback):
2307         (beforeAll):
2308
2309 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
2310
2311         [CSS Grid Layout] Remove runtime feature
2312         https://bugs.webkit.org/show_bug.cgi?id=132382
2313
2314         Reviewed by Benjamin Poulain.
2315
2316         Remove cssGridLayoutEnabled setting usage.
2317
2318         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2319         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2320         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2321         (TestRunner::overridePreference):
2322         * DumpRenderTree/mac/DumpRenderTree.mm:
2323         (resetWebPreferencesToConsistentValues):
2324
2325 2014-05-06  David Kilzer  <ddkilzer@apple.com>
2326
2327         Add Makefile targets for copying static libraries (LLVM and WKSI)
2328         <http://webkit.org/b/132619>
2329
2330         Reviewed by Mark Rowe.
2331
2332         * Scripts/copy-webkitlibraries-to-product-directory: Set a
2333         sensible default for product directory if not specified on
2334         either the command-line or in the environment (by Xcode) by
2335         calling productDir() in webkitdirs.pm.
2336
2337 2014-05-06  Brady Eidson  <beidson@apple.com>
2338
2339         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
2340         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
2341
2342         Reviewed by Sam Weinig.
2343
2344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2345
2346         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
2347         (TestWebKitAPI::itemURLLastComponentIsString):
2348         (TestWebKitAPI::didFinishLoadForFrame):
2349         (TestWebKitAPI::willGoToBackForwardListItem):
2350         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2351         (TestWebKitAPI::setPageLoaderClient):
2352         (TestWebKitAPI::TEST):
2353         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
2354         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
2355
2356         * WebKitTestRunner/TestController.cpp:
2357         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
2358
2359 2014-05-06  Darin Adler  <darin@apple.com>
2360
2361         Try to fix iOS build.
2362
2363         * DumpRenderTree/mac/TestRunnerMac.mm:
2364         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2365         Updated since I changed testRunner into a pointer instead of a reference.
2366         Updated argument names to avoid conflict with field names.
2367         (-[APITestDelegateIPhone run]): Ditto.
2368         (-[APITestDelegateIPhone _cleanUp]): Ditto.
2369
2370 2014-05-06  Commit Queue  <commit-queue@webkit.org>
2371
2372         Unreviewed, rolling out r168304.
2373         https://bugs.webkit.org/show_bug.cgi?id=132607
2374
2375         Broke the build (Requested by KaL on #webkit).
2376
2377         Reverted changeset:
2378
2379         "[GTK][CMake] Unable to do make install"
2380         https://bugs.webkit.org/show_bug.cgi?id=130188
2381         http://trac.webkit.org/changeset/168304
2382
2383 2014-05-04  Darin Adler  <darin@apple.com>
2384
2385         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2386         https://bugs.webkit.org/show_bug.cgi?id=80222
2387
2388         Reviewed by Alexey Proskuryakov.
2389
2390         * DumpRenderTree/mac/TestRunnerMac.mm:
2391         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2392         do more work here so we don't use RetainPtr local variables.
2393         (-[APITestDelegateIPhone dealloc]): Added.
2394         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2395         created. Updated for changes to member names and types.
2396         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2397         updated for changes to member names and types. Changed to two word spelling.
2398         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2399         name of _cleanUp method.
2400         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2401         Ditto.
2402         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2403
2404 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
2405
2406         Clean up Image Document and tweak the layout and viewport
2407         https://bugs.webkit.org/show_bug.cgi?id=132552
2408
2409         Reviewed by Anders Carlsson.
2410
2411         * DumpRenderTree/mac/DumpRenderTree.mm:
2412         (resetWebPreferencesToConsistentValues):
2413         Update the default settings to have something consistent with WebKit2.
2414
2415 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
2416
2417         [GTK][CMake] Unable to do make install
2418         https://bugs.webkit.org/show_bug.cgi?id=130188
2419
2420         Reviewed by Carlos Garcia Campos.
2421
2422         * Scripts/webkitdirs.pm:
2423         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2424         will give an early signal that a change has broken the documentation.
2425
2426 2014-05-05  Pratik Solanki  <psolanki@apple.com>
2427
2428         Update framework locations in package-root
2429         https://bugs.webkit.org/show_bug.cgi?id=132571
2430
2431         Reviewed by Simon Fraser.
2432
2433         * Scripts/package-root:
2434
2435 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
2436
2437         [EFL][WK2] Refactor favicon database APIs
2438         https://bugs.webkit.org/show_bug.cgi?id=132519
2439
2440         Reviewed by Gyuyoung Kim.
2441
2442         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2443         (update_view_favicon):
2444         (on_icon_changed_cb):
2445         (window_free):
2446         (on_url_changed):
2447         (window_create):
2448         (on_view_favicon_changed): Deleted.
2449
2450 2014-05-02  Mark Rowe  <mrowe@apple.com>
2451
2452         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2453
2454         Reviewed by Dan Bernstein.
2455
2456         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2457         when determining which LLVM archive to extract.
2458
2459 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2460
2461         Add Jeremy as a committer.
2462         https://bugs.webkit.org/show_bug.cgi?id=132492
2463
2464         Reviewed by Jer Noble.
2465
2466         Add myself as a committer.
2467
2468         * Scripts/webkitpy/common/config/contributors.json:
2469
2470 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2471
2472         Add Jeremy as a committer.
2473         https://bugs.webkit.org/show_bug.cgi?id=132492
2474
2475         Reviewed by Jer Noble.
2476
2477         Add Jeremy Jones to the committers file.
2478
2479         * Scripts/webkitpy/common/config/contributors.json:
2480
2481 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
2482
2483         Hard to figure out how to run a single test with run-api-tests
2484         https://bugs.webkit.org/show_bug.cgi?id=116332
2485
2486         Reviewed by Alexey Proskuryakov.
2487
2488         * Scripts/run-api-tests: add two examples to the help message.
2489
2490 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
2491
2492         Fix several memory leaks found by code inspection
2493         https://bugs.webkit.org/show_bug.cgi?id=132472
2494
2495         Reviewed by Geoffrey Garen.
2496         
2497         Fix memory leaks.
2498
2499         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2500         (TestWebKitAPI::TEST):
2501         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2502         (WTR::InjectedBundlePage::willSendRequestForFrame):
2503         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2504         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2505
2506 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2507
2508         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2509         https://bugs.webkit.org/show_bug.cgi?id=132446
2510
2511         Reviewed by Mark Hahnenberg.
2512         
2513         Test the FTL by default now that it's enabled by default.
2514
2515         * Scripts/run-javascriptcore-tests:
2516
2517 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2518
2519         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2520         https://bugs.webkit.org/show_bug.cgi?id=132240
2521
2522         Reviewed by Anders Carlsson.
2523
2524         Removed ewk_view_setting_tiled_backingstore related code.
2525
2526         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2527         (DumpRenderTreeChrome::createView):
2528         (shouldUseTiledBackingStore): Deleted.
2529         * EWebLauncher/main.c:
2530         (windowCreate):
2531         (parseUserArguments):
2532
2533 2014-05-01  Anders Carlsson  <andersca@apple.com>
2534
2535         window.testRunner.keepWebHistory() should update the UI process state
2536         https://bugs.webkit.org/show_bug.cgi?id=132440
2537
2538         Reviewed by Dan Bernstein.
2539
2540         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2541         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2542         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2544         (WTR::TestRunner::keepWebHistory):
2545         * WebKitTestRunner/TestInvocation.cpp:
2546         (WTR::TestInvocation::invoke):
2547         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2548
2549 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2550
2551         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2552         <http://webkit.org/b/132432>
2553
2554         Reviewed by Tim Horton.
2555
2556         * Scripts/webkitperl/FeatureList.pm: Remove support for
2557         --plugin-proxy-for-video switch.
2558
2559 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2560
2561         Kernel sysctl interface hw.activecpu don't exists on Linux.
2562         https://bugs.webkit.org/show_bug.cgi?id=132286
2563
2564         Reviewed by Filip Pizlo.
2565
2566         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2567         calling sysctl over hw.activecpu
2568
2569 2014-04-30  Anders Carlsson  <andersca@apple.com>
2570
2571         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2572         https://bugs.webkit.org/show_bug.cgi?id=132399
2573         <rdar://problem/15920046>
2574
2575         Reviewed by Dan Bernstein.
2576
2577         * Scripts/check-for-webkit-framework-include-consistency:
2578         Allos WAK headers in WebKitLegacy as well as WebKit.
2579
2580         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2581         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2582         Update header imports.
2583
2584 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2585
2586         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2587         https://bugs.webkit.org/show_bug.cgi?id=131954
2588
2589         Reviewed by Darin Adler.
2590         
2591         WebKitTestRunner was adding application-specific information to crash reports
2592         to log the test path, but only in the web process. Fix it to also do this
2593         for the UI process, for both iOS and OS X.
2594         
2595         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2596         both iOS and OS X.
2597         
2598         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2599         a new TestController::platformWillRunTest() function on Mac and iOS.
2600         
2601         Also remove Xcode-added unit test junk from the project.
2602
2603         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2604         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2605         * WebKitTestRunner/TestController.cpp:
2606         (WTR::TestController::runTest):
2607         * WebKitTestRunner/TestController.h:
2608         * WebKitTestRunner/TestInvocation.cpp:
2609         (WTR::TestInvocation::url):
2610         * WebKitTestRunner/TestInvocation.h:
2611         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2612         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2613         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2614         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2615         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2616         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2617         (WTR::testPathFromURL):
2618         (WTR::setCrashReportApplicationSpecificInformationToURL):
2619         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2620         (WTR::TestController::platformWillRunTest):
2621         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2622         (WTR::TestController::platformWillRunTest):
2623         * WebKitTestRunner/ios/TestControllerIOS.mm:
2624         (WTR::TestController::platformWillRunTest):
2625         (WTR::TestController::setHidden):
2626         * WebKitTestRunner/mac/TestControllerMac.mm:
2627         (WTR::TestController::platformWillRunTest):
2628
2629 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2630
2631         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2632
2633         Reviewed by Tim Horton.
2634
2635         * DumpRenderTree/mac/DumpRenderTree.mm:
2636         (resetWebPreferencesToConsistentValues):
2637         (prepareConsistentTestingEnvironment):
2638
2639 2014-04-30  Anders Carlsson  <andersca@apple.com>
2640
2641         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2642         https://bugs.webkit.org/show_bug.cgi?id=132397
2643
2644         Reviewed by Dan Bernstein.
2645
2646         * Scripts/check-for-inappropriate-macros-in-external-headers:
2647
2648 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2649
2650         [GTK] Make it easier to run CMake for downstreams
2651         https://bugs.webkit.org/show_bug.cgi?id=132370
2652
2653         Reviewed by Carlos Garcia Campos.
2654
2655         * Scripts/webkitdirs.pm:
2656         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2657         the GTK+ port.
2658
2659 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2660
2661         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2662         
2663         Rubber stamped by Jessie Berlin.
2664
2665         JSON.pm was removed from our tools setup.
2666
2667         * Scripts/generate-coverage-data:
2668
2669 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2670
2671         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2672         https://bugs.webkit.org/show_bug.cgi?id=112840
2673
2674         Rubber stamped by Geoffrey Garen.
2675
2676         * Scripts/build-jsc: Enable it on Mac.
2677         * Scripts/build-webkit: Enable it on Mac.
2678         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2679
2680 2014-04-28  Sam Weinig  <sam@webkit.org>
2681
2682         REGRESSION (r167751): svn-create-patch is very slow
2683         https://bugs.webkit.org/show_bug.cgi?id=132300
2684
2685         Reviewed by Alexey Proskuryakov.
2686
2687         * Scripts/svn-create-patch:
2688         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2689         by calling `svn-create-patch --style`.
2690
2691 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2692
2693         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2694         https://bugs.webkit.org/show_bug.cgi?id=132190
2695
2696         Reviewed by Gustavo Noronha Silva.
2697
2698         * Scripts/webkitdirs.pm:
2699         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2700             if ninja is in the path.
2701         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2702             to the previous ninja generator if not.
2703
2704 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2705
2706         check-webkit-style should understand --git-index
2707         https://bugs.webkit.org/show_bug.cgi?id=125364
2708
2709         Reviewed by Csaba Osztrogonác.
2710
2711         * Scripts/webkitpy/common/checkout/scm/git.py:
2712         (Git.create_patch): The command now supports the --cached option.
2713         * Scripts/webkitpy/style/main.py:
2714         (CheckWebKitStyle.main): Passing the --git-index option.
2715         * Scripts/webkitpy/style/optparser.py:
2716         (CommandOptionValues.__init__): The git-index option is switched off by default.
2717         (CommandOptionValues.__eq__): Equality check for the new option.
2718         (ArgumentParser._create_option_parser):Adding the --git-index option
2719         (ArgumentParser.parse):
2720         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2721         (CommandOptionValuesTest.test_init): 
2722         (CommandOptionValuesTest.test_eq):
2723
2724 2014-04-28  Michael Saboff  <msaboff@apple.com>
2725
2726         Crash in platform/mac/accessibility/table-visible-rows.html
2727         https://bugs.webkit.org/show_bug.cgi?id=132146
2728
2729         Reviewed by Filip Pizlo.
2730
2731         Instead of creating a local JSValueRef array on the stack and passing that to
2732         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2733         values using the JSObjectSetPropertyAtIndex() API.
2734
2735         * DumpRenderTree/AccessibilityUIElement.cpp:
2736         (elementsForRangeCallback):
2737         (convertElementsToObjectArray):
2738         * DumpRenderTree/mac/TestRunnerMac.mm:
2739         (originsArrayToJS):
2740         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2741         (WTR::EventSendingController::contextClick):
2742         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2743         (WTR::stringArrayToJS):
2744         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2745         (WTR::convertElementsToObjectArray):
2746
2747 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2748
2749         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2750         "no-cjit" runs force the old-school threshold.
2751
2752         Rubber stamped by Mark Hahnenberg.
2753
2754         * Scripts/run-jsc-stress-tests:
2755
2756 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2757
2758         [GTK] install-dependencies should also install ruby-json and ruby-highline
2759         https://bugs.webkit.org/show_bug.cgi?id=132292
2760
2761         Reviewed by Philippe Normand.
2762
2763         * gtk/install-dependencies: Install ruby json and highline packages.
2764
2765 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2766
2767         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2768         https://bugs.webkit.org/show_bug.cgi?id=132176
2769
2770         Reviewed by Gyuyoung Kim.
2771
2772         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2773         and turn off indexedDB feature until the sqlite implementation is introduced.
2774
2775         * Scripts/webkitperl/FeatureList.pm:
2776
2777 2014-04-25  James Craig  <jcraig@apple.com>
2778
2779         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2780         https://bugs.webkit.org/show_bug.cgi?id=132209
2781
2782         Reviewed by Daniel Bates.
2783
2784         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2785         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2786
2787         * Scripts/prepare-ChangeLog:
2788         (main): 
2789
2790 2014-04-25  Michael Saboff  <msaboff@apple.com>
2791
2792         Crash in platform/mac/accessibility/table-visible-rows.html
2793         https://bugs.webkit.org/show_bug.cgi?id=132146
2794
2795         Reviewed by Mark Lam.
2796
2797         Changed to use a local JSValueRef array temporary instead of a
2798         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2799         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2800         the temporary values could be collected.
2801
2802         * DumpRenderTree/AccessibilityUIElement.cpp:
2803         (convertElementsToObjectArray):
2804         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2805         (WTR::EventSendingController::contextClick):
2806         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2807         (WTR::convertElementsToObjectArray):
2808
2809 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2810
2811         Unreviewed GTK gardening
2812
2813         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2814         (TestRunner):
2815
2816 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2817
2818         prepare-ChangeLog reports as deleted methods that has not been removed.
2819         https://bugs.webkit.org/show_bug.cgi?id=131733
2820
2821         Reviewed by Ryosuke Niwa.
2822
2823         * Scripts/prepare-ChangeLog:
2824         (originalFile): Set merge base to origin/master by default.
2825
2826 2014-04-23  James Craig  <jcraig@apple.com>
2827
2828         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2829         https://bugs.webkit.org/show_bug.cgi?id=131115
2830
2831         Reviewed by Daniel Bates.
2832
2833         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2834
2835         * Scripts/commit-log-editor: Added --no-style.
2836         * Scripts/prepare-ChangeLog: Primary patch.
2837         (main): Primary patch.
2838         (createPatchCommand): Added --no-style.
2839         * Scripts/svn-create-patch: Primary patch.
2840         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2841         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2842         (SVN.create_patch): Added --no-style.
2843
2844 2014-04-23  Anders Carlsson  <andersca@apple.com>
2845
2846         Try to fix iOS build.
2847
2848         * DumpRenderTree/mac/DumpRenderTree.mm:
2849
2850 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2851
2852         Eliminate internals.setMockScrollbarsEnabled()
2853         https://bugs.webkit.org/show_bug.cgi?id=132085
2854
2855         Reviewed by Tim Horton.
2856
2857         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2858         No need to reset the preference, there is no way it can change.
2859
2860 2014-04-23  James Craig  <jcraig@apple.com>
2861
2862         Unreviewed. Moving myself from Contributors to Committers list.
2863
2864         * Scripts/webkitpy/common/config/contributors.json:
2865
2866 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2867
2868         Mock scrollbars don't always work in DumpRenderTree
2869         https://bugs.webkit.org/show_bug.cgi?id=132082
2870
2871         Reviewed by Alexey Proskuryakov.
2872
2873         * DumpRenderTree/mac/DumpRenderTree.mm:
2874         (prepareConsistentTestingEnvironment):
2875         Set the mock scrollbar setting before creating the WebView, as this setting
2876         cannot be dynamically changed, so any scrollbars that are created during
2877         WebView initialization and are not replaced before snapshotting will end
2878         up being platform scrollbars instead of mock ones.
2879         WebKitTestRunner already sets this preference before creating WKViews,
2880         so we're just matching its behavior.
2881
2882 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2883
2884         [GTK] ShadowRoot API was removed in r164131
2885         https://bugs.webkit.org/show_bug.cgi?id=132059
2886
2887         Reviewed by Gustavo Noronha Silva.
2888
2889         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2890         the API docs.
2891
2892         * gtk/webkitdom.py:
2893         (WebKitDOMDocGenerator):
2894
2895 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2896
2897         [GTK] run-webkit-tests script is failing to invoke run-launcher
2898         https://bugs.webkit.org/show_bug.cgi?id=132051
2899
2900         Reviewed by Philippe Normand.
2901
2902         After the WK1 support was dropped, if run-webkit-tests is executed
2903         without --no-show-results parameter, the launcher is being called
2904         using a -2 parameter that is it causing the run-launcher to break.
2905
2906         * Scripts/webkitpy/port/gtk.py:
2907         (GtkPort.show_results_html_file):
2908
2909 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2910
2911         DumpRenderTree generates black snapshots on some platforms
2912         https://bugs.webkit.org/show_bug.cgi?id=132029
2913         <rdar://problem/16679363>
2914
2915         Reviewed by Simon Fraser.
2916
2917         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2918         (createBitmapContextFromWebView):
2919         DRT checks with the WebView to determine whether it can use the window's
2920         backing store directly or (because of compositing) needs to take a WindowServer
2921         snapshot. However, on some platforms and in some situations, the window can
2922         be layer backed without the WebView necessarily currently being composited.
2923         We should check with the window in addition to the WebView before going
2924         ahead and using its backing store.
2925
2926 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2927
2928         DumpRenderTree generates white snapshots on some platforms
2929         https://bugs.webkit.org/show_bug.cgi?id=132026
2930         <rdar://problem/16679363>
2931
2932         Reviewed by Simon Fraser.
2933
2934         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2935         Link DRT against QuartzCore.
2936
2937         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2938         (createBitmapContextFromWebView):
2939         Force CoreAnimation to synchronously update layers in a more explicit
2940         way that doesn't depend on AppKit behavior. This is very similar to what
2941         WebKitTestRunner does (indirectly) during its force repaint.
2942
2943 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2944
2945         [Win] Support Python 2.7 in Cygwin
2946         https://bugs.webkit.org/show_bug.cgi?id=132023
2947
2948         Reviewed by Michael Saboff.
2949
2950         * Scripts/webkitdirs.pm:
2951         (checkInstalledTools): Remove check for Python 2.7, since
2952         it now works properly.
2953
2954 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2955
2956         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2957         https://bugs.webkit.org/show_bug.cgi?id=130867
2958         <rdar://problem/16432456> 
2959
2960         Reviewed by Mark Hahnenberg.
2961
2962         * Scripts/build-webkit:
2963         * Scripts/copy-webkitlibraries-to-product-directory:
2964
2965 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2966
2967         [GTK] Fails to build documentation when output is redirected
2968         https://bugs.webkit.org/show_bug.cgi?id=131178
2969
2970         Reviewed by Martin Robinson.
2971
2972         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2973         explicitly to avoid encoding issues when they are redirected.
2974
2975 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2976
2977         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2978         https://bugs.webkit.org/show_bug.cgi?id=131911
2979
2980         Reviewed by Martin Robinson.
2981
2982         common.get_build_path returns release path even though Debug configuration
2983         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2984
2985         * gtk/ycm_extra_conf.py:
2986         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2987         (FlagsForFile):
2988
2989 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2990
2991         Unreviewed build fix.
2992
2993         * DumpRenderTree/mac/EventSendingController.mm:
2994         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2995         Correct a typo that prevented tests from working properly.
2996
2997 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2998
2999         [GTK] Should have the ability to output composited contents during layout testing
3000         https://bugs.webkit.org/show_bug.cgi?id=131864
3001
3002         Reviewed by Philippe Normand.
3003
3004         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3005         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
3006         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
3007         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3008         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
3009
3010 2014-04-21  Sam Weinig  <sam@webkit.org>
3011
3012         Attempt to fix the tests.
3013
3014         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3015         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3016         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
3017
3018 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
3019
3020         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
3021         being the same as a "quick run", which is meant for genuinely slow tests).
3022
3023         * Scripts/run-jsc-stress-tests:
3024
3025 2014-04-21  Darin Adler  <darin@apple.com>
3026
3027         Add HashSet::takeAny
3028         https://bugs.webkit.org/show_bug.cgi?id=131928
3029
3030         Reviewed by Benjamin Poulain.
3031
3032         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
3033
3034 2014-04-20  Dan Bernstein  <mitz@apple.com>
3035
3036         Fixed a test timing out after r167572.
3037
3038         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3039         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
3040         -webView:didFinishLoadingNavigation:.
3041
3042 2014-04-20  Commit Queue  <commit-queue@webkit.org>
3043
3044         Unreviewed, rolling out r167510.
3045         https://bugs.webkit.org/show_bug.cgi?id=131915
3046
3047         broke GTK Debug bot (Requested by philn on #webkit).
3048
3049         Reverted changeset:
3050
3051         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
3052         it when running layout tests"
3053         https://bugs.webkit.org/show_bug.cgi?id=131472
3054         http://trac.webkit.org/changeset/167510
3055
3056 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
3057
3058         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
3059         https://bugs.webkit.org/show_bug.cgi?id=131472
3060
3061         Reviewed by Philippe Normand.
3062
3063         * Scripts/webkitpy/port/gtk.py:
3064         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
3065         when running WebKitTestRunner with run-webkit-tests.
3066         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
3067         installed.
3068         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
3069         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
3070         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
3071         deal.
3072
3073 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
3074
3075         DownloadDecideDestinationCrash API test uses an incorrect value for path
3076         https://bugs.webkit.org/show_bug.cgi?id=131845
3077         <rdar://problem/15925560>
3078
3079         Reviewed by Enrica Casucci.
3080
3081         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3082         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
3083
3084 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
3085
3086         [Mac] AttributedStringTest API tests fail with async text input
3087         https://bugs.webkit.org/show_bug.cgi?id=131833
3088
3089         Reviewed by Enrica Casucci.
3090
3091         Don't run sync NSTextInputClient tests where we don't implement these calls.
3092
3093         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3094         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
3095         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
3096         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
3097         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
3098         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
3099         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
3100
3101 2014-04-18  Philippe Normand  <pnormand@igalia.com>
3102
3103         Remove NETWORK_INFO support
3104         https://bugs.webkit.org/show_bug.cgi?id=131841
3105
3106         Reviewed by Gyuyoung Kim.
3107
3108         * Scripts/webkitperl/FeatureList.pm:
3109
3110 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
3111
3112         [GTK] YouCompleteMe doesn't work for cmake build system.
3113         https://bugs.webkit.org/show_bug.cgi?id=131591
3114
3115         Reviewed by Martin Robinson.
3116
3117         Add cmake build system support for YouCompleteMe. It should work regardless of
3118         using make or ninja. In addition, autotools related code is removed since it's
3119         not used anymore in WebKit.
3120
3121         * Scripts/webkitdirs.pm:
3122         (generateBuildSystemFromCMakeProject):
3123         * gtk/ycm_extra_conf.py:
3124         (transform_relative_paths_to_absolute_paths):
3125         (FlagsForFile):
3126
3127 2014-04-17  Anders Carlsson  <andersca@apple.com>
3128
3129         Fix build.
3130
3131         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3132         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3133         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3134
3135 2014-04-17  Anders Carlsson  <andersca@apple.com>
3136
3137         Remove unused API enums
3138         https://bugs.webkit.org/show_bug.cgi?id=131836
3139
3140         Reviewed by Tim Horton.
3141
3142         * MiniBrowser/mac/WK2BrowserWindowController.m:
3143         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3144
3145 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
3146
3147         [Win] A few final cleanups to the DataObject classes.
3148         https://bugs.webkit.org/show_bug.cgi?id=131784
3149
3150         Reviewed by Anders Carlsson.
3151
3152         * DumpRenderTree/win/DRTDataObject.cpp:
3153         (DRTDataObject::clearData): Use 'last()' method.
3154         * DumpRenderTree/win/UIDelegate.cpp:
3155         (DRTUndoStack::pop): Use 'takeLast()' method.
3156
3157 2014-04-17  Andres Gomez  <agomez@igalia.com>
3158
3159         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
3160         https://bugs.webkit.org/show_bug.cgi?id=131365
3161
3162         Reviewed by Brent Fulgham.
3163
3164         The cygwin installer is now downloading the wanted versions for
3165         the local installation given to the setup wizard.
3166
3167         * CygwinDownloader/cygwin-downloader.py:
3168         * CygwinDownloader/cygwin-downloader.zip:
3169
3170 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
3171
3172         [GTK] Make run-webkit-tests always use WKTR
3173         https://bugs.webkit.org/show_bug.cgi?id=131737
3174
3175         Reviewed by Darin Adler.
3176
3177         Now that the GTK+ port only has support for WebKit2, instruct
3178         run-webkit-tests to always use WKTR. This avoids needing to pass
3179         flag "-2" every time.
3180
3181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
3182         (_set_up_derived_options): Always set webkit_test_runner when
3183         the platform is GTK+.
3184
3185 2014-04-17  Brendan Long  <b.long@cablelabs.com>
3186
3187         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
3188         https://bugs.webkit.org/show_bug.cgi?id=131760
3189
3190         Reviewed by Philippe Normand.
3191
3192         * gtk/install-dependencies: Install ninja-build when it's available.
3193
3194 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
3195
3196         [Win] run-javascriptcore-tests fails to run.
3197         https://bugs.webkit.org/show_bug.cgi?id=131761
3198
3199         Reviewed by Brent Fulgham.
3200
3201         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
3202
3203 2014-04-16  Andres Gomez  <agomez@igalia.com>
3204
3205         [Win] Pass default parameters to cygwin setup wizard
3206         https://bugs.webkit.org/show_bug.cgi?id=131361
3207
3208         Reviewed by Brent Fulgham.
3209
3210         Added some parameters to the cygwin setup wizard so the user
3211         doesn't really have to do any interaction.
3212
3213         * CygwinDownloader/cygwin-downloader.py:
3214         * CygwinDownloader/cygwin-downloader.zip:
3215
3216 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
3217
3218         [Win] Eliminate use of deleteAllValues in Windows Files
3219         https://bugs.webkit.org/show_bug.cgi?id=131631
3220
3221         Reviewed by Darin Adler.
3222
3223         Switch to std::unique_ptr for memory lifetime. Get rid of
3224         deleteAllValues now that it is no longer needed. Use ranged
3225         for loops where possible.
3226
3227         * DumpRenderTree/win/DRTDataObject.cpp:
3228         (WCEnumFormatEtc::WCEnumFormatEtc):
3229         (DRTDataObject::~DRTDataObject):
3230         (DRTDataObject::GetData):
3231         (DRTDataObject::QueryGetData):
3232         (DRTDataObject::SetData):
3233         (DRTDataObject::clearData):
3234         * DumpRenderTree/win/DRTDataObject.h:
3235         * DumpRenderTree/win/UIDelegate.cpp:
3236         (DRTUndoObject::DRTUndoObject):
3237         (DRTUndoObject::~DRTUndoObject):
3238         (DRTUndoStack::~DRTUndoStack):
3239         (DRTUndoStack::clear):
3240         (DRTUndoStack::pop):
3241         (DRTUndoManager::DRTUndoManager):
3242         (DRTUndoManager::redo):
3243         (DRTUndoManager::undo):
3244         (UIDelegate::UIDelegate):
3245         (UIDelegate::resetUndoManager):
3246         * DumpRenderTree/win/UIDelegate.h:
3247
3248 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3249
3250         [GTK] Unreviewed GTK gardening.
3251
3252         Update list of skipped unit tests:
3253
3254           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
3255
3256           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
3257           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
3258
3259         * Scripts/run-gtk-tests:
3260         (TestRunner):
3261
3262 2014-04-16  Tim Horton  <timothy_horton@apple.com>
3263
3264         check-webkit-style doesn't check code style in .mm or .m files
3265         https://bugs.webkit.org/show_bug.cgi?id=131708
3266
3267         Reviewed by Darin Adler.
3268
3269         * Scripts/webkitpy/style/checker.py:
3270         * Scripts/webkitpy/style/checker_unittest.py:
3271         (CheckerDispatcherDispatchTest.test_cpp_paths):
3272         (CheckerDispatcherDispatchTest.test_text_paths):
3273         Check .mm and .m files as C++.
3274
3275         * Scripts/webkitpy/style/checkers/cpp.py:
3276         (check_spacing):
3277         Add an override for our ordinary "missing spaces around =" for @synthesize,
3278         which should look like "@synthesize propertyName=_varName;"
3279
3280         Add an override for "missing space before {" for blocks' "^{".
3281
3282         Don't follow the "extra space before [" rule for Objective-C, because
3283         it breaks this rule in a multitude of ways because of method calls.
3284
3285         (check_braces):
3286         Don't complain about { not being on the end of the previous line if
3287         the previous line starts with "- (" or "+ (", which would indicate a
3288         Objective-C method definition.
3289
3290 2014-04-16  Darin Adler  <darin@apple.com>
3291
3292         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
3293         https://bugs.webkit.org/show_bug.cgi?id=131735
3294
3295         Reviewed by Alexey Proskuryakov.
3296
3297         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
3298         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
3299         is on the right. This can be confusing since our JavaScript test framework does it the opposite
3300         way, but gtest works better this way.
3301
3302 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
3303
3304         [EFL] Fix problems with the pixel dump.
3305         https://bugs.webkit.org/show_bug.cgi?id=131265
3306
3307         Reviewed by Gyuyoung Kim.
3308
3309         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
3310         However pixel dump codes still call deprecated functions like ewk_view_paint(),
3311         which causes that nothing is drawn.
3312
3313         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
3314         One of new functions is AcceleratedCompositingContext::extractImageData(),
3315         which replaces deprecated function calls. Besides the extractImageData() is invoked by
3316         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
3317
3318         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3319         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
3320
3321 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
3322
3323         Update LLVM export scrpt to handle the build directory being different from the
3324         source directory.
3325
3326         Rubber stamped by Geoffrey Garen.
3327
3328         * Scripts/export-llvm-build:
3329
3330 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
3331
3332         Update the hyperlink to waterfall views of perf bots on build.webkit.org
3333         https://bugs.webkit.org/show_bug.cgi?id=131695
3334
3335         Reviewed by Antti Koivisto.
3336
3337         Updated.
3338
3339         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3340
3341 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3342
3343         [GTK] Reduce the binary size by compressing the text based web inspector resources
3344         https://bugs.webkit.org/show_bug.cgi?id=121545
3345
3346         Reviewed by Gustavo Noronha Silva.
3347
3348         Compress text based files when compiling inspector resources. It
3349         reduces the binary size in 3MB.
3350
3351         * gtk/generate-inspector-gresource-manifest.py:
3352         (find_all_files_in_directory):
3353         (is_compressible):
3354
3355 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3356
3357         Remove Gtk WebKit1 tester.
3358
3359         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
3360         results over and over as fast as it could.
3361
3362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3363         (WebKitBuildbot):
3364
3365 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3366
3367         Wrong link for webkitpy tests results in dashboard popover
3368         https://bugs.webkit.org/show_bug.cgi?id=131664
3369
3370         Reviewed by Timothy Hatcher.
3371
3372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3373         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3374         Use a correct link.
3375
3376 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3377
3378         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3379
3380         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3381
3382         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3383         (CommitMessageForThisCommitTest):
3384
3385 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3386
3387         Fix commit-log-editor bug revealed by r165447
3388         https://bugs.webkit.org/show_bug.cgi?id=130676
3389
3390         Reviewed by Csaba Osztrogonác.
3391
3392         * Scripts/commit-log-editor:
3393         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3394         Add \n before the first block too, because the longest common prefix now ends with only one newline.
3395         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3396         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3397
3398 2014-04-13  Darin Adler  <darin@apple.com>
3399
3400         userVisibleString should not try to "encode" host names
3401         https://bugs.webkit.org/show_bug.cgi?id=131587
3402         rdar://problem/14686849
3403
3404         Reviewed by Alexey Proskuryakov.
3405
3406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3407
3408         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3409         Coverage is tiny at this point; we could add a lot more cases!
3410
3411 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
3412
3413         Use #include instead of #import
3414         https://bugs.webkit.org/show_bug.cgi?id=131604
3415
3416         Reviewed by Darin Adler.
3417
3418         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3419
3420         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3421
3422 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
3423
3424         Make slow-stress tests run faster by running fewer VM variants.
3425
3426         Rubber stamped by Geoffrey Garen.
3427
3428         * Scripts/run-javascriptcore-tests:
3429         * Scripts/run-jsc-stress-tests:
3430
3431 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
3432
3433         [CMake] Add missing WTF unit tests
3434         https://bugs.webkit.org/show_bug.cgi?id=131459
3435
3436         Reviewed by Martin Robinson.
3437
3438         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3439         that should be compiled into the TestWTF binary.
3440
3441 2014-04-10  Brendan Long  <b.long@cablelabs.com>
3442
3443         [Gtk] run-launcher doesn't work by default
3444         https://bugs.webkit.org/show_bug.cgi?id=131494
3445
3446         Reviewed by Philippe Normand.
3447
3448         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3449         * Scripts/webkitdirs.pm:
3450         (launcherName): Same.
3451         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3452         * gtk/common.py:
3453         (get_build_path.is_valid_build_directory): Same.
3454         * gtk/manifest.txt: Same.
3455
3456 2014-04-09  Commit Queue  <commit-queue@webkit.org>
3457
3458         Unreviewed, rolling out r167046.
3459         https://bugs.webkit.org/show_bug.cgi?id=131479
3460
3461         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3462         on #webkit).
3463
3464         Reverted changeset:
3465
3466         "Remove "System Font" from whitelisted DRT fonts and char
3467         width calculations"
3468         https://bugs.webkit.org/show_bug.cgi?id=131411
3469         http://trac.webkit.org/changeset/167046
3470
3471 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3472
3473         Remove "System Font" from whitelisted DRT fonts and char width calculations
3474         https://bugs.webkit.org/show_bug.cgi?id=131411
3475
3476         Reviewed by Tim Horton.
3477
3478         Covered by existing tests.
3479
3480         * DumpRenderTree/mac/DumpRenderTree.mm:
3481         (allowedFontFamilySet):
3482
3483 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3484
3485         systemHiddenFontFamilySet in DRT is unnecessary
3486         https://bugs.webkit.org/show_bug.cgi?id=131414
3487
3488         Reviewed by Tim Horton.
3489
3490         It doesn't seem to affect test results on my machine.
3491
3492         * DumpRenderTree/mac/DumpRenderTree.mm:
3493         (drt_NSFontManager_availableFonts):
3494         (systemHiddenFontFamilySet): Deleted.
3495
3496 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3497
3498         [Win] Unreviewed test fix: Don't double-release BSTR.
3499
3500         * DumpRenderTree/win/DumpRenderTree.cpp:
3501         (dump): Remove unneeded call to SysFreeString now that we are
3502         using _bstr_t for this variable.
3503
3504 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3505
3506         [Win] Various DumpRenderTree Fixes.
3507         https://bugs.webkit.org/show_bug.cgi?id=131446.
3508
3509         Reviewed by Tim Horton.
3510
3511         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3512         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3513         (AccessibilityUIElement::description): Ditto.
3514         (AccessibilityUIElement::helpText): Ditto.
3515         (AccessibilityUIElement::intValue): Ditto.
3516         (AccessibilityUIElement::isPressActionSupported): Ditto.
3517         (AccessibilityUIElement::accessibilityValue): Ditto.
3518         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3519         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3520         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3521         (DRTDesktopNotificationPresenter::Release): Ditto.
3522         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3523         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3524         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3525         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3526         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3527         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3528         * DumpRenderTree/win/DumpRenderTree.cpp:
3529         (dumpFrameScrollPosition): Ditto.
3530         (dumpFramesAsText): Ditto.
3531         (compareHistoryItems): Ditto.
3532         (dumpHistoryItem): Ditto.
3533         (dump): Ditto.
3534         (resetDefaultsToConsistentValues): Ditto.
3535         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3536         (runTest): Ditto.
3537         (createWebViewAndOffscreenWindow): Ditto.
3538         * DumpRenderTree/win/EditingDelegate.cpp:
3539         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3540         (EditingDelegate::AddRef): Ditto.
3541         (EditingDelegate::Release): Ditto.
3542         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3543         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3544         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3545         (EditingDelegate::shouldInsertNode): Ditto.
3546         (EditingDelegate::shouldInsertText): Ditto.
3547         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3548         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3549         (EditingDelegate::shouldApplyStyle): Ditto.
3550         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3551         (EditingDelegate::doPlatformCommand): Ditto.
3552         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3553         (EditingDelegate::webViewDidChange): Ditto.
3554         (EditingDelegate::webViewDidEndEditing): Ditto.
3555         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3556         (EditingDelegate::webViewDidChangeSelection): Ditto.
3557         (EditingDelegate::checkSpellingOfString): Ditto.
3558         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3559         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3560         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3561         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3562         (FrameLoadDelegate::AddRef): Ditto.
3563         (FrameLoadDelegate::Release): Ditto.
3564         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3565         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3566         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3567         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3568         (FrameLoadDelegate::didReceiveTitle): Ditto.
3569         (FrameLoadDelegate::didChangeIcons): Ditto.
3570         (delegatesWithDelayedWork): Ditto.
3571         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3572         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3573         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3574         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3575         (FrameLoadDelegate::willCloseFrame): Ditto.
3576         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3577         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3578         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3579         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3580         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3581         * DumpRenderTree/win/FrameLoadDelegate.h:
3582         * DumpRenderTree/win/HistoryDelegate.cpp:
3583         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3584         (HistoryDelegate::updateHistoryTitle): Ditto.
3585         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3586         * DumpRenderTree/win/PolicyDelegate.cpp:
3587         (dumpPath):
3588         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3589         (PolicyDelegate::AddRef): Ditto.
3590         (PolicyDelegate::Release): Ditto.
3591         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3592         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3593         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3594         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3595         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3596         (ResourceLoadDelegate::AddRef): Ditto.
3597         (ResourceLoadDelegate::Release): Ditto.
3598         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3599         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3600         (ResourceLoadDelegate::willSendRequest): Ditto.
3601         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3602         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3603         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3604         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3605         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3606         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3607         (TestRunner::setUserStyleSheetLocation): Ditto.
3608         (TestRunner::execCommand): Ditto.
3609         (TestRunner::overridePreference): Ditto.
3610         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3611         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3612         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3613         (TextInputController::insertText): Ditto.
3614         * DumpRenderTree/win/UIDelegate.cpp:
3615         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3616         (UIDelegate::AddRef): Ditto.
3617         (UIDelegate::Release): Ditto.
3618         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3619         (UIDelegate::trackCustomPopupMenu): Ditto.
3620         (UIDelegate::registerUndoWithTarget): Ditto.
3621         (UIDelegate::removeAllActionsWithTarget): Ditto.
3622         (UIDelegate::setActionTitle): Ditto.
3623         (UIDelegate::undo): Ditto.
3624         (UIDelegate::redo): Ditto.
3625         (UIDelegate::canUndo): Ditto.
3626         (UIDelegate::canRedo): Ditto.
3627         (UIDelegate::printFrame): Ditto.
3628         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3629         (UIDelegate::webViewHeaderHeight): Ditto.
3630         (UIDelegate::webViewFooterHeight): Ditto.
3631         (UIDelegate::drawHeaderInRect): Ditto.
3632         (UIDelegate::drawFooterInRect): Ditto.
3633         (UIDelegate::webViewPrintingMarginRect): Ditto.
3634         (UIDelegate::canRunModal): Ditto.
3635         (UIDelegate::createModalDialog): Ditto.
3636         (UIDelegate::runModal): Ditto.
3637         (UIDelegate::isMenuBarVisible): Ditto.
3638         (UIDelegate::setMenuBarVisible): Ditto.
3639         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3640         (UIDelegate::paintCustomScrollbar): Ditto.
3641         (UIDelegate::paintCustomScrollCorner): Ditto.
3642         (UIDelegate::setFrame): Ditto.
3643         (UIDelegate::webViewFrame): Ditto.
3644         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3645         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3646         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3647         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3648         (UIDelegate::webViewAddMessageToConsole): Ditto.
3649         (UIDelegate::doDragDrop): Ditto.
3650         (UIDelegate::webViewGetDlgCode): Ditto.
3651         (UIDelegate::createWebViewWithRequest): Ditto.
3652         (UIDelegate::webViewClose): Ditto.
3653         (UIDelegate::webViewFocus): Ditto.
3654         (UIDelegate::webViewUnfocus): Ditto.