Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
4         https://bugs.webkit.org/show_bug.cgi?id=122183
5
6         Reviewed by Timothy Hatcher.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
9         (BuildbotIteration.prototype.update):
10
11 2013-10-01  Timothy Hatcher  <timothy@apple.com>
12
13         Tweaks to the Buildbot Dashboard
14
15         https://bugs.webkit.org/show_bug.cgi?id=122169
16
17         Reviewed by Alexey Proskuryakov.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
20         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
21         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
22         (BuildbotQueueView.prototype.revisionLinksForIteration):
23         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
24         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
25         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
28         (WebKitBuildbot.prototype.buildLogURLForIteration):
29         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
30
31 2013-10-01  Commit Queue  <commit-queue@webkit.org>
32
33         Unreviewed, rolling out r156725.
34         http://trac.webkit.org/changeset/156725
35         https://bugs.webkit.org/show_bug.cgi?id=122176
36
37         broke all the mismatch tests again (Requested by thorton on
38         #webkit).
39
40         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
41         (WTR::PlatformWebView::PlatformWebView):
42
43 2013-10-01  Alex Christensen  <achristensen@webkit.org>
44
45         Implemented createWebViewWithRequest in WinLauncher.
46         https://bugs.webkit.org/show_bug.cgi?id=122069
47
48         Reviewed by Brent Fulgham.
49
50         * WinLauncher/PrintWebUIDelegate.cpp:
51         (PrintWebUIDelegate::createWebViewWithRequest): Added.
52         * WinLauncher/PrintWebUIDelegate.h:
53         Removed createWebViewWithRequest stub.
54
55 2013-10-01  Tim Horton  <timothy_horton@apple.com>
56
57         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
58         https://bugs.webkit.org/show_bug.cgi?id=122006
59         <rdar://problem/15095197>
60
61         Reviewed by Dean Jackson.
62
63         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
64         (WTR::PlatformWebView::PlatformWebView):
65         Layer-back the root view in WebKitTestRunner's window, to work around a bug
66         where the window server snapshot API returns blank snapshots.
67
68         Re-landing after r156724, this should not break everything now.
69
70 2013-10-01  Tim Horton  <timothy_horton@apple.com>
71
72         [mac] 1x emulation on Retina hardware shouldn't use SPI
73         https://bugs.webkit.org/show_bug.cgi?id=122152
74         <rdar://problem/15119384>
75
76         Reviewed by Anders Carlsson.
77
78         * DumpRenderTree/mac/DumpRenderTree.mm:
79         (createWebViewAndOffscreenWindow):
80         (main):
81         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
82         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
83         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
84         (WTR::PlatformWebView::PlatformWebView):
85         * WebKitTestRunner/mac/main.mm:
86         (main):
87         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
88
89 2013-09-30  Sam Weinig  <sam@webkit.org>
90
91         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
92         https://bugs.webkit.org/show_bug.cgi?id=116474
93
94         Reviewed by Ryosuke Niwa.
95
96         * Scripts/webkitpy/style/checkers/cpp.py:
97         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
98
99 2013-09-30  Sam Weinig  <sam@webkit.org>
100
101         Remove support for DOMFileSystem
102         https://bugs.webkit.org/show_bug.cgi?id=122137
103
104         Reviewed by Anders Carlsson.
105
106         * Scripts/webkitperl/FeatureList.pm:
107         * Scripts/webkitpy/style/checkers/cpp.py:
108         (check_spacing):
109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
110         (CppStyleTest.test_spacing_for_binary_ops):
111         * qmake/mkspecs/features/features.pri:
112
113 2013-09-30  Mark Rowe  <mrowe@apple.com>
114
115         More build fixage for builds with SDKs.
116
117         * WebKitTestRunner/Configurations/Base.xcconfig:
118         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
119
120 2013-09-30  Timothy Hatcher  <timothy@apple.com>
121
122         Add initial version of a new Buildbot dashboard view.
123
124         https://bugs.webkit.org/show_bug.cgi?id=122131
125
126         Reviewed by Alexey Proskuryakov.
127
128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
137         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
160
161 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
162
163         Remove the code guarded by STYLE_SCOPED
164         https://bugs.webkit.org/show_bug.cgi?id=122123
165
166         Reviewed by Anders Carlsson.
167
168         * DumpRenderTree/gtk/DumpRenderTree.cpp:
169         (resetDefaultsToConsistentValues):
170         * Scripts/webkitperl/FeatureList.pm:
171         * qmake/mkspecs/features/features.pri:
172
173 2013-09-30  Mark Rowe  <mrowe@apple.com>
174
175         Fix the build when building against an SDK.
176
177         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
178         the compiler command lines. It can't know to do this for the system framework search paths
179         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
180
181         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
182         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
183
184 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
185
186         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
187
188         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
189         it to be double-freed.
190
191         * WinLauncher/WinLauncher.cpp:
192         (EditProc): Be explicit about type passed to loadURL.
193         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
194         that reallocating the BSTR is done with the knowledge of the smart pointer.
195
196 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
197
198         [Qt] Fix force_static_libs_as_shared in WebKit2
199         https://bugs.webkit.org/show_bug.cgi?id=121961
200
201         Reviewed by Csaba Osztrogonác.
202
203         Get rid of the unused WebKit2QML library
204
205         * qmake/mkspecs/features/webkit_modules.prf:
206         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
207
208 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
209
210         [EFL] Fix incorrect click counting in EventSenderProxy
211         https://bugs.webkit.org/show_bug.cgi?id=122098
212
213         Reviewed by Gyuyoung Kim.
214
215         Previously used two types of recording time, which conflicted with each other.
216
217         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
218         (WTR::EventSenderProxy::mouseUp):
219
220 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
221
222         [webkitpy] Make the Xvfb screen depth overridable
223         https://bugs.webkit.org/show_bug.cgi?id=122089
224
225         Reviewed by Gyuyoung Kim.
226
227         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
228         was set. The default value that's used if the variable wasn't set is 24.
229
230         * Scripts/webkitpy/port/xvfbdriver.py:
231         (XvfbDriver._xvfb_screen_depth):
232         (XvfbDriver._start):
233         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
234         (XvfbDriverTest.make_driver):
235         (XvfbDriverTest.test_start_no_pixel_tests):
236         (XvfbDriverTest.test_start_pixel_tests):
237         (XvfbDriverTest.test_start_arbitrary_worker_number):
238         (XvfbDriverTest.test_next_free_display):
239         (XvfbDriverTest.test_start_next_worker):
240
241 2013-09-29  Mark Rowe  <mrowe@apple.com>
242
243         Fix the Lion build.
244
245         Ensure that C++ and Objective-C++ files build with the right compiler flags.
246
247         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
248         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
249
250 2013-09-28  Mark Rowe  <mrowe@apple.com>
251
252         Fix some failures with newer versions of clang.
253
254         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
255         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
256         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
257         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
258         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
259
260         Reviewed by Dan Bernstein.
261
262         * DumpRenderTree/mac/Configurations/Base.xcconfig:
263         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
264         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
265         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
266         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
267         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
268         * WebKitTestRunner/Configurations/Base.xcconfig:
269         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
270         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
271         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
272         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
273
274 2013-09-27  Commit Queue  <commit-queue@webkit.org>
275
276         Unreviewed, rolling out r156569.
277         http://trac.webkit.org/changeset/156569
278         https://bugs.webkit.org/show_bug.cgi?id=122035
279
280         broke a lot of mismatch tests (Requested by thorton on
281         #webkit).
282
283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
284         (WTR::PlatformWebView::PlatformWebView):
285
286 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
287
288         Don't retry failures on Apple MountainLion Release WK1 tester
289         https://bugs.webkit.org/show_bug.cgi?id=122026
290
291         Reviewed by Mark Rowe.
292
293         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
294         on this bot.
295
296 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
297
298         Don't hardcode builder specific configuration in buildbot master.cfg
299         https://bugs.webkit.org/show_bug.cgi?id=122023
300
301         Reviewed by Mark Rowe.
302
303         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
304         property to Qt Mountain Lion Release, making it run pixel tests.
305
306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
307         (RunWebKitTests.start): Use additionalArguments.
308         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
309
310 2013-09-27  Tim Horton  <timothy_horton@apple.com>
311
312         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
313         https://bugs.webkit.org/show_bug.cgi?id=122006
314         <rdar://problem/15095197>
315
316         Reviewed by Dean Jackson.
317
318         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
319         (WTR::PlatformWebView::PlatformWebView):
320         Layer-back the root view in WebKitTestRunner's window, to work around a bug
321         where the window server snapshot API returns blank snapshots.
322
323 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
324
325         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
326         https://bugs.webkit.org/show_bug.cgi?id=106924
327
328         Reviewed by Chris Fleizach.
329
330         Consider headings levels as values to be returned in intValue()
331         both in DRT and WKTR, so we can share more tests with other ports.
332
333         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
334         (AccessibilityUIElement::intValue): Consider headings too.
335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
336         (WTR::AccessibilityUIElement::intValue): Ditto.
337
338 2013-09-26  Darin Adler  <darin@apple.com>
339
340         rename KURL to URL
341         https://bugs.webkit.org/show_bug.cgi?id=16214
342
343         Reviewed by Andreas Kling.
344
345         * many files: Renamed, using script.
346
347 2013-09-27  Darin Adler  <darin@apple.com>
348
349         Fix Python scripts test failures.
350
351         * Scripts/webkitpy/style/checkers/cpp.py:
352         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
353         now, not by the checker itself.
354
355 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
356
357         [GTK][WK2] Logging of accessibility events is not disabled between tests
358         https://bugs.webkit.org/show_bug.cgi?id=121957
359
360         Reviewed by Mario Sanchez Prada.
361
362         Fixed an issue in AccessibilityNotificationHandler where the destructor
363         was not disconnecting accessibility event callbacks if logging was on.
364         The decision of disconnecting events can solely rely on the existence of
365         notification handlers because logging uses the global notification
366         handler.
367
368         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
369         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
370         disconnection when logging is on.
371
372 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
373
374         Add general CMakeLists.txt for DRT
375         https://bugs.webkit.org/show_bug.cgi?id=119268
376
377         Reviewed by Gyuyoung Kim.
378
379         The new file allows better sharing between ports.
380
381         * CMakeLists.txt:
382         * DumpRenderTree/CMakeLists.txt: Added.
383         * DumpRenderTree/PlatformEfl.cmake: Added.
384         * DumpRenderTree/efl/CMakeLists.txt: Removed.
385
386 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
387
388         [Qt] Fix force_static_libs_as_shared in WebKit2
389         https://bugs.webkit.org/show_bug.cgi?id=121961
390
391         Reviewed by Csaba Osztrogonác.
392
393         Reenable force_static_libs_as_shared when building WebKit2.
394
395         * qmake/mkspecs/features/default_post.prf:
396
397 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
398
399         [Qt] Mock implementations of positioning and orientation not used
400         https://bugs.webkit.org/show_bug.cgi?id=121956
401
402         Reviewed by Csaba Osztrogonác.
403
404         Move production_build checks to sanitizeFeatures where its value is actually known.
405
406         * qmake/mkspecs/features/features.prf:
407         * qmake/mkspecs/features/features.pri:
408
409 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
410
411         [ATK] Normalize checks in entry points for DRT and WKTR
412         https://bugs.webkit.org/show_bug.cgi?id=121959
413
414         Reviewed by Chris Fleizach.
415
416         Always check if we have a proper instance of AtkObject,
417         implementing the interfaces that we might need for each case, at
418         the entry point of every method of AccessibilityUIElement for ATK,
419         and do those checks in an uniform way across DRT and WKTR, to
420         avoid confusion and issues when modifying these files in the future.
421
422         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
423         (AccessibilityUIElement::getChildren): Use normalized checks.
424         (AccessibilityUIElement::getChildrenWithRange): Ditto.
425         (AccessibilityUIElement::rowCount): Ditto.
426         (AccessibilityUIElement::columnCount): Ditto.
427         (AccessibilityUIElement::childrenCount): Ditto.
428         (AccessibilityUIElement::elementAtPoint): Ditto.
429         (AccessibilityUIElement::getChildAtIndex): Ditto.
430         (AccessibilityUIElement::allAttributes): Ditto.
431         (AccessibilityUIElement::titleUIElement): Ditto.
432         (AccessibilityUIElement::parentElement): Ditto.
433         (AccessibilityUIElement::attributesOfChildren): Ditto.
434         (AccessibilityUIElement::role): Ditto.
435         (AccessibilityUIElement::title): Ditto.
436         (AccessibilityUIElement::description): Ditto.
437         (AccessibilityUIElement::stringValue): Ditto.
438         (AccessibilityUIElement::language): Ditto.
439         (AccessibilityUIElement::x): Ditto.
440         (AccessibilityUIElement::y): Ditto.
441         (AccessibilityUIElement::width): Ditto.
442         (AccessibilityUIElement::height): Ditto.
443         (AccessibilityUIElement::orientation): Ditto.
444         (AccessibilityUIElement::intValue): Ditto.
445         (AccessibilityUIElement::minValue): Ditto.
446         (AccessibilityUIElement::maxValue): Ditto.
447         (indexRangeInTable): Ditto.
448         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
449         (AccessibilityUIElement::stringAttributeValue): Ditto.
450         (alterCurrentValue): Ditto.
451         (AccessibilityUIElement::press): Ditto.
452         (AccessibilityUIElement::documentEncoding): Ditto.
453         (AccessibilityUIElement::documentURI): Ditto.
454         (AccessibilityUIElement::hasPopup): Ditto.
455
456         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
457         (WTR::indexRangeInTable): Use normalized checks.
458         (WTR::alterCurrentValue): Ditto.
459         (WTR::AccessibilityUIElement::getChildren): Ditto.
460         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
461         (WTR::AccessibilityUIElement::childrenCount): Ditto.
462         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
463         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
464         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
465         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
466         (WTR::AccessibilityUIElement::parentElement): Ditto.
467         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
468         (WTR::AccessibilityUIElement::allAttributes): Ditto.
469         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
470         (WTR::AccessibilityUIElement::role): Ditto.
471         (WTR::AccessibilityUIElement::title): Ditto.
472         (WTR::AccessibilityUIElement::description): Ditto.
473         (WTR::AccessibilityUIElement::orientation): Ditto.
474         (WTR::AccessibilityUIElement::stringValue): Ditto.
475         (WTR::AccessibilityUIElement::language): Ditto.
476         (WTR::AccessibilityUIElement::x): Ditto.
477         (WTR::AccessibilityUIElement::y): Ditto.
478         (WTR::AccessibilityUIElement::width): Ditto.
479         (WTR::AccessibilityUIElement::height): Ditto.
480         (WTR::AccessibilityUIElement::intValue): Ditto.
481         (WTR::AccessibilityUIElement::minValue): Ditto.
482         (WTR::AccessibilityUIElement::maxValue): Ditto.
483         (WTR::AccessibilityUIElement::rowCount): Ditto.
484         (WTR::AccessibilityUIElement::columnCount): Ditto.
485         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
486         (WTR::AccessibilityUIElement::press): Ditto.
487         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
488         (WTR::AccessibilityUIElement::documentURI): Ditto.
489         (WTR::AccessibilityUIElement::hasPopup): Ditto.
490
491 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
492
493         [ATK] accessibility/aria-sort.html is failing after r156409
494         https://bugs.webkit.org/show_bug.cgi?id=121947
495
496         Reviewed by Chris Fleizach.
497
498         Implement AccessibilityUIElement::isSupported for the ATK
499         platforms, just by checking whether we have an associated object
500         attribute exposed for the wrapper object matching the required
501         attribute in the layout test (e.g "AXSortDirection" -> "sort").
502
503         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
504         (AccessibilityUIElement::isAttributeSupported): Implemented.
505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
506         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
507
508 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
509
510         [MediaStream] make MediaStream testable
511         https://bugs.webkit.org/show_bug.cgi?id=121967
512
513         Reviewed by Dean Jackson.
514
515         * DumpRenderTree/mac/UIDelegate.mm:
516         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
517             user media request policy delegate.
518
519 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
520
521         build-webkit --inspector-frontend should copy WebInspectorUI files
522         https://bugs.webkit.org/show_bug.cgi?id=117851
523
524         Reviewed by Joseph Pecoraro.
525
526         Change the --inspector-frontend build option to additionally build/copy 
527         WebInspectorUI by setting it as the only project that needs to be built.
528
529         * Scripts/build-webkit:
530
531 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
532
533         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
534         https://bugs.webkit.org/show_bug.cgi?id=121951
535
536         Reviewed by Carlos Garcia Campos.
537
538         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
539         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
540         500 layout tests that trigger accelerated compositing to be used.
541
542         * Scripts/webkitpy/port/xvfbdriver.py:
543         (XvfbDriver._start):
544         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
545         (XvfbDriverTest.test_start_no_pixel_tests):
546         (XvfbDriverTest.test_start_pixel_tests):
547         (XvfbDriverTest.test_start_arbitrary_worker_number):
548         (XvfbDriverTest.test_next_free_display):
549         (XvfbDriverTest.test_start_next_worker):
550
551 2013-09-26  Tim Horton  <timothy_horton@apple.com>
552
553         Tiled drawing should not imply threaded scrolling
554         https://bugs.webkit.org/show_bug.cgi?id=121874
555         <rdar://problem/15071494>
556
557         Reviewed by Sam Weinig.
558
559         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
560         (WTR::PlatformWebView::PlatformWebView):
561         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
562
563 2013-09-26  Commit Queue  <commit-queue@webkit.org>
564
565         Unreviewed, rolling out r156457.
566         http://trac.webkit.org/changeset/156457
567         https://bugs.webkit.org/show_bug.cgi?id=121960
568
569         Broke webkitpy tests. (Requested by kling on #webkit).
570
571         * Scripts/webkitpy/port/xvfbdriver.py:
572         (XvfbDriver._start):
573
574 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
575
576         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
577         https://bugs.webkit.org/show_bug.cgi?id=121951
578
579         Reviewed by Carlos Garcia Campos.
580
581         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
582         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
583         500 layout tests that trigger accelerated compositing to be used.
584
585         * Scripts/webkitpy/port/xvfbdriver.py:
586         (XvfbDriver._start):
587
588 2013-09-25  Alex Christensen  <achristensen@webkit.org>
589
590         Removed check for Apple Application Support directory in WinCairo port.
591         https://bugs.webkit.org/show_bug.cgi?id=121869
592
593         Reviewed by Brent Fulgham.
594
595         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
596         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
597         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
598         Use DLLLauncherWinCairo.props for WinCairo ports.
599         * win/DLLLauncher/DLLLauncherMain.cpp:
600         (wWinMain):
601         Don't call modifyPath to check for AAS in the WinCairo port.
602         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
603
604 2013-09-25  Alex Christensen  <achristensen@webkit.org>
605
606         Enabled AssembleBuildLogs on WinCairo port.
607         https://bugs.webkit.org/show_bug.cgi?id=121923
608
609         Reviewed by Brent Fulgham.
610
611         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
612         Fixed reference to README, added WinCairo configurations.
613         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
614         Fixed reference to README.
615         * win/AssembleBuildLogs/AssembleLogs.cmd:
616         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
617         * win/AssembleBuildLogs/README: Fixed spelling.
618
619 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
620
621         [WIN] Fix MSVC C4146 compiler warning
622         https://bugs.webkit.org/show_bug.cgi?id=121838
623
624         Reviewed by Brent Fulgham.
625
626         Fix some variables from unsinged to int to fix the compiler warning
627         "unary minus operator applied to unsigned type, result still unsigned".
628
629         * DumpRenderTree/WorkQueueItem.h:
630         (BackItem::BackItem):
631         (ForwardItem::ForwardItem):
632         * DumpRenderTree/win/DumpRenderTree.cpp:
633         (createWebViewAndOffscreenWindow):
634
635 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
636
637         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
638         https://bugs.webkit.org/show_bug.cgi?id=121256
639
640         Reviewed by Martin Robinson.
641
642         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
643         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
644
645         * BuildSlaveSupport/build.webkit.org-config/config.json:
646
647 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
648
649         Add style checker for CMake lists
650         https://bugs.webkit.org/show_bug.cgi?id=121764
651
652         Reviewed by Ryosuke Niwa.
653
654         Add an additional check to make sure that list of files are sorted.
655         Exclude lists of include directories for now, since the order
656         can be importent for compilation of some files.
657
658         * Scripts/webkitpy/style/checkers/cmake.py:
659         (CMakeChecker.check):
660         (CMakeChecker._check_indent):
661         (CMakeChecker):
662         (CMakeChecker._check_list_order):
663         (CMakeChecker._list_item_path):
664         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
665         (CMakeCheckerTest.test_check):
666
667 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
668
669         CMakeChecker takes unusually long time to run
670         https://bugs.webkit.org/show_bug.cgi?id=105662
671
672         Reviewed by Ryosuke Niwa.
673
674         Move the caching mechanism for regular expression of the C++ checker into
675         a common file and use it for the CMake and ChangeLog checkers too.
676
677         * Scripts/webkitpy/style/checkers/changelog.py:
678         (ChangeLogChecker.check_entry):
679         * Scripts/webkitpy/style/checkers/cmake.py:
680         (CMakeChecker._process_line):
681         (CMakeChecker._check_no_space_cmds):
682         (CMakeChecker._check_one_space_cmds):
683         (CMakeChecker._check_non_lowercase_cmd):
684         * Scripts/webkitpy/style/checkers/common.py:
685         (match):
686         (search):
687         (searchIgnorecase):
688         (sub):
689         (subn):
690         * Scripts/webkitpy/style/checkers/cpp.py:
691
692 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
693
694         [Qt] Fix build with Qt 5.2 QtPosition module
695         https://bugs.webkit.org/show_bug.cgi?id=121089
696
697         Reviewed by Simon Hausmann.
698
699         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
700         that might depend on them.
701
702         * qmake/mkspecs/features/default_pre.prf:
703         * qmake/mkspecs/features/features.prf:
704
705 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
706
707         [ATK] Fix style issues in AccessibilityUIElementAtk
708         https://bugs.webkit.org/show_bug.cgi?id=121898
709
710         Reviewed by Chris Fleizach.
711
712         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
713         instead of { 0, { { 0 } } } to initialize a GValue.
714
715         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
716         (AccessibilityUIElement::clickPointX): Remove suffix.
717         (AccessibilityUIElement::clickPointY): Ditto.
718         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
719         (AccessibilityUIElement::minValue): Ditto.
720         (AccessibilityUIElement::maxValue): Ditto.
721         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
722         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
723         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
724         (WTR::AccessibilityUIElement::x): Ditto.
725         (WTR::AccessibilityUIElement::y): Ditto.
726         (WTR::AccessibilityUIElement::width): Ditto.
727         (WTR::AccessibilityUIElement::height): Ditto.
728         (WTR::AccessibilityUIElement::clickPointX): Ditto.
729         (WTR::AccessibilityUIElement::clickPointY): Ditto.
730         (WTR::AccessibilityUIElement::intValue): Ditto.
731         (WTR::AccessibilityUIElement::minValue): Ditto.
732         (WTR::AccessibilityUIElement::maxValue): Ditto.
733
734 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
735
736         [EFL] accessibility/loading-iframe-sends-notification.html is failing
737         https://bugs.webkit.org/show_bug.cgi?id=112003
738
739         Reviewed by Mario Sanchez Prada.
740
741         Enabled addNotificationListener and removeNotificationListener for EFL port.
742
743         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
744         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
745         (WTR::AccessibilityController::removeNotificationListener):
746
747 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
748
749         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
750         https://bugs.webkit.org/show_bug.cgi?id=121844
751
752         Reviewed by Mark Hahnenberg.
753
754         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
755
756 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
757
758         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
759         https://bugs.webkit.org/show_bug.cgi?id=121854
760
761         Reviewed by Anders Carlsson.
762
763         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
764         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
765         settings in underlying frameworks.
766
767 2013-09-24  Mark Rowe  <mrowe@apple.com>
768
769         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
770
771         Reviewed by Dan Bernstein.
772
773         * DumpRenderTree/mac/Configurations/Base.xcconfig:
774         * MiniBrowser/Configurations/Base.xcconfig:
775         * TestWebKitAPI/Configurations/Base.xcconfig:
776         * WebKitLauncher/Configurations/Base.xcconfig:
777         * WebKitTestRunner/Configurations/Base.xcconfig:
778
779 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
780
781         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
782         https://bugs.webkit.org/show_bug.cgi?id=121674
783
784         Reviewed by Mario Sanchez Prada.
785
786         Implemented the global notification listener for
787         AccessibilityController. The signal is generated by
788         AXObjectCache::postPlatformNotification() and received by
789         axObjectEventListener(). axObjectEventListener will then invoke
790         JSObjectCallAsFunction() with the respective callback function.
791
792         There is no additional test for this patch since its implementation will
793         be tested by an accessibility layout test that is currently failing
794         (accessibility/loading-iframe-sends-notification.html).
795
796         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
797         stub implementations of addNotificationListener and
798         removeNotificationListener for the GTK port.
799         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
800         (WTR::AccessibilityController::addNotificationListener): Creates the
801         notification handler and sets the notification function callback.
802         (WTR::AccessibilityController::removeNotificationListener): Removes the
803         global handler.
804
805 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
806
807         [GTK] fast/images/exif-orientation-composited.html is failing
808         https://bugs.webkit.org/show_bug.cgi?id=119731
809
810         Reviewed by Carlos Garcia Campos.
811
812         Add handling respect image orientation property in DRT.
813
814         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
815         (TestRunner::overridePreference):
816
817 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
818
819         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
820         https://bugs.webkit.org/show_bug.cgi?id=121787
821
822         Reviewed by Gustavo Noronha Silva.
823
824         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
825         with the Wayland target enabled to version 3.10.0.
826
827 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
828
829         use NOMINMAX instead of #define min min
830         https://bugs.webkit.org/show_bug.cgi?id=73563
831
832         Reviewed by Brent Fulgham.
833
834         Use NOMINMAX instead of #define min/max as a cleaner
835         way of ensuring that Windows system header files don't
836         define min/max as macro in the first place.
837
838         * DumpRenderTree/DumpRenderTreePrefix.h:
839         * DumpRenderTree/cg/ImageDiffCG.cpp:
840         * DumpRenderTree/config.h:
841         * DumpRenderTree/win/ImageDiffCairo.cpp:
842         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
843         * WebKitTestRunner/config.h:
844
845 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
846
847         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
848         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
849
850         Reviewed by Alexey Proskuryakov.
851
852         Previously, initalizing a WebPreference would change the cache model
853         to WebCacheModelDocumentBrowser. That behavior was due to a stale
854         preference file on disk.
855
856         This patch fixes the tests by resetting the default, and using the proper
857         default values after initializing WebPreference.
858
859         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
860         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
861         to the previous runs.
862
863         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
864         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
865         cache model to the one required.
866
867         * TestWebKitAPI/ios/mainIOS.mm:
868         (main): Reset the preferences before testing.
869         * TestWebKitAPI/mac/mainMac.mm:
870         (main): Ditto.
871
872 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
873
874         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
875         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
876
877         Reviewed by Alexey Proskuryakov.
878
879         Previously, initalizing a WebPreference would change the cache model
880         to WebCacheModelDocumentBrowser. That behavior was due to a stale
881         preference file on disk.
882
883         This patch fixes the tests by resetting the default, and using the proper
884         default values after initializing WebPreference.
885
886         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
887         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
888         to the previous runs.
889
890         * TestWebKitAPI/ios/mainIOS.mm:
891         (main): Reset the preferences before testing.
892         * TestWebKitAPI/mac/mainMac.mm:
893         (main): Ditto.
894
895 2013-09-23  Anders Carlsson  <andersca@apple.com>
896
897         ListHashSet should work with move-only types
898         https://bugs.webkit.org/show_bug.cgi?id=121802
899
900         Reviewed by Andreas Kling.
901
902         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
903         (TestWebKitAPI::TEST):
904         Add a test for move-only types.
905
906 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
907
908         Added --64-bit option for Windows build.
909         https://bugs.webkit.org/show_bug.cgi?id=121799
910
911         Reviewed by Brent Fulgham.
912
913         * Scripts/webkitdirs.pm:
914         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
915         (isWin64): Added.
916         (determineIsWin64): Added.
917
918 2013-09-23  Anders Carlsson  <andersca@apple.com>
919
920         ListHashSet should use std::reverse_iterator for reverse iterators
921         https://bugs.webkit.org/show_bug.cgi?id=121795
922
923         Reviewed by Antti Koivisto.
924
925         Add test for reverse iterators.
926
927         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
928         (TestWebKitAPI::TEST):
929
930 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
931
932         [EFL] accessibility/aria-invalid is failing
933         https://bugs.webkit.org/show_bug.cgi?id=111986
934
935         Reviewed by Mario Sanchez Prada.
936
937         Adds possibility to retrieve JS context.
938         This is part of the implementation of AccessibilityUIElement::addNotificationListener
939         from 119883 and 120421.
940
941         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
942         (axObjectEventListener):
943         (addAccessibilityNotificationHandler):
944         (removeAccessibilityNotificationHandler):
945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
946         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
947         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
948
949 2013-09-20  Mark Rowe  <mrowe@apple.com>
950
951         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
952
953         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
954
955         Reviewed by David Kilzer.
956
957         * Scripts/webkitdirs.pm:
958         (checkRequiredSystemConfig):
959
960 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
961
962         [ATK] Do not expose aria-help in ATK based platforms
963         https://bugs.webkit.org/show_bug.cgi?id=121675
964
965         Reviewed by Chris Fleizach.
966
967         Remove the implementations for AccessibilityUIElement::helpText()
968         from DRT and WKTR for GTK and EFL, since they are based on the
969         AccessibilityObject::helpText() method and the 'aria-help'
970         attributes, which is wrong since they should not depend on that
971         but in ATK specific API (see also http://webkit.org/b/121684).
972
973         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
974         (AccessibilityUIElement::helpText): Added a new and empty
975         implementation, now that we are no longer using this in ATK.
976         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
977         as the only function provided here was helpText().
978         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
979         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
980         removed from the list of sources to compile.
981         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
982         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
983         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
984         based in DumpRenderTreeSupportGtk with an empty one.
985
986 2013-09-20  Dan Bernstein  <mitz@apple.com>
987
988         Make extract-localizable-strings available to WebCore clients
989         https://bugs.webkit.org/show_bug.cgi?id=121699
990
991         Reviewed by Darin Adler.
992
993         * Scripts/extract-localizable-strings: Copied to
994         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
995         executes the script from its new location. This is a temporary measure until certain code
996         that is external to WebKit is adapted to the new location.
997         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
998         from its new location.
999
1000 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
1001
1002         Nuke remaining VS2005 tools from the tree.
1003         https://bugs.webkit.org/show_bug.cgi?id=121691
1004
1005         Reviewed by Brent Fulgham.
1006
1007         * CLWrapper/CLWrapper.cpp: Removed.
1008         * CLWrapper/CLWrapper.sln: Removed.
1009         * CLWrapper/CLWrapper.vcproj: Removed.
1010         * MIDLWrapper/MIDLWrapper.cpp: Removed.
1011         * MIDLWrapper/MIDLWrapper.sln: Removed.
1012         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
1013         * Scripts/parallelcl: Removed.
1014         * vcbin/cl.exe: Removed.
1015         * vcbin/midl.exe: Removed.
1016
1017 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1018
1019         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
1020         https://bugs.webkit.org/show_bug.cgi?id=121294
1021
1022         Reviewed by Martin Robinson.
1023
1024         Provide a new patch to deal with the issue in the GTK+ module from
1025         the internal jhbuild environment. This issue has been reported
1026         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
1027
1028         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
1029         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
1030
1031 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
1032
1033         [ATK][WTR] accessibility/aria-invalid.html times out
1034         https://bugs.webkit.org/show_bug.cgi?id=121668
1035
1036         Reviewed by Mario Sanchez Prada.
1037
1038         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
1039         false in case of aria-invalid event with empty value.
1040
1041         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1042         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
1043         case of aria-invalid event with empty value.
1044
1045 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
1046
1047         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
1048         https://bugs.webkit.org/show_bug.cgi?id=120421
1049
1050         Reviewed by Mario Sanchez Prada.
1051
1052         Implemented the notification listener for AccessibilityUIElement for
1053         WebKitTestRunner. The signal is generated by
1054         AXObjectCache::postPlatformNotification() and received by
1055         axObjectEventListener(). axObjectEventListener() will then invoke
1056         JSObjectCallAsFunction() with the respective callback function. The
1057         notification handlers are stored in HashMap in
1058         AccessibilityNotificationHandlerAtk.cpp.
1059
1060         Moved ATK signal handling (printAccessibilityEvent and
1061         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
1062
1063         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
1064         include path.
1065         * WebKitTestRunner/GNUmakefile.am:
1066         Added AccessibilityNotificationHandlerAtk.cpp/h.
1067         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
1068         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
1069         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
1070         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
1071         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
1072         notification handler for GTK+ and EFL.
1073         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1074         Moved printAccessibilityEvent and axObjectEventListener to
1075         AccessibilityNotificationHandlerAtk.cpp.
1076         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
1077         IDs to AccessibilityNotificationHandlerAtk.cpp.
1078         (WTR::AccessibilityController::resetToConsistentState): Moved listener
1079         IDs to AccessibilityNotificationHandlerAtk.cpp.
1080         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
1081         (WTR::printAccessibilityEvent): Prints accessibility events. This
1082         function was moved from AccessibilityControllerAtk.cpp.
1083         (WTR::axObjectEventListener): Callback for signals. This function was
1084         moved from AccessibilityControllerAtk.cpp.
1085         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
1086         Initialize element and function callback.
1087         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
1088         Removes handler from HashMap and disconnects callbacks if necessary.
1089         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
1090         logging mode and connects callbacks.
1091         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1092         Sets the notification callback and connects callback to signals.
1093         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1094         Removes the notification callback from HashMap.
1095         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1096         Connects axObjectEventListener to ATK signals.
1097         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1098         Disconnects callback.
1099         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
1100         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
1101         of AccessibilityNotificationHandler.
1102         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
1103         element.
1104         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
1105         element.
1106         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
1107         Gets the notification callback.
1108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1109         (WTR::AccessibilityUIElement::addNotificationListener): Creates
1110         notification handler, set the platform element and the notification
1111         callback.
1112         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
1113         notification handler.
1114         * WebKitTestRunner/PlatformEfl.cmake:
1115         Added AccessibilityNotificationHandlerAtk.cpp.
1116
1117 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1118
1119         Update features.pri
1120         https://bugs.webkit.org/show_bug.cgi?id=121670
1121
1122         Reviewed by Jocelyn Turcotte.
1123
1124         Remove feature flags that no longer exists and new ones added to FeatureList.pm
1125
1126         * qmake/mkspecs/features/features.pri:
1127
1128 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
1129
1130         [GTK][WK2] accessibility/selection-states.html is failing
1131         https://bugs.webkit.org/show_bug.cgi?id=116972
1132
1133         Reviewed by Mario Sanchez Prada.
1134
1135         isSelectable() was not exposed in Accessibility.
1136
1137         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1138
1139 2013-09-19  Dan Bernstein  <mitz@apple.com>
1140
1141         Attempted build fix after r156114.
1142
1143         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
1144
1145 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
1146
1147         REGRESSION (r129451): run-safari --no-saved-state is broken
1148         https://bugs.webkit.org/show_bug.cgi?id=121566
1149
1150         Undo a last minute change that doesn't actually work.
1151
1152         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
1153         via command line, <rdar://problem/15032886>.
1154
1155 2013-09-19  Dan Bernstein  <mitz@apple.com>
1156
1157         Add a style guideline regarding spacing in range-based for loops
1158         https://bugs.webkit.org/show_bug.cgi?id=121620
1159
1160         Reviewed by Anders Carlsson.
1161
1162         * Scripts/webkitpy/style/checkers/cpp.py:
1163         (check_spacing): Added checking that there are spaces around the colon in a range-based for
1164         loop.
1165         (CppChecker): Added whitespace/colon to the categories set.
1166         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1167         (WebKitStyleTest.test_spacing): Added two tests for the new check.
1168
1169 2013-09-18  Sam Weinig  <sam@webkit.org>
1170
1171         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
1172         https://bugs.webkit.org/show_bug.cgi?id=121588
1173
1174         Reviewed by Anders Carlsson.
1175
1176         * DumpRenderTree/TestRunner.cpp:
1177         * ImageDiff/efl/ImageDiff.cpp:
1178         * TestWebKitAPI/JavaScriptTest.cpp:
1179         * TestWebKitAPI/PlatformUtilities.cpp:
1180         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1181         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1183         * WebKitTestRunner/StringFunctions.h:
1184         * WebKitTestRunner/TestInvocation.cpp:
1185         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1186         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1187
1188 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
1189
1190         W3C Test Import script reformats test HTML
1191         https://bugs.webkit.org/show_bug.cgi?id=119159
1192
1193         Reviewed by Dirk Pranke.
1194
1195         Completely rewrite the test conversion process to minimize
1196         reformatting when adding prefixes, etc. This isn't 100% perfect, there
1197         are still places where it will end up changing the formatting, but it
1198         is much better than before. Most notably, the public interface to the
1199         test converter has changed: now one calls a method instead of creating
1200         an instance of the test converter class. This is because the test
1201         converter class now has state, so one really needs a new instance for
1202         each test.
1203
1204         Note that this also lays some simple groundwork for being able to use
1205         a MockHost in the tests.
1206
1207         * Scripts/webkitpy/w3c/test_converter.py:
1208         (convert_for_webkit):
1209         (_W3CTestConverter):
1210         (_W3CTestConverter.__init__):
1211         (_W3CTestConverter.output):
1212         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1213         (_W3CTestConverter.convert_style_data):
1214         (_W3CTestConverter.convert_attributes_if_needed):
1215         (_W3CTestConverter.handle_starttag):
1216         (_W3CTestConverter.handle_endtag):
1217         (_W3CTestConverter.handle_startendtag):
1218         (_W3CTestConverter.handle_data):
1219         (_W3CTestConverter.handle_entityref):
1220         (_W3CTestConverter.handle_charref):
1221         (_W3CTestConverter.handle_comment):
1222         (_W3CTestConverter.handle_decl):
1223         (_W3CTestConverter.handle_pi):
1224         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1225         (W3CTestConverterTest):
1226         (W3CTestConverterTest.fake_dir_path):
1227         (W3CTestConverterTest.test_read_prefixed_property_list):
1228         (verify_no_conversion_happened):
1229         * Scripts/webkitpy/w3c/test_importer.py:
1230         (TestImporter.import_tests):
1231
1232 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1233
1234         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
1235         https://bugs.webkit.org/show_bug.cgi?id=121578
1236
1237         Rubber stamped by Geoffrey Garen.
1238
1239         * Scripts/run-layout-jsc:
1240
1241 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1242
1243         Unreviewed, fix for Ruby 1.8.
1244
1245         * Scripts/run-jsc-stress-tests:
1246
1247 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
1248
1249         run-jsc-stress-tests should make it easier to look at error spew from tests
1250         https://bugs.webkit.org/show_bug.cgi?id=121531
1251
1252         Reviewed by Mark Hahnenberg.
1253         
1254         This makes two changes:
1255         
1256         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
1257         
1258         - The same spew also goes to the console but is prefixed by the test's name.
1259         
1260         This required some tee and awk hacks, and then some sh hacks to work around the fact
1261         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
1262         operator will only see a failure of bar failed. So to pass output to tee and awk, I
1263         needed to do weird things.
1264
1265         * Scripts/run-jsc-stress-tests:
1266
1267 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
1268
1269         REGRESSION (r129451): run-safari --no-saved-state is broken
1270         https://bugs.webkit.org/show_bug.cgi?id=121566
1271
1272         Reviewed by Mark Rowe.
1273
1274         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
1275         Check arguments, not the newly created empty array. Pass a value that silences warnings.
1276         While at it, removed a check for Snow Leopard.
1277
1278 2013-09-18  Alex Christensen  <achristensen@webkit.org>
1279
1280         Improved WinLauncher's URL handling.
1281         https://bugs.webkit.org/show_bug.cgi?id=121535
1282
1283         Reviewed by Brent Fulgham.
1284
1285         * WinLauncher/WinLauncher.cpp:
1286         (EditProc):
1287         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
1288         (loadURL):
1289         Prepend "http://" to URLs with no scheme.
1290
1291 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1292
1293         DFG should support Int52 for local variables
1294         https://bugs.webkit.org/show_bug.cgi?id=121064
1295
1296         Reviewed by Oliver Hunt.
1297
1298         * Scripts/run-jsc-stress-tests:
1299
1300 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
1301
1302         [Win] TestWebKitAPI does not compile.
1303         https://bugs.webkit.org/show_bug.cgi?id=121485
1304
1305         Reviewed by Brent Fulgham.
1306
1307         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
1308         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
1309         to return null, which is the case we want to test.
1310
1311         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1312         (TestWebKitAPI::TEST):
1313
1314 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
1315
1316         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
1317         https://bugs.webkit.org/show_bug.cgi?id=121495
1318
1319         Reviewed by Chris Fleizach.
1320
1321         Adapted DRT and WKTR to deal with the new names for the ATK object
1322         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
1323
1324         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1325         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
1326         (AccessibilityUIElement::stringAttributeValue): Ditto.
1327         (AccessibilityUIElement::hasPopup): Ditto.
1328         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1329         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
1330         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1331         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1332
1333 2013-09-18  Commit Queue  <commit-queue@webkit.org>
1334
1335         Unreviewed, rolling out r156019 and r156020.
1336         http://trac.webkit.org/changeset/156019
1337         http://trac.webkit.org/changeset/156020
1338         https://bugs.webkit.org/show_bug.cgi?id=121540
1339
1340         Broke tests (Requested by ap on #webkit).
1341
1342         * Scripts/run-jsc-stress-tests:
1343
1344 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
1345
1346         Unreviewed. Add myself as a committer.
1347
1348         * Scripts/webkitpy/common/config/contributors.json:
1349
1350 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
1351
1352         Unreviewed. Add myself as a committer.
1353
1354         * Scripts/webkitpy/common/config/contributors.json:
1355
1356 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
1357
1358         DFG should support Int52 for local variables
1359         https://bugs.webkit.org/show_bug.cgi?id=121064
1360
1361         Reviewed by Oliver Hunt.
1362
1363         * Scripts/run-jsc-stress-tests:
1364
1365 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
1366
1367         Added back and forward buttons to WinLauncher.
1368         https://bugs.webkit.org/show_bug.cgi?id=121212
1369
1370         Reviewed by Brent Fulgham.
1371
1372         * WinLauncher/WinLauncher.cpp:
1373         (resizeSubViews):
1374         Move new back and forward buttons to correct positions before URL bar.
1375         (dllLauncherEntryPoint): 
1376         Store the default button window procedure and replace with my button procedures.
1377         (EditProc): Updated style and renamed from MyEditProc.
1378         (BackButtonProc): Added.
1379         (ForwardButtonProc): Added.
1380
1381 2013-09-17  Michael Saboff  <msaboff@apple.com>
1382
1383         Unreviewed typo fix after r155999
1384
1385         Changed en_US.UTB-8 to en_US.UTF-8
1386
1387         * Scripts/run-javascriptcore-tests:
1388
1389 2013-09-17  Michael Saboff  <msaboff@apple.com>
1390
1391         run-jsc-stress-tests fails with ruby version 2
1392         https://bugs.webkit.org/show_bug.cgi?id=121521
1393
1394         Reviewed by Jessie Berlin.
1395
1396         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
1397
1398         * Scripts/run-javascriptcore-tests:
1399
1400 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
1401
1402         [Windows] Unreviewed build fix after r155963.
1403
1404         * DumpRenderTree/win/TestRunnerWin.cpp:
1405         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
1406
1407 2013-09-17  Anders Carlsson  <andersca@apple.com>
1408
1409         Fix a typo.
1410
1411         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1412         (TestWebKitAPI::TEST):
1413
1414 2013-09-16  Anders Carlsson  <andersca@apple.com>
1415
1416         HashMap should work with move-only keys
1417         https://bugs.webkit.org/show_bug.cgi?id=121310
1418
1419         Reviewed by Darin Adler.
1420
1421         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1422         (TestWebKitAPI::TEST):
1423         Add test.
1424
1425 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
1426
1427         BrowserMarshal.h build fail
1428         https://bugs.webkit.org/show_bug.cgi?id=102938
1429
1430         Reviewed by Carlos Garcia Campos.
1431
1432         Fix variable name.
1433
1434         * MiniBrowser/gtk/GNUmakefile.am:
1435
1436 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
1437
1438         [Windows] Clean up WinLauncher by using smart pointers
1439         https://bugs.webkit.org/show_bug.cgi?id=121467
1440
1441         Reviewed by Anders Carlsson.
1442
1443         * WinLauncher/PrintWebUIDelegate.cpp:
1444         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
1445         * WinLauncher/WinLauncher.cpp:
1446         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
1447         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
1448         (showLastVisitedSites): Smart pointer updates.
1449         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
1450         (setToDefaultPreferences): Ditto.
1451         (dllLauncherEntryPoint): Ditto.
1452         (PrintView): Ditto.
1453         (LaunchInspector): Ditto.
1454         (NavigateToHistory): Ditto.
1455         (MyEditProc): Ditto.
1456         (loadURL): Ditto.
1457
1458 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
1459
1460         [Windows] Add rudimentary history to WinLauncher.
1461         https://bugs.webkit.org/show_bug.cgi?id=121463
1462
1463         Reviewed by Anders Carlsson.
1464
1465         * WinLauncher/WinLauncher.cpp:
1466         (updateMenuItemForHistoryItem): Added
1467         (showLastVisitedSites): Added
1468         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
1469         a new page has been visited.
1470         (dllLauncherEntryPoint): Deallocate history on exit.
1471         (NavigateToHistory): Added
1472         (WndProc): Add handler for history entries
1473         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
1474         up to 10 history slots.
1475         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
1476         Windows utility library to allow use of _bstr_t type.
1477         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
1478         to hold up to 10 history slots.
1479         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
1480
1481 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
1482
1483         [GTK] Make symbol export filter more strict, and disable for dev/test builds
1484         https://bugs.webkit.org/show_bug.cgi?id=120586
1485
1486         Reviewed by Martin Robinson.
1487
1488         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
1489         makefiles, so they can be included unconditionally.
1490         * GtkLauncher/GNUmakefile.am: added.
1491         * Scripts/webkitdirs.pm:
1492         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
1493         to configure, since we consider builds done through build-webkit to be development
1494         and test builds.
1495         * gtk/GNUmakefile.am: added.
1496         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
1497         it's not necessary and it will not work now that the Scripts directory is not
1498         shipped in the tarball.
1499
1500 2013-09-16  Anders Carlsson  <andersca@apple.com>
1501
1502         WTF::Deque should work with move only types
1503         https://bugs.webkit.org/show_bug.cgi?id=121446
1504
1505         Reviewed by Andreas Kling.
1506
1507         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1508         (TestWebKitAPI::TEST):
1509         Add a test.
1510
1511 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
1512
1513         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
1514         https://bugs.webkit.org/show_bug.cgi?id=98410
1515
1516         Reviewed by Darin Adler.
1517
1518         Add implementation of click() method of objects returned by eventSender.contextClick().
1519
1520         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1521         (MenuItemPrivateData):
1522         (WTR::menuItemClickCallback):
1523         (WTR::getMenuItemTitleCallback):
1524         (WTR::staticMenuItemFinalize):
1525         (WTR::getMenuItemClass):
1526         (WTR::EventSendingController::contextClick):
1527
1528 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
1529
1530         Make the GDB webkit.py script compatible with Python v3
1531         https://bugs.webkit.org/show_bug.cgi?id=121395
1532
1533         Reviewed by Ryosuke Niwa.
1534
1535         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
1536         uses of xrange() in the script are replaced with range(), and the print statements are changed into
1537         the print() function invocations.
1538
1539         * gdb/webkit.py:
1540         (guess_string_length):
1541         (ustring_to_string):
1542         (lstring_to_string):
1543         (WTFCStringPrinter.to_string):
1544         (PrintPathToRootCommand.invoke):
1545
1546 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
1547
1548         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
1549         https://bugs.webkit.org/show_bug.cgi?id=119631
1550
1551         Reviewed by Ryosuke Niwa.
1552
1553         The perf profiler is attached to the test runner after the test runner has been launched,
1554         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
1555         UIProcess, meaning that WebProcess operations will not be profiled.
1556
1557         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
1558         This is done in the scope of already present support for wrapper scripts (such as valgrind)
1559         that are settable through the --wrapper option. This causes the perf profiler to correctly
1560         continue profiling the WebProcess after it was spawned.
1561
1562         When the profiler is launched, a wait process is launched with the profiler's pid as the
1563         argument. This ensures we can check that the profiler exited normally. If it did not, its
1564         output can be corrupted and can cause problems when that output is examined. The after-exit
1565         report is avoided in that case.
1566
1567         * Scripts/webkitpy/common/system/profiler.py:
1568         (Profiler.wrapper_arguments): The method returns an empty list by default.
1569         (Perf.__init__): Remove unnecessary member variables.
1570         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
1571         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
1572         the method returns a list of arguments that should be used as a wrapper for the test runner.
1573         The arguments specify the 'perf record' command, with the output file and the instruction to
1574         construct the call graph given as well.
1575         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
1576         whitespace in the profile lines.
1577         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
1578         running. If it is running even after that, or if the profiler process produced a non-zero exit
1579         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
1580         the top 10 lines of the profile and how to examine the profile further.
1581         * Scripts/webkitpy/port/driver.py:
1582         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
1583         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
1584         or an empty list otherwise.
1585         (Driver.cmd_line):
1586         * Scripts/webkitpy/port/driver_unittest.py:
1587         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
1588         for the testing-specific Port object.
1589         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
1590         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
1591         a parameter.
1592         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
1593         when profiling on the Linux platform with the perf profiler.
1594
1595 2013-09-14  Dan Bernstein  <mitz@apple.com>
1596
1597         [mac] Check For Framework Include Consistency build phase checks the wrong framework
1598         https://bugs.webkit.org/show_bug.cgi?id=121215
1599
1600         Reviewed by Mark Rowe.
1601
1602         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
1603         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
1604         public and private headers folder paths. Also tweaked the error messages’ format to make
1605         Xcode recognize them as errors.
1606
1607 2013-09-14  Alberto Garcia  <berto@igalia.com>
1608
1609         [GTK] Fails to compile if the build directory is in a different partition
1610         https://bugs.webkit.org/show_bug.cgi?id=121296
1611
1612         Reviewed by Martin Robinson.
1613
1614         Instead of using os.symlink() to install the gtk-doc templates,
1615         use os.link() first and fall back to os.symlink() if it fails.
1616
1617         * gtk/gtkdoc.py:
1618         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
1619
1620 2013-09-14  Alberto Garcia  <berto@igalia.com>
1621
1622         [GTK] WebKitGTK+ is linking against libxslt in too many places
1623         https://bugs.webkit.org/show_bug.cgi?id=121356
1624
1625         Reviewed by Martin Robinson.
1626
1627         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
1628         so we don't need to link against it.
1629
1630         * MiniBrowser/gtk/GNUmakefile.am:
1631         * TestWebKitAPI/GNUmakefile.am:
1632         * WebKitTestRunner/GNUmakefile.am:
1633
1634 2013-09-14  Ross Burton  <ross.burton@intel.com>
1635
1636         Uses gtk-doc tools even when --disable-gtk-doc passed
1637         https://bugs.webkit.org/show_bug.cgi?id=91239
1638
1639         Reviewed by Martin Robinson.
1640
1641         Don't run generate-gtkdoc on install if gtk-doc is disabled.
1642
1643         * GNUmakefile.am:
1644
1645 2013-09-14  Alberto Garcia  <berto@igalia.com>
1646
1647         [GTK] Fails to compile if the build directory is in a different partition
1648         https://bugs.webkit.org/show_bug.cgi?id=121296
1649
1650         Reviewed by Carlos Garcia Campos.
1651
1652         Use symlinks instead of hard links to support building on a
1653         different file system.
1654
1655         * gtk/gtkdoc.py:
1656         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
1657
1658 2013-09-13  Darin Adler  <darin@apple.com>
1659
1660         Use a better name than m_invertibleCTM
1661         https://bugs.webkit.org/show_bug.cgi?id=121341
1662
1663         Reviewed by Andreas Kling.
1664
1665         * Scripts/do-webcore-rename: Updated to do this replace as we do.
1666
1667 2013-09-13  Anders Carlsson  <andersca@apple.com>
1668
1669         Pick the correct overload when a const reference is passed to appendSlowCase.
1670         https://bugs.webkit.org/show_bug.cgi?id=121326
1671
1672         Reviewed by Darin Adler.
1673
1674         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1675         (TestWebKitAPI::TEST):
1676
1677 2013-09-13  Darin Adler  <darin@apple.com>
1678
1679         Rename confusingly named "runtimeObject" functions
1680         https://bugs.webkit.org/show_bug.cgi?id=121339
1681
1682         Reviewed by Sam Weinig.
1683
1684         * Scripts/do-webcore-rename: Updated to do this replace as usual.
1685
1686 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
1687
1688         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
1689         https://bugs.webkit.org/show_bug.cgi?id=121330
1690
1691         Reviewed by Mark Hahnenberg and Oliver Hunt.
1692
1693         We should run tests even if they don't have expected files yet.
1694         
1695         * Scripts/run-layout-jsc:
1696
1697 2013-09-13  Anders Carlsson  <andersca@apple.com>
1698
1699         Use nullptr instead of 0 in calls to HashMap::add
1700         https://bugs.webkit.org/show_bug.cgi?id=121322
1701
1702         Reviewed by Sam Weinig.
1703
1704         * DumpRenderTree/mac/TestRunnerMac.mm:
1705         (TestRunner::evaluateScriptInIsolatedWorld):
1706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1707         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1708
1709 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1710
1711         [GTK] Move to the new web inspector
1712         https://bugs.webkit.org/show_bug.cgi?id=120647
1713
1714         Reviewed by Carlos Garcia Campos.
1715
1716         * GtkLauncher/main.c:
1717         (main): no longer set WEBKIT_INSPECTOR_PATH.
1718         * MiniBrowser/gtk/main.c:
1719         (main): ditto.
1720         * Scripts/old-run-webkit-tests:
1721         (openDumpTool): ditto.
1722         * Scripts/run-gtk-tests: ditto.
1723         * Scripts/webkitpy/port/gtk.py:
1724         (GtkPort.setup_environ_for_server): ditto.
1725
1726 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1727
1728         [Qt] REGRESSION(r154444): xss-DENIED test results changed
1729         https://bugs.webkit.org/show_bug.cgi?id=120595
1730
1731         Reviewed by Jocelyn Turcotte.
1732
1733         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
1734
1735         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1736         (DumpRenderTree::initJSObjects):
1737
1738 2013-09-13  Darin Adler  <darin@apple.com>
1739
1740         Give actions in Range class NON_SHOUTING_NAMES
1741         https://bugs.webkit.org/show_bug.cgi?id=121280
1742
1743         Reviewed by Andreas Kling.
1744
1745         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
1746         the tradition of checking in the last one we did, along with other
1747         rename ideas for the future.
1748
1749 2013-09-12  Lucas Forschler  <lforschler@apple.com>
1750
1751         Create short build logs for errors and warnings.
1752         https://bugs.webkit.org/show_bug.cgi?id=120614
1753
1754         Reviewed by Ryosuke Niwa.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1757             -include StringIO 
1758         (CompileWebKit.createSummary):
1759             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
1760
1761 2013-09-12  Roger Fong  <roger_fong@apple.com>
1762
1763         Update cygwin downloader to search for packages in the right location.
1764
1765         * CygwinDownloader/cygwin-downloader.py:
1766         * CygwinDownloader/cygwin-downloader.zip:
1767
1768 2013-09-12  Anders Carlsson  <andersca@apple.com>
1769
1770         Add rudimentary support for move-only types as values in HashMap
1771         https://bugs.webkit.org/show_bug.cgi?id=121226
1772
1773         Reviewed by Andreas Kling.
1774
1775         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1776         (TestWebKitAPI::TEST):
1777         Add a HashMap<unsigned, MoveOnly> test.
1778
1779 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
1780
1781         Auto GDB backtrace generation for EFL/GTK/Qt bots.
1782         https://bugs.webkit.org/show_bug.cgi?id=119338
1783
1784         Reviewed by Csaba Osztrogonác.
1785
1786         * Scripts/webkitpy/port/efl.py:
1787         (EflPort.check_sys_deps):
1788         (EflPort):
1789         (EflPort._get_crash_log):
1790         * Scripts/webkitpy/port/efl_unittest.py:
1791         (EflPortTest.test_show_results_html_file):
1792         (EflPortTest):
1793         (EflPortTest.test_get_crash_log):
1794         * Scripts/webkitpy/port/gtk.py:
1795         (GtkPort._get_crash_log):
1796         * Scripts/webkitpy/port/gtk_unittest.py:
1797         (GtkPortTest.test_get_crash_log):
1798         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
1799         (GDBCrashLogGenerator):
1800         (GDBCrashLogGenerator.__init__):
1801         (GDBCrashLogGenerator._get_gdb_output):
1802         (GDBCrashLogGenerator.generate_crash_log):
1803         (GDBCrashLogGenerator.generate_crash_log.match_filename):
1804         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
1805         (GDBCrashLogGeneratorTest):
1806         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1807         (_mock_gdb_output):
1808         * Scripts/webkitpy/port/qt.py:
1809         (QtPort.default_child_processes):
1810         (QtPort):
1811         (QtPort._get_crash_log):
1812         * Scripts/webkitpy/port/qt_unittest.py:
1813         (QtPortTest.test_check_sys_deps):
1814         (QtPortTest):
1815         (QtPortTest.test_get_crash_log):
1816
1817 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
1818
1819         Unreviewed. Moving myself to the commiters list.
1820
1821         * Scripts/webkitpy/common/config/contributors.json:
1822
1823 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
1824
1825         [GTK] Add jhbuild-wayland.modules
1826         https://bugs.webkit.org/show_bug.cgi?id=120455
1827
1828         Reviewed by Gustavo Noronha Silva.
1829
1830         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
1831         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
1832         WEBKIT_EXTRA_MODULESETS.
1833
1834         * gtk/jhbuild-wayland.modules: Added.
1835
1836 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
1837
1838         [GTK][WK2] a11y tests unconditionally launching a11y daemons
1839         https://bugs.webkit.org/show_bug.cgi?id=120299
1840
1841         Reviewed by Carlos Garcia Campos.
1842
1843         Use the right variable name to store a reference to the at-spi2
1844         bus launcher process, so we can be sure we are terminating it when
1845         calling _tear_down_testing_environment().
1846
1847         * Scripts/run-gtk-tests:
1848         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
1849         instead of _ally_bus_launcher.
1850
1851 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1852
1853         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
1854         https://bugs.webkit.org/show_bug.cgi?id=121218
1855
1856         Reviewed by Philippe Normand.
1857
1858         Skipping the entire suite was added to skip tests when they can't
1859         be run because of the environment, for example to skip the a11y
1860         tests when the at-spi daemons fail to start. This is no longer
1861         true for all the cases, so we can disable the tests that are
1862         impossible to run instead of skipping them.
1863
1864         * Scripts/run-gtk-tests:
1865         (TestRunner.__init__): Initialize the skipped tests list.
1866         (TestRunner._setup_testing_environment): Add
1867         TestWebKitAccessibility path to the list of disabled tests when
1868         at-spi daemon fail to start.
1869         (TestRunner._should_run_test_program): Check first if the test
1870         program is disabled and then whether it's skipped honoring the
1871         skipped command line option.
1872
1873 2013-09-12  Samuel White  <samuel_white@apple.com>
1874
1875         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
1876         https://bugs.webkit.org/show_bug.cgi?id=117651
1877
1878         Reviewed by Mario Sanchez Prada.
1879
1880         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
1881
1882         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1883         (AccessibilityUIElement::valueDescription):
1884         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1885         (WTR::AccessibilityUIElement::valueDescription):
1886
1887 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
1888
1889         REGRESSION(r154781): accessibility/notification-listeners.html is failing
1890         https://bugs.webkit.org/show_bug.cgi?id=120669
1891
1892         Reviewed by Chris Fleizach.
1893
1894         Fixed 4 problems that were causing notification-listeners.html to fail.
1895
1896         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
1897         implemented in axObjectEventListener().
1898
1899         A notification for AXFocusedUIElementChanged was incorrectly sent when
1900         the element lost focus.
1901
1902         Global notification was not dispatched if an element notification was
1903         present in the HashMap.
1904
1905         connectAccessibilityCallbacks() was connecting signals to callbacks
1906         multiple times because it was not checking if
1907         disconnectAccessibilityCallbacks() had an early return if there were
1908         active handlers.
1909
1910         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
1911         disconnectAccessibilityCallbacks() to inform if the callbacks were
1912         successfully disconnected.
1913         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1914         (axObjectEventListener): Implemented notifications for
1915         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
1916         notification, which was not dispatched if an element notification
1917         existed. Fixed the notification for AXFocusedUIElementChanged that was
1918         incorrectly sent when the element lost focus. In addition, fixed a typo
1919         where TRUE should be true.
1920         (connectAccessibilityCallbacks): Added early return if
1921         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
1922         (disconnectAccessibilityCallbacks): Added a return value to inform if
1923         callbacks were successfully disconnected.
1924
1925 2013-09-11  Anders Carlsson  <andersca@apple.com>
1926
1927         Try to fix GCC builds.
1928
1929         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
1930
1931 2013-09-11  Anders Carlsson  <andersca@apple.com>
1932
1933         Try to fix the build.
1934
1935         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
1936         file in the Tests/ directory in the first place.
1937
1938         * TestWebKitAPI/CMakeLists.txt:
1939         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1940         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1942         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
1943
1944 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
1945
1946         [Windows] Build fix for MoveOnly
1947
1948         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
1949         Tests to include search path.
1950         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1951         Ditto.
1952
1953 2013-09-11  Anders Carlsson  <andersca@apple.com>
1954
1955         Add HashSet::take
1956         https://bugs.webkit.org/show_bug.cgi?id=121192
1957
1958         Reviewed by Darin Adler.
1959
1960         Add a test for HashSet::take.
1961
1962         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1963         (TestWebKitAPI::TEST):
1964
1965 2013-09-11  Anders Carlsson  <andersca@apple.com>
1966
1967         HashSet should work with move only types
1968         https://bugs.webkit.org/show_bug.cgi?id=121188
1969
1970         Reviewed by Geoffrey Garen.
1971
1972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1973         * TestWebKitAPI/Tests/MoveOnly.h: Added.
1974         Move the MoveOnly class from Vector out into its own header.
1975
1976         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1977         (TestWebKitAPI::TEST):
1978         Add aHashSet<MoveOnly> test.
1979
1980         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1981         Include MoveOnly.h.
1982
1983 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
1984
1985         [Windows] Avoid converting from IntSize->SIZE->IntSize
1986         https://bugs.webkit.org/show_bug.cgi?id=121180
1987
1988         Reviewed by Anders Carlsson.
1989
1990         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1991         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
1992
1993 2013-09-11  Dan Bernstein  <mitz@apple.com>
1994
1995         REGRESSION (r155561): extract-localizable-strings can miss strings
1996         https://bugs.webkit.org/show_bug.cgi?id=121184
1997
1998         Reviewed by Darin Adler.
1999
2000         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
2001         parenthesis or bracket.
2002
2003 2013-09-11  Dan Bernstein  <mitz@apple.com>
2004
2005         update-webkit-localizable-strings is at least 5.8x slower than it should be
2006         https://bugs.webkit.org/show_bug.cgi?id=121178
2007
2008         Reviewed by Darin Adler.
2009
2010         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
2011         Note that this does not change functionality, because the script already does not understand
2012         the line continuation sequence (backslash followed by a newline).
2013
2014 2013-09-11  Anders Carlsson  <andersca@apple.com>
2015
2016         Vector::append doesn't work if element type has overloaded operator&
2017         https://bugs.webkit.org/show_bug.cgi?id=121175
2018
2019         Reviewed by Brent Fulgham.
2020
2021         Add a test case.
2022
2023         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2024         (TestWebKitAPI::TEST):
2025
2026 2013-09-11  Anders Carlsson  <andersca@apple.com>
2027
2028         Implement Vector::append for move-only types
2029         https://bugs.webkit.org/show_bug.cgi?id=120805
2030
2031         Reviewed by Sam Weinig.
2032
2033         Add a test for Vector<MoveOnly>::append.
2034
2035         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2036         (TestWebKitAPI::TEST):
2037
2038 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
2039
2040         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
2041
2042         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2043         (RunAndUploadPerfTests):
2044         (RunAndUploadPerfTests.start):
2045         (RunAndUploadPerfTests.getText2):
2046
2047 2013-09-11  Anders Carlsson  <andersca@apple.com>
2048
2049         The style checker shouldn't complain about returning or passing OwnPtr
2050         https://bugs.webkit.org/show_bug.cgi?id=121163
2051
2052         Reviewed by Antti Koivisto.
2053
2054         * Scripts/webkitpy/style/checkers/cpp.py:
2055         (check_function_definition_and_pass_ptr):
2056         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2057         (PassPtrTest.test_pass_ref_ptr_return_value):
2058         (PassPtrTest.test_own_ptr_parameter_value):
2059
2060 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2061
2062         [GTK] Remove Gail dependency from build system for GTK3
2063         https://bugs.webkit.org/show_bug.cgi?id=119673
2064
2065         Reviewed by Gustavo Noronha Silva.
2066
2067         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
2068         * Scripts/webkitpy/port/gtk.py:
2069         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
2070         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
2071
2072 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2073
2074         Performance tester bots should report the number of failing tests
2075         https://bugs.webkit.org/show_bug.cgi?id=120462
2076
2077         Reviewed by Csaba Osztrogonác.
2078
2079         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2080         (RunAndUploadPerfTests.start.getText):
2081         (RunAndUploadPerfTests.start):
2082         (RunAndUploadPerfTests):
2083         (RunAndUploadPerfTests.start.getText2):
2084
2085 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
2086
2087         [ATK] Adds mapping MenuItemRadioRole to ATK
2088         https://bugs.webkit.org/show_bug.cgi?id=121149
2089
2090         Reviewed by Mario Sanchez Prada.
2091
2092         Adds mapping MenuItemRadioRole to ATK.
2093
2094         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2095         (roleToString):
2096         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2097         (WTR::roleToString):
2098
2099 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
2100
2101         Unreviewed fix after the unreviewed r155498 to unbreak the failure
2102         counter of run-javascriptcore-tests build step on build.webkit.org.
2103
2104         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2105         (RunJavaScriptCoreTests.commandComplete):
2106         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2107
2108 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
2109
2110         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
2111         got a bit overlooked from the fast/js->js refactoring.
2112
2113         * Scripts/run-javascriptcore-tests:
2114
2115 2013-09-10  Daniel Bates  <dabates@apple.com>
2116
2117         [iOS] Upstream text autosizing
2118         https://bugs.webkit.org/show_bug.cgi?id=121111
2119
2120         Reviewed by Andy Estes and Sam Weinig.
2121
2122         Implement infrastructure to test the iOS text autosizing code.
2123
2124         * DumpRenderTree/TestRunner.cpp:
2125         (setTextAutosizingEnabledCallback): Added.
2126         (TestRunner::staticFunctions):
2127         * DumpRenderTree/TestRunner.h:
2128         * DumpRenderTree/mac/DumpRenderTree.mm:
2129         (resetDefaultsToConsistentValues):
2130         * DumpRenderTree/mac/TestRunnerMac.mm:
2131         (TestRunner::setTextAutosizingEnabled): Added.
2132
2133 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
2134
2135         run-jsc-stress-tests should have a mode for always running the copy phase
2136         https://bugs.webkit.org/show_bug.cgi?id=121128
2137
2138         Reviewed by Geoffrey Garen.
2139
2140         This will increase test coverage of the copying phase, which might not always get 
2141         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
2142
2143         * Scripts/run-jsc-stress-tests:
2144
2145 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
2146
2147         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
2148         https://bugs.webkit.org/show_bug.cgi?id=121114
2149
2150         Reviewed by Christophe Dumez.
2151
2152         Use a tarball for libseccomp instead of git to avoid network issues on
2153         the buildbots while checking out the git repo. Using tarballs has the
2154         advantage of them being cached if the checksum matches, in which case
2155         there will be no need to download them again.
2156
2157         * efl/jhbuild.modules:
2158
2159 2013-09-10  Mark Lam  <mark.lam@apple.com>
2160
2161         Replace remaining "fast js" names in scripts.
2162         https://bugs.webkit.org/show_bug.cgi?id=120899.
2163
2164         Rubber stamped by Filip Pizlo.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2167         (test_layout_failure_new_output):
2168         (test_layout_crash_new_output):
2169         (test_mozilla_and_layout_failure_new_output):
2170         * Scripts/run-fast-jsc: Removed.
2171         * Scripts/run-javascriptcore-tests:
2172         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
2173
2174 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
2175
2176         Enable JSC stress tests for the rest of non-Windows platforms
2177         https://bugs.webkit.org/show_bug.cgi?id=121021
2178
2179         Reviewed by Filip Pizlo.
2180
2181         The JSC stress tests can already be enabled on Linux-based ports.
2182
2183         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2184         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
2185         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
2186         complete output, with the number of failing or crashing tests properly extracted.
2187         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
2188         output in other unit tests testing the parsing of the output in the new format.
2189         (test_jsc_stress_failure_new_output):
2190         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
2191         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
2192         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
2193         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
2194         of available CPUs so the stress tests can be run in parallel.
2195
2196 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
2197
2198         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
2199         https://bugs.webkit.org/show_bug.cgi?id=120552
2200
2201         Unreviewed build fix.
2202
2203         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2204         (AccessibilityUIElement::classList):
2205
2206 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
2207
2208         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
2209         https://bugs.webkit.org/show_bug.cgi?id=120552
2210
2211         Reviewed by Darin Adler.
2212
2213         * DumpRenderTree/AccessibilityUIElement.cpp:
2214         (getClassListCallback):
2215         (AccessibilityUIElement::getJSClass):
2216         * DumpRenderTree/AccessibilityUIElement.h:
2217         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2218         (AccessibilityUIElement::classList):
2219         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2220         (AccessibilityUIElement::classList):
2221         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2222         (AccessibilityUIElement::classList):
2223         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2224         (AccessibilityUIElement::classList):
2225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2226         (WTR::AccessibilityUIElement::classList):
2227         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2228         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2230         (WTR::AccessibilityUIElement::classList):
2231         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2232         (WTR::AccessibilityUIElement::classList):
2233
2234 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
2235
2236         [GTK] accessibility/loading-iframe-sends-notification.html is failing
2237         https://bugs.webkit.org/show_bug.cgi?id=98370
2238
2239         Reviewed by Chris Fleizach.
2240
2241         Added AXLayoutComplete for the GTK platform.
2242
2243         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2244         (axObjectEventListener): Added notification AXLayoutComplete for
2245         layout-complete signal.
2246
2247 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
2248
2249         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
2250         https://bugs.webkit.org/show_bug.cgi?id=120778
2251
2252         Reviewed by Anders Carlsson.
2253
2254         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2255         (createBitmapContextFromWebView): Use GDIObject.
2256         * Scripts/webkitpy/style/checkers/cpp.py:
2257         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
2258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2259         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
2260         (LeakyPatternTest.test_create_compatible_dc): Ditto.
2261
2262 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2263
2264         Unreviewed. Add myself as a committer.
2265
2266         * Scripts/webkitpy/common/config/contributors.json:
2267
2268 2013-09-10  Mark Lam  <mark.lam@apple.com>
2269
2270         Move LayoutTests/fast/js to LayoutTests/js.
2271         https://bugs.webkit.org/show_bug.cgi?id=120899.
2272
2273         Rubber stamped by Filip Pizlo.
2274
2275         Changed scripts to reflect the path change.
2276
2277         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2278         (RunJavaScriptCoreTests.commandComplete):
2279         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2280         (test_fast_js_failure_new_output):
2281         (test_fast_js_crash_new_output):
2282         (test_mozilla_and_fast_js_failure_new_output):
2283         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2284         (BlackBerry::WebKit::DumpRenderTree::runTests):
2285         * Scripts/make-script-test-wrappers:
2286         (findTemplateFiles):
2287         * Scripts/run-fast-jsc:
2288         * Scripts/run-javascriptcore-tests:
2289         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2290         (TestExpectations):
2291
2292 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
2293
2294         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
2295         https://bugs.webkit.org/show_bug.cgi?id=70606
2296
2297         Reviewed by Mario Sanchez Prada.
2298
2299         Implemented the global notification listener for
2300         AccessibilityController. The signal is generated by
2301         AXObjectCache::postPlatformNotification() and received by
2302         axObjectEventListener(). axObjectEventListener will then invoke
2303         JSObjectCallAsFunction() with the respective callback function.
2304
2305         There is no additional test for this patch since its implementation will
2306         be tested by a11y layout tests that are currently skipped (e.g. bug
2307         98370).
2308
2309         * DumpRenderTree/AccessibilityController.h: Added a global notification
2310         handler for GTK+.
2311         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2312         (AccessibilityController::AccessibilityController): Initializes the
2313         global handler with 0.
2314         (AccessibilityController::addNotificationListener): Creates the
2315         notification handler and sets the notification function callback.
2316         (AccessibilityController::removeNotificationListener): Removes the
2317         global handler.
2318
2319 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
2320
2321         [ATK] Incorrect type for holding float value
2322         https://bugs.webkit.org/show_bug.cgi?id=121091
2323
2324         Reviewed by Mario Sanchez Prada.
2325
2326         Variable is not set properly, because of it's type.
2327
2328         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2329         (WTR::alterCurrentValue):
2330
2331 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2332
2333         [Qt] make use of qtHaveModule() 
2334         https://bugs.webkit.org/show_bug.cgi?id=121090
2335
2336         Reviewed by Jocelyn Turcotte.
2337         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
2338
2339         Use qtHaveModule instead of our own haveQtModule.
2340
2341         * QtTestBrowser/QtTestBrowser.pro:
2342         * qmake/mkspecs/features/configure.prf:
2343         * qmake/mkspecs/features/features.prf:
2344         * qmake/mkspecs/features/functions.prf:
2345
2346 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2347
2348         Unreviewed. Add myself as a committer.
2349
2350         * Scripts/webkitpy/common/config/contributors.json:
2351
2352 2013-09-10  Radu Stavila  <stavila@adobe.com>
2353
2354         Unreviewed. Added myself as a committer.
2355
2356         * Scripts/webkitpy/common/config/contributors.json:
2357
2358 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2359
2360         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
2361         https://bugs.webkit.org/show_bug.cgi?id=105538
2362
2363         Reviewed by Chris Fleizach.
2364
2365         Unskip passing test getTextInParagraphAndBodyModerate.
2366
2367         * Scripts/run-gtk-tests:
2368         (TestRunner): Unskip pasing test.
2369
2370 2013-09-09  Mark Lam  <mark.lam@apple.com>
2371
2372         Remove more references to the deleted js-test-style.css.
2373         https://bugs.webkit.org/show_bug.cgi?id=120899.
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2378         (translate_includes):
2379
2380 2013-09-09  Mark Lam  <mark.lam@apple.com>
2381
2382         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
2383         https://bugs.webkit.org/show_bug.cgi?id=120899.
2384
2385         Not reviewed.
2386
2387         The webkitpy test failure that resulted in the rollout is due to
2388         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
2389         which is to be deleted. Deleting that line fixes the issue.
2390
2391         * Scripts/make-new-script-test:
2392         (makePathToSharedSources):
2393         * Scripts/run-fast-jsc:
2394         * Scripts/webkitperl/httpd.pm:
2395         (getDefaultConfigForTestDirectory):
2396         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2397         (LayoutTestApacheHttpd.__init__):
2398         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2399         (Lighttpd.__init__):
2400         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2401         (BaseTest.integration_test_port_and_root):
2402         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2403         (TestHttpServer.test_start_cmd):
2404         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2405         (translate_includes):
2406         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2407         (TestTranslation.test_include_rewriting):
2408
2409 2013-09-09  Mark Lam  <mark.lam@apple.com>
2410
2411         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
2412         https://bugs.webkit.org/show_bug.cgi?id=120899.
2413
2414         Not reviewed.
2415
2416         * Scripts/make-new-script-test:
2417         (makePathToSharedSources):
2418         * Scripts/run-fast-jsc:
2419         * Scripts/webkitperl/httpd.pm:
2420         (getDefaultConfigForTestDirectory):
2421         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2422         (LayoutTestApacheHttpd.__init__):
2423         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2424         (Lighttpd.__init__):
2425         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2426         (BaseTest.integration_test_port_and_root):
2427         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2428         (TestHttpServer.test_start_cmd):
2429         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2430         (translate_includes):
2431         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2432         (TestTranslation.test_include_rewriting):
2433
2434 2013-09-09  Mark Lam  <mark.lam@apple.com>
2435
2436         Point Tools scripts to LayoutTests/resources.
2437         https://bugs.webkit.org/show_bug.cgi?id=120899.
2438
2439         Reviewed by Ryosuke Niwa.
2440
2441         * Scripts/make-new-script-test:
2442         (makePathToSharedSources):
2443         * Scripts/run-fast-jsc:
2444         * Scripts/webkitperl/httpd.pm:
2445         (getDefaultConfigForTestDirectory):
2446         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2447         (LayoutTestApacheHttpd.__init__):
2448         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2449         (Lighttpd.__init__):
2450         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2451         (BaseTest.integration_test_port_and_root):
2452         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2453         (TestHttpServer.test_start_cmd):
2454         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2455         (translate_includes):
2456         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2457         (TestTranslation.test_include_rewriting):
2458
2459 2013-09-09  Roger Fong  <roger_fong@apple.com>
2460
2461         Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
2462
2463         * CygwinDownloader/cygwin-downloader.py:
2464         * CygwinDownloader/cygwin-downloader.zip:
2465
2466 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
2467
2468         Unreviewed, fix Ruby exception handling.
2469
2470         * Scripts/run-jsc-stress-tests:
2471
2472 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
2473
2474         Stress tests should test the jsc profiler (-p)
2475         https://bugs.webkit.org/show_bug.cgi?id=121043
2476
2477         Reviewed by Mark Hahnenberg.
2478         
2479         Add a runProfiler command that all tests could use. This requires profiler-test-helper,
2480         which first runs the JS test and then tries the output with display-profiler-output.
2481         But if any of the things required for this to work aren't present, we just do a simpler
2482         test that just uses "-p".
2483         
2484         Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
2485         to create test collections using a yaml file that specifies the test path and the
2486         command to run.
2487
2488         * Scripts/jsc-stress-test-helpers: Added.
2489         * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
2490         * Scripts/run-javascriptcore-tests:
2491         * Scripts/run-jsc-stress-tests:
2492
2493 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
2494
2495         [webkitpy] Remove the DeprecatedPort class
2496         https://bugs.webkit.org/show_bug.cgi?id=121030
2497
2498         Reviewed by Ryosuke Niwa.
2499
2500         Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
2501
2502         The various methods returning commands are moved from the DeprecatedPort class into the Port class,
2503         with the Port subclasses overriding specific methods as required.
2504
2505         * Scripts/webkitpy/common/config/ports.py: Removed.
2506         * Scripts/webkitpy/common/config/ports_mock.py: Removed.
2507         * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
2508         * Scripts/webkitpy/port/base.py:
2509         (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
2510         It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
2511         string if the port instance represents the WK2 variation of the port.
2512         (Port.script_shell_command): Moved here from the DeprecatedPort interface.
2513         (Port.make_args): Ditto.
2514         (Port.update_webkit_command): Ditto.
2515         (Port.check_webkit_style_command): Ditto.
2516         (Port.prepare_changelog_command): Ditto.
2517         (Port.build_webkit_command): Ditto.
2518         (Port.run_javascriptcore_tests_command): Ditto.
2519         (Port.run_webkit_unit_tests_command): Ditto.
2520         (Port.run_webkit_tests_command): Ditto.
2521         (Port.run_python_unittests_command): Ditto.
2522         (Port.run_perl_unittests_command): Ditto.
2523         (Port.run_bindings_tests_command): Ditto.
2524         * Scripts/webkitpy/port/base_unittest.py:
2525         (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
2526         return value with different build types passed to the method.
2527         * Scripts/webkitpy/port/efl.py:
2528         (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
2529         to the command line.
2530         * Scripts/webkitpy/port/efl_unittest.py:
2531         (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
2532         variations of the EflPort class.
2533         * Scripts/webkitpy/port/gtk.py:
2534         (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
2535         to the command line.
2536         (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
2537         * Scripts/webkitpy/port/gtk_unittest.py:
2538         (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
2539         and WK2 variations of the GtkPort class.
2540         * Scripts/webkitpy/port/mac_unittest.py:
2541         (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
2542         variations of the MacPort class.
2543         * Scripts/webkitpy/port/qt.py:
2544         (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
2545         to the command line.
2546         (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
2547         * Scripts/webkitpy/port/qt_unittest.py:
2548         (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
2549         variations of the QtPort class.
2550         * Scripts/webkitpy/port/test.py:
2551         (TestPort.make_args): Return a mock value that's intended for testing.
2552         (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
2553         (TestPort.update_webkit_command): Ditto.
2554         (TestPort.build_webkit_command): Ditto.
2555         (TestPort.prepare_changelog_command): Ditto.
2556         (TestPort.run_python_unittests_command): Ditto.
2557         (TestPort.run_perl_unittests_command): Ditto.
2558         (TestPort.run_javascriptcore_tests_command): Ditto.
2559         (TestPort.run_webkit_unit_tests_command): Ditto.
2560         (TestPort.run_webkit_tests_command): Ditto.
2561         (TestPort.run_bindings_tests_command): Ditto.
2562         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2563         (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
2564         * Scripts/webkitpy/tool/bot/irc_command.py:
2565         (Rollout._update_working_copy): Ditto.
2566         * Scripts/webkitpy/tool/commands/download_unittest.py:
2567         (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
2568         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2569         (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
2570         * Scripts/webkitpy/tool/commands/queues.py:
2571         (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
2572         by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
2573         abstraction violation.
2574         (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
2575         * Scripts/webkitpy/tool/main.py:
2576         (WebKitPatch.__init__): self._deprecated_port -> self._port.
2577         (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
2578         (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
2579         * Scripts/webkitpy/tool/mocktool.py:
2580         (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
2581         to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
2582         a separate patch.
2583         (MockTool.port): Mimicks WebKitPatch.port().
2584         * Scripts/webkitpy/tool/steps/build.py:
2585         (Build.build): WebKitPatch.port() should be called now.
2586         * Scripts/webkitpy/tool/steps/checkstyle.py:
2587         (CheckStyle.run): Ditto.
2588         * Scripts/webkitpy/tool/steps/commit.py:
2589         (Commit._check_test_expectations): Ditto.
2590         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2591         (PrepareChangeLog.run): Ditto.
2592         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2593         (PrepareChangeLogForRevert.run): Ditto.
2594         * Scripts/webkitpy/tool/steps/runtests.py:
2595         (RunTests.run): Ditto.
2596         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2597         (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
2598         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2599         (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
2600         that the expected test output is adjusted to contain the mock-* command names.
2601         * Scripts/webkitpy/tool/steps/update.py:
2602         (Update._update_command): WebKitPatch.port() should be called now.
2603         * Scripts/webkitpy/tool/steps/update_unittest.py:
2604         (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
2605         that corresponds to the removed DeprecatedPort subclasses.
2606         (UpdateTest.test_update_command_interactive): Ditto.
2607
2608 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
2609
2610         [GTK] 32-bit builder should run the JSC tests
2611         https://bugs.webkit.org/show_bug.cgi?id=119215
2612
2613         Reviewed by Philippe Normand.
2614
2615         Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
2616         to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
2617         steps are only added if the LayoutTestClass member was not overridden to the value of None in a
2618         derived class.
2619
2620         Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
2621         is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
2622         This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
2623         is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
2624         layout testing while other types of testing are still expected to be performed.
2625
2626         * BuildSlaveSupport/build.webkit.org-config/config.json:
2627         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2628         (BuildFactory.__init__):
2629         (TestFactory):
2630         (TestFactory.__init__):
2631         (BuildAndTestFactory):
2632         (BuildAndTestFactory.__init__):
2633         (BuildAndTestWebKit2Factory):
2634         (BuildAndTestWebKit2OnlyFactory):
2635         (BuildAndNonLayoutTestFactory):
2636         (TestLeaksFactory):
2637         (TestWebKit2Factory):
2638
2639 2013-09-09  Manuel Rego Casasnovas  <rego@igalia.com>
2640
2641         Unreviewed. Add myself as a committer.
2642
2643         * Scripts/webkitpy/common/config/contributors.json:
2644
2645 2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
2646
2647         [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
2648         https://bugs.webkit.org/show_bug.cgi?id=121023
2649
2650         Reviewed by Mario Sanchez Prada.
2651
2652         Added mappings to ATK's ProgressBar element.
2653
2654         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2655         (roleToString):
2656         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2657         (WTR::roleToString):
2658
2659 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
2660
2661         run-jsc-stress-tests should be more paranoid about calling make
2662         https://bugs.webkit.org/show_bug.cgi?id=121011
2663
2664         Reviewed by Oliver Hunt.
2665         
2666         If it returns with any kind of error then bail out.  Also print the command being used
2667         in case we have to debug this, for example on the bots.  The extra verbosity isn't a
2668         big deal.
2669
2670         * Scripts/run-jsc-stress-tests:
2671
2672 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
2673
2674         Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
2675         like that. Pass a string instead.
2676
2677         * Scripts/run-jsc-stress-tests:
2678
2679 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
2680
2681         run-jsc-stress-tests should run tests in parallel if possible
2682         https://bugs.webkit.org/show_bug.cgi?id=120996
2683
2684         Reviewed by Oliver Hunt.
2685         
2686         Run tests in parallel by using Makefile hacks. This lets make take care of all load
2687         balancing. It's a really awesome speed-up for these tests.
2688         
2689         This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The 
2690         no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
2691         much awesome.
2692
2693         * Scripts/run-jsc-stress-tests:
2694
2695 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
2696
2697         run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
2698         https://bugs.webkit.org/show_bug.cgi?id=120994
2699
2700         Reviewed by Geoffrey Garen.
2701         
2702         run-jsc-stress-tests accepts a list of directories containing tests.  It needs to
2703         come up with names for all of them.  Currently it uses the basename of the test
2704         directory.  But that means that JSRegress gets called "script-tests", which is
2705         unfortunate since any directory in LayoutTests containing .js files will be
2706         called "script-tests".  So, this changes run-jsc-stress-tests to use more than
2707         just the basename if the basename has the word "tests" in it.  This causes
2708         JSRegress to be called "regress/script-tests".
2709
2710         * Scripts/run-jsc-stress-tests:
2711
2712 2013-09-08  Sergio Correia  <sergio.correia@openbossa.org>
2713
2714         [EFL][JHBUILD] Fix evas build with giflib5
2715         https://bugs.webkit.org/show_bug.cgi?id=120863
2716
2717         Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
2718
2719         Reviewed by Anders Carlsson.
2720
2721         * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
2722         * efl/patches/evas-fix-build-with-giflib5.patch: Added.
2723
2724 2013-09-07  Filip Pizlo  <fpizlo@apple.com>
2725
2726         Only run FTL tests if we have the FTL
2727         https://bugs.webkit.org/show_bug.cgi?id=120974
2728
2729         Reviewed by Geoffrey Garen.
2730         
2731         Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
2732         variants to run.
2733
2734         * Scripts/build-jsc:
2735         * Scripts/run-javascriptcore-tests:
2736         * Scripts/run-jsc-stress-tests:
2737
2738 2013-09-07  Santosh Mahto  <santosh.ma@samsung.com>
2739
2740         removing --dialog-element from build-webkit --help option message
2741         https://bugs.webkit.org/show_bug.cgi?id=120955
2742
2743         Reviewed by Daniel Bates.
2744
2745         --dialog-element option is useless while building as
2746         Dialog Element support has been removed in following changeset.
2747         http://trac.webkit.org/changeset/154835
2748         http://trac.webkit.org/changeset/154870
2749
2750         * Scripts/webkitperl/FeatureList.pm:
2751         Removed --dialog-element option message.
2752
2753 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
2754
2755         It should be possible to run-javascriptcore-tests with only a subset of the test suites
2756         https://bugs.webkit.org/show_bug.cgi?id=120918
2757
2758         Reviewed by Dan Bernstein.
2759
2760         * Scripts/run-javascriptcore-tests:
2761
2762 2013-09-06  Commit Queue  <commit-queue@webkit.org>
2763
2764         Unreviewed, rolling out r155196.
2765         http://trac.webkit.org/changeset/155196
2766         https://bugs.webkit.org/show_bug.cgi?id=120919
2767
2768         Broke 16 tests on build.webkit.org (Requested by rniwa on
2769         #webkit).
2770
2771         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2772         (Manager._set_up_run):
2773
2774 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
2775
2776         The 'failed' file should report collectionName/testName rather than just
2777         testName.
2778
2779         Rubber stamped by Mark Hahnenberg.
2780
2781         * Scripts/run-jsc-stress-tests:
2782
2783 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
2784
2785         Fix run-jsc-stress-tests to run on bots with old Ruby.
2786         
2787         Also make it create a repro file.
2788
2789         Rubber stamped by Mark Hahnenberg.
2790
2791         * Scripts/run-jsc-stress-tests:
2792
2793 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
2794
2795         Actually increment $numFailures
2796
2797         Reviewed by Mark Hahnenberg.
2798
2799         * Scripts/run-jsc-stress-tests:
2800
2801 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
2802
2803         Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
2804         
2805         Also make it uses system() instead of popen(); that means that test output
2806         will go to the console. This reduces error detection flakiness. It's fine
2807         because stress tests don't print() unless they really have to.
2808
2809         Rubber stamped by Mark Hahnenberg.
2810
2811         * Scripts/run-jsc-stress-tests:
2812
2813 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
2814
2815         Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
2816         https://bugs.webkit.org/show_bug.cgi?id=120808
2817
2818         Reviewed by Mark Hahnenberg and rubber stamped by Geoffrey Garen.
2819         
2820         Add a script for running stress tests.  A stress test is a .js file that is run
2821         through different configurations of JSC.  It can control which configurations it
2822         runs by using "//@ <ruby code>" to guide the script.
2823         
2824         This script is now run as part of run-javascriptcore-tests, on Mac only.
2825
2826         * Scripts/run-javascriptcore-tests:
2827         * Scripts/run-jsc-stress-tests: Added.
2828
2829 2013-09-06  Mario Sanchez Prada  <mario.prada@samsung.com>
2830
2831         [GTK] Desktop proxy settings are ignored inside the internal jhbuild
2832         https://bugs.webkit.org/show_bug.cgi?id=120833
2833
2834         Reviewed by Gustavo Noronha Silva.
2835
2836         Add dconf as an optional module for the internal jhbuild, along
2837         with vala 0.17 as a dependency, and make sure we do not explicitly
2838         set always the 'memory' backend, so we can have an easy way to
2839         allow apps access desktop settings from the jhbuild. This is
2840         useful for example to be able to run apps such as MiniBrowser
2841         inside the jhbuild (by means of run-launcher, for instance) while
2842         working behind a proxy, since those network settings have to be
2843         read from the system global configuration in org.gnome.system.proxy.
2844
2845         * gtk/jhbuild-optional.modules: Added dconf 0.14 and vala 0.17.
2846         * gtk/jhbuildrc: Do not explicitly choose the GSettings memory
2847         backend here, since that will make more difficult to use the dconf
2848         backend from inside the jhbuild if we need to do it so.
2849
2850 2013-09-06  Alexey Proskuryakov  <ap@apple.com>
2851
2852         Lots of pixel tests are failing on first run, so tests cannot finish
2853         https://bugs.webkit.org/show_bug.cgi?id=120755
2854
2855         Reviewed by Ryosuke Niwa.
2856
2857         For whatever reason, many reftests are color profile sensitive, and we only set
2858         color profile to a known one for pixel tests, not for reftests.
2859
2860         Pixel testing mode is also enabled  when retrying tests, so these failures used to
2861         be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
2862         But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
2863
2864         This probably shouldn't happen, as reftests should not be color profile sensitive.
2865         The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
2866
2867         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2868         (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
2869
2870 2013-09-06  Denis Nomiyama  <d.nomiyama@samsung.com>
2871
2872         [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
2873         https://bugs.webkit.org/show_bug.cgi?id=120416
2874
2875         Reviewed by Mario Sanchez Prada.
2876
2877         Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
2878         iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
2879         m_notificationHandler expected RefPtr.
2880
2881         The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
2882         HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
2883
2884         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
2885         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2886         (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
2887         global notification handler.
2888         (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
2889         for the global notification handler.
2890         (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
2891         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
2892         (AccessibilityNotificationHandler::create): Added static function to create
2893         AccessibilityNotificationHandler.
2894         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2895         (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
2896         AccessibilityNotificationHandler::create().
2897
2898 2013-09-06  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2899
2900         [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
2901         https://bugs.webkit.org/show_bug.cgi?id=120847
2902
2903         Reviewed by Csaba Osztrogonác.
2904
2905         Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
2906         Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
2907         Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
2908
2909         * WebKitTestRunner/PlatformWebView.h:
2910         (WTR::PlatformWebView::windowSnapshotEnabled):
2911         * WebKitTestRunner/TestInvocation.cpp:
2912         (WTR::TestInvocation::dumpResults):
2913         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2914         (WTR::WrapperWindow::handleStatusChanged):
2915         (WTR::PlatformWebView::windowSnapshotEnabled):
2916         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2917         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2918
2919 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2920
2921         REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
2922         https://bugs.webkit.org/show_bug.cgi?id=120843
2923
2924         Reviewed by Csaba Osztrogonác.
2925
2926         Call notifyDone like the platform specific forceRepaintDoneCallback methods
2927         it replaced did. The method is empty on the Apple ports.
2928
2929         * WebKitTestRunner/TestInvocation.cpp:
2930         (WTR::TestInvocation::forceRepaintDoneCallback):
2931
2932 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2933
2934         [Qt][WK2] Window used by WebKitTestRunner loses active status
2935         https://bugs.webkit.org/show_bug.cgi?id=120774
2936
2937         Reviewed by Jocelyn Turcotte.
2938
2939         When focusing the PlatformWebView which is done at the start of each test, we should
2940         ensure the host window of PlatformWebView is also made active, otherwise we will
2941         not receive the keyboard events send by EventSenderProxy.
2942
2943         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2944         (WTR::PlatformWebView::focus):
2945
2946 2013-09-05  Seokju Kwon  <seokju@webkit.org>
2947
2948         Unreviewed build fix. VectorReverse.cpp was removed after r155151.
2949
2950         * TestWebKitAPI/CMakeLists.txt:
2951
2952 2013-09-05  Anders Carlsson  <andersca@apple.com>
2953
2954         Make Vector::uncheckedAppend work with move-only types
2955         https://bugs.webkit.org/show_bug.cgi?id=120799
2956
2957         Reviewed by Andreas Kling.
2958
2959         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2960         (TestWebKitAPI::MoveOnly):
2961         Add a move-only class.
2962
2963         (TestWebKitAPI::TEST):
2964         Add a test for Vector<MoveOnly>::uncheckedAppend.
2965
2966 2013-09-05  Anders Carlsson  <andersca@apple.com>
2967
2968         Move all Vector tests into Vector.cpp
2969         https://bugs.webkit.org/show_bug.cgi?id=120797
2970
2971         Reviewed by Andreas Kling.
2972
2973         * TestWebKitAPI/CMakeLists.txt:
2974         * TestWebKitAPI/GNUmakefile.am:
2975         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2976         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2978         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
2981         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
2982         * TestWebKitAPI/Tests/WTF/WTF.pro:
2983
2984 2013-09-05  Simon Fraser  <simon.fraser@apple.com>
2985
2986         Expected result images are sometimes blank in WKTR
2987         https://bugs.webkit.org/show_bug.cgi?id=120715
2988
2989         Reviewed by Tim Horton.
2990         
2991         In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
2992         sometimes blank if a previous test triggered compositing mode, and the
2993         current test or reference did not require compositing. This happened
2994         because the UI process didn't wait for the web process to complete
2995         its compositing mode switch before snapshotting. Fix by calling
2996         WKPageForceRepaint() before we take the snapshot; this is async,
2997         so we have to spin the runloop for a while.
2998         
2999         Remove the Qt/EFL code that does the same thing.
3000
3001         * WebKitTestRunner/TestInvocation.cpp:
3002         (WTR::TestInvocation::forceRepaintDoneCallback):
3003         (WTR::TestInvocation::dumpResults):
3004         * WebKitTestRunner/TestInvocation.h:
3005         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3006         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3007         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3008         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3009
3010 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
3011
3012         Make build.webkit.org report the number of failing run-fast-jsc tests
3013         https://bugs.webkit.org/show_bug.cgi?id=120766
3014
3015         Reviewed by Filip Pizlo.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3018         (RunJavaScriptCoreTests.commandComplete):
3019         (RunJavaScriptCoreTests.getText2):
3020         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3021         (RunJavaScriptCoreTestsTest): Added.
3022         (RunJavaScriptCoreTestsTest.assertResults):
3023         (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
3024         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3025         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
3026         (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
3027         (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
3028         (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
3029
3030 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
3031
3032         Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
3033         https://bugs.webkit.org/show_bug.cgi?id=120759
3034
3035         Reviewed by Filip Pizlo.
3036
3037         * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
3038         * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
3039
3040 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3041
3042         Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
3043         Mozilla tests appears to run for a longer time.
3044         
3045         I think we want to continue to allow a few tests here and there to be
3046         longer-running, rather than excluding them. I seem to recall that those tests
3047         catch good bugs.
3048
3049         * Scripts/run-javascriptcore-tests:
3050
3051 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3052
3053         Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
3054         can't support it because if non-bourne shells. This fixes part #2 of the Linux
3055         bot breakage.
3056
3057         * Scripts/run-javascriptcore-tests:
3058
3059 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3060
3061         Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
3062
3063         * Scripts/run-javascriptcore-tests:
3064         (readAllLines):
3065
3066 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
3067
3068         jsc tests should have timeouts
3069         https://bugs.webkit.org/show_bug.cgi?id=120725
3070
3071         Reviewed by Geoffrey Garen.
3072         
3073         Set the timeout to 20 seconds per test for now.
3074
3075         * Scripts/run-javascriptcore-tests:
3076
3077 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
3078
3079         run-javascriptcore-tests should run-fast-jsc as well
3080         https://bugs.webkit.org/show_bug.cgi?id=120722
3081
3082         Reviewed by Geoffrey Garen.
3083         
3084         Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
3085         Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
3086
3087         * Scripts/run-javascriptcore-tests:
3088         (printThingsFound):
3089
3090 2013-09-04  Sergio Correia  <sergio.correia@openbossa.org>
3091
3092         [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
3093         https://bugs.webkit.org/show_bug.cgi?id=120646
3094
3095         Reviewed by Gyuyoung Kim.
3096
3097         * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
3098         list of passing tests, since it started to pass after r154045.
3099
3100 2013-09-04  Krzysztof Czech  <k.czech@samsung.com>
3101
3102         [ATK] Adds an accessibility support to access a value of the color control element
3103         https://bugs.webkit.org/show_bug.cgi?id=114354
3104
3105         Reviewed by Mario Sanchez Prada.
3106
3107         Added accessibility role of the color control element.
3108
3109         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3110         (roleToString):
3111         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3112         (WTR::roleToString):
3113
3114 2013-09-04  Mario Sanchez Prada  <mario.prada@samsung.com>
3115
3116         REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
3117         https://bugs.webkit.org/show_bug.cgi?id=100408
3118
3119         Unreviewed gardening. Unskip TestWebKitAccessibility after
3120         manually checking that it's running properly in the bot.
3121
3122         * Scripts/run-gtk-tests:
3123         (TestRunner): Unskipped TestWebKitAccessibility.
3124
3125 2013-09-04  Zan Dobersek  <zdobersek@igalia.com>
3126
3127         [GTK] Add support for the Wayland build target
3128         https://bugs.webkit.org/show_bug.cgi?id=120627
3129
3130         Reviewed by Gustavo Noronha Silva.
3131
3132         * GNUmakefile.am: Define the additional macros also if building the Wayland target.
3133
3134 2013-09-04  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
3135
3136         [GStreamer] cannot play live streams
3137         https://bugs.webkit.org/show_bug.cgi?id=116831
3138
3139         Reviewed by Philippe Normand.
3140
3141         Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
3142
3143         * gtk/jhbuild.modules:
3144         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
3145         * gtk/patches/udpsrc-improve-timeouts.patch: Added.
3146         Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
3147         and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
3148         Both patches are applied upstream and can be removed once a new gstreamer release
3149         is out (up to 1.0.10 the patches are not included) and we bump the requirements.
3150
3151 2013-09-03  Alexey Proskuryakov  <ap@apple.com>
3152
3153         [Mac] WebKitTestRunner still beeps sometimes
3154         https://bugs.webkit.org/show_bug.cgi?id=120652
3155
3156         Reviewed by Tim Horton.
3157
3158         In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
3159         UI process (notably, AppKit beeps when handling a key equivalent returns NO).
3160
3161         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
3162         Use the same SPI that we use in DRT and in WebProcess to disable beeping.
3163
3164 2013-09-03  Krzysztof Czech  <k.czech@samsung.com>
3165
3166         [AX][ATK] Added support for sort and help attributes
3167         https://bugs.webkit.org/show_bug.cgi?id=120456
3168
3169         Reviewed by Chris Fleizach.
3170
3171         Added missing implementation to AccessibilityUIElement::helpText and support for
3172         aria-sort attribute.
3173
3174         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3175         (coreAttributeToAtkAttribute):
3176         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3177         (WTR::coreAttributeToAtkAttribute):
3178         (WTR::AccessibilityUIElement::helpText):
3179
3180 2013-09-03  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3181
3182         [Qt][WK1] PageVisibility tests are flaky
3183         https://bugs.webkit.org/show_bug.cgi?id=120418
3184
3185         Reviewed by Jocelyn Turcotte.
3186
3187         Implement resetPageVisibility so we can reset visibility without
3188         emiting visibility state change events.
3189
3190         * DumpRenderTree/qt/TestRunnerQt.cpp:
3191         (TestRunner::resetPageVisibility):
3192
3193 2013-09-03  ChangSeok Oh  <changseok.oh@collabora.com>
3194
3195         [GTK] libsoup upversion to fix a gstreamer issue, bug115354
3196         https://bugs.webkit.org/show_bug.cgi?id=120613
3197
3198         Reviewed by Philippe Normand.
3199
3200         Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
3201         To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
3202         does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
3203         For the reason, we'll use libsoup git repo directly for a while until the next
3204         libsoup release.
3205
3206         * gtk/jhbuild.modules:
3207
3208 2013-09-02  Darin Adler  <darin@apple.com>
3209
3210         [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
3211         https://bugs.webkit.org/show_bug.cgi?id=120569
3212
3213         Reviewed by Andy Estes.
3214
3215         * DumpRenderTree/mac/DumpRenderTree.mm:
3216         (dump): Use CFBridgingRelease.
3217
3218 2013-09-02  Anton Obzhirov  <a.obzhirov@samsung.com>
3219
3220         <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
3221
3222         Reviewed by Mario Sanchez Prada.
3223
3224         Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
3225
3226         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3227         (axObjectEventListener):
3228         Added mapping for invalid-entry event parameter.
3229         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3230         (coreAttributeToAtkAttribute):
3231         Added mapping to aria-invalid.
3232         (AccessibilityUIElement::stringAttributeValue):
3233         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3234         (WTR::coreAttributeToAtkAttribute):
3235         Added mapping to aria-invalid.
3236
3237 2013-09-02  Nick Diego Yamane  <nick.yamane@openbossa.org>
3238
3239         Save md5 correctly when jhbuildPath doesn't exist yet
3240         https://bugs.webkit.org/show_bug.cgi?id=120548
3241
3242         Reviewed by Gustavo Noronha Silva.
3243
3244         After r152605, Md5 for jhbuild files are saved before the update
3245         process, this prevents the script to restart update from scratch
3246         when initial checkouts fail. However it causes an issue when builddir
3247         (or builddir/Dependencies) doesn't exist yet. In that case the
3248         saveJhbuildMd5 function fails to create md5 files.
3249         This patch adds a checking for the jhbuildPath and creates it if
3250         necessary before trying to open the md5 files.
3251
3252         * Scripts/update-webkit-libs-jhbuild:
3253         (saveJhbuildMd5):
3254
3255 2013-09-02  Mario Sanchez Prada  <mario.prada@samsung.com>
3256
3257         Unreviewed. Move myself to the reviewers list.
3258
3259         * Scripts/webkitpy/common/config/contributors.json:
3260
3261 2013-09-01  Alexey Proskuryakov  <ap@apple.com>
3262
3263         [WK2][Mac] Drag and drop tests interfere with user's UI
3264         https://bugs.webkit.org/show_bug.cgi?id=120538
3265
3266         Reviewed by Dan Bernstein.
3267
3268         This makes running WebKit2 regression tests locally more viable. The patch doesn't
3269         fix drag and drop tests to work as expected, I posted some thought about that in
3270         <https://bugs.webkit.org/show_bug.cgi?id=68552>.
3271
3272         * WebKitTestRunner/EventSenderProxy.h:
3273         (WTR::EventSenderProxy::position):
3274         * WebKitTestRunner/TestController.h:
3275         (WTR::TestController::eventSenderProxy):
3276         Expose a way to get current mouse position from anywhere in WKTR code.
3277
3278         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
3279
3280         * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
3281         Copied a FIXME comment from DumpRenderTree.
3282
3283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3284         (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3285         Override drag initiation, using a custom NSDraggingInfo implementation.
3286
3287         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
3288         Replace NSEvent with a custom class.
3289
3290         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
3291         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
3292         * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
3293         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
3294         Largely a copy of DumpRenderTree classes, modified to not use global variables.
3295         We should consider making these variables static in EventSenderProxy though, as
3296         it's strange that mouse state in WKTR is reset between tests without WebKit ever
3297         being told about that.
3298
3299 2013-08-30  Brent Fulgham  <bfulgham@apple.com>
3300
3301         [Windows] Unreviewed build fix.
3302
3303         * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
3304         from the build machines.
3305
3306 2013-08-30  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3307
3308         [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
3309         https://bugs.webkit.org/show_bug.cgi?id=120464
3310
3311         Reviewed by Jocelyn Turcotte.
3312
3313         * Scripts/webkitpy/port/qt.py:
3314         (QtPort._search_paths):
3315         * Scripts/webkitpy/port/qt_unittest.py:
3316         (QtPortTest):
3317
3318 2013-08-29  Filip Pizlo  <fpizlo@apple.com>
3319
3320         Just linking LLVM into JSC causes all plugin tests to fail
3321         https://bugs.webkit.org/show_bug.cgi?id=113915
3322
3323         Reviewed by Oliver Hunt.
3324         
3325         Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
3326         raise/abort/__assert_rtn.
3327
3328         * Scripts/configure-llvm:
3329
3330 2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>
3331
3332         new-run-webkit-tests does not respect --no-sample-on-timeout switch
3333         https://bugs.webkit.org/show_bug.cgi?id=120491
3334
3335         Reviewed by Darin Adler.
3336
3337         * Scripts/webkitpy/port/server_process.py:
3338         (ServerProcess._handle_timeout):
3339
3340 2013-08-29  Sam Weinig  <sam@webkit.org>
3341
3342         Add ENABLE guards for Promises
3343         https://bugs.webkit.org/show_bug.cgi?id=120488
3344
3345         Reviewed by Andreas Kling.
3346
3347         * Scripts/webkitperl/FeatureList.pm:
3348         * qmake/mkspecs/features/features.pri:
3349
3350 2013-08-29  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
3351
3352         [GTK] Should enable WebGL by default on MiniBrowser
3353         https://bugs.webkit.org/show_bug.cgi?id=120420
3354
3355         Reviewed by Gustavo Noronha Silva.
3356
3357         Enable WebGL by default on MiniBrowser.
3358
3359         * MiniBrowser/gtk/main.c:
3360         (main):
3361
3362 2013-08-28  Simon Fraser  <simon.fraser@apple.com>
3363
3364         Add a Command-R shortcut in MiniBrowser
3365         https://bugs.webkit.org/show_bug.cgi?id=120442
3366
3367         Reviewed by Dean Jackson.
3368         
3369         Add a "Reload Page" item to the View menu with a Command-R
3370         shortcut.
3371
3372         * MiniBrowser/mac/MainMenu.xib:
3373
3374 2013-08-29  Alberto Garcia  <berto@igalia.com>
3375
3376         [GTK] Update apt dependency list
3377         https://bugs.webkit.org/show_bug.cgi?id=120399
3378
3379         Reviewed by Philippe Normand.
3380
3381         Remove bogus package gail-3.0, add xfonts-utils (needed by
3382         xorg-xserver) and switch to the latest versions of libtiff and
3383         libjpeg.
3384
3385         * gtk/install-dependencies:
3386
3387 2013-08-28  Alexey Proskuryakov  <ap@apple.com>
3388
3389         [WK2][Mac] WebKitTestRunner doesn't force system appearance
3390         https://bugs.webkit.org/show_bug.cgi?id=120437
3391
3392         Reviewed by Darin Adler.
3393
3394         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3395         (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
3396         AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
3397         Fixed formatting.
3398
3399 2013-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3400
3401         <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
3402
3403         Reviewed by Darin Adler.
3404
3405         Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
3406
3407         We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
3408         editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
3409
3410         Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
3411         ranges in a given attributed string.
3412
3413         * DumpRenderTree/mac/TextInputController.m:
3414         (-[WebNSRange initWithNSRange:]):
3415         (-[WebNSRange location]):
3416         (-[WebNSRange length]):
3417         (+[WebNSRange isSelectorExcludedFromWebScript:]):
3418         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
3419         (+[NSMutableAttributedString webScriptNameForSelector:]):
3420         (-[NSMutableAttributedString ranges]): Added.
3421         (+[TextInputController isSelectorExcludedFromWebScript:]):
3422         (+[TextInputController webScriptNameForSelector:]):
3423         (-[TextInputController legacyAttributedString:]):
3424
3425 2013-08-28  Denis Nomiyama  <d.nomiyama@samsung.com>
3426
3427         [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
3428         https://bugs.webkit.org/show_bug.cgi?id=120419
3429
3430         Reviewed by Chris Fleizach.
3431
3432         Added a notification for AXFocusedUIElementChanged.
3433
3434         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3435         (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
3436
3437 2013-08-28  Roger Fong  <roger_fong@apple.com>
3438
3439         Decrease number of workers used in NRWT by the Windows port.
3440         https://bugs.webkit.org/show_bug.cgi?id=120435.
3441
3442         Reviewed by Brent Fulgham.
3443
3444         * Scripts/webkitpy/port/win.py:
3445         (WinPort.default_child_processes):
3446
3447 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3448
3449         Http tests fails on Debian with Apache 2.4
3450         https://bugs.webkit.org/show_bug.cgi?id=120352
3451
3452         Unreviewed fix-up.
3453
3454         Remember to update unit-test expectations and old-run-webkit-tests as well.
3455
3456         * Scripts/webkitperl/httpd.pm:
3457         (getHTTPDConfigPathForTestDirectory):
3458         * Scripts/webkitpy/port/port_testcase.py:
3459         (test_apache_config_file_name_for_platform):
3460
3461 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3462
3463         Http tests fails on Debian with Apache 2.4
3464         https://bugs.webkit.org/show_bug.cgi?id=120352
3465
3466         Reviewed by Andreas Kling.
3467
3468         Select httpd.conf file for debian based on version, matching Fedora behavior.
3469
3470         * Scripts/webkitpy/port/base.py:
3471         (Port._apache_config_file_name_for_platform):
3472
3473 2013-08-28  Commit Queue  <commit-queue@webkit.org>
3474
3475         Unreviewed, rolling out r154593.
3476         http://trac.webkit.org/changeset/154593
3477         https://bugs.webkit.org/show_bug.cgi?id=120403
3478
3479         Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
3480         on #webkit).
3481
3482         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3483         (WebPage::~WebPage):
3484
3485 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3486
3487         [Qt][Wk2] Many tests are flaky on Qt 5.1
3488         https://bugs.webkit.org/show_bug.cgi?id=118232
3489
3490         Reviewed by Jocelyn Turcotte.
3491
3492         We need to set renderToOffscreenBuffer since we won't otherwise get
3493         the paint calls necessary to synchronize UI- and Web-Process. It was
3494         only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
3495         which is no longer supported or needed.
3496
3497         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3498         (WTR::WrapperWindow::handleStatusChanged):
3499
3500 2013-08-27  Alexey Proskuryakov  <ap@apple.com>
3501
3502         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
3503         https://bugs.webkit.org/show_bug.cgi?id=120379
3504
3505         Reviewed by Darin Adler.
3506
3507         All major platforms have implemented UI process eventSender support, keeping old
3508         web process side code only adds confusion.
3509
3510         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3511         (WTR::EventSendingController::EventSendingController):
3512         (WTR::EventSendingController::mouseDown):
3513         (WTR::EventSendingController::mouseUp):
3514         (WTR::EventSendingController::mouseMoveTo):
3515         (WTR::EventSendingController::leapForward):
3516         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3517         * WebKitTestRunner/TestController.cpp:
3518         (WTR::TestController::resetStateToConsistentValues):
3519         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3520         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3521         * WebKitTestRunner/TestController.h:
3522
3523 2013-08-27  Roger Fong  <roger_fong@apple.com>
3524
3525         NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
3526         https://bugs.webkit.org/show_bug.cgi?id=120370.
3527
3528         Reviewed by Brent Fulgham.
3529
3530         * Scripts/webkitpy/port/win.py:
3531         (WinPort.delete_sem_locks):
3532         (WinPort.setup_test_run):
3533
3534 2013-08-27  Denis Nomiyama  <d.nomiyama@samsung.com>
3535
3536         [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
3537         https://bugs.webkit.org/show_bug.cgi?id=119883
3538
3539         Implemented the notification listener for AccessibilityUIElement. The signal is generated
3540         by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
3541         axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
3542         callback function. The global callback function and callbacks for specific elements are
3543         stored in a HashMap in AccessibilityCallbacksAtk.cpp.
3544
3545         Reviewed by Chris Fleizach.
3546
3547         * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
3548         * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
3549         and removeAccessibilityNotificationListener()
3550         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3551         (axObjectEventListener): Call JS callback for global notification or for a specific element
3552         (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
3553         notification handler
3554         (addAccessibilityNotificationHandler): Add notification listener to the list
3555         (removeAccessibilityNotificationHandler): Remove notification listener from the list
3556         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3557         (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
3558         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3559         (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
3560         (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
3561         Remove handler from the list and disconnect callbacks
3562         (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
3563         callback and connect callbacks to signals
3564         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
3565         (AccessibilityNotificationHandler::setPlatformElement): Set platform element
3566         (AccessibilityNotificationHandler::platformElement): Get platform element
3567         (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
3568         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3569         (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
3570         platform element and the notification callback
3571         (AccessibilityUIElement::removeNotificationListener):
3572         * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
3573         * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
3574
3575 2013-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3576
3577         Unreviewed. Fix GTK+ build after r154601.
3578
3579         * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
3580         compilation added by mistake in r154601.
3581
3582 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
3583
3584         WebKitTestRunner needs to protect the user's pasteboard contents while running
3585         https://bugs.webkit.org/show_bug.cgi?id=81419
3586         <rdar://problem/11066794>
3587
3588         Reviewed by Darin Adler.
3589
3590         Mostly a copy/paste of DRT code.
3591
3592         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
3593         doesn't interfere with my clipboard while being run in a loop.
3594
3595         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3596         * WebKitTestRunner/mac/PoseAsClass.h: Added.
3597         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
3598         * WebKitTestRunner/mac/TestControllerMac.mm:
3599         (WTR::TestController::platformInitialize):
3600         (WTR::TestController::platformDestroy):
3601         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
3602         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
3603
3604 2013-08-26  Commit Queue  <commit-queue@webkit.org>
3605
3606         Unreviewed, rolling out r154640.
3607         http://trac.webkit.org/changeset/154640
3608         https://bugs.webkit.org/show_bug.cgi?id=120329
3609
3610         Caused flaky crashes on a lot of editing tests (Requested by
3611         rniwa on #webkit).
3612
3613         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3614         * WebKitTestRunner/mac/PoseAsClass.h: Removed.
3615         * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
3616         * WebKitTestRunner/mac/TestControllerMac.mm:
3617         (WTR::TestController::platformInitialize):
3618         (WTR::TestController::platformDestroy):
3619         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
3620         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
3621
3622 2013-08-26  Dan Bernstein  <mitz@apple.com>
3623
3624         Automatic bug reports case pain
3625         https://bugs.webkit.org/show_bug.cgi?id=120330
3626
3627         Reviewed by Anders Carlsson.
3628
3629         * Scripts/webk