Add the ability to search for modifications that are staged for commit.
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2
3         Add the ability to search for modifications that are staged for commit.
4         https://bugs.webkit.org/show_bug.cgi?id=138373
5
6         Reviewed by Ryosuke Niwa and Daniel Bates.
7
8         This makes is easy to do identify files that require merge post-processing,
9         in addition to stand-alone utility.
10
11         * Scripts/webkitpy/common/checkout/scm/git.py:
12         (Git.modifications_staged_for_commit): Added.
13
14 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
15
16         Add a branch keyword argument to _run_git_svn_find_rev.
17         https://bugs.webkit.org/show_bug.cgi?id=138372
18
19         Reviewed by Ryosuke Niwa.
20
21         The addition of this keyword argument allows clients to determine the Git hash
22         of commits made on an SVN branch, provided that branch has been fetched locally.
23
24         * Scripts/webkitpy/common/checkout/scm/git.py:
25         (Git._run_git_svn_find_rev):
26         Add a branch keyword argument that is added to the end of the command, if present.
27
28 2014-11-04  Chris Dumez  <cdumez@apple.com>
29
30         Add ptr() method to Ref class
31         https://bugs.webkit.org/show_bug.cgi?id=138361
32
33         Reviewed by Darin Adler.
34
35         Use the new Ref::ptr() method.
36
37         * TestWebKitAPI/Tests/WTF/Ref.cpp:
38         (TestWebKitAPI::TEST):
39
40 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
41
42         [jhbuild] Make it possible to build GTK/EFL in same repository
43         https://bugs.webkit.org/show_bug.cgi?id=137448
44
45         Reviewed by Martin Robinson.
46
47         * Scripts/webkitdirs.pm:
48         (getJhbuildPath):
49         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
50         (getPlatformFontsPath):
51         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
52         (WTR::getFontsPath):
53         * jhbuild/jhbuild-wrapper:
54         (determine_platform):
55         (install_jhbuild):
56         * jhbuild/jhbuildrc_common.py:
57         (init):
58
59 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
60
61         [EFL] Bump LLVM to version 3.5.0
62         https://bugs.webkit.org/show_bug.cgi?id=138312
63
64         Reviewed by Csaba Osztrogonác.
65
66         * efl/jhbuild.modules:
67         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
68         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
69
70 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
71
72         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
73         https://bugs.webkit.org/show_bug.cgi?id=138257
74
75         Reviewed by Tim Horton.
76         
77         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
78         the user to toggle region page overlays on and off. Two overlays are available,
79         for the non-fast scrollable region, and the region of element with wheel
80         event handlers.
81
82         * MiniBrowser/mac/SettingsController.h:
83         * MiniBrowser/mac/SettingsController.m:
84         (-[SettingsController _populateMenu]):
85         (-[SettingsController validateMenuItem:]):
86         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
87         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
88         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
89         (-[SettingsController toggleDebugOverlay:]):
90         (-[SettingsController debugOverlayVisible:]):
91         * MiniBrowser/mac/WK2BrowserWindowController.m:
92         (-[WK2BrowserWindowController didChangeSettings]):
93
94 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
95
96         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
97         https://bugs.webkit.org/show_bug.cgi?id=138323
98
99         Reviewed by Zalan Bujtas.
100
101         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
102
103 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
104
105         [ninja] Don't remove response files for verbose builds
106         https://bugs.webkit.org/show_bug.cgi?id=137816
107
108         Reviewed by Csaba Osztrogonác.
109
110         * Scripts/webkitdirs.pm:
111         (determineNinjaVersion):
112         (buildCMakeGeneratedProject):
113
114 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
115
116         [GTK] Fix the build of FTL JIT
117         https://bugs.webkit.org/show_bug.cgi?id=138298
118
119         Reviewed by Carlos Garcia Campos.
120
121         * gtk/jhbuild-optional.modules:
122         Bump up LLVM version to 3.5.0 release and apply patches.
123         * gtk/patches/llvm-elf-add-stackmaps.patch:
124         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
125         trunk.
126         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
127         Added. Ensures that PC-relative relocations in EH frames are not
128         truncated to 32 bits on x86_64.
129
130 2014-10-31  Michael Saboff  <msaboff@apple.com>
131
132         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
133         https://bugs.webkit.org/show_bug.cgi?id=138268
134
135         Reviewed by Andreas Kling.
136
137         Added a --arch and --os option to set or override the values that are
138         normally computed based on examining the JavaScriptCore we want to test.
139
140         * Scripts/run-jsc-stress-tests:
141
142 2014-10-31  Dan Bernstein  <mitz@apple.com>
143
144         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
145         https://bugs.webkit.org/show_bug.cgi?id=138259
146
147         Reviewed by Geoff Garen.
148
149         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
150         going to be empty to silence the warning.
151
152 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
153
154         [GTK] Support script message handlers WebKitUserContentManager
155         https://bugs.webkit.org/show_bug.cgi?id=133730
156
157         Reviewed by Carlos Garcia Campos.
158
159         Support user script message handlers in WebKitUserContentManager.
160         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
161         an option is added to the CMake build files. The option is disabled
162         globally by default, and the WebKitGTK port enables it. On the API
163         level, two new methods to register and unregister names are provided
164         in the "window.webkit" namespace, and on message reception the
165         "WebKitUserContentManager::script-message-received" signal is
166         emitted, using the registered names as signal detail.
167
168         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
169         Add test case for user script message handlers.
170         (scriptMessageReceived):
171         (testUserContentManagerScriptMessageReceived):
172         (beforeAll):
173
174 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
175
176         bisect-builds should support WebKit clients other than Safari
177         https://bugs.webkit.org/show_bug.cgi?id=138225
178
179         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
180
181         The -a / --application optional argument allows the user to specify which application (or application bundle)
182         should be run against the WebKit nightly builds.
183
184         Reviewed by David Kilzer.
185
186         * Scripts/bisect-builds:
187         Swap out $safariPath for the more general $applicationPath
188         Leave --safari-path as a commandline option for backwards compatibility
189         (mountAndRunNightly):
190         Use File::Spec->cat correctly (one directory per argument)
191         Use open --wait-apps instead of running the target application directly
192
193 2014-10-30  Dana Burkart  <dburkart@apple.com>
194
195         <rdar://problem/18821260> Perpare for the mysterious future
196
197         Reviewed by Lucas Forschler.
198
199         * DumpRenderTree/mac/Configurations/Base.xcconfig:
200         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
201         * LayoutTestRelay/Configurations/Base.xcconfig:
202         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
203         * MiniBrowser/Configurations/Base.xcconfig:
204         * MiniBrowser/Configurations/DebugRelease.xcconfig:
205         * TestWebKitAPI/Configurations/Base.xcconfig:
206         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
207         * WebKitLauncher/Configurations/Base.xcconfig:
208         * WebKitTestRunner/Configurations/Base.xcconfig:
209         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
210
211 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
212
213         Update safariVersion to safariVersionString
214         https://bugs.webkit.org/show_bug.cgi?id=138193
215
216         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
217         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
218
219         Rubber-stamped by David Kilzer.
220
221         * Scripts/bisect-builds:
222         (makeNightlyList):
223         Compare safariVersionString to a string literal, instead of safariVersion.
224
225 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
226
227         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
228         https://bugs.webkit.org/show_bug.cgi?id=137775
229
230         Reviewed by Carlos Garcia Campos.
231
232         * MiniBrowser/gtk/BrowserWindow.c:
233         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
234         (browser_window_init):
235
236 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
237
238         CommitQueue and EWS should reject any patches that result in consistent test
239         failures that aren't present on the tree.
240         https://bugs.webkit.org/show_bug.cgi?id=138184
241
242         Reviewed by Alexey Proskuryakov.
243
244         * Scripts/webkitpy/layout_tests/models/test_results.py:
245         Adds a simple hashing function to allow for set operations to handle
246         TestResult objects properly.
247         (TestResult.__hash__):
248         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
249         Adds one unit test, and modifies others to agree with the notion that
250         patches that introduce new test failures (but also have flakyness)
251         should be rejected rather than spin.
252         (MockCommitQueue.report_flaky_tests):
253         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
254         (test_double_flaky_test_failure):
255         (test_two_flaky_tests):
256         (test_very_flaky_patch):
257         (test_very_flaky_patch_with_some_tree_redness):
258         (test_different_test_failures):
259         (test_different_test_failures_with_some_tree_redness):
260         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
261         (test_mildly_flaky_patch):
262         (test_mildly_flaky_patch_with_some_tree_redness):
263         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
264         Makes PatchAnalysisTask reject said patches.
265         (PatchAnalysisTask._test_patch):
266
267 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
268
269         WinCairoRequirements.zip cannot be downloaded from dropbox
270         https://bugs.webkit.org/show_bug.cgi?id=138113
271
272         Reviewed by Alexey Proskuryakov.
273
274         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
275
276 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
277
278         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
279         https://bugs.webkit.org/show_bug.cgi?id=138193
280
281         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
282         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
283
284         It also does a bit of refactoring, including distinguishing between versions and version strings and
285         saving versions to local variables instead of using eval in each conditional.
286
287         Reviewed by David Kilzer.
288
289         * Scripts/bisect-builds:
290         (makeNightlyList):
291         Restrict the set of nightlies to r174650 and above when running Yosemite.
292         Restrict the set of nightlies to r157846 and above when running Mavericks.
293         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
294
295 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
296
297         [EFL] build-webkit should try harder to avoid re-running cmake
298         https://bugs.webkit.org/show_bug.cgi?id=137949
299
300         Reviewed by Martin Robinson.
301
302         * Scripts/webkitdirs.pm:
303         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
304         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
305
306 2014-10-28  Daniel Bates  <dabates@apple.com>
307
308         Unify logic in RunTests.run() to run the Python unit tests
309         https://bugs.webkit.org/show_bug.cgi?id=138160
310
311         Reviewed by Martin Robinson.
312
313         Unify the interactive and non-interactive code path for running the Python unit tests
314         in step RunTests so as to remove duplicate code to compute the the path to the script
315         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
316
317         No new tests since no functionality was changed.
318
319         * Scripts/webkitpy/port/base.py:
320         (Port.python_unittest_results_directory):
321         * Scripts/webkitpy/tool/steps/runtests.py:
322         (RunTests.run):
323
324 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
325
326         Make runtest.py call test-webkitpy with the --json flag when in
327         non-interactive mode.
328         https://bugs.webkit.org/show_bug.cgi?id=137667
329
330         Reviewed by Daniel Bates.
331
332         * Scripts/webkitpy/port/base.py:
333         Adds the python_unittest_results_directory method.
334         (Port.python_unittest_results_directory):
335         * Scripts/webkitpy/tool/steps/runtests.py:
336         Changes RunTests to call test-webkitpy with the --json flag if the
337         --non-interactive flag is set.
338         (RunTests):
339         (RunTests.run):
340
341 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
342
343         import-w3c-tests should use re.escape() wherever it's handling file paths
344         https://bugs.webkit.org/show_bug.cgi?id=137934
345
346         This patch adds re.escape() to a few places where we're doing string
347         conversions. This prevents errors when attribute values coincidentally
348         have character sequences that can be interpreted as regular expressions.
349
350         Reviewed by Bem Jones-Bey.
351
352         * Scripts/webkitpy/w3c/test_converter.py:
353         (_W3CTestConverter.convert_attributes_if_needed):
354
355 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
356
357         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
358         https://bugs.webkit.org/show_bug.cgi?id=138130
359
360         Reviewed by Csaba Osztrogonác.
361
362         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
363
364 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
365
366         Fix link to Arch Linux Wiki
367         https://bugs.webkit.org/show_bug.cgi?id=138010
368
369         Reviewed by Benjamin Poulain.
370
371         * gtk/install-dependencies:
372
373 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
374
375         Test regressions are not detected when image result is missing
376         https://bugs.webkit.org/show_bug.cgi?id=138070
377
378         Reviewed by Simon Fraser.
379
380         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
381         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
382         Count these as regressions, not as flaky tests.
383
384         * Scripts/webkitpy/port/test.py:
385         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
386         Test it.
387
388 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
389
390         Add Conrad Shultz to the contributors list.
391
392         * Scripts/webkitpy/common/config/contributors.json:
393
394 2014-10-24  Dan Bernstein  <mitz@apple.com>
395
396         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
397         https://bugs.webkit.org/show_bug.cgi?id=138046
398
399         Reviewed by Alexey Proskuryakov.
400
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
402         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
403         401. Otherwise, we’ll retry normally in 45 seconds.
404
405 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
406
407         [GTK] Implement is_selected method on WebKitHitTestResult
408         https://bugs.webkit.org/show_bug.cgi?id=137110
409
410         Reviewed by Tim Horton.
411
412         Add tests for new context SELECTION on WebKitHitTestResult.
413
414         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
415         (testContextMenuDefaultMenu):
416         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
417         (testWebViewMouseTarget):
418
419 2014-10-23  Roger Fong  <roger_fong@apple.com>
420
421         [Win] Skip failing JSC tests following r175078
422         https://bugs.webkit.org/show_bug.cgi?id=130967.
423
424         * Scripts/run-javascriptcore-tests:
425
426 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
427
428         commitqueuetask_unittest.py should be made more concise.
429         https://bugs.webkit.org/show_bug.cgi?id=137985
430
431         Reviewed by Alexey Proskuryakov.
432
433         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
434         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
435         (MockCommitQueue.__init__):
436         (MockCommitQueue.report_flaky_tests):
437         (MockCommitQueue):
438         (MockCommitQueue.get_reported_flaky_tests):
439         (MockSimpleTestPlanCommitQueue.__init__):
440         (MockSimpleTestPlanCommitQueue.run_command):
441         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
442         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
443         (test_land_failure):
444         (test_failed_archive):
445         (test_double_flaky_test_failure):
446         (test_test_failure):
447         (test_red_test_failure):
448         (test_very_red_tree_retry):
449         (test_red_tree_patch_rejection):
450         (test_one_flaky_test):
451         (test_tree_more_red_than_patch):
452         (MockCommitQueue.test_results): Deleted.
453         (test_simple_flaky_test_failure): Deleted.
454         (_expect_validate): Deleted.
455         (_expect_validate.MockDelegate): Deleted.
456         (_expect_validate.MockDelegate.refetch_patch): Deleted.
457         (_expect_validate.MockDelegate.expected_failures): Deleted.
458         (_mock_patch): Deleted.
459         (test_validate): Deleted.
460         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
461         Fixes a bug that slipped through the cracks prior to this change.
462         (PatchAnalysisTask._test_patch):
463
464 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
465
466         Flakiness dashboard should support OS X Yosemite
467         https://bugs.webkit.org/show_bug.cgi?id=137986
468
469         Reviewed by Ryosuke Niwa.
470
471         * TestResultServer/app.yaml:
472         * TestResultServer/static-dashboards/builders.jsonp:
473         * TestResultServer/static-dashboards/flakiness_dashboard.js:
474
475 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
476
477         commitqueuetask should include more tests to ensure that the behavior
478         of PatchAnalysisTask._test_patch() is well defined
479         https://bugs.webkit.org/show_bug.cgi?id=137977
480
481         Reviewed by Alexey Proskuryakov.
482
483         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
484         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
485         and more readable to define tests that are meant to test the behaviour
486         of PatchAnalysisTask._test_patch(), and adds several unit tests.
487         (FailingTestCommitQueue.test_results):
488         (PatchAnalysisResult):
489         (MockSimpleTestPlanCommitQueue):
490         (MockSimpleTestPlanCommitQueue.__init__):
491         (MockSimpleTestPlanCommitQueue.run_command):
492         (MockSimpleTestPlanCommitQueue._mock_test_result):
493         (MockSimpleTestPlanCommitQueue.test_results):
494         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
495         (test_flaky_test_failure):
496         (test_failed_archive):
497         (test_two_flaky_tests):
498         (test_one_flaky_test):
499         (test_very_flaky_patch):
500         (test_very_flaky_patch_with_some_tree_redness):
501         (test_different_test_failures):
502         (test_different_test_failures_with_some_tree_redness):
503         (test_mildly_flaky_patch):
504         (test_mildly_flaky_patch_with_some_tree_redness):
505         (test_tree_more_red_than_patch):
506
507 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
508
509         PatchAnalysisTask._test_patch() needs refactoring
510         https://bugs.webkit.org/show_bug.cgi?id=137904
511
512         Reviewed by Alexey Proskuryakov.
513
514         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
515         Fixes several small bugs, and makes minor changes to accomodate the
516         changes in PatchAnalysisTask.
517         (MockCommitQueue.refetch_patch):
518         (MockCommitQueue.test_results):
519         (test_flaky_test_failure):
520         (test_failed_archive):
521         (test_very_red_tree_retry):
522         (_expect_validate.MockDelegate.refetch_patch):
523         (MockCommitQueue.expected_failures): Deleted.
524         (_expect_validate.MockDelegate.expected_failures): Deleted.
525         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
526         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
527         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
528         Removes the unexpected_failures member, adds the _clean_tree_results
529         member, adds a helper function for _test_patch, and refactors
530         _test_patch to be more readable.
531         (PatchAnalysisTask.__init__):
532         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
533         (PatchAnalysisTask._test_patch):
534         (PatchAnalysisTask.results_from_test_run_without_patch):
535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
536         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
537         (AbstractEarlyWarningSystem.begin_work_queue):
538         (AbstractEarlyWarningSystem._failing_tests_message):
539         (AbstractEarlyWarningSystem.command_failed):
540         (AbstractEarlyWarningSystem.expected_failures): Deleted.
541         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
542         Makes changes to accomodate the changes made to PatchAnalysisTask.
543         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
544         * Scripts/webkitpy/tool/commands/perfalizer.py:
545         Removes Perfalizer's dependancy on ExpectedFailures. 
546         (PerfalizerTask.refetch_patch):
547         (PerfalizerTask.expected_failures): Deleted.
548         * Scripts/webkitpy/tool/commands/queues.py:
549         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
550         initializer to allow for mock injection.
551         (CommitQueue.__init__):
552         (CommitQueue.begin_work_queue):
553         (CommitQueue.process_work_item):
554         (CommitQueue._failing_tests_message):
555         * Scripts/webkitpy/tool/commands/queues_unittest.py:
556         Removes dependancy on ExpectedFailures, and instead uses mock
557         injection.
558         (MockCommitQueueTask):
559         (MockCommitQueueTask.results_from_patch_test_run):
560         (MockCommitQueueTask.results_from_test_run_without_patch):
561         (mock_run_webkit_patch):
562
563 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
564
565         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
566         https://bugs.webkit.org/show_bug.cgi?id=136736
567
568         Reviewed by Gyuyoung Kim.
569
570         * MiniBrowser/efl/main.c:
571         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
572         (window_create):
573
574 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
575
576         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
577         https://bugs.webkit.org/show_bug.cgi?id=137884
578
579         Reviewed by Gustavo Noronha Silva.
580
581         Move InputMethodFilter test from WebCore tests to WebKit2 tests
582         and adapt it to use the new InputMethodFilter WebKit class. Instead
583         of having virtual methods just for testing, it has a testing mode
584         that logs the events.
585
586         * TestWebKitAPI/PlatformGTK.cmake:
587         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
588         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
589         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
590         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
591         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
592         (TestWebKitAPI::TEST):
593         (TestWebKitAPI::temporaryGetPreeditStringOverride):
594         (TestWebKitAPI::temporaryResetOverride):
595         (TestWebKitAPI::verifyCanceledComposition):
596
597 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
598
599         build.webkit.org/dashboard: Cannot click on green tester bubbles
600         https://bugs.webkit.org/show_bug.cgi?id=137909
601
602         Reviewed by Darin Adler.
603
604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
605         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
606
607 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
608
609         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
610         https://bugs.webkit.org/show_bug.cgi?id=137932
611
612         Reviewed by Simon Fraser.
613
614         This is the first step in moving over to native Windows rendering for our layout tests.
615         Once this change lands, approximately 300 tests will start failing on Windows. I will
616         rebaseline these changes against our test hardware and update this bug with the
617         commits related to that work.
618
619         * DumpRenderTree/win/DumpRenderTree.cpp:
620         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
621         we use native Windows drawing style.
622
623 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
624
625         Fix FTL Native Inlining for EFL
626         https://bugs.webkit.org/show_bug.cgi?id=137774
627
628         Reviewed by Michael Saboff.
629
630         Added Clang as an optional module to jhbuild.
631
632         * efl/jhbuild.modules:
633
634 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
635
636         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
637         https://bugs.webkit.org/show_bug.cgi?id=137832
638
639         Reviewed by Carlos Garcia Campos.
640
641         Ensure each test sets the TLS errors policy that it really needs.
642         Have each test except testTLSErrorsPolicy stash and restore the original
643         TLS errors policy. Update testTLSErrorsPolicy to account for the new
644         default policy.
645
646         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
647         (testSSL):
648         (testInsecureContent):
649         (testTLSErrorsPolicy):
650         (testTLSErrorsRedirect):
651         (testTLSErrorsHTTPAuth):
652         (testLoadFailedWithTLSErrors):
653         (beforeAll):
654
655 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
656
657         Unreviewed. Unskip inspector server unit tests.
658
659         They should pass now.
660
661         * Scripts/run-gtk-tests:
662         (TestRunner):
663
664 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
665
666         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
667         https://bugs.webkit.org/show_bug.cgi?id=132044
668
669         Reviewed by Brian Burg.
670
671         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
672         (openRemoteDebuggingSession): Remove trailing slash when
673         concatenating base inspector URL with the page, because the
674         inspector returns the relative paths with a leading slash.
675
676 2014-10-20  Tanay C  <tanay.c@samsung.com>
677
678         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
679         https://bugs.webkit.org/show_bug.cgi?id=137023
680
681         Reviewed by Gyuyoung Kim.
682
683         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
684         (search_box_show): Modified.
685         (search_box_hide): Modified.
686         (on_search_field_activated): Modified.
687         (on_search_backward_button_clicked): Modified.
688         (on_search_forward_button_clicked): Modified.
689         (on_search_case_option_changed): Added.
690         (on_search_word_start_option_changed): Added.
691         (window_create): Modified.
692
693 2014-10-20  Tanay C  <tanay.c@samsung.com>
694
695         [GTK][Minibrowser] Escape key does not hide the search box
696         https://bugs.webkit.org/show_bug.cgi?id=137734
697
698         Reviewed by Philippe Normand.
699
700         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
701         (stopPageLoad): Modified.
702
703 2014-10-18  Antti Koivisto  <antti@apple.com>
704
705         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
706         https://bugs.webkit.org/show_bug.cgi?id=137855
707
708         Reviewed by Dan Bernstein.
709
710         Test and warn if the dumped response mime type differs from the platform response mime type.
711
712         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
713         (WTR::InjectedBundlePage::didReceiveResponseForResource):
714         (WTR::InjectedBundlePage::platformResponseMimeType):
715         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
716         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
717         (WTR::InjectedBundlePage::platformResponseMimeType):
718
719 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
720
721         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
722         https://bugs.webkit.org/show_bug.cgi?id=137835
723
724         Reviewed by Andreas Kling.
725
726         * Scripts/run-inspector-perf-tests.py: Removed.
727         This script is stale, as PerformanceTests/inspector no longer exists.
728
729 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
730
731         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
732
733         * Scripts/webkitpy/port/ios.py:
734         (IOSSimulatorPort.default_baseline_search_path):
735
736 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
737
738         [iOS] Simplify test fallback paths for iOS Simulator testing
739         https://bugs.webkit.org/show_bug.cgi?id=137830
740
741         Reviewed by Zalan Bujtas.
742         
743         Make the fallback paths be:
744             ios-simulator -> generic
745             ios-simulator-wk2->ios-simulator -> generic
746         
747         so don't include mac in the fallback path. Also remove the
748         version handling for simplicity.
749
750         * Scripts/webkitpy/port/ios.py:
751         (IOSSimulatorPort):
752         (IOSSimulatorPort.default_baseline_search_path):
753
754 2014-10-17  Dana Burkart  <dburkart@apple.com>
755
756         Fix typos in the dashboard config file.
757
758         Unreviewed.
759
760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
761         (WebKitBuildbot):
762
763 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
764
765         [Win] Allow WinLauncher to specify Custom User Agent strings
766         https://bugs.webkit.org/show_bug.cgi?id=137828
767
768         Reviewed by Dean Jackson.
769
770         * WinLauncher/Common.cpp: Add support for custom user agent strings.
771         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
772         and set the user agent strings.
773         * WinLauncher/WinLauncher.h:
774         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
775         resources and dialog for setting custom User Agent strings.
776         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
777
778 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
779
780         [iOS] Turn off font autosizing for iOS WebKitTestRunner
781         https://bugs.webkit.org/show_bug.cgi?id=137806
782
783         Reviewed by Sam Weinig.
784
785         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
786         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
787         to disable font autosizing.
788         
789         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
790         test controller to set platform-specific prefs.
791
792         * WebKitTestRunner/TestController.cpp:
793         (WTR::TestController::resetPreferencesToConsistentValues):
794         (WTR::TestController::platformResetPreferencesToConsistentValues):
795         * WebKitTestRunner/TestController.h:
796         * WebKitTestRunner/ios/TestControllerIOS.mm:
797         (WTR::TestController::platformResetPreferencesToConsistentValues):
798         * WebKitTestRunner/mac/TestControllerMac.mm:
799         (WTR::TestController::platformResetPreferencesToConsistentValues):
800
801 2014-10-16  Dan Bernstein  <mitz@apple.com>
802
803         OSObjectPtr is missing leakRef()
804         https://bugs.webkit.org/show_bug.cgi?id=137798
805
806         Reviewed by Sam Weinig.
807
808         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
809         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
810
811 2014-10-16  Lucas Forschler  <lforschler@apple.com>
812
813         Update target platform to remove Leopard, Snow Leopard, Lion.
814         Add Yosemite. 
815         
816         Unreviewed.
817
818         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
819         (_should_file_trigger_build):
820
821 2014-10-16  David Kilzer  <ddkilzer@apple.com>
822
823         commit-queue: fails to replace OO-PS! with reviewer name
824         <http://webkit.org/b/137795>
825
826         Reviewed by Alexey Proskuryakov.
827
828         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
829         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
830         email addresses to unauthenticated page loads, so we must always
831         authenticate before getting bug data so we get full email
832         addresses.
833
834 2014-10-16  David Kilzer  <ddkilzer@apple.com>
835
836         commit-queue: fails to close bugs after successfully landing patches
837         <http://webkit.org/b/137794>
838
839         Reviewed by Alexey Proskuryakov.
840
841         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
842         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
843         tell Mechanize to use the second <textarea> on the page with
844         name="comment".
845
846 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
847
848         [Win] Update DRT to match Mac Logic
849         https://bugs.webkit.org/show_bug.cgi?id=137787
850
851         Reviewed by Dean Jackson.
852
853         * DumpRenderTree/win/DumpRenderTree.cpp:
854         (initialize): 0 -> nullptr
855         (runTest): Initialize MSG structure before using.
856         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
857         Also, cleanly shut down COM when exiting.
858         * DumpRenderTree/win/FrameLoadDelegate.cpp:
859         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
860         header and add printf to match Mac.
861         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
862         * DumpRenderTree/win/FrameLoadDelegate.h:
863         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
864         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
865         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
866         (isLocalhost): Added.
867         (hostIsUsedBySomeTestsToGenerateError): Added.
868         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
869         of certain error and redirect host names.
870         * DumpRenderTree/win/UIDelegate.cpp:
871         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
872         anything should be output to the console. This modifies behavior to match the Mac.
873         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
874         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
875         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
876         (UIDelegate::webViewAddMessageToConsole): Ditto.
877         * WinLauncher/PageLoadTestClient.cpp:
878         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
879         added last week.
880
881 2014-10-16  Commit Queue  <commit-queue@webkit.org>
882
883         Unreviewed, rolling out r174754.
884         https://bugs.webkit.org/show_bug.cgi?id=137789
885
886         Speculative fix for Windows test was ineffective. (Requested
887         by rfong on #webkit).
888
889         Reverted changeset:
890
891         "[Windows] Add some more logging to debug Windows test
892         issues."
893         http://trac.webkit.org/changeset/174754
894
895 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
896
897         Unreviewed, add myself to CoordinatedGraphics watchers.
898
899         * Scripts/webkitpy/common/config/watchlist:
900
901 2014-10-15  Roger Fong  <roger_fong@apple.com>
902
903         [Windows] Speculative Windows test fix.
904
905         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
906
907 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
908
909         import-w3c-test rewrites relative src paths in ref files incorrectly
910         https://bugs.webkit.org/show_bug.cgi?id=137586
911
912         This patch fixes a bug in test_converter.py where src paths were getting 
913         rewritten as ../../some-path instead of <script src="../../some-path>". 
914         It also adds support for rewriting src paths in style  elements, which was 
915         missing before and it adds tests for this case.
916
917         Reviewed by Bem Jones-Bey.
918
919         * Scripts/webkitpy/w3c/test_converter.py:
920         (_W3CTestConverter.convert_attributes_if_needed):
921         * Scripts/webkitpy/w3c/test_converter_unittest.py:
922         (test_convert_attributes_if_needed):
923         (verify_reference_relative_paths):
924
925 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
926
927         Add --json flag to test-webkitpy to emit JSON formatted test results
928         to stdout
929         https://bugs.webkit.org/show_bug.cgi?id=137353
930
931         Reviewed by Daniel Bates.
932
933         * Scripts/webkitpy/port/server_process_unittest.py:
934         Adds the read method to MockFile to allow the stdout of test_webkitpy
935         to be redirected without causing erroneous test failures.
936         In particular,
937         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
938         and
939         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
940         because when redirecting to a file, the
941         _wait_for_data_and_update_buffers_using_select method in 
942         server_process.py will find that there is a read file descriptor in
943         its call to select.select, which eventually leads to it calling read()
944         on the MockFile object.
945         (MockFile.read):
946         * Scripts/webkitpy/test/main.py:
947         Adds the _print_results_as_json method and the --json flag which
948         determines whether _print_results_as_json will get called.
949         (Tester._parse_args):
950         (Tester._print_results_as_json):
951         (Tester._print_results_as_json.result_dict_from_tuple):
952         (Tester._run_tests):
953
954 2014-10-13  David Farler  <dfarler@apple.com>
955
956         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
957         https://bugs.webkit.org/show_bug.cgi?id=137662
958
959         Reviewed by Darin Adler.
960
961         The layout test harness can close LayoutTestRelay's subprocess
962         stdout and stderr in the case of a timeout or if a run is
963         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
964         finds that no one is listening to its stdout/stderr (broken
965         pipe), then just exit(1), there is nothing to report.
966
967         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
968         (-[LTRelayController didReceiveStdoutData:]):
969         Add @try/@catch for NSFileHandleOperationException.
970         (-[LTRelayController didReceiveStderrData:]):
971         Add @try/@catch for NSFileHandleOperationException.
972
973 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
974
975         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
976         https://bugs.webkit.org/show_bug.cgi?id=137060
977
978         Reviewed by Philippe Normand.
979
980         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
981
982         * MiniBrowser/gtk/BrowserWindow.c:
983         (zoomInCallback):
984         (zoomOutCallback):
985         (defaultZoomCallback): Callback for default zoom keyboard support.
986         (browser_window_init):
987
988 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
989
990         [Mac] DRT stderr logging after the test completes gets attributed to the next test
991
992         Reviewed by Alexey Proskuryakov.
993         
994         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
995         logging to stderr to get associated with the next test.
996         
997         Fix by logging #EOF to stderr later, after we've completely finished with this test.
998
999         * DumpRenderTree/mac/DumpRenderTree.mm:
1000         (dumpTestResults):
1001         (runTest):
1002
1003 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
1004
1005         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
1006
1007         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
1008
1009 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1010
1011         [cmake] Fix the make build after r174683
1012         https://bugs.webkit.org/show_bug.cgi?id=137703
1013
1014         Reviewed by Martin Robinson.
1015
1016         * Scripts/webkitdirs.pm:
1017         (buildCMakeGeneratedProject):
1018
1019 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1020
1021         Adding myself to the watchlist to CachedFont
1022
1023         Unreviewed.
1024
1025         * Scripts/webkitpy/common/config/watchlist:
1026
1027 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1028
1029         [EFL][GTK] Make it possible to get verbose output with ninja
1030         https://bugs.webkit.org/show_bug.cgi?id=137606
1031
1032         Reviewed by Csaba Osztrogonác.
1033
1034         * Scripts/webkitdirs.pm:
1035         (buildCMakeGeneratedProject):
1036
1037 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1038
1039         [EFL] Make it possible to use ninja for EFL build too
1040         https://bugs.webkit.org/show_bug.cgi?id=137605
1041
1042         Reviewed by Csaba Osztrogonác.
1043
1044         * Scripts/webkitdirs.pm:
1045         (generateBuildSystemFromCMakeProject):
1046         * efl/install-dependencies:
1047
1048 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
1049
1050         [GTK] Minibrowser : Add home buton and keyboard support for home page load
1051         https://bugs.webkit.org/show_bug.cgi?id=137486
1052
1053         Reviewed by Philippe Normand.
1054
1055         * MiniBrowser/gtk/BrowserWindow.c:
1056         (loadHomePage): Callback for home page load.
1057         (browser_window_init):
1058         * MiniBrowser/gtk/BrowserWindow.h:
1059         * MiniBrowser/gtk/main.c:
1060         (main):
1061
1062 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
1063
1064         import-w3c-tests doesn't prefix property values
1065         https://bugs.webkit.org/show_bug.cgi?id=137600
1066
1067         Reviewed by Bem Jones-Bey.
1068
1069         Some property values are prefixed in WebKit. Modified the W3C import
1070         script in order to prefix property values and not only properties.
1071         The patch re-uses most of the already existent logic to prefix
1072         properties.
1073
1074         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
1075         from CSSValueKeywords.in and adapt converter to modify both properties
1076         and property values.
1077         (convert_for_webkit):
1078         (_W3CTestConverter.__init__):
1079         (_W3CTestConverter.output):
1080         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1081         (_W3CTestConverter):
1082         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
1083         (_W3CTestConverter.add_webkit_prefix_following_regex):
1084         (_W3CTestConverter.convert_reference_relpaths):
1085         (_W3CTestConverter.convert_style_data):
1086         (_W3CTestConverter.convert_attributes_if_needed):
1087         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
1088         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
1089         include checks for property values too.
1090         (W3CTestConverterTest.test_read_prefixed_property_list):
1091         (verify_no_conversion_happened):
1092         (verify_prefixed_properties):
1093         (verify_prefixed_property_values):
1094         (generate_test_content_properties_and_values):
1095         (generate_test_content):
1096         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
1097         prefixed property values and inform about them.
1098         (TestImporter.import_tests):
1099         (TestImporter.write_import_log):
1100
1101 2014-10-13  Jer Noble  <jer.noble@apple.com>
1102
1103         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1104         https://bugs.webkit.org/show_bug.cgi?id=137533
1105
1106         Reviewed by Andy Estes.
1107
1108         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
1109
1110         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1111         (TestWebKitAPI::isMSEEnabledCallback):
1112         (TestWebKitAPI::TEST):
1113
1114 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
1115
1116         [Win] Implement a page load profiling tool
1117         https://bugs.webkit.org/show_bug.cgi?id=137673
1118
1119         Reviewed by Dean Jackson.
1120
1121         Add a tool to capture and summarize page load statistics.
1122
1123         * WinLauncher/Common.cpp:
1124         (parseCommandLine): Move from WinMain.cpp so that it can
1125         be shared with internal tools.
1126         * WinLauncher/PageLoadTestClient.cpp: Added.
1127         (PageLoadTestClient::PageLoadTestClient):
1128         (PageLoadTestClient::pageLoadStartedAtTime):
1129         (PageLoadTestClient::didStartProvisionalLoad):
1130         (PageLoadTestClient::didCommitLoad):
1131         (PageLoadTestClient::didFirstLayoutForMainFrame):
1132         (PageLoadTestClient::didHandleOnLoadEvents):
1133         (PageLoadTestClient::didFinishLoad):
1134         (PageLoadTestClient::didFailLoad):
1135         (PageLoadTestClient::didInitiateResourceLoad):
1136         (PageLoadTestClient::didEndResourceLoad):
1137         (PageLoadTestClient::pageLoadEndedAtTime):
1138         (PageLoadTestClient::endPageLoad):
1139         (PageLoadTestClient::clearPageLoadState):
1140         (PageLoadTestClient::shouldConsiderPageLoadEnded):
1141         (PageLoadTestClient::maybeEndPageLoadSoon):
1142         (PageLoadTestClient::setPageURL):
1143         (PageLoadTestClient::dumpRunStatistics):
1144         * WinLauncher/PrintWebUIDelegate.cpp:
1145         (PrintWebUIDelegate::createWebViewWithRequest): Handle
1146         nullptr URL properly.
1147         * WinLauncher/ResourceLoadDelegate.cpp: Added.
1148         (ResourceLoadDelegate::QueryInterface):
1149         (ResourceLoadDelegate::AddRef):
1150         (ResourceLoadDelegate::Release):
1151         (ResourceLoadDelegate::identifierForInitialRequest):
1152         (ResourceLoadDelegate::willSendRequest):
1153         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1154         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
1155         (ResourceLoadDelegate::didReceiveResponse):
1156         (ResourceLoadDelegate::didReceiveContentLength):
1157         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1158         (ResourceLoadDelegate::didFailLoadingWithError):
1159         (ResourceLoadDelegate::plugInFailedWithError):
1160         * WinLauncher/ResourceLoadDelegate.h: Added.
1161         (ResourceLoadDelegate::ResourceLoadDelegate):
1162         * WinLauncher/WinLauncher.cpp:
1163         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
1164         page loading statistics.
1165         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
1166         and set private load delegate state.
1167         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
1168         that sets the view's resource load delegate.
1169         (WinLauncher::loadURL): If no URL is passed, load the test document.
1170         * WinLauncher/WinLauncher.h:
1171         (WinLauncher::pageLoadTestClient):
1172         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
1173         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
1174         * WinLauncher/WinLauncherWebHost.cpp:
1175         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
1176         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
1177         it could be used from other source files.
1178         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
1179         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
1180         (WinLauncherWebHost::didFailLoadWithError): Ditto.
1181         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
1182         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
1183         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
1184         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1185         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1186         * WinLauncher/WinLauncherWebHost.h:
1187         * WinLauncher/WinMain.cpp:
1188         (wWinMain): Create and use new delegates for gathering page load data.
1189         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
1190
1191 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1192
1193         Improve the test image diffs page
1194         https://bugs.webkit.org/show_bug.cgi?id=137674
1195
1196         Reviewed by Alexey Proskuryakov.
1197         
1198         Don't treat the input file as a format string, otherwise we have to escape special
1199         characters. Just do a couple of replaces.
1200
1201         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1202         (TestResultWriter.write_image_diff_files):
1203
1204 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1205
1206         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
1207         https://bugs.webkit.org/show_bug.cgi?id=137659
1208
1209         Reviewed by Martin Robinson.
1210
1211         * Scripts/webkitpy/port/xvfbdriver.py:
1212         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
1213
1214 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
1215
1216         Add more detailed wait time information to EWS metrics
1217         https://bugs.webkit.org/show_bug.cgi?id=137649
1218
1219         Reviewed by Daniel Bates.
1220
1221         Added average and worst time (we used to only have median), and also a percentage
1222         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
1223
1224         There is always some wait due to the polling nature of the queues, which is well understood
1225         and doesn't need to be measured. What needs to be measured is whether there is enough
1226         bot machines to process patches as soon as they are submitted.
1227
1228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1229         (Analyzer.prototype._analyzeBubblePerformance):
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1231         (MetricsBubbleView.prototype._update):
1232
1233 2014-10-11  Jer Noble  <jer.noble@apple.com>
1234
1235         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1236         https://bugs.webkit.org/show_bug.cgi?id=137533
1237
1238         Reviewed by Darin Adler.
1239
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1242         (TestWebKitAPI::TEST):
1243         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
1244         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
1245
1246 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1247
1248         iOS DRT snapshots are limited to the page visible area
1249         https://bugs.webkit.org/show_bug.cgi?id=137650
1250
1251         Reviewed by Daniel Bates.
1252         
1253         LegacyTileCache drawing was limited to the window's visible area, found by
1254         crawling up the layer hierarchy to the root layer. This caused test snapshots to
1255         be missing non-composited content outside the iPhone visible area, which hinders
1256         testing.
1257         
1258         Fix by adding a test-only mode where the window visible area is the entire window.
1259         
1260         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1261         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
1262         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1263         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
1264         for the DRT window.
1265         
1266
1267 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
1268
1269         Page not fully rendered in iOS DRT snapshots
1270         https://bugs.webkit.org/show_bug.cgi?id=137638
1271
1272         Reviewed by Tim Horton.
1273         
1274         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
1275         to ensure that the page has laid out and is rendered by the time we take
1276         the snapshot.
1277
1278         * DumpRenderTree/mac/DumpRenderTree.mm:
1279         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
1280         (-[DumpRenderTree _webThreadInvoked]): Moved.
1281         (-[DumpRenderTree _waitForWebThreadThenDump]):
1282         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
1283         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
1284         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
1285         relies on dispatch_async too, and the inner block won't complete until the outer block
1286         has completed.
1287         (dumpTestResults): Move the guts of dump() here.
1288         (runTest): Whitespace.
1289
1290 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
1291
1292         Adding svn:ignore so that .pyc files don't show up as new.
1293
1294         * Scripts/webkitpy/xcode: Added property svn:ignore.
1295
1296 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
1297
1298         [EFL] Introduce EWebKit_Extension
1299         https://bugs.webkit.org/show_bug.cgi?id=134921
1300
1301         Reviewed by Gyuyoung Kim.
1302
1303         * MiniBrowser/efl/main.c: Added x option to test extension path.
1304         (window_create):
1305         (elm_main):
1306         * Scripts/webkitpy/common/config/watchlist:
1307         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1308         * Scripts/webkitpy/style/checker.py:
1309         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1310
1311 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
1312
1313         After r174628 we send the test process a SIGTERM before the SIGKILL.
1314
1315         * Scripts/webkitpy/common/system/executive_unittest.py:
1316         (ExecutiveTest.serial_test_kill_process):
1317
1318 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
1319
1320         [EFL] Enable WebP support.
1321         https://bugs.webkit.org/show_bug.cgi?id=136156
1322
1323         Reviewed by Gyuyoung Kim.
1324
1325         Include libwebp-dev package to support WebP for WK2 Efl.
1326
1327         * efl/install-dependencies:
1328
1329 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1330
1331         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
1332         https://bugs.webkit.org/show_bug.cgi?id=137485
1333
1334         Reviewed by Sergio Villar Senin.
1335
1336         Update GMainLoopSource tests. Most of the tests are now run twice,
1337         first with a GMainLoopSource and then with a
1338         GThreadSafeMainLoopSource, since both should have the same
1339         behaviour. The threading test uses GThreadSafeMainLoopSource and
1340         the delete on destroy test uses GMainLoopSource. The tests
1341         themselves haven't changed, since there's no change in behaviour.
1342
1343         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1344         (TestWebKitAPI::GMainLoopSourceTest::source):
1345         (TestWebKitAPI::basicRescheduling):
1346         (TestWebKitAPI::TEST):
1347         (TestWebKitAPI::reentrantRescheduling):
1348         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1349         (TestWebKitAPI::basicDestroyCallbacks):
1350         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1351         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1352
1353 2014-10-10  Dana Burkart  <dburkart@apple.com>
1354
1355         Fix fat-fingered function name in git-add-reviewer.
1356
1357         Unreviewed.
1358
1359         * Scripts/git-add-reviewer:
1360         (getConfigValue):
1361
1362 2014-10-10  David Farler  <dfarler@apple.com>
1363
1364         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
1365         https://bugs.webkit.org/show_bug.cgi?id=137528
1366
1367         Reviewed by Simon Fraser.
1368
1369         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
1370         and SIGKILL the paired simulator app before exiting cleanly.
1371
1372         webkitpy only uses SIGKILL to kill processes which you cannot
1373         catch. Send SIGTERM to the process and give it chance to do
1374         its thing before sending SIGKILL. Sending a SIGKILL to an already
1375         dead PID is safe.
1376
1377         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1378         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1379         (-[LTRelayController finish]):
1380         * LayoutTestRelay/LayoutTestRelay/main.m:
1381         (receivedSignal):
1382         (main):
1383
1384 2014-10-10  David Farler  <dfarler@apple.com>
1385
1386         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1387         https://bugs.webkit.org/show_bug.cgi?id=137527
1388
1389         Reviewed by Simon Fraser.
1390
1391         NSFileHandle doesn't notify of EOF in its readability handler.
1392         Use a dispatch_source_t and an event handler that is called when reading is possible.
1393         In the handler block, do a run-of-the-mill read(2) from standard input and
1394         detect EOF in the usual way by checking that zero bytes were read.
1395
1396         Once an EOF is received, the FIFOs are disconnected, the simulator app
1397         is killed, and the relay exits with status 0.
1398
1399         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1400         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1401         (-[LTRelayController didDisconnect]):
1402         (-[LTRelayController didConnect]):
1403         (-[LTRelayController launchApp]):
1404         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1405         confusion with this new dispatch source, called "standardInputDispatchSource".
1406         (-[LTRelayController finish]): Added.
1407         (-[LTRelayController readFileHandle:]): Deleted.
1408
1409 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1410
1411         [EFL] Crash on facebook.com
1412         https://bugs.webkit.org/show_bug.cgi?id=137562
1413
1414         Reviewed by Chris Dumez.
1415
1416         Crash occurs on the facebook.com when the webview is resized
1417         after the <select> item is clicked but no item is chosen.
1418         This crash is just caused by the reference of invalidated variable.
1419         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1420         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1421         on MiniBrowser is called.
1422         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1423
1424         * MiniBrowser/efl/main.c:
1425         (on_popup_menu_hide):
1426
1427 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1428
1429         A small wording change for clarity.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1432         (MetricsBubbleView.prototype._update):
1433
1434 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1435
1436         Dashboard metrics page should have EWS statistics
1437         https://bugs.webkit.org/show_bug.cgi?id=137626
1438
1439         Reviewed by Ryosuke Niwa.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1442         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1445         (BubbleQueueServer): Re-ordered queues to match bubble order.
1446         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1447         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1448
1449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1450         Added analysis for bubble queues.
1451
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1455         (buildBubbleQueuesTable): Build the UI.
1456
1457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1458         Added JS sources to load.
1459
1460         * QueueStatusServer/app.yaml: To update app version.
1461
1462         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1463
1464         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1465
1466 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1467
1468         REGRESSION: Commit queue doesn't process rollouts
1469         https://bugs.webkit.org/show_bug.cgi?id=137623
1470
1471         Reviewed by Tim Horton.
1472
1473         * QueueStatusServer/app.yaml:
1474         * QueueStatusServer/handlers/updateworkitems.py:
1475         (UpdateWorkItems._work_items_from_request):
1476
1477 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
1478
1479         Fix syntax error after r174601.
1480
1481         * Scripts/run-javascriptcore-tests:
1482
1483 2014-10-10  Michael Saboff  <msaboff@apple.com>
1484
1485         Add ability to select tarfile name in run-jsc-stress-tests
1486         https://bugs.webkit.org/show_bug.cgi?id=137614
1487
1488         Reviewed by Mark Hahnenberg.
1489
1490         Added optional file name argument to the --tarball option.  
1491
1492         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
1493         extra test given after the options wont be used for the optional tarball file name.
1494         * Scripts/run-jsc-stress-tests:
1495
1496 2014-10-10  Chris Dumez  <cdumez@apple.com>
1497
1498         Unreviewed, update my information in contributors.json
1499
1500         Use my preferred first name and update my expertise areas.
1501
1502         * Scripts/webkitpy/common/config/contributors.json:
1503
1504 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
1505
1506         Fix perl scripts to run with env on Linux
1507         https://bugs.webkit.org/show_bug.cgi?id=137601
1508
1509         Reviewed by Csaba Osztrogonác.
1510
1511         Use of arguments in #! is nonstandard and does not behave the same on
1512         different systems. Linux would look for an executable named "perl -w" 
1513         "use warnings;" does the same things in a more portable way.
1514
1515         * Scripts/commit-log-editor:
1516         * Scripts/num-cpus:
1517         * Scripts/prepare-ChangeLog:
1518         * Scripts/run-launcher:
1519         * Scripts/svn-create-patch:
1520
1521 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1522
1523         [jhbuild] We should be able to disable wiping on configuration change
1524         https://bugs.webkit.org/show_bug.cgi?id=137446
1525
1526         Reviewed by Csaba Osztrogonác.
1527
1528         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
1529         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
1530         or passing --no-wipe-on-change command line option.
1531
1532         * Scripts/update-webkit-libs-jhbuild:
1533
1534 2014-10-09  Andy Estes  <aestes@apple.com>
1535
1536         Teach webkitpy about OS X Yosemite
1537         https://bugs.webkit.org/show_bug.cgi?id=137585
1538
1539         Reviewed by Simon Fraser.
1540
1541         * Scripts/webkitpy/common/system/platforminfo.py:
1542         (PlatformInfo._determine_mac_version):
1543         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1544         (TestPlatformInfo.test_os_version):
1545         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1546         (TestExpectationParser):
1547         * Scripts/webkitpy/port/builders.py:
1548         * Scripts/webkitpy/port/mac.py:
1549         (MacPort):
1550         * Scripts/webkitpy/port/mac_unittest.py:
1551         (test_versions):
1552         (test_baseline_search_path):
1553         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1554         (TestRebaselineTest.test_baseline_directory):
1555         (TestRebaselineExpectations.test_rebaseline_expectations):
1556
1557 2014-10-09  Dana Burkart  <dburkart@apple.com>
1558
1559         Add Mac OS Yosemite dashboard support.
1560
1561         Rubber-stamped by Lucas Forschler.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1568
1569 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
1570
1571         Add Babak to contributors.json and add historical email addresses for some contributors
1572         https://bugs.webkit.org/show_bug.cgi?id=137546
1573
1574         Reviewed by Christophe Dumez.
1575
1576         contributors.json is used to analyze historical commit data and change logs.
1577
1578         Add back historical email addresses for some contributors and also add Babak (Shafiei).
1579
1580         * Scripts/webkitpy/common/config/contributors.json:
1581
1582 2014-10-09  Lucas Forschler  <lforschler@apple.com>
1583
1584         Add Mac OS Yosemite webkit build infrastructure.
1585         
1586         This patch adds 15 bots to our build.webkit.org configuration.
1587         We are matching the current Mavericks machines 1:1.
1588         
1589         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
1590         
1591         Reviewed by Matt Hanson.
1592
1593         * BuildSlaveSupport/build.webkit.org-config/config.json:
1594
1595 2014-10-09  Dana Burkart  <dburkart@apple.com>
1596
1597         Don't use backticks when running commands, as we run into sh-related
1598         interpolation issues. Also, fix our usage of system() to properly
1599         retrieve the status code.
1600         https://bugs.webkit.org/show_bug.cgi?id=137541
1601
1602         Reviewed by Darin Adler.
1603
1604         * Scripts/git-add-reviewer:
1605         (interactive):
1606         (nonInteractive):
1607         (requireCleanWorkTree):
1608         (cherryPick):
1609         (commit):
1610         (addReviewerToFile):
1611         (head):
1612         (isAncestor):
1613         (toCommit):
1614         (changeLogsForCommit):
1615         (resetToCommit):
1616         (getConfigValue):
1617         (runCommandWithOutput):
1618
1619 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1620
1621         Add a WebKit1 preference for selection services
1622         https://bugs.webkit.org/show_bug.cgi?id=137498
1623         <rdar://problem/18572699>
1624
1625         Reviewed by Simon Fraser.
1626
1627         * MiniBrowser/mac/WK1BrowserWindowController.m:
1628         (-[WK1BrowserWindowController awakeFromNib]):
1629         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1630
1631 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1632
1633         Get the patch scripts running on Haiku
1634         https://bugs.webkit.org/show_bug.cgi?id=137559
1635
1636         Reviewed by Benjamin Poulain.
1637
1638         Use /usr/bin/env instead of hardcoding path to perl.
1639         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1640         failure.
1641
1642         * Scripts/commit-log-editor:
1643         * Scripts/num-cpus:
1644         * Scripts/prepare-ChangeLog:
1645         * Scripts/run-launcher:
1646         * Scripts/svn-create-patch:
1647         * Scripts/webkitpy/common/system/platforminfo.py:
1648         (PlatformInfo._determine_os_name):
1649
1650 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1651
1652         StyleQueue should throw a PatchIsNotValid exception to achieve
1653         consistency with CommitQueue and EWS
1654         https://bugs.webkit.org/show_bug.cgi?id=137500
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1659         Adds a call to validate() in run().
1660         (StyleQueueTask.run):
1661         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1662         Adds a return False in the patch is not valid exception statement.
1663         (AbstractEarlyWarningSystem.review_patch):
1664         * Scripts/webkitpy/tool/commands/queues.py:
1665         Adds a return False in the patch is not valid exception statement in
1666         commit queue, and adds an except statement to catch PatchIsNotValid
1667         exceptions in style queue.
1668         (CommitQueue.process_work_item):
1669         (StyleQueue.review_patch):
1670
1671 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1672
1673         Race condition with WebKitWebView:is-loading after starting page load
1674         https://bugs.webkit.org/show_bug.cgi?id=136692
1675
1676         Reviewed by Gustavo Noronha Silva.
1677
1678         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1679         (loadChangedCallback): Only check is-loading is false when load
1680         has finished if the load didn't fail due to a cancellation.
1681         (loadFailedCallback): Only check is-loading is false if the load
1682         didn't fail due to a cancellation.
1683         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1684         (WebViewTest::loadURI): Check is-loading is true and active URI is
1685         the requested one rigth after requesting the load.
1686         (WebViewTest::loadHtml): Ditto.
1687         (WebViewTest::loadPlainText): Ditto.
1688         (WebViewTest::loadBytes): Ditto.
1689         (WebViewTest::loadRequest): Ditto.
1690         (WebViewTest::loadAlternateHTML): Ditto.
1691         (WebViewTest::goBack): Ditto.
1692         (WebViewTest::goForward): Ditto.
1693         (WebViewTest::goToBackForwardListItem): Ditto.
1694
1695 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1696
1697         [Win] Resolve various static analyzer warnings in Tools.
1698         https://bugs.webkit.org/show_bug.cgi?id=137534
1699
1700         Reviewed by Dean Jackson.
1701
1702         * DumpRenderTree/cg/ImageDiffCG.cpp:
1703         (main): User proper printf specifiers.
1704         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1705         (AccessibilityUIElement::childrenCount): Handle possibility that
1706         gcc_accChildCount returns with an error.
1707         (accessibilityState): Ditto for gcc_accState.
1708         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1709         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1710         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1711         be treated as such.
1712         * DumpRenderTree/win/DumpRenderTree.cpp:
1713         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1714         by comparing an unsigned value as being greater-than zero.
1715         * DumpRenderTree/win/EditingDelegate.cpp:
1716         (dump): Pass proper character pointer type to printf.
1717         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1718         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1719         (EditingDelegate::shouldInsertNode): Ditto.
1720         (EditingDelegate::shouldInsertText): Ditto.
1721         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1722         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1723         (EditingDelegate::shouldApplyStyle): Ditto.
1724         * DumpRenderTree/win/EventSender.cpp:
1725         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1726         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1727         system headers.
1728         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1729         from CreateDIBSection.
1730         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1731         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1732         older versions of MSVC we no longer support.
1733         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1734         for 64-bit builds.
1735         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1736         * TestWebKitAPI/TestsController.h: Ditto.
1737         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1738         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1739         performing bitwise | before the comparison is done.
1740
1741 2014-10-08  Ada Chan  <adachan@apple.com>
1742
1743         Add a test for WKPageIsPlayingAudio().
1744         https://bugs.webkit.org/show_bug.cgi?id=137048
1745
1746         Reviewed by Darin Adler.
1747
1748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1749         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1750         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1751         (TestWebKitAPI::nullJavaScriptCallback):
1752         (TestWebKitAPI::didFinishLoadForFrame):
1753         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1754         (TestWebKitAPI::setUpClients):
1755         (TestWebKitAPI::TEST):
1756         This test loads a page with a video in it. When the page is loaded, we first check that
1757         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1758         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1759         now returns true for the page.
1760         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1761         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1762         This is a video copied from LayoutTests/media/content.
1763
1764 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1765
1766         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1767         https://bugs.webkit.org/show_bug.cgi?id=137516
1768
1769         Reviewed by Alexey Proskuryakov.
1770
1771         * Scripts/webkitpy/thirdparty/__init__.py:
1772         (AutoinstallImportHook._install_irc):
1773
1774 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1775
1776         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1777         https://bugs.webkit.org/show_bug.cgi?id=137520
1778
1779         Reviewed by Philippe Normand.
1780
1781         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1782         For other distributions, we are already installing libjpeg-turbo.
1783         So, do the same for Debian and derivatives.
1784
1785         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1786
1787 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1788
1789         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1790         https://bugs.webkit.org/show_bug.cgi?id=137519
1791
1792         Reviewed by Csaba Osztrogonác.
1793
1794         It was removed by <http://trac.webkit.org/changeset/174266>,
1795         because the comment stated it is a workaround for buggy python
1796         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1797         is still valid with python 2.7 shipped on the latest Ubuntu
1798         (12.04 and 14.04) and OS X 10.9.
1799
1800         * Scripts/webkitpy/common/system/autoinstall.py:
1801         (AutoInstaller):
1802         (AutoInstaller._extract_all):
1803         (AutoInstaller._unzip):
1804
1805 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1806
1807         Unreviewed, rolling out r174335.
1808         https://bugs.webkit.org/show_bug.cgi?id=137515
1809
1810         It broke EFL layout test totally (Requested by gyuyoung on
1811         #webkit).
1812
1813         Reverted changeset:
1814
1815         "[EFL] Introduce EWebKit_Extension"
1816         https://bugs.webkit.org/show_bug.cgi?id=134921
1817         http://trac.webkit.org/changeset/174335
1818
1819 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1820
1821         [GTK] Make forwarding headers generation depend on source code
1822         https://bugs.webkit.org/show_bug.cgi?id=137394
1823
1824         Reviewed by Philippe Normand.
1825
1826         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1827         * TestWebKitAPI/PlatformGTK.cmake: Only run
1828         generate-forwarding-headers.pl when source code changes.
1829         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1830
1831 2014-10-07  Tanay C  <tanay.c@samsung.com>
1832
1833         Remove build warnings in Hashmap API tests
1834         https://bugs.webkit.org/show_bug.cgi?id=137484
1835
1836         Reviewed by Darin Adler.
1837
1838         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1839         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1840
1841 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1842
1843         Commit queue doesn't drop obsolete patches sometimes
1844         https://bugs.webkit.org/show_bug.cgi?id=137460
1845
1846         Reviewed by Alexey Proskuryakov.
1847
1848         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1849         Adds another test patch for use in queues_unittest.py.
1850         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1851         (MockBugzilla):
1852         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1853         Raises a PatchIsNotValid exception in the case of validate() returning
1854         false.
1855         (CommitQueueTask.run):
1856         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1857         Raises a PatchIsNotValid exception in the case of validate() returning
1858         false.
1859         (EarlyWarningSystemTask.run):
1860         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1861         Defines PatchIsNotValid exception. 
1862         (PatchIsNotValid):
1863         (PatchIsNotValid.__init__):
1864         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1865         Remove call to validate() and instead catches the PatchIsNotValid
1866         exception.
1867         (AbstractEarlyWarningSystem.review_patch):
1868         * Scripts/webkitpy/tool/commands/queues.py:
1869         Adds logic to catch the PatchIsNotValid exception.
1870         (CommitQueue.process_work_item):
1871         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1872         Adds the test_non_valid_patch test to ensure that invalid patches are
1873         handled properly, and don't just result in indefinite spinning.
1874         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1875         (test_non_valid_patch):
1876
1877 2014-10-07  Daniel Bates  <dabates@apple.com>
1878
1879         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1880         https://bugs.webkit.org/show_bug.cgi?id=137499
1881
1882         Reviewed by Simon Fraser.
1883
1884         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1885         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1886         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1887         bit simulator builds of iOS WebKit.
1888
1889         * Scripts/webkitpy/port/ios.py:
1890         (IOSSimulatorPort._generate_all_test_configurations):
1891
1892 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1893
1894         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1895         https://bugs.webkit.org/show_bug.cgi?id=137482
1896
1897         Reviewed by Martin Robinson.
1898
1899         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1900
1901 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1902
1903         [SOUP] TLS errors should take precedence over HTTP authentication
1904         https://bugs.webkit.org/show_bug.cgi?id=137300
1905
1906         Reviewed by Sergio Villar Senin.
1907
1908         Add a test case to check that authenticate signal is not emitted
1909         in case of TLS errors, and the load fails instead.
1910
1911         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1912         (webViewAuthenticationCallback):
1913         (testTLSErrorsHTTPAuth):
1914         (httpsServerCallback):
1915         (beforeAll):
1916
1917 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1918
1919         Make webkit-patch find-users useful
1920         https://bugs.webkit.org/show_bug.cgi?id=137475
1921
1922         Reviewed by Alexey Proskuryakov.
1923
1924         Make find-users use the CommitterList instead of accessing Bugzilla.
1925
1926         This essentially exposes the same functionality as webkitbot's whois command.
1927
1928         * Scripts/webkitpy/tool/commands/findusers.py:
1929         (FindUsers.execute):
1930
1931 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1932
1933         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1934         https://bugs.webkit.org/show_bug.cgi?id=137289
1935
1936         Unreviewed build fix.
1937
1938         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1939         (AccessibilityUIElement::getChildrenWithRange):
1940
1941 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1942
1943         build.webkit.org/dashboard: Add commit queue
1944         https://bugs.webkit.org/show_bug.cgi?id=137462
1945
1946         Reviewed by Tim Horton.
1947
1948         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1949         Style queue is still invisible, as it doesn't have an associated platform, and also
1950         we never have problems with it anyway, so it's not worth watching.
1951
1952         The UI now allows for adding more bots to the Other column (such as leaks bot).
1953         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1954         sources of data in a cell.
1955
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1957         (BubbleQueue):
1958         (BubbleQueue.prototype.get statusPageURL):
1959         (BubbleQueue.prototype.update):
1960         (BubbleQueue.prototype.loadDetailedStatus):
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1962         (BubbleQueueServer):
1963         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1964         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1965         (BubbleQueueServer.prototype.queueStatusURL):
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1967         (BubbleQueueView):
1968         (BubbleQueueView.prototype.update.appendQueue):
1969         (BubbleQueueView.prototype.update):
1970         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1971         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1972         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1979         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1980         (.bubble-server-popover .latest-status-no-link):
1981         (.bubble-server-popover .bot-status-description):
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1983
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1985         (buildAggregateTable):
1986         (buildQueuesTable):
1987         Removed dysfunctional support for EWS for now. It will be different.
1988
1989 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1990
1991         One more case of incorrect comparison in recordpatchevent.py
1992         https://bugs.webkit.org/show_bug.cgi?id=137459
1993
1994         Reviewed by Tim Horton.
1995
1996         * QueueStatusServer/app.yaml:
1997         * QueueStatusServer/loggers/recordpatchevent.py:
1998         (RecordPatchEvent.started):
1999
2000 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2001
2002         webkit-queues PatchLog is incorrect for patches that took less than a second
2003         https://bugs.webkit.org/show_bug.cgi?id=137453
2004
2005         Reviewed by Tim Horton.
2006
2007         * QueueStatusServer/app.yaml: Updated app version.
2008
2009         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
2010         Don't bail out for patches that took 0 seconds to process (as frequently happens
2011         when a patch is obsolete).
2012
2013 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
2014
2015         EWS bubble hover shows wrong timestamps
2016         https://bugs.webkit.org/show_bug.cgi?id=137252
2017
2018         Reviewed by Alexey Proskuryakov.
2019
2020         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
2021
2022         * QueueStatusServer/handlers/queuestatusjson.py:
2023         (QueueStatusJSON.get):
2024         * QueueStatusServer/handlers/statusbubble.py:
2025         (StatusBubble._iso_time):
2026
2027 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
2028
2029         Unreviewed, updated list of email addresses in contributors.json
2030
2031         * Scripts/webkitpy/common/config/contributors.json: Added my former
2032         email address in Igalia, for the sake of completeness.
2033
2034 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2035
2036         Unreviewed, moved myself to the list of committers.
2037
2038         * Scripts/webkitpy/common/config/contributors.json:
2039
2040 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
2041
2042         [EFL] Introduce EWebKit_Extension
2043         https://bugs.webkit.org/show_bug.cgi?id=134921
2044
2045         Reviewed by Gyuyoung Kim.
2046
2047         * MiniBrowser/efl/main.c: Added x option to test extension path.
2048         (window_create):
2049         (elm_main):
2050         * Scripts/webkitpy/common/config/watchlist:
2051         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2052         * Scripts/webkitpy/style/checker.py:
2053         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2054
2055 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
2056
2057         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
2058         https://bugs.webkit.org/show_bug.cgi?id=137390
2059
2060         Reviewed by Carlos Garcia Campos.
2061
2062         * Scripts/update-webkit-libs-jhbuild:
2063
2064 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2065
2066         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
2067         https://bugs.webkit.org/show_bug.cgi?id=137391
2068
2069         Reviewed by Martin Robinson.
2070
2071         Add a custom command to only re-generate
2072         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
2073
2074         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2075
2076 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2077
2078         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
2079         https://bugs.webkit.org/show_bug.cgi?id=135502
2080
2081         Reviewed by Martin Robinson.
2082
2083         When writing to stdout/stderr fails due to a UnicodeDecodeError
2084         exception, try again without encoding the output.
2085
2086         * gtk/gtkdoc.py:
2087         (GTKDoc._run_command):
2088
2089 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2090
2091         Bugzilla status bubble displays an exception showing attachment 175738
2092         https://bugs.webkit.org/show_bug.cgi?id=137410
2093
2094         Reviewed by Tim Horton.
2095
2096         * QueueStatusServer/app.yaml: Update version.
2097
2098         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
2099         Don't fail even if expected status message is missing.
2100
2101         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
2102         the field in the same way it's defined in QueueStatus table.
2103
2104 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2105
2106         Record latest message in PatchLog for quick access
2107         https://bugs.webkit.org/show_bug.cgi?id=137405
2108
2109         Fixing a typo.
2110
2111         * QueueStatusServer/app.yaml:
2112         * QueueStatusServer/handlers/releasepatch.py:
2113
2114 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Record latest message in PatchLog for quick access
2117         https://bugs.webkit.org/show_bug.cgi?id=137405
2118
2119         Reviewed by Ryosuke Niwa.
2120
2121         It's no SQL...
2122
2123         * QueueStatusServer/handlers/releasepatch.py:
2124         * QueueStatusServer/handlers/updatestatus.py:
2125         * QueueStatusServer/loggers/recordpatchevent.py:
2126         * QueueStatusServer/model/patchlog.py:
2127
2128 2014-10-02  David Farler  <dfarler@apple.com>
2129
2130         -asan-blacklist option also renamed to generic -fsanitize-blacklist
2131         https://bugs.webkit.org/show_bug.cgi?id=137377
2132
2133         Reviewed by Daniel Bates.
2134
2135         * asan/asan.xcconfig:
2136         -asan-blacklist -> -fsanitize-blacklist
2137
2138         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2139
2140 2014-10-03  Roger Fong  <roger_fong@apple.com>
2141
2142         [Windows] Include batch size argument to layout tests on Windows.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2145         (RunWebKitTests.start): 
2146         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
2147         These crashes seem to happen on random tests though generally in a spread out fashion.
2148         It seems possible that the DRT instance is being clobbered somehow after running too many
2149         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
2150
2151 2014-10-03  Roger Fong  <roger_fong@apple.com>
2152
2153         [Windows] Settle for 2 chid processes running NRWT on Windows.
2154
2155         * Scripts/webkitpy/port/win.py:
2156         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
2157
2158 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
2159
2160         [GTK] Bump up and patch dependencies to allow building for aarch64
2161         https://bugs.webkit.org/show_bug.cgi?id=137147
2162
2163         Reviewed by Martin Robinson.
2164
2165         The currently used versions of pixman, libffi, librsvg, glib,
2166         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
2167         and/or build for aarch64, so they are bumped up and patched where
2168         necessary. Wherever possible, the same versions and patches were used as
2169         for the EFL port bump-up
2170         (https://bugs.webkit.org/show_bug.cgi?id=135885).
2171
2172         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
2173         regression by crashing http/tests/media/video-redirect.html . A patch
2174         already in upstream fixes that bug.
2175
2176         This change does not touch xserver, which also needs bumping up, but 
2177         will be dealt with later.
2178
2179         * gtk/jhbuild.modules:
2180         Specified versions and patches necessary to correctly build for aarch64.
2181         * gtk/patches/gst-events-arent-gstobjects.patch:
2182         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
2183         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
2184         Added. Patches gst-plugins-base to configure correctly for aarch64.
2185         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
2186         Added. Bumps up config.guess and config.sub in librsvg to recognize
2187         aarch64.
2188         * gtk/patches/libxml2-2.9.0-dtd.patch:
2189         Removed. Not necessary for libxml2 v2.9.1 anymore.
2190
2191 2014-09-28  Sam Weinig  <sam@webkit.org>
2192
2193         Remove RefPtrHashMap
2194         https://bugs.webkit.org/show_bug.cgi?id=137200
2195
2196         Reviewed by Darin Adler.
2197
2198         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2199         (TestWebKitAPI::TEST):
2200         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
2201         a minimum of refcount churn occurs.
2202
2203 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2204
2205         Remove workarounds for versions of Python before 2.7
2206         https://bugs.webkit.org/show_bug.cgi?id=137338
2207
2208         Reviewed by Csaba Osztrogonác.
2209
2210         * Scripts/webkitpy/common/system/autoinstall.py:
2211         (AutoInstaller._extract_targz):
2212         (AutoInstaller._unzip):
2213         (AutoInstaller): Deleted.
2214         (AutoInstaller._extract_all): Deleted.
2215         * Scripts/webkitpy/common/webkitunittest.py:
2216         (TestCase.setUp): Deleted.
2217         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2218         (TestConfigurationConverter.collapse_macros):
2219         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2220         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2221         (TestConfigurationConverter):
2222         (TestConfigurationConverter.combinations): Deleted.
2223         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2224         * Scripts/webkitpy/port/base.py:
2225
2226 2014-10-03  Commit Queue  <commit-queue@webkit.org>
2227
2228         Unreviewed, rolling out r174264.
2229         https://bugs.webkit.org/show_bug.cgi?id=137392
2230
2231         It broke run-webkit-tests (Requested by ebalazsfalvi on
2232         #webkit).
2233
2234         Reverted changeset:
2235
2236         "Remove workarounds for versions of Python before 2.7"
2237         https://bugs.webkit.org/show_bug.cgi?id=137338
2238         http://trac.webkit.org/changeset/174264
2239
2240 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2241
2242         Remove workarounds for versions of Python before 2.7
2243         https://bugs.webkit.org/show_bug.cgi?id=137338
2244
2245         Reviewed by Csaba Osztrogonác.
2246
2247         * Scripts/webkitpy/common/system/autoinstall.py:
2248         (AutoInstaller._extract_targz):
2249         (AutoInstaller._unzip):
2250         (AutoInstaller): Deleted.
2251         (AutoInstaller._extract_all): Deleted.
2252         * Scripts/webkitpy/common/webkitunittest.py:
2253         (TestCase.setUp): Deleted.
2254         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2255         (TestConfigurationConverter.collapse_macros):
2256         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2257         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2258         (TestConfigurationConverter):
2259         (TestConfigurationConverter.combinations): Deleted.
2260         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2261         * Scripts/webkitpy/port/base.py:
2262         * Scripts/webkitpy/port/driver.py:
2263         (ContentBlock.__init__):
2264         * Scripts/webkitpy/port/server_process.py:
2265         (ServerProcess._reset):
2266
2267 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2268
2269         Remove autoinstaller workaround for python 2.6
2270         https://bugs.webkit.org/show_bug.cgi?id=137343
2271
2272         Reviewed by Daniel Bates.
2273
2274         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2275         2.6, nor Snow Leopard is supported anymore, so the workaround is not
2276         needed anymore.
2277
2278         * Scripts/webkitpy/common/system/autoinstall.py:
2279         (AutoInstaller.install):
2280         * Scripts/webkitpy/test/main.py:
2281         (Tester._run_tests):
2282         * Scripts/webkitpy/thirdparty/__init__.py:
2283         (AutoinstallImportHook._install_mechanize):
2284         (AutoinstallImportHook._install_pep8):
2285         (AutoinstallImportHook._install_pylint):
2286         (AutoinstallImportHook._install_buildbot):
2287         (AutoinstallImportHook._install_coverage):
2288         (AutoinstallImportHook._install_eliza):
2289         (AutoinstallImportHook._install_irc):
2290         (AutoinstallImportHook._install):
2291         (autoinstall_everything):
2292
2293 2014-10-02  Daniel Bates  <dabates@apple.com>
2294
2295         Use version number 101000 instead of 10100 for OS X Yosemite
2296         https://bugs.webkit.org/show_bug.cgi?id=137372
2297
2298         Reviewed by Mark Rowe.
2299
2300         The version number for OS X Yosemite is 101000.
2301
2302         * DumpRenderTree/mac/TextInputController.m:
2303
2304 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
2305
2306         update-work-items should never delete items
2307         https://bugs.webkit.org/show_bug.cgi?id=137366
2308
2309         Reviewed by Ryosuke Niwa.
2310
2311         As we don't just replace the whole list any more, indicate which items are high
2312         priority, and which are not. Hight priority ones will be prepended to the queue,
2313         others will be appended.
2314
2315         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
2316         But hopefully we will never have many rollouts competing like that.
2317
2318         * QueueStatusServer/app.yaml: Update version.
2319
2320         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
2321         priority and regular items separately. Removed some error handling that used to
2322         end up in returning status 500 - an uncaught exception does that automatically.
2323
2324         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
2325
2326         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
2327
2328         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
2329         priority items.
2330
2331         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2332         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
2333         line that complicated testing.
2334
2335         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
2336
2337         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
2338         priority items into separate lists.
2339
2340         * Scripts/webkitpy/common/net/statusserver_mock.py:
2341         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2342         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2343         Updated tests.
2344
2345 2014-10-02  Brendan Long  <b.long@cablelabs.com>
2346
2347         Annoying build warnings in WTFString API tests
2348         https://bugs.webkit.org/show_bug.cgi?id=137360
2349
2350         Reviewed by Darin Adler.
2351
2352         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2353         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
2354
2355 2014-10-02  Roger Fong  <roger_fong@apple.com>
2356
2357         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
2358
2359         * Scripts/webkitpy/port/win.py:
2360         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
2361
2362 2014-10-02  David Farler  <dfarler@apple.com>
2363
2364         Move ASan arguments from LLVM (-mllvm) to the frontend
2365         https://bugs.webkit.org/show_bug.cgi?id=137365
2366
2367         Reviewed by David Kilzer.
2368
2369         * asan/asan.xcconfig:
2370         Remove the -mllvm prefix to the asan-blacklist argument, moving it
2371         to the clang frontend.
2372
2373         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2374
2375 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2376
2377         Unreviewed, rolling out r174120.
2378         https://bugs.webkit.org/show_bug.cgi?id=137350
2379
2380         While number of failures is reasonable with 2 processes, test
2381         results seem to be inconsistent between runs (Requested by
2382         rfong on #webkit).
2383
2384         Reverted changeset:
2385
2386         "[Windows] Back to 2 child processes for NRWT on Windows."
2387         http://trac.webkit.org/changeset/174120
2388
2389 2014-10-02  Jeff Miller  <jeffm@apple.com>
2390
2391         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2392         https://bugs.webkit.org/show_bug.cgi?id=137347
2393
2394         Reviewed by Dan Bernstein.
2395
2396         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2397         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2398
2399         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2400         Ditto.
2401
2402 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2403
2404         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2405
2406         Unreviewed.
2407
2408         The ftp access is recently failing to work as expected, and the
2409         bots fail to download the file.
2410         The same mirror is available via http and seems to work better.
2411
2412         * gtk/jhbuild.modules:
2413
2414 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2415
2416         Unreviewed, rolling out r174185.
2417         https://bugs.webkit.org/show_bug.cgi?id=137334
2418
2419         Patch that adds logging causes webkitpy failures (Requested by
2420         rfong on #webkit).
2421
2422         Reverted changeset:
2423
2424         "commitqueuetasks_unittest references a non-existent member
2425         variable"
2426         https://bugs.webkit.org/show_bug.cgi?id=137303
2427         http://trac.webkit.org/changeset/174185
2428
2429 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2430
2431         EWS and Commit Queue should know better than to spew 500 failed
2432         results in the case of extremely red patches.
2433         https://bugs.webkit.org/show_bug.cgi?id=137324
2434
2435         Reviewed by Alexey Proskuryakov.
2436
2437         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2438         Adds a check for did_exceed_test_failure_limit.
2439         (AbstractEarlyWarningSystem._failing_tests_message):
2440         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2441         Alters the task mock to respond properly to
2442         results_from_patch_test_run(patch)
2443         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2444         * Scripts/webkitpy/tool/commands/queues.py:
2445         Adds a check for did_exceed_test_failure_limit.
2446         (CommitQueue._failing_tests_message):
2447
2448 2014-10-01  Daniel Bates  <dabates@apple.com>
2449
2450         Unreviewed, rolling out r174192.
2451
2452         Revert the unit test fix in r174192 since we reverted r174187
2453         in r174194 due to correctness issues. See
2454         <http://webkit.org/b/137329> for more details.
2455
2456         Reverted changeset:
2457
2458         "Test fix after r174187"
2459         http://trac.webkit.org/changeset/174192
2460
2461 2014-10-01  Mark Rowe  <mrowe@apple.com>
2462
2463         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2464
2465         Reviewed by Dan Bernstein.
2466
2467         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2468         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2469         for the LLVM components when on Yosemite.
2470
2471 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2472
2473         Unreviewed, rolling out r174187.
2474         https://bugs.webkit.org/show_bug.cgi?id=137329
2475
2476         webkitpy failures, and thorton says the patch is wrong
2477         (Requested by dethbakin on #webkit).
2478
2479         Reverted changeset:
2480
2481         "[Windows] Increase layout test timeout for Windows following
2482         r174162."
2483         http://trac.webkit.org/changeset/174187
2484
2485 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
2486
2487         Test fix after r174187
2488
2489         * Scripts/webkitpy/port/win_unittest.py:
2490         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
2491
2492 2014-10-01  Roger Fong  <roger_fong@apple.com>
2493
2494         [Windows] Increase layout test timeout for Windows following r174162.
2495
2496         * Scripts/webkitpy/port/win.py:
2497         (WinPort.default_timeout_ms):
2498
2499 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2500
2501         commitqueuetasks_unittest references a non-existent member variable
2502         when mock-reporting flaky tests.
2503         https://bugs.webkit.org/show_bug.cgi?id=137303
2504
2505         Reviewed by Daniel Bates.
2506
2507         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2508         (MockCommitQueue.report_flaky_tests):
2509         Makes the appropriate name change.
2510         (test_simple_flaky_test_failure):
2511         Adds a unit test to make sure that the code is excercised.
2512
2513 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2514
2515         EWS is inconclusively spinning forever on a patch that breaks 500+
2516         tests
2517         https://bugs.webkit.org/show_bug.cgi?id=137223
2518
2519         Reviewed by Tim Horton.
2520
2521         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2522         Checks to see whether the tests have exceeded the failure limit, and
2523         only spins off another test if they have not exceeded the limit.
2524         (PatchAnalysisTask._test_patch):
2525
2526 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
2527
2528         Unreviewed, add Katie Madonna as a contributor.
2529
2530         * Scripts/webkitpy/common/config/contributors.json:
2531
2532 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2533
2534         commitqueuetasks_unittest does not construct FailingTestCommitQueue
2535         objects properly in its test cases.
2536         https://bugs.webkit.org/show_bug.cgi?id=137281
2537
2538         Reviewed by Daniel Bates.
2539
2540         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2541         (FailingTestCommitQueue.test_results):
2542         Adds an assert to make FailingTestCommitQueue harder to mis-use.
2543         (test_double_flaky_test_failure):
2544         Nests the intended test failure strings into one-length lists.
2545         (test_red_test_failure):
2546         Nests the intended test failure strings into one-length lists.
2547
2548 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2549
2550         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
2551         https://bugs.webkit.org/show_bug.cgi?id=136987
2552
2553         Reviewed by Daniel Bates.
2554
2555         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2556         Specify the default encoding for all WebKit developers to get consistent results.
2557
2558 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2559
2560         EWS is too eager to say that a patch does not apply to trunk of repository
2561         https://bugs.webkit.org/show_bug.cgi?id=137290
2562
2563         Reviewed by Ryosuke Niwa.
2564
2565         * QueueStatusServer/app.yaml: Updated app version.
2566
2567         * QueueStatusServer/handlers/statusbubble.py:
2568         (StatusBubble._build_bubble):
2569         (StatusBubble._build_bubbles_for_attachment):
2570         Rewrote to make more sense.
2571
2572 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2573
2574         Remove thirdparty/unittest2 from webkitpy
2575         https://bugs.webkit.org/show_bug.cgi?id=137251
2576
2577         Reviewed by Brent Fulgham.
2578
2579         Additionally ordered imports in related webkitpy files and
2580         removed unnecessary shebangs from unittest files.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
2583         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2584         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2585         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2586         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2587         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2588         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2589         * Scripts/webkitpy/common/config/committers_unittest.py:
2590         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2591         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
2592         * Scripts/webkitpy/common/config/ports_unittest.py:
2593         * Scripts/webkitpy/common/config/urls_unittest.py:
2594         * Scripts/webkitpy/common/editdistance_unittest.py:
2595         * Scripts/webkitpy/common/find_files_unittest.py:
2596         * Scripts/webkitpy/common/lru_cache_unittest.py:
2597         * Scripts/webkitpy/common/memoized_unittest.py:
2598         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2599         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2600         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2601         * Scripts/webkitpy/common/net/credentials_unittest.py:
2602         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2603         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2604         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2605         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2606         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2607         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2608         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2609         * Scripts/webkitpy/common/newstringio_unittest.py:
2610         * Scripts/webkitpy/common/prettypatch_unittest.py:
2611         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2612         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2613         * Scripts/webkitpy/common/system/environment_unittest.py:
2614         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2615         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2616         * Scripts/webkitpy/common/system/executive_unittest.py:
2617         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2618         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2619         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2620         * Scripts/webkitpy/common/system/logtesting.py:
2621         * Scripts/webkitpy/common/system/logutils_unittest.py:
2622         * Scripts/webkitpy/common/system/outputcapture.py:
2623         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2624         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2625         * Scripts/webkitpy/common/system/path_unittest.py:
2626         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2627         * Scripts/webkitpy/common/system/profiler_unittest.py:
2628         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2629         * Scripts/webkitpy/common/system/user_unittest.py:
2630         * Scripts/webkitpy/common/system/workspace_unittest.py:
2631         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2632         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2633         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2634         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2635         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2636         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2637         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2638         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2639         * Scripts/webkitpy/common/webkitunittest.py:
2640         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2641         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2642         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2643         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2644         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2645         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2646         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2647         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2648         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2649         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2650         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2651         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2652         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2653         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2654         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2655         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2656         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2657         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2658         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2659         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2660         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2661         * Scripts/webkitpy/port/base_unittest.py:
2662         * Scripts/webkitpy/port/builders_unittest.py:
2663         * Scripts/webkitpy/port/config_unittest.py:
2664         * Scripts/webkitpy/port/driver_unittest.py:
2665         * Scripts/webkitpy/port/efl_unittest.py:
2666         * Scripts/webkitpy/port/factory_unittest.py:
2667         * Scripts/webkitpy/port/gtk_unittest.py:
2668         * Scripts/webkitpy/port/http_lock_unittest.py:
2669         * Scripts/webkitpy/port/image_diff_unittest.py:
2670         * Scripts/webkitpy/port/leakdetector_unittest.py:
2671         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2672         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2673         * Scripts/webkitpy/port/mock_drt_unittest.py:
2674         * Scripts/webkitpy/port/port_testcase.py:
2675         * Scripts/webkitpy/port/server_process_unittest.py:
2676         * Scripts/webkitpy/port/westondriver_unittest.py:
2677         * Scripts/webkitpy/port/win_unittest.py:
2678         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2679         * Scripts/webkitpy/style/checker_unittest.py:
2680         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2681         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2682         * Scripts/webkitpy/style/checkers/common_unittest.py:
2683         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2684         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2685         * Scripts/webkitpy/style/checkers/js_unittest.py:
2686         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2687         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2688         * Scripts/webkitpy/style/checkers/png_unittest.py:
2689         * Scripts/webkitpy/style/checkers/python_unittest.py:
2690         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2691         * Scripts/webkitpy/style/checkers/text_unittest.py:
2692         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2693         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2694         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2695         * Scripts/webkitpy/style/error_handlers_unittest.py:
2696         * Scripts/webkitpy/style/filereader_unittest.py:
2697         * Scripts/webkitpy/style/filter_unittest.py:
2698         * Scripts/webkitpy/style/main_unittest.py:
2699         * Scripts/webkitpy/style/optparser_unittest.py:
2700         * Scripts/webkitpy/style/patchreader_unittest.py:
2701         * Scripts/webkitpy/test/finder_unittest.py:
2702         * Scripts/webkitpy/test/main.py: Ordered imports.
2703         * Scripts/webkitpy/test/main_unittest.py:
2704         * Scripts/webkitpy/test/printer.py: Ordered imports.
2705         (Printer.configure):
2706         * Scripts/webkitpy/test/runner_unittest.py:
2707         * Scripts/webkitpy/test/skip_unittest.py:
2708         * Scripts/webkitpy/thirdparty/__init__.py:
2709         (AutoinstallImportHook._install_irc):
2710         (AutoinstallImportHook._install_unittest2): Deleted.
2711         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2712         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2713         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2714         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2715         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2716         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2717         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2718         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2719         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2720         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2721         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2722         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2723         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2724         * Scripts/webkitpy/tool/commands/download_unittest.py:
2725         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2726         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2727         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2728         * Scripts/webkitpy/tool/commands/queuestest.py:
2729         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2730         * Scripts/webkitpy/tool/grammar_unittest.py:
2731         * Scripts/webkitpy/tool/mocktool_unittest.py:
2732         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2733         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2734         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2735         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2736         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2737         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2738         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2739         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2740         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2741         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2742         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2743         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2744         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2745         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2746         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2747         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2748         * Scripts/webkitpy/tool/steps/update_unittest.py:
2749         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2750         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2751         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2752         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2753         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2754
2755 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2756
2757         LayoutTestResults and ExpectedFailures should know about the
2758         interrupted flag from the json results file
2759         https://bugs.webkit.org/show_bug.cgi?id=137229
2760
2761         Reviewed by Daniel Bates.
2762
2763         Changes LayoutTestResults to use the interrupted flag instead of
2764         counting failures.
2765
2766         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2767         (BuilderTest._install_fetch_build._mock_fetch_build):
2768         (BuilderTest.test_latest_layout_test_results):
2769         * Scripts/webkitpy/common/net/layouttestresults.py:
2770         Removes notion of failure_limit_count, and adds
2771         did_exceed_test_failure_limit.
2772
2773         (LayoutTestResults.results_from_string):
2774         (LayoutTestResults.__init__):
2775         (LayoutTestResults.did_exceed_test_failure_limit):
2776         (LayoutTestResults): Deleted.
2777         (LayoutTestResults.set_failure_limit_count): Deleted.
2778         (LayoutTestResults.failure_limit_count): Deleted.
2779         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2780         Removes unit test for failure_limit_count logic.
2781
2782         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2783         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2784         Instead of providing a class method that returns a list of
2785         TestResults objects, resultsjsonparser now provides a class
2786         ParsedJSONResults that serves as an interface between the results.json
2787         file and the rest of webkitpy.
2788
2789         (ParsedJSONResults):
2790         (ParsedJSONResults.__init__):
2791         (ParsedJSONResults.did_exceed_test_failure_limit):
2792         (ParsedJSONResults.test_results):
2793         (ResultsJSONParser): Deleted.
2794         (ResultsJSONParser.parse_results_json): Deleted.
2795         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2796         Updates the unit test so that it can test the new ResultsJSONParser
2797         class.
2798
2799         (ParsedJSONResultsTest):
2800         (test_basic):
2801         (ResultsJSONParserTest): Deleted.
2802         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2803         Updates the unit test to instantiate ResultsJSONParser objects rather
2804         than simple lists of TestResult objects.
2805
2806         (MockCommitQueue.test_results):
2807         (FailingTestCommitQueue.test_results):
2808         (test_flaky_test_failure):
2809         (test_failed_archive):
2810         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2811         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2812         method rather than counting the number of failed tests.
2813
2814         (ExpectedFailures._should_trust):
2815         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2816         Updates MockResults to more closely resemble the updated
2817         LayoutTestResults class.
2818
2819         (MockResults.__init__):
2820         (MockResults.did_exceed_test_failure_limit):
2821         (ExpectedFailuresTest.test_can_trust_results):
2822         (ExpectedFailuresTest.test_unexpected_failures_observed):
2823         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2824         (MockResults.failure_limit_count): Deleted.
2825         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2826         Removes a FIXME regarding the use of the
2827         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2828
2829         (LayoutTestResultsReader.results):
2830         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2831         Updates test to not check the now-nonexistant failure_count_limit
2832         method.
2833
2834         (test_missing_unit_test_results_path):
2835         (test_layout_test_results):
2836         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2837         Accounts for name change: ResultsJSONParserTest ->
2838         ParsedJSONParserTest.
2839
2840         (RebaselineTestTest.test_gather_baselines):
2841
2842 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2843
2844         [EFL] Rename TEST_THEME_DIR macro
2845         https://bugs.webkit.org/show_bug.cgi?id=137244
2846
2847         Reviewed by Csaba Osztrogonác.
2848
2849         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2850         DEFAULT_THEME_DIR is better than it.
2851
2852         * MiniBrowser/efl/main.c:
2853         (window_create):
2854         * TestWebKitAPI/efl/PlatformWebView.cpp:
2855         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2856         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2857         (WTR::PlatformWebView::PlatformWebView):
2858
2859 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2860
2861         Windows EWS went purple when it failed to build
2862         https://bugs.webkit.org/show_bug.cgi?id=137267
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         * QueueStatusServer/app.yaml: Update the version.
2867
2868         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2869         Make it work for style and win-ews queues.
2870
2871 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2872
2873         It should be fun and easy to run every possible JavaScript benchmark from the command line
2874         https://bugs.webkit.org/show_bug.cgi?id=137245
2875
2876         Reviewed by Oliver Hunt.
2877         
2878         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2879         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2880         having their own private scripts for doing benchmark runs, and didn't share them in the open
2881         source community, because of fears about the shady licensing of the benchmarks suites that
2882         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2883         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2884         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2885         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2886         but some of them are. The non-public tests are exclusively those that were not made by any
2887         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2888
2889         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2890         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2891         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2892         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2893         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2894         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2895         probably never be checked in because there is no license text anywhere in that benchmark.
2896         A valid ~/.run-jsc-benchmarks file will just be something like:
2897         
2898             {
2899                 "OctanePath": "/path/to/Octane2",
2900                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2901             }
2902         
2903         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2904         run-jsc-benchmarks will just gracefully avoid running that test suite.
2905         
2906         Finally, a word about policy: it is understood that different organizations that do
2907         development on JSC may find themselves having internal benchmarks that they cannot share
2908         because of weird licensing. It happens - usually because the organization doing JSC
2909         development found some test in the wild that is owned by someone else and therefore cannot
2910         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2911         that add support for some new kind of benchmark suite even if the suite is not made public
2912         as part of the same patch - so long as the patch isn't too invasive. An example of
2913         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2914         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2915         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2916         completely open-sourced and committed to the WebKit repo - but the reality is that this
2917         can't always be done safely.
2918
2919         * Scripts/bencher: Removed.
2920         * Scripts/run-jsc-benchmarks: Added.
2921
2922 2014-09-30  Roger Fong  <roger_fong@apple.com>
2923
2924         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2925
2926         * Scripts/webkitpy/port/drdiver.py:
2927         (Driver.stop):
2928         * Scripts/webkitpy/port/server_process.py:
2929         (ServerProcess.stop):
2930
2931 2014-09-30  Roger Fong  <roger_fong@apple.com>
2932
2933         [Windows] Back to 2 child processes for NRWT on Windows.
2934
2935         * Scripts/webkitpy/port/win.py:
2936         (WinPort.default_child_processes):
2937         Changing the number of processes to 1 did not have an effect on the layout test results. 
2938         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2939         layout tests to timeout as a whole occasionally, but we should just fix that.
2940
2941 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2942
2943         Remove an accidentally committed line..
2944
2945         * QueueStatusServer/handlers/statusbubble.py:
2946         (StatusBubble._build_bubble):
2947
2948 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2949
2950         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2951         https://bugs.webkit.org/show_bug.cgi?id=137240
2952
2953         Reviewed by Ryosuke Niwa.
2954
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2956         (EWSQueue.prototype.loadDetailedStatus):
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2958         (EWSQueueView.prototype._popoverContentForEWSQueue):
2959         Use the new retry_count data member from JSON.
2960
2961         * QueueStatusServer/app.yaml: Updating the version.
2962
2963         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2964         Instead of message_count, produce retry_count.
2965
2966 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2967
2968         EWS doesn't need to show all the bubbles when a patch fails to apply
2969         https://bugs.webkit.org/show_bug.cgi?id=137256
2970
2971         Reviewed by Ryosuke Niwa.
2972
2973         * QueueStatusServer/app.yaml: Updated app version.
2974
2975         * QueueStatusServer/handlers/statusbubble.py:
2976         (StatusBubble._build_bubble):
2977         (StatusBubble._build_bubbles_for_attachment):
2978         (StatusBubble.get):
2979         * QueueStatusServer/templates/statusbubble.html:
2980         When some queues fail to apply, and no queues had meaningful output (meaning that
2981         they will almost certainly fail to apply later), we can show a single bubble
2982         telling the user just that.
2983
2984 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2985
2986         [EFL] Bump EFL version to 1.11.2
2987         https://bugs.webkit.org/show_bug.cgi?id=137118
2988
2989         Reviewed by Gyuyoung Kim.
2990
2991         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2992         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2993
2994         * efl/jhbuild.modules:
2995         * efl/patches/ecore.patch: Removed.
2996
2997 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         REGRESSION(r173929): [GTK] TestInspector fails after r173929
3000         https://bugs.webkit.org/show_bug.cgi?id=137247
3001
3002         Reviewed by Philippe Normand.
3003
3004         Wait until can-attach property changes before trying to attach the
3005         inspector after resizing the view.
3006
3007         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3008         (testInspectorDefault):
3009
3010 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3011
3012         Require Python 2.7 version
3013         https://bugs.webkit.org/show_bug.cgi?id=137112
3014
3015         Reviewed by Csaba Osztrogonác.
3016
3017         * Scripts/ensure-valid-python:
3018         (checkPythonVersion):
3019         * Scripts/webkitpy/common/version_check.py:
3020
3021 2014-09-30  Martin Hock  <mhock@apple.com>
3022
3023         Skip a JSC test after r174036.
3024         https://bugs.webkit.org/show_bug.cgi?id=137236
3025
3026         Reviewed by Csaba Osztrogonác.
3027
3028         * Scripts/run-javascriptcore-tests:
3029
3030 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3031
3032         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
3033         https://bugs.webkit.org/show_bug.cgi?id=137212
3034
3035         This moves TestNetscapePlugin to a new folder (lib/plugins).
3036         We should not use the same directory for TestNetscapePlugin and
3037         the other libraries, because we end up scanning all the .so in the
3038         lib dir for every test.
3039
3040         Reviewed by Carlos Garcia Campos.
3041
3042         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
3043         * Scripts/webkitpy/port/efl.py:
3044         (EflPort.setup_environ_for_server): Update plugin path.
3045         * Scripts/webkitpy/port/gtk.py:
3046         (GtkPort.setup_environ_for_server): Update plugin path.
3047         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
3048
3049 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3050
3051         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
3052
3053         Rubber-stamped by Tim Horton.
3054
3055         * QueueStatusServer/app.yaml:
3056         * QueueStatusServer/handlers/statusbubble.py:
3057         (StatusBubble._build_bubble):
3058
3059 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3060
3061         Typo fix, suggested by Tim Horton.
3062
3063         * QueueStatusServer/handlers/statusbubble.py:
3064         (StatusBubble._build_message_for_provisional_failure):
3065
3066 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3067
3068         Improve Bugzilla status bubbles
3069         https://bugs.webkit.org/show_bug.cgi?id=137232
3070
3071         Reviewed by Ryosuke Niwa.
3072
3073         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
3074
3075         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
3076         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
3077         that are stuck, as it was only confusing that they disappeared after 99.
3078
3079         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
3080         by old bubbles. We need a lot more information to determine color, so the implementation
3081         can not be here.
3082
3083         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
3084         always have a link for consistency. Added code to convert timestamps in tooltips
3085         to local time zone.
3086
3087 2014-09-29  Commit Queue  <commit-queue@webkit.org>
3088
3089         Unreviewed, rolling out r174045.
3090         https://bugs.webkit.org/show_bug.cgi?id=137231
3091
3092         Introduced a crash during page loading tests on Mac (Requested
3093         by rniwa on #webkit).
3094
3095         Reverted changeset:
3096
3097         "Replace OSObjectPtr with RetainPtr/adoptOS"
3098         https://bugs.webkit.org/show_bug.cgi?id=137158
3099         http://trac.webkit.org/changeset/174045
3100
3101 2014-09-29  Tim Horton  <timothy_horton@apple.com>
3102
3103         Add Jake as a contributor.
3104
3105         * Scripts/webkitpy/common/config/contributors.json:
3106
3107 2014-09-29  Roger Fong  <roger_fong@apple.com>
3108
3109         [Windows] Skip a javascriptcore test following r174036.
3110
3111         * Scripts/run-javascriptcore-tests:
3112
3113 2014-09-29  Roger Fong  <roger_fong@apple.com>
3114
3115         [Windows] Reduce number of processes used by NRWT on Windows to 1.
3116
3117         * Scripts/webkitpy/port/win.py:
3118         (WinPort.default_child_processes):
3119         Reduce number of processes to 1 so we can get a good baseline for what failures
3120         we should be expecting to see from the Windows bots.
3121
3122 2014-09-29  Darin Adler  <darin@apple.com>
3123
3124         Tweak and tighten SVG font converter
3125         https://bugs.webkit.org/show_bug.cgi?id=136956
3126
3127         Reviewed by Myles Maxfield.
3128
3129         I was investigating behavior of String::toInt, String::toDouble, and
3130         String::toFloat for various failure cases, and decided to start some
3131         unit tests for those functions here.
3132
3133         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3134         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
3135         StringToDouble testing.
3136
3137 2014-09-29  Philippe Normand  <pnormand@igalia.com>
3138
3139         [GTK][CMake] TestWebCore target build sometimes fail
3140         https://bugs.webkit.org/show_bug.cgi?id=137207
3141
3142         Reviewed by Csaba Osztrogon.
3143
3144         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
3145         headers are generated before the TestWebCore target is built.
3146
3147 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3148
3149         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
3150         https://bugs.webkit.org/show_bug.cgi?id=137209
3151
3152         Reviewed by Philippe Normand.
3153
3154         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
3155         from the WebCore test sources.
3156
3157 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3158
3159         Allow webkit-patch upload to respect the --directory argument with git checkouts
3160         https://bugs.webkit.org/show_bug.cgi?id=137166
3161
3162         Reviewed by Darin Adler.
3163
3164         We simply hadn't plumbed it through.
3165
3166         * Scripts/webkitpy/common/checkout/scm/detection.py:
3167         (SCMDetector.detect_scm_system):
3168         * Scripts/webkitpy/common/checkout/scm/git.py:
3169         (Git.__init__):
3170         (Git.changed_files):
3171
3172 2014-09-26  Sam Weinig  <sam@webkit.org>
3173
3174         Replace OSObjectPtr with RetainPtr/adoptOS
3175         https://bugs.webkit.org/show_bug.cgi?id=137158
3176
3177         Reviewed by Dan Bernstein.
3178
3179         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3180         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
3181         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
3182         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
3183
3184 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
3185
3186         Disable function.arguments
3187         https://bugs.webkit.org/show_bug.cgi?id=137167
3188
3189         Rubber stamped by Geoffrey Garen
3190         
3191         Enable the feature by default during tests.
3192
3193         * Scripts/run-jsc-stress-tests:
3194
3195 2014-09-26  Beth Dakin  <bdakin@apple.com>
3196
3197         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
3198         https://bugs.webkit.org/show_bug.cgi?id=137089
3199
3200         Reviewed by Tim Horton.
3201
3202         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
3203         tests run at 1x, but that code does not seem to execute at the right time for 
3204         these tests, so if we just ensure we start out at 1x, that appears to fix these 
3205         tests and does not break the HiDPI tests either.
3206         * WebKitTestRunner/TestController.cpp:
3207         (WTR::TestController::createWebViewWithOptions):
3208
3209 2014-09-26  Roger Fong  <roger_fong@apple.com>
3210
3211         [Windows] Decrease default number of child processes used by Windows.
3212
3213         * Scripts/webkitpy/port/win.py:
3214         (WinPort.default_child_processes):
3215         Having too many seems to cause many tests to crash or timeout. 
3216         We may even need to make it have only 1 child process if we’re still seeing problems after this.
3217
3218 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3219
3220         Mac EWS bots do not keep logs as promised
3221         https://bugs.webkit.org/show_bug.cgi?id=137151
3222
3223         Reviewed by Ryosuke Niwa.
3224
3225         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
3226
3227 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3228
3229         Get rid of webkit-queues dashboard
3230         https://bugs.webkit.org/show_bug.cgi?id=137141
3231
3232         Reviewed by Ryosuke Niwa.
3233
3234         * QueueStatusServer/app.yaml: Updated version.
3235
3236         * QueueStatusServer/templates/dashboard.html: Removed.
3237         * QueueStatusServer/handlers/dashboard.py: Removed.
3238         * QueueStatusServer/main.py:
3239         Kill it!
3240
3241         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
3242         (.status-cell): Deleted.
3243         (.status-cell:hover): Deleted.
3244         (.status-cell.pass): Deleted.
3245         (.status-cell.fail): Deleted.
3246         (.status-cell.pending): Deleted.
3247         (.status-cell.error): Deleted.
3248         * QueueStatusServer/stylesheets/dashboard.css: Removed.
3249         * QueueStatusServer/templates/activebots.html:
3250         * QueueStatusServer/templates/patch.html:
3251         * QueueStatusServer/templates/queuestatus.html:
3252         * QueueStatusServer/templates/recentstatus.html:
3253         Renamed dashboard.css to common.css, and removed dashboard-only rules.
3254
3255 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3256
3257         Get rid of Retry status in webkit-queues
3258         https://bugs.webkit.org/show_bug.cgi?id=137135
3259
3260         Reviewed by Ryosuke Niwa.
3261
3262         * QueueStatusServer/config/messages.py: Removed Retry.
3263
3264         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
3265         no longer needs to check the latest status. It just always both unlocks the patch
3266         and removes it from WorkItems.
3267
3268         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
3269         I don't understand why we even needed to check for retries here, but now that there
3270         are no retries, that code can go to /dev/null.
3271
3272         * QueueStatusServer/loggers/recordpatchevent.py:
3273         (RecordPatchEvent.started):
3274         (RecordPatchEvent.retrying): Deleted.
3275         Fixed retry counting, it should work for all queues now.
3276
3277         * QueueStatusServer/model/queuestatus.py:
3278         (QueueStatus.is_retry_request): Deleted. These are no more.
3279
3280         * Scripts/webkitpy/common/net/statusserver_mock.py:
3281         (MockStatusServer.release_lock):
3282         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3283         Did whatever it took to keep passing the tests. The particular test doesn't seem
3284         quite right, but whatever.
3285
3286         * Scripts/webkitpy/tool/commands/queues.py:
3287         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
3288         and let others pick up. Also, added explicit returns for clarity.
3289         (AbstractPatchQueue._did_retry): Deleted.
3290
3291 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3292
3293         [EFL] Fix the gst-libav build on ARM Thumb2
3294         https://bugs.webkit.org/show_bug.cgi?id=137022
3295
3296         Reviewed by Zoltan Herczeg.
3297
3298         * efl/jhbuild.modules:
3299         * efl/patches/gst-libav.patch: Added.
3300
3301 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3302
3303         [EFL] Bump up dependencies not to conflict with the GTK port.
3304         https://bugs.webkit.org/show_bug.cgi?id=137143
3305
3306         Reviewed by Gyuyoung Kim.
3307
3308         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
3309         installing and removing different versions of libgnutls-dev, thus
3310         hindering the development for both ports on the same machine. GTK is
3311         using the newer version of the package, now bumping up EFL to use the 
3312         same.
3313
3314         * efl/install-dependencies:
3315
3316 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
3317
3318         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
3319         https://bugs.webkit.org/show_bug.cgi?id=136854
3320
3321         Reviewed by Gyuyoung Kim.
3322
3323         'Escape' key should exit fullscreen first and then should be used to stop page load.
3324
3325         * MiniBrowser/efl/main.c:
3326         (on_key_down):
3327
3328 2014-09-25  Dean Jackson  <dino@apple.com>
3329
3330         Add Said to the contributors list so his name completes in bugzilla.
3331
3332         * Scripts/webkitpy/common/config/contributors.json:
3333
3334 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
3335
3336         EWS only repeats its cycle every two hours
3337         https://bugs.webkit.org/show_bug.cgi?id=137129
3338
3339         Reviewed by Ryosuke Niwa.
3340
3341         * QueueStatusServer/app.yaml: Updated version.
3342
3343         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
3344
3345         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
3346         the patch from work items.
3347
3348         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
3349
3350         * QueueStatusServer/main.py: Added release-lock.
3351
3352         * QueueStatusServer/model/activeworkitems.py:
3353         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
3354
3355         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
3356         we don't want it to be immediately picked up again, it's better to give other patches
3357         a chance.
3358
3359         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
3360         these interactive versions, but OK.
3361
3362         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
3363         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
3364         or svn is down).
3365
3366         * Scripts/webkitpy/tool/commands/queues.py:
3367         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
3368         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
3369         meaning that these handlers could never do the right thing. We'd either get a duplicate
3370         _did_fail, or try to unlock an already unlocked patch.
3371         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
3372         making it eligible for retry immediately.
3373
3374         * Scripts/webkitpy/common/net/statusserver.py:
3375         (StatusServer._post_release_lock):
3376         (StatusServer.release_lock):
3377         Added a call to release-lock.
3378
3379 2014-09-25  Roger Fong  <roger_fong@apple.com>
3380
3381         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
3382
3383         * Scripts/webkitpy/common/system/path.py:
3384         (_CygPath.convert):
3385
3386 2014-09-25  Roger Fong  <roger_fong@apple.com>
3387
3388         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
3389
3390         * Scripts/webkitpy/common/system/path.py:
3391         (_CygPath.convert):
3392
3393 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3394
3395         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
3396         https://bugs.webkit.org/show_bug.cgi?id=136377
3397
3398         Reviewed by Philippe Normand.
3399
3400         * Scripts/webkitdirs.pm:
3401         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
3402
3403 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
3404
3405         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
3406         https://bugs.webkit.org/show_bug.cgi?id=137117
3407
3408         Tools/efl/install-dependencies relies on apt-get to install packages.
3409         Unfortunately, if a package does not exist (e.g., for a given
3410         architecture) then apt-get install is not able to ignore the missing
3411         package and install the rest but fails to run entirely (and there
3412         seems to be no intent to change this behaviour).
3413
3414         On ARM64, the luajit package is missing and currently it needs manual
3415         editing of install-dependencies to get the script install as much as it
3416         can.
3417
3418         This patch separates the installation of the universally available
3419         packages from those which might not be available for all architectures.
3420
3421         Reviewed by Gyuyoung Kim.
3422
3423         * efl/install-dependencies:
3424
3425 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
3426
3427         Remove WinCE port from trunk
3428         https://bugs.webkit.org/show_bug.cgi?id=136951
3429
3430         Reviewed by Alex Christensen.
3431
3432         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3433         (_should_file_trigger_build):
3434         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3435         (ShouldBuildTest):
3436         * CMakeLists.txt:
3437         * DumpRenderTree/win/DRTDataObject.cpp:
3438         (DRTDataObject::CopyMedium):
3439         * Scripts/build-webkit:
3440         * Scripts/webkit-build-directory:
3441         * Scripts/webkitdirs.pm:
3442         (argumentsForConfiguration):
3443         (builtDylibPathForName):
3444         (isAppleWinWebKit):
3445         (launcherPath):
3446         (launcherName):
3447         (shouldRemoveCMakeCache):
3448         (cmakeBasedPortArguments):
3449         (cmakeBasedPortName):
3450         (isCMakeBuild):
3451         (isWinCE): Deleted.
3452         (determineIsWinCE): Deleted.
3453         * Scripts/webkitperl/FeatureList.pm:
3454         * Scripts/webkitpy/port/port_testcase.py:
3455         (test_apache_config_file_name_for_platform):
3456         * TestWebKitAPI/config.h:
3457         * WinCELauncher/CMakeLists.txt: Removed.
3458         * WinCELauncher/main.cpp: Removed.
3459         * gtk/manifest.txt:
3460
3461 2014-09-23  David Farler  <dfarler@apple.com>
3462
3463         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
3464         https://bugs.webkit.org/show_bug.cgi?id=136895
3465
3466         Reviewed by David Kilzer.
3467
3468         Create Device, DeviceType, and Runtime data classes.
3469         Create Simulator class represent simctl output.
3470
3471         Wherever possible, use structured data classes anywhere a raw
3472         identifier or UDID string was used for a cleaner implementation
3473         and to encapsulate the inherent fragility of scraping simctl output.
3474
3475         Create a suitably named testing device if one doesn't exist.
3476
3477         Finally, accurately handle having multiple simulator runtimes (SDKs)
3478         installed in the active Xcode.app bundle.
3479
3480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3481         (_set_up_derived_options):
3482         * Scripts/webkitpy/port/driver.py:
3483         (IOSSimulatorDriver.cmd_line):
3484         Construct DeviceType and Runtime objects from identifiers passed at the
3485         command line, still providing sensible defaults for 32- and 64-bit testing.
3486         * Scripts/webkitpy/port/ios.py:
3487         (IOSSimulatorPort.__init__):
3488         (IOSSimulatorPort.setup_test_run):
3489         (IOSSimulatorPort):
3490         (IOSSimulatorPort.testing_device):
3491         Cache the testing device once it is created or found.
3492         (IOSSimulatorPort.reset_preferences):
3493         Get the device path from the Device object instead of consructing it
3494         in the port class.
3495         (IOSSimulatorPort.simulator_udid): Deleted.
3496         Get the UDID from the testing_device :: Device object itself.
3497         * Scripts/webkitpy/xcode/simulator.py:
3498         Created Device, DeviceType, Runtime, and Simulator classes.
3499         (get_runtimes): Deleted.
3500         (get_devices): Deleted.
3501         (get_device_types): Deleted.
3502         (get_latest_runtime): Deleted.
3503
3504 2014-09-24  Roger Fong  <roger_fong@apple.com>
3505
3506         [Windows] Tentative fix for Windows test bots.
3507
3508         * Scripts/webkitpy/common/system/path.py:
3509         (_CygPath.convert):
3510
3511 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
3512
3513         Change more build.webkit.org links to https
3514         https://bugs.webkit.org/show_bug.cgi?id=137049
3515
3516         Reviewed by Csaba Osztrogonác.
3517
3518         Fix appspot, svn.webkit.org and Trac links.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3524         (ViewController.prototype._domForBuildName):
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3529         (.):
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3531         (EWS):
3532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3534         (TestHistory):
3535         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3536
3537 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
3538
3539         Update the list of u-szeged contributors.
3540
3541         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
3542
3543         * Scripts/webkitpy/common/config/contributors.json:
3544
3545 2014-09-23  Roger Fong  <roger_fong@apple.com>
3546
3547         [Windows] More debugging for the Windows bots.
3548
3549         * Scripts/webkitpy/common/system/path.py:
3550         (_CygPath):
3551
3552 2014-09-23  Roger Fong  <roger_fong@apple.com>
3553
3554         Unreviewed. Fix for r173899, those tabs should be spaces.
3555
3556         * Scripts/webkitpy/port/driver.py:
3557         (Driver._command_from_driver_input):
3558         (Driver): Deleted.
3559
3560 2014-09-23  Roger Fong  <roger_fong@apple.com>
3561
3562         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
3563
3564         * Scripts/webkitpy/port/driver.py:
3565         (Driver):
3566
3567 2014-09-23  Jer Noble  <jer.noble@apple.com>
3568
3569         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
3570         https://bugs.webkit.org/show_bug.cgi?id=137031
3571
3572         Reviewed by Joseph Pecoraro.
3573
3574         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
3575         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
3576         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
3577         ChangeLog locations before passing them to createCommitMessage().
3578
3579         * Scripts/commit-log-editor:
3580
3581 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3582
3583         W3C test importer should detect manual and reference tests according their filenames
3584         https://bugs.webkit.org/show_bug.cgi?id=133852
3585
3586         Reviewed by Bem Jones-Bey.
3587
3588         * Scripts/webkitpy/w3c/test_parser.py:
3589         (TestParser.analyze_test): Adding checks based on WPT filename rules.
3590         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
3591         (TestParser):
3592         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
3593         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
3594         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3595         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
3596
3597 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3598
3599         Unreviewed, add Rebecca Hauck as a contributor.
3600
3601         * Scripts/webkitpy/common/config/contributors.json:
3602
3603 2014-09-23  David Kilzer  <ddkilzer@apple.com>
3604
3605         Switch build.webkit.org URLs to https
3606
3607         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3608
3609         * TestResultServer/app.yaml: Update version to this commit
3610         revision.
3611
3612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3616         (WebKitBuildbot):
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3619         * BuildSlaveSupport/build.webk