Unreviewed, rolling out r141153.
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-29  Alan Cutter  <alancutter@chromium.org>
2
3         MockWeb should be able to serve mock web content
4         https://bugs.webkit.org/show_bug.cgi?id=108240
5
6         Reviewed by Dirk Pranke.
7
8         Added the ability to have MockWeb serve mock web data.
9
10         * Scripts/webkitpy/common/host_mock.py:
11         (MockHost.__init__):
12         * Scripts/webkitpy/common/net/web_mock.py:
13         (MockWeb.__init__):
14         (MockWeb.get_binary):
15
16 2013-01-29  Jessie Berlin  <jberlin@apple.com>
17
18         run-api-tests should have an option to specify root
19         https://bugs.webkit.org/show_bug.cgi?id=108210
20
21         Reviewed by Ryosuke Niwa.
22
23         * Scripts/run-api-tests:
24         Add the option and use it to set the configuration product directory. Since it is supposed
25         to point to the built products, do not build the products if root is specified (this mimics
26         the behavior of run-javascriptcore-tests).
27
28 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
29
30         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
31         https://bugs.webkit.org/show_bug.cgi?id=108122
32
33         Reviewed by Antonio Gomes.
34
35         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
36
37         * MiniBrowser/efl/main.c:
38         (on_key_down): Add 'F11' key handler.
39
40 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
41
42         [CMake] Use offical Windows CE support
43         https://bugs.webkit.org/show_bug.cgi?id=108061
44
45         Reviewed by Laszlo Gombos.
46
47         Recent version of CMake has added Windows CE support, but uses a
48         slightly different interface than the patched version used before.
49         Change the command line parameters to use the offical CMake binaries.
50
51         * Scripts/webkitdirs.pm:
52         (cmakeBasedPortArguments):
53
54 2013-01-29  Alan Cutter  <alancutter@chromium.org>
55
56         QueueStatusServer needs pages to display historical queue data
57         https://bugs.webkit.org/show_bug.cgi?id=107659
58
59         Reviewed by Eric Seidel.
60
61         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
62
63         * QueueStatusServer/app.yaml:
64         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
65         (get_time_unit):
66         * QueueStatusServer/filters/webkit_extras.py:
67         (webkit_linkify):
68         (webkit_bug_id):
69         (webkit_attachment_id):
70         (results_link):
71         (queue_status_link):
72         (queue_charts_link):
73         * QueueStatusServer/handlers/queuecharts.py: Added.
74         (QueueCharts):
75         (QueueCharts.get):
76         (QueueCharts._get_min_med_max):
77         (QueueCharts._get_patch_data):
78         (QueueCharts._get_patch_logs):
79         (QueueCharts._get_queue_data):
80         (QueueCharts._get_queue_logs):
81         (QueueCharts._get_time_unit):
82         (QueueCharts._get_timestamp):
83         (QueueCharts._get_view_range):
84         * QueueStatusServer/handlers/queuestatus.py:
85         (QueueStatus.get):
86         * QueueStatusServer/index.yaml:
87         * QueueStatusServer/main.py:
88         * QueueStatusServer/model/queuelog.py:
89         (QueueLog):
90         (QueueLog.create_key):
91         (QueueLog.get_at):
92         (QueueLog.get_current):
93         (QueueLog.get_or_create):
94         (QueueLog._get_or_create_txn):
95         * QueueStatusServer/stylesheets/charts.css: Added.
96         (.chart):
97         (.choices):
98         * QueueStatusServer/templates/queuecharts.html: Added.
99         * QueueStatusServer/templates/queuestatus.html:
100
101 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
102
103         [GTK] Missing build flags when building with Harfbuzz
104         https://bugs.webkit.org/show_bug.cgi?id=108174
105
106         Reviewed by Martin Robinson.
107
108         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
109         parameter will be added to linking lines when needed.
110
111         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
112         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
113         * TestWebKitAPI/GNUmakefile.am: Ditto.
114
115 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
116
117         [GTK] Implement resources API using injected bundle
118         https://bugs.webkit.org/show_bug.cgi?id=107457
119
120         Reviewed by Sam Weinig.
121
122         * Scripts/run-gtk-tests:
123         (TestRunner): Unksip resources unit tests.
124
125 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
126
127         Unreviewed, updated my email information.
128
129         * Scripts/webkitpy/common/config/committers.py:
130
131 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
132
133         [chromium] delete DRTTestRunner
134         https://bugs.webkit.org/show_bug.cgi?id=108082
135
136         Reviewed by Adam Barth.
137
138         * DumpRenderTree/DumpRenderTree.gypi:
139         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
140         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
141         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
142         (WebTestRunner::WebTestDelegate::testFinished):
143         (WebTestRunner::WebTestDelegate::testTimedOut):
144         (WebTestRunner::WebTestDelegate::isBeingDebugged):
145         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
146         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
147         (WebTestRunner::WebTestDelegate::navigationEntryCount):
148         (WebTestRunner::WebTestDelegate::windowCount):
149         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
150         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
151         (WebTestRunner::WebTestDelegate::goToOffset):
152         (WebTestRunner::WebTestDelegate::reload):
153         (WebTestRunner::WebTestDelegate::loadURLForFrame):
154         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
155         (WebTestRunner::WebTestRunner::policyDelegateDone):
156         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
157         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
158         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
159         (WebTestRunner):
160         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
161         (WebTestRunner::TestRunner::WorkQueue::processWork):
162         (WebTestRunner::TestRunner::WorkQueue::reset):
163         (WebTestRunner::TestRunner::WorkQueue::addWork):
164         (WebTestRunner::TestRunner::TestRunner):
165         (WebTestRunner::TestRunner::reset):
166         (WebTestRunner::TestRunner::policyDelegateDone):
167         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
168         (WebTestRunner::TestRunner::waitUntilDone):
169         (WebTestRunner::TestRunner::notifyDone):
170         (WebTestRunner::TestRunner::completeNotifyDone):
171         (WorkItemBackForward):
172         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
173         (WebTestRunner::WorkItemBackForward::run):
174         (WebTestRunner::TestRunner::queueBackNavigation):
175         (WebTestRunner::TestRunner::queueForwardNavigation):
176         (WorkItemReload):
177         (WebTestRunner::WorkItemReload::run):
178         (WebTestRunner::TestRunner::queueReload):
179         (WorkItemLoadingScript):
180         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
181         (WebTestRunner::WorkItemLoadingScript::run):
182         (WorkItemNonLoadingScript):
183         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
184         (WebTestRunner::WorkItemNonLoadingScript::run):
185         (WebTestRunner::TestRunner::queueLoadingScript):
186         (WebTestRunner::TestRunner::queueNonLoadingScript):
187         (WorkItemLoad):
188         (WebTestRunner::WorkItemLoad::WorkItemLoad):
189         (WebTestRunner::WorkItemLoad::run):
190         (WebTestRunner::TestRunner::queueLoad):
191         (WorkItemLoadHTMLString):
192         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
193         (WebTestRunner::WorkItemLoadHTMLString::run):
194         (WebTestRunner::TestRunner::queueLoadHTMLString):
195         (WebTestRunner::TestRunner::locationChangeDone):
196         (WebTestRunner::TestRunner::windowCount):
197         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
198         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
199         (WebTestRunner::TestRunner::waitForPolicyDelegate):
200         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
201         (TestRunner):
202         (WorkItem):
203         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
204         (WorkQueue):
205         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
206         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
207         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
208         (WebTestRunner::TestRunner::WorkQueue::taskList):
209         * DumpRenderTree/chromium/TestShell.cpp:
210         (TestShell::initialize):
211         (TestShell::runFileTest):
212         (TestShell::loadURL):
213         (TestShell::createNewWindow):
214         * DumpRenderTree/chromium/TestShell.h:
215         (TestShell::testRunner):
216         (TestShell):
217         * DumpRenderTree/chromium/WebViewHost.cpp:
218         (WebViewHost::testFinished):
219         (WebViewHost::testTimedOut):
220         (WebViewHost::isBeingDebugged):
221         (WebViewHost::layoutTestTimeout):
222         (WebViewHost::closeRemainingWindows):
223         (WebViewHost::navigationEntryCount):
224         (WebViewHost::windowCount):
225         (WebViewHost::setCustomPolicyDelegate):
226         (WebViewHost::waitForPolicyDelegate):
227         (WebViewHost::goToOffset):
228         (WebViewHost::reload):
229         (WebViewHost::loadURLForFrame):
230         (WebViewHost::shutdown):
231         (WebViewHost::testRunner):
232         * DumpRenderTree/chromium/WebViewHost.h:
233         (WebTestRunner):
234         (WebViewHost):
235
236 2013-01-28  Timothy Loh  <timloh@chromium.com>
237
238         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
239         https://bugs.webkit.org/show_bug.cgi?id=107903
240
241         Reviewed by Eric Seidel.
242
243         To make ChangeLog and PrepareChangeLog easier to test, we can use
244         FileSystem objects instead of just passing around paths.
245
246         * Scripts/webkitpy/common/checkout/changelog.py:
247         (ChangeLog.__init__):
248         (ChangeLog.parse_latest_entry_from_file):
249         (ChangeLog.parse_entries_from_file):
250         (ChangeLog.latest_entry):
251         (ChangeLog.update_with_unreviewed_message):
252         (ChangeLog.set_reviewer):
253         (ChangeLog.set_short_description_and_bug_url):
254         (ChangeLog.delete_entries):
255         (ChangeLog.prepend_text):
256         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
257         (ChangeLogTest):
258         (test_parse_log_entries_from_changelog):
259         (test_latest_entry_parse_single_entry):
260         (test_set_reviewer):
261         (test_set_short_description_and_bug_url):
262         (test_delete_entries):
263         (test_prepend_text):
264         * Scripts/webkitpy/common/system/filesystem_mock.py:
265         (ReadableTextFileObject.__init__):
266         * Scripts/webkitpy/tool/steps/preparechangelog.py:
267         (PrepareChangeLog._ensure_bug_url):
268         (PrepareChangeLog._resolve_existing_entry):
269         (PrepareChangeLog.run):
270         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
271         (test_ensure_bug_url):
272         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
273         (_assert_message_for_revert_output):
274
275 2013-01-28  Raymond Toy  <rtoy@google.com>
276
277         Add myself to committers.py
278         https://bugs.webkit.org/show_bug.cgi?id=107992
279
280         Reviewed by kbr@google.com.
281
282         * Scripts/webkitpy/common/config/committers.py:
283
284 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
285
286         [Mac] Update PageVisibilityState when WebView is hidden / visible
287         https://bugs.webkit.org/show_bug.cgi?id=107509
288
289         Reviewed by Sam Weinig.
290
291         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
292         automatically changes between hidden and visible as the view is added
293         and removed from window, or when it is in a window that changes
294         visibility, for instance by minimizing / deminimizing.
295
296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
297         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
298         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
299         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
300         (runJavaScriptAlert):
301         (PageVisibilityStateWithWindowChanges):
302         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
303         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
304         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
305         (TestWebKitAPI::TEST_F):
306         Test visibility state of a page in a WebView/WKView with different window states.
307
308         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
309         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
310         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
311         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
312         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
313         Add a WK1 and WK2 teardownView to balance initializeView.
314
315 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
316
317         Improve PageVisibility API with enums
318         https://bugs.webkit.org/show_bug.cgi?id=107364
319
320         Reviewed by Sam Weinig.
321
322         * DumpRenderTree/mac/TestRunnerMac.mm:
323         (TestRunner::resetPageVisibility):
324         (TestRunner::setPageVisibility):
325         Update the WK1 test code to use the new WK1 enums.
326
327         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
328         (WTR::InjectedBundle::setVisibilityState):
329         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
330         (InjectedBundle):
331         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
332         (WTR::TestRunner::setPageVisibility):
333         (WTR::TestRunner::resetPageVisibility):
334         * WebKitTestRunner/TestController.cpp:
335         (WTR::TestController::setVisibilityState):
336         * WebKitTestRunner/TestController.h:
337         (TestController):
338         * WebKitTestRunner/TestInvocation.cpp:
339         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
340         Update the WK2 test code to use the new WK2 API and enums.
341
342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
343         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
344         (TestWebKitAPI):
345         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
346         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
347         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
348         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
349         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
350         (TestWebKitAPI::didRunStep4InStatePreview):
351         (TestWebKitAPI::TEST):
352         Test the new WK2 API with all enum types.
353
354 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
355
356         [chromium] remove temporary define used for updating TestRunner API
357
358         Unreviewed. Clean-up change.
359
360         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
361
362 2013-01-28  James Craig  <james@cookiecrook.com>
363
364         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
365         https://bugs.webkit.org/show_bug.cgi?id=107650
366
367         Reviewed by Chris Fleizach.
368
369         Updating accessibility strings and accessors for DL/DT/DD.
370
371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
372         (createDescriptionList):
373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
374         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
375
376 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
377
378         [GTK][WTR] Update layoutTestController.pathToLocalResource
379         https://bugs.webkit.org/show_bug.cgi?id=107538
380
381         Reviewed by Martin Robinson.
382
383         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
384         (WTR::TestRunner::pathToLocalResource): Update implementation based on
385         DRT code.
386
387 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
388
389         [GTK][WTR] Move getTopLevelPath() to utilities file
390         https://bugs.webkit.org/show_bug.cgi?id=107541
391
392         Reviewed by Martin Robinson.
393
394         * WebKitTestRunner/GNUmakefile.am: Add new files.
395         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
396         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
397         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
398         (WTR):
399         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
400         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
401         (WTR): Add new method header and documentation.
402
403 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
404
405         [EFL] Include Ecore_Getopt.h in MiniBrowser.
406         https://bugs.webkit.org/show_bug.cgi?id=108067
407
408         Reviewed by Kenneth Rohde Christiansen.
409
410         Be explicit and include Ecore_Getopt.h since we use it for parsing
411         command line options. It is safer than relying on other headers
412         including it for us.
413
414         * MiniBrowser/efl/main.c:
415
416 2013-01-28  Renata Hodovan  <reni@webkit.org>
417
418         [WK2] Putting QtWebProcess into a chrooted sandbox
419         https://bugs.webkit.org/show_bug.cgi?id=90005
420
421         Reviewed by Anders Carlsson and  Zoltan Herczeg.
422
423         Add feature flag for suid sandbox in linux.
424
425         * Scripts/webkitperl/FeatureList.pm:
426
427 2013-01-27  David Farler  <dfarler@apple.com>
428
429         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
430         https://bugs.webkit.org/show_bug.cgi?id=108028
431
432         Reviewed by Dan Bernstein.
433
434         * DumpRenderTree/Makefile: Reverted.
435         * Makefile: Reverted.
436         * Scripts/webkitdirs.pm: Reverted.
437
438 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
439
440         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
441         https://bugs.webkit.org/show_bug.cgi?id=106740
442
443         Reviewed by Benjamin Poulain.
444
445         * DumpRenderTree/config.h:
446         * WinLauncher/stdafx.h:
447
448 2013-01-26  David Farler  <dfarler@apple.com>
449
450         Makefiles should work for arbitrary SDKs and architectures on Apple ports
451         https://bugs.webkit.org/show_bug.cgi?id=107863
452
453         Reviewed by David Kilzer.
454
455         * Makefile:
456         Added temporary filters for projects not yet building on iOS.
457         * DumpRenderTree/Makefile:
458         Building with iOS SDKs -> -target All-iOS
459         * Scripts/webkitdirs.pm:
460         (determineConfiguration):
461         Added --configuration switch detection.
462         (determineArchitecture):
463         Added --architecture and ARCH=(.*) switch detection.
464         (argumentsForConfiguration):
465         (determineXcodeSDK):
466         Look for --device, --simulator, and --sdk switches.
467         (xcodeSDK):
468         Added.
469         (XcodeOptions):
470         Determine Xcode SDK and generate -arch switches.
471
472 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
473
474         [chromium] move tracking of the top loading frame to TestRunner library
475         https://bugs.webkit.org/show_bug.cgi?id=107948
476
477         Reviewed by Adam Barth.
478
479         * DumpRenderTree/chromium/DRTTestRunner.cpp:
480         (DRTTestRunner::WorkQueue::processWorkSoon):
481         (DRTTestRunner::WorkQueue::processWork):
482         (DRTTestRunner::completeNotifyDone):
483         * DumpRenderTree/chromium/DRTTestRunner.h:
484         (DRTTestRunner):
485         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
486         (WebTestProxyBase):
487         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
488         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
489         (WebTestRunner::WebTestRunner::topLoadingFrame):
490         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
491         (WebTestRunner::TestRunner::TestRunner):
492         (WebTestRunner::TestRunner::reset):
493         (WebTestRunner::TestRunner::setTopLoadingFrame):
494         (WebTestRunner):
495         (WebTestRunner::TestRunner::topLoadingFrame):
496         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
497         (TestRunner):
498         (WebTestRunner::TestRunner::locationChangeDone):
499         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
500         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
501         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
502         (WebTestRunner::WebTestProxyBase::didFailLoad):
503         (WebTestRunner::WebTestProxyBase::didFinishLoad):
504         (WebTestRunner::WebTestProxyBase::locationChangeDone):
505         (WebTestRunner):
506         * DumpRenderTree/chromium/WebViewHost.cpp:
507         (WebViewHost::reset):
508         (WebViewHost::updateURL):
509         * DumpRenderTree/chromium/WebViewHost.h:
510         (WebViewHost):
511
512 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
513
514         Unreviewed, rolling out r140774.
515         http://trac.webkit.org/changeset/140774
516         https://bugs.webkit.org/show_bug.cgi?id=107932
517
518          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
519         and fastScrollingForFixedPosition are failing (Requested by
520         keishi on #webkit).
521
522         * DumpRenderTree/chromium/WebViewHost.cpp:
523         (WebViewHost::initializeLayerTreeView):
524         (WebViewHost::setWebWidget):
525
526 2013-01-25  Alan Cutter  <alancutter@chromium.org>
527
528         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
529         https://bugs.webkit.org/show_bug.cgi?id=107905
530
531         Reviewed by Eric Seidel.
532
533         Added line to EWS loop to clear /tmp of known Chromium test leak.
534         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
535
536         * EWSTools/start-queue.sh:
537
538 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
539
540         Update Anne's email address
541         https://bugs.webkit.org/show_bug.cgi?id=107866
542
543         Reviewed by Adam Barth.
544
545         * Scripts/webkitpy/common/config/committers.py:
546
547 2013-01-24  Alan Cutter  <alancutter@chromium.org>
548
549         HTTP 500 error between QueueStatusServer and bot(s)
550         https://bugs.webkit.org/show_bug.cgi?id=107184
551
552         Reviewed by Adam Barth.
553
554         Removed the use of memcache which was the source of the exception.
555
556         * QueueStatusServer/handlers/updatestatus.py:
557         (UpdateStatus.post):
558         * QueueStatusServer/model/attachment.py:
559         (Attachment):
560         (Attachment.summary):
561
562 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
563
564         Unreviewed, rolling out r140653.
565         http://trac.webkit.org/changeset/140653
566         https://bugs.webkit.org/show_bug.cgi?id=107916
567
568         Causes a temp file leak on the bots (Requested by abarth on
569         #webkit).
570
571         * DumpRenderTree/chromium/TestShell.cpp:
572         (TestShell::resetTestController):
573
574 2013-01-24  Eric Seidel  <eric@webkit.org>
575
576         Skip haslanded_unittest.py on systems which do not have interdiff installed
577         https://bugs.webkit.org/show_bug.cgi?id=106402
578
579         Unreviewed.
580
581         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
582         (HasLandedTest):
583
584 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
585
586         Disable the failing webkitpy test for now.
587
588         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
589
590 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
591
592         Fixing the diff_parser to correctly identify git diffs even with leading comments.
593         https://bugs.webkit.org/show_bug.cgi?id=107871
594
595         Reviewed by Eric Seidel.
596
597         * Scripts/webkitpy/common/checkout/diff_parser.py:
598         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
599         * Scripts/webkitpy/tool/steps/haslanded.py:
600
601 2013-01-24  James Robinson  <jamesr@chromium.org>
602
603         [chromium] Remove dead transitional code from WebViewImpl
604         https://bugs.webkit.org/show_bug.cgi?id=107889
605
606         Reviewed by Adrienne Walker.
607
608         * DumpRenderTree/chromium/WebViewHost.cpp:
609         (WebViewHost::initializeLayerTreeView):
610         (WebViewHost::setWebWidget):
611
612 2013-01-24  Joshua Bell  <jsbell@chromium.org>
613
614         Add watchlist for IndexedDB development, and add myself and others.
615
616         Unreviewed.
617
618         * Scripts/webkitpy/common/config/watchlist:
619
620 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
621
622         Abstract the logic for appending a UChar32 onto StringBuilder
623         https://bugs.webkit.org/show_bug.cgi?id=107505
624
625         Reviewed by Darin Adler.
626
627         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
628         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
629
630 2013-01-24  Erik Arvidsson  <arv@chromium.org>
631
632         Unreviewed, rolling out r140703.
633         http://trac.webkit.org/changeset/140703
634         https://bugs.webkit.org/show_bug.cgi?id=107556
635
636         r140561 was not the reason for the Android breakage
637
638         * DumpRenderTree/chromium/TestShell.cpp:
639         (TestShell::~TestShell):
640         (TestShell::closeWindow):
641         * DumpRenderTree/chromium/WebViewHost.cpp:
642         (WebViewHost::WebViewHost):
643         (WebViewHost::~WebViewHost):
644         (WebViewHost::shutdown):
645         * DumpRenderTree/chromium/WebViewHost.h:
646         (WebViewHost):
647
648 2013-01-24  Dean Jackson  <dino@apple.com>
649
650         Allow some plugin snapshot UI content to come from Injected Bundle
651         https://bugs.webkit.org/show_bug.cgi?id=107852
652
653         Reviewed by Anders Carlsson.
654
655         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
656         plugInExtraStyleSheet.
657
658         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
659         (WTR::InjectedBundlePage::InjectedBundlePage):
660
661 2013-01-24  Erik Arvidsson  <arv@chromium.org>
662
663         Unreviewed, rolling out r140561.
664         http://trac.webkit.org/changeset/140561
665         https://bugs.webkit.org/show_bug.cgi?id=107556
666
667         Suspected to break Android which prevens WebKit roll
668
669         * DumpRenderTree/chromium/TestShell.cpp:
670         (TestShell::~TestShell):
671         (TestShell::closeWindow):
672         * DumpRenderTree/chromium/WebViewHost.cpp:
673         (WebViewHost::WebViewHost):
674         (WebViewHost::~WebViewHost):
675         * DumpRenderTree/chromium/WebViewHost.h:
676         (WebViewHost):
677
678 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
679
680         Adding "has-landed" command to webkit-patch which compares a
681         committed patch to the changes which exist locally (ignoring the
682         ChangeLog file).
683
684         https://bugs.webkit.org/show_bug.cgi?id=106402
685
686         Reviewed by Eric Seidel.
687
688         * Scripts/webkitpy/common/checkout/diff_parser.py:
689         (git_diff_to_svn_diff):
690         * Scripts/webkitpy/common/net/bugzilla/bug.py:
691         (Bug.commit_revision):
692         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
693         (BugTest.test_is_in_comments):
694         (BugTest):
695         (BugTest.test_commit_revision):
696         * Scripts/webkitpy/tool/commands/upload.py:
697         (HasLanded):
698         * Scripts/webkitpy/tool/steps/__init__.py:
699         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
700         (HasLanded):
701         (HasLanded.convert_to_svn):
702         (HasLanded.strip_change_log):
703         (run):
704
705         * Scripts/webkitpy/common/net/bugzilla/bug.py:
706         (Bug.commit_revision):
707         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
708         (BugTest.test_is_in_comments):
709         (BugTest):
710         (BugTest.test_commit_revision):
711         * Scripts/webkitpy/tool/commands/upload.py:
712         (HasLanded):
713         * Scripts/webkitpy/tool/steps/__init__.py:
714         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
715         (HasLanded):
716         (HasLanded.convert_to_svn):
717         (HasLanded.strip_change_log):
718         (HasLanded.diff_diff):
719         (HasLanded.run):
720         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
721         (HasLandedTest):
722         (HasLandedTest.test_run):
723         (test_convert_to_svn_and_strip_change_log):
724
725 2013-01-24  Dan Carney  <dcarney@google.com>
726
727         [chromium] move most WebViewHost printf calls to WebTestProxy
728         https://bugs.webkit.org/show_bug.cgi?id=107553
729
730         Reviewed by Jochen Eisinger.
731
732         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
733         (WebKit):
734         (WebTestProxyBase):
735         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
736         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
737         (WebTestRunner::WebTestProxy::runModalAlertDialog):
738         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
739         (WebTestRunner::WebTestProxy::runModalPromptDialog):
740         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
741         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
742         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
743         (WebTestRunner::WebTestProxyBase::reset):
744         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
745         (WebTestRunner):
746         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
747         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
748         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
749         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
750         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
751         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
752         * DumpRenderTree/chromium/TestShell.cpp:
753         (TestShell::showDevTools):
754         * DumpRenderTree/chromium/WebViewHost.cpp:
755         (WebViewHost::didAddMessageToConsole):
756         (WebViewHost::runModalAlertDialog):
757         (WebViewHost::runModalConfirmDialog):
758         (WebViewHost::runModalPromptDialog):
759         (WebViewHost::runModalBeforeUnloadDialog):
760         (WebViewHost::unableToImplementPolicyWithError):
761         (WebViewHost::reset):
762         * DumpRenderTree/chromium/WebViewHost.h:
763         (WebViewHost):
764
765 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
766
767         [Chromium] Give webkit_support a chance to reset state between layout test runs
768         https://bugs.webkit.org/show_bug.cgi?id=107132
769
770         Reviewed by Adam Barth.
771
772         We currently only have need for this on OS(ANDROID), but now it
773         would be useful to have a hook for resetting state on all
774         platforms. Will soon be using this for IDBFactory initialization.
775
776         * DumpRenderTree/chromium/TestShell.cpp:
777         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
778
779 2013-01-23  Alan Cutter  <alancutter@chromium.org>
780
781         QueueStatusServer crashes in production on next-patch
782         https://bugs.webkit.org/show_bug.cgi?id=107775
783
784         Reviewed by Adam Barth.
785
786         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
787
788         * QueueStatusServer/app.yaml:
789         * QueueStatusServer/model/patchlog.py:
790         (PatchLog.calculate_wait_duration):
791         (PatchLog.calculate_process_duration):
792         (PatchLog):
793         (PatchLog._time_delta_to_seconds):
794
795 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
796
797         The previous patch wasn't complete. Finish reverting r139998 for real.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
800         (ProfilerAgent.getProfile):
801
802 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
803
804         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
805
806         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
807         (ProfilerAgent.getProfile):
808
809 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
810
811         [Chromium] Remove unused header files in chromium/public/platform/
812         https://bugs.webkit.org/show_bug.cgi?id=107741
813
814         Reviewed by James Robinson.
815
816         These header files have migrated to the new Platform directory.
817         This patch updates the remaining #include references and removes
818         the old files that did nothing but redirect to the new ones.
819
820         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
821         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
822
823 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
824
825         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
826         https://bugs.webkit.org/show_bug.cgi?id=107727
827
828         Reviewed by Gustavo Noronha Silva.
829
830         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
831         We are using the git repository now that github has deprecated the downloads feature.
832
833 2013-01-23  Tony Chang  <tony@chromium.org>
834
835         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
836
837         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
838         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
839         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
840         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
841
842 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
843
844         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
845         https://bugs.webkit.org/show_bug.cgi?id=107145
846
847         Reviewed by Adam Barth.
848
849         Part of a larger refactoring series; see tracking bug 82948.
850         
851         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
852         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
853         * DumpRenderTree/chromium/DRTDevToolsClient.h:
854         * DumpRenderTree/chromium/DRTTestRunner.cpp:
855         * DumpRenderTree/chromium/DRTTestRunner.h:
856         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
857         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
858         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
859         * DumpRenderTree/chromium/NotificationPresenter.cpp:
860         * DumpRenderTree/chromium/TestNavigationController.h:
861         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
862         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
863         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
864         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
865         (WebTestRunner):
866         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
867         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
868         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
869         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
870         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
871         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
872         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
873         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
874         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
875         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
876         * DumpRenderTree/chromium/TestShell.cpp:
877         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
878         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
879         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
880         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
881         * DumpRenderTree/chromium/WebViewHost.cpp:
882
883 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
884
885         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
886         https://bugs.webkit.org/show_bug.cgi?id=107556
887
888         Reviewed by Tony Chang.
889
890         WebViewHost initiates a navigation to about:blank in its destructor.
891         However, since WebTestProxy inherits from WebViewHost, at this point
892         the WebViewClient and WebFrameClient interfaces are already partially
893         destructed resulting in the use after free.
894
895         This does not affect the chromium implementation since it doesn't
896         invoke WebKit API methods in its destructor.
897
898         * DumpRenderTree/chromium/TestShell.cpp:
899         (TestShell::~TestShell):
900         (TestShell::closeWindow):
901         * DumpRenderTree/chromium/WebViewHost.cpp:
902         (WebViewHost::WebViewHost):
903         (WebViewHost::~WebViewHost):
904         (WebViewHost::shutdown):
905         * DumpRenderTree/chromium/WebViewHost.h:
906         (WebViewHost):
907
908 2013-01-23  Andrei Bucur  <abucur@adobe.com>
909
910         [CSS Regions] Create Regions watchlist
911         https://bugs.webkit.org/show_bug.cgi?id=107281
912
913         Reviewed by Adam Barth.
914
915         This patch adds 4 new definitions:
916         - RegionsDevelopment - used to track the development progress for regions
917         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
918         - RegionsUsage - used to track changes that make use of regions in all the code base
919
920         For now, the Adobe internal tracker is the only email address listening for these patterns.
921
922         * Scripts/webkitpy/common/config/watchlist:
923
924 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
925
926         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
927         https://bugs.webkit.org/show_bug.cgi?id=107523
928
929         Reviewed by Yury Semikhatsky.
930
931         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
932         (DRTDevToolsClient::isUnderTest):
933         (DRTDevToolsClient::call):
934         * DumpRenderTree/chromium/DRTDevToolsClient.h:
935         (DRTDevToolsClient):
936
937 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
938
939         Removing command line shortening as it makes it difficult to see the command during errors.
940         https://bugs.webkit.org/show_bug.cgi?id=107643
941
942         Reviewed by Eric Seidel.
943
944         * Scripts/webkitpy/common/system/executive.py:
945         (ScriptError):
946         (ScriptError.__init__):
947         * Scripts/webkitpy/common/system/executive_unittest.py:
948
949 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
950
951         Adding myself as contributor in committers.py (as requested by eseidel).
952         https://bugs.webkit.org/show_bug.cgi?id=107647
953
954         Reviewed by Eric Seidel.
955
956         * Scripts/webkitpy/common/config/committers.py:
957
958 2013-01-22  Alan Cutter  <alancutter@chromium.org>
959
960         Add monitoring of patches and queues to the QueueStatusServer
961         https://bugs.webkit.org/show_bug.cgi?id=107612
962
963         Reviewed by Adam Barth.
964
965         Created classes for recording events into the datastore and integrated them into the existing handlers.
966         Code for presenting the recorded data will come in a separate patch.
967
968         * QueueStatusServer/app.yaml:
969         * QueueStatusServer/config/__init__.py: Added.
970         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
971         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
972         * QueueStatusServer/handlers/nextpatch.py:
973         (NextPatch.get):
974         (NextPatch._assign_patch):
975         * QueueStatusServer/handlers/releasepatch.py:
976         (ReleasePatch.post):
977         * QueueStatusServer/handlers/updatestatus.py:
978         (UpdateStatus.post):
979         * QueueStatusServer/handlers/updateworkitems.py:
980         (UpdateWorkItems._parse_work_items_string):
981         (UpdateWorkItems):
982         (UpdateWorkItems._update_work_items_from_request):
983         (UpdateWorkItems._queue_from_request):
984         (UpdateWorkItems.post):
985         * QueueStatusServer/loggers/__init__.py: Added.
986         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
987         (RecordBotEvent):
988         (RecordBotEvent.activity):
989         * QueueStatusServer/loggers/recordpatchevent.py: Added.
990         (RecordPatchEvent):
991         (RecordPatchEvent.added):
992         (RecordPatchEvent.retrying):
993         (RecordPatchEvent.started):
994         (RecordPatchEvent.stopped):
995         (RecordPatchEvent.updated):
996         (RecordPatchEvent._get_patches_waiting):
997         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
998         (PatchLog):
999         (PatchLog.lookup):
1000         (PatchLog.calculate_wait_duration):
1001         (PatchLog.calculate_process_duration):
1002         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
1003         (QueueLog):
1004         (QueueLog.get_current):
1005         (QueueLog.create_key):
1006         * QueueStatusServer/model/queuestatus.py:
1007         (QueueStatus.is_retry_request):
1008
1009 2013-01-22  Timothy Loh  <timloh@chromium.com>
1010
1011         prepare-Changelog should support updating the list of changed files
1012         https://bugs.webkit.org/show_bug.cgi?id=74358
1013
1014         Reviewed by Eric Seidel.
1015
1016         Needing to re-make ChangeLog entries when the list of files/functions
1017         changes is a bit annoying, it'd be nice to have this more automated.
1018         This patch makes `webkit-patch update' update the date line and bug
1019         description if needed, and if the list of changed files/functions has
1020         changed, either updates the list (if there are no annotations), or
1021         otherwise appends the new list below.
1022
1023         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1024         (PrepareChangeLog._resolve_existing_entry):
1025         (PrepareChangeLog):
1026         (PrepareChangeLog._merge_entries):
1027         (PrepareChangeLog.run):
1028         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1029         (PrepareChangeLogTest.test_resolve_existing_entry):
1030         (make_entry):
1031         (test_ensure_bug_url):
1032
1033 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1034
1035         Use Python 2.7 unittest syntax in our unittests
1036         https://bugs.webkit.org/show_bug.cgi?id=105607
1037
1038         Reviewed by Eric Seidel.
1039
1040         * Scripts/webkitpy/**/*_unittest.py:
1041
1042 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1043
1044         Convert disable-msg to disable for new pylint.
1045         https://bugs.webkit.org/show_bug.cgi?id=107627
1046
1047         Reviewed by Eric Seidel.
1048
1049         * Scripts/webkitpy/common/checkout/scm/svn.py:
1050         (SVNRepository.has_authorization_for_realm):
1051         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1052         (Builder.force_build):
1053         * Scripts/webkitpy/common/system/executive_mock.py:
1054         (MockExecutive2.run_command):
1055         * Scripts/webkitpy/layout_tests/port/base.py:
1056         (Port.reference_files):
1057         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1058         (ChromiumPortTestCase.test_default_configuration):
1059         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1060         (PortTestCase.test_expectations_ordering):
1061         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1062         (HttpServerBase._check_that_all_ports_are_available):
1063         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1064         (AbstractLocalServerCommand.execute):
1065         * Scripts/webkitpy/tool/commands/download.py:
1066         (AbstractPatchProcessingCommand):
1067         * Scripts/webkitpy/tool/commands/rebaseline.py:
1068         (AbstractRebaseliningCommand):
1069         (AbstractParallelRebaselineCommand):
1070         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1071         (_BaseTestCase.setUp):
1072         (TestAnalyzeBaselines.setUp):
1073
1074 2013-01-22  Frank Farzan  <frankf@chromium.org>
1075
1076         Flakiness dashboard: update builders.jsonp
1077         https://bugs.webkit.org/show_bug.cgi?id=107610
1078
1079         Reviewed by Ojan Vafai.
1080
1081         * TestResultServer/static-dashboards/builders.jsonp:
1082
1083 2013-01-22  Frank Farzan  <frankf@chromium.org>
1084
1085         Add Android instrumentation tests from ChromiumLinux waterfall
1086         https://bugs.webkit.org/show_bug.cgi?id=107597
1087
1088         Reviewed by Ojan Vafai.
1089
1090         * TestResultServer/static-dashboards/builders.js:
1091         (loadBuildersList):
1092
1093 2013-01-21  Kentaro Hara  <haraken@chromium.org>
1094
1095         Implement UIEvent constructor
1096         https://bugs.webkit.org/show_bug.cgi?id=107430
1097
1098         Reviewed by Adam Barth.
1099
1100         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
1101
1102         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
1103         which is enabled on Safari and Chromium for now.
1104
1105         * Scripts/webkitperl/FeatureList.pm:
1106
1107 2013-01-22  Timothy Loh  <timloh@chromium.com>
1108
1109         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
1110         https://bugs.webkit.org/show_bug.cgi?id=107478
1111
1112         Reviewed by Eric Seidel.
1113
1114         On the road to resolving Bug 74358, we need a few more functions in
1115         changelog.py.
1116         To make things easier to mock, change @staticmethods to @classmethods.
1117
1118         * Scripts/webkitpy/common/checkout/changelog.py:
1119         (ChangeLogEntry):
1120         (ChangeLogEntry._parse_reviewer_text):
1121         (ChangeLogEntry._split_contributor_names):
1122         (ChangeLogEntry._parse_author_name_and_email):
1123         (ChangeLogEntry._parse_author_text):
1124         (ChangeLogEntry._parse_touched_functions):
1125         (ChangeLogEntry._parse_bug_description):
1126         (ChangeLogEntry._parse_entry):
1127         (ChangeLogEntry.date_line):
1128         (ChangeLogEntry.bug_description):
1129         (ChangeLogEntry.touched_functions):
1130         (ChangeLogEntry.touched_files_text):
1131         (ChangeLogEntry.is_touched_files_text_clean):
1132         (ChangeLog):
1133         (ChangeLog.parse_latest_entry_from_file):
1134         (ChangeLog._separate_revision_and_line):
1135         (ChangeLog.parse_entries_from_file):
1136         (ChangeLog.set_short_description_and_bug_url):
1137         (ChangeLog.delete_entries):
1138         (ChangeLog.prepend_text):
1139         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1140         (test_parse_log_entries_from_changelog):
1141         (test_latest_entry_parse):
1142         (test_set_short_description_and_bug_url):
1143         (test_delete_entries):
1144         (test_prepend_text):
1145
1146 2013-01-22  Lucas Forschler  <lforschler@apple.com>
1147
1148         Create a MAC EWS startup shell script.
1149
1150         Reviewed by Ryosuke Niwa.
1151
1152         * EWSTools/start-queue-mac.sh: Added.
1153
1154 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
1155
1156         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
1157         https://bugs.webkit.org/show_bug.cgi?id=107230
1158
1159         Reviewed by David Kilzer.
1160
1161         * DumpRenderTree/mac/TestRunnerMac.mm:
1162         (TestRunner::resetPageVisibility):
1163         Fix a typo in the original implementation. resetPageVisibility should
1164         pass initialState YES so an event is not dispatched, which causes
1165         issues in multiple tests. This now matches other ports.
1166
1167 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1168
1169         [GTK] Enable CSS Image Orientation feature
1170         https://bugs.webkit.org/show_bug.cgi?id=99040
1171
1172         Reviewed by Martin Robinson.
1173
1174         Enable the CSS Image Orientation feature in the development
1175         builds of the GTK port. The feature is still disabled in the release
1176         builds.
1177
1178         * Scripts/webkitperl/FeatureList.pm:
1179
1180 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1181
1182         [GTK] Enable the <template> element support in development builds
1183         https://bugs.webkit.org/show_bug.cgi?id=106575
1184
1185         Reviewed by Martin Robinson.
1186
1187         Enable the <template> element support in the development builds of the GTK port.
1188
1189         * Scripts/webkitperl/FeatureList.pm:
1190
1191 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1192
1193         Prettify the output of the override-feature-defines script
1194         https://bugs.webkit.org/show_bug.cgi?id=106542
1195
1196         Reviewed by Martin Robinson.
1197
1198         The output now clearly lists the feature defines being overridden
1199         along with the default and overriding values for each feature define.
1200
1201         * gtk/override-feature-defines:
1202         (adjust_feature_defines_makefile):
1203         (adjust_feature_defines_makefile.override_feature_define):
1204
1205 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
1206
1207         Remove uses of deprecated unittest.TestCase aliases
1208         https://bugs.webkit.org/show_bug.cgi?id=102252
1209
1210         Reviewed by Adam Barth.
1211
1212         Replace the deprecated assertEquals method of the TestCase interface
1213         used in some webkitpy unittests with the assertEqual method.
1214
1215         * Scripts/webkitpy/common/system/profiler_unittest.py:
1216         (ProfilerFactoryTest._assert_default_profiler_name):
1217         (ProfilerFactoryTest.test_default_profiler_output):
1218         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1219         (GtkPortTest.test_expectations_files):
1220         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1221         (TestHttpServer.test_win32_start_and_stop):
1222
1223 2013-01-22  Jer Noble  <jer.noble@apple.com>
1224
1225         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
1226         https://bugs.webkit.org/show_bug.cgi?id=107562
1227
1228         Rubber-stamped by Alexy Proskuryakov.
1229
1230         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
1231
1232         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1233         (WTR::PlatformWebView::PlatformWebView):
1234         (WTR::PlatformWebView::viewSupportsOptions):
1235
1236 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
1237
1238         One is not allowed to use commit-queue to make oneself a committer.
1239
1240         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
1241
1242 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
1243
1244         Add myself to commiters.py
1245         https://bugs.webkit.org/show_bug.cgi?id=107546
1246
1247         Reviewed by Kentaro Hara.
1248
1249         * Scripts/webkitpy/common/config/committers.py:
1250
1251 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
1252
1253         [GTK] Implement TestRunner::setTextDirection
1254         https://bugs.webkit.org/show_bug.cgi?id=107131
1255
1256         Reviewed by Philippe Normand.
1257
1258         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1259         (resetDefaultsToConsistentValues): Reset direction to default value.
1260         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1261         (TestRunner::setTextDirection): Implement method using
1262         gtk_widget_set_direction.
1263
1264 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
1265
1266         [chromium] move spell checking mocks to TestRunner library
1267         https://bugs.webkit.org/show_bug.cgi?id=107455
1268
1269         Reviewed by Kent Tamura.
1270
1271         The content module doesn't provide its own WebSpellCheckClient.
1272
1273         * DumpRenderTree/DumpRenderTree.gypi:
1274         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1275         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
1276         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1277         (WebKit):
1278         (WebTestRunner):
1279         (WebTestProxyBase):
1280         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1281         (WebTestRunner):
1282         (WebTestRunner::makeMenuItemStringsFor):
1283         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
1284         (MockGrammarCheck::checkGrammarOfString):
1285         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
1286         (WebKit):
1287         (MockGrammarCheck):
1288         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
1289         (MockSpellCheck::MockSpellCheck):
1290         (MockSpellCheck::~MockSpellCheck):
1291         (isNotASCIIAlpha):
1292         (MockSpellCheck::spellCheckWord):
1293         (MockSpellCheck::fillSuggestionList):
1294         (MockSpellCheck::initializeIfNeeded):
1295         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
1296         (MockSpellCheck):
1297         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
1298         (WebTestRunner::SpellCheckClient::SpellCheckClient):
1299         (WebTestRunner):
1300         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
1301         (WebTestRunner::SpellCheckClient::setDelegate):
1302         (WebTestRunner::SpellCheckClient::spellCheck):
1303         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
1304         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
1305         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
1306         (WebTestRunner::SpellCheckClient::autoCorrectWord):
1307         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
1308         (WebTestRunner):
1309         (SpellCheckClient):
1310         (WebTestRunner::SpellCheckClient::taskList):
1311         (WebTestRunner::SpellCheckClient::mockSpellCheck):
1312         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1313         (TestDelegate):
1314         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1315         (WebTestInterfaces::Internal):
1316         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1317         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1318         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1319         (WebTestRunner::WebTestProxyBase::setDelegate):
1320         (WebTestRunner::WebTestProxyBase::spellCheckClient):
1321         (WebTestRunner):
1322         * DumpRenderTree/chromium/WebViewHost.cpp:
1323         (WebViewHost::WebViewHost):
1324         (WebViewHost::setWebWidget):
1325         * DumpRenderTree/chromium/WebViewHost.h:
1326         (WebViewHost):
1327
1328 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
1329
1330         [EFL] Adds Accessibility support to wk1
1331         https://bugs.webkit.org/show_bug.cgi?id=107440
1332
1333         Reviewed by Gyuyoung Kim.
1334
1335         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
1336
1337 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
1338
1339         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
1340         https://bugs.webkit.org/show_bug.cgi?id=107506
1341
1342         Reviewed by Dan Bernstein.
1343
1344         * MiniBrowser/mac/WK1BrowserWindowController.m:
1345         (-[WK1BrowserWindowController dealloc]):
1346
1347 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
1348
1349         Add build flag for Canvas's Path object (disabled by default)
1350         https://bugs.webkit.org/show_bug.cgi?id=107473
1351
1352         Reviewed by Dean Jackson.
1353
1354         Add CANVAS_PATH build flag to build systems.
1355
1356         * Scripts/webkitperl/FeatureList.pm:
1357
1358 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
1359
1360         [EFL][WK2] Add APIs to set/get view source mode
1361         https://bugs.webkit.org/show_bug.cgi?id=106633
1362
1363         Reviewed by Gyuyoung Kim.
1364
1365         Added a shotcut 'F8' in Minibrowser to display a source code
1366         of the web page in a new window.
1367
1368        * MiniBrowser/efl/main.c:
1369         (on_key_down):
1370         (on_window_create):
1371         (window_create):
1372         (elm_main):
1373
1374 2013-01-21  Nico Weber  <thakis@chromium.org>
1375
1376         [chromium] Don't archive generated source files.
1377         https://bugs.webkit.org/show_bug.cgi?id=106736
1378
1379         Reviewed by Eric Seidel.
1380
1381         They shouldn't be needed to run tests. They don't need a lot of space,
1382         but add many lines to the "extracting" stdout. This attempts to reduce
1383         that noise a bit.
1384
1385         * BuildSlaveSupport/built-product-archive:
1386         (archiveBuiltProduct):
1387
1388 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
1389
1390         Mac DumpRenderTree's installSignalHandlers() is unreachable code
1391         https://bugs.webkit.org/show_bug.cgi?id=107383
1392
1393         Reviewed by Sam Weinig.
1394
1395         The CrashHandler of DumpRenderTree were originally used for restoring
1396         the color profile of the main display even if DRT crashes.
1397
1398         That feature was later limited to pixel tests only in r29999.
1399
1400         In r104351, the DRT was changed to use device color space. Making the crash
1401         handlers useless, but they were left in the code since the error reporting
1402         code was still reachable.
1403
1404         Later, r124581 refactored the code and dumpPixelsForCurrentTest
1405         is being used before being assigned its value.
1406         This did cause any regression because the code had become useless with the previous change.
1407
1408         * DumpRenderTree/mac/DumpRenderTree.mm:
1409         Remove crashHandler() and installSignalHandlers() as they have become useless and
1410         have been unreachable code for 6 months.
1411         (dumpRenderTree):
1412         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
1413         at those points.
1414
1415 2013-01-21  Nico Weber  <thakis@chromium.org>
1416
1417         Make ninja the default build system for build-webkit --chromium on mac
1418         https://bugs.webkit.org/show_bug.cgi?id=106737
1419
1420         Reviewed by Eric Seidel.
1421
1422         * Scripts/update-webkit-chromium:
1423
1424 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1425
1426         Regression(r140262): Causes a lot of flakiness
1427         https://bugs.webkit.org/show_bug.cgi?id=107454
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         r140262 introduced a lot of flakiness due to fixed layout mode
1432         not getting disabled on the view after being enabled for
1433         specific test cases. This patch makes sure fixed layout mode
1434         properly gets reset in WebKitTestRunner to avoid flakiness.
1435
1436         * WebKitTestRunner/TestInvocation.cpp:
1437         (WTR::updateLayoutType):
1438
1439 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
1440
1441         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
1442         https://bugs.webkit.org/show_bug.cgi?id=107421
1443
1444         Unreviewed build fix.
1445
1446         * Scripts/run-gtk-tests:
1447         (TestRunner): skip Resource tests.
1448
1449 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1450
1451         [EFL][WKTR] platformRunUntil() should keep the main loop running
1452         https://bugs.webkit.org/show_bug.cgi?id=107442
1453
1454         Reviewed by Noam Rosenthal.
1455
1456         EFL's implementation of platformRunUntil() should keep the main loop
1457         running and avoid calling sleep() between calls to
1458         ecore_main_loop_iterate(). This call to sleep seems to be a source
1459         of deadlocks (see Bug 106884).
1460
1461         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1462         (WTR::TestController::platformRunUntil):
1463
1464 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
1465
1466         QtTestBrowser should provide way to clear selected elements
1467         https://bugs.webkit.org/show_bug.cgi?id=107437
1468
1469         Reviewed by Simon Hausmann.
1470
1471         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
1472         Invoke the clearSelection prior to highlighting new elements.
1473
1474         * QtTestBrowser/launcherwindow.cpp:
1475         (ElementHighlight):
1476         (LauncherWindow::createChrome):
1477         (LauncherWindow::selectElements):
1478         (LauncherWindow::clearSelection):
1479         * QtTestBrowser/launcherwindow.h:
1480         (LauncherWindow):
1481
1482 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
1483
1484         [chromium] move methods interacting with willSendRequest to TestRunner
1485         https://bugs.webkit.org/show_bug.cgi?id=107270
1486
1487         Reviewed by Kent Tamura.
1488
1489         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1490         (DRTTestRunner::DRTTestRunner):
1491         (DRTTestRunner::waitForPolicyDelegate):
1492         * DumpRenderTree/chromium/DRTTestRunner.h:
1493         (DRTTestRunner):
1494         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1495         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1496         (WebTestRunner::WebTestRunner::httpHeadersToClear):
1497         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
1498         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
1499         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1500         (WebTestRunner::TestRunner::TestRunner):
1501         (WebTestRunner::TestRunner::reset):
1502         (WebTestRunner::TestRunner::httpHeadersToClear):
1503         (WebTestRunner):
1504         (WebTestRunner::TestRunner::shouldBlockRedirects):
1505         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
1506         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
1507         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1508         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
1509         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1510         (TestRunner):
1511         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1512         (WebTestRunner::WebTestProxyBase::willSendRequest):
1513         * DumpRenderTree/chromium/WebViewHost.cpp:
1514         (WebViewHost::willSendRequest):
1515         (WebViewHost::reset):
1516         * DumpRenderTree/chromium/WebViewHost.h:
1517         (WebViewHost):
1518
1519 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
1520
1521         [GTK] Stop building WebKit2 on GTK EWSs
1522         https://bugs.webkit.org/show_bug.cgi?id=107435
1523
1524         Reviewed by Philippe Normand.
1525
1526         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
1527         so stop building it on GTK EWSs.
1528
1529         * Scripts/webkitpy/common/config/ports.py:
1530         (GtkPort.build_webkit_command):
1531         * Scripts/webkitpy/common/config/ports_unittest.py:
1532         (DeprecatedPortTest.test_gtk_port):
1533
1534 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
1535
1536         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1537         https://bugs.webkit.org/show_bug.cgi?id=107120
1538
1539         Reviewed by Adam Barth.
1540
1541         Updating mock to use the new states.
1542
1543         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1544         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1545         (MockWebRTCPeerConnectionHandler::initialize):
1546         (MockWebRTCPeerConnectionHandler::updateICE):
1547
1548 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1549
1550         Extend diff_parser to support the --full-index output.
1551         https://bugs.webkit.org/show_bug.cgi?id=107408
1552
1553         Reviewed by Maciej Stachowiak.
1554
1555         * Scripts/webkitpy/common/checkout/diff_parser.py:
1556         (git_diff_to_svn_diff):
1557         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1558         (DiffParserTest):
1559         (DiffParserTest.test_git_diff_to_svn_diff):
1560         (git_diff_to_svn_diff):
1561
1562 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1563
1564         Dragging over an element with scrollbars should scroll the element when dragging near edges
1565         https://bugs.webkit.org/show_bug.cgi?id=39725
1566
1567         Reviewed by Hajime Morita.
1568
1569         This patch introduces canceling drag-and-drop by escape key for testing
1570         behavior after cancellation drag-and-drop.
1571
1572         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1573         (WebTestRunner):
1574         (WebTestRunner::EventSender::doMouseUp):
1575         (WebTestRunner::EventSender::finishDragAndDrop):
1576         (WebTestRunner::EventSender::keyDown):
1577         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1578         (EventSender):
1579         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1580
1581 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1582
1583         [chromium] move frame generation related methods to TestRunner
1584         https://bugs.webkit.org/show_bug.cgi?id=107268
1585
1586         Reviewed by Adam Barth.
1587
1588         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1589         (DRTTestRunner::DRTTestRunner):
1590         (DRTTestRunner::setWillSendRequestReturnsNull):
1591         * DumpRenderTree/chromium/DRTTestRunner.h:
1592         (DRTTestRunner):
1593         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1594         (WebTestRunner::WebTestDelegate::display):
1595         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1596         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1597         (WebTestRunner::TestRunner::TestRunner):
1598         (WebTestRunner::TestRunner::display):
1599         (WebTestRunner):
1600         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1601         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1602         (TestRunner):
1603         * DumpRenderTree/chromium/WebViewHost.cpp:
1604         (WebViewHost::display):
1605         (WebViewHost::displayInvalidatedRegion):
1606         * DumpRenderTree/chromium/WebViewHost.h:
1607
1608 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1609
1610         [chromium] move speech related methods to TestRunner library
1611         https://bugs.webkit.org/show_bug.cgi?id=107266
1612
1613         Reviewed by Adam Barth.
1614
1615         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1616         (DRTTestRunner::DRTTestRunner):
1617         (DRTTestRunner::displayInvalidatedRegion):
1618         * DumpRenderTree/chromium/DRTTestRunner.h:
1619         (DRTTestRunner):
1620         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1621         (WebTestDelegate):
1622         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1623         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1624         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1625         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1626         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1627         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1628         (WebTestRunner::TestRunner::TestRunner):
1629         (WebTestRunner):
1630         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1631         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1632         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1633         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1634         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1635         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1636         (TestRunner):
1637         * DumpRenderTree/chromium/WebViewHost.cpp:
1638         (WebViewHost::addMockSpeechInputResult):
1639         (WebViewHost::setMockSpeechInputDumpRect):
1640         (WebViewHost::addMockSpeechRecognitionResult):
1641         (WebViewHost::setMockSpeechRecognitionError):
1642         (WebViewHost::wasMockSpeechRecognitionAborted):
1643         * DumpRenderTree/chromium/WebViewHost.h:
1644
1645 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1646
1647         [chromium] move notification related methods to TestRunner
1648         https://bugs.webkit.org/show_bug.cgi?id=107269
1649
1650         Reviewed by Adam Barth.
1651
1652         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1653         (DRTTestRunner::DRTTestRunner):
1654         * DumpRenderTree/chromium/DRTTestRunner.h:
1655         (DRTTestRunner):
1656         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1657         (WebTestDelegate):
1658         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1659         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1660         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1661         (WebTestRunner::TestRunner::TestRunner):
1662         (WebTestRunner):
1663         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1664         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1665         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1666         (TestRunner):
1667         * DumpRenderTree/chromium/WebViewHost.cpp:
1668         (WebViewHost::grantWebNotificationPermission):
1669         (WebViewHost::simulateLegacyWebNotificationClick):
1670         * DumpRenderTree/chromium/WebViewHost.h:
1671
1672 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1673
1674         [chromium] move geolocation related methods to TestRunner
1675         https://bugs.webkit.org/show_bug.cgi?id=107267
1676
1677         Reviewed by Adam Barth.
1678
1679         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1680         (DRTTestRunner::DRTTestRunner):
1681         * DumpRenderTree/chromium/DRTTestRunner.h:
1682         (DRTTestRunner):
1683         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1684         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1685         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1686         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1687         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1688         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1689         (WebTestRunner::TestRunner::TestRunner):
1690         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1691         (WebTestRunner):
1692         (WebTestRunner::TestRunner::setGeolocationPermission):
1693         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1694         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1695         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1696         (TestRunner):
1697         * DumpRenderTree/chromium/WebViewHost.cpp:
1698         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1699         (WebViewHost::setGeolocationPermission):
1700         (WebViewHost::setMockGeolocationPosition):
1701         (WebViewHost::setMockGeolocationPositionUnavailableError):
1702         * DumpRenderTree/chromium/WebViewHost.h:
1703
1704 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1705
1706         Unreviewed build fix for Qt WK2 after r140258.
1707         Use the size_t type instead of unsigned for the variable
1708         which holds the position of the first null character in the
1709         console message.
1710
1711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1712         (WTR::InjectedBundlePage::willAddMessageToConsole):
1713
1714 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1715
1716         Unreviewed, rolling out r140260.
1717         http://trac.webkit.org/changeset/140260
1718         https://bugs.webkit.org/show_bug.cgi?id=107387
1719
1720         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1721         nothing else) (Requested by thakis__ on #webkit).
1722
1723         * Scripts/update-webkit-chromium:
1724
1725 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1726
1727         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1728         https://bugs.webkit.org/show_bug.cgi?id=106890
1729
1730         Reviewed by Kenneth Rohde Christiansen.
1731
1732         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1733
1734         * WebKitTestRunner/TestInvocation.cpp:
1735         (WTR::shouldUseFixedLayout):
1736         (WTR):
1737         (WTR::updateLayoutType):
1738
1739 2013-01-19  Nico Weber  <thakis@chromium.org>
1740
1741         Make ninja the default build system for build-webkit --chromium on mac
1742         https://bugs.webkit.org/show_bug.cgi?id=106737
1743
1744         Reviewed by Eric Seidel.
1745
1746         * Scripts/update-webkit-chromium:
1747
1748 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1749
1750         [WK2] svg/dom/fuzz-path-parser.html is failing
1751         https://bugs.webkit.org/show_bug.cgi?id=107133
1752
1753         Reviewed by Alexey Proskuryakov.
1754
1755         Console messages can contain null characters before the end of string.
1756         Appending such message to the StringBuilder as a WTFString appends the
1757         complete string, including the null character. This later cuts off everything
1758         after the null character when the string is being printed out to the test
1759         output.
1760
1761         To avoid this, truncate the string up to the first null character. This
1762         preserves the newline character appended immediately after this and
1763         stops giving incorrect output.
1764
1765         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1766         (WTR::InjectedBundlePage::willAddMessageToConsole):
1767
1768 2013-01-19  Eric Seidel  <eric@webkit.org>
1769
1770         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1771         https://bugs.webkit.org/show_bug.cgi?id=107367
1772
1773         Reviewed by Ryosuke Niwa.
1774
1775         Using srcdoc instead of document.write changes the error output
1776         ever so slightly.  Clearly we were already trying to ignore these
1777         messages, just not succeeding.  This change makes this new test "pass" correctly.
1778
1779         * Scripts/webkitpy/performance_tests/perftest.py:
1780         (PerfTest):
1781
1782 2013-01-18  Dan Winship  <danw@gnome.org>
1783
1784         REGRESSION (r139071): run-webkit-httpd complains at launch
1785         https://bugs.webkit.org/show_bug.cgi?id=107310
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         * Scripts/webkitperl/httpd.pm:
1790         (getApacheVersion): use preferred perl syntax
1791
1792 2013-01-18  Julie Parent  <jparent@chromium.org>
1793
1794         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1795         https://bugs.webkit.org/show_bug.cgi?id=107336
1796
1797         We need to have 'group' listed as a parameter, else we never parse it,
1798         as we only parse parameters with defaults.
1799         
1800         Reviewed by Ojan Vafai.
1801
1802         * TestResultServer/static-dashboards/dashboard_base.js:
1803
1804 2013-01-18  Emil A Eklund  <eae@chromium.org>
1805
1806         Update LayoutUnit rounding unit test
1807         https://bugs.webkit.org/show_bug.cgi?id=107322
1808
1809         Reviewed by Levi Weintraub.
1810         
1811         Update the LayoutUnitRounding test to use fromFloatRound for
1812         values that cannot accurately be represented as a LayoutUnit
1813         (the default behavior is to floor the value to the nearest
1814         LayoutUnit).
1815
1816         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1817         (TestWebKitAPI::TEST):
1818
1819 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1820
1821         VCSUtils.pm: Stop calling git repo-config.
1822         https://bugs.webkit.org/show_bug.cgi?id=107294
1823
1824         Reviewed by Dirk Pranke.
1825
1826         The `repo-config' git command has been deprecated since early
1827         2008, and recent versions have started warning it is deprecated.
1828
1829         Basically revert r27870 and use the `config' command all the time.
1830
1831         * Scripts/VCSUtils.pm:
1832         (gitConfig):
1833
1834 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1835
1836         LayoutUnit should round half consistently, not away from zero
1837         https://bugs.webkit.org/show_bug.cgi?id=107208
1838
1839         Reviewed by Eric Seidel.
1840
1841         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1842         cover this change in rounding behavior.
1843
1844 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1845
1846         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1847         https://bugs.webkit.org/show_bug.cgi?id=107234
1848
1849         Reviewed by Simon Fraser.
1850
1851         * DumpRenderTree/mac/DumpRenderTree.mm:
1852         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1854         (WTR::PlatformWebView::PlatformWebView): Ditto.
1855
1856 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1857
1858         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1859         https://bugs.webkit.org/show_bug.cgi?id=107251
1860
1861         Reviewed by Simon Fraser.
1862
1863         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1864
1865         * DumpRenderTree/mac/DumpRenderTree.mm:
1866         (dumpRenderTree):
1867         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1868         (WTR::InjectedBundle::platformInitialize):
1869
1870 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1871
1872         [GTK] Enable indexed database for development builds
1873         https://bugs.webkit.org/show_bug.cgi?id=107299
1874
1875         Reviewed by Gustavo Noronha Silva.
1876
1877         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1878         for GTK+ development builds.
1879
1880 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1881
1882         AX: Improve table-guessing heuristics
1883         https://bugs.webkit.org/show_bug.cgi?id=107042
1884
1885         Reviewed by Chris Fleizach.
1886
1887         Implement parentElementCallback on Chromium to make testing easier.
1888
1889         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1890         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1891
1892 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1893
1894         [GTK] Add property for IndexedDB database path to WebKitGTK+
1895         https://bugs.webkit.org/show_bug.cgi?id=106136
1896
1897         Reviewed by Gustavo Noronha Silva.
1898
1899         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1900         before falling back to the old default. This is necessary because
1901         indexed database tests require that each DRT shard is using a different
1902         IDB database location.
1903
1904         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1905         (temporaryDatabaseDirectory): Added this helper for getting the
1906         database directory.
1907         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1908
1909 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1910
1911         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1912         https://bugs.webkit.org/show_bug.cgi?id=107264
1913
1914         Reviewed by Laszlo Gombos.
1915
1916         Enable API test InjectedBundleFrameHitTest for hit-testing,
1917         since it is now passing on both Debug and Release builds.
1918
1919         * TestWebKitAPI/CMakeLists.txt:
1920         * TestWebKitAPI/PlatformEfl.cmake:
1921
1922 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1923
1924         [GTK] Implement TestRunner::addUserScript
1925         https://bugs.webkit.org/show_bug.cgi?id=107275
1926
1927         Reviewed by Philippe Normand.
1928
1929         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1930         (TestRunner::addUserScript): Implement method using
1931         DumpRenderTreeSupportGtk::addUserScript.
1932
1933 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1934
1935         Unreviewed, add my secondary email address to the list.
1936
1937         * Scripts/webkitpy/common/config/committers.py:
1938
1939 2013-01-18  Dan Carney  <dcarney@google.com>
1940
1941         [chromium] move pointerlock functions to TestRunner library
1942         https://bugs.webkit.org/show_bug.cgi?id=107241
1943
1944         Reviewed by Jochen Eisinger.
1945
1946         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1947         (DRTTestRunner::DRTTestRunner):
1948         * DumpRenderTree/chromium/DRTTestRunner.h:
1949         (DRTTestRunner):
1950         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1951         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1952         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1953         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1954         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1955         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1956         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1957         (WebTestRunner::TestRunner::TestRunner):
1958         (WebTestRunner):
1959         (WebTestRunner::TestRunner::didAcquirePointerLock):
1960         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1961         (WebTestRunner::TestRunner::didLosePointerLock):
1962         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1963         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1964         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1965         (TestRunner):
1966         * DumpRenderTree/chromium/WebViewHost.h:
1967         (WebViewHost):
1968
1969 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1970
1971         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1972         https://bugs.webkit.org/show_bug.cgi?id=106774
1973
1974         Reviewed by Martin Robinson.
1975
1976         In order to fix a long standing linespacing/font ascent & descent issue
1977         we found that FreeType commit b0962ac34e660 solves that problem.
1978         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1979         maintainer recommending several security updates after that said commit.
1980
1981         Also, in order to avoid extra rebaselining, let's activate subpixel
1982         layout at the same time.
1983
1984         * efl/jhbuild.modules: New freetype 2.4.11
1985
1986 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1987
1988         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1989         https://bugs.webkit.org/show_bug.cgi?id=107107
1990         PR 282192
1991
1992         Reviewed by Rob Buis.
1993
1994         The DRT application will convert relative/absolute file path to
1995         file://<real-file-path> format, so we only check for http/file prefix.
1996
1997         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1998         (BlackBerry::WebKit::isFullUrl):
1999         (WebKit):
2000         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2001
2002 2013-01-17  Frank Farzan  <frankf@chromium.org>
2003
2004         Flakiness dashboard: Add ChromiumFYI master
2005         https://bugs.webkit.org/show_bug.cgi?id=107180
2006
2007         Reviewed by Ojan Vafai.
2008
2009         This is needed to enable Chrome Android bots
2010         to upload results for instrumentation tests.
2011
2012         * TestResultServer/generate_builders_json.py:
2013         (main):
2014         * TestResultServer/static-dashboards/builders.jsonp:
2015
2016 2013-01-17  Frank Farzan  <frankf@chromium.org>
2017
2018         Add Chrome on Android instrumentation test types to flakiness dashboard
2019         https://bugs.webkit.org/show_bug.cgi?id=106964
2020
2021         Reviewed by Ojan Vafai.
2022
2023         Specifically, add these test types:
2024         
2025          androidwebview_instrumentation_tests
2026          chromiumtestshell_instrumentation_tests
2027          contentshell_instrumentation_tests
2028         
2029         Also, add ChromiumFYI to the list of masters.
2030
2031         * TestResultServer/static-dashboards/builders.js:
2032         (loadBuildersList):
2033         * TestResultServer/static-dashboards/dashboard_base.js:
2034         (currentBuilderGroupCategory):
2035
2036 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
2037
2038         Fixing webkitpy's SCM unit tests.
2039         https://bugs.webkit.org/show_bug.cgi?id=106429
2040
2041         Reviewed by Eric Seidel.
2042
2043         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2044         (SCMDetectorTest.test_detect_scm_system):
2045         * Scripts/webkitpy/common/checkout/scm/git.py:
2046         (Git.in_working_directory):
2047         (Git.read_git_config):
2048         (Git._assert_can_squash):
2049         (Git.remote_branch_ref):
2050         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2051         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
2052         (GitTestWithMock):
2053         (GitTestWithMock.make_scm):
2054         (GitTestWithMock.test_create_patch):
2055         * Scripts/webkitpy/common/system/outputcapture.py:
2056         (OutputCapture.assert_outputs):
2057         (OutputCaptureTestCaseBase):
2058         * Scripts/webkitpy/test/printer.py:
2059         (Printer.configure):
2060
2061 2013-01-17  Julie Parent  <jparent@chromium.org>
2062
2063         Flakiness dashboard assumes there must be ToT tests
2064         https://bugs.webkit.org/show_bug.cgi?id=107155
2065
2066         Remove group as a default parameter, since we can't actually know
2067         the name of a group initially.  Instead, introduces 
2068         currentBuilderGroupName which returns the current builder group
2069         if it has been explicitly set, or picks the first one available
2070         as a default. Allows us to remove some extra code tracking this
2071         stuff as well.
2072         
2073         Reviewed by Ojan Vafai.
2074
2075         * TestResultServer/static-dashboards/dashboard_base.js:
2076         (parseCrossDashboardParameters):
2077         (currentBuilderGroupName):
2078         (currentBuilderGroup):
2079         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2080         (platformAndBuildType):
2081         * TestResultServer/static-dashboards/loader.js:
2082         (.):
2083
2084 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2085
2086         Remove NodeListsNodeData when it's no longer needed
2087         https://bugs.webkit.org/show_bug.cgi?id=107074
2088
2089         Reviewed by Darin Adler.
2090
2091         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
2092
2093         * Scripts/webkitpy/performance_tests/perftest.py:
2094         (PerfTest):
2095
2096 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
2097
2098         Ref test images are upside-down in WebKit2
2099         https://bugs.webkit.org/show_bug.cgi?id=105457
2100
2101         Reviewed by Sam "Speedy" Weinig.
2102         
2103         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
2104         from the window snapshot contained a flipped copy of the image, causing all ref
2105         and pixel images to be upside-down.
2106
2107         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2108         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2109
2110 2013-01-17  Timothy Loh  <timloh@google.com>
2111
2112         Replaced specifiers variable with is_debug in builders.py
2113         https://bugs.webkit.org/show_bug.cgi?id=107057
2114
2115         Reviewed by Dirk Pranke.
2116
2117         Replaced specifiers variable with is_debug in builders.py to simplify
2118         Bug 106259. The other specifiers are not used elsewhere in the code.
2119         Fixed builder_name_for_port_name to return a debug builder if we don't
2120         have a release builder.
2121
2122         * Scripts/webkitpy/layout_tests/port/builders.py:
2123         (all_port_names):
2124         (builder_name_for_port_name):
2125         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2126         (TestRebaselineExpectations.test_rebaseline_expectations):
2127
2128 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
2129
2130         [GTK] Build with LevelDB when IndexedDB is enabled
2131         https://bugs.webkit.org/show_bug.cgi?id=103220
2132
2133         Reviewed by Gustavo Noronha Silva.
2134
2135         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
2136         as it does not conform to WebKit style.
2137
2138 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2139
2140         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
2141         https://bugs.webkit.org/show_bug.cgi?id=107119
2142
2143         Reviewed by Laszlo Gombos.
2144
2145         Do not use ASSERT on ecore_evas_init(), since the expression inside
2146         the macro compiles out of release builds.
2147
2148         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
2149         * TestWebKitAPI/efl/PlatformWebView.cpp:
2150         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
2151
2152 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
2153
2154         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
2155         https://bugs.webkit.org/show_bug.cgi?id=104545
2156
2157         Reviewed by Yury Semikhatsky.
2158
2159         Adopt signature changes.
2160
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2162         (ProfilerAgent.getCPUProfile): Renamed.
2163         (ProfilerAgent.getHeapSnapshot): Added.
2164
2165 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
2166
2167         [GTK][EFL] NWRT should check that Xvfb is installed
2168         https://bugs.webkit.org/show_bug.cgi?id=71767
2169
2170         Reviewed by Dirk Pranke.
2171
2172         EFL and GTK ports now check that Xvfb is installed before running
2173         layout tests. The command line used to check whether Xvfb is present
2174         is a simple `which Xvfb` that should return 0 as the exit code upon
2175         success.
2176
2177         * Scripts/webkitpy/layout_tests/port/efl.py:
2178         (EflPort.show_results_html_file):
2179         (EflPort):
2180         (EflPort.check_sys_deps):
2181         * Scripts/webkitpy/layout_tests/port/gtk.py:
2182         (GtkPort.check_sys_deps):
2183         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2184         (XvfbDriver):
2185         (XvfbDriver.check_xvfb):
2186
2187 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2188
2189         sheriffbot can't tell me who "kov" is
2190         https://bugs.webkit.org/show_bug.cgi?id=106184
2191
2192         Reviewed by Eric Seidel.
2193
2194         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
2195
2196         * Scripts/webkitpy/common/config/committers.py:
2197         (Account.matches_glob):
2198         (CommitterList.contributors_by_search_string):
2199         * Scripts/webkitpy/common/config/committers_unittest.py:
2200         (CommittersTest.test_committer_lookup):
2201         * Scripts/webkitpy/tool/bot/irc_command.py:
2202         (Whois):
2203
2204 2013-01-16  David Kilzer  <ddkilzer@apple.com>
2205
2206         Use xcrun to find path to make for Mac port
2207         <http://webkit.org/b/107091>
2208
2209         Reviewed by Dan Bernstein.
2210
2211         * Scripts/webkitpy/layout_tests/port/mac.py:
2212         (MacPort._build_java_test_support): Call self.make_command().
2213         (MacPort.make_command): Add.  Call xcrun_find().
2214         (MacPort.nm_command): Use self.xcrun_find().
2215         (MacPort.xcrun_find): Add.  Extract from nm_command().
2216
2217 2013-01-16  Sam Weinig  <sam@webkit.org>
2218
2219         Make debug-safari --target-web-process work again
2220         https://bugs.webkit.org/show_bug.cgi?id=107088
2221
2222         Reviewed by Anders Carlsson.
2223
2224         * Scripts/webkitdirs.pm:
2225         (execMacWebKitAppForDebugging):
2226         The shim is now called SecItemShim.
2227
2228 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2229
2230         GCE build scripts don't take working directory into account when calling findzone.sh
2231         https://bugs.webkit.org/show_bug.cgi?id=106962
2232
2233         Reviewed by Adam Barth.
2234
2235         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2236         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2237         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2238
2239 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2240
2241         start-queue.sh does not pass remaining parameters correctly
2242         https://bugs.webkit.org/show_bug.cgi?id=107054
2243
2244         Reviewed by Adam Barth.
2245
2246         start-queue.sh now passes all remaining params to the webkit-patch command.
2247         Previously only one additional queue parameter could be sent.
2248
2249         * EWSTools/start-queue.sh:
2250
2251 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
2252
2253         check-webkit-style script cannot running in Chinese windows.
2254         https://bugs.webkit.org/show_bug.cgi?id=87548
2255
2256         Reviewed by Darin Adler.
2257
2258         * Scripts/webkitpy/common/system/platforminfo.py:
2259         (PlatformInfo._win_version_tuple_from_cmd):
2260
2261 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
2262
2263         Delete an extraneous print statement.
2264         https://bugs.webkit.org/show_bug.cgi?id=106562
2265
2266         Delete the extraneous print statement introduced in r139841.
2267
2268         * Scripts/webkitpy/layout_tests/views/printing.py:
2269         (Printer.print_found):
2270
2271 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
2272
2273         Please reinstate --pixel
2274         https://bugs.webkit.org/show_bug.cgi?id=101995
2275
2276         Reviewed by Dirk Pranke.
2277
2278         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
2279         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
2280         Some developers are still used to these options that were available in the ORWT.
2281
2282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2283         (parse_args):
2284
2285 2013-01-16  Eric Seidel  <eric@webkit.org>
2286
2287         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
2288         https://bugs.webkit.org/show_bug.cgi?id=99512
2289
2290         Reviewed by Darin Adler.
2291
2292         * Scripts/run-sunspider:
2293
2294 2013-01-16  Eric Seidel  <eric@webkit.org>
2295
2296         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
2297         https://bugs.webkit.org/show_bug.cgi?id=106036
2298
2299         Reviewed by Darin Adler.
2300
2301         * Scripts/webkitpy/webkitpy.pyproj: Removed.
2302         * Scripts/webkitpy/webkitpy.sln: Removed.
2303
2304 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
2305
2306         [Chromium] Remove hardcoded chromium_*.jar in gyp files
2307         https://bugs.webkit.org/show_bug.cgi?id=104049
2308
2309         Reviewed by Eric Seidel.
2310
2311         Targets with dependencies (direct/indirect) on a java target receive
2312         the chromium_*.jar paths in the variable input_jars_paths. Targets
2313         should use that rather than hardcoding where they think the jar will
2314         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
2315         than as --jars to generate_native_test.py.
2316
2317         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2318         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2319
2320 2013-01-16  Dan Carney  <dcarney@google.com>
2321
2322         [chromium] move setMockDeviceOrientation to TestRunner library
2323         https://bugs.webkit.org/show_bug.cgi?id=106895
2324
2325         Reviewed by Jochen Eisinger.
2326
2327         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2328         (DRTTestRunner::DRTTestRunner):
2329         * DumpRenderTree/chromium/DRTTestRunner.h:
2330         (DRTTestRunner):
2331         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2332         (WebKit):
2333         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
2334         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2335         (WebTestRunner::TestRunner::TestRunner):
2336         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2337         (WebTestRunner):
2338         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2339         (TestRunner):
2340         * DumpRenderTree/chromium/WebViewHost.cpp:
2341         (WebViewHost::setDeviceOrientation):
2342         * DumpRenderTree/chromium/WebViewHost.h:
2343         (WebViewHost):
2344
2345 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2346
2347         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2348         https://bugs.webkit.org/show_bug.cgi?id=106904
2349
2350         Reviewed by Adam Barth.
2351
2352         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2353         (DRTTestRunner::DRTTestRunner):
2354         (DRTTestRunner::notifyDone):
2355         (DRTTestRunner::reset):
2356         * DumpRenderTree/chromium/DRTTestRunner.h:
2357         (DRTTestRunner):
2358         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2359         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2360         (WebTestRunner::WebTestDelegate::setFocus):
2361         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2362         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2363         (WebTestRunner::WebTestDelegate::setLocale):
2364         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2365         (WebTestRunner::TestRunner::TestRunner):
2366         (WebTestRunner::TestRunner::reset):
2367         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2368         (WebTestRunner):
2369         (WebTestRunner::TestRunner::setWindowIsKey):
2370         (WebTestRunner::TestRunner::pathToLocalResource):
2371         (WebTestRunner::TestRunner::setBackingScaleFactor):
2372         (WebTestRunner::TestRunner::setPOSIXLocale):
2373         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2374         (WebTestRunner::TestRunner::taskList):
2375         (TestRunner):
2376         * DumpRenderTree/chromium/WebViewHost.cpp:
2377         (WebViewHost::setDeviceScaleFactor):
2378         (WebViewHost::setFocus):
2379         (WebViewHost::setAcceptAllCookies):
2380         (WebViewHost::pathToLocalResource):
2381         (WebViewHost::setLocale):
2382         * DumpRenderTree/chromium/WebViewHost.h:
2383         (WebViewHost):
2384
2385 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
2386
2387         [GTK] build-webkit fails if the jhbuild wrapper is not used
2388         https://bugs.webkit.org/show_bug.cgi?id=106769
2389
2390         Reviewed by Martin Robinson.
2391
2392         Return an empty array instead of "" in
2393         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
2394         will not be recognized as a valid command when the returned array
2395         is directly passed to perl's system() call.
2396
2397         * Scripts/webkitdirs.pm:
2398         (jhbuildWrapperPrefixIfNeeded):
2399
2400 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2401
2402         [chromium] add title text direction attribute to TestRunner
2403         https://bugs.webkit.org/show_bug.cgi?id=106907
2404
2405         Reviewed by Adam Barth.
2406
2407         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2408         (DRTTestRunner::DRTTestRunner):
2409         (DRTTestRunner::reset):
2410         * DumpRenderTree/chromium/DRTTestRunner.h:
2411         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2412         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2413         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2414         (WebTestRunner::TestRunner::TestRunner):
2415         (WebTestRunner::TestRunner::reset):
2416         (WebTestRunner::TestRunner::setTitleTextDirection):
2417         (WebTestRunner):
2418         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2419         (TestRunner):
2420         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2421         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2422         * DumpRenderTree/chromium/WebViewHost.cpp:
2423         (WebViewHost::didReceiveTitle):
2424
2425 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2426
2427         NRWT still confused about test count with --repeat-each and --iterations
2428         https://bugs.webkit.org/show_bug.cgi?id=106562
2429
2430         Reviewed by Dirk Pranke.
2431
2432         Fix the printed unique test count and skipped count. This
2433         seems to have broken in r127688 ("NRWT lies about the number
2434         of tests that it's skipping when used with --repeat-each").
2435
2436         Also add a test for print_found()
2437
2438         * Scripts/webkitpy/layout_tests/views/printing.py:
2439         (Printer.print_found):
2440         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2441         (Testprinter.test_details):
2442         (Testprinter):
2443         (Testprinter.test_found):
2444
2445 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2446
2447         Unreviewed follow-up to r139769.
2448
2449         Note that omitting the WebKit1 code from the build now
2450         works for GTK as well.
2451
2452         * Scripts/build-webkit:
2453
2454 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2455
2456         test-webkitpy: truncate output to the terminal width when necessary
2457         https://bugs.webkit.org/show_bug.cgi?id=106973
2458
2459         Reviewed by Ojan Vafai.
2460
2461         this implements the same logic for test-webkitpy that we have
2462         for run-webkit-tests (and ninja).
2463
2464         No tests written as this is exercised by running test-webkitpy itself.
2465
2466         * Scripts/webkitpy/test/printer.py:
2467         (Printer.configure):
2468         (Printer._test_line):
2469
2470 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2471
2472         remove extraneous output in test-webkitpy
2473         https://bugs.webkit.org/show_bug.cgi?id=106971
2474
2475         Reviewed by Ojan Vafai.
2476
2477         We weren't ignoring or capturing the echoed output from
2478         these two tests, and getting noise in the logs as a result.
2479
2480         * Scripts/webkitpy/common/system/executive_unittest.py:
2481         (ExecutiveTest.test_auto_stringify_args):
2482         (ExecutiveTest.test_popen_args):
2483
2484 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2485
2486         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
2487         https://bugs.webkit.org/show_bug.cgi?id=106974
2488
2489         Reviewed by Ryosuke Niwa.
2490
2491         I forgot to stub out the call to check to ensure that the ports were
2492         available, so this test could fail if something was listening on 8000 or
2493         8443 on the machine.
2494
2495         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2496         (TestHttpServer.test_win32_start_and_stop):
2497
2498 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2499
2500         Unreviewed, rolling out r139792.
2501         http://trac.webkit.org/changeset/139792
2502         https://bugs.webkit.org/show_bug.cgi?id=106970
2503
2504         Broke the windows build.
2505
2506         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2507         (DRTTestRunner::DRTTestRunner):
2508         (DRTTestRunner::notifyDone):
2509         (DRTTestRunner::reset):
2510         (DRTTestRunner::setAlwaysAcceptCookies):
2511         (DRTTestRunner::setWindowIsKey):
2512         (DRTTestRunner::pathToLocalResource):
2513         (DRTTestRunner::setPOSIXLocale):
2514         (InvokeCallbackTask):
2515         (InvokeCallbackTask::InvokeCallbackTask):
2516         (InvokeCallbackTask::runIfValid):
2517         (DRTTestRunner::setBackingScaleFactor):
2518         * DumpRenderTree/chromium/DRTTestRunner.h:
2519         (DRTTestRunner):
2520         (DRTTestRunner::taskList):
2521         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2522         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2523         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2524         (WebTestRunner::TestRunner::TestRunner):
2525         (WebTestRunner::TestRunner::reset):
2526         (WebTestRunner::TestRunner::setDatabaseQuota):
2527         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2528         (TestRunner):
2529         * DumpRenderTree/chromium/WebViewHost.cpp:
2530         (WebViewHost::setPendingExtraData):
2531         (WebViewHost::setDeviceScaleFactor):
2532         * DumpRenderTree/chromium/WebViewHost.h:
2533         (WebViewHost):
2534
2535 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
2536
2537         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2538
2539         * Scripts/webkitpy/common/config/ports.py:
2540         (MacWK2Port):
2541
2542 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2543
2544         Extend sheriffbot's "help" command to be able to get help on individual commands
2545         https://bugs.webkit.org/show_bug.cgi?id=106629
2546
2547         Reviewed by Eric Seidel.
2548
2549         Added a help command to sheriffbot.
2550         Fixed some style issues and ordered the commands alphabetically.
2551
2552         * Scripts/webkitpy/tool/bot/irc_command.py:
2553         (IRCCommand):
2554         (IRCCommand.execute):
2555         (IRCCommand.usage):
2556         (IRCCommand.help):
2557         (CreateBug):
2558         (CreateBug.execute):
2559         (Help):
2560         (Help.execute):
2561         (Help._post_command_help):
2562         (Hi):
2563         (Hi.execute):
2564         (Restart):
2565         (RollChromiumDEPS):
2566         (RollChromiumDEPS._parse_args):
2567         (RollChromiumDEPS._expand_irc_nickname):
2568         (RollChromiumDEPS.execute):
2569         (Rollout):
2570         (Rollout._extract_revisions):
2571         (Rollout.execute):
2572         (Sheriffs):
2573         (Sheriffs.execute):
2574         (Whois):
2575         (Whois.execute):
2576         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2577         (IRCBotTest.test_help):
2578
2579 2013-01-15  Enrica Casucci  <enrica@apple.com>
2580
2581         Add a new set of WebKit2 APIs for text search and
2582         search results management.
2583         https://bugs.webkit.org/show_bug.cgi?id=106834.
2584         <rdar://problem/12597159>
2585
2586         Added new test for the new WebKit2 API for
2587         text search.
2588         
2589         Reviewed by Simon Fraser.
2590
2591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2592         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2593
2594 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2595
2596         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2597         https://bugs.webkit.org/show_bug.cgi?id=106904
2598
2599         Reverting 139794. It broke the build. It appears that a header file,
2600         WebTextDirection.h, was left out.
2601
2602         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2603         (DRTTestRunner::DRTTestRunner):
2604         (DRTTestRunner::reset):
2605         * DumpRenderTree/chromium/DRTTestRunner.h:
2606         (DRTTestRunner::setTitleTextDirection):
2607         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2608         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2609         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2610         (WebTestRunner::TestRunner::TestRunner):
2611         (WebTestRunner::TestRunner::reset):
2612         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2613         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2614         (TestRunner):
2615         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2616         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2617         * DumpRenderTree/chromium/WebViewHost.cpp:
2618         (WebViewHost::didReceiveTitle):
2619
2620 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2621
2622         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2623         https://bugs.webkit.org/show_bug.cgi?id=106904
2624
2625         Reviewed by Adam Barth.
2626
2627         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2628         (DRTTestRunner::DRTTestRunner):
2629         (DRTTestRunner::notifyDone):
2630         (DRTTestRunner::reset):
2631         * DumpRenderTree/chromium/DRTTestRunner.h:
2632         (DRTTestRunner):
2633         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2634         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2635         (WebTestRunner::WebTestDelegate::setFocus):
2636         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2637         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2638         (WebTestRunner::WebTestDelegate::setLocale):
2639         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2640         (WebTestRunner::TestRunner::TestRunner):
2641         (WebTestRunner::TestRunner::reset):
2642         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2643         (WebTestRunner):
2644         (WebTestRunner::TestRunner::setWindowIsKey):
2645         (WebTestRunner::TestRunner::pathToLocalResource):
2646         (WebTestRunner::TestRunner::setBackingScaleFactor):
2647         (WebTestRunner::TestRunner::setPOSIXLocale):
2648         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2649         (WebTestRunner::TestRunner::taskList):
2650         (TestRunner):
2651         * DumpRenderTree/chromium/WebViewHost.cpp:
2652         (WebViewHost::setDeviceScaleFactor):
2653         (WebViewHost::setFocus):
2654         (WebViewHost::setAcceptAllCookies):
2655         (WebViewHost::pathToLocalResource):
2656         (WebViewHost::setLocale):
2657         * DumpRenderTree/chromium/WebViewHost.h:
2658         (WebViewHost):
2659
2660 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2661
2662         Tests with WontFix expectation are (indirectly) skipped
2663         https://bugs.webkit.org/show_bug.cgi?id=105860
2664
2665         Reviewed by Dirk Pranke.
2666
2667         Only skip the WontFix expectation if there are no other layout test
2668         expectations (like Failure, ImageOnlyFailure) listed for the test.
2669         This makes it possible to run an expected failure for which there
2670         is no reason or interest to fix. There are some ports that would like
2671         to exercise this behavior as well as specific test cases that should use
2672         such expectations.
2673
2674         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2675         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2676         WONTFIX test if there are no expectations listed. The warning is adjusted
2677         to reflect the new behavior.
2678         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2679         and adjust test cases for these changes.
2680         (ExpectationSyntaxTests.test_wontfix):
2681         (SemanticTests.test_skip_and_wontfix):
2682
2683 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2684
2685         [chromium] add title text direction attribute to TestRunner
2686         https://bugs.webkit.org/show_bug.cgi?id=106907
2687
2688         Reviewed by Adam Barth.
2689
2690         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2691         (DRTTestRunner::DRTTestRunner):
2692         (DRTTestRunner::reset):
2693         * DumpRenderTree/chromium/DRTTestRunner.h:
2694         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2695         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2696         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2697         (WebTestRunner::TestRunner::TestRunner):
2698         (WebTestRunner::TestRunner::reset):
2699         (WebTestRunner::TestRunner::setTitleTextDirection):
2700         (WebTestRunner):
2701         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2702         (TestRunner):
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2704         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2705         * DumpRenderTree/chromium/WebViewHost.cpp:
2706         (WebViewHost::didReceiveTitle):
2707
2708 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2709
2710         nrwt: change the default # of locked shards on chromium_win to 1
2711         https://bugs.webkit.org/show_bug.cgi?id=106938
2712
2713         Reviewed by Eric Seidel.
2714
2715         It looks like LigHTTPd might be buggy or unstable if we are
2716         running multiple http tests in parallel; see
2717         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2718         context as well. This change will stop running http tests in parallel
2719         and we can see if this fixes things.
2720
2721         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2722         (ChromiumWinPort.default_max_locked_shards):
2723         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2724         (ChromiumWinTest.test_path_to_image_diff):
2725         (ChromiumWinTest):
2726         (ChromiumWinTest.test_default_max_locked_shards):
2727
2728 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2729
2730         [chromium] move WebDatabase related methods to TestRunner library
2731         https://bugs.webkit.org/show_bug.cgi?id=106905
2732
2733         Reviewed by Adam Barth.
2734
2735         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2736         (DRTTestRunner::DRTTestRunner):
2737         (DRTTestRunner::reset):
2738         * DumpRenderTree/chromium/DRTTestRunner.h:
2739         (DRTTestRunner):
2740         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2741         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2742         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2743         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2744         (WebTestRunner::TestRunner::TestRunner):
2745         (WebTestRunner::TestRunner::reset):
2746         (WebTestRunner::TestRunner::clearAllDatabases):
2747         (WebTestRunner):
2748         (WebTestRunner::TestRunner::setDatabaseQuota):
2749         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2750         (TestRunner):
2751         * DumpRenderTree/chromium/WebViewHost.cpp:
2752         (WebViewHost::clearAllDatabases):
2753         (WebViewHost::setDatabaseQuota):
2754         * DumpRenderTree/chromium/WebViewHost.h:
2755         (WebViewHost):
2756
2757 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2758
2759         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2760         functionality match the name.
2761         https://bugs.webkit.org/show_bug.cgi?id=106870
2762
2763         Reviewed by Adam Barth.
2764
2765         * Scripts/webkitpy/tool/commands/download.py:
2766         (Clean):
2767         (Update):
2768         (Build):
2769         (BuildAndTest):
2770         (CheckStyle):
2771         (BuildAttachment):
2772         (BuildAndTestAttachment):
2773         (AbstractPatchApplyingCommand):
2774         (ApplyWatchList):
2775         (AbstractPatchLandingCommand):
2776         (CreateRollout):
2777         * Scripts/webkitpy/tool/steps/__init__.py:
2778         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2779         (CleanWorkingDirectory.options):
2780         (CleanWorkingDirectory.run):
2781         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2782         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2783         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2784
2785 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2786
2787         [Autotools] Add support for WebKit2-only builds
2788         https://bugs.webkit.org/show_bug.cgi?id=106889
2789
2790         Reviewed by Gustavo Noronha Silva.
2791
2792         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2793         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2794         building the GTK port through build-webkit.
2795         * Scripts/webkitdirs.pm:
2796         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2797         arguments when not building WebKit1.
2798         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2799         through the Autotools build system.
2800
2801 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2802
2803         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2804         https://bugs.webkit.org/show_bug.cgi?id=106197
2805
2806         Reviewed by Martin Robinson.
2807
2808         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2809         features. Enable them on GTK, meaning they will be enabled in development builds
2810         (i.e. when building with build-webkit).
2811
2812 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2813
2814         [GTK] Enable CSS Image Resolution feature
2815         https://bugs.webkit.org/show_bug.cgi?id=99038
2816
2817         Reviewed by Gustavo Noronha Silva.
2818
2819         Enable the CSS Image Resolution feature for the development
2820         builds of the GTK port.
2821
2822         * Scripts/webkitperl/FeatureList.pm:
2823
2824 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2825
2826         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2827         https://bugs.webkit.org/show_bug.cgi?id=106579
2828
2829         Reviewed by Gustavo Noronha Silva.
2830
2831         The --enable-unstable-features flag is not required to be passed anymore
2832         to the configure script as it was removed in r138252.
2833
2834         * Scripts/webkitdirs.pm:
2835         (buildAutotoolsProject):
2836
2837 2013-01-15  Tony Chang  <tony@chromium.org>
2838
2839         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2840
2841         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2842         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2843         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2844         (TestHttpServer.test_win32_start_and_stop):
2845
2846 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2847
2848         Unreviewed. Adding Michael Pruett as contributor.
2849
2850         * Scripts/webkitpy/common/config/committers.py:
2851
2852 2013-01-15  Victor Carbune  <victor@rosedu.org>
2853
2854         Unreviewed. Update my email addresses.
2855
2856         * Scripts/webkitpy/common/config/committers.py:
2857
2858 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2859
2860         [GTK] Waiting on the gdb process will lead to deadlock
2861         https://bugs.webkit.org/show_bug.cgi?id=106906
2862
2863         Reviewed by Philippe Normand.
2864
2865         Use communicate() rather than wait() on the Popen object that's running the gdb
2866         command. This avoids the deadlock that occurs on the GTK builders.
2867
2868         * Scripts/webkitpy/layout_tests/port/gtk.py:
2869         (GtkPort._get_gdb_output):
2870
2871 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2872
2873         [GTK] Limit the number of frames printed out when backtracing with gdb
2874         https://bugs.webkit.org/show_bug.cgi?id=106901
2875
2876         Reviewed by Philippe Normand.
2877
2878         Printing an unlimited number of frames when dumping the gdb backtracing
2879         output can cause timeouts in the builders. This patch limits the number
2880         of frames that are printed out to 1024.
2881
2882         * Scripts/webkitpy/layout_tests/port/gtk.py:
2883         (GtkPort._get_gdb_output):
2884
2885 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2886
2887         [Qt] Fix ImageDiff's image format conversion
2888         https://bugs.webkit.org/show_bug.cgi?id=106880
2889
2890         Reviewed by Csaba Osztrogonác.
2891
2892         Besides actually doing the conversion this also silences the suspicious warning:
2893         "ignoring return value of function declared with warn_unused_result attribute".
2894
2895         * ImageDiff/qt/ImageDiff.cpp:
2896         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2897         copy of the image in the given format and does not alter the image itself.
2898
2899 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2900
2901         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2902         https://bugs.webkit.org/show_bug.cgi?id=106823
2903
2904         Reviewed by Darin Fisher.
2905
2906         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2907         (DRTTestRunner::DRTTestRunner):
2908         (DRTTestRunner::reset):
2909         * DumpRenderTree/chromium/DRTTestRunner.h:
2910         (DRTTestRunner):
2911         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2912         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2913         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2914         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2915         (WebTestRunner::WebTestRunner::testRepaint):
2916         (WebTestRunner::WebTestRunner::sweepHorizontally):
2917         (WebTestRunner::WebTestRunner::isPrinting):
2918         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2919         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2920         (WebTestRunner::TestRunner::TestRunner):
2921         (WebTestRunner::TestRunner::reset):
2922         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2923         (WebTestRunner):
2924         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2925         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2926         (WebTestRunner::TestRunner::testRepaint):
2927         (WebTestRunner::TestRunner::sweepHorizontally):
2928         (WebTestRunner::TestRunner::isPrinting):
2929         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2930         (WebTestRunner::TestRunner::dumpBackForwardList):
2931         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2932         (WebTestRunner::TestRunner::dumpSelectionRect):
2933         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2934         (WebTestRunner::TestRunner::setPrinting):
2935         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2936         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2937         (TestRunner):
2938
2939 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2940
2941         nrwt: stub out show_results_html for mock ports
2942         https://bugs.webkit.org/show_bug.cgi?id=106848
2943
2944         Reviewed by Ojan Vafai.
2945
2946         We were accidentally using the underlying ports'
2947         show_results_html_file() implementation, which would, unsurprisingly,
2948         fail in many cases (e.g., running mock-efl on the mac).
2949
2950         No test added since we don't generally add tests for the mock
2951         implementation.
2952
2953         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2954         (MockDRTPort.show_results_html_file):
2955
2956 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2957
2958         Changing clean_working_directory/clean_local_commits and related
2959         functions to have consistent naming.
2960
2961         https://bugs.webkit.org/show_bug.cgi?id=104198
2962
2963         Reviewed by Adam Barth.
2964
2965         * Scripts/webkitpy/common/checkout/scm/git.py:
2966         * Scripts/webkitpy/common/checkout/scm/scm.py:
2967         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2968         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2969         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2970         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2971
2972 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2973
2974         Fix EWS GCE build scripts to detect which zone is available
2975         https://bugs.webkit.org/show_bug.cgi?id=106524
2976
2977         Reviewed by Adam Barth.
2978
2979         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2980         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2981         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2982         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2983
2984 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2985
2986         Adding an error string to AmbiguousCommitError.
2987         https://bugs.webkit.org/show_bug.cgi?id=106846
2988
2989         Reviewed by Adam Barth.
2990
2991         * Scripts/webkitpy/common/checkout/scm/git.py:
2992         (AmbiguousCommitError.__init__):
2993
2994 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2995
2996         kill whole lighttpd process tree for chromium win
2997         https://bugs.webkit.org/show_bug.cgi?id=106838
2998
2999         Reviewed by Tony Chang.
3000
3001         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
3002         I think a test is causing a httpd server child process to wedge and
3003         killing the parent httpd server process isn't sufficient to ensure
3004         that the children are also killed.
3005
3006         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3007         (Lighttpd._check_and_kill):
3008         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3009         (TestHttpServer.test_start_cmd):
3010         (TestHttpServer):
3011         (TestHttpServer.test_win32_start_and_stop):
3012         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
3013         (TestHttpServer.test_win32_start_and_stop.mock_returns):
3014         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
3015
3016 2013-01-14  Nico Weber  <thakis@chromium.org>
3017
3018         [chromium] Enable `update-webkit --chromium --ninja` on windows
3019         https://bugs.webkit.org/show_bug.cgi?id=106836
3020
3021         Reviewed by Eric Seidel.
3022
3023         After running this, build-webkit --chromium will use ninja to build.
3024         Apparently there are some minor issues with that still, so it's
3025         not quite ready for use yet.
3026
3027         * Scripts/webkitdirs.pm:
3028         (determineIsChromiumNinja):
3029         (buildChromium):
3030
3031 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3032
3033         nrwt: use the same search path for baselines and TestExpectations on apple mac
3034         https://bugs.webkit.org/show_bug.cgi?id=105599
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         Bug 105583 revealed some confusion due to the fact that the Apple
3039         Mac port used a different list of directories to search for baselines
3040         and TestExpectations files (actually, pretty much every port does).
3041
3042         It seems like a good idea to use the same list for both by default, but
3043         making this happen will affect every port in slightly different ways, so
3044         we'll try this on the Apple Mac port first.
3045
3046         Note that the effective changes for this are that:
3047         1) The apple mac port will look in platform/wk2 for baselines where
3048         it didn't before (it will look after looking in mac-wk2 but before
3049         the non-wk2 dirs)
3050         2) The apple mac-snowleopard port will use the expectations in
3051         mac-lion as well as the expectations in mac-snowleopard, although
3052         I'm not even sure if mac-snowleopard is still supported ...
3053
3054         * Scripts/webkitpy/layout_tests/port/mac.py:
3055         (MacPort.default_baseline_search_path):
3056         (MacPort.expectations_files):
3057         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3058         (test_baseline_search_path):
3059
3060 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3061
3062         AX: Need to implement ColorWellRole
3063         https://bugs.webkit.org/show_bug.cgi?id=106756
3064
3065         Reviewed by Chris Fleizach.
3066
3067         Returns a string representation of the value of a color
3068         when the role is Color Well, to make it easy to write layout
3069         tests for color controls.
3070
3071         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3072
3073 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3074
3075         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
3076         https://bugs.webkit.org/show_bug.cgi?id=106682
3077
3078         Reviewed by Chris Fleizach.
3079
3080         Modify Chromium's DRT implementation of intValue to return a
3081         different value depending on the role.
3082
3083         There are actually platform-specific differences in what should
3084         be returned in the "value" of an object, so Chromium normally keeps
3085         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
3086         but this is a fine simplification to make cross-platform tests easier.
3087
3088         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3089         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
3090
3091 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
3092
3093         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
3094         https://bugs.webkit.org/show_bug.cgi?id=106785
3095
3096         Reviewed by Adam Barth.
3097
3098         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3099         (DRTTestRunner::DRTTestRunner):
3100         (DRTTestRunner::reset):
3101         * DumpRenderTree/chromium/DRTTestRunner.h:
3102         (DRTTestRunner):
3103         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3104         (WebTestProxyBase):
3105         (WebTestRunner::WebTestProxy::setStatusText):
3106         (WebTestRunner::WebTestProxy::didStopLoading):
3107         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3108         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
3109         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
3110         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3111         (WebTestRunner::TestRunner::TestRunner):
3112         (WebTestRunner::TestRunner::reset):
3113         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
3114         (WebTestRunner):
3115         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
3116         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
3117         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
3118         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3119         (TestRunner):
3120         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3121         (WebTestRunner::WebTestProxyBase::setStatusText):
3122         (WebTestRunner):
3123         (WebTestRunner::WebTestProxyBase::didStopLoading):
3124         * DumpRenderTree/chromium/WebViewHost.cpp:
3125         (WebViewHost::didStopLoading):
3126         * DumpRenderTree/chromium/WebViewHost.h:
3127         (WebViewHost):
3128
3129 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3130
3131         Web Inspector: devtools front-end doesn't have focus in TestShell
3132         https://bugs.webkit.org/show_bug.cgi?id=106778
3133
3134         Reviewed by Pavel Feldman.
3135
3136         Focus devTools window after loadURL method.
3137
3138         * DumpRenderTree/chromium/TestShell.cpp:
3139         (TestShell::runFileTest):
3140
3141 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3142
3143         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
3144         https://bugs.webkit.org/show_bug.cgi?id=106573
3145
3146         Reviewed by Philippe Normand.
3147
3148         Similarly to what's been described in bug 106569, we're building
3149         from release tarballs, so there's no reason to regenerate the
3150         autoconf-related stuff with autogen.sh, especially since we might
3151         run into trouble with automake 1.13 and deprecated macros.
3152
3153         * efl/jhbuild.modules:
3154
3155 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3156
3157         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
3158         https://bugs.webkit.org/show_bug.cgi?id=104909
3159
3160         Reviewed by Simon Hausmann.
3161
3162         To be able to build redistribuable binary packages, Qt's configure switches
3163         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
3164         dynamically link to optional system libraries.
3165         QtWebKit is doing its own configure checks for those libraries, thus adding a
3166         runtime dependency that might not be fulfilled if the packager's machine had
3167         those libraries while the user's machine won't.
3168
3169         Since in most cases where WebKit will want to use those system libraries, Qt will
3170         also be using them, remove these configure tests from WebKit.
3171
3172         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
3173         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
3174         * qmake/config.tests/libpng/libpng.cpp: Removed.
3175         * qmake/config.tests/libpng/libpng.pro: Removed.
3176         * qmake/mkspecs/features/features.prf:
3177
3178 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3179
3180         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
3181         https://bugs.webkit.org/show_bug.cgi?id=106574
3182
3183         Reviewed by Laszlo Gombos.
3184
3185         Rely on a more recent stable release, which includes support for
3186         Lua 5.2 in Edje and other assorted minor fixes.
3187
3188         While here, also use the "configure" script to build the libraries
3189         instead of relying on autogen.sh, which is not really needed with
3190         a release tarball and may have problems with automake 1.13.
3191
3192         * efl/jhbuild.modules:
3193
3194 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3195
3196         Web Inspector: fix DRT to deliver simulated events to devtools front-end
3197         https://bugs.webkit.org/show_bug.cgi?id=106650
3198
3199         Reviewed by Pavel Feldman.
3200
3201         Add separated m_devToolsTestInterfaces object to testShell which is
3202         bind to devTools webview.
3203
3204         * DumpRenderTree/chromium/TestShell.cpp:
3205         (TestShell::initialize):
3206         (TestShell::createMainWindow):
3207         (TestShell::~TestShell):
3208         (TestShell::showDevTools):
3209         (TestShell::resetTestController):
3210         (TestShell::bindJSObjectsToWindow):
3211         (TestShell::createNewWindow):
3212         * DumpRenderTree/chromium/TestShell.h:
3213         (TestShell):
3214
3215 2013-01-14  Alan Cutter  <alancutter@chromium.org>
3216
3217         Sheriffbot command aliases need test cases
3218         https://bugs.webkit.org/show_bug.cgi?id=106754
3219
3220         Reviewed by Eric Seidel.
3221
3222         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3223         (SheriffBotTest.test_command_aliases):
3224
3225 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3226
3227         Allow users to misspell the "sheriffs" command in sheriffbot
3228         https://bugs.webkit.org/show_bug.cgi?id=106628
3229
3230         Reviewed by Steve Block.
3231
3232         * Scripts/webkitpy/tool/bot/irc_command.py:
3233
3234 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3235
3236         Make "gardeners" an alias for "sheriffs" in sherrifbot
3237         https://bugs.webkit.org/show_bug.cgi?id=106627
3238
3239         Reviewed by Eric Seidel.
3240
3241         * Scripts/webkitpy/tool/bot/irc_command.py:
3242
3243 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
3244
3245         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
3246         https://bugs.webkit.org/show_bug.cgi?id=105380
3247
3248         Reviewed by Eric Seidel.
3249
3250         Fix a regression introduced in r137692 where we were double-encoding
3251         the arguments to popen(); this was only an issue on windows, where
3252         we would try to encode something to mbcs, then try to encode it
3253         to unicode as if the input as ascii.
3254
3255         * Scripts/webkitpy/common/system/executive.py:
3256         (Executive.run_command):
3257
3258 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3259
3260         State who told sheriffbot to roll the Chromium deps and to what revision
3261         https://bugs.webkit.org/show_bug.cgi?id=106626
3262
3263         Reviewed by Eric Seidel.
3264
3265         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
3266
3267         * Scripts/webkitpy/tool/bot/irc_command.py:
3268         (RollChromiumDEPS._expand_irc_nickname):
3269         (RollChromiumDEPS.execute):
3270         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3271         (IRCCommandTest.test_roll_chromium_deps):
3272         * Scripts/webkitpy/tool/bot/sheriff.py:
3273         (Sheriff.post_chromium_deps_roll):
3274         * Scripts/webkitpy/tool/commands/roll.py:
3275         (RollChromiumDEPS._prepare_state):
3276         (PostChromiumDEPSRoll):
3277         (PostChromiumDEPSRoll._prepare_state):
3278         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3279         (PostRollCommandsTest.test_prepare_state):
3280         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3281         (PrepareChangeLogForDEPSRoll.run):
3282
3283 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3284
3285         Add Alan Cutter as contributor
3286         https://bugs.webkit.org/show_bug.cgi?id=106747
3287
3288         Reviewed by Eric Seidel.
3289
3290         * Scripts/webkitpy/common/config/committers.py:
3291
3292 2013-01-13  Jonathan Liu  <net147@gmail.com>
3293
3294         Fix CONFIG missing link_pkgconfig on Windows
3295         https://bugs.webkit.org/show_bug.cgi?id=106647
3296
3297         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
3298         properly on Windows because they are added to PKGCONFIG but
3299         CONFIG does not contain link_pkgconfig.
3300
3301         This is because link_pkgconfig is added in unix/default_pre.prf
3302         which is only used for UNIX platforms. To fix this, move it to
3303         the general default_pre.prf.
3304
3305         Reviewed by Simon Hausmann.
3306
3307         * qmake/mkspecs/features/default_pre.prf:
3308         * qmake/mkspecs/features/unix/default_pre.prf:
3309
3310 2013-01-12  Nico Weber  <thakis@chromium.org>
3311
3312         nrwt/chromium: Don't prefer chromium over webkit build directories
3313         https://bugs.webkit.org/show_bug.cgi?id=105597
3314
3315         Reviewed by Dirk Pranke.
3316
3317         Rely on the new timestamp logic instead. Requested by dpranke in
3318         https://bugs.webkit.org/show_bug.cgi?id=105498
3319
3320         * Scripts/webkitpy/layout_tests/port/chromium.py:
3321         (ChromiumPort._static_build_path):
3322         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3323         (ChromiumLinuxPortTest.test_build_path):
3324         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3325         (ChromiumMacPortTest.test_build_path):
3326         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3327         (ChromiumWinTest.test_build_path):
3328
3329 2013-01-12  Nico Weber  <thakis@chromium.org>
3330
3331         Use ninja by default on Linux for build-webkit --chromium, bot edition
3332         https://bugs.webkit.org/show_bug.cgi?id=104434
3333
3334         Reviewed by Eric Seidel.
3335
3336         r139557 changed update-webkit to pick ninja by default on linux, but
3337         the bots run update-webkit-chromium directly so they didn't see this.
3338         Move the default for ninja into update-webkit-chromium so that it's
3339         picked up by the bots, and let update-webkit forward non-default
3340         options to there.
3341
3342         This way, the default is in one place only and both developers (who
3343         usually use update-webkit which then shells out to
3344         updat-webkit-chromium) and bots (which use update-webkit-chromium
3345         directly) see the same behavior.
3346
3347         * Scripts/update-webkit:
3348         * Scripts/update-webkit-chromium:
3349
3350 2013-01-12  Nico Weber  <thakis@chromium.org>
3351
3352         Make ninja the default build system on Linux for build-webkit --chromium
3353         https://bugs.webkit.org/show_bug.cgi?id=104434
3354
3355         Reviewed by Eric Seidel.
3356
3357         * Scripts/update-webkit:
3358
3359 2013-01-12  Alan Cutter  <alancutter@chromium.org>
3360
3361         Migrate the remaining bots in EC2 to Google Compute Engine
3362         https://bugs.webkit.org/show_bug.cgi?id=106005
3363
3364         Reviewed by Eric Seidel.
3365
3366         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
3367
3368         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
3369         * EWSTools/boot.sh:
3370         * EWSTools/build-repo.sh:
3371         * EWSTools/start-queue.sh:
3372
3373 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
3374
3375         [chromium] move inspector related methods to TestRunner library
3376         https://bugs.webkit.org/show_bug.cgi?id=106654
3377
3378         Reviewed by Adam Barth.
3379
3380         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3381         (DRTTestRunner::DRTTestRunner):
3382         * DumpRenderTree/chromium/DRTTestRunner.h:
3383         (DRTTestRunner):
3384         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3385         (WebTestRunner::WebTestDelegate::showDevTools):
3386         (WebTestRunner::WebTestDelegate::closeDevTools):
3387         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
3388         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3389         (WebTestRunner::TestRunner::TestRunner):
3390         (WebTestRunner::TestRunner::showWebInspector):
3391         (WebTestRunner):
3392         (WebTestRunner::TestRunner::closeWebInspector):
3393         (WebTestRunner::TestRunner::evaluateInWebInspector):
3394         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3395         (TestRunner):
3396         * DumpRenderTree/chromium/WebViewHost.cpp:
3397         (WebViewHost::showDevTools):
3398         (WebViewHost::closeDevTools):
3399         (WebViewHost::evaluateInWebInspector):
3400         * DumpRenderTree/chromium/WebViewHost.h:
3401         (WebViewHost):
3402
3403 2013-01-11  Julie Parent  <jparent@chromium.org>
3404
3405         Builder should not be a valid parameter for stats dashboard
3406         https://bugs.webkit.org/show_bug.cgi?id=106698
3407
3408         Reviewed by Dirk Pranke.
3409         
3410         Since builder is a dashboard specific parameter, dashboard_base
3411         should not be handling it in handleValidHashParameterWrapper, rather,
3412         each specific dashboard should in its handleValidHashParameter function.
3413     
3414         Note that the FIXME in dashboard_base about this was actually wrong -
3415         we don't want to move it to g_crossDashboardState, because it isn't
3416         actually cross dashboard state.
3417         
3418         In fact, flakiness and treemap have the code in 
3419         handleValidHashParameter, but it is currently dead code because 
3420         dashboard_base gets to it first.
3421         
3422         Added the proper handling to timeline_explorer, since builder is
3423         valid there.
3424
3425         * TestResultServer/static-dashboards/dashboard_base.js:
3426         * TestResultServer/static-dashboards/timeline_explorer.html:
3427
3428 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3429
3430         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
3431         https://bugs.webkit.org/show_bug.cgi?id=106688
3432
3433         Reviewed by Eric Seidel.
3434
3435         Update the regular expression used to strip the garbage at the beginning.
3436
3437         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3438         (RunWebKitTests.nrwt_log_message_regexp):
3439
3440 2013-01-11  Pratik Solanki  <psolanki@apple.com>
3441
3442         TestRunner leaks when running tests
3443         https://bugs.webkit.org/show_bug.cgi?id=106683
3444
3445         Reviewed by Simon Fraser.
3446
3447         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
3448         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
3449         tests.
3450
3451         * DumpRenderTree/TestRunner.cpp:
3452         (TestRunner::makeWindowObject):
3453
3454 2013-01-11  Julie Parent  <jparent@chromium.org>
3455
3456         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
3457         https://bugs.webkit.org/show_bug.cgi?id=106247
3458
3459         Old code nulled out the loader instance when it completed loading and
3460         then later used the fact that it was null to determine if it had loaded
3461         or not.  This is not only unintuitive, but it also prevents using the
3462         loader object later on.
3463         
3464         Added new method, used it, added unit test for it.
3465         
3466         Reviewed by Dirk Pranke.
3467
3468         * TestResultServer/static-dashboards/dashboard_base.js:
3469         (resourceLoadingComplete):
3470         (handleLocationChange):
3471         * TestResultServer/static-dashboards/loader.js:
3472         (.):
3473         * TestResultServer/static-dashboards/loader_unittests.js:
3474
3475 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3476
3477         Try CRLF to LF change in r139407 again.
3478
3479         * BuildSlaveSupport/delete-stale-build-files:
3480         (main):
3481         (webkitBuildDirectory):
3482         * BuildSlaveSupport/kill-old-processes:
3483         (main):
3484
3485 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         [GTK] Disable the unit tests timeout when running from make check
3488         https://bugs.webkit.org/show_bug.cgi?id=106670
3489
3490         Reviewed by Philippe Normand.
3491
3492         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
3493
3494 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3495
3496         Yet another unreviewed fix after r139431.
3497
3498         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
3499         the correct order.
3500
3501 2013-01-11  Dan Carney  <dcarney@google.com>
3502
3503         [chromium] move some whitespace and resize related methods to TestRunner library
3504         https://bugs.webkit.org/show_bug.cgi?id=106655
3505
3506         Reviewed by Jochen Eisinger.
3507
3508         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3509         (DRTTestRunner::DRTTestRunner):
3510         * DumpRenderTree/chromium/DRTTestRunner.h:
3511         (DRTTestRunner):
3512         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3513         (WebKit):
3514         (WebTestRunner::WebTestDelegate::setClientWindowRect):
3515         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
3516         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
3517         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3518         (WebTestRunner::TestRunner::TestRunner):
3519         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
3520         (WebTestRunner):
3521         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
3522         (WebTestRunner::TestRunner::enableAutoResizeMode):
3523         (WebTestRunner::TestRunner::disableAutoResizeMode):
3524         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3525         (TestRunner):
3526         * DumpRenderTree/chromium/WebViewHost.cpp:
3527         (WebViewHost::setClientWindowRect):
3528         * DumpRenderTree/chromium/WebViewHost.h:
3529         (WebViewHost):
3530
3531 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3532
3533         Unreviewed. Update my e-mail addresses.
3534
3535         * Scripts/webkitpy/common/config/committers.py:
3536
3537 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3538
3539         Another unreviewed fix after r139431.
3540
3541         In a way, this is also a generic bug fix, since previously isEfl()
3542         would fail when called from run-efl-tests and we thus did not use
3543         jhbuild to run our tests. This now resulted in us calling
3544         "jhbuild-wrapper run" without specifying a platform.
3545
3546         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3547         to work.
3548
3549 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3550
3551         [Qt][WK1] Web Audio support
3552         https://bugs.webkit.org/show_bug.cgi?id=106651
3553
3554         Reviewed by Jocelyn Turcotte.
3555
3556         Implements support for dumping audio data in DumpRenderTree.
3557
3558         Adds WebAudio to toggleable features in QtTestBrowser.
3559
3560         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3561         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3562
3563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3564         (WebCore::DumpRenderTree::dump):
3565         * DumpRenderTree/qt/TestRunnerQt.cpp:
3566         (TestRunner::reset):
3567         (TestRunner::overridePreference):
3568         (TestRunner::setAudioData):
3569         * DumpRenderTree/qt/TestRunnerQt.h:
3570         (TestRunner::shouldDumpAsAudio):
3571         (TestRunner::audioData):
3572         (TestRunner):
3573         * QtTestBrowser/launcherwindow.cpp:
3574         (LauncherWindow::applyPrefs):
3575         (LauncherWindow::createChrome):
3576         (LauncherWindow::toggleWebAudio):
3577         * QtTestBrowser/launcherwindow.h:
3578         (WindowOptions::WindowOptions):
3579         (WindowOptions):
3580         (LauncherWindow):
3581         * qmake/mkspecs/features/features.prf:
3582         * qmake/mkspecs/features/features.pri:
3583
3584 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3585
3586         Unreviewed jhbuild-related fix after r139431.
3587
3588         * Scripts/webkitpy/layout_tests/port/efl.py:
3589         (EflPort.__init__): Pass a string to set_option_default(), since
3590         shlex.split() will be called on it later.
3591
3592 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3593
3594         Unreviewed typo fixes after r139431.
3595
3596         * Scripts/run-javascriptcore-tests:
3597
3598 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3599
3600         [jhbuild] Remove the "run-with-jhbuild" scripts.
3601         https://bugs.webkit.org/show_bug.cgi?id=106572
3602
3603         Reviewed by Martin Robinson.
3604
3605         Both ports which use jhbuild were mostly duplicating the
3606         `run-with-jhbuild' script in their own directories for no clear reason.
3607
3608         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3609         so just start using that directly and get rid of a useless middle man.
3610
3611         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3612         instead.
3613
3614         * Scripts/run-javascriptcore-tests:
3615         * Scripts/run-launcher:
3616         * Scripts/webkitdirs.pm:
3617         (runAutogenForAutotoolsProjectIfNecessary):
3618         (buildAutotoolsProject):
3619         (jhbuildWrapperPrefixIfNeeded):
3620         (generateBuildSystemFromCMakeProject):
3621         (buildCMakeGeneratedProject):
3622         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3623         (run):
3624         * Scripts/webkitpy/layout_tests/port/efl.py:
3625         (EflPort.__init__):
3626         (EflPort._image_diff_command):
3627         * efl/run-with-jhbuild: Removed.
3628         * gtk/run-with-jhbuild: Removed.
3629
3630 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3631
3632         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3633         https://bugs.webkit.org/show_bug.cgi?id=106636
3634
3635         Reviewed by Adam Barth.
3636
3637         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3638
3639         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3640         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3641         * EWSTools/screen-config:
3642         * EWSTools/start-queue.sh:
3643
3644 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3645
3646         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3647         https://bugs.webkit.org/show_bug.cgi?id=106622
3648
3649         Reviewed by Simon Fraser.
3650
3651         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3652         Also escape clang\+\+ correctly in kill-old-processes.
3653
3654         * BuildSlaveSupport/delete-stale-build-files:
3655         * BuildSlaveSupport/kill-old-processes:
3656
3657 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3658
3659         Build fix after r139357. It was missing a comma.
3660
3661         * QueueStatusServer/model/queues.py:
3662         (Queue):
3663
3664 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3665
3666         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3667         https://bugs.webkit.org/show_bug.cgi?id=106420
3668
3669         Reviewed by Eric Seidel.
3670
3671         * Scripts/webkitpy/common/checkout/scm/git.py:
3672         (Git.push_local_commits_to_server):
3673         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3674         * Scripts/webkitpy/common/checkout/scm/svn.py:
3675         (SVNRepository):
3676         (SVNRepository.has_authorization_for_realm):
3677
3678 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3679
3680         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3681         https://bugs.webkit.org/show_bug.cgi?id=106552
3682
3683         Reviewed by Laszlo Gombos.
3684
3685         Use tarballs for gstreamer instead of git in EFL's jhbuild
3686         to work around intermittent network issues on our build
3687         bots. Tarballs are fully cached and require no network
3688         operation if their checksum matches.