[wx] Unreviewed build fix for Mac installation script.
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Unreviewed build fix for Mac installation script.
4
5         * wx/packaging/build-mac-installer.py:
6
7 2011-04-14  Ojan Vafai  <ojan@chromium.org>
8
9         Reviewed by Tony Chang.
10
11         sort columns in the new json_results.html file
12         https://bugs.webkit.org/show_bug.cgi?id=58581
13
14         Also fix padding on TDs and the path to layout tests.
15
16         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
17
18 2011-04-14  Eric Seidel  <eric@webkit.org>
19
20         Reviewed by Dimitri Glazkov.
21
22         queues.webkit.org should display when a bot last passed a patch
23         https://bugs.webkit.org/show_bug.cgi?id=58546
24
25         I am suspicious that some of our commit-queue instances are never
26         actually passing anything.
27
28         This will let us know if those bots are never passing patches.
29
30         * QueueStatusServer/handlers/queuestatus.py:
31         * QueueStatusServer/index.yaml:
32         * QueueStatusServer/templates/queuestatus.html:
33
34 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
35
36         Reviewed by Adam Roben.
37
38         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
39         https://bugs.webkit.org/show_bug.cgi?id=58545
40
41         Remove platform-specific overrides; the default behavior should
42         be working everywhere now, I think.
43
44         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
45         * Scripts/webkitpy/layout_tests/port/mac.py:
46
47 2011-04-14  Eric Seidel  <eric@webkit.org>
48
49         Reviewed by Adam Barth.
50
51         commit-queues are hitting an exception trying to land when the tree is red
52         https://bugs.webkit.org/show_bug.cgi?id=58558
53
54         Just an un-tested (and thus broken) code path from yesterday's changes.
55
56         * Scripts/webkitpy/common/net/layouttestresults.py:
57         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
58         * Scripts/webkitpy/tool/commands/queues.py:
59         * Scripts/webkitpy/tool/commands/queues_unittest.py:
60
61 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
62
63         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
64
65         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
66         (LayoutTestController::shadowRoot):
67         * wx/build/wxpresets.py:
68
69 2011-04-14  Victoria Kirst  <vrk@google.com>
70
71         Reviewed by James Robinson.
72
73         [chromium] Failing GPU video tests
74         https://bugs.webkit.org/show_bug.cgi?id=57926
75
76         Added/updated GPU directory names for rebaseline tool.
77
78         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
79
80 2011-04-13  Daniel Bates  <dbates@rim.com>
81
82         Reviewed by Adam Barth.
83
84         Perl unit test removeEOL.pl should print test case name on failure
85         https://bugs.webkit.org/show_bug.cgi?id=58513
86
87         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
88           second argument of Test::Simple::ok().
89
90 2011-04-13  Kent Tamura  <tkent@chromium.org>
91
92         Reviewed by Eric Seidel.
93
94         gdb-safari should pass arguments to safari.
95         https://bugs.webkit.org/show_bug.cgi?id=58439
96
97         We can do:
98           gdb-safari --debug LayoutTests/.../foo.html
99
100         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
101
102 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
103
104         Unreviewed, build fix.
105         https://bugs.webkit.org/show_bug.cgi?id=52763
106
107         r83799 broke test-webkitpy because it assumed we always have
108         access to a real filesystem (we don't during the unit tests).
109         Stubbing out the copy for now but we might need a better
110         solution at some point.
111
112         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
113
114 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Tony Chang.
117
118         new-run-webkit-tests --run-singly option is busted
119         https://bugs.webkit.org/show_bug.cgi?id=55909
120
121         Python's broken lexical scoping strikes again :(.
122
123         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
124         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
125
126 2011-04-13  Ojan Vafai  <ojan@chromium.org>
127
128         Reviewed by Eric Seidel.
129
130         generated unexpected_results.html from unexpected_results.json
131         https://bugs.webkit.org/show_bug.cgi?id=52763
132
133         Eventually, we'll merge this with results.html and have a single richer results page.
134         For now, I just want to get something checked in that we can iterate on.
135
136         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
137         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
138
139 2011-04-13  Eric Seidel  <eric@webkit.org>
140
141         Reviewed by Adam Barth.
142
143         Up the failure limit to allow the commit-queue to actually land when the tree is red
144         https://bugs.webkit.org/show_bug.cgi?id=58499
145
146         This change increases the --exit-after-N-failures limit used by the commit-queue
147         from 1 to 10.  This will cause the code added in bug 58494 to actually get
148         exercised and the queues should start being able to land when the trees are red.
149
150         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
151         only unit test to actually detect this change!  Since we don't actually
152         run on leopard anymore, I removed the hack code and repurposed the test.
153
154         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
155         * Scripts/webkitpy/tool/steps/runtests.py:
156         * Scripts/webkitpy/tool/steps/steps_unittest.py:
157
158 2011-04-13  Eric Seidel  <eric@webkit.org>
159
160         Reviewed by Adam Barth.
161
162         commit-queue should be able to land when tree is red
163         https://bugs.webkit.org/show_bug.cgi?id=58494
164
165         There is some yak hair on my hands, I will admit.
166
167         This change is mostly about adding an ExpectedFailures
168         class to track when the bots are red and we should be
169         ignoring failures when landing from the commit-queue.
170
171         However, to make intelligent decisions about patches we
172         need to know whether the run hit the --exit-after-N-failures limit
173         or not.  Right now that information is not saved off in results.html
174         so we have to pull the information from RunTests.
175
176         I've plumbed the --exit-after-N-failures information into
177         LayoutTestResults for now to make the ExpectedFailures code cleaner.
178
179         As a result of adding all these additional calls to delegate.layout_test_results()
180         I broke some of our flaky test detection tests and had to re-write them
181         to not depend on the number of layout_test_results code.
182
183         At the same time I updated the commit-queue to use the newer filesystem
184         API (to allow us to use MockFileSystem) which required further changes
185         to the layout tests.  Changes were required in either case, since
186         we're now calling layout_test_results() in more cases, which previously
187         would try and hit the disk (until I moved it to use tool.filesystem).
188
189         I should note that *all* of this code is disabled for now, since our
190         --exit-after-N-failures limit is currently 1!  (Thus were always in the
191         case where we can't actually tell if the layout test results are legit.)
192         I will up that limit in a second patch (which may require a couple more unit test tweaks).
193
194         * Scripts/webkitpy/common/net/layouttestresults.py:
195         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
196         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
197         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
198         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
199         * Scripts/webkitpy/tool/commands/queues.py:
200         * Scripts/webkitpy/tool/commands/queues_unittest.py:
201         * Scripts/webkitpy/tool/commands/queuestest.py:
202         * Scripts/webkitpy/tool/steps/runtests.py:
203
204 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
205
206         Unreviewed build correction.
207
208         * TestWebKitAPI/PlatformWebView.h: Limit include of
209           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
210
211 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
212
213         Reviewed by Eric Seidel.
214
215         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
216         https://bugs.webkit.org/show_bug.cgi?id=58489
217         
218         r83743 added --additional-platform-directory to old-run-webkit-tests,
219         rename the equivalent flag in new-run-webkit-tests to be consistent.
220
221         * Scripts/webkitpy/layout_tests/port/base.py:
222         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
223         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
224         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
225
226 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
227
228         Reviewed by Eric Seidel.
229
230         Rebaseline queue server
231         https://bugs.webkit.org/show_bug.cgi?id=57891
232
233         Adds a simple rebaseline queue server (meant to run at
234         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
235         builders and their failing tests, and allows those tests to be added to
236         a per-builer rebaseline queue.
237
238         A subsequent change will add a mode to NRWT (and/or a wrapper script)
239         for pulling the tests to be rebaselined from the server and running them
240         with --reset-results (the initial use-case is for the GPU hardware bots,
241         which do not have checked-in baselines, therefore there is no need for a
242         check-in step yet).
243
244         * RebaselineQueueServer/app.yaml: Added.
245         * RebaselineQueueServer/handlers/__init__.py: Added.
246         * RebaselineQueueServer/handlers/builderqueue.py: Added.
247         * RebaselineQueueServer/handlers/pages.py: Added.
248         * RebaselineQueueServer/index.yaml: Added.
249         * RebaselineQueueServer/main.py: Added.
250         * RebaselineQueueServer/model/__init__.py: Added.
251         * RebaselineQueueServer/model/queueentry.py: Added.
252         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
253         * RebaselineQueueServer/static/styles.css: Added.
254         * RebaselineQueueServer/templates/builder-picker.html: Added.
255         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
256         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
257         * RebaselineQueueServer/templates/home.html: Added.
258
259 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
260
261         Reviewed by Mihai Parparita.
262
263         nrwt: enable multiple processes by default on Chromium Win.
264         https://bugs.webkit.org/show_bug.cgi?id=55163
265
266         Re-land r79268; it should be more stable now and will hopefully
267         work.
268
269         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
270         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
271
272 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
273
274         Reviewed by Ojan Vafai.
275
276         new-run-webkit-tests: configure logging in child processes properly
277         https://bugs.webkit.org/show_bug.cgi?id=58296
278
279         Logging propagated properly from manager to worker processes on
280         Unix but not on Windows; this fixes that.
281
282         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
283         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
284
285 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
286
287         Reviewed by Ojan Vafai.
288
289         new-run-webkit-tests: suppress extraneous pretty patch warnings
290         https://bugs.webkit.org/show_bug.cgi?id=58295
291
292         NRWT wasn't being careful about when it logged messages from
293         PrettyPatch not being available; it should only log during
294         check_build(), and be silent otherwise. This was causing us to
295         get multiple errors at runtime, which was confusing.
296
297         * Scripts/webkitpy/layout_tests/port/base.py:
298         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
299         * Scripts/webkitpy/layout_tests/port/chromium.py:
300
301 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
302
303         Reviewed by Jian Li.
304
305         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
306         https://bugs.webkit.org/show_bug.cgi?id=58461
307
308         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
309
310 2011-04-13  Tony Chang  <tony@chromium.org>
311
312         Unreviewed, fix NRWT.  Stack:
313
314             return super(ChromiumPort, self).results_directory(self)
315         TypeError: results_directory() takes exactly 1 argument (2 given)
316
317         * Scripts/webkitpy/layout_tests/port/chromium.py:
318
319 2011-04-13  Adam Roben  <aroben@apple.com>
320
321         Teach ORWT about extra platform-specific directories to be searched before the default ones
322
323         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
324         platform-specific results
325
326         Reviewed by Anders Carlsson.
327
328         * Scripts/old-run-webkit-tests:
329         (top-level): Added @additionalPlatformDirectories and hooked up
330         --additional-platform-directories to populate it.
331         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
332         list (after filtering out any of the additional directories that don't exist).
333
334 2011-04-13  Lucas Forschler  <lforschler@apple.com>
335
336         Reviewed by Adam Roben.
337
338         Add the /T command to taskkill.exe.
339         This will kill spawned child processes.
340         
341         * BuildSlaveSupport/win/kill-old-processes:
342
343 2011-04-13  Lucas Forschler  <lforschler@apple.com>
344
345         Reviewed by Adam Roben.
346
347         Sort kill list alphabeticaly.
348         Fixed capitalization on VcBuildHelper.  
349
350         * BuildSlaveSupport/win/kill-old-processes:
351
352 2011-04-13  Lucas Forschler  <lforschler@apple.com>
353
354         Reviewed by Adam Roben.
355
356         https://bugs.webkit.org/show_bug.cgi?id=58384
357         Update kill-old-processes to include a few new ones.
358         
359         * BuildSlaveSupport/win/kill-old-processes:
360
361 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
362
363         Reviewed by Martin Robinson.
364
365         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
366         https://bugs.webkit.org/show_bug.cgi?id=58297
367
368         Do not disable flash specifically when built with GTK+ 3 -
369         PluginPackage should do the right thing while loading plugins.
370
371         * GtkLauncher/main.c:
372         (main):
373
374 2011-04-12  Kent Tamura  <tkent@chromium.org>
375
376         Reviewed by Dimitri Glazkov.
377
378         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
379         https://bugs.webkit.org/show_bug.cgi?id=57426
380
381         * DumpRenderTree/chromium/WebPreferences.cpp:
382         (WebPreferences::applyTo): Disable the validation message timer.
383
384 2011-04-12  James Kozianski  <koz@chromium.org>
385
386         Unreviewed.
387
388         Adding myself to committers.py.
389
390         * Scripts/webkitpy/common/config/committers.py:
391
392 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
393
394         Unreviewed build correction for WinCairo bot after r83639.
395         https://bugs.webkit.org/show_bug.cgi?id=51790
396
397         Correct typo for the new "update-webkit-wincairo-libs" script.
398
399         * Scripts/build-webkit: Incorrectly calling the
400           update-webkit-cairo-libs which does not exist.
401
402 2011-04-12  Alice Liu  <alice.liu@apple.com>
403
404         Reviewed by Jon Honeycutt.
405
406         A change that should have been part of http://trac.webkit.org/changeset/83628
407
408         * DumpRenderTree/win/DumpRenderTree.cpp:
409         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
410
411 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
412
413         Reviewed by Tony Chang.
414
415         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
416         https://bugs.webkit.org/show_bug.cgi?id=58272
417
418         NRWT was interpreting the --results-directory cmd line arg as
419         relative to the build directory, not the current working
420         directory (ORWT uses the latter, which is much more intuitive).
421         
422         This patch fixes the base case, but includes an override for
423         Chromium that is needed until the bots can be updated.
424
425         * Scripts/webkitpy/layout_tests/port/base.py:
426         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
427         * Scripts/webkitpy/layout_tests/port/chromium.py:
428         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
429         * Scripts/webkitpy/layout_tests/port/test.py:
430         * Scripts/webkitpy/layout_tests/port/webkit.py:
431         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
432         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
433
434 2011-04-12  Philippe Normand  <pnormand@igalia.com>
435
436         Unreviewed, roll out r83621 as it broke the GTK build.
437
438         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
439         https://bugs.webkit.org/show_bug.cgi?id=58333
440
441         * Scripts/build-jsc:
442         * Scripts/build-webkit:
443
444 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
445
446         Reviewed by Adam Roben.
447
448         Patch to download the WinCairo dependancies as part of build-webkit.
449         https://bugs.webkit.org/show_bug.cgi?id=51790
450
451         This patch downloads the dependancies from 
452             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
453         checking the modification timestamp etc. 
454
455         * Tools/Scripts/build-webkit
456         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
457           flag, and to update WinCairo dependencies when used.
458         * Tools/Scripts/update-webkit-cairo-libs: added
459         * Tools/Scripts/update-webkit-dependency: added
460         * Tools/Scripts/update-webkit-auxiliary-libs
461
462 2011-04-12  Jeff Miller  <jeffm@apple.com>
463
464         Reviewed by Adam Roben.
465
466         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
467         https://bugs.webkit.org/show_bug.cgi?id=56020
468
469         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
470         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
471         which would generate two characters for every keypress (for example).  I didn't bother doing this for
472         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
473         
474         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
475
476         * MiniBrowser/win/main.cpp:
477         (shouldTranslateMessage): Added.
478         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
479         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
480         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
481         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
482         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
483         (TestWebKitAPI::runAndWatchForWMChar): Added.
484         (TestWebKitAPI::TEST): Added.
485         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
486         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
487         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
488         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
489         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
490         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
491
492 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
493
494         Reviewed by Tony Chang.
495
496         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
497         https://bugs.webkit.org/show_bug.cgi?id=58290
498
499         This is some preliminary refactoring for bug 58272.
500
501         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
502         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
503         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
504         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
505         * Scripts/webkitpy/layout_tests/port/test.py:
506         * Scripts/webkitpy/layout_tests/port/chromium.py:
507         * Scripts/webkitpy/layout_tests/port/base.py:
508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
509
510 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
511
512         Reviewed by Eric Seidel.
513
514         webkitpy: fix mock_filesystem abspath to handle relative paths
515         and add filesystem.chdir() and filesystem.getcwd() to be able
516         to test this and mock it out.
517
518         https://bugs.webkit.org/show_bug.cgi?id=58288
519
520         * Scripts/webkitpy/common/system/filesystem.py:
521         * Scripts/webkitpy/common/system/filesystem_mock.py:
522         * Scripts/webkitpy/common/system/filesystem_unittest.py:
523
524 2011-04-12  Alice Liu  <alice.liu@apple.com>
525
526         Reviewed by Sam Weinig.
527
528         https://bugs.webkit.org/show_bug.cgi?id=58292
529         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
530
531         * DumpRenderTree/mac/DumpRenderTree.mm:
532         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
533
534 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
535
536         Reviewed by Eric Seidel.
537
538         [Qt] Enable JIT build for SH4 platforms.
539         https://bugs.webkit.org/show_bug.cgi?id=58317
540
541
542         * DumpRenderTree/qt/DumpRenderTree.pro:
543         * QtTestBrowser/QtTestBrowser.pro:
544         * Scripts/webkitdirs.pm:
545
546 2011-04-12  Tony Chang  <tony@chromium.org>
547
548         Reviewed by Andreas Kling.
549
550         [Qt] embed checksums in PNGs written by Qt-DRT
551         https://bugs.webkit.org/show_bug.cgi?id=58173
552
553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
554         (WebCore::DumpRenderTree::dump):
555
556 2011-04-12  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by Adam Barth.
559
560         commit-queue should upload failure diffs when tests fail
561         https://bugs.webkit.org/show_bug.cgi?id=58348
562
563         This change was mostly just plumbing.  We were already saving
564         this information for flaky test reporting.  I just made it possible
565         for normal failures to report archives as well.
566
567         I did a little abstraction work to try and share some code between
568         flakytestreporter.py and this new code.  There is still more we could do.
569
570         In making this change I also went through and updated the various
571         places we have urls hard-coded in our python and pointed them at
572         common.config.urls.
573
574         * Scripts/webkitpy/common/checkout/scm.py:
575         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
576         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
577         * Scripts/webkitpy/common/net/statusserver.py:
578         * Scripts/webkitpy/layout_tests/port/base.py:
579         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
580         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
581         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
582         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
583         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
584         * Scripts/webkitpy/tool/commands/queues.py:
585
586 2011-04-12  Daniel Bates  <dbates@rim.com>
587
588         Rubber-stamped by Eric Seidel.
589
590         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
591         with Windows line endings
592         https://bugs.webkit.org/show_bug.cgi?id=53625
593
594         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
595         applied to an SCM checkout on a Windows file system and vice-versa.
596
597         This issue manifests itself due to custom SCM settings as well as differences in
598         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
599         into svn-apply/unapply to compensate for differences in line endings by converting
600         the line endings in a patch to match the line endings in the target file (if it exists).
601
602         * Scripts/VCSUtils.pm:
603           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
604             content read from the specified file handle. Obviously, this heuristic will not work
605             for files with mixed line endings, but I don't envision such files to be the norm. If
606             this turns out to be an issue then we can improve the heuristic.
607           - Added firstEOLInFile().
608           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
609             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
610             endings in the diff instead of the line endings in the target file.
611           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
612             re-used in parseDiff().
613         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
614           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
615           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
616         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
617         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
618
619 2011-04-12  Sam Weinig  <sam@webkit.org>
620
621         Reviewed by Adam Roben.
622
623         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
624         https://bugs.webkit.org/show_bug.cgi?id=58336
625
626         * WebKitTestRunner/TestController.cpp:
627         (WTR::TestController::resetStateToConsistentValues):
628         Remove cache clearing as that is causing tests to crash on Windows 7.
629
630 2011-04-11  Sam Weinig  <sam@webkit.org>
631
632         Reviewed by Anders Carlsson.
633
634         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
635         <rdar://problem/8981346>
636         https://bugs.webkit.org/show_bug.cgi?id=54159
637
638         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
639         (WTR::InjectedBundlePage::InjectedBundlePage):
640         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
641         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
642         (WTR::InjectedBundlePage::decidePolicyForResponse):
643         (WTR::InjectedBundlePage::unableToImplementPolicy):
644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
645         Add short-circuited policy client which matches WebKit1.
646
647         * WebKitTestRunner/TestController.cpp:
648         (WTR::TestController::resetStateToConsistentValues):
649         Clear the cache between tests to ensure consistent results.
650
651 2011-04-11  George Guo  <George.Guo@nokia.com>
652
653         Reviewed by Eric Seidel.
654
655         prepare-ChangeLog support email input but -h did not show the option
656         https://bugs.webkit.org/show_bug.cgi?id=58164
657
658         Add email option to -h to improve the usability
659
660         * Scripts/prepare-ChangeLog:
661
662 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
663
664         Reviewed by Eric Carlson.
665
666         Rename MediaControls to MediaControlRootElement.
667         https://bugs.webkit.org/show_bug.cgi?id=58250
668
669         * Scripts/do-webcore-rename: Documented the renaming.
670
671 2011-04-11  Sam Weinig  <sam@webkit.org>
672
673         Fix Windows build.
674
675         * MiniBrowser/win/BrowserView.cpp:
676         (BrowserView::create):
677
678 2011-04-11  Sam Weinig  <sam@webkit.org>
679
680         Reviewed by Anders Carlsson.
681
682         Move focus management out of WebKit via  the UIClient
683         <rdar://problem/8784068>
684         https://bugs.webkit.org/show_bug.cgi?id=58278
685
686         * MiniBrowser/mac/BrowserWindowController.m:
687         (-[BrowserWindowController awakeFromNib]):
688         * WebKitTestRunner/TestController.cpp:
689         (WTR::TestController::createOtherPage):
690         (WTR::TestController::initialize):
691         Add stubs for new UIClient functions.
692
693 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
694
695         Reviewed by Eric Seidel.
696
697         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
698         https://bugs.webkit.org/show_bug.cgi?id=53605
699
700         Add an implementation of the PlainTextController for the GTK+ DRT.
701
702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
703         (addControllerToWindow): Added this helper method.
704         (webViewWindowObjectCleared): Use the new helper to add EventSender
705         and the PlainTextController to the window object.
706         * GNUmakefile.am: Added PlainTextController source files.
707         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
708         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
709         until that functionality exists somewhere in the WebKitGTK+ stack.
710         * DumpRenderTree/gtk/PlainTextController.h: Added.
711
712 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
713
714         Unreviewed.
715
716         Adding my IRC nick.
717
718         * Scripts/webkitpy/common/config/committers.py:
719
720 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
721
722         Reviewed by Adam Roben.
723
724         new-run-webkit-tests: fix crash when running under windows cmd.exe
725         https://bugs.webkit.org/show_bug.cgi?id=58197
726
727         We would intermittently crash when running NRWT directly under
728         cmd.exe on windows because we were sharing the stdin file
729         descriptor between the python process and the http server.
730         cmd.exe really didn't like that, and there was no reason to
731         share the descriptor, so we now use a PIPE instead.
732
733         * Scripts/webkitpy/layout_tests/port/http_server.py:
734
735 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
736
737         Reviewed by Ojan Vafai.
738
739         new-run-webkit-tests: add unit tests for Port.diff_image()
740         https://bugs.webkit.org/show_bug.cgi?id=58196
741
742         Add the unit tests for the fix in bug 58195.
743
744         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
745         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
746         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
747
748 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
749
750         Reviewed by Tony Chang.
751
752         new-run-webkit-tests: implement support for audio, take two
753         https://bugs.webkit.org/show_bug.cgi?id=58195
754
755         Attempt to re-land the fix for bug 58101 (which was initially
756         landed in r83330, but rolled out). This is the same patch but
757         fixes crashes in Port.diff_image() caused by the change for
758         empty image files being None instead of ''.
759
760         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
761         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
762         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
763         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
764         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
765         * Scripts/webkitpy/layout_tests/port/base.py:
766         * Scripts/webkitpy/layout_tests/port/chromium.py:
767         * Scripts/webkitpy/layout_tests/port/dryrun.py:
768         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
769         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
770         * Scripts/webkitpy/layout_tests/port/test.py:
771         * Scripts/webkitpy/layout_tests/port/webkit.py:
772
773 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
774
775         Reviewed by Xan Lopez.
776
777         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
778         https://bugs.webkit.org/show_bug.cgi?id=57854
779
780         Implement missing features in GTK's DRT.
781
782         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
783         (indexRangeInTable): New helper function to get the range string
784         for the current cell inside the parent table, either from the
785         point of view of rows or columns.
786         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
787         the new helper function indexRangeInTable().
788         (AccessibilityUIElement::columnIndexRange): Ditto.
789
790 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
791
792         Reviewed by Chris Fleizach.
793
794         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
795         https://bugs.webkit.org/show_bug.cgi?id=57826
796
797         Implement missing feature in GTK's DRT.
798
799         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
800         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
801         relying on the analogous function from the AtkTable interface.
802
803 2011-04-05  Timothy Hatcher  <timothy@apple.com>
804
805         Fix the extract-localizable-strings script errors that started after
806         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
807
808         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
809
810 2011-04-11  Tony Chang  <tony@chromium.org>
811
812         Reviewed by Eric Seidel.
813
814         fix crc computation on 64 bit machines
815         https://bugs.webkit.org/show_bug.cgi?id=58243
816
817         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
818
819         * DumpRenderTree/CyclicRedundancyCheck.cpp:
820         (makeCrcTable):
821         (computeCrc):
822         * DumpRenderTree/CyclicRedundancyCheck.h:
823         * DumpRenderTree/PixelDumpSupport.cpp:
824         (appendIntToVector):
825         (convertChecksumToPNGComment):
826
827 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
828
829         Reviewed by Eric Seidel.
830
831         Require no undefined symbols during compilation.
832
833         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
834         https://bugs.webkit.org/show_bug.cgi?id=54896
835
836         Add -Wl,--no-undefined to catch missing symbols early.
837
838         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
839         * WebKitTestRunner/qt/WebKitTestRunner.pro:
840
841 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
842
843         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
844
845         * wx/build/settings.py:
846
847 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
848
849         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
850
851         * wx/build/settings.py:
852
853 2011-04-10  David Levin  <levin@chromium.org>
854
855         Reviewed by Dimitri Glazkov.
856
857         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
858         https://bugs.webkit.org/show_bug.cgi?id=58201
859
860         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
861         and filed bug 58202.
862
863 2011-04-09  David Levin  <levin@chromium.org>
864
865         Unreviewed, rolling out r83394.
866         http://trac.webkit.org/changeset/83394
867         https://bugs.webkit.org/show_bug.cgi?id=53625
868
869         Patch was incorrect as noted in the bug.
870
871         * Scripts/svn-apply:
872
873 2011-04-09  David Levin  <levin@chromium.org>
874
875         Reviewed by Adam Barth.
876
877         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
878         https://bugs.webkit.org/show_bug.cgi?id=53625
879
880         * Scripts/svn-apply: Ensure that the portions of patches
881         which are for vcproj/vsprops files has DOS line endings.
882
883 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
884
885         Reviewed by Tony Chang.
886
887         It looks like NRWT has not been stopping DRT/TestShell
888         instances properly on windows, probably for a long time.
889         This would go a long way to explaining why we often have
890         processes lying around :)
891
892         https://bugs.webkit.org/show_bug.cgi?id=57807
893
894         * Scripts/webkitpy/layout_tests/port/chromium.py:
895         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
896
897 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
898
899         Reviewed by Laszlo Gombos.
900
901         [Qt] Don't link against fontconfig or X11 if embedded
902         https://bugs.webkit.org/show_bug.cgi?id=58104
903
904         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
905         * QtTestBrowser/QtTestBrowser.pro: ditto
906         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
907         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
908
909 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
910
911         http/tests/loading/preload-append-scan.php is failing on Windows
912         https://bugs.webkit.org/show_bug.cgi?id=58178
913
914         Reviewed by Brian Weinstein.
915
916         * DumpRenderTree/win/DumpRenderTree.cpp:
917         (lastPathComponent):
918         Use CFURL API to find the last path component, rather than
919         PathFindFileName(), because the latter will include the query string.
920
921 2011-04-08  Jian Li  <jianli@chromium.org>
922
923         Unreviewed, rolling out r83327, r83330 since these patches are very
924         likely to break chromium webkit mac10.6 builders.
925
926         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
927         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
928         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
929         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
930         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
931         * Scripts/webkitpy/layout_tests/port/base.py:
932         * Scripts/webkitpy/layout_tests/port/chromium.py:
933         * Scripts/webkitpy/layout_tests/port/dryrun.py:
934         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
935         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
936         * Scripts/webkitpy/layout_tests/port/test.py:
937         * Scripts/webkitpy/layout_tests/port/webkit.py:
938
939 2011-04-08  Vincent Scheib  <scheib@chromium.org>
940
941         Reviewed by Eric Seidel.
942
943         add chromium-gpu-linux-x86_64 to the recognized list of ports
944         https://bugs.webkit.org/show_bug.cgi?id=58099
945
946         Add chromium-gpu-linux-x86_64 to fix assert.
947
948         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
949
950 2011-04-08  Alpha Lam  <hclam@chromium.org>
951
952         Unreviewed, rolling out r83335.
953         http://trac.webkit.org/changeset/83335
954         https://bugs.webkit.org/show_bug.cgi?id=53556
955
956         GTK and QT bots are broken
957
958         * Scripts/build-webkit:
959
960 2011-04-07  Anna Cavender  <annacc@chromium.org>
961
962         Reviewed by Eric Carlson.
963
964         Setup ENABLE(TRACK) feature define
965         https://bugs.webkit.org/show_bug.cgi?id=53556
966
967         * Scripts/build-webkit:
968
969 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
970
971         Reviewed by Adam Roben.
972
973         new-run-webkit-tests: configure a NRWT test bot for Mac SL
974         https://bugs.webkit.org/show_bug.cgi?id=58114
975
976         This change removes the old new-run-webkit-tests entry and
977         updates it for a new test-only bot.
978
979         * BuildSlaveSupport/build.webkit.org-config/config.json:
980
981 2011-04-08  Dominic Cooney  <dominicc@google.com>
982
983         Reviewed by Adam Roben.
984
985         Make layoutTestController.shadowRoot return null, not undefined,
986         when its argument is invalid.
987         https://bugs.webkit.org/show_bug.cgi?id=58121
988
989         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
990         (LayoutTestController::shadowRoot):
991         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
992         (WTR::LayoutTestController::shadowRoot):
993
994 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
995
996         Reviewed by Adam Roben.
997
998         Locate NSTD.EXE in 64-bit Windows
999         https://bugs.webkit.org/show_bug.cgi?id=57847
1000
1001         * Scripts/old-run-webkit-tests:
1002
1003 2011-04-08  Adam Roben  <aroben@apple.com>
1004
1005         Qt build fix
1006
1007         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1008
1009 2011-04-07  Adam Roben  <aroben@apple.com>
1010
1011         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1012
1013         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1014         plugin
1015
1016         Reviewed by Anders Carlsson.
1017
1018         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1019         (pluginLogWithArguments): Moved code to format and log the message here...
1020         (pluginLog): ...from here.
1021
1022         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1023
1024         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1025         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1026
1027         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1028
1029         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1030         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1031         to begin.
1032         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1033         constructor.
1034         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1035         can be used to invoke our setWillBeDestroyed function.
1036         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1037         anything unexpected happens).
1038         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1039         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1040         NPP_SetWindow was *not* called during destruction.
1041         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1042         method, setWillBeDestroyed.
1043         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1044         object.
1045
1046         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1047         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1048         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1049         * GNUmakefile.am:
1050         Added new test.
1051
1052         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
1053         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
1054
1055 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1056
1057         Reviewed by Martin Robinson.
1058
1059         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1060         https://bugs.webkit.org/show_bug.cgi?id=58039
1061
1062         Implement missing functions in GTK's DRT.
1063
1064         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1065         (AccessibilityUIElement::increment): Implemented.
1066         (AccessibilityUIElement::decrement): Implemented.
1067
1068 2011-04-08  Dominic Cooney  <dominicc@google.com>
1069
1070         Reviewed by Kent Tamura.
1071
1072         Make WK2 layoutTestController.shadowRoot return undefined, not
1073         null, when its argument is not an element.
1074         https://bugs.webkit.org/show_bug.cgi?id=58121
1075
1076         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1077         (WTR::LayoutTestController::shadowRoot):
1078
1079 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
1080
1081         Reviewed by Mihai Parparita.
1082
1083         Change reference port for Mac GPU baselines from
1084         Leopard to SnowLeopard, XP to Win7, and Linux-x86
1085         to Linux x86-64.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=58099
1088
1089         * Scripts/webkitpy/layout_tests/port/chromium.py:
1090
1091 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1092
1093         Revert ENABLE_TRACK patch due to compile failures.
1094
1095         * Scripts/build-webkit:
1096
1097 2011-04-07  Tony Chang  <tony@chromium.org>
1098
1099         Reviewed by Eric Seidel.
1100
1101         update DRT to embed checksums in png files
1102         https://bugs.webkit.org/show_bug.cgi?id=57871
1103
1104         We insert the bytes for the comment in printPNG rather than at encode
1105         time because each platform does its own PNG encoding (either using CG
1106         or cairo).  Putting this in pringPNG avoids having to duplicate this
1107         code, although it's not as clean as doing it at encoding time.
1108
1109         We insert the comment right after the IHDR chunk of the PNG.
1110
1111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1112         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
1113         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1114         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1115         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
1116         * DumpRenderTree/PixelDumpSupport.cpp:
1117         (dumpWebViewAsPixelsAndCompareWithExpected):
1118         (convertChecksumToPNGComment): Generate the bytes to insert.
1119         (printPNG): Insert the png comment before the first IDAT section.
1120         * DumpRenderTree/PixelDumpSupport.h:
1121         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1122         (printPNG):
1123         (dumpBitmap):
1124         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1125         (printPNG):
1126         (dumpBitmap):
1127         * DumpRenderTree/win/DumpRenderTree.vcproj:
1128         * GNUmakefile.am:
1129
1130 2011-04-07  Jeff Miller  <jeffm@apple.com>
1131
1132         Reviewed by Adam Roben.
1133
1134         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
1135         https://bugs.webkit.org/show_bug.cgi?id=58058
1136
1137         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1138         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
1139
1140 2011-04-07  Chang Shu  <cshu@webkit.org>
1141
1142         Reviewed by Darin Adler.
1143
1144         WebKitTestRunner needs layoutTestController.isPageBoxVisible
1145         https://bugs.webkit.org/show_bug.cgi?id=42695
1146
1147         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1148         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1149         (WTR::LayoutTestController::isPageBoxVisible):
1150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1151
1152 2011-04-07  Adam Roben  <aroben@apple.com>
1153
1154         Build fix
1155
1156         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
1157
1158 2011-04-07  Adam Roben  <aroben@apple.com>
1159
1160         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
1161
1162         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
1163         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
1164         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
1165         be overridden by subclasses to provide extra URLs before we call up to the base class (after
1166         which adding more URLs is no longer possible).
1167
1168         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
1169         bot results page
1170
1171         Reviewed by John Sullivan.
1172
1173         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1174         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
1175         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
1176         method is never called for MasterShellCommands.
1177         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
1178         with this method (which is).
1179
1180 2011-04-07  Adam Roben  <aroben@apple.com>
1181
1182         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
1183
1184         This matches how most of our other build steps work, so is good just for improving
1185         consistency between build steps. It should also make it possible for
1186         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
1187         trying to do this in finished() after we had called up to the base class, but that was
1188         apparently too late to add more URLs.)
1189
1190         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
1191         results page
1192
1193         Reviewed by John Sullivan.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1196         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
1197         call setText to get the right text to show up for this step. This matches how most of our
1198         other build steps work.
1199         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
1200         This is how most of our other build steps work.
1201         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
1202         function, to match the base class.
1203
1204 2011-04-07  Adam Barth  <abarth@webkit.org>
1205
1206         Reviewed by Maciej Stachowiak.
1207
1208         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
1209         https://bugs.webkit.org/show_bug.cgi?id=58022
1210
1211         Previously, we were ignoring the args variable!  This patch fixes the
1212         regression introduced in http://trac.webkit.org/changeset/82771.
1213
1214         * Scripts/webkitpy/tool/commands/download_unittest.py:
1215         * Scripts/webkitpy/tool/mocktool.py:
1216         * Scripts/webkitpy/tool/steps/checkstyle.py:
1217
1218 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
1219
1220         Reviewed by Adam Barth.
1221
1222         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
1223         https://bugs.webkit.org/show_bug.cgi?id=58017
1224
1225         * Scripts/webkitpy/common/checkout/scm.py:
1226         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1227
1228 2011-04-06  Chang Shu  <cshu@webkit.org>
1229
1230         Reviewed by Darin Adler.
1231
1232         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
1233         https://bugs.webkit.org/show_bug.cgi?id=57984
1234
1235         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1236         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1237         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
1238         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1239
1240 2011-04-06  Chris Rogers  <crogers@google.com>
1241
1242         Reviewed by Tony Chang.
1243
1244         Add web audio support to DumpRenderTree (mac port)
1245         https://bugs.webkit.org/show_bug.cgi?id=57969
1246
1247         * DumpRenderTree/LayoutTestController.cpp:
1248         (LayoutTestController::LayoutTestController):
1249         (setEncodedAudioDataCallback):
1250         (LayoutTestController::staticFunctions):
1251         * DumpRenderTree/LayoutTestController.h:
1252         (LayoutTestController::dumpAsAudio):
1253         (LayoutTestController::setDumpAsAudio):
1254         (LayoutTestController::encodedAudioData):
1255         (LayoutTestController::setEncodedAudioData):
1256         * DumpRenderTree/mac/DumpRenderTree.mm:
1257         (dumpAudio):
1258         (dump):
1259
1260 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
1261
1262         Reviewed by Kenneth Rohde Christiansen.
1263
1264         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1265         https://bugs.webkit.org/show_bug.cgi?id=56086
1266
1267         Add the missing method.
1268
1269         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1270         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
1271         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1272         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1273         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1274
1275 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1276
1277         Reviewed by David Levin.
1278
1279         Add QUOTA build flag for unified quota API
1280         https://bugs.webkit.org/show_bug.cgi?id=57918
1281
1282         * Scripts/build-webkit: Added QUOTA build flag
1283
1284 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
1285
1286         Reviewed by Tony Chang.
1287
1288         Adjust the apple webkit port's default timeout to match
1289         old-run-webkit-tests at 35 seconds.
1290
1291         https://bugs.webkit.org/show_bug.cgi?id=37738
1292
1293         * Scripts/webkitpy/layout_tests/port/mac.py:
1294
1295 2011-04-06  Scott Cameron  <sccameron@rim.com>
1296
1297         Reviewed by Eric Seidel.
1298
1299         Remove global variable $httpdPath and replace with the return value of
1300         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
1301         https://bugs.webkit.org/show_bug.cgi?id=53499
1302
1303         * Scripts/run-iexploder-tests:
1304         * Scripts/webkitperl/httpd.pm:
1305
1306 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
1307
1308         Reviewed by Darin Adler.
1309
1310         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
1311         
1312         https://bugs.webkit.org/show_bug.cgi?id=27551
1313         
1314         * DumpRenderTree/config.h:
1315         * WebKitAPITest/config.h:
1316         * WebKitTestRunner/config.h:
1317
1318 2011-04-06  Tony Chang  <tony@chromium.org>
1319
1320         Reviewed by Darin Adler.
1321
1322         teach run-webkit-tests to read checksums from png files
1323         https://bugs.webkit.org/show_bug.cgi?id=57993
1324
1325         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
1326           no .checksum and look for the checksum in there.
1327
1328 2011-04-06  David Dorwin  <ddorwin@chromium.org>
1329
1330         Reviewed by David Levin.
1331
1332         Enable fullscreen layout tests for Chromium
1333         https://bugs.webkit.org/show_bug.cgi?id=55726
1334
1335         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1336
1337         * DumpRenderTree/chromium/WebPreferences.cpp:
1338         (WebPreferences::applyTo):
1339
1340 2011-04-06  Adam Roben  <aroben@apple.com>
1341
1342         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1343
1344         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1345
1346         Reviewed by David Kilzer.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1349         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1350         build's results directory here...
1351         (ExtractTestResults.finished): ...from here.
1352         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1353         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1354         leaks" link to point to Leaks Viewer for this build.
1355         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1356         but it seemed good to add for consistency with BuildAndTestFactory.
1357         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1358         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1359         that we'll get a "view leaks" link.
1360
1361 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1362
1363         Reviewed by Eric Seidel.
1364
1365         [Gtk] plugins/set-status.html fails
1366         https://bugs.webkit.org/show_bug.cgi?id=57844
1367
1368         Allow an empty status text to be dumped.
1369
1370         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1371         (webViewStatusBarTextChanged):
1372
1373 2011-04-06  Chang Shu  <cshu@webkit.org>
1374
1375         Reviewed by Darin Adler.
1376
1377         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1378         https://bugs.webkit.org/show_bug.cgi?id=42329
1379
1380         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1381         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1382         (WTR::LayoutTestController::pageNumberForElementById):
1383         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1384
1385 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1386
1387         Reviewed by Martin Robinson.
1388
1389         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1390         https://bugs.webkit.org/show_bug.cgi?id=57932
1391
1392         Some Layout tests have invalid URIs that do not generate valid
1393         SoupURI instances. Do not try to free those NULL SoupURIs.
1394
1395         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1396         (willSendRequestCallback):
1397
1398 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1399
1400         Reviewed by Andreas Kling.
1401
1402         ORWT shouldn't generate diff files for tests without expected files
1403         https://bugs.webkit.org/show_bug.cgi?id=57846
1404
1405         * Scripts/old-run-webkit-tests:
1406
1407 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1408
1409         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1410         to deps.
1411
1412         * wx/install-unix-extras:
1413
1414 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1415
1416         Unreviewed, rolling out r82978, r82999, and r83001.
1417         http://trac.webkit.org/changeset/82978
1418         http://trac.webkit.org/changeset/82999
1419         http://trac.webkit.org/changeset/83001
1420         https://bugs.webkit.org/show_bug.cgi?id=57913
1421
1422         Does not work in Python 2.5 (Requested by abarth on #webkit).
1423
1424         * Scripts/webkitpy/common/system/executive.py:
1425         * Scripts/webkitpy/common/system/executive_unittest.py:
1426
1427 2011-04-05  Chang Shu  <cshu@webkit.org>
1428
1429         Reviewed by Darin Adler.
1430
1431         WebKitTestRunner needs layoutTestController.numberOfPages
1432         https://bugs.webkit.org/show_bug.cgi?id=42694
1433
1434         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1435         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1436         (WTR::LayoutTestController::numberOfPages):
1437         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1438
1439 2011-04-05  Tony Chang  <tony@chromium.org>
1440
1441         Reviewed by Mihai Parparita.
1442
1443         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1444         https://bugs.webkit.org/show_bug.cgi?id=57889
1445
1446         * Scripts/webkitpy/layout_tests/port/chromium.py:
1447         * Scripts/webkitpy/layout_tests/port/test.py:
1448         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1449
1450 2011-04-05  Adam Barth  <abarth@webkit.org>
1451
1452         Silly with statement, from the future!
1453
1454         * Scripts/webkitpy/common/system/executive.py:
1455
1456 2011-04-05  Adam Barth  <abarth@webkit.org>
1457
1458         Reviewed by Tony Chang.
1459
1460         Don't use Exception.message because it's deprecated
1461         https://bugs.webkit.org/show_bug.cgi?id=57892
1462
1463         Suppress the warning for now.  When we move to Python 3, we might need
1464         to something more dramatic.
1465
1466         * Scripts/webkitpy/common/system/executive.py:
1467
1468 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1469
1470         Reviewed by Ojan Vafai.
1471
1472         Add builders.js to dashboard file list
1473         https://bugs.webkit.org/show_bug.cgi?id=57899
1474
1475         Add file added by http://crrev.com/80538 to dashboard file list.
1476
1477         * TestResultServer/handlers/dashboardhandler.py:
1478
1479 2011-04-05  MORITA Hajime  <morrita@google.com>
1480
1481         Reviewed by Adam Barth.
1482
1483         webkit-patch should print git's stderr when git svn dcommit fail
1484         http://webkit.org/b/57861
1485
1486         * Scripts/webkitpy/common/checkout/scm.py:
1487
1488 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1489
1490         Reviewed by Tony Chang.
1491
1492         Add --baseline-search-path to NRWT
1493         https://bugs.webkit.org/show_bug.cgi?id=56233
1494         
1495         Add NRWT option to specify additional directories to look for baselines
1496         (will be used by hardware GPU bots which will have local per-bot
1497         expectations for some tests)
1498
1499         * Scripts/webkitpy/common/system/filesystem_mock.py:
1500         * Scripts/webkitpy/layout_tests/port/base.py:
1501         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1503
1504 2011-04-05  Adam Roben  <aroben@apple.com>
1505
1506         Strip off /results.html from results URLs before trying to load leaks files from them
1507
1508         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1509         files, rather than pointing to the directory that contains them. This is more convenient for
1510         people browsing build.webkit.org, but confused Leaks Viewer.
1511
1512         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1513         list don't work
1514
1515         Reviewed by Joseph Pecoraro.
1516
1517         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1518         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1519
1520 2011-04-05  Carol Szabo  <carol@webkit.org>
1521
1522         Unreviewed.
1523
1524         Updated my info in committers.py
1525
1526         Scripts\webkitpy\common\config\committers.py 
1527
1528 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1529
1530         Reviewed by Laszlo Gombos.
1531
1532         [Qt] Make WebKitLibraries optional for building QtWebKit
1533         https://bugs.webkit.org/show_bug.cgi?id=57542
1534
1535         * Scripts/build-webkit:
1536
1537 2011-04-05  Chang Shu  <cshu@webkit.org>
1538
1539         Reviewed by Laszlo Gombos.
1540
1541         [Qt] MiniBrowser defaultUrl does not work
1542         https://bugs.webkit.org/show_bug.cgi?id=57021
1543
1544         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1545         * MiniBrowser/qt/main.cpp:
1546         (main):
1547
1548 2011-04-05  Jade Han  <jade.han@nokia.com>
1549
1550         Reviewed by Laszlo Gombos.
1551
1552         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1553         https://bugs.webkit.org/show_bug.cgi?id=54977
1554
1555         This change is a preparation to enable building webkit2 for Symbian.
1556         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1557
1558         * Tools.pro:
1559
1560 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1561
1562         Reviewed by Andreas Kling.
1563
1564         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1565         https://bugs.webkit.org/show_bug.cgi?id=57832
1566
1567         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1568
1569         * MiniBrowser/qt/UrlLoader.cpp:
1570         (UrlLoader::UrlLoader):
1571
1572 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1573
1574         [Qt] Linux Release minimal build fix after r82919.
1575
1576         * MiniBrowser/qt/BrowserWindow.cpp:
1577         (BrowserWindow::loadURLListFromFile):
1578         * QtTestBrowser/launcherwindow.cpp:
1579         (LauncherWindow::loadURLListFromFile):
1580
1581 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1582
1583         Reviewed by Andreas Kling.
1584
1585         [Qt] Make URL loader accessible from testbrowser's menus
1586         https://bugs.webkit.org/show_bug.cgi?id=57823
1587
1588         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1589
1590         * MiniBrowser/qt/BrowserWindow.cpp:
1591         (BrowserWindow::BrowserWindow):
1592         (BrowserWindow::loadURLListFromFile):
1593         (BrowserWindow::~BrowserWindow):
1594         * MiniBrowser/qt/BrowserWindow.h:
1595         * QtTestBrowser/launcherwindow.cpp:
1596         (LauncherWindow::LauncherWindow):
1597         (LauncherWindow::~LauncherWindow):
1598         (LauncherWindow::createChrome):
1599         (LauncherWindow::loadURLListFromFile):
1600         * QtTestBrowser/launcherwindow.h:
1601
1602 2011-04-04  Sam Weinig  <sam@webkit.org>
1603
1604         Reviewed by Brian Weinstein.
1605
1606         Remove duplicate API from WKContext
1607         <rdar://problem/8727879>
1608         https://bugs.webkit.org/show_bug.cgi?id=57815
1609
1610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1611         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1612         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1613         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1614
1615 2011-04-04  Tony Chang  <tony@chromium.org>
1616
1617         Reviewed by Ojan Vafai.
1618
1619         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1620         https://bugs.webkit.org/show_bug.cgi?id=57783
1621
1622         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1623         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1624
1625 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1626
1627         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1628         from WebKitBuild.
1629
1630         * Scripts/webkitdirs.pm:
1631
1632 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1633
1634         Reviewed by Gustavo Noronha Silva.
1635
1636         [GTK] WebGL support
1637         https://bugs.webkit.org/show_bug.cgi?id=31517
1638
1639         Add support to the DRT for turning on WebGL when a layout tests requests it.
1640
1641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1642         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1643
1644 2011-04-04  Chang Shu  <cshu@webkit.org>
1645
1646         Reviewed by Darin Adler.
1647
1648         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1649         https://bugs.webkit.org/show_bug.cgi?id=57572
1650
1651         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1652         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1653         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1654         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1655
1656 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1657
1658         Reviewed by Csaba Osztrogonác.
1659
1660         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1661         https://bugs.webkit.org/show_bug.cgi?id=57602
1662
1663         * DumpRenderTree/qt/main.cpp:
1664         (get_backtrace):
1665
1666 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1667
1668         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1669
1670         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1671         (LayoutTestController::shadowRoot):
1672
1673 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1674
1675         Unreviewed, fix exception in rebaseline tool.
1676
1677         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1678
1679 2011-04-02  Beth Dakin  <bdakin@apple.com>
1680
1681         Rubber-stamped by Geoff Garen.
1682
1683         For Dan!
1684         * DumpRenderTree/mac/DumpRenderTree.mm:
1685         (resetWebViewToConsistentStateBeforeTesting):
1686
1687 2011-04-02  Beth Dakin  <bdakin@apple.com>
1688
1689         Rubber-stamped by Geoff Garen.
1690
1691         Need to reset the scale, much like zoom.
1692         * DumpRenderTree/mac/DumpRenderTree.mm:
1693         (resetWebViewToConsistentStateBeforeTesting):
1694
1695 2011-04-02  Sam Weinig  <sam@webkit.org>
1696
1697         Reviewed by Beth Dakin.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=57605
1700         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1701         getClientRects()
1702         -and corresponding-
1703         <rdar://problem/9194541>
1704
1705         Add DRT support for the scaleWebView SPI.
1706         * DumpRenderTree/mac/EventSendingController.mm:
1707         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1708         (+[EventSendingController webScriptNameForSelector:]):
1709         (-[EventSendingController scalePageBy:atX:andY:]):
1710         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1711         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1712         (WTR::EventSendingController::scalePageBy):
1713         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1714         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1715         (WTR::InjectedBundlePage::reset):
1716
1717 2011-04-02  Dominic Cooney  <dominicc@google.com>
1718
1719         Reviewed by Martin Robinson.
1720
1721         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1722         https://bugs.webkit.org/show_bug.cgi?id=57551
1723
1724         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1725         (LayoutTestController::shadowRoot):
1726
1727 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1728
1729         Reviewed by Eric Seidel.
1730
1731         Remove AbstractStep._run_script and move script names to ports.py
1732         https://bugs.webkit.org/show_bug.cgi?id=57704
1733
1734         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1735
1736         * Scripts/webkitpy/common/config/ports.py:
1737         * Scripts/webkitpy/tool/commands/download_unittest.py:
1738         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1739         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1740         * Scripts/webkitpy/tool/steps/abstractstep.py:
1741         * Scripts/webkitpy/tool/steps/checkstyle.py:
1742         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1743         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1744         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1745
1746 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1747
1748         Reviewed by Eric Seidel.
1749
1750         Emulate shebang on Win32
1751         https://bugs.webkit.org/show_bug.cgi?id=55927
1752
1753         Scripts on Windows work only if they are called with the explicit interpreter.
1754         Read the first line of scripts to detect the correct executable.
1755
1756         * Scripts/webkitpy/common/config/ports.py:
1757         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1758         * Scripts/webkitpy/common/system/executive_unittest.py:
1759
1760 2011-04-01  Adam Barth  <abarth@webkit.org>
1761
1762         Reviewed by Eric Seidel.
1763
1764         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1765         https://bugs.webkit.org/show_bug.cgi?id=57692
1766
1767         Previously, we were using BeautifulSoup to process XML from
1768         bugs.webkit.org, but that's incorrect.  We should be using
1769         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1770         entity wrong because &apos; is an XML entity but not an HTML entity.
1771
1772         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1773         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1774
1775 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1776
1777         Unreviewed, rolling out r82721.
1778         http://trac.webkit.org/changeset/82721
1779         https://bugs.webkit.org/show_bug.cgi?id=57687
1780
1781         This patch introduced assertion failures on the GTK+ bots.
1782         (Requested by mrobinson on #webkit).
1783
1784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1785         (LayoutTestController::shadowRoot):
1786
1787 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1788
1789         Unreviewed buildfix.
1790
1791         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1792         https://bugs.webkit.org/show_bug.cgi?id=55074
1793
1794         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1795         (The isWK2() function removes it from @ARGV, but not from @options.)
1796
1797 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1798
1799         Reviewed by Csaba Osztrogonác.
1800
1801         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1802         https://bugs.webkit.org/show_bug.cgi?id=57666
1803
1804         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1805
1806 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1807
1808         Reviewed by Adam Barth.
1809
1810         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1811
1812         We apparently never implemented the code to skip tests based on
1813         what was compiled into DRT. Also, change the logic used to skip
1814         platform directories to match what old-run-webkit-tests does: 
1815         skip every test not in a directory in the baseline search path.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=57662
1818
1819         * Scripts/webkitpy/layout_tests/port/mac.py:
1820         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1821         * Scripts/webkitpy/layout_tests/port/webkit.py:
1822
1823 2011-03-29  Mark Rowe  <mrowe@apple.com>
1824
1825         Reviewed by Jon Honeycutt.
1826
1827         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1828
1829         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1830
1831         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1832         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1833         * Scripts/webkitpy/layout_tests/port/mac.py:
1834         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1835
1836 2011-04-01  Chang Shu  <cshu@webkit.org>
1837
1838         Reviewed by Csaba Osztrogonác.
1839
1840         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1841         https://bugs.webkit.org/show_bug.cgi?id=55074
1842
1843         * Scripts/build-webkit:
1844
1845 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1846
1847         Reviewed by Tony Chang.
1848
1849         new-run-webkit-tests: remove spurious port version override in webkit.py
1850         base.py provides a default implementation so this is just
1851         breaking things.
1852
1853         https://bugs.webkit.org/show_bug.cgi?id=57667
1854
1855         * Scripts/webkitpy/layout_tests/port/webkit.py:
1856         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1857
1858 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1859
1860         Reviewed by Adam Roben.
1861
1862         Make view results on waterfall direct link to results.html
1863         https://bugs.webkit.org/show_bug.cgi?id=57671
1864
1865         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1866         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1867
1868 2011-04-01  Sam Weinig  <sam@webkit.org>
1869
1870         Fix windows build.
1871
1872         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1873         (TestWebKitAPI::TEST):
1874         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1875         (TestWebKitAPI::flushMessages):
1876
1877 2011-04-01  Sam Weinig  <sam@webkit.org>
1878
1879         Reviewed by Adam Roben.
1880
1881         Add adoptWK to WKRetainPtr.h
1882         https://bugs.webkit.org/show_bug.cgi?id=57670
1883
1884         * TestWebKitAPI/PlatformUtilities.h:
1885         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1886         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1887         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1888         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1889         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1890         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1891         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1892         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1893         (TestWebKitAPI::createSessionStateContainingFormData):
1894         * WebKitTestRunner/StringFunctions.h:
1895         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1896
1897 2011-04-01  Sam Weinig  <sam@webkit.org>
1898
1899         Reviewed by Adam Roben.
1900
1901         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1902
1903         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1904         (WTR::LayoutTestController::shadowRoot):
1905         Make judicious use of adoptWK().
1906
1907 2011-04-01  Sam Weinig  <sam@webkit.org>
1908
1909         Reviewed by Timothy Hatcher.
1910
1911         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1912
1913         * Scripts/extract-localizable-strings:
1914
1915 2011-04-01  Anders Carlsson  <andersca@apple.com>
1916
1917         Reviewed by Sam Weinig.
1918
1919         Shockwave plug-in doesn't accept mouse events
1920         https://bugs.webkit.org/show_bug.cgi?id=57653
1921         <rdar://problem/8483273>
1922
1923         Add a plug-in test.
1924
1925         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1926         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1927         (PluginTest::indicateTestFailure):
1928         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1929
1930         (PluginTest::NPN_ConvertPoint):
1931         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1932         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1933         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1934         Call indicateTestFailure.
1935
1936         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1937         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1938         (ConvertPoint::ConvertPoint):
1939         (ConvertPoint::testConvert):
1940         (ConvertPoint::NPP_New):
1941
1942 2011-04-01  Dominic Cooney  <dominicc@google.com>
1943
1944         Reviewed by Martin Robinson.
1945
1946         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1947         https://bugs.webkit.org/show_bug.cgi?id=57551
1948
1949         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1950         (LayoutTestController::shadowRoot):
1951
1952 2011-04-01  Sam Weinig  <sam@webkit.org>
1953
1954         Reviewed by Anders Carlsson.
1955
1956         WebKitTestRunner needs layoutTestController.shadowRoot
1957         https://bugs.webkit.org/show_bug.cgi?id=57661
1958
1959         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1960         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1961         (WTR::LayoutTestController::shadowRoot):
1962         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1963         Implement layoutTestController.shadowRoot for WebKit2.
1964
1965 2011-04-01  Chang Shu  <cshu@webkit.org>
1966
1967         Reviewed by Darin Adler.
1968
1969         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1970         https://bugs.webkit.org/show_bug.cgi?id=57568
1971
1972         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1973         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1974         (WTR::LayoutTestController::setDatabaseQuota):
1975         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1976
1977 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1978
1979         Reviewed by Tony Chang.
1980
1981         This patch completes the cleanup of
1982         rebaseline-chromium-webkit-tests to work with all of the
1983         variants of a platform (we can now rebaseline gpu- and non-gpu
1984         files at the same time).
1985
1986         When the rebaselining is complete, any lines declared as
1987         REBASELINE in the expectations file that matches a test that was
1988         actually rebaselined will be deleted, even if only one of the
1989         variants was actually rebaselined. This may cause odd problems,
1990         but is better than where we're at today.
1991
1992         This change removes the -g flag and deprecates -w. The -g flag is gone
1993         because GPU baselines are handled just like any other variant.
1994         The -w flag is deprecated because this tool now only works
1995         against the canaries, since that's the only place we have a full
1996         set of bots. It will be trivial to change this to
1997         build.webkit.org if we decide that's where we want them to be.
1998
1999         Also, this patch deletes a lot of cruft that is no longer needed
2000         in the test_expectations code and the port-specific code.
2001
2002         https://bugs.webkit.org/show_bug.cgi?id=55191
2003
2004         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2005         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2006         * Scripts/webkitpy/layout_tests/port/base.py:
2007         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2008         * Scripts/webkitpy/layout_tests/port/chromium.py:
2009         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2010         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2011         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2012         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2013         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2014         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2015         * Scripts/webkitpy/layout_tests/port/mac.py:
2016         * Scripts/webkitpy/layout_tests/port/test.py:
2017         * Scripts/webkitpy/layout_tests/port/webkit.py:
2018         * Scripts/webkitpy/layout_tests/port/win.py:
2019         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2020         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2021
2022 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2023
2024         Reviewed by Adam Barth.
2025
2026         rebaseline-chromium-webkit-tests does not work correctly with
2027         version-specific baselines. This patch updates the tool to use
2028         all of the version-specific bots on the canaries, and will now
2029         attempt to rebaseline all of the versions by default, although
2030         it will not update both GPU and CPU versions.
2031         
2032         Also, it will no longer modify the test_expectations.txt file
2033         *at all*. You will have to manually delete the REBASELINE lines
2034         after running the tool and determining that it did what you
2035         wanted it to do. This should be fixed in a separate bug - see
2036         webkit bug #55191.
2037
2038         https://bugs.webkit.org/show_bug.cgi?id=55608
2039
2040         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2041         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2042         * Scripts/webkitpy/layout_tests/port/chromium.py:
2043         * Scripts/webkitpy/layout_tests/port/test.py:
2044         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2045         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2046
2047 2011-03-31  Tony Chang  <tony@chromium.org>
2048
2049         Reviewed by Ojan Vafai.
2050
2051         [chromium] update the rebaseline tool to know about pngs with checksums
2052         https://bugs.webkit.org/show_bug.cgi?id=57481
2053
2054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
2055         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2056
2057 2011-04-01  Adam Roben  <aroben@apple.com>
2058
2059         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
2060
2061         Previously, we were getting the revision of the first revision that triggered a build.
2062         Choosing the last revision would have been more accurate. But got_revision is what is used
2063         everywhere else on build.webkit.org, and should work even when there were no changes that
2064         triggered a build (e.g., if someone clicked the Force Build button).
2065
2066         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
2067         recent builds list
2068
2069         Reviewed by Anders Carlsson.
2070
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2072         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
2073         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
2074
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2076         (Array.prototype.first): Added this helper function to return the first element in an array
2077         that matches the given predicate, or null if no such element exists.
2078
2079 2011-03-31  Adam Roben  <aroben@apple.com>
2080
2081         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
2082
2083         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
2084
2085         Reviewed by Darin Adler.
2086
2087         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2088         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
2089         URL on its own line.
2090
2091         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2092         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
2093         progression, and added a new test that uses a short bug URL while I was at it.
2094
2095 2011-04-01  Adam Roben  <aroben@apple.com>
2096
2097         Mark .vcproj/.vsprops/.sln files as being Windows-only
2098
2099         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
2100
2101         Reviewed by Anders Carlsson.
2102
2103         * Scripts/webkitpy/common/config/build.py:
2104         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
2105         directories as Windows-only.
2106
2107         * Scripts/webkitpy/common/config/build_unittest.py:
2108         (ShoulBuildTest): Added test cases for the above.
2109
2110 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2111
2112         Reviewed by Laszlo Gombos.
2113
2114         [Qt] Build MiniBrowser for Symbian
2115         https://bugs.webkit.org/show_bug.cgi?id=56319
2116
2117         Have MiniBrowser reference it's own copy of useragentlist.txt instead
2118         of copying QtTestBrowser's.
2119         Remove Tools/MiniBrowser/DerivedSources.pro
2120         This reduces complexity in the Tools scripts due to Symbian limitations.
2121
2122         * DerivedSources.pro:
2123         * MiniBrowser/DerivedSources.pro: Removed.
2124         * MiniBrowser/MiniBrowser.qrc:
2125         * MiniBrowser/qt/MiniBrowser.pro:
2126         * Scripts/webkitdirs.pm:
2127
2128 2011-03-31  Chang Shu  <cshu@webkit.org>
2129
2130         Reviewed by Darin Adler.
2131
2132         WebKitTestRunner needs layoutTestController.clearAllDatabases
2133         https://bugs.webkit.org/show_bug.cgi?id=42540
2134
2135         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2137         (WTR::InjectedBundle::beginTesting):
2138         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2139         (WTR::LayoutTestController::clearAllDatabases):
2140         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2141
2142 2011-03-31  Chang Shu  <cshu@webkit.org>
2143
2144         Reviewed by Darin Adler.
2145
2146         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2147         https://bugs.webkit.org/show_bug.cgi?id=42692
2148
2149         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2150
2151 2011-03-31  Darin Adler  <darin@apple.com>
2152
2153         Reviewed by Sam Weinig.
2154
2155         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
2156         https://bugs.webkit.org/show_bug.cgi?id=57573
2157
2158         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2159         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
2160         Removed fake definitions of keyDown and contextClick.
2161
2162         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2163         (WTR::operator==): Added. So we can compare two WKPoint structs.
2164         (WTR::parseModifier): Added.
2165         (WTR::parseModifierArray): Added.
2166         (WTR::EventSendingController::EventSendingController): Initialize the
2167         new data members.
2168         (WTR::EventSendingController::mouseDown): Added. Calls
2169         WKBundlePageSimulateMouseDown.
2170         (WTR::EventSendingController::mouseUp): Added. Calls
2171         WKBundlePageSimulateMouseUp.
2172         (WTR::EventSendingController::mouseMoveTo): Added. Calls
2173         WKBundlePageSimulateMouseMotion.
2174         (WTR::EventSendingController::leapForward): Added.
2175         (WTR::EventSendingController::updateClickCount): Added. Used by the
2176         mouseDown/Up functions to create a click count.
2177
2178         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
2179         for the changes above.
2180
2181 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
2182
2183         Reviewed by Martin Robinson.
2184
2185         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
2186         https://bugs.webkit.org/show_bug.cgi?id=57362
2187
2188         Do not generate DRT output if willSendRequestReturnsNull is set.
2189
2190         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2191         (willSendRequestCallback):
2192
2193 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
2194
2195         Reviewed by Martin Robinson.
2196
2197         Implement MiniBrowser for Gtk port.
2198         https://bugs.webkit.org/show_bug.cgi?id=48512
2199
2200         Initial implementation of the Gtk MiniBrowser.
2201
2202         * MiniBrowser/gtk/GNUmakefile.am: Added.
2203         * MiniBrowser/gtk/main.c: Added.
2204         (activateUriEntryCallback):
2205         (destroyCallback):
2206         (goBackCallback):
2207         (goForwardCallback):
2208         (createToolbar):
2209         (createWebView):
2210         (createWindow):
2211         (argumentToURL):
2212         (main):
2213
2214 2011-03-30  Dominic Cooney  <dominicc@google.com>
2215
2216         Reviewed by Dimitri Glazkov.
2217
2218         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2219         https://bugs.webkit.org/show_bug.cgi?id=57415
2220
2221         * DumpRenderTree/LayoutTestController.cpp:
2222         (shadowRootCallback):
2223         (LayoutTestController::staticFunctions):
2224         * DumpRenderTree/LayoutTestController.h:
2225         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2226         (LayoutTestController::shadowRoot):
2227         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2228         (LayoutTestController::shadowRoot):
2229
2230 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
2231
2232         Reviewed by Chris Marrin.
2233
2234         Update fast/canvas tests to avoid dumping the render tree when possible
2235         https://bugs.webkit.org/show_bug.cgi?id=57493
2236
2237         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
2238           accelerated drawing and accelerated drawing for canvas
2239
2240 2011-03-30  Adam Roben  <aroben@apple.com>
2241
2242         Stop ignoring leaks in CGGradientCreateWithColorStops
2243
2244         Fixes <rdar://problem/7888547>.
2245
2246         Rubber-stamped by John Sullivan.
2247
2248         * Scripts/old-run-webkit-tests:
2249         (countAndPrintLeaks): Removed some code to ignore those leaks.
2250
2251 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
2252
2253         Reviewed by Alexey Proskuryakov.
2254
2255         Add some dynamic annotations to JavaScriptCore/wtf
2256         https://bugs.webkit.org/show_bug.cgi?id=53747
2257
2258         By using these annotations we can improve the precision of finding
2259         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
2260         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
2261
2262         These files don't add new functionality, so don't need extra tests.
2263
2264         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2265
2266 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2267
2268         Reviewed by Adam Roben.
2269
2270         Share most vsprops between Release and Production builds in releaseproduction.vsprops
2271         https://bugs.webkit.org/show_bug.cgi?id=57508
2272
2273         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2274         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2275         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2276         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2277         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2278         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2279         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2280         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2281         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2282         * FindSafari/FindSafariProduction.vsprops:
2283         * FindSafari/FindSafariRelease.vsprops:
2284         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
2285         * FindSafari/FindSafariReleasePGO.vsprops:
2286         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2287         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2288         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2289         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2290         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2291         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2292         * WebKitAPITest/WebKitAPITestRelease.vsprops:
2293         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
2294         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2295         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2296         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2297         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2298         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2299         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2300         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2301         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2302         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2303         * WinLauncher/WinLauncherProduction.vsprops:
2304         * WinLauncher/WinLauncherRelease.vsprops:
2305         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2306         * record-memory-win/record-memory-winProduction.vsprops:
2307         * record-memory-win/record-memory-winRelease.vsprops:
2308         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2309
2310 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2311
2312         Reviewed by Adam Roben.
2313
2314         Update Windows production build logic for new production configurations
2315         https://bugs.webkit.org/show_bug.cgi?id=57494
2316
2317         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2318         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2319         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2320         * FindSafari/FindSafariProduction.vsprops:
2321         * FindSafari/FindSafariReleasePGO.vsprops:
2322         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2323         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2324         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2325         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2326         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2327         * WinLauncher/WinLauncherProduction.vsprops:
2328         * record-memory-win/record-memory-winProduction.vsprops:
2329
2330 2011-03-30  Robert Hogan  <robert@webkit.org>
2331
2332         Reviewed by Antonio Gomes.
2333
2334         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2335         Unskip http/tests/navigation/go-back-to-error-page.html
2336
2337         Also add the location of DumpRenderTreeSupportQt.h
2338         to DRT's include paths.
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=52614
2341
2342         * DumpRenderTree/qt/DumpRenderTree.pro:
2343         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2344         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2345         * DumpRenderTree/qt/GCControllerQt.cpp:
2346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2347         (LayoutTestController::queueLoadHTMLString):
2348         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2349         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2350         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2351         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2352         (LoadAlternateHTMLStringItem::invoke):
2353         * DumpRenderTree/qt/WorkQueueItemQt.h:
2354         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2355         * QtTestBrowser/QtTestBrowser.pro:
2356         * QtTestBrowser/launcherwindow.h:
2357
2358 2011-03-30  Adam Barth  <abarth@webkit.org>
2359
2360         Reviewed by Adam Roben.
2361
2362         SheriffBot rollouts take too long
2363         https://bugs.webkit.org/show_bug.cgi?id=57498
2364
2365         We used to build before landing rollouts via the commit-queue to
2366         prevent further breakage, but now that our individual commit-queue
2367         machines are slower, building takes too long.  I can't remember the
2368         last time a rollout broke compile.  It seems like just landing the
2369         patch is the better trade-off.
2370
2371         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2373
2374 2011-03-30  Adam Barth  <abarth@webkit.org>
2375
2376         Remove platform/chromium-mac-snowleopard
2377         https://bugs.webkit.org/show_bug.cgi?id=57486
2378
2379         This directory no longer exists, so we can remove it from the fallback
2380         chain.
2381
2382         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2383
2384 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2385
2386         Reviewed by Adam Roben.
2387
2388         Rename Windows configuration Release_LTCG to Production for clarity
2389         https://bugs.webkit.org/show_bug.cgi?id=57465
2390
2391         * DumpRenderTree/DumpRenderTree.sln:
2392         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2393         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2394         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2395         * DumpRenderTree/win/DumpRenderTree.vcproj:
2396         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2397         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2398         * DumpRenderTree/win/ImageDiff.vcproj:
2399         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2400         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2401         * FindSafari/FindSafari.vcproj:
2402         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2403         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2404         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2405         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2406         * MiniBrowser/MiniBrowser.vcproj:
2407         * Scripts/webkitdirs.pm:
2408         * TestWebKitAPI/win/TestWebKitAPI.sln:
2409         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2410         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2411         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2412         * WebKitAPITest/WebKitAPITest.vcproj:
2413         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2414         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2415         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2416         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2417         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2418         * WebKitTestRunner/WebKitTestRunner.sln:
2419         * WebKitTestRunner/win/InjectedBundle.vcproj:
2420         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2421         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2422         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2423         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2424         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2425         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2426         * WinLauncher/WinLauncher.vcproj:
2427         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2428         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2429         * record-memory-win/record-memory-win.vcproj:
2430         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2431         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2432
2433 2011-03-30  MORITA Hajime  <morrita@google.com>
2434
2435         Reviewed by Dimitri Glazkov.
2436
2437         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2438         https://bugs.webkit.org/show_bug.cgi?id=56573
2439
2440         Added LayoutTestController.shadowRoot() to Chromium DRT.
2441
2442         * DumpRenderTree/chromium/LayoutTestController.cpp:
2443         (LayoutTestController::LayoutTestController):
2444         (LayoutTestController::shadowRoot):
2445         * DumpRenderTree/chromium/LayoutTestController.h:
2446
2447 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2448
2449         Reviewed by Kent Tamura.
2450
2451         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2452         https://bugs.webkit.org/show_bug.cgi?id=57430
2453
2454         * DumpRenderTree/chromium/LayoutTestController.cpp:
2455         (LayoutTestController::LayoutTestController):
2456         (LayoutTestController::setPluginsEnabled):
2457         * DumpRenderTree/chromium/LayoutTestController.h:
2458
2459 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2460
2461         Reviewed by Adam Barth.
2462
2463         make webkit-patch upload respect -d
2464         https://bugs.webkit.org/show_bug.cgi?id=57425
2465
2466         * Scripts/webkitpy/common/checkout/scm.py:
2467         * Scripts/webkitpy/tool/steps/commit.py:
2468
2469 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2470
2471         Reviewed by Adam Barth.
2472
2473         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2474         https://bugs.webkit.org/show_bug.cgi?id=57429
2475
2476         * Scripts/webkitpy/common/checkout/scm.py:
2477
2478 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2479
2480         Unreviewed, rolling out r82383.
2481         http://trac.webkit.org/changeset/82383
2482         https://bugs.webkit.org/show_bug.cgi?id=57417
2483
2484         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2485         #webkit).
2486
2487         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2488         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2489         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2490
2491 2011-03-29  Kent Tamura  <tkent@chromium.org>
2492
2493         Reviewed by Dimitri Glazkov.
2494
2495         Make validation message bubble testable
2496         https://bugs.webkit.org/show_bug.cgi?id=57290
2497
2498         * DumpRenderTree/mac/DumpRenderTree.mm:
2499         (createWebViewAndOffscreenWindow): Change a setting so that validation
2500           bubbles isn't hidden automatically.
2501
2502 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2503
2504         Reviewed by Ojan Vafai.
2505
2506         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2507
2508         It's a bit unclear whether multiple threads or multiple
2509         processes will be a better model on windows. This change will
2510         test threads for now while we're still working out the bugs in
2511         multiple-processes.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=57410
2514
2515         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2516         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2517         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2518
2519 2011-03-29  David Levin  <levin@chromium.org>
2520
2521         Reviewed by Shinichiro Hamaji.
2522
2523         check-webkit-style confused by two ChangeLog entries in a row from same user
2524         https://bugs.webkit.org/show_bug.cgi?id=57250
2525
2526         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2527         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2528         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2529           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2530           checking more than that would be very messey.
2531         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2532         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2533
2534 2011-03-29  Kent Tamura  <tkent@chromium.org>
2535
2536         Reviewed by Dimitri Glazkov.
2537
2538         [Mac] Enable interactive-validation tests on Mac DRT
2539         https://bugs.webkit.org/show_bug.cgi?id=57308
2540
2541         * DumpRenderTree/mac/DumpRenderTree.mm:
2542         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2543
2544 2011-03-29  Chang Shu  <cshu@webkit.org>
2545
2546         Reviewed by Kenneth Rohde Christiansen.
2547
2548         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2549         https://bugs.webkit.org/show_bug.cgi?id=42692
2550
2551         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2552         (WTR::InjectedBundle::beginTesting):
2553         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2554         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2555         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2556
2557 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2558
2559         Reviewed by Xan Lopez.
2560
2561         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2562         https://bugs.webkit.org/show_bug.cgi?id=57067
2563
2564         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2565         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2566         update DRT and pixel results as hundreds of results will need to be updated.
2567
2568         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2569         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2570         by overriding the theme RC/CSS files.
2571
2572 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2573
2574         Reviewed by Adam Roben.
2575
2576         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2577         https://bugs.webkit.org/show_bug.cgi?id=57394
2578
2579         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2580         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2581         the IDE. To avoid this, add a separate vsprops file for each project configuration that
2582         contains the required inherited property sheets.
2583
2584         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2585         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2586         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2587         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2588         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2589         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2590         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2591         * DumpRenderTree/win/DumpRenderTree.vcproj:
2592         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2593         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2594         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2595         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2596         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2597         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2598         * DumpRenderTree/win/ImageDiff.vcproj:
2599         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2600         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2601         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2602         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2603         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2604         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2605         * FindSafari/FindSafari.vcproj:
2606         * FindSafari/FindSafariDebug.vsprops: Added.
2607         * FindSafari/FindSafariDebugAll.vsprops: Added.
2608         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2609         * FindSafari/FindSafariRelease.vsprops: Added.
2610         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2611         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2612         * FindSafari/FindSafariReleasePGO.vsprops: Added.
2613         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2614         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2615         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2616         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2617         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2618         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2619         * MiniBrowser/MiniBrowser.vcproj:
2620         * WebKitAPITest/WebKitAPITest.vcproj:
2621         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2622         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2623         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2624         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2625         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2626         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2627         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2628         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2629         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2630         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2631         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2632         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2633         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2634         * WebKitTestRunner/win/InjectedBundle.vcproj:
2635         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2636         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2637         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2638         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2639         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2640         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2641         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2642         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2643         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2644         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2645         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2646         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2647         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2648         * WinLauncher/WinLauncher.vcproj:
2649         * WinLauncher/WinLauncherDebug.vsprops: Added.
2650         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2651         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2652         * WinLauncher/WinLauncherRelease.vsprops: Added.
2653         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2654         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2655         * record-memory-win/record-memory-win.vcproj:
2656         * record-memory-win/record-memory-winDebug.vsprops: Added.
2657         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2658         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2659         * record-memory-win/record-memory-winRelease.vsprops: Added.
2660         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2661         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2662
2663 2011-03-29  Adam Barth  <abarth@webkit.org>
2664
2665         Reviewed by Darin Adler.
2666
2667         test_runner2.py can crash due to undefined variable
2668         https://bugs.webkit.org/show_bug.cgi?id=57356
2669
2670         Replace reference to undefined variable with a variable that's actually
2671         defined.  AFAICT, there's no way to test this code.
2672
2673         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2674
2675 2011-03-29  Tony Chang  <tony@chromium.org>
2676
2677         Reviewed by Eric Seidel.
2678
2679         cleanup rebaseline-chromium-webkit-tests
2680         https://bugs.webkit.org/show_bug.cgi?id=57375
2681
2682         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2683             - Split _extract_and_add_new_baselines into 3 functions
2684             - Reduce the amount of line wrapping (the file already has lines
2685               over 80 col, so may as well try to make the file consistent)
2686             - Remove unnecessary ()s
2687
2688 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2689
2690         Reviewed by Adam Roben.
2691
2692         Make WinCairo a core builder.
2693         https://bugs.webkit.org/show_bug.cgi?id=57373
2694
2695         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2696         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2697
2698 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2699
2700         Update update-webkit-localizable-strings to understand that WebKit and
2701         WebKit2 strings go in WebCore.
2702
2703         Also make extract-localizable-strings optionally use an exclude file. No individual
2704         warnings are produced about unlocalized strings when there is no exclude file. This
2705         is needed for WebCore, since there are too many bare strings.
2706
2707         https://webkit.org/b/57354
2708
2709         Reviewed by Sam Weinig.
2710
2711         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2712         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2713
2714 2011-03-29  Darin Adler  <darin@apple.com>
2715
2716         Reviewed by Adam Roben.
2717
2718         WebKit2 bundle page needs to offer generated file hooks
2719         https://bugs.webkit.org/show_bug.cgi?id=57279
2720
2721         (Land missing part of the original patch after r82289.)
2722
2723         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2724         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2725
2726 2011-03-29  Tony Chang  <tony@chromium.org>
2727
2728         Reviewed by Ojan Vafai.
2729
2730         [chromium] NRWT should be able to read checksums from png comments
2731         https://bugs.webkit.org/show_bug.cgi?id=57280
2732
2733         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2734             from a file.
2735         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2736         * Scripts/webkitpy/common/system/filesystem_mock.py:
2737         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2738             if the -checksum.txt file doesn't exist, try looking in the png.
2739         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2740         * Scripts/webkitpy/layout_tests/port/test.py:
2741         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2742             2k for a png comment with the checksum
2743         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2744
2745 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2746
2747         Rubber-stamped by Gustavo Noronha Silva.
2748
2749         [GTK] http/tests/uri/username-with-no-hostname.html fails
2750         https://bugs.webkit.org/show_bug.cgi?id=57325
2751
2752         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2753         (willSendRequestCallback): URI host value check done case-insensitively.
2754
2755 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2756
2757         Reviewed by Martin Robinson.
2758
2759         [GTK] http/tests/uri/username-with-no-hostname.html fails
2760         https://bugs.webkit.org/show_bug.cgi?id=57325
2761
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         (willSendRequestCallback): Check URI before submitting the request
2764         to WebCore.
2765
2766 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2767
2768         Reviewed by Ojan Vafai.
2769
2770         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2771         https://bugs.webkit.org/show_bug.cgi?id=57303
2772
2773         * DumpRenderTree/chromium/EventSender.cpp:
2774         (EventSender::doDragDrop):
2775         (EventSender::beginDragWithFiles):
2776
2777 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2778
2779         Reviewed by Andreas Kling.
2780
2781         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2782         https://bugs.webkit.org/show_bug.cgi?id=57314
2783
2784         Provide possibility to print loaded urls to the standard output.
2785
2786         * MiniBrowser/qt/BrowserWindow.cpp:
2787         (BrowserWindow::BrowserWindow):
2788         (BrowserWindow::printURL):
2789         * MiniBrowser/qt/BrowserWindow.h:
2790         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2791         (MiniBrowserApplication::handleUserOptions):
2792         * MiniBrowser/qt/MiniBrowserApplication.h:
2793         (WindowOptions::WindowOptions):
2794         * QtTestBrowser/launcherwindow.cpp:
2795         (LauncherWindow::initializeView):
2796         (LauncherWindow::printURL):
2797         (LauncherWindow::cloneWindow):
2798         * QtTestBrowser/launcherwindow.h:
2799         (WindowOptions::WindowOptions):
2800         * QtTestBrowser/main.cpp:
2801         (LauncherApplication::handleUserOptions):
2802
2803 2011-03-29  Gabor Loki  <loki@webkit.org>
2804
2805         Rubber-stamped by Csaba Osztrogonác.
2806
2807         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2808         https://bugs.webkit.org/show_bug.cgi?id=56918
2809
2810         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2811
2812 2011-03-28  Gabor Loki  <loki@webkit.org>
2813
2814         Reviewed by Csaba Osztrogonác.
2815
2816         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2817         https://bugs.webkit.org/show_bug.cgi?id=56918
2818
2819         * Scripts/build-jsc:
2820         * Scripts/webkitdirs.pm:
2821
2822 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2823
2824         Reviewed by Ojan Vafai.
2825
2826         webkit-patch should be more intelligent about whether a bug applies to a patch
2827         Create a new function, parse_bug_id_from_changelog() which determines
2828         that a bug is related to a patch by parsing the output generated from
2829         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2830         the description of a patch.
2831         https://bugs.webkit.org/show_bug.cgi?id=56989
2832
2833         * Scripts/webkitpy/common/checkout/api.py:
2834         * Scripts/webkitpy/common/checkout/changelog.py:
2835         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2836         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2837         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2838         * Scripts/webkitpy/style/checkers/changelog.py:
2839         * Scripts/webkitpy/tool/commands/upload.py:
2840
2841 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2842
2843         Revert accidentally commited change.
2844
2845         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2846         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2847
2848 2011-03-28  Tony Chang  <tony@chromium.org>
2849
2850         Reviewed by Adam Barth.
2851
2852         [chromium] have DRT write the png checksum into a png comment
2853         https://bugs.webkit.org/show_bug.cgi?id=57255
2854
2855         * DumpRenderTree/chromium/TestShell.cpp:
2856         (TestShell::dumpImage):
2857
2858 2011-03-28  Adele Peterson  <adele@apple.com>
2859
2860         Removing Qt stub, since it doesn't use the same header as the others.
2861
2862         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2863
2864 2011-03-28  Adele Peterson  <adele@apple.com>
2865
2866         Added a few more stubs.
2867
2868         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2869         (LayoutTestController::hasGrammarMarker):
2870         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2871         (LayoutTestController::hasGrammarMarker):
2872         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2873         (LayoutTestController::hasGrammarMarker):
2874
2875 2011-03-28  Adele Peterson  <adele@apple.com>
2876
2877         Build fix.
2878
2879         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2880         (LayoutTestController::hasGrammarMarker):
2881
2882 2011-03-28  Adele Peterson  <adele@apple.com>
2883
2884         Reviewed by Eric Seidel.
2885
2886         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2887         https://bugs.webkit.org/show_bug.cgi?id=57173
2888
2889         * DumpRenderTree/LayoutTestController.cpp:
2890         (hasGrammarMarkerCallback): Added.
2891         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2892         * DumpRenderTree/LayoutTestController.h:
2893         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2894         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2895
2896 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2897
2898         Reviewed by Benjamin Poulain.
2899
2900         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2901         https://bugs.webkit.org/show_bug.cgi?id=57087
2902
2903         Trivial typo fix after r82082.
2904
2905         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2906         (WTR::activateFonts):
2907
2908 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2909
2910         Reviewed by Andreas Kling.
2911
2912         Add myself to the committers list.
2913
2914         * Scripts/webkitpy/common/config/committers.py:
2915
2916 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2917
2918         Reviewed by Sam Weinig.
2919
2920         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2921         to link against WebKit.framework for now.
2922
2923         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2924
2925 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2926
2927         Reviewed by Andreas Kling.
2928
2929         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2930         https://bugs.webkit.org/show_bug.cgi?id=57087
2931
2932         Disable QT_ASCII_CAST_WARNINGS for applications.
2933
2934         * DumpRenderTree/qt/DumpRenderTree.pro:
2935         * DumpRenderTree/qt/ImageDiff.pro:
2936         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2937         * MiniBrowser/qt/MiniBrowser.pro:
2938         * QtTestBrowser/QtTestBrowser.pro:
2939         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2940
2941 2011-03-28  Andreas Kling  <kling@webkit.org>
2942
2943         Reviewed by Kenneth Rohde Christiansen.
2944
2945         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2946         https://bugs.webkit.org/show_bug.cgi?id=57224
2947
2948         * QtTestBrowser/mainwindow.cpp:
2949         (MainWindow::buildUI):
2950         (MainWindow::onTitleChanged):
2951         * QtTestBrowser/mainwindow.h:
2952
2953 2011-03-27  Jer Noble  <jer.noble@apple.com>
2954
2955         Reviewed by Maciej Stachowiak.
2956
2957         Full Screen: disable keyboard access by default
2958         https://bugs.webkit.org/show_bug.cgi?id=56684
2959
2960         Accept the withKeyboard parameter to supportsFullScreenForElement.
2961
2962         * DumpRenderTree/mac/UIDelegate.mm:
2963         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2964
2965 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2966
2967         Reviewed by David Levin.
2968
2969         check-webkit-style should check ChangeLog for a valid bug number
2970         https://bugs.webkit.org/show_bug.cgi?id=57184
2971
2972         * Scripts/webkitpy/style/checker.py:
2973         * Scripts/webkitpy/style/checker_unittest.py:
2974         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2975         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2976
2977 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2978
2979         Reviewed by Andreas Kling.
2980
2981         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2982         https://bugs.webkit.org/show_bug.cgi?id=57087
2983
2984         Use explicit conversion for string to avoid depending on the default codec
2985         installed by the user code.
2986
2987         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2988         (WTR::activateFonts):
2989
2990 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2991
2992         Revert inadvertantly committed changes.
2993
2994         * Scripts/old-run-webkit-tests:
2995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2996
2997 2011-03-26  Andreas Kling  <kling@webkit.org>
2998
2999         Reviewed by Kenneth Rohde Christiansen.
3000
3001         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
3002         https://bugs.webkit.org/show_bug.cgi?id=57162
3003
3004         * QtTestBrowser/QtTestBrowser.qrc:
3005         * QtTestBrowser/favicon.png: Added.
3006         * QtTestBrowser/locationedit.cpp:
3007         (defaultPageIcon):
3008         (LocationEdit::LocationEdit):
3009         (LocationEdit::setPageIcon):
3010         (LocationEdit::resizeEvent):
3011         (LocationEdit::updateInternalGeometry):
3012         * QtTestBrowser/locationedit.h:
3013         * QtTestBrowser/mainwindow.cpp:
3014         (MainWindow::buildUI):
3015         (MainWindow::onIconChanged):
3016         (MainWindow::onLoadStarted):
3017         * QtTestBrowser/mainwindow.h:
3018
3019 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
3020
3021         Reviewed by Xan Lopez.
3022
3023         [GTK] Force DumpRenderTree to use 96 DPI
3024         https://bugs.webkit.org/show_bug.cgi?id=56866
3025
3026         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
3027         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
3028
3029         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3030         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
3031         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
3032         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
3033
3034 2011-03-25  Andy Estes  <aestes@apple.com>
3035
3036         Reviewed by Adele Peterson.
3037
3038         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3039         https://bugs.webkit.org/show_bug.cgi?id=49016
3040
3041         TestNetscapePlugIn needs to register support for an image MIME type so
3042         we can test that the embed tag prefers plug-ins to render image MIME
3043         types.
3044
3045         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
3046         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3047         (NP_GetMIMEDescription): Ditto.
3048         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
3049
3050 2011-03-25  Jessie Berlin  <jberlin@apple.com>
3051
3052         Reviewed by Sam Weinig.
3053
3054         WebKit2: Need to be able to set and get the Cookie Storage Policy.
3055         https://bugs.webkit.org/show_bug.cgi?id=50780
3056
3057         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
3058
3059         The test is named "CookieManager" so that we can eventually exercise more of the
3060         CookieManager functionality in the test.
3061
3062         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
3063         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3064         Assert that the policy returned is equal to the policy set in
3065         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
3066         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3067         Set the policy to something different than the user's policy and get the policy again.
3068         (TestWebKitAPI::didFinishLoadForFrame):
3069         Get the user's policy so that it can be restored at the end of the test.
3070         (TestWebKitAPI::TEST):
3071         Load about:blank so that the Web Process gets instatiated (needed to get the
3072         CookieManager).
3073
3074         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3075         Add CookieManager.cpp.
3076
3077 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3078
3079         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
3080
3081         * wx/build/settings.py:
3082
3083 2011-03-24  Ilya Sherman  <isherman@chromium.org>
3084
3085         Reviewed by Adam Roben.
3086
3087         Implement layoutTestController.setAutoFilled in DRT on Windows
3088         https://bugs.webkit.org/show_bug.cgi?id=56828
3089
3090         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3091         (LayoutTestController::setAutofilled): Implemented.
3092
3093 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3094
3095         Unreviewed build correction.
3096
3097         Correct vsprops file for Debug variant of the CFLite build.
3098         Disable a CFNETWORK-specific test when building for CFLite.
3099
3100         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
3101         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3102
3103 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3104
3105         Reviewed by Adam Barth.
3106
3107         fix regressions introduced in 81908 - there were a couple of
3108         code paths that only fired under python 2.5 that I missed.
3109
3110         Also change a couple of 'python' references to sys.executable
3111         in order to handle runing test-webkitpy with a binary other than
3112         something called 'python'.
3113
3114         https://bugs.webkit.org/show_bug.cgi?id=57063
3115
3116         * Scripts/webkitpy/layout_tests/port/mac.py:
3117         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3118         * Scripts/webkitpy/test/cat.py:
3119         * Scripts/webkitpy/test/echo.py:
3120
3121 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3122
3123         Unreviewed build correction.
3124
3125         Add a stub implementation of the TestInvocation dumping logic.
3126         Update project files to reflect new file.
3127
3128         * WebKitTestRunner/cairo: Added.
3129         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
3130         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3131         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3132
3133 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3134
3135         Reviewed by Tony Chang.
3136
3137         new-run-webkit-tests: clean up worker model defaults. This
3138         changes the default behavior to 'threads' instead of
3139         'old-threads', and clarifies that chromium-win-* and
3140         chromium-mac-leopard are exceptions.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=56971
3143
3144         * Scripts/webkitpy/layout_tests/port/base.py:
3145         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3146         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3147         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3148         * Scripts/webkitpy/layout_tests/port/test.py:
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3150
3151 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
3152
3153         Reviewed by Darin Adler.
3154
3155         Media Stream API: fix the order of the options in build-webkit.
3156         https://bugs.webkit.org/show_bug.cgi?id=56949
3157
3158         Fix the order of the options in build-webkit.
3159
3160         * Scripts/build-webkit:
3161
3162 2011-03-23  Adam Klein  <adamk@chromium.org>
3163
3164         Reviewed by Mihai Parparita.
3165
3166         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
3167         https://bugs.webkit.org/show_bug.cgi?id=56884
3168
3169         This option will be utilized by Chromium's ui_tests to allow
3170         referencing js-test-resources from a layout test over HTTP.
3171
3172         * Scripts/new-run-webkit-httpd:
3173         Added --layout_tests_dir option.
3174         * Scripts/webkitpy/layout_tests/port/http_server.py:
3175         Plumbed through as layout_tests_dir param.
3176
3177 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
3178
3179         Reviewed by Mihai Parparita.
3180
3181         new-run-webkit-tests: run tests in ascending alphabetical order per
3182         dir. This is a second attempt at the fix; the first attempt, in 
3183         r81597, broke the behavior on the old-inline and old-threads
3184         worker models.
3185
3186         https://bugs.webkit.org/show_bug.cgi?id=56760
3187
3188         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3189         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3190         * Scripts/webkitpy/layout_tests/port/test.py:
3191         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3192
3193 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
3194
3195         Reviewed by Martin Robinson.
3196
3197         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
3198         https://bugs.webkit.org/show_bug.cgi?id=56953
3199
3200         Print the string for the detail of 'property-change' signal.
3201
3202         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3203         (axObjectEventListener): Print the detail string.
3204
3205 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3206
3207         Reviewed by Pavel Feldman.
3208
3209         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3210         https://bugs.webkit.org/show_bug.cgi?id=56843
3211
3212         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3213         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3214
3215 2011-03-22  Eric Seidel  <eric@webkit.org>
3216
3217         Reviewed by Adam Barth.
3218
3219         Teach update-webkit about gyp
3220         https://bugs.webkit.org/show_bug.cgi?id=56881
3221
3222         This makes it possible for someone who builds from Xcode
3223         to just run update-webkit --gyp and have the project files
3224         generated after update automatically.
3225
3226         I also added a stand-alone "generate-project-files" script
3227         wrapping Source/gyp/configure.  This makes running gyp simpler
3228         since most people will not have gyp or Source/gyp in their path.
3229
3230         * Scripts/build-webkit:
3231         * Scripts/generate-project-files: Added.
3232         * Scripts/update-webkit:
3233
3234 2011-03-22  Anton D'Auria  <adauria@apple.com>
3235
3236         Reviewed by Alexey Proskuryakov.
3237
3238         Add +[WebApplicationCache getOriginsWithCache]
3239         https://bugs.webkit.org/show_bug.cgi?id=56722
3240
3241         * DumpRenderTree/LayoutTestController.cpp:
3242         (originsWithApplicationCacheCallback):
3243         (LayoutTestController::staticFunctions):
3244         * DumpRenderTree/LayoutTestController.h:
3245         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3246         (LayoutTestController::originsWithApplicationCache):
3247         * DumpRenderTree/chromium/LayoutTestController.h:
3248         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3249         (LayoutTestController::originsWithApplicationCache):
3250         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
3251         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
3252         (LayoutTestController::originsWithApplicationCache):
3253         (LayoutTestController::originsWithLocalStorage):
3254         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3255         (LayoutTestController::originsWithApplicationCache):
3256         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3257         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3258         (LayoutTestController::originsWithApplicationCache):
3259         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
3260         (LayoutTestController::originsWithApplicationCache):
3261
3262 2011-03-22  Eric Seidel  <eric@webkit.org>
3263
3264         Reviewed by Adam Barth.
3265
3266         Add support to build-webkit for building with gyp-generated project files
3267         https://bugs.webkit.org/show_bug.cgi?id=56877
3268
3269         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
3270         Eventually we'll want to support gyp-generated projects in a more general manner.
3271
3272         * Scripts/build-webkit:
3273
3274 2011-03-22  David Kilzer  <ddkilzer@apple.com>
3275
3276         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
3277
3278         Reviewed by Joseph Pecoraro.
3279
3280         * Scripts/build-webkit: Updated usage statement to include
3281         --dsym.
3282         * Scripts/webkitdirs.pm: Added $generateDsym variable.
3283         (generateDsym): Added. Call determineGenerateDsym() and
3284         return $generateDsym.
3285         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
3286         $generateDsym.
3287         (argumentsForXcode): Added.  Returns additional arguments for
3288         xcodebuild based on command-line switches.
3289         (XcodeOptions): Updated to include argumentsForXcode() in the
3290         array returned.
3291
3292 2011-03-22  Adam Roben  <aroben@apple.com>
3293
3294         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
3295
3296         These bots are consistently green again.
3297
3298         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
3299         core builders
3300
3301         Rubber-stamped by Antti Koivisto.
3302
3303         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3304         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
3305
3306         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3307         (BuildBotTest.test_builder_name_regexps): Updated expectations.
3308
3309 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3310
3311         Unreviewed, rolling out r81597.
3312         http://trac.webkit.org/changeset/81597
3313         https://bugs.webkit.org/show_bug.cgi?id=56801
3314
3315         Change results in lots of unexpected flaky on the dashboard.
3316         (Requested by pfeldman on #webkit).
3317
3318         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3319         * Scripts/webkitpy/layout_tests/port/test.py:
3320         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3321
3322 2011-03-21  Sam Weinig  <sam@webkit.org>
3323
3324         Fix failing tests on the WebKit2 bots.
3325
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::TestController::resetStateToConsistentValues):
3328
3329 2011-03-21  Daniel Sievers  <sievers@google.com>
3330
3331         Reviewed by Simon Fraser.
3332
3333         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3334         https://bugs.webkit.org/show_bug.cgi?id=56139
3335
3336         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3337         (main):
3338         * DumpRenderTree/chromium/LayoutTestController.cpp:
3339         (LayoutTestController::LayoutTestController):
3340         (LayoutTestController::layerTreeAsText):
3341         * DumpRenderTree/chromium/LayoutTestController.h:
3342         (LayoutTestController::setShowDebugLayerTree):
3343         * DumpRenderTree/chromium/TestShell.cpp:
3344         (TestShell::runFileTest):
3345         (TestShell::dump):
3346         * DumpRenderTree/chromium/TestShell.h:
3347         (TestParams::TestParams):
3348
3349 2011-03-21  Adam Roben  <aroben@apple.com>
3350
3351         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3352
3353         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3354         output as plain text
3355
3356         Reviewed by David Kilzer.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3359         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3360         to the master.
3361         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3362         since we're running on the build master, not the slave. Instead, turn the raw source of
3363         actual.html which the build slave uploaded into an HTML log.
3364
3365 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3366
3367         Reviewed by Mihai Parparita.
3368
3369         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3370         https://bugs.webkit.org/show_bug.cgi?id=56760
3371
3372         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3373         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3374         * Scripts/webkitpy/layout_tests/port/test.py:
3375
3376 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3377
3378         Reviewed by Steve Block.
3379
3380         Media Stream API patch 0: adding compilation guards.
3381         https://bugs.webkit.org/show_bug.cgi?id=56458
3382
3383         Adding options to enable the media stream API feature in Chromium.
3384
3385         * Scripts/build-webkit:
3386
3387 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3388
3389         Reviewed by Laszlo Gombos.
3390
3391         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3392         https://bugs.webkit.org/show_bug.cgi?id=56323
3393
3394         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
3395         "--stdout" or "--stderr" option.
3396
3397         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3398         (WebCore::DumpRenderTree::~DumpRenderTree):
3399         (WebCore::DumpRenderTree::processArgsLine):
3400         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3401         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3402         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3403         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3404         * DumpRenderTree/qt/main.cpp:
3405         (isOption):
3406         (takeOptionValue):
3407         (printUsage):
3408         (main):
3409
3410 2011-03-21  Adam Roben  <aroben@apple.com>
3411
3412         Fix exceptions on the buildbot due to my last change
3413
3414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3415         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3416
3417 2011-03-21  Adam Roben  <aroben@apple.com>
3418
3419         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3420
3421         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3422         output as plain text
3423
3424         Reviewed by Darin Adler.
3425
3426         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3427         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3428         logs.
3429         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3430         the build master. This will correctly treat it as HTML.
3431
3432 2011-03-20  Bill Budge  <bbudge@chromium.org>
3433
3434         Reviewed by Adam Barth.
3435
3436         Rename ThreadSafeShared to ThreadSafeRefCounted
3437         https://bugs.webkit.org/show_bug.cgi?id=56714
3438
3439         No new tests. Exposes no new functionality.
3440
3441         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3442         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3443         * Scripts/do-webcore-rename:
3444
3445 2011-03-19  Anton D'Auria  <adauria@apple.com>
3446
3447         Reviewed by Dan Bernstein.
3448
3449         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3450         https://bugs.webkit.org/show_bug.cgi?id=56719
3451
3452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3453         (LayoutTestController::clearApplicationCacheForOrigin):
3454
3455 2011-03-19  Anton D'Auria  <adauria@apple.com>
3456
3457         Reviewed by Alexey Proskuryakov.
3458
3459         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3460         https://bugs.webkit.org/show_bug.cgi?id=56415
3461
3462         * DumpRenderTree/LayoutTestController.cpp:
3463         (clearApplicationCacheForOriginCallback):
3464         (LayoutTestController::staticFunctions):
3465         * DumpRenderTree/LayoutTestController.h:
3466         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3467         (LayoutTestController::LayoutTestController):
3468         (LayoutTestController::clearAllApplicationCaches):
3469         (LayoutTestController::clearApplicationCacheForOrigin): 
3470         * DumpRenderTree/chromium/LayoutTestController.h:
3471         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3472         (LayoutTestController::clearApplicationCacheForOrigin):
3473         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3474         (LayoutTestController::clearApplicationCacheForOrigin):
3475         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3476         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3477         (LayoutTestController::clearApplicationCacheForOrigin):
3478         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3479         (LayoutTestController::clearApplicationCacheForOrigin):
3480
3481 2011-03-18  Dan Bernstein  <mitz@apple.com>
3482
3483         Revised build fix for r81135.
3484
3485         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3486         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3487
3488 2011-03-18  Adam Roben  <aroben@apple.com>
3489
3490         Windows build fix
3491
3492         * WebKitTestRunner/config.h: Add a missing #endif.
3493
3494 2011-03-18  Andreas Kling  <kling@webkit.org>
3495
3496         Unbreak Qt build after r81494.
3497
3498         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3499         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3500
3501 2011-03-18  Sam Weinig  <sam@webkit.org>
3502
3503         Fix windows build. This was really Adam Roben's fault. I swear!
3504
3505         * WebKitTestRunner/config.h:
3506
3507 2011-03-18  Sam Weinig  <sam@webkit.org>
3508
3509         Reviewed by Adam Roben.
3510
3511         Pixel tests don't work in WebKitTestRunner on Windows
3512         https://bugs.webkit.org/show_bug.cgi?id=56630
3513
3514         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3515         built-in snapshotting instead of using the window server on the Mac.
3516
3517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3518         (WTR::InjectedBundle::InjectedBundle):
3519         (WTR::InjectedBundle::didReceiveMessage):
3520         (WTR::InjectedBundle::beginTesting):
3521         (WTR::InjectedBundle::done):
3522         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3523         (WTR::InjectedBundle::setPixelResult):
3524         (WTR::InjectedBundle::shouldDumpPixels):
3525         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3526         (WTR::InjectedBundlePage::dump):
3527         Take the snapshot in the bundle and send it to the UIProcess for dumping.
3528
3529         * WebKitTestRunner/TestInvocation.cpp:
3530         (WTR::TestInvocation::invoke):
3531         (WTR::TestInvocation::dump):
3532         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3533         * WebKitTestRunner/TestInvocation.h:
3534         * WebKitTestRunner/cg: Added.
3535         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3536         (WTR::createCGContextFromImage):
3537         (WTR::computeMD5HashStringForContext):
3538         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3539         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3540         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3541
3542         * WebKitTestRunner/win/TestInvocationWin.cpp:
3543         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3544         Keep stub for Cairo build.
3545
3546         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3547         Add CG configuration.
3548
3549         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3550         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3551         Add new files.
3552
3553 2011-03-18  Adam Roben  <aroben@apple.com>
3554
3555         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3556
3557         Rubber-stamped by Simon Fraser.
3558
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3560         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3561         overflow-y:overlay so that the scrollbar doesn't overlay the content.
3562
3563 2011-03-18  Adam Roben  <aroben@apple.com>
3564
3565         Don't ellipsize long or indented function names in Leaks Viewer
3566
3567         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3568         scrollbar
3569
3570         Reviewed by Simon Fraser.
3571
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3573         (.data-grid .data-container):
3574         (.data-grid td > div, .data-grid th > div):
3575         Allow the contents to extend to the right.
3576
3577 2011-03-18  Adam Roben  <aroben@apple.com>
3578
3579         Fix some leaks in DRT seen on the leaks bot
3580
3581         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
3582         setWillSendRequestClearHeaderCallback in DRT are leaky
3583
3584         Reviewed by Alexey Proskuryakov.
3585
3586         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
3587
3588         * DumpRenderTree/LayoutTestController.cpp:
3589         (addURLToRedirectCallback):
3590         (setWillSendRequestClearHeaderCallback):
3591         Use OwnArrayPtr to cause the strings to be deleted.
3592
3593 2011-03-18  Adam Roben  <aroben@apple.com>
3594
3595         Fix a NSURLCredential leak seen on the leaks bot
3596
3597         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
3598         connection:didReceiveAuthenticationChallenge:] is leaky
3599
3600         Reviewed by John Sullivan.
3601
3602         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3603         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
3604         cause the NSURLCredential to be released.
3605
3606 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
3607
3608         Unreviewed.
3609
3610         Remove unnecessary brackets around my email address.
3611
3612         * Scripts/webkitpy/common/config/committers.py:
3613
3614 2011-03-18  Adam Roben  <aroben@apple.com>
3615         
3616         Remove some files I accidentally added in r81454
3617
3618         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
3619         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
3620
3621 2011-03-18  Adam Roben  <aroben@apple.com>
3622
3623         Ignore an NSNumberFormatter leak on SnowLeopard
3624
3625         * Scripts/old-run-webkit-tests:
3626         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
3627         getObjectValue:forString:errorDescription:].
3628
3629 2011-03-18  Adam Roben  <aroben@apple.com>
3630
3631         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
3632
3633         Rubber-stamped by Mark Rowe.
3634
3635         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3636         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
3637         released.
3638
3639 2011-03-17  Adam Roben  <aroben@apple.com>
3640
3641         Address a review comment I missed in r81445
3642
3643         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3644         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
3645         leaked bytes to speed up searching on long lines.
3646
3647 2011-03-17  Adam Roben  <aroben@apple.com>
3648
3649         Mark leaky builds orange, even if all regression tests passed
3650
3651         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3652         build.webkit.org when all tests pass even though there are still leaks
3653
3654         Reviewed by Dan Bernstein.
3655
3656         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3657         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3658         be marked orange if this build step generates warnings.
3659
3660 2011-03-17  Adam Roben  <aroben@apple.com>
3661
3662         Allow values in Leaks Viewer to be shown as percentages
3663
3664         Double-clicking on a column will toggle between showing percentages and showing real values.
3665
3666         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3667         number of leaked bytes in Leaks Viewer
3668
3669         Reviewed by Joe Pecoraro.
3670
3671         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3672         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3673         node's totalTime, which is used in