<rdar://problem/9304956> media/broken-video.html crashes
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-20  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         webkit-patch upload should assign the bug to you
6         https://bugs.webkit.org/show_bug.cgi?id=33699
7
8         This patch only re-assigns the bug if it is currently unassigned.  We
9         can be more aggressive in the future if people want us to be more
10         agressive.
11
12         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
13         * Scripts/webkitpy/tool/commands/upload_unittest.py:
14         * Scripts/webkitpy/tool/mocktool.py:
15         * Scripts/webkitpy/tool/steps/postdiff.py:
16
17 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
18
19         Reviewed by Csaba Osztrogonác.
20
21         Modify builder.html template to allow easy access
22         to list more builds on the builder's page.
23
24         https://bugs.webkit.org/show_bug.cgi?id=59008
25
26         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
27
28 2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>
29
30         Reviewed by Csaba Osztrogonác.
31
32         Add the default template for builder page.
33
34         https://bugs.webkit.org/show_bug.cgi?id=59008
35
36         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
37
38 2011-04-20  Ojan Vafai  <ojan@chromium.org>
39
40         Reviewed by Eric Seidel.
41
42         move page generation into a single function
43         https://bugs.webkit.org/show_bug.cgi?id=59027
44
45         Now executing the script doesn't create any state. We should then
46         be able to write tests for this by setting custom results data.
47
48         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
49
50 2011-04-20  Ojan Vafai  <ojan@chromium.org>
51
52         Reviewed by Eric Seidel.
53
54         move global state into a shared object
55         https://bugs.webkit.org/show_bug.cgi?id=59023
56
57         This makes the code more testable.
58
59         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
60
61 2011-04-20  Ojan Vafai  <ojan@chromium.org>
62
63         Reviewed by Tony Chang.
64
65         move global state into a shared object
66         https://bugs.webkit.org/show_bug.cgi?id=59023
67
68         This makes the code more testable.
69
70         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
71
72 2011-04-20  Ojan Vafai  <ojan@chromium.org>
73
74         Reviewed by Eric Seidel.
75
76         add expandAll/collapseAll links
77         https://bugs.webkit.org/show_bug.cgi?id=59011
78
79         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
80
81 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
82
83         [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
84
85         * Scripts/webkitdirs.pm:
86         * wx/build/build_utils.py:
87         * wx/build/settings.py:
88         * wx/install-unix-extras:
89         * wx/packaging/build-mac-installer.py:
90         * wx/packaging/build-win-installer.py:
91
92 2011-04-20  Adam Roben  <aroben@apple.com>
93
94         Replace old-run-webkit-tests's win-7 platform with win-7sp0
95
96         It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
97         version of Windows we cared about, so its results should just go in win. But now that
98         Windows 7 SP1 exists (and has different results for some tests), we need a place to store
99         results for Windows 7 without SP1 (and older versions of Windows).
100
101         Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
102         differences from Windows 7 "SP0"
103
104         Reviewed by David Kilzer.
105
106         * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
107         will just use "win".
108
109         * Scripts/webkitdirs.pm:
110         (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
111
112 2011-04-20  Adam Roben  <aroben@apple.com>
113
114         Teach webkitdirs::winVersion about build numbers
115
116         The build number isn't currently used, but soon will be.
117
118         As a bonus, winVersion now works on non-Cygwin variants of Perl!
119
120         Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
121         SP1
122
123         Reviewed by Anders Carlsson.
124
125         * Scripts/webkitdirs.pm:
126         (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
127         (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
128         number. Parse the version number into a hash, similar to how osXVersion() works.
129
130         (isWindows7):
131         (isWindowsVista):
132         (isWindowsXP):
133         Updated for changes to winVersion().
134
135 2011-04-20  W. James MacLean  <wjmaclean@chromium.org>
136
137         Reviewed by Kenneth Russell.
138
139         Add support for composite-to-texture to DumpRenderTree.
140         https://bugs.webkit.org/show_bug.cgi?id=58675
141
142         * DumpRenderTree/chromium/DumpRenderTree.cpp:
143         (main):
144         * DumpRenderTree/chromium/TestShell.cpp:
145         (TestShell::TestShell):
146         (TestShell::resetWebSettings):
147         * DumpRenderTree/chromium/TestShell.h:
148         (TestShell::setCompositeToTexture):
149         * DumpRenderTree/chromium/WebPreferences.cpp:
150         (WebPreferences::reset):
151         (WebPreferences::applyTo):
152         * DumpRenderTree/chromium/WebPreferences.h:
153
154 2011-04-19  Eric Seidel  <eric@webkit.org>
155
156         Reviewed by Adam Barth.
157
158         The commit-queue is confused when non-layout tests fail
159         https://bugs.webkit.org/show_bug.cgi?id=58955
160
161         As seen in http://queues.webkit.org/results/8474435
162
163         It fails to create an archive of the layout test results
164         and then throws an exception.
165
166         I've fixed this by making it catch the exception as well
167         as made it so it never calls that path in the common case.
168
169         I've updated MockFileSystem to understand rmtree's affect on
170         directories as well as files.
171
172         * Scripts/webkitpy/common/system/filesystem_mock.py:
173         * Scripts/webkitpy/common/system/workspace.py:
174         * Scripts/webkitpy/tool/commands/queues.py:
175         * Scripts/webkitpy/tool/commands/queues_unittest.py:
176         * Scripts/webkitpy/tool/mocktool.py:
177
178 2011-04-19  Ojan Vafai  <ojan@chromium.org>
179
180         Fix check for whether a failure is expected to deal with
181         flaky tests and FAIL expectations.
182         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
183
184 2011-04-19  Ojan Vafai  <ojan@chromium.org>
185
186         Reviewed by Eric Seidel.
187
188         don't show missing text results for tests that only dump image results
189         https://bugs.webkit.org/show_bug.cgi?id=58931
190
191         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
192         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
193
194 2011-04-19  Ojan Vafai  <ojan@chromium.org>
195
196         Reviewed by Eric Seidel.
197
198         don't show failures table if there are only new tests
199         https://bugs.webkit.org/show_bug.cgi?id=58929
200
201         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
202
203 2011-04-19  Ojan Vafai  <ojan@chromium.org>
204
205         Reviewed by Eric Seidel.
206
207         don't show failures table if there are only new tests
208         https://bugs.webkit.org/show_bug.cgi?id=58929
209
210         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
211
212 2011-04-19  Ojan Vafai  <ojan@chromium.org>
213
214         Fix unittest failures from http://trac.webkit.org/changeset/84294.
215
216         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
217         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
218
219 2011-04-18  Ojan Vafai  <ojan@chromium.org>
220
221         Reviewed by Eric Seidel.
222
223         switch new-run-webkit-tests to using the new results file
224         https://bugs.webkit.org/show_bug.cgi?id=58861
225
226         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
227         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
228         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
229
230 2011-04-19  Renata Hodovan  <reni@webkit.org>
231
232         Reviewed by Eric Seidel.
233
234         Move the alignment related macros from Vector.h to new Alignment.h.
235         https://bugs.webkit.org/show_bug.cgi?id=56000
236
237         Adding the new file to the forwarding headers of Tools.
238
239         * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
240
241 2011-04-19  Kevin Ollivier  <kevino@theolliviers.com>
242
243         [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
244
245         * wx/packaging/build-win-installer.py:
246         * wx/packaging/wxWebKitInstaller.iss.in:
247
248 2011-04-19  Adam Roben  <aroben@apple.com>
249
250         Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
251
252         * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
253         accelerated compositing is disabled.
254
255 2011-04-19  Ojan Vafai  <ojan@chromium.org>
256
257         Remove accidentally committed debug code.
258         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
259
260 2011-04-19  Brent Fulgham  <bfulgham@webkit.org>
261
262         Unreviewed build correction.
263
264         Avoid duplicate stub implementation of test routine
265         for WinCairo build.
266
267         * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
268         WinCairo from using this stub.
269
270 2011-04-18  Ojan Vafai  <ojan@chromium.org>
271
272         Reviewed by Eric Seidel.
273
274         make results file work with audio and reftests
275         https://bugs.webkit.org/show_bug.cgi?id=58860
276
277         Also fix bug with timeout tests and store a bit in the JSON
278         for new image tests instead of loading the image result to check if it's there.
279
280         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
281         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
282
283 2011-04-19  Jer Noble  <jer.noble@apple.com>
284
285         Reviewed by Adam Roben.
286
287         REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
288         https://bugs.webkit.org/show_bug.cgi?id=58890
289
290         Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
291         Defaults to false.
292
293         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
294         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
295         (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
296         (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
297         (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
298         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
299         (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
300         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
301         (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
302         (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
303
304 2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
305
306         Reviewed by Andreas Kling.
307
308         [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
309         https://bugs.webkit.org/show_bug.cgi?id=35086
310
311         fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
312         a DRT sideeffect problem, because the resetSettings didn't set
313         the default value of LocalContentCanAccessFileUrls.
314
315         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
316         (WebCore::WebPage::resetSettings):
317
318 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
319
320         Reviewed by Martin Robinson.
321
322         [GTK] Need support for dumping focus rectangles in pixel results
323         https://bugs.webkit.org/show_bug.cgi?id=53647
324
325         Dump the selection rect if it has been requested.
326
327         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
328         (createBitmapContextFromWebView):
329
330 2011-04-18  Eric Seidel  <eric@webkit.org>
331
332         Reviewed by Adam Barth.
333
334         test-webkitpy should run the ActiveWorkItems tests
335         https://bugs.webkit.org/show_bug.cgi?id=58859
336
337         Also make the unit tests pass. :)
338
339         * QueueStatusServer/model/activeworkitems.py:
340         * QueueStatusServer/model/queue.py:
341         * QueueStatusServer/model/workitems.py:
342
343 2011-04-18  Eric Seidel  <eric@webkit.org>
344
345         Reviewed by Adam Barth.
346
347         queues.webkit.org should show trailing-days pass counts for queues
348         https://bugs.webkit.org/show_bug.cgi?id=58812
349
350         This lets us see if each bot is pulling its own weight or not.
351         Before I wrote this patch our suspicious was that one of the
352         cq bots was doing most of the work.  Turns out they're actually
353         pretty even in their recent pass counts.
354
355         * QueueStatusServer/handlers/queuestatus.py:
356         * QueueStatusServer/index.yaml:
357         * QueueStatusServer/templates/queuestatus.html:
358
359 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
360
361         Reviewed by Eric Seidel.
362
363         new-run-webkit-tests: obsolete old threading code, part 1
364         https://bugs.webkit.org/show_bug.cgi?id=58752
365
366         This patch removes support for the 'old-inline' and
367         'old-threads' worker models, and deletes the corresponding code.
368         Now that the new code is stable, this stuff is no longer
369         necessary.
370
371         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
372         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
373         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
374         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
375         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
376         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
377
378 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
379
380         Reviewed by Eric Seidel.
381
382         new-run-webkit-tests: add an --additional-drt-flag option
383         https://bugs.webkit.org/show_bug.cgi?id=58680
384
385         NRWT has a bunch of command line flags that exist to pass
386         custom flags to DRT, especially on chromium. It would be nice
387         if there was a generic mechanism to pass through flags so we
388         didn't have all the custom ones.
389
390         * Scripts/webkitpy/layout_tests/port/chromium.py:
391         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
392         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
393         * Scripts/webkitpy/layout_tests/port/test.py:
394         * Scripts/webkitpy/layout_tests/port/webkit.py:
395         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
396
397 2011-04-05  Jer Noble  <jer.noble@apple.com>
398
399         Reviewed by Sam Weinig.
400
401         WebKit2: WKTR should support WebKit2 full screen APIs
402         https://bugs.webkit.org/show_bug.cgi?id=56318
403
404         Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing 
405         WKTR to test the LayoutTest/fullscreen/ tests.
406
407         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
408         (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
409         (WTR::InjectedBundlePage::supportsFullScreen): Added.
410         (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
411         (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
412         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
415
416 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
417
418         Reviewed by Tony Chang.
419
420         new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
421         https://bugs.webkit.org/show_bug.cgi?id=58388
422
423         * Scripts/webkitpy/layout_tests/port/chromium.py:
424
425 2011-04-18  Evan Martin  <evan@chromium.org>
426
427         Reviewed by Eric Seidel.
428
429         [chromium] expose title direction to webkit client
430         https://bugs.webkit.org/show_bug.cgi?id=58823
431
432         * DumpRenderTree/chromium/LayoutTestController.cpp:
433         (LayoutTestController::LayoutTestController):
434         (LayoutTestController::reset):
435         * DumpRenderTree/chromium/LayoutTestController.h:
436         (LayoutTestController::setTitleTextDirection):
437         Add member and setter to let us stash the title direction at load time.
438
439         * DumpRenderTree/chromium/WebViewHost.cpp:
440         (WebViewHost::didReceiveTitle):
441         * DumpRenderTree/chromium/WebViewHost.h:
442         Adapt to new API; push the title into layoutTestController when we
443         receive it.
444
445 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
446
447         Unreviewed.
448
449         Re-land r84112. It was rolled out in r84127 but it didn't need
450         to be. Only r84111 actually broke things.
451
452         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
453         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
454
455 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
456
457         Reviewed by Tony Chang.
458
459         new-run-webkit-tests: don't run more processes than necessary
460         https://bugs.webkit.org/show_bug.cgi?id=58751
461
462         Previously NRWT would start up 1 process for each processor on
463         the machine by default, which was a waste if we were only
464         running a few shards of tests.
465
466         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
467         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
468         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
469
470 2011-04-18  Ojan Vafai  <ojan@chromium.org>
471
472         Reviewed by Eric Seidel.
473
474         include links to actual.png files for new pixel tests
475         https://bugs.webkit.org/show_bug.cgi?id=58831
476
477         Load image elements to confirm whether the files exist.
478         Image elements will load without being appended to the DOM.
479
480         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
481
482 2011-04-18  Ojan Vafai  <ojan@chromium.org>
483
484         Reviewed by Eric Seidel.
485
486         add a zoomed view for pixel results to the new results html file
487         https://bugs.webkit.org/show_bug.cgi?id=58827
488
489         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
490
491 2011-04-18  Ojan Vafai  <ojan@chromium.org>
492
493         Reviewed by Eric Seidel.
494
495         add labels to results html page
496         https://bugs.webkit.org/show_bug.cgi?id=58803
497
498         -fix iframe size to be the size of the png results
499         -fix a bunch of aesthetic nits
500         -fix some incorrectly styled code
501
502         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
503
504 2011-04-18  Chang Shu  <cshu@webkit.org>
505
506         Reviewed by Eric Seidel.
507
508         WebKitTestRunner needs layoutTestController.pathToLocalResource
509         https://bugs.webkit.org/show_bug.cgi?id=42541
510
511         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
512         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
513         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
514         (WTR::LayoutTestController::pathToLocalResource):
515         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
516         (WTR::LayoutTestController::pathToLocalResource):
517         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
518         (WTR::LayoutTestController::pathToLocalResource):
519
520 2011-04-18  Timothy Hatcher  <timothy@apple.com>
521
522         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
523         now that all localized strings in WebKit/win use WEB_UI_STRING.
524
525         https://webkit.org/b/58747
526
527         Reviewed by Dan Bernstein.
528
529         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
530
531 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
532
533         Reviewed by Adam Roben.
534
535         [WIN] Use WCHAR instead of TCHAR
536         https://bugs.webkit.org/show_bug.cgi?id=58755
537
538         We always use the UNICODE versions of windows functions, so
539         the usage of TCHAR makes no sense and mixing them is bad style.
540
541         * WinLauncher/PrintWebUIDelegate.cpp:
542           Also fix various style issues (including indentation and removal of ugly C-casts).
543         * WinLauncher/WinLauncher.cpp:
544
545 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
546
547         Reviewed by Andreas Kling.
548
549         Add layoutTestController.shadowRoot to Qt DRT.
550         https://bugs.webkit.org/show_bug.cgi?id=58759
551
552         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
553         (LayoutTestController::shadowRoot): Added.
554         * DumpRenderTree/qt/LayoutTestControllerQt.h:
555
556 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
557
558         Unreviewed, rolling out r84111.
559         http://trac.webkit.org/changeset/84111
560         https://bugs.webkit.org/show_bug.cgi?id=58771
561
562         Chromium linux layout tests are broken. (Requested by loislo2
563         on #webkit).
564
565         * Scripts/webkitpy/layout_tests/port/chromium.py:
566         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
567         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
568
569 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
570
571         Unreviewed, rolling out r84112.
572         http://trac.webkit.org/changeset/84112
573         https://bugs.webkit.org/show_bug.cgi?id=58770
574
575         Chromium linux layout tests are broken. (Requested by loislo2
576         on #webkit).
577
578         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
579         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
580
581 2011-04-17  Daniel Bates  <dbates@webkit.org>
582
583         Reviewed by Eric Seidel and Adam Barth.
584
585         webkit-patch land hangs if svn prompts for credentials
586         https://bugs.webkit.org/show_bug.cgi?id=31500
587
588         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
589
590         * Scripts/webkitpy/common/checkout/scm.py:
591           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
592           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
593             for argument realm; modified call sites as needed.
594           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
595           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
596           - Modified Git._commit_on_branch() to take optional username and password argument.
597           - Modified Git.push_local_commits_to_server() to take optional username and password
598             argument and to call has_authorization_for_realm().
599         * Scripts/webkitpy/common/checkout/scm_unittest.py:
600           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
601           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
602             SVN.has_authorization_for_realm().
603         * Scripts/webkitpy/common/net/credentials.py:
604           - Modified Credentials.read_credentials() to call User.prompt_password() instead
605             of using getpass.getpass() directly.
606         * Scripts/webkitpy/common/system/user.py:
607           - Added User.prompt_password().
608         * Scripts/webkitpy/tool/steps/commit.py:
609           - Modified Commit.run() to prompt for a password if needed.
610
611 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
612
613         Reviewed by Ojan Vafai.
614
615         new-run-webkit-tests: save stderr into the layout-test-results dir
616         https://bugs.webkit.org/show_bug.cgi?id=58690
617
618         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
619         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
620
621 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
622
623         Reviewed by Ojan Vafai.
624
625         new-run-webkit-tests: read stderr from chromium DRT separately
626         https://bugs.webkit.org/show_bug.cgi?id=58708
627
628         * Scripts/webkitpy/layout_tests/port/chromium.py:
629         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
630         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
631
632 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
633
634         Reviewed by Adam Barth.
635
636         Rename PLATFORM(CA) to USE(CA)
637         https://bugs.webkit.org/show_bug.cgi?id=58742
638
639         * DumpRenderTree/mac/DumpRenderTree.mm:
640         (resetDefaultsToConsistentValues):
641
642 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
643
644         Reviewed by Adam Barth.
645
646         Rename PLATFORM(CG) to USE(CG)
647         https://bugs.webkit.org/show_bug.cgi?id=58729
648
649         * DumpRenderTree/PixelDumpSupport.cpp:
650         * DumpRenderTree/chromium/WebViewHost.cpp:
651         (WebViewHost::paintRect):
652         * DumpRenderTree/config.h:
653         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
654         (createBitmapContextFromWebView):
655         * TestWebKitAPI/PlatformWebView.h:
656         * WebKitTestRunner/config.h:
657         * WebKitTestRunner/win/TestInvocationWin.cpp:
658
659 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
660
661         Reviewed by Eric Seidel.
662
663         Rename PLATFORM(CAIRO) to USE(CAIRO)
664         https://bugs.webkit.org/show_bug.cgi?id=55192
665
666         * DumpRenderTree/PixelDumpSupport.cpp:
667         * DumpRenderTree/config.h:
668         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
669         (createBitmapContextFromWebView):
670         * WebKitTestRunner/config.h:
671
672 2011-04-16  Ojan Vafai  <ojan@chromium.org>
673
674         Reviewed by Eric Seidel.
675
676         show diffs+test inline in the results page
677         https://bugs.webkit.org/show_bug.cgi?id=58723
678         
679         Put each row in it's own tbody and sort based on tbodies. That way
680         we can append the results to the tbody inline as another table row.
681
682         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
683
684 2011-04-16  Ojan Vafai  <ojan@chromium.org>
685
686         Reviewed by Eric Seidel.
687
688         handle new tests in the new results html file
689         https://bugs.webkit.org/show_bug.cgi?id=58715
690
691         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
692
693 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
694
695         Reviewed by Ojan Vafai.
696
697         old-run-webkit-tests: save the list of tests actually run to a file
698         https://bugs.webkit.org/show_bug.cgi?id=58692
699
700         * Scripts/old-run-webkit-tests:
701
702 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
703
704         Reviewed by Ojan Vafai.
705
706         fix MockFileSystem.abspath() on windows
707         https://bugs.webkit.org/show_bug.cgi?id=58713
708
709         The existing code was borked on Windows if a path was passed
710         in using a drive letter (e.g., "d:\foo.txt"), and would go
711         into an infinite recursive loop. While win paths shouldn't
712         normally be passed into the mock filesystem, this just
713         bulletproofs things a bit (note that "/foo.txt" is considered
714         an absolute path on windows python as well.
715
716         * Scripts/webkitpy/common/system/filesystem_mock.py:
717
718 2011-04-15  Ojan Vafai  <ojan@chromium.org>
719
720         Reviewed by Eric Seidel.
721
722         show stderr files and httpd log files
723         https://bugs.webkit.org/show_bug.cgi?id=58714
724
725         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
726         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
727
728 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
729
730         Reviewed by James Robinson.
731
732         Add a flag to guard Page Visibility API changes.
733         https://bugs.webkit.org/show_bug.cgi?id=58464
734
735         * Scripts/build-webkit:
736
737 2011-04-15  Chang Shu  <cshu@webkit.org>
738
739         Reviewed by Alexey Proskuryakov.
740
741         When a message with url embedded is added to console, the "file:" scheme
742         and path should be stripped.
743         https://bugs.webkit.org/show_bug.cgi?id=58665
744
745         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
746         (WTR::lastFileURLPathComponent):
747         (WTR::InjectedBundlePage::willAddMessageToConsole):
748
749 2011-04-15  Jeff Miller  <jeffm@apple.com>
750
751         Reviewed by Sam Weinig.
752
753         Add takeFocus callback to WKPageUIClient
754         https://bugs.webkit.org/show_bug.cgi?id=58686
755
756         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
757
758         * MiniBrowser/mac/BrowserWindowController.m:
759         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
760         * MiniBrowser/win/BrowserView.cpp:
761         (BrowserView::create): Added empty takeFocus entry.
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
764         (WTR::TestController::initialize): Added empty takeFocus entry.
765
766 2011-04-15  Ojan Vafai  <ojan@chromium.org>
767
768         Reviewed by Eric Seidel.
769
770         only show pretty-diff/wdiff if they were generated
771         https://bugs.webkit.org/show_bug.cgi?id=58682
772
773         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
774         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
775         * Scripts/webkitpy/layout_tests/port/base.py:
776
777 2011-04-15  Andreas Kling  <kling@webkit.org>
778
779         Reviewed by Antonio Gomes.
780
781         [Qt] DRT: Default custom policy delegate decision should be Ignore.
782
783         If layoutTestController.setCustomPolicyDelegate() is called with only
784         one argument, the second ("permissive") should default to false.
785
786         * DumpRenderTree/qt/LayoutTestControllerQt.h:
787
788 2011-04-15  Ojan Vafai  <ojan@chromium.org>
789
790         Reviewed by Eric Seidel.
791
792         fix path to layout test in new results file
793         https://bugs.webkit.org/show_bug.cgi?id=58618
794
795         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
796         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
797
798 2011-04-15  Ojan Vafai  <ojan@chromium.org>
799
800         Reviewed by Eric Seidel.
801
802         fix sorting in new results file
803         https://bugs.webkit.org/show_bug.cgi?id=58616
804
805         -Fix the custom sort to return -1, 0, 1 instead of true/false.
806         -Secondary sort by test name when sort values are equal.
807         -Sort by test name by default.
808
809         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
810
811 2011-04-15  Dmitry Lomov  <dslomov@google.com>
812
813         Reviewed by David Levin.
814
815         check-webkit-style shouldn't complain about not including a primary header file 
816         if none exists
817         https://bugs.webkit.org/show_bug.cgi?id=39514
818
819         * Scripts/webkitpy/style/checkers/cpp.py:
820         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
821
822 2011-04-15  Eric Seidel  <eric@webkit.org>
823
824         Reviewed by Mihai Parparita.
825
826         queues.webkit.org should display when a bot last rebooted
827         https://bugs.webkit.org/show_bug.cgi?id=58562
828
829         There is more repeated code here than I would like.  I fear
830         my django-fu isn't quite up to snuff.
831
832         * QueueStatusServer/handlers/queuestatus.py:
833         * QueueStatusServer/templates/queuestatus.html:
834
835 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
836
837         Reviewed by Adam Barth.
838
839         Remove dependency on chromium skia::PlatformCanvas
840         https://bugs.webkit.org/show_bug.cgi?id=57563
841         
842         Fixed compile error on Mac when using Core Graphics.
843
844         * DumpRenderTree/chromium/WebViewHost.cpp:
845         (WebViewHost::paintRect):
846
847 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
848
849         Reviewed by James Robinson.
850
851         Remove dependency on chromium skia::PlatformCanvas
852         https://bugs.webkit.org/show_bug.cgi?id=57563
853
854         * DumpRenderTree/chromium/TestShell.cpp:
855         (makeCanvasOpaque):
856         (TestShell::dumpImage):
857         * DumpRenderTree/chromium/TestShell.h:
858         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
859         (WebThemeControlDRTWin::WebThemeControlDRTWin):
860         (WebThemeControlDRTWin::draw):
861         (WebThemeControlDRTWin::drawTextField):
862         (WebThemeControlDRTWin::drawProgressBar):
863         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
864         * DumpRenderTree/chromium/WebViewHost.cpp:
865         (WebViewHost::canvas):
866         * DumpRenderTree/chromium/WebViewHost.h:
867
868 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
869
870         Reviewed by Laszlo Gombos.
871
872         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
873         https://bugs.webkit.org/show_bug.cgi?id=58007
874
875         Adds flag to start the test browsers maximized.
876         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
877         suit.
878         Also fixes some ToggleFullScreen issues so that prior window state is
879         restored.
880
881         * MiniBrowser/qt/BrowserWindow.cpp:
882         (BrowserWindow::BrowserWindow):
883         (BrowserWindow::toggleFullScreenMode):
884         * MiniBrowser/qt/MiniBrowserApplication.cpp:
885         (MiniBrowserApplication::handleUserOptions):
886         * MiniBrowser/qt/MiniBrowserApplication.h:
887         (WindowOptions::WindowOptions):
888         * QtTestBrowser/launcherwindow.cpp:
889         (LauncherWindow::init):
890         (LauncherWindow::toggleFullScreenMode):
891         * QtTestBrowser/launcherwindow.h:
892         (WindowOptions::WindowOptions):
893         * QtTestBrowser/main.cpp:
894         (LauncherApplication::handleUserOptions):
895
896 2011-04-14  Ojan Vafai  <ojan@chromium.org>
897
898         Reviewed by Eric Seidel.
899
900         add checkbox to only show unexpected results to new results file
901         https://bugs.webkit.org/show_bug.cgi?id=58606
902
903         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
904
905 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
906
907         Reviewed by Martin Robinson.
908
909         [WinCairo] Implement ImageDiff Logic.
910         http://bugs.webkit.org/show_bug.cgi?id=58486
911
912         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
913         (strtof):
914         (readFromData):
915         (createImageFromStdin):
916         (releaseMallocBuffer):
917         (createDifferenceImage):
918         (imageHasAlpha):
919         (writeToData):
920         (main):
921         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
922           ImageDiffCairo.cpp (excluding from Apple builds).
923         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
924           new ImageDiffWinCairoCommon.vsprops file.
925         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
926           new ImageDiffWinCairoCommon.vsprops file.
927         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
928         * Scripts/old-run-webkit-tests: Make sure proper executable
929           is built and executed for WinCairo port.
930
931 2011-04-14  Ojan Vafai  <ojan@chromium.org>
932
933         Reviewed by Eric Seidel.
934
935         only show expected failure type for ports that use an expectations file
936         https://bugs.webkit.org/show_bug.cgi?id=58588
937
938         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
939         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
940
941 2011-04-14  Eric Seidel  <eric@webkit.org>
942
943         Reviewed by Adam Barth.
944
945         commit-queue fails to catch IOError when results.html is missing
946         https://bugs.webkit.org/show_bug.cgi?id=58589
947
948         * Scripts/webkitpy/tool/commands/queues.py:
949         * Scripts/webkitpy/tool/commands/queues_unittest.py:
950
951 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
952
953         [wx] Unreviewed build fix for Mac installation script.
954
955         * wx/packaging/build-mac-installer.py:
956
957 2011-04-14  Ojan Vafai  <ojan@chromium.org>
958
959         Reviewed by Tony Chang.
960
961         sort columns in the new json_results.html file
962         https://bugs.webkit.org/show_bug.cgi?id=58581
963
964         Also fix padding on TDs and the path to layout tests.
965
966         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
967
968 2011-04-14  Eric Seidel  <eric@webkit.org>
969
970         Reviewed by Dimitri Glazkov.
971
972         queues.webkit.org should display when a bot last passed a patch
973         https://bugs.webkit.org/show_bug.cgi?id=58546
974
975         I am suspicious that some of our commit-queue instances are never
976         actually passing anything.
977
978         This will let us know if those bots are never passing patches.
979
980         * QueueStatusServer/handlers/queuestatus.py:
981         * QueueStatusServer/index.yaml:
982         * QueueStatusServer/templates/queuestatus.html:
983
984 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
985
986         Reviewed by Adam Roben.
987
988         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
989         https://bugs.webkit.org/show_bug.cgi?id=58545
990
991         Remove platform-specific overrides; the default behavior should
992         be working everywhere now, I think.
993
994         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
995         * Scripts/webkitpy/layout_tests/port/mac.py:
996
997 2011-04-14  Eric Seidel  <eric@webkit.org>
998
999         Reviewed by Adam Barth.
1000
1001         commit-queues are hitting an exception trying to land when the tree is red
1002         https://bugs.webkit.org/show_bug.cgi?id=58558
1003
1004         Just an un-tested (and thus broken) code path from yesterday's changes.
1005
1006         * Scripts/webkitpy/common/net/layouttestresults.py:
1007         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1008         * Scripts/webkitpy/tool/commands/queues.py:
1009         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1010
1011 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1012
1013         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
1014
1015         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1016         (LayoutTestController::shadowRoot):
1017         * wx/build/wxpresets.py:
1018
1019 2011-04-14  Victoria Kirst  <vrk@google.com>
1020
1021         Reviewed by James Robinson.
1022
1023         [chromium] Failing GPU video tests
1024         https://bugs.webkit.org/show_bug.cgi?id=57926
1025
1026         Added/updated GPU directory names for rebaseline tool.
1027
1028         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1029
1030 2011-04-13  Daniel Bates  <dbates@rim.com>
1031
1032         Reviewed by Adam Barth.
1033
1034         Perl unit test removeEOL.pl should print test case name on failure
1035         https://bugs.webkit.org/show_bug.cgi?id=58513
1036
1037         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
1038           second argument of Test::Simple::ok().
1039
1040 2011-04-13  Kent Tamura  <tkent@chromium.org>
1041
1042         Reviewed by Eric Seidel.
1043
1044         gdb-safari should pass arguments to safari.
1045         https://bugs.webkit.org/show_bug.cgi?id=58439
1046
1047         We can do:
1048           gdb-safari --debug LayoutTests/.../foo.html
1049
1050         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
1051
1052 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1053
1054         Unreviewed, build fix.
1055         https://bugs.webkit.org/show_bug.cgi?id=52763
1056
1057         r83799 broke test-webkitpy because it assumed we always have
1058         access to a real filesystem (we don't during the unit tests).
1059         Stubbing out the copy for now but we might need a better
1060         solution at some point.
1061
1062         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1063
1064 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1065
1066         Reviewed by Tony Chang.
1067
1068         new-run-webkit-tests --run-singly option is busted
1069         https://bugs.webkit.org/show_bug.cgi?id=55909
1070
1071         Python's broken lexical scoping strikes again :(.
1072
1073         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1074         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1075
1076 2011-04-13  Ojan Vafai  <ojan@chromium.org>
1077
1078         Reviewed by Eric Seidel.
1079
1080         generated unexpected_results.html from unexpected_results.json
1081         https://bugs.webkit.org/show_bug.cgi?id=52763
1082
1083         Eventually, we'll merge this with results.html and have a single richer results page.
1084         For now, I just want to get something checked in that we can iterate on.
1085
1086         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
1087         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1088
1089 2011-04-13  Eric Seidel  <eric@webkit.org>
1090
1091         Reviewed by Adam Barth.
1092
1093         Up the failure limit to allow the commit-queue to actually land when the tree is red
1094         https://bugs.webkit.org/show_bug.cgi?id=58499
1095
1096         This change increases the --exit-after-N-failures limit used by the commit-queue
1097         from 1 to 10.  This will cause the code added in bug 58494 to actually get
1098         exercised and the queues should start being able to land when the trees are red.
1099
1100         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
1101         only unit test to actually detect this change!  Since we don't actually
1102         run on leopard anymore, I removed the hack code and repurposed the test.
1103
1104         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1105         * Scripts/webkitpy/tool/steps/runtests.py:
1106         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1107
1108 2011-04-13  Eric Seidel  <eric@webkit.org>
1109
1110         Reviewed by Adam Barth.
1111
1112         commit-queue should be able to land when tree is red
1113         https://bugs.webkit.org/show_bug.cgi?id=58494
1114
1115         There is some yak hair on my hands, I will admit.
1116
1117         This change is mostly about adding an ExpectedFailures
1118         class to track when the bots are red and we should be
1119         ignoring failures when landing from the commit-queue.
1120
1121         However, to make intelligent decisions about patches we
1122         need to know whether the run hit the --exit-after-N-failures limit
1123         or not.  Right now that information is not saved off in results.html
1124         so we have to pull the information from RunTests.
1125
1126         I've plumbed the --exit-after-N-failures information into
1127         LayoutTestResults for now to make the ExpectedFailures code cleaner.
1128
1129         As a result of adding all these additional calls to delegate.layout_test_results()
1130         I broke some of our flaky test detection tests and had to re-write them
1131         to not depend on the number of layout_test_results code.
1132
1133         At the same time I updated the commit-queue to use the newer filesystem
1134         API (to allow us to use MockFileSystem) which required further changes
1135         to the layout tests.  Changes were required in either case, since
1136         we're now calling layout_test_results() in more cases, which previously
1137         would try and hit the disk (until I moved it to use tool.filesystem).
1138
1139         I should note that *all* of this code is disabled for now, since our
1140         --exit-after-N-failures limit is currently 1!  (Thus were always in the
1141         case where we can't actually tell if the layout test results are legit.)
1142         I will up that limit in a second patch (which may require a couple more unit test tweaks).
1143
1144         * Scripts/webkitpy/common/net/layouttestresults.py:
1145         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1146         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1147         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
1148         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
1149         * Scripts/webkitpy/tool/commands/queues.py:
1150         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1151         * Scripts/webkitpy/tool/commands/queuestest.py:
1152         * Scripts/webkitpy/tool/steps/runtests.py:
1153
1154 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1155
1156         Unreviewed build correction.
1157
1158         * TestWebKitAPI/PlatformWebView.h: Limit include of
1159           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
1160
1161 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1162
1163         Reviewed by Eric Seidel.
1164
1165         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
1166         https://bugs.webkit.org/show_bug.cgi?id=58489
1167         
1168         r83743 added --additional-platform-directory to old-run-webkit-tests,
1169         rename the equivalent flag in new-run-webkit-tests to be consistent.
1170
1171         * Scripts/webkitpy/layout_tests/port/base.py:
1172         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1174         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1175
1176 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1177
1178         Reviewed by Eric Seidel.
1179
1180         Rebaseline queue server
1181         https://bugs.webkit.org/show_bug.cgi?id=57891
1182
1183         Adds a simple rebaseline queue server (meant to run at
1184         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
1185         builders and their failing tests, and allows those tests to be added to
1186         a per-builer rebaseline queue.
1187
1188         A subsequent change will add a mode to NRWT (and/or a wrapper script)
1189         for pulling the tests to be rebaselined from the server and running them
1190         with --reset-results (the initial use-case is for the GPU hardware bots,
1191         which do not have checked-in baselines, therefore there is no need for a
1192         check-in step yet).
1193
1194         * RebaselineQueueServer/app.yaml: Added.
1195         * RebaselineQueueServer/handlers/__init__.py: Added.
1196         * RebaselineQueueServer/handlers/builderqueue.py: Added.
1197         * RebaselineQueueServer/handlers/pages.py: Added.
1198         * RebaselineQueueServer/index.yaml: Added.
1199         * RebaselineQueueServer/main.py: Added.
1200         * RebaselineQueueServer/model/__init__.py: Added.
1201         * RebaselineQueueServer/model/queueentry.py: Added.
1202         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
1203         * RebaselineQueueServer/static/styles.css: Added.
1204         * RebaselineQueueServer/templates/builder-picker.html: Added.
1205         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
1206         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
1207         * RebaselineQueueServer/templates/home.html: Added.
1208
1209 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1210
1211         Reviewed by Mihai Parparita.
1212
1213         nrwt: enable multiple processes by default on Chromium Win.
1214         https://bugs.webkit.org/show_bug.cgi?id=55163
1215
1216         Re-land r79268; it should be more stable now and will hopefully
1217         work.
1218
1219         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1220         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1221
1222 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1223
1224         Reviewed by Ojan Vafai.
1225
1226         new-run-webkit-tests: configure logging in child processes properly
1227         https://bugs.webkit.org/show_bug.cgi?id=58296
1228
1229         Logging propagated properly from manager to worker processes on
1230         Unix but not on Windows; this fixes that.
1231
1232         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1233         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1234
1235 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1236
1237         Reviewed by Ojan Vafai.
1238
1239         new-run-webkit-tests: suppress extraneous pretty patch warnings
1240         https://bugs.webkit.org/show_bug.cgi?id=58295
1241
1242         NRWT wasn't being careful about when it logged messages from
1243         PrettyPatch not being available; it should only log during
1244         check_build(), and be silent otherwise. This was causing us to
1245         get multiple errors at runtime, which was confusing.
1246
1247         * Scripts/webkitpy/layout_tests/port/base.py:
1248         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1249         * Scripts/webkitpy/layout_tests/port/chromium.py:
1250
1251 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1252
1253         Reviewed by Jian Li.
1254
1255         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
1256         https://bugs.webkit.org/show_bug.cgi?id=58461
1257
1258         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1259
1260 2011-04-13  Tony Chang  <tony@chromium.org>
1261
1262         Unreviewed, fix NRWT.  Stack:
1263
1264             return super(ChromiumPort, self).results_directory(self)
1265         TypeError: results_directory() takes exactly 1 argument (2 given)
1266
1267         * Scripts/webkitpy/layout_tests/port/chromium.py:
1268
1269 2011-04-13  Adam Roben  <aroben@apple.com>
1270
1271         Teach ORWT about extra platform-specific directories to be searched before the default ones
1272
1273         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
1274         platform-specific results
1275
1276         Reviewed by Anders Carlsson.
1277
1278         * Scripts/old-run-webkit-tests:
1279         (top-level): Added @additionalPlatformDirectories and hooked up
1280         --additional-platform-directories to populate it.
1281         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
1282         list (after filtering out any of the additional directories that don't exist).
1283
1284 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1285
1286         Reviewed by Adam Roben.
1287
1288         Add the /T command to taskkill.exe.
1289         This will kill spawned child processes.
1290         
1291         * BuildSlaveSupport/win/kill-old-processes:
1292
1293 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1294
1295         Reviewed by Adam Roben.
1296
1297         Sort kill list alphabeticaly.
1298         Fixed capitalization on VcBuildHelper.  
1299
1300         * BuildSlaveSupport/win/kill-old-processes:
1301
1302 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1303
1304         Reviewed by Adam Roben.
1305
1306         https://bugs.webkit.org/show_bug.cgi?id=58384
1307         Update kill-old-processes to include a few new ones.
1308         
1309         * BuildSlaveSupport/win/kill-old-processes:
1310
1311 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
1312
1313         Reviewed by Martin Robinson.
1314
1315         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
1316         https://bugs.webkit.org/show_bug.cgi?id=58297
1317
1318         Do not disable flash specifically when built with GTK+ 3 -
1319         PluginPackage should do the right thing while loading plugins.
1320
1321         * GtkLauncher/main.c:
1322         (main):
1323
1324 2011-04-12  Kent Tamura  <tkent@chromium.org>
1325
1326         Reviewed by Dimitri Glazkov.
1327
1328         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
1329         https://bugs.webkit.org/show_bug.cgi?id=57426
1330
1331         * DumpRenderTree/chromium/WebPreferences.cpp:
1332         (WebPreferences::applyTo): Disable the validation message timer.
1333
1334 2011-04-12  James Kozianski  <koz@chromium.org>
1335
1336         Unreviewed.
1337
1338         Adding myself to committers.py.
1339
1340         * Scripts/webkitpy/common/config/committers.py:
1341
1342 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
1343
1344         Unreviewed build correction for WinCairo bot after r83639.
1345         https://bugs.webkit.org/show_bug.cgi?id=51790
1346
1347         Correct typo for the new "update-webkit-wincairo-libs" script.
1348
1349         * Scripts/build-webkit: Incorrectly calling the
1350           update-webkit-cairo-libs which does not exist.
1351
1352 2011-04-12  Alice Liu  <alice.liu@apple.com>
1353
1354         Reviewed by Jon Honeycutt.
1355
1356         A change that should have been part of http://trac.webkit.org/changeset/83628
1357
1358         * DumpRenderTree/win/DumpRenderTree.cpp:
1359         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1360
1361 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1362
1363         Reviewed by Tony Chang.
1364
1365         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
1366         https://bugs.webkit.org/show_bug.cgi?id=58272
1367
1368         NRWT was interpreting the --results-directory cmd line arg as
1369         relative to the build directory, not the current working
1370         directory (ORWT uses the latter, which is much more intuitive).
1371         
1372         This patch fixes the base case, but includes an override for
1373         Chromium that is needed until the bots can be updated.
1374
1375         * Scripts/webkitpy/layout_tests/port/base.py:
1376         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1377         * Scripts/webkitpy/layout_tests/port/chromium.py:
1378         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1379         * Scripts/webkitpy/layout_tests/port/test.py:
1380         * Scripts/webkitpy/layout_tests/port/webkit.py:
1381         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1382         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1383
1384 2011-04-12  Philippe Normand  <pnormand@igalia.com>
1385
1386         Unreviewed, roll out r83621 as it broke the GTK build.
1387
1388         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
1389         https://bugs.webkit.org/show_bug.cgi?id=58333
1390
1391         * Scripts/build-jsc:
1392         * Scripts/build-webkit:
1393
1394 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
1395
1396         Reviewed by Adam Roben.
1397
1398         Patch to download the WinCairo dependancies as part of build-webkit.
1399         https://bugs.webkit.org/show_bug.cgi?id=51790
1400
1401         This patch downloads the dependancies from 
1402             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
1403         checking the modification timestamp etc. 
1404
1405         * Tools/Scripts/build-webkit
1406         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
1407           flag, and to update WinCairo dependencies when used.
1408         * Tools/Scripts/update-webkit-cairo-libs: added
1409         * Tools/Scripts/update-webkit-dependency: added
1410         * Tools/Scripts/update-webkit-auxiliary-libs
1411
1412 2011-04-12  Jeff Miller  <jeffm@apple.com>
1413
1414         Reviewed by Adam Roben.
1415
1416         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
1417         https://bugs.webkit.org/show_bug.cgi?id=56020
1418
1419         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
1420         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
1421         which would generate two characters for every keypress (for example).  I didn't bother doing this for
1422         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
1423         
1424         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
1425
1426         * MiniBrowser/win/main.cpp:
1427         (shouldTranslateMessage): Added.
1428         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1429         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
1430         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
1431         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
1432         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
1433         (TestWebKitAPI::runAndWatchForWMChar): Added.
1434         (TestWebKitAPI::TEST): Added.
1435         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1436         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1437         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
1438         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1439         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
1440         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
1441
1442 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1443
1444         Reviewed by Tony Chang.
1445
1446         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
1447         https://bugs.webkit.org/show_bug.cgi?id=58290
1448
1449         This is some preliminary refactoring for bug 58272.
1450
1451         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1452         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1453         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1454         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1455         * Scripts/webkitpy/layout_tests/port/test.py:
1456         * Scripts/webkitpy/layout_tests/port/chromium.py:
1457         * Scripts/webkitpy/layout_tests/port/base.py:
1458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1459
1460 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1461
1462         Reviewed by Eric Seidel.
1463
1464         webkitpy: fix mock_filesystem abspath to handle relative paths
1465         and add filesystem.chdir() and filesystem.getcwd() to be able
1466         to test this and mock it out.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=58288
1469
1470         * Scripts/webkitpy/common/system/filesystem.py:
1471         * Scripts/webkitpy/common/system/filesystem_mock.py:
1472         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1473
1474 2011-04-12  Alice Liu  <alice.liu@apple.com>
1475
1476         Reviewed by Sam Weinig.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=58292
1479         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1480
1481         * DumpRenderTree/mac/DumpRenderTree.mm:
1482         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1483
1484 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
1485
1486         Reviewed by Eric Seidel.
1487
1488         [Qt] Enable JIT build for SH4 platforms.
1489         https://bugs.webkit.org/show_bug.cgi?id=58317
1490
1491
1492         * DumpRenderTree/qt/DumpRenderTree.pro:
1493         * QtTestBrowser/QtTestBrowser.pro:
1494         * Scripts/webkitdirs.pm:
1495
1496 2011-04-12  Tony Chang  <tony@chromium.org>
1497
1498         Reviewed by Andreas Kling.
1499
1500         [Qt] embed checksums in PNGs written by Qt-DRT
1501         https://bugs.webkit.org/show_bug.cgi?id=58173
1502
1503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1504         (WebCore::DumpRenderTree::dump):
1505
1506 2011-04-12  Eric Seidel  <eric@webkit.org>
1507
1508         Reviewed by Adam Barth.
1509
1510         commit-queue should upload failure diffs when tests fail
1511         https://bugs.webkit.org/show_bug.cgi?id=58348
1512
1513         This change was mostly just plumbing.  We were already saving
1514         this information for flaky test reporting.  I just made it possible
1515         for normal failures to report archives as well.
1516
1517         I did a little abstraction work to try and share some code between
1518         flakytestreporter.py and this new code.  There is still more we could do.
1519
1520         In making this change I also went through and updated the various
1521         places we have urls hard-coded in our python and pointed them at
1522         common.config.urls.
1523
1524         * Scripts/webkitpy/common/checkout/scm.py:
1525         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1526         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1527         * Scripts/webkitpy/common/net/statusserver.py:
1528         * Scripts/webkitpy/layout_tests/port/base.py:
1529         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
1530         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
1531         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1532         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1533         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1534         * Scripts/webkitpy/tool/commands/queues.py:
1535
1536 2011-04-12  Daniel Bates  <dbates@rim.com>
1537
1538         Rubber-stamped by Eric Seidel.
1539
1540         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
1541         with Windows line endings
1542         https://bugs.webkit.org/show_bug.cgi?id=53625
1543
1544         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
1545         applied to an SCM checkout on a Windows file system and vice-versa.
1546
1547         This issue manifests itself due to custom SCM settings as well as differences in
1548         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
1549         into svn-apply/unapply to compensate for differences in line endings by converting
1550         the line endings in a patch to match the line endings in the target file (if it exists).
1551
1552         * Scripts/VCSUtils.pm:
1553           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
1554             content read from the specified file handle. Obviously, this heuristic will not work
1555             for files with mixed line endings, but I don't envision such files to be the norm. If
1556             this turns out to be an issue then we can improve the heuristic.
1557           - Added firstEOLInFile().
1558           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
1559             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
1560             endings in the diff instead of the line endings in the target file.
1561           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
1562             re-used in parseDiff().
1563         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
1564           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
1565           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
1566         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
1567         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
1568
1569 2011-04-12  Sam Weinig  <sam@webkit.org>
1570
1571         Reviewed by Adam Roben.
1572
1573         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
1574         https://bugs.webkit.org/show_bug.cgi?id=58336
1575
1576         * WebKitTestRunner/TestController.cpp:
1577         (WTR::TestController::resetStateToConsistentValues):
1578         Remove cache clearing as that is causing tests to crash on Windows 7.
1579
1580 2011-04-11  Sam Weinig  <sam@webkit.org>
1581
1582         Reviewed by Anders Carlsson.
1583
1584         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
1585         <rdar://problem/8981346>
1586         https://bugs.webkit.org/show_bug.cgi?id=54159
1587
1588         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1589         (WTR::InjectedBundlePage::InjectedBundlePage):
1590         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1591         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
1592         (WTR::InjectedBundlePage::decidePolicyForResponse):
1593         (WTR::InjectedBundlePage::unableToImplementPolicy):
1594         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1595         Add short-circuited policy client which matches WebKit1.
1596
1597         * WebKitTestRunner/TestController.cpp:
1598         (WTR::TestController::resetStateToConsistentValues):
1599         Clear the cache between tests to ensure consistent results.
1600
1601 2011-04-11  George Guo  <George.Guo@nokia.com>
1602
1603         Reviewed by Eric Seidel.
1604
1605         prepare-ChangeLog support email input but -h did not show the option
1606         https://bugs.webkit.org/show_bug.cgi?id=58164
1607
1608         Add email option to -h to improve the usability
1609
1610         * Scripts/prepare-ChangeLog:
1611
1612 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
1613
1614         Reviewed by Eric Carlson.
1615
1616         Rename MediaControls to MediaControlRootElement.
1617         https://bugs.webkit.org/show_bug.cgi?id=58250
1618
1619         * Scripts/do-webcore-rename: Documented the renaming.
1620
1621 2011-04-11  Sam Weinig  <sam@webkit.org>
1622
1623         Fix Windows build.
1624
1625         * MiniBrowser/win/BrowserView.cpp:
1626         (BrowserView::create):
1627
1628 2011-04-11  Sam Weinig  <sam@webkit.org>
1629
1630         Reviewed by Anders Carlsson.
1631
1632         Move focus management out of WebKit via  the UIClient
1633         <rdar://problem/8784068>
1634         https://bugs.webkit.org/show_bug.cgi?id=58278
1635
1636         * MiniBrowser/mac/BrowserWindowController.m:
1637         (-[BrowserWindowController awakeFromNib]):
1638         * WebKitTestRunner/TestController.cpp:
1639         (WTR::TestController::createOtherPage):
1640         (WTR::TestController::initialize):
1641         Add stubs for new UIClient functions.
1642
1643 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1644
1645         Reviewed by Eric Seidel.
1646
1647         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1648         https://bugs.webkit.org/show_bug.cgi?id=53605
1649
1650         Add an implementation of the PlainTextController for the GTK+ DRT.
1651
1652         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1653         (addControllerToWindow): Added this helper method.
1654         (webViewWindowObjectCleared): Use the new helper to add EventSender
1655         and the PlainTextController to the window object.
1656         * GNUmakefile.am: Added PlainTextController source files.
1657         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
1658         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
1659         until that functionality exists somewhere in the WebKitGTK+ stack.
1660         * DumpRenderTree/gtk/PlainTextController.h: Added.
1661
1662 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
1663
1664         Unreviewed.
1665
1666         Adding my IRC nick.
1667
1668         * Scripts/webkitpy/common/config/committers.py:
1669
1670 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1671
1672         Reviewed by Adam Roben.
1673
1674         new-run-webkit-tests: fix crash when running under windows cmd.exe
1675         https://bugs.webkit.org/show_bug.cgi?id=58197
1676
1677         We would intermittently crash when running NRWT directly under
1678         cmd.exe on windows because we were sharing the stdin file
1679         descriptor between the python process and the http server.
1680         cmd.exe really didn't like that, and there was no reason to
1681         share the descriptor, so we now use a PIPE instead.
1682
1683         * Scripts/webkitpy/layout_tests/port/http_server.py:
1684
1685 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1686
1687         Reviewed by Ojan Vafai.
1688
1689         new-run-webkit-tests: add unit tests for Port.diff_image()
1690         https://bugs.webkit.org/show_bug.cgi?id=58196
1691
1692         Add the unit tests for the fix in bug 58195.
1693
1694         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1695         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1696         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1697
1698 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1699
1700         Reviewed by Tony Chang.
1701
1702         new-run-webkit-tests: implement support for audio, take two
1703         https://bugs.webkit.org/show_bug.cgi?id=58195
1704
1705         Attempt to re-land the fix for bug 58101 (which was initially
1706         landed in r83330, but rolled out). This is the same patch but
1707         fixes crashes in Port.diff_image() caused by the change for
1708         empty image files being None instead of ''.
1709
1710         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1711         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1712         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1713         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1714         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1715         * Scripts/webkitpy/layout_tests/port/base.py:
1716         * Scripts/webkitpy/layout_tests/port/chromium.py:
1717         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1718         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1719         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1720         * Scripts/webkitpy/layout_tests/port/test.py:
1721         * Scripts/webkitpy/layout_tests/port/webkit.py:
1722
1723 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1724
1725         Reviewed by Xan Lopez.
1726
1727         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
1728         https://bugs.webkit.org/show_bug.cgi?id=57854
1729
1730         Implement missing features in GTK's DRT.
1731
1732         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1733         (indexRangeInTable): New helper function to get the range string
1734         for the current cell inside the parent table, either from the
1735         point of view of rows or columns.
1736         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
1737         the new helper function indexRangeInTable().
1738         (AccessibilityUIElement::columnIndexRange): Ditto.
1739
1740 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1741
1742         Reviewed by Chris Fleizach.
1743
1744         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
1745         https://bugs.webkit.org/show_bug.cgi?id=57826
1746
1747         Implement missing feature in GTK's DRT.
1748
1749         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1750         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
1751         relying on the analogous function from the AtkTable interface.
1752
1753 2011-04-05  Timothy Hatcher  <timothy@apple.com>
1754
1755         Fix the extract-localizable-strings script errors that started after
1756         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
1757
1758         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
1759
1760 2011-04-11  Tony Chang  <tony@chromium.org>
1761
1762         Reviewed by Eric Seidel.
1763
1764         fix crc computation on 64 bit machines
1765         https://bugs.webkit.org/show_bug.cgi?id=58243
1766
1767         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
1768
1769         * DumpRenderTree/CyclicRedundancyCheck.cpp:
1770         (makeCrcTable):
1771         (computeCrc):
1772         * DumpRenderTree/CyclicRedundancyCheck.h:
1773         * DumpRenderTree/PixelDumpSupport.cpp:
1774         (appendIntToVector):
1775         (convertChecksumToPNGComment):
1776
1777 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
1778
1779         Reviewed by Eric Seidel.
1780
1781         Require no undefined symbols during compilation.
1782
1783         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
1784         https://bugs.webkit.org/show_bug.cgi?id=54896
1785
1786         Add -Wl,--no-undefined to catch missing symbols early.
1787
1788         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1789         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1790
1791 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1792
1793         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
1794
1795         * wx/build/settings.py:
1796
1797 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1798
1799         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
1800
1801         * wx/build/settings.py:
1802
1803 2011-04-10  David Levin  <levin@chromium.org>
1804
1805         Reviewed by Dimitri Glazkov.
1806
1807         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
1808         https://bugs.webkit.org/show_bug.cgi?id=58201
1809
1810         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
1811         and filed bug 58202.
1812
1813 2011-04-09  David Levin  <levin@chromium.org>
1814
1815         Unreviewed, rolling out r83394.
1816         http://trac.webkit.org/changeset/83394
1817         https://bugs.webkit.org/show_bug.cgi?id=53625
1818
1819         Patch was incorrect as noted in the bug.
1820
1821         * Scripts/svn-apply:
1822
1823 2011-04-09  David Levin  <levin@chromium.org>
1824
1825         Reviewed by Adam Barth.
1826
1827         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
1828         https://bugs.webkit.org/show_bug.cgi?id=53625
1829
1830         * Scripts/svn-apply: Ensure that the portions of patches
1831         which are for vcproj/vsprops files has DOS line endings.
1832
1833 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
1834
1835         Reviewed by Tony Chang.
1836
1837         It looks like NRWT has not been stopping DRT/TestShell
1838         instances properly on windows, probably for a long time.
1839         This would go a long way to explaining why we often have
1840         processes lying around :)
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=57807
1843
1844         * Scripts/webkitpy/layout_tests/port/chromium.py:
1845         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1846
1847 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
1848
1849         Reviewed by Laszlo Gombos.
1850
1851         [Qt] Don't link against fontconfig or X11 if embedded
1852         https://bugs.webkit.org/show_bug.cgi?id=58104
1853
1854         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
1855         * QtTestBrowser/QtTestBrowser.pro: ditto
1856         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
1857         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
1858
1859 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
1860
1861         http/tests/loading/preload-append-scan.php is failing on Windows
1862         https://bugs.webkit.org/show_bug.cgi?id=58178
1863
1864         Reviewed by Brian Weinstein.
1865
1866         * DumpRenderTree/win/DumpRenderTree.cpp:
1867         (lastPathComponent):
1868         Use CFURL API to find the last path component, rather than
1869         PathFindFileName(), because the latter will include the query string.
1870
1871 2011-04-08  Jian Li  <jianli@chromium.org>
1872
1873         Unreviewed, rolling out r83327, r83330 since these patches are very
1874         likely to break chromium webkit mac10.6 builders.
1875
1876         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1877         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1878         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1879         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1880         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1881         * Scripts/webkitpy/layout_tests/port/base.py:
1882         * Scripts/webkitpy/layout_tests/port/chromium.py:
1883         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1884         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1885         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1886         * Scripts/webkitpy/layout_tests/port/test.py:
1887         * Scripts/webkitpy/layout_tests/port/webkit.py:
1888
1889 2011-04-08  Vincent Scheib  <scheib@chromium.org>
1890
1891         Reviewed by Eric Seidel.
1892
1893         add chromium-gpu-linux-x86_64 to the recognized list of ports
1894         https://bugs.webkit.org/show_bug.cgi?id=58099
1895
1896         Add chromium-gpu-linux-x86_64 to fix assert.
1897
1898         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1899
1900 2011-04-08  Alpha Lam  <hclam@chromium.org>
1901
1902         Unreviewed, rolling out r83335.
1903         http://trac.webkit.org/changeset/83335
1904         https://bugs.webkit.org/show_bug.cgi?id=53556
1905
1906         GTK and QT bots are broken
1907
1908         * Scripts/build-webkit:
1909
1910 2011-04-07  Anna Cavender  <annacc@chromium.org>
1911
1912         Reviewed by Eric Carlson.
1913
1914         Setup ENABLE(TRACK) feature define
1915         https://bugs.webkit.org/show_bug.cgi?id=53556
1916
1917         * Scripts/build-webkit:
1918
1919 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
1920
1921         Reviewed by Adam Roben.
1922
1923         new-run-webkit-tests: configure a NRWT test bot for Mac SL
1924         https://bugs.webkit.org/show_bug.cgi?id=58114
1925
1926         This change removes the old new-run-webkit-tests entry and
1927         updates it for a new test-only bot.
1928
1929         * BuildSlaveSupport/build.webkit.org-config/config.json:
1930
1931 2011-04-08  Dominic Cooney  <dominicc@google.com>
1932
1933         Reviewed by Adam Roben.
1934
1935         Make layoutTestController.shadowRoot return null, not undefined,
1936         when its argument is invalid.
1937         https://bugs.webkit.org/show_bug.cgi?id=58121
1938
1939         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1940         (LayoutTestController::shadowRoot):
1941         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1942         (WTR::LayoutTestController::shadowRoot):
1943
1944 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
1945
1946         Reviewed by Adam Roben.
1947
1948         Locate NSTD.EXE in 64-bit Windows
1949         https://bugs.webkit.org/show_bug.cgi?id=57847
1950
1951         * Scripts/old-run-webkit-tests:
1952
1953 2011-04-08  Adam Roben  <aroben@apple.com>
1954
1955         Qt build fix
1956
1957         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1958
1959 2011-04-07  Adam Roben  <aroben@apple.com>
1960
1961         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1962
1963         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1964         plugin
1965
1966         Reviewed by Anders Carlsson.
1967
1968         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1969         (pluginLogWithArguments): Moved code to format and log the message here...
1970         (pluginLog): ...from here.
1971
1972         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1973
1974         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1975         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1976
1977         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1978
1979         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1980         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1981         to begin.
1982         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1983         constructor.
1984         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1985         can be used to invoke our setWillBeDestroyed function.
1986         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1987         anything unexpected happens).
1988         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1989         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1990         NPP_SetWindow was *not* called during destruction.
1991         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1992         method, setWillBeDestroyed.
1993         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1994         object.
1995
1996         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1997         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1998         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1999         * GNUmakefile.am:
2000         Added new test.
2001
2002         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
2003         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
2004
2005 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
2006
2007         Reviewed by Martin Robinson.
2008
2009         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
2010         https://bugs.webkit.org/show_bug.cgi?id=58039
2011
2012         Implement missing functions in GTK's DRT.
2013
2014         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2015         (AccessibilityUIElement::increment): Implemented.
2016         (AccessibilityUIElement::decrement): Implemented.
2017
2018 2011-04-08  Dominic Cooney  <dominicc@google.com>
2019
2020         Reviewed by Kent Tamura.
2021
2022         Make WK2 layoutTestController.shadowRoot return undefined, not
2023         null, when its argument is not an element.
2024         https://bugs.webkit.org/show_bug.cgi?id=58121
2025
2026         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2027         (WTR::LayoutTestController::shadowRoot):
2028
2029 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
2030
2031         Reviewed by Mihai Parparita.
2032
2033         Change reference port for Mac GPU baselines from
2034         Leopard to SnowLeopard, XP to Win7, and Linux-x86
2035         to Linux x86-64.
2036
2037         https://bugs.webkit.org/show_bug.cgi?id=58099
2038
2039         * Scripts/webkitpy/layout_tests/port/chromium.py:
2040
2041 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
2042
2043         Revert ENABLE_TRACK patch due to compile failures.
2044
2045         * Scripts/build-webkit:
2046
2047 2011-04-07  Tony Chang  <tony@chromium.org>
2048
2049         Reviewed by Eric Seidel.
2050
2051         update DRT to embed checksums in png files
2052         https://bugs.webkit.org/show_bug.cgi?id=57871
2053
2054         We insert the bytes for the comment in printPNG rather than at encode
2055         time because each platform does its own PNG encoding (either using CG
2056         or cairo).  Putting this in pringPNG avoids having to duplicate this
2057         code, although it's not as clean as doing it at encoding time.
2058
2059         We insert the comment right after the IHDR chunk of the PNG.
2060
2061         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2062         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
2063         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2064         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2065         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
2066         * DumpRenderTree/PixelDumpSupport.cpp:
2067         (dumpWebViewAsPixelsAndCompareWithExpected):
2068         (convertChecksumToPNGComment): Generate the bytes to insert.
2069         (printPNG): Insert the png comment before the first IDAT section.
2070         * DumpRenderTree/PixelDumpSupport.h:
2071         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2072         (printPNG):
2073         (dumpBitmap):
2074         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2075         (printPNG):
2076         (dumpBitmap):
2077         * DumpRenderTree/win/DumpRenderTree.vcproj:
2078         * GNUmakefile.am:
2079
2080 2011-04-07  Jeff Miller  <jeffm@apple.com>
2081
2082         Reviewed by Adam Roben.
2083
2084         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
2085         https://bugs.webkit.org/show_bug.cgi?id=58058
2086
2087         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2088         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
2089
2090 2011-04-07  Chang Shu  <cshu@webkit.org>
2091
2092         Reviewed by Darin Adler.
2093
2094         WebKitTestRunner needs layoutTestController.isPageBoxVisible
2095         https://bugs.webkit.org/show_bug.cgi?id=42695
2096
2097         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2098         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2099         (WTR::LayoutTestController::isPageBoxVisible):
2100         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2101
2102 2011-04-07  Adam Roben  <aroben@apple.com>
2103
2104         Build fix
2105
2106         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
2107
2108 2011-04-07  Adam Roben  <aroben@apple.com>
2109
2110         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
2111
2112         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
2113         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
2114         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
2115         be overridden by subclasses to provide extra URLs before we call up to the base class (after
2116         which adding more URLs is no longer possible).
2117
2118         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
2119         bot results page
2120
2121         Reviewed by John Sullivan.
2122
2123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2124         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
2125         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
2126         method is never called for MasterShellCommands.
2127         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
2128         with this method (which is).
2129
2130 2011-04-07  Adam Roben  <aroben@apple.com>
2131
2132         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
2133
2134         This matches how most of our other build steps work, so is good just for improving
2135         consistency between build steps. It should also make it possible for
2136         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
2137         trying to do this in finished() after we had called up to the base class, but that was
2138         apparently too late to add more URLs.)
2139
2140         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
2141         results page
2142
2143         Reviewed by John Sullivan.
2144
2145         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2146         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
2147         call setText to get the right text to show up for this step. This matches how most of our
2148         other build steps work.
2149         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
2150         This is how most of our other build steps work.
2151         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
2152         function, to match the base class.
2153
2154 2011-04-07  Adam Barth  <abarth@webkit.org>
2155
2156         Reviewed by Maciej Stachowiak.
2157
2158         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
2159         https://bugs.webkit.org/show_bug.cgi?id=58022
2160
2161         Previously, we were ignoring the args variable!  This patch fixes the
2162         regression introduced in http://trac.webkit.org/changeset/82771.
2163
2164         * Scripts/webkitpy/tool/commands/download_unittest.py:
2165         * Scripts/webkitpy/tool/mocktool.py:
2166         * Scripts/webkitpy/tool/steps/checkstyle.py:
2167
2168 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
2169
2170         Reviewed by Adam Barth.
2171
2172         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
2173         https://bugs.webkit.org/show_bug.cgi?id=58017
2174
2175         * Scripts/webkitpy/common/checkout/scm.py:
2176         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2177
2178 2011-04-06  Chang Shu  <cshu@webkit.org>
2179
2180         Reviewed by Darin Adler.
2181
2182         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
2183         https://bugs.webkit.org/show_bug.cgi?id=57984
2184
2185         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2186         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2187         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
2188         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2189
2190 2011-04-06  Chris Rogers  <crogers@google.com>
2191
2192         Reviewed by Tony Chang.
2193
2194         Add web audio support to DumpRenderTree (mac port)
2195         https://bugs.webkit.org/show_bug.cgi?id=57969
2196
2197         * DumpRenderTree/LayoutTestController.cpp:
2198         (LayoutTestController::LayoutTestController):
2199         (setEncodedAudioDataCallback):
2200         (LayoutTestController::staticFunctions):
2201         * DumpRenderTree/LayoutTestController.h:
2202         (LayoutTestController::dumpAsAudio):
2203         (LayoutTestController::setDumpAsAudio):
2204         (LayoutTestController::encodedAudioData):
2205         (LayoutTestController::setEncodedAudioData):
2206         * DumpRenderTree/mac/DumpRenderTree.mm:
2207         (dumpAudio):
2208         (dump):
2209
2210 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
2211
2212         Reviewed by Kenneth Rohde Christiansen.
2213
2214         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
2215         https://bugs.webkit.org/show_bug.cgi?id=56086
2216
2217         Add the missing method.
2218
2219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2220         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
2221         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2222         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2223         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2224
2225 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
2226
2227         Reviewed by David Levin.
2228
2229         Add QUOTA build flag for unified quota API
2230         https://bugs.webkit.org/show_bug.cgi?id=57918
2231
2232         * Scripts/build-webkit: Added QUOTA build flag
2233
2234 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
2235
2236         Reviewed by Tony Chang.
2237
2238         Adjust the apple webkit port's default timeout to match
2239         old-run-webkit-tests at 35 seconds.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=37738
2242
2243         * Scripts/webkitpy/layout_tests/port/mac.py:
2244
2245 2011-04-06  Scott Cameron  <sccameron@rim.com>
2246
2247         Reviewed by Eric Seidel.
2248
2249         Remove global variable $httpdPath and replace with the return value of
2250         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
2251         https://bugs.webkit.org/show_bug.cgi?id=53499
2252
2253         * Scripts/run-iexploder-tests:
2254         * Scripts/webkitperl/httpd.pm:
2255
2256 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
2257
2258         Reviewed by Darin Adler.
2259
2260         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
2261         
2262         https://bugs.webkit.org/show_bug.cgi?id=27551
2263         
2264         * DumpRenderTree/config.h:
2265         * WebKitAPITest/config.h:
2266         * WebKitTestRunner/config.h:
2267
2268 2011-04-06  Tony Chang  <tony@chromium.org>
2269
2270         Reviewed by Darin Adler.
2271
2272         teach run-webkit-tests to read checksums from png files
2273         https://bugs.webkit.org/show_bug.cgi?id=57993
2274
2275         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
2276           no .checksum and look for the checksum in there.
2277
2278 2011-04-06  David Dorwin  <ddorwin@chromium.org>
2279
2280         Reviewed by David Levin.
2281
2282         Enable fullscreen layout tests for Chromium
2283         https://bugs.webkit.org/show_bug.cgi?id=55726
2284
2285         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
2286
2287         * DumpRenderTree/chromium/WebPreferences.cpp:
2288         (WebPreferences::applyTo):
2289
2290 2011-04-06  Adam Roben  <aroben@apple.com>
2291
2292         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
2293
2294         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
2295
2296         Reviewed by David Kilzer.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2299         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
2300         build's results directory here...
2301         (ExtractTestResults.finished): ...from here.
2302         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
2303         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
2304         leaks" link to point to Leaks Viewer for this build.
2305         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
2306         but it seemed good to add for consistency with BuildAndTestFactory.
2307         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
2308         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
2309         that we'll get a "view leaks" link.
2310
2311 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
2312
2313         Reviewed by Eric Seidel.
2314
2315         [Gtk] plugins/set-status.html fails
2316         https://bugs.webkit.org/show_bug.cgi?id=57844
2317
2318         Allow an empty status text to be dumped.
2319
2320         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2321         (webViewStatusBarTextChanged):
2322
2323 2011-04-06  Chang Shu  <cshu@webkit.org>
2324
2325         Reviewed by Darin Adler.
2326
2327         WebKitTestRunner needs layoutTestController.pageNumberForElementById
2328         https://bugs.webkit.org/show_bug.cgi?id=42329
2329
2330         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2331         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2332         (WTR::LayoutTestController::pageNumberForElementById):
2333         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2334
2335 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
2336
2337         Reviewed by Martin Robinson.
2338
2339         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
2340         https://bugs.webkit.org/show_bug.cgi?id=57932
2341
2342         Some Layout tests have invalid URIs that do not generate valid
2343         SoupURI instances. Do not try to free those NULL SoupURIs.
2344
2345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2346         (willSendRequestCallback):
2347
2348 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
2349
2350         Reviewed by Andreas Kling.
2351
2352         ORWT shouldn't generate diff files for tests without expected files
2353         https://bugs.webkit.org/show_bug.cgi?id=57846
2354
2355         * Scripts/old-run-webkit-tests:
2356
2357 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
2358
2359         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
2360         to deps.
2361
2362         * wx/install-unix-extras:
2363
2364 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2365
2366         Unreviewed, rolling out r82978, r82999, and r83001.
2367         http://trac.webkit.org/changeset/82978
2368         http://trac.webkit.org/changeset/82999
2369         http://trac.webkit.org/changeset/83001
2370         https://bugs.webkit.org/show_bug.cgi?id=57913
2371
2372         Does not work in Python 2.5 (Requested by abarth on #webkit).
2373
2374         * Scripts/webkitpy/common/system/executive.py:
2375         * Scripts/webkitpy/common/system/executive_unittest.py:
2376
2377 2011-04-05  Chang Shu  <cshu@webkit.org>
2378
2379         Reviewed by Darin Adler.
2380
2381         WebKitTestRunner needs layoutTestController.numberOfPages
2382         https://bugs.webkit.org/show_bug.cgi?id=42694
2383
2384         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2385         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2386         (WTR::LayoutTestController::numberOfPages):
2387         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2388
2389 2011-04-05  Tony Chang  <tony@chromium.org>
2390
2391         Reviewed by Mihai Parparita.
2392
2393         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
2394         https://bugs.webkit.org/show_bug.cgi?id=57889
2395
2396         * Scripts/webkitpy/layout_tests/port/chromium.py:
2397         * Scripts/webkitpy/layout_tests/port/test.py:
2398         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2399
2400 2011-04-05  Adam Barth  <abarth@webkit.org>
2401
2402         Silly with statement, from the future!
2403
2404         * Scripts/webkitpy/common/system/executive.py:
2405
2406 2011-04-05  Adam Barth  <abarth@webkit.org>
2407
2408         Reviewed by Tony Chang.
2409
2410         Don't use Exception.message because it's deprecated
2411         https://bugs.webkit.org/show_bug.cgi?id=57892
2412
2413         Suppress the warning for now.  When we move to Python 3, we might need
2414         to something more dramatic.
2415
2416         * Scripts/webkitpy/common/system/executive.py:
2417
2418 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
2419
2420         Reviewed by Ojan Vafai.
2421
2422         Add builders.js to dashboard file list
2423         https://bugs.webkit.org/show_bug.cgi?id=57899
2424
2425         Add file added by http://crrev.com/80538 to dashboard file list.
2426
2427         * TestResultServer/handlers/dashboardhandler.py:
2428
2429 2011-04-05  MORITA Hajime  <morrita@google.com>
2430
2431         Reviewed by Adam Barth.
2432
2433         webkit-patch should print git's stderr when git svn dcommit fail
2434         http://webkit.org/b/57861
2435
2436         * Scripts/webkitpy/common/checkout/scm.py:
2437
2438 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
2439
2440         Reviewed by Tony Chang.
2441
2442         Add --baseline-search-path to NRWT
2443         https://bugs.webkit.org/show_bug.cgi?id=56233
2444         
2445         Add NRWT option to specify additional directories to look for baselines
2446         (will be used by hardware GPU bots which will have local per-bot
2447         expectations for some tests)
2448
2449         * Scripts/webkitpy/common/system/filesystem_mock.py:
2450         * Scripts/webkitpy/layout_tests/port/base.py:
2451         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2453
2454 2011-04-05  Adam Roben  <aroben@apple.com>
2455
2456         Strip off /results.html from results URLs before trying to load leaks files from them
2457
2458         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
2459         files, rather than pointing to the directory that contains them. This is more convenient for
2460         people browsing build.webkit.org, but confused Leaks Viewer.
2461
2462         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
2463         list don't work
2464
2465         Reviewed by Joseph Pecoraro.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2468         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
2469
2470 2011-04-05  Carol Szabo  <carol@webkit.org>
2471
2472         Unreviewed.
2473
2474         Updated my info in committers.py
2475
2476         Scripts\webkitpy\common\config\committers.py 
2477
2478 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
2479
2480         Reviewed by Laszlo Gombos.
2481
2482         [Qt] Make WebKitLibraries optional for building QtWebKit
2483         https://bugs.webkit.org/show_bug.cgi?id=57542
2484
2485         * Scripts/build-webkit:
2486
2487 2011-04-05  Chang Shu  <cshu@webkit.org>
2488
2489         Reviewed by Laszlo Gombos.
2490
2491         [Qt] MiniBrowser defaultUrl does not work
2492         https://bugs.webkit.org/show_bug.cgi?id=57021
2493
2494         Match the behavior and coding of MiniBrowser to QtTestBrowser.
2495         * MiniBrowser/qt/main.cpp:
2496         (main):
2497
2498 2011-04-05  Jade Han  <jade.han@nokia.com>
2499
2500         Reviewed by Laszlo Gombos.
2501
2502         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
2503         https://bugs.webkit.org/show_bug.cgi?id=54977
2504
2505         This change is a preparation to enable building webkit2 for Symbian.
2506         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
2507
2508         * Tools.pro:
2509
2510 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2511
2512         Reviewed by Andreas Kling.
2513
2514         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
2515         https://bugs.webkit.org/show_bug.cgi?id=57832
2516
2517         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
2518
2519         * MiniBrowser/qt/UrlLoader.cpp:
2520         (UrlLoader::UrlLoader):
2521
2522 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2523
2524         [Qt] Linux Release minimal build fix after r82919.
2525
2526         * MiniBrowser/qt/BrowserWindow.cpp:
2527         (BrowserWindow::loadURLListFromFile):
2528         * QtTestBrowser/launcherwindow.cpp:
2529         (LauncherWindow::loadURLListFromFile):
2530
2531 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2532
2533         Reviewed by Andreas Kling.
2534
2535         [Qt] Make URL loader accessible from testbrowser's menus
2536         https://bugs.webkit.org/show_bug.cgi?id=57823
2537
2538         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
2539
2540         * MiniBrowser/qt/BrowserWindow.cpp:
2541         (BrowserWindow::BrowserWindow):
2542         (BrowserWindow::loadURLListFromFile):
2543         (BrowserWindow::~BrowserWindow):
2544         * MiniBrowser/qt/BrowserWindow.h:
2545         * QtTestBrowser/launcherwindow.cpp:
2546         (LauncherWindow::LauncherWindow):
2547         (LauncherWindow::~LauncherWindow):
2548         (LauncherWindow::createChrome):
2549         (LauncherWindow::loadURLListFromFile):
2550         * QtTestBrowser/launcherwindow.h:
2551
2552 2011-04-04  Sam Weinig  <sam@webkit.org>
2553
2554         Reviewed by Brian Weinstein.
2555
2556         Remove duplicate API from WKContext
2557         <rdar://problem/8727879>
2558         https://bugs.webkit.org/show_bug.cgi?id=57815
2559
2560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2561         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
2562         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2563         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
2564
2565 2011-04-04  Tony Chang  <tony@chromium.org>
2566
2567         Reviewed by Ojan Vafai.
2568
2569         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
2570         https://bugs.webkit.org/show_bug.cgi?id=57783
2571
2572         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2573         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2574
2575 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2576
2577         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
2578         from WebKitBuild.
2579
2580         * Scripts/webkitdirs.pm:
2581
2582 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
2583
2584         Reviewed by Gustavo Noronha Silva.
2585
2586         [GTK] WebGL support
2587         https://bugs.webkit.org/show_bug.cgi?id=31517
2588
2589         Add support to the DRT for turning on WebGL when a layout tests requests it.
2590
2591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2592         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
2593
2594 2011-04-04  Chang Shu  <cshu@webkit.org>
2595
2596         Reviewed by Darin Adler.
2597
2598         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
2599         https://bugs.webkit.org/show_bug.cgi?id=57572
2600
2601         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2602         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2603         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
2604         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2605
2606 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
2607
2608         Reviewed by Csaba Osztrogonác.
2609
2610         [Qt] DumpRenderTree breaks compilation in some uClibc environments
2611         https://bugs.webkit.org/show_bug.cgi?id=57602
2612
2613         * DumpRenderTree/qt/main.cpp:
2614         (get_backtrace):
2615
2616 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2617
2618         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
2619
2620         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2621         (LayoutTestController::shadowRoot):
2622
2623 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
2624
2625         Unreviewed, fix exception in rebaseline tool.
2626
2627         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2628
2629 2011-04-02  Beth Dakin  <bdakin@apple.com>
2630
2631         Rubber-stamped by Geoff Garen.
2632
2633         For Dan!
2634         * DumpRenderTree/mac/DumpRenderTree.mm:
2635         (resetWebViewToConsistentStateBeforeTesting):
2636
2637 2011-04-02  Beth Dakin  <bdakin@apple.com>
2638
2639         Rubber-stamped by Geoff Garen.
2640
2641         Need to reset the scale, much like zoom.
2642         * DumpRenderTree/mac/DumpRenderTree.mm:
2643         (resetWebViewToConsistentStateBeforeTesting):
2644
2645 2011-04-02  Sam Weinig  <sam@webkit.org>
2646
2647         Reviewed by Beth Dakin.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=57605
2650         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
2651         getClientRects()
2652         -and corresponding-
2653         <rdar://problem/9194541>
2654
2655         Add DRT support for the scaleWebView SPI.
2656         * DumpRenderTree/mac/EventSendingController.mm:
2657         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2658         (+[EventSendingController webScriptNameForSelector:]):
2659         (-[EventSendingController scalePageBy:atX:andY:]):
2660         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2661         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2662         (WTR::EventSendingController::scalePageBy):
2663         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2665         (WTR::InjectedBundlePage::reset):
2666
2667 2011-04-02  Dominic Cooney  <dominicc@google.com>
2668
2669         Reviewed by Martin Robinson.
2670
2671         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2672         https://bugs.webkit.org/show_bug.cgi?id=57551
2673
2674         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2675         (LayoutTestController::shadowRoot):
2676
2677 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2678
2679         Reviewed by Eric Seidel.
2680
2681         Remove AbstractStep._run_script and move script names to ports.py
2682         https://bugs.webkit.org/show_bug.cgi?id=57704
2683
2684         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
2685
2686         * Scripts/webkitpy/common/config/ports.py:
2687         * Scripts/webkitpy/tool/commands/download_unittest.py:
2688         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2689         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2690         * Scripts/webkitpy/tool/steps/abstractstep.py:
2691         * Scripts/webkitpy/tool/steps/checkstyle.py:
2692         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2693         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2694         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2695
2696 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2697
2698         Reviewed by Eric Seidel.
2699
2700         Emulate shebang on Win32
2701         https://bugs.webkit.org/show_bug.cgi?id=55927
2702
2703         Scripts on Windows work only if they are called with the explicit interpreter.
2704         Read the first line of scripts to detect the correct executable.
2705
2706         * Scripts/webkitpy/common/config/ports.py:
2707         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
2708         * Scripts/webkitpy/common/system/executive_unittest.py:
2709
2710 2011-04-01  Adam Barth  <abarth@webkit.org>
2711
2712         Reviewed by Eric Seidel.
2713
2714         apos entities shouldn't show up in ChangeLogs when using webkit-patch
2715         https://bugs.webkit.org/show_bug.cgi?id=57692
2716
2717         Previously, we were using BeautifulSoup to process XML from
2718         bugs.webkit.org, but that's incorrect.  We should be using
2719         BeautifulStoneSoup to process the XML.  We were getting the &apos;
2720         entity wrong because &apos; is an XML entity but not an HTML entity.
2721
2722         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2723         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2724
2725 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2726
2727         Unreviewed, rolling out r82721.
2728         http://trac.webkit.org/changeset/82721
2729         https://bugs.webkit.org/show_bug.cgi?id=57687
2730
2731         This patch introduced assertion failures on the GTK+ bots.
2732         (Requested by mrobinson on #webkit).
2733
2734         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2735         (LayoutTestController::shadowRoot):
2736
2737 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2738
2739         Unreviewed buildfix.
2740
2741         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2742         https://bugs.webkit.org/show_bug.cgi?id=55074
2743
2744         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
2745         (The isWK2() function removes it from @ARGV, but not from @options.)
2746
2747 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2748
2749         Reviewed by Csaba Osztrogonác.
2750
2751         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
2752         https://bugs.webkit.org/show_bug.cgi?id=57666
2753
2754         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
2755
2756 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
2761
2762         We apparently never implemented the code to skip tests based on
2763         what was compiled into DRT. Also, change the logic used to skip
2764         platform directories to match what old-run-webkit-tests does: 
2765         skip every test not in a directory in the baseline search path.
2766
2767         https://bugs.webkit.org/show_bug.cgi?id=57662
2768
2769         * Scripts/webkitpy/layout_tests/port/mac.py:
2770         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2771         * Scripts/webkitpy/layout_tests/port/webkit.py:
2772
2773 2011-03-29  Mark Rowe  <mrowe@apple.com>
2774
2775         Reviewed by Jon Honeycutt.
2776
2777         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
2778
2779         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
2780
2781         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2782         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2783         * Scripts/webkitpy/layout_tests/port/mac.py:
2784         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2785
2786 2011-04-01  Chang Shu  <cshu@webkit.org>
2787
2788         Reviewed by Csaba Osztrogonác.
2789
2790         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2791         https://bugs.webkit.org/show_bug.cgi?id=55074
2792
2793         * Scripts/build-webkit:
2794
2795 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2796
2797         Reviewed by Tony Chang.
2798
2799         new-run-webkit-tests: remove spurious port version override in webkit.py
2800         base.py provides a default implementation so this is just
2801         breaking things.
2802
2803         https://bugs.webkit.org/show_bug.cgi?id=57667
2804
2805         * Scripts/webkitpy/layout_tests/port/webkit.py:
2806         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2807
2808 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2809
2810         Reviewed by Adam Roben.
2811
2812         Make view results on waterfall direct link to results.html
2813         https://bugs.webkit.org/show_bug.cgi?id=57671
2814
2815         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
2816         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
2817
2818 2011-04-01  Sam Weinig  <sam@webkit.org>
2819
2820         Fix windows build.
2821
2822         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2825         (TestWebKitAPI::flushMessages):
2826
2827 2011-04-01  Sam Weinig  <sam@webkit.org>
2828
2829         Reviewed by Adam Roben.
2830
2831         Add adoptWK to WKRetainPtr.h
2832         https://bugs.webkit.org/show_bug.cgi?id=57670
2833
2834         * TestWebKitAPI/PlatformUtilities.h:
2835         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2836         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2837         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2838         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2839         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2840         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2841         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2842         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2843         (TestWebKitAPI::createSessionStateContainingFormData):
2844         * WebKitTestRunner/StringFunctions.h:
2845         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
2846
2847 2011-04-01  Sam Weinig  <sam@webkit.org>
2848
2849         Reviewed by Adam Roben.
2850
2851         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
2852
2853         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2854         (WTR::LayoutTestController::shadowRoot):
2855         Make judicious use of adoptWK().
2856
2857 2011-04-01  Sam Weinig  <sam@webkit.org>
2858
2859         Reviewed by Timothy Hatcher.
2860
2861         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
2862
2863         * Scripts/extract-localizable-strings:
2864
2865 2011-04-01  Anders Carlsson  <andersca@apple.com>
2866
2867         Reviewed by Sam Weinig.
2868
2869         Shockwave plug-in doesn't accept mouse events
2870         https://bugs.webkit.org/show_bug.cgi?id=57653
2871         <rdar://problem/8483273>
2872
2873         Add a plug-in test.
2874
2875         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2876         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2877         (PluginTest::indicateTestFailure):
2878         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
2879
2880         (PluginTest::NPN_ConvertPoint):
2881         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2882         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2883         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2884         Call indicateTestFailure.
2885
2886         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
2887         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
2888         (ConvertPoint::ConvertPoint):
2889         (ConvertPoint::testConvert):
2890         (ConvertPoint::NPP_New):
2891
2892 2011-04-01  Dominic Cooney  <dominicc@google.com>
2893
2894         Reviewed by Martin Robinson.
2895
2896         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2897         https://bugs.webkit.org/show_bug.cgi?id=57551
2898
2899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2900         (LayoutTestController::shadowRoot):
2901
2902 2011-04-01  Sam Weinig  <sam@webkit.org>
2903
2904         Reviewed by Anders Carlsson.
2905
2906         WebKitTestRunner needs layoutTestController.shadowRoot
2907         https://bugs.webkit.org/show_bug.cgi?id=57661
2908
2909         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2911         (WTR::LayoutTestController::shadowRoot):
2912         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2913         Implement layoutTestController.shadowRoot for WebKit2.
2914
2915 2011-04-01  Chang Shu  <cshu@webkit.org>
2916
2917         Reviewed by Darin Adler.
2918
2919         WebKitTestRunner needs layoutTestController.setDatabaseQuota
2920         https://bugs.webkit.org/show_bug.cgi?id=57568
2921
2922         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2923         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2924         (WTR::LayoutTestController::setDatabaseQuota):
2925         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2926
2927 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2928
2929         Reviewed by Tony Chang.
2930
2931         This patch completes the cleanup of
2932         rebaseline-chromium-webkit-tests to work with all of the
2933         variants of a platform (we can now rebaseline gpu- and non-gpu
2934         files at the same time).
2935
2936         When the rebaselining is complete, any lines declared as
2937         REBASELINE in the expectations file that matches a test that was
2938         actually rebaselined will be deleted, even if only one of the
2939         variants was actually rebaselined. This may cause odd problems,
2940         but is better than where we're at today.
2941
2942         This change removes the -g flag and deprecates -w. The -g flag is gone
2943         because GPU baselines are handled just like any other variant.
2944         The -w flag is deprecated because this tool now only works
2945         against the canaries, since that's the only place we have a full
2946         set of bots. It will be trivial to change this to
2947         build.webkit.org if we decide that's where we want them to be.
2948
2949         Also, this patch deletes a lot of cruft that is no longer needed
2950         in the test_expectations code and the port-specific code.
2951
2952         https://bugs.webkit.org/show_bug.cgi?id=55191
2953
2954         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2955         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2956         * Scripts/webkitpy/layout_tests/port/base.py:
2957         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2958         * Scripts/webkitpy/layout_tests/port/chromium.py:
2959         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2960         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2961         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2962         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2963         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2964         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2965         * Scripts/webkitpy/layout_tests/port/mac.py:
2966         * Scripts/webkitpy/layout_tests/port/test.py:
2967         * Scripts/webkitpy/layout_tests/port/webkit.py:
2968         * Scripts/webkitpy/layout_tests/port/win.py:
2969         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2970         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2971
2972 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2973
2974         Reviewed by Adam Barth.
2975
2976         rebaseline-chromium-webkit-tests does not work correctly with
2977         version-specific baselines. This patch updates the tool to use
2978         all of the version-specific bots on the canaries, and will now
2979         attempt to rebaseline all of the versions by default, although
2980         it will not update both GPU and CPU versions.
2981         
2982         Also, it will no longer modify the test_expectations.txt file
2983         *at all*. You will have to manually delete the REBASELINE lines
2984         after running the tool and determining that it did what you
2985         wanted it to do. This should be fixed in a separate bug - see
2986         webkit bug #55191.
2987
2988         https://bugs.webkit.org/show_bug.cgi?id=55608
2989
2990         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2991         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2992         * Scripts/webkitpy/layout_tests/port/chromium.py:
2993         * Scripts/webkitpy/layout_tests/port/test.py:
2994         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2995         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2996
2997 2011-03-31  Tony Chang  <tony@chromium.org>
2998
2999         Reviewed by Ojan Vafai.
3000
3001         [chromium] update the rebaseline tool to know about pngs with checksums
3002         https://bugs.webkit.org/show_bug.cgi?id=57481
3003
3004         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
3005         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3006
3007 2011-04-01  Adam Roben  <aroben@apple.com>
3008
3009         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
3010
3011         Previously, we were getting the revision of the first revision that triggered a build.
3012         Choosing the last revision would have been more accurate. But got_revision is what is used
3013         everywhere else on build.webkit.org, and should work even when there were no changes that
3014         triggered a build (e.g., if someone clicked the Force Build button).
3015
3016         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
3017         recent builds list
3018
3019         Reviewed by Anders Carlsson.
3020
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3022         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
3023         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3026         (Array.prototype.first): Added this helper function to return the first element in an array
3027         that matches the given predicate, or null if no such element exists.
3028
3029 2011-03-31  Adam Roben  <aroben@apple.com>
3030
3031         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
3032
3033         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
3034
3035         Reviewed by Darin Adler.
3036
3037         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3038         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
3039         URL on its own line.
3040
3041         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3042         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
3043         progression, and added a new test that uses a short bug URL while I was at it.
3044
3045 2011-04-01  Adam Roben  <aroben@apple.com>
3046
3047         Mark .vcproj/.vsprops/.sln files as being Windows-only
3048
3049         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
3050
3051         Reviewed by Anders Carlsson.
3052
3053         * Scripts/webkitpy/common/config/build.py:
3054         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
3055         directories as Windows-only.
3056
3057         * Scripts/webkitpy/common/config/build_unittest.py:
3058         (ShoulBuildTest): Added test cases for the above.
3059
3060 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
3061
3062         Reviewed by Laszlo Gombos.
3063
3064         [Qt] Build MiniBrowser for Symbian
3065         https://bugs.webkit.org/show_bug.cgi?id=56319
3066
3067         Have MiniBrowser reference it's own copy of useragentlist.txt instead
3068         of copying QtTestBrowser's.
3069         Remove Tools/MiniBrowser/DerivedSources.pro
3070         This reduces complexity in the Tools scripts due to Symbian limitations.
3071
3072         * DerivedSources.pro:
3073         * MiniBrowser/DerivedSources.pro: Removed.
3074         * MiniBrowser/MiniBrowser.qrc:
3075         * MiniBrowser/qt/MiniBrowser.pro:
3076         * Scripts/webkitdirs.pm:
3077
3078 2011-03-31  Chang Shu  <cshu@webkit.org>
3079
3080         Reviewed by Darin Adler.
3081
3082         WebKitTestRunner needs layoutTestController.clearAllDatabases
3083         https://bugs.webkit.org/show_bug.cgi?id=42540
3084
3085         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3086         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3087         (WTR::InjectedBundle::beginTesting):
3088         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3089         (WTR::LayoutTestController::clearAllDatabases):
3090         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3091
3092 2011-03-31  Chang Shu  <cshu@webkit.org>
3093
3094         Reviewed by Darin Adler.
3095
3096         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
3097         https://bugs.webkit.org/show_bug.cgi?id=42692
3098
3099         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3100
3101 2011-03-31  Darin Adler  <darin@apple.com>
3102
3103         Reviewed by Sam Weinig.
3104
3105         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
3106         https://bugs.webkit.org/show_bug.cgi?id=57573
3107
3108         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3109         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
3110         Removed fake definitions of keyDown and contextClick.
3111
3112         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3113         (WTR::operator==): Added. So we can compare two WKPoint structs.
3114         (WTR::parseModifier): Added.
3115         (WTR::parseModifierArray): Added.
3116         (WTR::EventSendingController::EventSendingController): Initialize the
3117         new data members.
3118         (WTR::EventSendingController::mouseDown): Added. Calls
3119         WKBundlePageSimulateMouseDown.
3120         (WTR::EventSendingController::mouseUp): Added. Calls
3121         WKBundlePageSimulateMouseUp.
3122         (WTR::EventSendingController::mouseMoveTo): Added. Calls
3123         WKBundlePageSimulateMouseMotion.
3124         (WTR::EventSendingController::leapForward): Added.
3125         (WTR::EventSendingController::updateClickCount): Added. Used by the
3126         mouseDown/Up functions to create a click count.
3127
3128         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
3129         for the changes above.
3130
3131 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
3132
3133         Reviewed by Martin Robinson.
3134
3135         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
3136         https://bugs.webkit.org/show_bug.cgi?id=57362
3137
3138         Do not generate DRT output if willSendRequestReturnsNull is set.
3139
3140         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3141         (willSendRequestCallback):
3142
3143 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
3144
3145         Reviewed by Martin Robinson.
3146
3147         Implement MiniBrowser for Gtk port.
3148         https://bugs.webkit.org/show_bug.cgi?id=48512
3149
3150         Initial implementation of the Gtk MiniBrowser.
3151
3152         * MiniBrowser/gtk/GNUmakefile.am: Added.
3153         * MiniBrowser/gtk/main.c: Added.
3154         (activateUriEntryCallback):
3155         (destroyCallback):
3156         (goBackCallback):
3157         (goForwardCallback):
3158         (createToolbar):
3159         (createWebView):
3160         (createWindow):
3161         (argumentToURL):
3162         (main):
3163
3164 2011-03-30  Dominic Cooney  <dominicc@google.com>
3165
3166         Reviewed by Dimitri Glazkov.
3167
3168         Adds layoutTestController.shadowRoot accessor to Mac DRT.
3169         https://bugs.webkit.org/show_bug.cgi?id=57415
3170
3171         * DumpRenderTree/LayoutTestController.cpp:
3172         (shadowRootCallback):
3173         (LayoutTestController::staticFunctions):
3174         * DumpRenderTree/LayoutTestController.h:
3175         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3176         (LayoutTestController::shadowRoot):
3177         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3178         (LayoutTestController::shadowRoot):
3179
3180 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
3181
3182         Reviewed by Chris Marrin.
3183
3184         Update fast/canvas tests to avoid dumping the render tree when possible
3185         https://bugs.webkit.org/show_bug.cgi?id=57493
3186
3187         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
3188           accelerated drawing and accelerated drawing for canvas
3189
3190 2011-03-30  Adam Roben  <aroben@apple.com>
3191
3192         Stop ignoring leaks in CGGradientCreateWithColorStops
3193
3194         Fixes <rdar://problem/7888547>.
3195
3196         Rubber-stamped by John Sullivan.
3197
3198         * Scripts/old-run-webkit-tests:
3199         (countAndPrintLeaks): Removed some code to ignore those leaks.
3200
3201 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
3202
3203         Reviewed by Alexey Proskuryakov.
3204
3205         Add some dynamic annotations to JavaScriptCore/wtf
3206         https://bugs.webkit.org/show_bug.cgi?id=53747
3207
3208         By using these annotations we can improve the precision of finding
3209         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
3210         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
3211
3212         These files don't add new functionality, so don't need extra tests.
3213
3214         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3215
3216 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3217
3218         Reviewed by Adam Roben.
3219
3220         Share most vsprops between Release and Production builds in releaseproduction.vsprops
3221         https://bugs.webkit.org/show_bug.cgi?id=57508
3222
3223         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3224         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
3225         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
3226         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3227         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
3228         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
3229         * DumpRenderTree/win/ImageDiffProduction.vsprops:
3230         * DumpRenderTree/win/ImageDiffRelease.vsprops:
3231         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
3232         * FindSafari/FindSafariProduction.vsprops:
3233         * FindSafari/FindSafariRelease.vsprops:
3234         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
3235         * FindSafari/FindSafariReleasePGO.vsprops:
3236         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3237         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
3238         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
3239         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
3240         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
3241         * WebKitAPITest/WebKitAPITestProduction.vsprops:
3242         * WebKitAPITest/WebKitAPITestRelease.vsprops:
3243         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
3244         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3245         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
3246         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
3247         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3248         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
3249         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
3250         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3251         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
3252         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
3253         * WinLauncher/WinLauncherProduction.vsprops:
3254         * WinLauncher/WinLauncherRelease.vsprops:
3255         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
3256         * record-memory-win/record-memory-winProduction.vsprops:
3257         * record-memory-win/record-memory-winRelease.vsprops:
3258         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
3259
3260 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3261
3262         Reviewed by Adam Roben.
3263
3264         Update Windows production build logic for new production configurations
3265         https://bugs.webkit.org/show_bug.cgi?id=57494
3266
3267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3268         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3269         * DumpRenderTree/win/ImageDiffProduction.vsprops:
3270         * FindSafari/FindSafariProduction.vsprops:
3271         * FindSafari/FindSafariReleasePGO.vsprops:
3272         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3273         * WebKitAPITest/WebKitAPITestProduction.vsprops:
3274         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3275         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3276         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3277         * WinLauncher/WinLauncherProduction.vsprops:
3278         * record-memory-win/record-memory-winProduction.vsprops:
3279
3280 2011-03-30  Robert Hogan  <robert@webkit.org>
3281
3282         Reviewed by Antonio Gomes.
3283
3284         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
3285         Unskip http/tests/navigation/go-back-to-error-page.html
3286
3287         Also add the location of DumpRenderTreeSupportQt.h
3288         to DRT's include paths.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=52614
3291
3292         * DumpRenderTree/qt/DumpRenderTree.pro:
3293         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3294         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3295         * DumpRenderTree/qt/GCControllerQt.cpp:
3296         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3297         (LayoutTestController::queueLoadHTMLString):
3298         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3299         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3300         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3301         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3302         (LoadAlternateHTMLStringItem::invoke):
3303         * DumpRenderTree/qt/WorkQueueItemQt.h:
3304         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3305         * QtTestBrowser/QtTestBrowser.pro:
3306         * QtTestBrowser/launcherwindow.h:
3307
3308 2011-03-30  Adam Barth  <abarth@webkit.org>
3309
3310         Reviewed by Adam Roben.
3311
3312         SheriffBot rollouts take too long
3313         https://bugs.webkit.org/show_bug.cgi?id=57498
3314
3315         We used to build before landing rollouts via the commit-queue to
3316         prevent further breakage, but now that our individual commit-queue
3317         machines are slower, building takes too long.  I can't remember the
3318         last time a rollout broke compile.  It seems like just landing the
3319         patch is the better trade-off.
3320
3321         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3322         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3323
3324 2011-03-30  Adam Barth  <abarth@webkit.org>
3325
3326         Remove platform/chromium-mac-snowleopard
3327         https://bugs.webkit.org/show_bug.cgi?id=57486
3328
3329         This directory no longer exists, so we can remove it from the fallback
3330         chain.
3331
3332         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3333
3334 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3335
3336         Reviewed by Adam Roben.
3337
3338         Rename Windows configuration Release_LTCG to Production for clarity
3339         https://bugs.webkit.org/show_bug.cgi?id=57465
3340
3341         * DumpRenderTree/DumpRenderTree.sln:
3342         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3343         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
3344         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
3345         * DumpRenderTree/win/DumpRenderTree.vcproj:
3346         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
3347         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
3348         * DumpRenderTree/win/ImageDiff.vcproj:
3349         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
3350         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
3351         * FindSafari/FindSafari.vcproj:
3352         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
3353         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
3354         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
3355         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
3356         * MiniBrowser/MiniBrowser.vcproj:
3357         * Scripts/webkitdirs.pm:
3358         * TestWebKitAPI/win/TestWebKitAPI.sln:
3359         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3360         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3361         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3362         * WebKitAPITest/WebKitAPITest.vcproj:
3363         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
3364         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
3365         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3366         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
3367         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
3368         * WebKitTestRunner/WebKitTestRunner.sln:
3369         * WebKitTestRunner/win/InjectedBundle.vcproj:
3370         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3371         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
3372         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
3373         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3374         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
3375         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
3376         * WinLauncher/WinLauncher.vcproj:
3377         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
3378         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
3379         * record-memory-win/record-memory-win.vcproj:
3380         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
3381         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
3382
3383 2011-03-30  MORITA Hajime  <morrita@google.com>
3384
3385         Reviewed by Dimitri Glazkov.
3386
3387         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
3388         https://bugs.webkit.org/show_bug.cgi?id=56573
3389
3390         Added LayoutTestController.shadowRoot() to Chromium DRT.
3391
3392         * DumpRenderTree/chromium/LayoutTestController.cpp:
3393         (LayoutTestController::LayoutTestController):
3394         (LayoutTestController::shadowRoot):
3395         * DumpRenderTree/chromium/LayoutTestController.h:
3396
3397 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
3398
3399         Reviewed by Kent Tamura.
3400
3401         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
3402         https://bugs.webkit.org/show_bug.cgi?id=57430
3403
3404         * DumpRenderTree/chromium/LayoutTestController.cpp:
3405         (LayoutTestController::LayoutTestController):
3406         (LayoutTestController::setPluginsEnabled):
3407         * DumpRenderTree/chromium/LayoutTestController.h:
3408
3409 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
3410
3411         Reviewed by Adam Barth.
3412
3413         make webkit-patch upload respect -d
3414         https://bugs.webkit.org/show_bug.cgi?id=57425
3415
3416         * Scripts/webkitpy/common/checkout/scm.py:
3417         * Scripts/webkitpy/tool/steps/commit.py:
3418
3419 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
3420
3421         Reviewed by Adam Barth.
3422
3423         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
3424         https://bugs.webkit.org/show_bug.cgi?id=57429
3425
3426         * Scripts/webkitpy/common/checkout/scm.py:
3427
3428 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3429
3430         Unreviewed, rolling out r82383.
3431         http://trac.webkit.org/changeset/82383
3432         https://bugs.webkit.org/show_bug.cgi?id=57417
3433
3434         "nrwt isn't shutting down cleanly" (Requested by dpranke on
3435         #webkit).
3436
3437         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3438         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3439         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3440
3441 2011-03-29  Kent Tamura  <tkent@chromium.org>
3442
3443         Reviewed by Dimitri Glazkov.
3444
3445         Make validation message bubble testable
3446         https://bugs.webkit.org/show_bug.cgi?id=57290
3447
3448         * DumpRenderTree/mac/DumpRenderTree.mm:
3449         (createWebViewAndOffscreenWindow): Change a setting so that validation
3450           bubbles isn't hidden automatically.
3451
3452 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
3453
3454         Reviewed by Ojan Vafai.
3455
3456         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
3457
3458         It's a bit unclear whether multiple threads or multiple
3459         processes will be a better model on windows. This change will
3460         test threads for now while we're still working out the bugs in
3461         multiple-processes.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=57410
3464
3465         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3466         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3467         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3468
3469 2011-03-29  David Levin  <levin@chromium.org>
3470
3471         Reviewed by Shinichiro Hamaji.
3472
3473         check-webkit-style confused by two ChangeLog entries in a row from same user
3474         https://bugs.webkit.org/show_bug.cgi?id=57250
3475
3476         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
3477         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
3478         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
3479           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
3480           checking more than that would be very messey.
3481         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
3482         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
3483
3484 2011-03-29  Kent Tamura  <tkent@chromium.org>
3485
3486         Reviewed by Dimitri Glazkov.
3487
3488         [Mac] Enable interactive-validation tests on Mac DRT
3489         https://bugs.webkit.org/show_bug.cgi?id=57308
3490
3491         * DumpRenderTree/mac/DumpRenderTree.mm:
3492         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
3493
3494 2011-03-29  Chang Shu  <cshu@webkit.org>
3495
3496         Reviewed by Kenneth Rohde Christiansen.
3497
3498         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
3499         https://bugs.webkit.org/show_bug.cgi?id=42692
3500
3501         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3502         (WTR::InjectedBundle::beginTesting):
3503         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3504         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
3505         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3506
3507 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
3508
3509         Reviewed by Xan Lopez.
3510
3511         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
3512         https://bugs.webkit.org/show_bug.cgi?id=57067
3513
3514         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
3515         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
3516         update DRT and pixel results as hundreds of results will need to be updated.
3517
3518         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3519         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
3520         by overriding the theme RC/CSS files.
3521
3522 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
3523
3524         Reviewed by Adam Roben.
3525
3526         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
3527         https://bugs.webkit.org/show_bug.cgi?id=57394
3528
3529         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
3530         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
3531         the IDE. To avoid this, add a separate vsprops file for each project configuration that
3532         contains the required inherited property sheets.
3533
3534         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3535         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
3536         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
3537         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
3538         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
3539         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
3540         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
3541         * DumpRenderTree/win/DumpRenderTree.vcproj:
3542         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
3543         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
3544         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
3545         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
3546         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
3547         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
3548         * DumpRenderTree/win/ImageDiff.vcproj:
3549         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
3550         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
3551         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
3552         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
3553         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
3554         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
3555         * FindSafari/FindSafari.vcproj:
3556         * FindSafari/FindSafariDebug.vsprops: Added.
3557         * FindSafari/FindSafariDebugAll.vsprops: Added.
3558         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
3559         * FindSafari/FindSafariRelease.vsprops: Added.
3560         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
3561         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
3562         * FindSafari/FindSafariReleasePGO.vsprops: Added.
3563         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
3564         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
3565         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
3566         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
3567         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
3568         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
3569         * MiniBrowser/MiniBrowser.vcproj:
3570         * WebKitAPITest/WebKitAPITest.vcproj:
3571         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
3572         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
3573         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
3574         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
3575         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
3576         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
3577         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3578         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
3579         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
3580         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
3581         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
3582         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
3583         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
3584         * WebKitTestRunner/win/InjectedBundle.vcproj:
3585         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
3586         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
3587         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
3588         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
3589         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
3590         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
3591         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3592         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
3593         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
3594         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
3595         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
3596         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
3597         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
3598         * WinLauncher/WinLauncher.vcproj:
3599         * WinLauncher/WinLauncherDebug.vsprops: Added.
3600         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
3601         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
3602         * WinLauncher/WinLauncherRelease.vsprops: Added.
3603         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
3604         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
3605         * record-memory-win/record-memory-win.vcproj:
3606         * record-memory-win/record-memory-winDebug.vsprops: Added.
3607         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
3608         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
3609         * record-memory-win/record-memory-winRelease.vsprops: Added.
3610         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
3611         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
3612
3613 2011-03-29  Adam Barth  <abarth@webkit.org>
3614
3615         Reviewed by Darin Adler.
3616
3617         test_runner2.py can crash due to undefined variable
3618         https://bugs.webkit.org/show_bug.cgi?id=57356
3619
3620         Replace reference to undefined variable with a variable that's actually
3621         defined.  AFAICT, there's no way to test this code.
3622
3623         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3624
3625 2011-03-29  Tony Chang  <tony@chromium.org>
3626
3627         Reviewed by Eric Seidel.
3628
3629         cleanup rebaseline-chromium-webkit-tests
3630         https://bugs.webkit.org/show_bug.cgi?id=57375
3631
3632         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3633             - Split _extract_and_add_new_baselines into 3 functions
3634             - Reduce the amount of line wrapping (the file already has lines
3635               over 80 col, so may as well try to make the file consistent)
3636             - Remove unnecessary ()s
3637
3638 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
3639
3640         Reviewed by Adam Roben.
3641
3642         Make WinCairo a core builder.
3643         https://bugs.webkit.org/show_bug.cgi?id=57373
3644
3645         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
3646         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
3647
3648 2011-03-29  Timothy Hatcher  <timothy@apple.com>
3649
3650         Update update-webkit-localizable-strings to understand that WebKit and
3651         WebKit2 strings go in WebCore.
3652
3653         Also make extract-localizable-strings optionally use an exclude file. No individual
3654         warnings are produced about unlocalized strings when there is no exclude file. This
3655         is needed for WebCore, since there are too many bare strings.
3656
3657         https://webkit.org/b/57354
3658
3659         Reviewed by Sam Weinig.
3660
3661         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
3662         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
3663
3664 2011-03-29  Darin Adler  <darin@apple.com>
3665
3666         Reviewed by Adam Roben.
3667
3668         WebKit2 bundle page needs to offer generated file hooks
3669         https://bugs.webkit.org/show_bug.cgi?id=57279
3670
3671         (Land missing part of the original patch after r82289.)
3672
3673         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3674         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
3675
3676 2011-03-29  Tony Chang  <tony@chromium.org>
3677
3678         Reviewed by Ojan Vafai.
3679
3680         [chromium] NRWT should be able to read checksums from png comments